Re: [PATCH net-next 1/2] tcp: uniform the set up of sockets after successful connection

2017-10-03 Thread Wei Wang
On Tue, Oct 3, 2017 at 9:28 PM, David Miller wrote: > From: Wei Wang > Date: Mon, 2 Oct 2017 10:01:35 -0700 > >> @@ -456,6 +456,19 @@ void tcp_init_sock(struct sock *sk) >> } >> EXPORT_SYMBOL(tcp_init_sock); >> >> +void tcp_init_transfer(struct sock

Re: [PATCH net] net: fib_rules: Fix fib_rules_ops->compare implementations to support exact match

2017-10-03 Thread Shmulik Ladkani
Hi David, On Tue, 03 Oct 2017 14:54:18 -0700 (PDT) David Miller wrote: > I don't see any inconsistency. When you insert using NLM_F_EXCL the > insertion fails if any existing rule matches or overlaps in any way > with the keys in the new rule. Please note that current

[PATCH net-next] cxgb4: Update comment for min_mtu

2017-10-03 Thread Ganesh Goudar
From: Arjun Vynipadath We have lost a comment for minimum mtu value set for netdevice with 'commit d894be57ca92 ("ethernet: use net core MTU range checking in more drivers"). Updating it accordingly. Signed-off-by: Arjun Vynipadath Signed-off-by: Ganesh

[RFC 1/2] bpf: move instruction printing into a separate file

2017-10-03 Thread Jakub Kicinski
Separate the instruction printing into a standalone source file. This way sneaky code from tools/ can use it directly. Signed-off-by: Jakub Kicinski --- Like this? kernel/bpf/Makefile | 1 + kernel/bpf/disasm.c | 212

Re: [PATCH v2 net-next 06/12] qed: Add LL2 slowpath handling

2017-10-03 Thread Kalderon, Michal
From: Leon Romanovsky Sent: Tuesday, October 3, 2017 4:26 PM >On Tue, Oct 03, 2017 at 11:54:56AM +0300, Michal Kalderon wrote: >> For iWARP unaligned MPA flow, a slowpath event of flushing an >> MPA connection that entered an unaligned state is required. >> The flush ramrod is

Re: [PATCH] net: phy: DP83822 initial driver submission

2017-10-03 Thread Dan Murphy
Florian Thanks for the review On 10/03/2017 12:15 PM, Florian Fainelli wrote: > On 10/03/2017 08:53 AM, Dan Murphy wrote: >> Add support for the TI DP83822 10/100Mbit ethernet phy. >> >> The DP83822 provides flexibility to connect to a MAC through a >> standard MII, RMII or RGMII interface. >>

Re: [PATCH v2 net-next 06/12] qed: Add LL2 slowpath handling

2017-10-03 Thread Kalderon, Michal
From: David Miller Sent: Tuesday, October 3, 2017 8:17 PM >> @@ -423,6 +423,41 @@ static void qed_ll2_rxq_parse_reg(struct qed_hwfn >> *p_hwfn, >> } >> >> static int >> +qed_ll2_handle_slowpath(struct qed_hwfn *p_hwfn, >> + struct qed_ll2_info

[PATCH net-next v2 2/3] bridge: suppress arp pkts on BR_NEIGH_SUPPRESS ports

2017-10-03 Thread Roopa Prabhu
From: Roopa Prabhu This patch avoids flooding and proxies arp packets for BR_NEIGH_SUPPRESS ports. Moves existing br_do_proxy_arp to br_do_proxy_suppress_arp to support both proxy arp and neigh suppress. Signed-off-by: Roopa Prabhu ---

[PATCH net-next v2 3/3] bridge: suppress nd pkts on BR_NEIGH_SUPPRESS ports

2017-10-03 Thread Roopa Prabhu
From: Roopa Prabhu This patch avoids flooding and proxies ndisc packets for BR_NEIGH_SUPPRESS ports. Signed-off-by: Roopa Prabhu --- net/bridge/br_arp_nd_proxy.c | 246 +++ net/bridge/br_device.c

[PATCH net-next v2 1/3] bridge: add new BR_NEIGH_SUPPRESS port flag to suppress arp and nd flood

2017-10-03 Thread Roopa Prabhu
From: Roopa Prabhu This patch adds a new bridge port flag BR_NEIGH_SUPPRESS to suppress arp and nd flood on bridge ports. It implements rfc7432, section 10. https://tools.ietf.org/html/rfc7432#section-10 for ethernet VPN deployments. It is similar to the existing

[PATCH net-next v2 0/3] bridge: neigh msg proxy and flood suppression support

2017-10-03 Thread Roopa Prabhu
From: Roopa Prabhu This series implements arp and nd suppression in the bridge driver for ethernet vpns. It implements rfc7432, section 10 https://tools.ietf.org/html/rfc7432#section-10 for ethernet VPN deployments. It is similar to the existing BR_ARP_PROXY flag but

Re: [PATCH iproute2 2/3] include: add

2017-10-03 Thread Stephen Hemminger
On Tue, 3 Oct 2017 13:57:43 -0400 Stefan Hajnoczi wrote: > This new Linux header file defines the sock_diag interface used by > AF_VSOCK. > > Signed-off-by: Stefan Hajnoczi > --- > include/linux/vm_sockets_diag.h | 33

Re: [PATCH] net: phy: DP83822 initial driver submission

2017-10-03 Thread Florian Fainelli
On 10/03/2017 11:03 AM, Dan Murphy wrote: > Florian > > Thanks for the review > > On 10/03/2017 12:15 PM, Florian Fainelli wrote: >>> + } else { >>> + value &= ~DP83822_WOL_SECURE_ON; >>> + } >>> + >>> + value |= (DP83822_WOL_EN |

Re: [PATCH net-next v2 1/3] bridge: add new BR_NEIGH_SUPPRESS port flag to suppress arp and nd flood

2017-10-03 Thread Stephen Hemminger
On Tue, 3 Oct 2017 11:21:14 -0700 Roopa Prabhu wrote: > diff --git a/net/bridge/br_forward.c b/net/bridge/br_forward.c > index 48fb174..7a50dc5 100644 > --- a/net/bridge/br_forward.c > +++ b/net/bridge/br_forward.c > @@ -204,7 +204,8 @@ void br_flood(struct net_bridge

Re: [PATCH iproute2 1/3] ss: allow AF_FAMILY constants >32

2017-10-03 Thread Stephen Hemminger
On Tue, 3 Oct 2017 13:57:42 -0400 Stefan Hajnoczi wrote: > Linux has more than 32 address families defined in . Use > a 64-bit type so all of them can be represented in the filter->families > bitmask. > > It's easy to introduce bugs when using (1 << AF_FAMILY) because the

Re: [PATCH v4 net-next 0/8] flow_dissector: Protocol specific flow dissector offload

2017-10-03 Thread Tom Herbert
On Tue, Oct 3, 2017 at 12:46 AM, Jiri Pirko wrote: > Fri, Sep 29, 2017 at 07:59:35PM CEST, t...@herbertland.com wrote: >>On Fri, Sep 29, 2017 at 10:42 AM, David Miller wrote: >>> From: Tom Herbert >>> Date: Fri, 29 Sep 2017 08:48:55

Re: [RFC 1/2] bpf: move instruction printing into a separate file

2017-10-03 Thread Daniel Borkmann
On 10/03/2017 07:57 PM, Jakub Kicinski wrote: Separate the instruction printing into a standalone source file. This way sneaky code from tools/ can use it directly. Signed-off-by: Jakub Kicinski --- Like this? Looks good to me, yes.

[PATCH iproute2 2/3] include: add

2017-10-03 Thread Stefan Hajnoczi
This new Linux header file defines the sock_diag interface used by AF_VSOCK. Signed-off-by: Stefan Hajnoczi --- include/linux/vm_sockets_diag.h | 33 + 1 file changed, 33 insertions(+) create mode 100644 include/linux/vm_sockets_diag.h diff

[RFC 2/2] tools: bpftool: use the kernel's instruction printer

2017-10-03 Thread Jakub Kicinski
Compile the instruction printer from kernel/bpf and use it for disassembling "translated" eBPF code. Signed-off-by: Jakub Kicinski --- tools/bpf/bpftool/Documentation/bpftool-prog.txt | 11 +++--- tools/bpf/bpftool/Makefile | 7 ++--

[PATCH iproute2 0/3] ss: add AF_VSOCK support

2017-10-03 Thread Stefan Hajnoczi
This patch series adds AF_VSOCK support to ss(8). AF_VSOCK is a host<->guest communications channel supported by VMware, KVM (virtio-vsock), and Hyper-V. To dump AF_VSOCK sockets: $ ss --vsock The vsock_diag.ko kernel module for Linux was posted in "[PATCH 0/5] VSOCK: add sock_diag

[PATCH iproute2 3/3] ss: add AF_VSOCK support

2017-10-03 Thread Stefan Hajnoczi
The AF_VSOCK address family is a host<->guest communications channel supported by VMware, KVM, and Hyper-V. Initial VMware support was released in Linux 3.9 in 2013 and transports for other hypervisors were added later. AF_VSOCK addresses are tuples. The 32-bit cid integer is comparable to an

[PATCH iproute2 1/3] ss: allow AF_FAMILY constants >32

2017-10-03 Thread Stefan Hajnoczi
Linux has more than 32 address families defined in . Use a 64-bit type so all of them can be represented in the filter->families bitmask. It's easy to introduce bugs when using (1 << AF_FAMILY) because the value is 32-bit. This can produce incorrect results from bitmask operations so introduce

[PATCH] nfp: convert nfp_eth_set_bit_config() into a macro

2017-10-03 Thread Matthias Kaehlcke
nfp_eth_set_bit_config() is marked as __always_inline to allow gcc to identify the 'mask' parameter as known to be constant at compile time, which is required to use the FIELD_GET() macro. The forced inlining does the trick for gcc, but for kernel builds with clang it results in undefined

Re: [RFC 1/2] bpf: move instruction printing into a separate file

2017-10-03 Thread Alexei Starovoitov
On Tue, Oct 03, 2017 at 10:57:45AM -0700, Jakub Kicinski wrote: > Separate the instruction printing into a standalone source file. > This way sneaky code from tools/ can use it directly. > > Signed-off-by: Jakub Kicinski > --- > Like this? ... > +static void

Re: [PATCH] rndis_host: support Novatel Verizon USB730L

2017-10-03 Thread David Miller
From: Bjørn Mork Date: Tue, 03 Oct 2017 16:01:15 +0200 > We can pretty much ignore the USB-IF and any specs, since that is what > the vendors appear to do. They provide device specific drivers for > Windows, so all they care about is that their device "works" with their > driver.

Re: [PATCH next] bonding: speed/duplex update at NETDEV_UP event

2017-10-03 Thread David Miller
From: Mahesh Bandewar Date: Wed, 27 Sep 2017 18:03:49 -0700 > From: Mahesh Bandewar > > Some NIC drivers don't have correct speed/duplex settings at the > time they send NETDEV_UP notification and that messes up the > bonding state. Especially 802.3ad

Re: [PATCH net-next v2 0/3] tools: add bpftool

2017-10-03 Thread Arnaldo Carvalho de Melo
Em Mon, Oct 02, 2017 at 04:11:27PM -0700, Jakub Kicinski escreveu: > Hi! > > This set adds bpftool to the tools/ directory. The first > patch renames tools/net to tools/bpf, the second one adds > the new code, while the third adds simple documentation. > > v2: > - report names, map ids, load

Re: [PATCH net v1 1/2] ARM: dts: imx: let's name the ptp interrupt for the fec ethernet driver

2017-10-03 Thread Troy Kisky
On 10/2/2017 5:51 PM, Andrew Lunn wrote: > On Mon, Oct 02, 2017 at 05:04:41PM -0700, Troy Kisky wrote: >> imx7s/imx7d has the ptp interrupt newly added as well. >> This will allow the ptp interrupt to have its own interrupt routine. >> >> Signed-off-by: Troy Kisky

Re: [PATCH] bridge: Fix format string for %ul

2017-10-03 Thread Stephen Hemminger
On Fri, 26 Aug 2016 23:10:28 -0400 Oleg Drokin wrote: > %ul would print an unsigned value and a letter l, > likely it was %lu that was meant to print the long int, > but in reality the values printed there are just regular signed > ints, so just dropping the l altogether. >

Re: [PATCH net v1 1/2] ARM: dts: imx: let's name the ptp interrupt for the fec ethernet driver

2017-10-03 Thread Andrew Lunn
On Tue, Oct 03, 2017 at 01:41:34PM -0700, Troy Kisky wrote: > On 10/2/2017 5:51 PM, Andrew Lunn wrote: > > On Mon, Oct 02, 2017 at 05:04:41PM -0700, Troy Kisky wrote: > >> imx7s/imx7d has the ptp interrupt newly added as well. > >> This will allow the ptp interrupt to have its own interrupt

Re: [PATCH] nfp: convert nfp_eth_set_bit_config() into a macro

2017-10-03 Thread Jakub Kicinski
On Tue, 3 Oct 2017 13:05:46 -0700, Matthias Kaehlcke wrote: > nfp_eth_set_bit_config() is marked as __always_inline to allow gcc to > identify the 'mask' parameter as known to be constant at compile time, > which is required to use the FIELD_GET() macro. > > The forced inlining does the trick

Re: [PATCH net-next 2/3] bridge: suppress arp pkts on BR_NEIGH_SUPPRESS ports

2017-10-03 Thread kbuild test robot
Hi Roopa, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Roopa-Prabhu/bridge-neigh-msg-proxy-and-flood-suppression-support/20171003-124610 config: x86_64-randconfig-i0-10030107 (attached as .config) compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4 reproduce

[PATCH] net: 8021q: skip packets if the vlan is down

2017-10-03 Thread Vishakha Narvekar
If the vlan is down, free the packet instead of proceeding with other processing, or counting it as received. If vlan interfaces are used as slaves for bonding, with arp monitoring for connectivity, if the rx counter is seen to be incrementing, then the bond device will not observe that the

Re: [PATCH net-next 2/2] flow_dissector: dissect tunnel info

2017-10-03 Thread Tom Herbert
On Tue, Oct 3, 2017 at 2:40 AM, Simon Horman wrote: > On Mon, Oct 02, 2017 at 01:37:55PM -0700, Tom Herbert wrote: >> On Mon, Oct 2, 2017 at 1:41 AM, Simon Horman >> wrote: >> > Move dissection of tunnel info from the flower classifier to

[net-next:master 146/148] htmldocs: net/core/dev.c:1306: warning: No description found for parameter 'name'

2017-10-03 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: 26873308b21654b6e0785b9f9e2c5414d37a4c4c commit: 6c5570016b972d9b1f0f6c2dca9cc0422b1f92bf [146/148] net: core: decouple ifalias get/set from rtnl lock reproduce: make htmldocs All warnings (new ones

Re: [RFC] bpf: remove global verifier state

2017-10-03 Thread Alexei Starovoitov
On Tue, Oct 03, 2017 at 05:20:25PM -0700, Jakub Kicinski wrote: > The only global state protected by the verifier lock is > the verifier log. Move that log to struct bpf_verifier_env > and allow verification of multiple programs in parallel. > > Signed-off-by: Jakub Kicinski

Re: [PATCH net] net: fib_rules: Fix fib_rules_ops->compare implementations to support exact match

2017-10-03 Thread David Miller
From: Shmulik Ladkani Date: Sat, 30 Sep 2017 11:59:09 +0300 > This leads to inconsistencies, depending on order of operations, e.g.: I don't see any inconsistency. When you insert using NLM_F_EXCL the insertion fails if any existing rule matches or overlaps in any way with the

[PATCH net-next v2 03/10] sctp: factor out stream->in allocation

2017-10-03 Thread Marcelo Ricardo Leitner
There is 1 place allocating it and another reallocating. Move such procedures to a common function. v2: updated changelog Tested-by: Xin Long Signed-off-by: Marcelo Ricardo Leitner --- net/sctp/stream.c | 36

[PATCH net-next v2 06/10] sctp: introduce stream scheduler foundations

2017-10-03 Thread Marcelo Ricardo Leitner
This patch introduces the hooks necessary to do stream scheduling, as per RFC Draft ndata. It also introduces the first scheduler, which is what we do today but now factored out: first come first served (FCFS). With stream scheduling now we have to track which chunk was enqueued on which stream

[PATCH net-next v2 00/10] Introduce SCTP Stream Schedulers

2017-10-03 Thread Marcelo Ricardo Leitner
This patchset introduces the SCTP Stream Schedulers are defined by https://tools.ietf.org/html/draft-ietf-tsvwg-sctp-ndata-13 It provides 3 schedulers at the moment: FCFS, Priority and Round Robin. The other 3, Round Robin per packet, Fair Capacity and Weighted Fair Capacity will be added later.

[PATCH net-next v2 10/10] sctp: introduce round robin stream scheduler

2017-10-03 Thread Marcelo Ricardo Leitner
This patch introduces RFC Draft ndata section 3.2 Priority Based Scheduler (SCTP_SS_RR). Works by maintaining a list of enqueued streams and tracking the last one used to send data. When the datamsg is done, it switches to the next stream. See-also:

[PATCH net-next v2 08/10] sctp: add sockopt to get/set stream scheduler parameters

2017-10-03 Thread Marcelo Ricardo Leitner
As defined per RFC Draft ndata Section 4.3.3, named as SCTP_STREAM_SCHEDULER_VALUE. See-also: https://tools.ietf.org/html/draft-ietf-tsvwg-sctp-ndata-13 Tested-by: Xin Long Signed-off-by: Marcelo Ricardo Leitner --- include/uapi/linux/sctp.h |

[PATCH net-next 1/3] net/ipv4: Move shared tcp code to own subdirectory

2017-10-03 Thread Richard Sailer
net/ipv4 contains around 100 source files containing the IP implementation and various other functionality (UDP, TCP, xfrm, etc.). 30 of them make up the TCP implementation. I think moving the TCP implementation to a own subdirectory makes the source tree more explorable and well structured.

Re: [PATCH V2] Fix a sleep-in-atomic bug in shash_setkey_unaligned

2017-10-03 Thread Marcelo Ricardo Leitner
On Tue, Oct 03, 2017 at 10:25:22AM +0800, Jia-Ju Bai wrote: > The SCTP program may sleep under a spinlock, and the function call path is: > sctp_generate_t3_rtx_event (acquire the spinlock) > sctp_do_sm > sctp_side_effects > sctp_cmd_interpreter > sctp_make_init_ack >

[PATCH net] bpf: fix bpf_tail_call() x64 JIT

2017-10-03 Thread Alexei Starovoitov
- bpf prog_array just like all other types of bpf array accepts 32-bit index. Clarify that in the comment. - fix x64 JIT of bpf_tail_call which was incorrectly loading 8 instead of 4 bytes - tighten corresponding check in the interpreter to stay consistent The JIT bug can be triggered after

Re: [PATCH] net: stmmac: dwmac-rk: Add RK3128 GMAC support

2017-10-03 Thread David Miller
From: David Wu Date: Sat, 30 Sep 2017 17:47:23 +0800 > Add constants and callback functions for the dwmac on rk3128 soc. > As can be seen, the base structure is the same, only registers > and the bits in them moved slightly. > > Signed-off-by: David Wu

Re: [net-next 0/9][pull request] 100GbE Intel Wired LAN Driver Updates 2017-10-03

2017-10-03 Thread David Miller
From: Jeff Kirsher Date: Tue, 3 Oct 2017 09:31:29 -0700 > This series contains updates to fm10k only. Pulled, thanks Jeff.

[PATCH net-next v2 02/10] sctp: factor out stream->out allocation

2017-10-03 Thread Marcelo Ricardo Leitner
There is 1 place allocating it and 2 other reallocating. Move such procedures to a common function. Tested-by: Xin Long Signed-off-by: Marcelo Ricardo Leitner --- net/sctp/stream.c | 52 1

[PATCH net-next v2 07/10] sctp: add sockopt to get/set stream scheduler

2017-10-03 Thread Marcelo Ricardo Leitner
As defined per RFC Draft ndata Section 4.3.2, named as SCTP_STREAM_SCHEDULER. See-also: https://tools.ietf.org/html/draft-ietf-tsvwg-sctp-ndata-13 Tested-by: Xin Long Signed-off-by: Marcelo Ricardo Leitner --- include/uapi/linux/sctp.h | 1 +

[PATCH net-next v2 04/10] sctp: introduce struct sctp_stream_out_ext

2017-10-03 Thread Marcelo Ricardo Leitner
With the stream schedulers, sctp_stream_out will become too big to be allocated by kmalloc and as we need to allocate with BH disabled, we cannot use __vmalloc in sctp_stream_init(). This patch moves out the stats from sctp_stream_out to sctp_stream_out_ext, which will be allocated only when the

[PATCH net-next v2 09/10] sctp: introduce priority based stream scheduler

2017-10-03 Thread Marcelo Ricardo Leitner
This patch introduces RFC Draft ndata section 3.4 Priority Based Scheduler (SCTP_SS_PRIO). It works by having a struct sctp_stream_priority for each priority configured. This struct is then enlisted on a queue ordered per priority if, and only if, there is a stream with data queued, so that

[PATCH net-next v2 01/10] sctp: silence warns on sctp_stream_init allocations

2017-10-03 Thread Marcelo Ricardo Leitner
As SCTP supports up to 65535 streams, that can lead to very large allocations in sctp_stream_init(). As Xin Long noticed, systems with small amounts of memory are more prone to not have enough memory and dump warnings on dmesg initiated by user actions. Thus, silence them. Also, if the

[PATCH net-next v2 05/10] sctp: introduce sctp_chunk_stream_no

2017-10-03 Thread Marcelo Ricardo Leitner
Add a helper to fetch the stream number from a given chunk. Tested-by: Xin Long Signed-off-by: Marcelo Ricardo Leitner --- include/net/sctp/structs.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/net/sctp/structs.h

[PATCH net-next 2/3] tcp: Move cc algorithms to own subdirectory

2017-10-03 Thread Richard Sailer
Essentially the TCP code files consist of two groups: * main code and some utilities (13 files) * pluggable Congestion Control Algorithms (17 files) Similar to the previous commit, this moves the Congestion control Algorithms to a own subdirecty and updates the Makefiles accordingly to make

[PATCH net-next 3/3] Move shared tcp code to net/ipv4v6shared

2017-10-03 Thread Richard Sailer
Currently a lot of Code shared between IPv4 and IPv6 resides in net/ipv4. As an attempt to make things more modular and encapsulated + the source tree more self documenting this commit: * introduces net/ipv4v6shared * moves the shared tcp code there * updates the makefiles accordingly *

[PATCH net-next 0/3] A own subdirectory for shared TCP code

2017-10-03 Thread Richard Sailer
net/ipv4 currently contains around 100 source files containing the IP implementation and lots of other functionality (UDP, TCP, xfrm, etc.) # 1/3 To make the networking source tree more self documenting and well structured 1/3 moves the 30 shared TCP source files to a own subdirectory of

Re: [PATCH net-next 0/3] A own subdirectory for shared TCP code

2017-10-03 Thread Eric Dumazet
On Wed, 2017-10-04 at 00:22 +0200, Richard Sailer wrote: > net/ipv4 currently contains around 100 source files containing the > IP implementation and lots of other functionality (UDP, TCP, xfrm, etc.) > > # 1/3 > To make the networking source tree more self documenting and well > structured 1/3

Re: [PATCH net] bpf: fix bpf_tail_call() x64 JIT

2017-10-03 Thread Eric Dumazet
On Tue, 2017-10-03 at 15:37 -0700, Alexei Starovoitov wrote: > - bpf prog_array just like all other types of bpf array accepts 32-bit index. > Clarify that in the comment. > - fix x64 JIT of bpf_tail_call which was incorrectly loading 8 instead of 4 > bytes > - tighten corresponding check in

Re: [PATCH v3 net-next] net: core: decouple ifalias get/set from rtnl lock

2017-10-03 Thread David Miller
From: Florian Westphal Date: Mon, 2 Oct 2017 23:50:05 +0200 > Device alias can be set by either rtnetlink (rtnl is held) or sysfs. > > rtnetlink hold the rtnl mutex, sysfs acquires it for this purpose. > Add an extra mutex for it and use rcu to protect concurrent accesses. > >

Re: [PATCH V2] Fix a sleep-in-atomic bug in shash_setkey_unaligned

2017-10-03 Thread Marcelo Ricardo Leitner
On Tue, Oct 03, 2017 at 01:26:43PM +0800, Herbert Xu wrote: > On Mon, Oct 02, 2017 at 09:18:24PM -0700, Andy Lutomirski wrote: > > > On Oct 2, 2017, at 7:25 PM, Jia-Ju Bai wrote: > > > > > > The SCTP program may sleep under a spinlock, and the function call path > > > is: >

Re: [PATCH V2] Fix a sleep-in-atomic bug in shash_setkey_unaligned

2017-10-03 Thread Marcelo Ricardo Leitner
On Tue, Oct 03, 2017 at 07:33:08PM -0300, Marcelo Ricardo Leitner wrote: > On Tue, Oct 03, 2017 at 10:25:22AM +0800, Jia-Ju Bai wrote: > > The SCTP program may sleep under a spinlock, and the function call path is: > > sctp_generate_t3_rtx_event (acquire the spinlock) > > sctp_do_sm > >

Re: [PATCH net-next 0/3] A own subdirectory for shared TCP code

2017-10-03 Thread David Miller
From: Richard Sailer Date: Wed, 4 Oct 2017 00:22:10 +0200 > net/ipv4 currently contains around 100 source files containing the > IP implementation and lots of other functionality (UDP, TCP, xfrm, etc.) As someone who has to do backports regularly to -stable,

Re: [PATCH net] bpf: fix bpf_tail_call() x64 JIT

2017-10-03 Thread David Miller
From: Alexei Starovoitov Date: Tue, 3 Oct 2017 15:37:20 -0700 > - bpf prog_array just like all other types of bpf array accepts 32-bit index. > Clarify that in the comment. > - fix x64 JIT of bpf_tail_call which was incorrectly loading 8 instead of 4 > bytes > - tighten

Re: [PATCH net-next v2 00/10] Introduce SCTP Stream Schedulers

2017-10-03 Thread David Miller
From: Marcelo Ricardo Leitner Date: Tue, 3 Oct 2017 19:20:07 -0300 > This patchset introduces the SCTP Stream Schedulers are defined by > https://tools.ietf.org/html/draft-ietf-tsvwg-sctp-ndata-13 > > It provides 3 schedulers at the moment: FCFS, Priority and Round

Re: [patch net-next v2 3/7] ipv4: ipmr: Don't forward packets already forwarded by hardware

2017-10-03 Thread Nikolay Aleksandrov
On 03/10/17 10:58, Jiri Pirko wrote: > From: Yotam Gigi > > Change the ipmr module to not forward packets if: > - The packet is marked with the offload_mr_fwd_mark, and > - Both input interface and output interface share the same parent ID. > > This way, a packet can go

[PATCH 1/2 net-next] mlxsw: spectrum: Fix check for IS_ERR() instead of NULL

2017-10-03 Thread Dan Carpenter
mlxsw_afa_block_create() doesn't return error pointers, it returns NULL on error. Fixes: 0e14cacb ("mlxsw: spectrum: Add the multicast routing hardware logic") Signed-off-by: Dan Carpenter diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_mr_tcam.c

Re: [PATCH 1/2 net-next] mlxsw: spectrum: Fix check for IS_ERR() instead of NULL

2017-10-03 Thread Yotam Gigi
On 10/03/2017 01:53 PM, Dan Carpenter wrote: > mlxsw_afa_block_create() doesn't return error pointers, it returns NULL > on error. > > Fixes: 0e14cacb ("mlxsw: spectrum: Add the multicast routing hardware > logic") > Signed-off-by: Dan Carpenter Acked-by: Yotam

[PATCH net-next] dev: advertise the new nsid when the netns iface changes

2017-10-03 Thread Nicolas Dichtel
x-netns interfaces are bound to two netns: the link netns and the upper netns. Usually, this kind of interfaces is created in the link netns and then moved to the upper netns. At the end, the interface is visible only in the upper netns. The link nsid is advertised via netlink in the upper netns,

[PATCH] net: dsa: lan9303: make functions lan9303_mdio_phy_{read|write} static

2017-10-03 Thread Colin King
From: Colin Ian King The functions lan9303_mdio_phy_write and lan9303_mdio_phy_read are local to the source and do not need to be in global scope, so make them static. Cleans up sparse warnings: symbol 'lan9303_mdio_phy_write' was not declared. Should it be static?

Re: [PATCH 2/2 net-next] mlxsw: spectrum: Add missing error code on allocation failure

2017-10-03 Thread Yotam Gigi
On 10/03/2017 01:53 PM, Dan Carpenter wrote: > We accidentally return success if the kmalloc_array() call fails. > > Fixes: 0e14cacb ("mlxsw: spectrum: Add the multicast routing hardware > logic") > Signed-off-by: Dan Carpenter Acked-by: Yotam Gigi

[PATCH net] net: rtnetlink: fix info leak in RTM_GETSTATS call

2017-10-03 Thread Nikolay Aleksandrov
When RTM_GETSTATS was added the fields of its header struct were not all initialized when returning the result thus leaking 4 bytes of information to user-space per rtnl_fill_statsinfo call, so initialize them now. Thanks to Alexander Potapenko for the detailed report and bisection. Reported-by:

[PATCH 2/2 net-next] mlxsw: spectrum: Add missing error code on allocation failure

2017-10-03 Thread Dan Carpenter
We accidentally return success if the kmalloc_array() call fails. Fixes: 0e14cacb ("mlxsw: spectrum: Add the multicast routing hardware logic") Signed-off-by: Dan Carpenter diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_mr_tcam.c

Re: [patch net-next v2 2/7] ipv4: ipmr: Add the parent ID field to VIF struct

2017-10-03 Thread Nikolay Aleksandrov
On 03/10/17 10:58, Jiri Pirko wrote: > From: Yotam Gigi > > In order to allow the ipmr module to do partial multicast forwarding > according to the device parent ID, add the device parent ID field to the > VIF struct. This way, the forwarding path can use the parent ID field

[PATCH] net: dsa: mt7530: make functions mt7530_phy_write static

2017-10-03 Thread Colin King
From: Colin Ian King The function mt7530_phy_write is local to the source and does not need to be in global scope, so make it static. Cleans up sparse warnings: symbol 'mt7530_phy_write' was not declared. Should it be static? Signed-off-by: Colin Ian King

Re: [PATCH net] net: br: Fix igmp snooping offload with CONFIG_BRIDGE_VLAN_FILTERING

2017-10-03 Thread Andrew Lunn
On Tue, Oct 03, 2017 at 12:29:56PM +0900, Toshiaki Makita wrote: > On 2017/10/03 9:55, Andrew Lunn wrote: > > With CONFIG_BRIDGE_VLAN_FILTERING enabled, but the feature not enabled > > via /sys/class/net/brX/bridge/vlan_filtering, mdb offloaded to the > > kernel have the wrong VID. > > > > When

Re: [net-next V3 PATCH 3/5] bpf: cpumap xdp_buff to skb conversion and allocation

2017-10-03 Thread Jesper Dangaard Brouer
On Mon, 2 Oct 2017 18:02:46 -0700 Alexei Starovoitov wrote: > On Mon, Oct 02, 2017 at 06:05:29PM +0200, Jesper Dangaard Brouer wrote: > > + while ((xdp_pkt = __ptr_ring_consume(rcpu->queue))) { > > + struct sk_buff *skb; > > +

BUG in free_netdev() on ppp link deletion

2017-10-03 Thread Beniamino Galvani
Hi, I see the following BUG on 4.14-rc2 and previous versions (reproduced with 4.11 as well): [ cut here ] kernel BUG at net/core/dev.c:8141! invalid opcode: [#1] SMP Modules linked in: pppoe pppox ppp_generic slhc cfg80211 rfkill joydev uinput tun sunrpc

[patch net-next v2 4/7] mlxsw: acl: Introduce ACL trap and forward action

2017-10-03 Thread Jiri Pirko
From: Yotam Gigi Use trap/discard flex action to implement trap and forward. The action will later be used for multicast routing, as the multicast routing mechanism is done using ACL flexible actions in Spectrum hardware. Using that action, it will be possible to implement a

[patch net-next v2 7/7] mlxsw: spectrum: mr: Support trap-and-forward routes

2017-10-03 Thread Jiri Pirko
From: Yotam Gigi Add the support of trap-and-forward route action in the multicast routing offloading logic. A route will be set to trap-and-forward action if one (or more) of its output interfaces is not offload-able, i.e. does not have a valid Spectrum RIF. This way, a

[patch net-next v2 3/7] ipv4: ipmr: Don't forward packets already forwarded by hardware

2017-10-03 Thread Jiri Pirko
From: Yotam Gigi Change the ipmr module to not forward packets if: - The packet is marked with the offload_mr_fwd_mark, and - Both input interface and output interface share the same parent ID. This way, a packet can go through partial multicast forwarding in the

[patch net-next v2 5/7] mlxsw: spectrum: Add trap for multicast trap-and-forward routes

2017-10-03 Thread Jiri Pirko
From: Yotam Gigi When a multicast route is configured with trap-and-forward action, the packets should be marked with skb->offload_mr_fwd_mark, in order to prevent the packets from being forwarded again by the kernel ipmr module. Due to this, it is not possible to use the

[patch net-next v2 2/7] ipv4: ipmr: Add the parent ID field to VIF struct

2017-10-03 Thread Jiri Pirko
From: Yotam Gigi In order to allow the ipmr module to do partial multicast forwarding according to the device parent ID, add the device parent ID field to the VIF struct. This way, the forwarding path can use the parent ID field without invoking switchdev calls, which

[patch net-next v2 6/7] mlxsw: spectrum: mr_tcam: Add trap-and-forward multicast route

2017-10-03 Thread Jiri Pirko
From: Yotam Gigi In addition to the current multicast route actions, which include trap route action and a forward route action, add the trap-and-forward multicast route action, and implement it in the multicast routing hardware logic. To implement that, add a

[patch net-next v2 1/7] skbuff: Add the offload_mr_fwd_mark field

2017-10-03 Thread Jiri Pirko
From: Yotam Gigi Similarly to the offload_fwd_mark field, the offload_mr_fwd_mark field is used to allow partial offloading of MFC multicast routes. Switchdev drivers can offload MFC multicast routes to the hardware by registering to the FIB notification chain. When one of

[patch net-next v2 0/7] mlxsw: Add support for partial multicast route offload

2017-10-03 Thread Jiri Pirko
From: Jiri Pirko Yotam says: Previous patchset introduced support for offloading multicast MFC routes to the Spectrum hardware. As described in that patchset, no partial offloading is supported, i.e if a route has one output interface which is not a valid offloadable device

Re: [v2] cdc-ether: divorce initialisation with a filter reset and a generic method

2017-10-03 Thread Vignesh R
Hi Dave, On Monday 22 May 2017 06:20 PM, Oliver Neukum wrote: > Some devices need their multicast filter reset but others are crashed by that. > So the methods need to be separated. > > Signed-off-by: Oliver Neukum > Reported-by: "Ridgway, Keith" > --- I

Re: [PATCH 05/18] net: use ARRAY_SIZE

2017-10-03 Thread Andy Shevchenko
On Tue, Oct 3, 2017 at 4:22 AM, Jérémy Lefaure wrote: > On Mon, 2 Oct 2017 16:07:36 +0300 > Andy Shevchenko wrote: > >> > + {_lut_core0_rev0, ARRAY_SIZE(gainctrl_lut_core0_rev0), >> > 26, 192, >> > +32}, >> >> For all such

Re: Fw: [Bug 197099] New: Kernel panic in interrupt [l2tp_ppp]

2017-10-03 Thread James Chapman
On 2 October 2017 at 19:35, SviMik wrote: > Hi, James! > > No, I'm suffering from kernel panics since I started using 4.x > kernels. It's interesting that you are seeing l2tp issues since switching to 4.x kernels. Are you able to try earlier kernels to find the latest version

RE: [PATCH] fsl/fman: remove of_node

2017-10-03 Thread Madalin-cristian Bucur
> -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Tuesday, October 03, 2017 2:05 AM > To: Madalin-cristian Bucur > Subject: Re: [PATCH] fsl/fman: remove of_node > > From: Madalin Bucur > Date: Mon, 2 Oct 2017

[PATCH 2/7] crypto:chelsio: Check error code with IS_ERR macro

2017-10-03 Thread Harsh Jain
Check and return proper error code. Signed-off-by: Harsh Jain --- drivers/crypto/chelsio/chcr_algo.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/crypto/chelsio/chcr_algo.c b/drivers/crypto/chelsio/chcr_algo.c index

[PATCH 1/1] xdp: Sample xdp program implementing ip forward

2017-10-03 Thread cjacob
Implements port to port forwarding with route table and arp table lookup for ipv4 packets using bpf_redirect helper function and lpm_trie map. Signed-off-by: cjacob --- samples/bpf/Makefile|4 + samples/bpf/xdp3_kern.c | 204 +++

[PATCH 0/1] XDP Program for Ip forward

2017-10-03 Thread cjacob
The patch below implements port to port forwarding through route table and arp table lookup for ipv4 packets using bpf_redirect helper function and lpm_trie map. This has an improved performance over the normal kernel stack ip forward. Implementation details. --- The program

[PATCH v2 net-next 05/12] qed: Add the source of a packet sent on an iWARP ll2 connection

2017-10-03 Thread Michal Kalderon
When a packet is sent back to iWARP FW via the tx ll2 connection the FW needs to know the source of the packet. Whether it is OOO or unaligned MPA related. Since OOO is implemented entirely inside the ll2 code (and shared with iSCSI), packets are marked as IN_ORDER inside the ll2 code. For

[PATCH v2 net-next 04/12] qed: Fix initialization of ll2 offload feature

2017-10-03 Thread Michal Kalderon
enable_ip_cksum, enable_l4_cksum, calc_ip_len were added in commit stated below but not passed through to FW. This was OK until now as it wasn't used, but is required for the iWARP unaligned flow Fixes:7c7973b2ae27 ("qed: LL2 to use packed information for tx") Signed-off-by: Michal Kalderon

[PATCH v2 net-next 03/12] qed: Add ll2 option for dropping a tx packet

2017-10-03 Thread Michal Kalderon
The option of sending a packet on the ll2 and dropping it exists in hardware and was not used until now, thus not exposed. The iWARP unaligned MPA flow requires this functionality for flushing the tx queue. Signed-off-by: Michal Kalderon Signed-off-by: Ariel Elior

[PATCH v2 net-next 01/12] qed: Add ll2 option to limit the number of bds per packet

2017-10-03 Thread Michal Kalderon
iWARP uses 3 ll2 connections, the maximum number of bds is known during connection setup. This patch modifies the static array in the ll2_tx_packet descriptor to be a flexible array and significantlly reduces memory size. In addition, some redundant fields in the ll2_tx_packet were removed, which

[PATCH v2 net-next 00/12] qed: Add iWARP support for unaligned MPA packets

2017-10-03 Thread Michal Kalderon
This patch series adds support for handling unaligned MPA packets. (FPDUs split over more than one tcp packet). When FW detects a packet is unaligned it fowards the packet to the driver via a light l2 dedicated connection. The driver then stores this packet until the remainder of the packet is

[PATCH v2 net-next 02/12] qed: Add ll2 ability of opening a secondary queue

2017-10-03 Thread Michal Kalderon
When more than one ll2 queue is opened ( that is not an OOO queue ) ll2 code does not have enough information to determine whether the queue is the main one or not, so a new field is added to the acquire input data to expose the control of determining whether the queue is the main queue or a

[PATCH v2 net-next 09/12] qed: Add unaligned and packed packet processing

2017-10-03 Thread Michal Kalderon
The fpdu data structure is preallocated per connection. Each connection stores the current status of the connection: either nothing pending, or there is a partial fpdu that is waiting for the rest of the fpdu (incomplete bytes != 0). The same structure is also used for splitting a packet when

Re: [PATCH net-next 2/2] flow_dissector: dissect tunnel info

2017-10-03 Thread Simon Horman
On Mon, Oct 02, 2017 at 01:37:55PM -0700, Tom Herbert wrote: > On Mon, Oct 2, 2017 at 1:41 AM, Simon Horman > wrote: > > Move dissection of tunnel info from the flower classifier to the flow > > dissector where all other dissection occurs. This should not have any >

  1   2   3   >