Re: [PATCH 2/6] ath9k: add a quirk to set use_msi automatically

2017-10-05 Thread AceLan Kao
Hi all, Please drop my patches, Qualcomm is working internally and will submit the MSI patch by themselves. Thanks. Hi Daniel, I'll try your patches tomorrow. Best regards, AceLan Kao. 2017-10-02 12:21 GMT+08:00 Daniel Drake : > Hi AceLan, > > On Thu, Sep 28, 2017 at 4:28

Re: [PATCH v3 1/2] dt-bindings: add device tree binding for Allwinner XR819 SDIO Wi-Fi

2017-10-05 Thread Kalle Valo
Icenowy Zheng writes: > 于 2017年10月4日 GMT+08:00 下午6:11:45, Maxime Ripard > 写到: >>On Wed, Oct 04, 2017 at 10:02:48AM +, Arend van Spriel wrote: >>> On 10/4/2017 11:03 AM, Icenowy Zheng wrote: >>> > >>> > >>> > 于 2017年10月4日 GMT+08:00

Re: [PATCH] net/mac80211/mesh_plink: Convert timers to use

2017-10-05 Thread Johannes Berg
On Wed, 2017-10-04 at 17:49 -0700, Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list > pointer to all timer callbacks, switch to using the new timer_setup() > and from_timer() to pass the timer pointer explicitly. This requires > adding a pointer back to the

Re: [PATCH] net: tulip: de2104x: Convert timers to use

2017-10-05 Thread Tobias Klauser
On 2017-10-05 at 02:50:48 +0200, Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: "David S. Miller"

r8169 Wake-on-LAN causes immediate ACPI GPE wakeup

2017-10-05 Thread Daniel Drake
Hi, On the Acer laptop models Aspire ES1-533, Aspire ES1-732, PackardBell ENTE69AP and Gateway NE533, we are seeing a problem where the system immediately wakes up after being put into S3 suspend. This problem has been seen on all kernel versions that we have tried, including 4.14-rc3. After

[PATCH v3 2/2] net: phonet: mark phonet_protocol as const

2017-10-05 Thread Lin Zhang
The phonet_protocol structs don't need to be written by anyone and so can be marked as const. Signed-off-by: Lin Zhang --- changelog: v1 -> v2: * remove __read_mostly tag v2 -> v3: * revert __read_mostly tag --- include/net/phonet/phonet.h | 6 --

[PATCH v3] netfilter: SYNPROXY: fix process non tcp packet bug in {ipv4,ipv6}_synproxy_hook

2017-10-05 Thread Lin Zhang
In function {ipv4,ipv6}_synproxy_hook we expect a normal tcp packet, but the real server maybe reply an icmp error packet related to the exist tcp conntrack, so we will access wrong tcp data. For fix it, check for the protocol field and only process tcp traffic. Signed-off-by: Lin Zhang

[PATCH] net: qcom/emac: make function emac_isr static

2017-10-05 Thread Colin King
From: Colin Ian King The function emac_isr is local to the source and does not need to be in global scope, so make it static. Cleans up sparse warnings: symbol 'emac_isr' was not declared. Should it be static? Signed-off-by: Colin Ian King

Re: [PATCH] net: dl2k: Convert timers to use timer_setup()

2017-10-05 Thread Tobias Klauser
On 2017-10-05 at 02:51:50 +0200, Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: "David S. Miller"

[PATCH v3 1/6] staging: fsl-dpaa2/ethsw: Add APIs for DPSW object

2017-10-05 Thread Razvan Stefanescu
Add the command build/parse APIs for operating on DPSW objects through the DPAA2 Management Complex. Signed-off-by: Razvan Stefanescu --- Changelog: v2: - use u8 for en parameter of dpsw_if_set_flooding/broadcast() v3: - no changes

Re: [net-next V4 PATCH 2/5] bpf: XDP_REDIRECT enable use of cpumap

2017-10-05 Thread Daniel Borkmann
On 10/04/2017 02:03 PM, Jesper Dangaard Brouer wrote: This patch connects cpumap to the xdp_do_redirect_map infrastructure. Still no SKB allocation are done yet. The XDP frames are transferred to the other CPU, but they are simply refcnt decremented on the remote CPU. This served as a good

[PATCH net] net: enable interface alias removal via rtnl

2017-10-05 Thread Nicolas Dichtel
IFLA_IFALIAS is defined as NLA_STRING. It means that the minimal length of the attribute is 1 ("\0"). However, to remove an alias, the attribute length must be 0 (see dev_set_alias()). Let's define the type to NLA_BINARY, so that the alias can be removed. Example: $ ip l s dummy0 alias foo $ ip

[patch net-next 0/6] mlxsw: Offload bridge device mrouter

2017-10-05 Thread Jiri Pirko
From: Jiri Pirko Yotam says: Similarly to a bridged port, the bridge device itself can be configured by the user to be an mrouter port. In this case, all multicast traffic should be forwarded to it. Make the mlxsw Spectrum driver offload these directives to the Spectrum

[patch net-next 2/6] net: bridge: Notify on bridge device mrouter state changes

2017-10-05 Thread Jiri Pirko
From: Yotam Gigi Add the SWITCHDEV_ATTR_ID_BRIDGE_MROUTER switchdev notification type, used to indicate whether the bridge is or isn't mrouter. Notify when the bridge changes its state, similarly to the already existing bridged port mrouter notifications. The notification

[patch net-next 6/6] mlxsw: spectrum_switchdev: Support bridge mrouter notifications

2017-10-05 Thread Jiri Pirko
From: Yotam Gigi Support the SWITCHDEV_ATTR_ID_BRIDGE_MROUTER port attribute switchdev notification. To do that, add the mrouter flag to struct mlxsw_sp_bridge_device, which indicates whether the bridge device was set to be mrouter port. This field is set when: - A new

[patch net-next 5/6] mlxsw: spectrum_switchdev: Add support for router port in SMID entries

2017-10-05 Thread Jiri Pirko
From: Yotam Gigi In Spectrum, MDB entries point to MID entries, that indicate which ports a packet should be forwarded to. Add the support in creating MID entries that forward the packet to the Spectrum router port. This will be later used to handle the bridge mrouter port

Re: [PATCH] isdn/gigaset: Convert timers to use timer_setup()

2017-10-05 Thread Paul Bolle
Hi Kees, On Wed, 2017-10-04 at 17:52 -0700, Kees Cook wrote: > Also uses kzmalloc to replace open-coded field assignments to NULL and zero. If I'm allowed to whine (chances that I'm allowed to do that are not so great as Dave tends to apply gigaset patches before I even have a chance to look at

Re: [PATCH v1] s390/qeth: use kstrtobool() in qeth_bridgeport_hostnotification_store()

2017-10-05 Thread Julian Wiedmann
On 10/04/2017 03:38 PM, Andy Shevchenko wrote: > The sysfs enabled value is a boolean, so kstrtobool() is a better fit > for parsing the input string since it does the range checking for us. > > Signed-off-by: Andy Shevchenko > --- Thanks Andy, queued up for

[PATCH] net: ipv6: remove unused code in ipv6_find_hdr()

2017-10-05 Thread Lin Zhang
Storing the left length of skb into 'len' actually has no effect so we can remove it. Signed-off-by: Lin Zhang --- net/ipv6/exthdrs_core.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/net/ipv6/exthdrs_core.c b/net/ipv6/exthdrs_core.c index 305e2ed..98096ea

Re: [PATCH net-next 01/10] net/smc: add missing dev_put

2017-10-05 Thread Ursula Braun
On 10/02/2017 10:36 PM, Parav Pandit wrote: > Hi Ursula, Dave, Hans, > >> -Original Message- >> From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- >> ow...@vger.kernel.org] On Behalf Of Ursula Braun >> Sent: Wednesday, September 20, 2017 6:58 AM >> To: da...@davemloft.net >> Cc:

[PATCH v3 5/6] staging: fsl-dpaa2/ethsw: Add README

2017-10-05 Thread Razvan Stefanescu
Add a README file describing the driver architecture, components and interfaces. Signed-off-by: Razvan Stefanescu --- Changelog: v2: - no changes v3: - no changes drivers/staging/fsl-dpaa2/ethsw/README | 106 + 1 file

Re: [PATCH 3/3] ARM: dts: gr-peach: Add ETHER pin group

2017-10-05 Thread jacopo mondi
Hi Geert On Thu, Oct 05, 2017 at 11:09:40AM +0200, Geert Uytterhoeven wrote: > Hi Jacopo, > > On Thu, Oct 5, 2017 at 10:58 AM, Jacopo Mondi > wrote: > > Add pin configuration subnode for ETHER pin group and enable the interface. > > > > Signed-off-by: Jacopo Mondi

[PATCH v3 1/2] net: phonet: mark header_ops as const

2017-10-05 Thread Lin Zhang
Signed-off-by: Lin Zhang --- changelog: v2 -> v3: * fix phonet_header_ops type mismatch error --- include/linux/if_phonet.h | 2 +- net/phonet/af_phonet.c| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/if_phonet.h

Re: [PATCH V2] Fix a sleep-in-atomic bug in shash_setkey_unaligned

2017-10-05 Thread Herbert Xu
On Wed, Oct 04, 2017 at 09:37:58PM -0700, David Miller wrote: > > > I'm not talking about the code-path in question. I'm talking > > about the function which generates the secret key in the first > > place. AFAICS that's only called in GFP_KERNEL context. What > > am I missing? > > The setkey

Re: [PATCH] mwifiex: Use put_unaligned_le32

2017-10-05 Thread Kalle Valo
Himanshu Jha writes: >> > --- a/drivers/net/wireless/marvell/mwifiex/cmdevt.c >> > +++ b/drivers/net/wireless/marvell/mwifiex/cmdevt.c >> > @@ -17,6 +17,7 @@ >> > * this warranty disclaimer. >> > */ >> > >> > +#include >> >> I don't think this is correct.

Re: [PATCH net] netfilter: x_tables: avoid stack-out-of-bounds read in xt_copy_counters_from_user

2017-10-05 Thread Florian Westphal
Eric Dumazet wrote: > From: Eric Dumazet > > syzkaller reports an out of bound read in strlcpy(), triggered > by xt_copy_counters_from_user() > > Fix this by using memcpy(), then forcing a zero byte at the last position > of the destination, as

Re: [net-next V4 PATCH 3/5] bpf: cpumap xdp_buff to skb conversion and allocation

2017-10-05 Thread Daniel Borkmann
On 10/04/2017 02:03 PM, Jesper Dangaard Brouer wrote: [...] static int cpu_map_kthread_run(void *data) { struct bpf_cpu_map_entry *rcpu = data; set_current_state(TASK_INTERRUPTIBLE); while (!kthread_should_stop()) { + unsigned int processed = 0, drops =

Re: [PATCH] mwifiex: Use put_unaligned_le32

2017-10-05 Thread Kalle Valo
Himanshu Jha writes: > Use put_unaligned_le32 rather than using byte ordering function and > memcpy which makes code clear. > Also, add the header file where it is declared. > > Done using Coccinelle and semantic patch used is : > > @ rule1 @ > identifier tmp;

[PATCH v3 3/6] staging: fsl-dpaa2/ethsw: Add ethtool support

2017-10-05 Thread Razvan Stefanescu
Add driver information, link details and hardware statistics to be reported via ethtool -S. Signed-off-by: Razvan Stefanescu --- Changelog: v2: - no changes v3: - removed driver version drivers/staging/fsl-dpaa2/ethsw/Makefile| 2 +-

[PATCH v3 0/6] staging: Introduce DPAA2 Ethernet Switch driver

2017-10-05 Thread Razvan Stefanescu
This patchset introduces the Ethernet Switch Driver for Freescale/NXP SoCs with DPAA2 (DataPath Acceleration Architecture v2). The driver manages switch objects discovered on the fsl-mc bus. A description of the driver can be found in the associated README file. The patchset consists of: * A set

[PATCH v3 6/6] staging: fsl-dpaa2/ethsw: Add TODO

2017-10-05 Thread Razvan Stefanescu
Add a TODO file describing what needs to be added/changed before the driver can be moved out of staging. Signed-off-by: Razvan Stefanescu --- Changelog: v2: - no changes v3: - no changes drivers/staging/fsl-dpaa2/ethsw/TODO | 14 ++ 1 file

[PATCH v3 4/6] staging: fsl-dpaa2/ethsw: Add maintainer for Ethernet Switch driver

2017-10-05 Thread Razvan Stefanescu
Signed-off-by: Razvan Stefanescu --- Changelog: v2: - no changes v3: - no changes MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 2281af4..cfd4f74 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4297,6

Re: [PATCH net-next v6 0/4] bpf: add two helpers to read perf event enabled/running time

2017-10-05 Thread Daniel Borkmann
On 10/05/2017 10:34 AM, Peter Zijlstra wrote: On Wed, Oct 04, 2017 at 04:00:56PM -0700, David Miller wrote: From: Yonghong Song Date: Mon, 2 Oct 2017 15:42:14 -0700 [Dave, Peter, Previous communcation shows that this patch may potentially have merge conflict with upcoming

[patch net-next 1/6] net: bridge: Use the MDB_RTR_TYPE_TEMP on bridge device too

2017-10-05 Thread Jiri Pirko
From: Yotam Gigi Every bridge port is in one of four mcast router port states: - MDB_RTR_TYPE_PERM - the port is set by the user to be an mrouter port regardless of IGMP queries. - MDB_RTR_TYPE_DISABLED - the port is set by the user to not be an mrouter port

[patch net-next 4/6] mlxsw: spectrum: router: Export the mlxsw_sp_router_port function

2017-10-05 Thread Jiri Pirko
From: Yotam Gigi In Spectrum hardware, the router port is a virtual port that is the gateway to the routing mechanism. Hence, in order for a packet to be L3 forwarded, it must first be L2 forwarded to the router port inside the hardware. Further patches in this patchset are

[patch net-next 3/6] net: bridge: Export bridge multicast router state

2017-10-05 Thread Jiri Pirko
From: Yotam Gigi Add an access function that, given a bridge netdevice, returns whether the bridge device is currently an mrouter or not. The function uses the already existing br_multicast_is_router function to check that. This function is needed in order to allow ports

Re: [PATCH] mwifiex: Use put_unaligned_le32

2017-10-05 Thread Himanshu Jha
On Thu, Oct 05, 2017 at 10:23:37AM +0300, Kalle Valo wrote: > Himanshu Jha writes: > > > Use put_unaligned_le32 rather than using byte ordering function and > > memcpy which makes code clear. > > Also, add the header file where it is declared. > > > > Done using

Re: [PATCH net-next v6 0/4] bpf: add two helpers to read perf event enabled/running time

2017-10-05 Thread Peter Zijlstra
On Wed, Oct 04, 2017 at 04:00:56PM -0700, David Miller wrote: > From: Yonghong Song > Date: Mon, 2 Oct 2017 15:42:14 -0700 > > > [Dave, Peter, > > > > Previous communcation shows that this patch may potentially have > > merge conflict with upcoming tip changes in the next merge

[PATCH v3 2/6] staging: fsl-dpaa2/ethsw: Add Freescale DPAA2 Ethernet Switch driver

2017-10-05 Thread Razvan Stefanescu
Introduce the DPAA2 Ethernet Switch driver, which manages Datapath Switch (DPSW) objects discovered on the MC bus. Suggested-by: Alexandru Marginean Signed-off-by: Razvan Stefanescu --- Changelog: v2: - fix PVID cleanup in

Re: [net-next V4 PATCH 1/5] bpf: introduce new bpf cpu map type BPF_MAP_TYPE_CPUMAP

2017-10-05 Thread Daniel Borkmann
On 10/04/2017 02:03 PM, Jesper Dangaard Brouer wrote: [...] +#define CPU_MAP_BULK_SIZE 8 /* 8 == one cacheline on 64-bit archs */ +struct xdp_bulk_queue { + void *q[CPU_MAP_BULK_SIZE]; + unsigned int count; +}; + +/* Struct for every remote "destination" CPU in map */ +struct

[PATCH net] netfilter: x_tables: avoid stack-out-of-bounds read in xt_copy_counters_from_user

2017-10-05 Thread Eric Dumazet
From: Eric Dumazet syzkaller reports an out of bound read in strlcpy(), triggered by xt_copy_counters_from_user() Fix this by using memcpy(), then forcing a zero byte at the last position of the destination, as Florian did for the non COMPAT code. Fixes: d7591f0c41ce

Re: [PATCH] net/ipv4: Remove unused variable in route.c

2017-10-05 Thread David Miller
From: Tim Hansen Date: Wed, 4 Oct 2017 15:59:49 -0400 > int rc is unmodified after initalization in net/ipv4/route.c, this patch > simply cleans up that variable and returns 0. > > This was found with coccicheck M=net/ipv4/ on linus' tree. > > Signed-off-by: Tim Hansen

[net-next,v2] ip_gre: check packet length and mtu correctly in erspan tx

2017-10-05 Thread William Tu
Similarly to early patch for erspan_xmit(), the ARPHDR_ETHER device is the length of the whole ether packet. So skb->len should subtract the dev->hard_header_len. Fixes: 1a66a836da63 ("gre: add collect_md mode to ERSPAN tunnel") Fixes: 84e54fe0a5ea ("gre: introduce native tunnel support for

Re: [PATCH v6 11/11] of: mdio: Prevent of_mdiobus_register from scanning mdio-mux nodes

2017-10-05 Thread Rob Herring
On Wed, Sep 27, 2017 at 09:50:46PM -0700, Florian Fainelli wrote: > > > On 09/27/2017 07:12 AM, Andrew Lunn wrote: > > On Wed, Sep 27, 2017 at 09:34:14AM +0200, Corentin Labbe wrote: > >> Each child node of an MDIO node is scanned as a PHY when calling > >> of_mdiobus_register() givint the

Re: [RESEND PATCH 7/7] net: qrtr: Support decoding incoming v2 packets

2017-10-05 Thread David Miller
From: Bjorn Andersson Date: Wed, 4 Oct 2017 20:51:05 -0700 > +/** > + * struct qrtr_hdr_v2 - (I|R)PCrouter packet header later versions > + * @version: protocol version > + * @type: packet type; one of QRTR_TYPE_* > + * @flags: bitmask of QRTR_FLAGS_* > + * @optlen:

Re: [PATCH] net: qcom/emac: make function emac_isr static

2017-10-05 Thread David Miller
From: Colin King Date: Thu, 5 Oct 2017 10:10:23 +0100 > From: Colin Ian King > > The function emac_isr is local to the source and does not need to > be in global scope, so make it static. > > Cleans up sparse warnings: > symbol 'emac_isr'

Re: [PATCH] net: ipv6: remove unused code in ipv6_find_hdr()

2017-10-05 Thread David Miller
From: Lin Zhang Date: Fri, 6 Oct 2017 02:07:08 +0800 > Storing the left length of skb into 'len' actually has no effect > so we can remove it. > > Signed-off-by: Lin Zhang Applied.

Re: r8169 Wake-on-LAN causes immediate ACPI GPE wakeup

2017-10-05 Thread Rafael J. Wysocki
On Thu, Oct 5, 2017 at 10:57 AM, Daniel Drake wrote: > Hi, > > On the Acer laptop models Aspire ES1-533, Aspire ES1-732, PackardBell > ENTE69AP and Gateway NE533, we are seeing a problem where the system > immediately wakes up after being put into S3 suspend. > > This problem

Re: r8169 Wake-on-LAN causes immediate ACPI GPE wakeup

2017-10-05 Thread Daniel Drake
On Fri, Oct 6, 2017 at 8:16 AM, Francois Romieu wrote: > Daniel Drake : > [...] >> Also, is there a standard behaviour defined for ethernet drivers >> regarding wake-on-LAN? r8169 appears to enable wake-on-LAN by default >> if it believes the hardware is

Re: r8169 Wake-on-LAN causes immediate ACPI GPE wakeup

2017-10-05 Thread Daniel Drake
On Fri, Oct 6, 2017 at 9:24 AM, Rafael J. Wysocki wrote: >> On the other hand, the RP05 (root port) _PRW says it will wake up the >> system via GPE09, and the _L09 handler at least has one codepath which >> could potentially do a Notify(PXSX, 2) to indicate an ethernet wakeup.

Re: [PATCH v3 0/5] VSOCK: add sock_diag interface

2017-10-05 Thread David Miller
From: Stefan Hajnoczi Date: Thu, 5 Oct 2017 16:46:49 -0400 > v3: > * Rebased onto net-next/master and resolved Hyper-V transport conflict > > v2: > * Moved tests to tools/testing/vsock/. I was unable to put them in > selftests/ >because they require manual setup of

Re: [PATCH net v2 3/9] net/mac89x0: Fix and modernize log messages

2017-10-05 Thread David Miller
From: Finn Thain Date: Thu, 5 Oct 2017 21:11:05 -0400 (EDT) > Fix misplaced newlines in conditional log messages. Please don't do this, the way the author formatted the strings was intentional, they intended to print out: NAME: cs89%c0%s rev %c found at

Re: [PATCH net] selftests/net: rxtimestamp: Fix an off by one

2017-10-05 Thread David Miller
From: Dan Carpenter Date: Thu, 5 Oct 2017 15:53:47 +0300 > The > should be >= so that we don't write one element beyond the end of > the array. > > Fixes: 16e781224198 ("selftests/net: Add a test to validate behavior of rx > timestamps") > Signed-off-by: Dan Carpenter

Re: Fw: [Bug 197099] New: Kernel panic in interrupt [l2tp_ppp]

2017-10-05 Thread SviMik
2017-10-04 10:49 GMT+03:00 James Chapman : > On 3 October 2017 at 08:27, James Chapman wrote: >> For capturing complete oops messages, have you tried setting up >> netconsole? You might also find the full text in the syslog on reboot. Why, thank you!

Re: [PATCH] net/ipv6: remove unused err variable on icmpv6_push_pending_frames

2017-10-05 Thread David Miller
From: Tim Hansen Date: Thu, 5 Oct 2017 15:45:32 -0400 > int err is unused by icmpv6_push_pending_frames(), this patch returns removes > the variable and returns the function with 0. > > git bisect shows this variable has been around since linux has been in git in >

RE: [PATCH 2/3 v2] net: phy: DP83822 initial driver submission

2017-10-05 Thread Woojung.Huh
> > > +static int dp83822_suspend(struct phy_device *phydev) > > > +{ > > > + int value; > > > + > > > + mutex_lock(>lock); > > > + value = phy_read_mmd(phydev, DP83822_DEVADDR, > > > MII_DP83822_WOL_CFG); > > > + mutex_unlock(>lock); > > > Would we need mutex to access phy_read_mmd()? > >

Re: [PATCH net-next 0/3] tcp: improving RACK cpu performance

2017-10-05 Thread David Miller
From: Yuchung Cheng Date: Wed, 4 Oct 2017 12:59:57 -0700 > This patch set improves the CPU consumption of the RACK TCP loss > recovery algorithm, in particular for high-speed networks. Currently, > for every ACK in recovery RACK can potentially iterate over all sent > packets

[PATCH net-next 1/3] bpf: Change bpf_obj_name_cpy() to better ensure map's name is init by 0

2017-10-05 Thread Martin KaFai Lau
During get_info_by_fd, the prog/map name is memcpy-ed. It depends on the prog->aux->name and map->name to be zero initialized. bpf_prog_aux is easy to guarantee that aux->name is zero init. The name in bpf_map may be harder to be guaranteed in the future when new map type is added. Hence, this

[PATCH net-next 2/3] bpf: Use char in prog and map name

2017-10-05 Thread Martin KaFai Lau
Instead of u8, use char for prog and map name. It can avoid the userspace tool getting compiler's signess warning. The bpf_prog_aux, bpf_map, bpf_attr, bpf_prog_info and bpf_map_info are changed. Signed-off-by: Martin KaFai Lau Cc: Jakub Kicinski

[PATCH net-next 0/3] bpf: Misc improvements and a new usage on bpf obj name

2017-10-05 Thread Martin KaFai Lau
The first two patches make improvements on the bpf obj name. The last patch adds the prog name to kallsyms. Martin KaFai Lau (3): bpf: Change bpf_obj_name_cpy() to better ensure map's name is init by 0 bpf: Use char in prog and map name bpf: Append prog->aux->name in

[PATCH net-next 3/3] bpf: Append prog->aux->name in bpf_get_prog_name()

2017-10-05 Thread Martin KaFai Lau
This patch makes the bpf_prog's name available in kallsyms. The new format is bpf_prog_tag[_name]. Sample kallsyms from running selftests/bpf/test_progs: [root@arch-fb-vm1 ~]# egrep ' bpf_prog_[0-9a-fA-F]{16}' /proc/kallsyms a0048000 t bpf_prog_dabf0207d1992486_test_obj_id

Re: [PATCH] ipv6: fix net.ipv6.conf.all.accept_dad behaviour for real

2017-10-05 Thread Stefano Brivio
On Thu, 5 Oct 2017 19:03:05 +0200 Matteo Croce wrote: > Commit 35e015e1f577 ("ipv6: fix net.ipv6.conf.all interface DAD handlers") > was intended to affect accept_dad flag handling in such a way that > DAD operation and mode on a given interface would be selected > according

[PATCH] staging: irda: resolve sparse errors due to implicit pci_power_t casts

2017-10-05 Thread Matthew Giassa
Explicitly casting pci_power_t types to resolve sparse warnings (shown below). Also fixing a related logging bug where pci_power_t is cast to unsigned (can be negative, i.e. PCI_POWER_ERROR). Original sparse report: drivers/staging/irda/drivers//vlsi_ir.c:170:51: warning: cast from restricted

[PATCH net v2 8/9] net/8390: Fix redundant code

2017-10-05 Thread Finn Thain
The patch which introduced the 8390 core module parameter 'msg_enable' failed to do anything useful with it: it merely causes an ancient version string to be logged. Remove the other code that logs the same string. Use the msg_enable module parameter as the default value for ei_local->msg_enable.

[PATCH net v2 5/9] net/macmace: Fix and cleanup log messages

2017-10-05 Thread Finn Thain
Log the MAC address after the interface gets a meaningful name and in doing so, make the registration error path more idiomatic. Drop redundant debug messages for FIFO events recorded in the interface statistics (consistent with mace.c). Signed-off-by: Finn Thain

[PATCH net v2 7/9] net/sonic: Replace custom debug logging with netif_* calls

2017-10-05 Thread Finn Thain
Also eliminate duplicated debug code by moving it into the core driver. Cc: Thomas Bogendoerfer Cc: Chris Zankel Signed-off-by: Finn Thain --- Only the sonic.[ch] and macsonic.c changes have been tested. The other changes

[PATCH net v2 9/9] net/mac8390: Fix log messages

2017-10-05 Thread Finn Thain
Before expansion, dev->name is "eth%d", so log the slot number instead. Log the MAC address after the interface gets a meaningful name. Disambiguate the two identical "Card type %s is unsupported" messages. Fix the duplicated driver name in the pr_warn() message. Fixes: 3a3a7f3b7fbd ("net:

Re: [PATCH v2 net-next 2/2] tcp: clean up TFO server's initial tcp_rearm_rto() call

2017-10-05 Thread David Miller
From: Wei Wang Date: Wed, 4 Oct 2017 10:04:04 -0700 > From: Wei Wang > > This commit does a cleanup and moves tcp_rearm_rto() call in the TFO > server case into a previous spot in tcp_rcv_state_process() to make > it more compact. > This is only a

Re: [PATCH v2 net-next 1/2] tcp: uniform the set up of sockets after successful connection

2017-10-05 Thread David Miller
From: Wei Wang Date: Wed, 4 Oct 2017 10:03:44 -0700 > From: Wei Wang > > Currently in the TCP code, the initialization sequence for cached > metrics, congestion control, BPF, etc, after successful connection > is very inconsistent. This introduces

Re: [PATCH] net/mlx4_core: Convert timers to use timer_setup()

2017-10-05 Thread Leon Romanovsky
On Wed, Oct 04, 2017 at 05:51:54PM -0700, Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: Tariq Toukan

Re: [PATCH 1/4] dt-bindings: net: ravb: Document optional reset-gpios property

2017-10-05 Thread Rob Herring
On Thu, Sep 28, 2017 at 11:07:38PM +0300, Sergei Shtylyov wrote: > Hello! > > On 09/28/2017 06:53 PM, Geert Uytterhoeven wrote: > > > The optional "reset-gpios" property (part of the generic MDIO bus > > properties) lets us describe the GPIO used for resetting the Ethernet > > PHY. > > > >

[PATCH net v2 0/9] Fixes, cleanup and modernization for some legacy ethernet NIC drivers

2017-10-05 Thread Finn Thain
This patch series fixes some logging bugs and adds some missing message severity levels. There are also cleanup patches for dead code and some Kconfig cruft. Custom debug message logging is converted to netif_* calls to reduce code duplication. All up, about 150 lines of code are eliminated.

Re: [PATCH v2 net-next 06/12] qed: Add LL2 slowpath handling

2017-10-05 Thread Kalderon, Michal
From: linux-rdma-ow...@vger.kernel.org on behalf of David Miller >From: "Kalderon, Michal" >Date: Thu, 5 Oct 2017 20:27:22 + > >> The spinlock is required for the case that rx buffers are posted >> from a

[PATCH] rsi: fix integer overflow warning

2017-10-05 Thread Arnd Bergmann
gcc produces a harmless warning about a recently introduced signed integer overflow: drivers/net/wireless/rsi/rsi_91x_hal.c: In function 'rsi_prepare_mgmt_desc': include/uapi/linux/swab.h:13:15: error: integer overflow in expression [-Werror=overflow] (((__u16)(x) & (__u16)0x00ffU) << 8) | \

Re: [patch net-next 2/6] net: bridge: Notify on bridge device mrouter state changes

2017-10-05 Thread Nikolay Aleksandrov
On 05/10/17 13:36, Jiri Pirko wrote: > From: Yotam Gigi > > Add the SWITCHDEV_ATTR_ID_BRIDGE_MROUTER switchdev notification type, used > to indicate whether the bridge is or isn't mrouter. Notify when the bridge > changes its state, similarly to the already existing bridged

Re: [PATCH net-next 4/4] selinux: bpf: Add addtional check for bpf object file receive

2017-10-05 Thread Stephen Smalley
On Wed, 2017-10-04 at 11:29 -0700, Chenbo Feng wrote: > From: Chenbo Feng > > Introduce a bpf object related check when sending and receiving files > through unix domain socket as well as binder. It checks if the > receiving > process have privilege to read/write the bpf map or

Re: [patch net-next 1/6] net: bridge: Use the MDB_RTR_TYPE_TEMP on bridge device too

2017-10-05 Thread Nikolay Aleksandrov
On 05/10/17 15:09, Nikolay Aleksandrov wrote: > On 05/10/17 13:36, Jiri Pirko wrote: >> From: Yotam Gigi >> >> Every bridge port is in one of four mcast router port states: >> - MDB_RTR_TYPE_PERM - the port is set by the user to be an mrouter port >>regardless of IGMP

Re: [PATCH] netfilter: ipset: Convert timers to use timer_setup()

2017-10-05 Thread Jozsef Kadlecsik
Hi, On Wed, 4 Oct 2017, Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list pointer > to all timer callbacks, switch to using the new timer_setup() and > from_timer() to pass the timer pointer explicitly. This introduces a > pointer back to the struct ip_set,

RE: [PATCH net-next] ip_gre: check packet length and mtu correctly in erspan_fb_xmit

2017-10-05 Thread David Laight
From: William Tu > Sent: 05 October 2017 01:14 > Similarly to early patch for erspan_xmit(), the ARPHDR_ETHER device > is the length of the whole ether packet. So skb->len should subtract > the dev->hard_header_len. > > Fixes: 1a66a836da63 ("gre: add collect_md mode to ERSPAN tunnel") >

Re: [PATCH 3/7] crypto:gf128mul: The x8_ble multiplication functions

2017-10-05 Thread Harsh Jain
On 03-10-2017 20:28, David Laight wrote: > From: Harsh Jain >> Sent: 03 October 2017 07:46 >> It multiply GF(2^128) elements in the ble format. >> It will be used by chelsio driver to fasten gf multiplication. >^ speed up ?? It should be speed up. Will fix

Re: [PATCH] rsi: fix integer overflow warning

2017-10-05 Thread Joe Perches
On Thu, 2017-10-05 at 14:05 +0200, Arnd Bergmann wrote: > gcc produces a harmless warning about a recently introduced > signed integer overflow: > > drivers/net/wireless/rsi/rsi_91x_hal.c: In function 'rsi_prepare_mgmt_desc': > include/uapi/linux/swab.h:13:15: error: integer overflow in

Apply

2017-10-05 Thread Capital Finance
UNSECURED BUSINESS/PERSONAL LOAN BY LOAN CAPITAL FINANCE - NO COLLATERAL - MINIMUM DOCUMENTATION - BUSINESS LOAN UP TO FIVE(5) MILLION US DOLLARS CONTACT US TODAY VIA EMAIL: financeloa...@hotmail.com

[PATCH net] selftests/net: rxtimestamp: Fix an off by one

2017-10-05 Thread Dan Carpenter
The > should be >= so that we don't write one element beyond the end of the array. Fixes: 16e781224198 ("selftests/net: Add a test to validate behavior of rx timestamps") Signed-off-by: Dan Carpenter diff --git

Re: [PATCH 3/3] ARM: dts: gr-peach: Add ETHER pin group

2017-10-05 Thread Andrew Lunn
On Thu, Oct 05, 2017 at 11:39:15AM +0200, jacopo mondi wrote: > Hi Geert > > On Thu, Oct 05, 2017 at 11:09:40AM +0200, Geert Uytterhoeven wrote: > > Hi Jacopo, > > > > On Thu, Oct 5, 2017 at 10:58 AM, Jacopo Mondi > > wrote: > > > Add pin configuration subnode for

Re: [patch net-next 1/6] net: bridge: Use the MDB_RTR_TYPE_TEMP on bridge device too

2017-10-05 Thread Nikolay Aleksandrov
On 05/10/17 15:09, Nikolay Aleksandrov wrote: > On 05/10/17 13:36, Jiri Pirko wrote: >> From: Yotam Gigi >> >> Every bridge port is in one of four mcast router port states: >> - MDB_RTR_TYPE_PERM - the port is set by the user to be an mrouter port >>regardless of IGMP

Re: [PATCH v2 net-next 0/2] net/sched: support tunnel options in cls_flower and act_tunnel_key

2017-10-05 Thread Jiri Benc
On Mon, 2 Oct 2017 09:50:15 +0200, Simon Horman wrote: > I believe that in order to avoid per-packet overhead and at the same time > code complexity the TLVs should be described in-order. So matching on > TLV-A,TLV-B,TLV-C would be a different match to TLV-C,TLV-A,TLV-B. An > order-independent

[PATCH 3/3] xen/9pfs: don't inclide rwlock.h directly.

2017-10-05 Thread Sebastian Andrzej Siewior
rwlock.h should not be included directly. Instead linux/splinlock.h should be included. One thing it does is to break the RT build. Cc: Eric Van Hensbergen Cc: Ron Minnich Cc: Latchesar Ionkov Cc: "David S. Miller"

Re: [patch net-next 1/6] net: bridge: Use the MDB_RTR_TYPE_TEMP on bridge device too

2017-10-05 Thread Nikolay Aleksandrov
On 05/10/17 13:36, Jiri Pirko wrote: > From: Yotam Gigi > > Every bridge port is in one of four mcast router port states: > - MDB_RTR_TYPE_PERM - the port is set by the user to be an mrouter port >regardless of IGMP queries. > - MDB_RTR_TYPE_DISABLED - the port is set

Re: [patch net-next 3/6] net: bridge: Export bridge multicast router state

2017-10-05 Thread Nikolay Aleksandrov
On 05/10/17 13:36, Jiri Pirko wrote: > From: Yotam Gigi > > Add an access function that, given a bridge netdevice, returns whether the > bridge device is currently an mrouter or not. The function uses the already > existing br_multicast_is_router function to check that. > >

Re: [PATCH V2] Fix a sleep-in-atomic bug in shash_setkey_unaligned

2017-10-05 Thread Herbert Xu
On Thu, Oct 05, 2017 at 06:16:20PM +0800, Herbert Xu wrote: > > That was my point. Functions like sctp_pack_cookie shouldn't be > setting the key in the first place. The setkey should happen at > the point when the key is generated. That's sctp_endpoint_init > which AFAICS only gets called in

Re: [PATCH net-next 0/3] A own subdirectory for shared TCP code

2017-10-05 Thread Richard Siegfried
On 04/10/17 22:27, Andrew Lunn wrote: > Hi Richard > > It is generally unwanted. > > Have you tried back porting patches when the directory structure has > changed? Files have moved around? It makes it a lot harder to > do. Meaning patches are going to be back ported less often. Fixes > which

Re: [PATCH net-next 3/4] selinux: bpf: Add selinux check for eBPF syscall operations

2017-10-05 Thread Stephen Smalley
On Wed, 2017-10-04 at 11:29 -0700, Chenbo Feng wrote: > From: Chenbo Feng > > Implement the actual checks introduced to eBPF related syscalls. This > implementation use the security field inside bpf object to store a > sid that > identify the bpf object. And when processes try

Re: [PATCH] net: phy: DP83822 initial driver submission (fwd)

2017-10-05 Thread Dan Murphy
, > > [auto build test WARNING on net-next/master] > [also build test WARNING on v4.14-rc3 next-20170929] > [if your patch is applied to the wrong git tree, please drop us a note to > help improve the system] > > url: > https://github.com/0day-ci/linux/commits/Dan-Mu

Re: [PATCH net-next v3 0/2] libbpf: support more map options

2017-10-05 Thread Alexei Starovoitov
On 10/5/17 7:41 AM, Craig Gallek wrote: From: Craig Gallek The functional change to this series is the ability to use flags when creating maps from object files loaded by libbpf. In order to do this, the first patch updates the library to handle map definitions that differ

[PATCH] ipv6: gso: fix payload length when gso_size is zero

2017-10-05 Thread Alexey Kodanev
When gso_size reset to zero for the tail segment in skb_segment(), later in ipv6_gso_segment(), we will get incorrect payload_len for that segment. inet_gso_segment() already has a check for gso_size before calculating payload so fixing only IPv6 part. The issue was found with LTP vxlan & gre

[PATCH] ipv6: fix net.ipv6.conf.all.accept_dad behaviour for real

2017-10-05 Thread Matteo Croce
Commit 35e015e1f577 ("ipv6: fix net.ipv6.conf.all interface DAD handlers") was intended to affect accept_dad flag handling in such a way that DAD operation and mode on a given interface would be selected according to the maximum value of conf/{all,interface}/accept_dad. However,

Re: [PATCH] net/mac80211/mesh_plink: Convert timers to use

2017-10-05 Thread Kees Cook
On Wed, Oct 4, 2017 at 11:47 PM, Johannes Berg wrote: > On Wed, 2017-10-04 at 17:49 -0700, Kees Cook wrote: >> In preparation for unconditionally passing the struct timer_list >> pointer to all timer callbacks, switch to using the new timer_setup() >> and from_timer()

Re: [PATCH net-next 3/4] selinux: bpf: Add selinux check for eBPF syscall operations

2017-10-05 Thread Daniel Borkmann
On 10/05/2017 03:28 PM, Stephen Smalley wrote: [...] +static int selinux_bpf_prog(struct bpf_prog *prog) +{ + u32 sid = current_sid(); + struct bpf_security_struct *bpfsec; + + bpfsec = prog->aux->security; I haven't looked closely at the bpf code, but is it guaranteed that

Re: [PATCH] rsi: fix integer overflow warning

2017-10-05 Thread Joe Perches
On Thu, 2017-10-05 at 15:12 +, David Laight wrote: > From: Joe Perches > > Sent: 05 October 2017 13:19 > > On Thu, 2017-10-05 at 14:05 +0200, Arnd Bergmann wrote: > > > gcc produces a harmless warning about a recently introduced > > > signed integer overflow: > > > > > >

Re: [PATCH RFC 1/2] virtio_net: implement VIRTIO_CONFIG_S_NEEDS_RESET

2017-10-05 Thread Willem de Bruijn
On Tue, Aug 29, 2017 at 4:20 PM, Michael S. Tsirkin wrote: > On Tue, Aug 29, 2017 at 04:07:58PM -0400, Willem de Bruijn wrote: >> From: Willem de Bruijn >> >> Implement the reset communication request defined in the VIRTIO 1.0 >> specification and introduces

  1   2   >