Re: [PATCH] net: make ->ndo_get_phys_port_name accept 32-bit len

2017-10-08 Thread David Miller
From: Jakub Kicinski Date: Sun, 8 Oct 2017 18:25:45 -0700 > On Sun, 8 Oct 2017 01:19:17 +0300, Alexey Dobriyan wrote: >> Buffer length passed into this hook is always IFNAMSIZ which is 16. >> >> Code savings on x86_64: >> >> add/remove: 0/0 grow/shrink: 1/9

Re: [PATCH v2] net/core: Fix BUG to BUG_ON conditionals.

2017-10-08 Thread David Miller
From: Tim Hansen Date: Sun, 8 Oct 2017 16:03:38 -0400 > Mistakenly sent the patch previously with a missing semicolon. > Apologies. > > Fix BUG() calls to use BUG_ON(conditional) macros. > > This was found using make coccicheck M=net/core on linux next > tag

Re: [PATCH] net: ethernet: stmmac: Clean up dead code

2017-10-08 Thread David Miller
From: Christos Gkekas Date: Sun, 8 Oct 2017 20:13:49 +0100 > Many macros in dwmac-ipq806x are unused and should be removed. > Moreover gmac->id is an unsigned variable and therefore checking > whether it is less than zero is redundant. > > Signed-off-by: Christos Gkekas

Re: [PATCH v2 net-next 06/12] qed: Add LL2 slowpath handling

2017-10-08 Thread David Miller
From: "Kalderon, Michal" Date: Tue, 3 Oct 2017 18:05:32 + > From: David Miller > Sent: Tuesday, October 3, 2017 8:17 PM >>> @@ -423,6 +423,41 @@ static void qed_ll2_rxq_parse_reg(struct qed_hwfn >>> *p_hwfn, >>> } >>> >>> static int >>>

[PATCH net-next 0/2] net: defer cgroups init to accept()

2017-10-08 Thread Eric Dumazet
After TCP 3WHS became lockless, we should not attempt cgroup games from sk_clone_lock() since listener/cgroup might be already gone. Move this business to inet_csk_accept() where we have the guarantee both parent and child exist. Many thanks to John Sperbeck for spotting these issues Eric

[PATCH net-next 2/2] net: defer call to cgroup_sk_alloc()

2017-10-08 Thread Eric Dumazet
sk_clone_lock() might run while TCP/DCCP listener already vanished. In order to prevent use after free, it is better to defer cgroup_sk_alloc() to the point we know both parent and child exist, and from process context. Fixes: e994b2f0fb92 ("tcp: do not lock listener to process SYN packets")

[PATCH net-next 1/2] net: memcontrol: defer call to mem_cgroup_sk_alloc()

2017-10-08 Thread Eric Dumazet
Instead of calling mem_cgroup_sk_alloc() from BH context, it is better to call it from inet_csk_accept() in process context. Not only this removes code in mem_cgroup_sk_alloc(), but it also fixes a bug since listener might have been dismantled and css_get() might cause a use-after-free. Fixes:

Re: [PATCHv2 net-next] openvswitch: Add erspan tunnel support.

2017-10-08 Thread Pravin Shelar
On Wed, Oct 4, 2017 at 5:03 PM, William Tu wrote: > Add erspan netlink interface for OVS. > > Signed-off-by: William Tu > Cc: Pravin B Shelar > --- > v1->v2: remove unnecessary compat code. Looks good to me.

[PATCH v3] lib: fix multiple strlcpy definition

2017-10-08 Thread Baruch Siach
Some C libraries, like uClibc and musl, provide BSD compatible strlcpy(). Add check_strlcpy() to configure, and avoid defining strlcpy and strlcat when the C library provides them. This fixes the following static link error with uClibc-ng: .../sysroot/usr/lib/libc.a(strlcpy.os): In function

Re: [PATCH 13/14] netfilter/ipvs: Use %pS printk format for direct addresses

2017-10-08 Thread Simon Horman
On Wed, Sep 06, 2017 at 10:28:00PM +0200, Helge Deller wrote: > The debug and error printk functions in ipvs uses wrongly the %pF instead of > the %pS printk format specifier for printing symbols for the address returned > by _builtin_return_address(0). Fix it for the ia64, ppc64 and parisc64 >

Re: [PATCH 10/12] net/mlx4: replace with

2017-10-08 Thread Masahiro Yamada
2017-10-09 3:55 GMT+09:00 Leon Romanovsky : > On Mon, Oct 09, 2017 at 02:29:15AM +0900, Masahiro Yamada wrote: >> 2017-10-09 2:00 GMT+09:00 David Miller : >> > From: Masahiro Yamada >> > Date: Mon, 9 Oct 2017 01:10:11 +0900 >>

Re: [PATCH 10/12] net/mlx4: replace with

2017-10-08 Thread Masahiro Yamada
2017-10-09 2:32 GMT+09:00 Joe Perches : > On Mon, 2017-10-09 at 02:29 +0900, Masahiro Yamada wrote: >> The idea is simple; include necessary headers explicitly. > > Try that for kernel.h > > There's a reason aggregation of #includes is useful. > We should use a common sense for

<    1   2