Re: [PATCH v2] netlink: do not set cb_running if dump's start() errs

On Mon, 2017-10-09 at 14:14 +0200, Jason A. Donenfeld wrote: > It turns out that multiple places can call netlink_dump(), which > means > it's still possible to dereference partially initialized values in > dump() that were the result of a faulty returned start(). > > This fixes the issue by

Re: [PATCH net-next] net: mvpp2: phylink support

Hi Russell, On Mon, Sep 25, 2017 at 11:55:14AM +0200, Antoine Tenart wrote: > On Fri, Sep 22, 2017 at 12:07:31PM +0100, Russell King - ARM Linux wrote: > > On Thu, Sep 21, 2017 at 03:45:22PM +0200, Antoine Tenart wrote: > > > > +static int mvpp2_phylink_mac_link_state(struct net_device *dev, > >

Re: [PATCH 10/13] timer: Remove expires and data arguments from DEFINE_TIMER

On Wed, Oct 04, 2017 at 04:27:04PM -0700, Kees Cook wrote: > Subject: [PATCH 10/13] timer: Remove expires and data arguments from > DEFINE_TIMER > > Drop the arguments from the macro and adjust all callers with the > following script: > > perl -pi -e 's/DEFINE_TIMER\((.*), 0,

Re: [PATCH 2/4] ravb: Add optional PHY reset during system resume

On 10/09/2017 12:37 PM, Sergei Shtylyov wrote: If the optional "reset-gpios" property is specified in DT, the generic MDIO bus code takes care of resetting the PHY during device probe. However, the PHY may still have to be reset explicitly after system resume. This allows to restore Ethernet

[net 2/5] ixgbe: fix masking of bits read from IXGBE_VXLANCTRL register

From: Sabrina Dubroca In ixgbe_clear_udp_tunnel_port(), we read the IXGBE_VXLANCTRL register and then try to mask some bits out of the value, using the logical instead of bitwise and operator. Fixes: a21d0822ff69 ("ixgbe: add support for geneve Rx offload") Signed-off-by:

Re: [PATCH net] net: enable interface alias removal via rtnl

Le 09/10/2017 à 16:02, David Ahern a écrit : > On 10/9/17 2:23 AM, Nicolas Dichtel wrote: >> Le 06/10/2017 à 22:10, Oliver Hartkopp a écrit : >>> >>> >>> On 10/06/2017 08:18 PM, David Ahern wrote: On 10/5/17 4:19 AM, Nicolas Dichtel wrote: > IFLA_IFALIAS is defined as NLA_STRING. It means

[RFC net-next] ppp: allow usage in namespaces

Check for CAP_NET_ADMIN with ns_capable() instead of capable() to allow usage of ppp in user namespace other than the init one. Signed-off-by: Matteo Croce --- drivers/net/ppp/ppp_generic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH net-next] net: mvpp2: phylink support

On Mon, Oct 09, 2017 at 02:55:27PM +0200, Antoine Tenart wrote: > Hi Russell, > > On Mon, Sep 25, 2017 at 11:55:14AM +0200, Antoine Tenart wrote: > > On Fri, Sep 22, 2017 at 12:07:31PM +0100, Russell King - ARM Linux wrote: > > > On Thu, Sep 21, 2017 at 03:45:22PM +0200, Antoine Tenart wrote: > >

Re: [PATCH v2] netfilter: xt_bpf: Fix XT_BPF_MODE_FD_PINNED mode of 'xt_bpf_info_v1'

On Mon, Oct 09, 2017 at 02:35:46PM +0200, Daniel Borkmann wrote: > On 10/09/2017 02:27 PM, Shmulik Ladkani wrote: > >From: Shmulik Ladkani > > > >Commit 2c16d6033264 ("netfilter: xt_bpf: support ebpf") introduced > >support for attaching an eBPF object by an fd, with

Re: [pull request][for-next 0/9] Mellanox, mlx5 updates 2017-10-06

On Fri, 2017-10-06 at 16:37 -0700, Saeed Mahameed wrote: > The following changes since commit > e19b205be43d11bff638cad4487008c48d21c103: > > Linux 4.14-rc2 (2017-09-24 16:38:56 -0700) Thanks for keeping the base at rc2 like I requested. Pulled. -- Doug Ledford GPG

[PATCH v2] net/core: Fix BUG to BUG_ON conditionals.

Fix BUG() calls to use BUG_ON(conditional) macros. This was found using make coccicheck M=net/core on linux next tag next-2017092 Signed-off-by: Tim Hansen --- net/core/skbuff.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git

[PATCH net] udp: fix bcast packet reception

The commit bc044e8db796 ("udp: perform source validation for mcast early demux") does not take into account that broadcast packets lands in the same code path and they need different checks for the source address - notably, zero source address are valid for bcast and invalid for mcast. As a

Re: [PATCH 09/13] timer: Remove users of expire and data arguments to DEFINE_TIMER

On Wed, Oct 04, 2017 at 04:27:03PM -0700, Kees Cook wrote: > Subject: [PATCH 09/13] timer: Remove users of expire and data arguments to > DEFINE_TIMER > > The expire and data arguments of DEFINE_TIMER are only used in two places > and are ignored by the code (malta-display.c only uses

Re: [PATCH net] net: enable interface alias removal via rtnl

On 10/9/17 2:23 AM, Nicolas Dichtel wrote: > Le 06/10/2017 à 22:10, Oliver Hartkopp a écrit : >> >> >> On 10/06/2017 08:18 PM, David Ahern wrote: >>> On 10/5/17 4:19 AM, Nicolas Dichtel wrote: IFLA_IFALIAS is defined as NLA_STRING. It means that the minimal length of the attribute is 1

Re: [PATCH v2] netfilter: xt_bpf: Fix XT_BPF_MODE_FD_PINNED mode of 'xt_bpf_info_v1'

On 10/09/2017 02:27 PM, Shmulik Ladkani wrote: From: Shmulik Ladkani Commit 2c16d6033264 ("netfilter: xt_bpf: support ebpf") introduced support for attaching an eBPF object by an fd, with the 'bpf_mt_check_v1' ABI expecting the '.fd' to be specified upon each

[PATCH net-next] ipv6: avoid zeroing per cpu data again

From: Eric Dumazet per cpu allocations are already zeroed, no need to clear them again. Fixes: d52d3997f843f ("ipv6: Create percpu rt6_info") Signed-off-by: Eric Dumazet Cc: Martin KaFai Lau Cc: Tejun Heo ---

Re: [net-next V5 PATCH 1/5] bpf: introduce new bpf cpu map type BPF_MAP_TYPE_CPUMAP

On 10/09/2017 03:31 PM, Daniel Borkmann wrote: On 10/06/2017 06:12 PM, Jesper Dangaard Brouer wrote: [...] +/* Pre-limit array size based on NR_CPUS, not final CPU check */ +if (cmap->map.max_entries > NR_CPUS) Nit: needs to be >= NR_CPUS. Scratch that comment, you bail out on

[PATCH net-next 1/3] net/mlx4: Fix endianness issue in qp context params

Should take care of the endianness before assigning to params2 field. Fixes: 53f33ae295a5 ("net/mlx4_core: Port aggregation upper layer interface") Signed-off-by: Tariq Toukan --- drivers/net/ethernet/mellanox/mlx4/en_resources.c | 2 +-

[PATCH net-next 3/3] net/mlx4_en: Use __force to fix a sparse warning in TX datapath

In TX data-path, we intentionally do not byte-swap, as documented in code and in the cited commit log. This fixes sparse warning: en_tx.c:720:23: warning: incorrect type in argument 1 (different base types) en_tx.c:720:23:expected unsigned int [unsigned] [usertype] en_tx.c:720:23:got

[PATCH net-next 2/3] net/mlx4_core: Fix cast warning in fw.c

Fix the following SPARSE warning, in MLX4_GET() macro: drivers/net/ethernet/mellanox/mlx4/fw.c:233:9: warning: cast to restricted __be64 Fixes: 17d5ceb6e43e ("net/mlx4_core: Fix unaligned accesses") Signed-off-by: Tariq Toukan --- drivers/net/ethernet/mellanox/mlx4/fw.c |

[PATCH net-next 0/3] Fix mlx4 static checker warnings

Hi Dave, This patchset contains fixes for static checker warnings in the mlx4 Core and Eth drivers. Patch 1 fixes an actual bug discovered by the checker. Patches 2 and 3 fix the warnings without functional changes. Series generated against net-next commit: c49c777f9c87 qed: Delete redundant

[net 4/5] net: ixgbe: Use new PCI_DEV_FLAGS_NO_RELAXED_ORDERING flag

From: Ding Tianhong The ixgbe driver use the compile check to determine if it can send TLPs to Root Port with the Relaxed Ordering Attribute set, this is too inconvenient, now the new flag PCI_DEV_FLAGS_NO_RELAXED_ORDERING has been added to the kernel and we could check

[net 5/5] ixgbe: incorrect XDP ring accounting in ethtool tx_frame param

From: John Fastabend Changing the TX ring parameters with an XDP program attached may cause the XDP queues to be cleared and the TX rings to be incorrectly configured. Fix by doing correct ring accounting in setup call. Fixes: 33fdc82f0883 ("ixgbe: add support for

[net 3/5] Revert commit 1a8b6d76dc5b ("net:add one common config...")

From: Ding Tianhong The new flag PCI_DEV_FLAGS_NO_RELAXED_ORDERING has been added to indicate that Relaxed Ordering Attributes (RO) should not be used for Transaction Layer Packets (TLP) targeted toward these affected Root Port, it will clear the bit4 in the PCIe Device

[net 0/5][pull request] Intel Wired LAN Driver Updates 2017-10-09

This series contains updates to ixgbe and arch/Kconfig. Mark fixes a case where PHY register access is not supported and we were returning a PHY address, when we should have been returning -EOPNOTSUPP. Sabrina Dubroca fixes the use of a logical "and" when it should have been the bitwise "and"

Re: [PATCH net-next] ipv6: avoid zeroing per cpu data again

On Mon, Oct 09, 2017 at 06:01:37AM -0700, Eric Dumazet wrote: > From: Eric Dumazet > > per cpu allocations are already zeroed, no need to clear them again. > > Fixes: d52d3997f843f ("ipv6: Create percpu rt6_info") > Signed-off-by: Eric Dumazet > Cc:

[PATCH] thunderbolt: Initialize Thunderbolt bus earlier

The 0day kbuild robot reports following crash: BUG: unable to handle kernel NULL pointer dereference at 0004 IP: tb_property_find+0xe/0x41 *pde = Oops: [#1] CPU: 0 PID: 1 Comm: swapper Not tainted 4.14.0-rc1-00741-ge69b6c0 #412 Hardware name: QEMU Standard PC (i440FX

Re: [net-next V5 PATCH 1/5] bpf: introduce new bpf cpu map type BPF_MAP_TYPE_CPUMAP

On 10/06/2017 06:12 PM, Jesper Dangaard Brouer wrote: [...] +static struct bpf_map *cpu_map_alloc(union bpf_attr *attr) +{ + struct bpf_cpu_map *cmap; + int err = -ENOMEM; err init here is basically not needed since overriden later anyway w/o being read, but ... + u64 cost;

[net 1/5] ixgbe: Return error when getting PHY address if PHY access is not supported

From: Mark D Rustad In cases where PHY register access is not supported, don't mislead a caller into thinking that it is supported by returning a PHY address. Instead, return -EOPNOTSUPP when PHY access is not supported. Signed-off-by: Mark Rustad

Re: [PATCH net] ipv6: Fix traffic triggered IPsec connections.

From: Steffen Klassert Date: Mon, 9 Oct 2017 08:39:43 +0200 > A recent patch removed the dst_free() on the allocated > dst_entry in ipv6_blackhole_route(). The dst_free() marked > the dst_entry as dead and added it to the gc list. I.e. it > was setup for a one time

Re: [PATCH v3 1/3] net: phy: Remove TI DP83822 from DP83848 driver

On 10/09/2017 05:03 AM, Dan Murphy wrote: > Removing the DP83822 device from the DP83848 to > support the TI DP83822 dedicated driver that will > initially support WoL settings. Hi Dan, The ordering of patch 1 and 2 may have to be reversed, otherwise you are leaving people with the Generic PHY

Re: pull request (net): ipsec 2017-10-09

From: Steffen Klassert Date: Mon, 9 Oct 2017 09:16:35 +0200 > 1) Fix some error paths of the IPsec offloading API. > > 2) Fix a NULL pointer dereference when IPsec is used >with vti. From Alexey Kodanev. > > 3) Don't call xfrm_policy_cache_flush under

Re: pull request: linux-firmware: update cxgb4 firmware

On Wed, 2017-09-27 at 20:54 +0530, Ganesh Goudar wrote: > Hi, > > Kindly pull the new firmware from the following URL. > git://git.chelsio.net/pub/git/linux-firmware.git for-upstream Pulled, thanks. Ben. > Thanks > Ganesh > > The following changes since commit

[PATCH v4 1/2] net: phy: DP83822 initial driver submission

Add support for the TI DP83822 10/100Mbit ethernet phy. The DP83822 provides flexibility to connect to a MAC through a standard MII, RMII or RGMII interface. In addition the DP83822 needs to be removed from the DP83848 driver as the WoL support is added here for this device. Datasheet:

Re: [PATCH 00/12] Netfilter/IPVS fixes for net

From: Pablo Neira Ayuso Date: Mon, 9 Oct 2017 18:25:34 +0200 > The following patchset contains Netfilter/IPVS fixes for your net tree, > they are: ... > You can pull these changes from: > > git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git Pulled, thanks!

Re: [oss-drivers] Re: [PATCH net-next 0/7] nfp: extend match and action for flower offload

On Mon, Oct 09, 2017 at 08:45:41AM -0700, Tom Herbert wrote: > On Mon, Oct 9, 2017 at 1:05 AM, Simon Horman > wrote: > > On Fri, Oct 06, 2017 at 08:34:59AM -0700, Tom Herbert wrote: > >> Simon, > >> > >> Maybe a bit off topic, but I had the impression netronome would

[PATCH 05/12] netfilter: ipset: Fix race between dump and swap

From: Ross Lagerwall Fix a race between ip_set_dump_start() and ip_set_swap(). The race is as follows: * Without holding the ref lock, ip_set_swap() checks ref_netlink of the set and it is 0. * ip_set_dump_start() takes a reference on the set. * ip_set_swap() does

[PATCH 11/12] netfilter: SYNPROXY: skip non-tcp packet in {ipv4, ipv6}_synproxy_hook

From: Lin Zhang In function {ipv4,ipv6}_synproxy_hook we expect a normal tcp packet, but the real server maybe reply an icmp error packet related to the exist tcp conntrack, so we will access wrong tcp data. Fix it by checking for the protocol field and only process tcp

[PATCH net-next v2 2/7] bpf: encapsulate verifier log state into a structure

Put the loose log_* variables into a structure. This will make it simpler to remove the global verifier state in following patches. Signed-off-by: Jakub Kicinski Reviewed-by: Simon Horman Acked-by: Alexei Starovoitov

Re: [PATCH] net: thunderx: mark expected switch fall-throughs in nicvf_main()

From: "Gustavo A. R. Silva" Date: Mon, 9 Oct 2017 11:44:53 -0500 > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Cc: Sunil Goutham > Cc: Robert Richter > Cc:

Re: [PATCH net-next 0/2] ipv6: addrlabel: avoid dirtying ip6addrlbl_entry

On Mon, Oct 09, 2017 at 04:52:23PM +, Eric Dumazet wrote: > The refcount on ip6addrlbl_entry is only used to make sure ip6addrlbl_entry > does not disappear while ip6addrlbl_get() is allocating an skb. > > We can instead allocate skb first, then use RCU, so that we no longer need > to

[PATCH 07/12] netfilter: ebtables: fix race condition in frame_filter_net_init()

From: Artem Savkov It is possible for ebt_in_hook to be triggered before ebt_table is assigned resulting in a NULL-pointer dereference. Make sure hooks are registered as the last step. Fixes: aee12a0a3727 ("ebtables: remove nf_hook_register usage") Signed-off-by: Artem

Re: [PATCH linux-firmware 1/1] qed: Add firmware 8.30.16.0

On Wed, 2017-09-13 at 03:46 -0700, Rahul Verma wrote: > The new qed firmware contains fixes to firmware and added > support for new features, > -Add UFP support. > -DCQCN support for unlimited number of QP > -Add IP type to GFT filter profile. > -Added new TCP function counters. > -Support flow ID

[PATCH net-next v2 0/7] bpf: get rid of global verifier state and reuse instruction printer

Hi! This set started off as simple extraction of eBPF verifier's instruction printer into a separate file but evolved into removal of global state. The purpose of moving instruction printing code is to be able to reuse it from the bpftool. As far as the global verifier lock goes, this set

[PATCH net-next v2 3/7] bpf: move global verifier log into verifier environment

The biggest piece of global state protected by the verifier lock is the verifier_log. Move that log to struct bpf_verifier_env. struct bpf_verifier_env has to be passed now to all invocations of verbose(). Signed-off-by: Jakub Kicinski Reviewed-by: Simon Horman

Re: [PATCH net] udp: fix bcast packet reception

From: Paolo Abeni Date: Mon, 9 Oct 2017 14:52:10 +0200 > The commit bc044e8db796 ("udp: perform source validation for > mcast early demux") does not take into account that broadcast packets > lands in the same code path and they need different checks for the > source address

Re: [PATCH v2] netlink: do not set cb_running if dump's start() errs

From: "Jason A. Donenfeld" Date: Mon, 9 Oct 2017 14:14:51 +0200 > It turns out that multiple places can call netlink_dump(), which means > it's still possible to dereference partially initialized values in > dump() that were the result of a faulty returned start(). > > This

Re: [PATCH] nfp: convert nfp_eth_set_bit_config() into a macro

El Wed, Oct 04, 2017 at 07:13:26PM -0700 Manoj Gupta ha dit: > On Wed, Oct 4, 2017 at 7:06 PM, Jakub Kicinski > wrote: > > On Wed, 4 Oct 2017 18:50:04 -0700, Manoj Gupta wrote: > >> On Wed, Oct 4, 2017 at 5:56 PM, Jakub Kicinski wrote: > >> > On Wed, 4 Oct 2017

Re: [PATCH net-next] ipv6: avoid zeroing per cpu data again

From: Eric Dumazet Date: Mon, 09 Oct 2017 06:01:37 -0700 > From: Eric Dumazet > > per cpu allocations are already zeroed, no need to clear them again. > > Fixes: d52d3997f843f ("ipv6: Create percpu rt6_info") > Signed-off-by: Eric Dumazet

Re: [PATCH net-next 0/7] nfp: extend match and action for flower offload

On Mon, Oct 9, 2017 at 1:05 AM, Simon Horman wrote: > On Fri, Oct 06, 2017 at 08:34:59AM -0700, Tom Herbert wrote: >> Simon, >> >> Maybe a bit off topic, but I had the impression netronome would >> support BPF so that filters could be programmed for arbitrary >>

[PATCH 00/12] Netfilter/IPVS fixes for net

Hi David, The following patchset contains Netfilter/IPVS fixes for your net tree, they are: 1) Fix packet drops due to incorrect ECN handling in IPVS, from Vadim Fedorenko. 2) Fix splat with mark restoration in xt_socket with non-full-sock, patch from Subash Abhinov Kasiviswanathan. 3)

Re: [PATCH v2] netlink: do not set cb_running if dump's start() errs

On Mon, Oct 9, 2017 at 2:31 PM, Johannes Berg wrote: > > Reviewed-by: Johannes Berg Thanks for the review. Hopefully this can make it into 4.13.6 and 4.14-rc5.

[PATCH] net: thunderx: mark expected switch fall-throughs in nicvf_main()

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Cc: Sunil Goutham Cc: Robert Richter Cc: linux-arm-ker...@lists.infradead.org Cc: netdev@vger.kernel.org Signed-off-by: Gustavo A. R. Silva

Re: [PATCH v3 net-next 00/12] qed: Add iWARP support for unaligned MPA packets

From: Michal Kalderon Date: Mon, 9 Oct 2017 12:37:42 +0300 > This patch series adds support for handling unaligned MPA packets. > (FPDUs split over more than one tcp packet). > When FW detects a packet is unaligned it fowards the packet to > the driver via a light l2

Re: [net 0/5][pull request] Intel Wired LAN Driver Updates 2017-10-09

From: Jeff Kirsher Date: Mon, 9 Oct 2017 08:12:46 -0700 > This series contains updates to ixgbe and arch/Kconfig. Pulled, thanks Jeff.

Re: [PATCH v2] isdn/gigaset: Convert timers to use timer_setup()

On Mon, Oct 9, 2017 at 2:15 AM, David Laight wrote: > From: Kees Cook >> Sent: 06 October 2017 20:40 > ... >> I'm in no rush for any specific change. There are about 900 call sites >> I'm making my way through, about 2/3rd are pretty trivial, and the >> less obvious is

[PATCH 03/12] netfilter: ipset: Fix adding an IPv4 range containing more than 2^31 addresses

From: Jozsef Kadlecsik Wrong comparison prevented the hash types to add a range with more than 2^31 addresses but reported as a success. Fixes Netfilter's bugzilla id #1005, reported by Oleg Serditov and Oliver Ford. Signed-off-by: Jozsef Kadlecsik

[PATCH 08/12] netfilter: nf_tables: Release memory obtained by kasprintf

From: Arvind Yadav Free memory region, if nf_tables_set_alloc_name is not successful. Fixes: 387454901bd6 ("netfilter: nf_tables: Allow set names of up to 255 chars") Signed-off-by: Arvind Yadav Signed-off-by: Pablo Neira Ayuso

RE: [PATCH v3 2/3] net: phy: DP83822 initial driver submission

> Subject: [PATCH v3 2/3] net: phy: DP83822 initial driver submission > > Add support for the TI DP83822 10/100Mbit ethernet phy. > > The DP83822 provides flexibility to connect to a MAC through a > standard MII, RMII or RGMII interface. > > Datasheet: >

Re: [net-next 14/15] i40e: ignore skb->xmit_more when deciding to set RS bit

On Mon, Oct 9, 2017 at 2:07 AM, David Laight wrote: > From: Jeff Kirsher >> Sent: 06 October 2017 18:57 >> From: Jacob Keller >> >> Since commit 6a7fded776a7 ("i40e: Fix RS bit update in Tx path and >> disable force WB workaround") we've tried

[PATCH 10/12] netfilter: x_tables: avoid stack-out-of-bounds read in xt_copy_counters_from_user

From: Eric Dumazet syzkaller reports an out of bound read in strlcpy(), triggered by xt_copy_counters_from_user() Fix this by using memcpy(), then forcing a zero byte at the last position of the destination, as Florian did for the non COMPAT code. Fixes: d7591f0c41ce

[PATCH 09/12] netfilter: nf_tables: do not dump chain counters if not enabled

Chain counters are only enabled on demand since 9f08ea848117, skip them when dumping them via netlink. Fixes: 9f08ea848117 ("netfilter: nf_tables: keep chain counters away from hot path") Reported-by: Johny Mattsson Tested-by: Johny Mattsson

[PATCH 06/12] netfilter: nf_tables: fix update chain error

From: JingPiao Chen # nft add table filter # nft add chain filter c1 # nft rename chain filter c1 c2 Error: Could not process rule: No such file or directory rename chain filter c1 c2 ^^ # nft add chain filter c2 # nft rename chain filter c1

[PATCH 02/12] netfilter: xt_socket: Restore mark from full sockets only

From: Subash Abhinov Kasiviswanathan An out of bounds error was detected on an ARM64 target with Android based kernel 4.9. This occurs while trying to restore mark on a skb from an inet request socket. BUG: KASAN: slab-out-of-bounds in socket_match.isra.2+0xc8/0x1f0

[PATCH 04/12] netfilter: ipset: pernet ops must be unregistered last

From: Florian Westphal Removing the ipset module leaves a small window where one cpu performs module removal while another runs a command like 'ipset flush'. ipset uses net_generic(), unregistering the pernet ops frees this storage area. Fix it by first removing the

[PATCH 01/12] netfilter: ipvs: full-functionality option for ECN encapsulation in tunnel

From: Vadim Fedorenko IPVS tunnel mode works as simple tunnel (see RFC 3168) copying ECN field to outer header. That's result in packet drops on egress tunnels in case the egress tunnel operates as ECN-capable with Full-functionality option (like ip_tunnel and

Re: [PATCH net-next] ipv6: avoid zeroing per cpu data again

On Mon, Oct 09, 2017 at 01:01:37PM +, Eric Dumazet wrote: > From: Eric Dumazet > > per cpu allocations are already zeroed, no need to clear them again. > > Fixes: d52d3997f843f ("ipv6: Create percpu rt6_info") > Signed-off-by: Eric Dumazet > Cc:

Re: [PATCH net] ipv4: Fix traffic triggered IPsec connections.

From: Steffen Klassert Date: Mon, 9 Oct 2017 08:43:55 +0200 > A recent patch removed the dst_free() on the allocated > dst_entry in ipv4_blackhole_route(). The dst_free() marked the > dst_entry as dead and added it to the gc list. I.e. it was setup > for a one time

Re: [PATCH v3 3/3] net: phy: Change error to EINVAL for invalid MAC

On 10/09/2017 05:03 AM, Dan Murphy wrote: > Change the return error code to EINVAL if the MAC > address is not valid in the set_wol function. Looks fine to me, since you are respining, do you mind using "net: phy: at803x: Change error to EINVAL for invalid MAC" as a subject to further specify

Re: [PATCH v3 1/3] net: phy: Remove TI DP83822 from DP83848 driver

Florian On 10/09/2017 11:44 AM, Florian Fainelli wrote: > On 10/09/2017 05:03 AM, Dan Murphy wrote: >> Removing the DP83822 device from the DP83848 to >> support the TI DP83822 dedicated driver that will >> initially support WoL settings. > Hi Dan, > > The ordering of patch 1 and 2 may have to

Re: [PATCH 0/4] RCU: introduce noref debug

On Fri, 2017-10-06 at 09:34 -0700, Paul E. McKenney wrote: > On Fri, Oct 06, 2017 at 05:10:09PM +0200, Paolo Abeni wrote: > > Hi, > > > > On Fri, 2017-10-06 at 06:34 -0700, Paul E. McKenney wrote: > > > On Fri, Oct 06, 2017 at 02:57:45PM +0200, Paolo Abeni wrote: > > > > The networking subsystem

Re: pull-request: mac80211 2017-10-09

From: Johannes Berg Date: Mon, 9 Oct 2017 09:40:12 +0200 > The QCA folks found another netlink problem - we were missing validation > of some attributes. It's not super problematic since one can only read a > few bytes beyond the message (and that memory must exist),

[PATCH net-next 0/2] ipv6: addrlabel: avoid dirtying ip6addrlbl_entry

The refcount on ip6addrlbl_entry is only used to make sure ip6addrlbl_entry does not disappear while ip6addrlbl_get() is allocating an skb. We can instead allocate skb first, then use RCU, so that we no longer need to refcount these structures. Eric Dumazet (2): ipv6: addrlabel: rework

[PATCH net-next 2/2] ipv6: addrlabel: remove refcounting

After previous patch ("ipv6: addrlabel: rework ip6addrlbl_get()") we can remove the refcount from struct ip6addrlbl_entry, since it is no longer elevated in p6addrlbl_get() Signed-off-by: Eric Dumazet --- net/ipv6/addrlabel.c | 33 - 1 file

[PATCH net-next 1/2] ipv6: addrlabel: rework ip6addrlbl_get()

If we allocate skb before the lookup, we can use RCU without the need of ip6addrlbl_hold() This means that the following patch can get rid of refcounting. Signed-off-by: Eric Dumazet --- net/ipv6/addrlabel.c | 36 +--- 1 file changed, 13

Re: Fw: [Bug 197099] New: Kernel panic in interrupt [l2tp_ppp]

On Tue, Oct 03, 2017 at 08:27:32AM +0100, James Chapman wrote: > On 2 October 2017 at 19:35, SviMik wrote: > > Hi, James! > > > > No, I'm suffering from kernel panics since I started using 4.x > > kernels. > It's interesting that you are seeing l2tp issues since switching to >

Re: [PATCH v2] net/core: Fix BUG to BUG_ON conditionals.

On Mon, Oct 09, 2017 at 11:37:59AM -0400, Tim Hansen wrote: > Fix BUG() calls to use BUG_ON(conditional) macros. > > This was found using make coccicheck M=net/core on linux next > tag next-2017092 > > Signed-off-by: Tim Hansen > --- > net/core/skbuff.c | 15

Re: [PATCH net-next 0/3] Fix mlx4 static checker warnings

From: Tariq Toukan Date: Mon, 9 Oct 2017 16:59:47 +0300 > This patchset contains fixes for static checker warnings > in the mlx4 Core and Eth drivers. > > Patch 1 fixes an actual bug discovered by the checker. > Patches 2 and 3 fix the warnings without functional changes.

[PATCH 12/12] netfilter: xt_bpf: Fix XT_BPF_MODE_FD_PINNED mode of 'xt_bpf_info_v1'

From: Shmulik Ladkani Commit 2c16d6033264 ("netfilter: xt_bpf: support ebpf") introduced support for attaching an eBPF object by an fd, with the 'bpf_mt_check_v1' ABI expecting the '.fd' to be specified upon each IPT_SO_SET_REPLACE call. However this breaks subsequent

Re: [PATCH] net/mlx4_core: Convert timers to use timer_setup()

On Wed, 2017-10-04 at 17:51 -0700, Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list > pointer to > all timer callbacks, switch to using the new timer_setup() and > from_timer() > to pass the timer pointer explicitly. > > Cc: Tariq Toukan >

Re: [PATCH net-next 0/7] A few cleanup for hns3 ethernet driver

From: Yunsheng Lin Date: Mon, 9 Oct 2017 15:43:54 +0800 > This patchset contains a few cleanup for hns3 ethernet driver. > No functional change intended. Series applied, thank you.

Re: [PATCH net-next 00/15] nfp: bpf ABIv2 and multi port

From: Jakub Kicinski Date: Sun, 8 Oct 2017 21:04:02 -0700 > This series migrates our eBPF offload from old PoC firmware to > a redesigned, faster and more feature rich FW. Marking support > is dropped for now. We have to teach the JIT about encoding > local

[PATCH v4 2/2] net: phy: at803x: Change error to EINVAL for invalid MAC

Change the return error code to EINVAL if the MAC address is not valid in the set_wol function. Signed-off-by: Dan Murphy --- v4 - Updated $subject to include the part number - https://www.mail-archive.com/netdev@vger.kernel.org/msg192424.html v3 - No changes made v2 - There was

Re: [PATCH net-next] ipv6: fix a BUG in rt6_get_pcpu_route()

On Mon, Oct 09, 2017 at 04:07:18AM +, Eric Dumazet wrote: > From: Eric Dumazet > > Ido reported following splat and provided a patch. > > [ 122.221814] BUG: using smp_processor_id() in preemptible [] code: > sshd/2672 > [ 122.221845] caller is

Re: [patch net-next v2 0/5] mlxsw: Offload bridge device mrouter

From: Jiri Pirko Date: Mon, 9 Oct 2017 11:15:30 +0200 > From: Jiri Pirko > > Yotam says: > > Similarly to a bridged port, the bridge device itself can be configured by > the user to be an mrouter port. In this case, all multicast traffic should > be

[PATCH net-next v2 7/7] bpf: write back the verifier log buffer as it gets filled

Verifier log buffer can be quite large (up to 16MB currently). As Eric Dumazet points out if we allow multiple verification requests to proceed simultaneously, malicious user may use the verifier as a way of allocating large amounts of unswappable memory to OOM the host. Switch to a strategy of

[PATCH net-next v2 6/7] bpf: don't rely on the verifier lock for metadata_dst allocation

bpf_skb_set_tunnel_*() functions require allocation of per-cpu metadata_dst. The allocation happens upon verification of the first program using those helpers. In preparation for removing the verifier lock, use cmpxchg() to make sure we only allocate the metadata_dsts once. Signed-off-by: Jakub

[PATCH net-next v2 4/7] bpf: move instruction printing into a separate file

Separate the instruction printing into a standalone source file. This way sneaky code from tools/ can compile it in directly. Signed-off-by: Jakub Kicinski Reviewed-by: Simon Horman Acked-by: Alexei Starovoitov

[PATCH net-next v2 5/7] tools: bpftool: use the kernel's instruction printer

Compile the instruction printer from kernel/bpf and use it for disassembling "translated" eBPF code. Signed-off-by: Jakub Kicinski Reviewed-by: Simon Horman Acked-by: Alexei Starovoitov Acked-by: Daniel Borkmann

[PATCH net-next v2 1/7] selftests/bpf: add a test for verifier logs

Add a test for verifier log handling. Check bad attr combinations but focus on cases when log is truncated. Signed-off-by: Jakub Kicinski Reviewed-by: Simon Horman Acked-by: Alexei Starovoitov Acked-by: Daniel Borkmann

Re: [net PATCH] macvlan: Only deliver one copy of the frame to the macvlan interface

On Sun, Oct 8, 2017 at 6:07 PM, Eric Dumazet wrote: > On Sun, 2017-10-08 at 15:54 -0700, Alexander Duyck wrote: >> From: Alexander Duyck >> >> This patch intoduces a slight adjustment for macvlan to address the fact >> that in source mode I

Re: [PATCH] thunderbolt: Initialize Thunderbolt bus earlier

From: Mika Westerberg Date: Mon, 9 Oct 2017 16:22:34 +0300 > The 0day kbuild robot reports following crash: ... > The reason is that both Thunderbolt bus and thunderbolt-net are build > into the kernel image, and the latter is linked first because > drivers/net

Re: [PATCH net-next 0/2] ipv6: addrlabel: avoid dirtying ip6addrlbl_entry

From: Martin KaFai Lau Date: Mon, 9 Oct 2017 10:44:17 -0700 > On Mon, Oct 09, 2017 at 04:52:23PM +, Eric Dumazet wrote: >> The refcount on ip6addrlbl_entry is only used to make sure ip6addrlbl_entry >> does not disappear while ip6addrlbl_get() is allocating an skb. >> >> We

Re: [net-next V5 PATCH 1/5] bpf: introduce new bpf cpu map type BPF_MAP_TYPE_CPUMAP

On Mon, 09 Oct 2017 15:31:21 +0200 Daniel Borkmann wrote: > On 10/06/2017 06:12 PM, Jesper Dangaard Brouer wrote: > [...] > > +static struct bpf_map *cpu_map_alloc(union bpf_attr *attr) > > +{ > > + struct bpf_cpu_map *cmap; > > + int err = -ENOMEM; > > err init here

Re: [net PATCH] macvlan: Only deliver one copy of the frame to the macvlan interface

On Mon, Oct 9, 2017 at 10:30 AM, Alexander Duyck wrote: > On Sun, Oct 8, 2017 at 6:07 PM, Eric Dumazet wrote: >> On Sun, 2017-10-08 at 15:54 -0700, Alexander Duyck wrote: >>> From: Alexander Duyck >>> >>> This patch

Re: [PATCH] net: can: Convert timers to use timer_setup()

On Mon, Oct 9, 2017 at 10:53 AM, Marc Kleine-Budde wrote: > On 10/05/2017 02:51 AM, Kees Cook wrote: >> In preparation for unconditionally passing the struct timer_list pointer to >> all timer callbacks, switch to using the new timer_setup() and from_timer() >> to pass the

[net-next 08/10] ixgbe: fix the FWSM.PT check in ixgbe_mng_present()

From: Emil Tantilov Bits other than FWSM.PT can be set in IXGBE_SWFW_MODE_MASK making the previous check invalid. Change the check for MNG present to be only based on FWSM.PT bit. Signed-off-by: Emil Tantilov Tested-by: Andrew Bowers

[net-next 05/10] ixgbe: split Tx/Rx ring clearing for ethtool loopback test

From: Emil Tantilov Commit: fed21bcee7a5 ("ixgbe: Don't bother clearing buffer memory for descriptor rings) exposed some issues with the logic in the current implementation of ixgbe_clean_test_rings() that are being addressed in this patch: - Split the clearing of

RE: [PATCH v1 RFC 1/7] Replace license with GPL

> From: tristram...@microchip.com > > Sent: 06 October 2017 21:33 > > Replace license with GPL. > > Don't you need permission from all the people who have updated > the files in order to make this change? > > David I am a little confused by your comment. The 4 original KSZ9477 DSA driver

[net-next 02/10] ixgbe: declare ixgbe_mac_operations structures as const

From: Bhumika Goyal Declare ixgbe_mac_operations structures as const as they are only stored in the mac_ops field of ixgbe_info structure. This field is of type const and therefore ixgbe_mac_operations structure can be made const too. Signed-off-by: Bhumika Goyal

  1   2   3   >