[net-next 08/10] ixgbe: fix the FWSM.PT check in ixgbe_mng_present()

2017-10-09 Thread Jeff Kirsher
From: Emil Tantilov Bits other than FWSM.PT can be set in IXGBE_SWFW_MODE_MASK making the previous check invalid. Change the check for MNG present to be only based on FWSM.PT bit. Signed-off-by: Emil Tantilov Tested-by: Andrew Bowers

[net-next 05/10] ixgbe: split Tx/Rx ring clearing for ethtool loopback test

2017-10-09 Thread Jeff Kirsher
From: Emil Tantilov Commit: fed21bcee7a5 ("ixgbe: Don't bother clearing buffer memory for descriptor rings) exposed some issues with the logic in the current implementation of ixgbe_clean_test_rings() that are being addressed in this patch: - Split the clearing of

[net-next 06/10] ixgbe: add counter for times Rx pages gets allocated, not recycled

2017-10-09 Thread Jeff Kirsher
From: Jesper Dangaard Brouer The ixgbe driver have page recycle scheme based around the RX-ring queue, where a RX page is shared between two packets. Based on the refcnt, the driver can determine if the RX-page is currently only used by a single packet, if so it can then

[net-next 07/10] ixgbe: fix use of uninitialized padding

2017-10-09 Thread Jeff Kirsher
From: Emil Tantilov This patch is resolving Coverity hits where padding in a structure could be used uninitialized. - Initialize fwd_cmd.pad/2 before ixgbe_calculate_checksum() - Initialize buffer.pad2/3 before ixgbe_hic_unlocked() Signed-off-by: Emil Tantilov

[net-next 01/10] ixgbe: Clear SWFW_SYNC register during init

2017-10-09 Thread Jeff Kirsher
From: Emil Tantilov Added clearing of SW resource bits in the SW/FW synchronization register to ixgbe_init_swfw_sync_X540(). Updated ixgbe_acquire_swfw_sync_X540 SW Manageability host interface resource bit error case to match the error handling of the other SW

[net-next 10/10] ixgbe: fix crash when injecting AER after failed reset

2017-10-09 Thread Jeff Kirsher
From: Emil Tantilov In case where AER recovery fails the device is left in a down state. Consecutive AER error injection can lead to a double IRQ free. Signed-off-by: Emil Tantilov Tested-by: Andrew Bowers

[net-next 09/10] ixgbe: Update adaptive ITR algorithm

2017-10-09 Thread Jeff Kirsher
From: Alexander Duyck The following change is meant to update the adaptive ITR algorithm to better support the needs of the network. Specifically with this change what I have done is make it so that our ITR algorithm will try to prevent either starving a socket

[net-next 00/10][pull request] 10GbE Intel Wired LAN Driver Updates 2017-10-09

2017-10-09 Thread Jeff Kirsher
This series contains updates to ixgbe only. Emil fixes an issue where the semaphore bits could be stuck after a reset or a crash, by adding the clearing of software resource bits in the software/firmware synchronization register. Added error checks when we attempt to identify and initialize the

[net-next 04/10] ixgbe: add error checks when initializing the PHY

2017-10-09 Thread Jeff Kirsher
From: Emil Tantilov Ignoring errors when attempting to identify the PHY can lead to a crash. Specifically in the case of FW controlled PHYs where the PHY read/write operations are set to NULL. Removed redundant comment. Signed-off-by: Emil Tantilov

[net-next 03/10] ixgbe: restore normal RSS after last macvlan offload is removed

2017-10-09 Thread Jeff Kirsher
From: Shannon Nelson Just like when the last VF is removed, we need to restore normal operations after the last macvlan offload is removed, else we get stuck in single queue operations. To test: ethtool -l eth1 # note the number of queues in use, ~= cpus ethtool -K

linux-next: manual merge of the cgroup tree with the net-next tree

2017-10-09 Thread Mark Brown
Hi Tejun, Today's linux-next merge of the cgroup tree got a conflict in: kernel/cgroup/cgroup.c between commit: 324bda9e6c5ad ("bpf: multi program support for cgroup+bpf") from the net-next tree and commit: 041cd640b2f3c ("cgroup: Implement cgroup2 basic CPU usage accounting") from

RE: [PATCH v1 RFC 1/1] Add Microchip KSZ8795 DSA driver

2017-10-09 Thread Tristram.Ha
> in previous version I see that transit traffic (ping) goes to cpu, > then from cpu back to destination port. I.e. it works but with cpu > involving. Is this version supposed to work like that? Yes, it works in the old DSA way such that a software bridge is responsible to forward every packet.

Re: [PATCH] net: can: Convert timers to use timer_setup()

2017-10-09 Thread Marc Kleine-Budde
On 10/09/2017 08:09 PM, Kees Cook wrote: > On Mon, Oct 9, 2017 at 10:53 AM, Marc Kleine-Budde > wrote: >> On 10/05/2017 02:51 AM, Kees Cook wrote: >>> In preparation for unconditionally passing the struct timer_list pointer to >>> all timer callbacks, switch to using the new

Re: [PATCH] net: can: Convert timers to use timer_setup()

2017-10-09 Thread Kees Cook
On Mon, Oct 9, 2017 at 10:53 AM, Marc Kleine-Budde wrote: > On 10/05/2017 02:51 AM, Kees Cook wrote: >> In preparation for unconditionally passing the struct timer_list pointer to >> all timer callbacks, switch to using the new timer_setup() and from_timer() >> to pass the

net-next: WARNING: CPU: 0 PID: 1544 at net/ipv4/tcp_input.c:889

2017-10-09 Thread Andrei Vagin
Hello, We run CRIU tests on a daily basis for net-next and today they triggered a following warning: [ 58.827039] [ cut here ] [ 58.827078] WARNING: CPU: 0 PID: 1544 at net/ipv4/tcp_input.c:889 tcp_update_reordering+0x9f/0xb0 [ 58.827083] Modules linked in: [

Re: [net-next V5 PATCH 1/5] bpf: introduce new bpf cpu map type BPF_MAP_TYPE_CPUMAP

2017-10-09 Thread Jesper Dangaard Brouer
On Mon, 09 Oct 2017 15:31:21 +0200 Daniel Borkmann wrote: > On 10/06/2017 06:12 PM, Jesper Dangaard Brouer wrote: > [...] > > +static struct bpf_map *cpu_map_alloc(union bpf_attr *attr) > > +{ > > + struct bpf_cpu_map *cmap; > > + int err = -ENOMEM; > > err init here

linux-next: manual merge of the drivers-x86 tree with the net-next tree

2017-10-09 Thread Mark Brown
Hi Darren, [Apologies for multiple copies - for some reason vger seems to eat mails I send from scripts, still trying to figure this out] Today's linux-next merge of the drivers-x86 tree got a conflict in: Documentation/admin-guide/thunderbolt.rst between commit: e69b6c02b4c3b ("net: Add

usb/net/ar5523: warning in ar5523_submit_rx_cmd/usb_submit_urb

2017-10-09 Thread Andrey Konovalov
Hi! I've got the following report while fuzzing the kernel with syzkaller. On commit 8a5776a5f49812d29fe4b2d0a2d71675c3facf3f (4.14-rc4). It seems that the driver doesn't check the endpoint type provided in the USB descriptor. usb 1-1: BOGUS urb xfer, pipe 3 != type 1 [ cut here

Re: [PATCH] net: can: Convert timers to use timer_setup()

2017-10-09 Thread Marc Kleine-Budde
On 10/05/2017 02:51 AM, Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: Oliver Hartkopp > Cc: Marc

usb/net/ath6kl: GPF in ath6kl_usb_alloc_urb_from_pipe

2017-10-09 Thread Andrey Konovalov
Hi! I've got the following report while fuzzing the kernel with syzkaller. On commit 8a5776a5f49812d29fe4b2d0a2d71675c3facf3f (4.14-rc4). usb 1-1: New USB device found, idVendor=0cf3, idProduct=9375 usb 1-1: New USB device strings: Mfr=2, Product=255, SerialNumber=8 usb 1-1: Product: a usb 1-1:

usb/net/rtlwifi: trying to register non-static key in rtl_c2hcmd_launcher

2017-10-09 Thread Andrey Konovalov
Hi! I've got the following report while fuzzing the kernel with syzkaller. On commit 8a5776a5f49812d29fe4b2d0a2d71675c3facf3f (4.14-rc4). INFO: trying to register non-static key. the code is fine but needs lockdep annotation. turning off the locking correctness validator. CPU: 0 PID: 24 Comm:

usb/irda: global-out-of-bounds in irda_qos_bits_to_value

2017-10-09 Thread Andrey Konovalov
Hi! I've got the following report while fuzzing the kernel with syzkaller. On commit 8a5776a5f49812d29fe4b2d0a2d71675c3facf3f (4.14-rc4). It seems that qos->baud_rate.bits value is taken from USB descriptor and then used as a array index without any checks.

usb/net/rt2x00: warning in rt2800_eeprom_word_index

2017-10-09 Thread Andrey Konovalov
Hi! I've got the following report while fuzzing the kernel with syzkaller. On commit 8a5776a5f49812d29fe4b2d0a2d71675c3facf3f (4.14-rc4). I'm not sure whether this is a bug in the driver, or just a way to report misbehaving device. In the latter case this shouldn't be a WARN() call, since

Re: [net PATCH] macvlan: Only deliver one copy of the frame to the macvlan interface

2017-10-09 Thread Alexander Duyck
On Mon, Oct 9, 2017 at 10:30 AM, Alexander Duyck wrote: > On Sun, Oct 8, 2017 at 6:07 PM, Eric Dumazet wrote: >> On Sun, 2017-10-08 at 15:54 -0700, Alexander Duyck wrote: >>> From: Alexander Duyck >>> >>> This patch

Re: [PATCH net-next 0/2] ipv6: addrlabel: avoid dirtying ip6addrlbl_entry

2017-10-09 Thread David Miller
From: Martin KaFai Lau Date: Mon, 9 Oct 2017 10:44:17 -0700 > On Mon, Oct 09, 2017 at 04:52:23PM +, Eric Dumazet wrote: >> The refcount on ip6addrlbl_entry is only used to make sure ip6addrlbl_entry >> does not disappear while ip6addrlbl_get() is allocating an skb. >> >> We

Re: [PATCH net-next 0/2] ipv6: addrlabel: avoid dirtying ip6addrlbl_entry

2017-10-09 Thread Martin KaFai Lau
On Mon, Oct 09, 2017 at 04:52:23PM +, Eric Dumazet wrote: > The refcount on ip6addrlbl_entry is only used to make sure ip6addrlbl_entry > does not disappear while ip6addrlbl_get() is allocating an skb. > > We can instead allocate skb first, then use RCU, so that we no longer need > to

Re: [PATCH] net: thunderx: mark expected switch fall-throughs in nicvf_main()

2017-10-09 Thread David Miller
From: "Gustavo A. R. Silva" Date: Mon, 9 Oct 2017 11:44:53 -0500 > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Cc: Sunil Goutham > Cc: Robert Richter > Cc:

Re: [PATCH 00/12] Netfilter/IPVS fixes for net

2017-10-09 Thread David Miller
From: Pablo Neira Ayuso Date: Mon, 9 Oct 2017 18:25:34 +0200 > The following patchset contains Netfilter/IPVS fixes for your net tree, > they are: ... > You can pull these changes from: > > git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git Pulled, thanks!

Re: [PATCH v2] isdn/gigaset: Convert timers to use timer_setup()

2017-10-09 Thread Kees Cook
On Mon, Oct 9, 2017 at 2:15 AM, David Laight wrote: > From: Kees Cook >> Sent: 06 October 2017 20:40 > ... >> I'm in no rush for any specific change. There are about 900 call sites >> I'm making my way through, about 2/3rd are pretty trivial, and the >> less obvious is

Re: [net 0/5][pull request] Intel Wired LAN Driver Updates 2017-10-09

2017-10-09 Thread David Miller
From: Jeff Kirsher Date: Mon, 9 Oct 2017 08:12:46 -0700 > This series contains updates to ixgbe and arch/Kconfig. Pulled, thanks Jeff.

Re: [PATCH net-next 0/3] Fix mlx4 static checker warnings

2017-10-09 Thread David Miller
From: Tariq Toukan Date: Mon, 9 Oct 2017 16:59:47 +0300 > This patchset contains fixes for static checker warnings > in the mlx4 Core and Eth drivers. > > Patch 1 fixes an actual bug discovered by the checker. > Patches 2 and 3 fix the warnings without functional changes.

[PATCH net-next v2 2/7] bpf: encapsulate verifier log state into a structure

2017-10-09 Thread Jakub Kicinski
Put the loose log_* variables into a structure. This will make it simpler to remove the global verifier state in following patches. Signed-off-by: Jakub Kicinski Reviewed-by: Simon Horman Acked-by: Alexei Starovoitov

Re: [PATCH] thunderbolt: Initialize Thunderbolt bus earlier

2017-10-09 Thread David Miller
From: Mika Westerberg Date: Mon, 9 Oct 2017 16:22:34 +0300 > The 0day kbuild robot reports following crash: ... > The reason is that both Thunderbolt bus and thunderbolt-net are build > into the kernel image, and the latter is linked first because > drivers/net

Re: [net PATCH] macvlan: Only deliver one copy of the frame to the macvlan interface

2017-10-09 Thread Alexander Duyck
On Sun, Oct 8, 2017 at 6:07 PM, Eric Dumazet wrote: > On Sun, 2017-10-08 at 15:54 -0700, Alexander Duyck wrote: >> From: Alexander Duyck >> >> This patch intoduces a slight adjustment for macvlan to address the fact >> that in source mode I

[PATCH net-next v2 7/7] bpf: write back the verifier log buffer as it gets filled

2017-10-09 Thread Jakub Kicinski
Verifier log buffer can be quite large (up to 16MB currently). As Eric Dumazet points out if we allow multiple verification requests to proceed simultaneously, malicious user may use the verifier as a way of allocating large amounts of unswappable memory to OOM the host. Switch to a strategy of

[PATCH net-next v2 6/7] bpf: don't rely on the verifier lock for metadata_dst allocation

2017-10-09 Thread Jakub Kicinski
bpf_skb_set_tunnel_*() functions require allocation of per-cpu metadata_dst. The allocation happens upon verification of the first program using those helpers. In preparation for removing the verifier lock, use cmpxchg() to make sure we only allocate the metadata_dsts once. Signed-off-by: Jakub

[PATCH net-next v2 5/7] tools: bpftool: use the kernel's instruction printer

2017-10-09 Thread Jakub Kicinski
Compile the instruction printer from kernel/bpf and use it for disassembling "translated" eBPF code. Signed-off-by: Jakub Kicinski Reviewed-by: Simon Horman Acked-by: Alexei Starovoitov Acked-by: Daniel Borkmann

[PATCH net-next v2 1/7] selftests/bpf: add a test for verifier logs

2017-10-09 Thread Jakub Kicinski
Add a test for verifier log handling. Check bad attr combinations but focus on cases when log is truncated. Signed-off-by: Jakub Kicinski Reviewed-by: Simon Horman Acked-by: Alexei Starovoitov Acked-by: Daniel Borkmann

[PATCH net-next v2 4/7] bpf: move instruction printing into a separate file

2017-10-09 Thread Jakub Kicinski
Separate the instruction printing into a standalone source file. This way sneaky code from tools/ can compile it in directly. Signed-off-by: Jakub Kicinski Reviewed-by: Simon Horman Acked-by: Alexei Starovoitov

[PATCH net-next v2 0/7] bpf: get rid of global verifier state and reuse instruction printer

2017-10-09 Thread Jakub Kicinski
Hi! This set started off as simple extraction of eBPF verifier's instruction printer into a separate file but evolved into removal of global state. The purpose of moving instruction printing code is to be able to reuse it from the bpftool. As far as the global verifier lock goes, this set

[PATCH net-next v2 3/7] bpf: move global verifier log into verifier environment

2017-10-09 Thread Jakub Kicinski
The biggest piece of global state protected by the verifier lock is the verifier_log. Move that log to struct bpf_verifier_env. struct bpf_verifier_env has to be passed now to all invocations of verbose(). Signed-off-by: Jakub Kicinski Reviewed-by: Simon Horman

Re: [PATCH net-next] ipv6: avoid zeroing per cpu data again

2017-10-09 Thread David Miller
From: Eric Dumazet Date: Mon, 09 Oct 2017 06:01:37 -0700 > From: Eric Dumazet > > per cpu allocations are already zeroed, no need to clear them again. > > Fixes: d52d3997f843f ("ipv6: Create percpu rt6_info") > Signed-off-by: Eric Dumazet

Re: [PATCH] nfp: convert nfp_eth_set_bit_config() into a macro

2017-10-09 Thread Matthias Kaehlcke
El Wed, Oct 04, 2017 at 07:13:26PM -0700 Manoj Gupta ha dit: > On Wed, Oct 4, 2017 at 7:06 PM, Jakub Kicinski > wrote: > > On Wed, 4 Oct 2017 18:50:04 -0700, Manoj Gupta wrote: > >> On Wed, Oct 4, 2017 at 5:56 PM, Jakub Kicinski wrote: > >> > On Wed, 4 Oct 2017

Re: [PATCH v2] netlink: do not set cb_running if dump's start() errs

2017-10-09 Thread David Miller
From: "Jason A. Donenfeld" Date: Mon, 9 Oct 2017 14:14:51 +0200 > It turns out that multiple places can call netlink_dump(), which means > it's still possible to dereference partially initialized values in > dump() that were the result of a faulty returned start(). > > This

Re: [PATCH net] udp: fix bcast packet reception

2017-10-09 Thread David Miller
From: Paolo Abeni Date: Mon, 9 Oct 2017 14:52:10 +0200 > The commit bc044e8db796 ("udp: perform source validation for > mcast early demux") does not take into account that broadcast packets > lands in the same code path and they need different checks for the > source address

Re: [PATCH linux-firmware 1/1] qed: Add firmware 8.30.16.0

2017-10-09 Thread Ben Hutchings
On Wed, 2017-09-13 at 03:46 -0700, Rahul Verma wrote: > The new qed firmware contains fixes to firmware and added > support for new features, > -Add UFP support. > -DCQCN support for unlimited number of QP > -Add IP type to GFT filter profile. > -Added new TCP function counters. > -Support flow ID

Re: [PATCH v3 net-next 00/12] qed: Add iWARP support for unaligned MPA packets

2017-10-09 Thread David Miller
From: Michal Kalderon Date: Mon, 9 Oct 2017 12:37:42 +0300 > This patch series adds support for handling unaligned MPA packets. > (FPDUs split over more than one tcp packet). > When FW detects a packet is unaligned it fowards the packet to > the driver via a light l2

Re: [patch net-next v2 0/5] mlxsw: Offload bridge device mrouter

2017-10-09 Thread David Miller
From: Jiri Pirko Date: Mon, 9 Oct 2017 11:15:30 +0200 > From: Jiri Pirko > > Yotam says: > > Similarly to a bridged port, the bridge device itself can be configured by > the user to be an mrouter port. In this case, all multicast traffic should > be

Re: Fw: [Bug 197099] New: Kernel panic in interrupt [l2tp_ppp]

2017-10-09 Thread Guillaume Nault
On Tue, Oct 03, 2017 at 08:27:32AM +0100, James Chapman wrote: > On 2 October 2017 at 19:35, SviMik wrote: > > Hi, James! > > > > No, I'm suffering from kernel panics since I started using 4.x > > kernels. > It's interesting that you are seeing l2tp issues since switching to >

Re: [PATCH v2] net/core: Fix BUG to BUG_ON conditionals.

2017-10-09 Thread Alexei Starovoitov
On Mon, Oct 09, 2017 at 11:37:59AM -0400, Tim Hansen wrote: > Fix BUG() calls to use BUG_ON(conditional) macros. > > This was found using make coccicheck M=net/core on linux next > tag next-2017092 > > Signed-off-by: Tim Hansen > --- > net/core/skbuff.c | 15

Re: [PATCH net-next] ipv6: fix a BUG in rt6_get_pcpu_route()

2017-10-09 Thread Martin KaFai Lau
On Mon, Oct 09, 2017 at 04:07:18AM +, Eric Dumazet wrote: > From: Eric Dumazet > > Ido reported following splat and provided a patch. > > [ 122.221814] BUG: using smp_processor_id() in preemptible [] code: > sshd/2672 > [ 122.221845] caller is

[PATCH] net: thunderx: mark expected switch fall-throughs in nicvf_main()

2017-10-09 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Cc: Sunil Goutham Cc: Robert Richter Cc: linux-arm-ker...@lists.infradead.org Cc: netdev@vger.kernel.org Signed-off-by: Gustavo A. R. Silva

Re: [PATCH v2] netlink: do not set cb_running if dump's start() errs

2017-10-09 Thread Jason A. Donenfeld
On Mon, Oct 9, 2017 at 2:31 PM, Johannes Berg wrote: > > Reviewed-by: Johannes Berg Thanks for the review. Hopefully this can make it into 4.13.6 and 4.14-rc5.

[PATCH v4 2/2] net: phy: at803x: Change error to EINVAL for invalid MAC

2017-10-09 Thread Dan Murphy
Change the return error code to EINVAL if the MAC address is not valid in the set_wol function. Signed-off-by: Dan Murphy --- v4 - Updated $subject to include the part number - https://www.mail-archive.com/netdev@vger.kernel.org/msg192424.html v3 - No changes made v2 - There was

[PATCH v4 1/2] net: phy: DP83822 initial driver submission

2017-10-09 Thread Dan Murphy
Add support for the TI DP83822 10/100Mbit ethernet phy. The DP83822 provides flexibility to connect to a MAC through a standard MII, RMII or RGMII interface. In addition the DP83822 needs to be removed from the DP83848 driver as the WoL support is added here for this device. Datasheet:

Re: [PATCH 0/4] RCU: introduce noref debug

2017-10-09 Thread Paolo Abeni
On Fri, 2017-10-06 at 09:34 -0700, Paul E. McKenney wrote: > On Fri, Oct 06, 2017 at 05:10:09PM +0200, Paolo Abeni wrote: > > Hi, > > > > On Fri, 2017-10-06 at 06:34 -0700, Paul E. McKenney wrote: > > > On Fri, Oct 06, 2017 at 02:57:45PM +0200, Paolo Abeni wrote: > > > > The networking subsystem

Re: pull-request: mac80211 2017-10-09

2017-10-09 Thread David Miller
From: Johannes Berg Date: Mon, 9 Oct 2017 09:40:12 +0200 > The QCA folks found another netlink problem - we were missing validation > of some attributes. It's not super problematic since one can only read a > few bytes beyond the message (and that memory must exist),

[PATCH net-next 0/2] ipv6: addrlabel: avoid dirtying ip6addrlbl_entry

2017-10-09 Thread Eric Dumazet
The refcount on ip6addrlbl_entry is only used to make sure ip6addrlbl_entry does not disappear while ip6addrlbl_get() is allocating an skb. We can instead allocate skb first, then use RCU, so that we no longer need to refcount these structures. Eric Dumazet (2): ipv6: addrlabel: rework

[PATCH net-next 2/2] ipv6: addrlabel: remove refcounting

2017-10-09 Thread Eric Dumazet
After previous patch ("ipv6: addrlabel: rework ip6addrlbl_get()") we can remove the refcount from struct ip6addrlbl_entry, since it is no longer elevated in p6addrlbl_get() Signed-off-by: Eric Dumazet --- net/ipv6/addrlabel.c | 33 - 1 file

[PATCH net-next 1/2] ipv6: addrlabel: rework ip6addrlbl_get()

2017-10-09 Thread Eric Dumazet
If we allocate skb before the lookup, we can use RCU without the need of ip6addrlbl_hold() This means that the following patch can get rid of refcounting. Signed-off-by: Eric Dumazet --- net/ipv6/addrlabel.c | 36 +--- 1 file changed, 13

Re: [PATCH net-next 00/15] nfp: bpf ABIv2 and multi port

2017-10-09 Thread David Miller
From: Jakub Kicinski Date: Sun, 8 Oct 2017 21:04:02 -0700 > This series migrates our eBPF offload from old PoC firmware to > a redesigned, faster and more feature rich FW. Marking support > is dropped for now. We have to teach the JIT about encoding > local

Re: [PATCH net-next 0/7] A few cleanup for hns3 ethernet driver

2017-10-09 Thread David Miller
From: Yunsheng Lin Date: Mon, 9 Oct 2017 15:43:54 +0800 > This patchset contains a few cleanup for hns3 ethernet driver. > No functional change intended. Series applied, thank you.

Re: pull request: linux-firmware: update cxgb4 firmware

2017-10-09 Thread Ben Hutchings
On Wed, 2017-09-27 at 20:54 +0530, Ganesh Goudar wrote: > Hi, > > Kindly pull the new firmware from the following URL. > git://git.chelsio.net/pub/git/linux-firmware.git for-upstream Pulled, thanks. Ben. > Thanks > Ganesh > > The following changes since commit

Re: [PATCH v3 3/3] net: phy: Change error to EINVAL for invalid MAC

2017-10-09 Thread Florian Fainelli
On 10/09/2017 05:03 AM, Dan Murphy wrote: > Change the return error code to EINVAL if the MAC > address is not valid in the set_wol function. Looks fine to me, since you are respining, do you mind using "net: phy: at803x: Change error to EINVAL for invalid MAC" as a subject to further specify

Re: [PATCH v3 1/3] net: phy: Remove TI DP83822 from DP83848 driver

2017-10-09 Thread Dan Murphy
Florian On 10/09/2017 11:44 AM, Florian Fainelli wrote: > On 10/09/2017 05:03 AM, Dan Murphy wrote: >> Removing the DP83822 device from the DP83848 to >> support the TI DP83822 dedicated driver that will >> initially support WoL settings. > Hi Dan, > > The ordering of patch 1 and 2 may have to

Re: [PATCH v3 1/3] net: phy: Remove TI DP83822 from DP83848 driver

2017-10-09 Thread Florian Fainelli
On 10/09/2017 05:03 AM, Dan Murphy wrote: > Removing the DP83822 device from the DP83848 to > support the TI DP83822 dedicated driver that will > initially support WoL settings. Hi Dan, The ordering of patch 1 and 2 may have to be reversed, otherwise you are leaving people with the Generic PHY

Re: pull request (net): ipsec 2017-10-09

2017-10-09 Thread David Miller
From: Steffen Klassert Date: Mon, 9 Oct 2017 09:16:35 +0200 > 1) Fix some error paths of the IPsec offloading API. > > 2) Fix a NULL pointer dereference when IPsec is used >with vti. From Alexey Kodanev. > > 3) Don't call xfrm_policy_cache_flush under

Re: [PATCH net-next] ipv6: avoid zeroing per cpu data again

2017-10-09 Thread Martin KaFai Lau
On Mon, Oct 09, 2017 at 01:01:37PM +, Eric Dumazet wrote: > From: Eric Dumazet > > per cpu allocations are already zeroed, no need to clear them again. > > Fixes: d52d3997f843f ("ipv6: Create percpu rt6_info") > Signed-off-by: Eric Dumazet > Cc:

Re: [PATCH net] ipv4: Fix traffic triggered IPsec connections.

2017-10-09 Thread David Miller
From: Steffen Klassert Date: Mon, 9 Oct 2017 08:43:55 +0200 > A recent patch removed the dst_free() on the allocated > dst_entry in ipv4_blackhole_route(). The dst_free() marked the > dst_entry as dead and added it to the gc list. I.e. it was setup > for a one time

Re: [PATCH net] ipv6: Fix traffic triggered IPsec connections.

2017-10-09 Thread David Miller
From: Steffen Klassert Date: Mon, 9 Oct 2017 08:39:43 +0200 > A recent patch removed the dst_free() on the allocated > dst_entry in ipv6_blackhole_route(). The dst_free() marked > the dst_entry as dead and added it to the gc list. I.e. it > was setup for a one time

[PATCH 00/12] Netfilter/IPVS fixes for net

2017-10-09 Thread Pablo Neira Ayuso
Hi David, The following patchset contains Netfilter/IPVS fixes for your net tree, they are: 1) Fix packet drops due to incorrect ECN handling in IPVS, from Vadim Fedorenko. 2) Fix splat with mark restoration in xt_socket with non-full-sock, patch from Subash Abhinov Kasiviswanathan. 3)

[PATCH 04/12] netfilter: ipset: pernet ops must be unregistered last

2017-10-09 Thread Pablo Neira Ayuso
From: Florian Westphal Removing the ipset module leaves a small window where one cpu performs module removal while another runs a command like 'ipset flush'. ipset uses net_generic(), unregistering the pernet ops frees this storage area. Fix it by first removing the

[PATCH 06/12] netfilter: nf_tables: fix update chain error

2017-10-09 Thread Pablo Neira Ayuso
From: JingPiao Chen # nft add table filter # nft add chain filter c1 # nft rename chain filter c1 c2 Error: Could not process rule: No such file or directory rename chain filter c1 c2 ^^ # nft add chain filter c2 # nft rename chain filter c1

RE: [PATCH v3 2/3] net: phy: DP83822 initial driver submission

2017-10-09 Thread Woojung.Huh
> Subject: [PATCH v3 2/3] net: phy: DP83822 initial driver submission > > Add support for the TI DP83822 10/100Mbit ethernet phy. > > The DP83822 provides flexibility to connect to a MAC through a > standard MII, RMII or RGMII interface. > > Datasheet: >

Re: [net-next 14/15] i40e: ignore skb->xmit_more when deciding to set RS bit

2017-10-09 Thread Alexander Duyck
On Mon, Oct 9, 2017 at 2:07 AM, David Laight wrote: > From: Jeff Kirsher >> Sent: 06 October 2017 18:57 >> From: Jacob Keller >> >> Since commit 6a7fded776a7 ("i40e: Fix RS bit update in Tx path and >> disable force WB workaround") we've tried

[PATCH 10/12] netfilter: x_tables: avoid stack-out-of-bounds read in xt_copy_counters_from_user

2017-10-09 Thread Pablo Neira Ayuso
From: Eric Dumazet syzkaller reports an out of bound read in strlcpy(), triggered by xt_copy_counters_from_user() Fix this by using memcpy(), then forcing a zero byte at the last position of the destination, as Florian did for the non COMPAT code. Fixes: d7591f0c41ce

[PATCH 02/12] netfilter: xt_socket: Restore mark from full sockets only

2017-10-09 Thread Pablo Neira Ayuso
From: Subash Abhinov Kasiviswanathan An out of bounds error was detected on an ARM64 target with Android based kernel 4.9. This occurs while trying to restore mark on a skb from an inet request socket. BUG: KASAN: slab-out-of-bounds in socket_match.isra.2+0xc8/0x1f0

[PATCH 03/12] netfilter: ipset: Fix adding an IPv4 range containing more than 2^31 addresses

2017-10-09 Thread Pablo Neira Ayuso
From: Jozsef Kadlecsik Wrong comparison prevented the hash types to add a range with more than 2^31 addresses but reported as a success. Fixes Netfilter's bugzilla id #1005, reported by Oleg Serditov and Oliver Ford. Signed-off-by: Jozsef Kadlecsik

[PATCH 08/12] netfilter: nf_tables: Release memory obtained by kasprintf

2017-10-09 Thread Pablo Neira Ayuso
From: Arvind Yadav Free memory region, if nf_tables_set_alloc_name is not successful. Fixes: 387454901bd6 ("netfilter: nf_tables: Allow set names of up to 255 chars") Signed-off-by: Arvind Yadav Signed-off-by: Pablo Neira Ayuso

[PATCH 09/12] netfilter: nf_tables: do not dump chain counters if not enabled

2017-10-09 Thread Pablo Neira Ayuso
Chain counters are only enabled on demand since 9f08ea848117, skip them when dumping them via netlink. Fixes: 9f08ea848117 ("netfilter: nf_tables: keep chain counters away from hot path") Reported-by: Johny Mattsson Tested-by: Johny Mattsson

[PATCH 01/12] netfilter: ipvs: full-functionality option for ECN encapsulation in tunnel

2017-10-09 Thread Pablo Neira Ayuso
From: Vadim Fedorenko IPVS tunnel mode works as simple tunnel (see RFC 3168) copying ECN field to outer header. That's result in packet drops on egress tunnels in case the egress tunnel operates as ECN-capable with Full-functionality option (like ip_tunnel and

[PATCH 07/12] netfilter: ebtables: fix race condition in frame_filter_net_init()

2017-10-09 Thread Pablo Neira Ayuso
From: Artem Savkov It is possible for ebt_in_hook to be triggered before ebt_table is assigned resulting in a NULL-pointer dereference. Make sure hooks are registered as the last step. Fixes: aee12a0a3727 ("ebtables: remove nf_hook_register usage") Signed-off-by: Artem

Re: [PATCH] net/mlx4_core: Convert timers to use timer_setup()

2017-10-09 Thread Doug Ledford
On Wed, 2017-10-04 at 17:51 -0700, Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list > pointer to > all timer callbacks, switch to using the new timer_setup() and > from_timer() > to pass the timer pointer explicitly. > > Cc: Tariq Toukan >

[PATCH 12/12] netfilter: xt_bpf: Fix XT_BPF_MODE_FD_PINNED mode of 'xt_bpf_info_v1'

2017-10-09 Thread Pablo Neira Ayuso
From: Shmulik Ladkani Commit 2c16d6033264 ("netfilter: xt_bpf: support ebpf") introduced support for attaching an eBPF object by an fd, with the 'bpf_mt_check_v1' ABI expecting the '.fd' to be specified upon each IPT_SO_SET_REPLACE call. However this breaks subsequent

[PATCH 11/12] netfilter: SYNPROXY: skip non-tcp packet in {ipv4, ipv6}_synproxy_hook

2017-10-09 Thread Pablo Neira Ayuso
From: Lin Zhang In function {ipv4,ipv6}_synproxy_hook we expect a normal tcp packet, but the real server maybe reply an icmp error packet related to the exist tcp conntrack, so we will access wrong tcp data. Fix it by checking for the protocol field and only process tcp

[PATCH 05/12] netfilter: ipset: Fix race between dump and swap

2017-10-09 Thread Pablo Neira Ayuso
From: Ross Lagerwall Fix a race between ip_set_dump_start() and ip_set_swap(). The race is as follows: * Without holding the ref lock, ip_set_swap() checks ref_netlink of the set and it is 0. * ip_set_dump_start() takes a reference on the set. * ip_set_swap() does

Re: [oss-drivers] Re: [PATCH net-next 0/7] nfp: extend match and action for flower offload

2017-10-09 Thread Simon Horman
On Mon, Oct 09, 2017 at 08:45:41AM -0700, Tom Herbert wrote: > On Mon, Oct 9, 2017 at 1:05 AM, Simon Horman > wrote: > > On Fri, Oct 06, 2017 at 08:34:59AM -0700, Tom Herbert wrote: > >> Simon, > >> > >> Maybe a bit off topic, but I had the impression netronome would

Re: [PATCH net-next 0/7] nfp: extend match and action for flower offload

2017-10-09 Thread Tom Herbert
On Mon, Oct 9, 2017 at 1:05 AM, Simon Horman wrote: > On Fri, Oct 06, 2017 at 08:34:59AM -0700, Tom Herbert wrote: >> Simon, >> >> Maybe a bit off topic, but I had the impression netronome would >> support BPF so that filters could be programmed for arbitrary >>

[PATCH v2] net/core: Fix BUG to BUG_ON conditionals.

2017-10-09 Thread Tim Hansen
Fix BUG() calls to use BUG_ON(conditional) macros. This was found using make coccicheck M=net/core on linux next tag next-2017092 Signed-off-by: Tim Hansen --- net/core/skbuff.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git

Re: [PATCH net] net: enable interface alias removal via rtnl

2017-10-09 Thread Nicolas Dichtel
Le 09/10/2017 à 16:02, David Ahern a écrit : > On 10/9/17 2:23 AM, Nicolas Dichtel wrote: >> Le 06/10/2017 à 22:10, Oliver Hartkopp a écrit : >>> >>> >>> On 10/06/2017 08:18 PM, David Ahern wrote: On 10/5/17 4:19 AM, Nicolas Dichtel wrote: > IFLA_IFALIAS is defined as NLA_STRING. It means

[net 2/5] ixgbe: fix masking of bits read from IXGBE_VXLANCTRL register

2017-10-09 Thread Jeff Kirsher
From: Sabrina Dubroca In ixgbe_clear_udp_tunnel_port(), we read the IXGBE_VXLANCTRL register and then try to mask some bits out of the value, using the logical instead of bitwise and operator. Fixes: a21d0822ff69 ("ixgbe: add support for geneve Rx offload") Signed-off-by:

[net 0/5][pull request] Intel Wired LAN Driver Updates 2017-10-09

2017-10-09 Thread Jeff Kirsher
This series contains updates to ixgbe and arch/Kconfig. Mark fixes a case where PHY register access is not supported and we were returning a PHY address, when we should have been returning -EOPNOTSUPP. Sabrina Dubroca fixes the use of a logical "and" when it should have been the bitwise "and"

[net 3/5] Revert commit 1a8b6d76dc5b ("net:add one common config...")

2017-10-09 Thread Jeff Kirsher
From: Ding Tianhong The new flag PCI_DEV_FLAGS_NO_RELAXED_ORDERING has been added to indicate that Relaxed Ordering Attributes (RO) should not be used for Transaction Layer Packets (TLP) targeted toward these affected Root Port, it will clear the bit4 in the PCIe Device

[net 4/5] net: ixgbe: Use new PCI_DEV_FLAGS_NO_RELAXED_ORDERING flag

2017-10-09 Thread Jeff Kirsher
From: Ding Tianhong The ixgbe driver use the compile check to determine if it can send TLPs to Root Port with the Relaxed Ordering Attribute set, this is too inconvenient, now the new flag PCI_DEV_FLAGS_NO_RELAXED_ORDERING has been added to the kernel and we could check

[net 5/5] ixgbe: incorrect XDP ring accounting in ethtool tx_frame param

2017-10-09 Thread Jeff Kirsher
From: John Fastabend Changing the TX ring parameters with an XDP program attached may cause the XDP queues to be cleared and the TX rings to be incorrectly configured. Fix by doing correct ring accounting in setup call. Fixes: 33fdc82f0883 ("ixgbe: add support for

[net 1/5] ixgbe: Return error when getting PHY address if PHY access is not supported

2017-10-09 Thread Jeff Kirsher
From: Mark D Rustad In cases where PHY register access is not supported, don't mislead a caller into thinking that it is supported by returning a PHY address. Instead, return -EOPNOTSUPP when PHY access is not supported. Signed-off-by: Mark Rustad

Re: [PATCH net] net: enable interface alias removal via rtnl

2017-10-09 Thread David Ahern
On 10/9/17 2:23 AM, Nicolas Dichtel wrote: > Le 06/10/2017 à 22:10, Oliver Hartkopp a écrit : >> >> >> On 10/06/2017 08:18 PM, David Ahern wrote: >>> On 10/5/17 4:19 AM, Nicolas Dichtel wrote: IFLA_IFALIAS is defined as NLA_STRING. It means that the minimal length of the attribute is 1

[PATCH net-next 3/3] net/mlx4_en: Use __force to fix a sparse warning in TX datapath

2017-10-09 Thread Tariq Toukan
In TX data-path, we intentionally do not byte-swap, as documented in code and in the cited commit log. This fixes sparse warning: en_tx.c:720:23: warning: incorrect type in argument 1 (different base types) en_tx.c:720:23:expected unsigned int [unsigned] [usertype] en_tx.c:720:23:got

[PATCH net-next 2/3] net/mlx4_core: Fix cast warning in fw.c

2017-10-09 Thread Tariq Toukan
Fix the following SPARSE warning, in MLX4_GET() macro: drivers/net/ethernet/mellanox/mlx4/fw.c:233:9: warning: cast to restricted __be64 Fixes: 17d5ceb6e43e ("net/mlx4_core: Fix unaligned accesses") Signed-off-by: Tariq Toukan --- drivers/net/ethernet/mellanox/mlx4/fw.c |

[PATCH net-next 1/3] net/mlx4: Fix endianness issue in qp context params

2017-10-09 Thread Tariq Toukan
Should take care of the endianness before assigning to params2 field. Fixes: 53f33ae295a5 ("net/mlx4_core: Port aggregation upper layer interface") Signed-off-by: Tariq Toukan --- drivers/net/ethernet/mellanox/mlx4/en_resources.c | 2 +-

<    1   2   3   >