Re: [PATCHv4 iproute2 2/2] lib/libnetlink: update rtnl_talk to support malloc buff at run time

2017-10-13 Thread Phil Sutter
On Thu, Oct 12, 2017 at 09:07:06AM -0700, Stephen Hemminger wrote: > On Wed, 11 Oct 2017 13:10:07 +0200 > Phil Sutter wrote: > > > On Tue, Oct 10, 2017 at 09:47:43AM -0700, Stephen Hemminger wrote: > > > On Tue, 10 Oct 2017 08:41:17 +0200 > > > Michal Kubecek

[patch net-next 1/9] net: sched: store Qdisc pointer in struct block

2017-10-13 Thread Jiri Pirko
From: Jiri Pirko Prepare for removal of tp->q and store Qdisc pointer in the block structure. Signed-off-by: Jiri Pirko --- include/net/pkt_cls.h | 4 ++-- include/net/sch_generic.h | 1 + net/sched/cls_api.c | 3 ++- net/sched/sch_atm.c |

[patch net-next 9/9] net: sched: propagate q and parent from caller down to tcf_fill_node

2017-10-13 Thread Jiri Pirko
From: Jiri Pirko The callers have this info, they will pass it down to tcf_fill_node. Signed-off-by: Jiri Pirko --- net/sched/cls_api.c | 55 ++--- 1 file changed, 35 insertions(+), 20 deletions(-) diff

[patch net-next 6/9] net: sched: cls_u32: use block instead of q in tc_u_common

2017-10-13 Thread Jiri Pirko
From: Jiri Pirko tc_u_common is now per-q. With blocks, it has to be converted to be per-block. Signed-off-by: Jiri Pirko --- net/sched/cls_u32.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/net/sched/cls_u32.c

[patch net-next 5/9] net: sched: ematch: obtain net pointer from blocks

2017-10-13 Thread Jiri Pirko
From: Jiri Pirko Instead of using tp->q, use block to get the net pointer. Signed-off-by: Jiri Pirko --- net/sched/ematch.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sched/ematch.c b/net/sched/ematch.c index 03b677b..1331a4c

[patch net-next 3/9] net: sched: introduce tcf_block_q and tcf_block_dev helpers

2017-10-13 Thread Jiri Pirko
From: Jiri Pirko These helpers allows to get a q and netdev pointers for given block easily. Signed-off-by: Jiri Pirko --- include/net/pkt_cls.h | 21 + 1 file changed, 21 insertions(+) diff --git a/include/net/pkt_cls.h

[patch net-next 4/9] net: sched: teach tcf_bind/unbind_filter to use block->q

2017-10-13 Thread Jiri Pirko
From: Jiri Pirko Whenever the block->q is set, it can be used instead of tp->q as it contains the same value. When it is not set, which can't happen now but it might happen with the follow-up shared blocks introduction, the class is not set in the result. That would lead to a

[patch net-next 2/9] net: sched: store net pointer in block and introduce qdisc_net helper

2017-10-13 Thread Jiri Pirko
From: Jiri Pirko Store net pointer in the block structure. Along the way, introduce qdisc_net helper which allows to easily obtain net pointer for qdisc instance. Signed-off-by: Jiri Pirko --- include/net/pkt_sched.h | 7 +++

[PATCH net-next v2 8/8] cxgb4: collect IBQ and OBQ dumps

2017-10-13 Thread Rahul Lakkireddy
Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- v2: - Prefix symbols in cudbg_* files with cudbg_ drivers/net/ethernet/chelsio/cxgb4/cudbg_if.h| 14 ++ drivers/net/ethernet/chelsio/cxgb4/cudbg_lib.c | 165

[PATCH net-next v2 7/8] cxgb4: collect hardware module dumps

2017-10-13 Thread Rahul Lakkireddy
Collect SGE, PCIE, PM, UP CIM, MA and HMA dumps. Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- v2: - Prefix symbols in cudbg_* files with cudbg_ drivers/net/ethernet/chelsio/cxgb4/cudbg_entity.h | 74 ++

[PATCH net-next v2 4/8] cxgb4: collect firmware mbox and device log dump

2017-10-13 Thread Rahul Lakkireddy
Collect firmware mbox and device logs before collecting the rest of the hardware dumps to snap the firmware state before the mailbox logs are updated by other hardware dumps. Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- v2:

[PATCH net-next v2 2/8] cxgb4: collect register dump

2017-10-13 Thread Rahul Lakkireddy
Add base to collect dump entities. Collect register dump and update template header accordingly. Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- v2: - Prefix symbols in cxgb4_*.c files with cxgb4_ - Prefix symbols in cudbg_*

[PATCH net-next v2 6/8] cxgb4: collect TP dump

2017-10-13 Thread Rahul Lakkireddy
Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- v2: - Prefix symbols in cudbg_* files with cudbg_ drivers/net/ethernet/chelsio/cxgb4/cudbg_entity.h | 72 ++ drivers/net/ethernet/chelsio/cxgb4/cudbg_if.h | 1

[PATCH net-next v2 3/8] cxgb4: collect on-chip memory dump

2017-10-13 Thread Rahul Lakkireddy
Collect EDC0 and EDC1 memory dump. Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- v2: - Prefix symbols in cxgb4_*.c files with cxgb4_ - Prefix symbols in cudbg_* files with cudbg_ - Make cudbg_collect_mem_info() static.

[PATCH net-next v2 5/8] cxgb4: update API for TP indirect register access

2017-10-13 Thread Rahul Lakkireddy
Try to access TP indirect registers via firmware first. If this fails, fallback and access them directly. This ensures that driver and firmware do not conflict each other while accessing the TP indirect registers. Signed-off-by: Rahul Lakkireddy Signed-off-by:

Re: [PATCH] ath9k: debug: Simplify error checking

2017-10-13 Thread Kalle Valo
Christos Gkekas writes: > Variable val is unsigned so checking whether it is less than zero is > redundant. > > Signed-off-by: Christos Gkekas > --- > drivers/net/wireless/ath/ath9k/debug.c | 5 + > 1 file changed, 1 insertion(+), 4

[PATCH net-next v2 0/8] cxgb4: add support to get hardware debug logs via ethtool

2017-10-13 Thread Rahul Lakkireddy
This series of patches add support to collect hardware debug logs via ethtool --get-dump facility. Currently supports: Memory dumps - Collects on-chip EDC0 and EDC1 dumps. Hardware dumps - Collects firmware and hardware dumps. Patch 1 adds ethtool set/get dump data. It also adds template

[PATCH net-next v2 1/8] cxgb4: implement ethtool dump data operations

2017-10-13 Thread Rahul Lakkireddy
Implement operations to set/get dump data via ethtool. Also add template header that precedes dump data, which helps in decoding and extracting the dump data. Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- v2: - Renamed

[patch net-next 8/9] net: sched: use tcf_block_q helper to get q pointer for sch_tree_lock

2017-10-13 Thread Jiri Pirko
From: Jiri Pirko Use tcf_block_q helper to get q pointer to be used for direct call of sch_tree_lock/unlock instead of tcf_tree_lock/unlock. Signed-off-by: Jiri Pirko --- include/net/sch_generic.h | 3 --- net/sched/sch_api.c | 6 -- 2 files

[patch net-next 0/9] net: sched: remove some tp->q usage

2017-10-13 Thread Jiri Pirko
From: Jiri Pirko In order to prepare for block sharing, tcf_proto instances need to be independent on particular qdisc instances. This patchset takes care of removal of couple occurrences of tp->q usage. Jiri Pirko (9): net: sched: store Qdisc pointer in struct block net:

[patch net-next 7/9] net: sched: tcindex, fw, flow: use tcf_block_q helper to get struct Qdisc

2017-10-13 Thread Jiri Pirko
From: Jiri Pirko Use helper to get q pointer per block. Signed-off-by: Jiri Pirko --- net/sched/cls_flow.c| 7 +-- net/sched/cls_fw.c | 5 - net/sched/cls_tcindex.c | 5 - 3 files changed, 13 insertions(+), 4 deletions(-) diff --git

Re: [PATCH 2/2] cfg80211: fix CFG80211_EXTRA_REGDB_KEYDIR typo

2017-10-13 Thread Johannes Berg
Thanks, both applied. johannes

[PATCH iproute2 net-next] ip: bridge_slave: add support for per-port group_fwd_mask

2017-10-13 Thread Nikolay Aleksandrov
This patch adds the iproute2 support for getting and setting the per-port group_fwd_mask. It also tries to resolve the value into a more human friendly format by printing the known protocols instead of only the raw value. The man page is also updated with the new option. Signed-off-by: Nikolay

Re: [v2] mwifiex: Use put_unaligned_le32

2017-10-13 Thread Kalle Valo
Himanshu Jha wrote: > Use put_unaligned_le32 rather than using byte ordering function and > memcpy which makes code clear. > Also, add the header file where it is declared. > > Done using Coccinelle and semantic patch used is : > > @ rule1 @ > identifier tmp;

linux-next: manual merge of the rdma tree with the FIXME tree

2017-10-13 Thread Mark Brown
Hi Doug, Today's linux-next merge of the rdma tree got a conflict in: drivers/net/ethernet/mellanox/mlx4/catas.c between commit: d2a0012e7632a5 ("drivers: net: mlx4: use setup_timer() helper.") from the net-next tree and commit: 55c0fcc3de4605 ("net/mlx4_core: Convert timers to use

[iproute2] regression in ss output

2017-10-13 Thread Humberto Alves
Hi! With the last iproute2 release, ss command output does not differentiate between any-address IPv4 sockets from the IPv6 ones. I don't know if this is an expected behaviour, but the old output looks more useful. Below I pasted the difference between the old behaviour and the new one. I am

RE: [PATCH net-next 5/5] net: dsa: split dsa_port's netdev member

2017-10-13 Thread David Laight
From: Vivien Didelot > Sent: 13 October 2017 16:29 > Vivien Didelot writes: > > >>> How about using: > >>> > >>> union { > >>> struct net_device *master; > >>> struct net_device *slave; > >>> } netdev; > >> ... > >> > >> You can remove

Re: [PATCH net-next v2 1/2] dt-bindings: net: add DT bindings for Socionext UniPhier AVE

2017-10-13 Thread Masahiro Yamada
2017-10-13 9:35 GMT+09:00 Kunihiko Hayashi : > DT bindings for the AVE ethernet controller found on Socionext's > UniPhier platforms. > > Signed-off-by: Kunihiko Hayashi > Signed-off-by: Jassi Brar > ---

[PATCH v1] pch_gbe: Switch to new PCI IRQ allocation API

2017-10-13 Thread Andy Shevchenko
This removes custom flag handling. Signed-off-by: Andy Shevchenko --- drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe.h| 3 +- .../net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c | 42 +- 2 files changed, 17 insertions(+), 28 deletions(-)

pull-request: mac80211-next 2017-10-13

2017-10-13 Thread Johannes Berg
Hi Dave, Sorry for the quick succession - there were a few issues with the last pull request that only got noticed now, so I'm fixing those here. Please pull and let me know if there's any problem. Thanks, johannes The following changes since commit 90a53e4432b12288316efaa5f308adafb8d304b0:

RE: Kernel Performance Tuning for High Volume SCTP traffic

2017-10-13 Thread David Laight
From: Traiano Welcome (copied to netdev) > Sent: 13 October 2017 07:16 > To: linux-s...@vger.kernel.org > Subject: Kernel Performance Tuning for High Volume SCTP traffic > > Hi List > > I'm running a linux server processing high volumes of SCTP traffic and > am seeing large numbers of packet

Re: Kernel Performance Tuning for High Volume SCTP traffic

2017-10-13 Thread Traiano Welcome
Hi David On Fri, Oct 13, 2017 at 11:56 PM, David Laight wrote: > From: Traiano Welcome > > (copied to netdev) >> Sent: 13 October 2017 07:16 >> To: linux-s...@vger.kernel.org >> Subject: Kernel Performance Tuning for High Volume SCTP traffic >> >> Hi List >> >> I'm

[PATCH net] l2tp: check ps->sock before running pppol2tp_session_ioctl()

2017-10-13 Thread Guillaume Nault
When pppol2tp_session_ioctl() is called by pppol2tp_tunnel_ioctl(), the session may be unconnected. That is, it was created by pppol2tp_session_create() and hasn't been connected with pppol2tp_connect(). In this case, ps->sock is NULL, so we need to check for this case in order to avoid

RE: [PATCH net-next 5/5] net: dsa: split dsa_port's netdev member

2017-10-13 Thread Vivien Didelot
Hi David, David Laight writes: > From: Florian Fainelli >> Sent: 13 October 2017 00:05 > ... >> How about using: >> >> union { >> struct net_device *master; >> struct net_device *slave; >> } netdev; > ... > > You can remove the

RE: Kernel Performance Tuning for High Volume SCTP traffic

2017-10-13 Thread David Laight
From: Traiano Welcome > Sent: 13 October 2017 17:04 > On Fri, Oct 13, 2017 at 11:56 PM, David Laight > wrote: > > From: Traiano Welcome > > > > (copied to netdev) > >> Sent: 13 October 2017 07:16 > >> To: linux-s...@vger.kernel.org > >> Subject: Kernel Performance Tuning

RE: [PATCH net-next v2 2/4] net: dsa: mv88e6060: setup random mac address

2017-10-13 Thread Vivien Didelot
Hi David, Woojung, woojung@microchip.com writes: >> From: Vivien Didelot >> > Sent: 13 October 2017 02:41 >> > As for mv88e6xxx, setup the switch from within the mv88e6060 driver with >> > a random MAC address, and remove the .set_addr implementation. >> > >> > Signed-off-by: Vivien Didelot

Re: [PATCH v1] pch_gbe: Switch to new PCI IRQ allocation API

2017-10-13 Thread Andy Shevchenko
On Fri, 2017-10-13 at 20:02 +0300, Andy Shevchenko wrote: > This removes custom flag handling. Please, discard this one, slipped to early. > > Signed-off-by: Andy Shevchenko > --- > drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe.h| 3 +- >

Re: [next-queue PATCH v7 4/6] net/sched: Introduce Credit Based Shaper (CBS) qdisc

2017-10-13 Thread Vinicius Costa Gomes
Hi, Eric Dumazet writes: [...] > > Your mixing of s64 and u64 is disturbing. > > do_div() handles u64, not s64. > > div64_s64() might be needed in place of do_div() I wasn't very comfortable about the signal juggling either. Didn't know about div64_s64(), looks much

Re: [net-next v2 00/18] tipc: Introduce Communcation Group feature

2017-10-13 Thread David Miller
From: Jon Maloy Date: Fri, 13 Oct 2017 11:04:16 +0200 > With this commit series we introduce a 'Group Communication' feature in > order to resolve the datagram and multicast flow control problem. This > new feature makes it possible for a user to instantiate multiple

[PATCH net-next] virtio_net: implement VIRTIO_CONFIG_S_NEEDS_RESET

2017-10-13 Thread Willem de Bruijn
From: Willem de Bruijn Implement the reset communication request defined in the VIRTIO 1.0 specification and introduces in Linux in commit c00bbcf862896 ("virtio: add VIRTIO_CONFIG_S_NEEDS_RESET device status bit"). Use the virtnet_reset function introduced in commit

RE: [PATCH net-next v2 2/4] net: dsa: mv88e6060: setup random mac address

2017-10-13 Thread Woojung.Huh
> From: Vivien Didelot > > Sent: 13 October 2017 02:41 > > As for mv88e6xxx, setup the switch from within the mv88e6060 driver with > > a random MAC address, and remove the .set_addr implementation. > > > > Signed-off-by: Vivien Didelot > > --- > >

Re: [PATCH net-next v2 1/1] bridge: return error code when deleting Vlan

2017-10-13 Thread Roman Mashak
Nikolay Aleksandrov writes: [...] >>> Why do you want to return the error code here? Walking the code paths >>> seems like ENOENT or err from switchdev_port_obj_del are the 2 error >>> possibilities. >> >> For example, if you attempt to delete a non-existing vlan

[PATCH][net-next] cxgb4: fix missing break in switch and indent return statements

2017-10-13 Thread Colin King
From: Colin Ian King The break statement for the Macronix case is missing and will fall through to the Winbond case and re-assign the size setting. Fix this by adding the missing break statement. Also correctly indent the return statements. Detected by CoverityScan,

[RFC PATCH] net: realtek: r8169: implement set_link_ksettings()

2017-10-13 Thread Tobias Jakobi
Commit 6fa1ba61520576cf1346c4ff09a056f2950cb3bf partially implemented the new ethtool API, by replacing get_settings() with get_link_ksettings(). This breaks ethtool, since the userspace tool (according to the new API specs) never tries the legacy set() call, when the new get() call succeeds. All

RE: [PATCH net-next 5/5] net: dsa: split dsa_port's netdev member

2017-10-13 Thread Vivien Didelot
Hi David, David Laight writes: > From: Vivien Didelot >> Sent: 13 October 2017 16:29 >> Vivien Didelot writes: >> >> >>> How about using: >> >>> >> >>> union { >> >>> struct net_device *master; >> >>> struct

Re: [PATCH] [net] liquidio: fix timespec64_to_ns typo

2017-10-13 Thread David Miller
From: Arnd Bergmann Date: Thu, 12 Oct 2017 11:48:31 +0200 > While experimenting with changes to the timekeeping code, I > ran into a build error in the liquidio driver: > > drivers/net/ethernet/cavium/liquidio/lio_main.c: In function > 'liquidio_ptp_settime': >

Re: [PATCH] net: stmmac: dwmac_lib: fix interchanged sleep/timeout values in DMA reset function

2017-10-13 Thread David Miller
From: Emiliano Ingrassia Date: Thu, 12 Oct 2017 11:00:47 +0200 > The DMA reset timeout, used in read_poll_timeout, is > ten times shorter than the sleep time. > This patch fixes these values interchanging them, as it was > before the read_poll_timeout introduction. > >

[net-next 7/9] i40e: make const array patterns static, reduces object code size

2017-10-13 Thread Jeff Kirsher
From: Colin Ian King Don't populate const array patterns on the stack, instead make it static. Makes the object code smaller by over 60 bytes: Before: textdata bss dec hex filename 1953 496 02449 991 i40e_diag.o After: text

[PATCH net-next] ipv6: check fn before doing FIB6_SUBTREE(fn)

2017-10-13 Thread Wei Wang
From: Wei Wang In fib6_locate(), we need to first make sure fn is not NULL before doing FIB6_SUBTREE(fn) to avoid crash. This fixes the following static checker warning: net/ipv6/ip6_fib.c:1462 fib6_locate() warn: variable dereferenced before check 'fn' (see line

[PATCH net 2/6] bnxt_en: Don't use rtnl lock to protect link change logic in workqueue.

2017-10-13 Thread Michael Chan
As a further improvement to the PF/VF link change logic, use a private mutex instead of the rtnl lock to protect link change logic. With the new mutex, we don't have to take the rtnl lock in the workqueue when we have to handle link related functions. If the VF and PF drivers are running on the

[PATCH net 3/6] bnxt_en: Fix VF PCIe link speed and width logic.

2017-10-13 Thread Michael Chan
From: Vasundhara Volam PCIE PCIE_EP_REG_LINK_STATUS_CONTROL register is only defined in PF config space, so we must read it from the PF. Fixes: 90c4f788f6c0 ("bnxt_en: Report PCIe link speed and width during driver load") Signed-off-by: Vasundhara Volam

[PATCH net 5/6] bnxt_en: Fix possible corrupted NVRAM parameters from firmware response.

2017-10-13 Thread Michael Chan
In bnxt_find_nvram_item(), it is copying firmware response data after releasing the mutex. This can cause the firmware response data to be corrupted if the next firmware response overwrites the response buffer. The rare problem shows up when running ethtool -i repeatedly. Fix it by calling the

[PATCH net 1/6] bnxt_en: Improve VF/PF link change logic.

2017-10-13 Thread Michael Chan
Link status query firmware messages originating from the VFs are forwarded to the PF. The driver handles these interactions in a workqueue for the VF and PF. The VF driver waits for the response from the PF in the workqueue. If the PF and VF driver are running on the same host and the work for

Re: [RFC 0/3] Adding config get/set to devlink

2017-10-13 Thread Roopa Prabhu
On Fri, Oct 13, 2017 at 12:11 AM, Jiri Pirko wrote: > Thu, Oct 12, 2017 at 11:53:56PM CEST, ro...@cumulusnetworks.com wrote: >>On Thu, Oct 12, 2017 at 12:20 PM, Florian Fainelli >>wrote: >>> On 10/12/2017 12:06 PM, David Miller wrote: From: Florian

Re: [net-next RFC 0/4] Openvswitch meter action

2017-10-13 Thread Pravin Shelar
On Thu, Oct 12, 2017 at 3:38 PM, Andy Zhou wrote: > This patch series is the first attempt to add openvswitch > meter support. We have previously experimented with adding > metering support in nftables. However 1) It was not clear > how to expose a named nftables object cleanly,

[PATCH net 0/6] bnxt_en: bug fixes.

2017-10-13 Thread Michael Chan
Various bug fixes for the VF/PF link change logic, VF resource checking, potential firmware response corruption on NVRAM and DCB parameters, and reading the wrong register for PCIe link speed on the VF. Michael Chan (4): bnxt_en: Improve VF/PF link change logic. bnxt_en: Don't use rtnl lock

[PATCH net 6/6] bnxt_en: Fix possible corruption in DCB parameters from firmware.

2017-10-13 Thread Michael Chan
From: Sankar Patchineelam hwrm_send_message() is replaced with _hwrm_send_message(), and hwrm_cmd_lock mutex lock is grabbed for the whole period of firmware call until the firmware DCB parameters have been copied. This will prevent possible corruption of the

[PATCH net 4/6] bnxt_en: Fix VF resource checking.

2017-10-13 Thread Michael Chan
In bnxt_sriov_enable(), we calculate to see if we have enough hardware resources to enable the requested number of VFs. The logic to check for minimum completion rings and statistics contexts is missing. Add the required checks so that VF configuration won't fail. Signed-off-by: Michael Chan

[next-queue PATCH v8 1/6] net/sched: Check for null dev_queue on create flow

2017-10-13 Thread Vinicius Costa Gomes
From: Jesus Sanchez-Palencia In qdisc_alloc() the dev_queue pointer was used without any checks being performed. If qdisc_create() gets a null dev_queue pointer, it just passes it along to qdisc_alloc(), leading to a crash. That happens if a root qdisc

[next-queue PATCH v8 4/6] net/sched: Introduce Credit Based Shaper (CBS) qdisc

2017-10-13 Thread Vinicius Costa Gomes
This queueing discipline implements the shaper algorithm defined by the 802.1Q-2014 Section 8.6.8.2 and detailed in Annex L. It's primary usage is to apply some bandwidth reservation to user defined traffic classes, which are mapped to different queues via the mqprio qdisc. Only a simple

[next-queue PATCH v8 6/6] igb: Add support for CBS offload

2017-10-13 Thread Vinicius Costa Gomes
From: Andre Guedes This patch adds support for Credit-Based Shaper (CBS) qdisc offload from Traffic Control system. This support enable us to leverage the Forwarding and Queuing for Time-Sensitive Streams (FQTSS) features from Intel i210 Ethernet Controller. FQTSS is the

[next-queue PATCH v8 2/6] net/sched: Change behavior of mq select_queue()

2017-10-13 Thread Vinicius Costa Gomes
From: Jesus Sanchez-Palencia Currently, the class_ops select_queue() implementation on sch_mq returns a pointer to netdev_queue #0 when it receives and invalid qdisc id. That can be misleading since all of mq's inner qdiscs are attached to a valid netdev_queue.

[next-queue PATCH v8 0/6] TSN: Add qdisc based config interface for CBS

2017-10-13 Thread Vinicius Costa Gomes
Hi, Changes from v8: - Fixed comments from Eric Dumazet and Ivan Khoronzhuk; Changes since v6: - Fixed compilation for 32bit arches; - Aligned the behaviour of .select_queue() of the mq qdisc to be the same as mqprio; Changes since v5: - Fixed comments from Jiri Pirko; Changes since v4:

[next-queue PATCH v8 5/6] net/sched: Add support for HW offloading for CBS

2017-10-13 Thread Vinicius Costa Gomes
This adds support for offloading the CBS algorithm to the controller, if supported. Drivers wanting to support CBS offload must implement the .ndo_setup_tc callback and handle the TC_SETUP_CBS (introduced here) type. Signed-off-by: Vinicius Costa Gomes ---

Re: [net-next V7 PATCH 1/5] bpf: introduce new bpf cpu map type BPF_MAP_TYPE_CPUMAP

2017-10-13 Thread kbuild test robot
Hi Jesper, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Jesper-Dangaard-Brouer/New-bpf-cpumap-type-for-XDP_REDIRECT/20171014-061849 config: blackfin-allyesconfig (attached as .config) compiler: bfin-uclinux-gcc (GCC) 6.2.0 reproduce: wget

Re: [PATCH net-next] ipv6: only update __use and lastusetime once per jiffy at most

2017-10-13 Thread Eric Dumazet
On Fri, Oct 13, 2017 at 5:09 PM, Martin KaFai Lau wrote: > On Fri, Oct 13, 2017 at 10:08:07PM +, Wei Wang wrote: >> From: Wei Wang >> >> In order to not dirty the cacheline too often, we try to only update >> dst->__use and dst->lastusetime at most once per

[next-queue PATCH v8 3/6] net/sched: Add select_queue() class_ops for mqprio

2017-10-13 Thread Vinicius Costa Gomes
From: Jesus Sanchez-Palencia When replacing a child qdisc from mqprio, tc_modify_qdisc() must fetch the netdev_queue pointer that the current child qdisc is associated with before creating the new qdisc. Currently, when using mqprio as root qdisc, the kernel

[PATCH net-next 1/2] net: move memcpy_to[from]_msg() from skbuff.h to socket.h

2017-10-13 Thread yuan linyu
From: yuan linyu these two functions used by skb and other places, move to socket.h where struct msghdr defined. Signed-off-by: yuan linyu --- include/linux/skbuff.h | 10 -- include/linux/socket.h | 12 +++- 2

Re: [PATCH net-next] ipv6: only update __use and lastusetime once per jiffy at most

2017-10-13 Thread Martin KaFai Lau
On Fri, Oct 13, 2017 at 10:08:07PM +, Wei Wang wrote: > From: Wei Wang > > In order to not dirty the cacheline too often, we try to only update > dst->__use and dst->lastusetime at most once per jiffy. > As dst->lastusetime is only used by ipv6 garbage collector, it

Re: [net-next RFC 4/4] openvswitch: Add meter action support

2017-10-13 Thread Pravin Shelar
On Thu, Oct 12, 2017 at 3:38 PM, Andy Zhou wrote: > Implements OVS kernel meter action support. > > Signed-off-by: Andy Zhou > --- > include/uapi/linux/openvswitch.h | 1 + > net/openvswitch/actions.c| 12 > net/openvswitch/datapath.h |

Re: [net-next RFC 3/4] openvswitch: Add meter infrastructure

2017-10-13 Thread Pravin Shelar
On Thu, Oct 12, 2017 at 3:38 PM, Andy Zhou wrote: > OVS kernel datapath so far does not support Openflow meter action. > This is the first stab at adding kernel datapath meter support. > This implementation supports only drop band type. > > Signed-off-by: Andy Zhou

RE: [Intel-wired-lan] [PATCH][V3] e1000: avoid null pointer dereference on invalid stat type

2017-10-13 Thread Brown, Aaron F
> From: Intel-wired-lan [mailto:intel-wired-lan-boun...@osuosl.org] On Behalf > Of Colin King > Sent: Friday, September 22, 2017 10:14 AM > To: Kirsher, Jeffrey T ; intel-wired- > l...@lists.osuosl.org; netdev@vger.kernel.org > Cc: kernel-janit...@vger.kernel.org;

[PATCH net v2 2/2] net: fec: Let fec_ptp have its own interrupt routine

2017-10-13 Thread Troy Kisky
This is better for code locality and should slightly speed up normal interrupts. This also allows PPS clock output to start working for i.mx7. This is because i.mx7 was already using the limit of 3 interrupts, and needed another. Signed-off-by: Troy Kisky ---

[PATCH net v2 1/2] ARM: dts: imx: name the interrupts for the fec ethernet driver

2017-10-13 Thread Troy Kisky
imx7s/imx7d has the ptp interrupt newly added as well. For imx7, "int0" is the interrupt for queue 0 and ENET_MII "int1" is for queue 1 "int2" is for queue 2 For imx6sx, "int0" handles all 3 queues and ENET_MII And of course, the "ptp" interrupt is for the PTP_CLOCK_PPS interrupts This will

[PATCH net-next 2/2] net: add skb_memcpy_to[from]_msg() to optimize skb code

2017-10-13 Thread yuan linyu
From: yuan linyu add these two wrappers in skbuff.h which is better named than previous and only used for skb. Signed-off-by: yuan linyu --- drivers/isdn/mISDN/socket.c| 2 +- drivers/staging/irda/net/af_irda.c | 2 +-

[PATCH net-next 0/2] net: add skb_memcpy_to[from]_msg()

2017-10-13 Thread yuan linyu
From: yuan linyu yuan linyu (2): net: move memcpy_to[from]_msg() from skbuff.h to socket.h net: add skb_memcpy_to[from]_msg() to optimize skb code drivers/isdn/mISDN/socket.c| 2 +- drivers/staging/irda/net/af_irda.c | 2 +-

RE: [PATCH net-next 5/5] net: dsa: split dsa_port's netdev member

2017-10-13 Thread David Laight
From: Florian Fainelli > Sent: 13 October 2017 00:05 ... > How about using: > > union { > struct net_device *master; > struct net_device *slave; > } netdev; ... You can remove the 'netdev' all the compilers support unnamed unions. David

Re: [patch net-next 00/34] net: sched: allow qdiscs to share filter block instances

2017-10-13 Thread David Ahern
On 10/13/17 12:26 AM, Jiri Pirko wrote: > Thu, Oct 12, 2017 at 11:37:30PM CEST, dsah...@gmail.com wrote: >> On 10/12/17 11:17 AM, Jiri Pirko wrote: >>> So back to the example. First, we create 2 qdiscs. Both will share >>> block number 22. "22" is just an identification. If we don't pass any >>>

Re: [PATCH net-next v2 1/1] bridge: return error code when deleting Vlan

2017-10-13 Thread David Ahern
On 10/12/17 8:15 PM, Nikolay Aleksandrov wrote: > I do agree it's a bug, but there might be scripts that rely on it and > don't check the return value when clearing vlans. They will end up with > a partial clear and wrongly assumed state, so maybe leave the > opportunistic delete but count if

Fw: [Bug 197213] New: panic in interrupt after ioctl to tun

2017-10-13 Thread Stephen Hemminger
Begin forwarded message: Date: Thu, 12 Oct 2017 19:17:13 + From: bugzilla-dae...@bugzilla.kernel.org To: step...@networkplumber.org Subject: [Bug 197213] New: panic in interrupt after ioctl to tun https://bugzilla.kernel.org/show_bug.cgi?id=197213 Bug ID: 197213

[PATCH iproute2 v2 0/4] Fix ip segfault when using --color switch

2017-10-13 Thread Petr Vorel
Hi Stephen, I cleanup code not to use magic offsets. I kept it in separate commits, as it's clearer what happened. Petr Vorel (4): color: Fix ip segfault when using --color switch color: Fix another ip segfault when using --color switch color: Cleanup code to remove "magic" offset + 7

[PATCH iproute2 v2 1/4] color: Fix ip segfault when using --color switch

2017-10-13 Thread Petr Vorel
Commit d0e72011 ("ip: ipaddress.c: add support for json output") introduced passing -1 as enum color_attr. This is not only wrong as no color_attr has value -1, but also causes another segfault in color_fprintf() on this setup as there is no item with index -1 in array of enum attr_colors[]. Using

[PATCH v2 3/5] dpaa_eth: change device used

2017-10-13 Thread Madalin Bucur
Change device used for DMA mapping to the MAC device that is an of_device, with proper DMA ops. Using this device for the netdevice should also address the issue with DSA scenarios that need the netdevice to be backed by an of_device. Signed-off-by: Madalin Bucur ---

RE: [PATCH net-next 5/5] net: dsa: split dsa_port's netdev member

2017-10-13 Thread Vivien Didelot
Hi again, Vivien Didelot writes: >>> How about using: >>> >>> union { >>> struct net_device *master; >>> struct net_device *slave; >>> } netdev; >> ... >> >> You can remove the 'netdev' all the compilers support unnamed

[PATCH v2 4/5] dpaa_eth: cleanup dpaa_eth_probe() error paths

2017-10-13 Thread Madalin Bucur
Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 53 ++ 1 file changed, 20 insertions(+), 33 deletions(-) diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c

[PATCH v2 5/5] fsl/fman: add dpaa in module names

2017-10-13 Thread Madalin Bucur
Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/fman/Makefile | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/freescale/fman/Makefile b/drivers/net/ethernet/freescale/fman/Makefile index

Re: pull-request: wireless-drivers 2017-10-13

2017-10-13 Thread David Miller
From: Kalle Valo Date: Fri, 13 Oct 2017 10:25:14 +0300 > here's a pull request to net tree, more info in the signed tag below. > Please let me know if there are any problems. Pulled, thanks Kalle.

Re: RFC(v2): Audit Kernel Container IDs

2017-10-13 Thread Alan Cox
On Thu, 12 Oct 2017 10:14:00 -0400 Richard Guy Briggs wrote: > Containers are a userspace concept. The kernel knows nothing of them. > > The Linux audit system needs a way to be able to track the container > provenance of events and actions. Audit needs the kernel's help to

[PATCH iproute2 v2 4/4] color: Rename enum

2017-10-13 Thread Petr Vorel
COLOR_NONE is more descriptive than COLOR_CLEAR. Signed-off-by: Petr Vorel --- include/color.h | 2 +- include/json_print.h | 2 +- lib/color.c | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/include/color.h b/include/color.h index

[PATCH iproute2 v2 3/4] color: Cleanup code to remove "magic" offset + 7

2017-10-13 Thread Petr Vorel
Signed-off-by: Petr Vorel --- lib/color.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/lib/color.c b/lib/color.c index 05afcb21..497f5e1b 100644 --- a/lib/color.c +++ b/lib/color.c @@ -45,8 +45,8 @@ static const char * const

[PATCH iproute2 v2 2/4] color: Fix another ip segfault when using --color switch

2017-10-13 Thread Petr Vorel
Commit 959f1428 ("color: add new COLOR_NONE and disable_color function") introducing color enum COLOR_NONE, which is not only duplicite of COLOR_CLEAR, but also caused segfault, when running ip with --color switch, as 'attr + 8' in color_fprintf() access array item out of bounds. Thus removing it

Re: [patch net-next 00/34] net: sched: allow qdiscs to share filter block instances

2017-10-13 Thread Jiri Pirko
Fri, Oct 13, 2017 at 04:20:38PM CEST, dsah...@gmail.com wrote: >On 10/13/17 12:26 AM, Jiri Pirko wrote: >> Thu, Oct 12, 2017 at 11:37:30PM CEST, dsah...@gmail.com wrote: >>> On 10/12/17 11:17 AM, Jiri Pirko wrote: So back to the example. First, we create 2 qdiscs. Both will share block

RE: [PATCH net-next v2 2/4] net: dsa: mv88e6060: setup random mac address

2017-10-13 Thread David Laight
From: Vivien Didelot > Sent: 13 October 2017 02:41 > As for mv88e6xxx, setup the switch from within the mv88e6060 driver with > a random MAC address, and remove the .set_addr implementation. > > Signed-off-by: Vivien Didelot > --- >

Re: [PATCH net-next v2 0/2] net: stmmac: Improvements for multi-queuing and for AVB

2017-10-13 Thread Giuseppe CAVALLARO
Yes you need these settings, thx for these patches. Acked-by: Giuseppe Cavallaro On 10/13/2017 11:58 AM, Jose Abreu wrote: Hi, Two improvements for stmmac: First one corrects the available fifo size per queue, second one corrects enabling of AVB queues. More info in

[PATCH v2 2/5] dpaa_eth: move of_phy_connect() to the eth driver

2017-10-13 Thread Madalin Bucur
Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 48 +++-- drivers/net/ethernet/freescale/fman/mac.c | 97 ++ drivers/net/ethernet/freescale/fman/mac.h | 5 +- 3 files changed, 66 insertions(+), 84

[PATCH v2 1/5] fsl/fman: remove of_node

2017-10-13 Thread Madalin Bucur
The FMan MAC driver allocates a platform device for the Ethernet driver to probe on. Setting pdev->dev.of_node with the MAC node triggers the MAC driver probing of the new platform device. While this fails quickly and does not affect the functionality of the drivers, it is incorrect and must be

[PATCH v2 0/5] adapt DPAA drivers for DSA

2017-10-13 Thread Madalin Bucur
Junote Cai reported that he was not able to get a DSA setup involving the DPAA/FMAN driver to work and narrowed it down to of_find_net_device_by_node() call in DSA setup. The initial attempt to fix this by adding of_node to the platform device results in a second, failed, probing of the FMan MAC

Re: [Patch net-next v3] tcp: add a tracepoint for tcp retransmission

2017-10-13 Thread Brendan Gregg
On Fri, Oct 13, 2017 at 1:03 PM, Cong Wang wrote: > We need a real-time notification for tcp retransmission > for monitoring. > > Of course we could use ftrace to dynamically instrument this > kernel function too, however we can't retrieve the connection > information at

[PATCH net-next v2 3/4] tc-testing: Add test cases for police and skbmod

2017-10-13 Thread Lucas Bates
Add basic unit tests for police and skbmod actions in tc. Signed-off-by: Lucas Bates Acked-by: Jamal Hadi Salim --- .../tc-testing/tc-tests/actions/police.json| 527 + .../tc-testing/tc-tests/actions/skbmod.json| 372

[PATCH net-next v2 0/4] tc-testing: Test suite updates

2017-10-13 Thread Lucas Bates
This patch series is a roundup of changes to the tc-testing suite: - Add test cases for police and mirred modules and some coverage in already-submitted test categories - Break the test case files down into more user-friendly sizes - Bug fix to the tdc.py script's handling of the -l

  1   2   3   >