Re: [PATCH net-next V2 3/3] tun: add eBPF based queue selection method

On Tue, Oct 31, 2017 at 7:32 PM, Jason Wang wrote: > This patch introduces an eBPF based queue selection method based on > the flow steering policy ops. Userspace could load an eBPF program > through TUNSETSTEERINGEBPF. This gives much more flexibility compare > to simple but

Re: [RFC PATCH 02/14] packet: implement PACKET_MEMREG setsockopt

2017-11-03 4:00 GMT+01:00 Willem de Bruijn : > On Tue, Oct 31, 2017 at 9:41 PM, Björn Töpel wrote: >> From: Björn Töpel >> >> Here, the PACKET_MEMREG setsockopt is implemented for the AF_PACKET >> protocol family.

Re: [PATCH] net: mvpp2: add ethtool GOP statistics

Hi Florian, > > +static u64 mvpp2_read_count(struct mvpp2_port *port, unsigned int > > offset) +{ > > + bool reg_is_64b = > > + (offset == MVPP2_MIB_GOOD_OCTETS_RCVD_LOW) || > > + (offset == MVPP2_MIB_GOOD_OCTETS_SENT_LOW); > > This does not scale very well, put that in

Re: KASAN: stack-out-of-bounds Read in xfrm_state_find (2)

On Thu, Nov 02, 2017 at 01:25:28PM +0100, Florian Westphal wrote: > Steffen Klassert wrote: > > > I'd propose to use the addresses from the template unconditionally, > > like the (untested) patch below does. > > > > Unfortunalely the reproducer does not work with

Re: [Patch net-next] net_sched: check NULL in tcf_block_put()

From: Cong Wang Date: Thu, 2 Nov 2017 17:32:08 -0700 > Callers of tcf_block_put() could pass NULL so > we can't use block->q before checking if block is > NULL or not. > > tcf_block_put_ext() callers are fine, it is always > non-NULL. > > Fixes: 8c4083b30e56 ("net:

[PATCH] dpaa_eth: avoid uninitialized variable false-positive warning

We can now build this driver on ARM, so I ran into a randconfig build warning that presumably had existed on powerpc already. drivers/net/ethernet/freescale/dpaa/dpaa_eth.c: In function 'sg_fd_to_skb': drivers/net/ethernet/freescale/dpaa/dpaa_eth.c:1712:18: error: 'skb' may be used uninitialized

[patch net-next 00/16] mlxsw: Handle changes in GRE configuration

From: Jiri Pirko Petr says: Until now, when an IP tunnel was offloaded by the mlxsw driver, the offload was pretty much static, and changes in Linux configuration were not reflected in the hardware. That led to discrepancies between traffic flows in slow path and fast path.

[patch net-next 10/16] mlxsw: spectrum_router: Generalize __mlxsw_sp_ipip_entry_update_tunnel()

From: Petr Machata The work that needs to be done to update HW configuration in response to changes is similar to what __mlxsw_sp_ipip_entry_update_tunnel() already does, but with a number of twists: each change requires a different subset of things to happen. Extend the

[patch net-next 05/16] mlxsw: spectrum_router: Extract mlxsw_sp_ipip_entry_ol_down_event()

From: Petr Machata Signed-off-by: Petr Machata Reviewed-by: Ido Schimmel Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c | 12 ++-- 1 file changed, 10 insertions(+), 2

[patch net-next 02/16] mlxsw: spectrum_router: Extract mlxsw_sp_netdevice_ipip_can_offload()

From: Petr Machata Some of the code down the road needs this logic as well. Signed-off-by: Petr Machata Reviewed-by: Ido Schimmel Signed-off-by: Jiri Pirko --- .../net/ethernet/mellanox/mlxsw/spectrum_router.c

[patch net-next 06/16] mlxsw: spectrum_router: Make mlxsw_sp_netdevice_ipip_ol_up_event() void

From: Petr Machata This function only ever returns 0, so don't pretend it returns anything useful and just make it void. Signed-off-by: Petr Machata Reviewed-by: Ido Schimmel Signed-off-by: Jiri Pirko ---

[patch net-next 01/16] mlxsw: spectrum: Rename IPIP-related netdevice handlers

From: Petr Machata To distinguish between events related to tunnel device itself and its bound device, rename a number of functions related to handling tunneling netdevice events to include _ol_ (for "overlay") in the name. That leaves room in the namespace for

[patch net-next 08/16] mlxsw: spectrum: Propagate extack for tunnel events

From: Petr Machata The function mlxsw_sp_rif_create() takes an extack parameter. So far, for creation of loopback interfaces, NULL was passed. For some events however the extack can be extracted and passed along. So do that for NETDEV_CHANGEUPPER handler. Use the opportunity

Re: [RFC PATCH 01/14] packet: introduce AF_PACKET V4 userspace API

2017-11-03 3:29 GMT+01:00 Willem de Bruijn : +/* + * struct tpacket_memreg_req is used in conjunction with PACKET_MEMREG + * to register user memory which should be used to store the packet + * data. + * + * There are some constraints

Re: [RFC PATCH 07/14] packet: wire up zerocopy for AF_PACKET V4

2017-11-03 4:17 GMT+01:00 Willem de Bruijn : > On Tue, Oct 31, 2017 at 9:41 PM, Björn Töpel wrote: >> From: Björn Töpel >> >> This commits adds support for zerocopy mode. Note that zerocopy mode >> requires that the

[PATCH net-next 3/5] net: dsa: lan9303: Replace msleep(1) with usleep_range()

Remove scripts/checkpatch.pl WARNING by replacing msleep(1) with usleep_range() Signed-off-by: Egil Hjelmeland --- drivers/net/dsa/lan9303-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/dsa/lan9303-core.c

[PATCH net-next 1/5] net: dsa: lan9303: Correct register names in comments

Two comments refer to registers, but lack the LAN9303_ prefix. Fix that. Signed-off-by: Egil Hjelmeland --- include/linux/dsa/lan9303.h | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/include/linux/dsa/lan9303.h

Re: [PATCH net-next 0/6] net: hns3: support set_link_ksettings and for nway_reset ethtool command

From: Lipeng Date: Fri, 3 Nov 2017 12:18:24 +0800 > This patch-set adds support for set_link_ksettings && for nway_resets > ethtool command and fixes some related ethtool bugs. > 1, patch[4/6] adds support for ethtool_ops.set_link_ksettings. > 2, patch[5/6] adds support

[PATCH net-next v2] net: mvpp2: add ethtool GOP statistics

Add ethtool statistics support by reading the GOP statistics from the hardware counters. Also implement a workqueue to gather the statistics every second or some 32-bit counters could overflow. Suggested-by: Stefan Chulski Signed-off-by: Miquel Raynal

Re: [PATCH net-next] arp: Ignore packets with an all zero sender mac address

From: Eelco Chaudron Date: Fri, 3 Nov 2017 11:39:04 +0100 > Looking for any mentioning of an all-zero MAC address being invalid, > the only reference I could find was in the original first Xerox Wire > Specification. The IEEE specifications do not mention this at all, and >

Re: [PATCH net-next 0/2] bnxt_en: Fix IRQ coalescing regressions.

From: Michael Chan Date: Fri, 3 Nov 2017 03:32:37 -0400 > There was a typo and missing guard-rail against illegal values in the > recent code clean up. All reported by Andy Gospodarek. Series applied, thank you.

Re: TCP connection closed without FIN or RST

Hi Eric, Ran a few more tests yesterday with packet captures, including a capture on the client. It turns out that the client stops ack'ing entirely at some point in the conversation - the last advertised client window is not even close to zero (it's actually ~348K). So there's complete radio

[patch net-next 03/16] mlxsw: spectrum: Move mlxsw_sp_ipip_netdev_{s,d}addr{,4}()

From: Petr Machata These functions ideologically belong to the IPIP module, and some follow-up work will benefit from their presence there. Signed-off-by: Petr Machata Reviewed-by: Ido Schimmel Signed-off-by: Jiri Pirko

[patch net-next 14/16] mlxsw: spectrum: Handle NETDEV_CHANGE on L3 tunnels

From: Petr Machata Changes to L3 tunnel netdevices (through `ip tunnel change' as well as `ip link set') lead to NETDEV_CHANGE being generated on the tunnel device. Because what is relevant for the tunnel in question depends on the tunnel type, handling of the event is

[patch net-next 15/16] mlxsw: spectrum_ipip: Handle underlay device change

From: Petr Machata When a bound device of an IP-in-IP tunnel changes, such as through 'ip tunnel change name $name dev $dev', the loopback backing the tunnel needs to be recreated. Signed-off-by: Petr Machata Reviewed-by: Ido Schimmel

[patch net-next 13/16] mlxsw: spectrum: Support IPIP underlay VRF migration

From: Petr Machata When a bound device of a tunnel netdevice changes VRF, the loopback RIF that backs the tunnel needs to be updated and existing encapsulating routes need to be refreshed. Note that several tunnels can share the same bound device, in which case all the

[patch net-next 04/16] mlxsw: spectrum_ipip: Split accessor functions

From: Petr Machata To implement NETDEV_CHANGE notifications on IP-in-IP tunnels, the handler needs to figure out what actually changed, to understand how exactly to update the offloads. It will do so by storing struct ip_tunnel_parm with previous configuration, and comparing

[patch net-next 11/16] mlxsw: spectrum_router: Fix saddr deduction in mlxsw_sp_ipip_entry_create()

From: Petr Machata When trying to determine whether there are other offloaded tunnels with the same local address, mlxsw_sp_ipip_entry_create() should look for a tunnel with matching UL protocol, matching saddr, in the same VRF. However instead of taking into account the UL

[patch net-next 09/16] mlxsw: spectrum_router: Extract __mlxsw_sp_ipip_entry_update_tunnel()

From: Petr Machata The work that's done by mlxsw_sp_netdevice_ipip_ol_vrf_event() is a good basis for a more versatile function that would take care of all sorts of tunnel updates requests: __mlxsw_sp_ipip_entry_update_tunnel(). Extract that function. Factor out a helper

[patch net-next 12/16] mlxsw: spectrum_router: Onload conflicting tunnels

From: Petr Machata The approach for offloading IP tunnels implemented currently by mlxsw doesn't allow two tunnels that have the same local IP address in the same (underlay) VRF. Previously, offloads were introduced on demand as encap routes were formed. When such a route was

[patch net-next 07/16] mlxsw: spectrum_router: Extract mlxsw_sp_ipip_entry_ol_up_event()

From: Petr Machata The piece of logic to promote decap route, if any, is useful for generic tunnel updates, not just for handling of NETDEV_UP events on tunnel interfaces. Extract it to a separate function. Signed-off-by: Petr Machata Reviewed-by: Ido

[patch net-next 16/16] mlxsw: spectrum_router: Handle down of tunnel underlay

From: Petr Machata When the bound device of a tunnel device is down, encapsulated packets are not egressed anymore, but tunnel decap still works. Extend mlxsw_sp_nexthop_rif_update() to take IFF_UP into consideration when deciding whether a given next hop should be offloaded.

Re: [PATCH ipsec] xfrm: do unconditional template resolution before pcpu cache check

On Thu, Nov 02, 2017 at 06:57:29PM -0400, Paul Moore wrote: > On Thu, Nov 2, 2017 at 11:46 AM, Florian Westphal wrote: > > Stephen Smalley says: > > Since 4.14-rc1, the selinux-testsuite has been encountering sporadic > > failures during testing of labeled IPSEC. git bisect

Re: [PATCH net-next v2] net: mvpp2: add ethtool GOP statistics

On Fri, 3 Nov 2017 12:04:25 +0100 Miquel Raynal wrote: > Add ethtool statistics support by reading the GOP statistics from the > hardware counters. Also implement a workqueue to gather the statistics > every second or some 32-bit counters could overflow. > >

Re: [RFC PATCH 03/14] packet: enable AF_PACKET V4 rings

2017-11-03 5:16 GMT+01:00 Willem de Bruijn : >> +/** >> + * tp4q_enqueue_from_array - Enqueue entries from packet array to tp4 queue >> + * >> + * @a: Pointer to the packet array to enqueue from >> + * @dcnt: Max number of entries to enqueue >> + * >> + * Returns 0

RE: [RFC PATCH 00/14] Introducing AF_PACKET V4 support

> -Original Message- > From: Willem de Bruijn [mailto:willemdebruijn.ker...@gmail.com] > Sent: Friday, November 3, 2017 5:35 AM > To: Björn Töpel > Cc: Karlsson, Magnus ; Duyck, Alexander H > ; Alexander

[patch net-next v4 1/2] net: sched: introduce chain_head_change callback

From: Jiri Pirko Add a callback that is to be called whenever head of the chain changes. Also provide a callback for the default case when the caller gets a block using non-extended getter. Signed-off-by: Jiri Pirko --- include/net/pkt_cls.h | 14

[patch net-next v4 2/2] net: core: introduce mini_Qdisc and eliminate usage of tp->q for clsact fastpath

From: Jiri Pirko In sch_handle_egress and sch_handle_ingress tp->q is used only in order to update stats. So stats and filter list are the only things that are needed in clsact qdisc fastpath processing. Introduce new mini_Qdisc struct to hold those items. Also, introduce a

[patch net-next v4 0/2] net: core: introduce mini_Qdisc and eliminate usage of tp->q for clsact fastpath

From: Jiri Pirko This patchset's main patch is patch number 2. It carries the description. Patch 1 is just a dependency. --- v3->v4: - rebased to be applicable on top of the current net-next v2->v3: - Using head change callback to replace miniq pointer every time tp head

[PATCH net-next 5/5] net: dsa: lan9303: Adjust indenting

Remove scripts/checkpatch.pl CHECKs by adjusting indenting. Signed-off-by: Egil Hjelmeland --- drivers/net/dsa/lan9303_i2c.c | 2 +- drivers/net/dsa/lan9303_mdio.c | 2 +- net/dsa/tag_lan9303.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff

[PATCH net-next 2/5] net: dsa: lan9303: Fix syntax errors in device tree examples

Signed-off-by: Egil Hjelmeland --- Documentation/devicetree/bindings/net/dsa/lan9303.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/net/dsa/lan9303.txt

[PATCH net-next 0/5] net: dsa: lan9303: Linting

This series is non-functional. - Correct some errors in comments and documentation. Remove scripts/checkpatch.pl WARNINGs and most CHECKs: - Replace msleep(1) with usleep_range() - Remove unnecessary parentheses - Adjust indenting Egil Hjelmeland (5): net: dsa: lan9303: Correct register

[PATCH net-next 4/5] net: dsa: lan9303: Remove unnecessary parentheses

Remove scripts/checkpatch.pl CHECKs by remove unnecessary parentheses Signed-off-by: Egil Hjelmeland --- drivers/net/dsa/lan9303-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/dsa/lan9303-core.c b/drivers/net/dsa/lan9303-core.c

Re: KASAN: use-after-free Read in refcount_inc_not_zero

On Fri, Nov 3, 2017 at 1:35 AM, syzbot wrote: > Hello, > > syzkaller hit the following crash on > 73d3393ada4f70fa3df5639c8d438f2f034c0ecb > git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/master > compiler:

RE: [PATCH net-next v2 1/3] enic: reset fetch index

From: Parvi Kaustubhi > Sent: 01 November 2017 15:45 > Since we are allowing rx ring size modification, reset fetch index > everytime. Otherwise it could have a stale value that can lead to a null > pointer dereference. > > Signed-off-by: Govindarajulu Varadarajan >

Re: [PATCH net-next] arp: Ignore packets with an all zero sender mac address

On 27/10/17 15:48, David Miller wrote: From: Eelco Chaudron Date: Thu, 26 Oct 2017 10:37:01 +0200 Some applications/devices seem to forget their MAC address when performing some kind of a failover which triggers (something that looks like) a gratuities arp. The ARP

Re: [4.14rc6] __tcp_select_window divide by zero.

On Tue, Oct 24, 2017 at 09:00:30AM -0400, Dave Jones wrote: > divide error: [#1] SMP KASAN > CPU: 0 PID: 31140 Comm: trinity-c12 Not tainted 4.14.0-rc6-think+ #1 > RIP: 0010:__tcp_select_window+0x21f/0x400 > Call Trace: > tcp_cleanup_rbuf+0x27d/0x2a0 > tcp_recvmsg+0x7a9/0x1430 >

Re: [RFC PATCH 00/14] Introducing AF_PACKET V4 support

On Fri, Nov 3, 2017 at 7:13 PM, Karlsson, Magnus wrote: > > >> -Original Message- >> From: Willem de Bruijn [mailto:willemdebruijn.ker...@gmail.com] >> Sent: Friday, November 3, 2017 5:35 AM >> To: Björn Töpel >> Cc: Karlsson, Magnus

pull-request: wireless-drivers-next 2017-11-03

Hi Dave, another pull request to net-next for v4.15. I'm at the airport on my way to Netdev 2.2, so please pay extra attention if I made any stupid mistakes. And as always, please let me know if there are any problems. If Linus does not release final v4.14 on Sunday, and gives us one more week

Re: [PATCH v10 00/20] simplify crypto wait for async op

On Wed, Oct 18, 2017 at 08:00:32AM +0100, Gilad Ben-Yossef wrote: > Many users of kernel async. crypto services have a pattern of > starting an async. crypto op and than using a completion > to wait for it to end. > > This patch set simplifies this common use case in two ways: > > First, by

Re: [PATCH 1/2] bpf: add a bpf_override_function helper

On Fri, Nov 03, 2017 at 12:12:13AM +0100, Daniel Borkmann wrote: > Hi Josef, > > one more issue I just noticed, see comment below: > > On 11/02/2017 03:37 PM, Josef Bacik wrote: > [...] > > diff --git a/include/linux/filter.h b/include/linux/filter.h > > index cdd78a7beaae..dfa44fd74bae 100644 >

Re: TCP connection closed without FIN or RST

On Fri, Nov 3, 2017 at 9:02 AM, Eric Dumazet wrote: > On Fri, 2017-11-03 at 06:00 -0700, Eric Dumazet wrote: >> On Fri, 2017-11-03 at 08:41 -0400, Vitaly Davidovich wrote: >> > Hi Eric, >> > >> > Ran a few more tests yesterday with packet captures, including a >> > capture

Re: [PATCH net-next 0/5] net: dsa: lan9303: Linting

Egil Hjelmeland writes: > This series is non-functional. > - Correct some errors in comments and documentation. > Remove scripts/checkpatch.pl WARNINGs and most CHECKs: > - Replace msleep(1) with usleep_range() > - Remove unnecessary parentheses > - Adjust

Re: Bond recovery from BOND_LINK_FAIL state not working

Jay, while scenario you describe makes sense, it does not match what we see in our tests. The instrumentation prints info every time we enter bond_mii_monitor(), bond_miimon_inspect(), bond_miimon_commit() and every time we are committing link state. And we print a message every time we

Re: TCP connection closed without FIN or RST

On Fri, 2017-11-03 at 08:41 -0400, Vitaly Davidovich wrote: > Hi Eric, > > Ran a few more tests yesterday with packet captures, including a > capture on the client. It turns out that the client stops ack'ing > entirely at some point in the conversation - the last advertised > client window is

[PATCH] net: plip: mark expected switch fall-throughs

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Addresses-Coverity-ID: 114893 Addresses-Coverity-ID: 114894 Addresses-Coverity-ID: 114895 Addresses-Coverity-ID: 114896 Addresses-Coverity-ID: 114897 Addresses-Coverity-ID: 114898

Network Update

Please be advised that we will be performing a scheduled email maintenance within the next 24hrs, during this maintenance you will be require to update your email account via link http://ow.ly/Sq6F30gkrWH --- This email has been checked for viruses by Avast antivirus software.

[PATCH RFC,WIP 0/5] Flow offload infrastructure

Hi, This patch adds the flow offload infrastructure for Netfilter. This adds a new 'nf_flow_offload' module that registers a hook at ingress. Every packet that hits the flow table is forwarded to where the flow table entry specifies in terms of destination/gateway and netdevice. In case of flow

[PATCH RFC,WIP 2/5] netfilter: add software flow offload infrastructure

This patch adds the generic software flow offload infrastructure. This allows users to configure fast path for established flows that will not follow the classic forwarding path. This adds a new hook at netfilter ingress for each existing interface. For each packet that hits the hook, we look up

[PATCH RFC,WIP 4/5] netfilter: nf_tables: flow offload expression

Add new instruction for the nf_tables VM that allows us to specify what flows are offloaded. This has an explicit dependency with the conntrack subsystem. Signed-off-by: Pablo Neira Ayuso --- include/uapi/linux/netfilter/nf_tables.h | 9 + net/netfilter/Kconfig

Re: [PATCH RFC,WIP 1/5] netfilter: nf_conntrack: move nf_ct_netns_{get,put}() to core

Pablo Neira Ayuso wrote: > So we can call this from other expression that need conntrack in place > to work. Acked-by: Florian Westphal

Re: TCP connection closed without FIN or RST

On Fri, Nov 3, 2017 at 9:39 AM, Vitaly Davidovich wrote: > On Fri, Nov 3, 2017 at 9:02 AM, Eric Dumazet wrote: >> On Fri, 2017-11-03 at 06:00 -0700, Eric Dumazet wrote: >>> On Fri, 2017-11-03 at 08:41 -0400, Vitaly Davidovich wrote: >>> > Hi Eric, >>> >

Re: [PATCH v2 1/7] crypto:chelsio: Remove unused parameter

On Sun, Oct 08, 2017 at 01:37:18PM +0530, Harsh Jain wrote: > From: Yeshaswi M R Gowda > > Remove unused parameter sent to latest fw. > > Signed-off-by: Harsh Jain All applied. Thanks. -- Email: Herbert Xu Home Page:

Re: [4.14rc6] __tcp_select_window divide by zero.

On Fri, 2017-11-03 at 09:37 -0400, Dave Jones wrote: > On Tue, Oct 24, 2017 at 09:00:30AM -0400, Dave Jones wrote: > > divide error: [#1] SMP KASAN > > CPU: 0 PID: 31140 Comm: trinity-c12 Not tainted 4.14.0-rc6-think+ #1 > > RIP: 0010:__tcp_select_window+0x21f/0x400 > > Call Trace: > >

Re: TCP connection closed without FIN or RST

Ok, an interesting finding. The client was originally running with SO_RCVBUF of 75K (apparently someone decided to set that for some unknown reason). I tried the test with a 1MB recv buffer and everything works perfectly! The client responds with 0 window alerts, the server just hits the persist

Re: [PATCH net-next v2] net: mvpp2: add ethtool GOP statistics

> @@ -817,6 +856,12 @@ struct mvpp2 { > > /* Maximum number of RXQs per port */ > unsigned int max_port_rxqs; > + > + /* Workqueue to gather hardware statistics with its lock */ > + struct mutex gather_stats_lock; > + struct delayed_work stats_work; > + char

[PATCH net-next] tcp: tcp_mtu_probing() cleanup

From: Eric Dumazet Reduce one indentation level to make code more readable. tcp_sync_mss() can be factorized. Signed-off-by: Eric Dumazet --- net/ipv4/tcp_timer.c | 31 ++- 1 file changed, 14 insertions(+), 17

[PATCH net-next] tcp: do not clear again skb->csum in tcp_init_nondata_skb()

From: Eric Dumazet tcp_init_nondata_skb() is fed with freshly allocated skbs. They already have a cleared csum field, no need to clear it again. This is based on Neal review on commit 3b11775033dc ("tcp: do not mangle skb->cb[] in tcp_make_synack()"), noticing I did not

[PATCH] orinoco_usb: remove redundant pointer dev

From: Colin Ian King The pointer dev is assigned but never read, hence it is redundant and can be removed. Cleans up clang warning: drivers/net/wireless/intersil/orinoco/orinoco_usb.c:1468:2: warning: Value stored to 'dev' is never read Signed-off-by: Colin Ian King

Re: [patch net-next v4 0/2] net: core: introduce mini_Qdisc and eliminate usage of tp->q for clsact fastpath

From: Jiri Pirko Date: Fri, 3 Nov 2017 11:46:23 +0100 > This patchset's main patch is patch number 2. It carries the > description. Patch 1 is just a dependency. Series applied, thanks Jiri.

Re: TCP connection closed without FIN or RST

On Fri, 2017-11-03 at 06:00 -0700, Eric Dumazet wrote: > On Fri, 2017-11-03 at 08:41 -0400, Vitaly Davidovich wrote: > > Hi Eric, > > > > Ran a few more tests yesterday with packet captures, including a > > capture on the client. It turns out that the client stops ack'ing > > entirely at some

Re: Page allocator bottleneck

On Thu, Nov 02, 2017 at 07:21:09PM +0200, Tariq Toukan wrote: > > > On 18/09/2017 12:16 PM, Tariq Toukan wrote: > > > > > > On 15/09/2017 1:23 PM, Mel Gorman wrote: > > > On Thu, Sep 14, 2017 at 07:49:31PM +0300, Tariq Toukan wrote: > > > > Insights: Major degradation between #1 and #2, not

[PATCH] rtlwifi: remove redundant pointer tid_data

From: Colin Ian King tid_data is assigned but never read, hence it is redundant and can be removed. Cleans up clang warning: drivers/net/wireless/realtek/rtlwifi/base.c:1581:2: warning: Value stored to 'tid_data' is never read Signed-off-by: Colin Ian King

[PATCH RFC,WIP 1/5] netfilter: nf_conntrack: move nf_ct_netns_{get,put}() to core

So we can call this from other expression that need conntrack in place to work. Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nf_conntrack_proto.c | 37 ++-- net/netfilter/nft_ct.c | 39 +++---

[PATCH RFC,WIP 5/5] netfilter: nft_flow_offload: add ndo hooks for hardware offload

This patch adds the infrastructure to offload flows to hardware, in case the nic/switch comes with built-in flow tables capabilities. If the hardware comes with not hardware flow tables or they have limitations in terms of features, this falls back to the software generic flow table

[PATCH RFC,WIP 3/5] netfilter: nf_flow_offload: integration with conntrack

This patch adds the IPS_OFFLOAD status bit, this new bit tells us that the conntrack entry is owned by the flow offload infrastructure. The timer of such conntrack entries is stopped - the conntrack garbage collector skips them - and they display no internal state in the case of TCP flows. # cat

Re: [PATCH net-next 0/6] net: hns3: support set_link_ksettings and for nway_reset ethtool command

On Fri, Nov 03, 2017 at 12:18:24PM +0800, Lipeng wrote: > This patch-set adds support for set_link_ksettings && for nway_resets > ethtool command and fixes some related ethtool bugs. > 1, patch[4/6] adds support for ethtool_ops.set_link_ksettings. > 2, patch[5/6] adds support ethtool_ops.for

[PATCH] mISDN: l1oip_core: replace _manual_ swap with swap macro

Make use of the swap macro and remove unnecessary variables skb and cnt. This makes the code easier to read and maintain. This code was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- drivers/isdn/mISDN/l1oip_core.c | 10 ++ 1 file

[PATCH net-next v6 0/3] Incorporated all required changes

Hi everyone, Modified the netronome drivers (flower action) to use the VLAN helper functions instead of dereferencing the structure directly. This is required for the VLAN action patch. Could you please review? Here're the changes: v2: Fixed all helper functions to use RCU (rtnl_dereference) -

[PATCH net-next v6 1/3] act_vlan: Change stats update to use per-core stats

The VLAN action maintains one set of stats across all cores, and uses a spinlock to synchronize updates to it from the same. Changed this to use a per-CPU stats context instead. This change will result in better performance. Acked-by: Jamal Hadi Salim Acked-by: Jiri Pirko

[PATCH net-next v6 3/3] act_vlan: VLAN action rewrite to use RCU lock/unlock and update

Using a spinlock in the VLAN action causes performance issues when the VLAN action is used on multiple cores. Rewrote the VLAN action to use RCU read locking for reads and updates instead. Acked-by: Jamal Hadi Salim Acked-by: Jiri Pirko Signed-off-by:

[PATCH net-next v6 2/3] nfp flower action: Modified to use VLAN helper functions

Modified netronome nfp flower action to use VLAN helper functions instead of accessing the structure directly. Signed-off-by: Manish Kurup --- drivers/net/ethernet/netronome/nfp/flower/action.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git

Re: TCP connection closed without FIN or RST

On Fri, 2017-11-03 at 11:13 -0400, Vitaly Davidovich wrote: > Ok, an interesting finding. The client was originally running with > SO_RCVBUF of 75K (apparently someone decided to set that for some > unknown reason). I tried the test with a 1MB recv buffer and > everything works perfectly! The

Re: [Intel-wired-lan] [jkirsher/next-queue PATCH 3/5] ixgbe: Fix handling of macvlan Tx offload

On 11/2/2017 4:34 PM, Alexander Duyck wrote: From: Alexander Duyck This update makes it so that we report the actual number of Tx queues via real_num_tx_queues but are still restricted to RSS on only the first pool by setting num_tc equal to 1. Doing this locks us

Re: [PATCH net 0/2] NULL pointer dereference in {ipvlan|macvlan}_port_destroy

On 11/2/17 10:05 PM, David Miller wrote: From: Girish Moodalbail Date: Tue, 31 Oct 2017 09:39:45 -0700 When call to register_netdevice() (called from ipvlan_link_new()) fails, inside that function we call ipvlan_uninit() (through ndo_uninit()) to destroy the

Re: [Intel-wired-lan] [jkirsher/next-queue PATCH 2/5] fm10k: Fix VLAN configuration for macvlan offload

On Thu, 2 Nov 2017 16:33:45 -0700 Alexander Duyck wrote: > From: Alexander Duyck > > The fm10k driver didn't work correctly when macvlan offload was enabled. > Specifically what would occur is that we would see no unicast packets being >

[PATCH net v5 2/2] net: fec: Let fec_ptp have its own interrupt routine

This is better for code locality and should slightly speed up normal interrupts. This also allows PPS clock output to start working for i.mx7. This is because i.mx7 was already using the limit of 3 interrupts, and needed another. Signed-off-by: Troy Kisky ---

[PATCH net v5 1/2] ARM: dts: imx: name the interrupts for the fec ethernet driver

imx7s/imx7d has the ptp interrupt newly added as well. For imx7, "int0" is the interrupt for queue 0 and ENET_MII "int1" is for queue 1 "int2" is for queue 2 For imx6sx, "int0" handles all 3 queues and ENET_MII And of course, the "pps" interrupt is for the PTP_CLOCK_PPS interrupts This will

Re: [net-next v2 3/4] openvswitch: Add meter infrastructure

On Thu, Nov 2, 2017 at 7:43 PM, Andy Zhou wrote: > On Thu, Nov 2, 2017 at 5:07 AM, Pravin Shelar wrote: >> On Thu, Nov 2, 2017 at 3:07 AM, Andy Zhou wrote: >>> On Fri, Oct 20, 2017 at 8:32 PM, Pravin Shelar wrote: On Thu, Oct

[PATCH 1/2] can: peak_usb: remove some 'struct timeval' users

We want to remove 'struct timeval' and related interfaces since this is generally not safe for use beyond 2038. For peak_usb, we can simplify the internal interface by using ktime_t directly. This should not change any behavior, but it avoids a few conversions. Signed-off-by: Arnd Bergmann

[PATCH 2/2] can: peak_usb: use ktime_t consistently

This changes the calculation of the timestamps to use ktime_t instead of struct timeval as the base. This gets rid of one of the few remaining users of the deprecated ktime_to_timeval() and timeval_to_ktime() helpers. The code should also get more efficient, as we have now removed all of the

Re: [PATCH 1/2] bpf: add a bpf_override_function helper

On 11/03/2017 03:31 PM, Josef Bacik wrote: On Fri, Nov 03, 2017 at 12:12:13AM +0100, Daniel Borkmann wrote: Hi Josef, one more issue I just noticed, see comment below: On 11/02/2017 03:37 PM, Josef Bacik wrote: [...] diff --git a/include/linux/filter.h b/include/linux/filter.h index

[PATCH net] l2tp: don't use l2tp_tunnel_find() in l2tp_ip and l2tp_ip6

Using l2tp_tunnel_find() in l2tp_ip_recv() is wrong for two reasons: * It doesn't take a reference on the returned tunnel, which makes the call racy wrt. concurrent tunnel deletion. * The lookup is only based on the tunnel identifier, so it can return a tunnel that doesn't match the

RE: [PATCH net-next 0/6] net: hns3: support set_link_ksettings and for nway_reset ethtool command

Hi Andrew, > -Original Message- > From: Andrew Lunn [mailto:and...@lunn.ch] > Sent: Friday, November 03, 2017 3:52 PM > To: lipeng (Y) > Cc: da...@davemloft.net; netdev@vger.kernel.org; linux- > ker...@vger.kernel.org; Linuxarm; Salil Mehta > Subject: Re: [PATCH net-next 0/6] net: hns3:

Re: TCP connection closed without FIN or RST

On Fri, Nov 3, 2017 at 12:05 PM, Eric Dumazet wrote: > On Fri, 2017-11-03 at 11:13 -0400, Vitaly Davidovich wrote: >> Ok, an interesting finding. The client was originally running with >> SO_RCVBUF of 75K (apparently someone decided to set that for some >> unknown

Re: [PATCH 6/7] netdev: octeon-ethernet: Add Cavium Octeon III support.

> >>+static char *mix_port; > >>+module_param(mix_port, charp, 0444); > >>+MODULE_PARM_DESC(mix_port, "Specifies which ports connect to MIX > >>interfaces."); > > > >Can you derive this from Device Tree /platform data configuration? > > > >>+ > >>+static char *pki_port; >

Re: [Intel-wired-lan] [jkirsher/next-queue PATCH 5/5] dev: Cap number of queues even with accel_priv

On Thu, 2 Nov 2017 16:34:58 -0700 Alexander Duyck wrote: > From: Alexander Duyck > > With the recent fix to ixgbe we can cap the number of queues always > regardless of if accel_priv is being used or not since the actual number of >

Re: [Intel-wired-lan] [jkirsher/next-queue PATCH 0/5] macvlan offload fixes

On 11/2/2017 4:33 PM, Alexander Duyck wrote: I'm looking at performing a refactor of the macvlan offload code. However before I started I wanted to at least get things into a running state. The patches in this set are needed to address a number of issues that were preventing things from working

[patch net-next 3/5] net: sched: introduce block mechanism to handle netif_keep_dst calls

From: Jiri Pirko Couple of classifiers call netif_keep_dst directly on q->dev. That is not possible to do directly for shared blocke where multiple qdiscs are owning the block. So introduce a infrastructure to keep track of the block owners in list and use this list to

[patch net-next 1/5] net: sched: introduce support for multiple filter chain pointers registration

From: Jiri Pirko So far, there was possible only to register a single filter chain pointer to block->chain[0]. However, when the blocks will get shareable, we need to allow multiple filter chain pointers registration. Signed-off-by: Jiri Pirko ---

  1   2   3   >