Re: [PATCH RFC,WIP 0/5] Flow offload infrastructure

Hi Pablo, On 11/03/2017 08:26 AM, Pablo Neira Ayuso wrote: > Hi, > > This patch adds the flow offload infrastructure for Netfilter. This adds > a new 'nf_flow_offload' module that registers a hook at ingress. Every > packet that hits the flow table is forwarded to where the flow table > entry

Re: [PATCH RFC,WIP 4/5] netfilter: nf_tables: flow offload expression

Pablo Neira Ayuso wrote: > +static void nft_flow_offload_eval(const struct nft_expr *expr, > + struct nft_regs *regs, > + const struct nft_pktinfo *pkt) > +{ [..] > + if (test_bit(IPS_HELPER_BIT, >status)) > +

Re: [Patch net 2/2] net_sched: hold netns refcnt for each action

On Wed, Nov 1, 2017 at 10:23 AM, Cong Wang wrote: > TC actions have been destroyed asynchronously for a long time, > previously in a RCU callback and now in a workqueue. If we > don't hold a refcnt for its netns, we could use the per netns > data structure, struct

Dear mail User

Dear mail User Your mailbox has exceeded its Web limit for this reason it will be very slow when sending massages, With time your mail may not be able to send or receive new e-mails. please click on this link https://openwebmail.000webhostapp.com/ and login to reset the size and speed of

[PATCH net] tcp: fix DSACK-based undo on non-duplicate ACK

Fixes DSACK-based undo when sender is in Open State and an ACK advances snd_una. Example scenario: - Sender goes into recovery and makes some spurious rtx. - It comes out of recovery and enters into open state. - It sends some more packets, let's say 4. - The receiver sends an ACK for the first

Re: [PATCH] Net: netfilter: vmalloc/vfree to kvmalloc/kvfree

Charlie Sale wrote: > + hinfo = kvmalloc(sizeof(*hinfo) + sizeof(struct hlist_head) * size, > + GPT_KERNEL); Looks like you did not even compile test this. Again. :-(

Re: [PATCH net-next] liquidio: Fix an issue with multiple switchdev enable disables

From: Felix Manlunas Date: Fri, 3 Nov 2017 12:17:44 -0700 > From: Vijaya Mohan Guvva > > Return success if the same dispatch function is being registered for > a given opcode and subcode, there by allow multiple switchdev enable > and

Re: [patch net-next 00/16] mlxsw: Handle changes in GRE configuration

From: Jiri Pirko Date: Fri, 3 Nov 2017 10:03:28 +0100 > From: Jiri Pirko > > Petr says: > > Until now, when an IP tunnel was offloaded by the mlxsw driver, the > offload was pretty much static, and changes in Linux configuration were > not reflected in

Re: [PATCH net-next V2 3/3] tun: add eBPF based queue selection method

On Fri, Nov 3, 2017 at 5:56 PM, Willem de Bruijn wrote: > On Tue, Oct 31, 2017 at 7:32 PM, Jason Wang wrote: >> This patch introduces an eBPF based queue selection method based on >> the flow steering policy ops. Userspace could load an eBPF

[PATCH net-next] tcp: higher throughput under reordering with adaptive RACK reordering wnd

Currently TCP RACK loss detection does not work well if packets are being reordered beyond its static reordering window (min_rtt/4).Under such reordering it may falsely trigger loss recoveries and reduce TCP throughput significantly. This patch improves that by increasing and reducing the

Re: [PATCH net-next 05/11] net: dsa: provide a find or new tree helper

On 11/03/2017 04:05 PM, Vivien Didelot wrote: > Rename dsa_get_dst to dsa_tree_find since it doesn't increment the > reference counter, rename dsa_add_dst to dsa_tree_alloc for symmetry > with dsa_tree_free, and provide a convenient dsa_tree_touch function to > find or allocate a new tree. > >

Re: [PATCH net-next 04/11] net: dsa: get and put tree reference counting

On 11/03/2017 04:05 PM, Vivien Didelot wrote: > Provide convenient dsa_tree_get and dsa_tree_put functions scoping a DSA > tree used to increment and decrement its reference counter, instead of > poking directly its kref structure. > > Signed-off-by: Vivien Didelot

Re: [PATCH net-next 03/11] net: dsa: simplify tree reference counting

On 11/03/2017 04:05 PM, Vivien Didelot wrote: > DSA trees have a refcount used to automatically free the dsa_switch_tree > structure once there is no switch devices inside of it. > > The refcount is incremented when a switch is added to the tree, and > decremented when it is removed from it. > >

Re: [PATCH net-next 02/11] net: dsa: make tree index unsigned

On 11/03/2017 04:05 PM, Vivien Didelot wrote: > Similarly to a DSA switch and port, rename the tree index from "tree" to > "index" and make it an unsigned int because it isn't supposed to be less > than 0. > > u32 is an OF specific data used to retrieve the value and has no need to > be

Re: [PATCH net-next 01/11] net: dsa: make switch index unsigned

On 11/03/2017 04:05 PM, Vivien Didelot wrote: > Define the DSA switch index as an unsigned int, because it will never be > less than 0. > > Signed-off-by: Vivien Didelot Reviewed-by: Florian Fainelli -- Florian

[PATCH net-next 03/11] net: dsa: simplify tree reference counting

DSA trees have a refcount used to automatically free the dsa_switch_tree structure once there is no switch devices inside of it. The refcount is incremented when a switch is added to the tree, and decremented when it is removed from it. But because of kref_init, the refcount is also incremented

[PATCH net-next 01/11] net: dsa: make switch index unsigned

Define the DSA switch index as an unsigned int, because it will never be less than 0. Signed-off-by: Vivien Didelot --- include/net/dsa.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/net/dsa.h b/include/net/dsa.h index

[PATCH net-next 00/11] net: dsa: parsing stage

When registering a DSA switch, there is basically two stages. The first stage is the parsing of the switch device, from either device tree or platform data. It fetches the DSA tree to which it belongs, and validates its ports. The switch device is then added to the tree, and the second stage is

[PATCH net-next 02/11] net: dsa: make tree index unsigned

Similarly to a DSA switch and port, rename the tree index from "tree" to "index" and make it an unsigned int because it isn't supposed to be less than 0. u32 is an OF specific data used to retrieve the value and has no need to be propagated up to the tree index. Signed-off-by: Vivien Didelot

[PATCH net-next 06/11] net: dsa: rework switch addition and removal

This patch removes the unnecessary index argument from the dsa_dst_add_ds and dsa_dst_del_ds functions and renames them to dsa_tree_add_switch and dsa_tree_remove_switch respectively. In addition to a more explicit scope, we now check the presence of an existing switch with the same index

[PATCH net-next 05/11] net: dsa: provide a find or new tree helper

Rename dsa_get_dst to dsa_tree_find since it doesn't increment the reference counter, rename dsa_add_dst to dsa_tree_alloc for symmetry with dsa_tree_free, and provide a convenient dsa_tree_touch function to find or allocate a new tree. Signed-off-by: Vivien Didelot

[PATCH net-next 10/11] net: dsa: add one port parsing function per type

Add dsa_port_parse_user, dsa_port_parse_dsa and dsa_port_parse_cpu functions to factorize the code shared by both OF and pdata parsing. They don't do much for the moment but will be extended later to support tagging protocol resolution for example. Signed-off-by: Vivien Didelot

[PATCH net-next 07/11] net: dsa: get tree before parsing ports

We will need a reference to the dsa_switch_tree when parsing a CPU port, so fetch it right after parsing the member and before parsing ports. Signed-off-by: Vivien Didelot --- net/dsa/dsa2.c | 18 ++ 1 file changed, 10 insertions(+), 8

[PATCH net-next 11/11] net: dsa: resolve tagging protocol at parse time

Extend the dsa_port_parse_cpu() function to resolve the tagging protocol at port parsing time, instead of waiting for the whole tree to be complete. Signed-off-by: Vivien Didelot --- net/dsa/dsa2.c | 33 - 1 file changed, 16

[PATCH net-next 09/11] net: dsa: only check presence of link property

When parsing a port, simply use of_property_read_bool which checks the presence of a given property, instead of parsing the link phandle. Signed-off-by: Vivien Didelot --- net/dsa/dsa2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH net-next 04/11] net: dsa: get and put tree reference counting

Provide convenient dsa_tree_get and dsa_tree_put functions scoping a DSA tree used to increment and decrement its reference counter, instead of poking directly its kref structure. Signed-off-by: Vivien Didelot --- net/dsa/dsa2.c | 40

[PATCH net-next 08/11] net: dsa: rework switch parsing

When parsing a switch, we have to identify to which tree it belongs and parse its ports. Provide two functions to separate the OF and platform data specific paths. Also use the of_property_read_variable_u32_array function to parse the OF member array instead of calling of_property_read_u32_index

Re: [PATCH net-next] tcp: tcp_mtu_probing() cleanup

On Fri, Nov 3, 2017 at 9:09 AM, Eric Dumazet wrote: > From: Eric Dumazet > > Reduce one indentation level to make code more readable. > tcp_sync_mss() can be factorized. > > Signed-off-by: Eric Dumazet > --- >

Re: Bond recovery from BOND_LINK_FAIL state not working

On 2017-11-03 3:30 PM, Alex Sidorenko wrote: Indeed, we do not print slave's ->link_new_state on each entry - so it is quite possible that we are at stage 6. It is even possible that this has something to do with how NM initially created bonds. Customer says that the problem occurs once only

Re: TCP connection closed without FIN or RST

On Fri, 2017-11-03 at 14:28 -0400, Vitaly Davidovich wrote: > So Eric, while I still have your interest here (although I know it's > waning :)), any code pointers to where I might look to see if a > specific small-ish rcv buf size may interact poorly with the rest of > the stack? Is it possible

[PATCH net-next] liquidio: do not consider packets dropped by network stack as driver Rx dropped

From: Intiyaz Basha netdev->rx_dropped was including packets dropped by napi_gro_receive. If a packet is dropped by network stack, it should not be counted under driver Rx dropped. Made necessary changes to not include network stack drops under netdev->rx_dropped.

Re: [PATCH net] tcp: fix tcp_mtu_probe() vs highest_sack

On Fri, 2017-11-03 at 19:22 +0100, Oleksandr Natalenko wrote: > Hi. > > Thanks for the fix. > > However, tcp_fastretrans_alert() warning case still remains open even with > this patch. Do I understand correctly that these are 2 different issues? > > Currently, I use latest 4.13 stable kernel +

Re: [PATCH net-next 09/12] tools: bpftool: turn err() and info() macros into functions

2017-11-002 17:59 UTC-0700 ~ Joe Perches > On Mon, 2017-10-23 at 09:24 -0700, Jakub Kicinski wrote: >> From: Quentin Monnet >> >> Turn err() and info() macros into functions. >> >> In order to avoid naming conflicts with variables in the code,

Re: next-20171103 build: 3 failures 22 warnings (next-20171103)

On Fri, 3 Nov 2017 21:16:21 +0100 Arnd Bergmann wrote: > On Fri, Nov 3, 2017 at 8:27 PM, Masami Hiramatsu wrote: > > On Fri, 3 Nov 2017 15:44:53 +0100 Arnd Bergmann wrote: > >> On Fri, Nov 3, 2017 at 1:44 PM, Build bot for Mark Brown > >>

Re: [PATCH 1/2] bpf: add a bpf_override_function helper

On Fri, Nov 03, 2017 at 05:52:22PM +0100, Daniel Borkmann wrote: > On 11/03/2017 03:31 PM, Josef Bacik wrote: > > On Fri, Nov 03, 2017 at 12:12:13AM +0100, Daniel Borkmann wrote: > > > Hi Josef, > > > > > > one more issue I just noticed, see comment below: > > > > > > On 11/02/2017 03:37 PM,

[PATCH net-next] tools: bpftool: move p_err() and p_info() from main.h to common.c

From: Quentin Monnet The two functions were declared as static inline in a header file. There is no particular reason why they should be inlined, they just happened to remain in the same header file when they were turned from macros to functions in a precious

[PATCH net-next v2 01/15] net: bpf: rename ndo_xdp to ndo_bpf

ndo_xdp is a control path callback for setting up XDP in the driver. We can reuse it for other forms of communication between the eBPF stack and the drivers. Rename the callback and associated structures and definitions. Signed-off-by: Jakub Kicinski Reviewed-by:

[PATCH net-next v2 03/15] bpf: report offload info to user space

Extend struct bpf_prog_info to contain information about program being bound to a device. Since the netdev may get destroyed while program still exists we need a flag to indicate the program is loaded for a device, even if the device is gone. Signed-off-by: Jakub Kicinski

[PATCH net-next v2 05/15] xdp: allow attaching programs loaded for specific device

Pass the netdev pointer to bpf_prog_get_type(). This way BPF code can decide whether the device matches what the code was loaded/translated for. Signed-off-by: Jakub Kicinski Reviewed-by: Simon Horman Reviewed-by: Quentin Monnet

[PATCH net-next v2 08/15] nfp: bpf: remove the register renumbering leftovers

The register renumbering was removed and will not be coming back in its old, naive form, given that it would be fundamentally incompatible with calling functions. Remove the leftovers. Signed-off-by: Jakub Kicinski Reviewed-by: Quentin Monnet

[PATCH net-next v2 09/15] nfp: bpf: remove unnecessary include of nfp_net.h

BPF offload's main header does not need to include nfp_net.h. Signed-off-by: Jakub Kicinski Reviewed-by: Quentin Monnet --- drivers/net/ethernet/netronome/nfp/bpf/main.h | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH net-next v2 10/15] nfp: bpf: refactor offload logic

We currently create a fake cls_bpf offload object when we want to offload XDP. Simplify and clarify the code by moving the TC/XDP specific logic out of common offload code. This is easy now that we don't support legacy TC actions. We only need the bpf program and state of the skip_sw flag.

[PATCH net-next v2 15/15] bpf: remove old offload/analyzer

Thanks to the ability to load a program for a specific device, running verifier twice is no longer needed. Signed-off-by: Jakub Kicinski Reviewed-by: Quentin Monnet --- include/linux/bpf_verifier.h | 5 --- kernel/bpf/verifier.c

[PATCH net-next v2 13/15] nfp: bpf: move translation prepare to offload.c

struct nfp_prog is currently only used internally by the translator. This means there is a lot of parameter passing going on, between the translator and different stages of offload. Simplify things by allocating nfp_prog in offload.c already. We will now use kmalloc() to allocate the program

[PATCH net-next v2 02/15] bpf: offload: add infrastructure for loading programs for a specific netdev

The fact that we don't know which device the program is going to be used on is quite limiting in current eBPF infrastructure. We have to reverse or limit the changes which kernel makes to the loaded bytecode if we want it to be offloaded to a networking device. We also have to invent new APIs for

[PATCH net-next v2 06/15] cls_bpf: allow attaching programs loaded for specific device

If TC program is loaded with skip_sw flag, we should allow the device-specific programs to be accepted. Signed-off-by: Jakub Kicinski Reviewed-by: Simon Horman Reviewed-by: Quentin Monnet ---

[PATCH net-next v2 12/15] nfp: bpf: move program prepare and free into offload.c

Most of offload/translation prepare logic will be moved to offload.c. To help git generate more reasonable diffs move nfp_prog_prepare() and nfp_prog_free() functions there as a first step. Signed-off-by: Jakub Kicinski Reviewed-by: Quentin Monnet

[PATCH net-next v2 07/15] nfp: bpf: drop support for cls_bpf with legacy actions

Only support BPF_PROG_TYPE_SCHED_CLS programs in direct action mode. This simplifies preparing the offload since there will now be only one mode of operation for that type of program. We need to know the attachment mode type of cls_bpf programs, because exit codes are interpreted differently for

[PATCH net-next v2 11/15] nfp: bpf: require seamless reload for program replace

Firmware supports live replacement of programs for quite some time now. Remove the software-fallback related logic and depend on the FW for program replace. Seamless reload will become a requirement if maps are present, anyway. Load and start stages have to be split now, since replace only

[PATCH net-next v2 14/15] nfp: bpf: move to new BPF program offload infrastructure

Following steps are taken in the driver to offload an XDP program: XDP_SETUP_PROG: * prepare: - allocate program state; - run verifier (bpf_analyzer()); - run translation; * load: - stop old program if needed; - load program; - enable BPF if not enabled; * clean up: - free

[PATCH net-next v2 00/15] bpf: add offload as a first class citizen

Hi! This series is my stab at what was discussed at a recent IOvisor bi-weekly call. The idea is to make the device translator run at the program load time. This makes the offload more explicit to the user space. It also makes it easy for the device translator to insert information into the

Re: [PATCH RFC,WIP 5/5] netfilter: nft_flow_offload: add ndo hooks for hardware offload

Pablo Neira Ayuso wrote: > +static void flow_offload_work(struct work_struct *work) > +{ > + struct flow_hw_offload *offload, *next; > + > + spin_lock_bh(_hw_offload_lock); > + list_for_each_entry_safe(offload, next, _hw_offload_pending_list, > list) { > +

[PATCH net-next v2 04/15] bpftool: print program device bound info

If program is bound to a device, print the name of the relevant interface or unknown if the netdev has since been removed. Signed-off-by: Jakub Kicinski Reviewed-by: Simon Horman Reviewed-by: Quentin Monnet

Re: [PATCH RFC,WIP 2/5] netfilter: add software flow offload infrastructure

Pablo Neira Ayuso wrote: > +static int __init nf_flow_offload_module_init(void) > +{ > + struct rhashtable_params params = flow_offload_rhash_params; > + struct nf_hook_ops flow_offload_hook = { > + .hook = nf_flow_offload_hook, > +

Re: next-20171103 build: 3 failures 22 warnings (next-20171103)

On Fri, Nov 3, 2017 at 8:27 PM, Masami Hiramatsu wrote: > On Fri, 3 Nov 2017 15:44:53 +0100 Arnd Bergmann wrote: >> On Fri, Nov 3, 2017 at 1:44 PM, Build bot for Mark Brown >> wrote: >> >> > Warnings Summary: 22 >> > 2

Re: [patch net-next 3/5] net: sched: introduce block mechanism to handle netif_keep_dst calls

On 11/03/2017 06:19 PM, Jiri Pirko wrote: From: Jiri Pirko Couple of classifiers call netif_keep_dst directly on q->dev. That is not possible to do directly for shared blocke where multiple qdiscs are owning the block. So introduce a infrastructure to keep track of the block

[PATCH] ath9k: dfs: use swap macro in ath9k_check_chirping

Make use of the swap macro and remove unnecessary variable temp. This makes the code easier to read and maintain. This code was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- drivers/net/wireless/ath/ath9k/dfs.c | 8 +++- 1 file

[PATCH] Net: netfilter: vmalloc/vfree to kvmalloc/kvfree

Fixed FIXME by changing memory allocation and freeing in htable_create to kvmalloc and kvfree from vmalloc and vfree. Changes are made throughout the file in order to account for the different allocation of htable_create. Small note: This is a replacement of an earlier patch that did not work.

Re: [PATCH net-next 5/6] net: hns3: add support for nway_reset

On 11/02/2017 09:18 PM, Lipeng wrote: > From: Fuyun Liang > > This patch adds nway_reset support for ethtool cmd. > > Signed-off-by: Fuyun Liang > Signed-off-by: Lipeng > --- >

Re: [PATCH net-next 4/6] net: hns3: add support for set_link_ksettings

On 11/02/2017 09:18 PM, Lipeng wrote: > From: Fuyun Liang > > This patch adds set_link_ksettings support for ethtool cmd. > > Signed-off-by: Fuyun Liang > Signed-off-by: Lipeng > --- >

Re: [PATCH RFC,WIP 3/5] netfilter: nf_flow_offload: integration with conntrack

Pablo Neira Ayuso wrote: > This patch adds the IPS_OFFLOAD status bit, this new bit tells us that > the conntrack entry is owned by the flow offload infrastructure. The > timer of such conntrack entries is stopped - the conntrack garbage > collector skips them - and they

Re: Bond recovery from BOND_LINK_FAIL state not working

Indeed, we do not print slave's ->link_new_state on each entry - so it is quite possible that we are at stage 6. It is even possible that this has something to do with how NM initially created bonds. Customer says that the problem occurs once only after host reboot, after that failover works

[PATCH net-next] liquidio: Fix an issue with multiple switchdev enable disables

From: Vijaya Mohan Guvva Return success if the same dispatch function is being registered for a given opcode and subcode, there by allow multiple switchdev enable and disables. Signed-off-by: Vijaya Mohan Guvva Signed-off-by: Satanand Burla

Re: [PATCH net] tcp: fix tcp_mtu_probe() vs highest_sack

Hi. Thanks for the fix. However, tcp_fastretrans_alert() warning case still remains open even with this patch. Do I understand correctly that these are 2 different issues? Currently, I use latest 4.13 stable kernel + this patch and still get: WARNING: CPU: 1 PID: 736 at

Re: TCP connection closed without FIN or RST

On Fri, Nov 3, 2017 at 1:58 PM, Eric Dumazet wrote: > On Fri, 2017-11-03 at 13:23 -0400, Vitaly Davidovich wrote: >> On Fri, Nov 3, 2017 at 12:05 PM, Eric Dumazet wrote: >> > On Fri, 2017-11-03 at 11:13 -0400, Vitaly Davidovich wrote: >> >> Ok, an

Re: Bond recovery from BOND_LINK_FAIL state not working

Alex Sidorenko wrote: >Jay, > >while scenario you describe makes sense, it does not match what we see in our >tests. > >The instrumentation prints info every time we enter bond_mii_monitor(), >bond_miimon_inspect(), >bond_miimon_commit() and every time we are

​​ATTN: My Dear

ATTN: My Dear Good news,The BRITISH HIGH COMMISSION has actually verified and discovered that your payment has been unnecessarily Delayed by corrupt officials of the Company who are Trying to divert your fund of $4,700.000.00 Million into their private accounts. Therefore we have obtained an

Re: [jkirsher/next-queue PATCH 3/5] ixgbe: Fix handling of macvlan Tx offload

On Thu, Nov 2, 2017 at 4:34 PM, Alexander Duyck wrote: > From: Alexander Duyck > > This update makes it so that we report the actual number of Tx queues via > real_num_tx_queues but are still restricted to RSS on only the first pool > by

Your Response Required from Sgt.Monica Lin Brown

I am Sgt.Monica Lin Brown, originally from Lake Jackson Texas USA.I personally made a special research on Internet address book and I came across your information. I am presently writing this mail to you from U.S Military base Kabul Afghanistan I have a secured business proposal for you.Reply

Re: TCP connection closed without FIN or RST

On Fri, 2017-11-03 at 13:23 -0400, Vitaly Davidovich wrote: > On Fri, Nov 3, 2017 at 12:05 PM, Eric Dumazet wrote: > > On Fri, 2017-11-03 at 11:13 -0400, Vitaly Davidovich wrote: > >> Ok, an interesting finding. The client was originally running with > >> SO_RCVBUF of 75K

[PATCH net v5 1/2] ARM: dts: imx: name the interrupts for the fec ethernet driver

imx7s/imx7d has the ptp interrupt newly added as well. For imx7, "int0" is the interrupt for queue 0 and ENET_MII "int1" is for queue 1 "int2" is for queue 2 For imx6sx, "int0" handles all 3 queues and ENET_MII And of course, the "pps" interrupt is for the PTP_CLOCK_PPS interrupts This will

[PATCH net v5 2/2] net: fec: Let fec_ptp have its own interrupt routine

This is better for code locality and should slightly speed up normal interrupts. This also allows PPS clock output to start working for i.mx7. This is because i.mx7 was already using the limit of 3 interrupts, and needed another. Signed-off-by: Troy Kisky ---

Re: [PATCH iproute2] Add "show" subcommand to "ip fou"

On Fri, Nov 3, 2017 at 10:19 AM, Greg Greenway wrote: > On Nov 1, 2017, at 2:03 PM, Stephen Hemminger > wrote: >> >> On Tue, 31 Oct 2017 13:00:47 -0700 >> Greg Greenway wrote: >> >>> +if (tb[FOU_ATTR_AF]) { >>> +

Re: TCP connection closed without FIN or RST

On Fri, Nov 3, 2017 at 12:05 PM, Eric Dumazet wrote: > On Fri, 2017-11-03 at 11:13 -0400, Vitaly Davidovich wrote: >> Ok, an interesting finding. The client was originally running with >> SO_RCVBUF of 75K (apparently someone decided to set that for some >> unknown

[patch net-next 1/5] net: sched: introduce support for multiple filter chain pointers registration

From: Jiri Pirko So far, there was possible only to register a single filter chain pointer to block->chain[0]. However, when the blocks will get shareable, we need to allow multiple filter chain pointers registration. Signed-off-by: Jiri Pirko ---

[patch net-next 3/5] net: sched: introduce block mechanism to handle netif_keep_dst calls

From: Jiri Pirko Couple of classifiers call netif_keep_dst directly on q->dev. That is not possible to do directly for shared blocke where multiple qdiscs are owning the block. So introduce a infrastructure to keep track of the block owners in list and use this list to

Re: [PATCH iproute2] Add "show" subcommand to "ip fou"

On Nov 1, 2017, at 2:03 PM, Stephen Hemminger wrote: > > On Tue, 31 Oct 2017 13:00:47 -0700 > Greg Greenway wrote: > >> +if (tb[FOU_ATTR_AF]) { >> +family = rta_getattr_u8(tb[FOU_ATTR_AF]); >> +if (family == AF_INET)

[patch net-next 5/5] net: sched: allow ingress and clsact qdiscs to share filter blocks

From: Jiri Pirko Benefit from the previously introduced shared filter blocks infrastructure and allow ingress and clsact qdisc instances to share filter blocks. The block index is coming from userspace as qdisc option. Signed-off-by: Jiri Pirko ---

[patch net-next 2/5] net: sched: avoid usage of tp->q in tcf_classify

From: Jiri Pirko Use block index in the messages instead. Signed-off-by: Jiri Pirko --- net/sched/cls_api.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c index 4576b2d..b3e313f 100644

[patch net-next 4/5] net: sched: remove classid and q fields from tcf_proto

From: Jiri Pirko Both are no longer used, so remove them. Signed-off-by: Jiri Pirko --- include/net/sch_generic.h | 2 -- net/sched/cls_api.c | 7 ++- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/include/net/sch_generic.h

[patch net-next 0/5] net: sched: allow qdiscs to share filter block instances

From: Jiri Pirko Currently the filters added to qdiscs are independent. So for example if you have 2 netdevices and you create ingress qdisc on both and you want to add identical filter rules both, you need to add them twice. This patchset makes this easier and mainly saves

Re: [Intel-wired-lan] [jkirsher/next-queue PATCH 0/5] macvlan offload fixes

On 11/2/2017 4:33 PM, Alexander Duyck wrote: I'm looking at performing a refactor of the macvlan offload code. However before I started I wanted to at least get things into a running state. The patches in this set are needed to address a number of issues that were preventing things from working

Re: [Intel-wired-lan] [jkirsher/next-queue PATCH 5/5] dev: Cap number of queues even with accel_priv

On Thu, 2 Nov 2017 16:34:58 -0700 Alexander Duyck wrote: > From: Alexander Duyck > > With the recent fix to ixgbe we can cap the number of queues always > regardless of if accel_priv is being used or not since the actual number of >

Re: [Intel-wired-lan] [jkirsher/next-queue PATCH 2/5] fm10k: Fix VLAN configuration for macvlan offload

On Thu, 2 Nov 2017 16:33:45 -0700 Alexander Duyck wrote: > From: Alexander Duyck > > The fm10k driver didn't work correctly when macvlan offload was enabled. > Specifically what would occur is that we would see no unicast packets being >

Re: [PATCH 1/2] bpf: add a bpf_override_function helper

On 11/03/2017 03:31 PM, Josef Bacik wrote: On Fri, Nov 03, 2017 at 12:12:13AM +0100, Daniel Borkmann wrote: Hi Josef, one more issue I just noticed, see comment below: On 11/02/2017 03:37 PM, Josef Bacik wrote: [...] diff --git a/include/linux/filter.h b/include/linux/filter.h index

[PATCH] mISDN: l1oip_core: replace _manual_ swap with swap macro

Make use of the swap macro and remove unnecessary variables skb and cnt. This makes the code easier to read and maintain. This code was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- drivers/isdn/mISDN/l1oip_core.c | 10 ++ 1 file

Re: [PATCH net 0/2] NULL pointer dereference in {ipvlan|macvlan}_port_destroy

On 11/2/17 10:05 PM, David Miller wrote: From: Girish Moodalbail Date: Tue, 31 Oct 2017 09:39:45 -0700 When call to register_netdevice() (called from ipvlan_link_new()) fails, inside that function we call ipvlan_uninit() (through ndo_uninit()) to destroy the

[PATCH 1/2] can: peak_usb: remove some 'struct timeval' users

We want to remove 'struct timeval' and related interfaces since this is generally not safe for use beyond 2038. For peak_usb, we can simplify the internal interface by using ktime_t directly. This should not change any behavior, but it avoids a few conversions. Signed-off-by: Arnd Bergmann

[PATCH 2/2] can: peak_usb: use ktime_t consistently

This changes the calculation of the timestamps to use ktime_t instead of struct timeval as the base. This gets rid of one of the few remaining users of the deprecated ktime_to_timeval() and timeval_to_ktime() helpers. The code should also get more efficient, as we have now removed all of the

Re: [Intel-wired-lan] [jkirsher/next-queue PATCH 3/5] ixgbe: Fix handling of macvlan Tx offload

On 11/2/2017 4:34 PM, Alexander Duyck wrote: From: Alexander Duyck This update makes it so that we report the actual number of Tx queues via real_num_tx_queues but are still restricted to RSS on only the first pool by setting num_tc equal to 1. Doing this locks us

Re: [net-next v2 3/4] openvswitch: Add meter infrastructure

On Thu, Nov 2, 2017 at 7:43 PM, Andy Zhou wrote: > On Thu, Nov 2, 2017 at 5:07 AM, Pravin Shelar wrote: >> On Thu, Nov 2, 2017 at 3:07 AM, Andy Zhou wrote: >>> On Fri, Oct 20, 2017 at 8:32 PM, Pravin Shelar wrote: On Thu, Oct

Re: TCP connection closed without FIN or RST

On Fri, 2017-11-03 at 11:13 -0400, Vitaly Davidovich wrote: > Ok, an interesting finding. The client was originally running with > SO_RCVBUF of 75K (apparently someone decided to set that for some > unknown reason). I tried the test with a 1MB recv buffer and > everything works perfectly! The

RE: [PATCH net-next 0/6] net: hns3: support set_link_ksettings and for nway_reset ethtool command

Hi Andrew, > -Original Message- > From: Andrew Lunn [mailto:and...@lunn.ch] > Sent: Friday, November 03, 2017 3:52 PM > To: lipeng (Y) > Cc: da...@davemloft.net; netdev@vger.kernel.org; linux- > ker...@vger.kernel.org; Linuxarm; Salil Mehta > Subject: Re: [PATCH net-next 0/6] net: hns3:

Re: [PATCH net-next 0/6] net: hns3: support set_link_ksettings and for nway_reset ethtool command

On Fri, Nov 03, 2017 at 12:18:24PM +0800, Lipeng wrote: > This patch-set adds support for set_link_ksettings && for nway_resets > ethtool command and fixes some related ethtool bugs. > 1, patch[4/6] adds support for ethtool_ops.set_link_ksettings. > 2, patch[5/6] adds support ethtool_ops.for

[PATCH net-next v6 3/3] act_vlan: VLAN action rewrite to use RCU lock/unlock and update

Using a spinlock in the VLAN action causes performance issues when the VLAN action is used on multiple cores. Rewrote the VLAN action to use RCU read locking for reads and updates instead. Acked-by: Jamal Hadi Salim Acked-by: Jiri Pirko Signed-off-by:

[PATCH net-next v6 2/3] nfp flower action: Modified to use VLAN helper functions

Modified netronome nfp flower action to use VLAN helper functions instead of accessing the structure directly. Signed-off-by: Manish Kurup --- drivers/net/ethernet/netronome/nfp/flower/action.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git

[PATCH net-next v6 0/3] Incorporated all required changes

Hi everyone, Modified the netronome drivers (flower action) to use the VLAN helper functions instead of dereferencing the structure directly. This is required for the VLAN action patch. Could you please review? Here're the changes: v2: Fixed all helper functions to use RCU (rtnl_dereference) -

[PATCH net-next v6 1/3] act_vlan: Change stats update to use per-core stats

The VLAN action maintains one set of stats across all cores, and uses a spinlock to synchronize updates to it from the same. Changed this to use a per-CPU stats context instead. This change will result in better performance. Acked-by: Jamal Hadi Salim Acked-by: Jiri Pirko

[PATCH net] l2tp: don't use l2tp_tunnel_find() in l2tp_ip and l2tp_ip6

Using l2tp_tunnel_find() in l2tp_ip_recv() is wrong for two reasons: * It doesn't take a reference on the returned tunnel, which makes the call racy wrt. concurrent tunnel deletion. * The lookup is only based on the tunnel identifier, so it can return a tunnel that doesn't match the

Re: [PATCH 6/7] netdev: octeon-ethernet: Add Cavium Octeon III support.

> >>+static char *mix_port; > >>+module_param(mix_port, charp, 0444); > >>+MODULE_PARM_DESC(mix_port, "Specifies which ports connect to MIX > >>interfaces."); > > > >Can you derive this from Device Tree /platform data configuration? > > > >>+ > >>+static char *pki_port; >

  1   2   3   >