[PATCH net-next 1/2] {topost} net: hns3: fix a bug when getting phy address from NCL_config file

From: Fuyun Liang Driver gets phy address from NCL_config file and uses the phy address to initialize phydev. There are 5 bits for phy address. And C22 phy address has 5 bits. So 0-31 are all valid address for phy. If there is no phy, it will crash. Because driver always

[PATCH net-next 2/2] {topost} net: hns3: cleanup mac auto-negotiation state query in hclge_update_speed_duplex

From: Fuyun Liang When checking whether auto-negotiation is on, driver only needs to check the value of mac.autoneg(SW) directly, and does not need to query it from hardware. Because this value is always synchronized with the auto-negotiation state of hardware. This

Re: [lldp-devel] Fwd: [PATCH RESEND] Fix segfault on "lldptool -t -i eth2 -V PFC -c enabled"

On 11/07/2017 04:56 PM, Sowmini Varadhan wrote: > > We are trying to use DCBX via lldpad for some of our applications, > and finding/fixing bugs and enhancements as we go. > > However our attempts to upstream these fixes is encountering silence > from the lldp-devel list e.g., >

Re: [PATCH] af_netlink: give correct bounds to dump skb for NLMSG_DONE

Erf, your patch doesn't handle what happens if len comes back negative, but I'll fix it up and send a v2 using this approach. I think I really prefer v1 though. Jason

Re: [PATCH net] bonding: fix slave stuck in BOND_LINK_FAIL state

From: Jay Vosburgh Date: Tue, 07 Nov 2017 19:50:07 +0900 > The bonding miimon logic has a flaw, in that a failure of the > rtnl_trylock can cause a slave to become permanently stuck in > BOND_LINK_FAIL state. > > The sequence of events to cause this is as

Re: [PATCH net] qmi_wwan: Add missing skb_reset_mac_header-call

From: Kristian Evensen Date: Tue, 7 Nov 2017 13:47:56 +0100 > When we receive a packet on a QMI device in raw IP mode, we should call > skb_reset_mac_header() to ensure that skb->mac_header contains a valid > offset in the packet. While it shouldn't really matter,

Re: [PATCH net-next v17] openvswitch: enable NSH support

From: Yi Yang Date: Tue, 7 Nov 2017 21:07:02 +0800 ... > OVS master and 2.8 branch has merged NSH userspace > patch series, this patch is to enable NSH support > in kernel data path in order that OVS can support > NSH in compat mode by porting this. > > Signed-off-by: Yi

[PATCH] Bluetooth: Use common error handling code in bt_init()

From: Markus Elfring Date: Wed, 8 Nov 2017 08:03:04 +0100 * Improve jump targets so that a bit of exception handling can be better reused at the end of this function. * Adjust five condition checks. This issue was detected by using the Coccinelle software.

Re: [PATCH v2 iproute2] libnetlink: Handle extack messages for non-error case

On Tue, Nov 07, 2017 at 08:05:18PM -0800, David Ahern wrote: > Kernel can now return non-fatal error messages in extack facility. > Update iproute2 to dump to use if present. > - rename nl_dump_ext_err to nl_dump_ext_ack > - rename errmsg to msg > - add call to nl_dump_ext_ack in rtnl_dump_done

Re: [PATCH net-next 0/2] net: hns3: Bug fixes & Code improvements in HNS3 driver

please ignore this patch-set. I should remove "{topost}" from the subject. sorry for that, I will resend the patch-set. On 2017/11/8 15:31, Lipeng wrote: This patch-set introduces some bug fixes and code improvements. As [patch 1/2] depends on the patch {5392902 net: hns3: Consistently

[net 4/6] net/mlx5e: Fix napi poll with zero budget

napi->poll can be called with budget 0, e.g. in netpoll scenarios where the caller only wants to poll TX rings (poll_one_napi@net/core/netpoll.c). The below commit changed RX polling from "while" loop to "do {} while", which caused to ignore the initial budget and handle at least one RX packet.

[net 5/6] net/mlx5e: Set page to null in case dma mapping fails

From: Inbar Karmy Currently, when dma mapping fails, put_page is called, but the page is not set to null. Later, in the page_reuse treatment in mlx5e_free_rx_descs(), mlx5e_page_release() is called for the second time, improperly doing dma_unmap (for a non-mapped address)

[net 6/6] net/mlx5e: Increase Striding RQ minimum size limit to 4 multi-packet WQEs

From: Eugenia Emantayev This is to prevent the case of working with a single MPWQE (1 WQE is always reserved as RQ is linked-list). When the WQE is fully consumed, HW should still have available buffer in order not to drop packets. Fixes: 461017cb006a ("net/mlx5e: Support

[net 1/6] net/mlx5: Loop over temp list to release delay events

From: Huy Nguyen list_splice_init initializing waiting_events_list after splicing it to temp list, therefore we should loop over temp list to fire the events. Fixes: 4ca637a20a52 ("net/mlx5: Delay events till mlx5 interface's add complete for pci resume") Signed-off-by: Huy

[pull request][net 0/6] Mellanox, mlx5 fixes 2017-11-08

Hi Dave, The follwoing series includes some fixes for mlx5 core and etherent driver. Sorry for the late submission but as you can see i have some very critical fixes below that i would like them merged into this RC. Please pull and let me know if there is any problem. For -stable:

[net 2/6] net/mlx5: Cancel health poll before sending panic teardown command

From: Huy Nguyen After the panic teardown firmware command, health_care detects the error in PCI bus and calls the mlx5_pci_err_detected. This health_care flow is no longer needed because the panic teardown firmware command will bring down the PCI bus communication with the

[net 3/6] net/mlx5: FPGA, return -EINVAL if size is zero

From: Kamal Heib In the current code, if a size of zero is passed to mlx5_fpga_mem_{read|write}_i2c() functions the "err" return value will not initialized. Fixes: a9956d35d199 ('net/mlx5: FPGA, Add SBU infrastructure') Signed-off-by: Kamal Heib

[PATCH v2] af_netlink: give correct bounds to dump skb for NLMSG_DONE

The way people generally use netlink_dump is that they fill in the skb as much as possible, breaking when nla_put returns an error. Then, they get called again and start filling out the next skb, and again, and so forth. The mechanism at work here is the ability for the iterative dumping function

[PATCH net-next 0/2] net: hns3: Bug fixes & Code improvements in HNS3 driver

This patch-set introduces some bug fixes and code improvements. As [patch 1/2] depends on the patch {5392902 net: hns3: Consistently using GENMASK in hns3 driver}, which exists in net-next, not exists in net, so push this serise to nex-next. Fuyun Liang (2): {topost} net: hns3: fix a bug when

[PATCH net-next 2/2] net: hns3: cleanup mac auto-negotiation state query in hclge_update_speed_duplex

From: Fuyun Liang When checking whether auto-negotiation is on, driver only needs to check the value of mac.autoneg(SW) directly, and does not need to query it from hardware. Because this value is always synchronized with the auto-negotiation state of hardware. This

[PATCH net-next 1/2] net: hns3: fix a bug when getting phy address from NCL_config file

From: Fuyun Liang Driver gets phy address from NCL_config file and uses the phy address to initialize phydev. There are 5 bits for phy address. And C22 phy address has 5 bits. So 0-31 are all valid address for phy. If there is no phy, it will crash. Because driver always

Re: mlx5 broken affinity

Depending on the machine and the number of queues this might even result in completely losing the ability to suspend/hibernate because the number of available vectors on CPU0 is not sufficient to accomodate all queue interrupts. Would it be possible to keep the managed facility until a user

Re: [PATCH net-next 2/8] rtnetlink: add rtnl_register_module

Peter Zijlstra wrote: > Something like the below would go some way toward sanitizing this stuff; > rcu_assign_pointer() is a store-release, meaning it happens after > everything coming before. > > Therefore, when you observe that tab (through rcu_dereference) you're >

[rht_deferred_worker] BUG: workqueue lockup - pool cpus=0 node=0 flags=0x0 nice=0 stuck for 33s!

06:44:05 CST 2017 [0.00] Command line: ip=vm-lkp-os-openwrt-ia32-11::dhcp root=/dev/ram0 user=lkp job=/lkp/scheduled/vm-lkp-os-openwrt-ia32-11/boot-1-openwrt-i386-2016-03-16.cgz-39dae59d66acd86d1de24294bd2f343fd5e7a625-20171107-3579-gel5jo-0.yaml ARCH=x86_64 kconfig=x86_64-randconfig

Re: [PATCH v4] scripts: add leaking_addresses.pl

On Tue, Nov 07, 2017 at 09:32:11PM +1100, Tobin C. Harding wrote: > Currently we are leaking addresses from the kernel to user space. This > script is an attempt to find some of those leakages. Script parses > `dmesg` output and /proc and /sys files for hex strings that look like > kernel

Re: [PATCH] ARM: dts: add phy-reset property for rk3066a-rayeager emac

On 2017年11月07日 15:54, Vladimir Zapolskiy wrote: Hello Chris, On 11/07/2017 04:49 AM, Chris Zhong wrote: The ethernet phy of rk3066a-rayeager has a reset pin, it controlled by GPIO1_D6, this pin should be pull down then pull up to reset the phy. Add a phy-reset property in emac, make the phy

[PATCH][V2] netfilter: remove redundant assignment to e

From: Colin Ian King The assignment to variable e is redundant since the same assignment occurs just a few lines later, hence it can be removed. Cleans up clang warning for arp_tables, ip_tables and ip6_tables: warning: Value stored to 'e' is never read

[PATCH] pktgen: document 32-bit timestamp overflow

Timestamps in pktgen are currently retrieved using the deprecated do_gettimeofday() function that wraps its signed 32-bit seconds in 2038 (on 32-bit architectures) and requires a division operation to calculate microseconds. The pktgen header is also defined with the same limitations, hardcoding

[PATCH net] bonding: fix slave stuck in BOND_LINK_FAIL state

The bonding miimon logic has a flaw, in that a failure of the rtnl_trylock can cause a slave to become permanently stuck in BOND_LINK_FAIL state. The sequence of events to cause this is as follows: 1) bond_miimon_inspect finds that a slave's link is down, and so calls

Re: [PATCH 2/2] net: macb: add of_node_put to error paths

On Tue, Nov 07, 2017 at 10:27:20AM +0100, Nicolas Ferre wrote: > On 06/11/2017 at 12:10, Michael Grzeschik wrote: > > We add the call of_node_put(bp->phy_node) to all associated error > > paths for memory clean up. > > > > Signed-off-by: Michael Grzeschik > > --- > >

[PATCH v2] net: macb: add of_node_put to error paths

We add the call of_node_put(bp->phy_node) to all associated error paths for memory clean up. Signed-off-by: Michael Grzeschik --- v1 -> v2: removed extra of_node_put from macb_remove drivers/net/ethernet/cadence/macb_main.c | 2 ++ 1 file changed, 2 insertions(+)

[PATCH v4] scripts: add leaking_addresses.pl

Currently we are leaking addresses from the kernel to user space. This script is an attempt to find some of those leakages. Script parses `dmesg` output and /proc and /sys files for hex strings that look like kernel addresses. Only works for 64 bit kernels, the reason being that kernel addresses

[PATCH] net/tcp: track all ipv4/tcp state transition in tcp_set_state

When I hooked the function tcp_set_state with kprobe to track the ipv4/tcp state transistion, I found state transition from TCP_LISTEN to TCP_SYN_RECV is missed. I think it is better to use the helper to do state transition instead of assigning the state to sk_state directly. Then we can monitor

Re: [PATCH v3 net-next 5/5] net: dsa: switch: Don't add CPU port to an mdb by default

Hello! On 11/7/2017 2:26 AM, Andrew Lunn wrote: Now that the host indicates when a multicast group should be forwarded from the switch to the host, don't do it by default. Signed-off-by: Andrew Lunn --- net/dsa/switch.c | 3 ++- 1 file changed, 2 insertions(+), 1

[PATCH 0/2][v5] Add the ability to do BPF directed error injection

I'm sending this through Dave since it'll conflict with other BPF changes in his tree, but since it touches tracing as well Dave would like a review from somebody on the tracing side. v4->v5: - disallow kprobe_override programs from being put in the prog map array so we don't tail call into

Re: [PATCH v4] scripts: add leaking_addresses.pl

On Tue, Nov 07, 2017 at 01:56:05PM +, David Laight wrote: > From: Tobin C. Harding > > Sent: 07 November 2017 10:32 > > > > Currently we are leaking addresses from the kernel to user space. This > > script is an attempt to find some of those leakages. Script parses > > `dmesg` output and /proc

Re: [PATCH v3] scripts: add leaking_addresses.pl

On Tue, Nov 7, 2017 at 1:22 PM, Kees Cook wrote: > > Linus, what do you have in mind for the root-only "yes we really need > the actual address output" exceptions? I am convinced that absolutely none of them should use '%pK'. So far we have actually never seen a valid

Re: [PATCH v3] scripts: add leaking_addresses.pl

On Tue, Nov 7, 2017 at 1:44 PM, Linus Torvalds wrote: > On Tue, Nov 7, 2017 at 1:22 PM, Kees Cook wrote: >> >> Linus, what do you have in mind for the root-only "yes we really need >> the actual address output" exceptions? > > I am convinced

Re: [PATCH v3 net-next 0/5] IGMP snooping for local traffic

> In a switch case, they all translate to programming a MDB entry for > a given switch port, right? No, in fact it is the exact opposite. A normal switchdev MDB says send traffic for a group OUT this port. A host switchdev MDB says send traffic coming IN from a port to the CPU. This is why i

Re: [PATCH v3] scripts: add leaking_addresses.pl

On Tue, 7 Nov 2017 13:44:01 -0800 Linus Torvalds wrote: > > Looking other places that stand out, it seems like > > /proc/lockdep_chains and /proc/lockdep (CONFIG_LOCKDEP=y) has a ton of > > %p usage. It's unclear to me if a hash is sufficient for meaningful > >

[PATCH 1/2] bpf: add a bpf_override_function helper

From: Josef Bacik Error injection is sloppy and very ad-hoc. BPF could fill this niche perfectly with it's kprobe functionality. We could make sure errors are only triggered in specific call chains that we care about with very specific situations. Accomplish this with the

[PATCH 2/2] samples/bpf: add a test for bpf_override_return

From: Josef Bacik This adds a basic test for bpf_override_return to verify it works. We override the main function for mounting a btrfs fs so it'll return -ENOMEM and then make sure that trying to mount a btrfs fs will fail. Acked-by: Alexei Starovoitov

Re: [PATCH v4] scripts: add leaking_addresses.pl

On Tue, Nov 07, 2017 at 11:50:27AM +0100, Greg KH wrote: > On Tue, Nov 07, 2017 at 09:32:11PM +1100, Tobin C. Harding wrote: > > Currently we are leaking addresses from the kernel to user space. This > > script is an attempt to find some of those leakages. Script parses > > `dmesg` output and

RE: [PATCH net-next RFC 0/9] net: dsa: PTP timestamping for mv88e6xxx

> Oops, I had "slaveOnly" set in my PC's configuration. So layer2 seems > to work as expected. > > Have you tested UDPv4? It doesn't work. I have not. Our usage has been focused on 802.1AS; the ptp4l settings we use are the following: transportSpecific0x1 ptp_dst_mac

Re: [PATCH v3 net-next 0/5] IGMP snooping for local traffic

> > It is not quite as simple as that. Image: > > > > brctl addbr br0 > > brctl addif br0 eth2 > > brctl addif br0 lan0 Hi Vivien I will reply to your other points later. But another scenario to think about. Take the above configuration. A join is received on eth2. The bridge makes switchdev

Re: [RFC PATCH] bpf: Add helpers to read useful task_struct members

On Tue, Nov 7, 2017 at 12:37 AM, Naveen N. Rao wrote: > Alexei Starovoitov wrote: >> >> On 11/7/17 12:55 AM, Naveen N. Rao wrote: I thought such struct shouldn't change layout. If it is we need to fix include/linux/compiler-clang.h to do that

Re: [PATCH 0/2][v5] Add the ability to do BPF directed error injection

On 11/8/17 5:28 AM, Josef Bacik wrote: I'm sending this through Dave since it'll conflict with other BPF changes in his tree, but since it touches tracing as well Dave would like a review from somebody on the tracing side. v4->v5: - disallow kprobe_override programs from being put in the prog

Re: [PATCH v3 net-next 0/5] IGMP snooping for local traffic

Hi Andrew, Andrew Lunn writes: >> In a switch case, they all translate to programming a MDB entry for >> a given switch port, right? > > No, in fact it is the exact opposite. Yes, they do. The proof is you call dsa_port_mdb_add. > A normal switchdev MDB says send traffic for a

[PATCH 2/9] iscsi: associate endpoints with a host

Right now the iscsi_endpoint is only linked to a connection once that connection has been established. For net namespace filtering of the sysfs objects, associate an endpoint with the host that it was allocated for when it is created. Signed-off-by: Chris Leech ---

RE: [PATCH net] i40e: fix the calculation of VFs mac addresses

> -Original Message- > From: Tushar Dave [mailto:tushar.n.d...@oracle.com] > Sent: Tuesday, November 7, 2017 10:20 > To: Nicolas Dichtel ; Kirsher, Jeffrey T > > Cc: da...@davemloft.net; netdev@vger.kernel.org; Zijie Pan >

[PATCH net-next 2/3] netem: add uapi to express delay and jitter in nanosec

netem userspace has long relied on a horrible /proc/net/psched hack to translate the current notion of "ticks" to nanoseconds. Expressing latency and jitter instead, in well defined nanoseconds, increases the dynamic range of emulated delays and jitter in netem. It will also ease a transition

[PATCH iproute2 1/4] tc: support conversions to or from 64 bit nanosecond-based time

Using a 32 bit field to represent time in nanoseconds results in a maximum value of about 4.3 seconds, which is well below many observed delays in WiFi and LTE, and barely in the ballpark for a trip past the Earth's moon, Luna. Using 64 bit time fields in nanoseconds allows us to simulate network

[PATCH iproute2 3/4] q_netem: support delivering packets in delayed time slots

Slotting is a crude approximation of the behaviors of shared media such as cable, wifi, and LTE, which gather up a bunch of packets within a varying delay window and deliver them, relative to that, nearly all at once. It works within the existing loss, duplication, jitter and delay parameters of

[PATCH iproute2 2/4] q_netem: utilize 64 bit nanosecond API for delay and jitter

This starts to obsolete the old "ticks" api in favor of well defined nanoseconds for the kernel/userspace netem interface. Signed-off-by: Dave Taht --- tc/q_netem.c | 68 +++- 1 file changed, 44 insertions(+), 24

[PATCH iproute2 4/4] netem: add documentation for the new slotting feature

Signed-off-by: Dave Taht --- man/man8/tc-netem.8 | 32 +++- 1 file changed, 31 insertions(+), 1 deletion(-) diff --git a/man/man8/tc-netem.8 b/man/man8/tc-netem.8 index b31384f..8c41d77 100644 --- a/man/man8/tc-netem.8 +++ b/man/man8/tc-netem.8

[PATCH iproute2 0/4] support nsec uapi and add netem slotting feature

This patch series adds support for specifying time in nanoseconds to tc, updates netem to use such (requires pkt_sched.h from the kernel patch series to be imported), and lastly adds a new slotting feature intended to emulate better how LTE and WiFi work. Dave Taht (4): tc: support conversions

Re: [RFC PATCH] bpf: Add helpers to read useful task_struct members

On Tue, Nov 7, 2017 at 1:31 PM, Atish Patra wrote: > On 11/07/2017 03:14 PM, Y Song wrote: >> >> On Tue, Nov 7, 2017 at 12:37 AM, Naveen N. Rao >> wrote: >>> >>> Alexei Starovoitov wrote: On 11/7/17 12:55 AM, Naveen N. Rao

Re: [PATCH v4] scripts: add leaking_addresses.pl

On Tue, Nov 07, 2017 at 04:51:29PM +0100, Petr Mladek wrote: > On Tue 2017-11-07 21:32:11, Tobin C. Harding wrote: > > Currently we are leaking addresses from the kernel to user space. This > > script is an attempt to find some of those leakages. Script parses > > `dmesg` output and /proc and /sys

[PATCH net-next v9 1/3] act_vlan: Change stats update to use per-core stats

The VLAN action maintains one set of stats across all cores, and uses a spinlock to synchronize updates to it from the same. Changed this to use a per-CPU stats context instead. This change will result in better performance. Acked-by: Jamal Hadi Salim Acked-by: Jiri Pirko

[PATCH net-next v9 2/3] nfp flower action: Modified to use VLAN helper functions

Modified netronome nfp flower action to use VLAN helper functions instead of accessing/referencing TC act_vlan private structures directly. Reviewed-by: Pieter Jansen van Vuuren Signed-off-by: Manish Kurup ---

[PATCH net-next v9 3/3] act_vlan: VLAN action rewrite to use RCU lock/unlock and update

Using a spinlock in the VLAN action causes performance issues when the VLAN action is used on multiple cores. Rewrote the VLAN action to use RCU read locking for reads and updates instead. All functions now use an RCU dereferenced pointer to access the VLAN action context. Modified helper

Re: [PATCH v4] scripts: add leaking_addresses.pl

On Tue, Nov 7, 2017 at 12:58 PM, Tobin C. Harding wrote: > > Interesting idea. Isn't the same outcome already achieved with > dmesg_restrict. I appreciate that this does beg the question 'why are we > scanning dmesg then?' dmesg_restrict is even more asinine than kptr_restrict.

Re: [RFC PATCH] bpf: Add helpers to read useful task_struct members

On 11/8/17 6:14 AM, Y Song wrote: On Tue, Nov 7, 2017 at 12:37 AM, Naveen N. Rao wrote: Alexei Starovoitov wrote: On 11/7/17 12:55 AM, Naveen N. Rao wrote: I thought such struct shouldn't change layout. If it is we need to fix include/linux/compiler-clang.h

Re: [PATCH net-next v9 1/3] act_vlan: Change stats update to use per-core stats

Will leave it up to Dave - but even this + patch 3 should start with "net_sched actions: act_vlan" as the prefix. Sorry, shouldve said that in the last comment I sent. cheers, jamal

Re: [RFC PATCH] bpf: Add helpers to read useful task_struct members

On 11/8/17 6:47 AM, Y Song wrote: On Tue, Nov 7, 2017 at 1:39 PM, Alexei Starovoitov wrote: On 11/8/17 6:14 AM, Y Song wrote: On Tue, Nov 7, 2017 at 12:37 AM, Naveen N. Rao wrote: Alexei Starovoitov wrote: On 11/7/17 12:55 AM, Naveen N. Rao

[PATCH net-next 3/3] netem: support delivering packets in delayed time slots

Slotting is a crude approximation of the behaviors of shared media such as cable, wifi, and LTE, which gather up a bunch of packets within a varying delay window and deliver them, relative to that, nearly all at once. It works within the existing loss, duplication, jitter and delay parameters of

[PATCH net-next 1/3] netem: convert to qdisc_watchdog_schedule_ns

Upgrade the internal netem scheduler to use nanoseconds rather than ticks throughout. Convert to and from the std "ticks" userspace api automatically, while allowing for finer grained scheduling to take place. Signed-off-by: Dave Taht --- net/sched/sch_netem.c | 56

[PATCH net-next 0/3] netem: add nsec scheduling and slot feature

This patch series converts netem away from the old "ticks" interface and userspace API, and adds support for a new "slot" feature intended to emulate bursty macs such as WiFi and LTE better. Dave Taht (3): netem: convert to qdisc_watchdog_schedule_ns netem: add uapi to express delay and

Re: [PATCH v3 net-next 0/5] IGMP snooping for local traffic

On 11/07/2017 01:01 PM, Andrew Lunn wrote: >>> It is not quite as simple as that. Image: >>> >>> brctl addbr br0 >>> brctl addif br0 eth2 >>> brctl addif br0 lan0 > > Hi Vivien > > I will reply to your other points later. But another scenario to think > about. > > Take the above configuration.

Re: [RFC PATCH] bpf: Add helpers to read useful task_struct members

On Tue, Nov 7, 2017 at 2:04 PM, Alexei Starovoitov wrote: > On 11/8/17 6:47 AM, Y Song wrote: >> >> On Tue, Nov 7, 2017 at 1:39 PM, Alexei Starovoitov wrote: >>> >>> On 11/8/17 6:14 AM, Y Song wrote: On Tue, Nov 7, 2017 at 12:37 AM, Naveen N. Rao

[PATCH 6/9] iscsi: check net namespace for all iscsi lookups

All internal lookups of iSCSI transport objects need to be filtered by net namespace. Signed-off-by: Chris Leech --- drivers/infiniband/ulp/iser/iscsi_iser.c | 5 +- drivers/scsi/be2iscsi/be_iscsi.c | 4 +- drivers/scsi/bnx2i/bnx2i_iscsi.c | 4 +-

[PATCH 7/9] iscsi: convert flashnode devices from bus to class

The flashnode session and connection devices should be filtered by net namespace along with the iscsi_host, but we can't do that with a bus device. As these don't use any of the bus matching functionality, they make more sense as a class device anyway. Signed-off-by: Chris Leech

[PATCH 1/9] iscsi: create per-net iscsi netlink kernel sockets

Prepare iSCSI netlink to operate in multiple namespaces. Signed-off-by: Chris Leech --- drivers/scsi/scsi_transport_iscsi.c | 67 +++-- 1 file changed, 57 insertions(+), 10 deletions(-) diff --git a/drivers/scsi/scsi_transport_iscsi.c

[PATCH 9/9] iscsi: filter flashnode sysfs by net namespace

Finished the net namespace support for flashnode sysfs devices Signed-off-by: Chris Leech --- drivers/scsi/scsi_transport_iscsi.c | 33 + 1 file changed, 33 insertions(+) diff --git a/drivers/scsi/scsi_transport_iscsi.c

[PATCH 3/9] iscsi: sysfs filtering by network namespace

This makes the iscsi_host, iscsi_session, iscsi_connection, iscsi_iface, and iscsi_endpoint transport class devices only visible in sysfs under a matching network namespace. The network namespace for all of these objects is tracked in the iscsi_cls_host structure. Signed-off-by: Chris Leech

[PATCH 8/9] iscsi: rename iscsi_bus_flash_* to iscsi_flash_*

cleanups after the bus to class conversion Signed-off-by: Chris Leech --- drivers/scsi/qla4xxx/ql4_os.c | 52 +- drivers/scsi/scsi_transport_iscsi.c | 102 ++-- include/scsi/scsi_transport_iscsi.h | 48 +

[PATCH 0/9] use network namespace for iSCSI control interfaces

Hello, I've posted these changes to allow iSCSI management within a container using a network namespace to the SCSI and Open-iSCSI lists, but seeing as it's not really SCSI/block related I'm casting a wider net looking for reviews. These patches apply network namespace to the iSCSI netlink

[PATCH 5/9] iscsi: set netns for iscsi_tcp hosts

This lets iscsi_tcp operate in multiple namespaces. It uses current during session creation to find the net namespace, but it might be better to manage to pass it along from the iscsi netlink socket. Signed-off-by: Chris Leech --- drivers/scsi/iscsi_tcp.c| 7

[PATCH 4/9] iscsi: make all iSCSI netlink multicast namespace aware

Make use of the per-net netlink sockets. Responses are sent back on the same socket/namespace the request was received on. Async events are reported on the socket/namespace stored in the iscsi_cls_host associated with the event. Signed-off-by: Chris Leech ---

Re: [PATCH net-next v15] openvswitch: enable NSH support

On Tue, Nov 07, 2017 at 06:57:30PM +0800, Pravin Shelar wrote: > On Mon, Nov 6, 2017 at 4:22 AM, Jiri Benc wrote: > > On Sat, 4 Nov 2017 07:29:46 -0700, Pravin Shelar wrote: > >> > +int nsh_push(struct sk_buff *skb, const struct nshhdr *pushed_nh) > >> > +{ > >> > + struct

Re: [PATCH v2] net: macb: add of_node_put to error paths

On 07/11/2017 at 10:59, Michael Grzeschik wrote: > We add the call of_node_put(bp->phy_node) to all associated error > paths for memory clean up. > > Signed-off-by: Michael Grzeschik Thanks for your quick update: Acked-by: Nicolas Ferre

[PATCH] af_netlink: give correct bounds to dump skb for NLMSG_DONE

The way people generally use netlink_dump is that they fill in the skb as much as possible, breaking when nla_put returns an error. Then, they get called again and start filling out the next skb, and again, and so forth. The mechanism at work here is the ability for the iterative dumping function

Re: [PATCH net-next v15] openvswitch: enable NSH support

On Tue, Nov 7, 2017 at 3:55 AM, Yang, Yi wrote: > On Tue, Nov 07, 2017 at 03:58:35AM -0800, Pravin Shelar wrote: >> On Tue, Nov 7, 2017 at 3:28 AM, Yang, Yi wrote: >> > On Tue, Nov 07, 2017 at 06:57:30PM +0800, Pravin Shelar wrote: >> >> On Mon, Nov 6,

[PATCH net] Fixed NULL ptr deref in enqueue_to_backlog().

Hey folks, I replaced the free_skb() call wit a dev_free_skb_any() and performed a few regression tests on the machines available to me. I was neither able to reproduce the crash while upping/downing can interfaces during operation, nor could I observe problems with ethernet connections on my

Re: [PATCH net-next v15] openvswitch: enable NSH support

On Tue, Nov 7, 2017 at 3:28 AM, Yang, Yi wrote: > On Tue, Nov 07, 2017 at 06:57:30PM +0800, Pravin Shelar wrote: >> On Mon, Nov 6, 2017 at 4:22 AM, Jiri Benc wrote: >> > On Sat, 4 Nov 2017 07:29:46 -0700, Pravin Shelar wrote: >> >> > +int nsh_push(struct

Re: [PATCH net-next v15] openvswitch: enable NSH support

On Tue, Nov 07, 2017 at 03:58:35AM -0800, Pravin Shelar wrote: > On Tue, Nov 7, 2017 at 3:28 AM, Yang, Yi wrote: > > On Tue, Nov 07, 2017 at 06:57:30PM +0800, Pravin Shelar wrote: > >> On Mon, Nov 6, 2017 at 4:22 AM, Jiri Benc wrote: > >> > On Sat, 4 Nov

[PATCH net] qmi_wwan: Add missing skb_reset_mac_header-call

When we receive a packet on a QMI device in raw IP mode, we should call skb_reset_mac_header() to ensure that skb->mac_header contains a valid offset in the packet. While it shouldn't really matter, the packets have no MAC header and the interface is configured as-such, it seems certain parts of

Re: [PATCH net-next v15] openvswitch: enable NSH support

On Tue, Nov 07, 2017 at 05:01:28AM -0800, Pravin Shelar wrote: > On Tue, Nov 7, 2017 at 3:55 AM, Yang, Yi wrote: > > On Tue, Nov 07, 2017 at 03:58:35AM -0800, Pravin Shelar wrote: > >> On Tue, Nov 7, 2017 at 3:28 AM, Yang, Yi wrote: > >> > On Tue, Nov

Re: [PATCH net-next v15] openvswitch: enable NSH support

On Mon, Nov 6, 2017 at 4:22 AM, Jiri Benc wrote: > On Sat, 4 Nov 2017 07:29:46 -0700, Pravin Shelar wrote: >> > +int nsh_push(struct sk_buff *skb, const struct nshhdr *pushed_nh) >> > +{ >> > + struct nshhdr *nh; >> > + size_t length = nsh_hdr_len(pushed_nh); >> > +

Re: [PATCH net] qmi_wwan: Add missing skb_reset_mac_header-call

Kristian Evensen writes: > When we receive a packet on a QMI device in raw IP mode, we should call > skb_reset_mac_header() to ensure that skb->mac_header contains a valid > offset in the packet. While it shouldn't really matter, the packets have > no MAC header and

[PATCH net-next v17] openvswitch: enable NSH support

v16->17 - Fixed disputed check code: keep them in nsh_push and nsh_pop but also add them in __ovs_nla_copy_actions v15->v16 - Add csum recalculation for nsh_push, nsh_pop and set_nsh pointed out by Pravin - Move nsh key into the union with ipv4 and ipv6 and add check for nsh key in

Re: [PATCH v3 01/21] grace: replace BUG_ON by WARN_ONCE in exit_net hook

> - BUG_ON(!list_empty(grace_list)); > + WARN_ONCE(!list_empty(grace_list), > + "net %x %s: grace_list is not empty\n", > + net->ns.inum, __func__); * printing __func__ is unnecessary as it will be on top of the stacktrace anyway, * message duplicates

Re: [sock_def_readable] WARNING: bad unlock balance detected!

Sorry please ignore this report -- according to Peter: This is fixed by commit: 02a7c234e540 ("rcu: Suppress lockdep false-positive ->boost_mtx complaints") The problem is that RCU boosting was mixing futex and !futex rt_mutex ops. On Tue, Nov 07, 2017 at 12:34:15PM +0800, Fengguang Wu

Re: [PATCH net-next V3 2/3] tools: bpftool: show filenames of pinned objects

On Mon, 6 Nov 2017 15:06:31 +0900, Prashant Bhole wrote: > Added support to show filenames of pinned objects. > ... > Signed-off-by: Prashant Bhole Thanks for the changes, a couple more nit picks, sorry for not spotting them earlier. > v2: > - Dynamically

Re: [PATCH] netfilter: mark expected switch fall-throughs

Hello Pablo, Quoting Pablo Neira Ayuso : Hi Gustavo, On Thu, Oct 19, 2017 at 09:06:16AM -0500, Gustavo A. R. Silva wrote: diff --git a/net/netfilter/ipset/ip_set_core.c b/net/netfilter/ipset/ip_set_core.c index cf84f7b..72f654a 100644 ---

Re: [PATCH net] qmi_wwan: Add missing skb_reset_mac_header-call

Hei, On Tue, Nov 7, 2017 at 2:02 PM, Bjørn Mork wrote: > And his should probably go to stable as well? with a > > Fixes: 32f7adf633b9 ("net: qmi_wwan: support "raw IP" mode") Yes, I forgot to add the fixes-tag + comment about stable. Should I submit a v2? -Kristian

Re: [PATCH net-next 2/8] rtnetlink: add rtnl_register_module

On Tue, Nov 07, 2017 at 10:47:51AM +0100, Florian Westphal wrote: > I would expect this to trigger all the time, due to > > rtnl_register(AF_INET, RTM_GETROUTE, ... > rtnl_register(AF_INET, RTM_GETADDR, ... Ah, sure, then something like so then... There's bound to be bugs there too, as I pretty

Re: mlx5 broken affinity

On Sun, 5 Nov 2017, Sagi Grimberg wrote: > > > > This wasn't to start a debate about which allocation method is the > > > > perfect solution. I am perfectly happy with the new default, the part > > > > that is broken is to take away the user's option to reassign the > > > > affinity. That is a bug

Re: [PATCH net-next 2/8] rtnetlink: add rtnl_register_module

Peter Zijlstra wrote: > > rtnetlink_rcv_msg: > > > > 4406 dumpit = READ_ONCE(handlers[type].dumpit); > > 4407 if (!dumpit) > > 4408 goto err_unlock; > > 4409 owner =

Re: [PATCH v3 2/2] selftests: bpf: test_kmod.sh: use modprobe on target device

On 11/07/2017 09:35 AM, naresh.kamb...@linaro.org wrote: > From: Naresh Kamboju Odd to see this From: line in the patch. Could you take a look and see where this is coming from? Your gitconfig perhaps. I have to fix this up when I apply the patch which I would like to

<    1   2   3   4   >