Re: linux-next: build warning after merge of the netfilter-next tree

Hi Dave, On Tue, 7 Nov 2017 11:02:48 +1100 Stephen Rothwell wrote: > > Hi all, > > After merging the netfilter-next tree, today's linux-next build (powerpc > ppc64_defconfig) produced this warning: > > net/netfilter/nf_conntrack_netlink.c:536:15: warning:

Re: [PATCH v3] scripts: add leaking_addresses.pl

On Tue, Nov 07, 2017 at 05:44:13PM -0500, Steven Rostedt wrote: > On Tue, 7 Nov 2017 13:44:01 -0800 > Linus Torvalds wrote: > > > > Looking other places that stand out, it seems like > > > /proc/lockdep_chains and /proc/lockdep (CONFIG_LOCKDEP=y) has a ton of > > >

Re: [PATCH 04/31] nds32: Exception handling

On Wed, Nov 8, 2017 at 6:54 AM, Greentime Hu wrote: > From: Greentime Hu > > Signed-off-by: Vincent Chen > Signed-off-by: Greentime Hu > arch/nds32/mm/alignment.c | 564 >

Re: kernel BUG at net/key/af_key.c:LINE!

On Tue, Oct 24, 2017 at 05:10:06PM +0200, Dmitry Vyukov wrote: > On Tue, Oct 24, 2017 at 5:08 PM, syzbot > > wrote: > > Hello, > > > > syzkaller hit the following crash on > > 02a2b05395dde2f49eb67b51a5fbc6606943 > >

Re: [PATCH 00/31] Andes(nds32) Linux Kernel Port

Greentime Hu wrote: > The build script and toolchain repositories are able to be found here: > https://github.com/andestech/build_script.git Is arch support in upstream binutils and gcc? David

Re: [PATCH 05/31] nds32: MMU definitions

On Wed, Nov 8, 2017 at 6:54 AM, Greentime Hu wrote: > +/* > + * The DMA mask corresponding to the maximum bus address allocatable > + * using GFP_DMA. The default here places no restriction on DMA > + * allocations. This must be the smallest DMA mask in the system, > + * so

Re: [PATCH 10/31] nds32: IRQ handling

On Wed, Nov 8, 2017 at 6:54 AM, Greentime Hu wrote: > + > +#ifdef CONFIG_TRACE_IRQFLAGS > +void notrace arch_trace_hardirqs_on(void) > +{ > + trace_hardirqs_on(); > +} > + > +void notrace arch_trace_hardirqs_off(void) > +{ > + trace_hardirqs_off(); > +} > +#endif

Re: [PATCH net-next 3/4] net: phy: sfp: Separate enumerations and states

On Tue, Nov 07, 2017 at 07:49:10PM -0800, Florian Fainelli wrote: > Create separate enumerations for the SFP physical state (computed from GPIOs), > device state, module state, and actual state machine. This will make it easier > to make sure the correct states are used, and also pretty print

[PATCH v2 2/2] net: macb: add of_node_put to error paths

We add the call of_node_put(bp->phy_node) to all associated error paths for memory clean up. Signed-off-by: Michael Grzeschik --- v2: removed extra of_node_put from macb_remove drivers/net/ethernet/cadence/macb_main.c | 2 ++ 1 file changed, 2 insertions(+) diff

[PATCH v2 1/2] net: macb: add of_phy_deregister_fixed_link to error paths

We add the call of_phy_deregister_fixed_link to all associated error paths for memory clean up. Signed-off-by: Michael Grzeschik --- v2: removed extra parenthesis drivers/net/ethernet/cadence/macb_main.c | 7 +++ 1 file changed, 7 insertions(+) diff --git

[PATCH v2 0/2] net: macb: add error handling on probe and

This series adds more error handling to the macb driver. Michael Grzeschik (2): net: macb: add of_phy_deregister_fixed_link to error paths net: macb: add of_node_put to error paths drivers/net/ethernet/cadence/macb_main.c | 9 + 1 file changed, 9 insertions(+) -- 2.11.0

Re: [PATCH 08/31] nds32: Cache and TLB routines

2017-11-08 16:45 GMT+08:00 Arnd Bergmann : > On Wed, Nov 8, 2017 at 6:54 AM, Greentime Hu wrote: > >> +#ifndef __NDS32_PROCFNS_H__ >> +#define __NDS32_PROCFNS_H__ >> + >> +#define CPU_NAME n13 >> + >> +#ifdef __KERNEL__ >> + >> +#ifdef __STDC__ >> +#define

Re: kernel BUG at net/key/af_key.c:LINE!

On Wed, Nov 8, 2017 at 8:47 AM, Herbert Xu wrote: > On Tue, Oct 24, 2017 at 05:10:06PM +0200, Dmitry Vyukov wrote: >> On Tue, Oct 24, 2017 at 5:08 PM, syzbot >> >> wrote: >> > Hello, >> > >> >

[PATCH net-next] net: mvpp2: fix GOP statistics loop start and stop conditions

GOP statistics from all ports of one instance of the driver are gathered with one work recalled in loop in a workqueue. The loop is started when a port is up, and stopped when a port is down. This last condition is obviously wrong. Fix this by having a work per port. This way, starting and

Re: kernel BUG at net/key/af_key.c:LINE!

On Wed, Nov 8, 2017 at 8:59 AM, Dmitry Vyukov wrote: > On Wed, Nov 8, 2017 at 8:47 AM, Herbert Xu > wrote: >> On Tue, Oct 24, 2017 at 05:10:06PM +0200, Dmitry Vyukov wrote: >>> On Tue, Oct 24, 2017 at 5:08 PM, syzbot >>>

Re: regression: UFO removal breaks kvm live migration

On Wed, Nov 8, 2017 at 4:49 PM, Jason Wang wrote: > > > On 2017年11月08日 15:26, David Miller wrote: >> >> From: Willem de Bruijn >> Date: Wed, 8 Nov 2017 12:36:26 +0900 >> >>> On Tue, Nov 7, 2017 at 5:02 PM, Michal Kubecek

Re: regression: UFO removal breaks kvm live migration

On 2017年11月08日 17:08, Willem de Bruijn wrote: On Wed, Nov 8, 2017 at 4:49 PM, Jason Wang wrote: On 2017年11月08日 15:26, David Miller wrote: From: Willem de Bruijn Date: Wed, 8 Nov 2017 12:36:26 +0900 On Tue, Nov 7, 2017 at 5:02 PM,

[PATCHv2 1/1] bnx2x: fix slowpath null crash

When "NETDEV WATCHDOG: em4 (bnx2x): transmit queue 2 timed out" occurs, BNX2X_SP_RTNL_TX_TIMEOUT is set. In the function bnx2x_sp_rtnl_task, bnx2x_nic_unload and bnx2x_nic_load are executed to shutdown and open NIC. In the function bnx2x_nic_load, bnx2x_alloc_mem allocates dma failure. The message

Re: [PATCH 1/2] net: macb: add of_phy_deregister_fixed_link to error paths

On Wed, Nov 08, 2017 at 01:22:57PM +0900, David Miller wrote: > From: Michael Grzeschik > Date: Mon, 6 Nov 2017 12:10:04 +0100 > > > We add the call of_phy_deregister_fixed_link to all associated > > error paths for memory clean up. > > > > Signed-off-by: Michael

Re: [PATCH 00/31] Andes(nds32) Linux Kernel Port

2017-11-08 16:32 GMT+08:00 David Howells : > Greentime Hu wrote: > >> The build script and toolchain repositories are able to be found here: >> https://github.com/andestech/build_script.git > > Is arch support in upstream binutils and gcc? Yes, it is

Re: [PATCH 08/31] nds32: Cache and TLB routines

On Wed, Nov 8, 2017 at 6:54 AM, Greentime Hu wrote: > +#ifndef __NDS32_PROCFNS_H__ > +#define __NDS32_PROCFNS_H__ > + > +#define CPU_NAME n13 > + > +#ifdef __KERNEL__ > + > +#ifdef __STDC__ > +#define cpu_fn(name,fn) name##fn > +#else > +#define cpu_fn(name,fn)

Re: [PATCH 05/31] nds32: MMU definitions

2017-11-08 16:36 GMT+08:00 Arnd Bergmann : > On Wed, Nov 8, 2017 at 6:54 AM, Greentime Hu wrote: > >> +/* >> + * The DMA mask corresponding to the maximum bus address allocatable >> + * using GFP_DMA. The default here places no restriction on DMA >> + *

Re: [PATCH 11/31] nds32: Atomic operations

On Wed, Nov 8, 2017 at 6:54 AM, Greentime Hu wrote: > From: Greentime Hu > > Signed-off-by: Vincent Chen > Signed-off-by: Greentime Hu > --- > arch/nds32/include/asm/futex.h| 116

Re: [PATCH net-next 2/4] net: phy: sfp: Use correct endian for sfp->id.ext.options

On Tue, Nov 07, 2017 at 07:49:09PM -0800, Florian Fainelli wrote: > The extended ID options 16-bit value is big-endian (and actually annotated as > such), but we would be accessing it with our CPU endian, which would not > allow the correct detection of whether the LOS signal is inverted or not. >

[net-next v2 1/1] tipc: improve link resiliency when rps is activated

Currently, the TIPC RPS dissector is based only on the incoming packets' source node address, hence steering all traffic from a node to the same core. We have seen that this makes the links vulnerable to starvation and unnecessary resets when we turn down the link tolerance to very low values. To

Re: [PATCH 00/31] Andes(nds32) Linux Kernel Port

On Wed, Nov 8, 2017 at 6:54 AM, Greentime Hu wrote: > This patchset adds core architecture support to Linux for Andestech's > N13, N15, D15, N10, D10 processor cores. > > Based on the 16/32-bit AndeStar RISC-like architecture, we designed the > configurable AndesCore series of

RE: [PATCH 0/9] use network namespace for iSCSI control interfaces

From: Chris Leech > Sent: 07 November 2017 22:45 > > I've posted these changes to allow iSCSI management within a container > using a network namespace to the SCSI and Open-iSCSI lists, but seeing > as it's not really SCSI/block related I'm casting a wider net looking > for reviews. I didn't

Re: [kernel-hardening] Re: [PATCH resend 2/2] userns: control capabilities of some user namespaces

Sorry folks I was traveling and seems like lot happened on this thread. :p I will try to response few of these comments selectively - > The thing that makes me hesitate with this set is that it is a > permanent new feature to address what (I hope) is a temporary > problem. I agree this is

Re: iwlegacy: remove redundant pointer sta_priv

Colin Ian King wrote: > From: Colin Ian King > > Pointer sta_priv is assigned but never read, hence it is redundant > and can be removed. Cleans up clang warning: > > drivers/net/wireless/intel/iwlegacy/4965-rs.c:2163:2: warning: Value >

Re: [PATCH] ARM: dts: add phy-reset property for rk3066a-rayeager emac

Hi Florian Fainelli On 2017年11月08日 02:26, Florian Fainelli wrote: On 11/07/2017 01:51 AM, Chris Zhong wrote: On 2017年11月07日 15:54, Vladimir Zapolskiy wrote: Hello Chris, On 11/07/2017 04:49 AM, Chris Zhong wrote: The ethernet phy of rk3066a-rayeager has a reset pin, it controlled by

[RFC PATCH -tip 0/6] net: tcp: sctp: dccp: Replace jprobe usage with trace events

Hi, This series introduce new trace events which allows user to trace network congestion window etc. via ftrace or perftools. And remove jprobe usages (tcp_probe/dccp_probe/sctp_probe). So this series removes all register_jprobe users from the kernel tree. So following example in

[PATCH net-next v10 3/3] act_vlan: VLAN action rewrite to use RCU lock/unlock and update

Using a spinlock in the VLAN action causes performance issues when the VLAN action is used on multiple cores. Rewrote the VLAN action to use RCU read locking for reads and updates instead. All functions now use an RCU dereferenced pointer to access the VLAN action context. Modified helper

[PATCH net-next v10 2/3] nfp flower action: Modified to use VLAN helper functions

Modified netronome nfp flower action to use VLAN helper functions instead of accessing/referencing TC act_vlan private structures directly. Reviewed-by: Pieter Jansen van Vuuren Signed-off-by: Manish Kurup ---

Re: [1/3] rtlwifi: fix uninitialized rtlhal->last_suspend_sec time

Arnd Bergmann wrote: > We set rtlhal->last_suspend_sec to an uninitialized stack variable, > but unfortunately gcc never warned about this, I only found it > while working on another patch. I opened a gcc bug for this. > > Presumably the value of rtlhal->last_suspend_sec is not

Re: regression: UFO removal breaks kvm live migration

From: Jason Wang Date: Wed, 8 Nov 2017 21:53:27 +0900 > On 2017年11月08日 20:32, David Miller wrote: >> From: Jason Wang >> Date: Wed, 8 Nov 2017 17:25:48 +0900 >> >>> On 2017年11月08日 17:08, Willem de Bruijn wrote: That won't help in the short term.

Re: [PATCH 29/31] MAINTAINERS: Add nds32

On Tue, Nov 7, 2017 at 11:55 PM, Greentime Hu wrote: > From: Greentime Hu > > Signed-off-by: Greentime Hu > --- > MAINTAINERS |9 + > 1 file changed, 9 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS >

[RFC PATCH -tip 5/6] net: dccp: Add DCCP sendmsg trace event

Add DCCP sendmsg trace event (dccp/dccp_probe) for replacing dccpprobe. User can trace this event via ftrace or perftools. Signed-off-by: Masami Hiramatsu --- net/dccp/proto.c |5 +++ net/dccp/trace.h | 105 ++ 2

[RFC PATCH -tip 6/6] net: dccp: Remove dccpprobe module

Remove DCCP probe module since jprobe has been deprecated. That function is now replaced by dccp/dccp_probe trace-event. You can use it via ftrace or perftools. Signed-off-by: Masami Hiramatsu --- net/dccp/Kconfig | 17 net/dccp/Makefile |2 - net/dccp/probe.c

Re: [PATCH 25/31] nds32: defconfig

On Wed, Nov 8, 2017 at 6:55 AM, Greentime Hu wrote: > From: Greentime Hu > > Signed-off-by: Vincent Chen > Signed-off-by: Greentime Hu > --- > arch/nds32/configs/ae3xx_defconfig | 110 >

Re: Is there a race between __mod_timer() and del_timer()?

On Wed, 8 Nov 2017, David Howells wrote: > Is there a race between the optimisation for networking code in __mod_timer() > and del_timer() - or, at least, a race that matters? > > Consider: > > CPU A CPU B > ===

Re: [PATCH 5/7] scripts/leaking_addresses: add emailing results

On Wed, Nov 08, 2017 at 11:16:43AM +0100, Petr Mladek wrote: > On Wed 2017-11-08 14:37:37, Tobin C. Harding wrote: > > Developers may not have the time (or inclination) to investigate script > > output. This information is, however, useful. If we add functionality to > > the script to email

Re: [PATCH net-next 1/2] net: add support for Cavium PTP coprocessor

On 11/07/2017 10:49 PM, David Daney wrote: On 11/07/2017 11:07 AM, Aleksey Makarov wrote: From: Radoslaw Biernacki This patch adds support for the Precision Time Protocol Clocks and Timestamping hardware found on Cavium ThunderX processors. Signed-off-by: Radoslaw

[RFC PATCH -tip 1/6] net: tcp: Add trace events for TCP congestion window tracing

This adds an event to trace TCP stat variables with slightly intrusive trace-event. This uses ftrace/perf event log buffer to trace those state, no needs to prepare own ring-buffer, nor custom user apps. User can use ftrace to trace this event as below; # cd /sys/kernel/debug/tracing # echo

[RFC PATCH -tip 3/6] net: sctp: Add SCTP ACK tracking trace event

Add SCTP ACK tracking trace event to trace the changes of SCTP association state in response to incoming packets. It is used for debugging SCTP congestion control algorithms, and will replace sctp_probe module. Note that this event a bit tricky. Since this consists of 2 events (sctp_probe and

Re: [PATCH 4/7] scripts/leaking_addresses: add reporting

On Wed 2017-11-08 14:37:36, Tobin C. Harding wrote: > Currently script just dumps all results found. Potentially, this risks > loosing single results among multiple duplicate results. We need some > way of restricting duplicates to assist users of the script. It would > also be nice if we got a

[PATCH net] net: hns3: Updates MSI/MSI-X alloc/free APIs(depricated) to new APIs

This patch migrates the HNS3 driver code from use of depricated PCI MSI/MSI-X interrupt vector allocation/free APIs to new common APIs. Signed-off-by: Salil Mehta Suggested-by: Christoph Hellwig --- .../ethernet/hisilicon/hns3/hns3pf/hclge_main.c| 108

Re: [kernel-hardening] [PATCH v4] scripts: add leaking_addresses.pl

"Tobin C. Harding" writes: > Currently we are leaking addresses from the kernel to user space. This > script is an attempt to find some of those leakages. Script parses > `dmesg` output and /proc and /sys files for hex strings that look like > kernel addresses. > > Only works for

Re: [PATCH 24/31] nds32: Miscellaneous header files

On Wed, Nov 8, 2017 at 6:55 AM, Greentime Hu wrote: > + > +static inline void __delay(unsigned long loops) > +{ > + __asm__ __volatile__(".align 2\n" > +"1:\n" > +"\taddi\t%0, %0, -1\n" > +

Re: [PATCH 26/31] nds32: Build infrastructure

On Wed, Nov 8, 2017 at 6:55 AM, Greentime Hu wrote: > diff --git a/arch/nds32/Kconfig b/arch/nds32/Kconfig > new file mode 100644 > index 000..112f470 > --- /dev/null > +++ b/arch/nds32/Kconfig > @@ -0,0 +1,107 @@ > +# > +# For a description of the syntax of this

Re: [PATCH 5/7] scripts/leaking_addresses: add emailing results

On Wed 2017-11-08 14:37:37, Tobin C. Harding wrote: > Developers may not have the time (or inclination) to investigate script > output. This information is, however, useful. If we add functionality to > the script to email results for further investigation. > > Add --send-report flag to email

Is there a race between __mod_timer() and del_timer()?

Is there a race between the optimisation for networking code in __mod_timer() and del_timer() - or, at least, a race that matters? Consider: CPU A CPU B === === [timer X is active]

Re: [PATCH net-next 1/4] net: phy: sfp: Do not reject soldered down modules

On Tue, Nov 07, 2017 at 07:49:08PM -0800, Florian Fainelli wrote: > The SFP module identification code in sfp_sm_mod_probe() will reject SFF > modules soldered down because they have an identified of 0x2, while the code > currently checks for 0x3 only (SFP_PHYS_ID_SFP), update that. > >

Fwd: [PATCH net-next v6 3/3] act_vlan: VLAN action rewrite to use RCU lock/unlock and update

Hi Dave, On Tue, Nov 7, 2017 at 7:07 PM, David Miller wrote: > > From: Alexander Duyck > Date: Tue, 7 Nov 2017 08:54:20 -0800 > > > Are we really going to be so strict about the reverse xmas-tree that > > we won't allow for assignment w/ variable

Re: syzbot:dup: general protection fault in __lock_acquire (2)

On Sun, Nov 5, 2017 at 3:34 PM, Jon Maloy wrote: > The problem was already known, but the solution is non-trivial, and needs > some more review and testing before I can submit it. > > ///Jon Maloy Hi Jon, Thank you very much for actually bothering to reply with the dup

[PATCH] net: realtek: r8169: remove redundant assignment to giga_ctrl

From: Colin Ian King The variable giga_ctrl is being assigned to zero however this is never read and hence the assignment is redundant, so remove it. Cleans up clang warning: drivers/net/ethernet/realtek/r8169.c:1978:3: warning: Value stored to 'giga_ctrl' is never

[PATCH v2 net-next 03/12] tls: Fix TLS ulp context leak, when TLS_TX setsockopt is not used.

Previously the TLS ulp context would leak if we attached a TLS ulp to a socket but did not use the TLS_TX setsockopt, or did use it but it failed. This patch solves the issue by overriding prot[TLS_BASE_TX].close and fixing tls_sk_proto_close to work properly when its called with ctx->tx_conf ==

[PATCH v2 net-next 00/12] tls: Add generic NIC offload infrastructure

Changes from v1: - Remove the binding of the socket to a specific netdev through sk->sk_bound_dev_if. Add a check in validate_xmit_skb to detect route changes and call SW fallback code to do the crypto in software. - tls_get_record now returns the tls record sequence number. This is

[PATCH v2 net-next 09/12] net: Add SW fallback infrastructure for offloaded sockets

Offloaded sockets rely on the netdev to transform the transmitted packets before sending them over the network. When a packet from an offloaded socket is looped back or rerouted to a different device we need to detect it and do the transformation in software Signed-off-by: Ilya Lesokhin

[PATCH v2 net-next 04/12] tls: Move tls_make_aad to header to allow sharing

move tls_make_aad as it is going to be reused by the device offload code Signed-off-by: Ilya Lesokhin --- include/net/tls.h | 15 +++ net/tls/tls_sw.c | 18 +- 2 files changed, 16 insertions(+), 17 deletions(-) diff --git a/include/net/tls.h

[PATCH v2 net-next 02/12] tls: Add function to update the TLS socket configuration

The tx configuration is now stored in ctx->tx_conf. And sk->sk_prot is updated trough a function This will simplify things when we add rx and support for different possible tx and rx cross configurations. Signed-off-by: Ilya Lesokhin --- include/net/tls.h | 2 ++

[PATCH v2 net-next 08/12] net: Rename and export copy_skb_header

copy_skb_header is renamed to skb_copy_header and exported. Exposing this function give more flexibility in copying SKBs. skb_copy and skb_copy_expand do not give enough control over which parts are copied. Signed-off-by: Ilya Lesokhin --- include/linux/skbuff.h | 1 +

[PATCH v2 net-next 05/12] tls: Avoid copying crypto_info again after cipher_type check.

Avoid copying crypto_info again after cipher_type check to avoid a TOCTOU exploits. The temporary array on the stack is removed as we don't really need it Fixes: 3c4d7559159b ('tls: kernel TLS support') Signed-off-by: Ilya Lesokhin --- net/tls/tls_main.c | 29

[PATCH v2 net-next 06/12] tls: don't override sk_write_space if tls_set_sw_offload fails.

If we fail to enable tls in the kernel we shouldn't override the sk_write_space callback Fixes: 3c4d7559159b ('tls: kernel TLS support') Signed-off-by: Ilya Lesokhin --- net/tls/tls_main.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git

[PATCH v2 net-next 12/12] tls: Add generic NIC offload infrastructure.

This patch adds a generic infrastructure to offload TLS crypto to a network devices. It enables the kernel TLS socket to skip encryption and authentication operations on the transmit side of the data path. Leaving those computationally expensive operations to the NIC. The NIC offload

[PATCH v2 net-next 11/12] net: Add TLS TX offload features

This patch adds a netdev feature to configure TLS TX offloads. Signed-off-by: Boris Pismenny Signed-off-by: Ilya Lesokhin Signed-off-by: Aviad Yehezkel --- include/linux/netdev_features.h | 2 ++ net/core/ethtool.c |

Re: [PATCH 02/31] nds32: Kernel booting and initialization

On Tue, Nov 7, 2017 at 11:54 PM, Greentime Hu wrote: > From: Greentime Hu > Commit message needed. > Signed-off-by: Vincent Chen > Signed-off-by: Greentime Hu > --- > + /* it could update

[PATCH v2 net-next 10/12] net: Add TLS offload netdev ops

Add new netdev ops to add and delete tls context Signed-off-by: Boris Pismenny Signed-off-by: Ilya Lesokhin Signed-off-by: Aviad Yehezkel --- include/linux/netdevice.h | 21 + 1 file changed, 21 insertions(+)

[PATCH v2 net-next 01/12] tls: Use kzalloc for aead_request allocation

Use kzalloc for aead_request allocation as we don't set all the bits in the request. Fixes: 3c4d7559159b ('tls: kernel TLS support') Signed-off-by: Ilya Lesokhin --- net/tls/tls_sw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/tls/tls_sw.c

[PATCH v2 net-next 07/12] tcp: Add clean acked data hook

Called when a TCP segment is acknowledged. Could be used by application protocols who hold additional metadata associated with the stream data This is required by TLS device offload to release metadata associated with acknowledged TLS records. Signed-off-by: Boris Pismenny

Re: Is there a race between __mod_timer() and del_timer()?

David Howells wrote: > I think it might just be best to put a note in the comments in __mod_timer(). How about the attached? David --- commit d538c734f9bf885292b88a81a06c5efee528d70d Author: David Howells Date: Wed Nov 8 10:20:27 2017 + Add

[PATCH net-next] net: dsa: lan9303: Fix lan9303_alr_del_port()

Fix embarrassing bug in lan9303_alr_del_port(): Instead of zeroing entr->mac_addr, I destroyed the next cache entry. Affected .port_fdb_del and .port_mdb_del. Fixes: 0620427ea0d6 ("net: dsa: lan9303: Add fdb/mdb manipulation") Signed-off-by: Egil Hjelmeland ---

[PATCH net-next] net: dsa: lan9303: Documentation: Add missing word "Mbps"

Signed-off-by: Egil Hjelmeland --- Documentation/networking/dsa/lan9303.txt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Documentation/networking/dsa/lan9303.txt b/Documentation/networking/dsa/lan9303.txt index ec28683d107d..144b02b95207

Re: rtlwifi: remove redundant initialization to cfg_cmd

Colin Ian King wrote: > From: Colin Ian King > > cfg_cmd is initialized to zero and this value is never read, instead > it is over-written in the start of a do-while loop. Remove the > redundant initialization. Cleans up clang warning: > >

Re: zd1201: remove unused variable framelen

Colin Ian King wrote: > From: Colin Ian King > > Variable framelen is assigned but never read, hence it is redundant > and can be removed. Cleans up clang warning: > > drivers/net/wireless/zydas/zd1201.c:234:3: warning: Value stored > to

Re: [PATCH net-next 2/3] ip6_gre: Refactor ip6gre xmit codes

On Tue, Nov 7, 2017 at 6:10 PM, David Miller wrote: > From: William Tu > Date: Sun, 5 Nov 2017 10:39:04 -0800 > >> diff --git a/net/ipv6/ip6_gre.c b/net/ipv6/ip6_gre.c >> index 3e10c51e7e0c..8c7612f32926 100644 >> --- a/net/ipv6/ip6_gre.c >> +++

Re: [PATCH 23/31] nds32: Device tree support

On Wed, Nov 8, 2017 at 6:55 AM, Greentime Hu wrote: > From: Greentime Hu > > Signed-off-by: Vincent Chen > Signed-off-by: Greentime Hu > --- > arch/nds32/boot/dts/Makefile |8 ++ >

RE: [PATCH 11/31] nds32: Atomic operations

> -Original Message- > From: arndbergm...@gmail.com [mailto:arndbergm...@gmail.com] On > Behalf Of Arnd Bergmann > Sent: Wednesday, November 08, 2017 4:54 PM > To: Greentime Hu > Cc: Greentime Ying-Han Hu(胡英漢); Linux Kernel Mailing List; linux-arch; > Thomas Gleixner; Jason Cooper; Marc

Re: [PATCH 00/31] Andes(nds32) Linux Kernel Port

On Wed, Nov 8, 2017 at 9:41 AM, Greentime Hu wrote: > 2017-11-08 16:32 GMT+08:00 David Howells : >> Greentime Hu wrote: >> >>> The build script and toolchain repositories are able to be found here: >>>

Re: [PATCH] net/tcp: track all ipv4/tcp state transition in tcp_set_state

2017-11-08 14:51 GMT+08:00 David Miller : > From: Yafang Shao > Date: Tue, 7 Nov 2017 18:36:28 +0800 > >> When I hooked the function tcp_set_state with kprobe to track the ipv4/tcp >> state transistion, I found state transition from TCP_LISTEN to

Re: regression: UFO removal breaks kvm live migration

From: Jason Wang Date: Wed, 8 Nov 2017 17:25:48 +0900 > On 2017年11月08日 17:08, Willem de Bruijn wrote: >> That won't help in the short term. I'm still reading up to see if >> there are >> any other options besides reimplement or advertise-but-drop, such as >> an implicit

RE: mlx5 broken affinity

From: Sagi Grimberg > Sent: 08 November 2017 07:28 ... > > Why would you give the user a knob to destroy what you carefully optimized? > > Well, looks like someone relies on this knob, the question is if he is > doing something better for his workload. I don't know, its really up to > the user to

Re: orinoco_usb: remove redundant pointer dev

Colin Ian King wrote: > From: Colin Ian King > > The pointer dev is assigned but never read, hence it is redundant > and can be removed. Cleans up clang warning: > > drivers/net/wireless/intersil/orinoco/orinoco_usb.c:1468:2: warning: >

Re: regression: UFO removal breaks kvm live migration

On 2017年11月08日 20:32, David Miller wrote: From: Jason Wang Date: Wed, 8 Nov 2017 17:25:48 +0900 On 2017年11月08日 17:08, Willem de Bruijn wrote: That won't help in the short term. I'm still reading up to see if there are any other options besides reimplement or

Re: KASAN: use-after-free Read in worker_thread (2)

On Wed, Nov 8, 2017 at 1:58 PM, syzbot wrote: > Hello, > > syzkaller hit the following crash on > 7dfaa7bc99498da1c6c4a48bee8d2d5265161a8c > git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/master > compiler:

Re: [PATCH 27/31] dt-bindings: interrupt-controller: Andestech Internal Vector Interrupt Controller

+DT list On Tue, Nov 7, 2017 at 11:55 PM, Greentime Hu wrote: > From: Greentime Hu Commit msg needed. > Signed-off-by: Rick Chen > Signed-off-by: Greentime Hu > --- >

Re: [PATCH net-next v10 1/3] act_vlan: Change stats update to use per-core stats

On Wed, Nov 8, 2017 at 9:03 PM, Manish Kurup wrote: > The VLAN action maintains one set of stats across all cores, and uses a > spinlock to synchronize updates to it from the same. Changed this to use a > per-CPU stats context instead. > This change will result in better

Re: mlx5 broken affinity

On 11/07/2017 10:07 AM, Thomas Gleixner wrote: > On Sun, 5 Nov 2017, Sagi Grimberg wrote: >> I do agree that the user would lose better cpu online/offline behavior, >> but it seems that users want to still have some control over the IRQ >> affinity assignments even if they lose this functionality.

Re: [PATCH net-next V4 0/3] tools: bpftool: show filenames of pinned objects

On Wed, 8 Nov 2017 13:55:46 +0900, Prashant Bhole wrote: > This patchset adds support to show pinned objects in object details. > > Patch1 adds a funtionality to open a path in bpf-fs regardless of its object > type. > > Patch2 adds actual functionality by scanning the bpf-fs once and adding >

Re: mlx5 broken affinity

On 11/08/2017 05:21 AM, David Laight wrote: > From: Sagi Grimberg >> Sent: 08 November 2017 07:28 > ... >>> Why would you give the user a knob to destroy what you carefully optimized? >> >> Well, looks like someone relies on this knob, the question is if he is >> doing something better for his

RE: [PATCH net-next 1/2] net: hns3: fix a bug when getting phy address from NCL_config file

Hi Andrew, > -Original Message- > From: Andrew Lunn [mailto:and...@lunn.ch] > Sent: Wednesday, November 08, 2017 2:31 PM > To: lipeng (Y) > Cc: da...@davemloft.net; netdev@vger.kernel.org; linux- > ker...@vger.kernel.org; Linuxarm; Zhuangyuzeng (Yisen); Salil Mehta > Subject: Re: [PATCH

Re: [PATCH v3 net-next 0/5] IGMP snooping for local traffic

On 07. nov. 2017 18:58, Andrew Lunn wrote: Hi Andrew! When local application join multicast; the driver get 2 X .port_mdb_prepare + 4 x .port_mdb_add for the address. Humm, i would expect equal numbers of those. To be precise: it is (1 .port_mdb_prepare + 2 x .port_mdb_add), two times. I

Re: [PATCH v3 net-next 0/5] IGMP snooping for local traffic

Hi Egil, Egil Hjelmeland writes: > But _all_ .port_mdb_add are repeated twice as well. This is more > interesting. I suspect that there is a missing "return 0;" in > dsa_switch_mdb_add(), at the end of the "if > (switchdev_trans_ph_prepare(trans)) {". Dating back

Re: [PATCH net] net: dsa: return after vlan prepare phase

On Wed, Nov 08, 2017 at 10:50:10AM -0500, Vivien Didelot wrote: > The current code does not return after successfully preparing the VLAN > addition on every ports member of a it. Fix this. > > Fixes: 1ca4aa9cd4cc ("net: dsa: check VLAN capability of every switch") > Signed-off-by: Vivien Didelot

Re: regression: UFO removal breaks kvm live migration

On Wed, Nov 08, 2017 at 08:32:31PM +0900, David Miller wrote: > From: Jason Wang > Date: Wed, 8 Nov 2017 17:25:48 +0900 > > > On 2017年11月08日 17:08, Willem de Bruijn wrote: > >> That won't help in the short term. I'm still reading up to see if > >> there are > >> any other

[PATCH] nl802154: Improve unlocking of a table in four functions

From: Markus Elfring Date: Wed, 8 Nov 2017 17:08:55 +0100 * Add jump targets so that a call of the function "rdev_unlock_llsec_table" is stored only once in these function implementations. * Replace four calls by goto statements. This issue was detected by

Re: [PATCH net-next 1/2] net: hns3: fix a bug when getting phy address from NCL_config file

On Wed, Nov 08, 2017 at 03:52:22PM +0800, Lipeng wrote: > From: Fuyun Liang > > Driver gets phy address from NCL_config file and uses the phy address > to initialize phydev. There are 5 bits for phy address. And C22 phy > address has 5 bits. So 0-31 are all valid address

Re: [PATCH net-next v10 1/3] act_vlan: Change stats update to use per-core stats

Hi Or, On Wed, Nov 8, 2017 at 9:20 AM, Or Gerlitz wrote: > On Wed, Nov 8, 2017 at 9:03 PM, Manish Kurup wrote: >> The VLAN action maintains one set of stats across all cores, and uses a >> spinlock to synchronize updates to it from the same. Changed

Re: [PATCH net-next] net: dsa: lan9303: Fix lan9303_alr_del_port()

Egil Hjelmeland writes: > Fix embarrassing bug in lan9303_alr_del_port(): Instead of zeroing > entr->mac_addr, I destroyed the next cache entry. Affected .port_fdb_del and > .port_mdb_del. > > Fixes: 0620427ea0d6 ("net: dsa: lan9303: Add fdb/mdb manipulation") >

Re: [PATCH v3 net-next 0/5] IGMP snooping for local traffic

On Wed, Nov 08, 2017 at 04:11:12PM +0100, Egil Hjelmeland wrote: > On 07. nov. 2017 18:58, Andrew Lunn wrote: > >>Hi Andrew! > >> > >>When local application join multicast; the driver get 2 X .port_mdb_prepare > >>+ 4 x .port_mdb_add for the address. > > > >Humm, i would expect equal numbers of

[PATCH net] net: dsa: return after mdb prepare phase

The current code does not return after successfully preparing the MDB addition on every ports member of a multicast group. Fix this. Fixes: a1a6b7ea7f2d ("net: dsa: add cross-chip multicast support") Reported-by: Egil Hjelmeland Signed-off-by: Vivien Didelot

  1   2   3   4   >