[PATCH] sock: Remove the global prot_inuse counter.

2017-11-09 Thread Tonghao Zhang
The per-cpu counter for init_net is prepared in core_initcall. The patch 7d720c3e ("percpu: add __percpu sparse annotations to net") and d6d9ca0fe ("net: this_cpu_xxx conversions") optimize the routines. Then remove the old counter. Cc: Pavel Emelyanov Signed-off-by: Tonghao

Re: [PATCH] ARM: dts: add phy-reset property for rk3066a-rayeager emac

2017-11-09 Thread Roger Quadros
On 08/11/17 11:49, Chris Zhong wrote: > Hi Florian Fainelli > > > On 2017年11月08日 02:26, Florian Fainelli wrote: >> On 11/07/2017 01:51 AM, Chris Zhong wrote: >>> >>> On 2017年11月07日 15:54, Vladimir Zapolskiy wrote: Hello Chris, On 11/07/2017 04:49 AM, Chris Zhong wrote: > The

Re: [PATCH 25/31] nds32: defconfig

2017-11-09 Thread Arnd Bergmann
On Thu, Nov 9, 2017 at 9:00 AM, Greentime Hu wrote: > 2017-11-08 18:03 GMT+08:00 Arnd Bergmann : >> On Wed, Nov 8, 2017 at 6:55 AM, Greentime Hu wrote: >>> From: Greentime Hu >>> >>> Signed-off-by: Vincent Chen

Re: FW: [PATCH 24/31] nds32: Miscellaneous header files

2017-11-09 Thread Vincent Chen
>>On Wed, Nov 8, 2017 at 6:55 AM, Greentime Hu wrote: >> + >> +static inline void __delay(unsigned long loops) { >> + __asm__ __volatile__(".align 2\n" >> +"1:\n" >> +"\taddi\t%0, %0, -1\n" >> +

Re: kernel BUG at net/key/af_key.c:LINE!

2017-11-09 Thread Herbert Xu
On Wed, Nov 08, 2017 at 08:59:15AM +0100, Dmitry Vyukov wrote: > > Also the repro needs to be compiled with -m32 (but it does not compile > without it due to missing __NR_mmap2, so I guess you passed -m32). OK that's what I was missing. I had hacked it to compile in 64-bit :) However, I still

Re: [PATCH] net: sfc: remove redundant variable start

2017-11-09 Thread Bert Kenward
On 09/11/17 08:01, Colin King wrote: > From: Colin Ian King > > Variable start is assigned but never read hence it is redundant > and can be removed. Cleans up clang warning: > > drivers/net/ethernet/sfc/ptp.c:655:2: warning: Value stored to 'start' > is never read >

Re: [PATCH 00/31] Andes(nds32) Linux Kernel Port

2017-11-09 Thread Greentime Hu
2017-11-08 18:26 GMT+08:00 Arnd Bergmann : > On Wed, Nov 8, 2017 at 6:54 AM, Greentime Hu wrote: >> This patchset adds core architecture support to Linux for Andestech's >> N13, N15, D15, N10, D10 processor cores. >> >> Based on the 16/32-bit AndeStar RISC-like

Re: [PATCH 28/31] irqchip: Andestech Internal Vector Interrupt Controller driver

2017-11-09 Thread Greentime Hu
2017-11-08 22:24 GMT+08:00 Marc Zyngier : > On 08/11/17 05:55, Greentime Hu wrote: >> From: Greentime Hu >> > > Please add a commit message, indicating what this does, and potentially > a pointer to some documentation (if publicly available). >

Re: mlx5 broken affinity

2017-11-09 Thread Christoph Hellwig
On Wed, Nov 08, 2017 at 09:13:59AM -0700, Jens Axboe wrote: > There are numerous valid reasons to be able to set the affinity, for > both nics and block drivers. It's great that the kernel has a predefined > layout that works well, but users do need the flexibility to be able to > reconfigure

Re: [PATCH 29/31] MAINTAINERS: Add nds32

2017-11-09 Thread Arnd Bergmann
On Thu, Nov 9, 2017 at 10:46 AM, Greentime Hu wrote: > 2017-11-08 21:31 GMT+08:00 Rob Herring : >> On Tue, Nov 7, 2017 at 11:55 PM, Greentime Hu wrote: >>> From: Greentime Hu >>> >>> Signed-off-by: Greentime Hu

Re: [PATCH] ARM: dts: add phy-reset property for rk3066a-rayeager emac

2017-11-09 Thread Roger Quadros
On 09/11/17 10:28, Roger Quadros wrote: > On 08/11/17 11:49, Chris Zhong wrote: >> Hi Florian Fainelli >> >> >> On 2017年11月08日 02:26, Florian Fainelli wrote: >>> On 11/07/2017 01:51 AM, Chris Zhong wrote: On 2017年11月07日 15:54, Vladimir Zapolskiy wrote: > Hello Chris, > > On

Re: [PATCH 27/31] dt-bindings: interrupt-controller: Andestech Internal Vector Interrupt Controller

2017-11-09 Thread Greentime Hu
2017-11-08 21:25 GMT+08:00 Rob Herring : > +DT list > > On Tue, Nov 7, 2017 at 11:55 PM, Greentime Hu wrote: >> From: Greentime Hu > > Commit msg needed. Thanks. I will add commit msg in the next version patch. >> Signed-off-by:

Re: [PATCH 02/31] nds32: Kernel booting and initialization

2017-11-09 Thread Greentime Hu
2017-11-08 21:38 GMT+08:00 Rob Herring : > On Tue, Nov 7, 2017 at 11:54 PM, Greentime Hu wrote: >> From: Greentime Hu >> > > Commit message needed. Thanks. I will add more commit messages in the next version patch. > >>

Re: mlx5 broken affinity

2017-11-09 Thread Sagi Grimberg
Thomas, Because the user sometimes knows better based on statically assigned loads, or the user wants consistency across kernels. It's great that the system is better at allocating this now, but we also need to allow for a user to change it. Like anything on Linux, a user wanting to blow off

Re: [PATCH] ARM: dts: add phy-reset property for rk3066a-rayeager emac

2017-11-09 Thread Roger Quadros
Hi, On 07/11/17 09:54, Vladimir Zapolskiy wrote: > Hello Chris, > > On 11/07/2017 04:49 AM, Chris Zhong wrote: >> The ethernet phy of rk3066a-rayeager has a reset pin, it controlled by >> GPIO1_D6, this pin should be pull down then pull up to reset the phy. >> Add a phy-reset property in emac,

Re: [net-next v4 3/4] openvswitch: Add meter infrastructure

2017-11-09 Thread Pravin Shelar
On Thu, Nov 9, 2017 at 11:00 AM, Andy Zhou wrote: > OVS kernel datapath so far does not support Openflow meter action. > This is the first stab at adding kernel datapath meter support. > This implementation supports only drop band type. > > Signed-off-by: Andy Zhou

Re: [PATCH net-next 2/6] net: dsa: return after mdb prepare phase

2017-11-09 Thread Egil Hjelmeland
On 08. nov. 2017 18:19, Vivien Didelot wrote: The current code does not return after successfully preparing the MDB addition on every ports member of a multicast group. Fix this. Fixes: a1a6b7ea7f2d ("net: dsa: add cross-chip multicast support") Reported-by: Egil Hjelmeland

RE: [PATCH x86 v2] uprobe: emulate push insns for uprobe on x86

2017-11-09 Thread David Laight
From: Yonghong Song > Sent: 09 November 2017 00:55 > > Uprobe is a tracing mechanism for userspace programs. > Typical uprobe will incur overhead of two traps. > First trap is caused by replaced trap insn, and > the second trap is to execute the original displaced > insn in user space. > > To

[PATCH] netdev: add netdev_pagefrag_enabled sysctl

2017-11-09 Thread Hongbo Li
From: Hongbo Li This patch solves a memory frag issue when allocating skb. I found this issue in a udp scenario, here is my test model: 1. About five hundreds udp threads listen on server, and five hundreds client threads send udp pkts to them. Some threads send

Re: [net-next v4 4/4] openvswitch: Add meter action support

2017-11-09 Thread Pravin Shelar
On Thu, Nov 9, 2017 at 11:00 AM, Andy Zhou wrote: > Implements OVS kernel meter action support. > > Signed-off-by: Andy Zhou > --- I could not apply this patch on latest net-next.

Re: [net 3/6] net/mlx5: FPGA, return -EINVAL if size is zero

2017-11-09 Thread Or Gerlitz
On Thu, Nov 9, 2017 at 4:43 PM, Kamal Heib wrote: > On Wed, 2017-11-08 at 23:13 +0900, Or Gerlitz wrote: >> On Wed, Nov 8, 2017 at 4:21 PM, Saeed Mahameed >> wrote: >> > From: Kamal Heib >> > >> > In the current code, if a size of

Re: [net 3/6] net/mlx5: FPGA, return -EINVAL if size is zero

2017-11-09 Thread Or Gerlitz
On Thu, Nov 9, 2017 at 4:43 PM, Kamal Heib wrote: > On Wed, 2017-11-08 at 23:13 +0900, Or Gerlitz wrote: >> On Wed, Nov 8, 2017 at 4:21 PM, Saeed Mahameed >> wrote: >> > From: Kamal Heib >> > >> > In the current code, if a size of

Re: [PATCH 30/31] dt-bindings: nds32 CPU Bindings

2017-11-09 Thread Greentime Hu
2017-11-08 21:18 GMT+08:00 Rob Herring : > Please Cc the DT list on bindings. Sorry. I am not sure what you mean. Do you mean add devicet...@vger.kernel.org to cc list? > On Tue, Nov 7, 2017 at 11:55 PM, Greentime Hu wrote: >> From: Greentime Hu

Re: [PATCH 13/31] nds32: DMA mapping API

2017-11-09 Thread Arnd Bergmann
On Thu, Nov 9, 2017 at 8:12 AM, Greentime Hu wrote: > 2017-11-08 17:09 GMT+08:00 Arnd Bergmann : >> On Wed, Nov 8, 2017 at 6:55 AM, Greentime Hu wrote: >> >> You do the same cache operations for _to_cpu and _to_device, which >> usually

Re: [PATCH 26/31] nds32: Build infrastructure

2017-11-09 Thread Arnd Bergmann
On Thu, Nov 9, 2017 at 10:02 AM, Greentime Hu wrote: > 2017-11-08 18:16 GMT+08:00 Arnd Bergmann : >> On Wed, Nov 8, 2017 at 6:55 AM, Greentime Hu wrote: >>> +config GENERIC_CALIBRATE_DELAY >>> + def_bool y >> >> It's better to avoid

[PATCH net-next] net: thunderbolt: Clear finished Tx frame bus address in tbnet_tx_callback()

2017-11-09 Thread Mika Westerberg
When Thunderbolt network interface is disabled or when the cable is unplugged the driver releases all allocated buffers by calling tbnet_free_buffers() for each ring. This function then calls dma_unmap_page() for each buffer it finds where bus address is non-zero. Now, we only clear this bus

[PATCH net-next] net: thunderx: fix double free error

2017-11-09 Thread Aleksey Makarov
This patch fixes an error in memory allocation/freeing in ThunderX PF driver. I moved the allocation to the probe() function and made it managed. >From the Colin's email: While running static analysis on linux-next with CoverityScan I found 3 double free errors in the Cavium thunder driver.

Re: [PATCH 29/31] MAINTAINERS: Add nds32

2017-11-09 Thread Greentime Hu
2017-11-08 21:31 GMT+08:00 Rob Herring : > On Tue, Nov 7, 2017 at 11:55 PM, Greentime Hu wrote: >> From: Greentime Hu >> >> Signed-off-by: Greentime Hu >> --- >> MAINTAINERS |9 + >> 1 file

[PATCH v2 1/2] cxgb4: Add support for Inline IPSec Tx

2017-11-09 Thread Atul Gupta
Added Tx routine for ULD - define interface for ULD Tx. Export routines used for Tx data - Routines common for data transmit are used by cxgb4 and chcr drivers. - EXPORT routines enable transmit from chcr driver. Signed-off-by: Atul Gupta Signed-off-by: Harsh Jain

[PATCH v2 2/2] chcr: Add support for Inline IPSec

2017-11-09 Thread Atul Gupta
register xfrmdev_ops callbacks, Send IPsec tunneled data to HW for inline processing. The driver use hardware crypto accelerator to encrypt and generate ICV for the transmitted packet in Inline mode. Signed-off-by: Atul Gupta Signed-off-by: Harsh Jain

Re: [PATCH net] net: hns3: Updates MSI/MSI-X alloc/free APIs(depricated) to new APIs

2017-11-09 Thread Yuval Shaia
On Wed, Nov 08, 2017 at 11:56:06AM +, Salil Mehta wrote: > This patch migrates the HNS3 driver code from use of depricated PCI > MSI/MSI-X interrupt vector allocation/free APIs to new common APIs. > > Signed-off-by: Salil Mehta > Suggested-by: Christoph Hellwig

Re: [PATCH 26/31] nds32: Build infrastructure

2017-11-09 Thread Greentime Hu
2017-11-08 18:16 GMT+08:00 Arnd Bergmann : > On Wed, Nov 8, 2017 at 6:55 AM, Greentime Hu wrote: > >> diff --git a/arch/nds32/Kconfig b/arch/nds32/Kconfig >> new file mode 100644 >> index 000..112f470 >> --- /dev/null >> +++ b/arch/nds32/Kconfig >> @@ -0,0

Re: [PATCH net-next 1/6] net: dsa: remove trans argument from mdb ops

2017-11-09 Thread Egil Hjelmeland
On 08. nov. 2017 18:19, Vivien Didelot wrote: The DSA switch MDB ops pass the switchdev_trans structure down to the drivers, but no one is using them and they aren't supposed to anyway. Remove the trans argument from MDB prepare and add operations. - int (*port_mdb_prepare)(struct

Re: [PATCH 00/31] Andes(nds32) Linux Kernel Port

2017-11-09 Thread Greentime Hu
2017-11-08 18:18 GMT+08:00 Arnd Bergmann : > On Wed, Nov 8, 2017 at 9:41 AM, Greentime Hu wrote: >> 2017-11-08 16:32 GMT+08:00 David Howells : >>> Greentime Hu wrote: >>> The build script and toolchain repositories

[PATCH] ipvlan: fix ipv6 outbound device

2017-11-09 Thread liuqifa
From: Keefe Liu When process the outbound packet of ipv6, we should assign the master device to output device other than input device. Signed-off-by: Keefe Liu --- drivers/net/ipvlan/ipvlan_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [ovs-dev] [PATCH] openvswitch: add null pointer check on upcall

2017-11-09 Thread Pravin Shelar
On Thu, Nov 9, 2017 at 7:29 PM, Colin King wrote: > From: Colin Ian King > > upcall may be assigned a NULL pointer as genlmsg_put can potentially > return a NULL. Add a null check to avoid a null pointer dereference > on upcall. > > Detected

Re: mlx5 broken affinity

2017-11-09 Thread Thomas Gleixner
On Thu, 9 Nov 2017, Sagi Grimberg wrote: > Thomas, > > > > Because the user sometimes knows better based on statically assigned > > > loads, or the user wants consistency across kernels. It's great that the > > > system is better at allocating this now, but we also need to allow for a > > > user

[PATCH net-next 2/2] tcp: handle TCP_TIME_WAIT/TCP_NEW_SYN_RECV in tcp_set_state tracepoint

2017-11-09 Thread Yafang Shao
When TCP connetion in TCP_TIME_WAIT or TCP_NEW_SYN_RECV state, it can't get the sport/dport/saddr/daddr from inet_sock. trace_tcp_set_state may be called when the oldstate in these two states. Signed-off-by: Yafang Shao --- include/trace/events/tcp.h | 33

[PATCH net-next 1/2] net/tcp: track all TCP/IP state transition in tcp_set_state

2017-11-09 Thread Yafang Shao
The TCP/IP transition from TCP_LISTEN to TCP_SYN_RECV isn't traced in the tcp_set_state tracepoint. In order to trace the whole tcp lifespans, two helpers are introduced, static inline void __tcp_set_state(struct sock *sk, int state) static inline void __sk_state_store(struct sock *sk, int

Re: [PATCH 30/31] dt-bindings: nds32 CPU Bindings

2017-11-09 Thread Rob Herring
On Thu, Nov 9, 2017 at 3:39 AM, Greentime Hu wrote: > 2017-11-08 21:18 GMT+08:00 Rob Herring : >> Please Cc the DT list on bindings. > > Sorry. I am not sure what you mean. > Do you mean add devicet...@vger.kernel.org to cc list? Yes. Use

[PATCH] openvswitch: add null pointer check on upcall

2017-11-09 Thread Colin King
From: Colin Ian King upcall may be assigned a NULL pointer as genlmsg_put can potentially return a NULL. Add a null check to avoid a null pointer dereference on upcall. Detected by CoverityScan, CID#728404 ("Dereference null return value") Fixes: commit ccb1352e76cf

Re: [PATCH] uprobes/x86: emulate push insns for uprobe on x86

2017-11-09 Thread Oleg Nesterov
On 11/09, Oleg Nesterov wrote: > > And. Do you really need ->post_xol() method to emulate "push"? Why we can't > simply execute it out-of-line if copy_to_user() fails? > > branch_post_xol_op() is needed because we can't execute "call" out-of-line, > we need to restart and try again if

Re: [PATCH v3 net-next 0/5] IGMP snooping for local traffic

2017-11-09 Thread Vivien Didelot
Hi David, David Miller writes: > From: David Miller > Date: Thu, 09 Nov 2017 11:30:32 +0900 (KST) > >> Series applied, with the spurious whitespace change removed from patch >> #5. > > Actually I had to revert, this doesn't build: > > net/dsa/slave.c:

Re: [PATCH net-next 2/2] tcp: handle TCP_TIME_WAIT/TCP_NEW_SYN_RECV in tcp_set_state tracepoint

2017-11-09 Thread Eric Dumazet
On Thu, 2017-11-09 at 06:52 -0800, Eric Dumazet wrote: > Wow. > > > Since all three variants of sockets (full sockets, request sockets, > timewait sockets) are all hashed into ehash table these days, they all > have the fields at the same offset > > For IPv4, that would be : > >

Re: [PATCH net-next 2/2] tcp: handle TCP_TIME_WAIT/TCP_NEW_SYN_RECV in tcp_set_state tracepoint

2017-11-09 Thread Yafang Shao
2017-11-09 22:58 GMT+08:00 Eric Dumazet : > On Thu, 2017-11-09 at 06:52 -0800, Eric Dumazet wrote: > >> Wow. >> >> >> Since all three variants of sockets (full sockets, request sockets, >> timewait sockets) are all hashed into ehash table these days, they all >> have the

Re: [PATCH 4/4] RFC: net: dsa: realtek-smi: Add Realtek SMI driver

2017-11-09 Thread Roman Yeryomin
On 2017-11-09 15:24, Andrew Lunn wrote: Although it could be a good thing to bring this to mainline, I'm kind of pessimistic about supporting such switches in DSA/switchdev. IMO swconfig does a better job for now. I think the important point here is "... for now" ... as always, probably

Re: mlx5 broken affinity

2017-11-09 Thread Jens Axboe
On 11/09/2017 07:19 AM, Thomas Gleixner wrote: > On Thu, 9 Nov 2017, Sagi Grimberg wrote: >> Thomas, >> Because the user sometimes knows better based on statically assigned loads, or the user wants consistency across kernels. It's great that the system is better at allocating this

RE: [PATCH net] net: hns3: Updates MSI/MSI-X alloc/free APIs(depricated) to new APIs

2017-11-09 Thread Salil Mehta
Hi Yuval, > -Original Message- > From: Yuval Shaia [mailto:yuval.sh...@oracle.com] > Sent: Thursday, November 09, 2017 8:27 AM > To: Salil Mehta > Cc: da...@davemloft.net; h...@lst.de; Zhuangyuzeng (Yisen); lipeng (Y); > mehta.salil@gmail.com; netdev@vger.kernel.org; linux- >

Re: [PATCH net-next 2/2] tcp: handle TCP_TIME_WAIT/TCP_NEW_SYN_RECV in tcp_set_state tracepoint

2017-11-09 Thread Eric Dumazet
On Thu, 2017-11-09 at 23:11 +0800, Yafang Shao wrote: > I'm also very sad that I'm still using IPv4 in 2017 : ( > > Okay then another issue, > shoule we reduce the complexity in the function tcp4_seq_show() ? This is irrelevant really. I do not see how tcp4_seq_show() could avoid testing

Re: mlx5 broken affinity

2017-11-09 Thread Jens Axboe
On 11/09/2017 03:09 AM, Christoph Hellwig wrote: > On Wed, Nov 08, 2017 at 09:13:59AM -0700, Jens Axboe wrote: >> There are numerous valid reasons to be able to set the affinity, for >> both nics and block drivers. It's great that the kernel has a predefined >> layout that works well, but users do

Re: [PATCH 4/4] RFC: net: dsa: realtek-smi: Add Realtek SMI driver

2017-11-09 Thread Roman Yeryomin
On 2017-11-06 01:19, Linus Walleij wrote: This adds a driver core for the Realtek SMI chips and a subdriver for the RTL8366RB. I just added this chip simply because it is all I can test. The code is a massaged variant of the code that has been sitting out-of-tree in OpenWRT for years in the

Re: [PATCH] uprobes/x86: emulate push insns for uprobe on x86

2017-11-09 Thread Oleg Nesterov
On 11/09, Yonghong Song wrote: > > This patch extends the emulation to "push " > insns. These insns are typical in the beginning > of the function. For example, bcc > in https://github.com/iovisor/bcc repo provides > tools to measure funclantency, detect memleak, etc. > The tools will place

Re: [PATCH] uprobes/x86: emulate push insns for uprobe on x86

2017-11-09 Thread Oleg Nesterov
On 11/09, Yonghong Song wrote: > > + if (insn_class == UPROBE_PUSH_INSN) { > + src_ptr = get_push_reg_ptr(auprobe, regs); > + reg_width = sizeof_long(); > + sp = regs->sp; > + if (copy_to_user((void __user *)(sp - reg_width), src_ptr, >

Re: [PATCH v3 01/21] grace: replace BUG_ON by WARN_ONCE in exit_net hook

2017-11-09 Thread J. Bruce Fields
Applied for 4.15, thanks.--b. On Mon, Nov 06, 2017 at 04:22:48PM +0300, Vasily Averin wrote: > Signed-off-by: Vasily Averin > --- > fs/nfs_common/grace.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/fs/nfs_common/grace.c

Re: [PATCH v3 02/21] lockd: added cleanup checks in exit_net hook

2017-11-09 Thread J. Bruce Fields
Applied.--b. On Mon, Nov 06, 2017 at 04:23:24PM +0300, Vasily Averin wrote: > Signed-off-by: Vasily Averin > --- > fs/lockd/svc.c | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/fs/lockd/svc.c b/fs/lockd/svc.c > index 809cbcc..2a48558 100644 > ---

Re: mlx5 broken affinity

2017-11-09 Thread Saeed Mahameed
On Wed, 2017-11-08 at 09:27 +0200, Sagi Grimberg wrote: > > Depending on the machine and the number of queues this might even > > result in > > completely losing the ability to suspend/hibernate because the > > number of > > available vectors on CPU0 is not sufficient to accomodate all queue > >

Re: mlx5 broken affinity

2017-11-09 Thread Jens Axboe
On 11/09/2017 03:50 AM, Sagi Grimberg wrote: > Thomas, > >>> Because the user sometimes knows better based on statically assigned >>> loads, or the user wants consistency across kernels. It's great that the >>> system is better at allocating this now, but we also need to allow for a >>> user to

TO:参展负责人【收】——参展JEC是一个复合材料及新材料企业走向国际化的标志和途径 {mD-C50-上P3} 下午 11:14:59

2017-11-09 Thread 2017-11-09 23:14:59
JEC world Composites Show & Conferences 2018 2018第53届JEC世界复合材料展览及会议    —— 参展JEC是一个复合材料及新材料企业走向国际化的标志和途径    【中文名称】 2018第53届世界JEC复合材料展览及会议(法国巴黎) 【英文名称】 The 53th JEC Composites Show & Conferences 2018 in Paris France (JEC world 2018)    【展会时间】 2018年03月06-08日 (正月十九至二十一) 【展会地点】 法国巴黎北维勒班展览中心 (Paris

Re: [PATCH 4/4] RFC: net: dsa: realtek-smi: Add Realtek SMI driver

2017-11-09 Thread Andrew Lunn
> Although it could be a good thing to bring this to mainline, I'm kind of > pessimistic about supporting such switches in DSA/switchdev. IMO swconfig > does a better job for now. I think the important point here is "... for now" > Unless switchdev could be expanded to support other functions

Re: [PATCH v2 net-next 0/6] mv88e6xxx broadcast flooding in hardware

2017-11-09 Thread Vivien Didelot
Hi, David Miller writes: > net/dsa/slave.c: In function ‘dsa_slave_port_attr_get’: > net/dsa/slave.c:349:35: error: ‘struct dsa_switch_tree’ has no member named > ‘tree’ >attr->u.ppid.id_len = sizeof(dst->tree); >^~ >

Re: [PATCH net-next 2/2] tcp: handle TCP_TIME_WAIT/TCP_NEW_SYN_RECV in tcp_set_state tracepoint

2017-11-09 Thread Eric Dumazet
On Thu, 2017-11-09 at 14:26 +, Yafang Shao wrote: > When TCP connetion in TCP_TIME_WAIT or TCP_NEW_SYN_RECV state, it can't > get the sport/dport/saddr/daddr from inet_sock. > > trace_tcp_set_state may be called when the oldstate in these two states. > > Signed-off-by: Yafang Shao

Re: mlx5 broken affinity

2017-11-09 Thread Sagi Grimberg
The early discussion of the managed facility came to the conclusion that it will manage this stuff completely to allow fixed association of 'queue / interrupt / corresponding memory' to a single CPU or a set of CPUs. That removes a lot of 'affinity' handling magic from the driver and utilizes

Re: mlx5 broken affinity

2017-11-09 Thread Thomas Gleixner
On Thu, 9 Nov 2017, Jens Axboe wrote: > On 11/09/2017 09:01 AM, Sagi Grimberg wrote: > >> Now you try to blame the people who implemented the managed affinity stuff > >> for the wreckage, which was created by people who changed drivers to use > >> it. Nice try. > > > > I'm not trying to blame

Re: [PATCH resend 2/2] userns: control capabilities of some user namespaces

2017-11-09 Thread Serge E. Hallyn
Quoting Mahesh Bandewar (mah...@bandewar.net): > From: Mahesh Bandewar > > With this new notion of "controlled" user-namespaces, the controlled > user-namespaces are marked at the time of their creation while the > capabilities of processes that belong to them are controlled

Re: [PATCH resend 1/2] capability: introduce sysctl for controlled user-ns capability whitelist

2017-11-09 Thread Serge E. Hallyn
Quoting Mahesh Bandewar (mah...@bandewar.net): > From: Mahesh Bandewar > > Add a sysctl variable kernel.controlled_userns_caps_whitelist. This I understand the arguments in favor of whitelists in most cases for security purposes. But given that you've said the goal here is

Re: [kernel-hardening] Re: [PATCH resend 2/2] userns: control capabilities of some user namespaces

2017-11-09 Thread chris hyser
On 11/06/2017 10:23 PM, Serge E. Hallyn wrote: I think I definately prefer what I mentioned in the email to Boris. Basically a "permanent capability bounding set". The normal bounding set gets reset to a full set on every new user_ns creation. In this proposal, it would instead be set to the

Re: [PATCH 4/4] RFC: net: dsa: realtek-smi: Add Realtek SMI driver

2017-11-09 Thread Andrew Lunn
> >>Unless switchdev could be expanded to support other functions beyond > >>VLAN, > >>like port rate control, ACL, HW NAT (no switchdev L3 offload doesn't fit > >>this), etc. > > > >Switchdev allows offloading of TC. So port rate control would be > >implemented via TC. > > That's interesting.

[PATCH net-next] bindings: net: stmmac: correctify note about LPI interrupt

2017-11-09 Thread Niklas Cassel
There are two different combined signal for various interrupt events: In EQOS-CORE and EQOS-MTL configurations, mci_intr_o is the interrupt signal. In EQOS-DMA, EQOS-AHB and EQOS-AXI configurations, these interrupt events are combined with the events in the DMA on the sbd_intr_o signal. Depending

[PATCH net-next] net: dsa: remove tree refcount

2017-11-09 Thread Vivien Didelot
Setting the refcount to 0 when allocating a tree to match the number of switch devices it holds may cause an 'increment on 0; use-after-free'. Tracking the number of devices in a tree with a kref is not really appropriate anyway so removes it completely in favor of a basic counter. Fixes:

Re: [PATCH 4/4] RFC: net: dsa: realtek-smi: Add Realtek SMI driver

2017-11-09 Thread Florian Fainelli
On 11/09/2017 09:24 AM, Andrew Lunn wrote: >> The registers writing code is where? switchdev driver? >> All I care about is that all the switch specific code should be in one >> place. > > The switch specific code is in the switch specific driver. > > Take a look under drivers/net/dsa for the

Re: mlx5 broken affinity

2017-11-09 Thread Sagi Grimberg
Again, I think Jes or others can provide more information. Sagi, I believe Jes is not trying to argue about what initial affinity values you give to the driver, We have a very critical regression that is afflicting Live systems today and common tools that already exists in various distros,

Re: mlx5 broken affinity

2017-11-09 Thread Jens Axboe
On 11/09/2017 09:01 AM, Sagi Grimberg wrote: >> Now you try to blame the people who implemented the managed affinity stuff >> for the wreckage, which was created by people who changed drivers to use >> it. Nice try. > > I'm not trying to blame anyone, really. I was just trying to understand > how

[PATCH V2 net] net: hns3: Updates MSI/MSI-X alloc/free APIs(depricated) to new APIs

2017-11-09 Thread Salil Mehta
This patch migrates the HNS3 driver code from use of depricated PCI MSI/MSI-X interrupt vector allocation/free APIs to new common APIs. Signed-off-by: Salil Mehta Suggested-by: Christoph Hellwig --- PATCH V2: Yuval Shaia Link ->

Re: [PATCH resend 1/2] capability: introduce sysctl for controlled user-ns capability whitelist

2017-11-09 Thread Serge E. Hallyn
Quoting Mahesh Bandewar (mah...@bandewar.net): > From: Mahesh Bandewar > > Add a sysctl variable kernel.controlled_userns_caps_whitelist. This > takes input as capability mask expressed as two comma separated hex > u32 words. The mask, however, is stored in kernel as

pull-request: net-next: ieee802154 2017-11-09

2017-11-09 Thread Stefan Schmidt
A small update on ieee802154 patches for net-next. Nothing dramatic, but simply housekeeping this time around. A fix for the correct mask to be applied in the mrf24j40 driver by Gustavo A. R. Silva Removal of a non existing email user for the ca8210 driver by Harry Morris A bunch of checkpatch

Re: [PATCH 4/4] RFC: net: dsa: realtek-smi: Add Realtek SMI driver

2017-11-09 Thread Roman Yeryomin
On 2017-11-09 17:38, Andrew Lunn wrote: >>Unless switchdev could be expanded to support other functions beyond >>VLAN, >>like port rate control, ACL, HW NAT (no switchdev L3 offload doesn't fit >>this), etc. > >Switchdev allows offloading of TC. So port rate control would be >implemented via TC.

Re: [kernel-hardening] Re: [PATCH resend 2/2] userns: control capabilities of some user namespaces

2017-11-09 Thread Serge E. Hallyn
Quoting chris hyser (chris.hy...@oracle.com): > On 11/06/2017 10:23 PM, Serge E. Hallyn wrote: > >I think I definately prefer what I mentioned in the email to Boris. > >Basically a "permanent capability bounding set". The normal bounding > >set gets reset to a full set on every new user_ns

Re: mlx5 broken affinity

2017-11-09 Thread Thomas Gleixner
On Thu, 9 Nov 2017, Jens Axboe wrote: > On 11/09/2017 07:19 AM, Thomas Gleixner wrote: > If that's the attitude at your end, then I do suggest we just revert the > driver changes. Clearly this isn't going to be productive going forward. > > The better solution was to make the managed setup more

Re: [vlan_device_event] BUG: unable to handle kernel paging request at 6b6b6ccf

2017-11-09 Thread Girish Moodalbail
On 11/8/17 10:34 PM, Cong Wang wrote: On Wed, Nov 8, 2017 at 7:12 PM, Fengguang Wu wrote: Hi Alex, So looking over the trace the panic seems to be happening after a decnet interface is getting deleted. Is there any chance we could try compiling the kernel without

Re: [kernel-hardening] Re: [PATCH resend 2/2] userns: control capabilities of some user namespaces

2017-11-09 Thread Serge E. Hallyn
Quoting Mahesh Bandewar (महेश बंडेवार) (mahe...@google.com): > Of course. Let's take an example of the CVE that I have mentioned in > my cover-letter - > CVE-2017-7308(https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2017-7308). > It's well documented and even has a >

Re: [PATCH x86 v2] uprobe: emulate push insns for uprobe on x86

2017-11-09 Thread Yonghong Song
On 11/9/17 3:26 AM, David Laight wrote: From: Yonghong Song Sent: 09 November 2017 00:55 Uprobe is a tracing mechanism for userspace programs. Typical uprobe will incur overhead of two traps. First trap is caused by replaced trap insn, and the second trap is to execute the original displaced

Re: [PATCH 4/4] RFC: net: dsa: realtek-smi: Add Realtek SMI driver

2017-11-09 Thread Andrew Lunn
> The registers writing code is where? switchdev driver? > All I care about is that all the switch specific code should be in one > place. The switch specific code is in the switch specific driver. Take a look under drivers/net/dsa for the switches which are currently supported by DSA.

Re: [PATCH 18/27] bpf: Restrict kernel image access functions when the kernel is locked down

2017-11-09 Thread David Howells
Alexei Starovoitov wrote: > > TBH, I've no idea how bpf does anything, so I can't say whether this is > > better, overkill or insufficient. > > ok. To make it clear: > Nacked-by: Alexei Starovoitov > For the current patch. > Unnecessary checks for

Re: [PATCH] net: mvneta: fix handling of the Tx descriptor counter

2017-11-09 Thread Andreas Tobler
Hi Simon, On 08.11.17 18:17, Simon Guinot wrote: Hi Sven and Andreas, Please, can you try with this patch ? Today we, my son and I, repeated the failing scenario and we were able to show that our scenario behaves stable after you patch being applied. Thanks for taking care of this issue.

Re: [PATCH] [net-next,v3] ibmvnic: Feature implementation of Vital Product Data (VPD) for the ibmvnic driver

2017-11-09 Thread Tushar Dave
On 11/09/2017 11:00 AM, Desnes Augusto Nunes do Rosario wrote: This patch implements and enables VDP support for the ibmvnic driver. Moreover, it includes the implementation of suitable structs, signal transmission/handling and functions which allows the retrival of firmware information

Re: [PATCH v3 net-next 0/5] IGMP snooping for local traffic

2017-11-09 Thread Florian Fainelli
On 11/09/2017 11:30 AM, Andrew Lunn wrote: >> This means that switchdev drivers won't ever have to treat a HOST_MDB >> notification any differently than a PORT_MDB notification > > No, they need to treat it very differently. Allow me to rephrase, switchdev drivers will ignore HOST_MDB

Re: [PATCH v2 0/8] Cavium OCTEON-III network driver.

2017-11-09 Thread David Daney
I need to send v3. With this v2 set, there is a small bug in the RX initialization that causes failure on little-endian kernels. David. On 11/08/2017 04:51 PM, David Daney wrote: We are adding the Cavium OCTEON-III network driver. But since interacting with the input and output queues is

Re: [kernel-hardening] Re: [PATCH resend 2/2] userns: control capabilities of some user namespaces

2017-11-09 Thread chris hyser
On 11/09/2017 01:05 PM, Serge E. Hallyn wrote: Would the existing capability bounding set not suffice for that? The 'permanent' bounding set turns out to not be a good fit for the problem being discussed in this thread, but please feel free to start a new thread if you want to discuss your use

Re: [PATCH v3 net-next 0/5] IGMP snooping for local traffic

2017-11-09 Thread Andrew Lunn
> This means that switchdev drivers won't ever have to treat a HOST_MDB > notification any differently than a PORT_MDB notification No, they need to treat it very differently. A PORT_MDB says that frames for a group should be sent out that port. So it probably needs to iterate all the ports in

[PATCH v3 8/8] MAINTAINERS: Add entry for drivers/net/ethernet/cavium/octeon/octeon3-*

2017-11-09 Thread David Daney
Signed-off-by: David Daney --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 9a24f56e0451..142af33adc35 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3212,6 +3212,12 @@ W: http://www.cavium.com S:

Re: [PATCH v3 net-next 0/5] IGMP snooping for local traffic

2017-11-09 Thread Andrew Lunn
On Thu, Nov 09, 2017 at 11:38:26AM -0800, Florian Fainelli wrote: > On 11/09/2017 11:30 AM, Andrew Lunn wrote: > >> This means that switchdev drivers won't ever have to treat a HOST_MDB > >> notification any differently than a PORT_MDB notification > > > > No, they need to treat it very

Re: [PATCH] kallsyms: don't leak address when printing symbol

2017-11-09 Thread Steven Rostedt
On Thu, 9 Nov 2017 16:45:48 +1100 "Tobin C. Harding" wrote: > On Wed, Nov 08, 2017 at 10:35:55PM -0500, Steven Rostedt wrote: > > On Thu, 9 Nov 2017 12:50:29 +1100 > > "Tobin C. Harding" wrote: > > > > > Currently if a pointer is printed using %p[ssB] and the

Re: [PATCH] net/tcp: introduce TRACE_EVENT for TCP/IPv4 state transition

2017-11-09 Thread Song Liu
> On Nov 9, 2017, at 10:18 AM, Steven Rostedt wrote: > > On Thu, 9 Nov 2017 15:43:29 +0900 > Alexei Starovoitov wrote: > >>> +TRACE_EVENT(tcp_set_state, >>> + TP_PROTO(struct sock *sk, int oldstate, int newstate), >>> + TP_ARGS(sk,

[PATCH] [net-next,v3] ibmvnic: Feature implementation of Vital Product Data (VPD) for the ibmvnic driver

2017-11-09 Thread Desnes Augusto Nunes do Rosario
This patch implements and enables VDP support for the ibmvnic driver. Moreover, it includes the implementation of suitable structs, signal transmission/handling and functions which allows the retrival of firmware information from the ibmvnic card through the ethtool command. Signed-off-by:

Re: [PATCH net-next] Revert "net: dsa: constify cpu_dp member of dsa_port"

2017-11-09 Thread Florian Fainelli
On 11/09/2017 06:39 AM, Vivien Didelot wrote: > We may have to pass a port's dedicated CPU port to port-wide functions > such as dsa_port_mdb_add, e.g. when offloading bridge device's MDB. > > The DSA port-wide functions currently take a non-const struct dsa_port * > as first argument so we

Re: [PATCH net-next] net: dsa: remove tree refcount

2017-11-09 Thread Vivien Didelot
Hi Andrew, Andrew Lunn writes: > On Thu, Nov 09, 2017 at 12:36:52PM -0500, Vivien Didelot wrote: >> Setting the refcount to 0 when allocating a tree to match the number of >> switch devices it holds may cause an 'increment on 0; use-after-free'. >> >> Tracking the number of

[PATCH net-next v2] Revert "net: dsa: constify cpu_dp member of dsa_port"

2017-11-09 Thread Vivien Didelot
We may have to pass a port's dedicated CPU port to port-wide functions such as dsa_port_mdb_add, e.g. when offloading bridge device's MDB. The DSA port-wide functions currently take a non-const struct dsa_port * as first argument so we cannot make cpu_dp const yet, even though it'd be more

Re: mlx5 broken affinity

2017-11-09 Thread Jens Axboe
On 11/09/2017 10:03 AM, Thomas Gleixner wrote: > On Thu, 9 Nov 2017, Jens Axboe wrote: >> On 11/09/2017 07:19 AM, Thomas Gleixner wrote: >> If that's the attitude at your end, then I do suggest we just revert the >> driver changes. Clearly this isn't going to be productive going forward. >> >> The

Re: [kernel-hardening] [PATCH v4] scripts: add leaking_addresses.pl

2017-11-09 Thread Steven Rostedt
On Thu, 9 Nov 2017 10:24:32 +0530 Kaiwan N Billimoria wrote: > On Thu, Nov 9, 2017 at 10:13 AM, Kaiwan N Billimoria > wrote: > >> But I don't know if there is anything else than the profiling code > >> that _really_ wants access to

[PATCH v3 6/8] staging: octeon: Remove USE_ASYNC_IOBDMA macro.

2017-11-09 Thread David Daney
Previous patch sets USE_ASYNC_IOBDMA to 1 unconditionally. Remove USE_ASYNC_IOBDMA from all if statements. Remove dead code caused by the change. Signed-off-by: David Daney --- drivers/staging/octeon/ethernet-defines.h | 6 --- drivers/staging/octeon/ethernet-rx.c

  1   2   3   >