Re: [PATCH 2/3] bluetooth: hci_ll: add constant for vendor-specific command

2017-12-07 Thread Marcel Holtmann
Hi David, >>> This adds a #define for the vendor-specific HCI command to set the >>> baudrate instead of using the bare 0xff36 multiple times. >>> >>> Signed-off-by: David Lechner >>> --- >>> drivers/bluetooth/hci_ll.c | 10 -- >>> 1 file changed, 8 insertions(+), 2

Re: [PATCH v2 net-next 3/4] bpftool: implement prog load command

2017-12-07 Thread Jakub Kicinski
On Thu, 7 Dec 2017 18:39:08 +, Roman Gushchin wrote: > Add the prog load command to load a bpf program from a specified > binary file and pin it to bpffs. > > Usage description and examples are given in the corresponding man > page. > > Syntax: > $ bpftool prog load SOURCE_FILE FILE > >

[PATCH v6 net-next,mips 3/7] MIPS: Octeon: Automatically provision CVMSEG space.

2017-12-07 Thread David Daney
Remove CONFIG_CAVIUM_OCTEON_CVMSEG_SIZE and automatically calculate the amount of CVMSEG space needed. 1st 128-bytes: Use by IOBDMA 2nd 128-bytes: Reserved by kernel for scratch/TLS emulation. 3rd 128-bytes: OCTEON-III LMTLINE New config variable CONFIG_CAVIUM_OCTEON_EXTRA_CVMSEG provisions

[PATCH v6 net-next,mips 2/7] MIPS: Octeon: Enable LMTDMA/LMTST operations.

2017-12-07 Thread David Daney
From: Carlos Munoz LMTDMA/LMTST operations move data between cores and I/O devices: * LMTST operations can send an address and a variable length (up to 128 bytes) of data to an I/O device. * LMTDMA operations can send an address and a variable length (up to 128) of data

[iproute2] ss: print tcpi_rcv_ssthresh

2017-12-07 Thread Wei Wang
From: Wei Wang tcpi_rcv_ssthresh is an important stats when debugging receive side behavior. Add it to the ss output. Signed-off-by: Wei Wang Signed-off-by: Eric Dumazet --- misc/ss.c | 4 1 file changed, 4 insertions(+) diff

[PATCH v6 net-next,mips 0/7] Cavium OCTEON-III network driver.

2017-12-07 Thread David Daney
We are adding the Cavium OCTEON-III network driver. But since interacting with the input and output queues is done via special CPU local memory, we also need to add support to the MIPS/Octeon architecture code. Aren't SoCs nice in this way? The first five patches add the SoC support needed by

[PATCH v6 net-next,mips 1/7] dt-bindings: Add Cavium Octeon Common Ethernet Interface.

2017-12-07 Thread David Daney
From: Carlos Munoz Add bindings for Common Ethernet Interface (BGX) block. Acked-by: Rob Herring Signed-off-by: Carlos Munoz Signed-off-by: Steven J. Hill Signed-off-by: David Daney ---

[PATCH net 0/3] netvsc fix buffer size issues

2017-12-07 Thread Stephen Hemminger
The changes to allow setting buffer size can cause issues on older versions of Windows Server which have smaller limits. And the actual maximum value for WS2016 is 31M not 16M. This is a resend of patchset that didn't make it to netdev correctly. Haiyang Zhang (3): hv_netvsc: Correct the max

[PATCH net-next 2/2] tools: bpftool: create "uninstall", "doc-uninstall" make targets

2017-12-07 Thread Jakub Kicinski
From: Quentin Monnet Create two targets to remove executable and documentation that would have been previously installed with `make install` and `make doc-install`. Also create a "QUIET_UNINST" helper in tools/scripts/Makefile.include. Do not attempt to remove

Re: [PATCH net-next v2 1/5] net: Introduce NETIF_F_GRO_HW.

2017-12-07 Thread Michael Chan
On Thu, Dec 7, 2017 at 2:43 PM, Alexander Duyck wrote: > On Thu, Dec 7, 2017 at 2:08 PM, Michael Chan > wrote: >> On the bond, you can have LRO enabled and it is propagated to lower >> devices so that lower devices will enable LRO if it is

Re: [PATCH net-next v3 0/2] net: thunderx: add support for PTP clock

2017-12-07 Thread Jakub Kicinski
On Wed, 6 Dec 2017 16:30:56 +0300, Aleksey Makarov wrote: > This series adds support for IEEE 1588 Precision Time Protocol > to Cavium ethernet driver. > > The first patch adds support for the Precision Time Protocol Clocks and > Timestamping coprocessor (PTP) found on Cavium processors. > It

RE: [PATCH net-next] netdevsim: correctly check return value of debugfs_create_dir

2017-12-07 Thread Prashant Bhole
> From: Jakub Kicinski [mailto:jakub.kicin...@netronome.com] > > On Fri, 8 Dec 2017 09:52:50 +0900, Prashant Bhole wrote: > > Return value is now checked with IS_ERROR_OR_NULL because > > debugfs_create_dir doesn't return error value. It either returns NULL > > or a valid pointer. > > > >

Re: [PATCH net-next v2 1/5] net: Introduce NETIF_F_GRO_HW.

2017-12-07 Thread Michael Chan
On Thu, Dec 7, 2017 at 1:35 PM, Alexander Duyck wrote: > On Thu, Dec 7, 2017 at 10:44 AM, Michael Chan > wrote: >> On Thu, Dec 7, 2017 at 10:13 AM, Alexander Duyck >> wrote: >>> On Thu, Dec 7, 2017 at 12:03 AM,

Re: [PATCH V2] selinux: Add SCTP support

2017-12-07 Thread Paul Moore
On Wed, Dec 6, 2017 at 5:17 AM, Richard Haines wrote: > The SELinux SCTP implementation is explained in: > Documentation/security/SELinux-sctp.rst > > Signed-off-by: Richard Haines > --- > V2 Changes > Remove lock from

[PATCH net 3/3] hv_netvsc: Fix the default receive buffer size

2017-12-07 Thread Stephen Hemminger
From: Haiyang Zhang The intended size is 16 MB, and the default slot size is 1728. So, NETVSC_DEFAULT_RX should be 16*1024*1024 / 1728 = 9709. Fixes: 5023a6db73196 ("netvsc: increase default receive buffer size") Signed-off-by: Haiyang Zhang

[PATCH v6 net-next,mips 4/7] staging: octeon: Remove USE_ASYNC_IOBDMA macro.

2017-12-07 Thread David Daney
Previous patch sets USE_ASYNC_IOBDMA to 1 unconditionally. Remove USE_ASYNC_IOBDMA from all if statements. Remove dead code caused by the change. Acked-by: Greg Kroah-Hartman Signed-off-by: David Daney ---

[PATCH net 2/3] hv_netvsc: Limit the receive buffer size for legacy hosts

2017-12-07 Thread Stephen Hemminger
From: Haiyang Zhang Legacy hosts only allow 15 MB receive buffer, and we know the NVSP version only after negotiation. So, we put the limit in netvsc_init_buf(). Fixes: 5023a6db73196 ("netvsc: increase default receive buffer size") Signed-off-by: Haiyang Zhang

[PATCH v6 net-next,mips 7/7] MAINTAINERS: Add entry for drivers/net/ethernet/cavium/octeon/octeon3-*

2017-12-07 Thread David Daney
Signed-off-by: David Daney --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 4007fa2e193e..b4bf5b205380 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3249,6 +3249,12 @@ W: http://www.cavium.com S:

[PATCH v6 net-next,mips 5/7] MIPS: Octeon: Add a global resource manager.

2017-12-07 Thread David Daney
From: Carlos Munoz Add a global resource manager to manage tagged pointers within bootmem allocated memory. This is used by various functional blocks in the Octeon core like the FPA, Ethernet nexus, etc. Signed-off-by: Carlos Munoz Signed-off-by: Steven J.

[PATCH net 1/3] hv_netvsc: Correct the max receive buffer size

2017-12-07 Thread Stephen Hemminger
From: Haiyang Zhang It should be 31 MB on recent host versions. Signed-off-by: Haiyang Zhang Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/hyperv_net.h | 6 -- 1 file changed, 4 insertions(+), 2

[no subject]

2017-12-07 Thread Sistemas administrador
ATENCIÓN; Su buzón ha superado el límite de almacenamiento, que es de 5 GB definidos por el administrador, quien actualmente está ejecutando en 10.9GB, no puede ser capaz de enviar o recibir correo nuevo hasta que vuelva a validar su buzón de correo electrónico. Para revalidar su buzón de

[PATCH net-next] netdevsim: correctly check return value of debugfs_create_dir

2017-12-07 Thread Prashant Bhole
Return value is now checked with IS_ERROR_OR_NULL because debugfs_create_dir doesn't return error value. It either returns NULL or a valid pointer. Signed-off-by: Prashant Bhole --- drivers/net/netdevsim/netdev.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH net-next] net: stmmac: fix broken dma_interrupt handling for multi-queues

2017-12-07 Thread Niklas Cassel
There is nothing that says that number of TX queues == number of RX queues. E.g. the ARTPEC-6 SoC has 2 TX queues and 1 RX queue. This code is obviously wrong: for (chan = 0; chan < tx_channel_count; chan++) { struct stmmac_rx_queue *rx_q = >rx_queue[chan]; priv->rx_queue has size

[PATCH next] ipvlan: add L2 check for packets arriving via virtual devices

2017-12-07 Thread Mahesh Bandewar
From: Mahesh Bandewar Packets that don't have dest mac as the mac of the master device should not be entertained by the IPvlan rx-handler. This is mostly true as the packet path mostly takes care of that, except when the master device is a virtual device. As demonstrated in

Re: [PATCH net-next v2 1/5] net: Introduce NETIF_F_GRO_HW.

2017-12-07 Thread Michael Chan
On Thu, Dec 7, 2017 at 3:35 PM, Alexander Duyck wrote: > On Thu, Dec 7, 2017 at 3:17 PM, Michael Chan > wrote: >> I don't get this. I don't see how TSO is related. > > It isn't. That is the point. If I change ANY feature it will trigger >

Re: [PATCH v2 net-next 4/4] bpftool: implement cgroup bpf operations

2017-12-07 Thread Jakub Kicinski
On Thu, 7 Dec 2017 18:39:09 +, Roman Gushchin wrote: > This patch adds basic cgroup bpf operations to bpftool: > cgroup list, attach and detach commands. > > Usage is described in the corresponding man pages, > and examples are provided. > > Syntax: > $ bpftool cgroup list CGROUP > $ bpftool

Re: [PATCH] netfilter: fix clusterip_net_exit build regression

2017-12-07 Thread Pablo Neira Ayuso
On Thu, Dec 07, 2017 at 02:26:09PM +0100, Arnd Bergmann wrote: > The added check produces a build error when CONFIG_PROC_FS is > disabled: > > net/ipv4/netfilter/ipt_CLUSTERIP.c: In function 'clusterip_net_exit': > net/ipv4/netfilter/ipt_CLUSTERIP.c:822:28: error: 'cn' undeclared (first use > in

Re: [PATCH net-next v2 1/5] net: Introduce NETIF_F_GRO_HW.

2017-12-07 Thread Alexander Duyck
On Thu, Dec 7, 2017 at 2:08 PM, Michael Chan wrote: > On Thu, Dec 7, 2017 at 1:35 PM, Alexander Duyck > wrote: >> On Thu, Dec 7, 2017 at 10:44 AM, Michael Chan >> wrote: >>> On Thu, Dec 7, 2017 at 10:13 AM,

[PATCH net-next 1/2] tools: bpftool: harmonise Makefile and Documentation/Makefile

2017-12-07 Thread Jakub Kicinski
From: Quentin Monnet Several minor fixes and harmonisation items for Makefiles: * Use the same mechanism for verbose/non-verbose output in two files ("$(Q)"), for all commands. * Use calls to "QUIET_INSTALL" and equivalent in Makefile. In particular, use

Re: [PATCH v2 net-next 4/4] bpftool: implement cgroup bpf operations

2017-12-07 Thread Philippe Ombredanne
Roman, On Thu, Dec 7, 2017 at 11:23 PM, Jakub Kicinski wrote: > On Thu, 7 Dec 2017 18:39:09 +, Roman Gushchin wrote: >> This patch adds basic cgroup bpf operations to bpftool: >> cgroup list, attach and detach commands. >> >> Usage is described in the

[PATCH net-next 0/2] tools: bpftool: clean up and extend Makefiles

2017-12-07 Thread Jakub Kicinski
Hi! This is a follow up to a series of Makefile fixes for bpftool from two weeks ago. I think there will have to be a merge back of net-next into bpf-next (or rebase), AFAICT the previous series arrived in net-next already, but not in bpf-next. I hope that makes sense. FWIW this should not

Re: [PATCH net-next] netdevsim: correctly check return value of debugfs_create_dir

2017-12-07 Thread Jakub Kicinski
On Fri, 8 Dec 2017 09:52:50 +0900, Prashant Bhole wrote: > Return value is now checked with IS_ERROR_OR_NULL because > debugfs_create_dir doesn't return error value. It either returns > NULL or a valid pointer. > > Signed-off-by: Prashant Bhole > --- >

Re: [PATCH net-next 1/1] forcedeth: remove unnecessary variable

2017-12-07 Thread Yanjun Zhu
On 2017/12/8 3:07, David Miller wrote: From: Zhu Yanjun Date: Wed, 6 Dec 2017 23:15:15 -0500 Since both tx_ring and first_tx are the head of tx ring, it not necessary to use two variables. So first_tx is removed. These are not variables, they are structure members.

Re: [PATCH net-next] net: stmmac: fix broken dma_interrupt handling for multi-queues

2017-12-07 Thread Niklas Cassel
On Thu, Dec 07, 2017 at 11:56:10PM +0100, Niklas Cassel wrote: > Since each DMA channel can be used for rx and tx simultaneously, > the current code should probably be rewritten so that napi_struct is > embedded in a new struct stmmac_channel. > That way, stmmac_poll() can call stmmac_tx_clean()

linux-next: manual merge of the net-next tree with the vfs tree

2017-12-07 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: net/smc/smc_clc.c between commit: d63d271ce2b5 ("smc: switch to sock_recvmsg()") from the vfs tree and commit: e7b7a64a8493 ("smc: support variable CLC proposal messages") from the net-next tree. I fixed it up

Re: [Intel-wired-lan] [next-queue 06/10] ixgbe: restore offloaded SAs after a reset

2017-12-07 Thread Shannon Nelson
On 12/7/2017 1:52 PM, Alexander Duyck wrote: The reads/writes themselves should be cheap. These kind of things only get to be really expensive when you start looking at adding delays in between the writes/reads polling on things. As long as we aren't waiting milliseconds on things you can

Re: [PATCH 8/8] net: tipc: remove unused hardirq.h

2017-12-07 Thread Ying Xue
On 11/18/2017 07:02 AM, Yang Shi wrote: > Preempt counter APIs have been split out, currently, hardirq.h just > includes irq_enter/exit APIs which are not used by TIPC at all. > > So, remove the unused hardirq.h. > > Signed-off-by: Yang Shi > Cc: Jon Maloy

Re: [Intel-wired-lan] [next-queue 06/10] ixgbe: restore offloaded SAs after a reset

2017-12-07 Thread Alexander Duyck
On Thu, Dec 7, 2017 at 10:47 AM, Shannon Nelson wrote: > On 12/7/2017 9:16 AM, Alexander Duyck wrote: >> >> On Wed, Dec 6, 2017 at 9:43 PM, Shannon Nelson >> wrote: >>> >>> On 12/5/2017 9:30 AM, Alexander Duyck wrote: On Mon,

Re: [PATCH net-next V3] tun: add eBPF based queue selection method

2017-12-07 Thread Eric Dumazet
On Mon, 2017-12-04 at 17:31 +0800, Jason Wang wrote: > This patch introduces an eBPF based queue selection method. With > this, > the policy could be offloaded to userspace completely through a new > ioctl TUNSETSTEERINGEBPF. Sorry for the delay, I see this patch was merged already. ... >  

[PATCH net-next 1/2] rtnetlink: allow GSO maximums to be set on device creation

2017-12-07 Thread Stephen Hemminger
From: Stephen Hemminger Netlink device already allows changing GSO sizes with ip set command. The part that is missing is allowing overriding GSO settings on device creation. Signed-off-by: Stephen Hemminger allow set gso on create ---

[PATCH net-next 2/2] veth: set peer GSO values

2017-12-07 Thread Stephen Hemminger
When new veth is created, and GSO values have been configured on one device, clone those values to the peer. For example: # ip link add dev vm1 gso_max_size 65530 type veth peer name vm2 This should create vm1 <--> vm2 with both having GSO maximum size set to 65530. Signed-off-by: Stephen

[PATCH net-next v3 0/2] veth and GSO maximums

2017-12-07 Thread Stephen Hemminger
This is the more general way to solving the issue of GSO limits not being set correctly for containers on Azure. If a GSO packet is sent to host that exceeds the limit (reported by NDIS), then the host is forced to do segmentation in software which has noticeable performance impact. The core

[PATCH net] tcp: invalidate rate samples during SACK reneging

2017-12-07 Thread Yousuk Seung
Mark tcp_sock during a SACK reneging event and invalidate rate samples while marked. Such rate samples may overestimate bw by including packets that were SACKed before reneging. < ack 6001 win 1 sack 7001:38001 < ack 7001 win 0 sack 8001:38001 // Reneg detected > seq 7001:8001 // RTO, SACK

[PATCH] net: intel: e100: Fix warning of passing zero to 'PTR_ERR'

2017-12-07 Thread Vasyl Gomonovych
fw could be NULL and put into PTR_ERR also zero in PTR_ERR will be translated into success return statement Signed-off-by: Vasyl Gomonovych --- drivers/net/ethernet/intel/e100.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

Re: [PATCH net-next v2 1/5] net: Introduce NETIF_F_GRO_HW.

2017-12-07 Thread Alexander Duyck
On Thu, Dec 7, 2017 at 3:17 PM, Michael Chan wrote: > On Thu, Dec 7, 2017 at 2:43 PM, Alexander Duyck > wrote: >> On Thu, Dec 7, 2017 at 2:08 PM, Michael Chan >> wrote: >>> On the bond, you can have LRO enabled

Re: [PATCH v5 net-next] net/tcp: trace all TCP/IP state transition with tcp_set_state tracepoint

2017-12-07 Thread Yafang Shao
2017-12-08 4:02 GMT+08:00 Marcelo Ricardo Leitner : > On Thu, Dec 07, 2017 at 02:10:42PM +, Yafang Shao wrote: >> The TCP/IP transition from TCP_LISTEN to TCP_SYN_RECV and some other >> transitions are not traced with tcp_set_state tracepoint. >> >> In order to trace

[PATCH net-next] netdevsim: remove check on return value of debugfs_create_dir

2017-12-07 Thread Prashant Bhole
Initial discussion started about correct handling of this condition. Later it was decided to remove this check altogether to make it consistent. Removal of this check isn't fatal to this driver. Signed-off-by: Prashant Bhole --- drivers/net/netdevsim/netdev.c |

Re: [PATCH net-next 09/12] sctp: implement renege_events for sctp_stream_interleave

2017-12-07 Thread kbuild test robot
Hi Xin, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Xin-Long/sctp-Implement-Stream-Interleave-The-I-DATA-Chunk-Supporting-User-Message-Interleaving/20171208-031625 config:

Re: BUG: KASAN: use-after-free in tcf_block_put_ext+0x5cf/0x5e0

2017-12-07 Thread Jakub Kicinski
On Thu, 7 Dec 2017 20:51:27 -0800, Jakub Kicinski wrote: > Running the netdevsim test after a week and a bit of not trying it: > > $ make -C tools/testing/selftests/bpf/ CLANG=clang LLC=llc > # ./tools/testing/selftests/bpf/test_offload.py Ah, I didn't clarify - this is net-next at 66c5c5b56682

Re: [PATCH net-next V3] tun: add eBPF based queue selection method

2017-12-07 Thread Jason Wang
On 2017年12月08日 06:11, Eric Dumazet wrote: On Mon, 2017-12-04 at 17:31 +0800, Jason Wang wrote: This patch introduces an eBPF based queue selection method. With this, the policy could be offloaded to userspace completely through a new ioctl TUNSETSTEERINGEBPF. Sorry for the delay, I see this

[PATCH net-next v2] netdevsim: remove return value check of debugfs_create_dir

2017-12-07 Thread Prashant Bhole
Reason: Discussion started about adding error check on return value where it was not handled. Also handling the error using IS_ERR_OR_NULL instead of IS_ERR(), because debugfs_create_dir() doesn't return error. It returns NULL or a valid pointer when DebugFS is enabled. Finally it was decided to

Re: WireGuard Upstreaming Roadmap (November 2017)

2017-12-07 Thread Jason A. Donenfeld
On Thu, Dec 7, 2017 at 11:22 AM, Stefan Tatschner wrote: > I have a question which is related to the involved crypto. As far as I > have understood the protocol and the concept of wireguard > What's your opinion on this? This thread has been picked up on the WireGuard

[PATCH net-next] tuntap: fix possible deadlock when fail to register netdev

2017-12-07 Thread Jason Wang
Private destructor could be called when register_netdev() fail with rtnl lock held. This will lead deadlock in tun_free_netdev() who tries to hold rtnl_lock. Fixing this by switching to use spinlock to synchronize. Fixes: 96f84061620c ("tun: add eBPF based queue selection method") Reported-by:

Re: [PATCH net-next] tuntap: fix possible deadlock when fail to register netdev

2017-12-07 Thread Jason Wang
On 2017年12月08日 11:11, Eric Dumazet wrote: On Fri, 2017-12-08 at 10:54 +0800, Jason Wang wrote: Private destructor could be called when register_netdev() fail with rtnl lock held. This will lead deadlock in tun_free_netdev() who tries to hold rtnl_lock. Fixing this by switching to use spinlock

Re: [PATCH net-next v2] netdevsim: remove return value check of debugfs_create_dir

2017-12-07 Thread Jakub Kicinski
On Fri, 8 Dec 2017 14:32:18 +0900, Prashant Bhole wrote: > Reason: > Discussion started about adding error check on return value where > it was not handled. Also handling the error using IS_ERR_OR_NULL > instead of IS_ERR(), because debugfs_create_dir() doesn't return > error. It returns NULL or

Re: [PATCH] xfrm: fix xfrm_do_migrate() with AEAD e.g(AES-GCM)

2017-12-07 Thread Steffen Klassert
On Thu, Dec 07, 2017 at 09:54:27PM +0100, Antony Antony wrote: > copy geniv when cloning the xfrm state. > > x->geniv was not copied to the new state and migration would fail. > > xfrm_do_migrate > .. > xfrm_state_clone() >.. >.. >esp_init_aead() >crypto_alloc_aead() >

Re: [PATCH net-next] ip6_vti: adjust vti mtu according to mtu of output device

2017-12-07 Thread Steffen Klassert
On Wed, Dec 06, 2017 at 07:38:19PM +0300, Alexey Kodanev wrote: > LTP/udp6_ipsec_vti tests fail when sending large UDP datagrams > that require fragmentation and underlying device MTU <= 1500. > This happens because ip6_vti sets mtu to ETH_DATA_LEN and not > updating it depending on a destiantion

[PATCH v2 0/3] Bluetooth: hci_ll: Get BD address from NVMEM (was "bluetooth: hci_ll: Get MAC address from NVMEM")

2017-12-07 Thread David Lechner
This series adds supporting getting the BD address from a NVMEM provider for "LL" HCI controllers (Texas Instruments). v2 changes: * Fixed typos in dt-bindings * Use "bd-address" instead of "mac-address" * Updated dt-bindings to specify the byte order of "bd-address" * New patch "Bluetooth:

[PATCH v2 2/3] dt-bindings: Add optional nvmem BD address bindings to ti,wlink-st

2017-12-07 Thread David Lechner
This adds optional nvmem consumer properties to the ti,wlink-st device tree bindings to allow specifying the BD address. Signed-off-by: David Lechner --- v2 changes: * Renamed "mac-address" to "bd-address" * Fixed typos in example * Specify byte order of "bd-address"

Re: [PATCH net-next V2] tuntap: fix possible deadlock when fail to register netdev

2017-12-07 Thread Michael S. Tsirkin
On Fri, Dec 08, 2017 at 12:02:30PM +0800, Jason Wang wrote: > Private destructor could be called when register_netdev() fail with > rtnl lock held. This will lead deadlock in tun_free_netdev() who tries > to hold rtnl_lock. Fixing this by switching to use spinlock to > synchronize. > > Fixes:

Re: [PATCH v5 2/2] sock: Move the socket inuse to namespace.

2017-12-07 Thread Eric Dumazet
On Fri, 2017-12-08 at 13:28 +0800, Tonghao Zhang wrote: > On Fri, Dec 8, 2017 at 1:20 AM, Eric Dumazet > wrote: > > On Thu, 2017-12-07 at 08:45 -0800, Tonghao Zhang wrote: > > > In some case, we want to know how many sockets are in use in > > > different _net_ namespaces.

Re: [PATCH nf-next RFC,v2 1/6] netfilter: nf_conntrack: add IPS_OFFLOAD status bit

2017-12-07 Thread Florian Westphal
Pablo Neira Ayuso wrote: > diff --git a/include/uapi/linux/netfilter/nf_conntrack_common.h > b/include/uapi/linux/netfilter/nf_conntrack_common.h > index dc947e59d03a..6b463b88182d 100644 > --- a/include/uapi/linux/netfilter/nf_conntrack_common.h > +++

Re: [PATCH net-next] netdevsim: remove check on return value of debugfs_create_dir

2017-12-07 Thread Jakub Kicinski
On Fri, 8 Dec 2017 11:14:56 +0900, Prashant Bhole wrote: > Initial discussion started about correct handling of this condition. > Later it was decided to remove this check altogether to make it > consistent. > > Removal of this check isn't fatal to this driver. > > Signed-off-by: Prashant Bhole

Re: [PATCH v5 net-next] net/tcp: trace all TCP/IP state transition with tcp_set_state tracepoint

2017-12-07 Thread Yafang Shao
2017-12-08 9:41 GMT+08:00 Yafang Shao : > 2017-12-08 4:02 GMT+08:00 Marcelo Ricardo Leitner : >> On Thu, Dec 07, 2017 at 02:10:42PM +, Yafang Shao wrote: >>> The TCP/IP transition from TCP_LISTEN to TCP_SYN_RECV and some other >>> transitions

Re: [PATCH net-next v2 1/5] net: Introduce NETIF_F_GRO_HW.

2017-12-07 Thread Michael Chan
On Thu, Dec 7, 2017 at 6:36 PM, Alexander Duyck wrote: > On Thu, Dec 7, 2017 at 4:05 PM, Michael Chan > wrote: >> I see. But this won't happen. Because the bonding driver is not >> advertising NETIF_F_GRO_HW in its hw_features. It is not

[PATCH net-next V2] tuntap: fix possible deadlock when fail to register netdev

2017-12-07 Thread Jason Wang
Private destructor could be called when register_netdev() fail with rtnl lock held. This will lead deadlock in tun_free_netdev() who tries to hold rtnl_lock. Fixing this by switching to use spinlock to synchronize. Fixes: 96f84061620c ("tun: add eBPF based queue selection method") Reported-by:

[PATCH net-next v2 1/6] cxgb4: collect on-chip memory information

2017-12-07 Thread Rahul Lakkireddy
Collect memory layout of various on-chip memory regions. Move code for collecting on-chip memory information to cudbg_lib.c and update cxgb4_debugfs.c to use the common function. Also include cudbg_entity.h before cudbg_lib.h to avoid adding cudbg entity structure forward declarations in

[PATCH net-next v2 3/6] cxgb4: collect HMA memory dump

2017-12-07 Thread Rahul Lakkireddy
Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- v2: - No changes. drivers/net/ethernet/chelsio/cxgb4/cudbg_entity.h | 1 + drivers/net/ethernet/chelsio/cxgb4/cudbg_if.h | 1 +

[PATCH net-next v2 4/6] cxgb4: skip TX and RX payload regions in memory dumps

2017-12-07 Thread Rahul Lakkireddy
Use meminfo to identify TX and RX payload regions and skip them in collection of EDC, MC, and HMA. Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- v2: - No changes. drivers/net/ethernet/chelsio/cxgb4/cudbg_entity.h | 7 ++

[PATCH net-next v2 6/6] cxgb4: collect PCIe configuration logs

2017-12-07 Thread Rahul Lakkireddy
Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- v2: - No changes. drivers/net/ethernet/chelsio/cxgb4/cudbg_entity.h | 19 drivers/net/ethernet/chelsio/cxgb4/cudbg_if.h | 1 +

[PATCH net-next v2 5/6] cxgb4: collect egress and ingress SGE queue contexts

2017-12-07 Thread Rahul Lakkireddy
Use meminfo to identify the egress and ingress context regions and fetch all valid contexts from those regions. Also flush all contexts before attempting collection to prevent stale information. Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar

[PATCH net-next v2 2/6] cxgb4: collect MC memory dump

2017-12-07 Thread Rahul Lakkireddy
Use meminfo to get base address and size of MC memory. Also use same meminfo for EDC memory dumps. Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- v2: - No changes. drivers/net/ethernet/chelsio/cxgb4/cudbg_entity.h | 13

[PATCH net-next v2 0/6] cxgb4: collect hardware logs via ethtool

2017-12-07 Thread Rahul Lakkireddy
Collect more hardware logs via ethtool --get-dump facility. Patch 1 collects on-chip memory layout information. Patch 2 collects on-chip MC memory dumps. Patch 3 collects HMA memory dump. Patch 4 evaluates and skips TX and RX payload regions in memory dumps. Patch 5 collects egress and

Re: [PATCH net-next V2] tuntap: fix possible deadlock when fail to register netdev

2017-12-07 Thread Eric Dumazet
On Fri, 2017-12-08 at 12:02 +0800, Jason Wang wrote: > Private destructor could be called when register_netdev() fail with > rtnl lock held. This will lead deadlock in tun_free_netdev() who > tries > to hold rtnl_lock. Fixing this by switching to use spinlock to > synchronize. > > Fixes:

Re: [PATCH net-next] bridge: ebtables: Avoid resetting limit rule state

2017-12-07 Thread Linus Lüssing
On Fri, Dec 08, 2017 at 06:46:06AM +0100, Linus Lüssing wrote: > Extending the usersize to include info->prev would probably be too > hackish/ugly, right? And wouldn't be enough anyway, since info->{credit,credit_cap,cost} would still be zeroed... Hm.

Re: [PATCH net-next v2 1/5] net: Introduce NETIF_F_GRO_HW.

2017-12-07 Thread Alexander Duyck
On Thu, Dec 7, 2017 at 4:05 PM, Michael Chan wrote: > On Thu, Dec 7, 2017 at 3:35 PM, Alexander Duyck > wrote: >> On Thu, Dec 7, 2017 at 3:17 PM, Michael Chan >> wrote: >>> I don't get this. I don't see how TSO

[PATCH v2 3/3] Bluetooth: hci_ll: Add optional nvmem BD address source

2017-12-07 Thread David Lechner
This adds an optional nvmem consumer to get a BD address from an external source. The BD address is then set in the Bluetooth chip after the firmware has been loaded. This has been tested working with a TI CC2560A chip (in a LEGO MINDSTORMS EV3). Signed-off-by: David Lechner

[PATCH v2 1/3] Bluetooth: hci_ll: add support for setting public address

2017-12-07 Thread David Lechner
This adds support for setting the public address on Texas Instruments Bluetooth chips using a vendor-specific command. This has been tested on a CC2560A. The TI wiki also indicates that this command should work on TI WL17xx/WL18xx Bluetooth chips. Signed-off-by: David Lechner

Re: [PATCH net-next 09/12] sctp: implement renege_events for sctp_stream_interleave

2017-12-07 Thread Xin Long
On Fri, Dec 8, 2017 at 11:45 AM, kbuild test robot wrote: > Hi Xin, > > Thank you for the patch! Perhaps something to improve: > > [auto build test WARNING on net-next/master] > > url: >

Re: [PATCH net-next] bridge: ebtables: Avoid resetting limit rule state

2017-12-07 Thread Linus Lüssing
On Thu, Dec 07, 2017 at 01:26:19AM +0100, Pablo Neira Ayuso wrote: > > I also had a quick look at a 4.15-rc1 kernel in a VM now. I still > > end up in ebt_limit_mt_check() with the variables being reset > > when editing the table somewhere. > > My question is if your fix would work with 4.15-rc1.

pull-request: bpf-next 2017-12-07

2017-12-07 Thread Alexei Starovoitov
Hi David, The following pull-request contains BPF updates for your net-next tree. The main changes are: 1) Detailed documentation of BPF development process from Daniel. 2) Addition of is_fullsock, snd_cwnd and srtt_us fields to bpf_sock_ops from Lawrence. 3) Minor follow up for

BUG: KASAN: use-after-free in tcf_block_put_ext+0x5cf/0x5e0

2017-12-07 Thread Jakub Kicinski
Running the netdevsim test after a week and a bit of not trying it: $ make -C tools/testing/selftests/bpf/ CLANG=clang LLC=llc # ./tools/testing/selftests/bpf/test_offload.py [ 284.174418] == [ 284.182655] BUG: KASAN:

Re: [PATCH v5 2/2] sock: Move the socket inuse to namespace.

2017-12-07 Thread Tonghao Zhang
On Fri, Dec 8, 2017 at 1:20 AM, Eric Dumazet wrote: > On Thu, 2017-12-07 at 08:45 -0800, Tonghao Zhang wrote: >> In some case, we want to know how many sockets are in use in >> different _net_ namespaces. It's a key resource metric. >> > > ... > >> +static void

Re: [PATCH v2 08/35] nds32: Process management

2017-12-07 Thread Greentime Hu
2017-12-08 0:45 GMT+08:00 Al Viro : > On Mon, Nov 27, 2017 at 08:27:55PM +0800, Greentime Hu wrote: > >> +#define start_thread(regs,pc,stack) \ >> +({ \ >> + set_fs(USER_DS);

Re: [PATCH v2 06/35] nds32: MMU fault handling and page table management

2017-12-07 Thread Greentime Hu
2017-12-08 0:40 GMT+08:00 Al Viro : > On Mon, Nov 27, 2017 at 08:27:53PM +0800, Greentime Hu wrote: >> +void do_page_fault(unsigned long entry, unsigned long addr, >> +unsigned int error_code, struct pt_regs *regs) > [snip] >> + /* >> + * If we're

Re: Linux 4.14 - regression: broken tun/tap / bridge network with virtio - bisected

2017-12-07 Thread Andreas Hartmann
On 12/06/2017 at 04:08 AM Jason Wang wrote: > > > On 2017年12月06日 00:23, Andreas Hartmann wrote: >> On 12/05/2017 at 04:50 AM Jason Wang wrote: >>> >>> On 2017年12月05日 00:28, Andreas Hartmann wrote: On 12/03/2017 at 12:35 PM Andreas Hartmann wrote: > On 12/01/2017 at 11:11 AM Andreas

[PATCH] xfrm: fix xfrm_do_migrate() with AEAD e.g(AES-GCM)

2017-12-07 Thread Antony Antony
copy geniv when cloning the xfrm state. x->geniv was not copied to the new state and migration would fail. xfrm_do_migrate .. xfrm_state_clone() .. .. esp_init_aead() crypto_alloc_aead() crypto_alloc_tfm() crypto_find_alg() return EAGAIN and failed Signed-off-by: Antony

Re: [PATCH net-next] net: dsa: lan9303: Protect ALR operations with mutex

2017-12-07 Thread Andrew Lunn
On Thu, Dec 07, 2017 at 07:56:04PM +0100, Egil Hjelmeland wrote: > ALR table operations are a sequence of related register operations which > should be protected from concurrent access. The alr_cache should also be > protected. Add alr_mutex doing that. > > Signed-off-by: Egil Hjelmeland

Re: [PATCH net-next 1/1] net: dsa: microchip: Add Microchip KSZ8895 DSA driver

2017-12-07 Thread Pavel Machek
Hi! > > I went back to my version of dsa patches, and test above works as > > expected. > > Sorry to be this late for the reply. I finally got hold of a KSZ8895 board > that > works with my SoC board to confirm the network communication. > > As expected the KSZ8895 board works correctly as

Re: [PATCH net-next] netdevsim: check return value of debugfs_create_dir

2017-12-07 Thread Jakub Kicinski
On Thu, 7 Dec 2017 17:56:37 +0900, Prashant Bhole wrote: > > From: Jakub Kicinski [mailto:jakub.kicin...@netronome.com] > > > > On Thu, 7 Dec 2017 13:10:39 +0900, Prashant Bhole wrote: > > > > From: Jakub Kicinski [mailto:jakub.kicin...@netronome.com] > > > > > > > > On Thu, 7 Dec 2017

Re: [PATCH 2/3] bluetooth: hci_ll: add constant for vendor-specific command

2017-12-07 Thread David Lechner
On 12/04/2017 12:23 AM, Marcel Holtmann wrote: Hi David, This adds a #define for the vendor-specific HCI command to set the baudrate instead of using the bare 0xff36 multiple times. Signed-off-by: David Lechner --- drivers/bluetooth/hci_ll.c | 10 -- 1 file

Re: [PATCH v5 2/2] sock: Move the socket inuse to namespace.

2017-12-07 Thread Cong Wang
On Thu, Dec 7, 2017 at 9:20 AM, Eric Dumazet wrote: > On Thu, 2017-12-07 at 08:45 -0800, Tonghao Zhang wrote: >> In some case, we want to know how many sockets are in use in >> different _net_ namespaces. It's a key resource metric. >> > > ... > >> +static void

Re: [PATCH v2 33/35] clocksource/drivers/atcpit100: Add andestech atcpit100 timer

2017-12-07 Thread Daniel Lezcano
On 27/11/2017 13:28, Greentime Hu wrote: > From: Rick Chen > > ATCPIT100 is often used on the Andes architecture, > This timer provide 4 PIT channels. Each PIT channel is a > multi-function timer, can be configured as 32,16,8 bit timers > or PWM as well. > > For system

Re: [Bloat] Linux network is damn fast, need more use XDP (Was: DC behaviors today)

2017-12-07 Thread Jesper Dangaard Brouer
(Removed bloat-lists to avoid cross ML-posting) On Mon, 4 Dec 2017 18:19:09 +0100 Matthias Tafelmeier wrote: > Hello, > > Scaling up to more CPUs and TCP-stream, Tariq[1] and I have showed the > > Linux kernel network stack scales to 94Gbit/s (linerate minus

[PATCH net-next 5/6] cxgb4: collect egress and ingress SGE queue contexts

2017-12-07 Thread Rahul Lakkireddy
Use meminfo to identify the egress and ingress context regions and fetch all valid contexts from those regions. Also flush all contexts before attempting collection to prevent stale information. Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar

[PATCH net-next 3/6] cxgb4: collect HMA memory dump

2017-12-07 Thread Rahul Lakkireddy
Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- drivers/net/ethernet/chelsio/cxgb4/cudbg_entity.h | 1 + drivers/net/ethernet/chelsio/cxgb4/cudbg_if.h | 1 + drivers/net/ethernet/chelsio/cxgb4/cudbg_lib.c | 22

[PATCH net-next v2 2/5] net: Disable GRO_HW when generic XDP is installed on a device.

2017-12-07 Thread Michael Chan
Hardware should not aggregate any packets when generic XDP is installed. Cc: Ariel Elior Cc: everest-linux...@cavium.com Signed-off-by: Michael Chan --- net/core/dev.c | 24 1 file changed, 24 insertions(+) diff --git

[PATCH net-next v2 3/5] bnxt_en: Use NETIF_F_GRO_HW.

2017-12-07 Thread Michael Chan
Advertise NETIF_F_GRO_HW in hw_features if hardware GRO is supported. In bnxt_fix_features(), disable GRO_HW and LRO if current hardware configuration does not allow it. XDP setup will now rely on bnxt_fix_features() to turn off aggregation. During chip init, turn on or off hardware GRO based on

[PATCH net-next v2 1/5] net: Introduce NETIF_F_GRO_HW.

2017-12-07 Thread Michael Chan
Introduce NETIF_F_GRO_HW feature flag for NICs that support hardware GRO. With this flag, we can now independently turn on or off hardware GRO when GRO is on. Previously, drivers were using NETIF_F_GRO to control hardware GRO and so it cannot be independently turned on or off without affecting

[PATCH net-next v2 5/5] qede: Use NETIF_F_GRO_HW.

2017-12-07 Thread Michael Chan
Advertise NETIF_F_GRO_HW and set edev->gro_disable according to the feature flag. Add qede_fix_features() to drop NETIF_F_GRO_HW if XDP is running or MTU does not support GRO_HW. qede_change_mtu() also checks and disables GRO_HW if MTU is not supported. Cc: Ariel Elior

  1   2   3   4   >