Re: [PATCH v6 1/6] can: dev: Add support for limiting configured bitrate

Hi Marc, On Tuesday 02 January 2018 06:30 PM, Marc Kleine-Budde wrote: > On 12/22/2017 02:31 PM, Faiz Abbas wrote: >> From: Franklin S Cooper Jr >> >> Various CAN or CAN-FD IP may be able to run at a faster rate than >> what the transceiver the CAN node is connected to. This can

Re: [PATCH] ethernet: mlx4: Delete an error message for a failed memory allocation in five functions

On Wed, Jan 03, 2018 at 01:24:59PM +0200, Tariq Toukan wrote: > > > On 03/01/2018 10:06 AM, Julia Lawall wrote: > > > > > > On Wed, 3 Jan 2018, Tariq Toukan wrote: > > > > > > > > > > > On 01/01/2018 10:46 PM, SF Markus Elfring wrote: > > > > From: Markus Elfring >

Re: [PATCH net-next 3/5] net: dsa: mv88e6xxx: Allow the SERDES interfaces to have statistics

Hi Andrew, Andrew Lunn writes: > When gettting the number of statistics, the strings and the actual getting > statistics, call the SERDES ops if implemented. This means the stats > code needs to return the number of strings/stats they have placed into > the data,

Re: [PATCH net-next 4/5] net: dsa: mv88e6xxx: Add helper to determining if port has SERDES

Hi Andrew, Andrew Lunn writes: > -int mv88e6352_serdes_power(struct mv88e6xxx_chip *chip, int port, bool on) > +static int mv88e6352_port_has_serdes(struct mv88e6xxx_chip *chip, int port) > { > - int err; > u8 cmode; > + int err; > > err =

Re: [PATCH net-next 2/2] l2tp: add peer_offset parameter

> On Tue, Jan 02, 2018 at 08:28:03PM +0100, Lorenzo Bianconi wrote: >> Perhaps I am little bit polarized on UABI issue, but I was rethinking >> about it and maybe removing offset parameter would lead to an >> interoperability issue for device running L2TPv3 since offset >> parameter is there and

[PATCH net-next v2 1/4] phy: add 2.5G SGMII mode to the phy_mode enum

This patch adds one more generic PHY mode to the phy_mode enum, to allow configuring generic PHYs to the 2.5G SGMII mode by using the set_mode callback. Signed-off-by: Antoine Tenart --- include/linux/phy/phy.h | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH net-next v2 4/4] net: mvpp2: 2500baseX support

This patch adds the 2500Base-X PHY mode support in the Marvell PPv2 driver. 2500Base-X is quite close to 1000Base-X and SGMII modes and uses nearly the same code path. Signed-off-by: Antoine Tenart --- drivers/net/ethernet/marvell/mvpp2.c | 40

[PATCHv1 3/6] ARM: dts: imx6q-bx50v3: Add internal switch

B850v3, B650v3 and B450v3 all have a GPIO bit banged MDIO bus to communicate with a Marvell switch. On all devices the switch is connected to a PCI based network card, which needs to be referenced by DT, so this also adds the common PCI root node. Signed-off-by: Sebastian Reichel

[PATCHv1 4/6] ARM: dts: imx6q-b850v3: Add switch port configuration

This adds support for the Marvell switch and names the network ports according to the labels, that can be found next to the connectors ("ID", "IX", "ePort 1", "ePort 2"). The switch is connected to the host system using a PCI based network card. The PCI bus configuration has been written using

[PATCHv1 2/6] net: dsa: mv88e6xxx: add 88E6240 DT compatible

Add compatible for Marvell 88E6240 switch. Signed-off-by: Sebastian Reichel --- Documentation/devicetree/bindings/net/dsa/marvell.txt | 6 -- drivers/net/dsa/mv88e6xxx/chip.c | 4 2 files changed, 8 insertions(+), 2 deletions(-)

[PATCHv1 1/6] net: dsa: Support internal phy on 'cpu' port

This adds support for enabling the internal phy for a 'cpu' port. It has been tested on GE B850v3 and B650v3, which have a built-in MV88E6240 switch connected to a PCIe based network card. Without this patch the link does not come up and no traffic can be routed through the switch. Signed-off-by:

Re: [PATCH] rt2x00: Delete an error message for a failed memory allocation in rt2x00queue_allocate()

On Fri, Dec 29, 2017 at 10:18:14PM +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 29 Dec 2017 22:11:42 +0100 > > Omit an extra message for a memory allocation failure in this function. > > This issue was detected by using the Coccinelle

[PATCH net-next v2 3/4] net: mvpp2: 1000baseX support

This patch adds the 1000Base-X PHY mode support in the Marvell PPv2 driver. 1000Base-X is quite close the SGMII and uses nearly the same code path. Signed-off-by: Antoine Tenart --- drivers/net/ethernet/marvell/mvpp2.c | 45

[PATCH net-next v2 2/4] phy: cp110-comphy: 2.5G SGMII mode

This patch allow the CP100 comphy to configure some lanes in the 2.5G SGMII mode. This mode is quite close to SGMII and uses nearly the same code path. Signed-off-by: Antoine Tenart --- drivers/phy/marvell/phy-mvebu-cp110-comphy.c | 17 ++--- 1

[PATCH net-next v2 0/4] net: mvpp2: 1000BaseX and 2000BaseX support

Hi all, This series adds 1000BaseX and 2500BaseX support to the Marvell PPv2 driver. In order to use it, the 2.5 SGMII mode is added in the Marvell common PHY driver (cp110-comphy). This was tested on a mcbin. All patches should probably go through net-next as patch 4/4 depends on patch 1/4 to

Re: [PATCH v6 1/6] can: dev: Add support for limiting configured bitrate

Hi, On Tuesday 02 January 2018 09:45 PM, Marc Kleine-Budde wrote: > On 12/22/2017 02:31 PM, Faiz Abbas wrote: >> From: Franklin S Cooper Jr >> >> Various CAN or CAN-FD IP may be able to run at a faster rate than >> what the transceiver the CAN node is connected to. This can lead

Re: [PATCH v6 3/6] can: m_can: Add PM Runtime

Hi, On Tuesday 02 January 2018 09:37 PM, Marc Kleine-Budde wrote: > On 12/22/2017 02:31 PM, Faiz Abbas wrote: >> From: Franklin S Cooper Jr >> >> Add support for PM Runtime which is the new way to handle managing clocks. >> However, to avoid breaking SoCs not using PM_RUNTIME

Re: [net-next: PATCH 0/8] Armada 7k/8k PP2 ACPI support

> I already agreed with 'reg' being awkward in the later emails. > Wouldn't _ADR be more appropriate to specify PHY address on MDIO bus? Also, how do you specify which MDIO bus the PHY is on. To fully specify a PHY, you need both bits of information. In DT, the phy-handle phandle can point to

Re: [PATCHv1 1/6] net: dsa: Support internal phy on 'cpu' port

On Wed, Jan 03, 2018 at 01:26:04PM +0100, Sebastian Reichel wrote: > This adds support for enabling the internal phy for a 'cpu' port. > It has been tested on GE B850v3 and B650v3, which have a built-in > MV88E6240 switch connected to a PCIe based network card. Without > this patch the link does

Re: [PATCH net] sctp: fix handling of ICMP Frag Needed for too small MTUs

On Wed, Jan 03, 2018 at 03:31:00PM +0800, Xin Long wrote: > On Wed, Jan 3, 2018 at 5:44 AM, Marcelo Ricardo Leitner > wrote: > > syzbot reported a hang involving SCTP, on which it kept flooding dmesg > > with the message: > > [ 246.742374] sctp:

Re: [net-next: PATCH 0/8] Armada 7k/8k PP2 ACPI support

2018-01-03 14:33 GMT+01:00 Andrew Lunn : > On Wed, Jan 03, 2018 at 02:13:09PM +0100, Marcin Wojtas wrote: >> Hi Andrew, >> >> 2018-01-03 13:47 GMT+01:00 Andrew Lunn : >> >> I already agreed with 'reg' being awkward in the later emails. >> >> Wouldn't _ADR be more

Re: [PATCH net-next v2 1/3] virtio_net: propagate linkspeed/duplex settings from the hypervisor

On Fri, Dec 22, 2017 at 04:54:01PM -0500, Jason Baron wrote: > The ability to set speed and duplex for virtio_net in useful in various > scenarios as described here: > > 16032be virtio_net: add ethtool support for set and get of settings > > However, it would be nice to be able to set this from

Re: [PATCH net-next 2/2] l2tp: add peer_offset parameter

On Tue, Jan 02, 2018 at 08:28:03PM +0100, Lorenzo Bianconi wrote: > Perhaps I am little bit polarized on UABI issue, but I was rethinking > about it and maybe removing offset parameter would lead to an > interoperability issue for device running L2TPv3 since offset > parameter is there and it is

Re: [PATCH v6 3/6] can: m_can: Add PM Runtime

On 01/03/2018 01:39 PM, Faiz Abbas wrote: > On Tuesday 02 January 2018 09:37 PM, Marc Kleine-Budde wrote: >> On 12/22/2017 02:31 PM, Faiz Abbas wrote: >>> From: Franklin S Cooper Jr >>> >>> Add support for PM Runtime which is the new way to handle managing clocks. >>> However, to

Re: [PATCH net-next 1/6] phy: add 2.5G SGMII mode to the phy_mode enum

Hi Florian, On Thu, Dec 28, 2017 at 06:16:51AM -0800, Florian Fainelli wrote: > On 12/28/2017 02:06 AM, Antoine Tenart wrote: > > On Thu, Dec 28, 2017 at 08:20:53AM +0100, Andrew Lunn wrote: > >> On Wed, Dec 27, 2017 at 11:14:41PM +0100, Antoine Tenart wrote: > >>> This patch adds one more

[PATCHv2] 3c59x: fix missing dma_mapping_error check and bad ring refill logic

A few spots in 3c59x missed calls to dma_mapping_error checks, casuing WARN_ONS to trigger. Clean those up. While we're at it, refactor the refill code a bit so that if skb allocation or dma mapping fails, we recycle the existing buffer. This prevents holes in the rx ring, and makes for much

Re: [PATCHv2] 3c59x: fix missing dma_mapping_error check and bad ring refill logic

From: Neil Horman Date: Wed, 3 Jan 2018 09:44:15 -0500 > A few spots in 3c59x missed calls to dma_mapping_error checks, casuing > WARN_ONS to trigger. Clean those up. While we're at it, refactor the > refill code a bit so that if skb allocation or dma mapping fails, we

[PATCH] net: plip: Delete an error message for a failed memory allocation in plip_receive_packet()

From: Markus Elfring Date: Wed, 3 Jan 2018 16:00:23 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

Re: [net-next: PATCH 0/8] Armada 7k/8k PP2 ACPI support

Hi Andrew, 2018-01-03 13:47 GMT+01:00 Andrew Lunn : >> I already agreed with 'reg' being awkward in the later emails. >> Wouldn't _ADR be more appropriate to specify PHY address on MDIO bus? > > Also, how do you specify which MDIO bus the PHY is on. To fully > specify a PHY, you

Re: [PATCH net-next v2 1/3] virtio_net: propagate linkspeed/duplex settings from the hypervisor

On Thu, Dec 28, 2017 at 10:53:54AM -0500, Jason Baron wrote: > > > On 12/27/2017 04:43 PM, David Miller wrote: > > From: Jason Baron > > Date: Fri, 22 Dec 2017 16:54:01 -0500 > > > >> The ability to set speed and duplex for virtio_net in useful in various > >> scenarios as

[PATCH net-next 2/5] net: dsa: mv88e6xxx: Hold mutex while doing stats operations

Until now, there has been no need to hold the reg mutex while getting the count of statistics, or the strings, because the hardware was not accessed. When adding support for SERDES statistics, it is necessary to access the hardware, to determine if a port is using the SERDES interface. So add

Re: [PATCH net-next 1/5] dsa: Pass the port to get_sset_count()

Hi Andrew, Andrew Lunn writes: > --- a/net/dsa/master.c > +++ b/net/dsa/master.c > @@ -42,7 +42,7 @@ static int dsa_master_get_sset_count(struct net_device > *dev, int sset) > count += ops->get_sset_count(dev, sset); > > if (sset == ETH_SS_STATS &&

[PATCH] ps3_gelic_net: Delete an error message for a failed memory allocation in gelic_descr_prepare_rx()

From: Markus Elfring Date: Wed, 3 Jan 2018 14:50:59 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

Re: [PATCH] 3c59x: fix missing dma_mapping_error check

From: Neil Horman Date: Wed, 3 Jan 2018 05:42:04 -0500 > On Tue, Jan 02, 2018 at 09:48:27PM -0500, David Miller wrote: >> And for the RX cases, it allows the RX ring to deplete to empty which >> tends to hang most chips. You need to make the DMA failure detection >> early

Re: [PATCH net-next 2/5] net: dsa: mv88e6xxx: Hold mutex while doing stats operations

On Wed, Jan 03, 2018 at 09:32:42AM -0500, Vivien Didelot wrote: > Hi Andrew, > > Andrew Lunn writes: > > > -static int mv88e6xxx_get_sset_count(struct dsa_switch *ds, int port) > > +static int _mv88e6xxx_get_sset_count(struct dsa_switch *ds, int port) > > { > > struct

Re: [PATCHv1 1/6] net: dsa: Support internal phy on 'cpu' port

Hi Andrew, On Wed, Jan 03, 2018 at 02:21:28PM +0100, Andrew Lunn wrote: > On Wed, Jan 03, 2018 at 01:26:04PM +0100, Sebastian Reichel wrote: > > This adds support for enabling the internal phy for a 'cpu' port. > > It has been tested on GE B850v3 and B650v3, which have a built-in > > MV88E6240

Re: [PATCH v6 3/6] can: m_can: Add PM Runtime

Hi, On Wednesday 03 January 2018 07:55 PM, Marc Kleine-Budde wrote: > On 01/03/2018 01:39 PM, Faiz Abbas wrote: >> On Tuesday 02 January 2018 09:37 PM, Marc Kleine-Budde wrote: >>> On 12/22/2017 02:31 PM, Faiz Abbas wrote: From: Franklin S Cooper Jr Add support for

Re: ethernet: mlx4: Delete an error message for a failed memory allocation in five functions

> I don't really accept this claim... > Short informative strings worth the tiny space they consume. There can be different opinions for their usefulness. > In addition, some out-of-memory errors are recoverable, even though their > backtrace is also printed. How do you think about to

Re: [PATCH v5 02/39] openrisc: add ioremap_nocache declaration before include asm-generic/io.h and sync ioremap prototype with it.

Hello, On Tue, Jan 02, 2018 at 04:24:34PM +0800, Greentime Hu wrote: > From: Greentime Hu > > It will be built failed if commit id: d25ea659 is selected. This patch can > fix this > build error. Ideally you would mention the commit description since the id is not yet

Re: [PATCH net-next 1/6] phy: add 2.5G SGMII mode to the phy_mode enum

> > >>> diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h > > >>> index 4f8423a948d5..70459a28f3a1 100644 > > >>> --- a/include/linux/phy/phy.h > > >>> +++ b/include/linux/phy/phy.h > > >>> @@ -28,6 +28,7 @@ enum phy_mode { > > >>> PHY_MODE_USB_DEVICE, > > >>>

Re: [PATCHv2] 3c59x: fix missing dma_mapping_error check and bad ring refill logic

On Wed, Jan 03, 2018 at 09:58:49AM -0500, David Miller wrote: > From: Neil Horman > Date: Wed, 3 Jan 2018 09:44:15 -0500 > > > A few spots in 3c59x missed calls to dma_mapping_error checks, casuing > > WARN_ONS to trigger. Clean those up. While we're at it, refactor the

Re: [PATCH net-next v2 05/10] net: qualcomm: rmnet: Set pacing rate

On Wed, 2018-01-03 at 15:45 -0700, Subash Abhinov Kasiviswanathan wrote: > > > + sk_pacing_shift_update(skb->sk, 8); > > > > Well... Please tell us why this is needed in this driver. > > > > This interface is meant for wifi aggregation, not to work around some > > strange ethernet drivers

Re: [PATCH] ethernet: mlx4: Delete an error message for a failed memory allocation in five functions

On Wed, 3 Jan 2018, Tariq Toukan wrote: > > > On 01/01/2018 10:46 PM, SF Markus Elfring wrote: > > From: Markus Elfring > > Date: Mon, 1 Jan 2018 21:42:27 +0100 > > > > Omit an extra message for a memory allocation failure in these functions. > > > > This issue

Re: [PATCH v3 bpf-next 10/11] bpf: Add BPF_SOCK_OPS_STATE_CB

We created a new enum to allow different TCP state names between the kernel and BPF sock_ops programs. Since we want to catch changes in the original enum, we are comparing the values of the last entries of the enum types (which is triggering the warning). On 1/1/18, 8:02 PM, "kbuild test

Re: bonding: Delete an error message for a failed memory allocation in bond_update_slave_arr()

>> Omit an extra message for a memory allocation failure in this function. >> >> This issue was detected by using the Coccinelle software. >> > What is the issue with this message? * Is it redundant? * Would a Linux allocation failure report be already sufficient here? Regards, Markus

Re: [PATCH net-next] net: mdio: Only perform gpio reset for PHYs

Hi Andrew, On Tue, Jan 2, 2018 at 5:40 PM, Andrew Lunn wrote: > Ethernet switch on the MDIO bus have historically performed their own > handling of the GPIO reset line. The resent patch to have the MDIO > core handle the reset has broken the switch drivers, in that they > cannot

[PATCH net-next] tg3: Add Macronix NVRAM support

From: Prashant Sreedharan This patch adds the support for Macronix NVRAM Signed-off-by: Prashant Sreedharan Signed-off-by: Satish Baddipadige Reviewed-by: Michael Chan

Re: [PATCH] net: ipv4: emulate READ_ONCE() on ->hdrincl bit-field in raw_sendmsg()

Hi Stefano, Stefano Brivio writes: > On Tue, 2 Jan 2018 17:30:20 +0100 > Nicolai Stange wrote: > >> [...] >> >> diff --git a/net/ipv4/raw.c b/net/ipv4/raw.c >> index 5b9bd5c33d9d..e84290c28c0c 100644 >> --- a/net/ipv4/raw.c >> +++ b/net/ipv4/raw.c >> @@

Re: [patch net-next v4 00/10] net: sched: allow qdiscs to share filter block instances

Wed, Jan 03, 2018 at 03:07:36AM CET, dsah...@gmail.com wrote: >On 1/2/18 12:49 PM, Jiri Pirko wrote: >> DaveA, please consider following example: >> >> $ tc qdisc add dev ens7 ingress >> $ tc qdisc >> qdisc ingress : dev ens7 parent :fff1 block 1 >> >> Now I have one device with one

[bpf-next V4 PATCH 03/14] i40e: setup xdp_rxq_info

The i40e driver has a special "FDIR" RX-ring (I40E_VSI_FDIR) which is a sideband channel for configuring/updating the flow director tables. This (i40e_vsi_)type does not invoke XDP-ebpf code. As suggested by Björn (V2): Instead of marking this I40E_VSI_FDIR RX-ring a special case, reverse the

[bpf-next V4 PATCH 04/14] ixgbe: setup xdp_rxq_info

Driver hook points for xdp_rxq_info: * reg : ixgbe_setup_rx_resources() * unreg: ixgbe_free_rx_resources() Tested on actual hardware. V2: Fix ixgbe_set_ringparam, clear xdp_rxq_info in temp_ring Cc: intel-wired-...@lists.osuosl.org Cc: Jeff Kirsher Cc: Alexander

[bpf-next V4 PATCH 00/14] xdp: new XDP rx-queue info concept

V4: * Added reviewers/acks to patches * Fix patch desc in i40e that got out-of-sync with code * Add SPDX license headers for the two new files added in patch 14 V3: * Fixed bug in virtio_net driver * Removed export of xdp_rxq_info_init() V2: * Changed API exposed to drivers - Removed

[bpf-next V4 PATCH 01/14] xdp: base API for new XDP rx-queue info concept

This patch only introduce the core data structures and API functions. All XDP enabled drivers must use the API before this info can used. There is a need for XDP to know more about the RX-queue a given XDP frames have arrived on. For both the XDP bpf-prog and kernel side. Instead of extending

[bpf-next V4 PATCH 02/14] xdp/mlx5: setup xdp_rxq_info

The mlx5 driver have a special drop-RQ queue (one per interface) that simply drops all incoming traffic. It helps driver keep other HW objects (flow steering) alive upon down/up operations. It is temporarily pointed by flow steering objects during the interface setup, and when interface is down.

[bpf-next V4 PATCH 12/14] xdp: generic XDP handling of xdp_rxq_info

Hook points for xdp_rxq_info: * reg : netif_alloc_rx_queues * unreg: netif_free_rx_queues The net_device have some members (num_rx_queues + real_num_rx_queues) and data-area (dev->_rx with struct netdev_rx_queue's) that were primarily used for exporting information about RPS (CONFIG_RPS)

[bpf-next V4 PATCH 10/14] tun: setup xdp_rxq_info

Driver hook points for xdp_rxq_info: * reg : tun_attach * unreg: __tun_detach I've done some manual testing of this tun driver, but I would appriciate good review and someone else running their use-case tests, as I'm not 100% sure I understand the tfile->detached semantics. V2: Removed the

[bpf-next V4 PATCH 14/14] samples/bpf: program demonstrating access to xdp_rxq_info

This sample program can be used for monitoring and reporting how many packets per sec (pps) are received per NIC RX queue index and which CPU processed the packet. In itself it is a useful tool for quickly identifying RSS imbalance issues, see below. The default XDP action is XDP_PASS in-order to

[bpf-next V4 PATCH 08/14] nfp: setup xdp_rxq_info

Driver hook points for xdp_rxq_info: * reg : nfp_net_rx_ring_alloc * unreg: nfp_net_rx_ring_free In struct nfp_net_rx_ring moved member @size into a hole on 64-bit. Thus, the size remaines the same after adding member @xdp_rxq. Cc: oss-driv...@netronome.com Cc: Jakub Kicinski

[bpf-next V4 PATCH 07/14] bnxt_en: setup xdp_rxq_info

Driver hook points for xdp_rxq_info: * reg : bnxt_alloc_rx_rings * unreg: bnxt_free_rx_rings This driver should be updated to re-register when changing allocation mode of RX rings. Tested on actual hardware. Cc: Andy Gospodarek Cc: Michael Chan

[bpf-next V4 PATCH 09/14] thunderx: setup xdp_rxq_info

This driver uses a bool scheme for "enable"/"disable" when setting up different resources. Thus, the hook points for xdp_rxq_info is done in the same function call nicvf_rcv_queue_config(). This is activated through enable/disable via nicvf_config_data_transfer(), which is tied into

[bpf-next V4 PATCH 05/14] xdp/qede: setup xdp_rxq_info and intro xdp_rxq_info_is_reg

The driver code qede_free_fp_array() depend on kfree() can be called with a NULL pointer. This stems from the qede_alloc_fp_array() function which either (kz)alloc memory for fp->txq or fp->rxq. This also simplifies error handling code in case of memory allocation failures, but xdp_rxq_info_unreg

[bpf-next V4 PATCH 06/14] mlx4: setup xdp_rxq_info

Driver hook points for xdp_rxq_info: * reg : mlx4_en_create_rx_ring * unreg: mlx4_en_destroy_rx_ring Tested on actual hardware. Cc: Tariq Toukan Signed-off-by: Jesper Dangaard Brouer Reviewed-by: Tariq Toukan ---

[bpf-next V4 PATCH 13/14] bpf: finally expose xdp_rxq_info to XDP bpf-programs

Now all XDP driver have been updated to setup xdp_rxq_info and assign this to xdp_buff->rxq. Thus, it is now safe to enable access to some of the xdp_rxq_info struct members. This patch extend xdp_md and expose UAPI to userspace for ingress_ifindex and rx_queue_index. Access happens via bpf

[bpf-next V4 PATCH 11/14] virtio_net: setup xdp_rxq_info

The virtio_net driver doesn't dynamically change the RX-ring queue layout and backing pages, but instead reject XDP setup if all the conditions for XDP is not meet. Thus, the xdp_rxq_info also remains fairly static. This allow us to simply add the reg/unreg to net_device open/close functions.

Re: [PATCH net] sctp: fix error path in sctp_stream_init

On Tue, Jan 02, 2018 at 07:44:37PM -0200, Marcelo Ricardo Leitner wrote: > syzbot noticed a NULL pointer dereference panic in sctp_stream_free() > which was caused by an incomplete error handling in sctp_stream_init(). > By not clearing stream->outcnt, it made a for() in sctp_stream_free() > think

Re: [PATCH] flex_can: Correct the checking for frame length in flexcan_start_xmit()

On 01/02/2018 04:44 AM, Luu An Phu wrote: > From: "phu.luuan" > > The flexcan_start_xmit() function compares the frame length with data register > length to write frame content into data[0] and data[1] register. Data register > length is 4 bytes and frame maximum length is 8

Re: [PATCH] net: ipv4: emulate READ_ONCE() on ->hdrincl bit-field in raw_sendmsg()

Hi Nicolai, On Wed, 03 Jan 2018 10:28:20 +0100 Nicolai Stange wrote: > Hi Stefano, > > Stefano Brivio writes: > > > On Tue, 2 Jan 2018 17:30:20 +0100 > > Nicolai Stange wrote: > > > >> [...] > >> > >> diff --git a/net/ipv4/raw.c

Re: ACPI issues on cold power on [bisected]

On Wed, Jan 03, 2018 at 11:11:29AM +0900, Joonsoo Kim wrote: > On Tue, Jan 02, 2018 at 11:25:01AM +0100, Rafael J. Wysocki wrote: > > On Tue, Jan 2, 2018 at 3:54 AM, Joonsoo Kim wrote: > > > On Fri, Dec 29, 2017 at 04:36:59PM +, Jonathan McDowell wrote: > > >> On Fri,

Re: [PATCH] 3c59x: fix missing dma_mapping_error check

On Tue, Jan 02, 2018 at 09:48:27PM -0500, David Miller wrote: > From: Neil Horman > Date: Fri, 29 Dec 2017 11:40:10 -0500 > > > @@ -2067,6 +2072,9 @@ vortex_start_xmit(struct sk_buff *skb, struct > > net_device *dev) > > int len = (skb->len + 3) & ~3; > >

Re: [net-next: PATCH 0/8] Armada 7k/8k PP2 ACPI support

On Mon, Dec 18, 2017 at 10:40:31AM +0100, Ard Biesheuvel wrote: > On 18 December 2017 at 10:17, Marcin Wojtas wrote: > > Hi, > > > > This patchset introduces ACPI support in mvpp2 and mvmdio drivers. > > First three patches introduce fwnode helpers for obtaining PHY > >

Re: [RFT net-next v3 3/5] net: stmmac: dwmac-meson8b: fix internal RGMII clock configuration

On Sat, 2017-12-30 at 00:40 +0100, Martin Blumenstingl wrote: > > Maybe this bit 10 is indeed a 5/10 divider, as amlogic claims it is. Maybe, > > as > > Emiliano suggested, the output rate of div250 actually needs to be 250Mhz in > > RGMII, before being divided by 10 to produce the 25MHz of div25

Re: [net-next: PATCH 0/8] Armada 7k/8k PP2 ACPI support

Hi Graeme, 2018-01-03 12:00 GMT+01:00 Graeme Gregory : > On Mon, Dec 18, 2017 at 10:40:31AM +0100, Ard Biesheuvel wrote: >> On 18 December 2017 at 10:17, Marcin Wojtas wrote: >> > Hi, >> > >> > This patchset introduces ACPI support in mvpp2 and

Re: [net-next: PATCH v2 5/5] net: mvpp2: enable ACPI support in the driver

On Sun, Dec 31, 2017 at 08:23:54PM +0100, Andrew Lunn wrote: > > * Modify way of obtaining interrupts - with ACPI they are resources > > bound to struct platform_device and it's not possible to obtain > > them directly from the child node. Hence a formula is used, depending > > on the

Re: [net-next: PATCH v2 5/5] net: mvpp2: enable ACPI support in the driver

Graeme, 2018-01-03 12:16 GMT+01:00 : > On Sun, Dec 31, 2017 at 08:23:54PM +0100, Andrew Lunn wrote: >> > * Modify way of obtaining interrupts - with ACPI they are resources >> > bound to struct platform_device and it's not possible to obtain >> > them directly from

Re: [PATCH] ethernet: mlx4: Delete an error message for a failed memory allocation in five functions

On 03/01/2018 10:06 AM, Julia Lawall wrote: On Wed, 3 Jan 2018, Tariq Toukan wrote: On 01/01/2018 10:46 PM, SF Markus Elfring wrote: From: Markus Elfring Date: Mon, 1 Jan 2018 21:42:27 +0100 Omit an extra message for a memory allocation failure in these

Re: [net-next: PATCH v2 1/5] device property: Introduce fwnode_get_mac_address()

On Sunday, December 31, 2017 12:58:36 PM CET Marcin Wojtas wrote: > Until now there were two almost identical functions for > obtaining MAC address - of_get_mac_address() and, more generic, > device_get_mac_address(). However it is not uncommon, > that the network interface is represented as a

Re: ACPI issues on cold power on [bisected]

On Wednesday, January 3, 2018 11:38:12 AM CET Jonathan McDowell wrote: > On Wed, Jan 03, 2018 at 11:11:29AM +0900, Joonsoo Kim wrote: > > On Tue, Jan 02, 2018 at 11:25:01AM +0100, Rafael J. Wysocki wrote: > > > On Tue, Jan 2, 2018 at 3:54 AM, Joonsoo Kim > > > wrote: > >

Re: [net-next: PATCH v2 2/5] device property: Introduce fwnode_get_phy_mode()

On Sunday, December 31, 2017 12:58:37 PM CET Marcin Wojtas wrote: > Until now there were two almost identical functions for > obtaining network PHY mode - of_get_phy_mode() and, > more generic, device_get_phy_mode(). However it is not uncommon, > that the network interface is represented as a

Re: WARNING in sk_stream_kill_queues (2)

#syz dup: KASAN: slab-out-of-bounds Write in tcp_v6_syn_recv_sock

Re: [patch net-next v4 00/10] net: sched: allow qdiscs to share filter block instances

On Wed, 3 Jan 2018 18:22:09 +0100, Jiri Pirko wrote: > However I don't agree about breaking the existing filter add and show > and also imposibility to make not-shared block shared in the runtime > before defining it first. FWIW I would agree with David that allowing add on a shared block modify

Re: KASAN: slab-out-of-bounds Write in tcp_v6_syn_recv_sock

On Wed, Jan 3, 2018 at 12:55 PM, Ozgur wrote: > > > 03.01.2018, 21:57, "Cong Wang" : >> On Tue, Jan 2, 2018 at 3:58 PM, syzbot >> wrote: >>> Hello, >>> >>> syzkaller hit the following crash on

Re: "lockless" qdisc breaks tx_queue_len change too?

On Wed, Jan 3, 2018 at 10:09 AM, John Fastabend wrote: > On 01/02/2018 08:41 PM, Cong Wang wrote: >> Hi, John >> >> While reviewing your ptr_ring fix again today, it looks like your >> "lockless" qdisc patchset breaks dev->tx_queue_len behavior. >> >> Before your

Re: [patch net-next v2 00/10] Add support for resource abstraction

On 01/03/2018 08:29 PM, David Ahern wrote: > On 1/3/18 11:17 AM, Jiri Pirko wrote: >> Wed, Jan 03, 2018 at 07:14:16PM CET, d...@cumulusnetworks.com wrote: >>> On 1/3/18 11:05 AM, Arkadi Sharshevsky wrote: As I stated this is a user-space bug which I fixed, and updated my repo so please

Re: [PATCH net-next 0/2] Enable virtio to act as a master for a passthru device

On 1/3/2018 10:28 AM, Alexander Duyck wrote: On Wed, Jan 3, 2018 at 10:14 AM, Samudrala, Sridhar wrote: On 1/3/2018 8:59 AM, Alexander Duyck wrote: On Tue, Jan 2, 2018 at 6:16 PM, Jakub Kicinski wrote: On Tue, 2 Jan 2018 16:35:36 -0800, Sridhar

Re: [wireless-testsing2:master 1/4] drivers/net/netdevsim/bpf.c:130:14: sparse: incompatible types for 'case' statement

On Thu, 4 Jan 2018 03:53:20 +0800, kbuild test robot wrote: > tree: > https://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-testing.git > master > head: 6b3b30d0c31ddb2f4d8208c90bc2b4adef47204d > commit: af2cae39f6ab9dc596616d6a28c7772e1dd55e91 [1/4] Merge remote-tracking >

Re: [PATCH bpf-next v4 1/3] libbpf: add function to setup XDP

Hello, On Sat, 2017-12-30 at 21:41 +0100, Eric Leblond wrote: > Most of the code is taken from set_link_xdp_fd() in bpf_load.c and > slightly modified to be library compliant. I've just discovered this patch is breaking the build of samples/bpf/ (nlattr not included at least and some int type

[net-next 01/15] i40e: display priority_xon and priority_xoff stats

From: Alice Michael Display some more stats that were already being counted, to help users understand when priority xon/xoff packets are being sent/received Signed-off-by: Alice Michael Tested-by: Andrew Bowers

[net-next 02/15] i40evf: don't rely on netif_running() outside rtnl_lock()

From: Jacob Keller In i40evf_reset_task we use netif_running() to determine whether or not the device is currently up. This allows us to properly free queue memory and shut down things before we request the hardware reset. It turns out that we cannot be guaranteed of

[PATCH] net/mlx5e: hide an unused variable

The uplink_rpriv variable was added at the start of the function but only used inside of an #ifdef: drivers/net/ethernet/mellanox/mlx5/core/en_tc.c: In function 'mlx5e_route_lookup_ipv6': drivers/net/ethernet/mellanox/mlx5/core/en_tc.c:1549:25: error: unused variable 'uplink_rpriv'

[PATCH net-next 3/4] l2tp: remove configurable payload offset

If L2TP_ATTR_OFFSET is set to a non-zero value in L2TPv3 tunnels, it results in L2TPv3 packets being transmitted which might not be compliant with the L2TPv3 RFC. This patch has l2tp ignore the offset setting and send all packets with no offset. In more detail: L2TPv2 supports a variable offset

[PATCH net-next 1/4] l2tp: revert "l2tp: add peer_offset parameter"

Revert commit f15bc54eeecd ("l2tp: add peer_offset parameter"). This is removed because it is adding another configurable offset and configurable offsets are being removed. Signed-off-by: James Chapman --- include/uapi/linux/l2tp.h | 1 - net/l2tp/l2tp_core.c | 3

[PATCH net-next 2/4] l2tp: revert "l2tp: fix missing print session offset info"

Revert commit 820da5357572 ("l2tp: fix missing print session offset info"). The peer_offset parameter is removed. Signed-off-by: James Chapman --- net/l2tp/l2tp_netlink.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/l2tp/l2tp_netlink.c

[PATCH net-next 4/4] l2tp: add comment in API header that L2TP_ATTR_OFFSET is not used

Signed-off-by: James Chapman --- include/uapi/linux/l2tp.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/uapi/linux/l2tp.h b/include/uapi/linux/l2tp.h index d84ce5c..f78eef4 100644 --- a/include/uapi/linux/l2tp.h +++ b/include/uapi/linux/l2tp.h

Re: [PATCH] net/mlx5e: hide an unused variable

On 1/3/2018 2:40 PM, Arnd Bergmann wrote: The uplink_rpriv variable was added at the start of the function but only used inside of an #ifdef: drivers/net/ethernet/mellanox/mlx5/core/en_tc.c: In function 'mlx5e_route_lookup_ipv6': drivers/net/ethernet/mellanox/mlx5/core/en_tc.c:1549:25:

Re: [PATCH 0/2] Kill redundant checks in the Renesas Ethernet drivers

From: Sergei Shtylyov Date: Sun, 31 Dec 2017 21:41:34 +0300 > Here's a set of 2 patches against DaveM's 'net-next.git' repo removing > redundant checks in the driver probe() methods. Series applied with the "disassembly" typo fixed.

Re: [PATCHv1 3/6] ARM: dts: imx6q-bx50v3: Add internal switch

Hi, On Wed, Jan 03, 2018 at 05:48:42PM +0300, Sergei Shtylyov wrote: > Hello! > > On 01/03/2018 03:26 PM, Sebastian Reichel wrote: > > > B850v3, B650v3 and B450v3 all have a GPIO bit banged MDIO bus to > > communicate with a Marvell switch. On all devices the switch is > > connected to a PCI

Re: [PATCHv2] 3c59x: fix missing dma_mapping_error check and bad ring refill logic

From: David Miller Date: Wed, 03 Jan 2018 10:26:06 -0500 (EST) > From: Neil Horman > Date: Wed, 3 Jan 2018 10:13:33 -0500 > >> Thats exactly what this patch does, instead of creating a second loop to >> traverse all the emptied ring buffers, now I: >>

Re: [PATCH net-next 2/5] net: dsa: mv88e6xxx: Hold mutex while doing stats operations

Hi Andrew, Andrew Lunn writes: > On Wed, Jan 03, 2018 at 09:32:42AM -0500, Vivien Didelot wrote: >> Hi Andrew, >> >> Andrew Lunn writes: >> >> > -static int mv88e6xxx_get_sset_count(struct dsa_switch *ds, int port) >> > +static int

Re: [patch net-next v4 00/10] net: sched: allow qdiscs to share filter block instances

On 1/3/18 2:40 AM, Jiri Pirko wrote: > Wed, Jan 03, 2018 at 03:07:36AM CET, dsah...@gmail.com wrote: >> On 1/2/18 12:49 PM, Jiri Pirko wrote: >>> DaveA, please consider following example: >>> >>> $ tc qdisc add dev ens7 ingress >>> $ tc qdisc >>> qdisc ingress : dev ens7 parent :fff1 block

Re: [PATCH net-next] cxgb4: collect TX rate limit info in UP CIM logs

From: Rahul Lakkireddy Date: Tue, 2 Jan 2018 12:48:58 +0530 > Collect TX rate limiting related information in UP CIM logs. > > Signed-off-by: Rahul Lakkireddy > Signed-off-by: Ganesh Goudar Applied, thanks.

  1   2   3   4   >