[PATCH] can: m_can: mark runtime-PM handlers as __maybe_unused

Building without CONFIG_PM results in a harmless warning: drivers/net/can/m_can/m_can.c:1763:12: error: 'm_can_runtime_resume' defined but not used [-Werror=unused-function] drivers/net/can/m_can/m_can.c:1752:12: error: 'm_can_runtime_suspend' defined but not used [-Werror=unused-function]

Re: [net-next: PATCH v4 0/7] Armada 7k/8k PP2 ACPI support

Hi Marcin, I tested the series on a MacchiatoBin to ensure the mvpp2 DT support was still working. I was able to use all supported ports as before, and saw no issue. For all mvpp2 patches, you can add: Tested-by: Antoine Tenart Thanks! Antoine On Thu, Jan

Re: [RFC v2 net-next 06/10] net/sched: Introduce the TBS Qdisc

One more comment: Probably try to run a test with a very small delta with no offload (probably using something like prio as the root qdisc) and dump the stats. My gut feeling is your accounting of the backlog in particular is off. cheers, jamal On 18-01-18 08:35 AM, Jamal Hadi Salim wrote: On

Re: [PATCH] [net-next] net: sched: avoid uninitialized variable use

Thu, Jan 18, 2018 at 03:19:14PM CET, a...@arndb.de wrote: >On Thu, Jan 18, 2018 at 2:49 PM, Jiri Pirko wrote: >> Thu, Jan 18, 2018 at 02:17:28PM CET, a...@arndb.de wrote: >>>gcc has identified a code path in which we pass uninitialized >>>data into tc_dump_tfilter(): >>>

Re: [net-next: PATCH 0/8] Armada 7k/8k PP2 ACPI support

> I CC'ed Mika since he is more familiar with handling these bits of ACPI > specs - I wonder whether this is a problem that cropped up on x86 > systems too. Hi Lorenzo There is nothing about MDIO, PHYs, Ethernet switches, etc in version 6.2 of the spec. If x86 has this, it must be after 6.2 was

Re: [PATCH] [wireless-next] mt76: fix building without CONFIG_LEDS_CLASS

Arnd Bergmann writes: > When CONFIG_LEDS_CLASS is disabled, or it is a loadable module while > mt76 is built-in, we run into a link error: > > drivers/net/wireless/mediatek/mt76/mac80211.o: In function > `mt76_register_device': > mac80211.c:(.text+0xb78): relocation truncated to

Re: [PATCH] [net-next] net: sched: avoid uninitialized variable use

Thu, Jan 18, 2018 at 02:17:28PM CET, a...@arndb.de wrote: >gcc has identified a code path in which we pass uninitialized >data into tc_dump_tfilter(): > >net/sched/cls_api.c: In function 'tc_dump_tfilter': >net/sched/cls_api.c:1268:8: error: 'parent' may be used uninitialized in this >function

[PATCH iproute2 v2 5/9] ip/tunnel: Abstract tunnel encapsulation options printing

Get rid of code duplications and consolidate encapsulation options printing in single function - tnl_print_encap(). Introduce and use tnl_encap_str() to format encapsulation option string according to tempate and given values to avoid code duplication and simplify it. Use print_string() instead

[PATCH iproute2 v2 9/9] tunnel: Return constant string without copying it

We return constant string from tnl_strproto(), no need to copy it to temporary buffer and then return such buffer as const: return constant string instead. Signed-off-by: Serhey Popovych --- ip/tunnel.c | 25 +++-- 1 file changed, 7 insertions(+),

Re: [PATCHv2 net-next 0/8] net: sched: cls: add extack support

On 18-01-17 05:40 PM, Alexander Aring wrote: Hi, this patch adds extack support for TC classifier subsystem. The first patch fixes some code style issues for this patch series pointed out by checkpatch. The other patches until the last one prepares extack handling for the TC classifier

[PATCH] wcn36xx: release resources in case of error

wcn36xx_dxe_init() doesn't check for the return value of wcn36xx_dxe_init_descs(). This patch releases the resources in case an error ocurred. Signed-off-by: Ramon Fried --- drivers/net/wireless/ath/wcn36xx/dxe.c | 48 +- 1 file changed, 42

Re: [PATCH net-next v5 0/4] net: mvpp2: 1000BaseX and 2500BaseX support

Hi Russell, On Tue, Jan 16, 2018 at 03:12:45PM +, Russell King - ARM Linux wrote: > > As I've already said, we need to make sure things are done in a similar > way for all netdev DT drivers that are hoping to switch to phylink. > The mvneta patches are now in net-next for this. > > What I

Re: net: r8169: a question of memory barrier in the r8169 driver

On Thu, Jan 18, 2018 at 10:06:17PM +0800, Jia-Ju Bai wrote: > In the rt8169 driver, the function "rtl_tx" uses "smp_mb" to sync the > writing operation with rtl8169_start_xmit: > if (tp->dirty_tx != dirty_tx) { > tp->dirty_tx = dirty_tx; > smp_mb(); > ... > } > The

Re: [PATCHv2 net-next 7/8] net: sched: cls: add extack support for tc_setup_cb_call

Hi, On Wed, Jan 17, 2018 at 8:25 PM, Jakub Kicinski wrote: > On Wed, 17 Jan 2018 17:40:26 -0500, Alexander Aring wrote: >> diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c >> index 9f88107c29c5..e864ad523800 100644 >> --- a/net/sched/cls_api.c >> +++ b/net/sched/cls_api.c

Re: [PATCHv2 net-next 8/8] net: sched: cls_u32: add extack support

Hi, On Wed, Jan 17, 2018 at 8:27 PM, Jakub Kicinski wrote: > On Wed, 17 Jan 2018 17:40:27 -0500, Alexander Aring wrote: >> diff --git a/net/sched/cls_u32.c b/net/sched/cls_u32.c >> index 8840baa1b9b4..daeac7282387 100644 >> --- a/net/sched/cls_u32.c >> +++ b/net/sched/cls_u32.c

[net-next: PATCH v4 7/7] net: mvpp2: enable ACPI support in the driver

This patch introduces an alternative way of obtaining resources - via ACPI tables provided by firmware. Enabling coexistence with the DT support, in addition to the OF_*->device_*/fwnode_* API replacement, required following steps to be taken: * Add mvpp2_acpi_match table * Omit clock

[net-next: PATCH v4 0/7] Armada 7k/8k PP2 ACPI support

Hi, I quickly resend the series, thanks to Antoine Tenart's remark, who spotted !CONFIG_ACPI compilation issue after introducing the new fwnode_irq_get() routine. Please see the details in the changelog below and the 3/7 commit log. mvpp2 driver can work with the ACPI representation, as exposed

[net-next: PATCH v4 3/7] device property: Introduce fwnode_irq_get()

Until now there were two very similar functions allowing to get Linux IRQ number from ACPI handle (acpi_irq_get()) and OF node (of_irq_get()). The first one appeared to be used only as a subroutine of platform_irq_get(), which (in the generic code) limited IRQ obtaining from _CRS method only to

[net-next: PATCH v4 5/7] net: mvpp2: simplify maintaining enabled ports' list

'port_count' field of the mvpp2 structure holds an overall amount of available ports, based on DT nodes status. In order to be prepared to support other HW description, obtain the value by incrementing it upon each successful port initialization. This allowed for simplifying port indexing in the

Re: dangers of bots on the mailing lists was Re: divide error in ___bpf_prog_run

On Thu, Jan 18, 2018 at 2:01 PM, Dmitry Vyukov wrote: > On Thu, Jan 18, 2018 at 2:09 AM, Theodore Ts'o wrote: >> On Wed, Jan 17, 2018 at 04:21:13PM -0800, Alexei Starovoitov wrote: >>> >>> If syzkaller can only test one tree than linux-next should be the one.

Re: [PATCH v2 00/19] prevent bounds-check bypass via speculative execution

Hi Dan, Linus, On Thu, Jan 11, 2018 at 05:41:08PM -0800, Dan Williams wrote: > On Thu, Jan 11, 2018 at 5:19 PM, Linus Torvalds > wrote: > > On Thu, Jan 11, 2018 at 4:46 PM, Dan Williams > > wrote: > >> > >> This series incorporates Mark

Re: [PATCH iproute2] tunnel: Return constant string without copying it

Serhey Popovych wrote: > We return constant string from tnl_strproto(), no need > to copy it to temporary buffer and then return such > buffer as const: return constant string instead. > > Signed-off-by: Serhey Popovych This change should be ignored: now it is a part

[PATCH xfrm v1] xfrm: fix error flow in case of add state fails

If add state fails in case of device offload, netdev refcount will be negative since gc task is attempting to dev_free this state. This is fixed by putting NULL in state dev field. Signed-off-by: Aviad Yehezkel Signed-off-by: Boris Pismeny ---

Re: dangers of bots on the mailing lists was Re: divide error in ___bpf_prog_run

On Thu, 18 Jan 2018, Dmitry Vyukov wrote: > I've made a bunch of changes yesterday and today. This includes ... > and even per crash/tree. To alleviate this, syzbot will now say e.g. > "So far this crash happened 185 times on linux-next, mmots, net-next, > upstream". So that you can see that

Re: [PATCH 3/4] tsi108_eth: use dma API properly

From: Bjorn Helgaas Date: Wed, 17 Jan 2018 18:08:18 -0600 > [+cc David, FYI, I plan to merge this via PCI along with the rest of > Christoph's series] No problem.

[PATCH iproute2] iplink: Fix "alias" parameter length calculations

We need NEXT_ARG() to get *argv pointing to "alias" parameter value. Overwise we get and check "alias" string length. Fixes: f88becf35e08 ("iplink: Process "alias" parameter correctly") Signed-off-by: Serhey Popovych --- ip/iplink.c |2 +- 1 file changed, 1

Re: [PATCH net-next 3/5] net: hns3: add ethtool -p support for phy device

> +static int hclge_set_led_status_phy(struct phy_device *phydev, int value) > +{ > + int ret, cur_page; > + > + mutex_lock(>lock); > + > + ret = phy_read(phydev, HCLGE_PHY_PAGE_REG); > + if (ret < 0) > + goto out; > + else > + cur_page = ret; > + > +

Re: [PATCH net-next] kcm: do not attach sockets if sk_user_data is already used

On Wed, Jan 17, 2018 at 02:25:38PM -0500, David Miller wrote: > From: James Chapman > Date: Wed, 17 Jan 2018 11:13:33 + > > > On 16 January 2018 at 19:00, David Miller wrote: > >> From: Tom Herbert > >> Date: Tue, 16 Jan 2018

Re: [patch net-next v2] net: sched: silence uninitialized parent variable warning in tc_dump_tfilter

From: Jiri Pirko Date: Thu, 18 Jan 2018 16:14:49 +0100 > @@ -1317,6 +1317,13 @@ static int tc_dump_tfilter(struct sk_buff *skb, struct > netlink_callback *cb) > block = tcf_block_lookup(net, tcm->tcm_block_index); > if (!block) >

[net-next: PATCH v4 6/7] net: mvpp2: use device_*/fwnode_* APIs instead of of_*

OF functions can be used only for the driver using DT. As a preparation for introducing ACPI support in mvpp2 driver, use struct fwnode_handle in order to obtain properties from the hardware description. This patch replaces of_* function with device_*/fwnode_* where possible in the mvpp2.

[PATCH] [net-next] net: sched: avoid uninitialized variable use

gcc has identified a code path in which we pass uninitialized data into tc_dump_tfilter(): net/sched/cls_api.c: In function 'tc_dump_tfilter': net/sched/cls_api.c:1268:8: error: 'parent' may be used uninitialized in this function [-Werror=maybe-uninitialized] This initializes the variable to

Re: [PATCH v2] FIRMWARE: bcm47xx_nvram: Replace mac address parsing

On Thu, 2017-12-21 at 17:42 +0100, Hauke Mehrtens wrote: > > On 12/21/2017 03:40 PM, Andy Shevchenko wrote: > > Replace sscanf() with mac_pton(). > > > > Signed-off-by: Andy Shevchenko > > Acked-by: Hauke Mehrtens > > The patch looks good,

[PATCH iproute2 v2 3/9] ip/tunnel: Simplify and unify tos printing

For ip tunnels tos can be 0 when not configured, 1 when inherited from encapsulated packet and rest specifying diffserv (rfc2474) or tos (rfc1349) bits. It is stored in packet tos/diffserv field and returned in tos netlink attribute to userspace. Simplify and unify tos printing by using

[PATCH iproute2 v2 2/9] ip/tunnel: Correct and unify ttl/hoplimit printing

Both ttl/hoplimit is from 1 to 255. Zero has special meaning: use encapsulated packet value. In ip-link(8) -d output this looks like "ttl/hoplimit inherit". In JSON we have "int" type for ttl and therefore values from 0 (inherit) to 255. To do the best in handling ttl/hoplimit we need to accept

[PATCH iproute2 v2 4/9] ip/tunnel: Use print_0xhex() instead of print_string()

No need for custom SPRINT_BUF() and snprintf() 0x%x value to this buffer: we can use print_0xhex() instead of print_string(). In link_iptnl.c use s2 instead of s1 buffer and remove s1. While there adjust fwmark option print order in iptnl and ip6tnl to get it match each other. Signed-off-by:

[PATCH iproute2 v2 1/9] iplink: Use ll_index_to_name() instead of if_indextoname()

There are two reasons for switching to cached variant: 1) ll_index_to_name() may return result from cache, eliminating expensive ioctl() to the kernel. Note that most of the code already switched from plain if_indextoname() to ll_index_to_name() to cached variant in print

net: r8169: a question of memory barrier in the r8169 driver

In the rt8169 driver, the function "rtl_tx" uses "smp_mb" to sync the writing operation with rtl8169_start_xmit: if (tp->dirty_tx != dirty_tx) { tp->dirty_tx = dirty_tx; smp_mb(); ... } The function rtl8169_start_xmit reads tp->dirty_tx in TX_FRAGS_READY_FOR:

[PATCH iproute2 v2 6/9] gre/tunnel: Print erspan_index using print_uint()

One is missing in JSON output because fprintf() is used instead of print_uint(). Signed-off-by: Serhey Popovych --- ip/link_gre.c |3 ++- ip/link_gre6.c |4 +++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/ip/link_gre.c b/ip/link_gre.c index

Re: [PATCH v2] r8152: disable RX aggregation on Dell TB16 dock

From: Hayes Wang Date: Thu, 18 Jan 2018 03:04:08 + > [...] >> > r8153 on Dell TB15/16 dock corrupts rx packets. >> > >> > This change is suggested by Realtek. They guess that the XHCI >> > controller doesn't have enough buffer, and their guesswork is correct, >> > once

[patch net-next v2] net: sched: silence uninitialized parent variable warning in tc_dump_tfilter

From: Jiri Pirko When tcm->tcm_ifindex == TCM_IFINDEX_MAGIC_BLOCK, parent is still passed down but the value is never used. Compiler does not recognize it and issues a warning. Silence it down initializing parent to 0. Fixes: 7960d1daf278 ("net: sched: use block index as a

[nf-next] netfilter: Add support for inner IPv6 packet match

As described in the SRv6 network programming document [1], the SRv6 information can be added to a packet in two different modes, insert or encap. As shown below, you can see the original IPv6 packet and how it is carried in the two different encapsulation modes. In the insert mode the SRH header

Re: iscsi target regression due to "tcp: remove prequeue support" patch

Nicholas A. Bellinger wrote: > On Mon, 2018-01-15 at 11:41 +0100, Florian Westphal wrote: > > Mike Christie wrote: > > > > > Dec 13 17:55:01 rhel73n1 kernel: Got Login Command, Flags 0x81, ITT: > > > 0x, CmdSN: 0x, ExpStatSN:

[iptables] extensions: add support for inner IPv6 packet 'inner6' match

This patch adds a new exetension to iptables to inner IPv6 packet 'inner6' match. Signed-off-by: Ahmed Abdelsalam --- extensions/libip6t_inner6.c| 111 + extensions/libip6t_inner6.t| 4 ++

Re: [PATCH 1/3 net] ibmvnic: Modify buffer size on failover

Hi John, I love your patch! Yet something to improve: [auto build test ERROR on net/master] url: https://github.com/0day-ci/linux/commits/John-Allen/ibmvnic-Modify-buffer-size-on-failover/20180118-190528 config: powerpc-allyesconfig (attached as .config) compiler: powerpc64-linux-gnu-gcc

[net-next: PATCH v4 2/7] device property: Introduce fwnode_get_phy_mode()

Until now there were two almost identical functions for obtaining network PHY mode - of_get_phy_mode() and, more generic, device_get_phy_mode(). However it is not uncommon, that the network interface is represented as a child of the actual controller, hence it is not associated directly to any

[net-next: PATCH v4 1/7] device property: Introduce fwnode_get_mac_address()

Until now there were two almost identical functions for obtaining MAC address - of_get_mac_address() and, more generic, device_get_mac_address(). However it is not uncommon, that the network interface is represented as a child of the actual controller, hence it is not associated directly to any

Re: [net-next: PATCH 0/8] Armada 7k/8k PP2 ACPI support

[+cc Mika] On Tue, Jan 09, 2018 at 02:00:12PM +0100, Andrew Lunn wrote: > On Tue, Jan 09, 2018 at 11:22:00AM +0100, Marcin Wojtas wrote: > > 2018-01-09 11:19 GMT+01:00 Graeme Gregory : > > > On Mon, Jan 08, 2018 at 06:17:06PM +0100, Marcin Wojtas wrote: > > >> Hi

[net-next: PATCH v4 4/7] device property: Allow iterating over available child fwnodes

Implement a new helper function fwnode_get_next_available_child_node(), which enables obtaining next enabled child fwnode, which works on a similar basis to OF's of_get_next_available_child(). This commit also introduces a macro, thanks to which it is possible to iterate over the available

Re: [RFC PATCH net-next 00/12] selftests: forwarding: Add VRF-based tests

> > > >> > > > >> br0 > > > >> + > > > >>vrf-h1 | vrf-h2 > > > >> ++---+++ > > > >> |||| > > > >> 192.0.2.1/24 ++

Re: dangers of bots on the mailing lists was Re: divide error in ___bpf_prog_run

On Wed, Jan 17, 2018 at 12:09 PM, Dmitry Vyukov wrote: > On Wed, Jan 17, 2018 at 10:49 AM, Daniel Borkmann > wrote: >> Don't know if there's such a possibility, but it would be nice if we could >> target fuzzing for specific subsystems in related

Re: dangers of bots on the mailing lists was Re: divide error in ___bpf_prog_run

On Thu, Jan 18, 2018 at 5:01 AM, Dmitry Vyukov wrote: > On Thu, Jan 18, 2018 at 2:09 AM, Theodore Ts'o wrote: >> On Wed, Jan 17, 2018 at 04:21:13PM -0800, Alexei Starovoitov wrote: >>> >>> If syzkaller can only test one tree than linux-next should be the one.

Re: [PATCH] [net-next] net: sched: avoid uninitialized variable use

On Thu, Jan 18, 2018 at 2:49 PM, Jiri Pirko wrote: > Thu, Jan 18, 2018 at 02:17:28PM CET, a...@arndb.de wrote: >>gcc has identified a code path in which we pass uninitialized >>data into tc_dump_tfilter(): >> >>net/sched/cls_api.c: In function 'tc_dump_tfilter':

[patch net] mlxsw: spectrum_router: Free LPM tree upon failure

From: Ido Schimmel When a new LPM tree is created, we try to replace the trees in the existing virtual routers with it. If we fail, the tree needs to be freed. Currently, this does not happen in the unlikely case where we fail to bind the tree to the first virtual router,

Re: [PATCH 0/3] Check gso_size of packets when forwarding

Daniel Axtens writes: > Jason Wang writes: > >> On 2018年01月18日 16:28, Pravin Shelar wrote: >>> On Mon, Jan 15, 2018 at 6:09 PM, Daniel Axtens wrote: When regular packets are forwarded, we validate their size against the MTU of

[PATCH iproute2 v2 0/9] ip/tunnel: Improve tunnel parameters printing

Continue improvements to tunnel modules. Final goal is to make merge IP and IPv6 variants and make that transition as transparent as possible. Everything within this series is open for your comments, suggestions and criticism. See individual patch description message for details. v2 1) Fix

[PATCH iproute2 v2 7/9] vti/tunnel: Unify ikey/okey printing

For vti6 tunnel we print [io]key in dotted-quad notation (ipv4 address) while in vti we do that in hex format. For vti tunnel we print [io]key only if value is not zero while for vti6 we miss such check. Unify vti and vti6 tunnel [io]key output. While here enlarge s2 buffer to the same size as

Re: dangers of bots on the mailing lists was Re: divide error in ___bpf_prog_run

On Thu, Jan 18, 2018 at 02:01:28PM +0100, Dmitry Vyukov wrote: > On Thu, Jan 18, 2018 at 2:09 AM, Theodore Ts'o wrote: > > On Wed, Jan 17, 2018 at 04:21:13PM -0800, Alexei Starovoitov wrote: > >> > >> If syzkaller can only test one tree than linux-next should be the one. > > > >

[PATCH iproute2 v2 8/9] vti6/tunnel: Unify and simplify link type help functions

Both of these two changes are missing for link_vti6.c: commit 8b47135474cd ("ip: link: Unify link type help functions a bit") commit 561e650eff67 ("ip link: Shortify printing the usage of link type") Replay them on link_vti6.c to bring link type help functions inline with other tunneling

Re: pull-request: bpf 2018-01-18

From: Daniel Borkmann Date: Thu, 18 Jan 2018 02:16:03 +0100 > The following pull-request contains BPF updates for your *net* tree. > > The main changes are: > > 1) Fix a divide by zero due to wrong if (src_reg == 0) check in >64-bit mode. Properly handle this in

[PATCH] wcn36xx: release resources in case of error

wcn36xx_dxe_init() doesn't check for the return value of wcn36xx_dxe_init_descs(). This patch releases the resources in case an error ocurred. Signed-off-by: Ramon Fried --- drivers/net/wireless/ath/wcn36xx/dxe.c | 48 +- 1 file changed, 42

[PATCH] wcn36xx: release resources in case of error

wcn36xx_dxe_init() doesn't check for the return value of wcn36xx_dxe_init_descs(). This patch releases the resources in case an error ocurred. Signed-off-by: Ramon Fried --- drivers/net/wireless/ath/wcn36xx/dxe.c | 48 +- 1 file changed, 42

Re: aio poll, io_pgetevents and a new in-kernel poll API V3

FYI, this kernel has issues. It will boot up, but I don't have networking, and even rebooting doesn't succeed. I'm looking into it. -Jeff Christoph Hellwig writes: > Hi all, > > this series adds support for the IOCB_CMD_POLL operation to poll for the > readyness of file

Re: [net-next: PATCH v3 0/7] Armada 7k/8k PP2 ACPI support

On Wed, Jan 17, 2018 at 05:55:39PM +0100, Marcin Wojtas wrote: > Hi, > > This is a third version of the patchset introducing mvpp2 driver ability > to operate with ACPI. Until follow-up generic MDIO is introduced > it can using the link interrupt capability (a.k.a. in-band management) > on all

Re: [PATCH net-next] kcm: do not attach sockets if sk_user_data is already used

On 18 January 2018 at 15:18, Guillaume Nault wrote: > On Wed, Jan 17, 2018 at 02:25:38PM -0500, David Miller wrote: >> From: James Chapman >> Date: Wed, 17 Jan 2018 11:13:33 + >> >> > On 16 January 2018 at 19:00, David Miller

Re: [PATCH net] netlink: reset extack earlier in netlink_rcv_skb

On 1/17/18 10:48 PM, Xin Long wrote: > Move up the extack reset/initialization in netlink_rcv_skb, so that > those 'goto ack' will not skip it. Otherwise, later on netlink_ack > may use the uninitialized extack and cause kernel crash. > > Fixes: cbbdf8433a5f ("netlink: extack needs to be reset

Re: [PATCH next-queue 2/2] ixgbe: add unlikely notes to tx fastpath expressions

On 1/18/2018 1:06 AM, Yanjun Zhu wrote: On 2018/1/9 6:47, Shannon Nelson wrote: Add unlikely() to a few error checking expressions in the Tx offload handling. Suggested-by: Yanjun Zhu Hi, I am fine with this patch. I have a question. The ipsec feature is supported in

Re: [RFC v2 net-next 01/10] net: Add a new socket option for a future transmit time.

On Wed, Jan 17, 2018 at 03:06:12PM -0800, Jesus Sanchez-Palencia wrote: > @@ -2130,6 +2137,15 @@ int __sock_cmsg_send(struct sock *sk, struct msghdr > *msg, struct cmsghdr *cmsg, > sockc->tsflags &= ~SOF_TIMESTAMPING_TX_RECORD_MASK; > sockc->tsflags |= tsflags; >

Re: [RFC][PATCH] get rid of the use of set_fs() (by way of kernel_recvmsg()) in sunrpc

On Thu, Jan 18, 2018 at 08:29:57AM -0800, Christoph Hellwig wrote: > > We could turn ->msg_control/->msg_controllen into another > > iov_iter, but seeing that we never do scatter-gather for those > > IMO that would be a massive overkill. A flag controlling whether > > ->msg_control is kernel

Re: [Intel-wired-lan] [RFC v2 net-next 01/10] net: Add a new socket option for a future transmit time.

On Thu, Jan 18, 2018 at 09:42:27AM +0100, Miroslav Lichvar wrote: > In the discussion about the v1 patchset, there was a question if the > cmsg should include a clockid_t. Without that, how can an application > prevent the packet from being sent using an incorrect clock, e.g. > the system clock

Re: [RFC v2 net-next 06/10] net/sched: Introduce the TBS Qdisc

On Thu, Jan 18, 2018 at 08:35:18AM -0500, Jamal Hadi Salim wrote: > 1) iproute2: Avoid magic numbers like 1 or 11 please; "offload" > (without 1) and "TAI" will be more human friendly. Yes, and for the clockid, the program should accept CLOCK_REALTIME or CLOCK_TAI for the hard coded SYS-V IDs or

Re: [PATCH xfrm v1] xfrm: fix error flow in case of add state fails

On 1/18/2018 5:41 AM, Aviad Yehezkel wrote: If add state fails in case of device offload, netdev refcount will be negative since gc task is attempting to dev_free this state. This is fixed by putting NULL in state dev field. Signed-off-by: Aviad Yehezkel Signed-off-by:

[PATCH v2] net: ethernet: cavium: Correct Cavium Thunderx nicvf/nicpf modules names

From: Vadim Lomovtsev It was found that ethtool provides unexisting module name while it queries the specified network device for associated driver information. This patch is to correct Cavium CN88xx Thunder nicvf/nicpf modules names 'nicvf' to 'thunder_nicvf' and

[PATCH v2 net-next 1/2] net: dsa: mv88e6xxx: Return error from irq_find_mapping()

Fix a cut/paste error. When irq_find_mapping() returns an error for the ATU or VTU interrupt, return that error, not the value of chip->device_irq. Signed-off-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx/global1_atu.c | 2 +- drivers/net/dsa/mv88e6xxx/global1_vtu.c | 2 +- 2

Re: aio poll, io_pgetevents and a new in-kernel poll API V3

Jeff Moyer writes: > FYI, this kernel has issues. It will boot up, but I don't have > networking, and even rebooting doesn't succeed. I'm looking into it. A bisect lands on: eventfd: switch to ->poll_mask. That's not super helpful, though. I did run the ltp eventfd2

Re: [PATCH RFC net-next 1/6] sock: MSG_PEEK support for sk_error_queue

On Thu, 2018-01-18 at 11:10 -0500, Sowmini Varadhan wrote: > On (01/18/18 07:54), Eric Dumazet wrote: > > > > Some applications out there would break horribly, trust me. > > > > so I'm not particularly attached to that solution, and I appreciate > the wisdom (and the NACK), but lets try to find

Re: [PATCH net-next] kcm: do not attach sockets if sk_user_data is already used

On 18 January 2018 at 16:29, Guillaume Nault wrote: > On Thu, Jan 18, 2018 at 03:40:52PM +, James Chapman wrote: >> On 18 January 2018 at 15:18, Guillaume Nault wrote: >> > On Wed, Jan 17, 2018 at 02:25:38PM -0500, David Miller wrote: >> >> If all

Re: aio poll, io_pgetevents and a new in-kernel poll API V3

On Thu, Jan 18, 2018 at 11:44:03AM -0500, Jeff Moyer wrote: > Jeff Moyer writes: > > > FYI, this kernel has issues. It will boot up, but I don't have > > networking, and even rebooting doesn't succeed. I'm looking into it. > > A bisect lands on: eventfd: switch to

[PATCH net v2] ip6_gre: init dev->mtu and dev->hard_header_len correctly

Commit b05229f44228 ("gre6: Cleanup GREv6 transmit path, call common GRE functions") moved dev->mtu initialization from ip6gre_tunnel_setup() to ip6gre_tunnel_init(), as a result, the previously set values, before ndo_init(), are reset in the following cases: * rtnl_create_link() can update

[PATCH] net: ethernet: cavium: Correct Cacivum Thunderx nicvf/nicpf modules names

From: Vadim Lomovtsev It was found that ethtool provides unexisting module name while it queries the specified network device for associated driver information. This patch is to correct Cavium CN88xx Thunder nicvf/nicpf modules names 'nicvf' to 'thunder_nicvf' and

Re: [patch net-next v2] net: sched: silence uninitialized parent variable warning in tc_dump_tfilter

Thu, Jan 18, 2018 at 04:36:58PM CET, da...@davemloft.net wrote: >From: Jiri Pirko >Date: Thu, 18 Jan 2018 16:14:49 +0100 > >> @@ -1317,6 +1317,13 @@ static int tc_dump_tfilter(struct sk_buff *skb, >> struct netlink_callback *cb) >> block = tcf_block_lookup(net,

Re: [PATCHv3 net-next 5/7] net: sched: cls: add extack support for delete callback

Thu, Jan 18, 2018 at 05:20:53PM CET, ar...@mojatatu.com wrote: >This patch adds extack support for classifier delete callback api. This >prepares to handle extack support inside each specific classifier >implementation. > >Cc: David Ahern >Signed-off-by: Alexander Aring

[PATCH net-next] macsec: restore uAPI after addition of GCM-AES-256

Commit ccfdec908922 ("macsec: Add support for GCM-AES-256 cipher suite") changed a few values in the uapi headers for MACsec. Because of existing userspace implementations, we need to preserve the value of MACSEC_DEFAULT_CIPHER_ID. Not doing that resulted in wpa_supplicant segfaults when a secure

Re: [PATCH] [wireless-next] mt76: fix building without CONFIG_LEDS_CLASS

On 2018-01-18 14:14, Arnd Bergmann wrote: > When CONFIG_LEDS_CLASS is disabled, or it is a loadable module while > mt76 is built-in, we run into a link error: > > drivers/net/wireless/mediatek/mt76/mac80211.o: In function > `mt76_register_device': > mac80211.c:(.text+0xb78): relocation truncated

Re: [PATCH v2 00/31] Replacing net_mutex with rw_semaphore

On Mon, Nov 20, 2017 at 09:32:08PM +0300, Kirill Tkhai wrote: > Hi, > > there is the second version of patchset introducing net_sem > instead of net_mutex. The patchset adds net_sem in addition > to net_mutex and allows pernet_operations to be async. This > flag means, the pernet_operations

[PATCHv3 net-next 6/7] net: sched: cls: add extack support for tcf_change_indev

This patch adds extack handling for the tcf_change_indev function which is common used by TC classifier implementations. Cc: David Ahern Signed-off-by: Alexander Aring --- include/net/pkt_cls.h | 7 +-- net/sched/cls_flower.c | 7 ---

[PATCHv3 net-next 7/7] net: sched: cls_u32: add extack support

This patch adds extack support for the u32 classifier as example for delete and init callback. Cc: David Ahern Signed-off-by: Alexander Aring --- net/sched/cls_u32.c | 58 - 1 file changed, 44

[PATCHv3 net-next 2/7] net: sched: cls_api: handle generic cls errors

This patch adds extack support for generic cls handling. The extack will be set deeper to each called function which is not part of netdev core api. Cc: David Ahern Signed-off-by: Alexander Aring --- net/sched/cls_api.c | 52

[PATCHv3 net-next 3/7] net: sched: cls: add extack support for change callback

This patch adds extack support for classifier change callback api. This prepares to handle extack support inside each specific classifier implementation. Cc: David Ahern Signed-off-by: Alexander Aring --- include/net/sch_generic.h | 3 ++-

[PATCHv3 net-next 1/7] net: sched: cls: fix code style issues

This patch changes some code style issues pointed out by checkpatch inside the TC cls subsystem. Signed-off-by: Alexander Aring --- include/net/sch_generic.h | 3 ++- net/sched/cls_matchall.c | 2 +- net/sched/cls_u32.c | 8 3 files changed, 7 insertions(+),

[PATCHv3 net-next 5/7] net: sched: cls: add extack support for delete callback

This patch adds extack support for classifier delete callback api. This prepares to handle extack support inside each specific classifier implementation. Cc: David Ahern Signed-off-by: Alexander Aring --- include/net/sch_generic.h | 3 ++-

[PATCHv3 net-next 4/7] net: sched: cls: add extack support for tcf_exts_validate

The tcf_exts_validate function calls the act api change callback. For preparing extack support for act api, this patch adds the extack as parameter for this function which is common used in cls implementations. Furthermore the tcf_exts_validate will call action init callback which prepares the TC

[PATCHv3 net-next 0/7] net: sched: cls: add extack support

Hi, this patch adds extack support for TC classifier subsystem. The first patch fixes some code style issues for this patch series pointed out by checkpatch. The other patches until the last one prepares extack handling for the TC classifier subsystem and handle generic extack errors. The last

RE: [PATCH v2] r8152: disable RX aggregation on Dell TB16 dock

> -Original Message- > From: Kai Heng Feng [mailto:kai.heng.f...@canonical.com] > Sent: Thursday, January 18, 2018 10:57 AM > To: David Miller > Cc: Hayes Wang ; gre...@linuxfoundation.org; linux- > u...@vger.kernel.org; netdev@vger.kernel.org;

Re: [PATCH net-next] kcm: do not attach sockets if sk_user_data is already used

On Wed, Jan 17, 2018 at 11:25 AM, David Miller wrote: > From: James Chapman > Date: Wed, 17 Jan 2018 11:13:33 + > >> On 16 January 2018 at 19:00, David Miller wrote: >>> From: Tom Herbert >>> Date: Tue,

Re: [PATCH net-next] kcm: do not attach sockets if sk_user_data is already used

On Thu, Jan 18, 2018 at 7:40 AM, James Chapman wrote: > On 18 January 2018 at 15:18, Guillaume Nault wrote: >> On Wed, Jan 17, 2018 at 02:25:38PM -0500, David Miller wrote: >>> From: James Chapman >>> Date: Wed, 17 Jan 2018

Re: aio poll, io_pgetevents and a new in-kernel poll API V3

On 01/18/2018 05:46 PM, Jeff Moyer wrote: FYI, this kernel has issues. It will boot up, but I don't have networking, and even rebooting doesn't succeed. I'm looking into it. FWIW, I'm running an older version of this patchset on my desktop with no problems so far. -Jeff Christoph

Re: [PATCH RFC net-next 1/6] sock: MSG_PEEK support for sk_error_queue

On Thu, 2018-01-18 at 06:02 -0500, Sowmini Varadhan wrote: > On (01/17/18 18:50), Willem de Bruijn wrote: > > > > This can cause reordering with parallel readers. Can we avoid the need > > for peeking? It also caused a slew of subtle bugs previously. > > Yes, I did notice the potential for

Re: [PATCH RFC net-next 1/6] sock: MSG_PEEK support for sk_error_queue

On Wed, 2018-01-17 at 04:19 -0800, Sowmini Varadhan wrote: > Allow the application the ability to use MSG_PEEK with sk_error_queue > so that it can peek and re-read message in cases where MSG_TRUNC > may be encountered. > > Signed-off-by: Sowmini Varadhan Lets not

Re: [PATCH net-next] kcm: do not attach sockets if sk_user_data is already used

On Thu, Jan 18, 2018 at 03:40:52PM +, James Chapman wrote: > On 18 January 2018 at 15:18, Guillaume Nault wrote: > > On Wed, Jan 17, 2018 at 02:25:38PM -0500, David Miller wrote: > >> If all else was equal, even though it doesn't make much sense to KCM > >> attach L2TP

Re: [RFC][PATCH] get rid of the use of set_fs() (by way of kernel_recvmsg()) in sunrpc

> We could turn ->msg_control/->msg_controllen into another > iov_iter, but seeing that we never do scatter-gather for those > IMO that would be a massive overkill. A flag controlling whether > ->msg_control is kernel or userland pointer would do, especially > since we already have a flag

  1   2   3   4   >