Re: [PATCH iproute2-next v2 0/6] ipaddress: Get rid of print_linkinfo_brief()

David Ahern wrote: > On 1/30/18 11:09 AM, Serhey Popovych wrote: >> With this series I propose to get rid of custom print_linkinfo_brief() >> in favor of print_linkinfo() to avoid code duplication. >> > > Cover letter needs updating in light of the change to patch 6 > Agree, will resend series

[PATCH iproute2-next] Revert "ip address: Change print_linkinfo_brief to take filter as an input"

This reverts commit 63891c70137f200105c539c92eb73abade2c05d5. It seems print_linkinfo_brief() never accepts filter different than default one and David Ahern suggests to revert it instead of making new change that actually do revert. Conflicts: ip/ipaddress.c ip/iplink.c These

Re: [bpf-next PATCH v3 2/3] bpf: sockmap, add sock close() hook to remove socks

On 01/29/2018 09:27 PM, John Fastabend wrote: > The selftests test_maps program was leaving dangling BPF sockmap > programs around because not all psock elements were removed from > the map. The elements in turn hold a reference on the BPF program > they are attached to causing BPF programs to

Re: [PATCH] tcp_lp: use 64-bit arithmetic instead of 32-bit

From: "Gustavo A. R. Silva" Date: Wed, 31 Jan 2018 18:24:07 -0600 > Cast to s64 some variables and a macro in order to give the > compiler complete information about the proper arithmetic to > use. Notice that these elements are used in contexts that > expect expressions

Re: [PATCH v4] openvswitch: Remove padding from packet before L3+ conntrack processing

From: Ed Swierk Date: Wed, 31 Jan 2018 18:48:02 -0800 > IPv4 and IPv6 packets may arrive with lower-layer padding that is not > included in the L3 length. For example, a short IPv4 packet may have > up to 6 bytes of padding following the IP payload when received on an

Re: [bpf-next PATCH 0/5] tools/libbpf improvements and selftests

Hi Jesper, On 01/27/2018 06:26 PM, Jesper Dangaard Brouer wrote: > While playing with using libbpf for the Suricata project, we had > issues LLVM >= 4.0.1 generating ELF files that could not be loaded > with libbpf (tools/lib/bpf/). > > During the troubleshooting phase, I wrote a test program

Re: [PATCH iproute2-next v2 1/6] ipaddress: Improve print_linkinfo()

David Ahern wrote: > On 1/30/18 11:09 AM, Serhey Popovych wrote: > >> diff --git a/ip/ipaddress.c b/ip/ipaddress.c >> index 051a05f..f8fd392 100644 >> --- a/ip/ipaddress.c >> +++ b/ip/ipaddress.c >> @@ -948,14 +948,14 @@ int print_linkinfo_brief(const struct sockaddr_nl *who, >>

Re: [4.15-rc9] fs_reclaim lockdep trace

Peter Zijlstra wrote: > On Mon, Jan 29, 2018 at 08:47:20PM +0900, Tetsuo Handa wrote: > > Peter Zijlstra wrote: > > > On Sun, Jan 28, 2018 at 02:55:28PM +0900, Tetsuo Handa wrote: > > > > This warning seems to be caused by commit d92a8cfcb37ecd13 > > > > ("locking/lockdep: Rework FS_RECLAIM

[PATCH net] rtnetlink: remove check for IFLA_IF_NETNSID

RTM_NEWLINK supports the IFLA_IF_NETNSID property since 5bb8ed075428b71492734af66230aa0c07fcc515 so we should not error out when it is passed. Signed-off-by: Christian Brauner --- net/core/rtnetlink.c | 3 --- 1 file changed, 3 deletions(-) diff --git

Re: Compare length of req sock queue with sk_max_ack_backlog

On Thu, 2018-02-01 at 20:34 +0800, Tonghao Zhang wrote: > Hi Eric > One question for you, In the patch ef547f2ac16 ("tcp: remove > max_qlen_log"), why we compared the length of req sock queue with > sk_max_ack_backlog. If we remove the max_qlen_log, we should check the > length of req sock queue

Re: [PATCH] be2net: remove redundant initialization of 'head' and pointer txq

From: Colin King Date: Wed, 31 Jan 2018 16:14:25 + > From: Colin Ian King > > Variable head is initialized to a value that is never read and is > being updated to a new value a few lines later, hence this > initialization is redundant and

Re: [PATCH net-next 2/2] net: stmmac: Add support for DWMAC5 and implement Safety Features

> +static void dwmac5_log_error(struct net_device *ndev, u32 value, bool corr, > + const char *module_name, const char **errors_str) { > + unsigned long loc, mask; > + > + mask = value; > + for_each_set_bit(loc, , 32) { > + netdev_err(ndev, "Found %s error in

[PATCH] socket: Provide bounce buffer for constant sized put_cmsg()

Most callers of put_cmsg() use a "sizeof(foo)" for the length argument. Within put_cmsg(), a copy_to_user() call is made with a dynamic size, as a result of the cmsg header calculations. This means that hardened usercopy will examine the copy, even though it was technically a fixed size and should

Re: [PATCH] net: bridge: Fix uninitialized error in br_fdb_sync_static()

From: Geert Uytterhoeven Date: Thu, 1 Feb 2018 11:25:27 +0100 > With gcc-4.1.2.: > > net/bridge/br_fdb.c: In function ‘br_fdb_sync_static’: > net/bridge/br_fdb.c:996: warning: ‘err’ may be used uninitialized in this > function > > Indeed, if the list is empty,

Re: [PATCH bpf] tools/bpf: permit selftests/bpf to be built in a different directory

On 01/30/2018 06:23 AM, Yonghong Song wrote: > Fix a couple of issues at tools/testing/selftests/bpf/Makefile so > the following command >make -C tools/testing/selftests/bpf OUTPUT=/home/yhs/tmp > can put the built results into a different directory. > > Also add the built binary

[PATCH net-next 2/2] net: stmmac: Add support for DWMAC5 and implement Safety Features

This adds initial suport for DWMAC5 and implements the Automotive Safety Package which is available from core version 5.10. The Automotive Safety Pacakge (also called Safety Features) offers us with error protection in the core by implementing ECC Protection in memories, on-chip data path parity

[PATCH net-next 0/2] Fix TX Timeout and implement Safety Features

Fix the TX Timeout handler to correctly reconfigure the whole system and start implementing features for DWMAC5 cores, specifically the Safety Features. Cc: David S. Miller Cc: Joao Pinto Cc: Giuseppe Cavallaro Cc: Alexandre

[PATCH net-next 1/2] net: stmmac: Rework and fix TX Timeout code

Currently TX Timeout handler does not behaves as expected and leads to an unrecoverable state. Rework current implementation of TX Timeout handling to actually perform a complete reset of the driver state and IP. We use deferred work to init a task which will be responsible for resetting the

Re: [bpf-next PATCH 0/5] tools/libbpf improvements and selftests

On Thu, 1 Feb 2018 11:59:29 +0100 Daniel Borkmann wrote: > Hi Jesper, > > On 01/27/2018 06:26 PM, Jesper Dangaard Brouer wrote: > > While playing with using libbpf for the Suricata project, we had > > issues LLVM >= 4.0.1 generating ELF files that could not be loaded > >

Re: [PATCH iproute2-next v2 5/6] utils: Introduce and use print_name_and_link() to print name@link

David Ahern wrote: > On 1/30/18 11:09 AM, Serhey Popovych wrote: >> There is at least three places implementing same things: two in >> ipaddress.c print_linkinfo() & print_linkinfo_brief() and one in >> bridge/link.c. >> >> These two implementations diverge from each other very little: >>

[patch net] rocker: fix possible null pointer dereference in rocker_router_fib_event_work

From: Jiri Pirko Currently, rocker user may experience following null pointer derefence bug: [3.062141] BUG: unable to handle kernel NULL pointer dereference at 00d0 [3.065163] IP: rocker_router_fib_event_work+0x36/0x110 [rocker] The problem is

Re: [PATCH] net: bridge: Fix uninitialized error in br_fdb_sync_static()

On 01/02/18 12:25, Geert Uytterhoeven wrote: > With gcc-4.1.2.: > > net/bridge/br_fdb.c: In function ‘br_fdb_sync_static’: > net/bridge/br_fdb.c:996: warning: ‘err’ may be used uninitialized in this > function > > Indeed, if the list is empty, err will be uninitialized, and will be >

Re: [PATCH] inet: Avoid unitialized variable warning in inet_unhash()

On Thu, Feb 1, 2018 at 11:26 AM, Geert Uytterhoeven wrote: > With gcc-4.1.2: > > net/ipv4/inet_hashtables.c: In function ‘inet_unhash’: > net/ipv4/inet_hashtables.c:628: warning: ‘ilb’ may be used uninitialized > in this function > > While this is a false positive,

Re: [PATCH iproute2-next v2 2/6] ipaddress: Simplify print_linkinfo_brief() and it's usage

David Ahern wrote: > On 1/30/18 11:09 AM, Serhey Popovych wrote: >> Improve print_linkinfo_brief() and it's callers: >> >> 1) Get rid of custom @struct filter pointer @pfilter: it is NULL in >> all callers anyway and global @filter is used. >> > > Looks like I somehow dropped a vrf change

Compare length of req sock queue with sk_max_ack_backlog

Hi Eric One question for you, In the patch ef547f2ac16 ("tcp: remove max_qlen_log"), why we compared the length of req sock queue with sk_max_ack_backlog. If we remove the max_qlen_log, we should check the length of req sock queue with tcp_max_syn_backlog, right ? With this patch, the option

Re: [bpf-next PATCH v3 1/3] net: add a UID to use for ULP socket assignment

On 01/29/2018 09:27 PM, John Fastabend wrote: > Create a UID field and enum that can be used to assign ULPs to > sockets. This saves a set of string comparisons if the ULP id > is known. > > For sockmap, which is added in the next patches, a ULP is used to > hook into TCP sockets close state. In

RE: [PATCH net-next 2/2] net: stmmac: Add support for DWMAC5 and implement Safety Features

Looking great! -Original Message- From: Jose Abreu [mailto:joab...@synopsys.com] Sent: Thursday, February 1, 2018 2:42 PM To: netdev@vger.kernel.org Cc: Jose Abreu ; David S. Miller ; Joao Pinto ; Giuseppe Cavallaro

Re: [PATCH net] tcp_bbr: fix pacing_gain to always be unity when using lt_bw

From: Neal Cardwell Date: Wed, 31 Jan 2018 15:43:05 -0500 > This commit fixes the pacing_gain to remain at BBR_UNIT (1.0) when > using lt_bw and returning from the PROBE_RTT state to PROBE_BW. > > Previously, when using lt_bw, upon exiting PROBE_RTT and entering > PROBE_BW

Re: KASAN: stack-out-of-bounds Read in xfrm_state_find (4)

On Thu, Feb 1, 2018 at 11:30 AM, Dmitry Vyukov wrote: > On Thu, Feb 1, 2018 at 9:34 AM, Steffen Klassert > wrote: >> On Wed, Jan 31, 2018 at 07:58:01AM -0800, syzbot wrote: >>> Hello, >>> >>> syzbot hit the following crash on upstream commit >>>

Re: Backport Mellanox mlx5 patches to stable 4.9.y

On 2/1/2018 10:21 AM, Greg KH wrote: On Tue, Jan 30, 2018 at 10:12:51AM +0100, Marta Rybczynska wrote: Hello Mellanox maintainers, I'd like to ask you to OK backporting two patches in mlx5 driver to 4.9 stable tree (they're in master for some time already). We have multiple deployment in 4.9

Re: [PATCH] inet: Avoid unitialized variable warning in inet_unhash()

From: Geert Uytterhoeven Date: Thu, 1 Feb 2018 11:26:23 +0100 > With gcc-4.1.2: > > net/ipv4/inet_hashtables.c: In function ‘inet_unhash’: > net/ipv4/inet_hashtables.c:628: warning: ‘ilb’ may be used uninitialized > in this function > > While this is a false

regression in igb driver from commit 182785335447

one of my colleagues observed a regression in recent 4.4.x kernels on one of test machines with 82575EB NIC (rev 02, 8086:10a7, firmware version 1.6.5). On boot, first port fails to initialize and only the net device for second is created. Kernel log looks like [ 13.710535] igb: Intel(R)

Re: Backport Mellanox mlx5 patches to stable 4.9.y

- Mail original - > On Tue, Jan 30, 2018 at 10:12:51AM +0100, Marta Rybczynska wrote: >> Hello Mellanox maintainers, >> I'd like to ask you to OK backporting two patches in mlx5 driver to 4.9 >> stable >> tree (they're in master for some time already). >> >> We have multiple deployment

Re: [PATCH v4 0/2] bnx2x: disable GSO on too-large packets

From: Daniel Axtens Date: Wed, 31 Jan 2018 14:15:32 +1100 > We observed a case where a packet received on an ibmveth device had a > GSO size of around 10kB. This was forwarded by Open vSwitch to a bnx2x > device, where it caused a firmware assert. This is described in detail >

Re: WARNING in refcount_inc (2)

On Wed, Jan 31, 2018 at 8:27 AM, Eric Biggers wrote: > > Also Dmitry, syzbot seems to be grouping together unrelated bugs under the > refcount_t WARNINGs; maybe those should be on a blacklist? Not a blacklist, we need a proper way of extracting the offending caller like it's

Re: [patch net] rocker: fix possible null pointer dereference in rocker_router_fib_event_work

From: Jiri Pirko Date: Thu, 1 Feb 2018 12:21:15 +0100 > From: Jiri Pirko > > Currently, rocker user may experience following null pointer > derefence bug: > > [3.062141] BUG: unable to handle kernel NULL pointer dereference at > 00d0 > [

[PATCH] net: jme: remove unused initialization of 'rxdesc'

From: Colin Ian King Pointer rxdesc is assigned a value that is never read, it is overwritten by a new assignment inside a while loop hence the initial assignment is redundant and can be removed. Cleans up clang warning: drivers/net/ethernet/jme.c:1074:17: warning:

Re: [bpf-next PATCH 0/5] tools/libbpf improvements and selftests

On 02/01/2018 03:41 PM, Jesper Dangaard Brouer wrote: > On Thu, 1 Feb 2018 11:59:29 +0100 > Daniel Borkmann wrote: > >> Hi Jesper, >> >> On 01/27/2018 06:26 PM, Jesper Dangaard Brouer wrote: >>> While playing with using libbpf for the Suricata project, we had >>> issues

[PATCH, net] ibmvnic: fix firmware version when no firmware level has been provided by the VIOS server

Older versions of VIOS servers do not send the firmware level in the VPD buffer for the ibmvnic driver. Thus, not only the current message is mis- leading but the firmware version in the ethtool will be NULL. Therefore, this patch fixes the firmware string and its warning. Fixes: 4e6759be28e4

Re: sctp netns "unregister_netdevice: waiting for lo to become free. Usage count = 1"

2018-01-31 19:51 GMT+02:00 Tommi Rantala : > On 31.01.2018 14:31, Neil Horman wrote: >> >> On Wed, Jan 31, 2018 at 11:42:24AM +0200, Tommi Rantala wrote: >>> >>> I think there's a problem in the dst refcounting in sctp_v4_get_dst() >>> >>> There's a dst_entry struct that

[PATCH 2/6] netfilter: x_tables: avoid out-of-bounds reads in xt_request_find_{match|target}

From: Eric Dumazet It looks like syzbot found its way into netfilter territory. Issue here is that @name comes from user space and might not be null terminated. Out-of-bound reads happen, KASAN is not happy. v2 added similar fix for xt_request_find_target(), as Florian

[PATCH 0/6] Netfilter fixes for net

Hi David, The following patchset contains Netfilter fixes for your net tree, they are: 1) Fix OOM that syskaller triggers with ipt_replace.size = -1 and IPT_SO_SET_REPLACE socket option, from Dmitry Vyukov. 2) Check for too long extension name in xt_request_find_{match|target} that result

[RFC][PATCH iproute2-next 0/6] ip: Use netlink to walk through network device list

In this seris I replace /proc/net/dev and /sys/class/net usage for walk through network device list in iptunnel/ip6tunnel and iptuntap by rtnl_dump_filter() functionality. This is an RFC, tested minimally tunnels, tuntap seems work as before. Note that some comments, especially for

[RFC][PATCH iproute2-next 1/6] ipaddress: Unify print_link_stats() and print_link_stats64()

To show real differences between these two variants adjust whitespace intendation and use print_uint() instead of print_int() as all members in both @struct rtnl_link_stats and @struct rtnl_link_stats64 are unsigned. Signed-off-by: Serhey Popovych --- ip/ipaddress.c |

Re: [PATCH iproute2-next 0/4] ip: Introduce and use helper to read /proc/net/dev

Stephen Hemminger wrote: > On Wed, 31 Jan 2018 21:49:45 +0200 > Serhey Popovych wrote: > >> Currently there is two places in ip(8) where /proc/net/dev is read line >> by line with nearly identical steps: iptunnel.c and ip6tunnel.c >> >> On the other hand we have

Re: possible deadlock in do_ip_getsockopt

syzbot wrote: > Hello, > > syzbot hit the following crash on upstream commit > c4e0ca7fa24137e372d6135fe16e8df8e123f116 (Fri Jan 26 23:10:50 2018 +) > Merge tag 'riscv-for-linus-4.15-maintainers' of >

ethtool 4.15 released

ethtool version 4.15 has been released. Home page: https://www.kernel.org/pub/software/network/ethtool/ Download link: https://www.kernel.org/pub/software/network/ethtool/ethtool-4.15.tar.xz Release notes: * Feature: Support for FEC encoding control * Fix: Fix coding style

Re: sctp netns "unregister_netdevice: waiting for lo to become free. Usage count = 1"

On Thu, Feb 01, 2018 at 08:02:07PM +0200, Tommi Rantala wrote: > 2018-01-31 19:51 GMT+02:00 Tommi Rantala : > > On 31.01.2018 14:31, Neil Horman wrote: > >> > >> On Wed, Jan 31, 2018 at 11:42:24AM +0200, Tommi Rantala wrote: > >>> > >>> I think there's a problem in the

RE: [PATCH iproute2-next 08/10] rdma: Add QP resource tracking information

Hey Leon, > > From: Leon Romanovsky > > This patch adds ss-similar interface to view various resource > tracked objects. At this stage, only QP is presented. > > 1. Get all QPs for the specific device: > $ rdma res show qp link mlx5_4 > link mlx5_4/- lqpn 8 type UD state

[PATCH 3/6] netfilter: ipset: Fix wraparound in hash:*net* types

From: Jozsef Kadlecsik Fix wraparound bug which could lead to memory exhaustion when adding an x.x.x.x-255.255.255.255 range to any hash:*net* types. Fixes Netfilter's bugzilla id #1212, reported by Thomas Schwark. Fixes: 48596a8ddc46 ("netfilter: ipset: Fix adding an

[PATCH 4/6] netfilter: x_tables: fix pointer leaks to userspace

From: Dmitry Vyukov Several netfilter matches and targets put kernel pointers into info objects, but don't set usersize in descriptors. This leads to kernel pointer leaks if a match/target is set and then read back to userspace. Properly set usersize for these

[PATCH] ath5k: remove duplicated re-assignment to pointer 'tq'

From: Colin Ian King Pointer tq is initialized with >ah_txq[queue] and then a few lines later is re-assigned the same value, hence this duplicate assignment is redundant and can be removed. Cleans up clang warning: drivers/net/wireless/ath/ath5k/qcu.c:326:25: warning:

[PATCH net] net: igmp: add a missing rcu locking section

From: Eric Dumazet Newly added igmpv3_get_srcaddr() needs to be called under rcu lock. Timer callbacks do not ensure this locking. = WARNING: suspicious RCU usage 4.15.0+ #200 Not tainted -

[RFC][PATCH iproute2-next 3/6] tunnel: Split statistic getting and printing

This is first step to move tunnel code to use rtnl dump interface instead of /proc/net/dev read. Make tnl_print_stats() to accept @struct rtnl_link_stats64 parameter, introduce tnl_get_stats() that will parse line from /proc/net/dev into @struct rtnl_link_stats64. Signed-off-by: Serhey Popovych

[RFC][PATCH iproute2-next 6/6] tuntap: Use netlink to walk through tuntap list

It seems bad idea to depend on sysfs being mounted and reflected to the current network namespace. Same applies to procfs. Instead netlink should be used to talk to the kernel and get list of specific network devices among with their parameters. Support for kernel netlink message filtering by

[RFC][PATCH iproute2-next 4/6] iptunnel/ip6tunnel: Code cleanups

Use switch () instead of if () to compare tunnel type to fit into 80 columns and make code more readable. Print "\n" using fputc(). In iptunnel.c abstract tunnel parameters matching code in iptunnel.c into ip_tunnel_parm_match() helper to conform with ip6tunnel.c. In ip6tunnel.c no need to call

[RFC][PATCH iproute2-next 5/6] iptunnel/ip6tunnel: Use netlink to walk through tunnels list

Signed-off-by: Serhey Popovych --- ip/ip6tunnel.c | 115 --- ip/iptunnel.c | 108 ++- ip/tunnel.c| 117 +---

[RFC][PATCH iproute2-next 2/6] ip: Introduce get_rtnl_link_stats_rta() to get link statistics

Assume all statistics in ip(8) represented either by IFLA_STATS64 or IFLA_STATS is 64 bit. It is clean that we can store __u32 counters of @struct rtnl_link_stats in __u64 counters in @struct rtnl_link_stats64. New get_rtnl_link_stats_rta() follows __print_link_stats() behaviour on handling of

Re: [PATCH] lan78xx: remove redundant initialization of pointer 'phydev'

From: Colin King Date: Thu, 1 Feb 2018 17:10:18 + > From: Colin Ian King > > Pointer phydev is initialized and this value is never read, phydev > is immediately updated to a new value, hence this initialization > is redundant and can be

Re: [PATCH] vmxnet3: remove redundant initialization of pointer 'rq'

From: Colin King Date: Thu, 1 Feb 2018 17:29:21 + > From: Colin Ian King > > Pointer rq is being initialized but this value is never read, it > is being updated inside a for-loop. Remove the initialization and > move it into the scope of

Re: [PATCH net] net: igmp: add a missing rcu locking section

From: Eric Dumazet Date: Thu, 01 Feb 2018 10:26:57 -0800 > From: Eric Dumazet > > Newly added igmpv3_get_srcaddr() needs to be called under rcu lock. > > Timer callbacks do not ensure this locking. ... > Fixes: a46182b00290 ("net: igmp: Use

Re: [PATCH v2] net: pxa168_eth: add netconsole support

From: Alexander Monakov Date: Thu, 1 Feb 2018 22:45:17 +0300 (MSK) > This implements ndo_poll_controller callback which is necessary to > enable netconsole. > > Signed-off-by: Alexander Monakov Looks good, applied.

Re: [PATCH] vsock.7: document VSOCK socket address family

On Tue, Jan 30, 2018 at 10:31:54PM +0100, Michael Kerrisk (man-pages) wrote: > Hi Stefan, > > Ping on the below please, since it either blocks the man-pages release > I'd currently like to make, or I must remove the vsock.7 page for this > release. Sorry for the delay. The verbatim license is

Re: [PATCH 0/6] Netfilter fixes for net

From: Pablo Neira Ayuso Date: Thu, 1 Feb 2018 19:02:11 +0100 > The following patchset contains Netfilter fixes for your net tree, > they are: > > 1) Fix OOM that syskaller triggers with ipt_replace.size = -1 and >IPT_SO_SET_REPLACE socket option, from Dmitry Vyukov. >

[PATCH 6/6] netfilter: on sockopt() acquire sock lock only in the required scope

From: Paolo Abeni Syzbot reported several deadlocks in the netfilter area caused by rtnl lock and socket lock being acquired with a different order on different code paths, leading to backtraces like the following one: ==

[PATCH 1/6] netfilter: x_tables: fix int overflow in xt_alloc_table_info()

From: Dmitry Vyukov syzkaller triggered OOM kills by passing ipt_replace.size = -1 to IPT_SO_SET_REPLACE. The root cause is that SMP_ALIGN() in xt_alloc_table_info() causes int overflow and the size check passes when it should not. SMP_ALIGN() is no longer needed leftover.

[PATCH 5/6] netfilter: ipt_CLUSTERIP: fix out-of-bounds accesses in clusterip_tg_check()

From: Dmitry Vyukov Commit 136e92bbec0a switched local_nodes from an array to a bitmask but did not add proper bounds checks. As the result clusterip_config_init_nodelist() can both over-read ipt_clusterip_tgt_info.local_nodes and over-write clusterip_config.local_nodes. Add

[PATCH] ixgbevf: remove redundant initialization of variable 'dma'.

From: Colin Ian King Variable dma is initialized with a value that is never read, later on it is re-assigned a new value, hence the initialization is redundant and can be removed. Cleans up clang warning: drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c:584:13:

[PATCH v2] net: pxa168_eth: add netconsole support

This implements ndo_poll_controller callback which is necessary to enable netconsole. Signed-off-by: Alexander Monakov Cc: Russell King Cc: Sebastian Hesselbarth Cc: Florian Fainelli ---

Re: [PATCH net] net: memcontrol: charge allocated memory after mem_cgroup_sk_alloc()

On Thu, Feb 01, 2018 at 10:16:55AM -0500, David Miller wrote: > From: Roman Gushchin > Date: Wed, 31 Jan 2018 21:54:08 + > > > So I really start thinking that reverting 9f1c2674b328 > > ("net: memcontrol: defer call to mem_cgroup_sk_alloc()") > > and fixing the original issue

Re: [PATCH] vmxnet3: remove redundant initialization of pointer 'rq'

On Thu, 1 Feb 2018, Colin King wrote: > From: Colin Ian King > > Pointer rq is being initialized but this value is never read, it > is being updated inside a for-loop. Remove the initialization and > move it into the scope of the for-loop. > > Cleans up clang

Re: [PATCH] net: jme: remove unused initialization of 'rxdesc'

From: Colin King Date: Thu, 1 Feb 2018 16:58:42 + > From: Colin Ian King > > Pointer rxdesc is assigned a value that is never read, it is overwritten > by a new assignment inside a while loop hence the initial assignment > is redundant

Re: [PATCH, net] ibmvnic: fix firmware version when no firmware level has been provided by the VIOS server

From: Desnes Augusto Nunes do Rosario Date: Thu, 1 Feb 2018 16:04:30 -0200 > Older versions of VIOS servers do not send the firmware level in the VPD > buffer for the ibmvnic driver. Thus, not only the current message is mis- > leading but the firmware version in the

[PATCH] DT: net: renesas,ravb: document R8A77980 bindings

Renesas R-Car V3H (R8A77980) SoC has the R-Car gen3 compatible EtherAVB device, so document the SoC specific bindings. Signed-off-by: Sergei Shtylyov --- The patch is against DaveM's 'net-next.git' repo but I wouldn't mind if it's applied to 'net.git'

Re: [PATCH net] net: memcontrol: charge allocated memory after mem_cgroup_sk_alloc()

From: Roman Gushchin Date: Wed, 31 Jan 2018 21:54:08 + > So I really start thinking that reverting 9f1c2674b328 > ("net: memcontrol: defer call to mem_cgroup_sk_alloc()") > and fixing the original issue differently might be easier > and a proper way to go. Does it makes sense?

Respond for details

Dear sir/ madam Do you need a loan to pay off bills ? To pay off your mortgage quickly ? To set up a new business or to Re- finance your existing business ? I can help you secure a private loan at 3% interest rate please respond for more details Thanks Allen

Re: [RFC v2 02/14] tcp: Pass sock and skb to tcp_options_write

From: Christoph Paasch Date: Wed, 31 Jan 2018 16:07:04 -0800 > An upcoming patch adds a configurable, per-socket list of TCP options to > populate in the TCP header. This requires tcp_options_write() to know the > socket (to use the options list) and the skb (to provide

Re: [PATCH net] rtnetlink: remove check for IFLA_IF_NETNSID

From: Christian Brauner Date: Thu, 1 Feb 2018 12:56:00 +0100 > RTM_NEWLINK supports the IFLA_IF_NETNSID property since > 5bb8ed075428b71492734af66230aa0c07fcc515 so we should not error out > when it is passed. > > Signed-off-by: Christian Brauner

[PATCH] lan78xx: remove redundant initialization of pointer 'phydev'

From: Colin Ian King Pointer phydev is initialized and this value is never read, phydev is immediately updated to a new value, hence this initialization is redundant and can be removed Cleans up clang warning: drivers/net/usb/lan78xx.c:2009:21: warning: Value stored to

Re: WARNING in refcount_inc (2)

On Thu, Feb 1, 2018 at 3:34 PM, 'Andrey Konovalov' via syzkaller-bugs wrote: > On Wed, Jan 31, 2018 at 8:27 AM, Eric Biggers wrote: >> >> Also Dmitry, syzbot seems to be grouping together unrelated bugs under the >> refcount_t WARNINGs; maybe

Re: [RFC PATCH 00/24] Introducing AF_XDP support

On Wed, 31 Jan 2018 14:53:32 +0100 Björn Töpel wrote: > * In this RFC, do not use an XDP_REDIRECT action other than > bpf_xdpsk_redirect for XDP_DRV_ZC. This is because a zero-copy > allocated buffer will then be sent to a cpu id / queue_pair through > ndo_xdp_xmit

Re: [PATCH net-next 2/2] net: stmmac: Add support for DWMAC5 and implement Safety Features

From: Andrew Lunn Date: Thu, 1 Feb 2018 16:02:09 +0100 >> +static void dwmac5_log_error(struct net_device *ndev, u32 value, bool corr, >> +const char *module_name, const char **errors_str) { >> +unsigned long loc, mask; >> + >> +mask = value; >> +

Re: [RFC v2 00/14] Generic TCP-option framework and adoption for TCP-SMC and TCP-MD5

From: Christoph Paasch Date: Wed, 31 Jan 2018 16:07:02 -0800 > TCP-options like TCP_MD5 and SMC are rather rare use-cases, but their > implementation is rather intrusive to the TCP-stack. Other, more recent > TCP extensions like TCP-crypt, MPTCP or TCP-AO would make this

Re: [PATCH net-next 2/2] net: stmmac: Add support for DWMAC5 and implement Safety Features

From: Jose Abreu Date: Thu, 1 Feb 2018 15:26:44 + > Hmm, I have that locally and in the raw .patch file ... Maybe > there is something wrong with my git send-email? That's for you to figure out I suppose :-)

[PATCH net-next] r8169: add module param for control of ASPM disable

The patch is from Todd Broch . ASPM has been disabled in this driver by default as its been implicated in stability issues on at least one platform. This CL adds a module parameter to allow control of ASPM disable. The default value is to

Re: [PATCH iproute2-next] Revert "ip address: Change print_linkinfo_brief to take filter as an input"

On 2/1/18 4:25 AM, Serhey Popovych wrote: > This reverts commit 63891c70137f200105c539c92eb73abade2c05d5. > > It seems print_linkinfo_brief() never accepts filter different than > default one and David Ahern suggests to revert it instead of making > new change that actually do revert. > >

Re: [PATCH net-next 2/2] net: stmmac: Add support for DWMAC5 and implement Safety Features

Hi Andrew, On 01-02-2018 15:02, Andrew Lunn wrote: >> +static void dwmac5_log_error(struct net_device *ndev, u32 value, bool corr, >> +const char *module_name, const char **errors_str) { >> +unsigned long loc, mask; >> + >> +mask = value; >> +for_each_set_bit(loc, , 32) {

Kredit? so schnell wie möglich?

Kredit? so schnell wie möglich? unkompliziert und seriös ? Bei uns genau richtig. Wir arbeiten europaweit. Wir vermitteln Kredite und Darlehen zu fairen Konditionen. Durch unsere seriöse, kompetente und ehrliche Kreditberatung haben wir über Jahre eine starke Position auf dem Markt.

Re: [PATCH net-next 2/2] net: stmmac: Add support for DWMAC5 and implement Safety Features

Hi David, On 01-02-2018 15:09, David Miller wrote: > From: Andrew Lunn > Date: Thu, 1 Feb 2018 16:02:09 +0100 > >>> +static void dwmac5_log_error(struct net_device *ndev, u32 value, bool corr, >>> + const char *module_name, const char **errors_str) { >>> + unsigned

Re: [PATCH iproute2-next v2 5/6] utils: Introduce and use print_name_and_link() to print name@link

On 2/1/18 4:09 AM, Serhey Popovych wrote: > David Ahern wrote: >>> diff --git a/bridge/link.c b/bridge/link.c >>> index a11cbb1..90c9734 100644 >>> --- a/bridge/link.c >>> +++ b/bridge/link.c >>> @@ -125,20 +125,13 @@ int print_linkinfo(const struct sockaddr_nl *who, >>> if (n->nlmsg_type ==

Re: [PATCH bpf v2] bpf: fix null pointer deref in bpf_prog_test_run_xdp

On Wed, Jan 31, 2018 at 12:58:56PM +0100, Daniel Borkmann wrote: > syzkaller was able to generate the following XDP program ... > > (18) r0 = 0x0 > (61) r5 = *(u32 *)(r1 +12) > (04) (u32) r0 += (u32) 0 > (95) exit > > ... and trigger a NULL pointer dereference in ___bpf_prog_run() > via

[PATCH] vmxnet3: remove redundant initialization of pointer 'rq'

From: Colin Ian King Pointer rq is being initialized but this value is never read, it is being updated inside a for-loop. Remove the initialization and move it into the scope of the for-loop. Cleans up clang warning: drivers/net/vmxnet3/vmxnet3_drv.c:2763:27: warning:

Re: [Intel-wired-lan] [PATCH] ixgbevf: remove redundant initialization of variable 'dma'.

On Thu, Feb 1, 2018 at 10:35 AM, Colin King wrote: > From: Colin Ian King > > Variable dma is initialized with a value that is never read, later > on it is re-assigned a new value, hence the initialization is redundant > and can be removed. > >

Good Morning !

Good Morning , I have a project i would like to bring to you and i want you to help me discuss it. please let me know if you will be available for this project. Thanks

Urgent Attention!

I am Mr Gary Gibson. I've a proposal for you but I don't know if it would be against your ethics but would appreciate your acceptance, which would definitely be of a life time opportunity for the both of us. I hope you will accept my mail in good faith. I will give you detailed information as

Re: [PATCH net] net: memcontrol: charge allocated memory after mem_cgroup_sk_alloc()

On Thu, Feb 1, 2018 at 12:22 PM, Roman Gushchin wrote: > On Thu, Feb 01, 2018 at 10:16:55AM -0500, David Miller wrote: >> From: Roman Gushchin >> Date: Wed, 31 Jan 2018 21:54:08 + >> >> > So I really start thinking that reverting 9f1c2674b328 >> > ("net: memcontrol:

Re: [Patch net] xt_RATEEST: acquire xt_rateest_mutex for hash insert

On Wed, Jan 31, 2018 at 5:44 PM, Eric Dumazet wrote: > On Wed, 2018-01-31 at 16:26 -0800, Cong Wang wrote: >> rateest_hash is supposed to be protected by xt_rateest_mutex. >> >> Reported-by: >> Fixes: 5859034d7eb8

Re: suspicious RCU usage at net/tipc/bearer.c:LINE

On Sun, Dec 31, 2017 at 10:58:01AM -0800, syzbot wrote: > Hello, > > syzkaller hit the following crash on > 5aa90a84589282b87666f92b6c3c917c8080a9bf > git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console

Re: [PATCH] vsock.7: document VSOCK socket address family

On 1 February 2018 at 19:03, Stefan Hajnoczi wrote: > On Tue, Jan 30, 2018 at 10:31:54PM +0100, Michael Kerrisk (man-pages) wrote: >> Hi Stefan, >> >> Ping on the below please, since it either blocks the man-pages release >> I'd currently like to make, or I must remove the

RE: [RFC PATCH 1/2] hv_netvsc: Split netvsc_revoke_buf() and netvsc_teardown_gpadl()

There are multiple issues with some of the parameter change paths. Still working on getting something stable. Both upstream, and net-next do have crash issues under concurrent changes. I don't want Linux doing different workaround than Windows if at all possible; because it means that it would

  1   2   >