[PATCH net-next] ibmvnic: queue reset when CRQ gets closed during reset

While handling a driver reset we get a H_CLOSED return trying to send a CRQ event. When this occurs we need to queue up another reset attempt. Without doing this we see instances where the driver is left in a closed state because the reset failed and there is no further attempts to reset the

Re: [PATCH net] net: phy: fix phy_start to consider PHY_IGNORE_INTERRUPT

On 02/07/2018 11:26 AM, Heiner Kallweit wrote: > Am 07.02.2018 um 20:06 schrieb Florian Fainelli: >> >> >> On 02/07/2018 10:44 AM, Heiner Kallweit wrote: >>> This condition wasn't adjusted when PHY_IGNORE_INTERRUPT (-2) was added >>> long ago. In case of PHY_IGNORE_INTERRUPT the MAC interrupt

Re: [PATCH] net: ethernet: ti: cpsw: fix net watchdog timeout

On 02/07/2018 07:31 AM, Ivan Khoronzhuk wrote: > On Wed, Feb 07, 2018 at 05:03:19AM +0200, Ivan Khoronzhuk wrote: >> On Tue, Feb 06, 2018 at 07:17:06PM -0600, Grygorii Strashko wrote: >>> It was discovered that simple program which indefinitely sends 200b UDP >>> packets and runs on TI AM574x SoC

Re: [netfilter-core] kernel panic: Out of memory and no killable processes... (2)

On Wed, Feb 07, 2018 at 11:06:42AM -0800, Andrew Morton wrote: > From: Michal Hocko > Subject: net/netfilter/x_tables.c: remove size check > > Back in 2002 vmalloc used to BUG on too large sizes. We are much better > behaved these days and vmalloc simply returns NULL for those.

Re: [PATCH net] net: phy: fix phy_start to consider PHY_IGNORE_INTERRUPT

Am 07.02.2018 um 20:34 schrieb Florian Fainelli: > > > On 02/07/2018 11:26 AM, Heiner Kallweit wrote: >> Am 07.02.2018 um 20:06 schrieb Florian Fainelli: >>> >>> >>> On 02/07/2018 10:44 AM, Heiner Kallweit wrote: This condition wasn't adjusted when PHY_IGNORE_INTERRUPT (-2) was added

Re: Regression for ip6-in-ip4 IPsec tunnel in 4.14.16

On Wed, 2018-02-07 at 13:50 -0500, Mike Maloney wrote: > On Wed, Feb 7, 2018 at 12:23 PM, Yves-Alexis Perez > > Hi Yves-Alexis - > > I apologize for the problem. It seems to me that tunneling with an > outer MTU that causes the inner MTU to be smaller than the min, is >

[PATCH net v2] net: phy: fix phy_start to consider PHY_IGNORE_INTERRUPT

This condition wasn't adjusted when PHY_IGNORE_INTERRUPT (-2) was added long ago. In case of PHY_IGNORE_INTERRUPT the MAC interrupt indicates also PHY state changes and we should do what the symbol says. Signed-off-by: Heiner Kallweit --- v2: - use phy_interrupt_is_valid()

[PATCH net] net: phy: fix phy_start to consider PHY_IGNORE_INTERRUPT

This condition wasn't adjusted when PHY_IGNORE_INTERRUPT (-2) was added long ago. In case of PHY_IGNORE_INTERRUPT the MAC interrupt indicates also PHY state changes and we should do what the symbol says. Signed-off-by: Heiner Kallweit --- drivers/net/phy/phy.c | 2 +- 1

Re: Regression for ip6-in-ip4 IPsec tunnel in 4.14.16

On Wed, Feb 7, 2018 at 12:23 PM, Yves-Alexis Perez wrote: > On Wed, 2018-02-07 at 18:05 +0100, Yves-Alexis Perez wrote: >> I'll try to printk the mtu before returning EINVAL to see why it's lower than >> 1280, but maybe the IP encapsulation is not correctly handled? > > I did:

Re: [PATCH net] net: phy: fix phy_start to consider PHY_IGNORE_INTERRUPT

Am 07.02.2018 um 20:06 schrieb Florian Fainelli: > > > On 02/07/2018 10:44 AM, Heiner Kallweit wrote: >> This condition wasn't adjusted when PHY_IGNORE_INTERRUPT (-2) was added >> long ago. In case of PHY_IGNORE_INTERRUPT the MAC interrupt indicates >> also PHY state changes and we should do

[Secunia Research] Linux Kernel Vulnerability - Sending information

Hello, Secunia Research at Flexera has discovered a vulnerability in Linux Kernel, which can be exploited by malicious, local users to cause a DoS (Denial of Service). Details: - After a bit of fuzzing and some debugging, I've prepared a program that triggers a BUG() failure at

Re: [PATCH net] net: phy: fix phy_start to consider PHY_IGNORE_INTERRUPT

On 02/07/2018 10:44 AM, Heiner Kallweit wrote: > This condition wasn't adjusted when PHY_IGNORE_INTERRUPT (-2) was added > long ago. In case of PHY_IGNORE_INTERRUPT the MAC interrupt indicates > also PHY state changes and we should do what the symbol says. Do you use phy_enable_interrupts() to

Re: [netfilter-core] kernel panic: Out of memory and no killable processes... (2)

On Wed, 7 Feb 2018 18:44:39 +0100 Pablo Neira Ayuso wrote: > Hi, > > On Wed, Jan 31, 2018 at 09:19:16AM +0100, Michal Hocko wrote: > [...] > > Yeah, we do not BUG but rather fail instead. See __vmalloc_node_range. > > My excavation tools pointed me to "VM: Rework vmalloc

Re: qdisc_pkt_len_init: SCTP/GSO_BY_FRAGS and robustness questions

On Wed, Feb 07, 2018 at 12:15:32PM +1100, Daniel Axtens wrote: > Hi Marcelo and Eric, > > I'm working on checking code that might be impacted by GSO_BY_FRAGS - > after finding that the token bucket filter qdisc code doesn't handle it > properly, DaveM said I should look for other places where

Re: [RFC PATCH 00/24] Introducing AF_XDP support

On Wed, Jan 31, 2018 at 5:53 AM, Björn Töpel wrote: > From: Björn Töpel > > This RFC introduces a new address family called AF_XDP that is > optimized for high performance packet processing and zero-copy > semantics. Throughput improvements can be up

Re: [PATCH] selftests: bpf: test_kmod.sh: check the module path before insmod

Hi Daniel, On 7 February 2018 at 19:02, Daniel Borkmann wrote: > Hi Naresh, > > On 02/06/2018 10:07 PM, Naresh Kamboju wrote: >> test_kmod.sh reported false failure when module not present. >> Check test_bpf.ko is present in the path before loading it. >> >> Stop using

[PATCH] net: Extra '_get' in declaration of arch_get_platform_mac_address

In commit c7f5d105495a ("net: Add eth_platform_get_mac_address() helper."), two declarations were added: int eth_platform_get_mac_address(struct device *dev, u8 *mac_addr); unsigned char *arch_get_platform_get_mac_address(void); An extra '_get' was introduced in

[PATCH v2] selftests: bpf: test_kmod.sh: check the module path before insmod

test_kmod.sh reported false failure when module not present. Check test_bpf.ko is present in the path before loading it. Two cases to be addressed here, In the development process of test_bpf.c unit testing will be done by developers by using "insmod $SRC_TREE/lib/test_bpf.ko" On the other hand

Re: [PATCH 00/11] Netfilter fixes for net

From: Pablo Neira Ayuso Date: Wed, 7 Feb 2018 18:42:18 +0100 > The following patchset contains Netfilter fixes for you net tree, they > are: ... > You can pull these changes from: > > git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git Pulled, thanks Pablo. >

Re: [kbuild-all] [vhost:vhost 19/20] Warning: arch/x86/tools/test_get_len found difference at :ffffffff811aa5f0

On Thu, Feb 08, 2018 at 01:25:39AM +0100, Daniel Borkmann wrote: > On 02/08/2018 01:20 AM, Philip Li wrote: > > On Thu, Feb 08, 2018 at 02:09:41AM +0200, Michael S. Tsirkin wrote: > >> On Wed, Feb 07, 2018 at 03:02:57PM +0800, kbuild test robot wrote: > >>> tree:

Re: [PATCH] rtlwifi: rtl8192cu: Remove variable self-assignment in rf.c

On Wed, 2018-02-07 at 12:51 -0800, Matthias Kaehlcke wrote: > El Wed, Feb 07, 2018 at 02:35:59PM -0600 Larry Finger ha dit: > > > On 02/07/2018 02:26 PM, Matthias Kaehlcke wrote: > > > In _rtl92c_get_txpower_writeval_by_regulatory() the variable writeVal > > > is assigned to itself in an if ...

Re: [PATCH RFC 2/4] netlink: add generic object description infrastructure

On 02/06/2018 05:37 PM, Pablo Neira Ayuso wrote: > This patch allows netlink busses to provide object descriptions to > userspace, in terms of supported attributes and its corresponding > datatypes. > > Userspace sends a requests that looks like: > > netlink header > NLA_DESC_REQ_BUS

Re: [PATCH net] ptr_ring: fail early if queue occupies more than KMALLOC_MAX_SIZE

On 2018年02月07日 23:15, Michael S. Tsirkin wrote: On Wed, Feb 07, 2018 at 05:17:59PM +0800, Jason Wang wrote: On 2018年02月07日 16:08, Jason Wang wrote: To avoid slab to warn about exceeded size, fail early if queue occupies more than KMALLOC_MAX_SIZE. Reported-by:

Re: [PATCH net-next] sch_netem: Bug fixing in calculating Netem interval

On Tue, 6 Feb 2018 23:14:18 -0500 "Md. Islam" wrote: > In Kernel 4.15.0+, Netem does not work properly. > > Netem setup: > > tc qdisc add dev h1-eth0 root handle 1: netem delay 10ms 2ms > > Result: > > PING 172.16.101.2 (172.16.101.2) 56(84) bytes of data. > 64 bytes from

Re: [PATCH net] tcp: tracepoint: only call trace_tcp_send_reset with full socket

From: Song Liu Date: Tue, 6 Feb 2018 20:50:23 -0800 > tracepoint tcp_send_reset requires a full socket to work. However, it > may be called when in TCP_TIME_WAIT: > > case TCP_TW_RST: > tcp_v6_send_reset(sk, skb); >

Re: [PATCH net-next] sch_netem: Bug fixing in calculating Netem interval

From: "Md. Islam" Date: Tue, 6 Feb 2018 23:14:18 -0500 > In Kernel 4.15.0+, Netem does not work properly. > > Netem setup: > > tc qdisc add dev h1-eth0 root handle 1: netem delay 10ms 2ms > > Result: ... > (rnd % (2 * sigma)) - sigma was overflowing s32. After applying the

Re: [vhost:vhost 19/20] Warning: arch/x86/tools/test_get_len found difference at :ffffffff811aa5f0

On Wed, Feb 07, 2018 at 03:02:57PM +0800, kbuild test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost > head: 96bcd04462b99e2c80e09f6537770a0ca6b288d0 > commit: cc1d1dc07885803981520a5303ef5b130f2ca2e8 [19/20] mm: support > reporting free page blocks >

Re: [PATCH iproute2-next v2 0/6] ip: Use netlink to walk through network device list

On 2/6/18 11:30 PM, Serhey Popovych wrote: > In this seris I replace /proc/net/dev and /sys/class/net usage for walk > through network device list in iptunnel/ip6tunnel and iptuntap with > netlink dump. > > Following changed since RFC was sent: > > 1) Treat @struct rtnl_link_stats and @struct

[PATCH] net: Whitelist the skbuff_head_cache "cb" field

Most callers of put_cmsg() use a "sizeof(foo)" for the length argument. Within put_cmsg(), a copy_to_user() call is made with a dynamic size, as a result of the cmsg header calculations. This means that hardened usercopy will examine the copy, even though it was technically a fixed size and should

Re: [PATCH net-next] sun: Add SPDX license tags to Sun network drivers

From: Shannon Nelson Date: Tue, 6 Feb 2018 11:34:23 -0800 > Add the appropriate SPDX license tags to the Sun network drivers > as outlined in Documentation/process/license-rules.rst. > > Signed-off-by: Shannon Nelson I've decided to apply

Re: [suricata PATCH 1/3] suricata/ebpf: take clang -target bpf include issue of stdint.h into account

Hi, On Wed, 2018-02-07 at 23:21 +0100, Jesper Dangaard Brouer wrote: > From: Jesper Dangaard Brouer > > This patch prepares code before enabling the clang -target bpf. > > The clang compiler does not like #include when > using '-target bpf' it will fail with: > >

[PATCH iproute2-next 1/3] iproute: whitespace fixes

Add whitespace around operators for consistency. Use tabs for indentation. Signed-off-by: Stephen Hemminger --- ip/iproute.c | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/ip/iproute.c b/ip/iproute.c index

[PATCH iproute2-next 3/3] iproute: make flush a separate function

Minor refactoring to move flush into separate function to improve readability and reduce depth of nesting. Signed-off-by: Stephen Hemminger --- ip/iproute.c | 121 +++ 1 file changed, 64 insertions(+), 57

[PATCH iproute2-next 2/3] iproute: don't do assignment in condition

Fix checkpatch complaints about assignment in conditions. Signed-off-by: Stephen Hemminger --- ip/iproute.c | 25 - 1 file changed, 16 insertions(+), 9 deletions(-) diff --git a/ip/iproute.c b/ip/iproute.c index e9c4093fa3eb..22ed113e890a

Re: [kbuild-all] [vhost:vhost 19/20] Warning: arch/x86/tools/test_get_len found difference at :ffffffff811aa5f0

On 02/08/2018 01:20 AM, Philip Li wrote: > On Thu, Feb 08, 2018 at 02:09:41AM +0200, Michael S. Tsirkin wrote: >> On Wed, Feb 07, 2018 at 03:02:57PM +0800, kbuild test robot wrote: >>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost >>> head:

[PATCH iproute2-next 0/3] route code cleanups

Make code in iproute conform more to current coding style conventions. Also split flush out into separate function. Stephen Hemminger (3): iproute: whitespace fixes iproute: don't do assignment in condition iproute: make flush a separate function ip/iproute.c | 165

Re: [kbuild-all] [vhost:vhost 19/20] Warning: arch/x86/tools/test_get_len found difference at :ffffffff811aa5f0

On 02/08/2018 01:37 AM, Philip Li wrote: > On Thu, Feb 08, 2018 at 01:25:39AM +0100, Daniel Borkmann wrote: >> On 02/08/2018 01:20 AM, Philip Li wrote: >>> On Thu, Feb 08, 2018 at 02:09:41AM +0200, Michael S. Tsirkin wrote: On Wed, Feb 07, 2018 at 03:02:57PM +0800, kbuild test robot wrote:

Re: [PATCH] net: ethernet: ti: cpsw: fix net watchdog timeout

From: Grygorii Strashko Date: Tue, 6 Feb 2018 19:17:06 -0600 > It was discovered that simple program which indefinitely sends 200b UDP > packets and runs on TI AM574x SoC (SMP) under RT Kernel triggers network > watchdog timeout in TI CPSW driver (<6 hours run). The

Re: [PATCH v2] selftests: bpf: test_kmod.sh: check the module path before insmod

On 02/07/2018 07:15 PM, Naresh Kamboju wrote: > test_kmod.sh reported false failure when module not present. > Check test_bpf.ko is present in the path before loading it. > > Two cases to be addressed here, > In the development process of test_bpf.c unit testing will be done by > developers by

Re: [PATCH net] rxrpc: Fix received abort handling

From: David Howells Date: Tue, 06 Feb 2018 16:44:12 + > AF_RXRPC is incorrectly sending back to the server any abort it receives > for a client connection. This is due to the final-ACK offload to the > connection event processor patch. The abort code is copied into the

Re: [PATCH v1 1/1] spi_ks8995: use regmap to access chip registers.

From: Sven Van Asbroeck Date: Tue, 6 Feb 2018 10:13:56 -0500 > The register map layouts used in this driver are well suited to > being accessed through a regmap. This makes the driver simpler > and shorter, by eliminating some spi boilerplate code. > > Testing: > - tested on a

Re: [kbuild-all] [vhost:vhost 19/20] Warning: arch/x86/tools/test_get_len found difference at :ffffffff811aa5f0

On Thu, Feb 08, 2018 at 02:09:41AM +0200, Michael S. Tsirkin wrote: > On Wed, Feb 07, 2018 at 03:02:57PM +0800, kbuild test robot wrote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost > > head: 96bcd04462b99e2c80e09f6537770a0ca6b288d0 > > commit:

Re: [PATCH iproute2-next 0/9] print refactoring

On 2/7/18 10:10 AM, Stephen Hemminger wrote: > This patch set breaks up the big print_route function into > smaller pieces for readability and to make later changes > to support JSON and color output easier. > > Stephen Hemminger (9): > iproute: refactor printing flags > iproute: make

Re: [PATCH iproute2-next 0/3] route code cleanups

On 2/7/18 5:25 PM, Stephen Hemminger wrote: > Make code in iproute conform more to current coding style > conventions. Also split flush out into separate function. > > Stephen Hemminger (3): > iproute: whitespace fixes > iproute: don't do assignment in condition > iproute: make flush a

Re: [PATCH] cxgb4: Fix error handling path in 'init_one()'

From: Christophe JAILLET Date: Tue, 6 Feb 2018 21:17:17 +0100 > Commit baf5086840ab1 ("cxgb4: restructure VF mgmt code") has reordered > some code but an error handling label has not been updated accordingly. > So fix it and free 'adapter' if 't4_wait_dev_ready()'

Re: [PATCH net] net/ipv6: onlink nexthop checks should default to main table

From: David Ahern Date: Tue, 6 Feb 2018 13:17:06 -0800 > Because of differences in how ipv4 and ipv6 handle fib lookups, > verification of nexthops with onlink flag need to default to the main > table rather than the local table used by IPv4. As it stands an > address within

Re: [PATCH net] net/ipv6: Handle reject routes with onlink flag

From: David Ahern Date: Tue, 6 Feb 2018 12:14:12 -0800 > Verification of nexthops with onlink flag need to handle unreachable > routes. The lookup is only intended to validate the gateway address > is not a local address and if the gateway resolves the egress device > must

Re: [PATCH] rtlwifi: rtl8192cu: Remove variable self-assignment in rf.c

El Wed, Feb 07, 2018 at 02:35:59PM -0600 Larry Finger ha dit: > On 02/07/2018 02:26 PM, Matthias Kaehlcke wrote: > > In _rtl92c_get_txpower_writeval_by_regulatory() the variable writeVal > > is assigned to itself in an if ... else statement, apparently only to > > document that the branch

Re: [RFC PATCH 00/24] Introducing AF_XDP support

2018-02-07 18:59 GMT+01:00 Tom Herbert : > On Wed, Jan 31, 2018 at 5:53 AM, Björn Töpel wrote: [...] >> >> Below are the results in Mpps of the I40E NIC benchmark runs for 64 >> byte packets, generated by commercial packet generator HW that is >>

[suricata PATCH 1/3] suricata/ebpf: take clang -target bpf include issue of stdint.h into account

From: Jesper Dangaard Brouer This patch prepares code before enabling the clang -target bpf. The clang compiler does not like #include when using '-target bpf' it will fail with: fatal error: 'gnu/stubs-32.h' file not found This is because using clang -target bpf,

Re: [PATCH net v2] net: phy: fix phy_start to consider PHY_IGNORE_INTERRUPT

On 02/07/2018 11:44 AM, Heiner Kallweit wrote: > This condition wasn't adjusted when PHY_IGNORE_INTERRUPT (-2) was added > long ago. In case of PHY_IGNORE_INTERRUPT the MAC interrupt indicates > also PHY state changes and we should do what the symbol says. > > Signed-off-by: Heiner Kallweit

Re: [PATCH] net: ethernet: ti: cpsw: fix net watchdog timeout

On Wed, Feb 07, 2018 at 12:19:11PM -0600, Grygorii Strashko wrote: On 02/07/2018 07:31 AM, Ivan Khoronzhuk wrote: On Wed, Feb 07, 2018 at 05:03:19AM +0200, Ivan Khoronzhuk wrote: On Tue, Feb 06, 2018 at 07:17:06PM -0600, Grygorii Strashko wrote: It was discovered that simple program which

Re: Fwd: u32 ht filters

On Tue, Feb 6, 2018 at 11:01 PM, Jiri Pirko wrote: > Wed, Feb 07, 2018 at 06:09:15AM CET, xiyou.wangc...@gmail.com wrote: >>Hi, Jiri >> >>Your commit 7fa9d974f3c2a016b9accb18f4ee2ed2a738585c >>breaks the tc script by Paweł. Please find below for details. > > Did you do the

Re: [PATCH] net: ethernet: ti: cpsw: fix net watchdog timeout

Rechecked once again, seems it covers every case, at this moment, so Reviewed-by: Ivan Khoronzhuk -- Regards, Ivan Khoronzhuk

Re: handling of phy_stop() and phy_stop_machine() in phylib

On Wed, Feb 07, 2018 at 09:56:37PM +0100, Heiner Kallweit wrote: > Am 04.02.2018 um 03:48 schrieb Florian Fainelli: > > > > > > On 02/03/2018 03:58 PM, Heiner Kallweit wrote: > >> Am 03.02.2018 um 21:17 schrieb Andrew Lunn: > >>> On Sat, Feb 03, 2018 at 05:41:54PM +0100, Heiner Kallweit wrote: >

Re: [suricata PATCH 0/3] Suricata cleanup makefile

Hello Jesper, On Wed, 2018-02-07 at 23:21 +0100, Jesper Dangaard Brouer wrote: > Hi Eric, > > I've improved the Suricata ebpf makefile, in-order to avoid > generating > the .eh_frame sections. This required changing the code a bit, to > allow using clang -target bpf. > > The makefile have also

Re: handling of phy_stop() and phy_stop_machine() in phylib

Am 04.02.2018 um 03:48 schrieb Florian Fainelli: > > > On 02/03/2018 03:58 PM, Heiner Kallweit wrote: >> Am 03.02.2018 um 21:17 schrieb Andrew Lunn: >>> On Sat, Feb 03, 2018 at 05:41:54PM +0100, Heiner Kallweit wrote: This commit forces callers of phy_resume() and phy_suspend() to hold

Re: [RFC PATCH 00/24] Introducing AF_XDP support

2018-02-07 16:54 GMT+01:00 Willem de Bruijn : >> We realized, a bit late maybe, that 24 patches is a bit mouthful, so >> let me try to make it more palatable. > > Overall, this approach looks great to me. > Yay! :-) > The patch set incorporates all the feedback

[suricata PATCH 0/3] Suricata cleanup makefile

Hi Eric, I've improved the Suricata ebpf makefile, in-order to avoid generating the .eh_frame sections. This required changing the code a bit, to allow using clang -target bpf. The makefile have also been improved to stop on clang compile errors, instead of generating an almost empty BPF ELF

[suricata PATCH 2/3] suricata/ebpf: compile with clang -target bpf

From: Jesper Dangaard Brouer Enable compiling eBPF programs with clang -target bpf. This is mostly to workaround a bug in libbpf, where clang > ver 4.0.0 generates some ELF sections (.eh_frame) when -target bpf is NOT specified, and libbpf fails loading such files.

[suricata PATCH 3/3] suricata/ebpf: improving the ebpf makefile

From: Jesper Dangaard Brouer The current ebpf/Makefile.am have the problem that clang compile errors still result in an ELF .bpf output file. This is obviously problematic as the the problem is first seen runtime when loading the bpf-prog. This this is cause by the

Re: handling of phy_stop() and phy_stop_machine() in phylib

On 02/07/2018 01:13 PM, Russell King - ARM Linux wrote: > On Wed, Feb 07, 2018 at 09:56:37PM +0100, Heiner Kallweit wrote: >> Am 04.02.2018 um 03:48 schrieb Florian Fainelli: >>> >>> >>> On 02/03/2018 03:58 PM, Heiner Kallweit wrote: Am 03.02.2018 um 21:17 schrieb Andrew Lunn: > On Sat,

[PATCH] rtlwifi: rtl8192cu: Remove variable self-assignment in rf.c

In _rtl92c_get_txpower_writeval_by_regulatory() the variable writeVal is assigned to itself in an if ... else statement, apparently only to document that the branch condition is handled and that a previously read value should be returned unmodified. The self-assignment causes clang to raise the

Re: [RFC PATCH 05/24] bpf: added bpf_xdpsk_redirect

2018-02-05 14:42 GMT+01:00 Jesper Dangaard Brouer : > On Wed, 31 Jan 2018 14:53:37 +0100 Björn Töpel wrote: > >> The bpf_xdpsk_redirect call redirects the XDP context to the XDP >> socket bound to the receiving queue (if any). > > As I explained in-person

Re: [RFC PATCH 02/24] xsk: add user memory registration sockopt

2018-02-07 17:00 GMT+01:00 Willem de Bruijn : > On Wed, Jan 31, 2018 at 8:53 AM, Björn Töpel wrote: >> From: Björn Töpel >> >> The XDP_MEM_REG socket option allows a process to register a window of >> user space

Re: [PATCH] rtlwifi: rtl8192cu: Remove variable self-assignment in rf.c

On 02/07/2018 02:26 PM, Matthias Kaehlcke wrote: In _rtl92c_get_txpower_writeval_by_regulatory() the variable writeVal is assigned to itself in an if ... else statement, apparently only to document that the branch condition is handled and that a previously read value should be returned

[PATCH net V3 2/2] ptr_ring: fail on large queue size (>64K)

We need limit the maximum size of queue, otherwise it may cause several side effects e.g slab will warn when the size exceeds KMALLOC_MAX_SIZE. Using KMALLOC_MAX_SIZE still looks too so this patch tries to limit it to 64K. This value could be revisited if we found a real case that needs more.

[PATCH net V3 1/2] ptr_ring: try vmalloc() when kmalloc() fails

This patch switch to use kvmalloc_array() for using a vmalloc() fallback to help in case kmalloc() fails. Reported-by: syzbot+e4d4f9ddd42955397...@syzkaller.appspotmail.com Fixes: 2e0ab8ca83c12 ("ptr_ring: array based FIFO for pointers") Signed-off-by: Jason Wang ---

[PATCH bpf 2/6] libbpf: complete list of strings for guessing program type

From: Quentin Monnet It seems that the type guessing feature for libbpf, based on the name of the ELF section the program is located in, was inspired from samples/bpf/prog_load.c, which was not used by any sample for loading programs of certain types such as TC

[PATCH bpf 6/6] tools: bpftool: add bash completion for cgroup commands

From: Quentin Monnet Add bash completion for "bpftool cgroup" command family. While at it, also fix the formatting of some keywords in the man page for cgroups. Fixes: 5ccda64d38cc ("bpftool: implement cgroup bpf operations") Signed-off-by: Quentin Monnet

[PATCH bpf 3/6] tools: bpftool: exit doc Makefile early if rst2man is not available

From: Quentin Monnet If rst2man is not available on the system, running `make doc` from the bpftool directory fails with an error message. However, it creates empty manual pages (.8 files in this case). A subsequent call to `make doc-install` would then succeed and

[PATCH bpf 5/6] tools: bpftool: add bash completion for `bpftool prog load`

From: Quentin Monnet Add bash completion for bpftool command `prog load`. Completion for this command is easy, as it only takes existing file paths as arguments. Fixes: 49a086c201a9 ("bpftool: implement prog load command") Signed-off-by: Quentin Monnet

[PATCH bpf 4/6] tools: bpftool: make syntax for program map update explicit in man page

From: Quentin Monnet Specify in the documentation that when using bpftool to update a map of type BPF_MAP_TYPE_PROG_ARRAY, the syntax for the program used as a value should use the "id|tag|pinned" keywords convention, as used with "bpftool prog" commands. Fixes:

[PATCH bpf 1/6] nfp: bpf: fix immed relocation for larger offsets

Immed relocation is missing a shift which means for larger offsets the lower and higher part of the address would be ORed together. Fixes: ce4ebfd859c3 ("nfp: bpf: add helpers for updating immediate instructions") Signed-off-by: Jakub Kicinski Reviewed-by: Jiong

[PATCH net-queue 3/3] e1000e: Avoid missed interrupts following ICR read.

The 82574 specification update errata 12 states that interrupts may be missed if ICR is read while INT_ASSERTED is not set. Avoid that problem by setting all bits related to events that can trigger the Other interrupt in IMS. The Other interrupt is raised for such events regardless of whether or

[PATCH net-queue 1/3] Partial revert "e1000e: Avoid receiver overrun interrupt bursts"

This partially reverts commit 4aea7a5c5e940c1723add439f4088844cd26196d. We keep the fix for the first part of the problem (1) described in the log of that commit, that is to read ICR in the other interrupt handler. We remove the fix for the second part of the problem (2), Other interrupt

[PATCH v2 1/2] net, can, ifi: fix "write buffer full" error

the driver reads in the ISR first the IRQpending register, and clears after that in a write *all* bits in it. It could happen that the isr register raise bits between this 2 register accesses, which leads in lost bits ... In case it clears "TX message sent successfully", the driver never sends

[PATCH v2 2/2] net, can, ifi: loopback Tx message in IFI block

Current ifi driver reads first Rx messages, than loopback the Tx message, if the IFI_CANFD_INTERRUPT_TXFIFO_REMOVE bit is set. This can lead into the case, that Rx messages overhelm Tx messages! Fixed this in the following way: Set in the IFI_CANFD_TXFIFO_DLC register the FN value to 1, so the

[PATCH net-queue 2/3] e1000e: Fix queue interrupt re-raising in Other interrupt.

restores the ICS write for rx/tx queue interrupts which was present before commit 16ecba59bc33 ("e1000e: Do not read ICR in Other interrupt", v4.5-rc1) but was not restored in commit 4aea7a5c5e94 ("e1000e: Avoid receiver overrun interrupt bursts", v4.15-rc1). This re-raises the queue interrupts

Re: Fwd: u32 ht filters

Thu, Feb 08, 2018 at 12:08:36AM CET, xiyou.wangc...@gmail.com wrote: >On Tue, Feb 6, 2018 at 11:01 PM, Jiri Pirko wrote: >> Wed, Feb 07, 2018 at 06:09:15AM CET, xiyou.wangc...@gmail.com wrote: >>>Hi, Jiri >>> >>>Your commit 7fa9d974f3c2a016b9accb18f4ee2ed2a738585c >>>breaks the

[PATCH net V2 1/2] ptr_ring: try vmalloc() when kmalloc() fails

This patch switch to use kvmalloc_array() for using a vmalloc() fallback to help in case kmalloc() fails. Reported-by: syzbot+e4d4f9ddd42955397...@syzkaller.appspotmail.com Fixes: 2e0ab8ca83c12 ("ptr_ring: array based FIFO for pointers") Signed-off-by: Jason Wang ---

Re: [PATCH net V3 1/2] ptr_ring: try vmalloc() when kmalloc() fails

On Thu, Feb 08, 2018 at 11:59:24AM +0800, Jason Wang wrote: > This patch switch to use kvmalloc_array() for using a vmalloc() > fallback to help in case kmalloc() fails. > > Reported-by: syzbot+e4d4f9ddd42955397...@syzkaller.appspotmail.com > Fixes: 2e0ab8ca83c12 ("ptr_ring: array based FIFO for

[PATCH net 5/5] nfp: populate MODULE_VERSION

DKMS and similar out-of-tree module replacement services use module version to make sure the out-of-tree software is not older than the module shipped with the kernel. We use the kernel version in ethtool -i output, put it into MODULE_VERSION as well. Reported-by: Jan Gutter

[PATCH net 1/5] nfp: bpf: require ETH table

Upcoming changes will require all netdevs supporting TC offloads to have a full struct nfp_port. Require those for BPF offload. The operation without management FW reporting information about Ethernet ports is something we only support for very old and very basic NIC firmwares anyway.

[PATCH net 3/5] nfp: forbid disabling hw-tc-offload on representors while offload active

All netdevs which can accept TC offloads must implement .ndo_set_features(). nfp_reprs currently do not do that, which means hw-tc-offload can be turned on and off even when offloads are active. Whether the offloads are active is really a question to nfp_ports, so remove the per-app tc_busy

[PATCH net 2/5] nfp: don't advertise hw-tc-offload on non-port netdevs

nfp_port is a structure which represents an ASIC port, both PCIe vNIC (on a PF or a VF) or the external MAC port. vNIC netdev (struct nfp_net) and pure representor netdev (struct nfp_repr) both have a pointer to this structure. nfp_reprs always have a port associated. nfp_nets, however, only

[PATCH net 4/5] nfp: limit the number of TSO segments

Most FWs limit the number of TSO segments a frame can produce to 64. This is for fairness and efficiency (of FW datapath) reasons. If a frame with larger number of segments is submitted the FW will drop it. Signed-off-by: Jakub Kicinski ---

[PATCH net 0/5] nfp: fix disabling TC offloads in flower, max TSO segs and module version

Hi! This set corrects the way nfp deals with the NETIF_F_HW_TC flag. It has slipped the review that flower offload does not currently refuse disabling this flag when filter offload is active. nfp's flower offload does not actually keep track of how many filters for each port are offloaded. The

[Patch net] ipt_CLUSTERIP: fix a refcount bug in clusterip_config_find_get()

In clusterip_config_find_get() we hold RCU read lock so it could run concurrently with clusterip_config_entry_put(), as a result, the refcnt could go back to 1 from 0, which leads to a double list_del()... Just replace refcount_inc() with refcount_inc_not_zero(), as for c->refcount. Fixes:

[Patch net] ipt_CLUSTERIP: fix a race condition of proc file creation

There is a race condition between clusterip_config_entry_put() and clusterip_config_init(), after we release the spinlock in clusterip_config_entry_put(), a new proc file with a same IP could be created immediately since it is already removed from the configs list, therefore it triggers this

Re: [PATCH net V3 2/2] ptr_ring: fail on large queue size (>64K)

On 2018年02月08日 12:52, Michael S. Tsirkin wrote: On Thu, Feb 08, 2018 at 11:59:25AM +0800, Jason Wang wrote: We need limit the maximum size of queue, otherwise it may cause several side effects e.g slab will warn when the size exceeds KMALLOC_MAX_SIZE. Using KMALLOC_MAX_SIZE still looks too so

linux-next: Signed-off-by missing for commit in the net tree

Hi all, Commit 043e337f555e ("sch_netem: Bug fixing in calculating Netem interval") is missing a Signed-off-by from its author. -- Cheers, Stephen Rothwell

Re: [PATCH net V2 1/2] ptr_ring: try vmalloc() when kmalloc() fails

On 2018年02月08日 11:21, Jason Wang wrote: This patch switch to use kvmalloc_array() for using a vmalloc() fallback to help in case kmalloc() fails. Reported-by: syzbot+e4d4f9ddd42955397...@syzkaller.appspotmail.com Fixes: 2e0ab8ca83c12 ("ptr_ring: array based FIFO for pointers") Signed-off-by:

[PATCH bpf 0/6] nfp fix for calls, bpftool completions and doc fixes

Hi! First patch in this series fixes applying the relocation to immediate load instructions in the NFP JIT. The remaining patches come from Quentin. Small addition to libbpf makes sure it recognizes all standard section names. Makefile in bpftool/Documentation is improved to explicitly check

[PATCH] ath9k: turn on btcoex_enable as default

Without btcoex_enable, WiFi activies make both WiFi and Bluetooth unstable if there's a bluetooth connection. Enable this option when bt_ant_diversity is disabled. BugLink: https://bugs.launchpad.net/bugs/1746164 Signed-off-by: Kai-Heng Feng ---

[PATCH net V2 2/2] ptr_ring: fail on large queue size (>64K)

We need limit the maximum size of queue, otherwise it may cause several side effects e.g slab will warn when the size exceeds KMALLOC_MAX_SIZE. Using KMALLOC_MAX_SIZE still looks too so this patch tries to limit it to 64K. This value could be revisited if we found a real case that needs more.

Re: [PATCH 3/3] Revert "e1000e: Do not read ICR in Other interrupt"

On 2018/01/29 09:22, Alexander Duyck wrote: [...] > > > Consequently, we must clear OTHER manually from ICR, otherwise the > > interrupt is immediately re-raised after exiting the handler. > > > > These observations are the same whether the interrupt is triggered via a > > write to ICS or in

[PATCH] mpls, nospec: Sanitize array index in mpls_label_ok()

mpls_label_ok() validates that the 'platform_label' array index from a userspace netlink message payload is valid. Under speculation the mpls_label_ok() result may not resolve in the CPU pipeline until after the index is used to access an array element. Sanitize the index to zero to prevent

Re: [PATCH net V3 2/2] ptr_ring: fail on large queue size (>64K)

On Thu, Feb 08, 2018 at 11:59:25AM +0800, Jason Wang wrote: > We need limit the maximum size of queue, otherwise it may cause > several side effects e.g slab will warn when the size exceeds > KMALLOC_MAX_SIZE. Using KMALLOC_MAX_SIZE still looks too so this patch > tries to limit it to 64K. This

Re: [PATCH net v2] net: phy: fix phy_start to consider PHY_IGNORE_INTERRUPT

Am 08.02.2018 um 00:00 schrieb Florian Fainelli: > On 02/07/2018 11:44 AM, Heiner Kallweit wrote: >> This condition wasn't adjusted when PHY_IGNORE_INTERRUPT (-2) was added >> long ago. In case of PHY_IGNORE_INTERRUPT the MAC interrupt indicates >> also PHY state changes and we should do what the

  1   2   >