ipsec through openvpn broken

2018-02-11 Thread Artem Savkov
Hi Yossi, Steffen, I am using ipsec throug openvpn on one of my machines and it stopped working since 4.15. Bisection showed that the culprit is: 5efec5c655dd xfrm: Fix eth_hdr(skb)->h_proto to reflect inner IP version Reverting the patch does fix it for me. I am seing h_proto being changed

[no subject]

2018-02-11 Thread Alfred Cheuk Chow
Good Day, I am Mr. Alfred Cheuk Yu Chow, the Director for Credit & Marketing Chong Hing Bank, Hong Kong, Chong Hing Bank Center, 24 Des Voeux Road Central, Hong Kong. I have a business proposal of $ 38,980,369.00. All confirmable documents to back up the claims will be made available to you

[PATCH] rtl_bt: Add firmware and configuration files for the Bluetooth parts of RTL8821C and RTL8723D

2018-02-11 Thread Larry Finger
These devices are new models from Realtek. Updates to driver btrtl will soon be submitted to the kernel. These files were provided by the Realtek developer. Signed-off-by: 陆朱伟 Signed-off-by: Larry Finger --- WHENCE | 5

Re: xfrm, ip tunnel: non released device reference upon device unregistration

2018-02-11 Thread Florian Westphal
Eyal Birger wrote: Sorry for taking so long to respond. > On Tue, 6 Feb 2018 14:15:09 +0100 > Florian Westphal wrote: > > > Steffen Klassert wrote: > > > I gave the patch a quick try, but still I get this: > > > > > >

[PATCH iproute2-next v2 0/4] ip/tunnel: Unify local/remote endpoint address parsing

2018-02-11 Thread Serhey Popovych
Use get_addr_rta() helper to unify address retriveal from netlink message when configuring tunnel and get_addr() to parse endpoint address into @inet_prefix. This is next step towards ip and ipv6 tunnel module merge: endpoint address parsing code will differ only in @family constant being passed

RE: ipsec through openvpn broken

2018-02-11 Thread Yossi Kuperman
> -Original Message- > From: Artem Savkov [mailto:artem.sav...@gmail.com] > Sent: Sunday, February 11, 2018 10:34 AM > To: Yossi Kuperman ; Steffen Klassert > > Cc: netdev@vger.kernel.org > Subject: ipsec through openvpn broken > > Hi

[PATCH iproute2-next v2 2/4] vti/vti6: Unify local/remote endpoint address parsing

2018-02-11 Thread Serhey Popovych
We are going to merge link_vti.c and link_vti6.c and this is final step to make their diffs clear and show what needs to be changed during merge. Note that it is safe to omit endpoint address(es) from netlink create request as kernel is aware of such case and will use zero for that endpoint(s).

[PATCH iproute2-next v2 3/4] gre/gre6: Unify local/remote endpoint address parsing

2018-02-11 Thread Serhey Popovych
We are going to merge link_gre.c and link_gre6.c and this is final step to make their diffs clear and show what needs to be changed during merge. Note that it is safe to omit endpoint address(es) from netlink create request as kernel is aware of such case and will use zero for that endpoint(s).

[PATCH iproute2-next v2 4/4] iptnl/ip6tnl: Unify local/remote endpoint and 6rd address parsing

2018-02-11 Thread Serhey Popovych
We are going to merge link_iptnl.c and link_ip6tnl.c and this is final step to make their diffs clear and show what needs to be changed during merge. Note that it is safe to omit endpoint address(es) from netlink create request as kernel is aware of such case and will use zero for that

[PATCH iproute2-next v2 1/4] utils: Introduce and use inet_prefix_reset_flags()

2018-02-11 Thread Serhey Popovych
Initializing @inet_prefix using C initializers or memset() seems inefficient and unnecessary: only small part of ->data[] field will be used to store address corresponding to ->family. Instead initialize ->flags with zero and assume no other fields accessed before checking corresponding bits in

Re: [PATCH net] ptr_ring: prevent integer overflow when calculating size

2018-02-11 Thread Michael S. Tsirkin
On Sun, Feb 11, 2018 at 11:28:12AM +0800, Jason Wang wrote: > Switch to use dividing to prevent integer overflow when size is too > big to calculate allocation size properly. > > Reported-by: Eric Biggers > Fixes: 6e6e41c31122 ("ptr_ring: fail early if queue occupies more

[PATCH net-next] trace_events_filter: conditional trace event (tcp_probe full=0)

2018-02-11 Thread Md. Islam
Recently tcp_probe kernel module has been replaced by trace_event. Old tcp_probe had full=0 option where it only takes a snapshot only when congestion window is changed. However I did not find such functionality in trace_event. This is why I implemented this "conditional trace_event" where a

Re: tg3 crashes under high load, when using 100Mbits

2018-02-11 Thread Siva Reddy Kallam
On Fri, Feb 9, 2018 at 10:41 AM, Kai Heng Feng wrote: > Hi Broadcom folks, > > We are now enabling a new platform with tg3 nic, unfortunately we observed > the bug [1] that dated back to 2015. > I tried commit 4419bb1cedcd ("tg3: Add workaround to restrict 5762 MRRS

[PATCH RFC net-next 3/4] ipv4: route: dissect flow in input path if fib rules need it

2018-02-11 Thread Roopa Prabhu
From: Roopa Prabhu Dissect flow in fwd path if fib rules require it. Controlled by a flag to avoid penatly for the common case. Flag is set when fib rules with sport, dport and proto match that require flow dissect are installed. Also passes the dissected hash keys to

[PATCH RFC net-next 1/4] ipv4: fib_rules: support match on sport, dport and ip proto

2018-02-11 Thread Roopa Prabhu
From: Roopa Prabhu Add support to match on src port, dst port and ip protocol. Signed-off-by: Roopa Prabhu --- include/uapi/linux/fib_rules.h | 3 +++ net/ipv4/fib_rules.c | 46 -- 2 files

[PATCH RFC net-next 0/4] fib_rules: support sport, dport and proto match

2018-02-11 Thread Roopa Prabhu
From: Roopa Prabhu This series extends fib rule match support to include sport, dport and ip proto match (to complete the 5-tuple match support). Common use-cases of Policy based routing in the data center require 5-tuple match. The last 2 patches in the series add a

[PATCH RFC net-next 4/4] ipv6: route: dissect flow in input path if fib rules need it

2018-02-11 Thread Roopa Prabhu
From: Roopa Prabhu Dissect flow in fwd path if fib rules require it. Controlled by a flag to avoid penatly for the common case. Flag is set when fib rules with sport, dport and proto match that require flow dissect are installed. Also passes the dissected hash keys to

[PATCH RFC net-next 2/4] ipv6: fib6_rules: support for match on sport, dport and ip proto

2018-02-11 Thread Roopa Prabhu
From: Roopa Prabhu Add support to match on src port, dst port and ip protocol. Signed-off-by: Roopa Prabhu --- net/ipv6/fib6_rules.c | 49 ++--- 1 file changed, 46 insertions(+), 3 deletions(-)

Re: [PATCH iproute2-next v2 1/4] utils: Introduce and use inet_prefix_reset_flags()

2018-02-11 Thread David Ahern
On 2/11/18 4:48 PM, Stephen Hemminger wrote: > On Sun, 11 Feb 2018 22:02:30 +0200 > Serhey Popovych wrote: > >> +static inline void inet_prefix_reset_flags(inet_prefix *p) >> +{ >> +p->flags = 0; >> +} > > Just do it. > > Wrapper adds nothing here. > I asked for

[PATCH] mvpp2: fix multicast address filter

2018-02-11 Thread Mikulas Patocka
IPv6 doesn't work on the MacchiatoBIN board. It is caused by broken multicast address filter in the mvpp2 driver. The driver loads doesn't load any multicast entries if "allmulti" is not set. This condition should be reversed. The condition !netdev_mc_empty(dev) is useless (because

Re: [PATCH iproute2-next v2 1/4] utils: Introduce and use inet_prefix_reset_flags()

2018-02-11 Thread Stephen Hemminger
On Sun, 11 Feb 2018 22:02:30 +0200 Serhey Popovych wrote: > +static inline void inet_prefix_reset_flags(inet_prefix *p) > +{ > + p->flags = 0; > +} Just do it. Wrapper adds nothing here.

Re: [PATCH RFC net-next 4/4] ipv6: route: dissect flow in input path if fib rules need it

2018-02-11 Thread Ido Schimmel
On Sun, Feb 11, 2018 at 02:26:29PM -0800, Roopa Prabhu wrote: > From: Roopa Prabhu > > Dissect flow in fwd path if fib rules require it. Controlled by > a flag to avoid penatly for the common case. Flag is set when fib > rules with sport, dport and proto match that

[PATCH] headers: untangle kmemleak.h from mm.h

2018-02-11 Thread Randy Dunlap
From: Randy Dunlap Currently #includes for no obvious reason. It looks like it's only a convenience, so remove kmemleak.h from slab.h and add to any users of kmemleak_* that don't already #include it. Also remove from source files that do not use it. This is tested on

Re: [PATCH] headers: untangle kmemleak.h from mm.h

2018-02-11 Thread Ingo Molnar
* Randy Dunlap wrote: > From: Randy Dunlap > > Currently #includes for no obvious > reason. It looks like it's only a convenience, so remove kmemleak.h > from slab.h and add to any users of kmemleak_* > that don't already #include it. > Also

[PATCH net v4 13/13] net/sonic: Replace custom debug logging with netif_* calls

2018-02-11 Thread Finn Thain
Eliminate duplicated debug code by moving it into the core driver. Don't log the only valid silicon revision number (it's in the source). Cc: Thomas Bogendoerfer Cc: Chris Zankel Tested-by: Stan Johnson Signed-off-by: Finn Thain

[PATCH net v4 11/13] net/macsonic: Convert to nubus_driver

2018-02-11 Thread Finn Thain
This resolves an old issue preventing any NuBus SONIC NICs from working in a Mac with an on-board SONIC device. Tested-by: Stan Johnson Signed-off-by: Finn Thain --- drivers/net/ethernet/natsemi/macsonic.c | 172 ++-- 1

[PATCH net v4 02/13] net/8390: Fix msg_enable patch snafu

2018-02-11 Thread Finn Thain
The lib8390 module parameter 'msg_enable' doesn't do anything useful: it causes an ancient version string to be logged. Remove redundant code that logs the same string. In ne.c and wd.c, the value of ei_local->msg_enable is used before being assigned. Use ne_msg_enable and wd_msg_enable,

[PATCH net v4 06/13] net/mac89x0: Convert to platform_driver

2018-02-11 Thread Finn Thain
Apparently these Dayna cards don't have a pseudoslot declaration ROM which means they can't be probed like NuBus cards. Cc: Geert Uytterhoeven Signed-off-by: Finn Thain --- arch/m68k/mac/config.c| 4 ++ drivers/net/Space.c

[PATCH net v4 05/13] net/mac89x0: Remove dead or unreachable code

2018-02-11 Thread Finn Thain
Signed-off-by: Finn Thain --- drivers/net/ethernet/cirrus/mac89x0.c | 32 1 file changed, 32 deletions(-) diff --git a/drivers/net/ethernet/cirrus/mac89x0.c b/drivers/net/ethernet/cirrus/mac89x0.c index 977d4c2c759d..4fe0ae93ab36

[PATCH net v4 04/13] net/macmace: Fix and clean up log messages

2018-02-11 Thread Finn Thain
Don't log the unexpanded "eth%d" format string. Log the chip revision in the probe message (consistent with mace.c). Drop redundant debug messages for FIFO events recorded in the interface statistics (also consistent with mace.c). Tested-by: Stan Johnson Signed-off-by: Finn

[PATCH net v4 03/13] net/smc9194: Remove bogus CONFIG_MAC reference

2018-02-11 Thread Finn Thain
AFAIK the only version of smc9194.c with Mac support is the one in the linux-mac68k CVS repo, which never made it to the mainline. Despite that, from v2.3.45, arch/m68k/config.in listed CONFIG_SMC9194 under CONFIG_MAC. This mistake got carried over into Kconfig in v2.5.55. (See pre-git era

Re: [PATCH] ath9k: turn on btcoex_enable as default

2018-02-11 Thread Kai Heng Feng
> On 10 Feb 2018, at 10:05 PM, Felix Fietkau wrote: > > On 2018-02-10 14:56, Kai Heng Feng wrote: >> >>> On 9 Feb 2018, at 3:16 PM, Kalle Valo wrote: >>> Sure, but we have to make sure that we don't create regressions on >>> existing systems. For example,

[PATCH net v4 01/13] net/8390: Remove redundant make dependencies

2018-02-11 Thread Finn Thain
The hydra, zorro8390 and mcf8390 drivers all #include "lib8390.c" and have no need for 8390.o. modinfo confirms no dependency on 8390.ko. Drop the redundant dependency from the Makefile. objdump confirms that this has no effect on the module binaries. Cc: Greg Ungerer Cc:

[PATCH net v4 07/13] net/mac89x0: Fix and modernize log messages

2018-02-11 Thread Finn Thain
Fix log message fragments that no longer produce the desired output since the behaviour of printk() was changed. Add missing printk severity levels. Drop deprecated "out of memory" message as per checkpatch advice. Signed-off-by: Finn Thain ---

[PATCH net v4 10/13] net/mac8390: Fix log messages

2018-02-11 Thread Finn Thain
Use dev_foo() to log the slot number instead of the unexpanded "eth%d" format string. Disambiguate the two identical "Card type %s is unsupported" messages. Tested-by: Stan Johnson Signed-off-by: Finn Thain --- drivers/net/ethernet/8390/mac8390.c

[PATCH net v4 12/13] net/sonic: Clean up and modernize log messages

2018-02-11 Thread Finn Thain
Add missing printk severity levels by adopting pr_foo() calls for the platform_driver and dev_foo() calls for the nubus_driver. Avoid KERN_CONT usage as per advice from checkpatch. Avoid #ifdef around printk calls. Don't log driver probe messages after calling register_netdev(). Cc: Thomas

[PATCH net v4 09/13] net/mac8390: Convert to nubus_driver

2018-02-11 Thread Finn Thain
This resolves an old bug that constrained this driver to no more than one card. Tested-by: Stan Johnson Signed-off-by: Finn Thain --- drivers/net/Space.c | 3 - drivers/net/ethernet/8390/mac8390.c | 138

[PATCH net v4 08/13] net/mac89x0: Replace custom debug logging with netif_* calls

2018-02-11 Thread Finn Thain
Adopt the conventional style of debug logging because it is both shorter and more flexible. Signed-off-by: Finn Thain --- drivers/net/ethernet/cirrus/mac89x0.c | 47 +++ 1 file changed, 15 insertions(+), 32 deletions(-) diff --git

[PATCH net v4 00/13] Fixes, cleanup and modernization for some legacy ethernet NIC drivers

2018-02-11 Thread Finn Thain
This patch series adds Driver Model support to Mac NIC drivers, fixes some bugs, removes some dead code and adopts netif_* calls to reduce code duplication. This series results in a reduction of about 100 lines of code. It has been tested on a variety of Macs, with coverage for the changes to

Re: [PATCH net] ptr_ring: prevent integer overflow when calculating size

2018-02-11 Thread David Miller
From: Jason Wang Date: Sun, 11 Feb 2018 11:28:12 +0800 > Switch to use dividing to prevent integer overflow when size is too > big to calculate allocation size properly. > > Reported-by: Eric Biggers > Fixes: 6e6e41c31122 ("ptr_ring: fail early if

Re: [PATCH] mvpp2: fix multicast address filter

2018-02-11 Thread David Miller
From: Mikulas Patocka Date: Sun, 11 Feb 2018 18:10:28 -0500 (EST) > IPv6 doesn't work on the MacchiatoBIN board. It is caused by broken > multicast address filter in the mvpp2 driver. > > The driver loads doesn't load any multicast entries if "allmulti" is not > set. This

Re: [PATCH net-next 07/16] l2tp: hide sessions if they are closing

2018-02-11 Thread kbuild test robot
Hi James, I love your patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/James-Chapman/l2tp-fix-API-races-discovered-by-syzbot/20180212-102613 config: i386-randconfig-x079-201806 (attached as .config) compiler: gcc-7