RE: [net-next 1/1] tipc: avoid unnecessary copying of bundled messages

> -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev- > ow...@vger.kernel.org] On Behalf Of David Miller > Sent: Wednesday, February 14, 2018 21:27 > To: Jon Maloy > Cc: netdev@vger.kernel.org; Mohan Krishna Ghanta Krishnamurthy >

Re: [PATCH net-next v2 04/16] l2tp: refactor tunnel lifetime handling wrt its socket

Hi James, I love your patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/James-Chapman/l2tp-fix-API-races-discovered-by-syzbot/20180215-060031 config: x86_64-rhel (attached as .config) compiler: gcc-7 (Debian 7.3.0-1

Re: Serious performance degradation in Linux 4.15

On Wed, Feb 14, 2018 at 10:46:20PM +, Matt Fleming wrote: > Here's some more numbers. This is with RETPOLINE=y but you'll see it > doesn't make much of a difference. Oh, this is also with powersave > cpufreq governor. Hurmph, I'll go have a look when I can boot tip/master again :/ But didn't

[PATCH net v2] fib_semantics: Don't match route with mismatching tclassid

In fib_nh_match(), if output interface or gateway are passed in the FIB configuration, we don't have to check next hops of multipath routes to conclude whether we have a match or not. However, we might still have routes with different realms matching the same output interface and gateway

Re: [PATCH bpf 0/2] tools: bpftool: minor fixes for JSON in batch mode

On 02/15/2018 07:42 AM, Jakub Kicinski wrote: > Quentin says: > > These are two minor fixes to avoid breaking JSON output in batch mode. The > first one makes bpftool output a "null" JSON object, as expected in batch > mode if nothing else is to be printed, when dumping program instructions >

pull request: bluetooth-next 2018-02-15

Hi Dave, Here's the first bluetooth-next pull request targetting the 4.17 kernel release. - Fixes & cleanups to Atheros and Marvell drivers - Support for two new Realtek controllers - Support for new Intel Bluetooth controller - Fix for supporting multiple slave-role Bluetooth LE connections

Re: [PATCH net-next 0/3] eBPF Seccomp filters

On Thu, Feb 15, 2018 at 1:30 PM, Alexei Starovoitov wrote: > Specifically for android we added bpf_lsm hooks, cookie/uid helpers, > and read-only maps. > Lorenzo, > there was a claim in this thread that bpf is disabled on android. > Can you please clarify ? It's not

Re: [RFC net PATCH] virtio_net: disable XDP_REDIRECT in receive_mergeable() case

On 2018年02月16日 06:43, Jesper Dangaard Brouer wrote: The virtio_net code have three different RX code-paths in receive_buf(). Two of these code paths can handle XDP, but one of them is broken for at least XDP_REDIRECT. Function(1): receive_big() does not support XDP. Function(2):

Re: [PATCH bpf] bpf: fix mlock precharge on arraymaps

On 2/15/18 4:10 PM, Daniel Borkmann wrote: syzkaller recently triggered OOM during percpu map allocation; while there is work in progress by Dennis Zhou to add __GFP_NORETRY semantics for percpu allocator under pressure, there seems also a missing bpf_map_precharge_memlock() check in array map

[PATCH net] tg3: APE heartbeat changes

From: Prashant Sreedharan In ungraceful host shutdown or driver crash case BMC connectivity is lost. APE firmware is missing the driver state in this case to keep the BMC connectivity alive. This patch has below change to address this issue. Heartbeat mechanism

Re: [RFC PATCH] net/ncsi: Add generic netlink family

On Thu, 2018-02-15 at 14:50 +1030, Joel Stanley wrote: > Hey Sam, > > On Thu, Feb 15, 2018 at 2:00 PM, Samuel Mendoza-Jonas > wrote: > > Add a generic netlink family for NCSI. This supports two commands; > > NCSI_CMD_PKG_INFO which returns information on packages and their

[PATCH net] tg3: APE heartbeat changes

From: Prashant Sreedharan In ungraceful host shutdown or driver crash case BMC connectivity is lost. APE firmware is missing the driver state in this case to keep the BMC connectivity alive. This patch has below change to address this issue. Heartbeat mechanism

[PATCH net-next 1/2] nfp: standardize FW header whitespace

From: Michael Rapson The nfp_net_ctrl.h file used spaces for indentation in the past but tabs have crept in. Host driver files use tabs for indentation by default, so let's convert to tabs for consistency across the file and our drivers. Signed-off-by: Michael

[PATCH net-next 2/2] nfp: flower: implement tcp flag match offload

From: Pieter Jansen van Vuuren Implement tcp flag match offloading. Current tcp flag match support include FIN, SYN, RST, PSH and URG flags, other flags are unsupported. The PSH and URG flags are only set in the hardware fast path when used in combination

[PATCH net-next 0/2] nfp: whitespace sync and flower TCP flags

Hi! Whitespace cleanup from Michael and flower offload support for matching on TCP flags from Pieter. Michael Rapson (1): nfp: standardize FW header whitespace Pieter Jansen van Vuuren (1): nfp: flower: implement tcp flag match offload drivers/net/ethernet/netronome/nfp/flower/cmsg.h |

Re: [PATCH net v4 02/13] net/8390: Fix msg_enable patch snafu

On Wed, 14 Feb 2018, David Miller wrote: > > Have you considered that implementing the ethtool hooks in the core > > driver might allow removal of all 8390 driver 'msg_enable' module > > parameters and msglevel ethtool hooks added by c45f812f0280, excepting > > those in the core driver? But

[PATCH net] tg3: APE heartbeat changes

From: Prashant Sreedharan In ungraceful host shutdown or driver crash case BMC connectivity is lost. APE firmware is missing the driver state in this case to keep the BMC connectivity alive. This patch has below change to address this issue. Heartbeat mechanism

[RFC PATCH] ptr_ring: linked list fallback

So pointer rings work fine, but they have a problem: make them too small and not enough entries fit. Make them too large and you start flushing your cache and running out of memory. This is a new idea of mine: a ring backed by a linked list. Once you run out of rin entries, instead of a drop you

Re: [vhost:vhost 24/24] drivers/firmware/qemu_fw_cfg.c:499:22: error: storage size of 'files' isn't known

Hi On Wed, Feb 14, 2018 at 9:27 PM, kbuild test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost > head: 5d457fe6aeaab9d0a1665eafc8af7139bc6b6f2e > commit: 5d457fe6aeaab9d0a1665eafc8af7139bc6b6f2e [24/24] fw_cfg: fix sparse >

Re: ppp/pppoe, still panic 4.15.3 in ppp_push

On 2018-02-14 19:25, Guillaume Nault wrote: On Wed, Feb 14, 2018 at 06:49:19PM +0200, Denys Fedoryshchenko wrote: On 2018-02-14 18:47, Guillaume Nault wrote: > On Wed, Feb 14, 2018 at 06:29:34PM +0200, Denys Fedoryshchenko wrote: > > On 2018-02-14 18:07, Guillaume Nault wrote: > > > On Wed, Feb

[RFC PATCH] chtls_netdev() can be static

Fixes: 5995a3b59239 ("Makefile Kconfig") Signed-off-by: Fengguang Wu --- chtls_main.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/crypto/chelsio/chtls/chtls_main.c b/drivers/crypto/chelsio/chtls/chtls_main.c index

[PATCH net] cxgb4: free up resources of pf 0-3

free pf 0-3 resources, commit baf5086840ab ("cxgb4: restructure VF mgmt code") erroneously removed the code which frees the pf 0-3 resources, causing the probe of pf 0-3 to fail in case of driver reload. Fixes: baf5086840ab ("cxgb4: restructure VF mgmt code") Signed-off-by: Ganesh Goudar

Re: [PATCH] net: sched: tbf: handle GSO_BY_FRAGS case in enqueue

On Mon, Feb 05, 2018 at 02:34:33PM +1100, Daniel Axtens wrote: > tbf_enqueue() checks the size of a packet before enqueuing it. > However, the GSO size check does not consider the GSO_BY_FRAGS > case, and so will drop GSO SCTP packets, causing a massive drop > in throughput. > > Use

Re: [PATCHv2 net-next 3/8] net: sched: act: handle generic action errors

On Wed, 2018-02-14 at 17:13 -0500, Alexander Aring wrote: > This patch adds extack support for generic act handling. The extack > will be set deeper to each called function which is not part of netdev > core api. > > Based on work by David Ahern hello Alexander, after

[net-next 03/10] tipc: eliminate struct tipc_subscriber

It is unnecessary to keep two structures, struct tipc_conn and struct tipc_subscriber, with a one-to-one relationship and still with different life cycles. The fact that the two often run in different contexts, and still may access each other via direct pointers constitutes an additional hazard,

[net-next 02/10] tipc: remove unnecessary function pointers

Interaction between the functionality in server.c and subscr.c is done via function pointers installed in struct server. This makes the code harder to follow, and doesn't serve any obvious purpose. Here, we replace the function pointers with direct function calls. Acked-by: Ying Xue

[net-next 01/10] tipc: remove redundant code in topology server

The socket handling in the topology server is unnecessarily generic. It is prepared to handle both SOCK_RDM, SOCK_DGRAM and SOCK_STREAM type sockets, as well as the only socket type which is really used, SOCK_SEQPACKET. We now remove this redundant code to make the code more readable. Acked-by:

Re: [vhost:vhost 22/28] drivers/firmware/qemu_fw_cfg.c:35:10: fatal error: linux/fw_cfg.h: No such file or directory

On Wed, Feb 14, 2018 at 7:21 PM, kbuild test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost > head: 20b12f92d80433b9bd0d54b9712897501ac66fdd > commit: f59055103f6930c771fc597c42a92cbe997a765d [22/28] fw_cfg: add a public >

Re: [PATCH iproute2 2/7] devlink: mnlg: Add support for extended ack

On 02/14/2018 05:12 PM, Stephen Hemminger wrote: > On Wed, 14 Feb 2018 10:55:17 +0200 > Arkadi Sharshevsky wrote: > >> +static mnl_cb_t mnlg_cb_array[NLMSG_MIN_TYPE] = { >> +[NLMSG_NOOP]= mnlg_cb_noop, >> +[NLMSG_ERROR] = mnlg_cb_error, >> +[NLMSG_DONE]

[net-next 09/10] tipc: separate topology server listener socket from subcsriber sockets

We move the listener socket to struct tipc_server and give it its own work item. This makes it easier to follow the code, and entails some simplifications in the reception code in subscriber sockets. Acked-by: Ying Xue Signed-off-by: Jon Maloy ---

[net-next 10/10] tipc: rename tipc_server to tipc_topsrv

We rename struct tipc_server to struct tipc_topsrv. This reflect its now specialized role as topology server. Accoringly, we change or add function prefixes to make it clearer which functionality those belong to. There are no functional changes in this commit. Acked-by: Ying.Xue

[net-next 08/10] tipc: make struct tipc_server private for server.c

In order to narrow the interface and dependencies between the topology server and the subscription/binding table functionality we move struct tipc_server inside the file server.c. This requires some code adaptations in other files, but those are mostly minor. The most important change is that we

[net-next 07/10] tipc: some prefix changes

Since we now have removed struct tipc_subscriber from the code, and only struct tipc_subscription remains, there is no longer need for long and awkward prefixes to distinguish between their pertaining functions. We now change all tipc_subscrp_* prefixes to tipc_sub_*. This is a purely cosmetic

[net-next v2 1/1] tipc: avoid unnecessary copying of bundled messages

A received sk buffer may contain dozens of smaller 'bundled' messages which after extraction go each in their own direction. Unfortunately, when we extract those messages using skb_clone() each of the extracted buffers inherit the truesize value of the original buffer. Apart from causing massive

Re: [PATCH V2 net-next 4/7] rds: support for zcopy completion notification

On (02/14/18 19:41), Willem de Bruijn wrote: > > One more thing: this code notifies that the operation succeeded, but > the data was copied in the process. It does not have to be set otherwise. I see. this one was a bit confusing for me (hence the copy/paste) - maybe because the TCP/UDP/PACKET

Re: [Crypto v4 12/12] Makefile Kconfig

://github.com/0day-ci/linux/commits/Atul-Gupta/Chelsio-Inline-TLS/20180215-072600 base: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ sparse

[PATCH net] cxgb4: fix trailing zero in CIM LA dump

Set correct size of the CIM LA dump for T6. Fixes: 27887bc7cb7f ("cxgb4: collect hardware LA dumps") Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- drivers/net/ethernet/chelsio/cxgb4/cudbg_lib.c | 2 +-

Re: [PATCH bpf-next 0/4] Misc test usability improvements & cleanup

On 02/14/2018 10:50 PM, Joe Stringer wrote: > This is series makes some minor changes primarily focused on making it easier > to understand why test_verifier is failing a test. This includes printing the > observed output when a test fails in a different way than expected, or when > unprivileged

[net-next 00/10] tipc: de-generealize topology server

The topology server is partially based on a template that is much more generic than what we need. This results in a code that is unnecessarily hard to follow and keeping bug free. We now take the consequence of the fact that we only have one such server in TIPC, - with no prospects for

[net-next 04/10] tipc: simplify interaction between subscription and topology connection

The message transmission and reception in the topology server is more generic than is currently necessary. By basing the funtionality on the fact that we only send items of type struct tipc_event and always receive items of struct tipc_subcr we can make several simplifications, and also get rid of

[net-next 05/10] tipc: simplify endianness handling in topology subscriber

Because of the requirement for total distribution transparency, users send subscriptions and receive topology events in their own host format. It is up to the topology server to determine this format and do the correct conversions to and from its own host format when needed. Until now, this has

[net-next 06/10] tipc: collapse subscription creation functions

After the previous changes it becomes logical to collapse the two-level creation of subscription instances into one. We do that here. We also rename the creation and deletion functions for more consistency. Acked-by: Ying Xue Signed-off-by: Jon Maloy

[PATCH net-next] cxgb4: append firmware dump to vmcore in kernel panic

Register callback to panic_notifier_list. Invoke dump collect routine to append dump to vmcore. Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- drivers/net/ethernet/chelsio/cxgb4/cxgb4.h | 5 ++

Re: [PATCH] net: sched: tbf: handle GSO_BY_FRAGS case in enqueue

Hi Marcelo, > > If this block was meant to be an out-of-band/changelog comment, your > SOB line should be above the first --- marker. > Anyhow, > Reviewed-by: Marcelo Ricardo Leitner Thanks - I did a v2 with this around the right way [1], but DaveM asked me to be a

[PATCH net-next 1/2] net: dsa: mv88e6xxx: Release mutex between each statistics read

The PTP code needs low latency access to the PTP hardware timestamps. Reading all the statistics in one go adds a lot of latency to the PTP code. So take and release the reg_lock mutex for each individual statistics, allowing the PTP thread jump in between. Signed-off-by: Andrew Lunn

[PATCH net-next 2/2] net: dsa: mv88e6xxx: Release mutex between each ATU read

The PTP code needs low latency access to the PTP hardware timestamps. Reading all the ATU entries in one go adds a lot of latency to the PTP code. So take and release the reg_lock mutex for each individual MAC address in the ATU, allowing the PTP thread jump in between. Signed-off-by: Andrew Lunn

[PATCH net-next 0/2] net: dsa: mv88e6xxx: Improve PTP access latency

PTP needs to retrieve the hardware timestamps from the switch device in a low latency manor. However ethtool -S and bridge fdb show can hold the switch register access mutex for a long time. These patches changes the reading the statistics and the ATU so that the mutex is released and taken again

Re: tg3 crashes under high load, when using 100Mbits

On Mon, Feb 12, 2018 at 10:59 AM, Siva Reddy Kallam wrote: > On Fri, Feb 9, 2018 at 10:41 AM, Kai Heng Feng > wrote: >> Hi Broadcom folks, >> >> We are now enabling a new platform with tg3 nic, unfortunately we observed >> the bug [1] that

[PATCH] PCI/cxgb4: Extend T3 PCI quirk to T4+ devices

From: Casey Leedom We've run into a problem where our device is attached to a Virtual Machine and the use of the new pci_set_vpd_size() API doesn't help. The VM kernel has been informed that the accesses are okay, but all of the actual VPD Capability Accesses are trapped

Re: [PATCH 0/3] Remove IPVlan module dependencies on IPv6 and Netfilter

On Thu, Feb 15, 2018 at 2:11 AM, David Miller wrote: > From: Matteo Croce > Date: Wed, 14 Feb 2018 19:13:42 +0100 > >> The IPVlan module currently depends on IPv6 and Netfilter. >> Refactor the code to allow building IPVlan module regardless of the value

Re: [PATCH V6 0/4] Add SELinux SCTP protocol support

On Wed, Feb 14, 2018 at 02:19:03PM -0500, Paul Moore wrote: > On Tue, Feb 13, 2018 at 3:52 PM, Richard Haines > wrote: > > These patches have been built on Fedora 27 with kernel-4.16.0-0.rc1 plus > > the following userspace patches to enable testing: > > > > 1)

[PATCH net] net: sched: fix unbalance in the error path of tca_action_flush()

When tca_action_flush() calls the action walk() and gets an error, a successful call to nla_nest_start() is not followed by a call to nla_nest_cancel(). It's harmless, as the skb is freed in the error path - but it's worth to fix this unbalance. Signed-off-by: Davide Caratti

Re: [PATCH V6 2/4] sctp: Add ip option support

On Tue, Feb 13, 2018 at 08:54:44PM +, Richard Haines wrote: > Add ip option support to allow LSM security modules to utilise CIPSO/IPv4 > and CALIPSO/IPv6 services. > > Signed-off-by: Richard Haines > --- > include/net/sctp/sctp.h| 4 +++- >

Re: [PATCHv2 net-next 3/8] net: sched: act: handle generic action errors

On Thu, 2018-02-15 at 10:43 -0500, Alexander Aring wrote: > I will send v3 with your changes. But not with one error handling in > label, the most whole point is to get some messages when somebody > throw a -EINVAL to the userspace and TC subsystem has a lot of places > with that. that's ok for

Re: [PATCH V2 net-next 4/7] rds: support for zcopy completion notification

On Thu, Feb 15, 2018 at 7:03 AM, Sowmini Varadhan wrote: > On (02/14/18 19:41), Willem de Bruijn wrote: >> >> One more thing: this code notifies that the operation succeeded, but >> the data was copied in the process. It does not have to be set otherwise. > > I see.

Re: ppp/pppoe, still panic 4.15.3 in ppp_push

On Thu, Feb 15, 2018 at 12:19:52PM +0200, Denys Fedoryshchenko wrote: > Here we go: > > [24558.921549] > == > [24558.922167] BUG: KASAN: use-after-free in ppp_ioctl+0xa6a/0x1522 > [ppp_generic] > [24558.922776] Write of size 8

Re: [Crypto v5 03/12] support for inline tls

On 02/15/18 12:24 PM, Atul Gupta wrote: > @@ -401,6 +430,15 @@ static int do_tls_setsockopt_tx(struct sock *sk, char > __user *optval, > goto out; > } > > + rc = get_tls_offload_dev(sk); > + if (rc) { > + goto out; > + } else { > + /*

[PATCHv3 net-next 5/8] net: sched: act: add extack for lookup callback

This patch adds extack support for act lookup callback api. This prepares to handle extack support inside each specific act implementation. Cc: David Ahern Signed-off-by: Alexander Aring --- include/net/act_api.h | 3 ++- net/sched/act_api.c|

[PATCHv3 net-next 1/8] net: sched: act: fix code style

This patch is used by subsequent patches. It fixes code style issues caught by checkpatch. Signed-off-by: Alexander Aring --- include/net/act_api.h | 5 +++-- net/sched/act_api.c| 12 ++-- net/sched/act_mirred.c | 6 +++--- 3 files changed, 12 insertions(+),

[PATCHv3 net-next 4/8] net: sched: act: add extack to init callback

This patch adds extack support for act init callback api. This prepares to handle extack support inside each specific act implementation. Based on work by David Ahern Cc: David Ahern Signed-off-by: Alexander Aring ---

[PATCHv3 net-next 7/8] net: sched: act: handle extack in tcf_generic_walker

This patch adds extack handling for a common used TC act function "tcf_generic_walker()" to add an extack message on failures. The tcf_generic_walker() function can fail if get a invalid command different than DEL and GET. The naming "action" here is wrong, the correct naming would be command.

[PATCHv3 net-next 3/8] net: sched: act: handle generic action errors

This patch adds extack support for generic act handling. The extack will be set deeper to each called function which is not part of netdev core api. Based on work by David Ahern Cc: David Ahern Signed-off-by: Alexander Aring ---

Re: [PATCH V2 net-next 4/7] rds: support for zcopy completion notification

On (02/15/18 11:35), Willem de Bruijn wrote: > > The flag is a hint, so on its own it does not require a respin. > > There are by now four small items to patch up. I would respin so that the > patchset that is recorded can be read later as a single correct solution. Agreed, I'll genenrate V3

Re: [PATCH v7 04/37] earlycon: add reg-offset to physical address before mapping

On Tue, Feb 13, 2018 at 3:09 AM, Greentime Hu wrote: > It will get the wrong virtual address because port->mapbase is not added > the correct reg-offset yet. We have to update it before earlycon_map() > is called > > Signed-off-by: Greentime Hu >

v4.16-rc1 misaligned atomics in skb__clone / __napi_alloc_skb

Hi, While fuzzing arm64 v4.16-rc1 with Syzkaller, I've been hitting a misaligned atomic in __skb_clone: atomic_inc(&(skb_shinfo(skb)->dataref)); .. where dataref doesn't have the required natural alignment, and the atomic operation faults. e.g. i often see it aligned to a single byte

Re: v4.16-rc1 misaligned atomics in skb__clone / __napi_alloc_skb

On Thu, Feb 15, 2018 at 9:20 AM, Eric Dumazet wrote: > > Yes, it seems tun.c breaks the assumptions. > > If it really wants to provide arbitrary fragments and alignments, it > should use a separate Sorry, I have sent the message to soon. tun.c should use a private 'struct

Re: v4.16-rc1 misaligned atomics in skb__clone / __napi_alloc_skb

On Thu, Feb 15, 2018 at 09:24:36AM -0800, Eric Dumazet wrote: > On Thu, Feb 15, 2018 at 9:20 AM, Eric Dumazet wrote: > > > > Yes, it seems tun.c breaks the assumptions. > > > > If it really wants to provide arbitrary fragments and alignments, it > > should use a separate > >

RE: [Crypto v5 03/12] support for inline tls

-Original Message- From: Dave Watson [mailto:davejwat...@fb.com] Sent: Thursday, February 15, 2018 9:22 PM To: Atul Gupta Cc: da...@davemloft.net; herb...@gondor.apana.org.au; s...@queasysnail.net; linux-cry...@vger.kernel.org; netdev@vger.kernel.org; Ganesh GR

[PATCH net] udplite: fix partial checksum initialization

Since UDP-Lite is always using checksum, the following path is triggered when calculating pseudo header for it: udp4_csum_init() or udp6_csum_init() skb_checksum_init_zero_check() __skb_checksum_validate_complete() The problem can appear if skb->len is less than CHECKSUM_BREAK. In

Re: [PATCHv3 net-next 0/8] net: sched: act: add extack support

On 18-02-15 10:54 AM, Alexander Aring wrote: Hi, this patch series adds extack support for the TC action subsystem. As example I for the extack support in a TC action I choosed mirred action. For the patch series: Acked-by: Jamal Hadi Salim cheers, jamal

RE: [Crypto v5 03/12] support for inline tls

> > > @@ -401,6 +430,15 @@ static int do_tls_setsockopt_tx(struct sock *sk, > > > char __user *optval, > > > goto out; > > > } > > > > > > + rc = get_tls_offload_dev(sk); > > > + if (rc) { > > > + goto out; > > > + } else { > > > + /* Retain HW unhash for cleanup and

[PATCHv3 net-next 0/8] net: sched: act: add extack support

Hi, this patch series adds extack support for the TC action subsystem. As example I for the extack support in a TC action I choosed mirred action. - Alex Cc: David Ahern changes since v3: - adapt recommended changes from Davide Caratti, please check if I catch everything.

[PATCHv3 net-next 2/8] net: sched: act: add extack to init

This patch adds extack to tcf_action_init and tcf_action_init_1 functions. These are necessary to make individual extack handling in each act implementation. Based on work by David Ahern Cc: David Ahern Signed-off-by: Alexander Aring

[PATCHv3 net-next 6/8] net: sched: act: add extack for walk callback

This patch adds extack support for act walker callback api. This prepares to handle extack support inside each specific act implementation. Cc: David Ahern Signed-off-by: Alexander Aring --- include/net/act_api.h | 3 ++- net/sched/act_api.c|

[PATCHv3 net-next 8/8] net: sched: act: mirred: add extack support

This patch adds extack support for TC mirred action. Cc: David Ahern Signed-off-by: Alexander Aring --- net/sched/act_mirred.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/net/sched/act_mirred.c

Re: ppp/pppoe, still panic 4.15.3 in ppp_push

On 2018-02-15 17:55, Guillaume Nault wrote: On Thu, Feb 15, 2018 at 12:19:52PM +0200, Denys Fedoryshchenko wrote: Here we go: [24558.921549] == [24558.922167] BUG: KASAN: use-after-free in ppp_ioctl+0xa6a/0x1522

[PATCH net] dn_getsockoptdecnet: move nf_{get/set}sockopt outside sock lock

After commit 3f34cfae1238 ("netfilter: on sockopt() acquire sock lock only in the required scope"), the caller of nf_{get/set}sockopt() must not hold any lock, but, in such changeset, I forgot to cope with DECnet. This commit addresses the issue moving the nf call outside the lock, in the

Re: [RFC][PATCH bpf v2 1/2] bpf: allow 64-bit offsets for bpf function calls

On 02/13/2018 05:05 AM, Sandipan Das wrote: > The imm field of a bpf_insn is a signed 32-bit integer. For > JIT-ed bpf-to-bpf function calls, it stores the offset from > __bpf_call_base to the start of the callee function. > > For some architectures, such as powerpc64, it was found that > this

Re: [PATCH net-next 0/3] eBPF Seccomp filters

> On Feb 14, 2018, at 8:30 PM, Alexei Starovoitov > wrote: > > On Wed, Feb 14, 2018 at 10:32:22AM -0700, Tycho Andersen wrote: What's the reason for adding eBPF support? seccomp shouldn't need it, and it only makes the code more complex. I'd rather

Re: [PATCHv2 net-next 3/8] net: sched: act: handle generic action errors

Hi, On Thu, Feb 15, 2018 at 6:14 AM, Davide Caratti wrote: > On Wed, 2018-02-14 at 17:13 -0500, Alexander Aring wrote: >> This patch adds extack support for generic act handling. The extack >> will be set deeper to each called function which is not part of netdev >> core

Re: [Crypto v5 03/12] support for inline tls

On 02/15/18 04:10 PM, Atul Gupta wrote: > > -Original Message- > > From: Dave Watson [mailto:davejwat...@fb.com] > > Sent: Thursday, February 15, 2018 9:22 PM > > To: Atul Gupta > > Cc: da...@davemloft.net; herb...@gondor.apana.org.au; s...@queasysnail.net; > >

Re: v4.16-rc1 misaligned atomics in skb__clone / __napi_alloc_skb

On Thu, Feb 15, 2018 at 9:04 AM, Mark Rutland wrote: > Hi, > > While fuzzing arm64 v4.16-rc1 with Syzkaller, I've been hitting a > misaligned atomic in __skb_clone: > > atomic_inc(&(skb_shinfo(skb)->dataref)); > > .. where dataref doesn't have the required natural

Re: [PATCH v3 net-next 5/7] rds: zerocopy Tx support.

On 2/15/2018 10:49 AM, Sowmini Varadhan wrote: If the MSG_ZEROCOPY flag is specified with rds_sendmsg(), and, if the SO_ZEROCOPY socket option has been set on the PF_RDS socket, application pages sent down with rds_sendmsg() are pinned. The pinning uses the accounting infrastructure added by

[PATCH] i40e: check that pointer vsi is not null before dereferencing it

From: Colin Ian King Function i40e_find_vsi_from_id can potentially return null, hence vsi may be null, so defensively check it is non-null before dereferencing it to check the seid. Fixes: e284fc280473 ("i40e: Add and delete cloud filter") Signed-off-by: Colin Ian

Re: [PATCH iproute2-next v4 7/9] utils: Introduce and use get_ifname_rta()

On 2/15/18 11:34 AM, Serhey Popovych wrote: > Be consistent in handling of IFLA_IFNAME attribute in all places: if > there is no attribute report bug to stderr and use ll_idx_n2a() as > last measure to get name in "if%u" format instead of "". > > Use check_ifname() to validate network device

Re: [PATCH][next] net: dsa: mv88e6xxx: avoid unintended sign extension on a 16 bit shift

> diff --git a/drivers/net/dsa/mv88e6xxx/hwtstamp.c > b/drivers/net/dsa/mv88e6xxx/hwtstamp.c > index b251d534b70d..758e35fa69ab 100644 > --- a/drivers/net/dsa/mv88e6xxx/hwtstamp.c > +++ b/drivers/net/dsa/mv88e6xxx/hwtstamp.c > @@ -321,7 +321,7 @@ static void mv88e6xxx_get_rxts(struct

Re: [PATCH net] xfrm: reuse uncached_list to track xdsts

From: Xin Long Date: Wed, 14 Feb 2018 19:06:02 +0800 > In early time, when freeing a xdst, it would be inserted into > dst_garbage.list first. Then if it's refcnt was still held > somewhere, later it would be put into dst_busy_list in > dst_gc_task(). > > When one dev was

Re: [PATCH net v2] fib_semantics: Don't match route with mismatching tclassid

On 2/15/18 1:46 AM, Stefano Brivio wrote: > In fib_nh_match(), if output interface or gateway are passed in > the FIB configuration, we don't have to check next hops of > multipath routes to conclude whether we have a match or not. > > However, we might still have routes with different realms >

Re: [PATCH v3 net-next 7/7] selftests/net: add zerocopy support for PF_RDS test case

On Thu, Feb 15, 2018 at 1:49 PM, Sowmini Varadhan wrote: > Send a cookie with sendmsg() on PF_RDS sockets, and process the > returned batched cookies in do_recv_completion() > > Signed-off-by: Sowmini Varadhan Acked-by: Willem de Bruijn

Re: [PATCH v3 net-next 6/7] selftests/net: add support for PF_RDS sockets

On Thu, Feb 15, 2018 at 1:49 PM, Sowmini Varadhan wrote: > Add support for basic PF_RDS client-server testing in msg_zerocopy > > Signed-off-by: Sowmini Varadhan Acked-by: Willem de Bruijn

[PATCH v1 1/1] drivers: isdn: NULL pointer dereference [null-pointer-deref] (CWE 476) problem

The Parfait (version 2.1.0) static code analysis tool found the following NULL pointer dereference problem. - drivers/isdn/mISDN/core.c function channelmap_show() does not check the returned mdev variable from dev_to_mISDN() for NULL. Added the check for NULL, which results in a value of 0 being

[PATCH v3 net-next 0/7] RDS: zerocopy support

This is version 3 of the series, following up on review comments for http://patchwork.ozlabs.org/project/netdev/list/?series=28530 Review comments addressed Patch 4 - fix fragile use of skb->cb[], do not set ee_code incorrectly. Patch 5: - remove needless bzero of skb->cb[], consolidate err

Re: [PATCH net-next v2 0/3] Add ioctl() SIOCGSKNS cmd to allow obtaining net ns of tun device

From: Kirill Tkhai Date: Wed, 14 Feb 2018 16:39:45 +0300 > Currently, it's not possible to get or check net namespace, > which was used to create tun socket. User may have two tun > devices with the same names in different nets, and there > is no way to differ them each

Re: [PATCH net-next 0/7] tools: tc-testing: Plugin Architecture

From: "Brenda J. Butler" Date: Wed, 14 Feb 2018 14:09:18 -0500 > To make tdc.py more general, we are introducing a plugin architecture. > > This patch set first organizes the command line parameters, then > introduces the plugin architecture and some example plugins. Series

Re: [PATCH v3 net-next 1/7] skbuff: export mm_[un]account_pinned_pages for other modules

On Thu, Feb 15, 2018 at 1:49 PM, Sowmini Varadhan wrote: > RDS would like to use the helper functions for managing pinned pages > added by Commit a91dbff551a6 ("sock: ulimit on MSG_ZEROCOPY pages") > > Signed-off-by: Sowmini Varadhan

Re: [PATCH v3 net-next 3/7] sock: permit SO_ZEROCOPY on PF_RDS socket

On Thu, Feb 15, 2018 at 1:49 PM, Sowmini Varadhan wrote: > allow the application to set SO_ZEROCOPY on the underlying sk > of a PF_RDS socket > > Signed-off-by: Sowmini Varadhan Acked-by: Willem de Bruijn

Re: [PATCH net-next] net/ipv4: Remove fib table id from rtable

From: David Ahern Date: Wed, 14 Feb 2018 14:24:28 -0800 > Remove rt_table_id from rtable. It was added for getroute to return the > table id that was hit in the lookup. With the changes for fibmatch the > table id can be extracted from the fib_info returned in the fib_result >

Re: [PATCH v3 net-next 4/7] rds: support for zcopy completion notification

On Thu, Feb 15, 2018 at 2:46 PM, Santosh Shilimkar wrote: > On 2/15/2018 10:49 AM, Sowmini Varadhan wrote: >> >> RDS removes a datagram (rds_message) from the retransmit queue when >> an ACK is received. The ACK indicates that the receiver has queued >> the RDS

Re: [PATCH net-next v2] selftests/net: fixes psock_fanout eBPF test case

From: Prashant Bhole Date: Thu, 15 Feb 2018 09:19:26 +0900 > eBPF test fails due to verifier failure because log_buf is too small. > Fixed by increasing log_buf size > > Signed-off-by: Prashant Bhole > --- > v2: log_buf is

Re: [PATCH v3 net-next 5/7] rds: zerocopy Tx support.

On Thu, Feb 15, 2018 at 2:47 PM, Santosh Shilimkar wrote: > On 2/15/2018 10:49 AM, Sowmini Varadhan wrote: >> >> If the MSG_ZEROCOPY flag is specified with rds_sendmsg(), and, >> if the SO_ZEROCOPY socket option has been set on the PF_RDS socket, >> application pages

  1   2   >