Re: [PATCH] i40evf: remove redundant array comparisons to 0 checks

2018-02-18 Thread Andy Shevchenko
On Fri, Feb 16, 2018 at 6:53 PM, Colin Ian King wrote: > On 16/02/18 16:51, Andy Shevchenko wrote: >> On Thu, Feb 15, 2018 at 9:42 PM, Colin King wrote: >>> + filter->f.mask.tcp_spec.dst_ip[i] |= >>>

[PATCH] sh_eth: simplify sh_eth_check_reset()

2018-02-18 Thread Sergei Shtylyov
The *while* loop in this function can be turned into a normal *for* loop. And getting rid of the single return point saves us a few more LoCs... Signed-off-by: Sergei Shtylyov --- The patch is against DaveM's 'net-next.git' repo.

Re: [PATCH v5 06/14] net: pch_gbe: Allow longer for resets

2018-02-18 Thread kbuild test robot
/linux/commits/Paul-Burton/net-pch_gbe-Fixes-MIPS-support/20180218-213023 reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed by >>) drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:

Re: [PATCH v5 00/14] net: pch_gbe: Fixes & MIPS support

2018-02-18 Thread David Miller
Nobody is going to see and apply these patches if you don't CC: the Linux networking development list, netdev@vger.kernel.org Thank you.

Re: [PATCH v5 00/14] net: pch_gbe: Fixes & MIPS support

2018-02-18 Thread Paul Burton
Hi Andrew, On Sun, Feb 18, 2018 at 06:56:07PM +0100, Andrew Lunn wrote: > On Sun, Feb 18, 2018 at 09:03:10AM -0800, Paul Burton wrote: > > Hi David, > > > > On Sun, Feb 18, 2018 at 10:31:12AM -0500, David Miller wrote: > > > Nobody is going to see and apply these patches if you don't CC: the > >

Re: INFO: rcu detected stall in xfrm_confirm_neigh

2018-02-18 Thread Steffen Klassert
On Tue, Feb 13, 2018 at 10:19:17AM +0100, Dmitry Vyukov wrote: > On Mon, Feb 12, 2018 at 4:26 PM, Dmitry Vyukov wrote: > > On Mon, Feb 12, 2018 at 4:23 PM, syzbot > > wrote: > >> Hello, > >> > >> syzbot hit the following

Re: [PATCH net-next3/5] ibmvnic: Free and re-allocate scrqs when tx/rx scrqs change

2018-02-18 Thread kbuild test robot
/linux/commits/Nathan-Fontenot/ibmvnic-Free-and-re-allocate-scrqs-when-tx-rx-scrqs-change/20180218-203503 config: powerpc-allmodconfig (attached as .config) compiler: powerpc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin

[Crypto v6 10/12] chtls: Inline crypto request Tx/Rx

2018-02-18 Thread Atul Gupta
TLS handler for record transmit and receive. Create Inline TLS work request and post to FW. Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chtls/chtls_io.c | 1867 +++ 1 file changed, 1867 insertions(+) create mode 100644

[Crypto v6 12/12] Makefile Kconfig

2018-02-18 Thread Atul Gupta
Entry for Inline TLS as another driver dependent on cxgb4 and chcr Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/Kconfig| 11 +++ drivers/crypto/chelsio/Makefile | 1 + drivers/crypto/chelsio/chtls/Makefile | 4 3 files changed, 16

[Crypto v6 09/12] chtls: CPL handler definition

2018-02-18 Thread Atul Gupta
CPL handlers for TLS session, record transmit and receive. Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chtls/chtls_cm.c | 2041 +++ net/ipv4/tcp_minisocks.c|1 + 2 files changed, 2042 insertions(+) create mode

[Crypto v6 06/12] cxgb4: LLD driver changes to enable TLS

2018-02-18 Thread Atul Gupta
Read FW capability. Read key area size. Dump the TLS record count. Signed-off-by: Atul Gupta --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 32 +--- drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.h | 7 ++ drivers/net/ethernet/chelsio/cxgb4/sge.c| 98

[Crypto v6 11/12] chtls: Register chtls Inline TLS with net tls

2018-02-18 Thread Atul Gupta
Register chtls as Inline TLS driver, chtls is ULD to cxgb4. Setsockopt to program (tx/rx) keys on chip. Support AES GCM of key size 128. Support both Inline Rx and Tx. Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chtls/chtls_main.c | 600

[Crypto v6 07/12] chcr: Key Macro

2018-02-18 Thread Atul Gupta
Define macro for TLS Key context Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chcr_algo.h | 42 + drivers/crypto/chelsio/chcr_core.h | 55 +- 2 files changed, 96 insertions(+), 1 deletion(-) diff

[Crypto v6 08/12] chtls: Key program

2018-02-18 Thread Atul Gupta
Program the tx and rx key on chip. Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chtls/chtls_hw.c | 394 1 file changed, 394 insertions(+) create mode 100644 drivers/crypto/chelsio/chtls/chtls_hw.c diff --git

[Crypto v6 03/12] tls: support for inline tls

2018-02-18 Thread Atul Gupta
Facility to register Inline TLS drivers to net/tls. Setup TLS_FULL_HW prot to listen on offload device. Cases handled 1. Inline TLS device exists, setup prot for TLS_FULL_HW 2. Atleast one Inline TLS exists, sets TLS_FULL_HW. If non-inline capable device establish connection, move to TLS_SW_TX 3.

[Crypto v6 04/12] chtls: structure and macro definiton

2018-02-18 Thread Atul Gupta
Inline TLS state, connection management. Supporting macros definition. Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chtls/chtls.h| 487 drivers/crypto/chelsio/chtls/chtls_cm.h | 202 + 2 files changed, 689

[Crypto v6 02/12] ethtool: enable Inline TLS in HW

2018-02-18 Thread Atul Gupta
Signed-off-by: Atul Gupta --- include/linux/netdev_features.h | 2 ++ net/core/ethtool.c | 1 + 2 files changed, 3 insertions(+) diff --git a/include/linux/netdev_features.h b/include/linux/netdev_features.h index db84c51..aacabe2 100644 ---

[Crypto v6 05/12] cxgb4: Inline TLS FW Interface

2018-02-18 Thread Atul Gupta
Key area size in hw-config file. CPL struct for TLS request and response. Work request for Inline TLS. Signed-off-by: Atul Gupta --- drivers/net/ethernet/chelsio/cxgb4/t4_msg.h | 121 ++- drivers/net/ethernet/chelsio/cxgb4/t4_regs.h | 2 +

[Crypto v6 00/12] Chelsio Inline TLS

2018-02-18 Thread Atul Gupta
Series for Chelsio Inline TLS driver (chtls.ko) Use tls ULP infrastructure to register chtls as Inline TLS driver. Chtls use TCP Sockets to transmit and receive TLS record. TCP proto_ops is extended to offload TLS record. T6 adapter provides the following features: -TLS record offload,

[Crypto v6 01/12] tls: tls_device struct to register TLS drivers

2018-02-18 Thread Atul Gupta
tls_device structure to register Inline TLS drivers with net/tls Signed-off-by: Atul Gupta --- include/net/tls.h | 23 +++ 1 file changed, 23 insertions(+) diff --git a/include/net/tls.h b/include/net/tls.h index 4913430..e315bf9 100644 ---

[PATCH net] tg3: APE heartbeat changes

2018-02-18 Thread Satish Baddipadige
From: Prashant Sreedharan In ungraceful host shutdown or driver crash case BMC connectivity is lost. APE firmware is missing the driver state in this case to keep the BMC connectivity alive. This patch has below change to address this issue. Heartbeat mechanism

Re: [RFC PATCH v3 0/3] Enable virtio_net to act as a backup for a passthru device

2018-02-18 Thread Jakub Kicinski
On Sat, 17 Feb 2018 09:12:01 -0800, Alexander Duyck wrote: > >> We noticed a couple of issues with this approach during testing. > >> - As both 'bypass' and 'backup' netdevs are associated with the same > >> virtio pci device, udev tries to rename both of them with the same name > >> and the

Re: [PATCH net] tg3: APE heartbeat changes

2018-02-18 Thread Satish Baddipadige
On Sat, Feb 17, 2018 at 2:56 AM, David Miller wrote: > > From: Satish Baddipadige > Date: Fri, 16 Feb 2018 10:01:29 +0530 > > > @@ -990,6 +984,18 @@ static void tg3_ape_driver_state_change(struct tg3 > > *tp, int kind) > >

Re: [PATCH] i40evf: remove redundant array comparisons to 0 checks

2018-02-18 Thread Colin Ian King
On 18/02/18 16:31, Joe Perches wrote: > On Sun, 2018-02-18 at 16:58 +0200, Andy Shevchenko wrote: >> On Fri, Feb 16, 2018 at 6:53 PM, Colin Ian King >> wrote: >>> On 16/02/18 16:51, Andy Shevchenko wrote: On Thu, Feb 15, 2018 at 9:42 PM, Colin King

Re: TCP and BBR: reproducibly low cwnd and bandwidth

2018-02-18 Thread Oleksandr Natalenko
Hi. On neděle 18. února 2018 22:04:27 CET Eric Dumazet wrote: > I was able to take a look today, and I believe this is the time to > switch TCP to GSO being always on. > > As a bonus, we get speed boost for cubic as well. > > Todays high BDP and recent TCP improvements (rtx queue as rb-tree,

Re: [PATCH net-next3/5] ibmvnic: Free and re-allocate scrqs when tx/rx scrqs change

2018-02-18 Thread Nathan Fontenot
On 02/17/2018 05:32 PM, Nathan Fontenot wrote: > When the driver resets it is possible that the number of tx/rx > sub-crqs can change. This patch handles this so that the driver does > not try to access non-existent sub-crqs. > > Additionally, a parameter is added to release_sub_crqs() so that >

[PATCH nf] netfilter: bridge: ebt_among: add missing match size checks

2018-02-18 Thread Florian Westphal
ebt_among is special, it has a dynamic match size and is exempt from the central size checks. Therefore it must check that the size of the match structure provided from userspace is sane by making sure em->match_size is at least the minimum size of the expected structure. The module has such a

[PATCH net 0/4] Fixes, cleanup and modernization for 8390 ethernet drivers

2018-02-18 Thread Finn Thain
Changes since v4 of combined patch series: - Removed redundant and non-portable MACH_IS_MAC tests. - Added acked-by tags from Geert Uytterhoeven. - Omitted patches unrelated to 8390 drivers. Finn Thain (4): net/8390: Remove redundant make dependencies net/8390: Fix msg_enable patch snafu

Re: [PATCH net 1/4] net/8390: Remove redundant make dependencies

2018-02-18 Thread Greg Ungerer
Hi Finn, On 19/02/18 12:39, Finn Thain wrote: > The hydra, zorro8390 and mcf8390 drivers all #include "lib8390.c" and > have no need for 8390.o. modinfo confirms no dependency on 8390.ko. > Drop the redundant dependency from the Makefile. objdump confirms > that this patch has no effect on the

Re: [net-next v2 2/2] bpf: Add eBPF seccomp sample programs

2018-02-18 Thread Sargun Dhillon
On Sat, Feb 17, 2018 at 9:58 AM, Randy Dunlap wrote: > On 02/16/2018 11:36 PM, Sargun Dhillon wrote: >> + close(111); >> + assert(errno == EBADF); >> + close(999); >> + assert(errno = EPERM); > > should that be == ? > Woops. Embarassing. Will fix that

Re: TCP and BBR: reproducibly low cwnd and bandwidth

2018-02-18 Thread Eric Dumazet
On Sat, 2018-02-17 at 10:52 -0800, Eric Dumazet wrote: > > This must be some race condition in the code I added in TCP for self- > pacing, when a sort timeout is programmed. > > Disabling SG means TCP cooks 1-MSS packets. > > I will take a look, probably after the (long) week-end : Tuesday. I

[PATCH net 4/4] net/mac8390: Fix log messages

2018-02-18 Thread Finn Thain
Use dev_foo() to log the slot number instead of the unexpanded "eth%d" format string. Disambiguate the two identical "Card type %s is unsupported" messages. Tested-by: Stan Johnson Signed-off-by: Finn Thain --- drivers/net/ethernet/8390/mac8390.c

[PATCH net 3/4] net/mac8390: Convert to nubus_driver

2018-02-18 Thread Finn Thain
This resolves an old bug that constrained this driver to no more than one card. Tested-by: Stan Johnson Signed-off-by: Finn Thain --- drivers/net/Space.c | 3 - drivers/net/ethernet/8390/mac8390.c | 139

[PATCH net 2/4] net/8390: Fix msg_enable patch snafu

2018-02-18 Thread Finn Thain
The lib8390 module parameter 'msg_enable' doesn't do anything useful: it causes an ancient version string to be logged. Remove redundant code that logs the same string. In ne.c and wd.c, the value of ei_local->msg_enable is used before being assigned. Use ne_msg_enable and wd_msg_enable,

[PATCH net 1/4] net/8390: Remove redundant make dependencies

2018-02-18 Thread Finn Thain
The hydra, zorro8390 and mcf8390 drivers all #include "lib8390.c" and have no need for 8390.o. modinfo confirms no dependency on 8390.ko. Drop the redundant dependency from the Makefile. objdump confirms that this patch has no effect on the module binaries. The superfluous additions of 8390.o

a lot of WARNING, nf_xfrm_me_harder in 4.15.x

2018-02-18 Thread Denys Fedoryshchenko
Is there any bug with that or it is just some sort of spam? Cause i am troubleshooting at same time "hard to catch" bug in ppp/pppoe Workload: pppoe bras I am going to try last stable 4.14.x after 1-2 days as well, but probably i noticed this message appeared there as well, under some

[PATCH nf] netfilter: ebtables: CONFIG_COMPAT: don't trust userland offsets

2018-02-18 Thread Florian Westphal
We need to make sure the offsets are not out of range of the total size. Also check that they are in ascending order. The WARN_ON triggered by syzkaller (it sets panic_on_warn) is changed to also bail out, no point in continuing parsing. Briefly tested with simple ruleset of -A INPUT --limit

[PATCH net-next] dpaa_eth: fix pause capability advertisement logic

2018-02-18 Thread Jake Moroni
The ADVERTISED_Asym_Pause bit was being improperly set when both rx and tx pause were enabled. When rx and tx are both enabled, only the ADVERTISED_Pause bit is supposed to be set. Signed-off-by: Jake Moroni --- drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c | 2 +- 1

[PATCH] net: sched: report if filter is too large to dump

2018-02-18 Thread Roman Kapl
So far, if the filter was too large to fit in the allocated skb, the kernel did not return any error and stopped dumping. Modify the dumper so that it returns -ENOMSG when a filter fails to dump and it is the first filter in the skb. If we are not first, we will get a next chance with more room.

[PATCH iproute2-next 4/4] bridge: update man page for new color and json changes

2018-02-18 Thread Stephen Hemminger
Document color option, and no longer have restriction on json Signed-off-by: Stephen Hemminger --- man/man8/bridge.8 | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/man/man8/bridge.8 b/man/man8/bridge.8 index 490ef58da16c..05512b029fb9

[PATCH iproute2-next 2/4] bridge: colorize output and use JSON print library

2018-02-18 Thread Stephen Hemminger
Use new functions from json_print to simplify code. Provide standard flag for colorizing output. Note: the simple -c flag is ambiguous it could mean color or compressvlan; it is now changed to mean color for consistency with other iproute2 commands. Signed-off-by: Stephen Hemminger

[PATCH iproute2-next 3/4] bridge: add json support for link command

2018-02-18 Thread Stephen Hemminger
Add json output for bridge link show command. This also changes the output format slightly for the non JSON case so that it has same format as the ip link show command. Signed-off-by: Stephen Hemminger --- bridge/link.c | 304

[PATCH iproute2-next 1/4] bridge: implement json pretty print flag

2018-02-18 Thread Stephen Hemminger
Make bridge work like other iproute2 commands with standard -j and -p flags. Signed-off-by: Stephen Hemminger --- bridge/br_common.h | 3 ++- bridge/bridge.c| 9 ++--- bridge/fdb.c | 10 ++ bridge/mdb.c | 12 ++-- bridge/vlan.c

[PATCH iproute2-next 0/4] bridge: json and color output

2018-02-18 Thread Stephen Hemminger
This set of patches adds color and full JSON support to bridge command. It also aligns ths output format and command line options to match ip command; this is a change that may impact those using "compress vlan" option or doing screen scraping. The JSON output also changes slightly. But this

[PATCH iproute2-next] tc: fix an off-by-one error while printing tc actions

2018-02-18 Thread Adam Vyskovsky
The tc_print_action() function did not print all tc actions when e.g. TCA_ACT_MAX_PRIO actions were defined for a single tc filter. Signed-off-by: Adam Vyskovsky --- tc/m_action.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tc/m_action.c

Re: TCP and BBR: reproducibly low cwnd and bandwidth

2018-02-18 Thread Eric Dumazet
On Sun, 2018-02-18 at 13:04 -0800, Eric Dumazet wrote: > > Can you please test the following patch ? > > Note that some cleanups can be done later in TCP stack, removing lots > of legacy stuff. > > Also TCP internal-pacing could benefit from something similar to this > fq patch eventually,

Re: TCP and BBR: reproducibly low cwnd and bandwidth

2018-02-18 Thread Eric Dumazet
On Sun, 2018-02-18 at 22:49 +0100, Oleksandr Natalenko wrote: > Hi. > > On neděle 18. února 2018 22:04:27 CET Eric Dumazet wrote: > > I was able to take a look today, and I believe this is the time to > > switch TCP to GSO being always on. > > > > As a bonus, we get speed boost for cubic as

[PATCH V2 net-next 5/5] ibmvnic: Allocate max queues stats buffers

2018-02-18 Thread Nathan Fontenot
To avoid losing any stats when the number of sub-crqs change, allocate the max number of stats buffers so a stats buffer exists all possible sub-crqs. Signed-off-by: Nathan Fontenot --- drivers/net/ethernet/ibm/ibmvnic.c |4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH V2 net-next 4/5] ibmvnic: Make napi usage dynamic

2018-02-18 Thread Nathan Fontenot
In order to handle the number of rx sub crqs changing during a driver reset, the ibmvnic driver also needs to update the number of napi. To do this the code to init and free napi's is moved to their own routines so they can be called during the reset process. Signed-off-by: Nathan Fontenot

[PATCH V2 net-next 3/5] ibmvnic: Free and re-allocate scrqs when tx/rx scrqs change

2018-02-18 Thread Nathan Fontenot
When the driver resets it is possible that the number of tx/rx sub-crqs can change. This patch handles this so that the driver does not try to access non-existent sub-crqs. The count for releasing sub crqs depends on the adapter state. The active queue count is not set in probe, so if we are

[PATCH V2 net-next 2/5] ibmvnic: Move active sub-crq count settings

2018-02-18 Thread Nathan Fontenot
In preparation for using the active scrq count to track more active resources, move the setting of the active count to after initialization occurs in initial driver init and during driver reset. Signed-off-by: Nathan Fontenot --- drivers/net/ethernet/ibm/ibmvnic.c |

[PATCH V2 net-next 0/5] ibmvnic: Make driver resources dynamic

2018-02-18 Thread Nathan Fontenot
The ibmvnic driver needs to be able to handle the number of tx/rx sub-crqs changing during a reset of the driver. To do this several changes need to be made. First the num_active_[tx|rx]_pools counters need to be re-named to num_active_[tc|rx]_scrqs, and updated after resource initialization.

[PATCH V2 net-next 1/5] ibmvnic: Rename active queue count variables

2018-02-18 Thread Nathan Fontenot
Rename the tx/rx active pool variables to be tx/rx active scrq counts. The tx/rx pools are per sub-crq so this is a more appropriate name. This also is a preparatory step for using thiese variables for handling updates to sub-crqs and napi based on the active count. Signed-off-by: Nathan Fontenot

Re: [PATCH net] tcp: restrict F-RTO to work-around broken middle-boxes

2018-02-18 Thread Teodor Milkov
Hello, I've numerous reports from Windows users that after kernel upgrade from 4.9 to 4.14 they experienced major slow downs and transfer stalls. After some digging, I found that the slowness starts with this commit: tcp: extend F-RTO to catch more spurious timeouts (89fe18e44)

[no subject]

2018-02-18 Thread Alfred Chow
Good Day, This is the second time i am sending you this mail. I am Mr. Alfred Cheuk Yu Chow, the Director for Credit & Marketing Chong Hing Bank, Hong Kong, need your alliance in a deal that will be of mutual benefit. Email me back for more details. Regards.

Re: [PATCH RFC 0/4] net: add bpfilter

2018-02-18 Thread Florian Westphal
Daniel Borkmann wrote: > As rule translation can potentially become very complex, this is performed > entirely in user space. In order to ease deployment, request_module() code > is extended to allow user mode helpers to be invoked. Idea is that user mode > helpers are built

Re: [PATCH v5 00/14] net: pch_gbe: Fixes & MIPS support

2018-02-18 Thread David Miller
From: Paul Burton Date: Sun, 18 Feb 2018 09:03:10 -0800 > Hi David, > > On Sun, Feb 18, 2018 at 10:31:12AM -0500, David Miller wrote: >> Nobody is going to see and apply these patches if you don't CC: the >> Linux networking development list, netdev@vger.kernel.org > >

Re: [PATCH v5 00/14] net: pch_gbe: Fixes & MIPS support

2018-02-18 Thread Florian Fainelli
On 02/18/2018 05:15 PM, David Miller wrote: > From: Paul Burton > Date: Sun, 18 Feb 2018 09:03:10 -0800 > >> Hi David, >> >> On Sun, Feb 18, 2018 at 10:31:12AM -0500, David Miller wrote: >>> Nobody is going to see and apply these patches if you don't CC: the >>> Linux

Re: [PATCH V6 2/4] sctp: Add ip option support

2018-02-18 Thread Neil Horman
On Sun, Feb 18, 2018 at 01:44:42PM +, Richard Haines wrote: > On Fri, 2018-02-16 at 23:28 -0500, Neil Horman wrote: > > On Fri, Feb 16, 2018 at 07:51:02PM -0200, Marcelo Ricardo Leitner > > wrote: > > > On Fri, Feb 16, 2018 at 03:14:35PM -0500, Neil Horman wrote: > > > > On Fri, Feb 16, 2018

Re: ppp/pppoe, still panic 4.15.3 in ppp_push

2018-02-18 Thread Denys Fedoryshchenko
On 2018-02-16 20:48, Guillaume Nault wrote: On Fri, Feb 16, 2018 at 01:13:18PM +0200, Denys Fedoryshchenko wrote: On 2018-02-15 21:42, Guillaume Nault wrote: > On Thu, Feb 15, 2018 at 09:34:42PM +0200, Denys Fedoryshchenko wrote: > > On 2018-02-15 21:31, Guillaume Nault wrote: > > > On Thu, Feb

Re: [PATCH RFC net-next 0/7] net/ipv6: Add support for path selection using hash of 5-tuple

2018-02-18 Thread Or Gerlitz
On Thu, Feb 15, 2018 at 12:56 AM, David Ahern wrote: > On 2/14/18 3:45 PM, Or Gerlitz wrote: >> how the various systems you are dealing with do with traffic that involves >> ipv6 extension headers? what about environments with GRE? in ipv4 GRE >> fabrics are just broken for

Re: [PATCH v5 00/14] net: pch_gbe: Fixes & MIPS support

2018-02-18 Thread Andrew Lunn
On Sun, Feb 18, 2018 at 09:03:10AM -0800, Paul Burton wrote: > Hi David, > > On Sun, Feb 18, 2018 at 10:31:12AM -0500, David Miller wrote: > > Nobody is going to see and apply these patches if you don't CC: the > > Linux networking development list, netdev@vger.kernel.org > > You're replying to

Re: [PATCH v5 02/14] net: pch_gbe: Pull PHY GPIO handling out of Minnow code

2018-02-18 Thread Paul Burton
Hi Andrew, On Sun, Feb 18, 2018 at 12:34:42AM +0100, Andrew Lunn wrote: > > Even if that is true, rewriting the driver's PHY handling would be a > > very separate change to the changes this series make which allow this > > driver to work on a platform besides the Minnowboard. The *only* thing > >

Re: [PATCH] i40evf: remove redundant array comparisons to 0 checks

2018-02-18 Thread Joe Perches
On Sun, 2018-02-18 at 16:58 +0200, Andy Shevchenko wrote: > On Fri, Feb 16, 2018 at 6:53 PM, Colin Ian King > wrote: > > On 16/02/18 16:51, Andy Shevchenko wrote: > > > On Thu, Feb 15, 2018 at 9:42 PM, Colin King > > > wrote: > > > > +

Re: [PATCH v5 00/14] net: pch_gbe: Fixes & MIPS support

2018-02-18 Thread Paul Burton
Hi David, On Sun, Feb 18, 2018 at 10:31:12AM -0500, David Miller wrote: > Nobody is going to see and apply these patches if you don't CC: the > Linux networking development list, netdev@vger.kernel.org You're replying to mail that was "To: netdev@vger.kernel.org" and I see the whole series in

Re: [PATCH v5 12/14] net: pch_gbe: Fix TX RX descriptor accesses for big endian systems

2018-02-18 Thread kbuild test robot
/0day-ci/linux/commits/Paul-Burton/net-pch_gbe-Fixes-MIPS-support/20180218-213023 reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed by >>) drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_

[PATCH net-next] ibmvnic: Keep track of supplementary TX descriptors

2018-02-18 Thread Thomas Falcon
Supplementary TX descriptors were not being accounted for, which was resulting in an overflow of the hardware device's transmit queue. Keep track of those descriptors now when determining how many entries remain on the TX queue. Signed-off-by: Thomas Falcon ---

[PATCH net] ibmvnic: Clean RX pools only during a hard reset

2018-02-18 Thread Thomas Falcon
Sorry, this fixes a bug in commit d0869c0071e4. The cause of the bug is that "stale" RX buffers containing packet data are returned to the driver after device close and open. While most buffers will be returned with an error and handled by the polling routine, some buffers will be returned as

Re: [PATCH v5 02/14] net: pch_gbe: Pull PHY GPIO handling out of Minnow code

2018-02-18 Thread Andrew Lunn
> How would you feel if I were to adjust the binding to match the standard > PHY binding, but internally leave the driver's PHY handling as-is for > now? Hi Paul That is a reasonable compromise. Thanks Andrew

Re: [RFC net PATCH] virtio_net: disable XDP_REDIRECT in receive_mergeable() case

2018-02-18 Thread Jesper Dangaard Brouer
On Fri, 16 Feb 2018 13:31:37 +0800 Jason Wang wrote: > > Besides the described bug: > > > > Update(1): There is also a OOM leak in the XDP_REDIRECT code, which > > receive_small() is likely also affected by. Found the issue behind this memory leak... page refcnt issues when

Re: [PATCH V6 2/4] sctp: Add ip option support

2018-02-18 Thread Richard Haines
On Fri, 2018-02-16 at 23:28 -0500, Neil Horman wrote: > On Fri, Feb 16, 2018 at 07:51:02PM -0200, Marcelo Ricardo Leitner > wrote: > > On Fri, Feb 16, 2018 at 03:14:35PM -0500, Neil Horman wrote: > > > On Fri, Feb 16, 2018 at 10:56:07AM -0200, Marcelo Ricardo Leitner > > > wrote: > > > > On Thu,