Tue, Feb 27, 2018 at 02:18:12AM CET, m...@redhat.com wrote:
>On Mon, Feb 26, 2018 at 05:02:18PM -0800, Stephen Hemminger wrote:
>> On Mon, 26 Feb 2018 08:19:24 +0100
>> Jiri Pirko wrote:
>>
>> > Sat, Feb 24, 2018 at 12:59:04AM CET, step...@networkplumber.org wrote:
>> > >On
On Mon, Feb 26, 2018 at 03:10:51PM -0500, David Miller wrote:
> From: Simon Horman
> Date: Mon, 26 Feb 2018 11:58:24 +0100
>
> > On Sat, Feb 24, 2018 at 09:53:17PM -0500, David Miller wrote:
> >> From: Sergei Shtylyov
> >> Date: Sat, 24
Hi Geert,
On Mon, Feb 26, 2018 at 07:28:47PM +0100, Geert Uytterhoeven wrote:
> Hi Jacopo,
>
> On Mon, Feb 26, 2018 at 6:57 PM, Jacopo Mondi
> wrote:
> > as discussed with you Sergei and Geert, in order to enable EtherAVB for
> > R8A77965 we first wanted to make the
Colin Ian King wrote:
> From: Colin Ian King
>
> Pointer q is initialized and then almost immediately afterwards being
> re-assigned the same value. Remove the second redundant assignment.
>
> Cleans up clang warning:
>
From: Arkadi Sharshevsky
Date: Mon, 26 Feb 2018 18:25:42 +0200
> Fix resource coverity errors.
>
> Fixes: d9f9b9a4d05f ("devlink: Add support for resource abstraction")
> Signed-off-by: Arkadi Sharshevsky
> Acked-by: Jiri Pirko
On 2/27/18 8:38 AM, Ido Schimmel wrote:
> Use extack inside team's enslavement function and also propagate it to
> the netdevice notifier to allow enslaved ports to report the failure
> reason. Example:
>
> $ teamd -t team0 -d -c '{"runner": {"name": "lacp"}}'
> $ ip link set dev lo master team0
> On Feb 27, 2018, at 8:42 AM, David Miller wrote:
>
> From: Song Liu
> Date: Mon, 26 Feb 2018 09:49:22 -0800
>
>> diff --git a/kernel/bpf/stackmap.c b/kernel/bpf/stackmap.c
>> index b0ecf43..e6a48ca 100644
>> --- a/kernel/bpf/stackmap.c
>> +++
Hi Grygorii,
I love your patch! Yet something to improve:
[auto build test ERROR on net-next/master]
[also build test ERROR on v4.16-rc3 next-20180227]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux
On 27/02/18 17:38, David Miller wrote:
> The problem is there are syntax errors in your email headers.
>
> Any time a person's name contains a special character like ".",
> that entire string must be enclosed in double quotes.
>
> This is the case for "John W. Linville" so please add proper
>
Hi Andrew,
On mar., févr. 27 2018, Andrew Lunn wrote:
> On Tue, Feb 27, 2018 at 11:24:02AM +0100, Gregory CLEMENT wrote:
>> Hi Andrew,
>>
>> On jeu., févr. 22 2018, Andrew Lunn wrote:
>>
>> > Not all boards using the mv88e6xxx switches have the interrupt
From: Antoine Tenart
Date: Mon, 26 Feb 2018 15:14:26 +0100
> From: Yan Markman
>
> Adjust MVPP2_MAX_TSO_SEGS and stop_threshold/wake_threshold
> for better TXQ utilization and performance.
>
> Signed-off-by: Yan Markman
Am Dienstag, den 27.02.2018, 07:13 -0800 schrieb Eric Dumazet:
> On Tue, 2018-02-27 at 07:09 -0800, Eric Dumazet wrote:
> >
> >
> > Note that for this one, it seems we also could perform stats updates in
> > BH context, since skb is queued via defer_bh()
> >
> > But simplicity wins I guess.
>
Hi David,
While this patch was generated by a machine (CodeAI), we manually
reviewed and submitted it to this mailing list. I do apologize for
the marketing speech. We'll try to tone that down.
-Ben
On Fri, Feb 23, 2018 at 10:57 AM, David Miller wrote:
> From: C0deAi
From: Edward Cree
Date: Mon, 26 Feb 2018 15:29:48 +
> This series introduces the ability to mark an ethtool steering filter to use
> RSS spreading, and the ability to create and configure multiple RSS contexts
> with different indirection tables, hash keys, and hash
On 2/27/2018 8:39 AM, Andy Lutomirski wrote:
> On Tue, Feb 27, 2018 at 5:32 AM, Alexei Starovoitov
> wrote:
>> [ Snip ]
> An earlier version of the patch set used the seccomp filter chain.
> Mickaël, what exactly was wrong with that approach other than that the
>
From: Jeff Kirsher
Date: Mon, 26 Feb 2018 13:39:24 -0800
> This series contains updates to i40e and i40evf only.
Pulled, but...
Please stop splitting Fixes: tags up into multiple lines. Make it
always one line no matter how long the string is.
Also, please make
Current code ("qeth_l3_ip_from_hash()") matches a queried address object
against objects in the IP table by IP address, Mask/Prefix Length and
MAC address ("qeth_l3_ipaddrs_is_equal()"). But what callers actually
require is either
a) "is this IP address registered" (ie. match by IP address only),
From: Madalin Bucur
Date: Mon, 26 Feb 2018 11:24:00 -0600
> Fixed an issue on the Tx path that was visible in netperf
> TCP_SENDFILE tests. Addressed another issue with Rx errors
> not being always counted. Adding control for allmulti.
>
> v2: rephrased commit message,
On Tue, 27 Feb 2018 14:06:50 +0200
Serhey Popovych wrote:
> Since commit 596b1c94aa38 ("iproute: build more easily on Android"),
> iproute2 uses types __kernel_long_t and __kernel_ulong_t but does not
> provide internal definitions for it.
>
> This means that
Edward, none of these postings are making it to the list.
The problem is there are syntax errors in your email headers.
Any time a person's name contains a special character like ".",
that entire string must be enclosed in double quotes.
This is the case for "John W. Linville" so please add
When all the test results are being supplied by plugins, we may
not want to see any test results for the command under test. So
make a "no-tap" option, to suppress test result output for
the command under test.
Brenda J. Butler (2):
tools: tc-testing: Better tap output
tools: tc-testing: Add
Make it easier for automated test platforms to parse the test results.
Signed-off-by: Brenda J. Butler
---
tools/testing/selftests/tc-testing/plugin-lib/valgrindPlugin.py | 2 +-
tools/testing/selftests/tc-testing/tdc.py | 6 +++---
2 files changed, 4
Add a command line arg to suppress tap output. Handy in case
all the tap output is being supplied by the plugins.
Signed-off-by: Brenda J. Butler
---
tools/testing/selftests/tc-testing/tdc.py | 36 +--
1 file changed, 25 insertions(+), 11
qeth_get_elements_for_range() doesn't know how to handle a 0-length
range (ie. start == end), and returns 1 when it should return 0.
Such ranges occur on TSO skbs, where the L2/L3/L4 headers (and thus all
of the skb's linear data) are skipped when mapping the skb into regular
buffer elements.
If the HW is not reachable, then none of the IPs in qeth's internal
table has been registered with the HW yet. So when deleting such an IP,
there's no need to stage it for deregistration - just drop it from
the table.
This fixes the "add-delete-add" scenario on an offline card, where the
the
This reverts commit cb816192d986f7596009dedcf2201fe2e5bc2aa7.
The issue this attempted to fix never actually occurs.
l3_add_rxip() checks (via l3_ip_from_hash()) if the requested address
was previously added to the card. If so, it returns -EEXIST and doesn't
call l3_add_ip().
As a result, the
If multiple IPA commands are build & sent out concurrently,
fill_ipacmd_header() may assign a seqno value to a command that's
different from what send_control_data() later assigns to this command's
reply.
This is due to other commands passing through send_control_data(),
and incrementing
Hi Dave,
please apply some more qeth patches for -net and stable.
One patch fixes a performance bug in the TSO path. Then there's several
more fixes for IP management on L3 devices - including a revert, so that
the subsequent fix cleanly applies to earlier kernels.
The final patch takes care of
Registering an IPv4 address with the HW takes quite a while, so we
temporarily drop the ip_htable lock. Any concurrent add/remove of the
same IP adjusts the IP's use count, and (on remove) is then blocked by
addr->in_progress.
After the register call has completed, we check the use count for
This series introduces the ability to mark an ethtool steering filter to use
RSS spreading, and the ability to create and configure multiple RSS contexts
with different indirection tables, hash keys, and hash fields.
An implementation for the sfc driver (for 7000-series and later SFC NICs) is
On 2/27/2018 9:36 AM, Andy Lutomirski wrote:
> On Tue, Feb 27, 2018 at 5:30 PM, Casey Schaufler
> wrote:
>> On 2/27/2018 8:39 AM, Andy Lutomirski wrote:
>>> On Tue, Feb 27, 2018 at 5:32 AM, Alexei Starovoitov
>>> wrote:
[ Snip ]
>>> An
Use extack inside team's enslavement function and also propagate it to
the netdevice notifier to allow enslaved ports to report the failure
reason. Example:
$ teamd -t team0 -d -c '{"runner": {"name": "lacp"}}'
$ ip link set dev lo master team0
Error: Loopback device can't be added as a team
From: Jon Maloy
Date: Mon, 26 Feb 2018 20:14:04 +0100
> In commit 60c253069632 ("tipc: fix race between poll() and
> setsockopt()") we introduced a pointer from struct tipc_group to the
> 'group_is_connected' flag in struct tipc_sock, so that this field can
> be checked
Colin Ian King wrote:
> Pointer tq is initialized with >ah_txq[queue] and then a few
> lines later is re-assigned the same value, hence this duplicate
> assignment is redundant and can be removed.
>
> Cleans up clang warning:
>
On (02/27/18 11:49), David Miller wrote:
> > Do I need to resend?
>
> Yes, see my other email.
do we need to resend patches not showing up in patchwork?
I recall seeing email about picking things manually from inbox
but missed this.
--Sowmini
On 2/27/18 9:09 AM, Stephen Suryaputra wrote:
> Thanks David for confirming that this is unintended.
>
> Given that, I think the fix isn't complete because when forwarding
> isn't enabled on the original incoming netdev, the ICMP shouldn't be
> generated. This diff fixes that case:
>
> diff
On Mon, Feb 26, 2018 at 10:13:52PM +0100, Daniel Borkmann wrote:
> Unlike other archs flush_icache_range() is a noop on x64, therefore
> remove the JIT's bpf_flush_icache() altogether since not needed.
>
> Reported-by: Linus Torvalds
> Signed-off-by: Daniel
> I don't find such statement from the man page:
> http://man7.org/linux/man-pages/man8/tc-police.8.html
> What am I missing?
Under MTU the man page states:
mtu BYTES[/BYTES]
This is the maximum packet size handled by the policer (larger
ones will be handled like they
On Mon, 2018-02-26 at 03:17 +0200, Michael S. Tsirkin wrote:
> So pointer rings work fine, but they have a problem: make them too small
> and not enough entries fit. Make them too large and you start flushing
> your cache and running out of memory.
>
> This is a new idea of mine: a ring backed
From: Sowmini Varadhan
Date: Tue, 27 Feb 2018 12:48:24 -0500
> Do I need to do something?
I don't see V3 in patchwork either, weird...
Please resend. If it doesn't make it again I will take care of
it and diagnose.
Thank you, and sorry for this.
Use a linked list to associate user-facing context IDs with FW-facing
context IDs (since the latter can change after an MC reset).
Signed-off-by: Edward Cree
---
drivers/net/ethernet/sfc/ef10.c | 273 ++
drivers/net/ethernet/sfc/efx.c
We use a two-step process to configure a filter with RSS spreading. First,
the RSS context is allocated and configured using ETHTOOL_SRSSH; this
returns an identifier (rss_context) which can then be passed to subsequent
invocations of ETHTOOL_SRXCLSRLINS to specify that the offset from the RSS
From: Johan Hedberg
Date: Mon, 26 Feb 2018 12:43:07 +0100
> Here are a two Bluetooth driver fixes for the 4.16 kernel.
>
> Please let me know if there are any issues pulling. Thanks.
Pulled, thanks Johan.
From: Kirill Tkhai
Date: Mon, 26 Feb 2018 15:59:10 +0300
> This patchset continues to review and to convert pernet_operations
> to async. Where it is possible, they are grouped by type of actions
> init/exit methods ([1/28], for example). I hope this will make
> the review
From: Stefan Schmidt
Date: Mon, 26 Feb 2018 16:41:35 +0100
> An update from ieee802154 for *net-next*
>
> Alexander corrected a setting which got lost during some 6lowpan rework
> a while back and Xue Liu provided us with a new driver for the MCR20A
> transceiver.
>
>
From: Song Liu
Date: Mon, 26 Feb 2018 09:49:22 -0800
> diff --git a/kernel/bpf/stackmap.c b/kernel/bpf/stackmap.c
> index b0ecf43..e6a48ca 100644
> --- a/kernel/bpf/stackmap.c
> +++ b/kernel/bpf/stackmap.c
> @@ -9,16 +9,18 @@
> #include
> #include
> #include
>
Hi David,
On Tue, Feb 27, 2018 at 11:13:06AM -0500, David Miller wrote:
> From: Antoine Tenart
> > From: Yan Markman
> > -#define MVPP2_MAX_TSO_SEGS 300
> > +#define MVPP2_MAX_TSO_SEGS 100
> > #define MVPP2_MAX_SKB_DESCS
On 2/23/18 4:12 AM, Eyal Birger wrote:
> This patchset extends tc to support the ipt ematch.
>
> The first patch adds the ability for ematch cmdline parsers
> to receive argc,argv parameters.
> The second patch adds the em_ipt module.
>
> Eyal Birger (2):
> tc: ematch: add parse_eopt_argv()
From: Mark Rustad
Date: Sun, 25 Feb 2018 19:19:11 -0800
> diff --git a/drivers/pci/iov.c b/drivers/pci/iov.c
> index 677924ae0350..ddd44a9d93ec 100644
> --- a/drivers/pci/iov.c
> +++ b/drivers/pci/iov.c
> @@ -367,6 +367,54 @@ static void sriov_disable(struct pci_dev
Negotiate the interface format with the MAC rather than requiring it to
be a fixed type specified solely by the SFP module. This allows modules
that can work with several different interface signalling formats to
select a format compatible with the MAC - for example, a Fiber module
supporing
Some BiDi modules (eg, FiberStore SFP-GE-BX) are not compliant with
1000BASE-BX as they use different wavelengths from the 1000BASE-BX
standard (eg, 1310nm/1550nm rather than 1310nm/1490nm). These modules
support 1000BASE-X ethernet, so detect them by a failure to find any
other support, the
From: Jon Nettleton
This patch is the result of work by both Jon Nettleton and Russell King.
Jon wrote the original patch, adding support for SFP modules which
require a power level greater than '1'.
Russell's changes:
- Fix the power levels for big-endian, and make the code
Included in this series are a further few updates for SFP support:
- Adding support for Fiberstore's non-standard BiDi modules operating
at 1310nm/1550nm wavelengths rather than the 1000BASE-BX standard of
1310nm/1490nm.
- Adding support for negotiating the PHY interface mode with the MAC,
Add the new maximum power level property to the SFP binding.
Signed-off-by: Russell King
---
Documentation/devicetree/bindings/net/sff,sfp.txt | 5 +
1 file changed, 5 insertions(+)
diff --git a/Documentation/devicetree/bindings/net/sff,sfp.txt
On Tue, Feb 27, 2018 at 5:32 AM, Alexei Starovoitov
wrote:
> On Tue, Feb 27, 2018 at 05:20:55AM +, Andy Lutomirski wrote:
>> On Tue, Feb 27, 2018 at 4:54 AM, Alexei Starovoitov
>> wrote:
>> > On Tue, Feb 27, 2018 at 04:40:34AM
From: Edward Cree
Date: Tue, 27 Feb 2018 16:10:07 +
> Hmm, this doesn't seem to have appeared in Patchwork.
> Do I need to resend?
Yes, see my other email.
Thank you.
On 02/27/2018 11:00 AM, Kees Cook wrote:
On Tue, Feb 27, 2018 at 6:53 AM, chris hyser wrote:
On 02/26/2018 11:38 PM, Kees Cook wrote:
On Mon, Feb 26, 2018 at 8:19 PM, Andy Lutomirski
wrote:
3. Straight-up bugs. Those are exactly as problematic
On Tue, Feb 27, 2018 at 10:29:26AM +0800, Jason Wang wrote:
>
>
> On 2018年02月27日 04:34, Michael S. Tsirkin wrote:
> > On Mon, Feb 26, 2018 at 11:15:42AM +0800, Jason Wang wrote:
> > > On 2018年02月26日 09:17, Michael S. Tsirkin wrote:
> > > > So pointer rings work fine, but they have a problem:
On (02/27/18 12:40), David Miller wrote:
>
> I'm expecting a V3 respin of your zerocopy notification changes
> if that is what you're talking about, and I therefore marked
> the most recent spin as "changes requested".
sorry, I'm confused - you are waiting for V4?
I am not seeing v3 on
From: Jiri Pirko
Date: Mon, 26 Feb 2018 10:59:53 +0100
> From: Arkadi Sharshevsky
>
> The current implementation checks the combined size of the children with
> the 'size' of the parent. The correct behavior is to check the combined
> size vs the pending
Thanks David for confirming that this is unintended.
Given that, I think the fix isn't complete because when forwarding
isn't enabled on the original incoming netdev, the ICMP shouldn't be
generated. This diff fixes that case:
diff --git a/net/ipv4/route.c b/net/ipv4/route.c
index
From: Heiner Kallweit
Date: Mon, 26 Feb 2018 20:50:32 +0100
> Am 26.02.2018 um 19:56 schrieb David Miller:
>> From: Heiner Kallweit
>> Date: Sat, 24 Feb 2018 16:53:23 +0100
>>
>>> @@ -736,8 +736,7 @@ struct ring_info {
>>> };
>>>
>>> enum
On Mon, 2018-02-26 at 22:42 +0100, Paolo Abeni wrote:
> This changeset moves ipvlan address under RCU protection, using
> a per ipvlan device spinlock to protect list mutation and RCU
> read access to protect list traversal.
>
> Also explicitly use RCU read lock to traverse the per port
> ipvlans
On Tue, Feb 27, 2018 at 5:30 PM, Casey Schaufler wrote:
> On 2/27/2018 8:39 AM, Andy Lutomirski wrote:
>> On Tue, Feb 27, 2018 at 5:32 AM, Alexei Starovoitov
>> wrote:
>>> [ Snip ]
>> An earlier version of the patch set used the seccomp
From: Sowmini Varadhan
Date: Tue, 27 Feb 2018 11:51:12 -0500
> On (02/27/18 11:49), David Miller wrote:
>> > Do I need to resend?
>>
>> Yes, see my other email.
>
> do we need to resend patches not showing up in patchwork?
> I recall seeing email about picking
From: Arnd Bergmann
Date: Mon, 26 Feb 2018 10:41:30 +0100
> We no longer depend on IPV6, but that now causes a link error with
> CONFIG_IPV6=m and CONFIG_IPVLAN=y:
>
> drivers/net/ipvlan/ipvlan_core.o: In function `ipvlan_queue_xmit':
> ipvlan_core.c:(.text+0x1440): undefined
Matthias Kaehlcke wrote:
> In _rtl92c_get_txpower_writeval_by_regulatory() the variable writeVal
> is assigned to itself in an if ... else statement, apparently only to
> document that the branch condition is handled and that a previously read
> value should be returned
Arnd Bergmann wrote:
> gcc-8 points out that source and destination of the memcpy() are
> always the same pointer, so the effect of memcpy() is undefined
> here (its arguments must not overlap):
>
> drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c: In function
>
From: David Ahern
Date: Mon, 26 Feb 2018 09:53:15 -0800
> Fixes: 153e1b84f477 ("selftests: Add FIB onlink tests")
> Reported-by: Ido Schimmel
> Signed-off-by: David Ahern
Applied, thanks David.
Hi,
As a heads-up, while fuzzing v4.16-rc3 on arm64 with Syzkaller, I hit a
system hang which I was able to minize to the reproducer below. It looks
like the system hang is an artifact of Syzkaller using panic_on_warn, as
dns_resolver_preparse can trigger a WARN_ONCE() in the bowels of
printk(),
On 2/26/18 4:49 PM, Mike Manning wrote:
> Setting an interface into a VRF fails with 'RTNETLINK answers: File
> exists' if one of its VLAN interfaces is already in the same VRF.
> As the VRF is an upper device of the VLAN interface, it is also showing
> up as an upper device of the interface
Don't include in the Rx bytecount of the packet sent up the stack:
the FCB (frame control block), and the padding bytes inserted by
the controller into the frame payload, nor the FCS. All these are
being pulled out of the skb by gfar_process_frame().
This issue is old, likely from the driver's
On 02/27/2018 02:58 PM, Sergei Shtylyov wrote:
> We have uninlined the sh_eth_{read|write}() functions introduced in the
> commit 4a55530f38e ("net: sh_eth: modify the definitions of register").
> Now remove *inline* from sh_eth_tsu_{read|write}() as well and move
> these functions from the
From: Sabrina Dubroca
Date: Tue, 27 Feb 2018 15:13:28 +0100
> 2018-02-26, 12:11:27 -0500, David Miller wrote:
>> From: Sabrina Dubroca
>> Date: Mon, 26 Feb 2018 17:56:19 +0100
>>
>> That's completely different to this case, which is a bonfide
On Tue, Feb 27, 2018 at 6:53 AM, chris hyser wrote:
> On 02/26/2018 11:38 PM, Kees Cook wrote:
>>
>> On Mon, Feb 26, 2018 at 8:19 PM, Andy Lutomirski
>> wrote:
>>>
>>> 3. Straight-up bugs. Those are exactly as problematic as verifier
>>> bugs in any
From: Sabrina Dubroca
Date: Mon, 26 Feb 2018 16:13:43 +0100
> According to RFC 1191 sections 3 and 4, ICMP frag-needed messages
> indicating an MTU below 68 should be rejected:
>
> A host MUST never reduce its estimate of the Path MTU below 68
> octets.
>
> and
Colin Ian King wrote:
> From: Colin Ian King
>
> Bit pattern IEEE80211_CHAN_NO_IR is being bit-wise or'd twice;
> remove the redundant 2nd IEEE80211_CHAN_NO_IR
>
> Signed-off-by: Colin Ian King
Patch applied to
I will make this tomorrow.
Thanks for attention!
Best regards
Yan Markman
Tel. 05-44732819
-Original Message-
From: Antoine Tenart [mailto:antoine.ten...@bootlin.com]
Sent: Tuesday, February 27, 2018 7:14 PM
To: David Miller
Cc: antoine.ten...@bootlin.com; Yan
Following previous changes to ip6mr, mr_table and mr6_table are
basically the same [up to mr6_table having additional '6' suffixes to
its variable names].
Move the common structure definition into a common header; This
requires renaming all references in ip6mr to variables that had the
distinct
mfc_cache and mfc6_cache are almost identical - the main difference is
in the origin/group addresses and comparison-key. Make a common
structure encapsulating most of the multicast routing logic - mr_mfc
and convert both ipmr and ip6mr into using it.
For easy conversion [casting, in this case]
On Tue, Feb 27, 2018 at 8:59 AM, chris hyser wrote:
> On 02/27/2018 11:00 AM, Kees Cook wrote:
>>
>> On Tue, Feb 27, 2018 at 6:53 AM, chris hyser
>> wrote:
>>>
>>> On 02/26/2018 11:38 PM, Kees Cook wrote:
On Mon, Feb 26, 2018 at 8:19
From: Sowmini Varadhan
Date: Tue, 27 Feb 2018 09:52:41 -0800
> Resending with acked-by additions: previous attempt does not show
> up in Patchwork. This time with a new mail Message-Id.
>
> RDS applications use predominantly request-response, transacation
> based
From: Hoang Le
We introduce a set/getsockopt for setting socket receive buffer per
individual socket. This has turned out to sometimes be necessary for
anycast and multicast receivers when used without flow control.
Signed-off-by: Hoang Le
On Mon, Feb 26, 2018 at 5:59 PM, David Miller wrote:
> From: Jeff Kirsher
> Date: Mon, 26 Feb 2018 10:07:43 -0800
>
>> This series contains updates to ixgbe and ixgbevf only.
> ...
>> Emil updates ixgbevf with several features and improvements
On Tue, Feb 27, 2018 at 12:58:55PM +0200, Denys Fedoryshchenko wrote:
> On 2018-02-23 12:07, Guillaume Nault wrote:
> > On Fri, Feb 23, 2018 at 11:41:43AM +0200, Denys Fedoryshchenko wrote:
> > > On 2018-02-23 11:38, Guillaume Nault wrote:
> > > > On Thu, Feb 22, 2018 at 08:51:19PM +0200, Denys
From: Niklas Cassel
Date: Mon, 26 Feb 2018 22:47:05 +0100
> stmmac barrier fixes and cleanup
Series applied, thank you.
From: Maxime Chevallier
Date: Tue, 27 Feb 2018 10:11:43 +0100
> +/* Find tcam entry with matched pair */
> +static int mvpp2_prs_vid_range_find(struct mvpp2 *priv, int pmap, u16 vid,
> + u16 mask)
> +{
> + struct
From: Sergei Shtylyov
Date: Tue, 27 Feb 2018 14:58:16 +0300
> We have uninlined the sh_eth_{read|write}() functions introduced in the
> commit 4a55530f38e ("net: sh_eth: modify the definitions of register").
> Now remove *inline* from sh_eth_tsu_{read|write}()
On 27/02/18 20:58, Yuval Mintz wrote:
> Since commit 8fb472c09b9d ("ipmr: improve hash scalability") ipmr has
> been using rhashtable as a basis for its mfc routes, but ip6mr is
> currently still using the old private MFC hash implementation.
>
> Align ip6mr to the current ipmr implementation.
>
On Thu, Feb 22, 2018 at 07:30:38PM +0100, Guillaume Nault wrote:
> On Wed, Feb 21, 2018 at 12:04:30PM -0800, Cong Wang wrote:
> > For me it looks like pch->clist is not removed from the list ppp->channels
> > when destroyed via ppp_release(). But I don't want to pretend I understand
> > ppp logic.
The two implementations have almost identical structures - vif_device and
mif_device. As a step toward uniforming the mr_tables, eliminate the
mif_device and relocate the vif_device definition into a new common
header file.
Also, introduce a common initializing function for setting most of the
Same as previously done with the mfc seq, the logic for the vif seq is
refactored to be shared between ipmr and ip6mr.
Signed-off-by: Yuval Mintz
---
include/linux/mroute_base.h | 33 ++
net/ipv4/ipmr.c | 49
With the exception of the final dump, ipmr and ip6mr have the exact same
seq logic for traversing a given mr_table. Refactor that code and make
it common.
Signed-off-by: Yuval Mintz
---
include/linux/mroute_base.h | 69
net/ipv4/ipmr.c
MFC_NOTIFY exists in ip6mr, probably as some legacy code
[was already removed for ipmr in commit
06bd6c0370bb ("net: ipmr: remove unused MFC_NOTIFY flag and make the flags
enum").
Remove it from ip6mr as well, and move the enum into a common file;
Notice MFC_OFFLOAD is currently only used by
The various MFC entries are being held in the same kind of mr_tables
for both ipmr and ip6mr, and their traversal logic is identical.
Also, with the exception of the addresses [and other small tidbits]
the major bulk of the nla setting is identical.
Unite as much of the dumping as possible
Historically ip6mr was based [cut-n-paste] on ipmr and the two have not
diverged too much. Apparently as ipv4 multicast routing is more common
than its ipv6 brethren modifications since then are mostly one-way,
affecting ipmr while leaving ip6mr unchanged.
This series is meant to re-factor both
Now that both ipmr and ip6mr are using the same mr_table structure,
we can have a common function to allocate & initialize a new instance.
Signed-off-by: Yuval Mintz
---
include/linux/mroute_base.h | 17 +
net/ipv4/ipmr.c | 27
Since commit 8fb472c09b9d ("ipmr: improve hash scalability") ipmr has
been using rhashtable as a basis for its mfc routes, but ip6mr is
currently still using the old private MFC hash implementation.
Align ip6mr to the current ipmr implementation.
Signed-off-by: Yuval Mintz
ipmr and ip6mr utilize the exact same methods for searching the
hashed resolved connections, difference being only in the construction
of the hash comparison key.
In order to unite the flow, introduce an mr_table operation set that
would contain the protocol specific information required for
In ipmr the mr_table socket is handled under RCU. Introduce the same
for ip6mr.
Signed-off-by: Yuval Mintz
---
include/linux/mroute6.h | 6 +++---
net/ipv6/ip6_output.c | 2 +-
net/ipv6/ip6mr.c| 45 +++--
3 files changed,
1 - 100 of 303 matches
Mail list logo