Re: [RFC PATCH v3 0/3] Enable virtio_net to act as a backup for a passthru device

2018-02-27 Thread Jiri Pirko
Tue, Feb 27, 2018 at 02:18:12AM CET, m...@redhat.com wrote: >On Mon, Feb 26, 2018 at 05:02:18PM -0800, Stephen Hemminger wrote: >> On Mon, 26 Feb 2018 08:19:24 +0100 >> Jiri Pirko wrote: >> >> > Sat, Feb 24, 2018 at 12:59:04AM CET, step...@networkplumber.org wrote: >> > >On

Re: [PATCH] DT: net: renesas,ravb: document R8A77980 bindings

2018-02-27 Thread Simon Horman
On Mon, Feb 26, 2018 at 03:10:51PM -0500, David Miller wrote: > From: Simon Horman > Date: Mon, 26 Feb 2018 11:58:24 +0100 > > > On Sat, Feb 24, 2018 at 09:53:17PM -0500, David Miller wrote: > >> From: Sergei Shtylyov > >> Date: Sat, 24

Re: [PATCH 0/8] R-Car M3-N: Enable EtherAVB device node

2018-02-27 Thread jacopo mondi
Hi Geert, On Mon, Feb 26, 2018 at 07:28:47PM +0100, Geert Uytterhoeven wrote: > Hi Jacopo, > > On Mon, Feb 26, 2018 at 6:57 PM, Jacopo Mondi > wrote: > > as discussed with you Sergei and Geert, in order to enable EtherAVB for > > R8A77965 we first wanted to make the

Re: wireless: zd1211rw: remove redundant assignment of pointer 'q'

2018-02-27 Thread Kalle Valo
Colin Ian King wrote: > From: Colin Ian King > > Pointer q is initialized and then almost immediately afterwards being > re-assigned the same value. Remove the second redundant assignment. > > Cleans up clang warning: >

Re: [PATCH net-next] devlink: Fix resource coverity errors

2018-02-27 Thread David Miller
From: Arkadi Sharshevsky Date: Mon, 26 Feb 2018 18:25:42 +0200 > Fix resource coverity errors. > > Fixes: d9f9b9a4d05f ("devlink: Add support for resource abstraction") > Signed-off-by: Arkadi Sharshevsky > Acked-by: Jiri Pirko

Re: [PATCH net-next] team: Use extack to report enslavement failures

2018-02-27 Thread David Ahern
On 2/27/18 8:38 AM, Ido Schimmel wrote: > Use extack inside team's enslavement function and also propagate it to > the netdevice notifier to allow enslaved ports to report the failure > reason. Example: > > $ teamd -t team0 -d -c '{"runner": {"name": "lacp"}}' > $ ip link set dev lo master team0

Re: [PATCH bpf-next 1/2] bpf: extend stackmap to save binary_build_id+offset instead of address

2018-02-27 Thread Song Liu
> On Feb 27, 2018, at 8:42 AM, David Miller wrote: > > From: Song Liu > Date: Mon, 26 Feb 2018 09:49:22 -0800 > >> diff --git a/kernel/bpf/stackmap.c b/kernel/bpf/stackmap.c >> index b0ecf43..e6a48ca 100644 >> --- a/kernel/bpf/stackmap.c >> +++

Re: regression?: ti: cpsw: warning from phy_connect()->sysfs_create_link()-sysfs_warn_dup()

2018-02-27 Thread kbuild test robot
Hi Grygorii, I love your patch! Yet something to improve: [auto build test ERROR on net-next/master] [also build test ERROR on v4.16-rc3 next-20180227] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux

Re: [PATCH RESEND net-next 0/2] ntuple filters with RSS

2018-02-27 Thread Edward Cree
On 27/02/18 17:38, David Miller wrote: > The problem is there are syntax errors in your email headers. > > Any time a person's name contains a special character like ".", > that entire string must be enclosed in double quotes. > > This is the case for "John W. Linville" so please add proper >

Re: [PATCH 0/2] mv88e6xxx: Poll when no interrupt defined

2018-02-27 Thread Gregory CLEMENT
Hi Andrew, On mar., févr. 27 2018, Andrew Lunn wrote: > On Tue, Feb 27, 2018 at 11:24:02AM +0100, Gregory CLEMENT wrote: >> Hi Andrew, >> >> On jeu., févr. 22 2018, Andrew Lunn wrote: >> >> > Not all boards using the mv88e6xxx switches have the interrupt

Re: [PATCH net-next 2/3] net: mvpp2: adjust gso stop wake thresholds

2018-02-27 Thread David Miller
From: Antoine Tenart Date: Mon, 26 Feb 2018 15:14:26 +0100 > From: Yan Markman > > Adjust MVPP2_MAX_TSO_SEGS and stop_threshold/wake_threshold > for better TXQ utilization and performance. > > Signed-off-by: Yan Markman

Re: inconsistent lock state with usbnet/asix usb ethernet and xhci

2018-02-27 Thread Oliver Neukum
Am Dienstag, den 27.02.2018, 07:13 -0800 schrieb Eric Dumazet: > On Tue, 2018-02-27 at 07:09 -0800, Eric Dumazet wrote: > > > > > > Note that for this one, it seems we also could perform stats updates in > > BH context, since skb is queued via defer_bh() > > > > But simplicity wins I guess. >

Re: [PATCH] Remove useless assignment in ip_do_fragment

2018-02-27 Thread Code AI
Hi David, While this patch was generated by a machine (CodeAI), we manually reviewed and submitted it to this mailing list. I do apologize for the marketing speech. We'll try to tone that down. -Ben On Fri, Feb 23, 2018 at 10:57 AM, David Miller wrote: > From: C0deAi

Re: [PATCH net-next 0/2] ntuple filters with RSS

2018-02-27 Thread David Miller
From: Edward Cree Date: Mon, 26 Feb 2018 15:29:48 + > This series introduces the ability to mark an ethtool steering filter to use > RSS spreading, and the ability to create and configure multiple RSS contexts > with different indirection tables, hash keys, and hash

Re: [PATCH bpf-next v8 05/11] seccomp,landlock: Enforce Landlock programs per process hierarchy

2018-02-27 Thread Casey Schaufler
On 2/27/2018 8:39 AM, Andy Lutomirski wrote: > On Tue, Feb 27, 2018 at 5:32 AM, Alexei Starovoitov > wrote: >> [ Snip ] > An earlier version of the patch set used the seccomp filter chain. > Mickaël, what exactly was wrong with that approach other than that the >

Re: [net-next 0/7][pull request] 40GbE Intel Wired LAN Driver Updates 2018-02-26

2018-02-27 Thread David Miller
From: Jeff Kirsher Date: Mon, 26 Feb 2018 13:39:24 -0800 > This series contains updates to i40e and i40evf only. Pulled, but... Please stop splitting Fixes: tags up into multiple lines. Make it always one line no matter how long the string is. Also, please make

[PATCH net 5/6] s390/qeth: fix IP address lookup for L3 devices

2018-02-27 Thread Julian Wiedmann
Current code ("qeth_l3_ip_from_hash()") matches a queried address object against objects in the IP table by IP address, Mask/Prefix Length and MAC address ("qeth_l3_ipaddrs_is_equal()"). But what callers actually require is either a) "is this IP address registered" (ie. match by IP address only),

Re: [net-next v2 0/4] DPAA Ethernet fixes

2018-02-27 Thread David Miller
From: Madalin Bucur Date: Mon, 26 Feb 2018 11:24:00 -0600 > Fixed an issue on the Tx path that was visible in netperf > TCP_SENDFILE tests. Addressed another issue with Rx errors > not being always counted. Adding control for allmulti. > > v2: rephrased commit message,

Re: [PATCH iproute2 1/3] ip: Fix compilation with kernel headers < 3.4

2018-02-27 Thread Stephen Hemminger
On Tue, 27 Feb 2018 14:06:50 +0200 Serhey Popovych wrote: > Since commit 596b1c94aa38 ("iproute: build more easily on Android"), > iproute2 uses types __kernel_long_t and __kernel_ulong_t but does not > provide internal definitions for it. > > This means that

Re: [PATCH RESEND net-next 0/2] ntuple filters with RSS

2018-02-27 Thread David Miller
Edward, none of these postings are making it to the list. The problem is there are syntax errors in your email headers. Any time a person's name contains a special character like ".", that entire string must be enclosed in double quotes. This is the case for "John W. Linville" so please add

[PATCH net-next 0/2] tools: tc-testing: notap option

2018-02-27 Thread Brenda J. Butler
When all the test results are being supplied by plugins, we may not want to see any test results for the command under test. So make a "no-tap" option, to suppress test result output for the command under test. Brenda J. Butler (2): tools: tc-testing: Better tap output tools: tc-testing: Add

[PATCH net-next 1/2] tools: tc-testing: Better tap output

2018-02-27 Thread Brenda J. Butler
Make it easier for automated test platforms to parse the test results. Signed-off-by: Brenda J. Butler --- tools/testing/selftests/tc-testing/plugin-lib/valgrindPlugin.py | 2 +- tools/testing/selftests/tc-testing/tdc.py | 6 +++--- 2 files changed, 4

[PATCH net-next 2/2] tools: tc-testing: Add notap option

2018-02-27 Thread Brenda J. Butler
Add a command line arg to suppress tap output. Handy in case all the tap output is being supplied by the plugins. Signed-off-by: Brenda J. Butler --- tools/testing/selftests/tc-testing/tdc.py | 36 +-- 1 file changed, 25 insertions(+), 11

[PATCH net 1/6] s390/qeth: fix overestimated count of buffer elements

2018-02-27 Thread Julian Wiedmann
qeth_get_elements_for_range() doesn't know how to handle a 0-length range (ie. start == end), and returns 1 when it should return 0. Such ranges occur on TSO skbs, where the L2/L3/L4 headers (and thus all of the skb's linear data) are skipped when mapping the skb into regular buffer elements.

[PATCH net 2/6] s390/qeth: fix IP removal on offline cards

2018-02-27 Thread Julian Wiedmann
If the HW is not reachable, then none of the IPs in qeth's internal table has been registered with the HW yet. So when deleting such an IP, there's no need to stage it for deregistration - just drop it from the table. This fixes the "add-delete-add" scenario on an offline card, where the the

[PATCH net 4/6] Revert "s390/qeth: fix using of ref counter for rxip addresses"

2018-02-27 Thread Julian Wiedmann
This reverts commit cb816192d986f7596009dedcf2201fe2e5bc2aa7. The issue this attempted to fix never actually occurs. l3_add_rxip() checks (via l3_ip_from_hash()) if the requested address was previously added to the card. If so, it returns -EEXIST and doesn't call l3_add_ip(). As a result, the

[PATCH net 6/6] s390/qeth: fix IPA command submission race

2018-02-27 Thread Julian Wiedmann
If multiple IPA commands are build & sent out concurrently, fill_ipacmd_header() may assign a seqno value to a command that's different from what send_control_data() later assigns to this command's reply. This is due to other commands passing through send_control_data(), and incrementing

[PATCH net 0/6] s390/qeth: fixes 2018-02-27

2018-02-27 Thread Julian Wiedmann
Hi Dave, please apply some more qeth patches for -net and stable. One patch fixes a performance bug in the TSO path. Then there's several more fixes for IP management on L3 devices - including a revert, so that the subsequent fix cleanly applies to earlier kernels. The final patch takes care of

[PATCH net 3/6] s390/qeth: fix double-free on IP add/remove race

2018-02-27 Thread Julian Wiedmann
Registering an IPv4 address with the HW takes quite a while, so we temporarily drop the ip_htable lock. Any concurrent add/remove of the same IP adjusts the IP's use count, and (on remove) is then blocked by addr->in_progress. After the register call has completed, we check the use count for

[PATCH RESEND net-next 0/2] ntuple filters with RSS

2018-02-27 Thread Edward Cree
This series introduces the ability to mark an ethtool steering filter to use RSS spreading, and the ability to create and configure multiple RSS contexts with different indirection tables, hash keys, and hash fields. An implementation for the sfc driver (for 7000-series and later SFC NICs) is

Re: [PATCH bpf-next v8 05/11] seccomp,landlock: Enforce Landlock programs per process hierarchy

2018-02-27 Thread Casey Schaufler
On 2/27/2018 9:36 AM, Andy Lutomirski wrote: > On Tue, Feb 27, 2018 at 5:30 PM, Casey Schaufler > wrote: >> On 2/27/2018 8:39 AM, Andy Lutomirski wrote: >>> On Tue, Feb 27, 2018 at 5:32 AM, Alexei Starovoitov >>> wrote: [ Snip ] >>> An

[PATCH net-next] team: Use extack to report enslavement failures

2018-02-27 Thread Ido Schimmel
Use extack inside team's enslavement function and also propagate it to the netdevice notifier to allow enslaved ports to report the failure reason. Example: $ teamd -t team0 -d -c '{"runner": {"name": "lacp"}}' $ ip link set dev lo master team0 Error: Loopback device can't be added as a team

Re: [net 1/1] tipc: correct initial value for group congestion flag

2018-02-27 Thread David Miller
From: Jon Maloy Date: Mon, 26 Feb 2018 20:14:04 +0100 > In commit 60c253069632 ("tipc: fix race between poll() and > setsockopt()") we introduced a pointer from struct tipc_group to the > 'group_is_connected' flag in struct tipc_sock, so that this field can > be checked

Re: ath5k: remove duplicated re-assignment to pointer 'tq'

2018-02-27 Thread Kalle Valo
Colin Ian King wrote: > Pointer tq is initialized with >ah_txq[queue] and then a few > lines later is re-assigned the same value, hence this duplicate > assignment is redundant and can be removed. > > Cleans up clang warning: >

Re: [PATCH net-next 0/2] ntuple filters with RSS

2018-02-27 Thread Sowmini Varadhan
On (02/27/18 11:49), David Miller wrote: > > Do I need to resend? > > Yes, see my other email. do we need to resend patches not showing up in patchwork? I recall seeing email about picking things manually from inbox but missed this. --Sowmini

Re: VRF destination unreachable

2018-02-27 Thread David Ahern
On 2/27/18 9:09 AM, Stephen Suryaputra wrote: > Thanks David for confirming that this is unintended. > > Given that, I think the fix isn't complete because when forwarding > isn't enabled on the original incoming netdev, the ICMP shouldn't be > generated. This diff fixes that case: > > diff

Re: [PATCH bpf-next] bpf, x64: remove bpf_flush_icache

2018-02-27 Thread Alexei Starovoitov
On Mon, Feb 26, 2018 at 10:13:52PM +0100, Daniel Borkmann wrote: > Unlike other archs flush_icache_range() is a noop on x64, therefore > remove the JIT's bpf_flush_icache() altogether since not needed. > > Reported-by: Linus Torvalds > Signed-off-by: Daniel

Re: [PATCH] net: make tc-police action MTU behavior match documentation

2018-02-27 Thread Andrew Collins
> I don't find such statement from the man page: > http://man7.org/linux/man-pages/man8/tc-police.8.html > What am I missing? Under MTU the man page states: mtu BYTES[/BYTES] This is the maximum packet size handled by the policer (larger ones will be handled like they

Re: [RFC PATCH v2] ptr_ring: linked list fallback

2018-02-27 Thread Eric Dumazet
On Mon, 2018-02-26 at 03:17 +0200, Michael S. Tsirkin wrote: > So pointer rings work fine, but they have a problem: make them too small > and not enough entries fit. Make them too large and you start flushing > your cache and running out of memory. > > This is a new idea of mine: a ring backed

Re: [PATCH net-next 0/2] ntuple filters with RSS

2018-02-27 Thread David Miller
From: Sowmini Varadhan Date: Tue, 27 Feb 2018 12:48:24 -0500 > Do I need to do something? I don't see V3 in patchwork either, weird... Please resend. If it doesn't make it again I will take care of it and diagnose. Thank you, and sorry for this.

[PATCH net-next 2/2] sfc: support RSS spreading of ethtool ntuple filters

2018-02-27 Thread Edward Cree
Use a linked list to associate user-facing context IDs with FW-facing context IDs (since the latter can change after an MC reset). Signed-off-by: Edward Cree --- drivers/net/ethernet/sfc/ef10.c | 273 ++ drivers/net/ethernet/sfc/efx.c

[PATCH net-next 1/2] net: ethtool: extend RXNFC API to support RSS spreading of filter matches

2018-02-27 Thread Edward Cree
We use a two-step process to configure a filter with RSS spreading. First, the RSS context is allocated and configured using ETHTOOL_SRSSH; this returns an identifier (rss_context) which can then be passed to subsequent invocations of ETHTOOL_SRXCLSRLINS to specify that the offset from the RSS

Re: pull request: bluetooth 2018-02-26

2018-02-27 Thread David Miller
From: Johan Hedberg Date: Mon, 26 Feb 2018 12:43:07 +0100 > Here are a two Bluetooth driver fixes for the 4.16 kernel. > > Please let me know if there are any issues pulling. Thanks. Pulled, thanks Johan.

Re: [PATCH net-next 00/28] Converting pernet_operations (part #3)

2018-02-27 Thread David Miller
From: Kirill Tkhai Date: Mon, 26 Feb 2018 15:59:10 +0300 > This patchset continues to review and to convert pernet_operations > to async. Where it is possible, they are grouped by type of actions > init/exit methods ([1/28], for example). I hope this will make > the review

Re: pull-request: ieee802154-next 2018-02-26

2018-02-27 Thread David Miller
From: Stefan Schmidt Date: Mon, 26 Feb 2018 16:41:35 +0100 > An update from ieee802154 for *net-next* > > Alexander corrected a setting which got lost during some 6lowpan rework > a while back and Xue Liu provided us with a new driver for the MCR20A > transceiver. > >

Re: [PATCH bpf-next 1/2] bpf: extend stackmap to save binary_build_id+offset instead of address

2018-02-27 Thread David Miller
From: Song Liu Date: Mon, 26 Feb 2018 09:49:22 -0800 > diff --git a/kernel/bpf/stackmap.c b/kernel/bpf/stackmap.c > index b0ecf43..e6a48ca 100644 > --- a/kernel/bpf/stackmap.c > +++ b/kernel/bpf/stackmap.c > @@ -9,16 +9,18 @@ > #include > #include > #include >

Re: [PATCH net-next 2/3] net: mvpp2: adjust gso stop wake thresholds

2018-02-27 Thread Antoine Tenart
Hi David, On Tue, Feb 27, 2018 at 11:13:06AM -0500, David Miller wrote: > From: Antoine Tenart > > From: Yan Markman > > -#define MVPP2_MAX_TSO_SEGS 300 > > +#define MVPP2_MAX_TSO_SEGS 100 > > #define MVPP2_MAX_SKB_DESCS

Re: [PATCH iproute2-next 0/2] tc: add ipt ematch

2018-02-27 Thread David Ahern
On 2/23/18 4:12 AM, Eyal Birger wrote: > This patchset extends tc to support the ipt ematch. > > The first patch adds the ability for ematch cmdline parsers > to receive argc,argv parameters. > The second patch adds the em_ipt module. > > Eyal Birger (2): > tc: ematch: add parse_eopt_argv()

Re: [RFC PATCH V3] virtio_pci: Add SR-IOV support

2018-02-27 Thread David Miller
From: Mark Rustad Date: Sun, 25 Feb 2018 19:19:11 -0800 > diff --git a/drivers/pci/iov.c b/drivers/pci/iov.c > index 677924ae0350..ddd44a9d93ec 100644 > --- a/drivers/pci/iov.c > +++ b/drivers/pci/iov.c > @@ -367,6 +367,54 @@ static void sriov_disable(struct pci_dev

[PATCH net-next 2/4] phylink,sfp: negotiate interface format with MAC

2018-02-27 Thread Russell King
Negotiate the interface format with the MAC rather than requiring it to be a fixed type specified solely by the SFP module. This allows modules that can work with several different interface signalling formats to select a format compatible with the MAC - for example, a Fiber module supporing

[PATCH net-next 1/4] sfp: support 1G BiDi (eg, FiberStore SFP-GE-BX) modules

2018-02-27 Thread Russell King
Some BiDi modules (eg, FiberStore SFP-GE-BX) are not compliant with 1000BASE-BX as they use different wavelengths from the 1000BASE-BX standard (eg, 1310nm/1550nm rather than 1310nm/1490nm). These modules support 1000BASE-X ethernet, so detect them by a failure to find any other support, the

[PATCH net-next 4/4] sfp: add high power module support

2018-02-27 Thread Russell King
From: Jon Nettleton This patch is the result of work by both Jon Nettleton and Russell King. Jon wrote the original patch, adding support for SFP modules which require a power level greater than '1'. Russell's changes: - Fix the power levels for big-endian, and make the code

[PATCH net-next 0/4] SFP updates

2018-02-27 Thread Russell King - ARM Linux
Included in this series are a further few updates for SFP support: - Adding support for Fiberstore's non-standard BiDi modules operating at 1310nm/1550nm wavelengths rather than the 1000BASE-BX standard of 1310nm/1490nm. - Adding support for negotiating the PHY interface mode with the MAC,

[PATCH net-next 3/4] dt-bindings: add maximum power level to SFP binding

2018-02-27 Thread Russell King
Add the new maximum power level property to the SFP binding. Signed-off-by: Russell King --- Documentation/devicetree/bindings/net/sff,sfp.txt | 5 + 1 file changed, 5 insertions(+) diff --git a/Documentation/devicetree/bindings/net/sff,sfp.txt

Re: [PATCH bpf-next v8 05/11] seccomp,landlock: Enforce Landlock programs per process hierarchy

2018-02-27 Thread Andy Lutomirski
On Tue, Feb 27, 2018 at 5:32 AM, Alexei Starovoitov wrote: > On Tue, Feb 27, 2018 at 05:20:55AM +, Andy Lutomirski wrote: >> On Tue, Feb 27, 2018 at 4:54 AM, Alexei Starovoitov >> wrote: >> > On Tue, Feb 27, 2018 at 04:40:34AM

Re: [PATCH net-next 0/2] ntuple filters with RSS

2018-02-27 Thread David Miller
From: Edward Cree Date: Tue, 27 Feb 2018 16:10:07 + > Hmm, this doesn't seem to have appeared in Patchwork. > Do I need to resend? Yes, see my other email. Thank you.

Re: [net-next v3 0/2] eBPF seccomp filters

2018-02-27 Thread chris hyser
On 02/27/2018 11:00 AM, Kees Cook wrote: On Tue, Feb 27, 2018 at 6:53 AM, chris hyser wrote: On 02/26/2018 11:38 PM, Kees Cook wrote: On Mon, Feb 26, 2018 at 8:19 PM, Andy Lutomirski wrote: 3. Straight-up bugs. Those are exactly as problematic

Re: [RFC PATCH v2] ptr_ring: linked list fallback

2018-02-27 Thread Michael S. Tsirkin
On Tue, Feb 27, 2018 at 10:29:26AM +0800, Jason Wang wrote: > > > On 2018年02月27日 04:34, Michael S. Tsirkin wrote: > > On Mon, Feb 26, 2018 at 11:15:42AM +0800, Jason Wang wrote: > > > On 2018年02月26日 09:17, Michael S. Tsirkin wrote: > > > > So pointer rings work fine, but they have a problem:

Re: [PATCH net-next 0/2] ntuple filters with RSS

2018-02-27 Thread Sowmini Varadhan
On (02/27/18 12:40), David Miller wrote: > > I'm expecting a V3 respin of your zerocopy notification changes > if that is what you're talking about, and I therefore marked > the most recent spin as "changes requested". sorry, I'm confused - you are waiting for V4? I am not seeing v3 on

Re: [patch net] devlink: Compare to size_new in case of resource child validation

2018-02-27 Thread David Miller
From: Jiri Pirko Date: Mon, 26 Feb 2018 10:59:53 +0100 > From: Arkadi Sharshevsky > > The current implementation checks the combined size of the children with > the 'size' of the parent. The correct behavior is to check the combined > size vs the pending

Re: VRF destination unreachable

2018-02-27 Thread Stephen Suryaputra
Thanks David for confirming that this is unintended. Given that, I think the fix isn't complete because when forwarding isn't enabled on the original incoming netdev, the ICMP shouldn't be generated. This diff fixes that case: diff --git a/net/ipv4/route.c b/net/ipv4/route.c index

Re: [PATCH net-next v2] r8169: improve interrupt handling

2018-02-27 Thread David Miller
From: Heiner Kallweit Date: Mon, 26 Feb 2018 20:50:32 +0100 > Am 26.02.2018 um 19:56 schrieb David Miller: >> From: Heiner Kallweit >> Date: Sat, 24 Feb 2018 16:53:23 +0100 >> >>> @@ -736,8 +736,7 @@ struct ring_info { >>> }; >>> >>> enum

Re: [PATCH net-next] ipvlan: use per device spinlock to protect addrs list updates

2018-02-27 Thread Paolo Abeni
On Mon, 2018-02-26 at 22:42 +0100, Paolo Abeni wrote: > This changeset moves ipvlan address under RCU protection, using > a per ipvlan device spinlock to protect list mutation and RCU > read access to protect list traversal. > > Also explicitly use RCU read lock to traverse the per port > ipvlans

Re: [PATCH bpf-next v8 05/11] seccomp,landlock: Enforce Landlock programs per process hierarchy

2018-02-27 Thread Andy Lutomirski
On Tue, Feb 27, 2018 at 5:30 PM, Casey Schaufler wrote: > On 2/27/2018 8:39 AM, Andy Lutomirski wrote: >> On Tue, Feb 27, 2018 at 5:32 AM, Alexei Starovoitov >> wrote: >>> [ Snip ] >> An earlier version of the patch set used the seccomp

Re: [PATCH net-next 0/2] ntuple filters with RSS

2018-02-27 Thread David Miller
From: Sowmini Varadhan Date: Tue, 27 Feb 2018 11:51:12 -0500 > On (02/27/18 11:49), David Miller wrote: >> > Do I need to resend? >> >> Yes, see my other email. > > do we need to resend patches not showing up in patchwork? > I recall seeing email about picking

Re: [PATCH] [net-next] ipvlan: fix building with modular IPV6

2018-02-27 Thread David Miller
From: Arnd Bergmann Date: Mon, 26 Feb 2018 10:41:30 +0100 > We no longer depend on IPV6, but that now causes a link error with > CONFIG_IPV6=m and CONFIG_IPVLAN=y: > > drivers/net/ipvlan/ipvlan_core.o: In function `ipvlan_queue_xmit': > ipvlan_core.c:(.text+0x1440): undefined

Re: [v2] rtlwifi: rtl8192cu: Remove variable self-assignment in rf.c

2018-02-27 Thread Kalle Valo
Matthias Kaehlcke wrote: > In _rtl92c_get_txpower_writeval_by_regulatory() the variable writeVal > is assigned to itself in an if ... else statement, apparently only to > document that the branch condition is handled and that a previously read > value should be returned

Re: rtlwifi: rtl8192cu: remove pointless memcpy

2018-02-27 Thread Kalle Valo
Arnd Bergmann wrote: > gcc-8 points out that source and destination of the memcpy() are > always the same pointer, so the effect of memcpy() is undefined > here (its arguments must not overlap): > > drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c: In function >

Re: [PATCH net-next] selftests: Add fib-onlink-tests.sh to TEST_PROGS

2018-02-27 Thread David Miller
From: David Ahern Date: Mon, 26 Feb 2018 09:53:15 -0800 > Fixes: 153e1b84f477 ("selftests: Add FIB onlink tests") > Reported-by: Ido Schimmel > Signed-off-by: David Ahern Applied, thanks David.

dns_resolver_preparse tries to print arbitrarily-large user-provided strings

2018-02-27 Thread Mark Rutland
Hi, As a heads-up, while fuzzing v4.16-rc3 on arm64 with Syzkaller, I hit a system hang which I was able to minize to the reproducer below. It looks like the system hang is an artifact of Syzkaller using panic_on_warn, as dns_resolver_preparse can trigger a WARN_ONCE() in the bowels of printk(),

Re: [PATCH] net: allow interface to be set into VRF if VLAN interface in same VRF

2018-02-27 Thread David Ahern
On 2/26/18 4:49 PM, Mike Manning wrote: > Setting an interface into a VRF fails with 'RTNETLINK answers: File > exists' if one of its VLAN interfaces is already in the same VRF. > As the VRF is an upper device of the VLAN interface, it is also showing > up as an upper device of the interface

[PATCH net] gianfar: Fix Rx byte accounting for ndev stats

2018-02-27 Thread Claudiu Manoil
Don't include in the Rx bytecount of the packet sent up the stack: the FCB (frame control block), and the padding bytes inserted by the controller into the frame payload, nor the FCS. All these are being pulled out of the skb by gfar_process_frame(). This issue is old, likely from the driver's

Re: [PATCH net-next] sh_eth: uninline TSU register accessors

2018-02-27 Thread Sergei Shtylyov
On 02/27/2018 02:58 PM, Sergei Shtylyov wrote: > We have uninlined the sh_eth_{read|write}() functions introduced in the > commit 4a55530f38e ("net: sh_eth: modify the definitions of register"). > Now remove *inline* from sh_eth_tsu_{read|write}() as well and move > these functions from the

Re: [PATCH net-next] ipv6: allow userspace to add IFA_F_OPTIMISTIC addresses

2018-02-27 Thread David Miller
From: Sabrina Dubroca Date: Tue, 27 Feb 2018 15:13:28 +0100 > 2018-02-26, 12:11:27 -0500, David Miller wrote: >> From: Sabrina Dubroca >> Date: Mon, 26 Feb 2018 17:56:19 +0100 >> >> That's completely different to this case, which is a bonfide

Re: [net-next v3 0/2] eBPF seccomp filters

2018-02-27 Thread Kees Cook
On Tue, Feb 27, 2018 at 6:53 AM, chris hyser wrote: > On 02/26/2018 11:38 PM, Kees Cook wrote: >> >> On Mon, Feb 26, 2018 at 8:19 PM, Andy Lutomirski >> wrote: >>> >>> 3. Straight-up bugs. Those are exactly as problematic as verifier >>> bugs in any

Re: [PATCH net] net: ipv4: don't allow setting net.ipv4.route.min_pmtu below 68

2018-02-27 Thread David Miller
From: Sabrina Dubroca Date: Mon, 26 Feb 2018 16:13:43 +0100 > According to RFC 1191 sections 3 and 4, ICMP frag-needed messages > indicating an MTU below 68 should be rejected: > > A host MUST never reduce its estimate of the Path MTU below 68 > octets. > > and

Re: brcmsmac: remove duplicated bit-wise or of IEEE80211_CHAN_NO_IR

2018-02-27 Thread Kalle Valo
Colin Ian King wrote: > From: Colin Ian King > > Bit pattern IEEE80211_CHAN_NO_IR is being bit-wise or'd twice; > remove the redundant 2nd IEEE80211_CHAN_NO_IR > > Signed-off-by: Colin Ian King Patch applied to

RE: [PATCH net-next 2/3] net: mvpp2: adjust gso stop wake thresholds

2018-02-27 Thread Yan Markman
I will make this tomorrow. Thanks for attention! Best regards Yan Markman Tel. 05-44732819 -Original Message- From: Antoine Tenart [mailto:antoine.ten...@bootlin.com] Sent: Tuesday, February 27, 2018 7:14 PM To: David Miller Cc: antoine.ten...@bootlin.com; Yan

[PATCH net-next 04/11] mroute*: Make mr_table a common struct

2018-02-27 Thread Yuval Mintz
Following previous changes to ip6mr, mr_table and mr6_table are basically the same [up to mr6_table having additional '6' suffixes to its variable names]. Move the common structure definition into a common header; This requires renaming all references in ip6mr to variables that had the distinct

[PATCH net-next 06/11] ipmr, ip6mr: Make mfc_cache a common structure

2018-02-27 Thread Yuval Mintz
mfc_cache and mfc6_cache are almost identical - the main difference is in the origin/group addresses and comparison-key. Make a common structure encapsulating most of the multicast routing logic - mr_mfc and convert both ipmr and ip6mr into using it. For easy conversion [casting, in this case]

Re: [net-next v3 0/2] eBPF seccomp filters

2018-02-27 Thread Kees Cook
On Tue, Feb 27, 2018 at 8:59 AM, chris hyser wrote: > On 02/27/2018 11:00 AM, Kees Cook wrote: >> >> On Tue, Feb 27, 2018 at 6:53 AM, chris hyser >> wrote: >>> >>> On 02/26/2018 11:38 PM, Kees Cook wrote: On Mon, Feb 26, 2018 at 8:19

Re: [PATCH RESEND V3 net-next 0/3] RDS: optimized notification for zerocopy completion

2018-02-27 Thread David Miller
From: Sowmini Varadhan Date: Tue, 27 Feb 2018 09:52:41 -0800 > Resending with acked-by additions: previous attempt does not show > up in Patchwork. This time with a new mail Message-Id. > > RDS applications use predominantly request-response, transacation > based

[net-next 1/1] tipc: sockopt(TIPC_SO_RCVBUF) for setting receive buffer

2018-02-27 Thread Jon Maloy
From: Hoang Le We introduce a set/getsockopt for setting socket receive buffer per individual socket. This has turned out to sometimes be necessary for anycast and multicast receivers when used without flow control. Signed-off-by: Hoang Le

Re: [net-next 00/13][pull request] 10GbE Intel Wired LAN Driver Updates 2018-02-26

2018-02-27 Thread Alexander Duyck
On Mon, Feb 26, 2018 at 5:59 PM, David Miller wrote: > From: Jeff Kirsher > Date: Mon, 26 Feb 2018 10:07:43 -0800 > >> This series contains updates to ixgbe and ixgbevf only. > ... >> Emil updates ixgbevf with several features and improvements

Re: ppp/pppoe, still panic 4.15.3 in ppp_push

2018-02-27 Thread Guillaume Nault
On Tue, Feb 27, 2018 at 12:58:55PM +0200, Denys Fedoryshchenko wrote: > On 2018-02-23 12:07, Guillaume Nault wrote: > > On Fri, Feb 23, 2018 at 11:41:43AM +0200, Denys Fedoryshchenko wrote: > > > On 2018-02-23 11:38, Guillaume Nault wrote: > > > > On Thu, Feb 22, 2018 at 08:51:19PM +0200, Denys

Re: [PATCH net-next 0/4] stmmac barrier fixes and cleanup

2018-02-27 Thread David Miller
From: Niklas Cassel Date: Mon, 26 Feb 2018 22:47:05 +0100 > stmmac barrier fixes and cleanup Series applied, thank you.

Re: [PATCH net-next] net: mvpp2: Add hardware offloading for VLAN filtering

2018-02-27 Thread David Miller
From: Maxime Chevallier Date: Tue, 27 Feb 2018 10:11:43 +0100 > +/* Find tcam entry with matched pair */ > +static int mvpp2_prs_vid_range_find(struct mvpp2 *priv, int pmap, u16 vid, > + u16 mask) > +{ > + struct

Re: [PATCH net-next] sh_eth: uninline TSU register accessors

2018-02-27 Thread David Miller
From: Sergei Shtylyov Date: Tue, 27 Feb 2018 14:58:16 +0300 > We have uninlined the sh_eth_{read|write}() functions introduced in the > commit 4a55530f38e ("net: sh_eth: modify the definitions of register"). > Now remove *inline* from sh_eth_tsu_{read|write}()

Re: [PATCH net-next 03/11] ip6mr: Align hash implementation to ipmr

2018-02-27 Thread Nikolay Aleksandrov
On 27/02/18 20:58, Yuval Mintz wrote: > Since commit 8fb472c09b9d ("ipmr: improve hash scalability") ipmr has > been using rhashtable as a basis for its mfc routes, but ip6mr is > currently still using the old private MFC hash implementation. > > Align ip6mr to the current ipmr implementation. >

Re: ppp/pppoe, still panic 4.15.3 in ppp_push

2018-02-27 Thread Guillaume Nault
On Thu, Feb 22, 2018 at 07:30:38PM +0100, Guillaume Nault wrote: > On Wed, Feb 21, 2018 at 12:04:30PM -0800, Cong Wang wrote: > > For me it looks like pch->clist is not removed from the list ppp->channels > > when destroyed via ppp_release(). But I don't want to pretend I understand > > ppp logic.

[PATCH net-next 01/11] ipmr,ipmr6: Define a uniform vif_device

2018-02-27 Thread Yuval Mintz
The two implementations have almost identical structures - vif_device and mif_device. As a step toward uniforming the mr_tables, eliminate the mif_device and relocate the vif_device definition into a new common header file. Also, introduce a common initializing function for setting most of the

[PATCH net-next 09/11] ipmr, ip6mr: Unite vif seq functions

2018-02-27 Thread Yuval Mintz
Same as previously done with the mfc seq, the logic for the vif seq is refactored to be shared between ipmr and ip6mr. Signed-off-by: Yuval Mintz --- include/linux/mroute_base.h | 33 ++ net/ipv4/ipmr.c | 49

[PATCH net-next 08/11] ipmr, ip6mr: Unite mfc seq logic

2018-02-27 Thread Yuval Mintz
With the exception of the final dump, ipmr and ip6mr have the exact same seq logic for traversing a given mr_table. Refactor that code and make it common. Signed-off-by: Yuval Mintz --- include/linux/mroute_base.h | 69 net/ipv4/ipmr.c

[PATCH net-next 10/11] ip6mr: Remove MFC_NOTIFY and refactor flags

2018-02-27 Thread Yuval Mintz
MFC_NOTIFY exists in ip6mr, probably as some legacy code [was already removed for ipmr in commit 06bd6c0370bb ("net: ipmr: remove unused MFC_NOTIFY flag and make the flags enum"). Remove it from ip6mr as well, and move the enum into a common file; Notice MFC_OFFLOAD is currently only used by

[PATCH net-next 11/11] ipmr, ip6mr: Unite dumproute flows

2018-02-27 Thread Yuval Mintz
The various MFC entries are being held in the same kind of mr_tables for both ipmr and ip6mr, and their traversal logic is identical. Also, with the exception of the addresses [and other small tidbits] the major bulk of the nla setting is identical. Unite as much of the dumping as possible

[PATCH net-next 00/11] ipmr, ip6mr: Align multicast routing for IPv4 & IPv6

2018-02-27 Thread Yuval Mintz
Historically ip6mr was based [cut-n-paste] on ipmr and the two have not diverged too much. Apparently as ipv4 multicast routing is more common than its ipv6 brethren modifications since then are mostly one-way, affecting ipmr while leaving ip6mr unchanged. This series is meant to re-factor both

[PATCH net-next 05/11] ipmr, ip6mr: Unite creation of new mr_table

2018-02-27 Thread Yuval Mintz
Now that both ipmr and ip6mr are using the same mr_table structure, we can have a common function to allocate & initialize a new instance. Signed-off-by: Yuval Mintz --- include/linux/mroute_base.h | 17 + net/ipv4/ipmr.c | 27

[PATCH net-next 03/11] ip6mr: Align hash implementation to ipmr

2018-02-27 Thread Yuval Mintz
Since commit 8fb472c09b9d ("ipmr: improve hash scalability") ipmr has been using rhashtable as a basis for its mfc routes, but ip6mr is currently still using the old private MFC hash implementation. Align ip6mr to the current ipmr implementation. Signed-off-by: Yuval Mintz

[PATCH net-next 07/11] ipmr, ip6mr: Unite logic for searching in MFC cache

2018-02-27 Thread Yuval Mintz
ipmr and ip6mr utilize the exact same methods for searching the hashed resolved connections, difference being only in the construction of the hash comparison key. In order to unite the flow, introduce an mr_table operation set that would contain the protocol specific information required for

[PATCH net-next 02/11] ip6mr: Make mroute_sk rcu-based

2018-02-27 Thread Yuval Mintz
In ipmr the mr_table socket is handled under RCU. Introduce the same for ip6mr. Signed-off-by: Yuval Mintz --- include/linux/mroute6.h | 6 +++--- net/ipv6/ip6_output.c | 2 +- net/ipv6/ip6mr.c| 45 +++-- 3 files changed,

  1   2   3   4   >