[PATCH net-next] r8169: fix interrupt number after adding support for MSI-X interrupts

2018-02-28 Thread Heiner Kallweit
In case of MSI-X the interrupt number may differ from pcidev->irq. Fix this by using pci_irq_vector(). Fixes: 6c6aa15fdea5 ("r8169: improve interrupt handling") Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.c | 5 +++-- 1 file changed, 3

Re: [PATCH RFC net-next 18/20] net/ipv6: separate handling of FIB entries from dst based routes

2018-02-28 Thread Martin KaFai Lau
On Sun, Feb 25, 2018 at 11:47:28AM -0800, David Ahern wrote: > Signed-off-by: David Ahern > --- > include/net/ip6_fib.h | 4 +- > include/net/ip6_route.h | 3 +- > net/ipv6/addrconf.c | 31 ++--- > net/ipv6/anycast.c | 7 +- > net/ipv6/ip6_fib.c |

[PATCH net] net: ethtool: don't ignore return from driver get_fecparam method

2018-02-28 Thread Edward Cree
If ethtool_ops->get_fecparam returns an error, pass that error on to the user, rather than ignoring it. Fixes: 1a5f3da20bd9 ("net: ethtool: add support for forward error correction modes") Signed-off-by: Edward Cree --- net/core/ethtool.c | 5 - 1 file changed, 4

Re: [PATCH net-next] r8169: fix interrupt number after adding support for MSI-X interrupts

2018-02-28 Thread David Miller
From: Heiner Kallweit Date: Wed, 28 Feb 2018 20:43:38 +0100 > In case of MSI-X the interrupt number may differ from pcidev->irq. > Fix this by using pci_irq_vector(). > > Fixes: 6c6aa15fdea5 ("r8169: improve interrupt handling") > Signed-off-by: Heiner Kallweit

[PATCH v2 net-next 1/1] tools: tc-testing: Add notap option

2018-02-28 Thread Brenda J. Butler
Add a command line arg to suppress tap output. Handy in case all the tap output is being supplied by the plugins. Signed-off-by: Brenda J. Butler --- v2: Drop the first patch that changes the format of the tap output. The second "notap" patch is reworked to apply

Re: [pull request][for-next 00/15] Mellanox, mlx5 RDMA E-Switch representors 2018-02-23

2018-02-28 Thread Doug Ledford
On Wed, 2018-02-28 at 09:55 -0500, David Miller wrote: > From: Saeed Mahameed > Date: Mon, 26 Feb 2018 12:36:02 -0800 > > > This series includes shared code updates for mlx5 core driver for both > > netdev and rdma subsystems. This series should be pulled to both > > trees

[PATCH net-next v2 3/5] net: phy: teranetics: Utilize generic functions

2018-02-28 Thread Florian Fainelli
Update teranetics_aneg_done() to use genphy_c45_aneg_done() instead of duplicating that code, and switch to gen10g_* functions where appropriate instead of maintaining identical copies doing nothing. Signed-off-by: Florian Fainelli --- drivers/net/phy/teranetics.c | 30

[PATCH net-next v2 1/5] net: phy: aquantia: Utilize genphy_c45_aneg_done()

2018-02-28 Thread Florian Fainelli
The driver duplicates what the generic function does, so use the generic function intead. Signed-off-by: Florian Fainelli --- drivers/net/phy/aquantia.c | 20 ++-- 1 file changed, 6 insertions(+), 14 deletions(-) diff --git a/drivers/net/phy/aquantia.c

[PATCH net-next v2 2/5] net: phy: Export gen10g_* functions

2018-02-28 Thread Florian Fainelli
In order to remove a fair amount of duplication in the different 10G PHY drivers, export all gen10g_* functions to be able to make use of those. While we are at it, rename gen10g_soft_reset() to gen10g_no_soft_reset() to illustrate what it does. Signed-off-by: Florian Fainelli

[PATCH net-next v2 0/5] net: phy: Reduce duplication

2018-02-28 Thread Florian Fainelli
Hi all, This patch series reduces the duplication among 10G PHY drivers that just essentially stub most functions, but do that while replicating what the existing generic functions do. Changes in v2: - rename gen10g_soft_reset() to gen10g_no_soft_reset() to better illustrate what it does (or

Re: [PATCH RFC net-next 18/20] net/ipv6: separate handling of FIB entries from dst based routes

2018-02-28 Thread David Ahern
On 2/28/18 11:44 AM, Martin KaFai Lau wrote: > On Sun, Feb 25, 2018 at 11:47:28AM -0800, David Ahern wrote: >> Signed-off-by: David Ahern >> --- >> include/net/ip6_fib.h | 4 +- >> include/net/ip6_route.h | 3 +- >> net/ipv6/addrconf.c | 31 ++--- >>

Re: [PATCH net-next 0/6] tcp: remove non GSO code

2018-02-28 Thread Marcelo Ricardo Leitner
On Wed, Feb 21, 2018 at 02:37:48PM -0500, David Miller wrote: > From: Eric Dumazet > Date: Mon, 19 Feb 2018 11:56:46 -0800 > > > Switching TCP to GSO mode, relying on core networking layers > > to perform eventual adaptation for dumb devices was overdue. > > > > 1) Most TCP

Re: [PATCH net-next 06/11] ipmr, ip6mr: Make mfc_cache a common structure

2018-02-28 Thread Yuval Mintz
On Wed, Feb 28, 2018 at 12:38:20AM +0200, Nikolay Aleksandrov wrote: > On 27/02/18 20:58, Yuval Mintz wrote: > > mfc_cache and mfc6_cache are almost identical - the main difference is > > in the origin/group addresses and comparison-key. Make a common > > structure encapsulating most of the

[PATCH v2] KEYS: DNS: limit the length of option strings

2018-02-28 Thread Eric Biggers
From: Eric Biggers Adding a dns_resolver key whose payload contains a very long option name resulted in that string being printed in full. This hit the WARN_ONCE() in set_precision() during the printk(), because printk() only supports a precision of up to 32767 bytes:

Re: [patch net v2 0/4] mlxsw: couple of fixes

2018-02-28 Thread Jiri Pirko
Wed, Feb 28, 2018 at 06:33:06PM CET, da...@davemloft.net wrote: >From: Jiri Pirko >Date: Wed, 28 Feb 2018 13:12:07 +0100 > >> Couple of unrelated fixes for mlxsw. > >Series applied with a typo fix in the commit message of patch #2 >(memcpu -- memcpy). Oh... Thanks!

Re: [PATCH] xen-netfront: Fix hang on device removal

2018-02-28 Thread Juergen Gross
On 28/02/18 13:23, Jason Andryuk wrote: > A toolstack may delete the vif frontend and backend xenstore entries > while xen-netfront is in the removal code path. In that case, the > checks for xenbus_read_driver_state would return XenbusStateUnknown, and > xennet_remove would hang indefinitely.

Re: [PATCH net-next 5/5] net: phy: marvell10g: Utilize gen10g_soft_reset()

2018-02-28 Thread Russell King
On Wed, Feb 28, 2018 at 11:36:12AM -0800, Florian Fainelli wrote: > We do the same thing as the generic function: nothing, so utilize it. > > Signed-off-by: Florian Fainelli > --- > drivers/net/phy/marvell10g.c | 7 +-- > 1 file changed, 1 insertion(+), 6 deletions(-)

Re: [net-next v3 0/2] eBPF seccomp filters

2018-02-28 Thread Daniel Borkmann
On 02/28/2018 12:55 AM, chris hyser wrote: >> On 02/27/2018 04:58 PM, Daniel Borkmann wrote: >> On 02/27/2018 05:59 PM, >> chris hyser wrote: On 02/27/2018 11:00 AM, Kees Cook wrote: > On Tue, Feb 27, 2018 at 6:53 AM, chris hyser > wrote: >> On

I Hope You Get My Message This Time

2018-02-28 Thread Friedrich Mayrhofer
-- -- This is the second time i am sending you this mail.I, Friedrich Mayrhofer Donate $ 1,000,000.00 to You, Email Me personally for more details. Regards. Friedrich Mayrhofer

Re: [PATCH net-next v2 0/5] fib_rules: support sport, dport and proto match

2018-02-28 Thread David Miller
From: David Ahern Date: Wed, 28 Feb 2018 11:11:43 -0700 > Hi Dave: I'm not seeing it in your tree yet. I've been waiting on this > set for the next version of the L4 hashing for IPv6. Just pushed out, build test was still running :-)

Re: [PATCH] tcp: Support tcp socket allocated counter in namespace.

2018-02-28 Thread Stephen Hemminger
On Mon, 12 Feb 2018 18:44:00 -0800 Tonghao Zhang wrote: > Sometimes, we want to know how many tcp sockets are in use > different _net_ namespaces. It's a key resource metric. With > this patch, we can get it via /proc/net/sockstat. > > The 'alloc' show in

Re: [RFC PATCH v3 0/3] Enable virtio_net to act as a backup for a passthru device

2018-02-28 Thread Jiri Pirko
Wed, Feb 28, 2018 at 04:45:39PM CET, m...@redhat.com wrote: >On Wed, Feb 28, 2018 at 04:11:31PM +0100, Jiri Pirko wrote: >> Wed, Feb 28, 2018 at 03:32:44PM CET, m...@redhat.com wrote: >> >On Wed, Feb 28, 2018 at 08:08:39AM +0100, Jiri Pirko wrote: >> >> Tue, Feb 27, 2018 at 10:41:49PM CET,

Re: [PATCH net-next v2 0/5] fib_rules: support sport, dport and proto match

2018-02-28 Thread David Ahern
On 2/28/18 9:59 AM, David Miller wrote: > From: Roopa Prabhu > Date: Tue, 27 Feb 2018 19:52:40 -0800 > >> From: Roopa Prabhu >> >> This series extends fib rule match support to include sport, dport >> and ip proto match (to complete the

Re: [PATCH net] virtio-net: disable NAPI only when enabled during XDP set

2018-02-28 Thread Ben Greear
On 02/28/2018 09:22 AM, David Miller wrote: From: Jason Wang Date: Wed, 28 Feb 2018 18:20:04 +0800 We try to disable NAPI to prevent a single XDP TX queue being used by multiple cpus. But we don't check if device is up (NAPI is enabled), this could result stall because of

Re: [PATCH RFC net-next 10/20] net/ipv6: move expires into rt6_info

2018-02-28 Thread Martin KaFai Lau
On Mon, Feb 26, 2018 at 03:55:14PM -0700, David Ahern wrote: > On 2/26/18 3:28 PM, Wei Wang wrote: > >> @@ -213,11 +234,6 @@ static inline void rt6_set_expires(struct rt6_info > >> *rt, unsigned long expires) > >> > >> static inline void rt6_update_expires(struct rt6_info *rt0, int timeout) > >>

Re: [PATCH net-next 2/5] net: phy: Export gen10g_* functions

2018-02-28 Thread Russell King
On Wed, Feb 28, 2018 at 11:36:09AM -0800, Florian Fainelli wrote: > In order to remove a fair amount of duplication in the different 10G PHY > drivers, export all gen10g_* functions to be able to make use of those. The gen10g functions tend to be barely functional - for example,

[PATCH net-next v2 5/5] net: phy: marvell10g: Utilize gen10g_soft_reset()

2018-02-28 Thread Florian Fainelli
We do the same thing as the generic function: nothing, so utilize it. Signed-off-by: Florian Fainelli --- drivers/net/phy/marvell10g.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/net/phy/marvell10g.c

[PATCH net-next v2 4/5] net: phy: cortina: Utilize generic functions

2018-02-28 Thread Florian Fainelli
cortina_soft_reset() does the same thing as gen10g_soft_reset(), and cortina_config_aneg() is actually doing what gen10g_config_init() does for 10G capable PHYs. Signed-off-by: Florian Fainelli --- drivers/net/phy/cortina.c | 18 +++--- 1 file changed, 3

[PATCH net-next 0/5] net: phy: Reduce duplication

2018-02-28 Thread Florian Fainelli
Hi all, This patch series reduces the duplication among 10G PHY drivers that just essentially stub most functions, but do that while replicating what the existing generic functions do. Florian Fainelli (5): net: phy: aquantia: Utilize genphy_c45_aneg_done() net: phy: Export gen10g_*

[PATCH net-next 3/5] net: phy: teranetics: Utilize generic functions

2018-02-28 Thread Florian Fainelli
Update teranetics_aneg_done() to use genphy_c45_aneg_done() instead of duplicating that code, and switch to gen10g_* functions where appropriate instead of maintaining identical copies doing nothing. Signed-off-by: Florian Fainelli --- drivers/net/phy/teranetics.c | 30

[PATCH net-next 1/5] net: phy: aquantia: Utilize genphy_c45_aneg_done()

2018-02-28 Thread Florian Fainelli
The driver duplicates what the generic function does, so use the generic function intead. Signed-off-by: Florian Fainelli --- drivers/net/phy/aquantia.c | 20 ++-- 1 file changed, 6 insertions(+), 14 deletions(-) diff --git a/drivers/net/phy/aquantia.c

[PATCH net-next 2/5] net: phy: Export gen10g_* functions

2018-02-28 Thread Florian Fainelli
In order to remove a fair amount of duplication in the different 10G PHY drivers, export all gen10g_* functions to be able to make use of those. Signed-off-by: Florian Fainelli --- drivers/net/phy/phy-c45.c | 18 -- include/linux/phy.h | 8

pull-request: bpf 2018-02-28

2018-02-28 Thread Daniel Borkmann
Hi David, The following pull-request contains BPF updates for your *net* tree. The main changes are: 1) Add schedule points and reduce the number of loop iterations the test_bpf kernel module is performing in order to not hog the CPU for too long, from Eric. 2) Fix an out of bounds

Re: [RFC PATCH v3 0/3] Enable virtio_net to act as a backup for a passthru device

2018-02-28 Thread Michael S. Tsirkin
On Wed, Feb 28, 2018 at 08:25:01PM +0100, Jiri Pirko wrote: > Wed, Feb 28, 2018 at 04:45:39PM CET, m...@redhat.com wrote: > >On Wed, Feb 28, 2018 at 04:11:31PM +0100, Jiri Pirko wrote: > >> Wed, Feb 28, 2018 at 03:32:44PM CET, m...@redhat.com wrote: > >> >On Wed, Feb 28, 2018 at 08:08:39AM +0100,

Re: [PATCH net,v3] vrf: check forwarding on the original netdevice when generating ICMP dest unreachable

2018-02-28 Thread David Ahern
On 2/28/18 10:20 AM, Stephen Suryaputra wrote: > When ip_error() is called the device is the l3mdev master instead of the > original device. So the forwarding check should be on the original one. > > Changes from v2: > - Handle the original device disappearing (per David Ahern) > - Minimize the

Re: [PATCH] KEYS: DNS: limit the length of option strings

2018-02-28 Thread Eric Biggers
On Tue, Feb 27, 2018 at 06:34:19PM -0800, Eric Dumazet wrote: > On Tue, 2018-02-27 at 17:49 -0800, Eric Biggers wrote: > > From: Eric Biggers > > > > Adding a dns_resolver key whose payload contains a very long option name > > resulted in that string being printed in full.

[PATCH net-next 5/5] net: phy: marvell10g: Utilize gen10g_soft_reset()

2018-02-28 Thread Florian Fainelli
We do the same thing as the generic function: nothing, so utilize it. Signed-off-by: Florian Fainelli --- drivers/net/phy/marvell10g.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/net/phy/marvell10g.c b/drivers/net/phy/marvell10g.c

[PATCH net-next 4/5] net: phy: cortina: Utilize generic functions

2018-02-28 Thread Florian Fainelli
cortina_soft_reset() does the same thing as gen10g_soft_reset(), and cortina_config_aneg() is actually doing what gen10g_config_init() does for 10G capable PHYs. Signed-off-by: Florian Fainelli --- drivers/net/phy/cortina.c | 18 +++--- 1 file changed, 3

Re: [PATCH net-next 5/5] net: phy: marvell10g: Utilize gen10g_soft_reset()

2018-02-28 Thread Moritz Fischer
Florian, On Wed, Feb 28, 2018 at 11:44 AM, Russell King wrote: > On Wed, Feb 28, 2018 at 11:36:12AM -0800, Florian Fainelli wrote: >> We do the same thing as the generic function: nothing, so utilize it. >> >> Signed-off-by: Florian Fainelli >> --- >>

[PATCH v2 net-next 00/11] ipmr, ip6mr: Align multicast routing for IPv4 & IPv6

2018-02-28 Thread Yuval Mintz
Historically ip6mr was based [cut-n-paste] on ipmr and the two have not diverged too much. Apparently as ipv4 multicast routing is more common than its ipv6 brethren modifications since then are mostly one-way, affecting ipmr while leaving ip6mr unchanged. This series is meant to re-factor both

[PATCH v2 net-next 06/11] ipmr, ip6mr: Make mfc_cache a common structure

2018-02-28 Thread Yuval Mintz
mfc_cache and mfc6_cache are almost identical - the main difference is in the origin/group addresses and comparison-key. Make a common structure encapsulating most of the multicast routing logic - mr_mfc and convert both ipmr and ip6mr into using it. For easy conversion [casting, in this case]

[PATCH v2 net-next 04/11] mroute*: Make mr_table a common struct

2018-02-28 Thread Yuval Mintz
Following previous changes to ip6mr, mr_table and mr6_table are basically the same [up to mr6_table having additional '6' suffixes to its variable names]. Move the common structure definition into a common header; This requires renaming all references in ip6mr to variables that had the distinct

Re: [PATCH] selftests/bpf: Add bpf_probe_read_str to bpf_helpers.h

2018-02-28 Thread Daniel Borkmann
On 02/28/2018 10:28 PM, Tushar Dave wrote: > On 02/28/2018 08:57 AM, Daniel Borkmann wrote: >> Hi Tushar, >> >> On 02/28/2018 01:33 AM, Tushar Dave wrote: >>> Using bpf_probe_read_str() from samples/bpf causes compiler warning. >>> e.g. >>> warning: implicit declaration of function

[PATCH v2 net-next 03/11] ip6mr: Align hash implementation to ipmr

2018-02-28 Thread Yuval Mintz
Since commit 8fb472c09b9d ("ipmr: improve hash scalability") ipmr has been using rhashtable as a basis for its mfc routes, but ip6mr is currently still using the old private MFC hash implementation. Align ip6mr to the current ipmr implementation. Signed-off-by: Yuval Mintz

[PATCH v2 net-next 05/11] ipmr, ip6mr: Unite creation of new mr_table

2018-02-28 Thread Yuval Mintz
Now that both ipmr and ip6mr are using the same mr_table structure, we can have a common function to allocate & initialize a new instance. Signed-off-by: Yuval Mintz Acked-by: Nikolay Aleksandrov --- include/linux/mroute_base.h | 17

[PATCH v2 net-next 08/11] ipmr, ip6mr: Unite mfc seq logic

2018-02-28 Thread Yuval Mintz
With the exception of the final dump, ipmr and ip6mr have the exact same seq logic for traversing a given mr_table. Refactor that code and make it common. Signed-off-by: Yuval Mintz Acked-by: Nikolay Aleksandrov --- include/linux/mroute_base.h

[PATCH v4 iproute2-next 3/3] ip: Allow rules to accept a specified protocol

2018-02-28 Thread Donald Sharp
Allow the specification of a protocol when the user adds/modifies/deletes a rule. Signed-off-by: Donald Sharp --- ip/iprule.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/ip/iprule.c b/ip/iprule.c index 8120520e..6fdc9b5e 100644 --- a/ip/iprule.c +++

[PATCH v4 iproute2-next 0/3] Allow 'ip rule' command to use protocol

2018-02-28 Thread Donald Sharp
Fix iprule.c to use the actual `struct fib_rule_hdr` and to allow the end user to see and use the protocol keyword for rule manipulation. v2: Rearrange and code changes as per David Ahern v3: Fix some missed RTN_XXX to appropriate FR_XX and doc changes v4: Cleanup some code, fix 'ip rule save' no

[PATCH v4 iproute2-next 1/3] ip: Use the `struct fib_rule_hdr` for rules

2018-02-28 Thread Donald Sharp
The iprule.c code was using `struct rtmsg` as the data type to pass into the kernel for the netlink message. While 'struct rtmsg' and `struct fib_rule_hdr` are the same size and mostly the same, we should use the correct data structure. This commit translates the data structures to have iprule.c

[PATCH] IP6 Fragment: Export ip6_fragment function

2018-02-28 Thread Sheena Mira-ato
Export the ip6_fragment function so other loadable kernel modules can access it. The ipv4 version is already exported. --- net/ipv6/ip6_output.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/ipv6/ip6_output.c b/net/ipv6/ip6_output.c index 997c7f19ad62..8604031f0a93 100644 ---

Re: [PATCH iproute2 2/3] ss: Fix build with old libc headers without AF_VSOCK

2018-02-28 Thread Stephen Hemminger
On Tue, 27 Feb 2018 14:06:51 +0200 Serhey Popovych wrote: > diff --git a/include/compat/libc/bits/socket.h > b/include/compat/libc/bits/socket.h > new file mode 100644 > index 000..25ef0d5 > --- /dev/null > +++ b/include/compat/libc/bits/socket.h > @@ -0,0 +1,15 @@

[PATCH net-next 0/2] gre: add sequence number for collect md mode.

2018-02-28 Thread William Tu
Currently GRE sequence number can only be used in native tunnel mode. The first patch adds sequence number support for gre collect metadata mode, and the second patch tests it using BPF. RFC2890 defines GRE sequence number to be specific to the traffic flow identified by the key. However, this

[PATCH net-next 1/2] gre: add sequence number for collect md mode.

2018-02-28 Thread William Tu
Currently GRE sequence number can only be used in native tunnel mode. This patch adds sequence number support for gre collect metadata mode. RFC2890 defines GRE sequence number to be specific to the traffic flow identified by the key. However, this patch does not implement per-key seqno. The

Re: [PATCH] net: make tc-police action MTU behavior match documentation

2018-02-28 Thread Andrew Collins
From: Cong Wang > If this is just an iproute2 issue, please fix it there rather in kernel. I'm fine with fixing this as a documentation issue (fix being change man page, MTU "Defaults to unlimited" to "Defaults to 2047"). Note however this does mean that tc-police

Re: [PATCH] pci-iov: Add support for unmanaged SR-IOV

2018-02-28 Thread Alexander Duyck
On Wed, Feb 28, 2018 at 2:59 PM, Alex Williamson wrote: > On Wed, 28 Feb 2018 09:49:21 -0800 > Alexander Duyck wrote: > >> On Tue, Feb 27, 2018 at 2:25 PM, Alexander Duyck >> wrote: >> > On Tue, Feb 27, 2018 at

Re: [PATCH v2 net-next 06/11] ipmr, ip6mr: Make mfc_cache a common structure

2018-02-28 Thread Nikolay Aleksandrov
On 28/02/18 23:29, Yuval Mintz wrote: > mfc_cache and mfc6_cache are almost identical - the main difference is > in the origin/group addresses and comparison-key. Make a common > structure encapsulating most of the multicast routing logic - mr_mfc > and convert both ipmr and ip6mr into using it.

Re: [PATCH RFC net-next 10/20] net/ipv6: move expires into rt6_info

2018-02-28 Thread Martin KaFai Lau
On Wed, Feb 28, 2018 at 03:25:02PM -0700, David Ahern wrote: > On 2/28/18 12:21 PM, Martin KaFai Lau wrote: > > On Mon, Feb 26, 2018 at 03:55:14PM -0700, David Ahern wrote: > >> On 2/26/18 3:28 PM, Wei Wang wrote: > @@ -213,11 +234,6 @@ static inline void rt6_set_expires(struct rt6_info >

Re: [PATCH 5/6] net: add and use helpers when adjusting gso_size

2018-02-28 Thread Daniel Borkmann
On 03/01/2018 01:17 AM, Daniel Axtens wrote: [...] >>> It means that a user loaded eBPF program can trigger logs full of >>> warnings merely by using this eBPF helper and generating GSO'd SCTP >>> traffic. >>> >>> Daniel and Alexei, this is a serious problem. The eBPF helpers >>> mentioned here

[PATCH v2 net-next 5/5] net: dsa: mv88e6xxx: Get mv88e6352 SERDES statistics

2018-02-28 Thread Andrew Lunn
Add support for reading the SERDES statistics of the mv88e8352, using the standard ethtool -S option. The SERDES interface can be mapped to either port 4 or 5, so only return statistics on those ports, if the SERDES interface is in use. The counters are reset on read, so need to be accumulated.

[PATCH v2 net-next 3/5] net: dsa: mv88e6xxx: Allow the SERDES interfaces to have statistics

2018-02-28 Thread Andrew Lunn
When gettting the number of statistics, the strings and the actual statistics, call the SERDES ops if implemented. This means the stats code needs to return the number of strings/stats they have placed into the data, so that the SERDES strings/stats can follow on. Signed-off-by: Andrew Lunn

[PATCH v2 net-next 09/11] ipmr, ip6mr: Unite vif seq functions

2018-02-28 Thread Yuval Mintz
Same as previously done with the mfc seq, the logic for the vif seq is refactored to be shared between ipmr and ip6mr. Signed-off-by: Yuval Mintz Acked-by: Nikolay Aleksandrov --- include/linux/mroute_base.h | 33 ++

[PATCH v2 net-next 07/11] ipmr, ip6mr: Unite logic for searching in MFC cache

2018-02-28 Thread Yuval Mintz
ipmr and ip6mr utilize the exact same methods for searching the hashed resolved connections, difference being only in the construction of the hash comparison key. In order to unite the flow, introduce an mr_table operation set that would contain the protocol specific information required for

[PATCH v2 net-next 02/11] ip6mr: Make mroute_sk rcu-based

2018-02-28 Thread Yuval Mintz
In ipmr the mr_table socket is handled under RCU. Introduce the same for ip6mr. Signed-off-by: Yuval Mintz Acked-by: Nikolay Aleksandrov --- include/linux/mroute6.h | 6 +++--- net/ipv6/ip6_output.c | 2 +- net/ipv6/ip6mr.c| 45

[PATCH v2 net-next 11/11] ipmr, ip6mr: Unite dumproute flows

2018-02-28 Thread Yuval Mintz
The various MFC entries are being held in the same kind of mr_tables for both ipmr and ip6mr, and their traversal logic is identical. Also, with the exception of the addresses [and other small tidbits] the major bulk of the nla setting is identical. Unite as much of the dumping as possible

[PATCH v2 net-next 01/11] ipmr,ipmr6: Define a uniform vif_device

2018-02-28 Thread Yuval Mintz
The two implementations have almost identical structures - vif_device and mif_device. As a step toward uniforming the mr_tables, eliminate the mif_device and relocate the vif_device definition into a new common header file. Also, introduce a common initializing function for setting most of the

[PATCH v2 net-next 10/11] ip6mr: Remove MFC_NOTIFY and refactor flags

2018-02-28 Thread Yuval Mintz
MFC_NOTIFY exists in ip6mr, probably as some legacy code [was already removed for ipmr in commit 06bd6c0370bb ("net: ipmr: remove unused MFC_NOTIFY flag and make the flags enum"). Remove it from ip6mr as well, and move the enum into a common file; Notice MFC_OFFLOAD is currently only used by

Re: [PATCH iproute2] bpf: Print section name when hitting non ld64 issue

2018-02-28 Thread Daniel Borkmann
On 02/28/2018 11:16 PM, Joe Stringer wrote: > It's useful to be able to tell which section is being processed in the > ELF when this error is triggered, so print that detail. > > Signed-off-by: Joe Stringer Acked-by: Daniel Borkmann

Re: [PATCH net-next 0/2] tcp_bbr: more GSO work

2018-02-28 Thread Soheil Hassas Yeganeh
On Wed, Feb 28, 2018 at 5:40 PM Eric Dumazet wrote: > Playing with r8152 USB 1Gbit NIC, on both USB2 and USB3 slots, > I found that BBR was performing poorly, because of TSO being limited to 16KB > This patch series makes sure BBR is not under estimating number > of packets

Re: [PATCH] net/tcp/illinois: replace broken algorithm reference link

2018-02-28 Thread Joey Pabalinas
On Wed, Feb 28, 2018 at 12:03:58PM -0500, David Miller wrote: > Applied, thank you. No problem, cheers. -- Joey Pabalinas signature.asc Description: PGP signature

linux-next: build failure after merge of the net-next tree

2018-02-28 Thread Stephen Rothwell
Hi all, After merging the net-next tree, today's linux-next build (x86_64 allmodconfig) failed like this: net/core/devlink.c: In function 'devlink_resource_validate_size': net/core/devlink.c:2349:34: error: invalid type argument of '->' (have 'struct devlink_resource_size_params') if (size >

[PATCH v4 iproute2-next 2/3] ip: Display ip rule protocol used

2018-02-28 Thread Donald Sharp
Modify 'ip rule' command to notice when the kernel passes to us the originating protocol. Add code to allow the `ip rule flush protocol XXX` command to be accepted and properly handled. Modify the documentation to reflect these code changes. Signed-off-by: Donald Sharp

Re: [PATCH] net: make tc-police action MTU behavior match documentation

2018-02-28 Thread Cong Wang
On Tue, Feb 27, 2018 at 9:41 AM, Andrew Collins wrote: >> I don't find such statement from the man page: >> http://man7.org/linux/man-pages/man8/tc-police.8.html > > >> What am I missing? > > Under MTU the man page states: > > mtu BYTES[/BYTES] > This is

Re: [PATCH] pci-iov: Add support for unmanaged SR-IOV

2018-02-28 Thread Alex Williamson
On Wed, 28 Feb 2018 09:49:21 -0800 Alexander Duyck wrote: > On Tue, Feb 27, 2018 at 2:25 PM, Alexander Duyck > wrote: > > On Tue, Feb 27, 2018 at 1:40 PM, Alex Williamson > > wrote: > >> On Tue, 27 Feb 2018

[PATCH iproute2] bpf: Print section name when hitting non ld64 issue

2018-02-28 Thread Joe Stringer
It's useful to be able to tell which section is being processed in the ELF when this error is triggered, so print that detail. Signed-off-by: Joe Stringer --- lib/bpf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/bpf.c b/lib/bpf.c index 2db151e4dd3c..c38d92d87759

Re: [PATCH RFC net-next 10/20] net/ipv6: move expires into rt6_info

2018-02-28 Thread David Ahern
On 2/28/18 12:21 PM, Martin KaFai Lau wrote: > On Mon, Feb 26, 2018 at 03:55:14PM -0700, David Ahern wrote: >> On 2/26/18 3:28 PM, Wei Wang wrote: @@ -213,11 +234,6 @@ static inline void rt6_set_expires(struct rt6_info *rt, unsigned long expires) static inline void

F.LLI PISTOLESI Snc

2018-02-28 Thread . F.LLI PISTOLESI Snc
Hello , I am looking for a reliable supplier /manufacturer of products for sell in Europe. I came across your listing and wanted to get some information regarding minimum Order Quantities, FOB pricing and also the possibility of packaging including payments terms. So could you please get

Re: [PATCH net-next 5/5] net: phy: marvell10g: Utilize gen10g_soft_reset()

2018-02-28 Thread Florian Fainelli
On 02/28/2018 11:49 AM, Moritz Fischer wrote: > Florian, > > On Wed, Feb 28, 2018 at 11:44 AM, Russell King wrote: >> On Wed, Feb 28, 2018 at 11:36:12AM -0800, Florian Fainelli wrote: >>> We do the same thing as the generic function: nothing, so utilize it. >>> >>>

Re: [PATCH] pci-iov: Add support for unmanaged SR-IOV

2018-02-28 Thread Gregory Rose
On 2/28/2018 9:49 AM, Alexander Duyck wrote: On Tue, Feb 27, 2018 at 2:25 PM, Alexander Duyck wrote: On Tue, Feb 27, 2018 at 1:40 PM, Alex Williamson wrote: On Tue, 27 Feb 2018 11:06:54 -0800 Alexander Duyck

Re: [PATCH iproute2] devlink: Fix error reporting

2018-02-28 Thread Stephen Hemminger
On Wed, 28 Feb 2018 11:24:22 +0200 Arkadi Sharshevsky wrote: > The current code doesn't set errno in case of extended ack. > > Fixes: 049c58539f5d ("devlink: mnlg: Add support for extended ack") > Signed-off-by: Arkadi Sharshevsky > Acked-by: Jiri

[PATCH net-next 2/2] samples/bpf: add gre sequence number test.

2018-02-28 Thread William Tu
The patch adds tests for GRE sequence number support for metadata mode tunnel. Signed-off-by: William Tu --- samples/bpf/tcbpf2_kern.c | 6 -- samples/bpf/test_tunnel_bpf.sh | 4 ++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git

Re: [PATCH] selftests/bpf: Add bpf_probe_read_str to bpf_helpers.h

2018-02-28 Thread Tushar Dave
On 02/28/2018 08:57 AM, Daniel Borkmann wrote: Hi Tushar, On 02/28/2018 01:33 AM, Tushar Dave wrote: Using bpf_probe_read_str() from samples/bpf causes compiler warning. e.g. warning: implicit declaration of function 'bpf_probe_read_str' is invalid in C99

[PATCH 1/2] net: usb: asix88179_178a: set permanent address once only

2018-02-28 Thread Alexander Kurz
The permanent address of asix88179_178a devices is read at probe time and should not be overwritten later. Otherwise it may be overwritten unintentionally with a configured address. Signed-off-by: Alexander Kurz --- drivers/net/usb/ax88179_178a.c | 1 - 1 file changed, 1

[PATCH 2/2] net: usb: asix88179_178a: de-duplicate code

2018-02-28 Thread Alexander Kurz
Remove the duplicated code for asix88179_178a bind and reset methods. Signed-off-by: Alexander Kurz --- drivers/net/usb/ax88179_178a.c | 117 +++-- 1 file changed, 31 insertions(+), 86 deletions(-) diff --git a/drivers/net/usb/ax88179_178a.c

Re: [PATCH v2 net-next 07/11] ipmr, ip6mr: Unite logic for searching in MFC cache

2018-02-28 Thread Nikolay Aleksandrov
On 28/02/18 23:29, Yuval Mintz wrote: > ipmr and ip6mr utilize the exact same methods for searching the > hashed resolved connections, difference being only in the construction > of the hash comparison key. > > In order to unite the flow, introduce an mr_table operation set that > would contain

[PATCH net-next 2/2] tcp_bbr: remove bbr->tso_segs_goal

2018-02-28 Thread Eric Dumazet
Its value is computed then immediately used, there is no need to store it. Signed-off-by: Eric Dumazet --- net/ipv4/tcp_bbr.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/net/ipv4/tcp_bbr.c b/net/ipv4/tcp_bbr.c index

[PATCH net-next 1/2] tcp_bbr: better deal with suboptimal GSO (II)

2018-02-28 Thread Eric Dumazet
This is second part of dealing with suboptimal device gso parameters. In first patch (350c9f484bde "tcp_bbr: better deal with suboptimal GSO") we dealt with devices having low gso_max_segs Some devices lower gso_max_size from 64KB to 16 KB (r8152 is an example) In order to probe an optimal cwnd,

[PATCH net-next 0/2] tcp_bbr: more GSO work

2018-02-28 Thread Eric Dumazet
Playing with r8152 USB 1Gbit NIC, on both USB2 and USB3 slots, I found that BBR was performing poorly, because of TSO being limited to 16KB This patch series makes sure BBR is not under estimating number of packets that are needed to fill the pipe when a device has suboptimal TSO limits. Eric

linux-next: manual merge of the net-next tree with the net tree

2018-02-28 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: drivers/net/ethernet/mellanox/mlxsw/spectrum.c between commit: 77d270967c5f ("mlxsw: spectrum: Fix handling of resource_size_param") from the net tree and commit: 4f4bbf7c4e3d ("devlink: Perform cleanup of

[net-next PATCH] ixgbevf: fix unused variable warning

2018-02-28 Thread Arnd Bergmann
The new ixgbevf_set_rx_buffer_len() function causes a harmless warnings in configurations with large page size: drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c: In function 'ixgbevf_set_rx_buffer_len': drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c:1758:15: error: unused variable

Re: [PATCH 5/6] net: add and use helpers when adjusting gso_size

2018-02-28 Thread Daniel Axtens
Hi Daniel, >> It means that a user loaded eBPF program can trigger logs full of >> warnings merely by using this eBPF helper and generating GSO'd SCTP >> traffic. >> >> Daniel and Alexei, this is a serious problem. The eBPF helpers >> mentioned here cannot handle SCTP GSO packets properly, and

[PATCH v2 net-next 4/5] net: dsa: mv88e6xxx: Add helper to determining if port has SERDES

2018-02-28 Thread Andrew Lunn
Refactor the existing code. This helper will be used for SERDES statistics. Signed-off-by: Andrew Lunn Tested-by: Florian Fainelli --- v2: Use Boolean return value --- drivers/net/dsa/mv88e6xxx/serdes.c | 22 +- 1 file changed, 17

[PATCH v2] net: iucv: Free memory obtained by kzalloc

2018-02-28 Thread Arvind Yadav
Free memory, if afiucv_iucv_init is not successful. So calling put_device() before kfree(). This will decrement the last reference. Signed-off-by: Arvind Yadav --- changes in v2: Calling put_device() before kfree(). net/iucv/af_iucv.c | 5 - 1 file

[PATCH v2 1/4] net: rename skb_gso_validate_mtu -> skb_gso_validate_network_len

2018-02-28 Thread Daniel Axtens
If you take a GSO skb, and split it into packets, will the network length (L3 headers + L4 headers + payload) of those packets be small enough to fit within a given MTU? skb_gso_validate_mtu gives you the answer to that question. However, we recently added to add a way to validate the MAC length

[PATCH v2 4/4] net: make skb_gso_*_seglen functions private

2018-02-28 Thread Daniel Axtens
They're very hard to use properly as they do not consider the GSO_BY_FRAGS case. Code should use skb_gso_validate_network_len and skb_gso_validate_mac_len as they do consider this case. Make the seglen functions static, which stops people using them outside of skbuff.c Signed-off-by: Daniel

[PATCH v2 0/4] GSO_BY_FRAGS correctness improvements

2018-02-28 Thread Daniel Axtens
As requested [1], I went through and had a look at users of gso_size to see if there were things that need to be fixed to consider GSO_BY_FRAGS, and I have tried to improve our helper functions to deal with this case. I found a few. This fixes bugs relating to the use of skb_gso_*_seglen() where

[PATCH v2 2/4] net: sched: tbf: handle GSO_BY_FRAGS case in enqueue

2018-02-28 Thread Daniel Axtens
tbf_enqueue() checks the size of a packet before enqueuing it. However, the GSO size check does not consider the GSO_BY_FRAGS case, and so will drop GSO SCTP packets, causing a massive drop in throughput. Use skb_gso_validate_mac_len() instead, as it does consider that case. Signed-off-by:

[PATCH v2 3/4] net: xfrm: use skb_gso_validate_network_len() to check gso sizes

2018-02-28 Thread Daniel Axtens
Replace skb_gso_network_seglen() with skb_gso_validate_network_len(), as it considers the GSO_BY_FRAGS case. Signed-off-by: Daniel Axtens --- net/ipv4/xfrm4_output.c | 3 ++- net/ipv6/xfrm6_output.c | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git

[PATCH net-next 1/2] virtio-net: re enable XDP_REDIRECT for mergeable buffer

2018-02-28 Thread Jason Wang
XDP_REDIRECT support for mergeable buffer was removed since commit 7324f5399b06 ("virtio_net: disable XDP_REDIRECT in receive_mergeable() case"). This is because we don't reserve enough tailroom for struct skb_shared_info which breaks XDP assumption. Other complaints are, the complex linearize

[PATCH net-next 2/2] virtio-net: simplify XDP handling in small buffer

2018-02-28 Thread Jason Wang
We used to do data copy through xdp_linearize_page() for the buffer without sufficient headroom, it brings extra complexity without helping for the performance. So this patch remove it and switch to use generic XDP routine to handle this case. Signed-off-by: Jason Wang ---

Re: [PATCH] inet: add bound ports statistic

2018-02-28 Thread Eric Dumazet
On Wed, 2018-02-28 at 22:32 -0500, David Miller wrote: > From: Eric Dumazet > Date: Wed, 28 Feb 2018 18:28:02 -0800 > > > How useful it is to report this information ? > > > > Given REUSEADDR and REUSEPORT, I really wonder what can be derived from > > this counter. > >

  1   2   3   >