[PATCH 16/36] net: add support for ->poll_mask in proto_ops

2018-03-05 Thread Christoph Hellwig
The socket file operations still implement ->poll until all protocols are switched over. Signed-off-by: Christoph Hellwig --- include/linux/net.h | 3 +++ net/socket.c| 51 ++- 2 files changed, 49 insertions(+), 5

[PATCH 21/36] net/dccp: convert to ->poll_mask

2018-03-05 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig --- net/dccp/dccp.h | 3 +-- net/dccp/ipv4.c | 2 +- net/dccp/ipv6.c | 2 +- net/dccp/proto.c | 13 ++--- 4 files changed, 5 insertions(+), 15 deletions(-) diff --git a/net/dccp/dccp.h b/net/dccp/dccp.h index f91e3816806b..0ea2ee56ac1b

[PATCH v2 net-next 2/2] net: phy: use phy_disable_interrupts in phy_stop

2018-03-05 Thread Heiner Kallweit
Now that phy_disable_interrupts() can't take lock phydev->lock any longer, we can use it to simplify phy_stop(). Signed-off-by: Heiner Kallweit --- drivers/net/phy/phy.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/net/phy/phy.c

[PATCH 11/36] fs: update documentation for __poll_t

2018-03-05 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig --- Documentation/filesystems/Locking | 2 +- Documentation/filesystems/vfs.txt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/filesystems/Locking b/Documentation/filesystems/Locking index

[PATCH v2 net-next 2/5] net/ipv6: Address checks need to consider the L3 domain

2018-03-05 Thread David Ahern
ipv6_chk_addr_and_flags determines if an address is a local address. It is called by ip6_route_info_create to validate a gateway address is not a local address. It currently does not consider L3 domains and as a result does not allow a route to be added in one VRF if the nexthop points to an

[PATCH v2 net-next 1/5] net/ipv6: Refactor gateway validation on route add

2018-03-05 Thread David Ahern
Move gateway validation code from ip6_route_info_create into ip6_validate_gw. Code move plus adjustments to handle the potential reset of dev and idev and to make checkpatch happy. Signed-off-by: David Ahern --- net/ipv6/route.c | 120

[PATCH 23/36] net/vmw_vsock: convert to ->poll_mask

2018-03-05 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig --- net/vmw_vsock/af_vsock.c | 19 ++- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsock/af_vsock.c index e0fc84daed94..b9210329bda8 100644 --- a/net/vmw_vsock/af_vsock.c +++

[PATCH v2 net-next 1/2] net: phy: remove phy_error from phy_disable_interrupts

2018-03-05 Thread Heiner Kallweit
All callers of phy_disable_interrupts() call phy_error() in the error case. Therefore we don't need to do this within the function too. This change also allows us to use phy_disable_interrupts() in code holding phydev->lock (because phy_error() can take this lock). Signed-off-by: Heiner Kallweit

[PATCH v2 net-next 3/5] selftests: fib_tests: Use an alias for ip command

2018-03-05 Thread David Ahern
Replace 'ip -netns testns' with the alias IP. Shortens the line lengths and makes running the commands manually a bit easier. Signed-off-by: David Ahern --- tools/testing/selftests/net/fib_tests.sh | 169 --- 1 file changed, 85 insertions(+), 84

Re: [bpf-next PATCH 02/16] sockmap: convert refcnt to an atomic refcnt

2018-03-05 Thread David Miller
From: John Fastabend Date: Mon, 05 Mar 2018 11:51:06 -0800 > The sockmap refcnt up until now has been wrapped in the > sk_callback_lock(). So its not actually needed any locking of its > own. The counter itself tracks the lifetime of the psock object. > Sockets in a

[PATCH v2 net-next 4/5] selftests: fib_tests: Allow user to run a specific test

2018-03-05 Thread David Ahern
Allow a user to run just a specific fib test by setting the TEST environment variable. Signed-off-by: David Ahern --- tools/testing/selftests/net/fib_tests.sh | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git

[PATCH v2 net-next 5/5] selftests: fib_tests: Add IPv6 nexthop spec tests

2018-03-05 Thread David Ahern
Add series of tests for valid and invalid nexthop specs for IPv6. $ TEST=fib_nexthop_test ./fib_tests.sh ... IPv6 nexthop tests TEST: Directly connected nexthop, unicast address [ OK ] TEST: Directly connected nexthop, unicast address with device [ OK ] TEST: Gateway is

[PATCH 22/36] net/atm: convert to ->poll_mask

2018-03-05 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig --- net/atm/common.c | 11 +++ net/atm/common.h | 2 +- net/atm/pvc.c| 2 +- net/atm/svc.c| 2 +- 4 files changed, 6 insertions(+), 11 deletions(-) diff --git a/net/atm/common.c b/net/atm/common.c index fc78a0508ae1..1f2af59935db

[PATCH v2 net-next 0/5] net/ipv6: Address checks need to consider the L3 domain

2018-03-05 Thread David Ahern
IPv6 prohibits a local address from being used as a gateway for a route. However, it is ok for the local address to be in a different L3 domain (e.g., VRF); this allows, for example, veth pairs to connect VRFs. ip6_route_info_create calls ipv6_chk_addr_and_flags for gateway addresses to determine

[PATCH 24/36] net/tipc: convert to ->poll_mask

2018-03-05 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig --- net/tipc/socket.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/net/tipc/socket.c b/net/tipc/socket.c index b0323ec7971e..1ea1666e8e95 100644 --- a/net/tipc/socket.c +++ b/net/tipc/socket.c @@ -694,10 +694,9

Re: [bpf-next PATCH 01/16] sock: make static tls function alloc_sg generic sock helper

2018-03-05 Thread David Miller
From: John Fastabend Date: Mon, 05 Mar 2018 11:51:01 -0800 > The TLS ULP module builds scatterlists from a sock using > page_frag_refill(). This is going to be useful for other ULPs > so move it into sock file for more general use. > > In the process remove useless

[PATCH 26/36] net/bluetooth: convert to ->poll_mask

2018-03-05 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig --- include/net/bluetooth/bluetooth.h | 2 +- net/bluetooth/af_bluetooth.c | 7 ++- net/bluetooth/l2cap_sock.c| 2 +- net/bluetooth/rfcomm/sock.c | 2 +- net/bluetooth/sco.c | 2 +- 5 files changed, 6

[PATCH 28/36] net/nfc: convert to ->poll_mask

2018-03-05 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig --- net/nfc/llcp_sock.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/net/nfc/llcp_sock.c b/net/nfc/llcp_sock.c index 376040092142..b6010750e634 100644 --- a/net/nfc/llcp_sock.c +++ b/net/nfc/llcp_sock.c @@ -549,16

[PATCH 27/36] net/caif: convert to ->poll_mask

2018-03-05 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig --- net/caif/caif_socket.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/net/caif/caif_socket.c b/net/caif/caif_socket.c index a6fb1b3bcad9..c7991867d622 100644 --- a/net/caif/caif_socket.c +++

[PATCH 30/36] net/iucv: convert to ->poll_mask

2018-03-05 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig --- include/net/iucv/af_iucv.h | 2 -- net/iucv/af_iucv.c | 7 ++- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/include/net/iucv/af_iucv.h b/include/net/iucv/af_iucv.h index f4c21b5a1242..b0eaeb02d46d 100644 ---

[PATCH 29/36] net/phonet: convert to ->poll_mask

2018-03-05 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig --- net/phonet/socket.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/net/phonet/socket.c b/net/phonet/socket.c index 28d981512f5f..70ac4539d5b7 100644 --- a/net/phonet/socket.c +++ b/net/phonet/socket.c @@ -341,15

[net-next v2 1/3] igb: add VF trust infrastructure

2018-03-05 Thread Jeff Kirsher
From: Corinna Vinschen * Add a per-VF value to know if a VF is trusted, by default don't trust VFs. * Implement netdev op to trust VFs (igb_ndo_set_vf_trust) and add trust status to ndo_get_vf_config output. * Allow a trusted VF to change MAC and MAC filters even if

[net-next v2 2/3] igb: Do not call netif_device_detach() when PCIe link goes missing

2018-03-05 Thread Jeff Kirsher
From: Mika Westerberg When the driver notices that PCIe link is gone by reading 0x from a register it clears hw->hw_addr and then calls netif_device_detach(). This happens when the PCIe device is physically unplugged for example the user disconnected the

[net-next v2 3/3] igb: Fix a test with HWTSTAMP_TX_ON

2018-03-05 Thread Jeff Kirsher
From: Christophe JAILLET 'HWTSTAMP_TX_ON' should be handled as a value, not as a bit mask. The modified code should behave the same, because HWTSTAMP_TX_ON is 1 and no other possible values of 'tx_type' would match the test. However, this is more future-proof,

[net-next v2 0/3][pull request] 1GbE Intel Wired LAN Driver Updates 2018-03-05

2018-03-05 Thread Jeff Kirsher
This series contains updates to igb only. Corinna Vinschen adds the support for trusted VFs into the igb driver. Mika fixes an issue where PCIe device is physically unplugged can cause a kernel crash. This issue is that netif_device_detach() is called in these cases, which prevents

[PATCH 32/36] crypto: af_alg: convert to ->poll_mask

2018-03-05 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig --- crypto/af_alg.c | 13 +++-- crypto/algif_aead.c | 4 ++-- crypto/algif_skcipher.c | 4 ++-- include/crypto/if_alg.h | 3 +-- 4 files changed, 8 insertions(+), 16 deletions(-) diff --git a/crypto/af_alg.c b/crypto/af_alg.c

[PATCH 31/36] net/rxrpc: convert to ->poll_mask

2018-03-05 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig --- net/rxrpc/af_rxrpc.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/net/rxrpc/af_rxrpc.c b/net/rxrpc/af_rxrpc.c index 0c9c18aa7c77..d2440d5c3ce8 100644 --- a/net/rxrpc/af_rxrpc.c +++ b/net/rxrpc/af_rxrpc.c @@

[PATCH v2 net-next 0/2] net: phy: remove phy_error from phy_disable_interrupts

2018-03-05 Thread Heiner Kallweit
All callers of phy_disable_interrupts() call phy_error() in the error case. Therefore we don't need to do this within the function too. This change also allows us to use phy_disable_interrupts() in code holding phydev->lock (because phy_error() takes this lock). Make use of this in phy_stop().

[PATCH 35/36] timerfd: convert to ->poll_mask

2018-03-05 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig --- fs/timerfd.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/fs/timerfd.c b/fs/timerfd.c index cdad49da3ff7..d84a2bee4f82 100644 --- a/fs/timerfd.c +++ b/fs/timerfd.c @@ -226,21 +226,20 @@ static int

[PATCH 34/36] eventfd: switch to ->poll_mask

2018-03-05 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig --- fs/eventfd.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/fs/eventfd.c b/fs/eventfd.c index 012f5bd46dfa..d70b4907f978 100644 --- a/fs/eventfd.c +++ b/fs/eventfd.c @@ -101,14 +101,20 @@ static int

[PATCH 33/36] pipe: convert to ->poll_mask

2018-03-05 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig --- fs/pipe.c | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/fs/pipe.c b/fs/pipe.c index 7b1954caf388..81937590ea0a 100644 --- a/fs/pipe.c +++ b/fs/pipe.c @@ -509,19 +509,22 @@ static long

[PATCH 25/36] net/sctp: convert to ->poll_mask

2018-03-05 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig --- include/net/sctp/sctp.h | 3 +-- net/sctp/ipv6.c | 2 +- net/sctp/protocol.c | 2 +- net/sctp/socket.c | 4 +--- 4 files changed, 4 insertions(+), 7 deletions(-) diff --git a/include/net/sctp/sctp.h b/include/net/sctp/sctp.h

[PATCH 36/36] random: convert to ->poll_mask

2018-03-05 Thread Christoph Hellwig
The big change is that random_read_wait and random_write_wait are merged into a single waitqueue that uses keyed wakeups. Because wait_event_* doesn't know about that this will lead to occassional spurious wakeups in _random_read and add_hwgenerator_randomness, but wait_event_* is designed to

[PATCH 02/36] aio: remove an outdated comment in aio_complete

2018-03-05 Thread Christoph Hellwig
These days we don't treat sync iocbs special in the aio completion code as they never use it. Remove the old comment, and move the BUG_ON for a sync iocb to the top of the function. Signed-off-by: Christoph Hellwig Acked-by: Jeff Moyer --- fs/aio.c | 11

RE: [PATCH V2 net] qed: Free RoCE ILT Memory on rmmod qedr

2018-03-05 Thread Yuval Mintz
> - /* Free Task CXT */ > + /* Free Task CXT ( Intentionally RoCE as task-id is shared between > + * RoCE and iWARP > + */ Broken parenthesis In comment...

Re: [net-next 4/4] e1000e: allocate ring descriptors with dma_zalloc_coherent

2018-03-05 Thread David Miller
From: Jeff Kirsher Date: Mon, 05 Mar 2018 11:09:29 -0800 > On Mon, 2018-03-05 at 10:23 -0800, Eric Dumazet wrote: >> On Mon, 2018-03-05 at 10:16 -0800, Jeff Kirsher wrote: >> > From: Pierre-Yves Kerbrat >> > >> > Descriptor rings were not

Re: [next-queue PATCH v2 8/8] igb: Add support for adding offloaded clsflower filters

2018-03-05 Thread Jakub Kicinski
On Fri, 2 Mar 2018 10:43:44 -0800, Vinicius Costa Gomes wrote: > This allows filters added by tc-flower and specifying MAC addresses, > Ethernet types, and the VLAN priority field, to be offloaded to the > controller. > > This reuses most of the infrastructure used by ethtool, ethtool can be >

Re: [PATCH bpf-next 0/5] bpf, tracing: introduce bpf raw tracepoints

2018-03-05 Thread Steven Rostedt
On Mon, 5 Mar 2018 14:36:07 +0100 Daniel Borkmann wrote: > Ping, Peter/Steven. If you have a chance, please review the series. You're not off my radar, but I'm doing a lot of traveling for the next two weeks (started last week). I'll see if I can find some time to look at

Re: [PATCH] net/mlx4_en: fix potential use-after-free with dma_unmap_page

2018-03-05 Thread Sarah Newman
On 03/05/2018 02:09 AM, Tariq Toukan wrote: > > > On 05/03/2018 6:20 AM, Sarah Newman wrote: >> Take an additional reference to a page whenever it is placed >> into the rx ring and put the page again after running >> dma_unmap_page. >> >> When swiotlb is in use, calling dma_unmap_page means that

Re: [PATCH 5/8] dt-bindings: iommu/ipmmu-vmsa: Add R-Car M3-N (R8A77965)

2018-03-05 Thread Rob Herring
On Mon, Feb 26, 2018 at 06:57:13PM +0100, Jacopo Mondi wrote: > Add Renesas R-Car M3-N (R8A77965) compat string to IPMMU DT bindings > documentation. > > Signed-off-by: Jacopo Mondi > --- > Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.txt | 1 + > 1 file

Re: [for-next 09/14] {net,IB}/mlx5: Add has_tag to mlx5_flow_act

2018-03-05 Thread Jason Gunthorpe
On Mon, Mar 05, 2018 at 12:46:32PM -0800, Saeed Mahameed wrote: > From: Matan Barak > > The has_tag member will indicate whether a tag action was specified > in flow specification. It would be good to describe in the commit message why flow_act.flow_tag !=

Re: [for-next 08/14] IB/mlx5: Pass mlx5_flow_act struct instead of multiple arguments

2018-03-05 Thread Jason Gunthorpe
On Mon, Mar 05, 2018 at 12:46:31PM -0800, Saeed Mahameed wrote: > From: Boris Pismenny > > Group and pass all function arguments of parse_flow_attr call in one > common struct mlx5_flow_act. > > This patch passes all the action arguments of parse_flow_attr in one common >

Re: [for-next 10/14] net/mlx5: Add shim layer between fs and cmd

2018-03-05 Thread Jason Gunthorpe
On Mon, Mar 05, 2018 at 12:46:33PM -0800, Saeed Mahameed wrote: > +static struct mlx5_flow_cmds mlx5_flow_cmds = { 'static const' on these new static structs? Jason

Re: [PATCH] pci-iov: Add support for unmanaged SR-IOV

2018-03-05 Thread Don Dutile
On 03/01/2018 03:22 PM, Alex Williamson wrote: On Wed, 28 Feb 2018 16:36:38 -0800 Alexander Duyck wrote: On Wed, Feb 28, 2018 at 2:59 PM, Alex Williamson wrote: On Wed, 28 Feb 2018 09:49:21 -0800 Alexander Duyck

Re: [for-next 01/14] net/mlx5: Fixed sparse issues

2018-03-05 Thread Sergei Shtylyov
Hello! On 03/05/2018 11:46 PM, Saeed Mahameed wrote: > From: Aviad Yehezkel > > 1. Local fucntions should be static. Functions, > 2. Missing declarations warnings. Plkase do one thing per patch. > Signed-off-by: Aviad Yehezkel >

Re: [for-next 02/14] IB/mlx5: Removed not used parameters

2018-03-05 Thread Jason Gunthorpe
On Mon, Mar 05, 2018 at 12:46:25PM -0800, Saeed Mahameed wrote: > From: Aviad Yehezkel > > Signed-off-by: Aviad Yehezkel > Signed-off-by: Saeed Mahameed > drivers/infiniband/hw/mlx5/main.c | 2 -- >

Re: [for-next 01/14] net/mlx5: Fixed sparse issues

2018-03-05 Thread Or Gerlitz
On Mon, Mar 5, 2018 at 10:46 PM, Saeed Mahameed wrote: > From: Aviad Yehezkel > > 1. Local fucntions should be static. s/fucntions/functions/ > 2. Missing declarations warnings. > > Signed-off-by: Aviad Yehezkel > Signed-off-by:

[for-next 09/14] {net,IB}/mlx5: Add has_tag to mlx5_flow_act

2018-03-05 Thread Saeed Mahameed
From: Matan Barak The has_tag member will indicate whether a tag action was specified in flow specification. Signed-off-by: Matan Barak Reviewed-by: Aviad Yehezkel Signed-off-by: Saeed Mahameed ---

[for-next 02/14] IB/mlx5: Removed not used parameters

2018-03-05 Thread Saeed Mahameed
From: Aviad Yehezkel Signed-off-by: Aviad Yehezkel Signed-off-by: Saeed Mahameed --- drivers/infiniband/hw/mlx5/main.c | 2 -- drivers/infiniband/hw/mlx5/qp.c | 3 --- 2 files changed, 5 deletions(-) diff --git

[for-next 13/14] {net,IB}/mlx5: Add flow steering helpers

2018-03-05 Thread Saeed Mahameed
From: Boris Pismenny Add helper functions that check if a protocol is part of a flow steering match criteria. Signed-off-by: Boris Pismenny Signed-off-by: Matan Barak Signed-off-by: Aviad Yehezkel

[for-next 11/14] net/mlx5: Add empty egress namespace to flow steering core

2018-03-05 Thread Saeed Mahameed
From: Aviad Yehezkel Currently, we don't support egress flow steering namespace in mlx5 flow steering core implementation. However, when we want to encrypt a packet, we model it as a flow steering rule in the egress path. To overcome this, we add an empty egress namespace

[for-next 14/14] net/mlx5: Flow steering cmd interface should get the fte when deleting

2018-03-05 Thread Saeed Mahameed
From: Aviad Yehezkel Previously, deleting a flow steering entry only got the index. Since the FPGA implementation of FTE's deletion might need to dig inside the FTE itself, we would like to get the FTE's context. Changing the interface to pass the FTE context.

[for-next 12/14] net/mlx5: Embed mlx5_flow_act into fs_fte

2018-03-05 Thread Saeed Mahameed
From: Matan Barak fte objects contain the match value and action. Currently, extending the actions require in adding them both to the API and fs_fte. Signed-off-by: Matan Barak Signed-off-by: Aviad Yehezkel Signed-off-by: Saeed

[for-next 08/14] IB/mlx5: Pass mlx5_flow_act struct instead of multiple arguments

2018-03-05 Thread Saeed Mahameed
From: Boris Pismenny Group and pass all function arguments of parse_flow_attr call in one common struct mlx5_flow_act. This patch passes all the action arguments of parse_flow_attr in one common struct mlx5_flow_act. It allows us to scale the number of actions without

[for-next 10/14] net/mlx5: Add shim layer between fs and cmd

2018-03-05 Thread Saeed Mahameed
From: Matan Barak The shim layer allows each namespace to define possibly different functionality for add/delete/update commands. The shim layer introduced here, will be used to support flow steering with the FPGA. Signed-off-by: Matan Barak

[for-next 06/14] net/mlx5e: Removed not need synchronize_rcu

2018-03-05 Thread Saeed Mahameed
From: Aviad Yehezkel This is already done by xfrm layer between state_dev_del callback to state_dev_free callback. Signed-off-by: Aviad Yehezkel Signed-off-by: Saeed Mahameed ---

[for-next 07/14] net/mlx5: FPGA and IPSec initialization to be before flow steering

2018-03-05 Thread Saeed Mahameed
From: Matan Barak Some flow steering namespace initialization (i.e. egress namespace) might depend on FPGA capabilities. Changing the initialization order such that the FPGA will be initialized before flow steering. Flow steering fs cmds initialization might depend on IPSec

[for-next 05/14] net/mlx5e: Fixed sleeping inside atomic context

2018-03-05 Thread Saeed Mahameed
From: Aviad Yehezkel We can't allocate with GFP_KERNEL inside spinlock. Actually ida_simple doesn't require spinlock so remove it. Fixes: 547eede070eb ("net/mlx5e: IPSec, Innova IPSec offload infrastructure") Signed-off-by: Aviad Yehezkel

[for-next 04/14] net/mlx5e: Wait for FPGA command responses with a timeout

2018-03-05 Thread Saeed Mahameed
From: Aviad Yehezkel Generally, FPGA IPSec commands must always complete. We want to wait for one minute for them to complete gracefully also when killing a process. Signed-off-by: Aviad Yehezkel Signed-off-by: Saeed Mahameed

[pull request][for-next 00/14] Mellanox, mlx5 IPSec updates 2018-02-28-1

2018-03-05 Thread Saeed Mahameed
Hi Dave and Doug, This series includes shared code updates for mlx5 core driver for both netdev and rdma subsystems. This series should be pulled to both trees so we can continue netdev and rdma specific submissions separately. For more information please see tag log below. The series doesn't

[for-next 01/14] net/mlx5: Fixed sparse issues

2018-03-05 Thread Saeed Mahameed
From: Aviad Yehezkel 1. Local fucntions should be static. 2. Missing declarations warnings. Signed-off-by: Aviad Yehezkel Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 4 ++--

[for-next 03/14] net/mlx5: Fixed compilation issue when CONFIG_MLX5_ACCEL is disabled

2018-03-05 Thread Saeed Mahameed
From: Aviad Yehezkel IPSec init and cleanup functions also depends on linux/mlx5/driver.h. Signed-off-by: Aviad Yehezkel Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/accel/ipsec.h | 4 ++-- 1 file

Re: [PATCH net-next] net: phy: remove call to phy_error from phy_disable_interrupts

2018-03-05 Thread Andrew Lunn
On Mon, Mar 05, 2018 at 08:30:49PM +0100, Heiner Kallweit wrote: > All callers of phy_disable_interrupts() call phy_error() in the error > case. Therefore we don't need to do this within the function too. > This change also allows us to use phy_disable_interrupts() in code > holding phydev->lock

RE: [PATCH v4 net-next 1/2] lan743x: Add main source files for new lan743x driver

2018-03-05 Thread Bryan.Whitehead
> On Mon, Mar 05, 2018 at 02:23:30PM -0500, Bryan Whitehead wrote: > > Add main source files for new lan743x driver > > > > Signed-off-by: Bryan Whitehead > > For MDIO & PHY handling etc > > Reviewed-by: Andrew Lunn > > But i have not look at any

Re: [PATCH v4 net-next 1/2] lan743x: Add main source files for new lan743x driver

2018-03-05 Thread Andrew Lunn
On Mon, Mar 05, 2018 at 02:23:30PM -0500, Bryan Whitehead wrote: > Add main source files for new lan743x driver > > Signed-off-by: Bryan Whitehead For MDIO & PHY handling etc Reviewed-by: Andrew Lunn But i have not look at any packet handling,

[PATCH 21/25] slab: make usercopy region 32-bit

2018-03-05 Thread Alexey Dobriyan
If kmem case sizes are 32-bit, then usecopy region should be too. Cc: netdev@vger.kernel.org Signed-off-by: Alexey Dobriyan --- include/linux/slab.h | 2 +- include/linux/slab_def.h | 4 ++-- include/linux/slub_def.h | 4 ++-- include/net/sock.h | 4 ++--

[bpf-next PATCH 16/16] bpf: sockmap test script

2018-03-05 Thread John Fastabend
This adds the test script I am currently using to validate the latest sockmap changes. Shortly sockmap will be ported to selftests and these will be run from the infrastructure there. Until then add the script here so we have a coverage checklist when porting into selftests. Signed-off-by: John

[bpf-next PATCH 14/16] bpf: sockmap sample support for bpf_msg_cork_bytes()

2018-03-05 Thread John Fastabend
Add sample application support for the bpf_msg_cork_bytes helper. This lets the user specify how many bytes each verdict should apply to. Signed-off-by: John Fastabend --- include/uapi/linux/bpf_common.h |7 ++-- samples/sockmap/sockmap_kern.c

[bpf-next PATCH 12/16] bpf: sockmap sample, add data verification option

2018-03-05 Thread John Fastabend
To verify data is not being dropped or corrupted this adds an option to verify test-patterns on recv. Signed-off-by: John Fastabend --- samples/sockmap/sockmap_user.c | 118 1 file changed, 84 insertions(+), 34 deletions(-)

[bpf-next PATCH 15/16] sockmap: add SK_DROP tests

2018-03-05 Thread John Fastabend
Add tests for SK_DROP. Signed-off-by: John Fastabend --- samples/sockmap/sockmap_kern.c | 15 ++ samples/sockmap/sockmap_user.c | 62 ++-- 2 files changed, 61 insertions(+), 16 deletions(-) diff --git

[bpf-next PATCH 13/16] bpf: sockmap, add sample option to test apply_bytes helper

2018-03-05 Thread John Fastabend
This adds an option to test the apply_bytes helper. This option lets the user specify an int on the command line specifying how much data each verdict should apply to. When this is set a map entry is set with the bytes input by the user and then the specified program --txmsg or --txmsg_redir will

[bpf-next PATCH 11/16] bpf: sockmap sample, add sendfile test

2018-03-05 Thread John Fastabend
To exercise TX ULP sendpage implementation we need a test that does a sendfile. Add sendfile test option here. Signed-off-by: John Fastabend --- samples/sockmap/sockmap_user.c | 70 ++-- 1 file changed, 60 insertions(+), 10

[bpf-next PATCH 09/16] bpf: add verifier tests for BPF_PROG_TYPE_SK_MSG

2018-03-05 Thread John Fastabend
Test read and writes for BPF_PROG_TYPE_SK_MSG. Signed-off-by: John Fastabend --- tools/testing/selftests/bpf/test_verifier.c | 54 +++ 1 file changed, 54 insertions(+) diff --git a/tools/testing/selftests/bpf/test_verifier.c

[bpf-next PATCH 07/16] bpf: sockmap, add msg_cork_bytes() helper

2018-03-05 Thread John Fastabend
In the case where we need a specific number of bytes before a verdict can be assigned, even if the data spans multiple sendmsg or sendfile calls. The BPF program may use msg_apply_bytes(). The extreme case is a user can call sendmsg repeatedly with 1-byte msg segments. Obviously, this is bad for

[bpf-next PATCH 04/16] net: generalize sk_alloc_sg to work with scatterlist rings

2018-03-05 Thread John Fastabend
The current implementation of sk_alloc_sg expects scatterlist to always start at entry 0 and complete at entry MAX_SKB_FRAGS. Future patches will want to support starting at arbitrary offset into scatterlist so add an additional sg_start parameters and then default to the current values in TLS

[bpf-next PATCH 02/16] sockmap: convert refcnt to an atomic refcnt

2018-03-05 Thread John Fastabend
The sockmap refcnt up until now has been wrapped in the sk_callback_lock(). So its not actually needed any locking of its own. The counter itself tracks the lifetime of the psock object. Sockets in a sockmap have a lifetime that is independent of the map they are part of. This is possible because

[bpf-next PATCH 00/16] bpf,sockmap: sendmsg/sendfile ULP

2018-03-05 Thread John Fastabend
This series adds a BPF hook for sendmsg and sendfile by using the ULP infrastructure and sockmap. A simple pseudocode example would be, // load the programs bpf_prog_load(SOCKMAP_TCP_MSG_PROG, BPF_PROG_TYPE_SK_MSG, , _prog); // lookup the sockmap bpf_map_msg =

[bpf-next PATCH 03/16] net: do_tcp_sendpages flag to avoid SKBTX_SHARED_FRAG

2018-03-05 Thread John Fastabend
When calling do_tcp_sendpages() from in kernel and we know the data has no references from user side we can omit SKBTX_SHARED_FRAG flag. This patch adds an internal flag, NO_SKBTX_SHARED_FRAG that can be used to omit setting SKBTX_SHARED_FRAG. The flag is not exposed to userspace because the

[bpf-next PATCH 01/16] sock: make static tls function alloc_sg generic sock helper

2018-03-05 Thread John Fastabend
The TLS ULP module builds scatterlists from a sock using page_frag_refill(). This is going to be useful for other ULPs so move it into sock file for more general use. In the process remove useless goto at end of while loop. Signed-off-by: John Fastabend ---

[bpf-next PATCH 10/16] bpf: sockmap sample, add option to attach SK_MSG program

2018-03-05 Thread John Fastabend
Add sockmap option to use SK_MSG program types. Signed-off-by: John Fastabend --- samples/bpf/bpf_load.c|8 +++ samples/sockmap/sockmap_kern.c| 52 +++ samples/sockmap/sockmap_user.c| 67

[bpf-next PATCH 05/16] bpf: create tcp_bpf_ulp allowing BPF to monitor socket TX/RX data

2018-03-05 Thread John Fastabend
This implements a BPF ULP layer to allow policy enforcement and monitoring at the socket layer. In order to support this a new program type BPF_PROG_TYPE_SK_MSG is used to run the policy at the sendmsg/sendpage hook. To attach the policy to sockets a sockmap is used with a new program attach type

[bpf-next PATCH 06/16] bpf: sockmap, add bpf_msg_apply_bytes() helper

2018-03-05 Thread John Fastabend
A single sendmsg or sendfile system call can contain multiple logical messages that a BPF program may want to read and apply a verdict. But, without an apply_bytes helper any verdict on the data applies to all bytes in the sendmsg/sendfile. Alternatively, a BPF program may only care to read the

[bpf-next PATCH 08/16] bpf: add map tests for BPF_PROG_TYPE_SK_MSG

2018-03-05 Thread John Fastabend
Add map tests to attach BPF_PROG_TYPE_SK_MSG types to a sockmap. Signed-off-by: John Fastabend --- tools/include/uapi/linux/bpf.h | 16 ++ tools/testing/selftests/bpf/Makefile |2 - tools/testing/selftests/bpf/bpf_helpers.h

[PATCH net] net: usbnet: fix potential deadlock on 32bit hosts

2018-03-05 Thread Eric Dumazet
From: Eric Dumazet Marek reported a LOCKDEP issue occurring on 32bit host, that we tracked down to the fact that usbnet could either run from soft or hard irqs. This patch adds u64_stats_update_begin_irqsave() and u64_stats_update_end_irqrestore() helpers to solve this

[PATCH net-next] net: phy: remove call to phy_error from phy_disable_interrupts

2018-03-05 Thread Heiner Kallweit
All callers of phy_disable_interrupts() call phy_error() in the error case. Therefore we don't need to do this within the function too. This change also allows us to use phy_disable_interrupts() in code holding phydev->lock (because phy_error() takes this lock). Make use of this in phy_stop().

[PATCH v4 net-next 0/2] lan743x: Add new lan743x driver

2018-03-05 Thread Bryan Whitehead
Add new lan743x driver. The lan743x from Microchip Technologies Inc, is a PCIe to Gigabit Ethernet Controller. Updates for V4: Patch 1/2 - Applied community suggestions convert to using module_pci_driver Updates for V3: Patch 1/2 - Applied community suggestions removed

[PATCH v4 net-next 2/2] lan743x: Update MAINTAINERS to include lan743x driver

2018-03-05 Thread Bryan Whitehead
Update MAINTAINERS to include lan743x driver Signed-off-by: Bryan Whitehead --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index e0b3900..a2129b3 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -9157,6 +9157,13

[PATCH v4 net-next 1/2] lan743x: Add main source files for new lan743x driver

2018-03-05 Thread Bryan Whitehead
Add main source files for new lan743x driver Signed-off-by: Bryan Whitehead --- drivers/net/ethernet/microchip/Kconfig| 10 + drivers/net/ethernet/microchip/Makefile |3 + drivers/net/ethernet/microchip/lan743x_main.c | 2781

Re: [PATCH] Fix partial warnings of checkpatch.pl for ipx_route.c

2018-03-05 Thread Eric Dumazet
On Mon, 2018-03-05 at 20:19 +0100, Horatiu Vultur wrote: > Fix partial warnings of checkpatch.pl for ipx_route.c > > Signed-off-by: Horatiu Vultur > --- >  drivers/staging/ipx/ipx_route.c | 7 --- >  1 file changed, 4 insertions(+), 3 deletions(-) > Please take a look at

[PATCH] Fix partial warnings of checkpatch.pl for ipx_route.c

2018-03-05 Thread Horatiu Vultur
Fix partial warnings of checkpatch.pl for ipx_route.c Signed-off-by: Horatiu Vultur --- drivers/staging/ipx/ipx_route.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/staging/ipx/ipx_route.c b/drivers/staging/ipx/ipx_route.c index

Re: [net-next 4/4] e1000e: allocate ring descriptors with dma_zalloc_coherent

2018-03-05 Thread Jeff Kirsher
On Mon, 2018-03-05 at 10:23 -0800, Eric Dumazet wrote: > On Mon, 2018-03-05 at 10:16 -0800, Jeff Kirsher wrote: > > From: Pierre-Yves Kerbrat > > > > Descriptor rings were not initialized at zero when allocated > > When area contained garbage data, it caused skb_over_panic in

Re: inconsistent lock state with usbnet/asix usb ethernet and xhci

2018-03-05 Thread Eric Dumazet
On Mon, 2018-03-05 at 12:46 +0100, Oliver Neukum wrote: > On Mon, 2018-03-05 at 08:45 +0100, Marek Szyprowski wrote: > > Hi Oliver, > > > > On 2018-02-27 17:07, Oliver Neukum wrote: > > > Am Dienstag, den 27.02.2018, 07:13 -0800 schrieb Eric Dumazet: > > > > On Tue, 2018-02-27 at 07:09 -0800,

[net 0/5][pull request] Intel Wired LAN Driver Updates 2018-03-05

2018-03-05 Thread Jeff Kirsher
This series contains fixes to e1000e only. Benjamin Poirier provides all the fixes in this series, starting with workaround for a VMWare e1000e emulation issue where ICR reads 0x0 on the emulated device. Partially reverted a previous commit dealing with the "Other" interrupt throttling to avoid

[net 4/5] e1000e: Avoid missed interrupts following ICR read

2018-03-05 Thread Jeff Kirsher
From: Benjamin Poirier The 82574 specification update errata 12 states that interrupts may be missed if ICR is read while INT_ASSERTED is not set. Avoid that problem by setting all bits related to events that can trigger the Other interrupt in IMS. The Other interrupt is

[net 5/5] e1000e: Fix check_for_link return value with autoneg off

2018-03-05 Thread Jeff Kirsher
From: Benjamin Poirier When autoneg is off, the .check_for_link callback functions clear the get_link_status flag and systematically return a "pseudo-error". This means that the link is not detected as up until the next execution of the e1000_watchdog_task() 2 seconds later.

[net 1/5] e1000e: Remove Other from EIAC

2018-03-05 Thread Jeff Kirsher
From: Benjamin Poirier It was reported that emulated e1000e devices in vmware esxi 6.5 Build 7526125 do not link up after commit 4aea7a5c5e94 ("e1000e: Avoid receiver overrun interrupt bursts", v4.15-rc1). Some tracing shows that after e1000e_trigger_lsc() is called, ICR reads

[net 3/5] e1000e: Fix queue interrupt re-raising in Other interrupt

2018-03-05 Thread Jeff Kirsher
From: Benjamin Poirier Restores the ICS write for Rx/Tx queue interrupts which was present before commit 16ecba59bc33 ("e1000e: Do not read ICR in Other interrupt", v4.5-rc1) but was not restored in commit 4aea7a5c5e94 ("e1000e: Avoid receiver overrun interrupt bursts",

[net 2/5] Partial revert "e1000e: Avoid receiver overrun interrupt bursts"

2018-03-05 Thread Jeff Kirsher
From: Benjamin Poirier This partially reverts commit 4aea7a5c5e940c1723add439f4088844cd26196d. We keep the fix for the first part of the problem (1) described in the log of that commit, that is to read ICR in the other interrupt handler. We remove the fix for the second part

Re: [net-next 4/4] e1000e: allocate ring descriptors with dma_zalloc_coherent

2018-03-05 Thread Eric Dumazet
On Mon, 2018-03-05 at 10:16 -0800, Jeff Kirsher wrote: > From: Pierre-Yves Kerbrat > > Descriptor rings were not initialized at zero when allocated > When area contained garbage data, it caused skb_over_panic in > e1000_clean_rx_irq (if data had E1000_RXD_STAT_DD bit set) >

[PATCH iproute2 net-next v2] iprule: support for ip_proto, sport and dport match options

2018-03-05 Thread Roopa Prabhu
From: Roopa Prabhu add support to match on ip_proto, sport and dport ranges. example: $ip rule add sport 666-777 dport 999 ip_proto tcp table 100 $ip rule show 0: from all lookup local 32765: from all ip_proto 6 sport 666-777 dport 999 lookup 100 32766: from

<    1   2   3   4   >