Re: [PATCH net-next] hv_netvsc: Correct filter setting for multicast/broadcast

Hello! On 03/09/2018 04:25 PM, Mohammed Gamal wrote: > Commit 009f766 intended to filter multicast/broadcast, however At least 12 digits needed here, and the summary line too, just like you do for the Fixes: tag. > the NDIS filter wasn't set properly in non-promiscuous modes, > which

Re: [PATCH net-next] modules: allow modprobe load regular elf binaries

On Fri, Mar 9, 2018 at 10:48 AM, Andy Lutomirski wrote: >> On Mar 9, 2018, at 10:17 AM, Linus Torvalds >> wrote: >> >> Hmm. I wish we had an "execute blob" model, but we really don't, and >> it would be hard/impossible to do without pinning

Re: [PATCH net-next] modules: allow modprobe load regular elf binaries

On Fri, Mar 9, 2018 at 10:50 AM, Linus Torvalds wrote: > On Fri, Mar 9, 2018 at 10:43 AM, Kees Cook wrote: >> >> Module loading (via kernel_read_file()) already uses >> deny_write_access(), and so does do_open_execat(). As long as module >>

[PATCH v10 crypto 03/11] cxgb4: Inline TLS FW Interface

Key area size in hw-config file. CPL struct for TLS request and response. Work request for Inline TLS. Signed-off-by: Atul Gupta --- drivers/net/ethernet/chelsio/cxgb4/t4_msg.h | 121 ++- drivers/net/ethernet/chelsio/cxgb4/t4_regs.h | 2 +

[PATCH v10 crypto 04/11] chtls: structure and macro definiton

Inline TLS state, connection management. Supporting macros definition. Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chtls/chtls.h| 487 drivers/crypto/chelsio/chtls/chtls_cm.h | 202 + 2 files changed, 689

[PATCH v10 crypto 05/11] cxgb4: LLD driver changes to enable TLS

Read the Inline TLS capability from firmware. Determine the area reserved for storing the keys Dump the Inline TLS tx and rx records count. Signed-off-by: Atul Gupta --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 32 +---

[PATCH v10 crypto 07/11] chtls: Program the TLS Key

Initialize the space reserved for storing the TLS keys get and free the location where key is stored for the TLS connection Program the tx and rx key as received from user in struct tls12_crypto_info_aes_gcm_128 and understood by hardware. Signed-off-by: Atul Gupta ---

[PATCH v10 crypto 06/11] chcr: Inline TLS Key Macros

Define macro for programming the TLS Key context Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chcr_algo.h | 42 + drivers/crypto/chelsio/chcr_core.h | 55 +- 2 files changed, 96 insertions(+), 1

[PATCH v10 crypto 02/11] ethtool: enable Inline TLS in HW

Ethtool option enables TLS record offload on HW, user configures the feature for netdev capable of Inline TLS. This allows user to define custom sk_prot for Inline TLS sock Signed-off-by: Atul Gupta --- include/linux/netdev_features.h | 2 ++ net/core/ethtool.c

Re: [PATCH net-next] modules: allow modprobe load regular elf binaries

On Fri, Mar 9, 2018 at 7:38 PM, Linus Torvalds wrote: > On Fri, Mar 9, 2018 at 11:12 AM, Linus Torvalds > wrote: >> >> How are you going to handle five processes doing the same setup concurrently? > > Side note: it's not just

Re: [PATCH 01/15] ice: Add basic driver framework for Intel(R) E800 Series

On Fri, 9 Mar 2018 09:21:22 -0800, Anirudh Venkataramanan wrote: > diff --git a/Documentation/networking/ice.txt > b/Documentation/networking/ice.txt > new file mode 100644 > index ..6261c46378e1 > --- /dev/null > +++ b/Documentation/networking/ice.txt nit: ice.rst, maybe?

[PATCH net-next 1/1] tc-testing: updated gact tests with batch test cases

Add test cases to exercise code paths responsible for adding or deleting batch of TC actions. Signed-off-by: Roman Mashak --- .../tc-testing/tc-tests/actions/gact.json | 73 +- 1 file changed, 72 insertions(+), 1 deletion(-) diff --git

Re: [PATCH net-next] modules: allow modprobe load regular elf binaries

On Fri, Mar 9, 2018 at 10:43 AM, Kees Cook wrote: > > Module loading (via kernel_read_file()) already uses > deny_write_access(), and so does do_open_execat(). As long as module > loading doesn't call allow_write_access() before the execve() has > started in the new

[PATCH v10 crypto 08/11] chtls: CPL handler definition

Exchange CPL messages with hardware to program the TLS session CPL handlers defined to process messages received from chip. Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chtls/chtls_cm.c | 2041 +++ net/ipv4/tcp_minisocks.c

[PATCH v10 crypto 11/11] Makefile Kconfig

Entry for Inline TLS as another driver dependent on cxgb4 and chcr Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/Kconfig| 11 +++ drivers/crypto/chelsio/Makefile | 1 + drivers/crypto/chelsio/chtls/Makefile | 4 3 files changed, 16

[bpf-next V3 PATCH 06/15] tun: convert to use generic xdp_frame and xdp_return_frame API

The tuntap driver invented it's own driver specific way of queuing XDP packets, by storing the xdp_buff information in the top of the XDP frame data. Convert it over to use the more generic xdp_frame structure. The main problem with the in-driver method is that the xdp_rxq_info pointer cannot be

[bpf-next V3 PATCH 05/15] xdp: introduce a new xdp_frame type

This is needed to convert drivers tuntap and virtio_net. This is a generalization of what is done inside cpumap, which will be converted later. Signed-off-by: Jesper Dangaard Brouer --- include/net/xdp.h | 40 1 file changed, 40

[bpf-next V3 PATCH 04/15] xdp: move struct xdp_buff from filter.h to xdp.h

This is done to prepare for the next patch, and it is also nice to move this XDP related struct out of filter.h. Signed-off-by: Jesper Dangaard Brouer --- include/linux/filter.h | 24 +--- include/net/xdp.h | 22 ++ 2 files

[bpf-next V3 PATCH 03/15] ixgbe: use xdp_return_frame API

Extend struct ixgbe_tx_buffer to store the xdp_mem_info. Signed-off-by: Jesper Dangaard Brouer --- drivers/net/ethernet/intel/ixgbe/ixgbe.h |1 + drivers/net/ethernet/intel/ixgbe/ixgbe_main.c |6 -- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git

[bpf-next V3 PATCH 00/15] XDP redirect memory return API

This patchset works towards supporting different XDP RX-ring memory allocators. As this will be needed by the AF_XDP zero-copy mode. The patchset uses mlx5 as the sample driver, which gets implemented XDP_REDIRECT RX-mode, but not ndo_xdp_xmit (as this API is subject to change thought the

[bpf-next V3 PATCH 01/15] mlx5: basic XDP_REDIRECT forward support

This implements basic XDP redirect support in mlx5 driver. Notice that the ndo_xdp_xmit() is NOT implemented, because that API need some changes that this patchset is working towards. The main purpose of this patch is have different drivers doing XDP_REDIRECT to show how different memory models

[PATCH net-next 1/1] tc-testing: updated gact tests with batch test cases

Add test cases to exercise code paths responsible for adding or deleting batch of TC actions. Signed-off-by: Roman Mashak --- .../tc-testing/tc-tests/actions/gact.json | 73 +- 1 file changed, 72 insertions(+), 1 deletion(-) diff --git

Re: [PATCH net-next] modules: allow modprobe load regular elf binaries

On 3/9/18 10:23 AM, Andy Lutomirski wrote: On Mar 9, 2018, at 10:15 AM, Greg KH wrote: Oh, and for the record, I like Andy's proposal as well as dumping this into a kernel module "blob" with the exception that this now would take up unswapable memory, which

Re: [PATCH v3] kernel.h: Skip single-eval logic on literals in min()/max()

On Fri, Mar 9, 2018 at 12:05 PM, Kees Cook wrote: > When max() is used in stack array size calculations from literal values > (e.g. "char foo[max(sizeof(struct1), sizeof(struct2))]", the compiler > thinks this is a dynamic calculation due to the single-eval logic, which >

[PATCH v2 net-next 2/3] net: macb: Add phy-handle DT support

This optional binding (as described in the ethernet DT bindings doc) directs the netdev to the phydev to use. This is useful for a phy chip that has >1 phy in it, and two netdevs are using the same phy chip (i.e. the second mac's phy lives on the first mac's MDIO bus) The devicetree snippet would

[PATCH v2 net-next 3/3] Documentation: macb: Document phy-handle optional binding

Signed-off-by: Brad Mouring --- Documentation/devicetree/bindings/net/macb.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/net/macb.txt b/Documentation/devicetree/bindings/net/macb.txt index 27966ae741e0..457d5ae16f23 100644 ---

Re: [PATCH] net/9p: avoid -ERESTARTSYS leak to userspace

On Fri, 09 Mar 2018 21:41:38 +0100 Greg Kurz wrote: > If it was interrupted by a signal, the 9p client may need to send some > more requests to the server for cleanup before returning to userspace. > > To avoid such a last minute request to be interrupted right away, the >

Re: [PATCH net-next] modules: allow modprobe load regular elf binaries

On Fri, Mar 9, 2018 at 10:35 AM, David Miller wrote: > From: Linus Torvalds > Date: Fri, 9 Mar 2018 10:17:42 -0800 > >> - use deny_write_access() to make sure that we don't have active >> writers and cannot get them during the execve. > > I

[PATCH v10 crypto 00/11] Chelsio Inline TLS

Series for Chelsio Inline TLS driver (chtls) Use tls ULP infrastructure to register chtls as Inline TLS driver. Chtls use TCP Sockets to transmit and receive TLS record. TCP proto is extended to offload TLS record. T6 adapter provides the following features: -TLS record offload, TLS

[PATCH v10 crypto 01/11] tls: support for Inline tls record

Facility to register Inline TLS drivers to net/tls. Setup TLS_HW_RECORD prot to listen on offload device. Cases handled - Inline TLS device exists, setup prot for TLS_HW_RECORD - Atleast one Inline TLS exists, sets TLS_HW_RECORD. - If non-inline device establish connection, move to TLS_SW_TX

Re: [PATCH net] ipv4: lock mtu in fnhe when received PMTU < net.ipv4.route.min_pmtu

From: Sabrina Dubroca Date: Fri, 9 Mar 2018 17:43:21 +0100 > diff --git a/include/net/ip_fib.h b/include/net/ip_fib.h > index f80524396c06..77d0a78cf7d2 100644 > --- a/include/net/ip_fib.h > +++ b/include/net/ip_fib.h > @@ -59,6 +59,7 @@ struct fib_nh_exception { >

Re: [PATCH net-next] modules: allow modprobe load regular elf binaries

From: Alexei Starovoitov Date: Fri, 9 Mar 2018 10:50:49 -0800 > On 3/9/18 10:23 AM, Andy Lutomirski wrote: >> It might not be totally crazy to back it by tmpfs. > > interesting. how do you propose to do it? > Something like: > - create /umh_module_tempxxx dir > - mount tmpfs there

Re: [PATCH] pktgen: Remove VLA usage

On 03/09/2018 10:58 AM, David Miller wrote: From: "Gustavo A. R. Silva" Date: Thu, 8 Mar 2018 23:43:40 -0600 In preparation to enabling -Wvla, remove VLA usage and replace it with a fixed-length array instead. Signed-off-by: Gustavo A. R. Silva

Re: [PATCH] net: use skb_is_gso_sctp() instead of open-coding

On Fri, Mar 09, 2018 at 02:06:09PM +1100, Daniel Axtens wrote: > As well as the basic conversion, I noticed that a lot of the > SCTP code checks gso_type without first checking skb_is_gso() > so I have added that where appropriate. > > Also, document the helper. Thanks Daniel. > > Cc: Daniel

[bpf-next V3 PATCH 11/15] page_pool: refurbish version of page_pool code

Need a fast page recycle mechanism for ndo_xdp_xmit API for returning pages on DMA-TX completion time, which have good cross CPU performance, given DMA-TX completion time can happen on a remote CPU. Refurbish my page_pool code, that was presented[1] at MM-summit 2016. Adapted page_pool code to

[bpf-next V3 PATCH 10/15] xdp: rhashtable with allocator ID to pointer mapping

Use the IDA infrastructure for getting a cyclic increasing ID number, that is used for keeping track of each registered allocator per RX-queue xdp_rxq_info. Instead of using the IDR infrastructure, which uses a radix tree, use a dynamic rhashtable, for creating ID to pointer lookup table, because

[bpf-next V3 PATCH 09/15] mlx5: register a memory model when XDP is enabled

Now all the users of ndo_xdp_xmit have been converted to use xdp_return_frame. This enable a different memory model, thus activating another code path in the xdp_return_frame API. V2: Fixed issues pointed out by Tariq. Signed-off-by: Jesper Dangaard Brouer ---

[bpf-next V3 PATCH 12/15] xdp: allow page_pool as an allocator type in xdp_return_frame

New allocator type MEM_TYPE_PAGE_POOL for page_pool usage. The registered allocator page_pool pointer is not available directly from xdp_rxq_info, but it could be (if needed). For now, the driver should keep separate track of the page_pool pointer, which it should use for RX-ring page

[bpf-next V3 PATCH 07/15] virtio_net: convert to use generic xdp_frame and xdp_return_frame API

The virtio_net driver assumes XDP frames are always released based on page refcnt (via put_page). Thus, is only queues the XDP data pointer address and uses virt_to_head_page() to retrieve struct page. Use the XDP return API to get away from such assumptions. Instead queue an xdp_frame, which

[bpf-next V3 PATCH 08/15] bpf: cpumap convert to use generic xdp_frame

The generic xdp_frame format, was inspired by the cpumap own internal xdp_pkt format. It is now time to convert it over to the generic xdp_frame format. The cpumap needs one extra field dev_rx. Signed-off-by: Jesper Dangaard Brouer --- include/net/xdp.h |1 +

[bpf-next V3 PATCH 15/15] xdp: transition into using xdp_frame for ndo_xdp_xmit

Changing API ndo_xdp_xmit to take a struct xdp_frame instead of struct xdp_buff. This brings xdp_return_frame and ndp_xdp_xmit in sync. This builds towards changing the API further to become a bulk API, because xdp_buff is not a queue-able object while xdp_frame is. Signed-off-by: Jesper

[bpf-next V3 PATCH 13/15] mlx5: use page_pool for xdp_return_frame call

This patch shows how it is possible to have both the driver local page cache, which uses elevated refcnt for "catching"/avoiding SKB put_page. And at the same time, have pages getting returned to the page_pool from ndp_xdp_xmit DMA completion. Performance is surprisingly good. Tested DMA-TX

[bpf-next V3 PATCH 02/15] xdp: introduce xdp_return_frame API and use in cpumap

Introduce an xdp_return_frame API, and convert over cpumap as the first user, given it have queued XDP frame structure to leverage. V3: Cleanup and remove C99 style comments, pointed out by Alex Duyck. Signed-off-by: Jesper Dangaard Brouer --- include/net/xdp.h | 28

[bpf-next V3 PATCH 14/15] xdp: transition into using xdp_frame for return API

Changing API xdp_return_frame() to take struct xdp_frame as argument, seems like a natural choice. But there are some subtle performance details here that needs extra care, which is a deliberate choice. When de-referencing xdp_frame on a remote CPU during DMA-TX completion, result in the

Re: KASAN: use-after-free Read in sctp_association_free (2)

On Fri, Mar 09, 2018 at 12:59:06PM -0800, syzbot wrote: > Hello, > > syzbot hit the following crash on net-next commit > fd372a7a9e5e9d8011a0222d10edd3523abcd3b1 (Thu Mar 8 19:43:48 2018 +) > Merge tag 'mlx5-updates-2018-02-28-2' of >

Re: [PATCH net-next] hv_netvsc: Correct filter setting for multicast/broadcast

On 03/09/2018 09:37 PM, Sergei Shtylyov wrote: >> Commit 009f766 intended to filter multicast/broadcast, however > >At least 12 digits needed here, and the summary line too, just like you do > for the Fixes: tag. > >> the NDIS filter wasn't set properly in non-promiscuous modes, >> which

Re: [PATCH net-next] modules: allow modprobe load regular elf binaries

> On Mar 9, 2018, at 10:17 AM, Linus Torvalds > wrote: > > > Hmm. I wish we had an "execute blob" model, but we really don't, and > it would be hard/impossible to do without pinning the pages in memory. > Why so hard? We can already execute a struct file

Re: [PATCH net-next] modules: allow modprobe load regular elf binaries

On 3/9/18 10:50 AM, Linus Torvalds wrote: On Fri, Mar 9, 2018 at 10:43 AM, Kees Cook wrote: Module loading (via kernel_read_file()) already uses deny_write_access(), and so does do_open_execat(). As long as module loading doesn't call allow_write_access() before the

[PATCH v10 crypto 10/11] chtls: Register chtls Inline TLS with net tls

Register chtls as Inline TLS driver, chtls is ULD to cxgb4. Setsockopt to program (tx/rx) keys on chip. Support AES GCM of key size 128. Support both Inline Rx and Tx. Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chtls/chtls_main.c | 577

[PATCH v10 crypto 09/11] chtls: Inline TLS request Tx/Rx

TLS handler for record transmit and receive. Create Inline TLS work request and post to FW. Create Inline TLS record CPLs for hardware Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chtls/chtls_io.c | 1863 +++ 1 file changed, 1863

Re: [PATCH net-next] modules: allow modprobe load regular elf binaries

On Fri, Mar 9, 2018 at 10:57 AM, David Miller wrote: > > Once the helper UMH is invoked, it runs asynchronously taking eBPF > translation requests. How? Really. See my comment about mutual exclusion. The current patch is *broken* because it doesn't handle it. Really. Think

[PATCH 0/4 net-next] ibmvnic: Fix VLAN and other device errata

This patch series contains fixes for VLAN and other backing hardware errata. The VLAN fixes are mostly to account for the additional four bytes VLAN header in TX descriptors and buffers, when applicable. The other fixes for device errata are to pad small packets to avoid a possible connection

[PATCH 1/4 net-next] ibmvnic: Account for VLAN tag in L2 Header descriptor

If a VLAN tag is present in the Ethernet header, account for that when providing the L2 header to firmware. Signed-off-by: Thomas Falcon --- drivers/net/ethernet/ibm/ibmvnic.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

[PATCH 4/4 net-next] ibmvnic: Handle TSO backing device errata

TSO packets with one segment or with an MSS less than 224 can cause errors on some backing devices, so disable GSO in those cases. Signed-off-by: Thomas Falcon --- drivers/net/ethernet/ibm/ibmvnic.c | 18 ++ 1 file changed, 18 insertions(+) diff

Re: [PATCH net 4/5] tcp: prevent bogus undos when SACK is not enabled

On Fri, 9 Mar 2018, David Miller wrote: > From: Ilpo Järvinen > Date: Fri, 9 Mar 2018 16:11:47 +0200 (EET) > > > Unfortunately I don't have now permission to publish the time-seq > > graph about it but I've tried to improve the changelog messages so > > that you can

[PATCH 3/4 net-next] ibmvnic: Pad small packets to minimum MTU size

Some backing devices cannot handle small packets well, so pad any small packets to avoid that. It was recommended that the VNIC driver should not send packets smaller than the minimum MTU value provided by firmware, so pad small packets to be at least that long. Signed-off-by: Thomas Falcon

[PATCH 2/4 net-next] ibmvnic: Account for VLAN header length in TX buffers

The extra four bytes of a VLAN packet was throwing off TX buffer entry values used by the driver. Account for those bytes when in buffer size and buffer entry calculations Signed-off-by: Thomas Falcon --- drivers/net/ethernet/ibm/ibmvnic.c | 6 +++--- 1 file

Re: [PATCH net-next] modules: allow modprobe load regular elf binaries

On Fri, Mar 9, 2018 at 11:12 AM, Linus Torvalds wrote: > > How are you going to handle five processes doing the same setup concurrently? Side note: it's not just serialization. It's also "is it actually up and running". The rule for "request_module()" (for a real

Re: [PATCH v2 net 1/5] tcp: feed correct number of pkts acked to cc modules also in recovery

On Fri, 9 Mar 2018, Sergei Shtylyov wrote: > On 03/09/2018 05:10 PM, Ilpo Järvinen wrote: > > > @@ -3068,8 +3072,11 @@ static int tcp_clean_rtx_queue(struct sock *sk, u32 > > prior_fack, > > - if (!after(scb->end_seq, tp->high_seq)) > > + if

Re: [PATCH net-next] modules: allow modprobe load regular elf binaries

From: Linus Torvalds Date: Fri, 9 Mar 2018 10:53:45 -0800 > Anyway, see my other suggestion that makes this all irrelevant. Just > wait synchronously (until the exit), and just use deny_write_access(). What exit? Once the helper UMH is invoked, it runs

Re: [PATCH net-next] modules: allow modprobe load regular elf binaries

On Fri, Mar 9, 2018 at 6:55 PM, David Miller wrote: > From: Alexei Starovoitov > Date: Fri, 9 Mar 2018 10:50:49 -0800 > >> On 3/9/18 10:23 AM, Andy Lutomirski wrote: >>> It might not be totally crazy to back it by tmpfs. >> >> interesting. how do you propose to

[PATCH v2 net-next 1/3] net: macb: Reorganize macb_mii bringup

The macb mii setup (mii_probe() and mii_init()) previously was somewhat interspersed, likely a result of organic growth and hacking. This change moves mii bus registration into mii_init and probing the bus for devices into mii_probe. Signed-off-by: Brad Mouring

Re: [PATCH v2 net 1/5] tcp: feed correct number of pkts acked to cc modules also in recovery

Hello! On 03/09/2018 05:10 PM, Ilpo Järvinen wrote: > A miscalculation for the number of acknowledged packets occurs during > RTO recovery whenever SACK is not enabled and a cumulative ACK covers > any non-retransmitted skbs. The reason is that pkts_acked value > calculated in

[PATCH v3] kernel.h: Skip single-eval logic on literals in min()/max()

When max() is used in stack array size calculations from literal values (e.g. "char foo[max(sizeof(struct1), sizeof(struct2))]", the compiler thinks this is a dynamic calculation due to the single-eval logic, which is not needed in the literal case. This change removes several accidental stack

Re: [PATCH v3] kernel.h: Skip single-eval logic on literals in min()/max()

On Fri, Mar 9, 2018 at 1:10 PM, Linus Torvalds wrote: > On Fri, Mar 9, 2018 at 12:05 PM, Kees Cook wrote: >> When max() is used in stack array size calculations from literal values >> (e.g. "char foo[max(sizeof(struct1), sizeof(struct2))]",

[PATCH net-next 1/1] tc-testing: add TC vlan action tests

Signed-off-by: Roman Mashak Tested-by: Brenda J. Butler --- .../tc-testing/tc-tests/actions/vlan.json | 410 + 1 file changed, 410 insertions(+) create mode 100644 tools/testing/selftests/tc-testing/tc-tests/actions/vlan.json

Re: [PATCH net 0/2] mlxsw: ACL and mirroring fixes

From: Ido Schimmel Date: Fri, 9 Mar 2018 15:33:51 +0200 > The first patch fixes offload of rules using the 'pass' action. Instead > of continuing to evaluate lower priority rules, the binding is > terminated and the packet proceeds to the bridge and router blocks on >

Re: [PATCH net 0/3] a couple of erspan fixes

From: William Tu Date: Fri, 9 Mar 2018 07:34:39 -0800 > The series fixes a couple of erspan issues. > The first patch adds the erspan v2 proto type to the ip6 tunnel lookup. > The second patch improves the error handling when users screws the > version number in metadata.

Re: [PATCH net-next 00/12] s390/qeth: updates 2018-03-09

From: Julian Wiedmann Date: Fri, 9 Mar 2018 18:12:51 +0100 > here is the current pile of qeth patches for net-next. Just the usual > small updates and clean ups. Please apply. These look good, series applied, thanks.

Re: [PATCH 12/15] ice: Add stats and ethtool support

On Fri, Mar 09, 2018 at 09:21:33AM -0800, Anirudh Venkataramanan wrote: > This patch implements a watchdog task to get packet statistics from > the device. > > This patch also adds support for the following ethtool operations: > > ethtool devname > ethtool -s devname [msglvl N] [msglevel type

Re: [PATCH net-next] modules: allow modprobe load regular elf binaries

On Fri, Mar 09, 2018 at 09:32:36AM -0800, Alexei Starovoitov wrote: > On 3/9/18 8:24 AM, Andy Lutomirski wrote: > > On Fri, Mar 9, 2018 at 3:39 PM, Alexei Starovoitov wrote: > > > On 3/9/18 7:16 AM, Andy Lutomirski wrote: > > > > > > > > > > > > On Mar 8, 2018, at 9:08 PM, Alexei

Re: [PATCH net-next] modules: allow modprobe load regular elf binaries

On Thu, Mar 8, 2018 at 9:08 PM, Alexei Starovoitov wrote: > > there is not abi breakage and file cannot disappear from running task. > One cannot umount fs while file is still being used. I think that "cannot umount" part _is_ the ABI breakage that Andy is talking about. > Not only

Re: [PATCH 00/15] Add ice driver

From: Anirudh Venkataramanan Date: Fri, 9 Mar 2018 09:21:21 -0800 > This patch series adds the ice driver, which will support the Intel(R) > E800 Series of network devices. > > This is the first phase in the release of this driver where we implement > basic

Re: [PATCH net-next] modules: allow modprobe load regular elf binaries

> On Mar 9, 2018, at 10:15 AM, Greg KH wrote: > > > Oh, and for the record, I like Andy's proposal as well as dumping this > into a kernel module "blob" with the exception that this now would take > up unswapable memory, which isn't the nicest and is one big

Re: [PATCH net v2 2/2] l2tp: fix races with ipv4-mapped ipv6 addresses

On Fri, Mar 09, 2018 at 06:58:00PM +0100, Paolo Abeni wrote: > On Fri, 2018-03-09 at 18:47 +0100, Guillaume Nault wrote: > > On Fri, Mar 09, 2018 at 06:04:03PM +0100, Paolo Abeni wrote: > > > Hi, > > > > > > On Fri, 2018-03-09 at 17:43 +0100, Guillaume Nault wrote: > > > > > diff --git

Re: [PATCH net-next] modules: allow modprobe load regular elf binaries

On Fri, Mar 09, 2018 at 10:23:27AM -0800, Andy Lutomirski wrote: > > > > On Mar 9, 2018, at 10:15 AM, Greg KH wrote: > > > > > > > Oh, and for the record, I like Andy's proposal as well as dumping this > > into a kernel module "blob" with the exception that this

Re: [PATCH net-next] modules: allow modprobe load regular elf binaries

From: Linus Torvalds Date: Fri, 9 Mar 2018 10:17:42 -0800 > - use deny_write_access() to make sure that we don't have active > writers and cannot get them during the execve. I agree that this is necessary for image validation purposes.

Re: [PATCH] net: ipv6: xfrm6_state: remove VLA usage

Hello! On 03/09/2018 03:21 PM, Andreas Christoforou wrote: > The kernel would like to have all stack VLA usage removed[1]. > > Signed-off-by: Andreas Christoforou > --- > net/ipv6/xfrm6_state.c | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > >

Re: WARNING in __proc_create

On Fri, Mar 9, 2018 at 1:59 PM, syzbot wrote: > Hello, > > syzbot hit the following crash on net-next commit > 617aebe6a97efa539cc4b8a52adccd89596e6be0 (Sun Feb 4 00:25:42 2018 +) > Merge tag 'usercopy-v4.16-rc1' of >

Re: [PATCH v3] kernel.h: Skip single-eval logic on literals in min()/max()

On Fri, Mar 9, 2018 at 5:30 PM, Kees Cook wrote: > -- > Kees Cook > Pixel SecurityOn > [...] WTF, gmail just blasted HTML into my explicitly plain-text email?! Apologies... -- Kees Cook Pixel SecurityOn Fri, Mar 9, 2018 at 5:30 PM, Kees Cook mailto:keesc...@chromium.org;

Re: WARNING in __proc_create

On 03/09/2018 02:48 PM, Cong Wang wrote: On Fri, Mar 9, 2018 at 1:59 PM, syzbot wrote: Hello, syzbot hit the following crash on net-next commit 617aebe6a97efa539cc4b8a52adccd89596e6be0 (Sun Feb 4 00:25:42 2018 +) Merge tag

Re: WARNING in __proc_create

On Fri, Mar 9, 2018 at 2:58 PM, Eric Dumazet wrote: > > > On 03/09/2018 02:56 PM, Eric Dumazet wrote: > >> >> I sent a patch a while back, but Pablo/Florian wanted more than that >> simple fix. >> >> We also need to filter special characters like '/' proc_create_data()

Re: WARNING in __proc_create

Cong Wang wrote: > On Fri, Mar 9, 2018 at 2:58 PM, Eric Dumazet wrote: > > > > > > On 03/09/2018 02:56 PM, Eric Dumazet wrote: > > > >> > >> I sent a patch a while back, but Pablo/Florian wanted more than that > >> simple fix. > >> > >> We also

Re: [PATCH v3] kernel.h: Skip single-eval logic on literals in min()/max()

On 03/09/2018 04:07 PM, Andrew Morton wrote: > On Fri, 9 Mar 2018 12:05:36 -0800 Kees Cook wrote: > >> When max() is used in stack array size calculations from literal values >> (e.g. "char foo[max(sizeof(struct1), sizeof(struct2))]", the compiler >> thinks this is a

RE: [Intel-wired-lan] [PATCH 1/2] Revert "e1000e: Separate signaling for link check/link up"

> From: Intel-wired-lan [mailto:intel-wired-lan-boun...@osuosl.org] On > Behalf Of Benjamin Poirier > Sent: Monday, March 5, 2018 5:56 PM > To: Kirsher, Jeffrey T > Cc: netdev@vger.kernel.org; intel-wired-...@lists.osuosl.org; linux- > ker...@vger.kernel.org; Lennart

Re: WARNING in __proc_create

On 03/09/2018 02:56 PM, Eric Dumazet wrote: I sent a patch a while back, but Pablo/Florian wanted more than that simple fix. We also need to filter special characters like '/' Or maybe I am mixing with something else. Yes, Florian mentioned that we also had to reject "." and ".."

Re: [PATCH v3 1/2] bpf: extend stackmap to save binary_build_id+offset instead of address

Hi Song, On 03/06/2018 08:42 PM, Song Liu wrote: [...]> +/* > + * Parse build id from the note segment. This logic can be shared between > + * 32-bit and 64-bit system, because Elf32_Nhdr and Elf64_Nhdr are > + * identical. > + */ > +static inline int stack_map_parse_build_id(void *vm_start, > +

Re: WARNING in __proc_create

On 03/09/2018 03:32 PM, Cong Wang wrote: On Fri, Mar 9, 2018 at 3:21 PM, Eric Dumazet wrote: On 03/09/2018 03:05 PM, Cong Wang wrote: BTW, the warning itself is all about empty names, so perhaps it's better to fix them separately. Huh ? You want more syzbot

Re: [PATCH v3] kernel.h: Skip single-eval logic on literals in min()/max()

On Fri, Mar 9, 2018 at 4:07 PM, Andrew Morton wrote: > > A brief poke failed to reveal a workaround - gcc-4.4.4 doesn't appear > to know that __builtin_constant_p(x) is a constant. Or something. LOL. I suspect it might be that it wants to evaluate

Re: [PATCH v3] kernel.h: Skip single-eval logic on literals in min()/max()

On Fri, Mar 9, 2018 at 4:38 PM, Linus Torvalds wrote: > On Fri, Mar 9, 2018 at 4:32 PM, Andrew Morton > wrote: >> >> I wonder which gcc versions actually accept Kees's addition. Ah, my old nemesis, gcc 4.4.4. *sob* > Note that we

[PATCH net 1/8] bnxt_en: Refactor the functions to reserve hardware rings.

The bnxt_hwrm_reserve_{pf|vf}_rings() functions are very similar to the bnxt_hwrm_check_{pf|vf}_rings() functions. Refactor the former so that the latter can make use of common code in the next patch. Signed-off-by: Michael Chan ---

[PATCH net 4/8] bnxt_en: Pass complete VLAN TCI to the stack.

When receiving a packet with VLAN tag, pass the entire 16-bit TCI to the stack when calling __vlan_hwaccel_put_tag(). The current code is only passing the 12-bit tag and it is missing the priority bits. Signed-off-by: Michael Chan ---

[PATCH net 6/8] bnxt_en: Return standard Linux error codes for hwrm flow cmds.

From: Venkat Duvvuru Currently, internal error value is returned by the driver, when hwrm_cfa_flow_alloc() fails due lack of resources. We should be returning Linux errno value -ENOSPC instead. This patch also converts other similar command errors to standard

[PATCH net 3/8] bnxt_en: Remove unwanted ovs-offload messages in some conditions

From: Sriharsha Basavapatna In some conditions when the driver fails to add a flow in HW and returns an error back to the stack, the stack continues to invoke get_flow_stats() and/or del_flow() on it. The driver fails these APIs with an error message "no

[PATCH net 0/8] bnxt_en: Bug fixes.

There are 3 bug fixes in this series to fix regressions recently introduced when adding the new ring reservations scheme. 2 minor fixes in the TC Flower code to return standard errno values and to elide some unnecessary warning dmesg. One Fixes the VLAN TCI value passed to the stack by including

[PATCH net 5/8] bnxt_en: Fix regressions when setting up MQPRIO TX rings.

Recent changes added the bnxt_init_int_mode() call in the driver's open path whenever ring reservations are changed. This call was previously only called in the probe path. In the open path, if MQPRIO TC has been setup, the bnxt_init_int_mode() call would reset and mess up the MQPRIO per TC

[PATCH net 7/8] bnxt_en: close & open NIC, only when the interface is in running state.

From: Venkat Duvvuru bnxt_restore_pf_fw_resources routine frees PF resources by calling close_nic and allocates the resources back, by doing open_nic. However, this is not needed, if the PF is already in closed state. This bug causes the driver to call open the

[PATCH net 2/8] bnxt_en: Fix vnic accounting in the bnxt_check_rings() path.

From: Eddie Wai The number of vnics to check must be determined ahead of time because only standard RX rings require vnics to support RFS. The logic is similar to the ring reservation logic and we can now use the refactored common functions to do most of the work in

[PATCH net 8/8] bnxt_en: Check valid VNIC ID in bnxt_hwrm_vnic_set_tpa().

During initialization, if we encounter errors, there is a code path that calls bnxt_hwrm_vnic_set_tpa() with invalid VNIC ID. This may cause a warning in firmware logs. Fixes: c0c050c58d84 ("bnxt_en: New Broadcom ethernet driver.") Signed-off-by: Michael Chan ---

Re: [PATCH] net: remove VLA usage

On Wed, Mar 07, 2018 at 08:26:14PM -0500, David Miller wrote: > From: Laszlo Toth > Date: Thu, 8 Mar 2018 01:19:53 +0100 > > > Separated snmp_seq_show_tcp_udp() to tcp and udp variants, > > so the usage of max_t() for the array size can be emitted. > > > > Signed-off-by:

  1   2   3   >