Re: [PATCH net-next 2/2 v1] netns: isolate seqnums to use per-netns locks

On Tue, Apr 24, 2018 at 03:39:25PM -0400, David Miller wrote: > From: Christian Brauner > Date: Mon, 23 Apr 2018 12:24:43 +0200 > > > + #ifdef CONFIG_NET > > + seqnum = get_ns_uevent_seqnum_by_vpid(); > > + #else > > + seqnum = uevent_seqnum;

Re: [PATCH net-next 2/2 v2] netns: isolate seqnums to use per-netns locks

Christian Brauner writes: > Now that it's possible to have a different set of uevents in different > network namespaces, per-network namespace uevent sequence numbers are > introduced. This increases performance as locking is now restricted to the > network

Re: [PATCH bpf-next v5 0/2] bpf: allow map helpers access to map values directly

On 04/24/2018 03:06 PM, Paul Chaignon wrote: > Currently, helpers that expect ARG_PTR_TO_MAP_KEY and ARG_PTR_TO_MAP_VALUE > can only access stack and packet memory. This patchset allows these > helpers to directly access map values by passing registers of type > PTR_TO_MAP_VALUE. > > The first

Re: [Cake] [PATCH net-next v2] Add Common Applications Kept Enhanced (cake) qdisc

Georgios Amanakis writes: > On Tue, Apr 24, 2018 at 11:47 AM, Georgios Amanakis > wrote: >>> >>> Does anyone know if there is a way to do this so the module/builtin >>> split doesn't bite us? >>> >> #ifdef CONFIG_NF_CONNTRACK ?? That is basically what

Re: [net-next regression] kselftest failure in fib_nl_newrule()

On Tue, Apr 24, 2018 at 2:46 AM, Anders Roxell <anders.rox...@linaro.org> wrote: > Hi, > > fib-onlink-tests.sh (from kselftest) found a regression between > next-20180424 [1] (worked with tag next-20180423 [2]) > > here is tree commits that look suspicious specially this pa

Re: [PATCH v3] kvmalloc: always use vmalloc if CONFIG_DEBUG_SG

On Tue, 24 Apr 2018, Michal Hocko wrote: > On Tue 24-04-18 11:50:30, Mikulas Patocka wrote: > > > > > > On Tue, 24 Apr 2018, Michal Hocko wrote: > > > > > On Mon 23-04-18 20:06:16, Mikulas Patocka wrote: > > > [...] > > > > @@ -404,6 +405,12 @@ void *kvmalloc_node(size_t size, gfp_t f > > >

Re: [net-next 1/2] ipv6: sr: add a per namespace sysctl to control seg6 flowlabel

From: Ahmed Abdelsalam Date: Mon, 23 Apr 2018 23:36:59 +0200 > This patch adds a per namespace sysctl, named 'seg6_flowlabel', to be used > by seg6_do_srh_encap() to control the behaviour of setting the flowlabel > value of outer IPv6. > > The currently support behaviours

Re: [PATCH] liquidio: fix lio_vf_rep_pkt_xmit()'s return type

On Tue, Apr 24, 2018 at 03:16:39PM +0200, Luc Van Oostenryck wrote: > The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', > which is a typedef for an enum type, but the implementation in this > driver returns an 'int'. > > Fix this by returning 'netdev_tx_t' in this driver too.

Re: [PATCH v3] kvmalloc: always use vmalloc if CONFIG_DEBUG_SG

On Tue, Apr 24, 2018 at 08:29:14AM -0400, Mikulas Patocka wrote: > > > On Mon, 23 Apr 2018, Matthew Wilcox wrote: > > > On Mon, Apr 23, 2018 at 08:06:16PM -0400, Mikulas Patocka wrote: > > > Some bugs (such as buffer overflows) are better detected > > > with kmalloc code, so we must test the

Re: [PATCH net] packet: fix bitfield update race

From: Willem de Bruijn Date: Mon, 23 Apr 2018 17:37:03 -0400 > From: Willem de Bruijn > > Updates to the bitfields in struct packet_sock are not atomic. > Serialize these read-modify-write cycles. > > Move po->running into a separate

Re: mt7601u: phy: mark expected switch fall-through

"Gustavo A. R. Silva" wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Signed-off-by: Gustavo A. R. Silva > Acked-by: Jakub Kicinski Patch applied to

Re: [PATCH 0/4] A few rhashtables cleanups

From: NeilBrown Date: Tue, 24 Apr 2018 08:29:13 +1000 > 2 patches fixes documentation > 1 fixes a bit in rhashtable_walk_start() > 1 improves rhashtable_walk stability. > > All reviewed and Acked. Series applied to net-next, thanks Neil.

Re: [PATCH v3] kvmalloc: always use vmalloc if CONFIG_DEBUG_SG

On Tue 24-04-18 13:28:49, Mikulas Patocka wrote: > > > On Tue, 24 Apr 2018, Michal Hocko wrote: > > > On Tue 24-04-18 13:00:11, Mikulas Patocka wrote: > > > > > > > > > On Tue, 24 Apr 2018, Michal Hocko wrote: > > > > > > > On Tue 24-04-18 11:50:30, Mikulas Patocka wrote: > > > > > > > > >

Re: [PATCH net v2] net: ethtool: Add missing kernel doc for FEC parameters

From: Florian Fainelli Date: Mon, 23 Apr 2018 15:51:38 -0700 > While adding support for ethtool::get_fecparam and set_fecparam, kernel > doc for these functions was missed, add those. > > Fixes: 1a5f3da20bd9 ("net: ethtool: add support for forward error correction >

Re: [PATCH] net: phy: allow scanning busses with missing phys

On Tue, Apr 24, 2018 at 09:37:09AM -0700, Florian Fainelli wrote: > > > On 04/24/2018 09:09 AM, Alexandre Belloni wrote: > > Some MDIO busses will error out when trying to read a phy address with no > > phy present at that address. In that case, probing the bus will fail > > because

Re: [PATCH V7 net-next 00/14] TLS offload, netdev & MLX5 support

From: Boris Pismenny Date: Tue, 24 Apr 2018 16:12:51 +0300 > The following series provides TLS TX inline crypto offload. Unfortunately the mlx5 bits don't apply cleanly to net-next, please respin. Thank you.

Re: [PATCH] fsl/fman_port: remove redundant check on port->rev_info.major

From: Colin King Date: Tue, 24 Apr 2018 12:39:45 +0100 > From: Colin Ian King > > The check port->rev_info.major >= 6 is being performed twice, thus > the inner second check is always true and is redundant, hence it > can be removed. Detected

Re: [PATCH] net/tls: remove redundant second null check on sgout

From: Colin King Date: Tue, 24 Apr 2018 13:36:58 +0100 > From: Colin Ian King > > A duplicated null check on sgout is redundant as it is known to be > already true because of the identical earlier check. Remove it. > Detected by cppcheck: >

Boot failures with net-next after rebase to v4.17.0-rc1

Hi all, I'm experiencing boot failures with net-next git-tree after it got rebased/merged with Linus'es tree at v4.17.0-rc1. The boot problem only occurs for certain kernel configs. I've bisected the config problem down to enabling CONFIG_PREEMPT=y and resulting dependencies in below diff. Is

Re: [PATCH net-next v5 0/3] kernel: add support to collect hardware logs in crash recovery kernel

From: Rahul Lakkireddy Date: Sat, 21 Apr 2018 22:35:52 +0530 > Patch 1 adds API to vmcore module to allow drivers to register callback > to collect the device specific hardware/firmware logs. The logs will > be added to /proc/vmcore as elf notes. > > Patch 2

Re: Boot failures with net-next after rebase to v4.17.0-rc1

On Tue, Apr 24, 2018 at 12:54 PM, Jesper Dangaard Brouer wrote: > Hi all, > > I'm experiencing boot failures with net-next git-tree after it got > rebased/merged with Linus'es tree at v4.17.0-rc1. I suspect it's the global bit stuff that came in very late in the merge window,

Re: [PATCH net-next] net/ipv6: fix LOCKDEP issue in rt6_remove_exception_rt()

From: Eric Dumazet Date: Tue, 24 Apr 2018 09:22:49 -0700 > rt6_remove_exception_rt() is called under rcu_read_lock() only. > > We lock rt6_exception_lock a bit later, so we do not hold > rt6_exception_lock yet. > > Fixes: 8a14e46f1402 ("net/ipv6: Fix missing rcu

Re: [net 0/6][pull request] Intel Wired LAN Driver Updates 2018-04-24

From: Jeff Kirsher Date: Tue, 24 Apr 2018 12:43:44 -0700 > On Tue, 2018-04-24 at 12:29 -0700, Jeff Kirsher wrote: >> This series contains fixes to ixgbevf, igb and ice drivers. >> >> Colin Ian King fixes the return value on error for the new XDP >> support >> that

[PATCH net-next 2/2 v2] netns: isolate seqnums to use per-netns locks

Now that it's possible to have a different set of uevents in different network namespaces, per-network namespace uevent sequence numbers are introduced. This increases performance as locking is now restricted to the network namespace affected by the uevent rather than locking everything. Testing

[PATCH net-next 0/2 v2] netns: uevent performance tweaks

Hey everyone, This is v2 of "netns: uevent performance tweaks" which contains *no functional changes* just a minor indendation fix as requested by David. Like Eric requested, I did extensive testing that prove significant performance improvements when using per-netns uevent sequence numbers with

[PATCH net-next 1/2 v2] netns: restrict uevents

commit 07e98962fa77 ("kobject: Send hotplug events in all network namespaces") enabled sending hotplug events into all network namespaces back in 2010. Over time the set of uevents that get sent into all network namespaces has shrunk a little. We have now reached the point where hotplug events

Re: [PATCH net-next 1/2 v2] netns: restrict uevents

We already do this in practice in userspace. It doesn't make much sense to perform this delivery. So we might as well make this optimization. Christian Brauner writes: > commit 07e98962fa77 ("kobject: Send hotplug events in all network namespaces") > > enabled

packetdrill 2.0 release

Hi All, We're happy to announce the 2.0 release of the Google version of the packetdrill network testing tool. The code may be found at the packetdrill-v2.0 tag in the Google packetdrill github repo: https://github.com/google/packetdrill The commit is here:

[PATCH net-next] sctp: fix identification of new acks for SFR-CACC

It's currently written as: if (!tchunk->tsn_gap_acked) { [1] tchunk->tsn_gap_acked = 1; ... } if (TSN_lte(tsn, sack_ctsn)) { if (!tchunk->tsn_gap_acked) { /* SFR-CACC processing */ ... } } Which causes the SFR-CACC processing on

[PATCH net-next] sctp: fix const parameter violation in sctp_make_sack

sctp_make_sack() make changes to the asoc and this cast is just bypassing the const attribute. As there is no need to have the const there, just remove it and fix the violation. Signed-off-by: Marcelo Ricardo Leitner --- This one can go to net or net-next, but

Re: [PATCH bpf-next,v3 0/2] bpf: add helper for getting xfrm states

On 04/24/2018 04:50 PM, Eyal Birger wrote: > This patchset adds support for fetching XFRM state information from > an eBPF program called from TC. > > The first patch introduces a helper for fetching an XFRM state from the > skb's secpath. The XFRM state is modeled using a new virtual struct

Re: [PATCH net-next] liquidio: Swap VF representor Tx and Rx statistics

From: Felix Manlunas Date: Tue, 24 Apr 2018 10:23:27 -0700 > From: Srinivas Jampala > > Swap VF representor tx and rx interface statistics since it is a > virtual switchdev port and tx for VM should be rx for VF representor > and

[PATCH net-next] neighbour: support for NTF_EXT_LEARNED flag

From: Roopa Prabhu This patch extends NTF_EXT_LEARNED support to the neighbour system. Example use-case: An Ethernet VPN implementation (eg in FRR routing suite) can use this flag to add dynamic reachable external neigh entires learned via control plane. The use of

Re: [pci PATCH v8 0/4] Add support for unmanaged SR-IOV

On Sat, Apr 21, 2018 at 05:22:27PM -0700, Alexander Duyck wrote: > On Sat, Apr 21, 2018 at 1:34 PM, Bjorn Helgaas wrote: > > For example, I'm not sure what you mean by "devices where the PF is > > not capable of managing VF resources." > > > > It *sounds* like you're saying

[GIT] Networking

1) Fix rtnl deadlock in ipvs, from Julian Anastasov. 2) s390 qeth fixes from Julian Wiedmann (control IO completion stalls, bad MAC address update sequence, request side races on command IO timeouts). 3) Handle seq_file overflow properly in l2tp, from Guillaume Nault. 4) Fix VLAN priority

[PATCH bpf-next] tools/bpf: remove test_sock_addr from TEST_GEN_PROGS

Since test_sock_addr is not supposed to run by itself, remove it from TEST_GEN_PROGS and add it to TEST_GEN_PROGS_EXTENDED. This way, run_tests will not run test_sock_addr. The corresponding test to run is test_sock_addr.sh. Signed-off-by: Yonghong Song ---

Re: [PATCH v2] selftests: bpf: update .gitignore with missing file

On 04/24/2018 12:53 AM, Anders Roxell wrote: > Fixes: c0fa1b6c3efc ("bpf: btf: Add BTF tests") > Signed-off-by: Anders Roxell > --- > Rebased against bpf-next. Applied to bpf-next, thanks Anders!

Re: [PATCH bpf-next] tools/bpf: remove test_sock_addr from TEST_GEN_PROGS

On 04/24/2018 11:45 PM, Yonghong Song wrote: > Since test_sock_addr is not supposed to run by itself, > remove it from TEST_GEN_PROGS and add it to > TEST_GEN_PROGS_EXTENDED. This way, run_tests will > not run test_sock_addr. The corresponding test to run > is test_sock_addr.sh. > >

Re: [PATCH net-next 2/2 v2] netns: isolate seqnums to use per-netns locks

On Tue, Apr 24, 2018 at 04:52:20PM -0500, Eric W. Biederman wrote: > Christian Brauner writes: > > > Now that it's possible to have a different set of uevents in different > > network namespaces, per-network namespace uevent sequence numbers are > > introduced. This

[PATCH v3 net] sfc: ARFS filter IDs

Associate an arbitrary ID with each ARFS filter, allowing to properly query for expiry. The association is maintained in a hash table, which is protected by a spinlock. v3: fix build warnings when CONFIG_RFS_ACCEL is disabled (thanks lkp-robot). v2: fixed uninitialised variable (thanks davem

Re: [PATCH net-next] Revert "net: init sk_cookie for inet socket"

On 04/24/2018 08:59 AM, Yafang Shao wrote: > On Tue, Apr 24, 2018 at 11:49 PM, Eric Dumazet wrote: >> >> >> On 04/24/2018 08:12 AM, Yafang Shao wrote: >>> On Tue, Apr 24, 2018 at 8:38 PM, Eric Dumazet >>> wrote: On 04/24/2018

Re: [PATCH] net: phy: TLK10X initial driver submission

On Thu, Apr 19, 2018 at 10:28:16AM +0200, Måns Andersson wrote: > From: Mans Andersson > > Add suport for the TI TLK105 and TLK106 10/100Mbit ethernet phys. > > In addition the TLK10X needs to be removed from DP83848 driver as the > power back off support is added here

Re: [PATCH bpf-next 13/15] xsk: support for Tx

On Mon, Apr 23, 2018 at 9:56 AM, Björn Töpel wrote: > From: Magnus Karlsson > > Here, Tx support is added. The user fills the Tx queue with frames to > be sent by the kernel, and let's the kernel know using the sendmsg > syscall. > >

Re: [PATCH 1/1] Revert "rds: ib: add error handle"

On 4/24/2018 4:25 AM, Dag Moxnes wrote: I was going to suggest the following correction: If all agree that this is the correct way of doing it, I can go ahead and an post it. Yes please. Go ahead and post your fix. Regards, Santosh P.S: Avoid top posting please.

Re: [PATCH bpf-next 14/15] xsk: statistics support

On Mon, Apr 23, 2018 at 9:56 AM, Björn Töpel wrote: > From: Magnus Karlsson > > In this commit, a new getsockopt is added: XDP_STATISTICS. This is > used to obtain stats from the sockets. > > Signed-off-by: Magnus Karlsson

Re: [net-next 1/2] ipv6: sr: add a per namespace sysctl to control seg6 flowlabel

On Tue, 24 Apr 2018 13:16:50 -0400 (EDT) David Miller wrote: > From: Ahmed Abdelsalam > Date: Mon, 23 Apr 2018 23:36:59 +0200 > > > This patch adds a per namespace sysctl, named 'seg6_flowlabel', to be used > > by seg6_do_srh_encap() to control the

[PATCH] net: phy: allow scanning busses with missing phys

Some MDIO busses will error out when trying to read a phy address with no phy present at that address. In that case, probing the bus will fail because __mdiobus_register() is scanning the bus for all possible phys addresses. In case MII_PHYSID1 returns -EIO or -ENODEV, consider there is no phy at

Re: [PATCH bpf-next 00/15] Introducing AF_XDP support

On Mon, Apr 23, 2018 at 9:56 AM, Björn Töpel wrote: > From: Björn Töpel > > This RFC introduces a new address family called AF_XDP that is > optimized for high performance packet processing and, in upcoming > patch sets, zero-copy semantics.

Re: [PATCH] net: phy: allow scanning busses with missing phys

On 24/04/2018 09:37:09-0700, Florian Fainelli wrote: > > > On 04/24/2018 09:09 AM, Alexandre Belloni wrote: > > Some MDIO busses will error out when trying to read a phy address with no > > phy present at that address. In that case, probing the bus will fail > > because __mdiobus_register() is

Re: [PATCH] net: nfp: fix nfp_net_tx()'s return type

On Tue, 24 Apr 2018 15:17:07 +0200, Luc Van Oostenryck wrote: > The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', > which is a typedef for an enum type, but the implementation in this > driver returns an 'int'. > > Fix this by returning 'netdev_tx_t' in this driver too. > >

Re: [PATCH bpf-next 08/15] bpf: introduce new bpf AF_XDP map type BPF_MAP_TYPE_XSKMAP

2018-04-24 18:56 GMT+02:00 Willem de Bruijn : > On Mon, Apr 23, 2018 at 9:56 AM, Björn Töpel wrote: >> From: Björn Töpel >> >> The xskmap is yet another BPF map, very much inspired by >> dev/cpu/sockmap, and is a

[net 2/6] igb: Fix the transmission mode of queue 0 for Qav mode

From: Vinicius Costa Gomes When Qav mode is enabled, queue 0 should be kept on Stream Reservation mode. From the i210 datasheet, section 8.12.19: "Note: Queue0 QueueMode must be set to 1b when TransmitMode is set to Qav." ("QueueMode 1b" represents the Stream

[net 3/6] ice: Fix initialization for num_nodes_added

From: Anirudh Venkataramanan ice_sched_add_nodes_to_layer is used recursively, and so we start with num_nodes_added being 0. This way, in case of an error or if num_nodes is NULL, the function just returns 0 to indicate that no nodes were added. Fixes:

[net 5/6] ice: Do not check INTEVENT bit for OICR interrupts

From: Ben Shelton According to the hardware spec, checking the INTEVENT bit isn't a reliable way to detect if an OICR interrupt has occurred. This is because this bit can be cleared by the hardware/firmware before the interrupt service routine has run. So instead,

[net 4/6] ice: Fix incorrect comment for action type

From: Anirudh Venkataramanan Action type 5 defines large action generic values. Fix comment to reflect that better. Signed-off-by: Anirudh Venkataramanan Tested-by: Tony Brelinski Signed-off-by:

[net 0/6][pull request] Intel Wired LAN Driver Updates 2018-04-24

This series contains fixes to ixgbevf, igb and ice drivers. Colin Ian King fixes the return value on error for the new XDP support that went into ixgbevf for 4.16. Vinicius provides a fix for queue 0 for igb, which was not receiving all the credits it needed when QAV mode was enabled. Anirudh

[net 1/6] ixgbevf: ensure xdp_ring resources are free'd on error exit

From: Colin Ian King The current error handling for failed resource setup for xdp_ring data is a break out of the loop and returning 0 indicated everything was OK, when in fact it is not. Fix this by exiting via the error exit label err_setup_tx that will clean up the

[net 6/6] ice: Fix insufficient memory issue in ice_aq_manage_mac_read

From: Md Fahad Iqbal Polash For the MAC read operation, the device can return up to two (LAN and WoL) MAC addresses. Without access to adequate memory, the device will return an error. Fixed this by allocating the right amount of memory. Also, logic to detect and

Re: [PATCH net-next 2/2 v1] netns: isolate seqnums to use per-netns locks

From: Christian Brauner Date: Mon, 23 Apr 2018 12:24:43 +0200 > + #ifdef CONFIG_NET > + seqnum = get_ns_uevent_seqnum_by_vpid(); > + #else > + seqnum = uevent_seqnum; > + #endif Please don't indend the code like this. By

Re: [PATCH] net: phy: TLK10X initial driver submission

On 04/19/2018 01:28 AM, Måns Andersson wrote: > From: Mans Andersson > > Add suport for the TI TLK105 and TLK106 10/100Mbit ethernet phys. > > In addition the TLK10X needs to be removed from DP83848 driver as the > power back off support is added here for this device.

Re: kTLS in combination with mlx4 is very unstable

On 04/22/18 11:21 PM, Andre Tomt wrote: > kTLS looks fun, so I decided to play with it. It is quite spiffy - however > with mlx4 I get kernel crashes I'm not seeing when testing on ixgbe. > > For testing I'm using a git build of the "stream reflector" cubemap[1] > configured with kTLS and 8

Re: [PATCH net-next] tcp: md5: only call tp->af_specific->md5_lookup() for md5 sockets

From: Eric Dumazet Date: Mon, 23 Apr 2018 14:46:25 -0700 > RETPOLINE made calls to tp->af_specific->md5_lookup() quite expensive, > given they have no result. > We can omit the calls for sockets that have no md5 keys. > > Signed-off-by: Eric Dumazet

[net-next v2] ipv6: sr: Compute flowlabel for outer IPv6 header of seg6 encap mode

ECMP (equal-cost multipath) hashes are typically computed on the packets' 5-tuple(src IP, dst IP, src port, dst port, L4 proto). For encapsulated packets, the L4 data is not readily available and ECMP hashing will often revert to (src IP, dst IP). This will lead to traffic polarization on a

Re: [PATCH net-next] qed: Fix copying 2 strings

From: Denis Bolotin Date: Tue, 24 Apr 2018 15:32:53 +0300 > The strscpy() was a recent fix (net: qed: use correct strncpy() size) to > prevent passing the length of the source buffer to strncpy() and guarantee > null termination. > It misses the goal of overwriting only

[net-next v3] ipv6: sr: Compute flowlabel for outer IPv6 header of seg6 encap mode

ECMP (equal-cost multipath) hashes are typically computed on the packets' 5-tuple(src IP, dst IP, src port, dst port, L4 proto). For encapsulated packets, the L4 data is not readily available and ECMP hashing will often revert to (src IP, dst IP). This will lead to traffic polarization on a

Re: [PATCH 5/5] PCI: remove PCI_DMA_BUS_IS_PHYS

On Tue, 24 Apr 2018 11:16:25 PDT (-0700), Christoph Hellwig wrote: This was used by the ide, scsi and networking code in the past to determine if they should bounce payloads. Now that the dma mapping always have to support dma to all physical memory (thanks to swiotlb for non-iommu systems)

Re: VRF: Ingress IPv6 Linklocal/Multicast destined pkt from slave VRF device does not map to Master device socket

On 4/23/18 11:57 PM, Sukumar Gopalakrishnan wrote: > Get master device address from (skb->dev) and pass master to socket > lookup up function for Ipv6 Linklocal/Multicast address. > > ipv6_raw_deliver() > { > int mdif; > .. > .. > mdif = (((nexthdr == IPPROTO_PIM || nexthdr == 89 /*

Re: fix for bnx2x panic during ethtool reporting

Here's an updated version of the patch that is checkpatch.pl clean (I had forgotten to sign off...). -- Sebastian Kuzminsky From 45fe6fb1f6a187233bd1304b031bed20b3819d26 Mon Sep 17 00:00:00 2001 From: Sebastian Kuzminsky Date: Mon, 16 Apr 2018 23:24:07 + Subject: [PATCH]

Re: [PATCH v2 0/8] ipconfig: NTP server support, bug fixes, documentation improvements

From: Chris Novakovic Date: Tue, 24 Apr 2018 03:56:31 +0100 > This series (against net-next) makes various improvements to ipconfig: > > - Patch #1 correctly documents the behaviour of parameter 4 in the >"ip=" and "nfsaddrs=" command line parameter. > - Patch #2

Re: [PATCH 2/3] net/unix: hook unix_socketpair() into LSM

On Mon, Apr 23, 2018 at 9:30 AM, David Herrmann wrote: > Use the newly created LSM-hook for unix_socketpair(). The default hook > return-value is 0, so behavior stays the same unless LSMs start using > this hook. > > Signed-off-by: David Herrmann >

Re: [PATCH v3] kvmalloc: always use vmalloc if CONFIG_DEBUG_SG

On Tue, 24 Apr 2018, Matthew Wilcox wrote: > On Tue, Apr 24, 2018 at 08:29:14AM -0400, Mikulas Patocka wrote: > > > > > > On Mon, 23 Apr 2018, Matthew Wilcox wrote: > > > > > On Mon, Apr 23, 2018 at 08:06:16PM -0400, Mikulas Patocka wrote: > > > > Some bugs (such as buffer overflows) are

Re: [net 0/6][pull request] Intel Wired LAN Driver Updates 2018-04-24

On Tue, 2018-04-24 at 12:29 -0700, Jeff Kirsher wrote: > This series contains fixes to ixgbevf, igb and ice drivers. > > Colin Ian King fixes the return value on error for the new XDP > support > that went into ixgbevf for 4.16. Oops, I meant 4.17, not 4.16. > > Vinicius provides a fix for

Re: simplify procfs code for seq_file instances

On Tue, Apr 24, 2018 at 08:19:16AM -0700, Andrew Morton wrote: > > > I want to ask if it is time to start using poorman function overloading > > > with _b_c_e(). There are millions of allocation functions for example, > > > all slightly difference, and people will add more. Seeing /proc interfaces

[PATCH net-next] net/ipv6: fix LOCKDEP issue in rt6_remove_exception_rt()

rt6_remove_exception_rt() is called under rcu_read_lock() only. We lock rt6_exception_lock a bit later, so we do not hold rt6_exception_lock yet. Fixes: 8a14e46f1402 ("net/ipv6: Fix missing rcu dereferences on from") Signed-off-by: Eric Dumazet Reported-by: syzbot

Re: [PATCH bpf-next 03/15] xsk: add umem fill queue support and mmap

+/* Pgoff for mmaping the rings */ +#define XDP_UMEM_PGOFF_FILL_RING 0x1 + +struct xdp_ring { + __u32 producer __attribute__((aligned(64))); + __u32 consumer __attribute__((aligned(64))); +}; >>> >>> Why 64? And do you still need these guys in

Re: [PATCH bpf-next 05/15] xsk: add support for bind for Rx

On Mon, Apr 23, 2018 at 9:56 AM, Björn Töpel wrote: > From: Magnus Karlsson > > Here, the bind syscall is added. Binding an AF_XDP socket, means > associating the socket to an umem, a netdev and a queue index. This > can be done in two ways. > >

Re: [PATCH bpf-next 08/15] bpf: introduce new bpf AF_XDP map type BPF_MAP_TYPE_XSKMAP

On Mon, Apr 23, 2018 at 9:56 AM, Björn Töpel wrote: > From: Björn Töpel > > The xskmap is yet another BPF map, very much inspired by > dev/cpu/sockmap, and is a holder of AF_XDP sockets. A user application > adds AF_XDP sockets into the map, and by

Re: [PATCH bpf-next 07/15] xsk: add Rx receive functions and poll support

On Mon, Apr 23, 2018 at 9:56 AM, Björn Töpel wrote: > From: Björn Töpel > > Here the actual receive functions of AF_XDP are implemented, that in a > later commit, will be called from the XDP layers. > > There's one set of functions for the XDP_DRV

Re: [PATCH] liquidio: fix liquidio_xmit()'s return type

On Tue, Apr 24, 2018 at 03:16:37PM +0200, Luc Van Oostenryck wrote: > The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', > which is a typedef for an enum type, but the implementations in this > driver returns an 'int'. > > Fix this by returning 'netdev_tx_t' in this driver too.

Re: [PATCH net-next] ipv6: addrconf: don't evaluate keep_addr_on_down twice

On 4/24/18 1:31 AM, Ivan Vecera wrote: > The addrconf_ifdown() evaluates keep_addr_on_down state twice. There > is no need to do it. > > Cc: David Ahern > Signed-off-by: Ivan Vecera > --- > net/ipv6/addrconf.c | 23 ++- > 1 file changed, 10

Re: [net-next v2] ipv6: sr: Compute flowlabel for outer IPv6 header of seg6 encap mode

On Tue, 24 Apr 2018 19:59:55 +0200 Ahmed Abdelsalam wrote: > This patch has been tested for IPv6, IPv4, and L2 traffic. > > Signed-off-by: Ahmed Abdelsalam > --- > include/net/netns/ipv6.h | 1 + > net/ipv6/seg6_iptunnel.c | 24

Re: [PATCH] kvmalloc: always use vmalloc if CONFIG_DEBUG_VM

On Tue 24-04-18 11:30:40, Mikulas Patocka wrote: > > > On Tue, 24 Apr 2018, Michal Hocko wrote: > > > On Mon 23-04-18 20:25:15, Mikulas Patocka wrote: > > > > > Fixing __vmalloc code > > > is easy and it doesn't require cooperation with maintainers. > > > > But it is a hack against the

Re: [PATCH] net: phy: allow scanning busses with missing phys

On 04/24/2018 09:09 AM, Alexandre Belloni wrote: > Some MDIO busses will error out when trying to read a phy address with no > phy present at that address. In that case, probing the bus will fail > because __mdiobus_register() is scanning the bus for all possible phys > addresses. > > In case

Re: [PATCH] net: sh-eth: fix sh_eth_start_xmit()'s return type

Hello! On 04/24/2018 04:17 PM, Luc Van Oostenryck wrote: > The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', > which is a typedef for an enum type, but the implementation in this > driver returns an 'int'. > > Fix this by returning 'netdev_tx_t' in this driver too. > >

Re: [PATCH v3] kvmalloc: always use vmalloc if CONFIG_DEBUG_SG

On Tue 24-04-18 13:00:11, Mikulas Patocka wrote: > > > On Tue, 24 Apr 2018, Michal Hocko wrote: > > > On Tue 24-04-18 11:50:30, Mikulas Patocka wrote: > > > > > > > > > On Tue, 24 Apr 2018, Michal Hocko wrote: > > > > > > > On Mon 23-04-18 20:06:16, Mikulas Patocka wrote: > > > > [...] > > >

Re: ath9k_htc - Division by zero in kernel (as well as firmware panic)

I finally got around to applying your patch, building the toolchain (based on master source (gcc8)), but alas while there is no firmware panic in the log, wifi drops off the face of the planet (ssid disappears and hostapd doesn't know wifi failed (nothing in the log either)). On Wed, Jun 7, 2017

Re: [PATCH v3] kvmalloc: always use vmalloc if CONFIG_DEBUG_SG

On Tue, 24 Apr 2018, Michal Hocko wrote: > On Tue 24-04-18 13:00:11, Mikulas Patocka wrote: > > > > > > On Tue, 24 Apr 2018, Michal Hocko wrote: > > > > > On Tue 24-04-18 11:50:30, Mikulas Patocka wrote: > > > > > > > > > > > > On Tue, 24 Apr 2018, Michal Hocko wrote: > > > > > > > > > On

Re: [PATCH] net: phy: TLK10X initial driver submission

> > +Required properties: > > + - reg - The ID number for the phy, usually a small integer > > Isn't this the MDIO bus address? Hi Rob Yes. This text has been take direct from the generic PHY binding. > This should have a compatible string too. Please see

Re: [PATCH net-next v2 0/2] openvswitch: Support conntrack zone limit

On Tue, Apr 24, 2018 at 10:42 AM, David Miller wrote: > From: Pravin Shelar > Date: Mon, 23 Apr 2018 23:34:48 -0700 > >> OK. Thanks for the info. > > So, ACK, Reviewed-by, etc.? :-) > Parvin provides feedback in a previous email. I will address them and

Re: [PATCH net-next 5/8] net: mscc: Add initial Ocelot switch support

I realise now that I didn't reply to this comment: On 30/03/2018 16:50:08+0200, Andrew Lunn wrote: > > The fact is that ocelot doesn't have separate controls. The port is > > either forwarding or not. If it is not forwarding, then there is nothing > > to tell the HW to do. > > Think about the

Re: [PATCH net-next v2 0/2] openvswitch: Support conntrack zone limit

From: Yi-Hung Wei Date: Tue, 24 Apr 2018 11:21:33 -0700 > On Tue, Apr 24, 2018 at 10:42 AM, David Miller wrote: >> From: Pravin Shelar >> Date: Mon, 23 Apr 2018 23:34:48 -0700 >> >>> OK. Thanks for the info. >> >> So, ACK,

Re: [PATCH net-next] net/ipv6: fix LOCKDEP issue in rt6_remove_exception_rt()

On 4/24/18 10:22 AM, Eric Dumazet wrote: > rt6_remove_exception_rt() is called under rcu_read_lock() only. > > We lock rt6_exception_lock a bit later, so we do not hold > rt6_exception_lock yet. > > Fixes: 8a14e46f1402 ("net/ipv6: Fix missing rcu dereferences on from") > Signed-off-by: Eric

Re: [PATCH] kvmalloc: always use vmalloc if CONFIG_DEBUG_VM

On Tue, 24 Apr 2018, Michal Hocko wrote: > On Tue 24-04-18 11:30:40, Mikulas Patocka wrote: > > > > > > On Tue, 24 Apr 2018, Michal Hocko wrote: > > > > > On Mon 23-04-18 20:25:15, Mikulas Patocka wrote: > > > > > > > Fixing __vmalloc code > > > > is easy and it doesn't require cooperation

Re: [PATCH net-next v2 0/2] openvswitch: Support conntrack zone limit

From: Pravin Shelar Date: Mon, 23 Apr 2018 23:34:48 -0700 > OK. Thanks for the info. So, ACK, Reviewed-by, etc.? :-)

[PATCH net-next v2] ipv6: addrconf: don't evaluate keep_addr_on_down twice

The addrconf_ifdown() evaluates keep_addr_on_down state twice. There is no need to do it. Cc: David Ahern Signed-off-by: Ivan Vecera --- net/ipv6/addrconf.c | 23 ++- 1 file changed, 10 insertions(+), 13 deletions(-) diff --git

Re: [PATCH v3 net] sfc: ARFS filter IDs

From: Edward Cree Date: Tue, 24 Apr 2018 17:09:30 +0100 > Associate an arbitrary ID with each ARFS filter, allowing to properly query > for expiry. The association is maintained in a hash table, which is > protected by a spinlock. > > v3: fix build warnings when

[PATCH 2/5] ide: kill ide_toggle_bounce

ide_toggle_bounce did select various strange block bounce limits, including not bouncing at all as soon as an iommu is present in the system. Given that the dma_map routines now handle any required bounce buffering except for ISA DMA, and the ide code already must handle either ISA DMA or highmem

remove PCI_DMA_BUS_IS_PHYS V2

Hi all, this series tries to get rid of the global and PCI_DMA_BUS_IS_PHYS flag, which causes the block layer and networking code to bounce buffer memory above the dma mask in some cases. It is a leftover from i386 + highmem days and is obsolete now that we have swiotlb or iommus so that the dma

Re: [PATCH bpf-next 05/15] xsk: add support for bind for Rx

2018-04-24 18:55 GMT+02:00 Willem de Bruijn : > On Mon, Apr 23, 2018 at 9:56 AM, Björn Töpel wrote: >> From: Magnus Karlsson >> >> Here, the bind syscall is added. Binding an AF_XDP socket, means >> associating

Re: [PATCH v3] kvmalloc: always use vmalloc if CONFIG_DEBUG_SG

On Tue 24-04-18 11:50:30, Mikulas Patocka wrote: > > > On Tue, 24 Apr 2018, Michal Hocko wrote: > > > On Mon 23-04-18 20:06:16, Mikulas Patocka wrote: > > [...] > > > @@ -404,6 +405,12 @@ void *kvmalloc_node(size_t size, gfp_t f > > >*/ > > > WARN_ON_ONCE((flags & GFP_KERNEL) !=

  1   2   3   4   >