Re: [PATCH net-next] Revert "net: init sk_cookie for inet socket"

On Tue, Apr 24, 2018 at 8:38 PM, Eric Dumazet wrote: > > > On 04/24/2018 05:05 AM, Yafang Shao wrote: >> This revert commit ("net: init sk_cookie for inet socket") >> >> Per discussion with Eric. >> > > I suggest you include a bit more details, about cache line false

[PATCH] xen-netback: fix xenvif_start_xmit()'s return type

The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck ---

[PATCH] usbnet: ipheth: fix ipheth_tx()'s return type

The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck ---

[PATCH] xen-netfront: fix xennet_start_xmit()'s return type

The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck ---

[PATCH] rapidio/rionet: fix rionet_start_xmit()'s return type

The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck ---

[PATCH] mwifiex: fix mwifiex_hard_start_xmit()'s return type

The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck ---

[PATCH] net: w5100: fix w5100_start_tx()'s return type

The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck ---

[PATCH] net: sh-eth: fix sh_eth_start_xmit()'s return type

The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck ---

[PATCH] net: nfp: fix nfp_net_tx()'s return type

The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck ---

[PATCH] net: pxa168: fix pxa168_eth_start_xmit()'s return type

The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck ---

[PATCH] net: mvneta: fix mvneta_tx()'s return type

The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck ---

[PATCH] caif-virtio: fix cfv_netdev_tx()'s return type

The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck ---

[PATCH] altera-tse: fix tse_start_xmit()'s return type

The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck ---

Re: [PATCH bpf-next v4 1/2] bpf: allow map helpers access to map values directly

On 04/23/2018 11:18 PM +0200, Daniel Borkmann wrote: > On 04/22/2018 11:52 PM, Paul Chaignon wrote: > > Helpers that expect ARG_PTR_TO_MAP_KEY and ARG_PTR_TO_MAP_VALUE can only > > access stack and packet memory. Allow these helpers to directly access > > map values by passing registers of type

[PATCH] caif: fix caif_xmit()'s return type

The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck ---

[PATCH] cail-hsi: fix cfhsi_xmit()'s return type

The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck ---

[PATCH V7 net-next 13/14] MAINTAINERS: Update mlx5 innova driver maintainers

Signed-off-by: Boris Pismenny Signed-off-by: Saeed Mahameed --- MAINTAINERS | 17 - 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index fc812fb..4bc79e3 100644 --- a/MAINTAINERS +++

[PATCH V7 net-next 14/14] MAINTAINERS: Update TLS maintainers

Signed-off-by: Boris Pismenny Signed-off-by: Saeed Mahameed --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 4bc79e3..9e218d1 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -9820,7

Re: [PATCH 20/39] afs: simplify procfs code

On Fri, Apr 20, 2018 at 01:29:34PM +0100, David Howells wrote: > David Howells wrote: > > > > Use remove_proc_subtree to remove the whole subtree on cleanup, and > > > unwind the registration loop into individual calls. Switch to use > > > proc_create_seq where applicable.

Re: [PATCH 26/39] rtc/proc: switch to proc_create_single_data

On Thu, Apr 19, 2018 at 03:10:27PM +0200, Alexandre Belloni wrote: > On 19/04/2018 14:41:27+0200, Christoph Hellwig wrote: > > And stop trying to get a reference on the submodule, procfs code deals > > with release after and unloaded module and thus removed proc entry. > > > > Are you sure about

Re: [PATCH 16/39] ipmi: simplify procfs code

On Thu, Apr 19, 2018 at 10:29:29AM -0500, Corey Minyard wrote: > On 04/19/2018 07:41 AM, Christoph Hellwig wrote: >> Use remove_proc_subtree to remove the whole subtree on cleanup instead >> of a hand rolled list of proc entries, unwind the registration loop into >> individual calls. Switch to

Re: [PATCH 03/39] proc: introduce proc_create_seq_private

On Thu, Apr 19, 2018 at 05:18:18PM +0300, Dan Carpenter wrote: > > -static const struct file_operations cio_ignore_proc_fops = { > > - .open= cio_ignore_proc_open, > > - .read= seq_read, > > - .llseek = seq_lseek, > > - .release = seq_release_private, > > - .write =

Re: [PATCH net-next V3 0/3] Introduce adaptive TX interrupt moderation to net DIM

From: Tal Gilboa Date: Tue, 24 Apr 2018 13:36:00 +0300 > Net DIM is a library designed for dynamic interrupt moderation. It was > implemented and optimized with receive side interrupts in mind, since these > are usually the CPU expensive ones. This patch-set introduces

Re: [PATCH 02/39] proc: introduce proc_create_seq{,_data}

On Thu, Apr 19, 2018 at 09:41:06PM +0300, Alexey Dobriyan wrote: > Should be oopsable. > Once proc_create_data() returns, entry is live, ->open can be called. Ok, switching to opencoding proc_create_data instead.

Re: [PATCH 03/39] proc: introduce proc_create_seq_private

On Thu, Apr 19, 2018 at 09:50:27PM +0300, Alexey Dobriyan wrote: > On Thu, Apr 19, 2018 at 02:41:04PM +0200, Christoph Hellwig wrote: > > Variant of proc_create_data that directly take a struct seq_operations > > > --- a/fs/proc/internal.h > > +++ b/fs/proc/internal.h > > @@ -45,6 +45,7 @@ struct

[PATCH RFC 7/9] veth: Add XDP TX and REDIRECT

From: Toshiaki Makita This allows further redirection of xdp_frames like NIC -> veth--veth -> veth--veth (XDP) (XDP) (XDP) The intermediate XDP, redirecting packets from NIC to the other veth, reuses xdp_mem info from NIC so that page

[PATCH RFC 9/9] veth: Avoid per-packet spinlock of XDP napi ring on enqueueing

From: Toshiaki Makita Use percpu temporary storage to avoid per-packet spinlock. This is different from dequeue in that multiple veth devices can be redirect target in one napi loop so allocate percpu storage in veth private structure. Signed-off-by: Toshiaki

[PATCH RFC 8/9] veth: Avoid per-packet spinlock of XDP napi ring on dequeueing

From: Toshiaki Makita Use percpu temporary storage to avoid per-packet spinlock. Signed-off-by: Toshiaki Makita --- drivers/net/veth.c | 46 +++--- 1 file changed, 27 insertions(+), 19

[PATCH RFC 3/9] veth: Avoid drops by oversized packets when XDP is enabled

From: Toshiaki Makita All oversized packets including GSO packets are dropped if XDP is enabled on receiver side, so don't send such packets from peer. Drop TSO and SCTP fragmentation features so that veth devices themselves segment packets with XDP enabled. Also

[PATCH RFC 5/9] veth: Handle xdp_frame in xdp napi ring

From: Toshiaki Makita This is preparation for XDP TX and ndo_xdp_xmit. Now the napi ring accepts both skb and xdp_frame. When xdp_frame is enqueued, skb will not be allocated until XDP program on veth returns PASS. This will speedup the XDP processing when

Re: [PATCH] net: aquantia: fix aq_ndev_start_xmit()'s return type

Luc please don't submit such a huge number of patches all at one time. Also, please fix the indentation of the functions whose arguments span multiple lines as has been pointed out to you in patch feedback. Finally, make this a true patch series. It is so much easier for maintainers to work

Re: [Cake] [PATCH iproute2-next v3] Add support for cake qdisc

On Tue, 24 Apr 2018 14:30:46 +0200 Toke Høiland-Jørgensen wrote: > +static void cake_print_json_tin(struct tc_cake_tin_stats *tst, uint version) > +{ > + open_json_object(NULL); > + print_uint(PRINT_JSON, "threshold_rate", NULL, tst->threshold_rate); > +

Re: [Cake] [PATCH iproute2-next v3] Add support for cake qdisc

Stephen Hemminger writes: > On Tue, 24 Apr 2018 14:30:46 +0200 > Toke Høiland-Jørgensen wrote: > >> +static void cake_print_json_tin(struct tc_cake_tin_stats *tst, uint version) >> +{ >> +open_json_object(NULL); >> +print_uint(PRINT_JSON,

[PATCH iproute2] ipaddress: strengthen check on 'label' input

As mentioned in the ip-address man page, an address label must be equal to the device name or prefixed by the device name followed by a colon. Currently the only check on this input is to see if the device name appears at the beginning of the label string. This commit adds an additional check to

[PATCH v2 net] sfc: ARFS filter IDs

Associate an arbitrary ID with each ARFS filter, allowing to properly query for expiry. The association is maintained in a hash table, which is protected by a spinlock. v2: fixed uninitialised variable (thanks davem and lkp-robot). Fixes: 3af0f34290f6 ("sfc: replace asynchronous filter

Re: simplify procfs code for seq_file instances

On Thu, Apr 19, 2018 at 09:57:50PM +0300, Alexey Dobriyan wrote: > > git://git.infradead.org/users/hch/misc.git proc_create > > > I want to ask if it is time to start using poorman function overloading > with _b_c_e(). There are millions of allocation functions for example, > all slightly

Re: [PATCH bpf-next 02/15] xsk: add user memory registration support sockopt

Hi Björn, I love your patch! Yet something to improve: [auto build test ERROR on bpf-next/master] url: https://github.com/0day-ci/linux/commits/Bj-rn-T-pel/Introducing-AF_XDP-support/20180424-085240 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master config: m68k

[PATCH RFC 1/9] net: Export skb_headers_offset_update and skb_copy_header

From: Toshiaki Makita Signed-off-by: Toshiaki Makita --- include/linux/skbuff.h | 2 ++ net/core/skbuff.c | 12 +++- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/include/linux/skbuff.h

[PATCH RFC 6/9] veth: Add ndo_xdp_xmit

From: Toshiaki Makita This allows NIC's XDP to redirect packets to veth. The destination veth device enqueues redirected packets to the napi ring of its peer, then they are processed by XDP on its peer veth device. This can be thought as calling another XDP program

[PATCH RFC 0/9] veth: Driver XDP

From: Toshiaki Makita This patch set introduces driver XDP for veth. Basically this is used in conjunction with redirect action of another XDP program. NIC ---> veth===veth (XDP) (redirect)(XDP) In this case xdp_frame can be forwarded to the

[PATCH RFC 2/9] veth: Add driver XDP

From: Toshiaki Makita This is basic implementation of veth driver XDP. Incoming packets are sent from the peer veth device in the form of skb, so this is generally doing the same thing as generic XDP. This itself is not so useful, but a starting point to

[PATCH RFC 4/9] veth: Use NAPI for XDP

From: Toshiaki Makita In order to avoid stack inflation by recursive XDP program call from ndo_xdp_xmit, this change introduces NAPI in veth. Add veth's own NAPI handler when XDP is enabled. Use ptr_ring to emulate NIC ring. Tx function enqueues packets to the

Re: [Cake] [PATCH iproute2-next v3] Add support for cake qdisc

On Tue, 24 Apr 2018 14:30:46 +0200 Toke Høiland-Jørgensen wrote: > diff --git a/tc/q_cake.c b/tc/q_cake.c > new file mode 100644 > index ..12263361 > --- /dev/null > +++ b/tc/q_cake.c > @@ -0,0 +1,778 @@ > +/* SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) */ > +/* > +

Re: [PATCH] net: sh-eth: fix sh_eth_start_xmit()'s return type

On Tue, Apr 24, 2018 at 3:17 PM, Luc Van Oostenryck wrote: > The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', > which is a typedef for an enum type, but the implementation in this > driver returns an 'int'. > > Fix this by returning 'netdev_tx_t'

[PATCH bpf-next,v3 1/2] bpf: add helper for getting xfrm states

This commit introduces a helper which allows fetching xfrm state parameters by eBPF programs attached to TC. Prototype: bpf_skb_get_xfrm_state(skb, index, xfrm_state, size, flags) skb: pointer to skb index: the index in the skb xfrm_state secpath array xfrm_state: pointer to 'struct

Re: [PATCH net] sfc: ARFS filter IDs

Hi Edward, I love your patch! Perhaps something to improve: [auto build test WARNING on net/master] url: https://github.com/0day-ci/linux/commits/Edward-Cree/sfc-ARFS-filter-IDs/20180424-080737 config: i386-randconfig-x0-04242110 (attached as .config) compiler: gcc-5 (Debian 5.5.0-3) 5.4.1

[PATCH bpf-next,v3 0/2] bpf: add helper for getting xfrm states

This patchset adds support for fetching XFRM state information from an eBPF program called from TC. The first patch introduces a helper for fetching an XFRM state from the skb's secpath. The XFRM state is modeled using a new virtual struct which contains the SPI, peer address, and reqid values of

[PATCH bpf-next,v3 2/2] samples/bpf: extend test_tunnel_bpf.sh with xfrm state test

Add a test for fetching xfrm state parameters from a tc program running on ingress. Signed-off-by: Eyal Birger --- samples/bpf/tcbpf2_kern.c | 16 +++ samples/bpf/test_tunnel_bpf.sh| 71 +++

Attention Please,

Attention Please, Dear Friend, ac My name is Mrs Ariet zongo. I am working with Bank of Africa here in Burkina Faso. Here in this bank existed dormant account for many years, which belong to one of our late foreign customer. When I discovered that there had been neither deposits nor

Re: [Cake] [PATCH iproute2-next v3] Add support for cake qdisc

Stephen Hemminger writes: > On Tue, 24 Apr 2018 16:52:57 +0200 > Toke Høiland-Jørgensen wrote: > >> Well, this is leftover from keeping track of different versions of the >> out-of-tree patch, and we already broke compatibility pretty thoroughly >> as a

Re: [PATCH 1/8] net: ethernet: stmmac: add adaptation for stm32mp157c.

On Tue, Apr 24, 2018 at 05:01:53PM +0200, Christophe Roullier wrote: > + case PHY_INTERFACE_MODE_RGMII: > + val = SYSCFG_PMCR_ETH_SEL_RGMII; > + if (dwmac->int_phyclk) > + val |= SYSCFG_PMCR_ETH_CLK_SEL; > + pr_debug("SYSCFG init :

Re: [Cake] [PATCH net-next v2] Add Common Applications Kept Enhanced (cake) qdisc

Georgios Amanakis writes: > On Tue, 24 Apr 2018 13:44:06 +0200 > Toke Høiland-Jørgensen wrote: > >> +config NET_SCH_CAKE >> + tristate "Common Applications Kept Enhanced (CAKE)" >> + help >> + Say Y here if you want to use the Common

[PATCH net-next v2 2/5] bpf: Add IPv6 Segment Routing helpers

The BPF seg6local hook should be powerful enough to enable users to implement most of the use-cases one could think of. After some thinking, we figured out that the following actions should be possible on a SRv6 packet, requiring 3 specific helpers : - bpf_lwt_seg6_store_bytes: Modify

[PATCH net-next v2 4/5] ipv6: sr: Add seg6local action End.BPF

This patch adds the End.BPF action to the LWT seg6local infrastructure. This action works like any other seg6local End action, meaning that an IPv6 header with SRH is needed, whose DA has to be equal to the SID of the action. It will also advance the SRH to the next segment, the BPF program does

[PATCH net-next v2 0/5] ipv6: sr: introduce seg6local End.BPF action

As of Linux 4.14, it is possible to define advanced local processing for IPv6 packets with a Segment Routing Header through the seg6local LWT infrastructure. This LWT implements the network programming principles defined in the IETF “SRv6 Network Programming” draft. The implemented operations are

[PATCH net-next v2 3/5] bpf: Split lwt inout verifier structures

The new bpf_lwt_push_encap helper should only be accessible within the LWT BPF IN hook, and not the OUT one, as this may lead to a skb under panic. At the moment, both LWT BPF IN and OUT share the same list of helpers, whose calls are authorized by the verifier. This patch separates the verifier

[PATCH net-next v2 5/5] selftests/bpf: test for seg6local End.BPF action

Add a new test for the seg6local End.BPF action. The following helpers are also tested : - bpf_lwt_push_encap within the LWT BPF IN hook - bpf_lwt_seg6_action - bpf_lwt_seg6_adjust_srh - bpf_lwt_seg6_store_bytes A chain of End.BPF actions is built. The SRH is injected through a LWT BPF IN hook

[PATCH net-next v2 1/5] ipv6: sr: export function lookup_nexthop

The function lookup_nexthop is essential to implement most of the seg6local actions. As we want to provide a BPF helper allowing to apply some of these actions on the packet being processed, the helper should be able to call this function, hence the need to make it public. Moreover, if one

Re: [PATCH net-next] Revert "net: init sk_cookie for inet socket"

On 04/24/2018 08:12 AM, Yafang Shao wrote: > On Tue, Apr 24, 2018 at 8:38 PM, Eric Dumazet wrote: >> >> >> On 04/24/2018 05:05 AM, Yafang Shao wrote: >>> This revert commit ("net: init sk_cookie for inet socket") >>> >>> Per discussion with Eric. >>> >> >> I suggest you

Re: [PATCH v3] kvmalloc: always use vmalloc if CONFIG_DEBUG_SG

On Tue, 24 Apr 2018, Michal Hocko wrote: > On Mon 23-04-18 20:06:16, Mikulas Patocka wrote: > [...] > > @@ -404,6 +405,12 @@ void *kvmalloc_node(size_t size, gfp_t f > > */ > > WARN_ON_ONCE((flags & GFP_KERNEL) != GFP_KERNEL); > > > > +#ifdef CONFIG_DEBUG_SG > > + /* Catch bugs

Re: [Cake] [PATCH net-next v2] Add Common Applications Kept Enhanced (cake) qdisc

On Tue, Apr 24, 2018 at 11:47 AM, Georgios Amanakis wrote: >> >> Does anyone know if there is a way to do this so the module/builtin >> split doesn't bite us? >> > #ifdef CONFIG_NF_CONNTRACK ??

Re: [PATCH net-next 2/2] net/ipv6: Fix missing rcu dereferences on from

On 04/23/2018 11:32 AM, David Ahern wrote: > kbuild test robot reported 2 uses of rt->from not properly accessed > using rcu_dereference: > 1. add rcu_dereference_protected to rt6_remove_exception_rt and make >sure it is always called with rcu lock held. > > 2. change rt6_do_redirect to

Re: [PATCH net-next 2/2] net/ipv6: Fix missing rcu dereferences on from

On 04/24/2018 08:54 AM, Eric Dumazet wrote: > > > On 04/23/2018 11:32 AM, David Ahern wrote: >> kbuild test robot reported 2 uses of rt->from not properly accessed >> using rcu_dereference: >> 1. add rcu_dereference_protected to rt6_remove_exception_rt and make >>sure it is always called

Re: [PATCH net-next] Revert "net: init sk_cookie for inet socket"

On Tue, Apr 24, 2018 at 11:49 PM, Eric Dumazet wrote: > > > On 04/24/2018 08:12 AM, Yafang Shao wrote: >> On Tue, Apr 24, 2018 at 8:38 PM, Eric Dumazet wrote: >>> >>> >>> On 04/24/2018 05:05 AM, Yafang Shao wrote: This revert commit ("net:

<    1   2   3   4