Re: linux-next: manual merge of the bpf-next tree with the bpf tree

2018-05-02 Thread Song Liu
> On May 1, 2018, at 10:50 PM, Stephen Rothwell wrote: > > Hi Song, > > On Wed, 2 May 2018 04:40:20 + Song Liu wrote: >> >>> - CHECK(build_id_matches < 1, "build id match", >>> - "Didn't find expected build ID from the map\n"); >>>

[PATCH net] ipv4: fix fnhe usage by non-cached routes

2018-05-02 Thread Julian Anastasov
Allow some non-cached routes to use non-expired fnhe: 1. ip_del_fnhe: moved above and now called by find_exception. The 4.5+ commit deed49df7390 expires fnhe only when caching routes. Change that to: 1.1. use fnhe for non-cached local output routes, with the help from (2) 1.2. allow

Re: [PATCH] vhost: make msg padding explicit

2018-05-02 Thread Kevin Easton
On Tue, May 01, 2018 at 02:05:51PM -0400, David Miller wrote: > From: "Michael S. Tsirkin" > Date: Tue, 1 May 2018 20:19:19 +0300 > > > On Tue, May 01, 2018 at 11:28:22AM -0400, David Miller wrote: > >> From: "Michael S. Tsirkin" > >> Date: Fri, 27 Apr 2018

[PATCH net-next v2 1/2] mlxsw: spectrum_router: Return an error for non-default FIB rules

2018-05-02 Thread Ido Schimmel
Since commit 9776d32537d2 ("net: Move call_fib_rule_notifiers up in fib_nl_newrule") it is possible to forbid the installation of unsupported FIB rules. Have mlxsw return an error for non-default FIB rules in addition to the existing extack message. Example: # ip rule add from 198.51.100.1 table

[PATCH net-next v2 0/2] mlxsw: Reject unsupported FIB configurations

2018-05-02 Thread Ido Schimmel
Recently it became possible for listeners of the FIB notification chain to veto operations such as addition of routes and rules. Adjust the mlxsw driver to take advantage of it and return an error for unsupported FIB rules and for routes configured after the abort mechanism was triggered (due to

[PATCH net-next v2 2/2] mlxsw: spectrum_router: Return an error for routes added after abort

2018-05-02 Thread Ido Schimmel
We currently do not perform accounting in the driver and thus can't reject routes before resources are exceeded. However, in order to make users aware of the fact that routes are no longer offloaded we can return an error for routes configured after the abort mechanism was triggered.

Re: [RFC v3 4/5] virtio_ring: add event idx support in packed ring

2018-05-02 Thread Tiwei Bie
On Wed, May 02, 2018 at 10:51:06AM +0800, Jason Wang wrote: > On 2018年04月25日 13:15, Tiwei Bie wrote: > > This commit introduces the event idx support in packed > > ring. This feature is temporarily disabled, because the > > implementation in this patch may not work as expected, > > and some

Re: [PATCH net-next v9 3/4] virtio_net: Extend virtio to use VF datapath when available

2018-05-02 Thread Jiri Pirko
Wed, May 02, 2018 at 02:20:26AM CEST, sridhar.samudr...@intel.com wrote: >On 4/30/2018 12:20 AM, Jiri Pirko wrote: >> >> > > Now I try to change mac of the failover master: >> > > [root@test1 ~]# ip link set ens3 addr 52:54:00:b2:a7:f3 >> > > RTNETLINK answers: Operation not supported >> > > >>

[PATCH net-next] cxgb4: add new T5 device id's

2018-05-02 Thread Ganesh Goudar
Add device id's 0x5019, 0x501a and 0x501b for T5 cards. Signed-off-by: Ganesh Goudar --- drivers/net/ethernet/chelsio/cxgb4/t4_pci_id_tbl.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/chelsio/cxgb4/t4_pci_id_tbl.h

Re: [PATCH RFC net-next] net: ipvs: Adjust gso_size for IPPROTO_TCP

2018-05-02 Thread Julian Anastasov
Hello, On Thu, 19 Apr 2018, Martin KaFai Lau wrote: > This patch is not a proper fix and mainly serves for discussion purpose. > It is based on net-next which I have been using to debug the issue. > > The change that works around the issue is in ensure_mtu_is_adequate(). > Other

Re: [PATCH net-next] udp: disable gso with no_check_tx

2018-05-02 Thread Michal Kubecek
On Mon, Apr 30, 2018 at 03:58:36PM -0400, Willem de Bruijn wrote: > From: Willem de Bruijn > > Syzbot managed to send a udp gso packet without checksum offload into > the gso stack by disabling tx checksum (UDP_NO_CHECK6_TX). This > triggered the skb_warn_bad_offload. > >

[PATCH] change the comment of ip6gre_tnl_addr_conflict

2018-05-02 Thread Sun Lianwen
The comment of ip6gre_tnl_addr_conflict() is wrong. which use ip6_tnl_addr_conflict instead of ip6gre_tnl_addr_conflict. Signed-off-by: Sun Lianwen --- net/ipv6/ip6_gre.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv6/ip6_gre.c

non-blocking connect for kernel SCTP sockets

2018-05-02 Thread Michal Kubecek
Hello, while investigating a bug, we noticed that DLM tries to connect an SCTP socket in non-blocking mode using result = sock->ops->connect(sock, (struct sockaddr *), addr_len, O_NONBLOCK); which does not work. The reason is that inet_dgram_connect()

Re: [PATCH net-next] modules: allow modprobe load regular elf binaries

2018-05-02 Thread Jesper Dangaard Brouer
On Tue, 6 Mar 2018 15:42:41 -0800 Chris Mason wrote: > On 6 Mar 2018, at 11:12, Linus Torvalds wrote: > [...] > > > > I do *not* want this to be a magical way to hide things. > > Especially early on, this makes a lot of sense. But I wanted to plug > bps and the hopefully

Re: non-blocking connect for kernel SCTP sockets

2018-05-02 Thread Xin Long
On Wed, May 2, 2018 at 5:06 PM, Michal Kubecek wrote: > Hello, > > while investigating a bug, we noticed that DLM tries to connect an SCTP > socket in non-blocking mode using > > result = sock->ops->connect(sock, (struct sockaddr *), addr_len, >

Re: [PATCH net-next v2 15/15] arm64: dts: allwinner: a64: add SRAM controller device tree node

2018-05-02 Thread Maxime Ripard
Hi, On Wed, May 02, 2018 at 12:12:27AM +0800, Chen-Yu Tsai wrote: > From: Icenowy Zheng > > Allwinner A64 has a SRAM controller, and in the device tree currently > we have a syscon node to enable EMAC driver to access the EMAC clock > register. As SRAM controller driver can now

[PATCH] NET/netlink: optimize output of seq_puts in af_netlink.c

2018-05-02 Thread Bo YU
Optimization of command output: `cat /proc/net/netlink` After the patch, we will get: https://clbin.com/lnu4L Signed-off-by: Bo YU --- net/netlink/af_netlink.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/netlink/af_netlink.c

RE: [PATCH v1 net-next] microchip_t1: Add driver for Microchip LAN87XX T1 PHYs

2018-05-02 Thread Nisar.Sayed
Hi Florian > > diff --git a/drivers/net/phy/microchip_t1.c > > b/drivers/net/phy/microchip_t1.c new file mode 100644 index > > 000..1f6f299 > > --- /dev/null > > +++ b/drivers/net/phy/microchip_t1.c > > @@ -0,0 +1,88 @@ > > +/* SPDX-License-Identifier: GPL-2.0 */ > > This is not the

Re: [PATCH net-next v2 15/15] arm64: dts: allwinner: a64: add SRAM controller device tree node

2018-05-02 Thread Icenowy Zheng
于 2018年5月2日 GMT+08:00 下午5:53:21, Chen-Yu Tsai 写到: >On Wed, May 2, 2018 at 5:51 PM, Maxime Ripard > wrote: >> Hi, >> >> On Wed, May 02, 2018 at 12:12:27AM +0800, Chen-Yu Tsai wrote: >>> From: Icenowy Zheng >>> >>> Allwinner A64 has a

[PATCH net-next] net: phy: broadcom: add support for BCM89610 PHY

2018-05-02 Thread Bhadram Varka
It adds support for BCM89610 (Single-Port 10/100/1000BASE-T) transceiver which is used in P3310 Tegra186 platform. Signed-off-by: Bhadram Varka --- drivers/net/phy/broadcom.c | 11 +++ include/linux/brcmphy.h| 1 + 2 files changed, 12 insertions(+) diff --git

Re: [PATCH 1/2] net: phy: broadcom: add support for BCM89610 PHY

2018-05-02 Thread Bhadram Varka
Hi, On 5/2/2018 3:48 PM, Bhadram Varka wrote: It adds support for BCM89610 (Single-Port 10/100/1000BASE-T) transceiver which is used in P3310 Tegra186 platform. Signed-off-by: Bhadram Varka --- drivers/net/phy/broadcom.c | 11 +++ include/linux/brcmphy.h|

Re: [v2 PATCH 1/1] tg3: fix meaningless hw_stats reading after tg3_halt memset 0 hw_stats

2018-05-02 Thread Zumeng Chen
On 2018年05月02日 13:12, Michael Chan wrote: On Tue, May 1, 2018 at 5:42 PM, Zumeng Chen wrote: diff --git a/drivers/net/ethernet/broadcom/tg3.h b/drivers/net/ethernet/broadcom/tg3.h index 3b5e98e..c61d83c 100644 --- a/drivers/net/ethernet/broadcom/tg3.h +++

[PATCH bpf-next v3 02/15] xsk: add user memory registration support sockopt

2018-05-02 Thread Björn Töpel
From: Björn Töpel In this commit the base structure of the AF_XDP address family is set up. Further, we introduce the abilty register a window of user memory to the kernel via the XDP_UMEM_REG setsockopt syscall. The memory window is viewed by an AF_XDP socket as a set of

[PATCH bpf-next v3 01/15] net: initial AF_XDP skeleton

2018-05-02 Thread Björn Töpel
From: Björn Töpel Buildable skeleton of AF_XDP without any functionality. Just what it takes to register a new address family. Signed-off-by: Björn Töpel --- MAINTAINERS | 8 include/linux/socket.h |

[PATCH bpf-next v3 03/15] xsk: add umem fill queue support and mmap

2018-05-02 Thread Björn Töpel
From: Magnus Karlsson Here, we add another setsockopt for registered user memory (umem) called XDP_UMEM_FILL_QUEUE. Using this socket option, the process can ask the kernel to allocate a queue (ring buffer) and also mmap it (XDP_UMEM_PGOFF_FILL_QUEUE) into the process.

[PATCH bpf-next v3 00/15] Introducing AF_XDP support

2018-05-02 Thread Björn Töpel
From: Björn Töpel This patch set introduces a new address family called AF_XDP that is optimized for high performance packet processing and, in upcoming patch sets, zero-copy semantics. In this patch set, we have removed all zero-copy related code in order to make it

[PATCH bpf-next v3 04/15] xsk: add Rx queue setup and mmap support

2018-05-02 Thread Björn Töpel
From: Björn Töpel Another setsockopt (XDP_RX_QUEUE) is added to let the process allocate a queue, where the kernel can pass completed Rx frames from the kernel to user process. The mmapping of the queue is done using the XDP_PGOFF_RX_QUEUE offset. Signed-off-by: Björn

[PATCH bpf-next v3 05/15] xsk: add support for bind for Rx

2018-05-02 Thread Björn Töpel
From: Magnus Karlsson Here, the bind syscall is added. Binding an AF_XDP socket, means associating the socket to an umem, a netdev and a queue index. This can be done in two ways. The first way, creating a "socket from scratch". Create the umem using the XDP_UMEM_REG

[PATCH bpf-next v3 13/15] xsk: support for Tx

2018-05-02 Thread Björn Töpel
From: Magnus Karlsson Here, Tx support is added. The user fills the Tx queue with frames to be sent by the kernel, and let's the kernel know using the sendmsg syscall. Signed-off-by: Magnus Karlsson --- net/xdp/xsk.c | 111

[PATCH bpf-next v3 15/15] samples/bpf: sample application and documentation for AF_XDP sockets

2018-05-02 Thread Björn Töpel
From: Magnus Karlsson This is a sample application for AF_XDP sockets. The application supports three different modes of operation: rxdrop, txonly and l2fwd. To show-case a simple round-robin load-balancing between a set of sockets in an xskmap, set the RR_LB compile

[PATCH bpf-next v3 09/15] xsk: wire up XDP_SKB side of AF_XDP

2018-05-02 Thread Björn Töpel
From: Björn Töpel This commit wires up the xskmap to XDP_SKB layer. Signed-off-by: Björn Töpel --- include/linux/filter.h | 2 +- net/core/dev.c | 35 +++ net/core/filter.c | 17 ++--- 3

[PATCH bpf-next v3 11/15] xsk: add Tx queue setup and mmap support

2018-05-02 Thread Björn Töpel
From: Magnus Karlsson Another setsockopt (XDP_TX_QUEUE) is added to let the process allocate a queue, where the user process can pass frames to be transmitted by the kernel. The mmapping of the queue is done using the XDP_PGOFF_TX_QUEUE offset. Signed-off-by: Magnus

[PATCH bpf-next v3 10/15] xsk: add umem completion queue support and mmap

2018-05-02 Thread Björn Töpel
From: Magnus Karlsson Here, we add another setsockopt for registered user memory (umem) called XDP_UMEM_COMPLETION_QUEUE. Using this socket option, the process can ask the kernel to allocate a queue (ring buffer) and also mmap it (XDP_UMEM_PGOFF_COMPLETION_QUEUE) into

[PATCH bpf-next v3 12/15] dev: packet: make packet_direct_xmit a common function

2018-05-02 Thread Björn Töpel
From: Magnus Karlsson The new dev_direct_xmit will be used by AF_XDP in later commits. Signed-off-by: Magnus Karlsson --- include/linux/netdevice.h | 1 + net/core/dev.c| 38 ++

[PATCH bpf-next v3 14/15] xsk: statistics support

2018-05-02 Thread Björn Töpel
From: Magnus Karlsson In this commit, a new getsockopt is added: XDP_STATISTICS. This is used to obtain stats from the sockets. v2: getsockopt now returns size of stats structure. Signed-off-by: Magnus Karlsson ---

[PATCH] 8139too: Use disable_irq_nosync() in rtl8139_poll_controller()

2018-05-02 Thread Sebastian Andrzej Siewior
From: Ingo Molnar Use disable_irq_nosync() instead of disable_irq() as this might be called in atomic context with netpoll. Signed-off-by: Ingo Molnar Signed-off-by: Thomas Gleixner Signed-off-by: Sebastian Andrzej Siewior

Re: [PATCH net] sctp: init active key for the new asoc in dupcook_a and dupcook_b

2018-05-02 Thread Neil Horman
On Wed, May 02, 2018 at 01:37:44PM +0800, Xin Long wrote: > When processing a duplicate cookie-echo chunk, for case 'A' and 'B', > after sctp_process_init for the new asoc, if auth is enabled for the > cookie-ack chunk, the active key should also be initialized. > > Otherwise, the cookie-ack

[PATCH bpf-next v3 07/15] bpf: introduce new bpf AF_XDP map type BPF_MAP_TYPE_XSKMAP

2018-05-02 Thread Björn Töpel
From: Björn Töpel The xskmap is yet another BPF map, very much inspired by dev/cpu/sockmap, and is a holder of AF_XDP sockets. A user application adds AF_XDP sockets into the map, and by using the bpf_redirect_map helper, an XDP program can redirect XDP frames to an AF_XDP

[PATCH bpf-next v3 06/15] xsk: add Rx receive functions and poll support

2018-05-02 Thread Björn Töpel
From: Björn Töpel Here the actual receive functions of AF_XDP are implemented, that in a later commit, will be called from the XDP layers. There's one set of functions for the XDP_DRV side and another for XDP_SKB (generic). A new XDP API, xdp_return_buff, is also

[PATCH bpf-next v3 08/15] xsk: wire up XDP_DRV side of AF_XDP

2018-05-02 Thread Björn Töpel
From: Björn Töpel This commit wires up the xskmap to XDP_DRV layer. Signed-off-by: Björn Töpel --- net/core/filter.c | 23 --- 1 file changed, 20 insertions(+), 3 deletions(-) diff --git a/net/core/filter.c b/net/core/filter.c

[PATCH v3 2/3] selftests/bpf: Makefile: add include path

2018-05-02 Thread Sirio Balmelli
On some systems selftests fail to build, missing the following headers: asm/byteorder.h asm/socket.h asm/swab.h In the specific case of Ubuntu, this is because the files are in '/usr/include/x86_64-linux-gnu' (see ) which is both architecture- and

[PATCH v3 1/3] selftests/bpf: add architecture-agnostic headers

2018-05-02 Thread Sirio Balmelli
bpf selftests fail to build with missing headers 'asm/bitsperlong.h' and 'asm/errno.h' These already exist in 'tools/arch/[arch]/include'; add architecture-agnostic header files in 'tools/include/uapi' to reference them. Signed-off-by: Sirio Balmelli ---

[PATCH v3 3/3] selftests/bpf: ignore build products

2018-05-02 Thread Sirio Balmelli
Update .gitignore files Signed-off-by: Sirio Balmelli --- tools/bpf/bpftool/.gitignore | 3 +++ tools/testing/selftests/bpf/.gitignore | 1 + 2 files changed, 4 insertions(+) create mode 100644 tools/bpf/bpftool/.gitignore diff --git a/tools/bpf/bpftool/.gitignore

[PATCH v3 0/3] selftests/bpf

2018-05-02 Thread Sirio Balmelli
Review of v2 patch appreciated. Trying a saner approach for includes handling, thank you dan...@iogearbox.net for steering me in the right direction. Please note I did run into some missing headers that were nowhere in '$(KERNEL)/tools' at all, but present in '$(KERNEL)/usr/include'. I'm

Re: [RFC v2 bpf-next 9/9] samples/bpf: Add examples of ipv4 and ipv6 forwarding in XDP

2018-05-02 Thread Jesper Dangaard Brouer
On Sun, 29 Apr 2018 11:07:52 -0700 David Ahern wrote: > + /* verify egress index has xdp support */ > + // TO-DO bpf_map_lookup_elem(_port, ) fails with > + // cannot pass map_type 14 into func bpf_map_lookup_elem#1: I just want to point out that I/we are

Re: [RFC v2 bpf-next 8/9] bpf: Provide helper to do lookups in kernel FIB table

2018-05-02 Thread Jesper Dangaard Brouer
On Sun, 29 Apr 2018 11:07:51 -0700 David Ahern wrote: > Initial performance numbers collected by Jesper, forwarded packets/sec: > >Full stackXDP FIB lookupXDP Direct lookup > IPv4 1,947,969 7,074,156 7,415,333 > IPv6 1,728,000

Re: [PATCH net] sctp: use the old asoc when making the cookie-ack chunk in dupcook_d

2018-05-02 Thread Neil Horman
On Wed, May 02, 2018 at 01:39:46PM +0800, Xin Long wrote: > When processing a duplicate cookie-echo chunk, for case 'D', sctp will > not process the param from this chunk. It means old asoc has nothing > to be updated, and the new temp asoc doesn't have the complete info. > > So there's no reason

Re: [PATCH net] sctp: fix the issue that the cookie-ack with auth can't get processed

2018-05-02 Thread Neil Horman
On Wed, May 02, 2018 at 01:45:12PM +0800, Xin Long wrote: > When auth is enabled for cookie-ack chunk, in sctp_inq_pop, sctp > processes auth chunk first, then continues to the next chunk in > this packet if chunk_end + chunk_hdr size < skb_tail_pointer(). > Otherwise, it will go to the next

RE: [PATCH 2/8] dt-bindings: stm32-dwmac: add support of MPU families

2018-05-02 Thread Christophe ROULLIER
Hi, My answers below under "CRO" Thanks. Christophe -Original Message- From: Rob Herring [mailto:r...@kernel.org] Sent: mardi 1 mai 2018 15:59 To: Christophe ROULLIER Cc: mark.rutl...@arm.com; mcoquelin.st...@gmail.com; Alexandre TORGUE

Re: [PATCH] net: stmmac: Avoid VLA usage

2018-05-02 Thread Jose Abreu
Hi Kees, On 01-05-2018 22:01, Kees Cook wrote: > In the quest to remove all stack VLAs from the kernel[1], this switches > the "status" stack buffer to use the existing small (8) upper bound on > how many queues can be checked for DMA, and adds a sanity-check just to > make sure it doesn't

Re: [PATCH] net/xfrm: Fix lookups for states with spi == 0

2018-05-02 Thread Herbert Xu
On Wed, May 02, 2018 at 03:02:20AM +0100, Dmitry Safonov wrote: > It seems to be a valid use case to add xfrm state without > Security Parameter Indexes (SPI) value associated: > ip xfrm state add src $src dst $dst proto $proto mode $mode sel src $src dst > $dst $algo > > The bad thing is that

Re: [PATCH bpf-next 1/2] bpf: enable stackmap with build_id in nmi context

2018-05-02 Thread Peter Zijlstra
On Tue, May 01, 2018 at 05:02:19PM -0700, Song Liu wrote: > @@ -267,17 +285,27 @@ static void stack_map_get_build_id_offset(struct > bpf_stack_build_id *id_offs, > { > int i; > struct vm_area_struct *vma; > + bool in_nmi_ctx = in_nmi(); > + bool irq_work_busy = false; > +

Re: [PATCH net-next] udp: Complement partial checksum for GSO packet

2018-05-02 Thread Willem de Bruijn
On Tue, May 1, 2018 at 12:06 PM, Willem de Bruijn wrote: > On Tue, May 1, 2018 at 2:01 AM, Sean Tranchetti > wrote: >> Using the udp_v4_check() function to calculate the pseudo header >> for the newly segmented UDP packets results in

[PATCH v2 net-next] microchip_t1: Add driver for Microchip LAN87XX T1 PHYs

2018-05-02 Thread Nisar Sayed
Add driver for Microchip LAN87XX T1 PHYs This patch support driver for Microchp T1 PHYs. There will be followup patches to this driver to support T1 PHY features such as cable diagnostics, signal quality indicator(SQI), sleep and wakeup (TC10) support. Signed-off-by: Nisar Sayed

Re: [RFC V3 PATCH 1/8] vhost: move get_rx_bufs to vhost.c

2018-05-02 Thread Tiwei Bie
On Mon, Apr 23, 2018 at 01:34:53PM +0800, Jason Wang wrote: > Move get_rx_bufs() to vhost.c and rename it to > vhost_get_rx_bufs(). This helps to hide vring internal layout from A small typo. Based on the code change in this patch, it seems that this function is renamed to vhost_get_bufs().

Re: [PATCH V2 net-next 6/6] ipvlan: Add support for SCTP checksum offload

2018-05-02 Thread Davide Caratti
On Tue, 2018-05-01 at 22:07 -0400, Vladislav Yasevich wrote: > Since ipvlan is a software device, we can turn on SCTP checksum > offload and let the checksum be computed at the lower layer. > > Signed-off-by: Vladislav Yasevich > --- > drivers/net/ipvlan/ipvlan_main.c | 3

Re: [PATCH bpf-next] bpf/verifier: enable ctx + const + 0.

2018-05-02 Thread Daniel Borkmann
On 05/02/2018 06:52 AM, Alexei Starovoitov wrote: > On Tue, May 01, 2018 at 09:35:29PM -0700, William Tu wrote: >> >>> How did you test this patch? >>> >> Without the patch, the test case will fail. >> With the patch, the test case passes. > > Please test it with real program and you'll see

[PATCH net-next v8 1/3] vmcore: add API to collect hardware dump in second kernel

2018-05-02 Thread Rahul Lakkireddy
The sequence of actions done by device drivers to append their device specific hardware/firmware logs to /proc/vmcore are as follows: 1. During probe (before hardware is initialized), device drivers register to the vmcore module (via vmcore_add_device_dump()), with callback function, along with

[PATCH net-next v8 0/3] kernel: add support to collect hardware logs in crash recovery kernel

2018-05-02 Thread Rahul Lakkireddy
On production servers running variety of workloads over time, kernel panic can happen sporadically after days or even months. It is important to collect as much debug logs as possible to root cause and fix the problem, that may not be easy to reproduce. Snapshot of underlying hardware/firmware

Re: [PATCH net-next v2 15/15] arm64: dts: allwinner: a64: add SRAM controller device tree node

2018-05-02 Thread Chen-Yu Tsai
On Wed, May 2, 2018 at 5:51 PM, Maxime Ripard wrote: > Hi, > > On Wed, May 02, 2018 at 12:12:27AM +0800, Chen-Yu Tsai wrote: >> From: Icenowy Zheng >> >> Allwinner A64 has a SRAM controller, and in the device tree currently >> we have a syscon node to

Re: [PATCH net-next] udp: disable gso with no_check_tx

2018-05-02 Thread Willem de Bruijn
On Wed, May 2, 2018 at 9:05 AM, Michal Kubecek wrote: > On Mon, Apr 30, 2018 at 03:58:36PM -0400, Willem de Bruijn wrote: >> From: Willem de Bruijn >> >> Syzbot managed to send a udp gso packet without checksum offload into >> the gso stack by disabling tx

[PATCH net-next v8 3/3] cxgb4: collect hardware dump in second kernel

2018-05-02 Thread Rahul Lakkireddy
Register callback to collect hardware/firmware dumps in second kernel before hardware/firmware is initialized. The dumps for each device will be available as elf notes in /proc/vmcore in second kernel. Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar

[PATCH net-next v8 2/3] vmcore: append device dumps to vmcore as elf notes

2018-05-02 Thread Rahul Lakkireddy
Update read and mmap logic to append device dumps as additional notes before the other elf notes. We add device dumps before other elf notes because the other elf notes may not fill the elf notes buffer completely and we will end up with zero-filled data between the elf notes and the device dumps.

[PATCH 1/2] net: phy: broadcom: add support for BCM89610 PHY

2018-05-02 Thread Bhadram Varka
It adds support for BCM89610 (Single-Port 10/100/1000BASE-T) transceiver which is used in P3310 Tegra186 platform. Signed-off-by: Bhadram Varka --- drivers/net/phy/broadcom.c | 11 +++ include/linux/brcmphy.h| 1 + 2 files changed, 12 insertions(+) diff --git

Re: [PATCH net] sctp: init active key for the new asoc in dupcook_a and dupcook_b

2018-05-02 Thread Marcelo Ricardo Leitner
On Wed, May 02, 2018 at 01:37:44PM +0800, Xin Long wrote: > When processing a duplicate cookie-echo chunk, for case 'A' and 'B', > after sctp_process_init for the new asoc, if auth is enabled for the > cookie-ack chunk, the active key should also be initialized. > > Otherwise, the cookie-ack chunk

Re: [PATCH net] sctp: use the old asoc when making the cookie-ack chunk in dupcook_d

2018-05-02 Thread Marcelo Ricardo Leitner
On Wed, May 02, 2018 at 01:39:46PM +0800, Xin Long wrote: > When processing a duplicate cookie-echo chunk, for case 'D', sctp will > not process the param from this chunk. It means old asoc has nothing > to be updated, and the new temp asoc doesn't have the complete info. > > So there's no reason

Re: [PATCH] net/xfrm: Fix lookups for states with spi == 0

2018-05-02 Thread Dmitry Safonov
On Wed, 2018-05-02 at 17:11 +0800, Herbert Xu wrote: > On Wed, May 02, 2018 at 03:02:20AM +0100, Dmitry Safonov wrote: > > It seems to be a valid use case to add xfrm state without > > Security Parameter Indexes (SPI) value associated: > > ip xfrm state add src $src dst $dst proto $proto mode

Re: [PATCH net-next v2 15/15] arm64: dts: allwinner: a64: add SRAM controller device tree node

2018-05-02 Thread Maxime Ripard
On Wed, May 02, 2018 at 06:19:51PM +0800, Icenowy Zheng wrote: > > > 于 2018年5月2日 GMT+08:00 下午5:53:21, Chen-Yu Tsai 写到: > >On Wed, May 2, 2018 at 5:51 PM, Maxime Ripard > > wrote: > >> Hi, > >> > >> On Wed, May 02, 2018 at 12:12:27AM +0800, Chen-Yu Tsai

Re: [PATCH net] sctp: fix the issue that the cookie-ack with auth can't get processed

2018-05-02 Thread Marcelo Ricardo Leitner
On Wed, May 02, 2018 at 01:45:12PM +0800, Xin Long wrote: > When auth is enabled for cookie-ack chunk, in sctp_inq_pop, sctp > processes auth chunk first, then continues to the next chunk in > this packet if chunk_end + chunk_hdr size < skb_tail_pointer(). > Otherwise, it will go to the next

Re: non-blocking connect for kernel SCTP sockets

2018-05-02 Thread Michal Kubecek
On Wed, May 02, 2018 at 05:46:23PM +0800, Xin Long wrote: > On Wed, May 2, 2018 at 5:06 PM, Michal Kubecek wrote: > > Hello, > > > > while investigating a bug, we noticed that DLM tries to connect an SCTP > > socket in non-blocking mode using > > > > result =

Re: [PATCH] net: stmmac: Avoid VLA usage

2018-05-02 Thread Kees Cook
On Wed, May 2, 2018 at 1:54 AM, Jose Abreu wrote: > Hi Kees, > > On 01-05-2018 22:01, Kees Cook wrote: >> In the quest to remove all stack VLAs from the kernel[1], this switches >> the "status" stack buffer to use the existing small (8) upper bound on >> how many queues

[PATCH bpf-next v2] bpf: relax constraints on formatting for eBPF helper documentation

2018-05-02 Thread Quentin Monnet
The Python script used to parse and extract eBPF helpers documentation from include/uapi/linux/bpf.h expects a very specific formatting for the descriptions (single dot represents a space, '>' stands for a tab): /* ... *.int bpf_helper(list of arguments) *.>Description

Re: [PATCH V2 net-next 5/6] macvlan/macvtap: Add support for SCTP checksum offload.

2018-05-02 Thread Vlad Yasevich
On 05/01/2018 11:24 PM, Michael S. Tsirkin wrote: > On Tue, May 01, 2018 at 10:07:38PM -0400, Vladislav Yasevich wrote: >> Since we now have support for software CRC32c offload, turn it on >> for macvlan and macvtap devices so that guests can take advantage >> of offload SCTP checksums to the host

Re: [PATCH net-next] net: phy: broadcom: add support for BCM89610 PHY

2018-05-02 Thread Andrew Lunn
On Wed, May 02, 2018 at 03:54:36PM +0530, Bhadram Varka wrote: > It adds support for BCM89610 (Single-Port 10/100/1000BASE-T) > transceiver which is used in P3310 Tegra186 platform. > > Signed-off-by: Bhadram Varka > --- > drivers/net/phy/broadcom.c | 11 +++ >

Re: [PATCH] net/mlx4_core: Fix error handling in mlx4_init_port_info.

2018-05-02 Thread Tariq Toukan
On 27/04/2018 6:20 PM, Tarick Bedeir wrote: Avoid exiting the function with a lingering sysfs file (if the first call to device_create_file() fails while the second succeeds), and avoid calling devlink_port_unregister() twice. In other words, either mlx4_init_port_info() succeeds and returns

Re: kvmalloc: always use vmalloc if CONFIG_DEBUG_VM

2018-05-02 Thread Mike Snitzer
On Tue, May 01 2018 at 8:36pm -0400, Andrew Morton wrote: > On Tue, 24 Apr 2018 12:33:01 -0400 (EDT) Mikulas Patocka > wrote: > > > > > > > On Tue, 24 Apr 2018, Michal Hocko wrote: > > > > > On Tue 24-04-18 11:30:40, Mikulas Patocka wrote: >

Re: [PATCH] vhost: make msg padding explicit

2018-05-02 Thread Michael S. Tsirkin
On Wed, May 02, 2018 at 02:28:09AM -0400, Kevin Easton wrote: > On Tue, May 01, 2018 at 02:05:51PM -0400, David Miller wrote: > > From: "Michael S. Tsirkin" > > Date: Tue, 1 May 2018 20:19:19 +0300 > > > > > On Tue, May 01, 2018 at 11:28:22AM -0400, David Miller wrote: > > >>

Re: non-blocking connect for kernel SCTP sockets

2018-05-02 Thread Marcelo Ricardo Leitner
On Wed, May 02, 2018 at 02:32:28PM +0200, Michal Kubecek wrote: > On Wed, May 02, 2018 at 05:46:23PM +0800, Xin Long wrote: ... > > It is a bug, https://bugzilla.redhat.com/show_bug.cgi?id=1251530 > > Not authorized. :-) Oups! I just made it public. Marcelo

Re: Page allocator bottleneck

2018-05-02 Thread Tariq Toukan
On 27/04/2018 11:45 AM, Aaron Lu wrote: On Mon, Apr 23, 2018 at 09:10:33PM +0800, Aaron Lu wrote: On Mon, Apr 23, 2018 at 11:54:57AM +0300, Tariq Toukan wrote: Hi, I ran my tests with your patches. Initial BW numbers are significantly higher than I documented back then in this mail-thread.

Re: [PATCH RFC iproute2-next 2/2] rdma: print provider resource attributes

2018-05-02 Thread Leon Romanovsky
On Mon, Apr 30, 2018 at 08:25:24AM -0700, Stephen Hemminger wrote: > On Mon, 30 Apr 2018 07:36:18 -0700 > Steve Wise wrote: > > > +#define nla_type(attr) ((attr)->nla_type & NLA_TYPE_MASK) > > + > > +void newline(struct rd *rd) > > +{ > > + if (rd->json_output) > >

Re: [dm-devel] [PATCH v5] fault-injection: introduce kvmalloc fallback options

2018-05-02 Thread John Stoffel
> "Mikulas" == Mikulas Patocka writes: Mikulas> On Mon, 30 Apr 2018, John Stoffel wrote: >> > "Mikulas" == Mikulas Patocka writes: >> Mikulas> On Thu, 26 Apr 2018, John Stoffel wrote: >> Mikulas> I see your point - and I think the

Re: [dm-devel] kvmalloc: always use vmalloc if CONFIG_DEBUG_VM

2018-05-02 Thread John Stoffel
> "Mike" == Mike Snitzer writes: Mike> On Tue, May 01 2018 at 8:36pm -0400, Mike> Andrew Morton wrote: >> On Tue, 24 Apr 2018 12:33:01 -0400 (EDT) Mikulas Patocka >> wrote: >> >> > >> > >> > On Tue, 24 Apr 2018,

Re: [PATCH V2 net-next 5/6] macvlan/macvtap: Add support for SCTP checksum offload.

2018-05-02 Thread Michael S. Tsirkin
On Wed, May 02, 2018 at 09:27:00AM -0400, Vlad Yasevich wrote: > On 05/01/2018 11:24 PM, Michael S. Tsirkin wrote: > > On Tue, May 01, 2018 at 10:07:38PM -0400, Vladislav Yasevich wrote: > >> Since we now have support for software CRC32c offload, turn it on > >> for macvlan and macvtap devices so

Re: [PATCH v2] net/mlx4_en: fix potential use-after-free with dma_unmap_page

2018-05-02 Thread Tariq Toukan
On 28/04/2018 2:48 AM, David Miller wrote: From: Sarah Newman Date: Wed, 25 Apr 2018 21:00:34 -0700 When swiotlb is in use, calling dma_unmap_page means that the original page mapped with dma_map_page must still be valid as swiotlb will copy data from its internal cache back

Re: [RFC v3 4/5] virtio_ring: add event idx support in packed ring

2018-05-02 Thread Michael S. Tsirkin
On Wed, May 02, 2018 at 03:28:19PM +0800, Tiwei Bie wrote: > On Wed, May 02, 2018 at 10:51:06AM +0800, Jason Wang wrote: > > On 2018年04月25日 13:15, Tiwei Bie wrote: > > > This commit introduces the event idx support in packed > > > ring. This feature is temporarily disabled, because the > > >

Re: [PATCH V2 net-next 1/6] virtio: Add support for SCTP checksum offloading

2018-05-02 Thread Michael S. Tsirkin
On Wed, May 02, 2018 at 11:14:13AM -0300, Marcelo Ricardo Leitner wrote: > On Wed, May 02, 2018 at 06:16:45AM +0300, Michael S. Tsirkin wrote: > > On Tue, May 01, 2018 at 10:07:34PM -0400, Vladislav Yasevich wrote: > > > To support SCTP checksum offloading, we need to add a new feature > > > to

[PATCH V2 1/8] net: ethernet: stmmac: add adaptation for stm32mp157c.

2018-05-02 Thread Christophe Roullier
Glue codes to support stm32mp157c device and stay compatible with stm32 mcu family Signed-off-by: Christophe Roullier --- drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c | 270 -- 1 file changed, 255 insertions(+), 15 deletions(-) diff --git

[PATCH V2 3/8] ARM: dts: stm32: add ethernet pins to stm32mp157c

2018-05-02 Thread Christophe Roullier
Add ethernet pins on stm32mp157c. Signed-off-by: Christophe Roullier --- arch/arm/boot/dts/stm32mp157-pinctrl.dtsi | 46 +++ 1 file changed, 46 insertions(+) diff --git a/arch/arm/boot/dts/stm32mp157-pinctrl.dtsi

[PATCH V2 8/8] dt-bindings: stm32: add compatible for syscon

2018-05-02 Thread Christophe Roullier
This patch describes syscon DT bindings. Signed-off-by: Christophe Roullier --- Documentation/devicetree/bindings/arm/stm32.txt | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/arm/stm32.txt

Re: [PATCH V2 6/8] net: stmmac: add dwmac-4.20a compatible

2018-05-02 Thread Jose Abreu
Hi Christophe, On 02-05-2018 15:18, Christophe Roullier wrote: > Manage dwmac-4.20a version from synopsys > > Just being curious: Can you tell me which HW features do you have on your NIC? Thanks and Best Regards, Jose Miguel Abreu

Re: [PATCH] net: ethernet: ti: cpsw: fix packet leaking in dual_mac mode

2018-05-02 Thread David Miller
From: Grygorii Strashko Date: Tue, 1 May 2018 12:41:22 -0500 > In dual_mac mode packets arrived on one port should not be forwarded by > switch hw to another port. Only Linux Host can forward packets between > ports. The below test case (reported in [1]) shows that

Re: [PATCH RFC iproute2-next 1/2] rdma: update rdma_netlink.h to get provider attrs

2018-05-02 Thread David Ahern
On 4/30/18 8:36 AM, Steve Wise wrote: > Signed-off-by: Steve Wise > --- > rdma/include/uapi/rdma/rdma_netlink.h | 37 > ++- > 1 file changed, 36 insertions(+), 1 deletion(-) > > diff --git a/rdma/include/uapi/rdma/rdma_netlink.h >

Re: [PATCH net] sctp: use the old asoc when making the cookie-ack chunk in dupcook_d

2018-05-02 Thread David Miller
From: Xin Long Date: Wed, 2 May 2018 13:39:46 +0800 > When processing a duplicate cookie-echo chunk, for case 'D', sctp will > not process the param from this chunk. It means old asoc has nothing > to be updated, and the new temp asoc doesn't have the complete info. > >

Re: [PATCH net] sctp: init active key for the new asoc in dupcook_a and dupcook_b

2018-05-02 Thread David Miller
From: Xin Long Date: Wed, 2 May 2018 13:37:44 +0800 > When processing a duplicate cookie-echo chunk, for case 'A' and 'B', > after sctp_process_init for the new asoc, if auth is enabled for the > cookie-ack chunk, the active key should also be initialized. > > Otherwise,

Re: [PATCH net] sctp: fix the issue that the cookie-ack with auth can't get processed

2018-05-02 Thread David Miller
From: Xin Long Date: Wed, 2 May 2018 13:45:12 +0800 > When auth is enabled for cookie-ack chunk, in sctp_inq_pop, sctp > processes auth chunk first, then continues to the next chunk in > this packet if chunk_end + chunk_hdr size < skb_tail_pointer(). > Otherwise, it will

RE: [PATCH V2 6/8] net: stmmac: add dwmac-4.20a compatible

2018-05-02 Thread Christophe ROULLIER
Hi Jose, >Just being curious: Can you tell me which HW features do you have on your NIC? Nothing specific to SNPS 4.20a, it is just to be align with our SNPS IP in our NIC ;-) BR Christophe. -Original Message- From: Jose Abreu [mailto:jose.ab...@synopsys.com] Sent: mercredi 2 mai

Re: [PATCH] net: stmmac: Avoid VLA usage

2018-05-02 Thread Jose Abreu
On 02-05-2018 13:36, Kees Cook wrote: > On Wed, May 2, 2018 at 1:54 AM, Jose Abreu wrote: >> Hi Kees, >> >> On 01-05-2018 22:01, Kees Cook wrote: >>> In the quest to remove all stack VLAs from the kernel[1], this switches >>> the "status" stack buffer to use the

[PATCH V2 0/8] net: ethernet: stmmac: add support for stm32mp1

2018-05-02 Thread Christophe Roullier
Patches to have Ethernet support on stm32mp1 Changelog: Remark from Andrew Lunn In drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c Add support of PHY_INTERFACE_MODE_RGMII_ID, PHY_INTERFACE_MODE_RGMII_RXID, PHY_INTERFACE_MODE_RGMII_TXID. Remark from Rob Herring In

[PATCH V2 2/8] dt-bindings: stm32-dwmac: add support of MPU families

2018-05-02 Thread Christophe Roullier
Add description for Ethernet MPU families fields Signed-off-by: Christophe Roullier --- Documentation/devicetree/bindings/net/stm32-dwmac.txt | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git

[PATCH V2 7/8] ARM: dts: stm32: add support of ethernet on stm32mp157c-ev1

2018-05-02 Thread Christophe Roullier
MAC is connected to a PHY in RGMII mode. Signed-off-by: Christophe Roullier --- arch/arm/boot/dts/stm32mp157c-ev1.dts | 20 1 file changed, 20 insertions(+) diff --git a/arch/arm/boot/dts/stm32mp157c-ev1.dts

  1   2   3   4   >