[PATCH net-next v3 8/8] sctp: rework switch cases in sctp_outq_flush_data

Remove an inner one, which tended to be error prone due to the cascading and it can be replaced by a simple if (). Rework the outer one so that the actual flush code is not inside it. Now we first validate if we can or cannot send data, return if not, and then the flush code. Suggested-by: Xin

[PATCH net-next v3 1/8] sctp: add sctp_packet_singleton

Factor out the code for generating singletons. It's used only once, but helps to keep the context contained. The const variables are to ease the reading of subsequent calls in there. Signed-off-by: Marcelo Ricardo Leitner --- net/sctp/outqueue.c | 22

[PATCH net-next v3 3/3] sctp: checkpatch fixups

A collection of fixups from previous patches, left for later to not introduce unnecessary changes while moving code around. Signed-off-by: Marcelo Ricardo Leitner --- net/sctp/outqueue.c | 20 +++- 1 file changed, 7 insertions(+), 13 deletions(-) diff

[PATCH net-next v3 7/8] sctp: make use of gfp on retransmissions

Retransmissions may be triggered when in user context, so lets make use of gfp. Signed-off-by: Marcelo Ricardo Leitner --- net/sctp/outqueue.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/net/sctp/outqueue.c

[PATCH net-next v3 2/3] sctp: add asoc and packet to sctp_flush_ctx

Pre-compute these so the compiler won't reload them (due to no-strict-aliasing). Changes since v2: - Do not replace a return with a break in sctp_outq_flush_data Signed-off-by: Marcelo Ricardo Leitner --- net/sctp/outqueue.c | 97

[PATCH net-next v3 5/8] sctp: move flushing of data chunks out of sctp_outq_flush

To the new sctp_outq_flush_data. Again, smaller functions and with well defined objectives. Signed-off-by: Marcelo Ricardo Leitner --- net/sctp/outqueue.c | 149 ++-- 1 file changed, 75 insertions(+), 74 deletions(-)

[PATCH net-next v3 1/3] sctp: add sctp_flush_ctx, a context struct on outq_flush routines

With this struct we avoid passing lots of variables around and taking care of updating the current transport/packet. Signed-off-by: Marcelo Ricardo Leitner --- net/sctp/outqueue.c | 182 +--- 1 file changed, 88

[PATCH net-next v3 6/8] sctp: move transport flush code out of sctp_outq_flush

To the new sctp_outq_flush_transports. Comment on Nagle is outdated and removed. Nagle is performed earlier, while checking if the chunk fits the packet: if the outq length is not enough to fill the packet, it returns SCTP_XMIT_DELAY. So by when it gets to sctp_outq_flush_transports, it has to

Re: Kernel panic on kernel-3.10.0-693.21.1.el7 in ndisc.h

Hi Alexander, Thank you for the answer. Unfortunately CentOS goes with these dinosaurs. So we will try to debug the problem in the current one and try to reproduce on the latest kernel. Thanks, Roman. 2018-05-14 18:40 GMT+03:00 Alexander Aring : > Hi, > > On Sun, May 13,

Re: [net-next 00/11][pull request] 40GbE Intel Wired LAN Driver Updates 2018-05-14

From: Jeff Kirsher Date: Mon, 14 May 2018 08:27:36 -0700 > This series contains updates to virtchnl, i40e and i40evf. > > Bruce cleans up whitespace and unnecessary parentheses in virtchnl. > > Jake does a number of stat cleanups in the i40e driver, including >

Re: [PATCH] net/mlx5: Use 'kvfree()' for memory allocated by 'kvzalloc()'

From: Christophe JAILLET Date: Sat, 12 May 2018 19:09:25 +0200 > 'out' is allocated with 'kvzalloc()'. 'kvfree()' must be used to free it. > > Signed-off-by: Christophe JAILLET Saeed, I assume I will see this in one of your

Re: possible deadlock in sk_diag_fill

On Sat, May 12, 2018 at 09:46:25AM +0200, Dmitry Vyukov wrote: > On Fri, May 11, 2018 at 8:33 PM, Andrei Vagin wrote: > > On Sat, May 05, 2018 at 10:59:02AM -0700, syzbot wrote: > >> Hello, > >> > >> syzbot found the following crash on: > >> > >> HEAD commit:c1c07416cdd4

Re: [bpf-next PATCH 5/5] bpf, doc: howto use/run the BPF selftests

On Mon, May 14, 2018 at 06:05:14PM +0200, Jesper Dangaard Brouer wrote: > On Mon, 14 May 2018 17:15:54 +0200 > Silvan Jegen wrote: > > > Hi > > > > Some typo fixes below. > > > > On Mon, May 14, 2018 at 3:43 PM Jesper Dangaard Brouer > > wrote: > > > I

Re: [PATCH v3 0/1] multi-threading device shutdown

On 05/14/2018 11:03 AM, Greg KH wrote: > On Mon, May 07, 2018 at 11:54:01AM -0400, Pavel Tatashin wrote: >> Changelog >> v2 - v3 >> - Fixed warning from kbuild test. >> - Moved device_lock/device_unlock inside device_shutdown_tree(). >> >> v1 - v2 >> - It turns out we cannot lock

Re: [net-next PATCH 1/3] net: Refactor XPS for CPUs and Rx queues

On 5/14/2018 9:53 AM, Tom Herbert wrote: > On Wed, May 9, 2018 at 1:54 PM, Nambiar, Amritha > wrote: >> On 5/9/2018 1:31 PM, Tom Herbert wrote: >>> On Thu, Apr 19, 2018 at 6:04 PM, Amritha Nambiar >>> wrote: Refactor XPS code to support

[PATCH net-next v3 3/8] sctp: move the flush of ctrl chunks into its own function

Named sctp_outq_flush_ctrl and, with that, keep the contexts contained. One small fix embedded is the reset of one_packet at every iteration. This allows bundling of some control chunks in case they were preceeded by another control chunk that cannot be bundled. Other than this, it has the same

[PATCH net-next v3 0/8] sctp: refactor sctp_outq_flush

Currently sctp_outq_flush does many different things and arguably unrelated, such as doing transport selection and outq dequeueing. This patchset refactors it into smaller and more dedicated functions. The end behavior should be the same. The next patchset will rework the function parameters.

[PATCH net-next v3 0/3] sctp: Introduce sctp_flush_ctx

This struct will hold all the context used during the outq flush, so we don't have to pass lots of pointers all around. Checked on x86_64, the compiler inlines all these functions and there is no derreference added because of the struct. This patchset depends on 'sctp: refactor sctp_outq_flush'

Re: [PATCH 05/14] net: sched: always take reference to action

On Mon 14 May 2018 at 16:23, Jiri Pirko wrote: > Mon, May 14, 2018 at 04:27:06PM CEST, vla...@mellanox.com wrote: >>Without rtnl lock protection it is no longer safe to use pointer to tc >>action without holding reference to it. (it can be destroyed concurrently) >> >>Remove

[PATCH net-next v2 1/4] bonding: don't queue up extraneous rlb updates

arps for incomplete entries can't be sent anyway. Signed-off-by: Debabrata Banerjee --- drivers/net/bonding/bond_alb.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/net/bonding/bond_alb.c b/drivers/net/bonding/bond_alb.c

Re: iproute2 - modifying routes in place

On 5/14/18 12:40 PM, Ryan Whelan wrote: > Same behavior: > > > root@rwhelan-linux ~ > # ip -6 route > ::1 dev lo proto kernel metric 256 pref medium > fd9b:caee:ff93:ceef:3431:3831:3930:3031 dev internal0 proto kernel metric > 256 pref medium > fd9b:caee:ff93:ceef:3431:3831:3930:3032 dev

Re: [PATCH net V2] tun: fix use after free for ptr_ring

From: Jason Wang Date: Fri, 11 May 2018 10:49:25 +0800 > We used to initialize ptr_ring during TUNSETIFF, this is because its > size depends on the tx_queue_len of netdevice. And we try to clean it > up when socket were detached from netdevice. A race were spotted when >

[PATCH net-next v10 3/7] sch_cake: Add optional ACK filter

The ACK filter is an optional feature of CAKE which is designed to improve performance on links with very asymmetrical rate limits. On such links (which are unfortunately quite prevalent, especially for DSL and cable subscribers), the downstream throughput can be limited by the number of ACKs

[PATCH net-next v10 0/7] sched: Add Common Applications Kept Enhanced (cake) qdisc

This patch series adds the CAKE qdisc, and has been split up to ease review. I have attempted to split out each configurable feature into its own patch. The first commit adds the base shaper and packet scheduler, while subsequent commits add the optional features. The full userspace API and most

Re: [PATCH bpf-next 3/6] bpf, x64: clean up retpoline emission slightly

On Sun, May 13, 2018 at 5:26 PM, Daniel Borkmann wrote: > Make the RETPOLINE_{RA,ED}X_BPF_JIT() a bit more readable by > cleaning up the macro, aligning comments and spacing. > > Signed-off-by: Daniel Borkmann > --- >

Re: [PATCH v3] selftests: add headers_install to lib.mk

On Mon, May 14, 2018 at 01:58:09PM +0200, Anders Roxell wrote: > If the kernel headers aren't installed we can't build all the tests. > Add a new make target rule 'khdr' in the file lib.mk to generate the > kernel headers and that gets include for every test-dir Makefile that > includes lib.mk If

Re: [PATCH net-next 0/3] net: dsa: mv88e6xxx: remove Global 1 setup

From: Vivien Didelot Date: Fri, 11 May 2018 17:16:33 -0400 > The mv88e6xxx driver is still writing arbitrary registers at setup time, > e.g. priority override bits. Add ops for them and provide specific setup > functions for priority and stats before getting

[PATCH net-next v10 2/7] sch_cake: Add ingress mode

The ingress mode is meant to be enabled when CAKE runs downlink of the actual bottleneck (such as on an IFB device). The mode changes the shaper to also account dropped packets to the shaped rate, as these have already traversed the bottleneck. Enabling ingress mode will also tune the AQM to

[PATCH net-next v10 1/7] sched: Add Common Applications Kept Enhanced (cake) qdisc

sch_cake targets the home router use case and is intended to squeeze the most bandwidth and latency out of even the slowest ISP links and routers, while presenting an API simple enough that even an ISP can configure it. Example of use on a cable ISP uplink: tc qdisc add dev eth0 cake bandwidth

[PATCH net-next v10 5/7] sch_cake: Add DiffServ handling

This adds support for DiffServ-based priority queueing to CAKE. If the shaper is in use, each priority tier gets its own virtual clock, which limits that tier's rate to a fraction of the overall shaped rate, to discourage trying to game the priority mechanism. CAKE defaults to a simple,

[PATCH net-next v10 6/7] sch_cake: Add overhead compensation support to the rate shaper

This commit adds configurable overhead compensation support to the rate shaper. With this feature, userspace can configure the actual bottleneck link overhead and encapsulation mode used, which will be used by the shaper to calculate the precise duration of each packet on the wire. This feature

[PATCH net-next v10 4/7] sch_cake: Add NAT awareness to packet classifier

When CAKE is deployed on a gateway that also performs NAT (which is a common deployment mode), the host fairness mechanism cannot distinguish internal hosts from each other, and so fails to work correctly. To fix this, we add an optional NAT awareness mode, which will query the kernel conntrack

[PATCH net-next v10 7/7] sch_cake: Conditionally split GSO segments

At lower bandwidths, the transmission time of a single GSO segment can add an unacceptable amount of latency due to HOL blocking. Furthermore, with a software shaper, any tuning mechanism employed by the kernel to control the maximum size of GSO segments is thrown off by the artificial limit on

RE: [PATCH net-next 4/4] bonding: allow carrier and link status to determine link state

> From: Jay Vosburgh [mailto:jay.vosbu...@canonical.com] > Debabrata Banerjee wrote: > > >In a mixed environment it may be difficult to tell if your hardware > >support carrier, if it does not it can always report true. With a new > >use_carrier option of 2, we can check

Re: [PATCH net-next v8 0/3] kernel: add support to collect hardware logs in crash recovery kernel

From: ebied...@xmission.com (Eric W. Biederman) Date: Mon, 14 May 2018 08:11:24 -0500 > David Miller writes: > >> I'm deferring this patch series. >> >> If we can't get a reasonable review from an interested party in 10+ >> days, that is not reasonable. >> >> Resubmit this

Re: INFO: rcu detected stall in kfree_skbmem

On Mon, May 14, 2018 at 9:34 PM, Neil Horman wrote: > On Fri, May 11, 2018 at 12:00:38PM +0200, Dmitry Vyukov wrote: >> On Mon, Apr 30, 2018 at 8:09 PM, syzbot >> wrote: >> > Hello, >> > >> > syzbot found the following

Re: iproute2 - modifying routes in place

Same behavior: root@rwhelan-linux ~ # ip -6 route ::1 dev lo proto kernel metric 256 pref medium fd9b:caee:ff93:ceef:3431:3831:3930:3031 dev internal0 proto kernel metric 256 pref medium fd9b:caee:ff93:ceef:3431:3831:3930:3032 dev internal0 src fd9b:caee:ff93:ceef:3431:3831:3930:3031 metric 1024

[PATCH net-next v2 2/4] bonding: use common mac addr checks

Replace homegrown mac addr checks with faster defs from etherdevice.h Note that this will also prevent any rlb arp updates for multicast addresses, however this should have been forbidden anyway. Signed-off-by: Debabrata Banerjee --- drivers/net/bonding/bond_alb.c | 28

[PATCH net-next v2 3/4] bonding: allow use of tx hashing in balance-alb

The rx load balancing provided by balance-alb is not mutually exclusive with using hashing for tx selection, and should provide a decent speed increase because this eliminates spinlocks and cache contention. Signed-off-by: Debabrata Banerjee ---

[PATCH net-next v2 0/4] bonding: performance and reliability

Series of fixes to how rlb updates are handled, code cleanup, allowing higher performance tx hashing in balance-alb mode, and reliability of link up/down monitoring. v2: refactor bond_is_nondyn_tlb with inline fn, update log comment to point out that multicast addresses will not get rlb updates.

[PATCH net-next v2 4/4] bonding: allow carrier and link status to determine link state

In a mixed environment it may be difficult to tell if your hardware support carrier, if it does not it can always report true. With a new use_carrier option of 2, we can check both carrier and link status sequentially, instead of one or the other Signed-off-by: Debabrata Banerjee

Re: [PATCH v1 iproute2-next 2/3] rdma: print driver resource attributes

On 5/14/2018 3:41 PM, Jason Gunthorpe wrote: > On Mon, May 07, 2018 at 08:53:16AM -0700, Steve Wise wrote: >> This enhancement allows printing rdma device-specific state, if provided >> by the kernel. This is done in a generic manner, so rdma tool doesn't >> need to know about the details of

maximal supported bit rate in traffic control

Hi, In RHEVM we use traffic control to enable users to shape their QoS on the networks they use. IIUC from the traffic control man page, the maximal bit rate currently supported (RHEL 7.4) is 2^32 - 1 bytes per sec, which translates to 32 Gibit\s if I have done my maths correctly. Does anyone

[PATCH net-stable 19/24] hv_netvsc: common detach logic

From: Stephen Hemminger commit 7b2ee50c0cd513a176a26a71f2989facdd75bfea upstream Make common function for detaching internals of device during changes to MTU and RSS. Make sure no more packets are transmitted and all packets have been received before doing device

[PATCH net-stable 13/24] hv_netvsc: cancel subchannel setup before halting device

From: Stephen Hemminger commit a7483ec0267c69b34e818738da60b392623da94b upstream Block setup of multiple channels earlier in the teardown process. This avoids possible races between halt and subchannel initialization. Suggested-by: Haiyang Zhang

[PATCH net-stable 00/24] hv_netvsc patches for 4.14 stable

These patches are backport of latest stability related patches from upstream. Although it looks like a lot it encompasses three main areas: 1. The set of patches to get rid of races when MTU or number of queues is changed while device is up. And make this work on older versions of

[PATCH net-stable 06/24] hv_netvsc: netvsc_teardown_gpadl() split

From: Vitaly Kuznetsov commit 0cf737808ae7cb25e952be619db46b9147a92f46 upstream. It was found that in some cases host refuses to teardown GPADL for send/ receive buffers (probably when some work with these buffere is scheduled or ongoing). Change the teardown logic to be:

[PATCH net-stable 16/24] hv_netvsc: disable NAPI before channel close

From: Stephen Hemminger commit 8348e0460ab1473f06c8b824699dd2eed3c1979d upstream This makes sure that no CPU is still process packets when the channel is closed. Fixes: 76bb5db5c749 ("netvsc: fix use after free on module removal") Signed-off-by: Stephen Hemminger

[PATCH net-stable 17/24] hv_netvsc: use RCU to fix concurrent rx and queue changes

From: Stephen Hemminger commit 02400fcee2542ee334a2394e0d9f6efd969fe782 upstream The receive processing may continue to happen while the internal network device state is in RCU grace period. The internal RNDIS structure is associated with the internal netvsc_device

[PATCH net-stable 18/24] hv_netvsc: change GPAD teardown order on older versions

From: Stephen Hemminger commit 0ef58b0a05c127762f975c3dfe8b922e4aa87a29 upstream On older versions of Windows, the host ignores messages after vmbus channel is closed. Workaround this by doing what Windows does and send the teardown before close on older versions of

[PATCH net-stable 22/24] hv_netvsc: Ensure correct teardown message sequence order

From: Mohammed Gamal commit a56d99d714665591fed8527b90eef21530ea61e0 upstream Prior to commit 0cf737808ae7 ("hv_netvsc: netvsc_teardown_gpadl() split") the call sequence in netvsc_device_remove() was as follows (as implemented in netvsc_destroy_buf()): 1- Send

[PATCH net-stable 11/24] hv_netvsc: only wake transmit queue if link is up

From: Stephen Hemminger commit f4950e4586dfc957e0a28226eeb992ddc049b5a2 upstream Don't wake transmit queues if link is not up yet. Signed-off-by: Stephen Hemminger Signed-off-by: David S. Miller ---

[PATCH net-stable 07/24] hv_netvsc: preserve hw_features on mtu/channels/ringparam changes

From: Vitaly Kuznetsov commit aefd80e874e98a864915df5b7d90824a4340b450 upstream. rndis_filter_device_add() is called both from netvsc_probe() when we initially create the device and from set channels/mtu/ringparam routines where we basically remove the device and add it

[PATCH net-stable 08/24] hv_netvsc: empty current transmit aggregation if flow blocked

From: Stephen Hemminger commit cfd8afd986cdb59ea9adac873c5082498a1eb7c0 upstream If the transmit queue is known full, then don't keep aggregating data. And the cp_partial flag which indicates that the current aggregation buffer is full can be folded in to avoid more

[PATCH net-stable 01/24] hv_netvsc: Fix the real number of queues of non-vRSS cases

From: Haiyang Zhang commit 6450f8f269a9271985e4a8c13920b7e4cf21c0f3 upstream. For older hosts without multi-channel (vRSS) support, and some error cases, we still need to set the real number of queues to one. This patch adds this missing setting. Fixes: 8195b1396ec8

[PATCH net-stable 15/24] hv_netvsc: defer queue selection to VF

From: Stephen Hemminger commit b3bf5666a51068ad5ddd89a76ed877101ef3bc16 upstream When VF is used for accelerated networking it will likely have more queues (and different policy) than the synthetic NIC. This patch defers the queue policy to the VF so that all the

[PATCH net-stable 24/24] hv_netvsc: set master device

From: Stephen Hemminger commit 97f3efb64323beb0690576e9d74e94998ad6e82a upstream The hyper-v transparent bonding should have used master_dev_link. The netvsc device should look like a master bond device not like the upper side of a tunnel. This makes the semantics

[PATCH net-stable 23/24] hv_netvsc: Fix net device attach on older Windows hosts

From: Mohammed Gamal commit 55be9f25be1ca5bda75c39808fc77e42691bc07f upstream On older windows hosts the net_device instance is returned to the caller of rndis_filter_device_add() without having the presence bit set first. This would cause any subsequent calls to network

[PATCH net-stable 20/24] hv_netvsc: Use Windows version instead of NVSP version on GPAD teardown

From: Mohammed Gamal commit 2afc5d61a7197de25a61f54ea4ecfb4cb62b1d42A upstram When changing network interface settings, Windows guests older than WS2016 can no longer shutdown. This was addressed by commit 0ef58b0a05c12 ("hv_netvsc: change GPAD teardown order on older

Re: [PATCH bpf-next v5 3/6] bpf: Add IPv6 Segment Routing helpers

On 05/12/2018 07:25 PM, Mathieu Xhonneux wrote: [...] > +BPF_CALL_4(bpf_lwt_seg6_store_bytes, struct sk_buff *, skb, u32, offset, > +const void *, from, u32, len) > +{ > +#if IS_ENABLED(CONFIG_IPV6_SEG6_BPF) > + struct seg6_bpf_srh_state *srh_state = > +

[net-next 08/16] net/mlx5e: Return success when TC offloaded fdb actions parsed ok

From: Or Gerlitz Reaching here, means we didn't err anywhere, so lets just return success. Signed-off-by: Or Gerlitz Reviewed-by: Jianbo Liu Signed-off-by: Saeed Mahameed ---

[net-next 09/16] net/mlx5e: Use local actions var while processing offloaded TC flow actions

From: Or Gerlitz Use local actions variable while parsing the actions of offloaded TC flow. Signed-off-by: Or Gerlitz Reviewed-by: Roi Dayan Signed-off-by: Saeed Mahameed ---

[net-next 07/16] net/mlx5e: Avoid redundant zeroing of offloaded TC flow attributes

From: Or Gerlitz This is not needed as the attributes are zeroed out on allocation. Signed-off-by: Or Gerlitz Reviewed-by: Jianbo Liu Signed-off-by: Saeed Mahameed ---

[net-next 01/16] net/mlx5e: Remove redundant vport context vlan update

In delete vlan flow an extra call to mlx5e_vport_context_update_vlans was added by mistake, remove it. Fixes: 86d722ad2c3b ("net/mlx5: Use flow steering infrastructure for mlx5_en") Signed-off-by: Saeed Mahameed Reviewed-by: Gal Pressman ---

[net 1/1] net/mlx5: Fix build break when CONFIG_SMP=n

Avoid using the kernel's irq_descriptor and return IRQ vector affinity directly from the driver. This fixes the following build break when CONFIG_SMP=n include/linux/mlx5/driver.h: In function ‘mlx5_get_vector_affinity_hint’: include/linux/mlx5/driver.h:1299:13: error: ‘struct irq_desc’

Re: [PATCH net-next 3/3] udp: only use paged allocation with scatter-gather

On 05/14/2018 04:07 PM, Willem de Bruijn wrote: > From: Willem de Bruijn > > Paged allocation stores most payload in skb frags. This helps udp gso > by avoiding copying from the gso skb to segment skb in skb_segment. > > But without scatter-gather, data must be linear, so

Re: [PATCH net-next 2/3] gso: limit udp gso to egress-only virtual devices

On Mon, May 14, 2018 at 7:07 PM, Willem de Bruijn wrote: > From: Willem de Bruijn > > Until the udp receive stack supports large packets (UDP GRO), GSO > packets must not loop from the egress to the ingress path. > > Revert the change that

[PATCH net-next 2/3] gso: limit udp gso to egress-only virtual devices

From: Willem de Bruijn Until the udp receive stack supports large packets (UDP GRO), GSO packets must not loop from the egress to the ingress path. Revert the change that added NETIF_F_GSO_UDP_L4 to various virtual devices through NETIF_F_GSO_ENCAP_ALL as this included

Re: [PATCH net-next 3/3] udp: only use paged allocation with scatter-gather

On 05/14/2018 04:30 PM, Willem de Bruijn wrote: > I don't quite follow. The reported crash happens in the protocol layer, > because of this check. With pagedlen we have not allocated > sufficient space for the skb_put. > > if (!(rt->dst.dev->features_F_SG)) { >

Re: [PATCH ghak81 RFC V2 3/5] audit: use inline function to get audit context

On Sat, May 12, 2018 at 9:58 PM, Richard Guy Briggs wrote: > Recognizing that the audit context is an internal audit value, use an > access function to retrieve the audit context pointer for the task > rather than reaching directly into the task struct to get it. > >

Re: [PATCH net-next v3 0/7] Microsemi Ocelot Ethernet switch support

On Mon, May 14, 2018 at 10:58:44PM +0200, Andrew Lunn wrote: > Hi Alexandre > > > > The ocelot dts changes are here for reference and should probably go > > through the MIPS tree once the bindings are accepted. > > For your next version, you probably want to drop those patches, so > that David

[net-next 11/16] net/mlx5e: Get the required HW match level while parsing TC flow matches

From: Or Gerlitz Introduce levels of matching on headers of offloaded flows (none, L2, L3, L4) that follow the inline mode levels. This is pre-step for us to offload flows without any matches on headers. Signed-off-by: Or Gerlitz Reviewed-by: Roi

[net-next 16/16] net/mlx5e: Remove MLX5E_TEST_BIT macro

From: Gal Pressman MLX5E_TEST_BIT macro is the same as the already existent test_bit, remove it and replace all usages. Signed-off-by: Gal Pressman Signed-off-by: Tariq Toukan Signed-off-by: Saeed Mahameed ---

[net-next 15/16] net/mlx5e: Use test bit in en accel xmit flow

From: Gal Pressman Replace (mask & bit) check with test_bit. Signed-off-by: Gal Pressman Signed-off-by: Tariq Toukan Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_accel/en_accel.h

[net-next 13/16] net/mlx5e: Report all channels with min RX WQEs timeout

From: Eran Ben Elisha Report all channels which got timeout on posting the minimal number of RX WQEs and not only the first one. Avoid busy wait on every channel, when one of the RQs check got timeout, poll once for the remaining RQs. In addition, add channel index to log

[net-next 14/16] net/mlx5e: Use __set_bit for adaptive-moderation bit in RQ state

From: Gal Pressman Make the code more clear by replacing the existing code with __set_bit. Signed-off-by: Gal Pressman Signed-off-by: Tariq Toukan Signed-off-by: Saeed Mahameed ---

Re: maximal supported bit rate in traffic control

On 05/14/2018 03:15 PM, Eitan Raviv wrote: > Hi, > > In RHEVM we use traffic control to enable users to shape their QoS on > the networks they use. > > IIUC from the traffic control man page, the maximal bit rate currently > supported (RHEL 7.4) is 2^32 - 1 bytes per sec, which translates to

Re: [PATCH net-next] udp: Fix kernel panic in UDP GSO path

>> Paged skbuffs is an optimization for gso, but the feature should >> continue to work even if gso skbs are linear, indeed (if at the cost >> of copying during skb_segment). >> >> We need to make paged contingent on scatter-gather. Rough >> patch below. That is for ipv4 only, the same will be

[PATCH net-next 3/3] udp: only use paged allocation with scatter-gather

From: Willem de Bruijn Paged allocation stores most payload in skb frags. This helps udp gso by avoiding copying from the gso skb to segment skb in skb_segment. But without scatter-gather, data must be linear, so do not use paged mode unless NETIF_F_SG. Fixes: 15e36f5b8e98

Re: [PATCH bpf-next v2] samples/bpf: xdp_monitor, accept short options

On 05/14/2018 12:20 PM, Jesper Dangaard Brouer wrote: > > On Mon, 14 May 2018 17:29:15 +0900 Prashant Bhole > wrote: > >> Updated optstring parameter for getopt_long() to accept short options. >> Also updated usage() function. >> >> Signed-off-by: Prashant

[PATCH net-next 1/3] udp: exclude gso from xfrm paths

From: Willem de Bruijn UDP GSO conflicts with transformations in the XFRM layer. Return an error if GSO is attempted. Fixes: bec1f6f69736 ("udp: generate gso with UDP_SEGMENT") CC: Michal Kubecek Signed-off-by: Willem de Bruijn ---

[PATCH net-next 0/3] udp gso fixes

From: Willem de Bruijn A few small fixes: - disallow segmentation with XFRM - do not leak gso packets into the ingress path - fix a panic if scatter-gather is disabled Willem de Bruijn (3): udp: exclude gso from xfrm paths gso: limit udp gso to egress-only virtual

Re: [PATCH ghak81 RFC V2 5/5] audit: collect audit task parameters

On Sat, May 12, 2018 at 9:58 PM, Richard Guy Briggs wrote: > The audit-related parameters in struct task_struct should ideally be > collected together and accessed through a standard audit API. > > Collect the existing loginuid, sessionid and audit_context together in a > new

[PATCH net-stable 21/24] hv_netvsc: Split netvsc_revoke_buf() and netvsc_teardown_gpadl()

From: Mohammed Gamal commit 7992894c305eaf504d005529637ff8283d0a849d upstream Split each of the functions into two for each of send/recv buffers. This will be needed in order to implement a fine-grained messaging sequence to the host so that we accommodate the requirements of

[PATCH net-stable 02/24] hv_netvsc: Rename ind_table to rx_table

From: Haiyang Zhang commit 47371300dfc269dd8d150e5b872bdbbda98ba809 upstream. Rename this variable because it is the Receive indirection table. Signed-off-by: Haiyang Zhang Signed-off-by: David S. Miller ---

[PATCH net-stable 04/24] hv_netvsc: Add initialization of tx_table in netvsc_device_add()

From: Haiyang Zhang commit 6b0cbe315868d613123cf387052ccda5f09d49ea upstream. tx_table is part of the private data of kernel net_device. It is only zero-ed out when allocating net_device. We may recreate netvsc_device w/o recreating net_device, so the private netdev

[PATCH net-stable 09/24] hv_netvsc: Use the num_online_cpus() for channel limit

From: Haiyang Zhang commit 25a39f7f975c3c26a0052fbf9b59201c06744332 upstream Since we no longer localize channel/CPU affiliation within one NUMA node, num_online_cpus() is used as the number of channel cap, instead of the number of processors in a NUMA node. This patch

[PATCH net-stable 10/24] hv_netvsc: avoid retry on send during shutdown

From: Stephen Hemminger commit 12f69661a49446840d742d8feb593ace022d9f66 upstream Change the initialization order so that the device is ready to transmit (ie connect vsp is completed) before setting the internal reference to the device with RCU. This avoids any races

[PATCH net-stable 03/24] hv_netvsc: Rename tx_send_table to tx_table

From: Haiyang Zhang commit 39e91cfbf6f5fb26ba64cc2e8874372baf1671e7 upstream. Simplify the variable name: tx_send_table Signed-off-by: Haiyang Zhang Signed-off-by: David S. Miller --- drivers/net/hyperv/hyperv_net.h | 2 +-

[PATCH net-stable 05/24] hv_netvsc: Set tx_table to equal weight after subchannels open

From: Haiyang Zhang commit a6fb6aa3cfa9047b62653dbcfc9bcde6e2272b41 upstream. In some cases, like internal vSwitch, the host doesn't provide send indirection table updates. This patch sets the table to be equal weight after subchannels are all open. Otherwise, all

[PATCH net-stable 14/24] hv_netvsc: fix race in napi poll when rescheduling

From: Stephen Hemminger commit d64e38ae690e3337db0d38d9b149a193a1646c4b upstream There is a race between napi_reschedule and re-enabling interrupts which could lead to missed host interrrupts. This occurs when interrupts are re-enabled (hv_end_read) and vmbus irq

[PATCH net-stable 12/24] hv_netvsc: fix error unwind handling if vmbus_open fails

From: Stephen Hemminger commit fcfb4a00d1e514e8313277a01ef919de1113025b upstream Need to delete NAPI association if vmbus_open fails. Signed-off-by: Stephen Hemminger Signed-off-by: David S. Miller ---

Re: [PATCH net-next] udp: Fix kernel panic in UDP GSO path

On 2018-05-11 17:16, Willem de Bruijn wrote: Hmm, no, we absolutely need to fix GSO instead. Think of a bonding device (or any virtual devices), your patch wont avoid the crash. Hi Eric. Can you clarify what you mean by "fix GSO?" Is that just having the GSO path work regardless of

Re: [PATCH v3 bpf-next 0/2] bpf: enable stackmap with build_id in nmi

On 05/07/2018 07:50 PM, Song Liu wrote: > Changes v2 -> v3: > Improve syntax based on suggestion by Tobin C. Harding. > > Changes v1 -> v2: > 1. Rename some variables to (hopefully) reduce confusion; > 2. Check irq_work status with IRQ_WORK_BUSY (instead of work->sem); > 3. In Kconfig,

Re: [net 1/1] net/mlx5: Fix build break when CONFIG_SMP=n

On 05/14/2018 03:38 PM, Saeed Mahameed wrote: > Avoid using the kernel's irq_descriptor and return IRQ vector affinity > directly from the driver. > > This fixes the following build break when CONFIG_SMP=n > > include/linux/mlx5/driver.h: In function ‘mlx5_get_vector_affinity_hint’: >

Re: [PATCH v1 1/4] media: rc: introduce BPF_PROG_IR_DECODER

On 05/14/2018 02:10 PM, Sean Young wrote: > Add support for BPF_PROG_IR_DECODER. This type of BPF program can call Kconfig file below uses IR_BPF_DECODER instead of the symbol name above. and then patch 3 says a third choice: The context provided to a BPF_PROG_RAWIR_DECODER is a struct

Re: [PATCH net-next 3/3] udp: only use paged allocation with scatter-gather

On Mon, May 14, 2018 at 7:12 PM, Eric Dumazet wrote: > > > On 05/14/2018 04:07 PM, Willem de Bruijn wrote: >> From: Willem de Bruijn >> >> Paged allocation stores most payload in skb frags. This helps udp gso >> by avoiding copying from the gso skb to

Re: [PATCH 01/14] net: sched: use rcu for action cookie update

Hi Vlad, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net/master] [also build test WARNING on v4.17-rc5 next-20180514] [cannot apply to net-next/master] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url

Re: [PATCH ghak81 RFC V2 4/5] audit: use inline function to set audit context

On Sat, May 12, 2018 at 9:58 PM, Richard Guy Briggs wrote: > Recognizing that the audit context is an internal audit value, use an > access function to set the audit context pointer for the task > rather than reaching directly into the task struct to set it. > > Signed-off-by:

Re: linux-next: manual merge of the bpf-next tree with the bpf tree

Hi Jakub, On Mon, 14 May 2018 13:41:40 -0700 Jakub Kicinski wrote: > > On Mon, 14 May 2018 11:57:00 +1000, Stephen Rothwell wrote: > > diff --cc tools/lib/bpf/libbpf.c > > index 8da4eeb101a6,df54c4c9e48a.. > > --- a/tools/lib/bpf/libbpf.c > > +++

<    1   2   3   4   >