Re: Request for -stable inclusion: time stamping fix for nfp

On Thu, May 17, 2018 at 08:32:02PM +0200, Willy Tarreau wrote: > Adding Greg here. > > Greg, apparently a backport of 46f1c52e66db is needed in 4.9 according > to the thread below. It was merged in 4.13 so 4.14 already has it. Thanks for the notice, now queued up. greg k-h

Re: [PATCH bpf-next v2 1/7] perf/core: add perf_get_event() to return perf_event given a struct file

On Thu, May 17, 2018 at 10:32:53PM -0700, Yonghong Song wrote: > A new extern function, perf_get_event(), is added to return a perf event > given a struct file. This function will be used in later patches. Can't you do a narrower interface? Like return the prog. I'm not too keen on random !perf

[PATCH 1/2] bpf: sockmap, double free in __sock_map_ctx_update_elem()

We accidentally free "e" twice. Fixes: 81110384441a ("bpf: sockmap, add hash map support") Signed-off-by: Dan Carpenter diff --git a/kernel/bpf/sockmap.c b/kernel/bpf/sockmap.c index c6de1393df63..216d5c9b0eb3 100644 --- a/kernel/bpf/sockmap.c +++

Re: [PATCH 38/42] isdn: replace ->proc_fops with ->proc_show

Hi Christoph, (I don't think the patches of this series ever hit the ISDN related addresses still found in MAINTAINERS. And now I might be a bit late.) Christoph Hellwig schreef op wo 16-05-2018 om 11:43 [+0200]: > diff --git a/drivers/isdn/gigaset/capi.c b/drivers/isdn/gigaset/capi.c > index

[PATCH net-next 2/2] net: mscc: ocelot: add VLAN filtering

From: Antoine Tenart Add hardware VLAN filtering offloading on ocelot. Signed-off-by: Antoine Tenart Signed-off-by: Alexandre Belloni --- drivers/net/ethernet/mscc/ocelot.c | 285

[PATCH net-next 0/2] net: mscc; ocelot: add more features

Hi, This series adds link aggregation and VLAN filtering hardware offload support to the ocelot driver. PTP is also on the list of features but it will probably not be submitted this cycle. Alexandre Belloni (1): net: mscc: ocelot: add bonding support Antoine Tenart (1): net: mscc: ocelot:

[PATCH net-next 1/2] net: mscc: ocelot: add bonding support

Add link aggregation hardware offload support for Ocelot. ocelot_get_link_ksettings() is not great but it does work until the driver is reworked to switch to phylink. Signed-off-by: Alexandre Belloni --- drivers/net/ethernet/mscc/ocelot.c | 177

Re: [PATCH net-next ] net: mscc: Add SPDX identifier

On 18/05/2018 01:14:25-0700, Joe Perches wrote: > Mostly, it's a question of what the original > license is. As far as I can tell, microsemi > publishes their code only under an MIT license. > This code didn't exist until I wrote it. The original license is the one from the SPDX identifier. >

[patch net-next 1/5] devlink: introduce devlink_port_attrs_set

From: Jiri Pirko Change existing setter for split port information into more generic attrs setter. Alongside with that, allow to set port number and subport number for split ports. Signed-off-by: Jiri Pirko --- RFC->v1: - Reduced the nfp change just to

[patch net-next 0/5] devlink: introduce port flavours and common phys_port_name generation

From: Jiri Pirko This patchset resolves 2 issues we have right now: 1) There are many netdevices / ports in the system, for port, pf, vf represenatation but the user has no way to see which is which 2) The ndo_get_phys_port_name is implemented in each driver separatelly,

[patch net-next 2/5] devlink: extend attrs_set for setting port flavours

From: Jiri Pirko Devlink ports can have specific flavour according to the purpose of use. This patch extend attrs_set so the driver can say which flavour port has. Initial flavours are: physical, cpu, dsa User can query this to see right away what is the purpose of each port.

[patch net-next 3/5] devlink: introduce a helper to generate physical port names

From: Jiri Pirko Each driver implements physical port name generation by itself. However as devlink has all needed info, it can easily do the job for all its users. So implement this helper in devlink. Signed-off-by: Jiri Pirko --- RFC->v1: - rebased ---

[patch net-next 4/5] dsa: set devlink port attrs for dsa ports

From: Jiri Pirko Set the attrs and allow to expose port flavour to user via devlink. Signed-off-by: Jiri Pirko --- RFC->v1: - added missing break pointed out by Andrew --- net/dsa/dsa2.c | 24 1 file changed, 24 insertions(+)

[patch net-next 5/5] mlxsw: use devlink helper to generate physical port name

From: Jiri Pirko Since devlink knows the info needed to generate the physical port name in a generic way for all devlink users, use the helper to do the job. Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/core.c | 11 +++

Re: [Cake] [PATCH net-next v12 3/7] sch_cake: Add optional ACK filter

On 18 May 2018 at 13:38, Eric Dumazet wrote: > > > On 05/17/2018 07:36 PM, Ryan Mounce wrote: >> On 17 May 2018 at 22:41, Toke Høiland-Jørgensen wrote: >>> Eric Dumazet writes: >>> On 05/17/2018 04:23 AM, Toke Høiland-Jørgensen

Re: [patch net-next RFC 04/12] dsa: set devlink port attrs for dsa ports

Fri, May 18, 2018 at 03:41:37AM CEST, and...@lunn.ch wrote: >> >>> ds = dsa_switch_alloc(>dev, DSA_MAX_PORTS); >> >>> >> >>> It is allocating a switch with 12 ports. However only 4 of them have >> >>> names. So the core only creates slave devices for those 4. >> >>> >> >>> This is a useful

Re: [patch net-next RFC 04/12] dsa: set devlink port attrs for dsa ports

Fri, May 18, 2018 at 12:40:17AM CEST, and...@lunn.ch wrote: >On Thu, May 17, 2018 at 03:06:36PM -0700, Florian Fainelli wrote: >> On 05/17/2018 02:08 PM, Andrew Lunn wrote: >> > On Thu, May 17, 2018 at 10:48:55PM +0200, Jiri Pirko wrote: >> >> Thu, May 17, 2018 at 09:14:32PM CEST,

[PATCH net-next 7/9] net/smc: do a few smc_core.c cleanups

From: Hans Wippel This patch consists of Christmas tree fixes and removal of an unneeded function parameter. Signed-off-by: Hans Wippel Signed-off-by: Ursula Braun --- net/smc/smc_core.c | 14 ++ 1 file changed,

[PATCH net-next 9/9] net/smc: restructure client and server code in af_smc

From: Hans Wippel This patch splits up the functions smc_connect_rdma and smc_listen_work into smaller functions. Signed-off-by: Hans Wippel Signed-off-by: Ursula Braun --- net/smc/af_smc.c | 559

[PATCH net-next 6/9] net/smc: restructure CDC message reception

From: Hans Wippel This patch moves a CDC sanity check from smc_cdc_msg_recv_action() to the other sanity checks in smc_cdc_rx_handler(). While doing this, it simplifies smc_cdc_msg_recv() and removes unneeded function parameters. Signed-off-by: Hans Wippel

[PATCH net-next 1/9] net/smc: add common buffer size in send and receive buffer descriptors

From: Hans Wippel In addition to the buffer references, SMC currently stores the sizes of the receive and send buffers in each connection as separate variables. This patch introduces a buffer length variable in the common buffer descriptor and uses this length instead.

[PATCH net-next] net: mvpp2: Add missing VLAN tag detection

Marvell PPv2 Header Parser sets some bits in the 'result_info' field in each lookup iteration, to identify different packet attributes such as DSA / VLAN tag, protocol infos, etc. This is used in further classification stages in the controller. It's the DSA tag detection entry that is in charge

[PATCH net-next 0/9] net/smc: cleanups 2018-05-18

From: Ursula Braun Hi Dave, here are SMC patches for net-next providing restructuring and cleanup in different areas. Thanks, Ursula Hans Wippel (9): net/smc: add common buffer size in send and receive buffer descriptors net/smc: move link group list to smc_core

[PATCH net-next 4/9] net/smc: calculate write offset in RMB only once per connection

From: Hans Wippel Currently, the write offset within the RMB is calculated on each write operation although it is fixed for each connection. With this patch, the offset is calculated once and stored in a connection specific variable. Signed-off-by: Hans Wippel

Re: [PATCH net-next ] net: mscc: Add SPDX identifier

On 17/05/2018 18:13:25-0700, Joe Perches wrote: > On Thu, 2018-05-17 at 21:39 +0200, Alexandre Belloni wrote: > > On 17/05/2018 12:28:59-0700, Joe Perches wrote: > > > On Thu, 2018-05-17 at 21:23 +0200, Alexandre Belloni wrote: > > > > ocelot_qsys.h is missing the SPDX identfier, fix that. > > > >

Re: [PATCH 1/2] bpf: sockmap, double free in __sock_map_ctx_update_elem()

Hi Dan, On 05/18/2018 09:58 AM, Dan Carpenter wrote: > We accidentally free "e" twice. > > Fixes: 81110384441a ("bpf: sockmap, add hash map support") > Signed-off-by: Dan Carpenter > > diff --git a/kernel/bpf/sockmap.c b/kernel/bpf/sockmap.c > index

Re: [PATCH net-next ] net: mscc: Add SPDX identifier

On 17/05/18 21:23, Alexandre Belloni wrote: > ocelot_qsys.h is missing the SPDX identfier, fix that. > > Signed-off-by: Alexandre Belloni > --- > drivers/net/ethernet/mscc/ocelot_qsys.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

[PATCH bpf-next 1/5] selftests/bpf: test_sockmap, check test failure

Test failures are not identified because exit code of RX/TX threads is not checked. Also threads are not returning correct exit code. - Return exit code from threads depending on test execution status - In main thread, check the exit code of RX/TX threads Fixes: 16962b2404ac ("bpf: sockmap, add

[PATCH bpf-next 0/5] fix test_sockmap

This series fixes bugs in test_sockmap code. They weren't caught previously because failure in RX/TX thread was not notified to the main thread. Also fixed data verification logic and slightly improved test output such that parameters values (cork, apply, start, end) of failed test can be easily

[PATCH bpf-next 3/5] selftests/bpf: test_sockmap, fix test timeout

In order to reduce runtime of tests, recently timout for select() call was reduced from 1sec to 10usec. This was causing many tests failures. It was caught with failure handling commits in this series. Restoring the timeout from 10usec to 1sec Fixes: a18fda1a62c3 ("bpf: reduce runtime of

[PATCH bpf-next 2/5] selftests/bpf: test_sockmap, join cgroup in selftest mode

In case of selftest mode, temporary cgroup environment is created but cgroup is not joined. It causes test failures. Fixed by joining the cgroup Fixes: 16962b2404ac ("bpf: sockmap, add selftests") Signed-off-by: Prashant Bhole ---

[PATCH bpf-next 5/5] selftests/bpf: test_sockmap, print additional test options

Print values of test options like apply, cork, start, end so that individual failed tests can be identified for manual run Signed-off-by: Prashant Bhole --- tools/testing/selftests/bpf/test_sockmap.c | 28 +++- 1 file changed, 19

[PATCH bpf-next 4/5] selftests/bpf: test_sockmap, fix data verification

When data verification is enabled, some tests fail because verification is done incorrectly. Following changes fix it. - Identify the size of data block to be verified - Reset verification counter when data block size is reached - Fixed the value printed in case of verification failure Fixes:

Re: [PATCH net-next ] net: mscc: Add SPDX identifier

On Fri, 2018-05-18 at 09:52 +0200, Alexandre Belloni wrote: > On 17/05/2018 18:13:25-0700, Joe Perches wrote: > > On Thu, 2018-05-17 at 21:39 +0200, Alexandre Belloni wrote: > > > On 17/05/2018 12:28:59-0700, Joe Perches wrote: > > > > On Thu, 2018-05-17 at 21:23 +0200, Alexandre Belloni wrote: >

[PATCH net-next 2/9] net/smc: move link group list to smc_core

From: Hans Wippel This patch moves the global link group list to smc_core where the link group functions are. To make this work, it moves code in af_smc and smc_ib that operates on the link group list to smc_core as well. While at it, the link group counter is integrated

[PATCH net-next 8/9] net/smc: change smc_buf_free function parameters

From: Hans Wippel This patch changes the function smc_buf_free to use the SMC link group instead of the link as function parameter. Also, it changes the order of the other two parameters. Signed-off-by: Hans Wippel Signed-off-by: Ursula Braun

[PATCH net-next 3/9] net/smc: rename connection index to RMBE index

From: Hans Wippel The connection index is actually a RMBE index. So, this patch changes the name accordingly. Signed-off-by: Hans Wippel Signed-off-by: Ursula Braun --- net/smc/af_smc.c | 2 +- net/smc/smc.h | 2 +-

[PATCH net-next 5/9] net/smc: move smc_core specific code from smc.h to smc_core

From: Hans Wippel SMC connection and buffer handling belong to smc_core. So, this patch moves this code from smc.h to smc_core. Signed-off-by: Hans Wippel Signed-off-by: Ursula Braun --- net/smc/smc.h | 41

Re: [PATCH] netfilter: ebtables: handle string from userspace with care

On Fri, Apr 27, 2018 at 10:45:31AM +0200, Paolo Abeni wrote: > strlcpy() can't be safely used on a user-space provided string, > as it can try to read beyond the buffer's end, if the latter is > not NULL terminated. Applied, thanks!

[PATCH 2/2] bpf: sockmap, potential uninitialized return in __sock_map_ctx_update_elem()

Smatch complains that "err" might be uninitialized. That seems possible. Anyway we can just return zero. Fixes: e5cd3abcb31a ("bpf: sockmap, refactor sockmap routines to work with hashmap") Signed-off-by: Dan Carpenter diff --git a/kernel/bpf/sockmap.c

WARNING in __static_key_slow_dec

We report the crash: WARNING in __static_key_slow_dec This crash has been found in v4.8 using RaceFuzzer (a modified version of Syzkaller), which we describe more at the end of this report. Even though v4.8 is the relatively old version, we did manual verification and we think the bug still

[no subject]

Bcc: Subject: WARNING in ip_recv_error Reply-To: We report the crash: WARNING in ip_recv_error This crash has been found in v4.17-rc1 using RaceFuzzer (a modified version of Syzkaller), which we describe more at the end of this report. Our analysis shows that the race occurs when invoking two

Re: [net-next 3/6] ixgbe: release lock for the duration of ixgbe_suspend_close()

Hello! On 5/17/2018 7:37 PM, Jeff Kirsher wrote: From: Pavel Tatashin Currently, during device_shutdown() ixgbe holds rtnl_lock for the duration of lengthy ixgbe_close_suspend(). On machines with multiple ixgbe cards this lock prevents scaling if device_shutdown()

Re: [PATCH v2 net-next 00/12] net: stmmac: Clean-up and tune-up

Hi David, On 17-05-2018 19:47, David Miller wrote: > From: David Miller > Date: Thu, 17 May 2018 14:41:17 -0400 (EDT) > >> From: Jose Abreu >> Date: Thu, 17 May 2018 14:24:42 +0100 >> >>> Given that the difference between better/worst is < 1%, I

Re: [PATCH v3 2/2] bpf: add selftest for rawir_event type program

2018-05-17 22:01 UTC+0100 ~ Sean Young > On Thu, May 17, 2018 at 10:17:59AM -0700, Y Song wrote: >> On Wed, May 16, 2018 at 2:04 PM, Sean Young wrote: >>> This is simple test over rc-loopback. >>> >>> Signed-off-by: Sean Young >>> --- >>>

Re: general protection fault in qdisc_hash_add

On Fri, May 18, 2018 at 11:14:07AM +0200, Dmitry Vyukov wrote: > On Fri, May 18, 2018 at 10:38 AM, Hangbin Liu wrote: > > Hi Dmitry, > > > > I got a kasan GPF error when run netlink sched test. The syzkaller log file > > and call trace attached. > > > > What interested me is

[PATCH v2] wcn36xx: Add support for Factory Test Mode (FTM)

From: Eyal Ilsar Introduce infrastructure for supporting Factory Test Mode (FTM) of the wireless LAN subsystem. In order for the user space to access the firmware in test mode the relevant netlink channel needs to be exposed from the kernel driver. The above is achieved

Re: [PATCH v2] netfilter: properly initialize xt_table_info structure

On Fri, May 18, 2018 at 11:27:56AM +0200, Florian Westphal wrote: > Greg Kroah-Hartman wrote: > > On Thu, May 17, 2018 at 12:42:00PM +0200, Jan Engelhardt wrote: > > > > > > On Thursday 2018-05-17 12:09, Greg Kroah-Hartman wrote: > > > >> > ---

Re: [net-next 3/6] ixgbe: release lock for the duration of ixgbe_suspend_close()

  * parallelized this function, so drop lock for the > >     Parallelizing? Else the sentence doesn't parse for me. :-) Hi Sergei, In a separate series I parallelized device_shutdown(), see: http://lkml.kernel.org/r/20180516024004.28977-1-pasha.tatas...@oracle.com But, this particular

Re: [PATCH 1/4] arcnet: com20020: Add com20020 io mapped version

On 05/17/2018 10:31 PM, David Miller wrote: > From: Andrea Greco > Date: Thu, 17 May 2018 15:05:29 +0200 > >> + /* Will be set by userspace during if setup */ >> + dev->dev_addr[0] = 0; > > Hmmm... really? > > Also, every error path from this point forward will

[PATCH] net/atheros: fix spelling mistake: "Ddescription" -> "Description"

From: Colin Ian King Trivial fix to spelling mistakes in name field text Signed-off-by: Colin Ian King --- drivers/net/ethernet/atheros/atl1e/atl1e_param.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH v2] netfilter: properly initialize xt_table_info structure

Greg Kroah-Hartman wrote: > On Thu, May 17, 2018 at 12:42:00PM +0200, Jan Engelhardt wrote: > > > > On Thursday 2018-05-17 12:09, Greg Kroah-Hartman wrote: > > >> > --- a/net/netfilter/x_tables.c > > >> > +++ b/net/netfilter/x_tables.c > > >> > @@ -1183,11 +1183,10 @@

Re: [PATCH] wcn36xx: Add support for Factory Test Mode (FTM)

On 17 May 2018 at 21:37, Jeff Johnson wrote: > On 2018-05-17 04:32, Ramon Fried wrote: >> >> From: Eyal Ilsar > > ... >> >> +int wcn36xx_smd_process_ptt_msg(struct wcn36xx *wcn, >> + struct ieee80211_vif *vif, void

Re: [PATCH v2] sh_eth: Change platform check to CONFIG_ARCH_RENESAS

On 05/18/2018 01:52 PM, Geert Uytterhoeven wrote: > Since commit 9b5ba0df4ea4f940 ("ARM: shmobile: Introduce ARCH_RENESAS") > is CONFIG_ARCH_RENESAS a more appropriate platform check than the legacy "If" should follow, not precede the option as this is not a question. :-) >

Re: [PATCH 0/3] Add R8A77980 GEther support

On 05/17/2018 09:53 PM, David Miller wrote: >> Here's a set of 3 patches against DaveM's 'net-next.git' repo. They >> (gradually) >> add R8A77980 GEther support to the 'sh_eth' driver, starting with couple new >> register bits/values introduced with this chip, and ending with adding a new >>

Re: [Cake] [PATCH net-next v12 3/7] sch_cake: Add optional ACK filter

Hi Kevin, > On May 18, 2018, at 13:18, Kevin Darbyshire-Bryant > wrote: > > > >> On 18 May 2018, at 05:27, Cong Wang wrote: >> >> On Thu, May 17, 2018 at 4:23 AM, Toke Høiland-Jørgensen wrote: >>> Eric Dumazet

Re: Request for -stable inclusion: time stamping fix for nfp

On Thu, May 17, 2018 at 02:09:03PM -0400, David Miller wrote: > From: Guillaume Nault > Date: Thu, 17 May 2018 19:41:47 +0200 > > > On Thu, Nov 16, 2017 at 10:13:28AM +0900, David Miller wrote: > >> From: Guillaume Nault > >> Date: Wed, 15 Nov 2017

Re: [PATCH net-next] tipc: eliminate complaint of KMSAN uninit-value in tipc_conn_rcv_sub

On Fri, May 18, 2018 at 1:50 PM, Ying Xue wrote: > As variable s of struct tipc_subscr type is not initialized > in tipc_conn_rcv_from_sock() before it is used in tipc_conn_rcv_sub(), > KMSAN reported the following uninit-value type complaint: > >

Re: general protection fault in qdisc_hash_add

On Fri, May 18, 2018 at 10:38 AM, Hangbin Liu wrote: > Hi Dmitry, > > I got a kasan GPF error when run netlink sched test. The syzkaller log file > and call trace attached. > > What interested me is the TCA_RED_PARMS. Here is the log > > r0 = socket$nl_route(0x10, 0x3, 0x0)

Re: KASAN: use-after-free Read in vhost_chr_write_iter

On 2018年05月17日 21:45, DaeRyong Jeong wrote: We report the crash: KASAN: use-after-free Read in vhost_chr_write_iter This crash has been found in v4.17-rc1 using RaceFuzzer (a modified version of Syzkaller), which we describe more at the end of this report. Our analysis shows that the race

Re: [Cake] [PATCH net-next v12 3/7] sch_cake: Add optional ACK filter

> On 18 May 2018, at 05:27, Cong Wang wrote: > > On Thu, May 17, 2018 at 4:23 AM, Toke Høiland-Jørgensen wrote: >> Eric Dumazet writes: >> >>> On 05/16/2018 01:29 PM, Toke Høiland-Jørgensen wrote: The ACK filter is an

[PATCH net] sock_diag: fix use-after-free read in __sk_free

We must not call sock_diag_has_destroy_listeners(sk) on a socket that has no reference on net structure. BUG: KASAN: use-after-free in sock_diag_has_destroy_listeners include/linux/sock_diag.h:75 [inline] BUG: KASAN: use-after-free in __sk_free+0x329/0x340 net/core/sock.c:1609 Read of size 8 at

[PATCH v2] sh_eth: Change platform check to CONFIG_ARCH_RENESAS

Since commit 9b5ba0df4ea4f940 ("ARM: shmobile: Introduce ARCH_RENESAS") is CONFIG_ARCH_RENESAS a more appropriate platform check than the legacy CONFIG_ARCH_SHMOBILE, hence use the former. Renesas SuperH SH-Mobile SoCs are still covered by the CONFIG_CPU_SH4 check. This will allow to drop

Re: [RFC v4 3/5] virtio_ring: add packed ring support

On Thu, May 17, 2018 at 08:01:52PM +0800, Jason Wang wrote: > On 2018年05月16日 22:33, Tiwei Bie wrote: > > On Wed, May 16, 2018 at 10:05:44PM +0800, Jason Wang wrote: > > > On 2018年05月16日 21:45, Tiwei Bie wrote: > > > > On Wed, May 16, 2018 at 08:51:43PM +0800, Jason Wang wrote: > > > > > On

[PATCH bpf-next 1/4] xsk: clean up SPDX headers

From: Björn Töpel Clean up SPDX-License-Identifier and removing licensing leftovers. Signed-off-by: Björn Töpel --- include/net/xdp_sock.h | 13 ++--- include/uapi/linux/if_xdp.h | 13 ++--- kernel/bpf/xskmap.c | 9

[PATCH bpf-next 2/4] xsk: remove newline at end of file

From: Björn Töpel Minor cleanup, remove newline at end of Makefile. Signed-off-by: Björn Töpel --- net/xdp/Makefile | 1 - 1 file changed, 1 deletion(-) diff --git a/net/xdp/Makefile b/net/xdp/Makefile index 074fb2b2d51c..04f073146256 100644 ---

[PATCH bpf-next 3/4] xsk: fixed some cases of unnecessary parentheses

From: Björn Töpel Removed some cases of unnecessary parentheses. Signed-off-by: Björn Töpel --- net/xdp/xdp_umem.c | 4 ++-- net/xdp/xsk_queue.c | 3 +-- net/xdp/xsk_queue.h | 4 ++-- 3 files changed, 5 insertions(+), 6 deletions(-) diff --git

[PATCH bpf-next 4/4] xsk: proper '=' alignment

From: Björn Töpel Properly align xsk_proto_ops initialization. Signed-off-by: Björn Töpel --- net/xdp/xsk.c | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/net/xdp/xsk.c b/net/xdp/xsk.c

[PATCH bpf-next 0/4] AF_XDP follow-up patches, cosmetics

From: Björn Töpel This series contain "cosmetics only" follow-up patches for AF_XDP. Thanks to Daniel for suggesting them! Björn Töpel (4): xsk: clean up SPDX headers xsk: remove newline at end of file xsk: fixed some cases of unnecessary parentheses xsk: proper

Re: [PATCH 38/42] isdn: replace ->proc_fops with ->proc_show

On Fri, May 18, 2018 at 10:43:46AM +0200, Paul Bolle wrote: > > iif->ctr.release_appl = gigaset_release_appl; > > iif->ctr.send_message = gigaset_send_message; > > - iif->ctr.procinfo = gigaset_procinfo; > > Is this intentional? You didn't touch the procinfo method in the other

[PATCH] hippi: fix spelling mistake: "Framming" -> "Framing"

From: Colin Ian King Trivial fix to spelling mistake in printk message text Signed-off-by: Colin Ian King --- drivers/net/hippi/rrunner.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/hippi/rrunner.c

[PATCH net-next] tipc: eliminate complaint of KMSAN uninit-value in tipc_conn_rcv_sub

As variable s of struct tipc_subscr type is not initialized in tipc_conn_rcv_from_sock() before it is used in tipc_conn_rcv_sub(), KMSAN reported the following uninit-value type complaint: == BUG: KMSAN: uninit-value in

WARNING in ip_recv_error

We report the crash: WARNING in ip_recv_error (I resend the email since I mistakenly missed the subject in my previous email. I'm sorry.) This crash has been found in v4.17-rc1 using RaceFuzzer (a modified version of Syzkaller), which we describe more at the end of this report. Our analysis

[PATCHv2 net-next] erspan: set bso bit based on mirrored packet's len

Before the patch, the erspan BSO bit (Bad/Short/Oversized) is not handled. BSO has 4 possible values: 00 --> Good frame with no error, or unknown integrity 11 --> Payload is a Bad Frame with CRC or Alignment Error 01 --> Payload is a Short Frame 10 --> Payload is an Oversized Frame Based

Re: [patch net-next 0/5] devlink: introduce port flavours and common phys_port_name generation

On 05/18/2018 12:28 AM, Jiri Pirko wrote: > From: Jiri Pirko > > This patchset resolves 2 issues we have right now: > 1) There are many netdevices / ports in the system, for port, pf, vf >represenatation but the user has no way to see which is which > 2) The

[PATCH net] net: ip6_gre: fix tunnel metadata device sharing.

Currently ip6gre and ip6erspan share single metadata mode device, using 'collect_md_tun'. Thus, when doing: ip link add dev ip6gre11 type ip6gretap external ip link add dev ip6erspan12 type ip6erspan external RTNETLINK answers: File exists simply fails due to the 2nd tries to create the

[PATCH net] cxgb4: fix offset in collecting TX rate limit info

Correct the indirect register offsets in collecting TX rate limit info in UP CIM logs. Also, T5 doesn't support these indirect register offsets, so remove them from collection logic. Fixes: be6e36d916b1 ("cxgb4: collect TX rate limit info in UP CIM logs") Signed-off-by: Rahul Lakkireddy

Re: [PATCH bpf-next v3 00/15] Introducing AF_XDP support

On 05/18/2018 05:38 AM, Alexei Starovoitov wrote: > On 5/16/18 11:46 PM, Björn Töpel wrote: >> 2018-05-04 1:38 GMT+02:00 Alexei Starovoitov : >>> On Fri, May 04, 2018 at 12:49:09AM +0200, Daniel Borkmann wrote: On 05/02/2018 01:01 PM, Björn Töpel wrote: >

Re: [PATCH bpf-next 3/3] bpf: Add mtu checking to FIB forwarding helper

On 05/18/2018 02:34 AM, David Ahern wrote: > On 5/17/18 4:22 PM, Daniel Borkmann wrote: >> On 05/17/2018 06:09 PM, David Ahern wrote: >>> Add check that egress MTU can handle packet to be forwarded. If >>> the MTU is less than the packet lenght, return 0 meaning the >>> packet is expected to

Re: [PATCH net] tuntap: raise EPOLLOUT on device up

On Fri, May 18, 2018 at 10:00:31PM +0800, Jason Wang wrote: > > > On 2018年05月18日 21:26, Jason Wang wrote: > > > > > > On 2018年05月18日 21:13, Michael S. Tsirkin wrote: > > > On Fri, May 18, 2018 at 09:00:43PM +0800, Jason Wang wrote: > > > > We return -EIO on device down but can not raise

Re: [PATCH v3 net-next 00/12] net: stmmac: Clean-up and tune-up

On Fri, May 18, 2018 at 02:55:57PM +0100, Jose Abreu wrote: > This targets to uniformize the handling of the different GMAC versions in > stmmac_main.c file and also tune-up the HW. > > Currently there are some if/else conditions in the main source file which > calls different callbacks depending

Re: [PATCH net] tuntap: raise EPOLLOUT on device up

On 2018年05月18日 22:06, Michael S. Tsirkin wrote: On Fri, May 18, 2018 at 10:00:31PM +0800, Jason Wang wrote: On 2018年05月18日 21:26, Jason Wang wrote: On 2018年05月18日 21:13, Michael S. Tsirkin wrote: On Fri, May 18, 2018 at 09:00:43PM +0800, Jason Wang wrote: We return -EIO on device down

Re: [PATCH] hippi: fix spelling mistake: "Framming" -> "Framing"

On 05/18/2018 06:09 AM, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in printk message text > > Signed-off-by: Colin Ian King > --- > drivers/net/hippi/rrunner.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [PATCH bpf-next v3 00/15] Introducing AF_XDP support

2018-05-18 15:43 GMT+02:00 Daniel Borkmann : > On 05/18/2018 05:38 AM, Alexei Starovoitov wrote: >> On 5/16/18 11:46 PM, Björn Töpel wrote: >>> 2018-05-04 1:38 GMT+02:00 Alexei Starovoitov : On Fri, May 04, 2018 at 12:49:09AM +0200, Daniel

Re: [RFC PATCH ghak32 V2 01/13] audit: add container id

On 2018-05-18 09:56, Steve Grubb wrote: > On Thu, 17 May 2018 17:56:00 -0400 > Richard Guy Briggs wrote: > > > > During syscall events, the path info is returned in a a record > > > simply called AUDIT_PATH, cwd info is returned in AUDIT_CWD. So, > > > rather than calling the

Re: [PATCH] hippi: fix spelling mistake: "Framming" -> "Framing"

From: Jes Sorensen Date: Fri, 18 May 2018 10:33:50 -0400 > I do wonder if it's time to retire this driver and the HIPPI code. I > haven't had access to hardware for over a decade so I have no idea > if it even works anymore. That's a good question. If you really think

Re: WARNING in ip_recv_error

From: Eric Dumazet Date: Fri, 18 May 2018 08:30:43 -0700 > We probably need to revert Willem patch > (7ce875e5ecb8562fd44040f69bda96c999e38bbc) Is it really valid to reach ip_recv_err with an ipv6 socket?

Re: [PATCH bpf v2 6/6] bpf: fix JITed dump for multi-function programs via syscall

On 05/18/2018 02:50 PM, Sandipan Das wrote: > Currently, for multi-function programs, we cannot get the JITed > instructions using the bpf system call's BPF_OBJ_GET_INFO_BY_FD > command. Because of this, userspace tools such as bpftool fail > to identify a multi-function program as being JITed or

[PATCH v2 net-next] net: stmmac: Populate missing callbacks in HWIF initialization

Some HW specific setups, like sun8i, do not populate all the necessary callbacks, which is what HWIF helpers were expecting. Fix this by always trying to get the generic helpers and populate them if they were not previously populated by HW specific setup. Signed-off-by: Jose Abreu

Re: [PATCH iproute2-next] tc: flower: add support for verbose logging

On 5/13/18 2:44 PM, Marcelo Ricardo Leitner wrote: > From: Marcelo Ricardo Leitner > > Currently there is no way to log offloading errors if the rule is not > explicitly marked as skip_sw, making it hard for other applications such > as Open vSwitch to log why a given could

Re: [net PATCH] net: Fix a bug in removing queues from XPS map

From: Amritha Nambiar Date: Thu, 17 May 2018 14:50:44 -0700 > While removing queues from the XPS map, the individual CPU ID > alone was used to index the CPUs map, this should be changed to also > factor in the traffic class mapping for the CPU-to-queue lookup. > >

Re: [iproute2-next v3 1/1] tipc: fixed node and name table listings

On 5/17/18 8:02 AM, Jon Maloy wrote: > We make it easier for users to correlate between 128-bit node > identities and 32-bit node hash number by extending the 'node list' > command to also show the hash number. > > We also improve the 'nametable show' command to show the node identity > instead

Re: [PATCH bpf-next v3 00/15] Introducing AF_XDP support

2018-05-18 18:17 GMT+02:00 Daniel Borkmann : > On 05/18/2018 05:18 PM, Björn Töpel wrote: >> 2018-05-18 15:43 GMT+02:00 Daniel Borkmann : >>> On 05/18/2018 05:38 AM, Alexei Starovoitov wrote: On 5/16/18 11:46 PM, Björn Töpel wrote: > 2018-05-04

Re: [PATCH bpf-next v2 1/7] perf/core: add perf_get_event() to return perf_event given a struct file

On 5/18/18 12:18 AM, Peter Zijlstra wrote: On Thu, May 17, 2018 at 10:32:53PM -0700, Yonghong Song wrote: A new extern function, perf_get_event(), is added to return a perf event given a struct file. This function will be used in later patches. Can't you do a narrower interface? Like return

Re: [PATCH bpf-next 2/5] selftests/bpf: test_sockmap, join cgroup in selftest mode

On 05/18/2018 12:17 AM, Prashant Bhole wrote: > In case of selftest mode, temporary cgroup environment is created but > cgroup is not joined. It causes test failures. Fixed by joining the > cgroup > > Fixes: 16962b2404ac ("bpf: sockmap, add selftests") > Signed-off-by: Prashant Bhole

Re: [PATCH bpf-next 4/5] selftests/bpf: test_sockmap, fix data verification

On 05/18/2018 12:17 AM, Prashant Bhole wrote: > When data verification is enabled, some tests fail because verification is > done > incorrectly. Following changes fix it. > > - Identify the size of data block to be verified > - Reset verification counter when data block size is reached > - Fixed

[PATCH] powerpc/32: Implement csum_ipv6_magic in assembly

The generic csum_ipv6_magic() generates a pretty bad result : 0: 81 23 00 00 lwz r9,0(r3) 4: 81 03 00 04 lwz r8,4(r3) 8: 7c e7 4a 14 add r7,r7,r9 c: 7d 29 38 10 subfc r9,r9,r7 10: 7d 4a 51 10 subfe r10,r10,r10 14: 7d 27 42

Re: WARNING in ip_recv_error

On 05/18/2018 05:08 AM, DaeRyong Jeong wrote: > We report the crash: WARNING in ip_recv_error > (I resend the email since I mistakenly missed the subject in my previous > email. I'm sorry.) > > > This crash has been found in v4.17-rc1 using RaceFuzzer (a modified > version of Syzkaller), which

Re: [PATCH bpf v2 2/6] bpf: powerpc64: add JIT support for multi-function programs

On 05/18/2018 02:50 PM, Sandipan Das wrote: > This adds support for bpf-to-bpf function calls in the powerpc64 > JIT compiler. The JIT compiler converts the bpf call instructions > to native branch instructions. After a round of the usual passes, > the start addresses of the JITed images for the

Re: [PATCH net-next ] net: mscc: Add SPDX identifier

From: Alexandre Belloni Date: Thu, 17 May 2018 21:23:05 +0200 > ocelot_qsys.h is missing the SPDX identfier, fix that. > > Signed-off-by: Alexandre Belloni Applied, thank you.

  1   2   3   >