Re: [PATCH] net: netsec: reduce DMA mask to 40 bits

2018-05-26 Thread Ard Biesheuvel
On 26 May 2018 at 05:44, Jassi Brar wrote: > On 26 May 2018 at 08:56, Jassi Brar wrote: >> On 26 May 2018 at 01:07, Robin Murphy wrote: >>> On Sat, 26 May 2018 00:33:05 +0530 >>> Jassi Brar

Re: [bpf-next PATCH] bpf: sockhash fix race with bpf_tcp_close and map delete

2018-05-26 Thread Song Liu
On Fri, May 25, 2018 at 10:37 AM, John Fastabend wrote: > syzbot reported two related splats, a use after free and null > pointer dereference, when a TCP socket is closed while the map is > also being removed. > > The psock keeps a reference to all map slots that have a

Re: WARNING in bpf_int_jit_compile

2018-05-26 Thread syzbot
syzbot has found a reproducer for the following crash on: HEAD commit:62d18ecfa641 Merge tag 'arm64-fixes' of git://git.kernel.o.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=14c6bf5780 kernel config:

Re: [PATCH] rtnetlink: Add more well known protocol values

2018-05-26 Thread Sergei Shtylyov
Hello! On 5/25/2018 9:20 PM, Donald Sharp wrote: FRRouting installs routes into the kernel associated with the originating protocol. Add these values to the well known values in rtnetlink.h. Signed-off-by: Donald Sharp --- include/uapi/linux/rtnetlink.h | 5

[PATCH v2 2/2] batman-adv: Drop "experimental" from BATMAN_V Kconfig

2018-05-26 Thread Sven Eckelmann
The Kconfig option BATMAN_ADV_BATMAN_V is now enabled by default when the BATMAN_ADV is enabled. A feature which is enabled by default for a module should not be considered experimental. Reported-by: Joe Perches Signed-off-by: Sven Eckelmann --- v2: no

[PATCH v2 1/2] batman-adv: Remove "default n" in Kconfig

2018-05-26 Thread Sven Eckelmann
The "default n" is the default value for any bool or tristate Kconfig setting. It is therefore not necessary to add it to a config entry. Reported-by: Sergei Shtylyov Signed-off-by: Sven Eckelmann --- v2: changed "the an config entry" to

[PATCH net-next] net: bpfilter: make function bpfilter_mbox_request() static

2018-05-26 Thread Wei Yongjun
Fixes the following sparse warnings: net/ipv4/bpfilter/sockopt.c:13:5: warning: symbol 'bpfilter_mbox_request' was not declared. Should it be static? Signed-off-by: Wei Yongjun --- net/ipv4/bpfilter/sockopt.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)

[PATCH net-next] netfilter: nat: make symbol nat_hook static

2018-05-26 Thread Wei Yongjun
Fixes the following sparse warning: net/netfilter/nf_nat_core.c:1039:20: warning: symbol 'nat_hook' was not declared. Should it be static? Signed-off-by: Wei Yongjun --- net/netfilter/nf_nat_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Is it possible to get device information via CMSG?

2018-05-26 Thread Eric S. Raymond
I'm trying to untangle some nasty code in the Mills implementation of NTP. I could simplify it a lot if there were a way to query a packet to find out the name of the network interface it arrived on. (At the moment the code has to iterate over all interfaces checking for traffic on each one just

Re: System hung for reg_check_changs_work()-> rtnl_lock()->mutex_lock()

2018-05-26 Thread Dmitry Vyukov
On Mon, May 21, 2018 at 5:47 AM, Shawn Lin wrote: > Hi, > > I found this hung for several times these days, and seems syzbot already > reported a similar problem. Is there any patch(es) for that? > > Successfully initialized wpa_supplicant > [ 240.091941] INFO: task

Re: aio poll and a new in-kernel poll API V13

2018-05-26 Thread Al Viro
On Sat, May 26, 2018 at 01:11:11AM +0100, Al Viro wrote: > On Wed, May 23, 2018 at 09:19:49PM +0200, Christoph Hellwig wrote: > > Hi all, > > > > this series adds support for the IOCB_CMD_POLL operation to poll for the > > readyness of file descriptors using the aio subsystem. The API is based >

Re: aio poll and a new in-kernel poll API V13

2018-05-26 Thread Christoph Hellwig
I'm still waking up..

Re: [PATCH net-next v12 2/5] netvsc: refactor notifier/event handling code to use the failover framework

2018-05-26 Thread Samudrala, Sridhar
On 5/25/2018 4:28 PM, Stephen Hemminger wrote: On Fri, 25 May 2018 16:11:47 -0700 "Samudrala, Sridhar" wrote: On 5/25/2018 3:34 PM, Stephen Hemminger wrote: On Thu, 24 May 2018 09:55:14 -0700 Sridhar Samudrala wrote: ---

Re: [PATCH net-next v12 1/5] net: Introduce generic failover module

2018-05-26 Thread Jiri Pirko
Sat, May 26, 2018 at 12:37:44AM CEST, step...@networkplumber.org wrote: >On Thu, 24 May 2018 09:55:13 -0700 >Sridhar Samudrala wrote: > > >> +spin_lock(_lock); > >Since register is not in fast path, this should be a mutex? I don't get it. Why would you prefer

Re: [PATCH net-next] bpfilter: fix a build err

2018-05-26 Thread Yafang Shao
On Sat, May 26, 2018 at 10:25 AM, YueHaibing wrote: > On 2018/5/26 0:19, Alexei Starovoitov wrote: >> On Fri, May 25, 2018 at 06:17:57PM +0800, YueHaibing wrote: >>> gcc-7.3.0 report following err: >>> >>> HOSTCC net/bpfilter/main.o >>> In file included from

KASAN: use-after-free Read in bpf_tcp_close

2018-05-26 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:3fb48d881dbe Merge branch 'bpf-fib-mtu-check' git tree: bpf-next console output: https://syzkaller.appspot.com/x/log.txt?x=15fc197780 kernel config: https://syzkaller.appspot.com/x/.config?x=b632d8e2c2ab2c1 dashboard link:

Re: WARNING: ODEBUG bug in __sk_destruct

2018-05-26 Thread syzbot
syzbot has found a reproducer for the following crash on: HEAD commit:e52cde717093 net: dsa: dsa_loop: Make dynamic debugging he.. git tree: net-next console output: https://syzkaller.appspot.com/x/log.txt?x=1424a4b780 kernel config:

Re: [PATCH net-next v12 2/5] netvsc: refactor notifier/event handling code to use the failover framework

2018-05-26 Thread Jiri Pirko
Sat, May 26, 2018 at 09:22:18AM CEST, sridhar.samudr...@intel.com wrote: >On 5/25/2018 4:28 PM, Stephen Hemminger wrote: >> On Fri, 25 May 2018 16:11:47 -0700 >> "Samudrala, Sridhar" wrote: >> >> > On 5/25/2018 3:34 PM, Stephen Hemminger wrote: >> > > On Thu, 24 May

Re: [bpf-next PATCH] bpf: sockhash fix race with bpf_tcp_close and map delete

2018-05-26 Thread Daniel Borkmann
Hi John, On 05/25/2018 07:37 PM, John Fastabend wrote: > syzbot reported two related splats, a use after free and null > pointer dereference, when a TCP socket is closed while the map is > also being removed. > > The psock keeps a reference to all map slots that have a reference > to the sock so

general protection fault in sock_do_ioctl

2018-05-26 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:62c8a069b510 net: mvpp2: Add missing VLAN tag detection git tree: net-next console output: https://syzkaller.appspot.com/x/log.txt?x=10ad582780 kernel config: https://syzkaller.appspot.com/x/.config?x=b632d8e2c2ab2c1

Re: [PATCH 1/2] batman-adv: Remove "default n" in Kconfig

2018-05-26 Thread Sergei Shtylyov
On 5/25/2018 10:48 PM, Sven Eckelmann wrote: The "default n" is the default value for any bool or tristate Kconfig setting. It is therefore not necessary to add it to the an config entry. ^^ One article would be enough. And it's "a",

general protection fault in bpf_tcp_close

2018-05-26 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:fd0bfa8d6e04 Merge branch 'bpf-af-xdp-cleanups' git tree: bpf-next console output: https://syzkaller.appspot.com/x/log.txt?x=11da942780 kernel config: https://syzkaller.appspot.com/x/.config?x=b632d8e2c2ab2c1 dashboard link:

WARNING in bpf_int_jit_compile

2018-05-26 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:203ec2fed17a Merge tag 'armsoc-fixes' of git://git.kernel... git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=14f0d5a780 kernel config: https://syzkaller.appspot.com/x/.config?x=f3b4e30da84ec1ed

[PATCH net-next] net: remove unnecessary genlmsg_cancel() calls

2018-05-26 Thread YueHaibing
the message be freed immediately, no need to trim it back to the previous size. Inspired by commit 7a9b3ec1e19f ("nl80211: remove unnecessary genlmsg_cancel() calls") Signed-off-by: YueHaibing --- drivers/net/team/team.c | 2 --

Re: [PATCH v4 2/3] media: rc: introduce BPF_PROG_LIRC_MODE2

2018-05-26 Thread Sean Young
On Fri, May 25, 2018 at 01:45:11PM -0700, Alexei Starovoitov wrote: > On Fri, May 18, 2018 at 03:07:29PM +0100, Sean Young wrote: > > Add support for BPF_PROG_LIRC_MODE2. This type of BPF program can call > > rc_keydown() to reported decoded IR scancodes, or rc_repeat() to report > > that the last

Re: [PATCH bpf-next] selftests/bpf: missing headers test_lwt_seg6local

2018-05-26 Thread Mathieu Xhonneux
2018-05-25 18:39 GMT+02:00 Daniel Borkmann : > Yes, should definitely go there to tools include infrastructure. What is the point of tools/testing/selftests/bpf/include/uapi/ then ? Incompatibility issues preventing linux/types.h to be included in non-bpf testing executables

[PATCH bpf-next v2] selftests/bpf: missing headers test_lwt_seg6local

2018-05-26 Thread Mathieu Xhonneux
Previous patch "selftests/bpf: test for seg6local End.BPF action" lacks some UAPI headers in tools/. clang -I. -I./include/uapi -I../../../include/uapi -idirafter /usr/local/include -idirafter /data/users/yhs/work/llvm/build/install/lib/clang/7.0.0/include -idirafter /usr/include

[PATCH] rsi: fix spelling mistake "Uknown" -> "Unknown"

2018-05-26 Thread Colin King
From: Colin Ian King Trivial fix to spelling mistake in rsi_dbg message text Signed-off-by: Colin Ian King --- drivers/net/wireless/rsi/rsi_91x_mac80211.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: INFO: rcu detected stall in corrupted

2018-05-26 Thread Dmitry Vyukov
On Thu, May 24, 2018 at 11:02 AM, Xin Long wrote: > On Thu, May 24, 2018 at 7:13 AM, Marcelo Ricardo Leitner > wrote: >> On Mon, May 21, 2018 at 11:13:46AM -0700, Eric Dumazet wrote: >>> >>> >>> On 05/21/2018 11:09 AM, David Miller wrote: >>> >

Re: INFO: rcu detected stall in kmem_cache_alloc_node_trace

2018-05-26 Thread Dmitry Vyukov
On Mon, Apr 30, 2018 at 8:05 PM, syzbot wrote: > Hello, > > syzbot found the following crash on: > > HEAD commit:17dec0a94915 Merge branch 'userns-linus' of > git://git.kerne... > git tree: net-next > console output:

Re: INFO: rcu detected stall in skb_free_head

2018-05-26 Thread Dmitry Vyukov
On Sun, Apr 29, 2018 at 6:33 PM, syzbot wrote: > Hello, > > syzbot hit the following crash on upstream commit > a27fc14219f2e3c4a46ba9177b04d9b52c875532 (Mon Apr 16 21:07:39 2018 +) > Merge branch 'parisc-4.17-3' of >

Re: [PATCH 4/6] sh_eth: remove custom .nway_reset from ethtool ops

2018-05-26 Thread Sergei Shtylyov
On 05/26/2018 09:46 PM, Sergei Shtylyov wrote: >> The change fixes a sleep in atomic context issue, which can be >> always triggered by running 'ethtool -r' command, because >> phy_start_aneg() protects phydev fields by a mutex. > >Again, I'm unable to reproduce this BUG()... Now I can!

Re: [PATCH net-next v12 2/5] netvsc: refactor notifier/event handling code to use the failover framework

2018-05-26 Thread Samudrala, Sridhar
'On 5/26/2018 12:51 AM, Jiri Pirko wrote: Sat, May 26, 2018 at 09:22:18AM CEST, sridhar.samudr...@intel.com wrote: On 5/25/2018 4:28 PM, Stephen Hemminger wrote: On Fri, 25 May 2018 16:11:47 -0700 "Samudrala, Sridhar" wrote: On 5/25/2018 3:34 PM, Stephen

Re: [PATCH 4/7] x86: remove a stray reference to pci-nommu.c

2018-05-26 Thread Thomas Gleixner
On Fri, 25 May 2018, Christoph Hellwig wrote: Subject should be: Documentation/x86: Remove . please > This is just the minimal workaround. The file file is mostly either stale file file? > and/or duplicative of Documentation/admin-guide/kernel-parameters.txt, > but that is much more work

Re: [PATCH 1/6] ravb: remove custom .nway_reset from ethtool ops

2018-05-26 Thread Sergei Shtylyov
Hello. A formal patch review this time... On 05/24/2018 02:11 PM, Vladimir Zapolskiy wrote: > The change fixes a sleep in atomic context issue, which can be > always triggered by running 'ethtool -r' command, because > phy_start_aneg() protects phydev fields by a mutex. OK so far... >

Re: [PATCH 1/6] ravb: remove custom .nway_reset from ethtool ops

2018-05-26 Thread Sergei Shtylyov
Hello. A formal patch review this time... On 05/24/2018 02:11 PM, Vladimir Zapolskiy wrote: > The change fixes a sleep in atomic context issue, which can be > always triggered by running 'ethtool -r' command, because > phy_start_aneg() protects phydev fields by a mutex. OK so far... >

Re: [PATCH 0/6] ravb/sh_eth: fix sleep in atomic by reusing shared ethtool handlers

2018-05-26 Thread Sergei Shtylyov
On 05/25/2018 09:25 AM, Vladimir Zapolskiy wrote: For ages trivial changes to RAVB and SuperH ethernet links by means of standard 'ethtool' trigger a 'sleeping function called from invalid context' bug, to visualize it on r8a7795 ULCB: % ethtool -r eth0 BUG:

Re: [PATCH 3/6] ravb: remove custom .set_link_ksettings from ethtool ops

2018-05-26 Thread Sergei Shtylyov
On 05/24/2018 02:11 PM, Vladimir Zapolskiy wrote: > The change replaces a custom implementation of .set_link_ksettings > callback with a shared phy_ethtool_set_link_ksettings(), this fixes > sleep in atomic context bug, which is encountered every time when link > settings are changed by ethtool.

Re: [PATCH 1/6] ravb: remove custom .nway_reset from ethtool ops

2018-05-26 Thread Sergei Shtylyov
On 05/24/2018 02:11 PM, Vladimir Zapolskiy wrote: > The change fixes a sleep in atomic context issue, which can be > always triggered by running 'ethtool -r' command, because > phy_start_aneg() protects phydev fields by a mutex. BTW, I was unable to trigger the BUG() with 'ethtool -r eth0'

[PATCH v4 net] stmmac: 802.1ad tag stripping support fix

2018-05-26 Thread Elad Nachman
stmmac reception handler calls stmmac_rx_vlan() to strip the vlan before calling napi_gro_receive(). The function assumes VLAN tagged frames are always tagged with 802.1Q protocol, and assigns ETH_P_8021Q to the skb by hard-coding the parameter on call to __vlan_hwaccel_put_tag() . This causes

Proposal

2018-05-26 Thread Miss Zeliha Omer Faruk
Hello Greetings to you please i have a business proposal for you contact me for more detailes asap thanks. Best Regards, Miss.Zeliha ömer faruk Esentepe Mahallesi Büyükdere Caddesi Kristal Kule Binasi No:215 Sisli - Istanbul, Turkey

Re: [PATCH net] sctp: not allow to set rto_min with a value below 200 msecs

2018-05-26 Thread Michael Tuexen
> On 25. May 2018, at 21:13, Neil Horman wrote: > > On Sat, May 26, 2018 at 01:41:02AM +0800, Xin Long wrote: >> syzbot reported a rcu_sched self-detected stall on CPU which is caused >> by too small value set on rto_min with SCTP_RTOINFO sockopt. With this >> value,

Re: INFO: rcu detected stall in ip_route_output_key_hash

2018-05-26 Thread Dmitry Vyukov
On Wed, May 16, 2018 at 5:29 PM, syzbot wrote: > Hello, > > syzbot found the following crash on: > > HEAD commit:0b7d9978406f Merge branch 'Microsemi-Ocelot-Ethernet-switc.. > git tree: net-next > console output:

Re: [PATCH] crypto: chtls: generic handling of data and hdr

2018-05-26 Thread Herbert Xu
On Mon, May 14, 2018 at 04:41:38PM +0530, Atul Gupta wrote: > removed redundant check and made TLS PDU and header recv > handling common as received from HW. > Ensure that only tls header is read in cpl_rx_tls_cmp > read-ahead and skb is freed when entire data is processed. > > Signed-off-by:

Re: [PATCH v2] netfilter: properly initialize xt_table_info structure

2018-05-26 Thread Greg Kroah-Hartman
On Fri, May 18, 2018 at 11:27:56AM +0200, Florian Westphal wrote: > Greg Kroah-Hartman wrote: > > On Thu, May 17, 2018 at 12:42:00PM +0200, Jan Engelhardt wrote: > > > > > > On Thursday 2018-05-17 12:09, Greg Kroah-Hartman wrote: > > > >> > ---

Re: [PATCH net-next 6/7] net: bridge: Notify about bridge VLANs

2018-05-26 Thread Vivien Didelot
Hi Petr, Petr Machata writes: > Vivien Didelot writes: > >>> + } else { >>> + err = br_switchdev_port_obj_add(dev, v->vid, flags); >>> + if (err && err != -EOPNOTSUPP) >>> + goto out; >>> } >>

Re: [PATCH 2/6] ravb: remove custom .get_link_ksettings from ethtool ops

2018-05-26 Thread Sergei Shtylyov
On 05/24/2018 02:11 PM, Vladimir Zapolskiy wrote: > The change replaces a custom implementation of .get_link_ksettings > callback with a shared phy_ethtool_get_link_ksettings(), note that > >lock wrapping is not needed, because the lock does not > serialize access to phydev fields. No BUG()

Re: [PATCH 4/6] sh_eth: remove custom .nway_reset from ethtool ops

2018-05-26 Thread Sergei Shtylyov
On 05/24/2018 02:11 PM, Vladimir Zapolskiy wrote: > The change fixes a sleep in atomic context issue, which can be > always triggered by running 'ethtool -r' command, because > phy_start_aneg() protects phydev fields by a mutex. Again, I'm unable to reproduce this BUG()... > Another note is

Re: INFO: rcu detected stall in sctp_generate_heartbeat_event

2018-05-26 Thread Dmitry Vyukov
On Tue, May 8, 2018 at 2:06 PM, Marcelo Ricardo Leitner wrote: > On Tue, May 08, 2018 at 12:35:02AM -0700, syzbot wrote: >> Hello, >> >> syzbot found the following crash on: >> >> HEAD commit:90278871d4b0 Merge git://git.kernel.org/pub/scm/linux/kern.. >> git tree:

Re: [PATCH net] sctp: not allow to set rto_min with a value below 200 msecs

2018-05-26 Thread Dmitry Vyukov
On Sat, May 26, 2018 at 5:42 PM, Michael Tuexen wrote: >> On 25. May 2018, at 21:13, Neil Horman wrote: >> >> On Sat, May 26, 2018 at 01:41:02AM +0800, Xin Long wrote: >>> syzbot reported a rcu_sched self-detected stall on CPU which is

RE: [PATCH, net-next] net/mlx5e: fix TLS dependency

2018-05-26 Thread Boris Pismenny
Acked-by: Boris Pismenny Thank you. > -Original Message- > From: Saeed Mahameed > Sent: Saturday, May 26, 2018 2:19 AM > To: da...@davemloft.net; a...@arndb.de; l...@kernel.org > Cc: linux-ker...@vger.kernel.org; linux-r...@vger.kernel.org; Boris > Pismenny

Re: INFO: rcu detected stall in kfree_skbmem

2018-05-26 Thread Dmitry Vyukov
On Mon, May 14, 2018 at 8:04 PM, Xin Long wrote: > On Mon, May 14, 2018 at 9:34 PM, Neil Horman wrote: >> On Fri, May 11, 2018 at 12:00:38PM +0200, Dmitry Vyukov wrote: >>> On Mon, Apr 30, 2018 at 8:09 PM, syzbot >>>

Re: INFO: rcu detected stall in sctp_packet_transmit

2018-05-26 Thread Dmitry Vyukov
On Wed, May 16, 2018 at 2:12 PM, Dmitry Vyukov wrote: > On Wed, May 16, 2018 at 1:02 PM, Xin Long wrote: wrote: > Hello, > > syzbot found the following crash on: > > HEAD

Greetings

2018-05-26 Thread Zeliha Omer Faruk
Hello Greetings to you please i have a business proposal for you contact me for more detailes asap thanks. Best Regards, Miss.Zeliha ömer faruk Esentepe Mahallesi Büyükdere Caddesi Kristal Kule Binasi No:215 Sisli - Istanbul, Turkey

Re: [PATCH net] net: sched: check netif_xmit_frozen_or_stopped() in sch_direct_xmit()

2018-05-26 Thread John Fastabend
On 05/25/2018 12:46 PM, Song Liu wrote: > On Fri, May 25, 2018 at 11:11 AM, Song Liu wrote: >> Summary: >> >> At the end of sch_direct_xmit(), we are in the else path of >> !dev_xmit_complete(ret), which means ret == NETDEV_TX_OK. The following >> condition will always fail

Re: [PATCH 3/4] cpsw_switchdev: add switchdev support files

2018-05-26 Thread kbuild test robot
Hi Ilias, Thank you for the patch! Yet something to improve: [auto build test ERROR on net/master] [also build test ERROR on v4.17-rc6] [cannot apply to net-next/master] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [bpf-next PATCH] bpf: sockhash fix race with bpf_tcp_close and map delete

2018-05-26 Thread John Fastabend
On 05/26/2018 01:30 AM, Daniel Borkmann wrote: > Hi John, > > On 05/25/2018 07:37 PM, John Fastabend wrote: >> syzbot reported two related splats, a use after free and null >> pointer dereference, when a TCP socket is closed while the map is >> also being removed. >> >> The psock keeps a

Re: [PATCH net] sctp: not allow to set rto_min with a value below 200 msecs

2018-05-26 Thread Neil Horman
On Sat, May 26, 2018 at 05:50:39PM +0200, Dmitry Vyukov wrote: > On Sat, May 26, 2018 at 5:42 PM, Michael Tuexen > wrote: > >> On 25. May 2018, at 21:13, Neil Horman wrote: > >> > >> On Sat, May 26, 2018 at 01:41:02AM +0800, Xin Long

[PATCH net] VSOCK: check sk state before receive

2018-05-26 Thread Hangbin Liu
Since vmci_transport_recv_dgram_cb is a callback function and we access the socket struct without holding the lock here, there is a possibility that sk has been released and we use it again. This may cause a NULL pointer dereference later, while receiving. Here is the call trace: [ 389.486319]

Re: net-next boot error: KASAN: use-after-free Write in call_usermodehelper_exec_work

2018-05-26 Thread Dmitry Vyukov
On Sun, May 27, 2018 at 7:34 AM, syzbot wrote: > Hello, > > syzbot found the following crash on: > > HEAD commit:5b79c2af667c Merge git://git.kernel.org/pub/scm/linux/kern.. > git tree: net-next > console output:

[PATCH] net: qcom/emac: fix device tree initialization

2018-05-26 Thread Timur Tabi
Commit "net: qcom/emac: Encapsulate sgmii ops under one structure" introduced the sgmii_ops structure, but did not correctly initialize it on device tree platforms. This resulted in compiler warnings when ACPI is not enabled. Reported-by: Arnd Bergmann Signed-off-by: Timur Tabi

Re: [PATCH, net-next] qcom-emag: hide ACPI specific functions

2018-05-26 Thread Timur Tabi
On 5/25/18 7:22 PM, Timur Tabi wrote: -phy->open = emac_sgmii_open; -phy->close = emac_sgmii_close; -phy->link_up = emac_sgmii_link_up; -phy->link_down = emac_sgmii_link_down; I'll take it look at it next week when I'm back in the office. I posted a patch that fixes this

Re: [PATCH] net: netsec: reduce DMA mask to 40 bits

2018-05-26 Thread Jassi Brar
On 26 May 2018 at 11:46, Ard Biesheuvel wrote: > On 26 May 2018 at 05:44, Jassi Brar wrote: >> On 26 May 2018 at 08:56, Jassi Brar wrote: >>> On 26 May 2018 at 01:07, Robin Murphy wrote: