Re: [RFC v5 2/5] virtio_ring: support creating packed ring

2018-05-29 Thread Jason Wang
On 2018年05月29日 13:24, Tiwei Bie wrote: On Tue, May 29, 2018 at 10:49:11AM +0800, Jason Wang wrote: On 2018年05月22日 16:16, Tiwei Bie wrote: This commit introduces the support for creating packed ring. All split ring specific functions are added _split suffix. Some necessary stubs for packed

Re: [RFC v5 3/5] virtio_ring: add packed ring support

2018-05-29 Thread Jason Wang
On 2018年05月29日 13:11, Tiwei Bie wrote: On Tue, May 29, 2018 at 11:18:57AM +0800, Jason Wang wrote: On 2018年05月22日 16:16, Tiwei Bie wrote: [...] +static void detach_buf_packed(struct vring_virtqueue *vq, + unsigned int id, void **ctx) +{ + struct

[PATCH net] vhost_net: flush batched heads before trying to busy polling

2018-05-29 Thread Jason Wang
After commit e2b3b35eb989 ("vhost_net: batch used ring update in rx"), we tend to batch updating used heads. But it doesn't flush batched heads before trying to do busy polling, this will cause vhost to wait for guest TX which waits for the used RX. Fixing by flush batched heads before busy loop.

Re: [PATCH bpf-next] bpf: clean up eBPF helpers documentation

2018-05-29 Thread Song Liu
On Tue, May 29, 2018 at 4:27 AM, Quentin Monnet wrote: > These are minor edits for the eBPF helpers documentation in > include/uapi/linux/bpf.h. > > The main fix consists in removing "BPF_FIB_LOOKUP_", because it ends > with a non-escaped underscore that gets interpreted by rst2man and > produces

Re: [PATCH mlx5-next v2 11/13] IB/mlx5: Add flow counters binding support

2018-05-29 Thread Jason Gunthorpe
On Tue, May 29, 2018 at 04:09:15PM +0300, Leon Romanovsky wrote: > diff --git a/include/uapi/rdma/mlx5-abi.h b/include/uapi/rdma/mlx5-abi.h > index 508ea8c82da7..ef3f430a7050 100644 > +++ b/include/uapi/rdma/mlx5-abi.h > @@ -443,4 +443,18 @@ enum { > enum { > MLX5_IB_CLOCK_INFO_V1

Re: [pull request][for-next 00/12] Mellanox, mlx5e updates 2018-05-25

2018-05-29 Thread Saeed Mahameed
On Tue, 2018-05-29 at 09:47 -0400, David Miller wrote: > From: Saeed Mahameed > Date: Fri, 25 May 2018 17:01:55 -0700 > > > This is a mlx5e only pull request, for more information please see > > tag > > log below. > > > > Please pull and let me know if there's any problem. > > Pulled, thanks

Re: [PATCH bpf-next 02/11] bpf: add also cbpf long jump test cases with heavy expansion

2018-05-29 Thread Song Liu
On Sun, May 27, 2018 at 5:43 PM, Daniel Borkmann wrote: > We have one triggering on eBPF but lets also add a cBPF example to > make sure we keep tracking them. Also add anther cBPF test running > max number of MSH ops. > > Signed-off-by: Daniel Borkmann > Acked-by: Alexei Starovoitov Acked-by:

[PATCH bpf-next] bpf: Verify flags in bpf_fib_lookup

2018-05-29 Thread dsahern
From: David Ahern Verify flags argument contains only known flags. Allows programs to probe for support as more are added. Signed-off-by: David Ahern --- net/core/filter.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/net/core/filter.c b/net/core/filter.c index

Re: [PATCH bpf-next] bpf: Verify flags in bpf_fib_lookup

2018-05-29 Thread Daniel Borkmann
On 05/29/2018 08:59 PM, dsah...@kernel.org wrote: > From: David Ahern > > Verify flags argument contains only known flags. Allows programs to probe > for support as more are added. > > Signed-off-by: David Ahern Applied to bpf-next, thanks David!

Re: [PATCH bpf-next] bpf: Drop mpls from bpf_fib_lookup

2018-05-29 Thread Daniel Borkmann
On 05/29/2018 07:58 PM, dsah...@kernel.org wrote: > From: David Ahern > > MPLS support will not be submitted this dev cycle, but in working on it > I do see a few changes are needed to the API. For now, drop mpls from the > API. Since the fields in question are unions, the mpls fields can be

Re: [PATCH rdma-next v2 01/13] IB/uverbs: Add an ib_uobject getter to ioctl() infrastructure

2018-05-29 Thread Jason Gunthorpe
On Tue, May 29, 2018 at 07:31:22PM +, Ruhl, Michael J wrote: > >-struct ib_uverbs_destroy_cq_resp resp; > > struct ib_uobject *uobj = > >-uverbs_attr_get(attrs, > >UVERBS_ATTR_DESTROY_CQ_HANDLE)->obj_attr.uobject; > >-struct ib_ucq_object *obj = container_of(uobj,

Re: [PATCH rdma-next 0/3] Introduce new mlx5 CQE format

2018-05-29 Thread Jason Gunthorpe
On Sun, May 27, 2018 at 01:42:31PM +0300, Leon Romanovsky wrote: > From: Leon Romanovsky > > Introduce new internal to mlx5 CQE format - mini-CQE. It is a CQE in > compressed form that holds data needed to extra a single full CQE. > > It stride index, byte count and packet checksum. > > Thanks

Re: [PATCH net] sctp: not allow to set rto_min with a value below 200 msecs

2018-05-29 Thread Xin Long
On Wed, May 30, 2018 at 1:06 AM, Marcelo Ricardo Leitner wrote: > On Tue, May 29, 2018 at 12:03:46PM -0400, Neal Cardwell wrote: >> On Tue, May 29, 2018 at 11:45 AM Marcelo Ricardo Leitner < >> marcelo.leit...@gmail.com> wrote: >> > - patch2 - fix rtx attack vector >> >- Add the floor value

Re: [PATCH bpf-next 01/11] bpf: test case for map pointer poison with calls/branches

2018-05-29 Thread Song Liu
On Sun, May 27, 2018 at 5:43 PM, Daniel Borkmann wrote: > Add several test cases where the same or different map pointers > originate from different paths in the program and execute a map > lookup or tail call at a common location. > > Signed-off-by: Daniel Borkmann > Acked-by: Alexei

Re: [PATCH bpf-next 04/11] bpf: show prog and map id in fdinfo

2018-05-29 Thread Daniel Borkmann
On 05/29/2018 07:27 PM, Jesper Dangaard Brouer wrote: > On Mon, 28 May 2018 02:43:37 +0200 > Daniel Borkmann wrote: > >> Its trivial and straight forward to expose it for scripts that can >> then use it along with bpftool in order to inspect an individual >> application's used maps and progs.

Re: [PATCH net] sctp: not allow to set rto_min with a value below 200 msecs

2018-05-29 Thread Marcelo Ricardo Leitner
On Wed, May 30, 2018 at 01:45:08AM +0800, Xin Long wrote: > If we're counting on max_t to fix this CPU stuck. It should not that > matter if min rto < the value causing that stuck. Yes but putting a floor to rto_{min,max} now is to protect the rtx timer now, not the heartbeat one. > > > > >

Re: [PATCH bpf-next 03/11] bpf: fixup error message from gpl helpers on license mismatch

2018-05-29 Thread Song Liu
On Tue, May 29, 2018 at 10:16 AM, Jesper Dangaard Brouer wrote: > On Mon, 28 May 2018 02:43:36 +0200 > Daniel Borkmann wrote: > >> Stating 'proprietary program' in the error is just silly since it >> can also be a different open source license than that which is just >> not compatible. >> >>

Re: [PATCH net-next 1/5] net: aquantia: Ethtool based ring size configuration

2018-05-29 Thread Jakub Kicinski
On Tue, 29 May 2018 15:56:58 +0300, Igor Russkikh wrote: > +static int aq_set_ringparam(struct net_device *ndev, > + struct ethtool_ringparam *ring) > +{ > + int err = 0; > + struct aq_nic_s *aq_nic = netdev_priv(ndev); > + struct aq_nic_cfg_s *aq_nic_cfg =

Re: [PATCH bpf-next] bpf: clean up eBPF helpers documentation

2018-05-29 Thread Daniel Borkmann
On 05/29/2018 08:27 PM, Song Liu wrote: > On Tue, May 29, 2018 at 4:27 AM, Quentin Monnet > wrote: >> These are minor edits for the eBPF helpers documentation in >> include/uapi/linux/bpf.h. >> >> The main fix consists in removing "BPF_FIB_LOOKUP_", because it ends >> with a non-escaped

[PATCH bpf-next] bpf: Drop mpls from bpf_fib_lookup

2018-05-29 Thread dsahern
From: David Ahern MPLS support will not be submitted this dev cycle, but in working on it I do see a few changes are needed to the API. For now, drop mpls from the API. Since the fields in question are unions, the mpls fields can be added back later without affecting the uapi. Signed-off-by:

RE: [PATCH rdma-next v2 01/13] IB/uverbs: Add an ib_uobject getter to ioctl() infrastructure

2018-05-29 Thread Ruhl, Michael J
>-Original Message- >From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- >ow...@vger.kernel.org] On Behalf Of Leon Romanovsky >Sent: Tuesday, May 29, 2018 9:09 AM >To: Doug Ledford ; Jason Gunthorpe > >Cc: Leon Romanovsky ; RDMA mailing list r...@vger.kernel.org>; Boris Pismenny ;

Re: [PATCH] net: sched: split tc_ctl_tfilter into three handlers

2018-05-29 Thread David Miller
From: Vlad Buslov Date: Sun, 27 May 2018 22:55:03 +0300 > tc_ctl_tfilter handles three netlink message types: RTM_NEWTFILTER, > RTM_DELTFILTER, RTM_GETTFILTER. However, implementation of this function > involves a lot of branching on specific message type because most of the > code is

[PATCH] ixgbe: check ipsec ip addr against mgmt filter

2018-05-29 Thread Shannon Nelson
Make sure we don't try to offload the decryption of an incoming packet that should get delivered to the management engine. This is a corner case that will likely be very seldom seen, but could really confuse someone if they were to hit it. Suggested-by: Jesse Brandeburg Signed-off-by: Shannon

Re: [PATCH mlx5-next 1/2] net/mlx5: Add temperature warning event to log

2018-05-29 Thread Andrew Lunn
On Tue, May 29, 2018 at 05:19:53PM -0700, Saeed Mahameed wrote: > From: Ilan Tayari > > Temperature warning event is sent by FW to indicate high temperature > as detected by one of the sensors on the board. > Add handling of this event by writing the numbers of the alert sensors > to the kernel

Re: [PATCH bpf-next] bpftool: Support sendmsg{4,6} attach types

2018-05-29 Thread Jakub Kicinski
On Tue, 29 May 2018 13:29:31 -0700, Andrey Ignatov wrote: > Add support for recently added BPF_CGROUP_UDP4_SENDMSG and > BPF_CGROUP_UDP6_SENDMSG attach types to bpftool, update documentation > and bash completion. > > Signed-off-by: Andrey Ignatov Reviewed-by: Jakub Kicinski > I'm not sure

[PATCH mlx5-next 2/2] net/mlx5: Add FPGA QP error event

2018-05-29 Thread Saeed Mahameed
From: Ilan Tayari The FPGA QP event fires whenever a QP on the FPGA trasitions to the error state. At this stage, this event is unrecoverable, it may become recoverable in the future. Signed-off-by: Ilan Tayari Signed-off-by: Adi Nissim Signed-off-by: Saeed Mahameed ---

[PATCH mlx5-next 1/2] net/mlx5: Add temperature warning event to log

2018-05-29 Thread Saeed Mahameed
From: Ilan Tayari Temperature warning event is sent by FW to indicate high temperature as detected by one of the sensors on the board. Add handling of this event by writing the numbers of the alert sensors to the kernel log. Signed-off-by: Ilan Tayari Signed-off-by: Adi Nissim Signed-off-by:

[PATCH mlx5-next 0/2] Mellanox, mlx5 new device events

2018-05-29 Thread Saeed Mahameed
Hi, The following series is for mlx5-next tree [1], it adds the support of two new device events, from Ilan Tayari: 1. High temperature warnings. 2. FPGA QP error event. In case of no objection this series will be applied to mlx5-next tree and will be sent later as a pull request to both rdma

Re: [PATCH bpf-next 11/11] bpf, doc: add missing patchwork url and libbpf to maintainers

2018-05-29 Thread Song Liu
On Sun, May 27, 2018 at 5:43 PM, Daniel Borkmann wrote: > Add missing bits under tools/lib/bpf/ and also Q: entry in order to > make it easier for people to retrieve current patch queue. > > Signed-off-by: Daniel Borkmann > Acked-by: Alexei Starovoitov Acked-by: Song Liu > --- >

RE: [PATCH rdma-next v2 01/13] IB/uverbs: Add an ib_uobject getter to ioctl() infrastructure

2018-05-29 Thread Ruhl, Michael J
>-Original Message- >From: Jason Gunthorpe [mailto:j...@mellanox.com] >Sent: Tuesday, May 29, 2018 4:21 PM >To: Ruhl, Michael J >Cc: Leon Romanovsky ; Doug Ledford >; Leon Romanovsky ; RDMA >mailing list ; Boris Pismenny >; Matan Barak ; Raed >Salem ; Yishai Hadas ; Saeed >Mahameed ;

Re: [PATCH net-next 0/7] net/ipv6: Fix route append and replace use cases

2018-05-29 Thread Thomas Winter
The only thing this breaks is adding IPv6 routes via ioctl. Previously they would be automatically appended to form multipath routes but this no longer occurs. Changing to netlink or use iproute2 and using NLM_F_APPEND gets around this. This basically what David Ahern said earlier but I wanted

[net-next 2/7] net/mlx5: FPGA, Add device name

2018-05-29 Thread Saeed Mahameed
From: Ilan Tayari Add device name for Mellanox FPGA devices. Signed-off-by: Ilan Tayari Signed-off-by: Adi Nissim Signed-off-by: Saeed Mahameed --- .../ethernet/mellanox/mlx5/core/fpga/cmd.h| 7 ++ .../ethernet/mellanox/mlx5/core/fpga/core.c | 24 --- 2 files

[net-next 3/7] net/mlx5: FPGA, print SBU identification on init

2018-05-29 Thread Saeed Mahameed
From: Ilan Tayari Add print of the following values on init: 1. ieee vendor id 2. sandbox product id 3. sandbox product version Signed-off-by: Ilan Tayari Signed-off-by: Adi Nissim Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/fpga/core.c | 7 +-- 1 file

[net-next 6/7] net/mlx5: FPGA, Call DMA unmap with the right size

2018-05-29 Thread Saeed Mahameed
From: Ilya Lesokhin When mlx5_fpga_conn_unmap_buf is called buf->sg[0].size should equal the actual buffer size, not the message size. Otherwise we will trigger the following dma debug warning "DMA-API: device driver frees DMA memory with different size" Fixes: 537a50574175 ('net/mlx5: FPGA,

[net-next 5/7] net/mlx5: FPGA, Properly initialize dma direction on fpga conn send

2018-05-29 Thread Saeed Mahameed
From: Ilya Lesokhin Properly initialize dma direction on fpga conn send. Do not rely on dma_dir == 0 (DMA_BIDIRECTIONAL). Signed-off-by: Ilya Lesokhin Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/fpga/conn.c | 1 + 1 file changed, 1 insertion(+) diff --git

[net-next 7/7] net/mlx5e: Get the number of offloaded TC rules from the correct table

2018-05-29 Thread Saeed Mahameed
From: Or Gerlitz As we keep the offloaded TC rules for NIC and e-switch in two different places, make sure to return the number of offloaded flows according to the use-case and not blindly from the priv. Fixes: 655dc3d2b91b ('net/mlx5e: Use shared table for offloaded TC eswitch flows')

[pull request][net-next 0/7] Mellanox, mlx5e & FPGA updates 2018-05-29

2018-05-29 Thread Saeed Mahameed
Hi Dave, The following series includes some minor FPGA and mlx5e netdev updates, for more information please see tag log below. Please pull and let me know if there's any problem. Note: This series doesn't include nor require any mlx5-next shared code and can be applied as is to net-next tree.

[net-next 4/7] net/mlx5: FPGA, Abort FPGA init if the device reports no QP capability

2018-05-29 Thread Saeed Mahameed
From: Yevgeny Kliteynik In the case that the reported max number of QPs capability equals to zero, abort FPGA init. Signed-off-by: Yevgeny Kliteynik Signed-off-by: Adi Nissim Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/fpga/core.c | 6 ++ 1 file changed, 6

[net-next 1/7] net/mlx5: FPGA, Add doxygen for access type enum

2018-05-29 Thread Saeed Mahameed
From: Ilan Tayari Add doxygen comments for enum mlx5_fpga_access_type. Signed-off-by: Ilan Tayari Signed-off-by: Adi Nissim Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/fpga/sdk.h | 6 ++ 1 file changed, 6 insertions(+) diff --git

Re: [PATCH mlx5-next 2/2] net/mlx5: Add FPGA QP error event

2018-05-29 Thread Andrew Lunn
On Tue, May 29, 2018 at 05:19:54PM -0700, Saeed Mahameed wrote: > From: Ilan Tayari > > The FPGA QP event fires whenever a QP on the FPGA trasitions > to the error state. FPGA i know, field programmable gate array. Could you offer some clue as to what QP means? Thanks Andrew

[PATCH bpf-next] bpftool: Support sendmsg{4,6} attach types

2018-05-29 Thread Andrey Ignatov
Add support for recently added BPF_CGROUP_UDP4_SENDMSG and BPF_CGROUP_UDP6_SENDMSG attach types to bpftool, update documentation and bash completion. Signed-off-by: Andrey Ignatov --- I'm not sure about "since 4.18" in Documentation part. I can follow-up when the next kernel version is known.

Re: [PATCH mlx5-next 1/3] net/mlx5: Exposing a new mini-CQE format

2018-05-29 Thread Saeed Mahameed
On Sun, 2018-05-27 at 13:42 +0300, Leon Romanovsky wrote: > From: Yonatan Cohen > > The new mini-CQE format includes byte-count, checksum > and stride index. > > Reviewed-by: Yishai Hadas > Reviewed-by: Guy Levi > Signed-off-by: Yonatan Cohen > Signed-off-by: Leon Romanovsky Applied to

Re: [PATCH mlx5-next 1/3] net/mlx5: Exposing a new mini-CQE format

2018-05-29 Thread Jason Gunthorpe
On Tue, May 29, 2018 at 03:01:27PM -0600, Saeed Mahameed wrote: > On Sun, 2018-05-27 at 13:42 +0300, Leon Romanovsky wrote: > > From: Yonatan Cohen > > > > The new mini-CQE format includes byte-count, checksum > > and stride index. > > > > Reviewed-by: Yishai Hadas > > Reviewed-by: Guy Levi >

Re: [PATCH bpf v2 0/5] fix test_sockmap

2018-05-29 Thread Prashant Bhole
On 5/30/2018 12:48 AM, John Fastabend wrote: On 05/27/2018 09:37 PM, Prashant Bhole wrote: This series fixes error handling, timeout and data verification in test_sockmap. Previously it was not able to detect failure/timeout in RX/TX thread because error was not notified to the main thread.

Re: [PATCH net-next 1/3] net: Add support to configure SR-IOV VF minimum and maximum queues.

2018-05-29 Thread Samudrala, Sridhar
On 5/29/2018 1:18 AM, Michael Chan wrote: VF Queue resources are always limited and there is currently no infrastructure to allow the admin. on the host to add or reduce queue resources for any particular VF. With ever increasing number of VFs being supported, it is desirable to allow the

Re: [PATCH rdma-next v2 01/13] IB/uverbs: Add an ib_uobject getter to ioctl() infrastructure

2018-05-29 Thread Jason Gunthorpe
On Tue, May 29, 2018 at 08:49:58PM +, Ruhl, Michael J wrote: > >From: Jason Gunthorpe [mailto:j...@mellanox.com] > >Sent: Tuesday, May 29, 2018 4:21 PM > >To: Ruhl, Michael J > >Cc: Leon Romanovsky ; Doug Ledford > >; Leon Romanovsky ; RDMA > >mailing list ; Boris Pismenny > >; Matan Barak ;

Re: [PATCH net-next 0/8] nfp: offload LAG for tc flower egress

2018-05-29 Thread Jiri Pirko
Tue, May 29, 2018 at 04:08:48PM CEST, john.hur...@netronome.com wrote: >On Sat, May 26, 2018 at 3:47 AM, Jakub Kicinski > wrote: >> On Fri, 25 May 2018 08:48:09 +0200, Jiri Pirko wrote: >>> Thu, May 24, 2018 at 04:22:47AM CEST, jakub.kicin...@netronome.com wrote: >>> >Hi! >>> > >>> >This series

Re: [PATCH bpf-next] bpftool: Support sendmsg{4,6} attach types

2018-05-29 Thread Song Liu
On Tue, May 29, 2018 at 2:20 PM, Jakub Kicinski wrote: > On Tue, 29 May 2018 13:29:31 -0700, Andrey Ignatov wrote: >> Add support for recently added BPF_CGROUP_UDP4_SENDMSG and >> BPF_CGROUP_UDP6_SENDMSG attach types to bpftool, update documentation >> and bash completion. >> >> Signed-off-by:

[PATCH net-next 0/3] net: Add support to configure SR-IOV VF queues.

2018-05-29 Thread Michael Chan
VF Queue resources are always limited and there is currently no infrastructure to allow the admin. on the host to add or reduce queue resources for any particular VF. This series adds the infrastructure to do that and adds the functionality to the bnxt_en driver. The "ip link set" command will

[PATCH net-next 2/3] bnxt_en: Store min/max tx/rx rings for individual VFs.

2018-05-29 Thread Michael Chan
With new infrastructure to configure queues differently for each VF, we need to store the current min/max rx/tx rings and other resources for each VF. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 9 + drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c

[PATCH net-next 3/3] bnxt_en: Implement .ndo_set_vf_queues().

2018-05-29 Thread Michael Chan
Implement .ndo_set_vf_queues() on the PF driver to configure the queues parameters for individual VFs. This allows the admin. on the host to increase or decrease queues for individual VFs. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 1 +

[PATCH net-next 1/3] net: Add support to configure SR-IOV VF minimum and maximum queues.

2018-05-29 Thread Michael Chan
VF Queue resources are always limited and there is currently no infrastructure to allow the admin. on the host to add or reduce queue resources for any particular VF. With ever increasing number of VFs being supported, it is desirable to allow the admin. to configure queue resources differently

Re: [PATCH rdma-next v1 11/13] IB/mlx5: Add flow counters binding support

2018-05-29 Thread Leon Romanovsky
On Mon, May 28, 2018 at 11:27:52AM -0600, Jason Gunthorpe wrote: > On Sun, May 27, 2018 at 01:23:44PM +0300, Leon Romanovsky wrote: > > > + if (!mcounters->hw_cntrs_hndl) { > > + mcounters->hw_cntrs_hndl = > > + (void > >

[no subject]

2018-05-29 Thread администратор
пользователь веб-почты Обратите внимание, что 95% ваших писем, полученных после последнего раза, когда вам нужно обновить сервер своей веб-почты в нашей базе данных, были отложены. Регулярно получать и отправлять свои сообщения. Техническая команда нашей электронной почты обновит вашу учетную

Re: [PATCH net-next 05/14] nfp: abm: add simple RED offload

2018-05-29 Thread Nogah Frankel
On 29-May-18 2:05 AM, Jakub Kicinski wrote: Hi Jakub, Hi Nogah! On Mon, 28 May 2018 18:49:51 +0300, Nogah Frankel wrote: +static int +nfp_abm_red_replace(struct net_device *netdev, struct nfp_abm_link *alink, + struct tc_red_qopt_offload *opt) +{ + struct nfp_port

Re: [PATCH bpf v2 0/5] fix test_sockmap

2018-05-29 Thread John Fastabend
On 05/29/2018 05:44 PM, Prashant Bhole wrote: > > > On 5/30/2018 12:48 AM, John Fastabend wrote: >> On 05/27/2018 09:37 PM, Prashant Bhole wrote: >>> This series fixes error handling, timeout and data verification in >>> test_sockmap. Previously it was not able to detect failure/timeout in >>>

[PATCH v5 net] stmmac: 802.1ad tag stripping fix

2018-05-29 Thread Elad Nachman
stmmac reception handler calls stmmac_rx_vlan() to strip the vlan before calling napi_gro_receive(). The function assumes VLAN tagged frames are always tagged with 802.1Q protocol, and assigns ETH_P_8021Q to the skb by hard-coding the parameter on call to __vlan_hwaccel_put_tag() . This causes

Re: [PATCH net-next 1/3] net: Add support to configure SR-IOV VF minimum and maximum queues.

2018-05-29 Thread Michael Chan
On Tue, May 29, 2018 at 1:46 PM, Samudrala, Sridhar wrote: > > Isn't ndo_set_vf_xxx() considered a legacy interface and not planned to be > extended? I didn't know about that. > Shouldn't we enable this via ethtool on the port representor netdev? > > We discussed about this. ethtool on the

Re: [PATCH V4] mlx4_core: allocate ICM memory in page size chunks

2018-05-29 Thread Eric Dumazet
On 05/25/2018 10:23 AM, David Miller wrote: > From: Qing Huang > Date: Wed, 23 May 2018 16:22:46 -0700 > >> When a system is under memory presure (high usage with fragments), >> the original 256KB ICM chunk allocations will likely trigger kernel >> memory management to enter slow path doing

Re: [net] vhost: Use kzalloc() to allocate vhost_msg_node

2018-05-29 Thread Guenter Roeck
On 05/29/2018 08:01 PM, Michael S. Tsirkin wrote: On Tue, May 29, 2018 at 03:19:08PM -0700, Guenter Roeck wrote: On Fri, Apr 27, 2018 at 11:45:02AM -0400, Kevin Easton wrote: The struct vhost_msg within struct vhost_msg_node is copied to userspace, so it should be allocated with kzalloc() to

Re: [PATCH V4] mlx4_core: allocate ICM memory in page size chunks

2018-05-29 Thread Eric Dumazet
On 05/29/2018 11:34 PM, Eric Dumazet wrote: > I will test : > > diff --git a/drivers/net/ethernet/mellanox/mlx4/icm.c > b/drivers/net/ethernet/mellanox/mlx4/icm.c > index > 685337d58276fc91baeeb64387c52985e1bc6dda..4d2a71381acb739585d662175e86caef72338097 > 100644 > ---

Re: [PATCH V4] mlx4_core: allocate ICM memory in page size chunks

2018-05-29 Thread Eric Dumazet
On 05/29/2018 11:44 PM, Eric Dumazet wrote: > > And I will add this simple fix, this really should address your initial > concern much better. > > @@ -99,6 +100,8 @@ static int mlx4_alloc_icm_pages(struct scatterlist *mem, > int order, > { > struct page *page; > > + if

[PATCH net] mlx4_core: restore optimal ICM memory allocation

2018-05-29 Thread Eric Dumazet
Commit 1383cb8103bb ("mlx4_core: allocate ICM memory in page size chunks") brought a regression caught in our regression suite, thanks to KASAN. Note that mlx4_alloc_icm() is already able to try high order allocations and fallback to low-order allocations under high memory pressure. We only have

Re: [PATCH bpf v2 0/5] fix test_sockmap

2018-05-29 Thread Prashant Bhole
On 5/30/2018 2:12 PM, John Fastabend wrote: On 05/29/2018 05:44 PM, Prashant Bhole wrote: On 5/30/2018 12:48 AM, John Fastabend wrote: On 05/27/2018 09:37 PM, Prashant Bhole wrote: This series fixes error handling, timeout and data verification in test_sockmap. Previously it was not able

[PATCH bpf v3 0/5] fix test_sockmap

2018-05-29 Thread Prashant Bhole
This series fixes error handling, timeout and data verification in test_sockmap. Previously it was not able to detect failure/timeout in RX/TX thread because error was not notified to the main thread. Also slightly improved test output by printing parameter values (cork, apply, start, end) so

[PATCH bpf v3 1/5] selftests/bpf: test_sockmap, check test failure

2018-05-29 Thread Prashant Bhole
Test failures are not identified because exit code of RX/TX threads is not checked. Also threads are not returning correct exit code. - Return exit code from threads depending on test execution status - In main thread, check the exit code of RX/TX threads - Skip error checking for corked tests as

Re: [PATCH net-next 1/3] net: Add support to configure SR-IOV VF minimum and maximum queues.

2018-05-29 Thread Jakub Kicinski
On Tue, 29 May 2018 20:19:54 -0700, Michael Chan wrote: > On Tue, May 29, 2018 at 1:46 PM, Samudrala, Sridhar wrote: > > Isn't ndo_set_vf_xxx() considered a legacy interface and not planned to be > > extended? +1 it's painful to see this feature being added to the legacy API :( Another

[PATCH bpf v3 3/5] selftests/bpf: test_sockmap, fix test timeout

2018-05-29 Thread Prashant Bhole
In order to reduce runtime of tests, recently timout for select() call was reduced from 1sec to 10usec. This was causing many tests failures. It was caught with failure handling commits in this series. Restoring the timeout from 10usec to 1sec Fixes: a18fda1a62c3 ("bpf: reduce runtime of

[PATCH bpf v3 4/5] selftests/bpf: test_sockmap, fix data verification

2018-05-29 Thread Prashant Bhole
When data verification is enabled, some tests fail because verification is done incorrectly. Following changes fix it. - Identify the size of data block to be verified - Reset verification counter when data block size is reached - Fixed the value printed in case of verfication failure Fixes:

[PATCH bpf v3 5/5] selftests/bpf: test_sockmap, print additional test options

2018-05-29 Thread Prashant Bhole
Print values of test options like apply, cork, start, end so that individual failed tests can be identified for manual run Acked-by: John Fastabend Signed-off-by: Prashant Bhole --- tools/testing/selftests/bpf/test_sockmap.c | 28 +++--- 1 file changed, 19 insertions(+), 9

[PATCH bpf v3 2/5] selftests/bpf: test_sockmap, join cgroup in selftest mode

2018-05-29 Thread Prashant Bhole
In case of selftest mode, temporary cgroup environment is created but cgroup is not joined. It causes test failures. Fixed by joining the cgroup Fixes: 16962b2404ac ("bpf: sockmap, add selftests") Acked-by: John Fastabend Signed-off-by: Prashant Bhole ---

Re: [PATCH net-next] net: remove bypassed check in sch_direct_xmit()

2018-05-29 Thread Sergei Shtylyov
Hello! On 5/29/2018 12:36 AM, Song Liu wrote: Check sch_direct_xmit() at the end of sch_direct_xmit() will be bypassed. "Checking netif_xmit_frozen_or_stopped()", perhaps? Else it doesn't make much sense... This is because "ret" from sch_direct_xmit() will be either NETDEV_TX_OK or

Re: [PATCH v3 11/11] net: sched: change action API to use array of pointers to actions

2018-05-29 Thread Vlad Buslov
On Mon 28 May 2018 at 21:31, Marcelo Ricardo Leitner wrote: > On Mon, May 28, 2018 at 12:17:29AM +0300, Vlad Buslov wrote: > ... >> -int tcf_action_destroy(struct list_head *actions, int bind) >> +int tcf_action_destroy(struct tc_action *actions[], int bind) >> { >> const struct

[PATCH bpf-next] bpf: clean up eBPF helpers documentation

2018-05-29 Thread Quentin Monnet
These are minor edits for the eBPF helpers documentation in include/uapi/linux/bpf.h. The main fix consists in removing "BPF_FIB_LOOKUP_", because it ends with a non-escaped underscore that gets interpreted by rst2man and produces the following message in the resulting manual page: DOCUTILS

[PATCH net-next 1/1] qed*: Add link change count value to ethtool statistics display.

2018-05-29 Thread Sudarsana Reddy Kalluru
This patch adds driver changes for capturing the link change count in ethtool statistics display. Please consider applying this to "net-next". Signed-off-by: Sudarsana Reddy Kalluru Signed-off-by: Ariel Elior --- drivers/net/ethernet/qlogic/qed/qed_l2.c| 12 ++--

Re: Unable to create ip alias on bridge interface

2018-05-29 Thread Michal Kubecek
On Tue, May 29, 2018 at 03:39:05PM +0530, Akshat Kakkar wrote: > For following commands, > ip addr add 10.10.10.1/24 brd + dev br0 > ip addr add 10.10.10.2/24 brd + dev br0 > ip addr add 20.20.20.1/24 brd + dev br0 > ip addr add 20.20.20.2/24 brd + dev br0 > > Both 10.10.10.1 and

Re: Unable to create ip alias on bridge interface

2018-05-29 Thread Michal Kubecek
On Mon, May 28, 2018 at 11:50:05PM +0530, Akshat Kakkar wrote: > 1. How can this survive across reboots without having a custom script > on boot up? Like some ifcfg file,etc. Every reasonable distribution should provide a way to use more than one address on an interface. But as there is no

Re: Unable to create ip alias on bridge interface

2018-05-29 Thread Akshat Kakkar
For following commands, ip addr add 10.10.10.1/24 brd + dev br0 ip addr add 10.10.10.2/24 brd + dev br0 ip addr add 20.20.20.1/24 brd + dev br0 ip addr add 20.20.20.2/24 brd + dev br0 Both 10.10.10.1 and 20.20.20.1 becomes primary. Which one will be used as source IP? Is it nextHop

Re: [PATCH v3 00/11] Modify action API for implementing lockless actions

2018-05-29 Thread Vlad Buslov
On Tue 29 May 2018 at 04:26, Cong Wang wrote: >> Currently, all netlink protocol handlers for updating rules, actions and >> qdiscs are protected with single global rtnl lock which removes any >> possibility for parallelism. This patch set is a first step to remove >> rtnl lock dependency from TC

Re: Unable to create ip alias on bridge interface

2018-05-29 Thread Akshat Kakkar
Thanks. Thanks a lot for clarifying all this. On Tue, May 29, 2018 at 3:59 PM, Michal Kubecek wrote: > On Tue, May 29, 2018 at 03:39:05PM +0530, Akshat Kakkar wrote: >> For following commands, >> ip addr add 10.10.10.1/24 brd + dev br0 >> ip addr add 10.10.10.2/24 brd + dev br0 >> ip

[PATCH net-next 5/5] net: aquantia: bump driver version

2018-05-29 Thread Igor Russkikh
Signed-off-by: Igor Russkikh --- drivers/net/ethernet/aquantia/atlantic/ver.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/aquantia/atlantic/ver.h b/drivers/net/ethernet/aquantia/atlantic/ver.h index a445de6..94efc64 100644 ---

Re: [PATCH net-next 00/14] nfp: abm: RED/MQ qdisc offload

2018-05-29 Thread David Miller
From: Jakub Kicinski Date: Fri, 25 May 2018 21:53:24 -0700 > This is second batch of advanced buffer management nfp driver > changes. This series adds the qdisc offload. Support for > a very simple subset of RED qdisc offload is added as needed > for DCTCP ECN marking (min and max thresholds

Re: [PATCH net] sctp: not allow to set rto_min with a value below 200 msecs

2018-05-29 Thread Neil Horman
On Mon, May 28, 2018 at 04:43:15PM -0300, Marcelo Ricardo Leitner wrote: > On Sat, May 26, 2018 at 09:01:00PM -0400, Neil Horman wrote: > > On Sat, May 26, 2018 at 05:50:39PM +0200, Dmitry Vyukov wrote: > > > On Sat, May 26, 2018 at 5:42 PM, Michael Tuexen > > > wrote: > > > >> On 25. May 2018,

Re: [PATCH bpf-next 06/11] bpf: add bpf_skb_cgroup_id helper

2018-05-29 Thread Quentin Monnet
Hi Daniel, 2018-05-28 02:43 UTC+0200 ~ Daniel Borkmann > Add a new bpf_skb_cgroup_id() helper that allows to retrieve the > cgroup id from the skb's socket. This is useful in particular to > enable bpf_get_cgroup_classid()-like behavior for cgroup v1 in > cgroup v2 by allowing ID based matching

[PATCH rdma-next v2 08/13] IB/core: Add support for flow counters

2018-05-29 Thread Leon Romanovsky
From: Raed Salem A counters object could be attached to flow on creation by providing the counter specification action. General counters description which count packets and bytes are introduced, downstream patches from this series will use them as part of flow counters binding. In addition,

[PATCH rdma-next v2 05/13] IB/core: Introduce counters read verb

2018-05-29 Thread Leon Romanovsky
From: Raed Salem The user supplies counters instance and a reference to an output array of uint64_t. The driver reads the hardware counters values and writes them to the output index location in the user supplied array. All counters values are represented as uint64_t types. To be able to

[PATCH mlx5-next v2 02/13] net/mlx5: Export flow counter related API

2018-05-29 Thread Leon Romanovsky
From: Raed Salem Exports counters API to be used in both IB and EN. Tested-by: Michael Guralnik Reviewed-by: Yishai Hadas Signed-off-by: Raed Salem Signed-off-by: Leon Romanovsky --- drivers/net/ethernet/mellanox/mlx5/core/fs_core.h | 23 --

[PATCH rdma-next v2 13/13] IB/mlx5: Add counters read support

2018-05-29 Thread Leon Romanovsky
From: Raed Salem This patch implements the uverbs counters read API, it will use the specific read counters function to the given type to accomplish its task. Tested-by: Michael Guralnik Reviewed-by: Yishai Hadas Signed-off-by: Raed Salem Signed-off-by: Leon Romanovsky ---

[PATCH net-next 4/5] net: aquantia: Add renegotiate ethtool operation support

2018-05-29 Thread Igor Russkikh
From: Anton Mikaev Adds ethtool -r|--negotiate operation support. It triggers special control bit on FW interface causing FW to restart link negotiation. Signed-off-by: Igor Russkikh Signed-off-by: Anton Mikaev --- .../net/ethernet/aquantia/atlantic/aq_ethtool.c| 14 +

[PATCH net-next 3/5] net: aquantia: Implement rx/tx flow control ethtools callback

2018-05-29 Thread Igor Russkikh
Runtime change of pause frame configuration (rx/tx flow control) via ethtool. Signed-off-by: Igor Russkikh --- .../net/ethernet/aquantia/atlantic/aq_ethtool.c| 42 ++ drivers/net/ethernet/aquantia/atlantic/aq_nic.c| 6 +++-

Re: [PATCH net] sctp: not allow to set rto_min with a value below 200 msecs

2018-05-29 Thread Michael Tuexen
> On 29. May 2018, at 13:41, Neil Horman wrote: > > On Mon, May 28, 2018 at 04:43:15PM -0300, Marcelo Ricardo Leitner wrote: >> On Sat, May 26, 2018 at 09:01:00PM -0400, Neil Horman wrote: >>> On Sat, May 26, 2018 at 05:50:39PM +0200, Dmitry Vyukov wrote: On Sat, May 26, 2018 at 5:42 PM,

[PATCH net-next 2/5] net: aquantia: Improve adapter init/deinit logic

2018-05-29 Thread Igor Russkikh
We now pass link drop status to FW on init/deinit. This is required to inform FW that driver took/released a control on link. FW then will manage its own state and device power profile based on this information. To improve management we remove mpi_set function which ambiguously took both state and

[PATCH net-next 0/5] net: aquantia: various ethtool ops implementation

2018-05-29 Thread Igor Russkikh
In this patchset Anton Mikaev and I added some useful ethtool operations: - ring size changes - link renegotioation - flow control management The patch also improves init/deinit sequence. Igor Russkikh (5): net: aquantia: Ethtool based ring size configuration net: aquantia: Improve adapter

[PATCH net-next 1/5] net: aquantia: Ethtool based ring size configuration

2018-05-29 Thread Igor Russkikh
From: Anton Mikaev Implemented ring size setup, min/max validation and reconfiguration in runtime. NIC level lock is used to prevent collisions on parallel reconfiguration and interference with periodic service timer job. Signed-off-by: Anton Mikaev Signed-off-by: Igor Russkikh ---

[PATCH rdma-next v2 09/13] IB/uverbs: Add support for flow counters

2018-05-29 Thread Leon Romanovsky
From: Raed Salem The struct ib_uverbs_flow_spec_action_count associates a counters object with the flow. Post this association the flow counters can be read via the counters object. Tested-by: Michael Guralnik Reviewed-by: Yishai Hadas Signed-off-by: Raed Salem Signed-off-by: Leon

[PATCH rdma-next v2 12/13] IB/mlx5: Add flow counters read support

2018-05-29 Thread Leon Romanovsky
From: Raed Salem Implements the flow counters read wrapper. Tested-by: Michael Guralnik Reviewed-by: Yishai Hadas Signed-off-by: Raed Salem Signed-off-by: Leon Romanovsky --- drivers/infiniband/hw/mlx5/main.c| 15 +++ drivers/infiniband/hw/mlx5/mlx5_ib.h | 13 -

[PATCH rdma-next v2 06/13] IB/uverbs: Add read counters support

2018-05-29 Thread Leon Romanovsky
From: Raed Salem This patch exposes the read counters verb to user space applications. By that verb the user can read the hardware counters which are associated with the counters object. The application needs to provide a sufficient memory to hold the statistics. Tested-by: Michael Guralnik

[PATCH rdma-next v2 03/13] IB/core: Introduce counters object and its create/destroy

2018-05-29 Thread Leon Romanovsky
From: Raed Salem A verbs application may need to get statistics and info on various aspects of a verb object (e.g. Flow, QP, ...), in general case the application will state which object's counters its interested in (we refer to this action as attach), bind this new counters object to the

[PATCH mlx5-next v2 11/13] IB/mlx5: Add flow counters binding support

2018-05-29 Thread Leon Romanovsky
From: Raed Salem Associates a counters with a flow when IB_FLOW_SPEC_ACTION_COUNT is part of the flow specifications. The counters user space placements of location and description (index, description) pairs are passed as private data of the counters flow specification. Tested-by: Michael

[PATCH rdma-next v2 10/13] IB/mlx5: Add counters create and destroy support

2018-05-29 Thread Leon Romanovsky
From: Raed Salem This patch implements the device counters create and destroy APIs and introducing some internal management structures. Downstream patches in this series will add the functionality to support flow counters binding and reading. Tested-by: Michael Guralnik Reviewed-by: Yishai

  1   2   >