Re: [PATCH rdma-next v1 0/7] Preparation to DevX extension series

2018-09-20 Thread Or Gerlitz
On Thu, Sep 20, 2018 at 9:35 PM, Leon Romanovsky wrote: > From: Leon Romanovsky > Set uid as part of various IB commands so that the firmware can manage > the IB object in a secured way. This series deals with FS core and commands used by the Ethernet driver > net/mlx5: Update mlx5_ifc with

Re: [PATCH net-next] net/tls: Add support for async encryption of records for performance

2018-09-20 Thread David Miller
From: Vakul Garg Date: Wed, 19 Sep 2018 20:51:35 +0530 > This patch enables encryption of multiple records in parallel when an > async capable crypto accelerator is present in system. This seems to be trading off zero copy with async support. Async crypto device support is not the common case

Re: [PATCH net] sctp: update dst pmtu with the correct daddr

2018-09-20 Thread David Miller
From: Xin Long Date: Thu, 20 Sep 2018 17:27:28 +0800 > When processing pmtu update from an icmp packet, it calls .update_pmtu > with sk instead of skb in sctp_transport_update_pmtu. > > However for sctp, the daddr in the transport might be different from > inet_sock->inet_daddr or

Re: [PATCH net] af_key: free SKBs under RCU protection

2018-09-20 Thread stranche
I do not believe the changelog or the patch makes sense. Having skb still referencing a socket prevents this socket being released. If you think about it, what would prevent the freeing happening _before_ the rcu_read_lock() in pfkey_broadcast() ? Maybe the correct fix is that

[PATCH mlx5-next v1 2/7] net/mlx5: Set uid as part of QP commands

2018-09-20 Thread Leon Romanovsky
From: Yishai Hadas Set uid as part of QP commands so that the firmware can manage the QP object in a secured way. That will enable using a QP that was created by verbs application to be used by the DEVX flow in case the uid is equal. Signed-off-by: Yishai Hadas Signed-off-by: Leon Romanovsky

[PATCH mlx5-next v1 7/7] net/mlx5: Update mlx5_ifc with DEVX UID bits

2018-09-20 Thread Leon Romanovsky
From: Leon Romanovsky Add DEVX information to WQ, SRQ, CQ, TRI, TIS, QP, RQ, XRCD, PD, MKEY and MCG. Signed-off-by: Leon Romanovsky --- include/linux/mlx5/mlx5_ifc.h | 67 +++ 1 file changed, 43 insertions(+), 24 deletions(-) diff --git

[PATCH rdma-next v1 0/7] Preparation to DevX extension series

2018-09-20 Thread Leon Romanovsky
From: Leon Romanovsky Changelog v0->v1: * Update commit messages * Split DevX series to small sub-series. * Change static initialization from {0} to be {} --- From Yishai, Set uid as part of various IB commands so that the firmware can manage the IB object in a secured way. The

[PATCH mlx5-next v1 1/7] net/mlx5: Set uid as part of CQ commands

2018-09-20 Thread Leon Romanovsky
From: Yishai Hadas Set uid as part of CQ commands so that the firmware can manage the CQ object in a secured way. The firmware should mark this CQ with the given uid so that it can be used later on only by objects with the same uid. Upon DEVX flows that use this CQ (e.g. create QP command),

[PATCH mlx5-next v1 3/7] net/mlx5: Set uid as part of RQ commands

2018-09-20 Thread Leon Romanovsky
From: Yishai Hadas Set uid as part of RQ commands so that the firmware can manage the RQ object in a secured way. That will enable using an RQ that was created by verbs application to be used by the DEVX flow in case the uid is equal. Signed-off-by: Yishai Hadas Signed-off-by: Leon Romanovsky

[PATCH mlx5-next v1 4/7] net/mlx5: Set uid as part of SQ commands

2018-09-20 Thread Leon Romanovsky
From: Yishai Hadas Set uid as part of SQ commands so that the firmware can manage the SQ object in a secured way. That will enable using an SQ that was created by verbs application to be used by the DEVX flow in case the uid is equal. Signed-off-by: Yishai Hadas Signed-off-by: Leon Romanovsky

[PATCH mlx5-next v1 5/7] net/mlx5: Set uid as part of SRQ commands

2018-09-20 Thread Leon Romanovsky
From: Yishai Hadas Set uid as part of SRQ commands so that the firmware can manage the SRQ object in a secured way. That will enable using an SRQ that was created by verbs application to be used by the DEVX flow in case the uid is equal. Signed-off-by: Yishai Hadas Signed-off-by: Leon

[PATCH mlx5-next v1 6/7] net/mlx5: Set uid as part of DCT commands

2018-09-20 Thread Leon Romanovsky
From: Yishai Hadas Set uid as part of DCT commands so that the firmware can manage the DCT object in a secured way. That will enable using a DCT that was created by verbs application to be used by the DEVX flow in case the uid is equal. Signed-off-by: Yishai Hadas Signed-off-by: Leon

IT Decision Makers Across the Globe

2018-09-20 Thread beverly . bruce
Hello, Hope all is well! We are a database organization. We provide business executives' contact information. Below, I've included a few examples: Industry-Specific Lists: Agriculture, Business Services, Chambers of Commerce, Cities, Towns & Municipalities, Construction, Consumer

Re: [PATCH mlx5-next v1 7/7] net/mlx5: Update mlx5_ifc with DEVX UID bits

2018-09-20 Thread Or Gerlitz
On Thu, Sep 20, 2018 at 9:35 PM, Leon Romanovsky wrote: > Add DEVX information to WQ, SRQ, CQ, TRI, TIS, QP, > RQ, XRCD, PD, MKEY and MCG. typo - TRI --> TIR "DEVX information" is a bit cryptic - what does xxx_valid means for the devx use case (fw command is issued by devx process) - and what

Re: [PATCH net] ixgbe: check return value of napi_complete_done()

2018-09-20 Thread Jeff Kirsher
On Thu, 2018-09-20 at 13:35 -0700, Eric Dumazet wrote: > On 09/20/2018 12:01 PM, Song Liu wrote: > > The NIC driver should only enable interrupts when napi_complete_done() > > returns true. This patch adds the check for ixgbe. > > > > Cc: sta...@vger.kernel.org # 4.10+ > > Cc: Jeff Kirsher > >

Re: [PATCH net] ixgbe: check return value of napi_complete_done()

2018-09-20 Thread Eric Dumazet
On 09/20/2018 12:01 PM, Song Liu wrote: > The NIC driver should only enable interrupts when napi_complete_done() > returns true. This patch adds the check for ixgbe. > > Cc: sta...@vger.kernel.org # 4.10+ > Cc: Jeff Kirsher > Suggested-by: Eric Dumazet > Signed-off-by: Song Liu > ---

[PATCH net-next v2] net: phy: don't reschedule state machine when PHY is halted

2018-09-20 Thread Heiner Kallweit
When being in state PHY_HALTED we don't have to reschedule the state machine, phy_start() will start it again. Signed-off-by: Heiner Kallweit --- v2: - added comment --- drivers/net/phy/phy.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/net/phy/phy.c

[PATCH net] ixgbe: check return value of napi_complete_done()

2018-09-20 Thread Song Liu
The NIC driver should only enable interrupts when napi_complete_done() returns true. This patch adds the check for ixgbe. Cc: sta...@vger.kernel.org # 4.10+ Cc: Jeff Kirsher Suggested-by: Eric Dumazet Signed-off-by: Song Liu --- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 12 +++-

Re: [PATCH mlx5-next v1 7/7] net/mlx5: Update mlx5_ifc with DEVX UID bits

2018-09-20 Thread Or Gerlitz
On Thu, Sep 20, 2018 at 9:35 PM, Leon Romanovsky wrote: > From: Leon Romanovsky > > Add DEVX information to WQ, SRQ, CQ, TRI, TIS, QP, > RQ, XRCD, PD, MKEY and MCG. > > Signed-off-by: Leon Romanovsky > --- > include/linux/mlx5/mlx5_ifc.h | 67 > +++ > 1

[PATCH net-next 1/3] bnx2x: Add VF spoof-checking configuration

2018-09-20 Thread Shahed Shaikh
Add support for `ndo_set_vf_spoofchk' to allow PF control over its VF spoof-checking configuration. Signed-off-by: Shahed Shaikh Signed-off-by: Ariel Elior --- drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h | 1 + drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 1 +

[PATCH net-next 2/3] bnx2x: Ignore bandwidth attention in single function mode

2018-09-20 Thread Shahed Shaikh
From: Shahed Shaikh This is a workaround for FW bug - MFW generates bandwidth attention in single function mode, which is only expected to be generated in multi function mode. This undesired attention in SF mode results in incorrect HW configuration and resulting into Tx timeout. Signed-off-by:

[PATCH net-next 3/3] bnx2x: Provide VF link status in ndo_get_vf_config

2018-09-20 Thread Shahed Shaikh
From: Shahed Shaikh Provide current link status of VF in ndo_get_vf_config handler. Signed-off-by: Shahed Shaikh Signed-off-by: Ariel Elior --- drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH net] netlabel: check for IPV4MASK in addrinfo_get

2018-09-20 Thread Sean Tranchetti
netlbl_unlabel_addrinfo_get() assumes that if it finds the NLBL_UNLABEL_A_IPV4ADDR attribute, it must also have the NLBL_UNLABEL_A_IPV4MASK attribute as well. However, this is not necessarily the case as the current checks in netlbl_unlabel_staticadd() and friends are not sufficent to enforce

[PATCH net-next 0/3] bnx2x: enhancements

2018-09-20 Thread Shahed Shaikh
From: Shahed Shaikh Hi Dave, This series adds below changes - - support for VF spoof-check configuration through .ndo_set_vf_spoofchk. - workaround for MFW bug regarding unexpected bandwidth notifcation in single function mode. - supply VF link status as part of get VF config handling.

[PATCH net] r8169: fix autoneg issue on resume with RTL8168E

2018-09-20 Thread Heiner Kallweit
It was reported that chip version 33 (RTL8168E) ends up with 10MBit/Half on a 1GBit link after resuming from S3 (with different link partners). For whatever reason the PHY on this chip doesn't properly start a renegotiation when soft-reset. Explicitly requesting a renegotiation fixes this.

[PATCH net-next v2] net/tls: Add support for async encryption of records for performance

2018-09-20 Thread Vakul Garg
In current implementation, tls records are encrypted & transmitted serially. Till the time the previously submitted user data is encrypted, the implementation waits and on finish starts transmitting the record. This approach of encrypt-one record at a time is inefficient when asynchronous crypto

Re: [PATCH net-next 0/5] vrf: allow simultaneous service instances in default and other VRFs

2018-09-20 Thread David Ahern
On 9/20/18 1:58 AM, Mike Manning wrote: > Services currently have to be VRF-aware if they are using an unbound > socket. One cannot have multiple service instances running in the > default and other VRFs for services that are not VRF-aware and listen > on an unbound socket. This is because there

答复: [PATCH][next-next][v2] netlink: avoid to allocate full skb when sending to many devices

2018-09-20 Thread Li,Rongqing
: Re: [PATCH][next-next][v2] netlink: avoid to allocate full skb when > sending to many devices > > > > On 09/20/2018 06:43 AM, Eric Dumazet wrote: > > > Sorry, I should cc to you. > > And lastly this patch looks way too complicated to me. > > You probably can write something much simpler. >

Re: [PATCH net] ixgbe: check return value of napi_complete_done()

2018-09-20 Thread Song Liu
> On Sep 20, 2018, at 2:01 PM, Jeff Kirsher wrote: > > On Thu, 2018-09-20 at 13:35 -0700, Eric Dumazet wrote: >> On 09/20/2018 12:01 PM, Song Liu wrote: >>> The NIC driver should only enable interrupts when napi_complete_done() >>> returns true. This patch adds the check for ixgbe. >>> >>>

Re: array bounds warning in xfrm_output_resume

2018-09-20 Thread David Ahern
On 9/20/18 7:06 AM, Florian Westphal wrote: > David Ahern wrote: >>> $ make O=kbuild/perf -j 24 -s >>> In file included from /home/dsa/kernel-3.git/include/linux/kernel.h:10:0, >>> from /home/dsa/kernel-3.git/include/linux/list.h:9, >>> from

Re: [PATCH net] ixgbe: check return value of napi_complete_done()

2018-09-20 Thread Eric Dumazet
On 09/20/2018 03:42 PM, Song Liu wrote: > > >> On Sep 20, 2018, at 2:01 PM, Jeff Kirsher >> wrote: >> >> On Thu, 2018-09-20 at 13:35 -0700, Eric Dumazet wrote: >>> On 09/20/2018 12:01 PM, Song Liu wrote: The NIC driver should only enable interrupts when napi_complete_done()

Re: [PATCH net] ixgbe: check return value of napi_complete_done()

2018-09-20 Thread Eric Dumazet
On 09/20/2018 04:43 PM, Song Liu wrote: > > I tried to totally skip ndo_poll_controller() here. It did avoid hitting > the issue. However, netpoll will drop (fail to send) more packets. > Why is it failing ? If you are under high memory pressure, then maybe if you absolutely want memory

[PATCH RESEND] PCI: hv: Fix return value check in hv_pci_assign_slots()

2018-09-20 Thread Wei Yongjun
In case of error, the function pci_create_slot() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Fixes: a15f2c08c708 ("PCI: hv: support reporting serial number as slot information") Signed-off-by: Wei Yongjun --- Since the orig

Re: [PATCH net] r8169: fix autoneg issue on resume with RTL8168E

2018-09-20 Thread David Miller
From: Heiner Kallweit Date: Thu, 20 Sep 2018 22:47:09 +0200 > It was reported that chip version 33 (RTL8168E) ends up with > 10MBit/Half on a 1GBit link after resuming from S3 (with different > link partners). For whatever reason the PHY on this chip doesn't > properly start a renegotiation when

Re: [PATCH bpf-next 2/3] bpf: emit RECORD_MMAP events for bpf prog load/unload

2018-09-20 Thread Alexei Starovoitov
On Thu, Sep 20, 2018 at 03:56:51PM +0200, Peter Zijlstra wrote: > On Thu, Sep 20, 2018 at 10:25:45AM -0300, Arnaldo Carvalho de Melo wrote: > > PeterZ provided a patch introducing PERF_RECORD_MUNMAP, went nowhere due > > to having to cope with munmapping parts of existing mmaps, etc. > > > > I'm

Re: [PATCH net] ixgbe: check return value of napi_complete_done()

2018-09-20 Thread Song Liu
> On Sep 20, 2018, at 4:22 PM, Eric Dumazet wrote: > > > > On 09/20/2018 03:42 PM, Song Liu wrote: >> >> >>> On Sep 20, 2018, at 2:01 PM, Jeff Kirsher >>> wrote: >>> >>> On Thu, 2018-09-20 at 13:35 -0700, Eric Dumazet wrote: On 09/20/2018 12:01 PM, Song Liu wrote: > The NIC

Re: [PATCH iproute2-next] iplink: add ipvtap support

2018-09-20 Thread David Ahern
On 9/18/18 8:03 PM, Hangbin Liu wrote: > IPVLAN and IPVTAP are using the same functions and parameters. So we can > just add a new link_util with id ipvtap. Others are the same. > > Signed-off-by: Hangbin Liu > --- > ip/iplink.c | 4 ++-- > ip/iplink_ipvlan.c| 28

[PATCH net] net/ipv6: Display all addresses in output of /proc/net/if_inet6

2018-09-20 Thread Jeff Barnhill
The backend handling for /proc/net/if_inet6 in addrconf.c doesn't properly handle starting/stopping the iteration. The problem is that at some point during the iteration, an overflow is detected and the process is subsequently stopped. The item being shown via seq_printf() when the overflow

Re: [PATCH net] af_key: free SKBs under RCU protection

2018-09-20 Thread Eric Dumazet
On 09/20/2018 03:10 PM, Eric Dumazet wrote: > > > On 09/20/2018 12:25 PM, stran...@codeaurora.org wrote: >>> >>> I do not believe the changelog or the patch makes sense. >>> >>> Having skb still referencing a socket prevents this socket being released. >>> >>> If you think about it, what

RE: [PATCH net-next] net/tls: Add support for async encryption of records for performance

2018-09-20 Thread Vakul Garg
> -Original Message- > From: David Miller > Sent: Thursday, September 20, 2018 11:49 PM > To: Vakul Garg > Cc: netdev@vger.kernel.org; bor...@mellanox.com; > avia...@mellanox.com; davejwat...@fb.com; doro...@fb.com > Subject: Re: [PATCH net-next] net/tls: Add support for async

Re: [PATCH net] af_key: free SKBs under RCU protection

2018-09-20 Thread Eric Dumazet
On 09/20/2018 12:25 PM, stran...@codeaurora.org wrote: >> >> I do not believe the changelog or the patch makes sense. >> >> Having skb still referencing a socket prevents this socket being released. >> >> If you think about it, what would prevent the freeing happening >> _before_ the

Re: [PATCH net] mpls: allow routes on ip6gre devices

2018-09-20 Thread David Miller
From: Saif Hasan Date: Wed, 19 Sep 2018 12:59:24 -0700 > @@ -1533,10 +1533,11 @@ static int mpls_dev_notify(struct > notifier_block *this, unsigned long event, > unsigned int flags; > > if (event == NETDEV_REGISTER) { > - /* For now just support Ethernet, IPGRE,

[PATCH net-next 00/13] mlxsw: Further MC-awareness configuration

2018-09-20 Thread Ido Schimmel
Petr says: Due to an issue in Spectrum chips, when unicast traffic shares the same queue as BUM traffic, and there is congestion, the BUM traffic is admitted to the queue anyway, thus pushing out all UC traffic. In order to give unicast traffic precedence over BUM traffic, multicast-aware mode is

Re: [PATCH net-next v2 08/10] net: sched: protect block idr with spinlock

2018-09-20 Thread Vlad Buslov
On Wed 19 Sep 2018 at 22:09, Cong Wang wrote: > On Mon, Sep 17, 2018 at 12:19 AM Vlad Buslov wrote: >> @@ -482,16 +483,25 @@ static int tcf_block_insert(struct tcf_block *block, >> struct net *net, >> struct netlink_ext_ack *extack) >> { >> struct tcf_net

Re: [PATCH net-next 1/2] r8169: simplify RTL8169 PHY initialization

2018-09-20 Thread David Miller
From: Heiner Kallweit Date: Wed, 19 Sep 2018 22:00:24 +0200 > PCI_LATENCY_TIMER is ignored on PCIe, therefore we have to do this > for the PCI chips (version <= 06) only. Also we can move setting > PCI_CACHE_LINE_SIZE. > > Signed-off-by: Heiner Kallweit Applied.

Re: [PATCH net-next 2/2] r8169: remove duplicated RTL8169s PHY initialization steps

2018-09-20 Thread David Miller
From: Heiner Kallweit Date: Wed, 19 Sep 2018 22:02:11 +0200 > Setting register 0x82 to value 01 is done a few lines before for all > chip versions <= 06 anyway. And setting PHY register 0x0b to value 00 > is done at the end of rtl8169s_hw_phy_config() already. So we can > remove this. > >

Re: [PATCH 0/2] net/sched: Add hardware specific counters to TC actions

2018-09-20 Thread Eelco Chaudron
On 29 Aug 2018, at 20:12, Jakub Kicinski wrote: On Wed, 29 Aug 2018 11:43:47 +0200, Eelco Chaudron wrote: On 23 Aug 2018, at 20:14, Jakub Kicinski wrote: On Mon, 20 Aug 2018 16:03:40 +0200, Eelco Chaudron wrote: On 17 Aug 2018, at 13:27, Jakub Kicinski wrote: On Thu, 16 Aug 2018

Re: [PATCH net] bnxt_en: don't try to offload VLAN 'modify' action

2018-09-20 Thread Sathya Perla
On Wed, Sep 19, 2018 at 10:31 PM Davide Caratti wrote: > > bnxt offload code currently supports only 'push' and 'pop' operation: let > .ndo_setup_tc() return -EOPNOTSUPP if VLAN 'modify' action is configured. > > Fixes: 2ae7408fedfe ("bnxt_en: bnxt: add TC flower filter offload support") >

[PATCH bpf-next] samples/bpf: fix compilation failure

2018-09-20 Thread Prashant Bhole
following commit: commit d58e468b1112 ("flow_dissector: implements flow dissector BPF hook") added struct bpf_flow_keys which conflicts with the struct with same name in sockex2_kern.c and sockex3_kern.c similar to commit: commit 534e0e52bc23 ("samples/bpf: fix a compilation failure") we tried

Re: [PATCH iproute2 v2 0/3] testsuite: make alltests fixes

2018-09-20 Thread Phil Sutter
Hi Petr, On Thu, Sep 20, 2018 at 01:36:21AM +0200, Petr Vorel wrote: > here are simply fixes to restore 'make alltests'. > Currently it does not run. Yeah, that testsuite definitely deserves some love. Just one nit: The one-line summary in Fixes: tags should be enclosed in quotes and parens,

Re: [PATCH net 0/3] qed: Fix series for multi-function mode implementation.

2018-09-20 Thread David Miller
From: Sudarsana Reddy Kalluru Date: Wed, 19 Sep 2018 21:59:09 -0700 > From: Sudarsana Reddy Kalluru > > The patch series addresses few issues in the switch dependent multi-function > modes. > Please consider applying it to 'net' tree. Series applied, thank you.

[PATCH net-next 05/13] mlxsw: spectrum_buffers: Allow pools of infinite size

2018-09-20 Thread Ido Schimmel
From: Petr Machata The MC pool should have an infinite size (i.e. no quota). To that end, add infi_size to the SBPR register and extend mlxsw_reg_sbpr_pack(). Also add MLXSW_SP_SB_INFI to denote buffers that should have an infinite size. Change mlxsw_sp_sb_pr_write() to take as parameter byte

[PATCH net-next 04/13] mlxsw: spectrum_buffers: Keep shared buffer size in mlxsw_sp_sb

2018-09-20 Thread Ido Schimmel
From: Petr Machata Entities of infinite size will be reported as if they had the maximum size allowed by the chip. To that end, keep track of maximum shared buffer size in mlxsw_sp->sb. Signed-off-by: Petr Machata Reviewed-by: Jiri Pirko Signed-off-by: Ido Schimmel ---

[PATCH net-next 02/13] mlxsw: spectrum_buffers: Use devlink pool indices throughout

2018-09-20 Thread Ido Schimmel
From: Petr Machata Currently, mlxsw assumes that each ingress pool has its egress counterpart, and that pool index for purposes of caching matches the index with which the hardware should be configured. As we want to expose the MC pool, both of these assumptions break. Instead, maintain the

[PATCH net-next 10/13] mlxsw: spectrum_buffers: Tweak SBMM configuration

2018-09-20 Thread Ido Schimmel
From: Petr Machata The SBMM register configures shared buffer allocation and settings for MC packets according to switch priority. The recommended values are no reserved buffer and alpha of 1/4, which corresponds to buf_max of 6. Update mlxsw_sp_sb_mms accordingly. Signed-off-by: Petr Machata

[PATCH net-next 09/13] mlxsw: spectrum_buffers: Configure MC pool

2018-09-20 Thread Ido Schimmel
From: Petr Machata Pool 15 (indexed as 8) is dedicated to MC traffic. Its configuration has been kept at default, because the table-based configuration wasn't expressive enough to allow the explicit configuration. Now that the configuration of pool 15 can be described, do so. The MC pool should

[PATCH net-next 06/13] mlxsw: spectrum_buffers: Allow an infinite maximum for per-TC pool limit

2018-09-20 Thread Ido Schimmel
From: Petr Machata The SBCM register configures the shared buffer configuration according to port and TC. So far all pools have had a dynamic size, where the infinite size is easy to express by using max_buff of 0xff. However the MC pool should be configured with static size, and the infinite

[PATCH net-next 11/13] selftests: forwarding: lib: Add ethtool_stats_get()

2018-09-20 Thread Ido Schimmel
From: Petr Machata Add a new service function to obtain ethtool counters. Signed-off-by: Petr Machata Reviewed-by: Jiri Pirko Signed-off-by: Ido Schimmel --- tools/testing/selftests/net/forwarding/lib.sh | 8 1 file changed, 8 insertions(+) diff --git

[PATCH net-next 13/13] selftests: mlxsw: Add a test for UC behavior under MC flood

2018-09-20 Thread Ido Schimmel
From: Petr Machata A so-called "MC-aware" mode has recently been enabled in mlxsw. In MC-aware mode, BUM traffic is handled in a special way so that when a switch is flooded with BUM, UC performance isn't unduly impacted. Without enablement of this mode, a stream of BUM traffic can cause

[PATCH net-next 01/13] mlxsw: spectrum: Init shaper for TCs 8..15

2018-09-20 Thread Ido Schimmel
From: Petr Machata With introduction of MC-aware mode to mlxsw, it became necessary to configure TCs above 7 as well. There is now code in mlxsw to disable ETS for these higher classes, but disablement of max shaper was neglected. By default, max shaper is currently disabled to begin with, so

[PATCH net-next 07/13] mlxsw: spectrum_buffers: Pass SBPM min_size in cells

2018-09-20 Thread Ido Schimmel
From: Petr Machata The SBPM register configures the shared buffer allocation and configuration per port and pool. The min_buff value is the buffer size dedicated to this single function, and is configured in cells. Currently, all sb_pm entries have 0 for min_buff, and therefore the actual unit

[PATCH net-next 08/13] mlxsw: spectrum_buffers: Allow configuration of static pools

2018-09-20 Thread Ido Schimmel
From: Petr Machata Some pools configured through the sb_pm entries may have by default static size. The MC pool is now not explicitly configured, however it gets configured as static implicitly by 0-initializing sb->prs, and a follow-up patch adds an explicit configuration to the same effect.

[PATCH net-next 03/13] mlxsw: spectrum_buffers: Split TC_COUNT into ingress and egress

2018-09-20 Thread Ido Schimmel
From: Petr Machata Current code assumes that ingress and egress has the same number of traffic classes. Since the introduction of MC-aware mode that assumption hasn't held anymore, and there have been 16 TCs on the egress as opposed to 8 on ingress. Break the assumption of symmetry by splitting

[PATCH] smc: generic netlink family should be __ro_after_init

2018-09-20 Thread Johannes Berg
From: Johannes Berg The generic netlink family is only initialized during module init, so it should be __ro_after_init like all other generic netlink families. Signed-off-by: Johannes Berg --- net/smc/smc_pnet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH rdma-next 2/5] net/smc: Use IB device index instead of name

2018-09-20 Thread Leon Romanovsky
From: Leon Romanovsky IB device name is not stable and will be possible to rename in the following patches, update SMC code to use IB index as a stable identification. Signed-off-by: Leon Romanovsky --- net/smc/smc_diag.c | 6 +++--- net/smc/smc_pnet.c | 27 --- 2

[PATCH rdma-next 1/5] RDMA/core: Provide getter and setter to access IB device name

2018-09-20 Thread Leon Romanovsky
From: Leon Romanovsky Prepare IB device name field to rename operation by ensuring that all accesses to it are protected with lock and users don't see part of name. The protection is done with global device_lock because it is used in allocation and deallocation phases. At this stage, this lock

[PATCH rdma-next 3/5] RDMA: Convert IB drivers to name allocation routine

2018-09-20 Thread Leon Romanovsky
From: Leon Romanovsky Move internal implementation of device name to the IB/core. Signed-off-by: Leon Romanovsky --- drivers/infiniband/core/device.c | 5 - drivers/infiniband/hw/bnxt_re/main.c | 6 +- drivers/infiniband/hw/cxgb3/iwch_provider.c| 5 -

[PATCH rdma-next 4/5] RDMA/core: Implement IB device rename function

2018-09-20 Thread Leon Romanovsky
From: Leon Romanovsky Generic implementation of IB device rename function. Signed-off-by: Leon Romanovsky --- drivers/infiniband/core/core_priv.h | 1 + drivers/infiniband/core/device.c| 23 +++ 2 files changed, 24 insertions(+) diff --git

[PATCH rdma-next 5/5] RDMA/nldev: Allow IB device rename through RDMA netlink

2018-09-20 Thread Leon Romanovsky
From: Leon Romanovsky Provide an option to rename IB device name through RDMA netlink and limit it to users with ADMIN capability only. Signed-off-by: Leon Romanovsky --- drivers/infiniband/core/nldev.c | 33 + include/uapi/rdma/rdma_netlink.h | 3 ++- 2

[PATCH rdma-next 0/5] IB device rename support

2018-09-20 Thread Leon Romanovsky
From: Leon Romanovsky Hi, This series introduce long-waiting feature - "IB device rename". Such feature gives and option to rename user visible IB device name from vendor specific name (e.g. mlx5_0) to anything else. The user space component through rdmatool will follow this series.

[RFC PATCH iproute2-next 0/3] rdma: IB device rename

2018-09-20 Thread Leon Romanovsky
From: Leon Romanovsky Hi, This is comprehensive part of kernel series posted earlier. The kernel part is not accepted yet, so first patch will have different commit message with different commit SHA1. This is why it is marked as RFC. An example: [leonro@server /]$ lspci |grep -i Ether 00:08.0

[RFC PATCH iproute2-next 2/3] rdma: Introduce command execution helper with required device name

2018-09-20 Thread Leon Romanovsky
From: Leon Romanovsky In contradiction to various show commands, the set command explicitly requires to use device name as an argument. Provide new command execution helper which enforces it. Signed-off-by: Leon Romanovsky --- rdma/rdma.h | 1 + rdma/utils.c | 10 ++ 2 files

[RFC PATCH iproute2-next 1/3] rdma: Update kernel include file to support IB device renaming

2018-09-20 Thread Leon Romanovsky
From: Leon Romanovsky Bring kernel header file changes upto commit 908b44308eda ("RDMA/nldev: Allow IB device rename through RDMA netlink") Signed-off-by: Leon Romanovsky --- rdma/include/uapi/rdma/rdma_netlink.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[RFC PATCH iproute2-next 3/3] rdma: Add an option to rename IB device interface

2018-09-20 Thread Leon Romanovsky
From: Leon Romanovsky Enrich rdmatool with an option to rename IB devices, the command interface follows Iproute2 convention: "rdma dev set [OLD-DEVNAME] name NEW-DEVNAME" Signed-off-by: Leon Romanovsky --- rdma/dev.c | 35 +++ 1 file changed, 35 insertions(+)

[PATCH][next-next][v2] netlink: avoid to allocate full skb when sending to many devices

2018-09-20 Thread Li RongQing
if skb->head is vmalloc address, when this skb is delivered, full allocation for this skb is required, if there are many devices, the full allocation will be called for every devices now if it is vmalloc, allocate a new skb, whose data is not vmalloc address, and use new allocated skb to clone

[PATCH 2/3] net: Register af_inet_ops earlier

2018-09-20 Thread Kirill Tkhai
This function just initializes locks and defaults. Let register it before other pernet operation, since some of them potentially may relay on that. Signed-off-by: Kirill Tkhai --- net/ipv4/af_inet.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/ipv4/af_inet.c

[PATCH net-next 0/3] Refactorings on af_inet pernet initialization

2018-09-20 Thread Kirill Tkhai
This patch set makes several cleanups around inet_init_net(). --- Cong Wang (1): ipv4: initialize ra_mutex in inet_init_net() Kirill Tkhai (2): net: Remove inet_exit_net() net: Register af_inet_ops earlier net/core/net_namespace.c |1 - net/ipv4/af_inet.c | 13

[PATCH 3/3] ipv4: initialize ra_mutex in inet_init_net()

2018-09-20 Thread Kirill Tkhai
From: Cong Wang ra_mutex is a IPv4 specific mutex, it is inside struct netns_ipv4, but its initialization is in the generic netns code, setup_net(). Move it to IPv4 specific net init code, inet_init_net(). Fixes: d9ff3049739e ("net: Replace ip_ra_lock with per-net mutex") Signed-off-by: Cong

Re: [PATCH bpf-next 2/3] bpf: emit RECORD_MMAP events for bpf prog load/unload

2018-09-20 Thread Peter Zijlstra
On Wed, Sep 19, 2018 at 03:39:34PM -0700, Alexei Starovoitov wrote: > void bpf_prog_kallsyms_del(struct bpf_prog *fp) > { > + unsigned long symbol_start, symbol_end; > + /* mmap_record.filename cannot be NULL and has to be u64 aligned */ > + char buf[sizeof(u64)] = {}; > + > if

[PATCH 1/3] net: Remove inet_exit_net()

2018-09-20 Thread Kirill Tkhai
This function does nothing, and since ops_exit_list() checks for NULL ->exit method, we do not need stub here. Signed-off-by: Kirill Tkhai --- net/ipv4/af_inet.c |5 - 1 file changed, 5 deletions(-) diff --git a/net/ipv4/af_inet.c b/net/ipv4/af_inet.c index 1fbe2f815474..f4ecbe0aaf1a

[PATCH net] mlxsw: spectrum: Bump required firmware version

2018-09-20 Thread Ido Schimmel
From: Petr Machata MC-aware mode was introduced to mlxsw in commit 7b8195306694 ("mlxsw: spectrum: Configure MC-aware mode on mlxsw ports") and fixed up later in commit 3a3539cd3632 ("mlxsw: spectrum_buffers: Set up a dedicated pool for BUM traffic"). As the final piece of puzzle, a firmware

Re: [PATCH net-next v2 05/10] net: sched: use Qdisc rcu API instead of relying on rtnl lock

2018-09-20 Thread Vlad Buslov
On Wed 19 Sep 2018 at 22:04, Cong Wang wrote: > On Mon, Sep 17, 2018 at 12:19 AM Vlad Buslov wrote: >> +static void tcf_qdisc_put(struct Qdisc *q, bool rtnl_held) >> +{ >> + if (!q) >> + return; >> + >> + if (rtnl_held) >> + qdisc_put(q); >> + else

Re: [PATCH net-next] nfp: provide a better warning when ring allocation fails

2018-09-20 Thread David Miller
From: Jakub Kicinski Date: Wed, 19 Sep 2018 14:42:50 -0700 > NFP supports fairly enormous ring sizes (up to 256k descriptors). > In commit 466271703867 ("nfp: use kvcalloc() to allocate SW buffer > descriptor arrays") we have started using kvcalloc() functions to > make sure the allocation of

Re: [PATCH net-next] e1000: remove set but not used variable 'txb2b'

2018-09-20 Thread David Miller
From: YueHaibing Date: Thu, 20 Sep 2018 02:04:38 + > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/net/ethernet/intel/e1000/e1000_main.c: In function 'e1000_watchdog': > drivers/net/ethernet/intel/e1000/e1000_main.c:2436:9: warning: > variable 'txb2b' set but not used

Re: [PATCH] net: toshiba: remove a redundant local variable 'index_specified'

2018-09-20 Thread David Miller
From: zhong jiang Date: Thu, 20 Sep 2018 09:56:05 +0800 > The local variable 'index_specified' is never used after being assigned. > hence it should be redundant adn can be removed. > > Signed-off-by: zhong jiang Applied.

Re: [PATCH net-next] atl1: remove set but not used variable 'advertising'

2018-09-20 Thread David Miller
From: YueHaibing Date: Thu, 20 Sep 2018 02:41:30 + > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/net/ethernet/atheros/atlx/atl1.c: In function > 'atl1_set_link_ksettings': > drivers/net/ethernet/atheros/atlx/atl1.c:3280:6: warning: > variable 'advertising' set but not used

[PATCH net-next 12/13] selftests: forwarding: lib: Add mtu_set(), mtu_restore()

2018-09-20 Thread Ido Schimmel
From: Petr Machata Some selftests need to tweak MTU of an interface, and naturally should at teardown restore the MTU back to the original value. Add two functions to facilitate this MTU handling: mtu_set() to change MTU value, and mtu_reset() to change it back to what it was before.

Re: [PATCH rdma-next 1/5] RDMA/core: Provide getter and setter to access IB device name

2018-09-20 Thread Steve Wise
On 9/20/2018 6:21 AM, Leon Romanovsky wrote: > From: Leon Romanovsky > > Prepare IB device name field to rename operation by ensuring that all > accesses to it are protected with lock and users don't see part of name. > > The protection is done with global device_lock because it is used in >

Re: [PATCH 00/21] SMMU enablement for NXP LS1043A and LS1046A

2018-09-20 Thread Laurentiu Tudor
On 20.09.2018 14:49, Robin Murphy wrote: > On 20/09/18 11:38, Laurentiu Tudor wrote: >> >> >> On 19.09.2018 17:37, Robin Murphy wrote: >>> On 19/09/18 15:18, Laurentiu Tudor wrote: Hi Robin, On 19.09.2018 16:25, Robin Murphy wrote: > Hi Laurentiu, > > On 19/09/18

Re: [PATCH bpf-next 2/2] xsk: fix bug when trying to use both copy and zero-copy on one queue id

2018-09-20 Thread Jakub Kicinski
On Thu, 20 Sep 2018 11:17:17 +0200, Magnus Karlsson wrote: > On Wed, Sep 19, 2018 at 9:18 AM Magnus Karlsson wrote: > > On Wed, Sep 19, 2018 at 3:58 AM Jakub Kicinski wrote: > > > > > > On Tue, 18 Sep 2018 10:22:11 -0700, Y Song wrote: > > > > > +/* The umem is stored both in the _rx struct

Re: [PATCH net-next 00/13] mlxsw: Further MC-awareness configuration

2018-09-20 Thread David Miller
From: Ido Schimmel Date: Thu, 20 Sep 2018 09:21:23 +0300 > Petr says: > > Due to an issue in Spectrum chips, when unicast traffic shares the same > queue as BUM traffic, and there is congestion, the BUM traffic is > admitted to the queue anyway, thus pushing out all UC traffic. In order > to

Re: [PATCH net] mlxsw: spectrum: Bump required firmware version

2018-09-20 Thread David Miller
From: Ido Schimmel Date: Thu, 20 Sep 2018 09:31:45 +0300 > From: Petr Machata > > MC-aware mode was introduced to mlxsw in commit 7b8195306694 ("mlxsw: > spectrum: > Configure MC-aware mode on mlxsw ports") and fixed up later in commit > 3a3539cd3632 ("mlxsw: spectrum_buffers: Set up a

Re: [PATCH] smc: generic netlink family should be __ro_after_init

2018-09-20 Thread David Miller
From: Johannes Berg Date: Thu, 20 Sep 2018 09:27:30 +0200 > From: Johannes Berg > > The generic netlink family is only initialized during module init, > so it should be __ro_after_init like all other generic netlink > families. > > Signed-off-by: Johannes Berg Looks good, applied.

Re: [PATCH bpf-next 2/3] bpf: emit RECORD_MMAP events for bpf prog load/unload

2018-09-20 Thread Arnaldo Carvalho de Melo
Em Thu, Sep 20, 2018 at 10:44:24AM +0200, Peter Zijlstra escreveu: > On Wed, Sep 19, 2018 at 03:39:34PM -0700, Alexei Starovoitov wrote: > > void bpf_prog_kallsyms_del(struct bpf_prog *fp) > > { > > + unsigned long symbol_start, symbol_end; > > + /* mmap_record.filename cannot be NULL and

Re: [PATCH v3 net-next 07/12] net: ethernet: Add helper to remove a supported link mode

2018-09-20 Thread Andrew Lunn
> 1. net-next: cf7d97e1e54d ("net: mdio: remove duplicated include from > mdio_bus.c") > > # mii-tool -vv eth0 > Using SIOCGMIIPHY=0x8947 > eth0: no link > registers for MII PHY 0: > 1140 7949 0022 1622 0d81 c1e1 000f > 0300 3000 >

Re: [PATCH net-next 4/5] ipv6: do not drop vrf udp multicast packets

2018-09-20 Thread Paolo Abeni
Hi, On Thu, 2018-09-20 at 09:58 +0100, Mike Manning wrote: > diff --git a/net/ipv6/ip6_input.c b/net/ipv6/ip6_input.c > index 108f5f88ec98..fc60f297d95b 100644 > --- a/net/ipv6/ip6_input.c > +++ b/net/ipv6/ip6_input.c > @@ -325,9 +325,12 @@ static int ip6_input_finish(struct net *net, struct sock

Re: [PATCH net] af_key: free SKBs under RCU protection

2018-09-20 Thread Eric Dumazet
On 09/19/2018 05:18 PM, Sean Tranchetti wrote: > pfkey_broadcast() can make calls to pfkey_broadcast_one() which > will clone or copy the passed in SKB. This new SKB will be assigned > the sock_rfree() function as its destructor, which requires that > the socket reference the SKB contains is

Re: [PATCH RFT net-next 0/2] net: phy: Eliminate unnecessary soft

2018-09-20 Thread Andrew Lunn
On Tue, Sep 18, 2018 at 06:35:03PM -0700, Florian Fainelli wrote: > Hi all, > > This patch series eliminates unnecessary software resets of the PHY. > This should hopefully not break anybody's hardware; but I would > appreciate testing to make sure this is is the case. > > Sorry for this long

RE: [PATCH v2 1/5] netlink: remove NLA_NESTED_COMPAT

2018-09-20 Thread David Laight
From: Johannes Berg > Sent: 19 September 2018 20:49 > This isn't used anywhere, so we might as well get rid of it. > > Reviewed-by: David Ahern > Signed-off-by: Johannes Berg > --- > include/net/netlink.h | 2 -- > lib/nlattr.c | 11 --- > 2 files changed, 13 deletions(-) >

Re: [PATCH rdma-next 1/5] RDMA/core: Provide getter and setter to access IB device name

2018-09-20 Thread Jason Gunthorpe
On Thu, Sep 20, 2018 at 02:21:58PM +0300, Leon Romanovsky wrote: > From: Leon Romanovsky > > Prepare IB device name field to rename operation by ensuring that all > accesses to it are protected with lock and users don't see part of name. Oh dear, no, that isn't going to work, there is too much

  1   2   >