Re: [PATCH v3 2/2] net: qcom/emac: add phy-handle support for ACPI

2018-10-26 Thread Andrew Lunn
On Fri, Oct 26, 2018 at 03:04:25AM +, Wang, Dongsheng wrote: > On 2018/10/26 10:37, Timur Tabi wrote: > > On 10/25/18 9:18 PM, Wang, Dongsheng wrote: > >> But when I was reading Documentation/acpi/DSD-properties-rules.txt, my > >> understanding is we should try to conform to DT bindings. So

Re: [PATCH net] net: sched: Remove TCA_OPTIONS from policy

2018-10-26 Thread Marco Berizzi
> Il 24 ottobre 2018 alle 17.32 David Ahern ha scritto: > net/sched/sch_api.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/net/sched/sch_api.c b/net/sched/sch_api.c > index 3dc0acf54245..be7cd140b2a3 100644 > --- a/net/sched/sch_api.c > +++ b/net/sched/sch_api.c > @@ -1309,7 +1309,6

Re: [PATCH] igb: shorten maximum PHC timecounter update interval

2018-10-26 Thread Miroslav Lichvar
On Fri, Oct 12, 2018 at 07:05:30AM -0700, Richard Cochran wrote: > On Fri, Oct 12, 2018 at 01:13:39PM +0200, Miroslav Lichvar wrote: > > Since commit 500462a9d ("timers: Switch to a non-cascading wheel"), > > scheduling of delayed work seems to be less accurate and a requested > > delay of 540

Re: [PATCH v2 00/17] octeontx2-af: NPC parser and NIX blocks initialization

2018-10-26 Thread Arnd Bergmann
On 10/23/18, David Miller wrote: > From: sunil.kovv...@gmail.com > Date: Mon, 22 Oct 2018 23:25:47 +0530 > >> From: Sunil Goutham >> >> This patchset is a continuation to earlier submitted two patch >> series to add a new driver for Marvell's OcteonTX2 SOC's >> Resource virtualization unit (RVU)

Re: Fw: [Bug 201423] New: eth0: hw csum failure

2018-10-26 Thread Andre Tomt
On 26.10.2018 14:59, Eric Dumazet wrote: On Fri, Oct 26, 2018 at 5:38 AM Andre Tomt wrote: And it tripped again with that commit; however on another box with a much more complicated setup (VRFs, sch_cake, ifb, conntrack/nat, 6in4 tunnel, VF device on mlx4) [ 8197.348260] wanib: hw csum

Re: [PATCH net] ipv6/ndisc: Preserve IPv6 control buffer if protocol error handlers are called

2018-10-26 Thread Sabrina Dubroca
2018-10-24, 14:37:21 +0200, Stefano Brivio wrote: > Commit a61bbcf28a8c ("[NET]: Store skb->timestamp as offset to a base > timestamp") introduces a neighbour control buffer and zeroes it out in > ndisc_rcv(), as ndisc_recv_ns() uses it. > > Commit f2776ff04722 ("[IPV6]: Fix address/interface

Re: Fw: [Bug 201423] New: eth0: hw csum failure

2018-10-26 Thread Eric Dumazet
On Fri, Oct 26, 2018 at 5:38 AM Andre Tomt wrote: > > On 26.10.2018 13:45, Andre Tomt wrote: > > On 25.10.2018 19:38, Eric Dumazet wrote: > >> > >> > >> On 10/24/2018 12:41 PM, Andre Tomt wrote: > >>> > >>> It eventually showed up again with mlx4, on 4.18.16 + fix and also on > >>> 4.19. I still

Re: [PATCH v2 00/17] octeontx2-af: NPC parser and NIX blocks initialization

2018-10-26 Thread Arnd Bergmann
On Fri, Oct 26, 2018 at 5:47 PM Andrew Lunn wrote: > > > I fear that setting a precedent of using the mbox for user-level > > configuration management would mean that we would have to > > treat each of these interfaces as an ABI, which in turn requires > > much deeper review as well as raising

Re: [PATCH v2 00/17] octeontx2-af: NPC parser and NIX blocks initialization

2018-10-26 Thread Sunil Kovvuri
On Fri, Oct 26, 2018 at 6:24 PM Arnd Bergmann wrote: > > On 10/23/18, David Miller wrote: > > From: sunil.kovv...@gmail.com > > Date: Mon, 22 Oct 2018 23:25:47 +0530 > > > >> From: Sunil Goutham > >> > >> This patchset is a continuation to earlier submitted two patch > >> series to add a new

Re: [PATCH net] net: sched: Remove TCA_OPTIONS from policy

2018-10-26 Thread David Ahern
On 10/26/18 5:34 AM, Marco Berizzi wrote: > Apologies for bothering you again. > I applied your patch to 4.19, but after issuing this > command: > > root@Calimero:~# tc qdisc add dev eth0 root handle 1:0 hfsc default 1 > root@Calimero:~# ping 10.81.104.1 > PING 10.81.104.1 (10.81.104.1) 56(84)

Re: Fw: [Bug 201423] New: eth0: hw csum failure

2018-10-26 Thread Andre Tomt
On 26.10.2018 13:45, Andre Tomt wrote: On 25.10.2018 19:38, Eric Dumazet wrote: On 10/24/2018 12:41 PM, Andre Tomt wrote: It eventually showed up again with mlx4, on 4.18.16 + fix and also on 4.19. I still do not have a useful packet capture. It is running a torrent client serving up

[BPF] "padded" structures are not supported by BPF

2018-10-26 Thread Krishna Chaitanya
Hi, With below config BPF doesn't seem to support "padded" structures. Is this a bug or expected? Kernel Version: 4.15.0-34, Intel, Ubuntu. Below is the BPF JIT output. struct info { u16 seq_num; u32 packet_num; }; bpf: Failed to load program: Permission denied 0: (69) r1 =

Re: [PATCH v2 05/17] octeontx2-af: Config NPC KPU engines with parser profile

2018-10-26 Thread Arnd Bergmann
On 10/22/18, sunil.kovv...@gmail.com wrote: > From: Sunil Goutham > > +struct npc_kpu_action0 { > +#if defined(__BIG_ENDIAN_BITFIELD) > + u64 rsvd_63_57 : 7; > + u64 byp_count : 3; > + u64 capture_ena: 1; > + u64 parse_done : 1; > + u64 next_state : 8; >

Re: [PATCH v2 00/17] octeontx2-af: NPC parser and NIX blocks initialization

2018-10-26 Thread Arnd Bergmann
On 10/26/18, Sunil Kovvuri wrote: > On Fri, Oct 26, 2018 at 6:24 PM Arnd Bergmann wrote: >> >> I see this has been applied, but I'd still like to understand better how >> the >> configuration interface is expected to work once the driver is complete. >> >> In particular, so far the interfaces

Re: [PATCH v2 00/17] octeontx2-af: NPC parser and NIX blocks initialization

2018-10-26 Thread Andrew Lunn
> I fear that setting a precedent of using the mbox for user-level > configuration management would mean that we would have to > treat each of these interfaces as an ABI, which in turn requires > much deeper review as well as raising the fundamental question > on how this should be done across

RE: [PATCH] igb: shorten maximum PHC timecounter update interval

2018-10-26 Thread Keller, Jacob E
> -Original Message- > From: Miroslav Lichvar [mailto:mlich...@redhat.com] > Sent: Friday, October 26, 2018 5:04 AM > To: Richard Cochran > Cc: intel-wired-...@lists.osuosl.org; netdev@vger.kernel.org; Keller, Jacob E > ; Thomas Gleixner > Subject: Re: [PATCH] igb: shorten maximum PHC

RE: [RFC PATCH 0/4] More accurate PHC<->system clock synchronization

2018-10-26 Thread Keller, Jacob E
Hi Miroslav, > -Original Message- > From: Miroslav Lichvar [mailto:mlich...@redhat.com] > Sent: Friday, October 26, 2018 9:28 AM > To: netdev@vger.kernel.org > Cc: intel-wired-...@lists.osuosl.org; Richard Cochran > ; > Keller, Jacob E ; Miroslav Lichvar > > Subject: [RFC PATCH 0/4]

Re: [PATCH net] net: sched: Remove TCA_OPTIONS from policy

2018-10-26 Thread Jiri Pirko
Fri, Oct 26, 2018 at 06:02:01PM CEST, dsah...@gmail.com wrote: >On 10/25/18 12:31 AM, Jiri Pirko wrote: >> Wed, Oct 24, 2018 at 05:32:49PM CEST, dsah...@kernel.org wrote: >>> From: David Ahern >>> >>> Marco reported an error with hfsc: >>> root@Calimero:~# tc qdisc add dev eth0 root handle 1:0

Re: [PATCH net] bridge: do not add port to router list when receives query with source 0.0.0.0

2018-10-26 Thread nikolay
On 26 October 2018 05:28:43 EEST, Hangbin Liu wrote: >Based on RFC 4541, 2.1.1. IGMP Forwarding Rules > > The switch supporting IGMP snooping must maintain a list of > multicast routers and the ports on which they are attached. This > list can be constructed in any combination of the

Re: [PATCH v2 00/17] octeontx2-af: NPC parser and NIX blocks initialization

2018-10-26 Thread Sunil Kovvuri
On Fri, Oct 26, 2018 at 7:34 PM Arnd Bergmann wrote: > > On 10/26/18, Sunil Kovvuri wrote: > > On Fri, Oct 26, 2018 at 6:24 PM Arnd Bergmann wrote: > >> > >> I see this has been applied, but I'd still like to understand better how > >> the > >> configuration interface is expected to work once

RE: [RFC PATCH 0/4] More accurate PHC<->system clock synchronization

2018-10-26 Thread Keller, Jacob E
> -Original Message- > From: Miroslav Lichvar [mailto:mlich...@redhat.com] > Sent: Friday, October 26, 2018 9:28 AM > To: netdev@vger.kernel.org > Cc: intel-wired-...@lists.osuosl.org; Richard Cochran > ; > Keller, Jacob E ; Miroslav Lichvar > > Subject: [RFC PATCH 0/4] More accurate

Re: [PATCH net] net/neigh: fix NULL deref in pneigh_dump_table()

2018-10-26 Thread David Ahern
On 10/26/18 10:33 AM, Eric Dumazet wrote: > pneigh can have NULL device pointer, so we need to make hmmm.. missed that. > neigh_master_filtered() and neigh_ifindex_filtered() more robust. > ... > Fixes: 6f52f80e8530 ("net/neigh: Extend dump filter to proxy neighbor dumps") > Signed-off-by:

Re: [PATCH net] net: sched: Remove TCA_OPTIONS from policy

2018-10-26 Thread Cong Wang
On Fri, Oct 26, 2018 at 4:35 AM Marco Berizzi wrote: > Apologies for bothering you again. > I applied your patch to 4.19, but after issuing this > command: > > root@Calimero:~# tc qdisc add dev eth0 root handle 1:0 hfsc default 1 > root@Calimero:~# ping 10.81.104.1 > PING 10.81.104.1

RE: [RFC PATCH 4/4] ixgbe: add support for extended PHC gettime

2018-10-26 Thread Keller, Jacob E
> -Original Message- > From: Miroslav Lichvar [mailto:mlich...@redhat.com] > Sent: Friday, October 26, 2018 9:28 AM > To: netdev@vger.kernel.org > Cc: intel-wired-...@lists.osuosl.org; Richard Cochran > ; > Keller, Jacob E ; Miroslav Lichvar > > Subject: [RFC PATCH 4/4] ixgbe: add

[RFT net-next] net: stmmac: Fix RX packet size > 8191

2018-10-26 Thread thor . thayer
From: Thor Thayer Ping problems with packets > 8191 as shown: PING 192.168.1.99 (192.168.1.99) 8150(8178) bytes of data. 8158 bytes from 192.168.1.99: icmp_seq=1 ttl=64 time=0.669 ms wrong data byte 8144 should be 0xd0 but was 0x0 1610 11 12 13 14 15 16 17 18 19 1a 1b 1c 1d 1e 1f 20

Re: Fw: [Bug 201423] New: eth0: hw csum failure

2018-10-26 Thread Andre Tomt
On 25.10.2018 19:38, Eric Dumazet wrote: On 10/24/2018 12:41 PM, Andre Tomt wrote: It eventually showed up again with mlx4, on 4.18.16 + fix and also on 4.19. I still do not have a useful packet capture. It is running a torrent client serving up various linux distributions. Have you

Re: [PATCH net] bridge: do not add port to router list when receives query with source 0.0.0.0

2018-10-26 Thread Roopa Prabhu
On Thu, Oct 25, 2018 at 7:29 PM Hangbin Liu wrote: > > Based on RFC 4541, 2.1.1. IGMP Forwarding Rules > > The switch supporting IGMP snooping must maintain a list of > multicast routers and the ports on which they are attached. This > list can be constructed in any combination of the

[RFC PATCH 4/4] ixgbe: add support for extended PHC gettime

2018-10-26 Thread Miroslav Lichvar
Cc: Richard Cochran Cc: Jacob Keller Signed-off-by: Miroslav Lichvar --- drivers/net/ethernet/intel/ixgbe/ixgbe_ptp.c | 57 1 file changed, 57 insertions(+) diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_ptp.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_ptp.c index

[RFC PATCH 2/4] e1000e: add support for extended PHC gettime

2018-10-26 Thread Miroslav Lichvar
Cc: Richard Cochran Cc: Jacob Keller Signed-off-by: Miroslav Lichvar --- drivers/net/ethernet/intel/e1000e/e1000.h | 3 ++ drivers/net/ethernet/intel/e1000e/netdev.c | 48 +- drivers/net/ethernet/intel/e1000e/ptp.c| 21 ++ 3 files changed, 62 insertions(+), 10

[PATCH v2 net] igb: shorten maximum PHC timecounter update interval

2018-10-26 Thread Miroslav Lichvar
The timecounter needs to be updated at least once per ~550 seconds in order to avoid a 40-bit SYSTIM timestamp to be misinterpreted as an old timestamp. Since commit 500462a9de65 ("timers: Switch to a non-cascading wheel"), scheduling of delayed work seems to be less accurate and a requested

RE: [PATCH v2 net] igb: shorten maximum PHC timecounter update interval

2018-10-26 Thread Keller, Jacob E
> -Original Message- > From: Miroslav Lichvar [mailto:mlich...@redhat.com] > Sent: Friday, October 26, 2018 10:13 AM > To: netdev@vger.kernel.org > Cc: intel-wired-...@lists.osuosl.org; Miroslav Lichvar ; > Keller, Jacob E ; Richard Cochran > ; Thomas Gleixner > Subject: [PATCH v2 net]

[RFC PATCH 0/4] More accurate PHC<->system clock synchronization

2018-10-26 Thread Miroslav Lichvar
This series adds support for a more accurate synchronization between a PTP hardware clock and the system clock. The first patch adds an extended version of the PTP_SYS_OFFSET ioctl, which returns three timestamps for each measurement. The idea is to shorten the interval between the system

[RFC PATCH 1/4] ptp: add PTP_SYS_OFFSET_EXTENDED ioctl

2018-10-26 Thread Miroslav Lichvar
The PTP_SYS_OFFSET ioctl, which can be used to measure the offset between a PHC and the system clock, includes the total time that the gettime64 function of a driver needs to read the PHC timestamp. This typically involves reading of multiple PCI registers (sometimes in multiple iterations) and

[RFC PATCH 3/4] igb: add support for extended PHC gettime

2018-10-26 Thread Miroslav Lichvar
Cc: Richard Cochran Cc: Jacob Keller Signed-off-by: Miroslav Lichvar --- drivers/net/ethernet/intel/igb/igb_ptp.c | 43 1 file changed, 43 insertions(+) diff --git a/drivers/net/ethernet/intel/igb/igb_ptp.c b/drivers/net/ethernet/intel/igb/igb_ptp.c index

Re: [PATCH v2 00/17] octeontx2-af: NPC parser and NIX blocks initialization

2018-10-26 Thread Andrew Lunn
> No there is no need for any userspace tools. Cool. The problem with the Freescale architecture is that you seem to need to provision the hardware. Tell it how many instances of various things to create, and how to logically connect them together. They have a user space tool to do this, in an

Re: [PATCH net] net: sched: Remove TCA_OPTIONS from policy

2018-10-26 Thread David Ahern
On 10/25/18 12:31 AM, Jiri Pirko wrote: > Wed, Oct 24, 2018 at 05:32:49PM CEST, dsah...@kernel.org wrote: >> From: David Ahern >> >> Marco reported an error with hfsc: >> root@Calimero:~# tc qdisc add dev eth0 root handle 1:0 hfsc default 1 >> Error: Attribute failed policy validation. >> >>

Re: [PATCH v2 00/17] octeontx2-af: NPC parser and NIX blocks initialization

2018-10-26 Thread Sunil Kovvuri
On Fri, Oct 26, 2018 at 9:56 PM Sunil Kovvuri wrote: > > On Fri, Oct 26, 2018 at 7:34 PM Arnd Bergmann wrote: > > > > On 10/26/18, Sunil Kovvuri wrote: > > > On Fri, Oct 26, 2018 at 6:24 PM Arnd Bergmann wrote: > > >> > > >> I see this has been applied, but I'd still like to understand better

[PATCH net] net/neigh: fix NULL deref in pneigh_dump_table()

2018-10-26 Thread Eric Dumazet
pneigh can have NULL device pointer, so we need to make neigh_master_filtered() and neigh_ifindex_filtered() more robust. syzbot report : kasan: CONFIG_KASAN_INLINE enabled kasan: GPF could be caused by NULL-ptr deref or user memory access general protection fault: [#1] PREEMPT SMP KASAN

Re: [PATCH v2 00/17] octeontx2-af: NPC parser and NIX blocks initialization

2018-10-26 Thread David Miller
From: Arnd Bergmann Date: Fri, 26 Oct 2018 16:04:44 +0200 > I fear that setting a precedent of using the mbox for user-level > configuration management would mean that we would have to > treat each of these interfaces as an ABI, which in turn requires > much deeper review as well as raising the

Re: [PATCH net v2] net: udp: fix handling of CHECKSUM_COMPLETE packets

2018-10-26 Thread Maciej Żenczykowski
Possibly worth mentioning that without this fix you can also end up with valid udp packets being dropped (ie. the reverse of the commit description which talks about receiving invalid ones). The (approximate?) requirement is: (a) nic generates CHECKSUM_COMPLETE, but gets the actual checksum wrong

pull-request: bpf 2018-10-27

2018-10-26 Thread Daniel Borkmann
Hi David, The following pull-request contains BPF updates for your *net* tree. The main changes are: 1) Fix toctou race in BTF header validation, from Martin and Wenwen. 2) Fix devmap interface comparison in notifier call which was neglecting netns, from Taehee. 3) Several fixes in various

[net:master 17/19] net//bridge/br_multicast.c:1432:32: error: 'union ' has no member named 'ip6'; did you mean 'ip4'?

2018-10-26 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git master head: aab456dfa404f3a16d6f1780e62a6a8533c4d008 commit: 5a2de63fd1a59c30c02526d427bc014b98adf508 [17/19] bridge: do not add port to router list when receives query with source 0.0.0.0 config: powerpc-defconfig (attached

checksumming on non-local forward path

2018-10-26 Thread Jason A. Donenfeld
Hey netdev, In a protocol like wireguard, if a packet arrives on the other end of the tunnel, and the crypto checks out, then we're absolutely certain that the packet hasn't been modified in transit. In this case, there's no useful information that validating the inner checksums of the various

[Bug?] ss command display unix domain port overflow

2018-10-26 Thread Suoben
> Dear all, > > When l use ss command to display unix domain socket, the ss shows as below, > the local address port and peer address port may overflow which looks like > equal to the socket fd inode . > > /** > # ss –apx > Netid State Recv-Q Send-Q Local Address:Port

[Patch net 07/11] net: hns3: bugfix for hclge_mdio_write and hclge_mdio_read

2018-10-26 Thread Huazhong Tan
When there is a PHY, the driver needs to complete some operations through MDIO during reset reinitialization, so HCLGE_STATE_CMD_DISABLE is more suitable than HCLGE_STATE_RST_HANDLING to prevent the MDIO operation from being sent during the hardware reset. Fixes: b50ae26c57cb ("net: hns3: never

[Patch net 05/11] net: hns3: remove unnecessary queue reset in the hns3_uninit_all_ring()

2018-10-26 Thread Huazhong Tan
It is not necessary to reset the queue in the hns3_uninit_all_ring(), since the queue is stopped in the down operation, and will be resetted in the up operaton. And the judgment of the HCLGE_STATE_RST_HANDLING flag in the hclge_reset_tqp() is not correct, because we need to reset tqp during pf

[Patch net 08/11] net: hns3: fix incorrect return value/type of some functions

2018-10-26 Thread Huazhong Tan
There are some functions that, when they fail to execute a send command, need to return the corresponding error value to its caller. Fixes: 46a3df9f9718 ("net: hns3: Add HNS3 Acceleration Engine & Compatibility Layer Support") Fixes: 681ec3999b3d ("net: hns3: fix for vlan table lost problem when

[Patch net 11/11] net: hns3: bugfix for rtnl_lock's range in the hclgevf_reset()

2018-10-26 Thread Huazhong Tan
Since hclgevf_reset_wait() is used to wait for the hardware to complete the reset, it is not necessary to hold the rtnl_lock during hclgevf_reset_wait(). So this patch release the lock for the duration of hclgevf_reset_wait(). Fixes: 6988eb2a9b77 ("net: hns3: Add support to reset the enet/ring

[Patch net 03/11] net: hns3: bugfix for reporting unknown vector0 interrupt repeatly problem

2018-10-26 Thread Huazhong Tan
The current driver supports handling two vector0 interrupts, reset and mailbox. When the hardware reports an interrupt of another type of interrupt source, if the driver does not process the interrupt and enables the interrupt, the hardware will repeatedly report the unknown interrupt. Therefore,

[Patch net 02/11] net: hns3: add error handler for hns3_get_ring_config/hns3_queue_to_ring

2018-10-26 Thread Huazhong Tan
When hns3_get_ring_config()/hns3_queue_to_ring() failed during resetting, the allocated memory has not been freed before hns3_get_ring_config() and hns3_queue_to_ring() return. So this patch fixes the buffer not freeing problem during resetting. Fixes: 76ad4f0ee747 ("net: hns3: Add support of

[Patch net 04/11] net: hns3: bugfix for the initialization of command queue's spin lock

2018-10-26 Thread Huazhong Tan
The spin lock of the command queue only needs to be initialized once when the driver initializes the command queue. It is not necessary to initialize the spin lock when resetting. At the same time, the modification of the queue member should be performed after acquiring the lock. Fixes:

[Patch net 09/11] net: hns3: bugfix for handling mailbox while the command queue reinitialized

2018-10-26 Thread Huazhong Tan
In a multi-core machine, the mailbox service and reset service will be executed at the same time. The reset server will re-initialize the commond queue, before that, the mailbox handler can only get some invalid messages. The HCLGE_STATE_CMD_DISABLE flag means that the command queue is not

[Patch net 10/11] net: hns3: bugfix for rtnl_lock's range in the hclge_reset()

2018-10-26 Thread Huazhong Tan
Since hclge_reset_wait() is used to wait for the hardware to complete the reset, it is not necessary to hold the rtnl_lock during hclge_reset_wait(). So this patch release the lock for the duration of hclge_reset_wait(). Fixes: 6d4fab39533f ("net: hns3: Reset net device with rtnl_lock")

[Patch net 00/11] Bugfix for the HNS3 driver

2018-10-26 Thread Huazhong Tan
This patch series include bugfix for the HNS3 ethernet controller driver. Huazhong Tan (11): net: hns3: add error handler for hns3_nic_init_vector_data() net: hns3: add error handler for hns3_get_ring_config/hns3_queue_to_ring net: hns3: bugfix for reporting unknown vector0 interrupt

[Patch net 01/11] net: hns3: add error handler for hns3_nic_init_vector_data()

2018-10-26 Thread Huazhong Tan
When hns3_nic_init_vector_data() failed for mapping ring to vector, it should cancel the netif_napi_add() that have been successfully done and then exit. Fixes: 76ad4f0ee747 ("net: hns3: Add support of HNS3 Ethernet Driver for hip08 SoC") Signed-off-by: Huazhong Tan ---

[Patch net 06/11] net: hns3: bugfix for is_valid_csq_clean_head()

2018-10-26 Thread Huazhong Tan
The HEAD pointer of the hardware command queue maybe equal to the command queue's next_to_use the driver, so that does not belong to the invalid HEAD pointer, since the hardware may not process the command in time, causing the HEAD pointer to be too late to update. The variables' name in this

[net:master 17/19] net/bridge/br_multicast.c:1432:31: error: 'union ' has no member named 'ip6'

2018-10-26 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git master head: aab456dfa404f3a16d6f1780e62a6a8533c4d008 commit: 5a2de63fd1a59c30c02526d427bc014b98adf508 [17/19] bridge: do not add port to router list when receives query with source 0.0.0.0 config: i386-randconfig-x0-10270816

Re: [Patch net 08/11] net: hns3: fix incorrect return value/type of some functions

2018-10-26 Thread kbuild test robot
Hi Huazhong, Thank you for the patch! Yet something to improve: [auto build test ERROR on net/master] url: https://github.com/0day-ci/linux/commits/Huazhong-Tan/Bugfix-for-the-HNS3-driver/20181027-105711 config: xtensa-allyesconfig (attached as .config) compiler: xtensa-linux-gcc (GCC)

Re: pull-request: bpf 2018-10-27

2018-10-26 Thread David Miller
From: Daniel Borkmann Date: Sat, 27 Oct 2018 02:07:48 +0200 > The following pull-request contains BPF updates for your *net* tree. > > The main changes are: > > 1) Fix toctou race in BTF header validation, from Martin and Wenwen. > > 2) Fix devmap interface comparison in notifier call which

Re: [PATCH net] net/neigh: fix NULL deref in pneigh_dump_table()

2018-10-26 Thread David Miller
From: Eric Dumazet Date: Fri, 26 Oct 2018 09:33:27 -0700 > pneigh can have NULL device pointer, so we need to make > neigh_master_filtered() and neigh_ifindex_filtered() more robust. ... > Fixes: 6f52f80e8530 ("net/neigh: Extend dump filter to proxy neighbor dumps") > Signed-off-by: Eric

[PATCH] Fix ss Netid column and Local/Peer_Address

2018-10-26 Thread Yoann P.
When using ss -Hutn4 or -utn3, Netid and State columns are sometime merged, it can be confusing when trying to pipe into awk or column. Details (before and after output) are available on this github issue: https:// github.com/shemminger/iproute2/issues/20 Signed-off-by: YoyPa --- misc/ss.c | 6

Re: [PATCH] net: allow traceroute with a specified interface in a vrf

2018-10-26 Thread David Ahern
On 10/26/18 5:24 AM, Mike Manning wrote: > Traceroute executed in a vrf succeeds if no device is given or if the > vrf is given as the device, but fails if the interface is given as the > device. This is for default UDP probes, it succeeds for TCP SYN or ICMP > ECHO probes. As the skb bound dev is

[PATCH] ptp: drop redundant kasprintf() to create worker name

2018-10-26 Thread Rasmus Villemoes
Building with -Wformat-nonliteral, gcc complains drivers/ptp/ptp_clock.c: In function ‘ptp_clock_register’: drivers/ptp/ptp_clock.c:239:26: warning: format not a string literal and no format arguments [-Wformat-nonliteral] worker_name : info->name); kthread_create_worker takes

[PATCH bpf] bpf: fix wrong helper enablement in cgroup local storage

2018-10-26 Thread Daniel Borkmann
Commit cd3394317653 ("bpf: introduce the bpf_get_local_storage() helper function") enabled the bpf_get_local_storage() helper also for BPF program types where it does not make sense to use them. They have been added both in sk_skb_func_proto() and sk_msg_func_proto() even though both program

Re: [PATCH v2 00/17] octeontx2-af: NPC parser and NIX blocks initialization

2018-10-26 Thread Arnd Bergmann
On Fri, Oct 26, 2018 at 6:33 PM Sunil Kovvuri wrote: > On Fri, Oct 26, 2018 at 9:56 PM Sunil Kovvuri wrote: > > On Fri, Oct 26, 2018 at 7:34 PM Arnd Bergmann wrote: > > > > On 10/26/18, Sunil Kovvuri wrote: > > > > On Fri, Oct 26, 2018 at 6:24 PM Arnd Bergmann wrote: > > > > > > > > As of now

[PATCH net v3] net/ipv6: Add anycast addresses to a global hashtable

2018-10-26 Thread Jeff Barnhill
icmp6_send() function is expensive on systems with a large number of interfaces. Every time it’s called, it has to verify that the source address does not correspond to an existing anycast address by looping through every device and every anycast address on the device. This can result in

[PATCH net] net: sched: gred: pass the right attribute to gred_change_table_def()

2018-10-26 Thread Jakub Kicinski
gred_change_table_def() takes a pointer to TCA_GRED_DPS attribute, and expects it will be able to interpret its contents as struct tc_gred_sopt. Pass the correct gred attribute, instead of TCA_OPTIONS. This bug meant the table definition could never be changed after Qdisc was initialized (unless

Re: [PATCH net] ipv6/ndisc: Preserve IPv6 control buffer if protocol error handlers are called

2018-10-26 Thread David Miller
From: Stefano Brivio Date: Wed, 24 Oct 2018 14:37:21 +0200 > Commit a61bbcf28a8c ("[NET]: Store skb->timestamp as offset to a base > timestamp") introduces a neighbour control buffer and zeroes it out in > ndisc_rcv(), as ndisc_recv_ns() uses it. > > Commit f2776ff04722 ("[IPV6]: Fix

Re: [PATCH bpf] bpf: fix wrong helper enablement in cgroup local storage

2018-10-26 Thread Roman Gushchin
On Sat, Oct 27, 2018 at 12:49:02AM +0200, Daniel Borkmann wrote: > Commit cd3394317653 ("bpf: introduce the bpf_get_local_storage() > helper function") enabled the bpf_get_local_storage() helper also > for BPF program types where it does not make sense to use them. > > They have been added both

Re: [PATCH net v3] net/ipv6: Add anycast addresses to a global hashtable

2018-10-26 Thread David Ahern
On 10/26/18 3:22 PM, Jeff Barnhill wrote: > @@ -275,6 +356,13 @@ int __ipv6_dev_ac_inc(struct inet6_dev *idev, const > struct in6_addr *addr) > err = -ENOMEM; > goto out; > } > + err = ipv6_add_acaddr_hash(dev_net(idev->dev), addr); > + if (err) { > +

Re: [PATCH net] bridge: do not add port to router list when receives query with source 0.0.0.0

2018-10-26 Thread David Miller
From: Hangbin Liu Date: Fri, 26 Oct 2018 10:28:43 +0800 > Based on RFC 4541, 2.1.1. IGMP Forwarding Rules > > The switch supporting IGMP snooping must maintain a list of > multicast routers and the ports on which they are attached. This > list can be constructed in any combination of

Re: [PATCH] net: allow traceroute with a specified interface in a vrf

2018-10-26 Thread David Miller
From: Mike Manning Date: Fri, 26 Oct 2018 12:24:35 +0100 > Traceroute executed in a vrf succeeds if no device is given or if the > vrf is given as the device, but fails if the interface is given as the > device. This is for default UDP probes, it succeeds for TCP SYN or ICMP > ECHO probes. As

Re: [PATCH net V2 1/1] net/smc: fix smc_buf_unuse to use the lgr pointer

2018-10-26 Thread David Miller
From: Ursula Braun Date: Thu, 25 Oct 2018 13:25:28 +0200 > From: Karsten Graul > > The pointer to the link group is unset in the smc connection structure > right before the call to smc_buf_unuse. Provide the lgr pointer to > smc_buf_unuse explicitly. > And move the call to

[iproute2 PATCH v2] bridge: fix vlan show stats formatting

2018-10-26 Thread Tobias Jungel
The output of -statistics vlan show was broken previous change for json output. This aligns the format to vlan show. v2: fixed too greedy deletion that caused a -Wmaybe-uninitialized Signed-off-by: Tobias Jungel --- bridge/vlan.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff

Re: [Intel-wired-lan] [RFC PATCH 1/4] ptp: add PTP_SYS_OFFSET_EXTENDED ioctl

2018-10-26 Thread Vinicius Costa Gomes
Hi Miroslav, Miroslav Lichvar writes: > The PTP_SYS_OFFSET ioctl, which can be used to measure the offset > between a PHC and the system clock, includes the total time that the > gettime64 function of a driver needs to read the PHC timestamp. > > This typically involves reading of multiple PCI

Re: [PATCH bpf] bpf: fix wrong helper enablement in cgroup local storage

2018-10-26 Thread Alexei Starovoitov
On Fri, Oct 26, 2018 at 10:57:18PM +, Roman Gushchin wrote: > On Sat, Oct 27, 2018 at 12:49:02AM +0200, Daniel Borkmann wrote: > > Commit cd3394317653 ("bpf: introduce the bpf_get_local_storage() > > helper function") enabled the bpf_get_local_storage() helper also > > for BPF program types

Re: [RFC net-next v2 2/8] net: add netif_is_geneve()

2018-10-26 Thread Sergei Shtylyov
Hello! On 25.10.2018 15:26, John Hurley wrote: Add a helper function to determine if the type of a netdev is geneve based on its rtnl_link_ops. This allows drivers that may wish to ofload tunnels Offload? to check the underlying type of the device. A recent patch added a similar helper

Re: [RFC] net: stmmac: RX Jumbo packet size > 8191 problem

2018-10-26 Thread Jose Abreu
On 25-10-2018 21:41, Thor Thayer wrote: > Hi, > > I'm running into a weird issue at the DMA boundary for large > packets (>8192) that I can't explain. I'm hoping someone here > has an idea on why I'm seeing this issue. > > This is the Synopsys DesignWare Ethernet GMAC core (3.74) using > the

Re: [PATCH net-next] net/ipv6: Block IPv6 addrconf on team ports

2018-10-26 Thread Jiri Pirko
Fri, Oct 26, 2018 at 12:40:31AM CEST, jay.vosbu...@canonical.com wrote: >Chas Williams <3ch...@gmail.com> wrote: > >>On 10/25/2018 05:59 PM, Jay Vosburgh wrote: >>> Chas Williams <3ch...@gmail.com> wrote: >>> netif_is_lag_port should be used to identify link aggregation ports. For this

[PATCH] net: allow traceroute with a specified interface in a vrf

2018-10-26 Thread Mike Manning
Traceroute executed in a vrf succeeds if no device is given or if the vrf is given as the device, but fails if the interface is given as the device. This is for default UDP probes, it succeeds for TCP SYN or ICMP ECHO probes. As the skb bound dev is the interface and the sk dev is the vrf, sk