Re: [PATCH net] sctp: hold transport before accessing its asoc in sctp_hash_transport

On Tue, Nov 20, 2018 at 07:09:16PM +0800, Xin Long wrote: > In sctp_hash_transport, it dereferences a transport's asoc only under > rcu_read_lock. Without holding the transport, its asoc could be freed > already, which leads to a use-after-free panic. > > A similar fix as Commit bab1be79a516

[PATCH net-next 4/4] mlx5: use skb_vlan_tag_get_prio()

Signed-off-by: Michał Mirosław --- drivers/net/ethernet/mellanox/mlx5/core/en_tx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tx.c b/drivers/net/ethernet/mellanox/mlx5/core/en_tx.c index 6dacaeba2fbf..9afdf955f2bc 100644 ---

[PATCH net-next 0/4] VLAN tag handling cleanup

This is a cleanup set after VLAN_TAG_PRESENT removal. The CFI bit handling is made similar to how other tag fields are used. Michał Mirosław (4): net/vlan: introduce skb_vlan_tag_get_cfi() helper net/hyperv: use skb_vlan_tag_*() helpers benet: use skb_vlan_tag_get_prio() mlx5: use

[PATCH net-next 1/4] net/vlan: introduce skb_vlan_tag_get_cfi() helper

Abstract CFI/DEI bit access consistently with other VLAN tag fields. Signed-off-by: Michał Mirosław --- include/linux/if_vlan.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/linux/if_vlan.h b/include/linux/if_vlan.h index 7a541eadf78e..4cca4da7a6de 100644 ---

[PATCH net-next 2/4] net/hyperv: use skb_vlan_tag_*() helpers

Replace open-coded bitfield manipulation with skb_vlan_tag_*() helpers. This also enables correctly passing of VLAN.CFI bit. Signed-off-by: Michał Mirosław --- drivers/net/hyperv/netvsc_drv.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git

[PATCH net-next 3/4] benet: use skb_vlan_tag_get_prio()

Signed-off-by: Michał Mirosław --- drivers/net/ethernet/emulex/benet/be_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c index 80b2bd3747ce..245abf0d19c0 100644 ---

Geschäftsvorschlag

Hallo, Ich bin Mr. Alan Austin und arbeite derzeit mit der Credit suisse Bank London. Ich habe Ihren Kontakt während meiner privaten Suche gesehen und bin der festen Überzeugung, dass Sie sehr ehrlich, engagiert und in der Lage sein werden, dieses Unternehmen zu unterstützen. Ich bin ein

Re: [PATCH net] net: skb_scrub_packet(): Scrub offload_fwd_mark

Tue, Nov 20, 2018 at 12:39:56PM CET, pe...@mellanox.com wrote: >When a packet is trapped and the corresponding SKB marked as >already-forwarded, it retains this marking even after it is forwarded >across veth links into another bridge. There, since it ingresses the >bridge over veth, which doesn't

[PATCH net] net: skb_scrub_packet(): Scrub offload_fwd_mark

When a packet is trapped and the corresponding SKB marked as already-forwarded, it retains this marking even after it is forwarded across veth links into another bridge. There, since it ingresses the bridge over veth, which doesn't have offload_fwd_mark, it triggers a warning in

Re: [PATCH net-next v3 1/6] net: phy: mscc: migrate to phy_select/restore_page functions

On Nov 19 2018, Andrew Lunn wrote: > I still don't see why that would cause a hang. [ 996.37] [] mutex_lock+0x22/0x2a [ 996.38] [] mdiobus_read+0x36/0x60 [ 996.38] [] vsc85xx_config_init+0x4c/0x1e2 vsc85xx_config_init is calling mdiobus_read while holding the mdio_lock.

Re: [PATCH 3/3] selftests: add a test for bpf_prog_test_run output size

On Sun, 18 Nov 2018 at 05:59, Y Song wrote: > > On Fri, Nov 16, 2018 at 12:55 PM Lorenz Bauer wrote: > > > > Make sure that bpf_prog_test_run returns the correct length > > in the size_out argument and that the kernel respects the > > output size hint. > > > > Signed-off-by: Lorenz Bauer > >

Re: [PATCH v1 2/2] netfilter: Add PSID mode to MASQUERADE

Hi Blair, Thank you for the patch! Yet something to improve: [auto build test ERROR on nf-next/master] [also build test ERROR on v4.20-rc3 next-20181120] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux

Re: [RFC PATCH] net: don't keep lonely packets forever in the gro hash

On 11/20/2018 01:17 PM, Paolo Abeni wrote: > Eric noted that with UDP GRO and napi timeout, we could keep a single NAPI, else you're simply inconsistent. > UDP packet inside the GRO hash forever, if the related NAPI instance > calls napi_gro_complete() at an higher frequency than the napi

Re: [PATCH bpf-next 1/2] bpf: adding support for map in map in libbpf

On 20/11/18 00:06, Nikita V. Shirokov wrote: > idea is pretty simple. for specified map (pointed by struct bpf_map) > we would provide descriptor of already loaded map, which is going to be > used as a prototype for inner map. proposed workflow: > 1) open bpf's object (bpf_object__open) > 2)

Re: [PATCH v5 bpf-next 00/13] bpf: Add btf func info support

On 19/11/18 23:29, Martin KaFai Lau wrote: > The BTF support was added to kernel by Commit 69b693f0aefa > ("bpf: btf: Introduce BPF Type Format (BTF)"), which introduced > .BTF section into ELF file and is primarily > used for map pretty print. > pahole is used to convert dwarf to BTF for ELF

[PATCH net] sctp: hold transport before accessing its asoc in sctp_epaddr_lookup_transport

Without holding transport to dereference its asoc, a use after free panic can be caused in sctp_epaddr_lookup_transport. Note that a sock lock can't protect these transports that belong to other socks. A similar fix as Commit bab1be79a516 ("sctp: hold transport before accessing its asoc in

[PATCH net] sctp: hold transport before accessing its asoc in sctp_hash_transport

In sctp_hash_transport, it dereferences a transport's asoc only under rcu_read_lock. Without holding the transport, its asoc could be freed already, which leads to a use-after-free panic. A similar fix as Commit bab1be79a516 ("sctp: hold transport before accessing its asoc in

[RFC PATCH] net: don't keep lonely packets forever in the gro hash

Eric noted that with UDP GRO and napi timeout, we could keep a single UDP packet inside the GRO hash forever, if the related NAPI instance calls napi_gro_complete() at an higher frequency than the napi timeout. Willem noted that even TCP packets could be trapped there, till the next

Re: [net 01/13] net/mlx5: IPSec, Fix the SA context hash key

Hello! On 20.11.2018 2:41, Saeed Mahameed wrote: From: Raed Salem The commit "net/mlx5: Refactor accel IPSec code" introduced a You also need to cite the commit ID. bug where asynchronous short time change in hash key value by create/release SA context might happen during an

Re: netns_id in bpf_sk_lookup_{tcp,udp}

Le 20/11/2018 à 00:46, David Ahern a écrit : [snip] > That revelation shows another hole: > $ ip netns add foo > $ ip netns set foo 0x It also works with 0xf000 ... > $ ip netns list > foo (id: 0) > > Seems like alloc_netid() should error out if reqid < -1 (-1 being the >

Re: [PATCH net] ipv6/mcast: update mc_qrv when join new group

On Wed, Nov 14, 2018 at 10:37:31AM +0800, Hangbin Liu wrote: > On Thu, Nov 08, 2018 at 03:44:10PM +0800, Hangbin Liu wrote: > > On Fri, Oct 26, 2018 at 10:30:54AM +0800, Hangbin Liu wrote: > > > Currently we only set mc_qrv to sysctl_mld_qrv when interface up. If we > > > change sysctl_mld_qrv

Re: [PATCH] ipv4: allow newer DSCP values in ip rules

On Mon, Nov 19, 2018 at 03:11:29PM -0800, David Miller wrote: > From: Pavel Balaev > Date: Mon, 19 Nov 2018 12:00:45 +0300 > > > After this patch this one can use it: > > You can "configure it" but it doesn't work at all. > > Did you test this in any way beyond simply dumping the FIB rule >

[PATCH net] tcp: Fix SOF_TIMESTAMPING_RX_HARDWARE to use the latest timestamp during TCP coalescing

During tcp coalescing ensure that the skb hardware timestamp refers to the highest sequence number data. Previously only the software timestamp was updated during coalescing. Signed-off-by: Stephen Mallon --- net/ipv4/tcp_input.c | 1 + 1 file changed, 1 insertion(+) diff --git

<    1   2   3