Re: [PATCHv2 net] sctp: check and update stream->out_curr when allocating stream_out

2018-11-29 Thread Xin Long
On Thu, Nov 29, 2018 at 9:50 PM Neil Horman wrote: > > On Thu, Nov 29, 2018 at 02:42:56PM +0800, Xin Long wrote: > > Now when using stream reconfig to add out streams, stream->out > > will get re-allocated, and all old streams' information will > > be copied to the new ones and the old ones will

Re: [PATCHv2 net] sctp: check and update stream->out_curr when allocating stream_out

2018-11-29 Thread Neil Horman
On Thu, Nov 29, 2018 at 02:42:56PM +0800, Xin Long wrote: > Now when using stream reconfig to add out streams, stream->out > will get re-allocated, and all old streams' information will > be copied to the new ones and the old ones will be freed. > > So without stream->out_curr updated, next time

Re: [PATCH net-next v2 3/3] vxlan: move flag sets to use a helper func

2018-11-29 Thread Sabrina Dubroca
2018-11-28, 14:27:59 -0800, Roopa Prabhu wrote: > +/* Set/clear flags based on attribute */ > +static void vxlan_nl2flag(struct vxlan_config *conf, struct nlattr *tb[], > + int attrtype, unsigned long mask) > +{ > + unsigned long flags; > + > + if (!tb[attrtype]) > +

[RFC PATCH] net: mvpp2: fix detection of 10G SFP modules

2018-11-29 Thread Baruch Siach
The mvpp2_phylink_validate() relies on the interface field of phylink_link_state to determine valid link modes. However, when called from phylink_sfp_module_insert() this field in not initialized. The default switch case then excludes 10G link modes. This allows 10G SFP modules that are detected

[PATCH net 2/2] i40e: DRY rx_ptype handling code

2018-11-29 Thread Michał Mirosław
Move rx_ptype extracting to i40e_process_skb_fields() to avoid duplicating the code. Signed-off-by: Michał Mirosław Signed-off-by: Michał Mirosław --- drivers/net/ethernet/intel/i40e/i40e_txrx.c | 12 drivers/net/ethernet/intel/i40e/i40e_xsk.c | 6 +- 2 files changed, 5

[PATCH net 1/2] i40e: fix VLAN.TCI == 0 RX HW offload

2018-11-29 Thread Michał Mirosław
This fixes two bugs in hardware VLAN offload: 1. VLAN.TCI == 0 was being dropped 2. there was a race between disabling of VLAN RX feature in hardware and processing RX queue, where packets processed in this window could have their VLAN information dropped Fix moves the VLAN handling

Re: [PATCH net-next v2 1/3] vxlan: support changelink for a few more attributes

2018-11-29 Thread Sabrina Dubroca
2018-11-28, 14:27:57 -0800, Roopa Prabhu wrote: > From: Roopa Prabhu > > We started very conservative when supporting changelink > especially because not all attribute changes could be > tested. This patch opens up a few more attributes for > changelink. The reason for choosing this set of

Re: [PATCH] net: phy: sfp: correct store of detected link modes

2018-11-29 Thread Baruch Siach
Hi Russell, Russell King - ARM Linux writes: > On Thu, Nov 29, 2018 at 12:40:11PM +0200, Baruch Siach wrote: >> The link modes that sfp_parse_support() detects are stored in the >> 'modes' bitmap. There is no reason to make an exception for 1000Base-PX >> or 1000Base-BX10. > > I think you may be

Re: [PATCHv2 net] sctp: check and update stream->out_curr when allocating stream_out

2018-11-29 Thread Neil Horman
On Thu, Nov 29, 2018 at 02:42:56PM +0800, Xin Long wrote: > Now when using stream reconfig to add out streams, stream->out > will get re-allocated, and all old streams' information will > be copied to the new ones and the old ones will be freed. > > So without stream->out_curr updated, next time

[PATCH net 0/2] fixes for XPS configuration after Symmetric queue selection

2018-11-29 Thread Sabrina Dubroca
This fixes some bugs introduced by the "Symmetric queue selection using XPS for Rx queues". First, the refactoring of the cleanup function skipped resetting the queue's NUMA node under some conditions. Second, the accounting on static keys for XPS and RXQS-XPS is unbalanced, so the static key

[PATCH net 2/2] net: fix XPS static_key accounting

2018-11-29 Thread Sabrina Dubroca
Commit 04157469b7b8 ("net: Use static_key for XPS maps") introduced a static key for XPS, but the increments/decrements don't match. First, the static key's counter is incremented once for each queue, but only decremented once for a whole batch of queues, leading to large unbalances. Second, the

[PATCH net 1/2] net: restore call to netdev_queue_numa_node_write when resetting XPS

2018-11-29 Thread Sabrina Dubroca
Before commit 80d19669ecd3 ("net: Refactor XPS for CPUs and Rx queues"), netif_reset_xps_queues() did netdev_queue_numa_node_write() for all the queues being reset. Now, this is only done when the "active" variable in clean_xps_maps() is false, ie when on all the CPUs, there's no active XPS

[PATCH net] tun: forbid iface creation with rtnl ops

2018-11-29 Thread Nicolas Dichtel
It's not supported right now (the goal of the initial patch was to support 'ip link del' only). Before the patch: $ ip link add foo type tun [ 239.632660] BUG: unable to handle kernel NULL pointer dereference at [snip] [ 239.636410] RIP: 0010:register_netdevice+0x8e/0x3a0

RE: [PATCH net-next,v4 05/12] flow_offload: add statistics retrieval infrastructure and use it

2018-11-29 Thread Venkat Duvvuru
> -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev- > ow...@vger.kernel.org] On Behalf Of Pablo Neira Ayuso > Sent: Thursday, November 29, 2018 7:52 AM > To: netdev@vger.kernel.org > Cc: da...@davemloft.net; thomas.lenda...@amd.com; > f.faine...@gmail.com;

2% Apply for urgent loan.

2018-11-29 Thread Robert Gigson Rob
Good Day, Getting a legitimate loan have always been a huge problem to clients who are in financial needs.The issue of credit and collateral are something that clients are always worried about when seeking a loan from a legitimate lender. Sun Finance Company has made that difference in the

Re: [PATCH net-next,v4 09/12] ethtool: add basic ethtool_rx_flow_spec to flow_rule structure translator

2018-11-29 Thread Michal Kubecek
On Thu, Nov 29, 2018 at 03:22:28AM +0100, Pablo Neira Ayuso wrote: > This patch adds a function to translate the ethtool_rx_flow_spec > structure to the flow_rule representation. > > This allows us to reuse code from the driver side given that both flower > and ethtool_rx_flow interfaces use the

Re: [Patch net] mlx5: fix get_ip_proto()

2018-11-29 Thread Tariq Toukan
On 29/11/2018 1:04 AM, Cong Wang wrote: > IP header is not necessarily located right after struct ethhdr, > there could be multiple 802.1Q headers in between, this is why > we call __vlan_get_protocol(). > > Fixes: fe1dc069990c ("net/mlx5e: don't set CHECKSUM_COMPLETE on SCTP packets") > Cc:

Re: [PATCH] net: phy: sfp: correct store of detected link modes

2018-11-29 Thread Russell King - ARM Linux
On Thu, Nov 29, 2018 at 02:30:53PM +0200, Baruch Siach wrote: > Hi Russell, > > Russell King - ARM Linux writes: > > On Thu, Nov 29, 2018 at 12:40:11PM +0200, Baruch Siach wrote: > >> The link modes that sfp_parse_support() detects are stored in the > >> 'modes' bitmap. There is no reason to make

[PATCH net v2 2/2] i40e: DRY rx_ptype handling code

2018-11-29 Thread Michał Mirosław
Move rx_ptype extracting to i40e_process_skb_fields() to avoid duplicating the code. Signed-off-by: Michał Mirosław Signed-off-by: Michał Mirosław --- v2: * fix prototype in i40e_txrx_common.h --- drivers/net/ethernet/intel/i40e/i40e_txrx.c| 12

[PATCH net v2 1/2] i40e: fix VLAN.TCI == 0 RX HW offload

2018-11-29 Thread Michał Mirosław
This fixes two bugs in hardware VLAN offload: 1. VLAN.TCI == 0 was being dropped 2. there was a race between disabling of VLAN RX feature in hardware and processing RX queue, where packets processed in this window could have their VLAN information dropped Fix moves the VLAN handling

Re: [PATCH net-next v2 1/3] vxlan: support changelink for a few more attributes

2018-11-29 Thread Roopa Prabhu
On Thu, Nov 29, 2018 at 5:56 AM Sabrina Dubroca wrote: > > 2018-11-28, 14:27:57 -0800, Roopa Prabhu wrote: > > From: Roopa Prabhu > > > > We started very conservative when supporting changelink > > especially because not all attribute changes could be > > tested. This patch opens up a few more

[PATCH ethtool] ethtool: don't report UFO on kernels v4.14 and above

2018-11-29 Thread Ivan Vecera
Support for UDP fragmentation offloading was removed in kernel v4.14. The ethtool reports incorrectly its state on this and newer kernels: $ ethtool -k enp0s31f6 | grep udp-frag udp-fragmentation-offload: off It's look like that the feature is supported and disabled only. Instead of this

Re: [PATCH net-next,v4 00/12] add flow_rule infrastructure

2018-11-29 Thread John Fastabend
On 11/28/18 6:22 PM, Pablo Neira Ayuso wrote: > Hi, > > This patchset is another iteration to introduce an in-kernel intermediate > representation (IR) to express ACL hardware offloads [1] [2] [3]. > Hi, Also wanted to add. In an earlier thread it was mentioned this could be used for other

Re: [PATCH net-next v2 1/3] vxlan: support changelink for a few more attributes

2018-11-29 Thread Sabrina Dubroca
2018-11-29, 07:33:11 -0800, Roopa Prabhu wrote: > On Thu, Nov 29, 2018 at 5:56 AM Sabrina Dubroca wrote: > > > > 2018-11-28, 14:27:57 -0800, Roopa Prabhu wrote: > > > From: Roopa Prabhu > > > > > > We started very conservative when supporting changelink > > > especially because not all attribute

[PATCH net-next] tcp: remove loop to compute wscale

2018-11-29 Thread Eric Dumazet
We can remove the loop and conditional branches and compute wscale efficiently thanks to ilog2() Signed-off-by: Eric Dumazet --- net/ipv4/tcp_output.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c index

Re: [PATCH net-next] tcp: remove loop to compute wscale

2018-11-29 Thread Soheil Hassas Yeganeh
On Thu, Nov 29, 2018 at 10:56 AM Eric Dumazet wrote: > > We can remove the loop and conditional branches > and compute wscale efficiently thanks to ilog2() > > Signed-off-by: Eric Dumazet Acked-by: Soheil Hassas Yeganeh Very nice, thank you, Eric! > --- > net/ipv4/tcp_output.c | 8 +++-

Re: [PATCH net-next v2 3/3] vxlan: move flag sets to use a helper func

2018-11-29 Thread Roopa Prabhu
On Thu, Nov 29, 2018 at 6:19 AM Sabrina Dubroca wrote: > > 2018-11-28, 14:27:59 -0800, Roopa Prabhu wrote: > > +/* Set/clear flags based on attribute */ > > +static void vxlan_nl2flag(struct vxlan_config *conf, struct nlattr *tb[], > > + int attrtype, unsigned long mask) > >

Re: [PATCH net-next v2 3/3] vxlan: move flag sets to use a helper func

2018-11-29 Thread Sabrina Dubroca
2018-11-29, 07:27:17 -0800, Roopa Prabhu wrote: > On Thu, Nov 29, 2018 at 6:19 AM Sabrina Dubroca wrote: > > 2018-11-28, 14:27:59 -0800, Roopa Prabhu wrote: > > nit: This patch would have been easier to review if it came first in > > the series. Converting: > > I considered that. But the first

Re: [PATCH net-next v2 3/3] vxlan: move flag sets to use a helper func

2018-11-29 Thread Roopa Prabhu
On Thu, Nov 29, 2018 at 7:55 AM Sabrina Dubroca wrote: > > 2018-11-29, 07:27:17 -0800, Roopa Prabhu wrote: > > On Thu, Nov 29, 2018 at 6:19 AM Sabrina Dubroca > > wrote: > > > 2018-11-28, 14:27:59 -0800, Roopa Prabhu wrote: > > > nit: This patch would have been easier to review if it came first

Re: [PATCH iproute2] ss: add support for bytes_sent, bytes_retrans, dsack_dups and reord_seen

2018-11-29 Thread David Ahern
On 11/29/18 11:50 AM, Stephen Hemminger wrote: > PS: ss still doesn't support JSON output, given the volume of output it would > be good. I thought Stefano was investigating it as an alternative to the 'display selected columns' patches.

Re: [PATCH net-next 2/3] vxlan: extack support for some changelink cases

2018-11-29 Thread kbuild test robot
Hi Roopa, I love your patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Roopa-Prabhu/vxlan-support-changelink-for-a-few-more-attributes/20181130-030315 config: x86_64-randconfig-x006-201847 (attached as .config)

Re: [PATCH net-next v2 1/2] udp: msg_zerocopy

2018-11-29 Thread Willem de Bruijn
On Thu, Nov 29, 2018 at 3:27 AM Paolo Abeni wrote: > > Hi, > > Thank you for the update! > > On Wed, 2018-11-28 at 18:50 -0500, Willem de Bruijn wrote: > > I did revert to the basic implementation using an extra ref > > for the function call, similar to TCP, as you suggested. > > > > On top of

Re: [PATCH net-next] tun: implement carrier change

2018-11-29 Thread Andrew Lunn
On Thu, Nov 29, 2018 at 12:06:18PM +0100, Nicolas Dichtel wrote: > Le 28/11/2018 à 22:48, Andrew Lunn a écrit : > > On Wed, Nov 28, 2018 at 07:12:56PM +0100, Nicolas Dichtel wrote: > >> The userspace may need to control the carrier state. > > > > Hi Nicolas > Hi Andrew, > > > > > Could you

Re: [Intel-wired-lan] [PATCH] intel: ice: Do not enable NAPI on q_vectors that have no rings

2018-11-29 Thread Venkataramanan, Anirudh
On Thu, 2018-11-29 at 01:54 +, Yang Xiao wrote: > From: Young Xiao > > If ice driver has q_vectors w/ active NAPI that has no rings, > then this will result in a divide by zero error. To correct it > I am updating the driver code so that we only support NAPI on > q_vectors that have 1 or

Re: [PATCH net-next,v4 00/12] add flow_rule infrastructure

2018-11-29 Thread Jiri Pirko
Thu, Nov 29, 2018 at 04:47:07PM CET, john.fastab...@gmail.com wrote: >On 11/28/18 6:22 PM, Pablo Neira Ayuso wrote: >> Hi, >> >> This patchset is another iteration to introduce an in-kernel intermediate >> representation (IR) to express ACL hardware offloads [1] [2] [3]. >> > >Hi, > >Also wanted

<    1   2