Re: [PATCH 0/3] net: macb: DMA race condition fixes

2018-12-07 Thread Anssi Hannula
On 5.12.2018 22:35, David Miller wrote: > From: Anssi Hannula > Date: Fri, 30 Nov 2018 20:21:34 +0200 > >> Here are a couple of race condition fixes for the macb driver. The first >> two are issues observed on real HW. > It looks like there is still an active discussion about the memory >

[PATCH v2 net-next 0/4] net: aquantia: add RSS configuration

2018-12-07 Thread Igor Russkikh
In this patchset few bugs related to RSS are fixed and RSS table and hash key configuration is added. We also do increase max number of HW rings upto 8. v2: removed extra arg check Dmitry Bogdanov (4): net: aquantia: fix RSS table and key sizes net: aquantia: increase max number of hw

[PATCH v2 net-next 1/4] net: aquantia: fix RSS table and key sizes

2018-12-07 Thread Igor Russkikh
From: Dmitry Bogdanov Set RSS indirection table and RSS hash key sizes to their real size. Signed-off-by: Dmitry Bogdanov Signed-off-by: Igor Russkikh --- drivers/net/ethernet/aquantia/atlantic/aq_cfg.h | 4 ++-- drivers/net/ethernet/aquantia/atlantic/aq_nic.c | 2 +- 2 files changed, 3

[PATCH v2 net-next 4/4] net: aquantia: add support of RSS configuration

2018-12-07 Thread Igor Russkikh
From: Dmitry Bogdanov Add support of configuration of RSS hash key and RSS indirection table. Signed-off-by: Dmitry Bogdanov Signed-off-by: Igor Russkikh --- .../ethernet/aquantia/atlantic/aq_ethtool.c | 36 +++ 1 file changed, 36 insertions(+) diff --git

[PATCH v2 net-next 2/4] net: aquantia: increase max number of hw queues

2018-12-07 Thread Igor Russkikh
From: Dmitry Bogdanov Increase the upper limit of the hw queues up to 8. This makes RSS better on multiheaded cpus. This is a maximum AQC hardware supports in one traffic class. The actual value is still limited by a number of available cpu cores. Signed-off-by: Dmitry Bogdanov

[PATCH v2 net-next 3/4] net: aquantia: fix initialization of RSS table

2018-12-07 Thread Igor Russkikh
From: Dmitry Bogdanov Now RSS indirection table is initialized before setting up the number of hw queues, consequently the table may be filled by non existing queues. This patch moves the initialization when the number of hw queues is known. Signed-off-by: Dmitry Bogdanov Signed-off-by: Igor

Urgently need money? We can help you!

2018-12-07 Thread Mr. Muller Dieter
Urgently need money? We can help you! Are you by the current situation in trouble or threatens you in trouble? In this way, we give you the ability to take a new development. As a rich person I feel obliged to assist people who are struggling to give them a chance. Everyone deserved a second

Re: [PATCH 3/3] net: macb: add missing barriers when reading buffers

2018-12-07 Thread Anssi Hannula
On 6.12.2018 16:14, claudiu.bez...@microchip.com wrote: > Hi Anssi, Hi! > On 05.12.2018 16:00, Anssi Hannula wrote: >> On 5.12.2018 14:37, claudiu.bez...@microchip.com wrote: >>> On 30.11.2018 20:21, Anssi Hannula wrote: When reading buffer descriptors on RX or on TX completion, an

Re: [RFC PATCH 4/6] dt-bindings: update mvneta binding document

2018-12-07 Thread Russell King - ARM Linux
On Fri, Dec 07, 2018 at 05:30:52PM +0530, Kishon Vijay Abraham I wrote: > Hi, > > On 07/12/18 5:03 PM, Russell King - ARM Linux wrote: > > On Fri, Dec 07, 2018 at 04:43:27PM +0530, Kishon Vijay Abraham I wrote: > >> Russell, > >> > >> No, I haven't merged patches from this series. That would have

Re: [PATCH] bpf: fix overflow of bpf_jit_limit when PAGE_SIZE >= 64K

2018-12-07 Thread Michael Ellerman
Michael Roth writes: > Commit ede95a63b5 introduced a bpf_jit_limit tuneable to limit BPF > JIT allocations. At compile time it defaults to PAGE_SIZE * 4, > and is adjusted again at init time if MODULES_VADDR is defined. > > For ppc64 kernels, MODULES_VADDR isn't defined, so we're stuck with

Re: [RFC PATCH 4/6] dt-bindings: update mvneta binding document

2018-12-07 Thread Russell King - ARM Linux
On Fri, Dec 07, 2018 at 09:37:54AM +0530, Kishon Vijay Abraham I wrote: > Hi Russell, > > On 05/12/18 9:00 PM, Rob Herring wrote: > > On Wed, Dec 5, 2018 at 5:00 AM Russell King - ARM Linux > > wrote: > >> > >> On Mon, Dec 03, 2018 at 05:54:55PM -0600, Rob Herring wrote: > >>> On Mon, Nov 12,

[PATCH bpf-next 3/7] bpf: add bpf_xsk_redirect function

2018-12-07 Thread Björn Töpel
From: Björn Töpel The bpf_xsk_redirect function is a new redirect bpf function, in addition to bpf_redirect/bpf_redirect_map. If an XDP socket has been attached to a netdev Rx queue via the XDP_ATTACH bind() option and bpf_xsk_redirect is called, the packet will be redirected to the attached

[PATCH bpf-next 4/7] bpf: prepare for builtin bpf program

2018-12-07 Thread Björn Töpel
From: Björn Töpel Break up bpf_prog_load into one function that allocates, initializes and verifies a bpf program, and one that allocates a file descriptor. The former function will be used in a later commit to load a builtin BPF program. Signed-off-by: Björn Töpel --- kernel/bpf/syscall.c |

[PATCH bpf-next 0/7] Add XDP_ATTACH bind() flag to AF_XDP sockets

2018-12-07 Thread Björn Töpel
From: Björn Töpel Hi! This patch set adds support for a new XDP socket bind option, XDP_ATTACH. The rationale behind attach is performance and ease of use. Many XDP socket users just need a simple way of creating/binding a socket and receiving frames right away without loading an XDP program.

[PATCH bpf-next 1/7] xsk: simplify AF_XDP socket teardown

2018-12-07 Thread Björn Töpel
From: Björn Töpel Prior this commit, when the struct socket object was being released, the UMEM did not have its reference count decreased. Instead, this was done in the struct sock sk_destruct function. There is no reason to keep the UMEM reference around when the socket is being orphaned, so

[PATCH bpf-next 2/7] xsk: add XDP_ATTACH bind() flag

2018-12-07 Thread Björn Töpel
From: Björn Töpel In this commit the XDP_ATTACH bind() flag is introduced. When an XDP socket is bound with this flag set, the socket will be associated with a certain netdev Rx queue. The idea is that the XDP socket users do not have to deal with the XSKMAP, or even an XDP program. Instead

Re: [PATCH bpf-next 0/7] Add XDP_ATTACH bind() flag to AF_XDP sockets

2018-12-07 Thread Jesper Dangaard Brouer
On Fri, 7 Dec 2018 12:44:24 +0100 Björn Töpel wrote: > The rationale behind attach is performance and ease of use. Many XDP > socket users just need a simple way of creating/binding a socket and > receiving frames right away without loading an XDP program. > > XDP_ATTACH adds a mechanism we

Re: [RFC PATCH 4/6] dt-bindings: update mvneta binding document

2018-12-07 Thread Kishon Vijay Abraham I
Russell, On 07/12/18 4:11 PM, Russell King - ARM Linux wrote: > On Fri, Dec 07, 2018 at 09:37:54AM +0530, Kishon Vijay Abraham I wrote: >> Hi Russell, >> >> On 05/12/18 9:00 PM, Rob Herring wrote: >>> On Wed, Dec 5, 2018 at 5:00 AM Russell King - ARM Linux >>> wrote: On Mon, Dec 03,

[PATCH bpf-next 6/7] xsk: load a builtin XDP program on XDP_ATTACH

2018-12-07 Thread Björn Töpel
From: Björn Töpel This commit extends the XDP_ATTACH bind option by loading a builtin XDP program. The builtin program is the simplest program possible to redirect a frame to an attached socket. In restricted C it would look like this: SEC("xdp") int xdp_prog(struct xdp_md *ctx) {

[PATCH bpf-next 5/7] bpf: add function to load builtin BPF program

2018-12-07 Thread Björn Töpel
From: Björn Töpel The added bpf_prog_load_builtin can be used to load and verify a BPF program that originates from the kernel. We call this a "builtin BPF program". A builtin program can be used for convenience, e.g. it allows for the kernel to use the bpf infrastructure for internal tasks.

Re: [PATCH net-next 4/4] net: aquantia: add support of RSS configuration

2018-12-07 Thread Igor Russkikh
>> +/* Fill out the redirection table */ >> +if (indir) { >> +/* Verify user input. */ >> +for (i = 0; i < rss_entries; i++) >> +if (indir[i] >= cfg->num_rss_queues) >> +return -EINVAL; > > nit: you shouldn't have to

Re: [PATCH] gianfar: Add gfar_change_carrier()

2018-12-07 Thread Joakim Tjernlund
On Thu, 2018-12-06 at 20:43 +0100, Andrew Lunn wrote: > CAUTION: This email originated from outside of the organization. Do not click > links or open attachments unless you recognize the sender and know the > content is safe. > > > > I can have a look at using dormant, but what is

Re: [PATCH] gianfar: Add gfar_change_carrier()

2018-12-07 Thread Andrew Lunn
> Been a bit busy today but now I have played with dormant using ip link and > got some odd results: > # > ifconfig eth0 > eth0: flags=4163 mtu 1500 > inet 172.20.0.246 netmask 255.255.0.0 broadcast 172.20.255.255 > inet6 fe80::ad9c:b230:1da8:1821 prefixlen 64 scopeid 0x20 >

Re: [PATCH] net: Fix xps_needed inc/dec mismatch

2018-12-07 Thread Sabrina Dubroca
Hi Ross, 2018-12-07, 10:16:21 +, Ross Lagerwall wrote: > xps_needed is incremented only when a new dev map is allocated (in > __netif_set_xps_queue). Therefore it should be decremented only when we > actually have a dev map to destroy. Without this, it may be decremented > too many times

Re: [RFC PATCH 4/6] dt-bindings: update mvneta binding document

2018-12-07 Thread Russell King - ARM Linux
On Fri, Dec 07, 2018 at 04:43:27PM +0530, Kishon Vijay Abraham I wrote: > Russell, > > No, I haven't merged patches from this series. That would have failed > compilation since Grygorii modified enum phy_mode which is used in this > series. > You have also noted this in your cover letter. Ok,

Re: [RFC PATCH 4/6] dt-bindings: update mvneta binding document

2018-12-07 Thread Kishon Vijay Abraham I
Hi, On 07/12/18 5:03 PM, Russell King - ARM Linux wrote: > On Fri, Dec 07, 2018 at 04:43:27PM +0530, Kishon Vijay Abraham I wrote: >> Russell, >> >> No, I haven't merged patches from this series. That would have failed >> compilation since Grygorii modified enum phy_mode which is used in this >>

Re: [PATCH bpf-next 0/7] Add XDP_ATTACH bind() flag to AF_XDP sockets

2018-12-07 Thread Björn Töpel
Den fre 7 dec. 2018 kl 14:42 skrev Jesper Dangaard Brouer : > > On Fri, 7 Dec 2018 12:44:24 +0100 > Björn Töpel wrote: > > > The rationale behind attach is performance and ease of use. Many XDP > > socket users just need a simple way of creating/binding a socket and > > receiving frames right

[PATCH v2 bpf-next] bpf: relax verifier restriction on BPF_MOV | BPF_ALU

2018-12-07 Thread Jiong Wang
Currently, the destination register is marked as unknown for 32-bit sub-register move (BPF_MOV | BPF_ALU) whenever the source register type is SCALAR_VALUE. This is too conservative that some valid cases will be rejected. Especially, this may turn a constant scalar value into unknown value that

Re: [PATCH] gianfar: Add gfar_change_carrier()

2018-12-07 Thread Joakim Tjernlund
On Fri, 2018-12-07 at 15:15 +0100, Andrew Lunn wrote: > > > > Been a bit busy today but now I have played with dormant using ip link and > > got some odd results: > > # > ifconfig eth0 > > eth0: flags=4163 mtu 1500 > > inet 172.20.0.246 netmask 255.255.0.0 broadcast 172.20.255.255 >

Re: [PATCH v2 net-next 0/8] dpaa2-eth: Introduce XDP support

2018-12-07 Thread Ilias Apalodimas
Hi Ioana, > > > > > > I only did a quick grep around the driver so i might be missing something, > > but i can only see allocations via napi_alloc_frag(). XDP requires pages > > (either a single page per packet or a driver that does the page management > > of > > its own and fits 2 frames in a

Re: IP fragmentation performance and don't fragment bug when forwarding

2018-12-07 Thread Risto Pajula
Hello. I have been to track the poor forwarding latency to the TCP Window scale options. The Netgem device uses rather large windows scale options (x256) and I have been able to reproduce the routers poor forwarding latency also with linux box running in the internal network and changing the

Re: [PATCH bpf-next 0/7] Add XDP_ATTACH bind() flag to AF_XDP sockets

2018-12-07 Thread Björn Töpel
Den fre 7 dec. 2018 kl 14:42 skrev Jesper Dangaard Brouer : > > On Fri, 7 Dec 2018 12:44:24 +0100 > Björn Töpel wrote: > > > The rationale behind attach is performance and ease of use. Many XDP > > socket users just need a simple way of creating/binding a socket and > > receiving frames right

Re: [PATCH] gianfar: Add gfar_change_carrier()

2018-12-07 Thread Andrew Lunn
> Would you be happier if .ndo_change_carrier() only acted on Fixed PHYs? I think it makes sense to allow a fixed phy carrier to be changed from user space. However, i don't think you can easily plumb that to .ndo_change_carrier(), since that is a MAC feature. You need to change the

[PATCH] net: ethernet: ti: cpsw: Assign OF node to slave devices

2018-12-07 Thread Marek Vasut
Assign OF node to CPSW slave devices, otherwise it is not possible to bind eg. DSA switch to them. Without this patch, the DSA code tries to find the ethernet device by OF match, but fails to do so because the slave device has NULL OF node. Signed-off-by: Marek Vasut Cc: David S. Miller Cc:

RE: [PATCH v2 net-next 0/8] dpaa2-eth: Introduce XDP support

2018-12-07 Thread Ioana Ciocoi Radulescu
> -Original Message- > From: Ilias Apalodimas > Sent: Friday, December 7, 2018 7:20 PM > To: Ioana Ciocoi Radulescu > Cc: Jesper Dangaard Brouer ; > netdev@vger.kernel.org; da...@davemloft.net; Ioana Ciornei > ; dsah...@gmail.com; Camelia Alexandra Groza > > Subject: Re: [PATCH v2

Re: [PATCH] net: Fix xps_needed inc/dec mismatch

2018-12-07 Thread Ross Lagerwall
On 12/7/18 11:01 AM, Sabrina Dubroca wrote: Hi Ross, 2018-12-07, 10:16:21 +, Ross Lagerwall wrote: xps_needed is incremented only when a new dev map is allocated (in __netif_set_xps_queue). Therefore it should be decremented only when we actually have a dev map to destroy. Without this, it

Re: [PATCH] bpf: fix overflow of bpf_jit_limit when PAGE_SIZE >= 64K

2018-12-07 Thread Michael Roth
Quoting Michael Ellerman (2018-12-07 06:31:13) > Michael Roth writes: > > > Commit ede95a63b5 introduced a bpf_jit_limit tuneable to limit BPF > > JIT allocations. At compile time it defaults to PAGE_SIZE * 4, > > and is adjusted again at init time if MODULES_VADDR is defined. > > > > For

RE: [PATCH v2 net-next 0/8] dpaa2-eth: Introduce XDP support

2018-12-07 Thread Ioana Ciocoi Radulescu
> -Original Message- > From: Jesper Dangaard Brouer > Sent: Wednesday, December 5, 2018 5:45 PM > To: Ioana Ciocoi Radulescu > Cc: bro...@redhat.com; netdev@vger.kernel.org; da...@davemloft.net; > Ioana Ciornei ; dsah...@gmail.com; Camelia > Alexandra Groza ; Ilias Apalodimas > >

Re: OMAP4430 SDP with KS8851: very slow networking

2018-12-07 Thread Russell King - ARM Linux
Hi Tony, You know most of what's been going on from IRC, but here's the patch which gets me: 1) working interrupts for networking 2) solves the stuck-wakeup problem It also contains some of the debug bits I added. I think what this means is that we should strip out ec0daae685b2 ("gpio: omap:

[PATCH] net: dsa: ksz: Add reset GPIO handling

2018-12-07 Thread Marek Vasut
Add code to handle optional reset GPIO in the KSZ switch driver. The switch has a reset GPIO line which can be controlled by the CPU, so make sure it is configured correctly in such setups. Signed-off-by: Marek Vasut Cc: Vivien Didelot Cc: Woojung Huh Cc: David S. Miller Cc: Tristram Ha ---

[PATCH] net: dsa: ksz: Increase the tag alignment

2018-12-07 Thread Marek Vasut
Make sure to cater even for network packets with VLAN tags in them, increase the minimal packets size to account for those. Signed-off-by: Marek Vasut Cc: Vivien Didelot Cc: Woojung Huh Cc: David S. Miller Cc: Tristram Ha --- net/dsa/tag_ksz.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH] net: dsa: ksz: Fix port membership

2018-12-07 Thread Marek Vasut
If two ports are in the same bridge and in forwarding state, the packets must be able to pass between them in both directions. The current code only configures this bridge membership for a port newly added to the bridge, but does not update all the other ports. Thus, ingress packets on the new

Re: [PATCH bpf-next] bpf: relax verifier restriction on BPF_MOV | BPF_ALU

2018-12-07 Thread Jiong Wang
On 06/12/2018 03:13, Alexei Starovoitov wrote: On Wed, Dec 05, 2018 at 03:32:50PM +, Jiong Wang wrote: On 05/12/2018 14:52, Edward Cree wrote: On 05/12/18 09:46, Jiong Wang wrote: There is NO processed instruction number regression, either with or without -mattr=+alu32. Cilium bpf ===

Re: [PATCH v2 net-next 0/8] dpaa2-eth: Introduce XDP support

2018-12-07 Thread Ilias Apalodimas
Hi Ioana, > > > > > Add support for XDP programs. Only XDP_PASS, XDP_DROP and XDP_TX > > > actions are supported for now. Frame header changes are also > > > allowed. I only did a quick grep around the driver so i might be missing something, but i can only see allocations via napi_alloc_frag().

Re: OMAP4430 SDP with KS8851: very slow networking

2018-12-07 Thread Russell King - ARM Linux
On Fri, Dec 07, 2018 at 11:03:12AM -0800, Tony Lindgren wrote: > * Tony Lindgren [181207 18:14]: > > Hi, > > > > * Russell King - ARM Linux [181207 18:01]: > > > Hi Tony, > > > > > > You know most of what's been going on from IRC, but here's the patch > > > which gets me: > > > > > > 1)

[PATCH v2 net-next] neighbor: Improve garbage collection

2018-12-07 Thread David Ahern
From: David Ahern The existing garbage collection algorithm has a number of problems: 1. The gc algorithm will not evict PERMANENT entries as those entries are managed by userspace, yet the existing algorithm walks the entire hash table which means it always considers PERMANENT entries

Re: [PATCH] gianfar: Add gfar_change_carrier()

2018-12-07 Thread Florian Fainelli
On 12/7/18 9:26 AM, Andrew Lunn wrote: >> Would you be happier if .ndo_change_carrier() only acted on Fixed PHYs? > > I think it makes sense to allow a fixed phy carrier to be changed from > user space. However, i don't think you can easily plumb that to > .ndo_change_carrier(), since that is a

Re: [PATCH 1/5] net: dsa: ksz: Add MIB counter reading support

2018-12-07 Thread David Miller
Every patch series should have a header posting with Subject of the form "[PATCH 0/N] ..." explaining what the series does at a high level, how it does it, and why it does it that way.

I wait to hear from you.

2018-12-07 Thread Mr. David Abraham
My Greeting, How are you today?Did you receive the letter i sent to you. Please answer me. Best Regard, Mr.David Abraham.

[PATCH 5/5] net: dsa: ksz: Add Microchip KSZ8795 DSA driver

2018-12-07 Thread Marek Vasut
From: Tristram Ha Add Microchip KSZ8795 DSA driver. Signed-off-by: Tristram Ha Signed-off-by: Marek Vasut Cc: Vivien Didelot Cc: Woojung Huh Cc: David S. Miller --- drivers/net/dsa/microchip/Kconfig | 17 + drivers/net/dsa/microchip/Makefile |2 +

Re: [PATCH] net: dsa: ksz: Add reset GPIO handling

2018-12-07 Thread Andrew Lunn
> + dev->reset_gpio = -1; > + reset_gpio = of_get_named_gpio_flags(np, "reset-gpios", 0, > + _gpio_flags); > + if (reset_gpio >= 0) { > + flags = (reset_gpio_flags == OF_GPIO_ACTIVE_LOW) ? > + GPIOF_ACTIVE_LOW :

Re: [PATCH] net: dsa: ksz: Fix port membership

2018-12-07 Thread Marek Vasut
On 12/07/2018 08:37 PM, tristram...@microchip.com wrote: >> If two ports are in the same bridge and in forwarding state, the packets >> must be able to pass between them in both directions. The current code >> only configures this bridge membership for a port newly added to the >> bridge, but does

Re: [PATCH rdma-next 0/3] Packet based credit mode

2018-12-07 Thread Jason Gunthorpe
On Fri, Dec 07, 2018 at 08:04:26AM +0200, Leon Romanovsky wrote: > On Thu, Dec 06, 2018 at 08:27:06PM -0700, Jason Gunthorpe wrote: > > On Fri, Nov 30, 2018 at 01:22:03PM +0200, Leon Romanovsky wrote: > > > From: Leon Romanovsky > > > > > > >From Danit, > > > > > > Packet based credit mode is an

Re: [PATCH net-next v2 0/4] net: mitigate retpoline overhead

2018-12-07 Thread Paolo Abeni
Hi, On Thu, 2018-12-06 at 22:28 -0800, David Miller wrote: > From: David Miller > Date: Thu, 06 Dec 2018 22:24:09 -0800 (PST) > > > Series applied, thanks! > > Erm... actually reverted. Please fix these build failures: oops ... I'm sorry for the late reply. I'm travelling and I will not able

Re: OMAP4430 SDP with KS8851: very slow networking

2018-12-07 Thread Tony Lindgren
* Russell King - ARM Linux [181207 19:27]: > You mentioned that edge mode didn't work as well as level mode on > duovero smsc controller, I think this may help to solve the same > issue but for edge IRQs - we need a mask_ack_irq function to avoid > acking while the edge interrupt is masked. Let

RE: [PATCH v2 net-next 0/8] dpaa2-eth: Introduce XDP support

2018-12-07 Thread Ioana Ciocoi Radulescu
> -Original Message- > From: Ilias Apalodimas > Sent: Friday, December 7, 2018 7:52 PM > To: Ioana Ciocoi Radulescu > Cc: Jesper Dangaard Brouer ; > netdev@vger.kernel.org; da...@davemloft.net; Ioana Ciornei > ; dsah...@gmail.com; Camelia Alexandra Groza > > Subject: Re: [PATCH v2

[PATCH 1/5] net: dsa: ksz: Add MIB counter reading support

2018-12-07 Thread Marek Vasut
From: Tristram Ha Add MIB counter reading support to KSZ9477 driver. This makes the MIB counter code more generic by removing the TOTAL_SWITCH_COUNTER_NUM and instead making that configurable per switch model. Signed-off-by: Tristram Ha Signed-off-by: Marek Vasut Cc: Vivien Didelot Cc:

[PATCH 2/5] net: dsa: ksz: Rename NET_DSA_TAG_KSZ to _KSZ9477

2018-12-07 Thread Marek Vasut
From: Tristram Ha Rename the tag Kconfig option and related macros in preparation for addition of new KSZ family switches with different tag formats. Signed-off-by: Tristram Ha Signed-off-by: Marek Vasut Cc: Vivien Didelot Cc: Woojung Huh Cc: David S. Miller ---

[PATCH 3/5] net: dsa: ksz: Factor out common tag code

2018-12-07 Thread Marek Vasut
From: Tristram Ha Factor out common code from the tag_ksz , so that the code can be used with other KSZ family switches which use differenly sized tags. Signed-off-by: Tristram Ha Signed-off-by: Marek Vasut Cc: Vivien Didelot Cc: Woojung Huh Cc: David S. Miller --- net/dsa/tag_ksz.c | 125

[PATCH 4/5] net: dsa: ksz: Add KSZ8795 tag code

2018-12-07 Thread Marek Vasut
From: Tristram Ha Add DSA tag code for Microchip KSZ8795 switch. The switch is simpler and the tag is only 1 byte, instead of 2 as is the case with KSZ9477. Signed-off-by: Tristram Ha Signed-off-by: Marek Vasut Cc: Vivien Didelot Cc: Woojung Huh Cc: David S. Miller --- include/net/dsa.h

RE: [PATCH] net: dsa: ksz: Fix port membership

2018-12-07 Thread Tristram.Ha
> If two ports are in the same bridge and in forwarding state, the packets > must be able to pass between them in both directions. The current code > only configures this bridge membership for a port newly added to the > bridge, but does not update all the other ports. Thus, ingress packets > on

Re: [PATCH v2 net-next 0/4] net: aquantia: add RSS configuration

2018-12-07 Thread David Miller
From: Igor Russkikh Date: Fri, 7 Dec 2018 14:00:09 + > In this patchset few bugs related to RSS are fixed and RSS table and > hash key configuration is added. > > We also do increase max number of HW rings upto 8. > > v2: removed extra arg check Series applied.

Re: OMAP4430 SDP with KS8851: very slow networking

2018-12-07 Thread Tony Lindgren
* Tony Lindgren [181207 18:14]: > Hi, > > * Russell King - ARM Linux [181207 18:01]: > > Hi Tony, > > > > You know most of what's been going on from IRC, but here's the patch > > which gets me: > > > > 1) working interrupts for networking > > 2) solves the stuck-wakeup problem > > > > It

Re: [PATCH] net: dsa: ksz: Fix port membership

2018-12-07 Thread Andrew Lunn
> I think if you do this without setting offload_fwd_mark you will > receive duplicate frame. I don't think it will, at least not in the normal case. The hardware should know the egress port, so there is no need to forward a copy to the CPU. The only time it should forward to the CPU is when the

Re: OMAP4430 SDP with KS8851: very slow networking

2018-12-07 Thread Tony Lindgren
Hi, * Russell King - ARM Linux [181207 18:01]: > Hi Tony, > > You know most of what's been going on from IRC, but here's the patch > which gets me: > > 1) working interrupts for networking > 2) solves the stuck-wakeup problem > > It also contains some of the debug bits I added. This is

Re: [PATCH bpf-next] bpf: relax verifier restriction on BPF_MOV | BPF_ALU

2018-12-07 Thread Alexei Starovoitov
On Fri, Dec 07, 2018 at 05:19:21PM +, Jiong Wang wrote: > On 06/12/2018 03:13, Alexei Starovoitov wrote: > > On Wed, Dec 05, 2018 at 03:32:50PM +, Jiong Wang wrote: > > > On 05/12/2018 14:52, Edward Cree wrote: > > > > On 05/12/18 09:46, Jiong Wang wrote: > > > > > There is NO processed

Re: [PATCH] net: dsa: ksz: Fix port membership

2018-12-07 Thread Florian Fainelli
On 12/7/18 11:37 AM, tristram...@microchip.com wrote: >> If two ports are in the same bridge and in forwarding state, the packets >> must be able to pass between them in both directions. The current code >> only configures this bridge membership for a port newly added to the >> bridge, but does

Re: [PATCH net-next] neighbour: Improve garbage collection

2018-12-07 Thread David Ahern
On 12/6/18 8:59 PM, David Miller wrote: > But why do you need the on_gc_list boolean state? f mental blockage. v2 coming up.

Re: [PATCH net] ipv6: sr: properly initialize flowi6 prior passing to ip6_route_output

2018-12-07 Thread David Miller
From: Shmulik Ladkani Date: Fri, 7 Dec 2018 09:50:17 +0200 > In 'seg6_output', stack variable 'struct flowi6 fl6' was missing > initialization. > > Fixes: 6c8702c60b88 ("ipv6: sr: add support for SRH encapsulation and > injection with lwtunnels") > Signed-off-by: Shmulik Ladkani Applied and

Re: [PATCH iproute2-next 0/2] devlink: Add support for 'fw_load_policy' generic parameter

2018-12-07 Thread David Ahern
On 12/4/18 3:14 AM, Shalom Toledo wrote: > Patch #1 add string to uint conversion support for generic parameters. > Patch #2 add string to uint support for 'fw_load_policy' generic parameter > > Shalom Toledo (2): > devlink: Add string to uint{8,16,32} conversion for generic parameters >

Re: [PATCH bpf 1/2] selftests/bpf: use thoff instead of nhoff in BPF flow dissector

2018-12-07 Thread Alexei Starovoitov
On Wed, Dec 05, 2018 at 08:40:47PM -0800, Stanislav Fomichev wrote: > We are returning thoff from the flow dissector, not the nhoff. Pass > thoff along with nhoff to the bpf program (initially thoff == nhoff) > and expect flow dissector amend/return thoff, not nhoff. > > This avoids confusion,

Re: [PATCH net-next] neighbor: Add protocol attribute

2018-12-07 Thread David Ahern
On 12/7/18 3:20 PM, Eric Dumazet wrote: > > > On 12/07/2018 01:49 PM, David Ahern wrote: >> From: David Ahern >> >> Similar to routes and rules, add protocol attribute to neighbor entries >> for easier tracking of how each was created. >> >> Signed-off-by: David Ahern >> --- >>

Re: [PATCH V2] net: dsa: ksz: Add reset GPIO handling

2018-12-07 Thread Marek Vasut
On 12/07/2018 11:24 PM, Andrew Lunn wrote: > On Fri, Dec 07, 2018 at 10:51:36PM +0100, Marek Vasut wrote: >> Add code to handle optional reset GPIO in the KSZ switch driver. The switch >> has a reset GPIO line which can be controlled by the CPU, so make sure it is >> configured correctly in such

[PATCH bpf-next 2/7] bpf: tools: Sync uapi bpf.h

2018-12-07 Thread Martin KaFai Lau
Sync uapi bpf.h to tools/include/uapi/linux for the new bpf_line_info. Signed-off-by: Martin KaFai Lau Acked-by: Yonghong Song --- tools/include/uapi/linux/bpf.h | 19 +++ 1 file changed, 19 insertions(+) diff --git a/tools/include/uapi/linux/bpf.h

[PATCH bpf-next 1/7] bpf: Add bpf_line_info support

2018-12-07 Thread Martin KaFai Lau
This patch adds bpf_line_info support. It accepts an array of bpf_line_info objects during BPF_PROG_LOAD. The "line_info", "line_info_cnt" and "line_info_rec_size" are added to the "union bpf_attr". The "line_info_rec_size" makes bpf_line_info extensible in the future. The new

[PATCH bpf-next 6/7] bpf: libbpf: Add btf_line_info support to libbpf

2018-12-07 Thread Martin KaFai Lau
This patch adds bpf_line_info support to libbpf: 1) Parsing the line_info sec from ".BTF.ext" 2) Relocating the line_info. If the main prog *_info relocation fails, it will ignore the remaining subprog line_info and continue. If the subprog *_info relocation fails, it will bail out. 3)

Re: [PATCH v2 bpf-next 0/7] bpf: support BPF_ALU | BPF_ARSH

2018-12-07 Thread Alexei Starovoitov
On Wed, Dec 05, 2018 at 01:52:29PM -0500, Jiong Wang wrote: > BPF_ALU | BPF_ARSH | BPF_* were rejected by commit: 7891a87efc71 > ("bpf: arsh is not supported in 32 bit alu thus reject it"). As explained > in the commit message, this is due to there is no complete support for them > on interpreter

Re: [PATCH V2] net: dsa: ksz: Add reset GPIO handling

2018-12-07 Thread David Miller
From: Marek Vasut Date: Fri, 7 Dec 2018 23:59:58 +0100 > On 12/07/2018 11:24 PM, Andrew Lunn wrote: >> On Fri, Dec 07, 2018 at 10:51:36PM +0100, Marek Vasut wrote: >>> Add code to handle optional reset GPIO in the KSZ switch driver. The switch >>> has a reset GPIO line which can be controlled by

Re: [PATCH net-next] neighbor: Add protocol attribute

2018-12-07 Thread David Miller
From: Eric Dumazet Date: Fri, 7 Dec 2018 15:03:04 -0800 > On 12/07/2018 02:24 PM, David Ahern wrote: >> On 12/7/18 3:20 PM, Eric Dumazet wrote: >> >> /* --- cacheline 3 boundary (192 bytes) --- */ >> struct hh_cachehh; /* 19248 */ >> >> ... >> >> but does

Re: [PATCH v2 net-next] neighbor: Improve garbage collection

2018-12-07 Thread David Miller
From: David Ahern Date: Fri, 7 Dec 2018 12:24:57 -0800 > From: David Ahern > > The existing garbage collection algorithm has a number of problems: ... > This patch addresses these problems as follows: > > 1. Use of a separate list_head to track entries that can be garbage >collected

Re: [Patch v2 net-next] call sk_dst_reset when set SO_DONTROUTE

2018-12-07 Thread David Miller
From: yupeng Date: Wed, 5 Dec 2018 18:56:28 -0800 > after set SO_DONTROUTE to 1, the IP layer should not route packets if > the dest IP address is not in link scope. But if the socket has cached > the dst_entry, such packets would be routed until the sk_dst_cache > expires. So we should clean

RE: [PATCH] net: dsa: ksz: Fix port membership

2018-12-07 Thread Tristram.Ha
> Do you have a git tree with all the KSZ patches based on -next > somewhere, so I don't have to look for them in random MLs ? I just sent it this Monday and the subject for that patch is "[PATCH RFC 6/6] net: dsa: microchip: Add switch offload forwarding support."

Re: [PATCH] net-udp: deprioritize cpu match for udp socket lookup

2018-12-07 Thread David Miller
From: Maciej Żenczykowski Date: Wed, 5 Dec 2018 12:59:17 -0800 > From: Maciej Żenczykowski > > During udp socket lookup cpu match should be lowest priority, > hence it should increase score by only 1. > > The next priority is delivering v4 to v4 sockets, and v6 to v6 sockets. > The v6 code

Re: [PATCH net-next 0/4] tc-testing: implement command timeouts and better results tracking

2018-12-07 Thread David Miller
From: Lucas Bates Date: Thu, 6 Dec 2018 17:42:23 -0500 > Patch 1 adds a timeout feature for any command tdc launches in a subshell. > This prevents tdc from hanging indefinitely. > > Patches 2-4 introduce a new method for tracking and generating test case > results, and implements it across

[PATCH V2] net: dsa: ksz: Add reset GPIO handling

2018-12-07 Thread Marek Vasut
Add code to handle optional reset GPIO in the KSZ switch driver. The switch has a reset GPIO line which can be controlled by the CPU, so make sure it is configured correctly in such setups. Signed-off-by: Marek Vasut Cc: Vivien Didelot Cc: Woojung Huh Cc: David S. Miller Cc: Tristram Ha ---

Re: [PATCH] net: dsa: ksz: Add reset GPIO handling

2018-12-07 Thread Marek Vasut
On 12/07/2018 08:55 PM, Andrew Lunn wrote: >> +dev->reset_gpio = -1; >> +reset_gpio = of_get_named_gpio_flags(np, "reset-gpios", 0, >> + _gpio_flags); >> +if (reset_gpio >= 0) { >> +flags = (reset_gpio_flags == OF_GPIO_ACTIVE_LOW) ?

Re: [PATCH net-next] neighbor: Add protocol attribute

2018-12-07 Thread Eric Dumazet
On 12/07/2018 02:24 PM, David Ahern wrote: > On 12/7/18 3:20 PM, Eric Dumazet wrote: >> >> >> On 12/07/2018 01:49 PM, David Ahern wrote: >>> From: David Ahern >>> >>> Similar to routes and rules, add protocol attribute to neighbor entries >>> for easier tracking of how each was created. >>>

RE: [PATCH] net: dsa: ksz: Fix port membership

2018-12-07 Thread Tristram.Ha
> > I think if you do this without setting offload_fwd_mark you will > > receive duplicate frame. > > I don't think it will, at least not in the normal case. The hardware > should know the egress port, so there is no need to forward a copy to > the CPU. The only time it should forward to the CPU

Re: [PATCH net] tcp: lack of available data can also cause TSO defer

2018-12-07 Thread David Miller
From: Eric Dumazet Date: Thu, 6 Dec 2018 09:58:24 -0800 > tcp_tso_should_defer() can return true in three different cases : > > 1) We are cwnd-limited > 2) We are rwnd-limited > 3) We are application limited. > > Neal pointed out that my recent fix went too far, since > it assumed that if

[PATCH bpf-next 3/7] bpf: Refactor and bug fix in test_func_type in test_btf.c

2018-12-07 Thread Martin KaFai Lau
1) bpf_load_program_xattr() is absorbing the EBIG error which makes testing this case impossible. It is replaced with a direct syscall(__NR_bpf, BPF_PROG_LOAD,...). 2) The test_func_type() is renamed to test_info_raw() to prepare for the new line_info test in the next patch. 3) The

[PATCH bpf-next 0/7] Introduce bpf_line_info

2018-12-07 Thread Martin KaFai Lau
This patch series introduces the bpf_line_info. Please see individual patch for details. It will be useful for introspection purpose, like: [root@arch-fb-vm1 bpf]# ~/devshare/fb-kernel/linux/tools/bpf/bpftool/bpftool prog dump jited pinned /sys/fs/bpf/test_btf_haskv [...] int

[PATCH bpf-next 7/7] bpf: libbpf: bpftool: Print bpf_line_info during prog dump

2018-12-07 Thread Martin KaFai Lau
This patch adds print bpf_line_info function in 'prog dump jitted' and 'prog dump xlated': [root@arch-fb-vm1 bpf]# ~/devshare/fb-kernel/linux/tools/bpf/bpftool/bpftool prog dump jited pinned /sys/fs/bpf/test_btf_haskv [...] int test_long_fname_2(struct dummy_tracepoint_args * arg):

[PATCH bpf-next 4/7] bpf: Add unit tests for bpf_line_info

2018-12-07 Thread Martin KaFai Lau
Add unit tests for bpf_line_info for both BPF_PROG_LOAD and BPF_OBJ_GET_INFO_BY_FD. jit enabled: [root@arch-fb-vm1 bpf]# ./test_btf -k 0 BTF prog info raw test[5] (line_info (No subprog)): OK BTF prog info raw test[6] (line_info (No subprog. insn_off >= prog->len)): OK BTF prog info raw test[7]

[PATCH bpf-next 5/7] bpf: libbpf: Refactor and bug fix on the bpf_func_info loading logic

2018-12-07 Thread Martin KaFai Lau
This patch refactor and fix a bug in the libbpf's bpf_func_info loading logic. The bug fix and refactoring are targeting the same commit 2993e0515bb4 ("tools/bpf: add support to read .BTF.ext sections") which is in the bpf-next branch. 1) In bpf_load_program_xattr(), it should retry when errno

Re: [PATCH bpf-next 0/7] Add XDP_ATTACH bind() flag to AF_XDP sockets

2018-12-07 Thread Alexei Starovoitov
On Fri, Dec 07, 2018 at 12:44:24PM +0100, Björn Töpel wrote: > From: Björn Töpel > > Hi! > > This patch set adds support for a new XDP socket bind option, > XDP_ATTACH. > > The rationale behind attach is performance and ease of use. Many XDP > socket users just need a simple way of

Re: [PATCH V2] net: dsa: ksz: Add reset GPIO handling

2018-12-07 Thread Andrew Lunn
On Fri, Dec 07, 2018 at 10:51:36PM +0100, Marek Vasut wrote: > Add code to handle optional reset GPIO in the KSZ switch driver. The switch > has a reset GPIO line which can be controlled by the CPU, so make sure it is > configured correctly in such setups. Hi Marek Please make this a patch

Re: [PATCH] net-udp: deprioritize cpu match for udp socket lookup

2018-12-07 Thread Maciej Żenczykowski
> This doesn't apply to the current net tree. > > Also "net-udp: " is a weird subsystem prefix, just use "udp: ". > > Thank you. Interesting... this patch was on top of net-next/master, and it still rebases cleanly on current net-next/master. Would you like it on net/master instead? It indeed

[PATCH net-next] neighbor: Add protocol attribute

2018-12-07 Thread David Ahern
From: David Ahern Similar to routes and rules, add protocol attribute to neighbor entries for easier tracking of how each was created. Signed-off-by: David Ahern --- include/net/neighbour.h| 2 ++ include/uapi/linux/neighbour.h | 1 + net/core/neighbour.c | 24

[PATCH] net: dsa: Add optional reset GPIO to Microchip KSZ switch binding

2018-12-07 Thread Marek Vasut
Add optional reset GPIO, as such a signal is available on the KSZ switches. Signed-off-by: Marek Vasut Cc: Andrew Lunn Cc: Florian Fainelli Cc: Woojung Huh Cc: David S. Miller --- Documentation/devicetree/bindings/net/dsa/ksz.txt | 4 1 file changed, 4 insertions(+) diff --git

Re: [PATCH net-next] neighbor: Add protocol attribute

2018-12-07 Thread Eric Dumazet
On 12/07/2018 01:49 PM, David Ahern wrote: > From: David Ahern > > Similar to routes and rules, add protocol attribute to neighbor entries > for easier tracking of how each was created. > > Signed-off-by: David Ahern > --- > include/net/neighbour.h| 2 ++ >

  1   2   >