[PATCH net v3 2/5] fsl/fman: fix dereference null return value

2020-08-03 Thread Florinel Iordache
Check before using returned value to avoid dereferencing null pointer. Fixes: 18a6c85fcc78 ("fsl/fman: Add FMan Port Support") Signed-off-by: Florinel Iordache --- drivers/net/ethernet/freescale/fman/fman_port.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/

[PATCH net v3 3/5] fsl/fman: fix unreachable code

2020-08-03 Thread Florinel Iordache
The parameter 'priority' is incorrectly forced to zero which ultimately induces logically dead code in the subsequent lines. Fixes: 57ba4c9b56d8 ("fsl/fman: Add FMan MAC support") Signed-off-by: Florinel Iordache --- drivers/net/ethernet/freescale/fman/fman_memac.c | 1 - 1 file changed, 1 delet

[PATCH net v3 0/5] DPAA FMan driver fixes

2020-08-03 Thread Florinel Iordache
Here are several fixes for the DPAA FMan driver. v2 changes: * corrected patch 4 by removing the line added by mistake * used longer fixes tags with the first 12 characters of the SHA-1 ID v3 changes: * remove the empty line inserted after fixes tag Florinel Iordache (5): fsl/fman: use 32-bit

[PATCH net v3 4/5] fsl/fman: check dereferencing null pointer

2020-08-03 Thread Florinel Iordache
Add a safe check to avoid dereferencing null pointer Fixes: 57ba4c9b56d8 ("fsl/fman: Add FMan MAC support") Signed-off-by: Florinel Iordache --- drivers/net/ethernet/freescale/fman/fman_dtsec.c | 4 ++-- drivers/net/ethernet/freescale/fman/fman_memac.c | 2 +- drivers/net/ethernet/freescale/fman

[PATCH net v3 5/5] fsl/fman: fix eth hash table allocation

2020-08-03 Thread Florinel Iordache
Fix memory allocation for ethernet address hash table. The code was wrongly allocating an array for eth hash table which is incorrect because this is the main structure for eth hash table (struct eth_hash_t) that contains inside a number of elements. Fixes: 57ba4c9b56d8 ("fsl/fman: Add FMan MAC su

[PATCH net v3 1/5] fsl/fman: use 32-bit unsigned integer

2020-08-03 Thread Florinel Iordache
Potentially overflowing expression (ts_freq << 16 and intgr << 16) declared as type u32 (32-bit unsigned) is evaluated using 32-bit arithmetic and then used in a context that expects an expression of type u64 (64-bit unsigned) which ultimately is used as 16-bit unsigned by typecasting to u16. Fixed

Re: [PATCH net 2/2] net/sched: act_ct: Set offload timeout when setting the offload bit

2020-08-03 Thread Roi Dayan
On 2020-07-29 8:10 PM, Marcelo Ricardo Leitner wrote: > On Wed, Jul 29, 2020 at 03:55:53PM +0300, Roi Dayan wrote: >> >> >> On 2020-07-28 5:42 PM, Marcelo Ricardo Leitner wrote: >>> On Tue, Jul 28, 2020 at 02:57:59PM +0300, Roi Dayan wrote: On heavily loaded systems the GC can take time to

[PATCH] qmi_wwan: support modify usbnet's rx_urb_size

2020-08-03 Thread yzc666
From: carl When QMUX enabled, the 'dl-datagram-max-size' can be 4KB/16KB/31KB depend on QUALCOMM's chipsets. User can set 'dl-datagram-max-size' by 'QMI_WDA_SET_DATA_FORMAT'. The usbnet's rx_urb_size must lager than or equal to the 'dl-datagram-max-size'. This patch allow user t

[PATCH bpf-next v2 1/2] bpf: change uapi for bpf iterator map elements

2020-08-03 Thread Yonghong Song
Commit a5cbe05a6673 ("bpf: Implement bpf iterator for map elements") added bpf iterator support for map elements. The map element bpf iterator requires info to identify a particular map. In the above commit, the attr->link_create.target_fd is used to carry map_fd and an enum bpf_iter_link_info is a

[PATCH net v2 2/2] netfilter: flowtable: Set offload timeout when adding flow

2020-08-03 Thread Roi Dayan
On heavily loaded systems the GC can take time to go over all existing conns and reset their timeout. At that time other calls like from nf_conntrack_in() can call of nf_ct_is_expired() and see the conn as expired. To fix this when we set the offload bit we should also reset the timeout instead of

[PATCH bpf-next v2 2/2] tools/bpf: support new uapi for map element bpf iterator

2020-08-03 Thread Yonghong Song
Previous commit adjusted kernel uapi for map element bpf iterator. This patch adjusted libbpf API due to uapi change. bpftool and bpf_iter selftests are also changed accordingly. Signed-off-by: Yonghong Song --- tools/bpf/bpftool/iter.c | 8 +++-- tools/include/uapi/linux/b

[PATCH net v2 1/2] netfilter: conntrack: Move nf_ct_offload_timeout to header file

2020-08-03 Thread Roi Dayan
To be used by callers from other modules. Signed-off-by: Roi Dayan Reviewed-by: Oz Shlomo --- include/net/netfilter/nf_conntrack.h | 12 net/netfilter/nf_conntrack_core.c| 12 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/include/net/netfilter/nf

[PATCH bpf-next v2 0/2] bpf: change uapi for bpf iterator map elements

2020-08-03 Thread Yonghong Song
Andrii raised a concern that current uapi for bpf iterator map element is a little restrictive and not suitable for future potential complex customization. This is a valid suggestion, considering people may indeed add more complex custimization to the iterator, e.g., cgroup_id + user_id, etc. for t

[PATCH net v2 0/2] netfilter: conntrack: Fix CT offload timeout on heavily loaded systems

2020-08-03 Thread Roi Dayan
On heavily loaded systems the GC can take time to go over all existing conns and reset their timeout. At that time other calls like from nf_conntrack_in() can call of nf_ct_is_expired() and see the conn as expired. To fix this when we set the offload bit we should also reset the timeout instead of

[PATCH v3] seg6_iptunnel: Refactor seg6_lwt_headroom out of uapi header

2020-08-03 Thread Ioana-Ruxandra Stancioi
From: Ioana-Ruxandra Stăncioi Refactor the function seg6_lwt_headroom out of the seg6_iptunnel.h uapi header, because it is only used in seg6_iptunnel.c. Moreover, it is only used in the kernel code, as indicated by the "#ifdef __KERNEL__". Suggested-by: David Miller Signed-off-by: Ioana-Ruxand

[PATCH net-next 0/2] Add IP_DSCP_MASK and fix vxlan tos value before xmit

2020-08-03 Thread Hangbin Liu
This patch set is aim to update the old IP_TOS_MASK to new IP_DSCP_MASK as tos value has been obsoleted for a long time. But to make sure we don't break any existing behaviour, we can't just replease all IP_TOS_MASK to new IP_DSCP_MASK. So let's update it case by case. The first issue we will fix

[PATCH net-next 1/2] net: add IP_DSCP_MASK

2020-08-03 Thread Hangbin Liu
In RFC1349 it defined TOS field like 0 1 2 3 4 5 6 7 +-+-+-+-+-+-+-+-+ | PRECEDENCE| TOS | MBZ | +-+-+-+-+-+-+-+-+ But this has been obsoleted by RFC2474, and upd

[PATCH net-next 2/2] vxlan: fix getting tos value from DSCP field

2020-08-03 Thread Hangbin Liu
In commit 71130f29979c ("vxlan: fix tos value before xmit") we strict the vxlan tos value before xmit. But as IP tos field has been obsoleted by RFC2474, and updated by RFC3168 later. We should use new DSCP field, or we will lost the first 3 bits value when xmit. Fixes: 71130f29979c ("vxlan: fix t

Re: [PATCH] qmi_wwan: support modify usbnet's rx_urb_size

2020-08-03 Thread Greg KH
On Mon, Aug 03, 2020 at 02:51:05PM +0800, yzc...@netease.com wrote: > From: carl > > When QMUX enabled, the 'dl-datagram-max-size' can be 4KB/16KB/31KB depend > on QUALCOMM's chipsets. > User can set 'dl-datagram-max-size' by 'QMI_WDA_SET_DATA_FORMAT'. > The usbnet's rx_urb_size must

Re: [PATCH] qmi_wwan: support modify usbnet's rx_urb_size

2020-08-03 Thread Daniele Palmas
Hi Greg, Il giorno lun 3 ago 2020 alle ore 10:18 Greg KH ha scritto: > > On Mon, Aug 03, 2020 at 02:51:05PM +0800, yzc...@netease.com wrote: > > From: carl > > > > When QMUX enabled, the 'dl-datagram-max-size' can be 4KB/16KB/31KB > > depend on QUALCOMM's chipsets. > > User can set 'dl-

RE: [PATCH net v3 0/5] DPAA FMan driver fixes

2020-08-03 Thread Madalin Bucur (OSS)
> -Original Message- > From: netdev-ow...@vger.kernel.org On > Behalf Of Florinel Iordache > Sent: 03 August 2020 10:07 > To: Madalin Bucur ; da...@davemloft.net; > k...@kernel.org; netdev@vger.kernel.org > Cc: linux-ker...@vger.kernel.org; Florinel Iordache > > Subject: [PATCH net v3 0/5

RE: [PATCH 2/2] net: phy: Associate device node with fixed PHY

2020-08-03 Thread Madalin Bucur (OSS)
> -Original Message- > From: netdev-ow...@vger.kernel.org On > Behalf Of Andrew Lunn > Sent: 01 August 2020 18:11 > To: Russell King - ARM Linux admin > Cc: Vikas Singh ; f.faine...@gmail.com; > hkallwe...@gmail.com; netdev@vger.kernel.org; Calvin Johnson (OSS) > ; kuldip dwivedi > ; Mada

Re: [PATCH] qmi_wwan: support modify usbnet's rx_urb_size

2020-08-03 Thread Sergei Shtylyov
On 03.08.2020 9:51, yzc...@netease.com wrote: From: carl Prefrrably a full name, matching that one in the signoff tag. When QMUX enabled, the 'dl-datagram-max-size' can be 4KB/16KB/31KB depend on QUALCOMM's chipsets. No indentation here please, start at column 1 and respect th

Re: [PATCH] tools/bpf/bpftool: Fix wrong return value in do_dump()

2020-08-03 Thread Tobias Klauser
On 2020-08-02 at 13:15:40 +0200, Tianjia Zhang wrote: > In case of btf_id does not exist, a negative error code -ENOENT > should be returned. > > Fixes: c93cc69004df3 ("bpftool: add ability to dump BTF types") > Cc: Andrii Nakryiko > Signed-off-by: Tianjia Zhang Reviewed-by: Tobias Klauser

Re: [PATCH 0/3] Modernize tasklet callback API

2020-08-03 Thread Allen
Kees, > > [heavily trimmed CC list because I think lkml is ignoring this > thread...] > > On Thu, Jul 30, 2020 at 09:03:55AM +0200, Thomas Gleixner wrote: > > Kees, > > > > Kees Cook writes: > > > This is the infrastructure changes to prepare the tasklet API for > > > conversion to passing the ta

[PATCH net-next] net: stmmac: fix failed to suspend if phy based WOL is enabled

2020-08-03 Thread Jisheng Zhang
With the latest net-next tree, if test suspend/resume after enabling WOL, we get error as below: [ 487.086365] dpm_run_callback(): mdio_bus_suspend+0x0/0x30 returns -16 [ 487.086375] PM: Device stmmac-0:00 failed to suspend: error -16 -16 means -EBUSY, this is because I didn't enable wakeup of

[PATCH bpf-next v6 2/2] bpf: allow to specify ifindex for skb in bpf_prog_test_run_skb

2020-08-03 Thread Dmitry Yakunin
Now skb->dev is unconditionally set to the loopback device in current net namespace. But if we want to test bpf program which contains code branch based on ifindex condition (eg filters out localhost packets) it is useful to allow specifying of ifindex from userspace. This patch adds such option th

[PATCH bpf-next v6 1/2] bpf: setup socket family and addresses in bpf_prog_test_run_skb

2020-08-03 Thread Dmitry Yakunin
Now it's impossible to test all branches of cgroup_skb bpf program which accesses skb->family and skb->{local,remote}_ip{4,6} fields because they are zeroed during socket allocation. This commit fills socket family and addresses from related fields in constructed skb. v2: - fix build without CON

[PATCH bpf-next v6 0/2] bpf: cgroup skb improvements for bpf_prog_test_run

2020-08-03 Thread Dmitry Yakunin
This patchset contains some improvements for testing cgroup/skb programs through BPF_PROG_TEST_RUN command. v2: - fix build without CONFIG_CGROUP_BPF (kernel test robot ) v3: - fix build without CONFIG_IPV6 (kernel test robot ) v4: - remove cgroup storage related commits for future rework

Re: [PATCH 2/2] net: phy: Associate device node with fixed PHY

2020-08-03 Thread Russell King - ARM Linux admin
On Mon, Aug 03, 2020 at 08:33:19AM +, Madalin Bucur (OSS) wrote: > > -Original Message- > > From: netdev-ow...@vger.kernel.org On > > Behalf Of Andrew Lunn > > Sent: 01 August 2020 18:11 > > To: Russell King - ARM Linux admin > > Cc: Vikas Singh ; f.faine...@gmail.com; > > hkallwe...@

Re: [PATCH net-next 1/2] net: add IP_DSCP_MASK

2020-08-03 Thread Guillaume Nault
On Mon, Aug 03, 2020 at 04:02:16PM +0800, Hangbin Liu wrote: > In RFC1349 it defined TOS field like > >0 1 2 3 4 5 6 7 > +-+-+-+-+-+-+-+-+ > | PRECEDENCE| TOS | MBZ | > +-+-+-+-+

Re: [PATCH net-next 2/2] vxlan: fix getting tos value from DSCP field

2020-08-03 Thread Guillaume Nault
On Mon, Aug 03, 2020 at 04:02:17PM +0800, Hangbin Liu wrote: > In commit 71130f29979c ("vxlan: fix tos value before xmit") we strict > the vxlan tos value before xmit. But as IP tos field has been obsoleted > by RFC2474, and updated by RFC3168 later. We should use new DSCP field, > or we will lost

Re: [Linux-kernel-mentees] [PATCH net] rds: Prevent kernel-infoleak in rds_notify_queue_get()

2020-08-03 Thread Dan Carpenter
Ah, thanks. We've had a bunch of discussions about these leaks but I wasn't aware of this. regards, dan carpenter

Re: [PATCH] qmi_wwan: support modify usbnet's rx_urb_size

2020-08-03 Thread Greg KH
On Mon, Aug 03, 2020 at 10:26:18AM +0200, Daniele Palmas wrote: > Hi Greg, > > Il giorno lun 3 ago 2020 alle ore 10:18 Greg KH > ha scritto: > > > > On Mon, Aug 03, 2020 at 02:51:05PM +0800, yzc...@netease.com wrote: > > > From: carl > > > > > > When QMUX enabled, the 'dl-datagram-max-size'

Re: [net v3] drivers/net/wan/lapbether: Use needed_headroom instead of hard_header_len

2020-08-03 Thread Willem de Bruijn
On Sun, Aug 2, 2020 at 9:51 PM Xie He wrote: > > In net/packet/af_packet.c, the function packet_snd first reserves a > headroom of length (dev->hard_header_len + dev->needed_headroom). > Then if the socket is a SOCK_DGRAM socket, it calls dev_hard_header, > which calls dev->header_ops->create, to

Re: [PATCH] qmi_wwan: support modify usbnet's rx_urb_size

2020-08-03 Thread kernel test robot
umented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/yzc666-netease-com/qmi_wwan-support-modify-usbnet-s-rx_urb_size/20200803-152459 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/sparc-next.git master config: sh-allmodconfig (a

Re: [PATCH net-next RFC 00/13] Add devlink reload level option

2020-08-03 Thread Vasundhara Volam
On Tue, Jul 28, 2020 at 10:13 PM Jacob Keller wrote: > > > > On 7/27/2020 10:25 PM, Vasundhara Volam wrote: > > On Mon, Jul 27, 2020 at 4:36 PM Moshe Shemesh wrote: > >> > >> Introduce new option on devlink reload API to enable the user to select the > >> reload level required. Complete support f

Re: [PATCH] qmi_wwan: support modify usbnet's rx_urb_size

2020-08-03 Thread Bjørn Mork
Daniele Palmas writes: > Il giorno lun 3 ago 2020 alle ore 10:18 Greg KH > ha scritto: > >> Actually, no, this all should be done "automatically", do not change the >> urb size on the fly. Change it at probe time based on the device you >> are using, do not force userspace to "know" what to do h

Re: [PATCH net v2 0/2] netfilter: conntrack: Fix CT offload timeout on heavily loaded systems

2020-08-03 Thread Pablo Neira Ayuso
On Mon, Aug 03, 2020 at 10:33:03AM +0300, Roi Dayan wrote: > On heavily loaded systems the GC can take time to go over all existing > conns and reset their timeout. At that time other calls like from > nf_conntrack_in() can call of nf_ct_is_expired() and see the conn as > expired. To fix this when

Re: [PATCH] qmi_wwan: support modify usbnet's rx_urb_size

2020-08-03 Thread Daniele Palmas
Il giorno lun 3 ago 2020 alle ore 11:49 Greg KH ha scritto: > > On Mon, Aug 03, 2020 at 10:26:18AM +0200, Daniele Palmas wrote: > > Hi Greg, > > > > Il giorno lun 3 ago 2020 alle ore 10:18 Greg KH > > ha scritto: > > > > > > On Mon, Aug 03, 2020 at 02:51:05PM +0800, yzc...@netease.com wrote: > >

答复: [PATCH] qmi_wwan: support modify usbnet's rx_urb_size

2020-08-03 Thread 殷张成
Hi Greg: I am carl, software engineer from a Chinese company ' Quectel Wireless Solutions Co., Ltd'. Chinese name is Yinzhangcheng. So English name carl.yin. My company’s products are LTE/5G modules base on QUALCOMM's chipset, like MDM9607/MDM9640/SDX24/SDX55...etc. On 20

RE: [net-next 1/5] ice: add the virtchnl handler for AdminQ command

2020-08-03 Thread Wang, Haiyue
> -Original Message- > From: Jakub Kicinski > Sent: Tuesday, July 28, 2020 07:04 > To: Tom Herbert > Cc: Venkataramanan, Anirudh ; Wang, Haiyue > ; > da...@davemloft.net; nhor...@redhat.com; sassm...@redhat.com; Bowers, AndrewX > ; Kirsher, Jeffrey T ; > netdev@vger.kernel.org; > Nguyen

Re: [PATCH] qmi_wwan: support modify usbnet's rx_urb_size

2020-08-03 Thread Bjørn Mork
Daniele Palmas writes: > Il giorno lun 3 ago 2020 alle ore 11:49 Greg KH > ha scritto: >> >> Where does QMI_WDA_SET_DATA_FORMAT come from? >> > > This is a request of Qualcomm proprietary protocol used, among other > things, to configure data aggregation for modems. There's an open > source users

Re: [PATCH net v2 1/2] netfilter: conntrack: Move nf_ct_offload_timeout to header file

2020-08-03 Thread Pablo Neira Ayuso
On Mon, Aug 03, 2020 at 10:33:04AM +0300, Roi Dayan wrote: > To be used by callers from other modules. > > Signed-off-by: Roi Dayan > Reviewed-by: Oz Shlomo > --- > include/net/netfilter/nf_conntrack.h | 12 > net/netfilter/nf_conntrack_core.c| 12 > 2 files change

PMTUD broken inside network namespace with multipath routing

2020-08-03 Thread mastertheknife
Hi, I have observed that PMTUD (Path MTU discovery) is broken using multipath routing inside a network namespace. This breaks TCP, because it keeps trying to send oversized packets. Observed on kernel 5.4.44, other kernels weren't tested. However i went through net/ipv4/route.c and haven't spotted

Re: [PATCH v3 iproute2-next] devlink: Add board.serial_number to info subcommand.

2020-08-03 Thread Jiri Pirko
Fri, Jul 31, 2020 at 12:46:43PM CEST, vasundhara-v.vo...@broadcom.com wrote: >Add support for reading board serial_number to devlink info >subcommand. Example: > >$ devlink dev info pci/:af:00.0 -jp >{ >"info": { >"pci/:af:00.0": { >"driver": "bnxt_en", >

RE: [PATCH 2/2] net: phy: Associate device node with fixed PHY

2020-08-03 Thread Madalin Bucur (OSS)
> -Original Message- > From: Russell King - ARM Linux admin > Sent: 03 August 2020 12:07 > To: Madalin Bucur (OSS) > Cc: Andrew Lunn ; Vikas Singh > ; f.faine...@gmail.com; hkallwe...@gmail.com; > netdev@vger.kernel.org; Calvin Johnson (OSS) ; > kuldip dwivedi ; Vikas Singh > > Subject:

[PATCH ethtool 0/7] compiler warnings cleanup, part 1

2020-08-03 Thread Michal Kubecek
Maciej Żenczykowski recently cleaned up many "unused parameter" compiler warnings but some new occurences appeared since (mostly in netlink code). This series gets rid of all currently found "unused parameter" warnings and also one zero length array access warning (gcc10). There are still some co

[PATCH ethtool 3/7] igc: mark unused callback parameter

2020-08-03 Thread Michal Kubecek
Mark info parameter of igc_dump_regs() as unused to get rid of gcc warning. Signed-off-by: Michal Kubecek --- igc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/igc.c b/igc.c index 2c4abcef1e15..1550ac0c1c2b 100644 --- a/igc.c +++ b/igc.c @@ -94,7 +94,8 @@ static const c

[PATCH ethtool 6/7] netlink: mark unused parameters of parser callbacks

2020-08-03 Thread Michal Kubecek
Some calbacks used with nl_parser() do not use all parameters passed to them. Mark unused parameters explicitly to get rid of compiler warnings. Signed-off-by: Michal Kubecek --- netlink/parser.c | 28 1 file changed, 16 insertions(+), 12 deletions(-) diff --git a/n

[PATCH ethtool 7/7] ioctl: avoid zero length array warning in get_stringset()

2020-08-03 Thread Michal Kubecek
Starting with gcc10, gcc issues a warning about accessing elements of zero leghth arrays. This is usually fixed by using C99 variable length arrays but struct ethtool_sset_info is part of kernel UAPI so use an auxiliary pointer instead. Signed-off-by: Michal Kubecek --- ethtool.c | 4 +++- 1 fil

[PATCH ethtool 2/7] cable_test: clean up unused parameters

2020-08-03 Thread Michal Kubecek
Functions nl_cable_test_ntf_attr() and nl_cable_test_tdr_ntf_attr() do not use nlctx parameter and as they are not callbacks with fixed signature, we can simply drop it. Once we do, the same is true for cable_test_ntf_nest() and cable_test_tdr_ntf_nest(). Signed-off-by: Michal Kubecek --- netlin

[PATCH ethtool 4/7] netlink: mark unused callback parameter

2020-08-03 Thread Michal Kubecek
Function nomsg_reply_cb() is used as a callback for mnl_cb_run() but it does not use its data parameter; mark it as unused to get rid of compiler warning. Signed-off-by: Michal Kubecek --- netlink/netlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/netlink/netlink.c b/n

[PATCH ethtool 5/7] netlink: mark unused parameters of bitset walker callbacks

2020-08-03 Thread Michal Kubecek
Some callbacks used with walk_bitset() do not use all parameters passed to them. Mark unused parameters explicitly to get rid of compiler warnings. Signed-off-by: Michal Kubecek --- netlink/pause.c | 3 ++- netlink/privflags.c | 2 +- netlink/settings.c | 9 ++--- netlink/tsinfo.c|

[PATCH ethtool 1/7] rename maybe_unused macro to __maybe_unused

2020-08-03 Thread Michal Kubecek
This makes the code consistent with kernel and also makes it a bit more apparent that it is an attribute. Signed-off-by: Michal Kubecek --- amd8111e.c | 2 +- at76c50x-usb.c | 2 +- de2104x.c | 4 ++-- dsa.c | 2 +- e100.c | 2 +- e1000.c| 2 +- et131x.c |

Re: [PATCH bpf-next v3 00/29] bpf: switch to memcg-based memory accounting

2020-08-03 Thread Daniel Borkmann
On 7/30/20 11:22 PM, Roman Gushchin wrote: Currently bpf is using the memlock rlimit for the memory accounting. This approach has its downsides and over time has created a significant amount of problems: 1) The limit is per-user, but because most bpf operations are performed as root, the lim

答复: [PATCH] qmi_wwan: support modify usbnet's rx_urb_size

2020-08-03 Thread 殷张成
bj...@mork.no writes: > Daniele Palmas writes: > > Il giorno lun 3 ago 2020 alle ore 10:18 Greg KH > > ha scritto: > > > >> Actually, no, this all should be done "automatically", do not change > >> the urb size on the fly. Change it at probe time based on the device > >> you are using, do not fo

pull-request: mac80211-next 2020-08-03

2020-08-03 Thread Johannes Berg
Hi Dave, Not sure you'll still take a few stragglers, but if you're going to make a last pass then having a few more things in would be nice. One (the while -> if) is something I'd even send as a bugfix later, the rest are just nice to have. :) Please pull (if you still want) and let me know if t

Re: [PATCH net-next RFC 00/13] Add devlink reload level option

2020-08-03 Thread Moshe Shemesh
On 8/3/2020 1:24 PM, Vasundhara Volam wrote: On Tue, Jul 28, 2020 at 10:13 PM Jacob Keller wrote: On 7/27/2020 10:25 PM, Vasundhara Volam wrote: On Mon, Jul 27, 2020 at 4:36 PM Moshe Shemesh wrote: Introduce new option on devlink reload API to enable the user to select the reload level r

Re: [Linux-kernel-mentees] [PATCH net] net/smc: Prevent kernel-infoleak in __smc_diag_dump()

2020-08-03 Thread Ursula Braun
On 8/1/20 9:44 PM, Peilin Ye wrote: > __smc_diag_dump() is potentially copying uninitialized kernel stack memory > into socket buffers, since the compiler may leave a 4-byte hole near the > beginning of `struct smcd_diag_dmbinfo`. Fix it by initializing `dinfo` > with memset(). > > Cc: sta...@v

[PATCH 5.7 095/120] iwlwifi: fix crash in iwl_dbg_tlv_alloc_trigger

2020-08-03 Thread Greg Kroah-Hartman
From: Jiri Slaby [ Upstream commit ea0cca61d628662e4a1b26c77c7646f9a0257069 ] The tlv passed to iwl_dbg_tlv_alloc_trigger comes from a loaded firmware file. The memory can be marked as read-only as firmware could be shared. In anyway, writing to this memory is not expected. So, iwl_dbg_tlv_alloc

Re: [PATCH net-next RFC 00/13] Add devlink reload level option

2020-08-03 Thread Vasundhara Volam
On Mon, Aug 3, 2020 at 5:47 PM Moshe Shemesh wrote: > > > On 8/3/2020 1:24 PM, Vasundhara Volam wrote: > > On Tue, Jul 28, 2020 at 10:13 PM Jacob Keller > > wrote: > >> > >> > >> On 7/27/2020 10:25 PM, Vasundhara Volam wrote: > >>> On Mon, Jul 27, 2020 at 4:36 PM Moshe Shemesh wrote: > Int

Re: [PATCH 2/2] net: phy: Associate device node with fixed PHY

2020-08-03 Thread Andrew Lunn
> I see you agree that there were and there will be many changes for a while, > It's not a complaint, I know hot it works, it's just a decision based on > required effort vs features offered vs user requirements. Lately it's been > time consuming to try to fix things in this area. So the conclusio

[PATCH net-next] mptcp: use mptcp_for_each_subflow in mptcp_stream_accept

2020-08-03 Thread Geliang Tang
Use mptcp_for_each_subflow in mptcp_stream_accept instead of open-coding. Signed-off-by: Geliang Tang --- net/mptcp/protocol.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/mptcp/protocol.c b/net/mptcp/protocol.c index d3fe7296e1c9..400824eabf73 100644 --- a/net/mptcp/p

Re: [PATCH net v2 1/2] netfilter: conntrack: Move nf_ct_offload_timeout to header file

2020-08-03 Thread Roi Dayan
On 2020-08-03 2:03 PM, Pablo Neira Ayuso wrote: > On Mon, Aug 03, 2020 at 10:33:04AM +0300, Roi Dayan wrote: >> To be used by callers from other modules. >> >> Signed-off-by: Roi Dayan >> Reviewed-by: Oz Shlomo >> --- >> include/net/netfilter/nf_conntrack.h | 12 >> net/netfilter

[PATCH net-next] fib: Fix undef compile warning

2020-08-03 Thread YueHaibing
net/core/fib_rules.c:26:7: warning: "CONFIG_IP_MULTIPLE_TABLES" is not defined, evaluates to 0 [-Wundef] #elif CONFIG_IP_MULTIPLE_TABLES ^ Fixes: 8b66a6fd34f5 ("fib: fix another fib_rules_ops indirect call wrapper problem") Signed-off-by: YueHaibing --- net/core

[PATCH ethtool] ethtool.spec: Add bash completion script

2020-08-03 Thread Roi Dayan
After the additon of the bash completion script, packaging using the default spec file fails for installed but not packaged error. so package it. Fixes: 9b802643d7bd ("ethtool: Add bash-completion script") Signed-off-by: Roi Dayan --- ethtool.spec.in | 1 + 1 file changed, 1 insertion(+) diff -

Re: [PATCH ethtool 0/7] compiler warnings cleanup, part 1

2020-08-03 Thread Andrew Lunn
On Mon, Aug 03, 2020 at 01:57:03PM +0200, Michal Kubecek wrote: > Maciej Żenczykowski recently cleaned up many "unused parameter" compiler > warnings but some new occurences appeared since (mostly in netlink code). Hi Michal Could you modify the compiler flags to get gcc to warn about these? Othe

Re: [PATCH v4 09/11] net: dsa: microchip: Add Microchip KSZ8863 SMI based driver support

2020-08-03 Thread Randy Dunlap
On 8/2/20 10:44 PM, Michael Grzeschik wrote: > diff --git a/drivers/net/dsa/microchip/Kconfig > b/drivers/net/dsa/microchip/Kconfig > index 4ec6a47b7f7284f..c5819bd4121cc7c 100644 > --- a/drivers/net/dsa/microchip/Kconfig > +++ b/drivers/net/dsa/microchip/Kconfig > @@ -40,3 +40,12 @@ config NET_DS

Re: PMTUD broken inside network namespace with multipath routing

2020-08-03 Thread David Ahern
On 8/3/20 5:14 AM, mastertheknife wrote: > What seems to be happening, is that when multipath routing is used > inside LXC (or any network namespace), the kernel doesn't generate a > routing exception to force the lower MTU. > I believe this is a bug inside the kernel. > Known problem. Original m

Re: [PATCH net-next RFC 00/13] Add devlink reload level option

2020-08-03 Thread Moshe Shemesh
On 8/3/2020 3:47 PM, Vasundhara Volam wrote: On Mon, Aug 3, 2020 at 5:47 PM Moshe Shemesh wrote: On 8/3/2020 1:24 PM, Vasundhara Volam wrote: On Tue, Jul 28, 2020 at 10:13 PM Jacob Keller wrote: On 7/27/2020 10:25 PM, Vasundhara Volam wrote: On Mon, Jul 27, 2020 at 4:36 PM Moshe Shemesh

Re: [PATCH ethtool 0/7] compiler warnings cleanup, part 1

2020-08-03 Thread Michal Kubecek
On Mon, Aug 03, 2020 at 03:31:25PM +0200, Andrew Lunn wrote: > On Mon, Aug 03, 2020 at 01:57:03PM +0200, Michal Kubecek wrote: > > Maciej Żenczykowski recently cleaned up many "unused parameter" compiler > > warnings but some new occurences appeared since (mostly in netlink code). > > Hi Michal >

Re: [PATCH v6 bpf-next 0/6] bpf: tailcalls in BPF subprograms

2020-08-03 Thread Daniel Borkmann
On 8/2/20 5:07 AM, Alexei Starovoitov wrote: On Sat, Aug 01, 2020 at 09:13:57AM +0200, Maciej Fijalkowski wrote: On Sat, Aug 01, 2020 at 03:03:19AM +0200, Daniel Borkmann wrote: On 7/31/20 2:03 AM, Maciej Fijalkowski wrote: v5->v6: - propagate only those poke descriptors that individual subpro

Re: 答复: [PATCH] qmi_wwan: support modify usbnet's rx_urb_size

2020-08-03 Thread Bjørn Mork
"Carl Yin(殷张成)" writes: > Hi Bjørn, > You can check cdc_ncm.c. > cdc ncm driver set 'rx_urb_size' on driver probe time, and the value > read from' cdc_ncm_bind_common() 's USB_CDC_GET_NTB_FORMAT '. > and also allow the userspace to modify 'rx_urb_size' by ' > /sys/class/net/w

bpf-next is CLOSED

2020-08-03 Thread Daniel Borkmann
The merge window is open right now, therefore please send bug fixes only at this point. bpf-next will open back up in roughly 2 weeks after the merge window is closed. The last bpf-next PR will go out today to David after processing pending BPF items from patchwork. Thank you, Daniel

Re: [PATCH net-next] tipc: Use is_broadcast_ether_addr() instead of memcmp()

2020-08-03 Thread Ying Xue
On 8/3/20 10:00 AM, Huang Guobin wrote: > Using is_broadcast_ether_addr() instead of directly use > memcmp() to determine if the ethernet address is broadcast > address. > > spatch with a semantic match is used to found this problem. > (http://coccinelle.lip6.fr/) > > Signed-off-by: Huang Guobin

Re: [PATCH 2/2] net: phy: Associate device node with fixed PHY

2020-08-03 Thread Russell King - ARM Linux admin
On Mon, Aug 03, 2020 at 11:45:55AM +, Madalin Bucur (OSS) wrote: > > -Original Message- > > From: Russell King - ARM Linux admin > > Sent: 03 August 2020 12:07 > > To: Madalin Bucur (OSS) > > Cc: Andrew Lunn ; Vikas Singh > > ; f.faine...@gmail.com; hkallwe...@gmail.com; > > netdev@vg

RE: [PATCH RFC net-next 2/3] net: phy: Move into subdirectories

2020-08-03 Thread Madalin Bucur (OSS)
> -Original Message- > From: netdev-ow...@vger.kernel.org On > Behalf Of Andrew Lunn > Sent: 27 July 2020 23:48 > To: netdev > Cc: Ioana Ciornei ; Florian Fainelli > ; Russell King ; Heiner > Kallweit ; Andrew Lunn > Subject: [PATCH RFC net-next 2/3] net: phy: Move into subdirectories >

Re: [PATCH net-next RFC 01/13] devlink: Add reload level option to devlink reload command

2020-08-03 Thread Jiri Pirko
Sat, Aug 01, 2020 at 11:32:25PM CEST, mo...@mellanox.com wrote: > >On 7/31/2020 2:11 AM, Jakub Kicinski wrote: >> On Thu, 30 Jul 2020 15:30:45 +0300 Moshe Shemesh wrote: >> > > > > My expectations would be that the driver must perform the lowest >> > > > > reset level possible that satisfies the re

Re: [PATCH RFC net-next 2/3] net: phy: Move into subdirectories

2020-08-03 Thread Andrew Lunn
On Mon, Aug 03, 2020 at 02:11:10PM +, Madalin Bucur (OSS) wrote: > > -Original Message- > > From: netdev-ow...@vger.kernel.org On > > Behalf Of Andrew Lunn > > Sent: 27 July 2020 23:48 > > To: netdev > > Cc: Ioana Ciornei ; Florian Fainelli > > ; Russell King ; Heiner > > Kallweit ; A

Re: [PATCH bpf-next] tools build: propagate build failures from tools/build/Makefile.build

2020-08-03 Thread Daniel Borkmann
On 7/31/20 4:42 AM, Andrii Nakryiko wrote: The '&&' command seems to have a bad effect when $(cmd_$(1)) exits with non-zero effect: the command failure is masked (despite `set -e`) and all but the first command of $(dep-cmd) is executed (successfully, as they are mostly printfs), thus overall ret

RE: [PATCH net-next] Add Mellanox BlueField Gigabit Ethernet driver

2020-08-03 Thread Asmaa Mnebhi
> -Original Message- > From: Andrew Lunn > Sent: Friday, July 31, 2020 9:15 PM > To: Asmaa Mnebhi > Cc: David Thompson ; > netdev@vger.kernel.org; da...@davemloft.net; k...@kernel.org; Jiri Pirko > > Subject: Re: [PATCH net-next] Add Mellanox BlueField Gigabit Ethernet driver > > > >

Re: PMTUD broken inside network namespace with multipath routing

2020-08-03 Thread mastertheknife
Hi David, In this case, both paths are in the same layer2 network, there is no symmetric multi-path routing. If original message takes path 1, ICMP response will come from path 1 If original message takes path 2, ICMP response will come from path 2 Also, It works fine outside of LXC. Thank you,

Re: [PATCH] tools/bpf/bpftool: Fix wrong return value in do_dump()

2020-08-03 Thread Daniel Borkmann
On 8/2/20 1:15 PM, Tianjia Zhang wrote: In case of btf_id does not exist, a negative error code -ENOENT should be returned. Fixes: c93cc69004df3 ("bpftool: add ability to dump BTF types") Cc: Andrii Nakryiko Signed-off-by: Tianjia Zhang Applied, thanks!

RE: [PATCH 2/2] net: phy: Associate device node with fixed PHY

2020-08-03 Thread Madalin Bucur (OSS)
> -Original Message- > From: Andrew Lunn > Sent: 03 August 2020 15:58 > To: Madalin Bucur (OSS) > Cc: Russell King - ARM Linux admin ; Vikas Singh > ; f.faine...@gmail.com; hkallwe...@gmail.com; > netdev@vger.kernel.org; Calvin Johnson (OSS) ; > kuldip dwivedi ; Vikas Singh > > Subject:

Re: [PATCH v2 net-next 03/11] sfc_ef100: read Design Parameters at probe time

2020-08-03 Thread Edward Cree
On 31/07/2020 21:18, Jakub Kicinski wrote: > On Fri, 31 Jul 2020 13:58:35 +0100 Edward Cree wrote: >> +default: >> +/* Host interface says "Drivers should ignore design parameters >> + * that they do not recognise." >> + */ >> +netif_info(efx, pro

Re: [PATCH v2 net-next 04/11] sfc_ef100: TX path for EF100 NICs

2020-08-03 Thread Edward Cree
On 31/07/2020 20:39, Jakub Kicinski wrote: > On Fri, 31 Jul 2020 13:59:04 +0100 Edward Cree wrote: >> +static inline efx_oword_t *ef100_tx_desc(struct efx_tx_queue *tx_queue, >> + unsigned int index) > Does this static inline make any difference? > > You know the

[PATCH net-next] net/mlx5: remove erroneous fallthrough

2020-08-03 Thread Dan Carpenter
This isn't a fall through because it was after a return statement. The fall through annotation leads to a Smatch warning: drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c:246 mlx5e_ethtool_get_sset_count() warn: ignoring unreachable code. Signed-off-by: Dan Carpenter --- drivers/ne

Re: [PATCH iproute2-next v2 0/2] Expose port attributes

2020-08-03 Thread David Ahern
On 7/30/20 8:33 AM, Danielle Ratson wrote: > Add two new devlink port attributes: > - Lanes: indicates the number of port lanes. > - Splittable: indicates the port split ability. > > Patch 1: Update kernel headers > Patch 2: Expose number of lanes > > v2: *Update 'devlink_policy' with the new att

Re: [PATCH bpf-next 0/3] Add generic and raw BTF parsing APIs to libbpf

2020-08-03 Thread Daniel Borkmann
On 8/2/20 3:32 AM, Andrii Nakryiko wrote: It's pretty common for applications to want to parse raw (binary) BTF data from file, as opposed to parsing it from ELF sections. It's also pretty common for tools to not care whether given file is ELF or raw BTF format. This patch series exposes internal

RE: [PATCH 2/2] net: phy: Associate device node with fixed PHY

2020-08-03 Thread Madalin Bucur (OSS)
> -Original Message- > From: Russell King - ARM Linux admin > Sent: 03 August 2020 17:10 > To: Madalin Bucur (OSS) > Cc: Andrew Lunn ; Vikas Singh > ; f.faine...@gmail.com; hkallwe...@gmail.com; > netdev@vger.kernel.org; Calvin Johnson (OSS) ; > kuldip dwivedi ; Vikas Singh > > Subject:

Re: [PATCH] kprobes: fix NULL pointer dereference at kprobe_ftrace_handler

2020-08-03 Thread Masami Hiramatsu
On Mon, 3 Aug 2020 13:46:25 +0800 Muchun Song wrote: > Ping guys. Any comments or suggestions? > > On Tue, Jul 28, 2020 at 2:45 PM Muchun Song wrote: > > > > We found a case of kernel panic on our server. The stack trace is as > > follows(omit some irrelevant information): > > > > BUG: kernel

Re: [PATCH net] net/bpfilter: initialize pos in __bpfilter_process_sockopt

2020-08-03 Thread Daniel Borkmann
On 8/1/20 9:48 PM, Alexei Starovoitov wrote: On Fri, Jul 31, 2020 at 02:07:42AM +0200, Daniel Borkmann wrote: On 7/30/20 6:13 PM, Christian Brauner wrote: On Thu, Jul 30, 2020 at 06:09:00PM +0200, Christoph Hellwig wrote: __bpfilter_process_sockopt never initialized the pos variable passed to

Re: [PATCH iproute2-next] ip-xfrm: add support for oseq-may-wrap extra flag

2020-08-03 Thread David Ahern
On 7/31/20 1:12 AM, Petr Vaněk wrote: > This flag allows to create SA where sequence number can cycle in > outbound packets if set. > > Signed-off-by: Petr Vaněk > --- > include/uapi/linux/xfrm.h | 1 + > ip/ipxfrm.c | 3 +++ > ip/xfrm_state.c | 4 +++- > man/man8/ip-xfrm

Re: [PATCH 2/2] net: phy: Associate device node with fixed PHY

2020-08-03 Thread Andrew Lunn
On Mon, Aug 03, 2020 at 02:33:56PM +, Madalin Bucur (OSS) wrote: > > -Original Message- > > From: Andrew Lunn > > Sent: 03 August 2020 15:58 > > To: Madalin Bucur (OSS) > > Cc: Russell King - ARM Linux admin ; Vikas Singh > > ; f.faine...@gmail.com; hkallwe...@gmail.com; > > netdev@vg

KASAN: slab-out-of-bounds Read in hci_le_meta_evt

2020-08-03 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:5a30a789 Merge tag 'x86-urgent-2020-08-02' of git://git.ke.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=11cd21cc90 kernel config: https://syzkaller.appspot.com/x/.config?x=c0cfcf935bcc94d2 das

KASAN: use-after-free Read in tipc_bcast_get_mode

2020-08-03 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:bd0b33b2 Merge git://git.kernel.org/pub/scm/linux/kernel/g.. git tree: net-next console output: https://syzkaller.appspot.com/x/log.txt?x=13f236a490 kernel config: https://syzkaller.appspot.com/x/.config?x=91a13b78c7dc258d das

Re: [net-next v2 0/5] devlink flash update overwrite mask

2020-08-03 Thread Jiri Pirko
Sat, Aug 01, 2020 at 02:21:54AM CEST, jacob.e.kel...@intel.com wrote: >This series introduces support for a new attribute to the flash update >command: DEVLINK_ATTR_FLASH_UPDATE_OVERWRITE_MASK. This attribute is a u32 >value that represents a bitmask of which subsections of flash to >request/allow

[PATCH net 0/2] net: fix a mcast issue for tipc udp media

2020-08-03 Thread Xin Long
Patch 1 is to add a function to get the dev by source address, whcih will be used by Patch 2. Xin Long (2): ipv6: add ipv6_dev_find() tipc: set ub->ifindex for local ipv6 address include/net/addrconf.h | 2 ++ net/ipv6/addrconf.c| 39 +++ net/tipc/udp

[PATCH net 1/2] ipv6: add ipv6_dev_find()

2020-08-03 Thread Xin Long
This is to add an ip_dev_find like function for ipv6, used to find the dev by saddr. It will be used by TIPC protocol. So also export it. Signed-off-by: Xin Long --- include/net/addrconf.h | 2 ++ net/ipv6/addrconf.c| 39 +++ 2 files changed, 41 insertio

  1   2   3   4   >