On Tue, Jul 26, 2005 at 08:14:47AM +0200, Thomas Graf ([EMAIL PROTECTED]) wrote:
> * Evgeniy Polyakov <[EMAIL PROTECTED]> 2005-07-26 08:45
> > On Tue, Jul 26, 2005 at 01:46:04AM +0200, Patrick McHardy ([EMAIL
> > PROTECTED]) wrote:
> > > Usually netlink is easily extendable by using nested TLVs. B
* Evgeniy Polyakov <[EMAIL PROTECTED]> 2005-07-26 08:45
> On Tue, Jul 26, 2005 at 01:46:04AM +0200, Patrick McHardy ([EMAIL PROTECTED])
> wrote:
> > Usually netlink is easily extendable by using nested TLVs. By hiding
> > this you basically remove this extensibility.
>
> Current netlink is not ex
On Mon, Jul 25, 2005 at 09:56:56PM -0700, Stephen Hemminger ([EMAIL PROTECTED])
wrote:
> Evgeniy Polyakov wrote:
>
> >On Tue, Jul 26, 2005 at 01:46:04AM +0200, Patrick McHardy
> >([EMAIL PROTECTED]) wrote:
> >
> >
> >>Evgeniy Polyakov wrote:
> >>
> >>
> >>>On Mon, Jul 25, 2005 at 04:32:32PM
Evgeniy Polyakov wrote:
On Tue, Jul 26, 2005 at 01:46:04AM +0200, Patrick McHardy ([EMAIL PROTECTED])
wrote:
Evgeniy Polyakov wrote:
On Mon, Jul 25, 2005 at 04:32:32PM +0200, Patrick McHardy
([EMAIL PROTECTED]) wrote:
If I understand correctly it tries to workaround some net
On Tue, Jul 26, 2005 at 01:46:04AM +0200, Patrick McHardy ([EMAIL PROTECTED])
wrote:
> Evgeniy Polyakov wrote:
> >On Mon, Jul 25, 2005 at 04:32:32PM +0200, Patrick McHardy
> >([EMAIL PROTECTED]) wrote:
> >
> >>If I understand correctly it tries to workaround some netlink
> >>limitations (limited
Hi,
I am new to networking.I want to do a project in networking,Would
you please give any suggessions and the resources.
Thanking you,
raja
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.k
Balazs Scheidler <[EMAIL PROTECTED]> wrote:
>
> While reading through the xfrm code I've found a possible array overflow
> in struct sock.
Thanks for catching this. However, the check should be done in xfrm_user
as we do for af_key. The following patch does just that.
Signed-off-by: Herbert Xu
From: Thomas Graf <[EMAIL PROTECTED]>
Date: Tue, 26 Jul 2005 01:38:08 +0200
> Therefore I'd say stick to the device pointers for now to be on the
> safe side, in case we're missing a 4 bytes saving for cacheline
> reasons we can think about this again and defuse the worst case a
> bit by increasin
On Jul 25, 2005, at 5:01 PM, John Ronciak wrote:
The manual covers all of the PCI/PCI-X controllers supported by the
e1000 driver. We will be following this release up with another
manual which covers our PCI-Express controllers.
Thanks John (and Intel) for providing this.
I did a quick sca
* Patrick McHardy <[EMAIL PROTECTED]> 2005-07-26 02:16
> Thomas Graf wrote:
> >* Patrick McHardy <[EMAIL PROTECTED]> 2005-07-26 01:46
> >
> >>You still have to take care of mixed 64/32 bit environments, u64 fields
> >>for example are differently alligned.
> >
> >My solution to this (in the same pat
Thomas Graf wrote:
* Patrick McHardy <[EMAIL PROTECTED]> 2005-07-26 01:46
You still have to take care of mixed 64/32 bit environments, u64 fields
for example are differently alligned.
My solution to this (in the same patchset) is that we never
derference u64s but instead copy them.
I don't
At long last the software developers manual for the Intel PRO/1000
Gigabit Ethernet controllers is now available on our Sourceforge web
site. The URL is: http://sourceforge.net/projects/e1000
The manual covers all of the PCI/PCI-X controllers supported by the
e1000 driver. We will be following t
* Patrick McHardy <[EMAIL PROTECTED]> 2005-07-26 01:46
> Netlink users don't have to care about shared or cloned skbs. I don't
> think its a big issue to use alloc_skb and then the usual netlink
> macros. Thomas added a number of macros that simplfiy use a lot.
Once I've finished the generic netli
Evgeniy Polyakov wrote:
On Mon, Jul 25, 2005 at 04:32:32PM +0200, Patrick McHardy ([EMAIL PROTECTED])
wrote:
If I understand correctly it tries to workaround some netlink
limitations (limited number of netlink families and multicast groups)
by sending everything to userspace and demultiplexing
* David S. Miller <[EMAIL PROTECTED]> 2005-07-25 16:18
> From: Thomas Graf <[EMAIL PROTECTED]>
> Date: Tue, 26 Jul 2005 01:11:13 +0200
>
> > Not sure but as I see it:
> ...
> > The __dev_get_by_index() can be expensive with
> > more than a 1k interfaces but the hash generally
> > does well so I d
jamal wrote:
On Mon, 2005-25-07 at 15:49 -0700, Ben Greear wrote:
jamal wrote:
Name is not totaly sane either:
I think one of the fscked s/ware i have seen is pppd that tries
to recycle names immediately with the same name but different ifindex.
It should probably use ppp for name.
That w
From: Thomas Graf <[EMAIL PROTECTED]>
Date: Tue, 26 Jul 2005 01:11:13 +0200
> Not sure but as I see it:
...
> The __dev_get_by_index() can be expensive with
> more than a 1k interfaces but the hash generally
> does well so I don't see much of a problem.
Whilst this does save us 4 bytes on 64-bit
On Tue, 2005-26-07 at 00:56 +0200, Thomas Graf wrote:
> There is no code to set this flag at the moment so my question
> simply is what are your plans regarding this flag? It's dead code
> at the moment.
Ok, sorry, i misunderstood you then.
Shouldnt be dead for long. The dummy device will use it
From: Patrick McHardy <[EMAIL PROTECTED]>
Date: Tue, 26 Jul 2005 00:58:25 +0200
> It is one of the three patches I sent on the 23. in the morning:
>
> [NETFILTER]: Fix unresolved symbol __nfa_fill when nfnetlink is not
> compiled in
>
> According to my logs it was successfully delivered, didn't
* David S. Miller <[EMAIL PROTECTED]> 2005-07-25 15:56
> From: Thomas Graf <[EMAIL PROTECTED]>
> Date: Tue, 26 Jul 2005 00:35:05 +0200
>
> > We can also use ifindex and hold a reference. We won't access input_dev
> > too often so a __dev_get_by_ifindex() won't be too expensive given the
> > number
On Mon, 2005-25-07 at 15:54 -0700, David S. Miller wrote:
> We should probably just bite the bullet and do something like:
>
> static inline void skb_set_input_dev(struct sk_buff *skb, struct net_device
> *dev)
> {
> struct net_device *orig_dev = skb->input_dev;
>
> if (orig_dev)
>
On Mon, 2005-25-07 at 15:49 -0700, Ben Greear wrote:
> jamal wrote:
> > Name is not totaly sane either:
> > I think one of the fscked s/ware i have seen is pppd that tries
> > to recycle names immediately with the same name but different ifindex.
> > It should probably use ppp for name.
>
> That
David S. Miller wrote:
From: Patrick McHardy <[EMAIL PROTECTED]>
Date: Tue, 26 Jul 2005 00:53:15 +0200
The patch I send uses ifdefs to fix it for now.
Ok, where is it? :-)
It is one of the three patches I sent on the 23. in the morning:
[NETFILTER]: Fix unresolved symbol __nfa_fill when
* jamal <[EMAIL PROTECTED]> 2005-07-25 18:40
> On Tue, 2005-26-07 at 00:32 +0200, Thomas Graf wrote:
> > I was referring to the tc_verd & TC_NCLS check in tcf_action_exec()
> > which uses input_dev in a printk. I assume dave was referring to the
> > same code part. What is intended usage of TC_NCLS
From: Thomas Graf <[EMAIL PROTECTED]>
Date: Tue, 26 Jul 2005 00:32:32 +0200
> I was referring to the tc_verd & TC_NCLS check in tcf_action_exec()
> which uses input_dev in a printk. I assume dave was referring to the
> same code part.
Yes, I was.
-
To unsubscribe from this list: send the line "un
From: Thomas Graf <[EMAIL PROTECTED]>
Date: Tue, 26 Jul 2005 00:35:05 +0200
> We can also use ifindex and hold a reference. We won't access input_dev
> too often so a __dev_get_by_ifindex() won't be too expensive given the
> number of interfaces is not too big but that's another issue.
Since the
From: Patrick McHardy <[EMAIL PROTECTED]>
Date: Tue, 26 Jul 2005 00:53:15 +0200
> The patch I send uses ifdefs to fix it for now.
Ok, where is it? :-)
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://v
From: jamal <[EMAIL PROTECTED]>
Date: Mon, 25 Jul 2005 18:42:55 -0400
> Having centralized it like Dave is intending to makes it tricky on where
> to actually issue the hold/put.
We should probably just bite the bullet and do something like:
static inline void skb_set_input_dev(struct sk_buff *
David S. Miller wrote:
From: Stephen Hemminger <[EMAIL PROTECTED]>
Date: Mon, 25 Jul 2005 14:17:52 -0700
MODPOST
*** Warning: "__nfa_fill" [net/ipv4/netfilter/iptable_nat.ko] undefined!
*** Warning: "__nfa_fill" [net/ipv4/netfilter/ip_conntrack.ko]
undefined!
There seems no easy fix for thi
jamal wrote:
If a device goes down, and comes back up with the same name
but a different ifindex, we should still match it with existing
rules based upon name.
The ifindex will change if you unload a module;
If you try hard enough you will hit a point where things will wrap
around; you ju
On Tue, 2005-26-07 at 00:35 +0200, Thomas Graf wrote:
> * jamal <[EMAIL PROTECTED]> 2005-07-25 18:28
> > So ifindex maybe the simplest way to go. If someone unloads a module
> > for the netdevice then loads it back or pops out a hotplug net card
> > and then pops it in - could we safely assume they
On Tue, 2005-26-07 at 00:32 +0200, Thomas Graf wrote:
> * jamal <[EMAIL PROTECTED]> 2005-07-25 18:22
> > > The code block which uses input_dev is dead, TC_NCLS is never
> > > set as of now. Jamal might have use for it though? Generally,
> > > tcf_action_exec() may be called on both ingress and egre
David S. Miller wrote:
From: Ben Greear <[EMAIL PROTECTED]>
Date: Mon, 25 Jul 2005 14:13:20 -0700
From what I remember, a new message could be added with a 32-bit
or so routing table identifier. It should be backwards compatible since
and old version of IP would never create or access the rou
* jamal <[EMAIL PROTECTED]> 2005-07-25 18:28
> So ifindex maybe the simplest way to go. If someone unloads a module
> for the netdevice then loads it back or pops out a hotplug net card
> and then pops it in - could we safely assume they are talking about
> another device? ;->
We can also use ifin
* jamal <[EMAIL PROTECTED]> 2005-07-25 18:22
> > The code block which uses input_dev is dead, TC_NCLS is never
> > set as of now. Jamal might have use for it though? Generally,
> > tcf_action_exec() may be called on both ingress and egress.
>
> I mentioned the meta action already; the dummy device
On Mon, 2005-25-07 at 15:19 -0700, David S. Miller wrote:
> The idea is to do the changes as a multi-step process :-)
>
> First, we do the input_dev initialization in a centralized
> location, then we investigate the legality of using ifindex.
>
> So we've done the first part, and are now discus
On Mon, 2005-25-07 at 22:09 +0200, Thomas Graf wrote:
> * David S. Miller <[EMAIL PROTECTED]> 2005-07-25 12:09
> > Ok, so can we agree on the following patch? ing_filter() should
> > never see a NULL ->input_dev, and we could add a BUG() check
> > there for that invariant if you want.
>
> This lo
From: jamal <[EMAIL PROTECTED]>
Date: Mon, 25 Jul 2005 18:14:45 -0400
> BTW, I just glanced at your suggested patch. If we are not going to use
> ifindex we aint saving the 4 bytes on 64 bit machines. And we have to
> keep refcounts and release devices.
The idea is to do the changes as a multi-st
On Mon, 2005-25-07 at 13:54 -0700, David S. Miller wrote:
> From: Thomas Graf <[EMAIL PROTECTED]>
> Date: Mon, 25 Jul 2005 22:16:21 +0200
>
> > * David S. Miller <[EMAIL PROTECTED]> 2005-07-25 13:14
> > > We removed INPUT_DEV from the meta ematch last week remember?
> >
> > Sure, but we can readd
Olof Johansson writes:
>
> Here's a new patch on top of that tree. Yet again, it builds, but I don't
> have a setup to test it with just yet. I'll work on that later this week,
> If someone else (Robert?) has a chance to give it a run before that,
> let me know.
Hello!
Thanks. A huge pat
From: Stephen Hemminger <[EMAIL PROTECTED]>
Date: Mon, 25 Jul 2005 14:17:52 -0700
> MODPOST
> *** Warning: "__nfa_fill" [net/ipv4/netfilter/iptable_nat.ko] undefined!
> *** Warning: "__nfa_fill" [net/ipv4/netfilter/ip_conntrack.ko]
> undefined!
There seems no easy fix for this one.
Harald, it's
From: Ben Greear <[EMAIL PROTECTED]>
Date: Mon, 25 Jul 2005 14:13:20 -0700
> From what I remember, a new message could be added with a 32-bit
> or so routing table identifier. It should be backwards compatible since
> and old version of IP would never create or access the routing tables > 0xFF,
>
On Sun, 24 Jul 2005 17:57:05 -0700 (PDT)
"David S. Miller" <[EMAIL PROTECTED]> wrote:
> From: Harald Welte <[EMAIL PROTECTED]>
> Date: Sat, 23 Jul 2005 01:11:08 -0400
>
> > so there now is
> > rsync://rsync.kernel.org/pub/scm/linux/kernel/git/davem/
> > net-2.6.14.git/ and
> > rsync://rsync.kern
David S. Miller wrote:
From: Ben Greear <[EMAIL PROTECTED]>
Date: Sun, 24 Jul 2005 23:25:53 -0700
When these other changes go in, is there any chance that
we can get support for more than 256 routing tables? That
can help make all of these virtual interfaces more useful
for some of us with st
Andy Fleming <[EMAIL PROTECTED]> :
> This patch contains the PHY layer itself, no phy drivers
[...]
> diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig
> new file mode 100644
> --- /dev/null
> +++ b/drivers/net/phy/Kconfig
[...]
> +config MARVELL_PHY
> + bool "Drivers for Marvell P
From: Thomas Graf <[EMAIL PROTECTED]>
Date: Mon, 25 Jul 2005 22:16:21 +0200
> * David S. Miller <[EMAIL PROTECTED]> 2005-07-25 13:14
> > We removed INPUT_DEV from the meta ematch last week remember?
>
> Sure, but we can readd it once its clear how it will be used.
> What I meant is that the meta
From: Thomas Graf <[EMAIL PROTECTED]>
Date: Mon, 25 Jul 2005 22:05:21 +0200
> The meta ematch which will the primary user of input_dev
> provides both, filtering by ifindex and by name so I'm fine
> with input_dev being an ifindex.
We removed INPUT_DEV from the meta ematch last week remember?
-
T
* David S. Miller <[EMAIL PROTECTED]> 2005-07-25 13:14
> From: Thomas Graf <[EMAIL PROTECTED]>
> Date: Mon, 25 Jul 2005 22:05:21 +0200
>
> > The meta ematch which will the primary user of input_dev
> > provides both, filtering by ifindex and by name so I'm fine
> > with input_dev being an ifindex.
* David S. Miller <[EMAIL PROTECTED]> 2005-07-25 11:46
> There is, of course, still the issue of refcounting. If we go
> the ifindex route for skb->input_dev, it might make sense to
> translate device specifications in action rules into ifindex.
> But things could break if you down then up a devic
* David S. Miller <[EMAIL PROTECTED]> 2005-07-25 12:09
> Ok, so can we agree on the following patch? ing_filter() should
> never see a NULL ->input_dev, and we could add a BUG() check
> there for that invariant if you want.
This looks good to me, a input_dev==NULL means the packets
origin is loca
This patch contains the PHY drivers
diff --git a/drivers/net/phy/cicada.c b/drivers/net/phy/cicada.c
new file mode 100644
--- /dev/null
+++ b/drivers/net/phy/cicada.c
@@ -0,0 +1,134 @@
+/*
+ * drivers/net/phy/cicada.c
+ *
+ * Driver for Cicada PHYs
+ *
+ * Author: Andy Fleming
+ *
+ * Copyright (
From: Adrian Bunk <[EMAIL PROTECTED]>
Date: Sun, 24 Jul 2005 00:05:30 +0200
> This patch contains the following possible cleanups:
> - make needlessly global code static
> - #if 0 the following unused global function:
> - xfrm4_state.c: xfrm4_state_fini
> - remove the following unneeded EXPORT_S
On Mon, Jul 25, 2005 at 04:43:43PM +0200, Eric Leblond ([EMAIL PROTECTED])
wrote:
> Le lundi 25 juillet 2005 à 16:32 +0200, Patrick McHardy a écrit :
> > Evgeniy Polyakov wrote:
> > > On Mon, Jul 25, 2005 at 02:02:10AM -0400, James Morris ([EMAIL
> > > PROTECTED]) wrote:
> > If I understand corre
Hi,
On Sun, 24 Jul 2005, David S. Miller wrote:
> I'll sit on this until we get some feedback from Roman.
The second patch looks better, minus the typo in the description and the
initial comment in the patch is a little redundant.
bye, Roman
-
To unsubscribe from this list: send the line "unsu
On Mon, Jul 25, 2005 at 04:32:32PM +0200, Patrick McHardy ([EMAIL PROTECTED])
wrote:
> Evgeniy Polyakov wrote:
> >On Mon, Jul 25, 2005 at 02:02:10AM -0400, James Morris
> >([EMAIL PROTECTED]) wrote:
> >
> >>On Sun, 24 Jul 2005, David S. Miller wrote:
> >>
> >>>From: Evgeniy Polyakov <[EMAIL PROTE
From: Ben Greear <[EMAIL PROTECTED]>
Date: Sun, 24 Jul 2005 23:25:53 -0700
> When these other changes go in, is there any chance that
> we can get support for more than 256 routing tables? That
> can help make all of these virtual interfaces more useful
> for some of us with strange routing fetis
From: Jamal Hadi Salim <[EMAIL PROTECTED]>
Date: Mon, 25 Jul 2005 09:50:33 -0400
>
> if (!skb->input_dev)
> skb->input_dev = skb->dev->ifindex;
> -
>
> We get rid of the printk and all other places that set input_dev except
> for mirred.
> Any new actions can continue to
I just upgraded my Dell 2800 from kernel 2.6.7 to 2.6.11 and noticed that
the e1000 driver doesn't work when I change the MTU from 1500 to something
larger. I traced the bug down to the following item in
e1000_main.c::e1000_up(). In a past life I recall PHY's needing to
explicitly have the 'power
From: Jamal Hadi Salim <[EMAIL PROTECTED]>
Date: Mon, 25 Jul 2005 09:50:33 -0400
> how about we set it in only ing_filter() if it is zero. i.e,
>
>
> if (!skb->input_dev)
> skb->input_dev = skb->dev->ifindex;
> -
Ok... how about we take this one step further? The idea
b
On Tue, 19 Jul 2005, Jason L Tibbitts III wrote:
mii-tool -v eth0:
eth0: negotiated 100baseTx-FD flow-control, link ok
product info: vendor 00:50:43, model 2 rev 3
basic mode: autonegotiation enabled
basic status: autonegotiation complete, link ok
capabilities: 100baseTx-FD 100baseTx-HD
On Thu, 21 Jul 2005, [EMAIL PROTECTED] wrote:
> dropped: rnbc does not mean dropped, see above. mpc means dropped.
>
> fifo: mpc means the fifo overflowed, and the packet was dropped (the
> only time we drop).
>
> missed: this should also be mpc because it shows we missed the packet.
Wow, thank
* Jamal Hadi Salim <[EMAIL PROTECTED]> 2005-07-25 09:50
> Thomas:
> bit 0 of tc_verd can be moved into cb;
Any reason why we don't see OK2MUNGE in the action itself but
have it triggered by setting MUNGED first?
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a m
> I am not against reporting back (NETDEV_TX_CONTINUE or
> NETDEV_TX_GIVE_ME_THE_SAME_Q_AGAIN for example);
> what worries me is that the stopping of the queue being complex. As i
> said, I may be worrying too much and i will be proved wrong.
I understand, this schema will probably work perfectly
I'll throw these into the driver...
Jeff
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Le lundi 25 juillet 2005 à 16:32 +0200, Patrick McHardy a écrit :
> Evgeniy Polyakov wrote:
> > On Mon, Jul 25, 2005 at 02:02:10AM -0400, James Morris ([EMAIL PROTECTED])
> > wrote:
> If I understand correctly it tries to workaround some netlink
> limitations (limited number of netlink families an
Evgeniy Polyakov wrote:
On Mon, Jul 25, 2005 at 02:02:10AM -0400, James Morris ([EMAIL PROTECTED])
wrote:
On Sun, 24 Jul 2005, David S. Miller wrote:
From: Evgeniy Polyakov <[EMAIL PROTECTED]>
Date: Sat, 23 Jul 2005 13:14:55 +0400
Andrew has no objection against connector and it lives in
On Sun, 2005-24-07 at 23:18 -0400, Jamal Hadi Salim wrote:
> > Posting a bunch of patches that explicitly set input_dev to dev
> > right before netif_rx() sort of further proves my point :-)
> >
>
> ;->
> Let me sleep it over and think about it - I am not thinking straight
> right now. I am back
> Hi,
>
> I'm attaching a small testprogram which tries to install an
> XFRM_POLICY_FWD, and I confirmed with a printk that the value of 2 is
> successfully propagated to xfrm_sk_policy_insert().
test program originally missed, here it is this time.
--
Bazsi
#include
#include
#include
#incl
Sorry, I read my emails in a LIFO manner - typically that works well
with last email in thread covering all the previous, but occasionally
something is left over.
On Sat, 2005-23-07 at 18:14 +0200, Thomas Graf wrote:
> > i.e you map the time slots to weights and priorities on the rings to the
>
> > Since we're introducing some changes to the network stack
> > (SO_RCVBUFFORCE, ...), I would like to update the respective man pages.
> >
> > I think Andi wrote most of the current ones, but said they're
> > unmaintained by now. If this is still the case, can someone please
> > send me the l
Hi,
While reading through the xfrm code I've found a possible array overflow
in struct sock.
When issuing a setsockopt(SOL_IP, IP_XFRM_POLICY) on a socket, a
function called xfrm_user_policy() is called to compile and install a
socket specific XFRM policy.
This function calls km->compile_policy(
On Sat, Jul 23, 2005 at 05:29:38PM +0100, Ben Dooks wrote:
> The DM9000 driver is responding to ioctl() calls it should not be. This
> can cause problems with the wireless tools incorrectly indentifying the
> device as wireless capable, and crashing under certain operations.
>
> This patch also mo
Hi,
On Sat, Jul 23, 2005 at 05:25:18PM +0100, Ben Dooks wrote:
> Fix DM9000 driver usage of spinlocks, which mainly came to light
> when running a kernel with spinlock debugging. These come down to:
>
> 1) Un-initialised spin lock
>
> 2) Several cases of using spin_xxx(lock) and not spin_xxx(&l
On Mon, Jul 25, 2005 at 02:02:10AM -0400, James Morris ([EMAIL PROTECTED])
wrote:
> On Sun, 24 Jul 2005, David S. Miller wrote:
> >From: Evgeniy Polyakov <[EMAIL PROTECTED]>
> >Date: Sat, 23 Jul 2005 13:14:55 +0400
> >
> >>Andrew has no objection against connector and it lives in -mm
> >
> >A patc
74 matches
Mail list logo
