[RFC] Net vm deadlock fix (take two)

2005-08-06 Thread Daniel Phillips
Hi, This version does not do blatantly stupid things in hardware irq context, is more efficient, and... wow the patch is smaller! (That never happens.) I don't mark skbs as being allocated from reserve any more. That works, but it is slightly bogus, because it doesn't matter which skb came

Re: [PATCH] netpoll can lock up on low memory.

2005-08-06 Thread Daniel Phillips
On Saturday 06 August 2005 12:32, Steven Rostedt wrote: If you need to really get the data out, then the design should be changed. Have some return value showing the failure, check for oops_in_progress or whatever, and try again after turning interrupts back on, and getting to a point

Re: [PATCH] netpoll can lock up on low memory.

2005-08-06 Thread Ingo Molnar
* Andi Kleen [EMAIL PROTECTED] wrote: On Fri, Aug 05, 2005 at 01:01:57PM -0700, Matt Mackall wrote: The netpoll philosophy is to assume that its traffic is an absolute priority - it is better to potentially hang trying to deliver a panic message than to give up and crash silently. That

Re: critical section violation in tg3.c?

2005-08-06 Thread David S. Miller
Simply do the pci_save_state before the register_netdev() call, no need to mess around with the locking. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: test

2005-08-06 Thread David S. Miller
From: Daniel Phillips [EMAIL PROTECTED] Date: Sat, 6 Aug 2005 04:52:07 +1000 So then there is no choice but to throttle the per-cpu -input_pkt queues. Make the driver support NAPI if you want device fairness. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a

Re: ICMP broken in 2.6.13-rc5

2005-08-06 Thread Harald Welte
On Sat, Aug 06, 2005 at 02:08:15AM +0400, Vladimir B. Savkin wrote: I found that it really is NOTRACK who cause? bogus ICMP errors. Well, this means that your ICMP errors need to be NAT'ed but they cannot, since the original connection causing the ICMP error did not go through connection

[PATCH 5/6][INET] Generalise tcp_v4_hash tcp_unhash

2005-08-06 Thread Arnaldo Carvalho de Melo
David, First set of changesets, please consider pulling from: rsync://rsync.kernel.org/pub/scm/linux/kernel/git/acme/net-2.6.14.git - Arnaldo tree 7095737bc15a06613ef809457f95847e88a66550 parent f48ce924d611ea239cc3527235c2d926715564bb author Arnaldo

[PATCH 6/6][INET] Generalise tcp_v4_lookup_listener

2005-08-06 Thread Arnaldo Carvalho de Melo
David, First set of changesets, please consider pulling from: rsync://rsync.kernel.org/pub/scm/linux/kernel/git/acme/net-2.6.14.git - Arnaldo tree 74a7900b3b8a414e7bd2703d46ab098cb3058c97 parent 31c00831e34dd1da084057326655a0a080ba5fb2 author Arnaldo

Re: [PATCH 6/6][INET] Generalise tcp_v4_lookup_listener

2005-08-06 Thread David S. Miller
All pulled, as well as your dccp-2.6.14 tree, into net-2.6.14 It should show up on the kernel.org mirrors shortly. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 6/6][INET] Generalise tcp_v4_lookup_listener

2005-08-06 Thread Arnaldo Carvalho de Melo
On 8/6/05, David S. Miller [EMAIL PROTECTED] wrote: All pulled, as well as your dccp-2.6.14 tree, into net-2.6.14 It should show up on the kernel.org mirrors shortly. WOW, that was fast, thank you! I'll be just one e-mail away to work right away on fixing any bug introduced by these

ANNOUNCE: Linux DCCP implementation merged

2005-08-06 Thread Arnaldo Carvalho de Melo
Hi Guys, I'm very pleased to announce that the Linux 2.6 DCCP implementation has been merged in David Miller's net-2.6.14.git tree, and should appear shortly on Andrew Morton's 2.6.13-rcLATEST-mm tree and finally in mainline when Linus starts 2.6.14. There is still a lot of work

Re: [PATCH] netpoll can lock up on low memory.

2005-08-06 Thread Steven Rostedt
On Sat, 2005-08-06 at 02:46 -0700, David S. Miller wrote: Can you guys stop peeing your pants over this, put aside your differences, and work on a mutually acceptable fix for these bugs? Much appreciated, thanks :-) In my last email, I stated that this discussion seems to have demonstrated

Re: [PATCH] IPSec anti-replay sequence numbers

2005-08-06 Thread Ulrich Weber
KOVACS Krisztian wrote: Hi, On Friday 05 August 2005 12.50, Patrick McHardy wrote: Is there already userspace code which uses this feature somewhere? AFAIK Ulrich has a patch for OpenSWAN, and we (Balabit) have a patch for racoon. Unfortunately this racoon version is available

Re: [PATCH] netpoll can lock up on low memory.

2005-08-06 Thread Andi Kleen
On Sat, Aug 06, 2005 at 09:45:03AM +0200, Ingo Molnar wrote: * Andi Kleen [EMAIL PROTECTED] wrote: On Fri, Aug 05, 2005 at 01:01:57PM -0700, Matt Mackall wrote: The netpoll philosophy is to assume that its traffic is an absolute priority - it is better to potentially hang trying to

Re: assertion (cnt = tp-packets_out) failed

2005-08-06 Thread John Bäckstrand
Hang on a second, the original poster mentioned rc5. Is this really pristine rc5 with the one netpoll patch? If so then it can't be the patches we're talking about because they only went in days later. Yes, I have no other patches in, so if it was not in -RC5, I was not running it. --- John

Re: [PATCH] netpoll can lock up on low memory.

2005-08-06 Thread John Bäckstrand
Steven Rostedt wrote: In my last email, I stated that this discussion seems to have demonstrated that the e1000 driver's netpoll is indeed broken, and needs to be fixed. I submitted eariler a patch for this, but it's untested and someone who owns an e1000 needs to try it. I can test this,

Re: [PATCH 1/1][INET] Make inet_create try to load protocol modules

2005-08-06 Thread David S. Miller
From: [EMAIL PROTECTED] (Arnaldo Carvalho de Melo) Date: Sat, 6 Aug 2005 10:01:05 -0300 + /* Be more specific, e.g. net-pf-2-132-1 (net-pf-PF_INET-IPPROTO_SCTP-SOCK_STREAM) */ + if (++try_loading_module == 1) +

Re: [PATCH 1/1][INET] Make inet_create try to load protocol modules

2005-08-06 Thread Arnaldo Carvalho de Melo
Em Sat, Aug 06, 2005 at 06:24:35AM -0700, David S. Miller escreveu: From: [EMAIL PROTECTED] (Arnaldo Carvalho de Melo) Date: Sat, 6 Aug 2005 10:01:05 -0300 + /* Be more specific, e.g. net-pf-2-132-1 (net-pf-PF_INET-IPPROTO_SCTP-SOCK_STREAM) */ + if

Re: [PATCH 2.6 6/5] tg3: Fix bug in setting a tg3_flag

2005-08-06 Thread David S. Miller
Michael, I've added all 6 patches to my net-2.6.14 tree. It should show up on the kernel.org GIT mirrors shortly. I decided against sticking this into 2.6.13, as these changes can introduce regressions and the space of users effected by this problem is decidedly small compared to how many could

Re: assertion (cnt = tp-packets_out) failed

2005-08-06 Thread David S. Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Sat, 6 Aug 2005 17:57:17 +1000 Hang on a second, the original poster mentioned rc5. Is this really pristine rc5 with the one netpoll patch? If so then it can't be the patches we're talking about because they only went in days later. This seems to be

[PATCH 1/1][INET] Make inet_create try to load protocol modules

2005-08-06 Thread Arnaldo Carvalho de Melo
Em Sat, Aug 06, 2005 at 06:24:35AM -0700, David S. Miller escreveu: From: [EMAIL PROTECTED] (Arnaldo Carvalho de Melo) Date: Sat, 6 Aug 2005 10:01:05 -0300 + /* Be more specific, e.g. net-pf-2-132-1 (net-pf-PF_INET-IPPROTO_SCTP-SOCK_STREAM) */ + if

Re: [PATCH 1/2] LSM-IPSec Networking Hooks -- revised flow cache [resend]

2005-08-06 Thread Trent Jaeger
OK. Thanks for the comments. I'll get back soon. Regards, Trent. Trent Jaeger IBM T.J. Watson Research Center 19 Skyline Drive, Hawthorne, NY 10532 (914) 784-7225, FAX (914) 784-7225 Herbert Xu [EMAIL PROTECTED] 08/06/2005 03:45

Re: ICMP broken in 2.6.13-rc5

2005-08-06 Thread Harald Welte
On Sat, Aug 06, 2005 at 01:25:43PM +0400, Vladimir B. Savkin wrote: On Sat, Aug 06, 2005 at 11:13:37AM +0200, Harald Welte wrote: On Sat, Aug 06, 2005 at 02:08:15AM +0400, Vladimir B. Savkin wrote: I found that it really is NOTRACK who cause? bogus ICMP errors. Well, this means that

Re: ICMP broken in 2.6.13-rc5

2005-08-06 Thread Vladimir B. Savkin
On Sat, Aug 06, 2005 at 05:12:01PM +0200, Harald Welte wrote: Well, this means that your ICMP errors need to be NAT'ed but they cannot, since the original connection causing the ICMP error did not go through connection tracking. How so, when there are no NAT rules that can match

Re: ICMP broken in 2.6.13-rc5

2005-08-06 Thread Vladimir B. Savkin
On Sat, Aug 06, 2005 at 04:58:46PM +0200, Patrick McHardy wrote: Harald Welte wrote: On Sat, Aug 06, 2005 at 02:08:15AM +0400, Vladimir B. Savkin wrote: I found that it really is NOTRACK who cause? bogus ICMP errors. Good work tracking this down. I've seen reports of this before, but

Re: atheros driver - desc

2005-08-06 Thread Kalle Valo
Mateusz Berezecki [EMAIL PROTECTED] writes: The driver is not yet fully working because I didn't finish kernel integration yet. Almost all driver I/O ops are reverse engineered independently of openbsd openhal which is missing just too much. Ok, enough talking. Most of the atheros 5212 hal

Re: w1 netlink

2005-08-06 Thread Evgeniy Polyakov
On Sat, Aug 06, 2005 at 09:37:00PM +0200, Patrick McHardy ([EMAIL PROTECTED]) wrote: I'm working on extending netlink to work with an arbitary number of groups and stumbled over this in the w1 driver: dev-groups = 23 NETLINK_CB(skb).dst_group = dev-groups;

Re: kfree_skb questions

2005-08-06 Thread Patrick McHardy
Daniel Phillips wrote: Hi, The way I read this, __kfree_skb will sometimes be called with -users = 1 and sometimes with -users = 0, is that right? Yes. static inline void kfree_skb(struct sk_buff *skb) { if (likely(atomic_read(skb-users) == 1)) smp_rmb();

Re: kfree_skb questions

2005-08-06 Thread Daniel Phillips
On Sunday 07 August 2005 06:26, Patrick McHardy wrote: Anyway, do we not want BUG_ON(!atomic_read(skb-users)) at the beginning of kfree_skb, since we rely on it? Why do you care if skb-users is 0 or 1 in __kfree_skb()? Because I am a neatness freak and I like to check things that

[PATCH] reorganize include/linux/dccp.h

2005-08-06 Thread Harald Welte
Hi Arnaldo! The protocol header files in linux/foo.h are usually structured in a way to be included by userspace code. The top section consists of general protocol structure definitions, typedefs, enums - followed by an #ifdef __KERNEL__ section. Currently linux/dccp.h doesn't follow that

Re: [PATCH] reorganize include/linux/dccp.h

2005-08-06 Thread Arnaldo Carvalho de Melo
On 8/6/05, Harald Welte [EMAIL PROTECTED] wrote: Hi Arnaldo! The protocol header files in linux/foo.h are usually structured in a way to be included by userspace code. The top section consists of general protocol structure definitions, typedefs, enums - followed by an #ifdef __KERNEL__

Re: atheros driver - desc

2005-08-06 Thread Mateusz Berezecki
Kalle Valo [EMAIL PROTECTED] wrote: | | This is great news. An open source Atheros driver which could be | included to Linux is really needed. | | But how was the reverse engineering done? I noticed that forcedeth | driver was implemented using the clean room design[1] and Linux | Broadcom 4301

Re: ANNOUNCE: Linux DCCP implementation merged

2005-08-06 Thread Harald Welte
On Sat, Aug 06, 2005 at 06:57:15AM -0300, Arnaldo Carvalho de Melo wrote: Hi Guys, I'm very pleased to announce that the Linux 2.6 DCCP implementation has been merged in David Miller's net-2.6.14.git tree, and should appear shortly on Andrew Morton's 2.6.13-rcLATEST-mm tree and finally

[RFC] Net vm deadlock fix, version 4

2005-08-06 Thread Daniel Phillips
Hi, This patch fills in some missing pieces: * Support v4 udp: same as v4 tcp, when in reserve, drop packets on noncritical sockets * Support v4 icmp: when in reserve, drop icmp traffic * Add reserve skb support to e1000 driver * API for dropping packets before delivery

Re: [PATCH] netpoll can lock up on low memory.

2005-08-06 Thread Matt Mackall
On Sat, Aug 06, 2005 at 09:58:27AM +0200, Ingo Molnar wrote: btw., the current NR_SKBS 32 in netpoll.c seems quite low, especially e1000 can have a whole lot more skbs queued at once. Might be more robust to increase it to 128 or 256? Not sure that the card's queueing really makes a