Re: [Bcm43xx-dev] Re: [softmac-dev] [PATCH] ieee80211_rx_any: filter out packets, call ieee80211_rx or ieee80211_rx_mgt

2006-01-24 Thread Denis Vlasenko
On Monday 23 January 2006 16:32, Johannes Berg wrote: On Sun, 2006-01-22 at 14:04 +0200, Denis Vlasenko wrote: + hdr = (struct ieee80211_hdr_4addr *)skb-data;: + fc = le16_to_cpu(hdr-frame_ctl);: +: + switch (fc IEEE80211_FCTL_FTYPE) {: + case

[PATCH] increase ipw2100 driver version to git-1.1.4

2006-01-24 Thread Zhu Yi
[PATCH] ipw2100: increase ipw2100 driver version to git-1.1.4 --- a/drivers/net/wireless/ipw2100.c +++ b/drivers/net/wireless/ipw2100.c @@ -167,7 +167,7 @@ that only one external action is invoked #include ipw2100.h -#define IPW2100_VERSION 1.1.3 +#define IPW2100_VERSION git-1.1.4

Fw: [Bugme-new] [Bug 5946] New: KERNEL: assertion (!sk-sk_forward_alloc) failed at net/core/stream.c (279)

2006-01-24 Thread Andrew Morton
Begin forwarded message: Date: Tue, 24 Jan 2006 00:11:51 -0800 From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: [Bugme-new] [Bug 5946] New: KERNEL: assertion (!sk-sk_forward_alloc) failed at net/core/stream.c (279) http://bugzilla.kernel.org/show_bug.cgi?id=5946 Summary:

[PATCH 00/18] ipw2200 driver updated

2006-01-24 Thread Zhu Yi
Hi, Here is a series of patches for ipw2200 driver. It brings ipw2200 up to date (version 1.0.10 from ipw2200.sf.net and with more recent patches from my queue and others). Patches include: [PATCH 01/18] ipw2200: Fix NETDEV_TX_BUSY erroneous returned [PATCH 02/18] ipw2200: Fix iwspy ethx off

[PATCH 07/18] ipw2200: Bluetooth coexistence support

2006-01-24 Thread Zhu Yi
[PATCH] ipw2200: Bluetooth coexistence support I've added a new module param bt_coexist which defaults to OFF. This does not seem to fix the firmware restarts, but it does do the right thing and disables something that we were enabling by default: signaling the Bluetooth h/w which channel we're

[PATCH 06/18] ipw2200: Add LEAP authentication algorithm support

2006-01-24 Thread Zhu Yi
[PATCH] ipw2200: Add LEAP authentication algorithm support Signed-off-by: Hong Liu [EMAIL PROTECTED] Signed-off-by: Zhu Yi [EMAIL PROTECTED] --- --- a/drivers/net/wireless/ipw2200.c +++ b/drivers/net/wireless/ipw2200.c @@ -6254,6 +6254,9 @@ static int ipw_wpa_set_auth_algs(struct }

[PATCH 04/18] ipw2200: Fix indirect SRAM/register 8/16-bit write routines

2006-01-24 Thread Zhu Yi
[PATCH] ipw2200: Fix indirect SRAM/register 8/16-bit write routines The indirect SRAM/register 8/16-bit write routines are broken for non-dword-aligned destination addresses. Fortunately, these routines are, so far, not used for non-dword-aligned destinations, but here's a patch that fixes

[PATCH 03/18] ipw2200: Fix sw_reset doesn't clear the static essid problem

2006-01-24 Thread Zhu Yi
[PATCH] ipw2200: Fix sw_reset doesn't clear the static essid problem Signed-off-by: Zhu Yi [EMAIL PROTECTED] --- --- a/drivers/net/wireless/ipw2200.c +++ b/drivers/net/wireless/ipw2200.c @@ -8012,6 +8015,10 @@ static int ipw_sw_reset(struct ipw_priv else

[PATCH 11/18] ipw2200: Scale firmware loading watchdog with the firmware size

2006-01-24 Thread Zhu Yi
[PATCH] ipw2200: Scale firmware loading watchdog with the firmware size. I can't really help with why restarts happen, but the following patch greatly increases the likelihood that a firmware reload will succeed afterward on my thinkpad. It addresses two issues. First, sysfs module loading and

[PATCH 10/18] ipw2200: add module parameter to enable/disable roaming

2006-01-24 Thread Zhu Yi
[PATCH] ipw2200: add module parameter to enable/disable roaming Signed-off-by: Zhu Yi [EMAIL PROTECTED] --- --- a/drivers/net/wireless/ipw2200.c +++ b/drivers/net/wireless/ipw2200.c @@ -57,6 +57,7 @@ static int led = 0; static int disable = 0; static int bt_coexist = 0; static int hwcrypto =

[PATCH 12/18] ipw2200: stack reduction

2006-01-24 Thread Zhu Yi
[PATCH] ipw2200 stack reduction Checking the stack usage of my kernel, showed that ipw2200 had a few bad offenders. This is on i386 32-bit: 0x2876 ipw_send_associate: 544 0x28ee ipw_send_associate: 544 0x27dc

[PATCH 14/18] ipw2200: Fix a variable referenced after kfree() bug

2006-01-24 Thread Zhu Yi
[PATCH] ipw2200: Fix a variable referenced after kfree() bug. Signed-off-by: Zhu Yi [EMAIL PROTECTED] --- --- a/drivers/net/wireless/ipw2200.c +++ b/drivers/net/wireless/ipw2200.c @@ -11144,8 +11150,8 @@ static void ipw_pci_remove(struct pci_de /* Free MAC hash list for ADHOC */

[PATCH 15/18] ipw2200: increase ipw2200 driver version

2006-01-24 Thread Zhu Yi
[PATCH] ipw2200: increase ipw2200 driver version to git-1.0.10 Signed-off-by: Zhu Yi [EMAIL PROTECTED] --- --- a/drivers/net/wireless/ipw2200.c +++ b/drivers/net/wireless/ipw2200.c @@ -33,7 +33,7 @@ #include ipw2200.h #include linux/version.h -#define IPW2200_VERSION git-1.0.8 +#define

[PATCH 13/18] ipw2200: Fix qos_cmd param switch bug

2006-01-24 Thread Zhu Yi
[PATCH] ipw2200: Fix qos_cmd param switch bug The patch fixes a couple of errors regarding QoS, which results in compile warnings and malfunction of the driver. Signed-off-by: Henrik Brix Andersen [EMAIL PROTECTED] Signed-off-by: Zhu Yi [EMAIL PROTECTED] --- ---

[PATCH 09/18] ipw2200: Make LED blinking frequency independ of HZ

2006-01-24 Thread Zhu Yi
[PATCH] ipw2200: Make LED blinking frequency independ of HZ Signed-off-by: Clemens Buchacher [EMAIL PROTECTED]. Signed-off-by: Zhu Yi [EMAIL PROTECTED] --- --- a/drivers/net/wireless/ipw2200.c +++ b/drivers/net/wireless/ipw2200.c @@ -776,9 +776,9 @@ u32 ipw_register_toggle(u32 reg) * - On

[PATCH 16/18] ipw2200: remove white space and better format the code

2006-01-24 Thread Zhu Yi
[PATCH] ipw2200: remove white space and better format the code Signed-off-by: James Ketrenos [EMAIL PROTECTED] Signed-off-by: Zhu Yi [EMAIL PROTECTED] --- --- a/drivers/net/wireless/ipw2200.c +++ b/drivers/net/wireless/ipw2200.c @@ -272,7 +272,6 @@ static inline void ipw_write_reg32(struc

[PATCH 18/18] ipw2200: Disable hwcrypto by default

2006-01-24 Thread Zhu Yi
[PATCH] ipw2200: Disable hwcrypto by default After looking at the mailing list (and experiencing permanent driver lockups while using hwcrypto=1) I think that disabling this option by default would be better than otherwise. Signed-off-by: Andreas Happe [EMAIL PROTECTED] ---

Re: Fw: [Bugme-new] [Bug 5946] New: KERNEL: assertion (!sk-sk_forward_alloc) failed at net/core/stream.c (279)

2006-01-24 Thread Krzysztof Oledzki
On Tue, 24 Jan 2006, Andrew Morton wrote: Begin forwarded message: Date: Tue, 24 Jan 2006 00:11:51 -0800 From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: [Bugme-new] [Bug 5946] New: KERNEL: assertion (!sk-sk_forward_alloc) failed at net/core/stream.c (279)

Re: [BUG] sky2 broken for Yukon PCI-E Gigabit Ethernet Controller 11ab:4362 (rev 19)

2006-01-24 Thread Knut Petersen
Stephen Hemminger schrieb: Could you try turning off rx checksumming (with ethtool). ethtool -K eth0 rx off There probably still are (generic) bugs in the netfilter code for CHECKSUM_HW socket buffers. ethtool -K eth0 rx off does cure my problem with sky2. Anybody is invited to

[PATCH] sky2: fix ethtool ops

2006-01-24 Thread Carl-Daniel Hailfinger
This fixes setting rx_coalesce_usecs_irq via ethtool in sky2. The write was directed to the wrong register. Signed-off-by: Carl-Daniel Hailfinger [EMAIL PROTECTED] --- linux/drivers/net/sky2.c2006-01-23 23:41:35.0 +0100 +++ linux/drivers/net/sky2.c2006-01-24 12:52:11.0

driver skb reuse

2006-01-24 Thread Robert Olsson
Hello! We disussed the resue of skb's some time ago. Below some code to examine how skb's can be reused if upper layer (RX softirq) can consume the skb so we with in NAPI path can detect and reuse the skb. It can give new possibilites for TCP optimization (davem), driver common copbreak etc.

sky2 rx error (was: Re: sky2 freezes the system)

2006-01-24 Thread Pekka Pietikainen
On Mon, Jan 23, 2006 at 08:03:15PM +0200, Pekka Pietikainen wrote: The box is a Nexcom NSA 1086 with 4x skge ports and 4x sky2. acpi=off made the driver work apparently, haven't used it with much load yet, though. Ran the box for a while with some load (the sky2 ports on the box are only used

Re: [Patch 7/7] mv643xx_eth: use MII library for ethtool functions

2006-01-24 Thread Dale Farnsworth
On Fri, Jan 20, 2006 at 05:06:09PM -0700, I wrote: Use the common ethtool support functions of the MII library. Add generic MII ioctl handler. Add PHY parameter speed/duplex/negotiation initialization and modification. I've seen a couple of unexplained network failures with this patch (7/7),

Re: [PATCH] sky2: fix hang on Yukon-EC (0xb6) rev 1

2006-01-24 Thread Stephen Hemminger
On Tue, 24 Jan 2006 14:19:56 +0100 Carl-Daniel Hailfinger [EMAIL PROTECTED] wrote: This patch for sky2 fixes a hang on Yukon-EC (0xb6) rev 1 where suddenly no more interrupts were delivered. I don't know the real cause of the hang due to lack of docs, but the patch has been running stable

Re: [BUG] sky2 broken for Yukon PCI-E Gigabit Ethernet Controller 11ab:4362 (rev 19)

2006-01-24 Thread Stephen Hemminger
On Tue, 24 Jan 2006 10:43:57 +0100 Knut Petersen [EMAIL PROTECTED] wrote: Stephen Hemminger schrieb: Could you try turning off rx checksumming (with ethtool). ethtool -K eth0 rx off There probably still are (generic) bugs in the netfilter code for CHECKSUM_HW socket buffers.

Re: [PATCH] sky2: fix hang on Yukon-EC (0xb6) rev 1

2006-01-24 Thread Carl-Daniel Hailfinger
Stephen Hemminger schrieb: On Tue, 24 Jan 2006 14:19:56 +0100 Carl-Daniel Hailfinger [EMAIL PROTECTED] wrote: This patch for sky2 fixes a hang on Yukon-EC (0xb6) rev 1 where suddenly no more interrupts were delivered. I don't know the real cause of the hang due to lack of docs, but the

Re: [Patch 1/1] Resubmit: TCP/UDP getpeersec

2006-01-24 Thread James Morris
On Mon, 23 Jan 2006, Catherine Zhang wrote: +static int selinux_socket_getpeersec_udp(struct sk_buff *skb, char **scontext, u32 *scontext_len) +{ + int err = 0; + u32 peer_sid = selinux_socket_getpeer_udp(skb); + + if (!peer_sid) + return -EINVAL; + + err =

Re: driver skb reuse

2006-01-24 Thread Ben Greear
Robert Olsson wrote: + /* + * If skb is consumed by RX softirq we can simply use it again + * otherwise undo the users increment with kfree +*/ + + if (!multi_descriptor atomic_read(skb-users) == 1 + realloc_skb(skb, adapter-rx_buffer_len, GFP_ATOMIC)) { +

Re: driver skb reuse

2006-01-24 Thread David S. Miller
From: Ben Greear [EMAIL PROTECTED] Date: Tue, 24 Jan 2006 12:25:21 -0800 That 16 is probably the same bug as broke pktgen for chelsio NICs. Shouldn't we take the netdev-hard_header_len into account?? Ben, this code is in the e1000 driver... don't be rediculious :) - To unsubscribe from this

Re: [BUG] sky2 broken for Yukon PCI-E Gigabit Ethernet Controller 11ab:4362 (rev 19)

2006-01-24 Thread Herbert Xu
Knut Petersen [EMAIL PROTECTED] wrote: ethtool -K eth0 rx off does cure my problem with sky2. Anybody is invited to send patches as the problem is 100% reproducible here. Does the problem go away if you disable conntrack by unloading its module? Please try to capture the offending ICMP

Re: driver skb reuse

2006-01-24 Thread Benjamin LaHaise
On Tue, Jan 24, 2006 at 02:23:15PM +0100, Robert Olsson wrote: etc. In the test below I use my usual lab setup but just let netfilter drop the packets. We win about 13% in this experiment below. Here we process (drop) about 13% packets more when skb'a get reued. Instead of doing a

Re: driver skb reuse

2006-01-24 Thread David S. Miller
From: Benjamin LaHaise [EMAIL PROTECTED] Date: Tue, 24 Jan 2006 15:58:27 -0500 Instead of doing a completely separate skb reuse path, what happens if you remove the memset() from __alloc_skb() and instead do it in a slab ctor? I remember seeing that in the profiles for af_unix. Dave, could

Re: [PATCH] fix MLDv2 change records when transitioning to/from inactive

2006-01-24 Thread David S. Miller
From: David Stevens [EMAIL PROTECTED] Date: Thu, 19 Jan 2006 15:30:02 -0700 The following patch fixes these problems in MLDv2: 1) Add/remove delete records for sending change reports when addition of a filter results in that filter transitioning to/from inactive. [same as

Re: [PATCH] mii: check carrier state even when force_media == 1

2006-01-24 Thread Jeff Garzik
On Tue, Jan 24, 2006 at 03:50:09PM -0500, John W. Linville wrote: Drivers using mii_check_media (via-rhine in particular) and also forcing link parameters with ethtool can reach a state where the link goes down and never comes back up. This is because mii_check_media short-circuits early if

Re: driver skb reuse

2006-01-24 Thread Robert Olsson
Benjamin LaHaise writes: Instead of doing a completely separate skb reuse path, what happens if you remove the memset() from __alloc_skb() and instead do it in a slab ctor? I remember seeing that in the profiles for af_unix. Dave, could you refresh my memory why the slab ctor ended

NAK: [PATCH 01/18] ipw2200: Fix NETDEV_TX_BUSY erroneous returned

2006-01-24 Thread Stefan Rompf
Am Dienstag 24 Januar 2006 09:36 schrieb Zhu Yi: Two problems in ipw2200: 1. We now have the ieee_device-is_queue_full interface, and it will be called at the beginning of ieee80211_xmit function. So no need to call it at the driver xmit function. This interface is totally broken.

Re: [PATCH] Additional options for resetting packet statistics

2006-01-24 Thread YOSHIFUJI Hideaki / 吉藤英明
Hello. In article [EMAIL PROTECTED] (at Sat, 7 Jan 2006 10:05:52 -0800), Kris Katterjohn [EMAIL PROTECTED] says: PACKET_AUTO_STATISTICS is the default and the kernel will zero the packet statistics when the PACKET_STATISTICS getsockopt() call is used. + case PACKET_AUTO_STATISTICS: +

[PATCH] ipw2200: fix -eeprom[EEPROM_VERSION] check

2006-01-24 Thread Alexey Dobriyan
priv-eeprom is a pointer. Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED] --- drivers/net/wireless/ipw2200.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/wireless/ipw2200.c +++ b/drivers/net/wireless/ipw2200.c @@ -2456,7 +2456,7 @@ static void

Re: [PATCH] Additional options for resetting packet statistics

2006-01-24 Thread Kris Katterjohn
From: YOSHIFUJI Hideaki Sent: 1/24/2006 3:20:32 PM We can merge PACKET_AUTO_STATISTICS and PACKET_MANUAL_STATISTICS, into one, e.g. PACKET_ACCUMULATED_STATISTICS, and we can reuse PACKET_STATISTICS for resetting; case PACKET_ACCUMULATED_STATISTICS: { int val;

Re: [PATCH] Additional options for resetting packet statistics

2006-01-24 Thread Kris Katterjohn
From: Kris Katterjohn Sent: 1/24/2006 4:38:26 PM --- x/include/linux/if_packet.h 2006-01-24 18:27:41.0 -0600 +++ y/include/linux/if_packet.h 2006-01-24 17:50:02.0 -0600 @@ -37,8 +37,9 @@ struct sockaddr_ll #define PACKET_RECV_OUTPUT 3 /* Value 4 is

Re: [PATCH] ipw2200: fix -eeprom[EEPROM_VERSION] check

2006-01-24 Thread Zhu Yi
Acked. Thanks, -yi On Wed, 2006-01-25 at 03:44 +0300, Alexey Dobriyan wrote: priv-eeprom is a pointer. Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED] --- drivers/net/wireless/ipw2200.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/wireless/ipw2200.c

Re: NAK: [PATCH 01/18] ipw2200: Fix NETDEV_TX_BUSY erroneous returned

2006-01-24 Thread Zhu Yi
On Tue, 2006-01-24 at 23:09 +0100, Stefan Rompf wrote: This interface is totally broken. Actually this happens in ipw2200 since version 1.0.8: -dev-hard_start_xmit() calls ieee80211_xmit() -ieee80211_xmit() calls into ieee-is_queue_full() which is ipw_net_is_queue_full() for the ipw2200

[PATCH] ipw2200: support WEXT-18 enc_capa v3

2006-01-24 Thread Zhu Yi
[PATCH] ipw2200: support WEXT-18 enc_capa v3 Dan Williams added a corresponding patch to IPW2100. This patch does the same thing for ipw2200. Signed-off-by: Miles Lane [EMAIL PROTECTED] Signed-off-by: Zhu Yi [EMAIL PROTECTED] --- --- a/drivers/net/wireless/ipw2200.c +++

Re: [PATCH] mii: check carrier state even when force_media == 1

2006-01-24 Thread Denis Vlasenko
On Tuesday 24 January 2006 23:12, Jeff Garzik wrote: On Tue, Jan 24, 2006 at 03:50:09PM -0500, John W. Linville wrote: Drivers using mii_check_media (via-rhine in particular) and also forcing link parameters with ethtool can reach a state where the link goes down and never comes back up.

Re: NAK: [PATCH 01/18] ipw2200: Fix NETDEV_TX_BUSY erroneous returned

2006-01-24 Thread James Ketrenos
Stefan Rompf wrote: Am Dienstag 24 Januar 2006 09:36 schrieb Zhu Yi: Two problems in ipw2200: 1. We now have the ieee_device-is_queue_full interface, and it will be called at the beginning of ieee80211_xmit function. So no need to call it at the driver xmit function. This