Re: [RFC, patch-2.6, RESEND] Controlling the auto-route setting behaviour of the kernel

2006-03-06 Thread Sven Anders
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Herbert Xu schrieb: Sven Anders [EMAIL PROTECTED] wrote: This enables the user - as an example - to set all routes in the local table automatically, but leave the main table untouched. (This is the special case I needed.) If you want you can

Another gss_krb5 double kfre

2006-03-06 Thread Dave Jones
Variation on a theme, with same result - double free of same object. Coverity #950 Signed-off-by: Dave Jones [EMAIL PROTECTED] --- linux-2.6/net/sunrpc/auth_gss/gss_krb5_seal.c~ 2006-03-06 04:23:05.0 -0500 +++ linux-2.6/net/sunrpc/auth_gss/gss_krb5_seal.c 2006-03-06

spider_net versus sungem_phy

2006-03-06 Thread Andrew Morton
drivers/net/spider_net.c:421: multiple definition of `mii_phy_probe' drivers/net/sungem_phy.o(.opd+0x160):drivers/net/sungem_phy.c:95: first defined here - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

SIOCGMIIPHY on 'eth2' failed: Operation not supported

2006-03-06 Thread Ozgur Karatas
hello, ozgur:/lib/modules/2.6.12-1-386/kernel/drivers/net# uname -ar Linux ozgur 2.6.12-1-386 #1 Tue Sep 27 12:41:08 JST 2005 i686 GNU/Linux ozgur:/lib/modules/2.6.12-1-386/kernel/drivers/net#ls 3c501.koamd8111e.ko dl2k.ko forcedeth.ko ne2.ko ppp_generic.ko slip.ko

Re: GigE on PowerMac G5

2006-03-06 Thread Benjamin Herrenschmidt
On Mon, 2006-03-06 at 11:40 +0100, Andreas Schwab wrote: Benjamin Herrenschmidt [EMAIL PROTECTED] writes: On Sat, 2006-03-04 at 15:53 +0100, Andreas Schwab wrote: I suppose the NIC in the PowerMac G5 can do GigE, yet when plugged into a GB switch it is only willing to talk 100MB with it.

Re: [XFRM]: Fix aevent related crash

2006-03-06 Thread Patrick McHardy
Patrick McHardy wrote: Fix a regression in net-2.6.17 from the aevent patches. Protect references of xfrm_nl from outside of xfrm_user by RCU, check that the socket is present in xfrm_aevent_is_on and set it to NULL when unloading xfrm_user. static void __exit xfrm_user_exit(void) {

Re: [XFRM]: Fix aevent related crash

2006-03-06 Thread jamal
On Mon, 2006-06-03 at 15:01 +0100, Patrick McHardy wrote: xfrm_user can be a module, so an ifdef won't help. good point. The rcu_dereference doesn't cost anything except on alpha. We could reduce the overhead a bit more by avoiding the rcu_read_lock/rcu_read_unlock, the code is AFAICT

Re: [XFRM]: Fix aevent related crash

2006-03-06 Thread Patrick McHardy
jamal wrote: On Mon, 2006-06-03 at 15:01 +0100, Patrick McHardy wrote: The rcu_dereference doesn't cost anything except on alpha. We could reduce the overhead a bit more by avoiding the rcu_read_lock/rcu_read_unlock, the code is AFAICT only called from the xfrm output functions, which already

Re: de2104x: interrupts before interrupt handler is registered

2006-03-06 Thread Martin Michlmayr
* Francois Romieu [EMAIL PROTECTED] [2006-03-05 19:59]: I have a system on which I can reproduce this bug 100%. While I have no idea how to fix the issue, I can provide debugging information and test a fix. (not compile-tested) Thanks a lot for your quick response, Francois. I can

[RFC/PATCH 13/13] d80211: fix AP interfaces

2006-03-06 Thread Jiri Benc
This allows interfaces of IEEE80211_SUB_IF_TYPE_MGMT type (wlan%dap interfaces) to be put UP. Signed-off-by: Jiri Benc [EMAIL PROTECTED] Index: dscape/net/d80211/ieee80211.c === --- dscape.orig/net/d80211/ieee80211.c 2006-03-06

[RFC/PATCH 9/13] d80211: master interface auto up/down

2006-03-06 Thread Jiri Benc
There is no reason to put master interface to UP/DOWN state manually. Calling of hw-open and hw-stop callbacks logically belongs to ieee80211_master_open and ieee80211_master_stop functions, but then we need to refuse putting master interface to UP state when there is no other interface running,

[RFC/PATCH 1/13] d80211: allow WDS remote to by set by WE

2006-03-06 Thread Jiri Benc
Setting of address of WDS remote peer wasn't possible by a WE call. Remote WDS peer can be understood as a remote AP and SIOCSIWAP/SIOCGIWAP are unused in WDS mode, so let's use them. Signed-off-by: Jiri Benc [EMAIL PROTECTED] Index: dscape/net/d80211/ieee80211.c

[RFC/PATCH 5/13] d80211: ask driver for allowed iface combinations

2006-03-06 Thread Jiri Benc
Not all combinations of interfaces (in fact, very few combination of interfaces) are possible to be UP together. When an interface is going UP, let's ask the driver if this is possible. Please note that ieee80211_if_conf structure is not complete yet - new fields will need to be added to allow

Re: RFC: move SDP from AF_INET_SDP to IPPROTO_SDP

2006-03-06 Thread David Stevens
I don't know any details about SDP, but if there are no differences at the protocol layer, then neither the address family nor the protocol is appropriate. If it's just an API change, the socket type is the right selector. So, maybe SOCK_DIRECT to go along with SOCK_STREAM, SOCK_DGRAM, etc.

Re: de2104x: interrupts before interrupt handler is registered

2006-03-06 Thread Francois Romieu
Martin Michlmayr [EMAIL PROTECTED] : [...] There's another interrupt related bug in the driver, though. I sometimes get a kernel panic when rsycing several 100 megs of data across the LAN. A picture showing the call trace can be found at http://www.cyrius.com/tmp/de2104x_panic.jpg Can you

Re: Discourage duplicate symbols in the kernel? [Was: Intel I/O Acc...]

2006-03-06 Thread Chris Leech
On 3/5/06, Andrew Morton [EMAIL PROTECTED] wrote: Sam Ravnborg [EMAIL PROTECTED] wrote: On Sun, Mar 05, 2006 at 12:09:33AM -0800, Andrew Morton wrote: + +static inline u8 read_reg8(struct cb_device *device, unsigned int offset) +{ +return readb(device-reg_base +

Re: de2104x: interrupts before interrupt handler is registered

2006-03-06 Thread Martin Michlmayr
* Francois Romieu [EMAIL PROTECTED] [2006-03-06 20:48]: There's another interrupt related bug in the driver, though. I sometimes get a kernel panic when rsycing several 100 megs of data across the LAN. A picture showing the call trace can be found at

[PATCH 1/6] IB: common handling for marshalling parameters to/from userspace

2006-03-06 Thread Sean Hefty
Provide common handling for marshalling data between userspace clients and kernel mode Infiniband drivers. Signed-off-by: Sean Hefty [EMAIL PROTECTED] --- diff -uprN -X linux-2.6.git/Documentation/dontdiff linux-2.6.git/drivers/infiniband/core/Makefile

[PATCH 2/6] IB: match connection requests based on private data

2006-03-06 Thread Sean Hefty
Extend matching connection requests to listens in the Infiniband CM to include private data checks. This allows applications to listen on the same service identifier, with private data directing the request to the appropriate application. Signed-off-by: Sean Hefty [EMAIL PROTECTED] --- diff

[PATCH 3/6] net/IB: export ip_dev_find

2006-03-06 Thread Sean Hefty
Export ip_dev_find to allow locating a net_device given an IP address. Signed-off-by: Sean Hefty [EMAIL PROTECTED] --- diff -uprN -X linux-2.6.git/Documentation/dontdiff linux-2.6.git/net/ipv4/fib_frontend.c linux-2.6.ib/net/ipv4/fib_frontend.c --- linux-2.6.git/net/ipv4/fib_frontend.c

[PATCH 4/6] IB: address translation to map IP to IB addresses (GIDs)

2006-03-06 Thread Sean Hefty
Add an address translation service that maps IP addresses to Infiniband GID addresses using IPoIB. Signed-off-by: Sean Hefty [EMAIL PROTECTED] --- diff -uprN -X linux-2.6.git/Documentation/dontdiff linux-2.6.git/drivers/infiniband/core/addr.c linux-2.6.ib/drivers/infiniband/core/addr.c ---

[PATCH 6/6] IB: userspace support for RDMA connection manager

2006-03-06 Thread Sean Hefty
Kernel component necessary to support the userspace RDMA connection management library. Signed-off-by: Sean Hefty [EMAIL PROTECTED] --- diff -uprN -X linux-2.6.git/Documentation/dontdiff linux-2.6.git/drivers/infiniband/core/Makefile linux-2.6.ib/drivers/infiniband/core/Makefile ---

RE: [PATCH 2/6] IB: match connection requests based on private data

2006-03-06 Thread Caitlin Bestler
-Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Sean Hefty Sent: Monday, March 06, 2006 11:04 AM To: 'Roland Dreier' Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; openib-general@openib.org Subject: [PATCH 2/6] IB: match connection

[PATCH 5/6] IB: IP address based RDMA connection manager

2006-03-06 Thread Sean Hefty
Kernel mode connection management agent over Infiniband that connects based on IP addresses. The agent defines a generic RDMA connection abstraction to support clients wanting to connect over different RDMA devices. Agent also handles RDMA device hotplug events on behalf of clients.

Re: [openib-general] RE: [PATCH 2/6] IB: match connection requests based on private data

2006-03-06 Thread Sean Hefty
Caitlin Bestler wrote: The term private data is intended to convey the intent that the data is private to the application layer and is opaque to middleware and the network. The private data area is for the use of whatever client resides above the Infiniband CM only. There is no assumption

RE: RFC: move SDP from AF_INET_SDP to IPPROTO_SDP

2006-03-06 Thread Caitlin Bestler
-Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of David Stevens Sent: Monday, March 06, 2006 11:49 AM To: Michael S. Tsirkin Cc: Linux Kernel Mailing List; netdev@vger.kernel.org Subject: Re: RFC: move SDP from AF_INET_SDP to IPPROTO_SDP I

Re: RFC: move SDP from AF_INET_SDP to IPPROTO_SDP

2006-03-06 Thread Michael S. Tsirkin
Quoting r. David Stevens [EMAIL PROTECTED]: Subject: Re: RFC: move SDP from AF_INET_SDP to IPPROTO_SDP I don't know any details about SDP, but if there are no differences at the protocol layer, then neither the address family nor the protocol is appropriate. If it's just an API change, the

Re: de2104x: interrupts before interrupt handler is registered

2006-03-06 Thread Francois Romieu
Martin Michlmayr [EMAIL PROTECTED] : [...] http://www.cyrius.com/tmp/config-2.6.16-rc5-486 By the way, I'm getting the following messages in dmesg: netconsole appears enabled. Do you use it ? -- Ueimor - To unsubscribe from this list: send the line unsubscribe netdev in the body of a

RE: RFC: move SDP from AF_INET_SDP to IPPROTO_SDP

2006-03-06 Thread Caitlin Bestler
-Original Message- From: David Stevens [mailto:[EMAIL PROTECTED] Sent: Monday, March 06, 2006 12:32 PM To: Caitlin Bestler Cc: Linux Kernel Mailing List; Michael S. Tsirkin; netdev@vger.kernel.org Subject: RE: RFC: move SDP from AF_INET_SDP to IPPROTO_SDP IPPROTO_* should

IPv6: avoid dereference of null route entry in ipv6_del_addr()

2006-03-06 Thread Jean-Mickael Guerin
Hi, This patch fixes potential null pointer dereference (I never experiment such crash). The patch is made for net-2.6.17. Regards, Jean-Mickael Signed-off-by: [EMAIL PROTECTED] -- diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index 8df9eb9..8393f45 100644 ---

Re: [RFC/PATCH 6/13] d80211: remove obsolete stuff

2006-03-06 Thread Jouni Malinen
On Mon, Mar 06, 2006 at 08:07:26PM +0100, Jiri Benc wrote: On Mon, 6 Mar 2006 10:49:46 -0800, Jouni Malinen wrote: The reason for this optimization was in even high-end CPUs starting to run out of resources when running one radio with 2007 virtual STAs, Yes, I'm aware of that. But I'm

Re: de2104x: interrupts before interrupt handler is registered

2006-03-06 Thread Francois Romieu
Martin Michlmayr [EMAIL PROTECTED] : [...] By the way, I'm getting the following messages in dmesg: eth0: tx err, status 0x7fffb002 Tx underrun. Is there anything which could induce a noticeable load on the PCI bus ? -- Ueimor - To unsubscribe from this list: send the line unsubscribe

spider_net versus sungem_phy

2006-03-06 Thread Jens Osterkamp
Which kernel version was this in ? 2.6.16-rc5 builds ok for me. drivers/net/spider_net.c:421: multiple definition of `mii_phy_probe' drivers/net/sungem_phy.o(.opd+0x160):drivers/net/sungem_phy.c:95: first defined here - - To unsubscribe from this list: send the line unsubscribe netdev in the

Re: [PATCH 2/9] sky2: warn on newer untested chips

2006-03-06 Thread Stephen Hemminger
Wrong version... of patch please use this one! - The driver includes support for the lowcost version of Yukon-EC chipset. Since this has never been explictly tested, add a disclaimer message to get some feedback. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] ---

Re: [PATCH 7/9] sky2: smarter irq handling

2006-03-06 Thread Francois Romieu
(s/osld.org/osdl.org/g) Stephen Hemminger [EMAIL PROTECTED] : Redo the interupt handling of sky2 driver based on the IRQ mangement documentation. All interrupts are handled by the device0 NAPI poll routine. Is there something beyond smarter irq handling which would urge to merge this code for

Re: [PATCH 7/9] sky2: smarter irq handling

2006-03-06 Thread Jeff Garzik
Stephen Hemminger wrote: On Mon, 6 Mar 2006 22:30:59 +0100 Francois Romieu [EMAIL PROTECTED] wrote: (s/osld.org/osdl.org/g) Stephen Hemminger [EMAIL PROTECTED] : Redo the interupt handling of sky2 driver based on the IRQ mangement documentation. All interrupts are handled by the device0

Re: [PATCH 7/9] sky2: smarter irq handling

2006-03-06 Thread Stephen Hemminger
On Mon, 6 Mar 2006 22:30:59 +0100 Francois Romieu [EMAIL PROTECTED] wrote: (s/osld.org/osdl.org/g) Stephen Hemminger [EMAIL PROTECTED] : Redo the interupt handling of sky2 driver based on the IRQ mangement documentation. All interrupts are handled by the device0 NAPI poll routine. Is

[EMAIL PROTECTED]: [PATCH] use fget_light() in net/socket.c]

2006-03-06 Thread Benjamin LaHaise
Hello folks, Here's an updated copy of the patch to use fget_light in net/socket.c. Rerunning the tests show a drop of ~80Mbit/s on average, which looks bad until you see the drop in cpu usage from ~89% to ~82%. That will get fixed in another patch... Before: max 8113.70, min 8026.32, avg

[RFC/PATCH] rcuification of ipv4 established and timewait connections

2006-03-06 Thread Benjamin LaHaise
Hello again, This patch introduces the use of rcu for the ipv4 established connections hashtable, as well as the timewait table since they are closely intertwined. This removes 4 atomic operations per packet from the tcp_v4_rcv codepath, which helps quite a bit when the other performance

Re: [EMAIL PROTECTED]: [PATCH] use fget_light() in net/socket.c]

2006-03-06 Thread Rick Jones
Benjamin LaHaise wrote: Hello folks, Here's an updated copy of the patch to use fget_light in net/socket.c. Rerunning the tests show a drop of ~80Mbit/s on average, which looks bad until you see the drop in cpu usage from ~89% to ~82%. That will get fixed in another patch... Before: max

Re: [PATCH 3/6] net/IB: export ip_dev_find

2006-03-06 Thread Roland Dreier
Sean Export ip_dev_find to allow locating a net_device given an Sean IP address. My plan is to queue all of this stuff for merging in 2.6.17. Is there any objection from netdev or openib-general people? I just looked back, and the original unexport ip_dev_find() patch was a de-Bunk-ing

Re: [PATCH 6/6] IB: userspace support for RDMA connection manager

2006-03-06 Thread Roland Dreier
+struct rdma_ucm_query_route_resp { +__u64 node_guid; +struct ib_user_path_rec ib_route[2]; +struct sockaddr_in6 src_addr; +struct sockaddr_in6 dst_addr; +__u32 num_paths; +__u8 port_num; +__u8 reserved[3]; +}; Is there a 32-bit/64-bit compatibility

Re: [PATCH 6/6] IB: userspace support for RDMA connection manager

2006-03-06 Thread Roland Dreier
I think it makes sense to merge patches 1-5 independently of this patch. The kernel interface is needed by iSER and NFS/RDMA, and maintaining compatibility isn't a huge deal, so we can merge it now (assuming it looks mergable). On the other hand I think it would be good to let this userspace

Re: [openib-general] Re: [PATCH 6/6] IB: userspace support for RDMA connection manager

2006-03-06 Thread Sean Hefty
Roland Dreier wrote: +struct rdma_ucm_query_route_resp { + __u64 node_guid; + struct ib_user_path_rec ib_route[2]; + struct sockaddr_in6 src_addr; + struct sockaddr_in6 dst_addr; + __u32 num_paths; + __u8 port_num; + __u8 reserved[3]; +}; Is there a 32-bit/64-bit compatibility

Re: [openib-general] Re: [PATCH 6/6] IB: userspace support for RDMA connection manager

2006-03-06 Thread Sean Hefty
Roland Dreier wrote: On the other hand I think it would be good to let this userspace interface cook a little more, say in -mm. I think that this makes sense. - Sean - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo

Re: [openib-general] Re: [PATCH 6/6] IB: userspace support for RDMA connection manager

2006-03-06 Thread Roland Dreier
Sean Unless I miss counted, they should be aligned. Sean ib_user_path_rec is defined near the end of patch 1/6. You're right. struct sockaddr_in6 is 28 bytes long (not a multiple of 8) but gcc seems to lay everything out the same on 32-bit and 64-bit architectures just the same. - R. -

Re: [RFC/PATCH 7/13] d80211: remove adm_status

2006-03-06 Thread Jean Tourrilhes
Jouni Malinen wrote : On Mon, Mar 06, 2006 at 04:44:27PM +0100, Jiri Benc wrote: PRISM2_PARAM_ADM_STATUS is not used anywhere in kernel nor in userspace. It just passes a value to the driver, so it's safe to remove it. This is used to implement radio on/off without having to change

Re: [PATCH 7/9] sky2: smarter irq handling

2006-03-06 Thread Stephen Hemminger
On Mon, 06 Mar 2006 16:57:11 -0500 Jeff Garzik [EMAIL PROTECTED] wrote: Stephen Hemminger wrote: On Mon, 6 Mar 2006 22:30:59 +0100 Francois Romieu [EMAIL PROTECTED] wrote: (s/osld.org/osdl.org/g) Stephen Hemminger [EMAIL PROTECTED] : Redo the interupt handling of sky2 driver

Re: [EMAIL PROTECTED]: [PATCH] use fget_light() in net/socket.c]

2006-03-06 Thread David S. Miller
From: Benjamin LaHaise [EMAIL PROTECTED] Date: Mon, 6 Mar 2006 13:59:39 -0800 Here's an updated copy of the patch to use fget_light in net/socket.c. I like this patch a lot, applied to net-2.6.17 I fixed this up by hand: Adds trailing whitespace. diff:286: fput_light(sock_file,

Re: [PATCH] minor net_rx_action optimization

2006-03-06 Thread David S. Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Mon, 6 Mar 2006 14:24:35 -0800 The functions list_del followed by list_add_tail is equivalent to the existing inline list_move_tail. list_move_tail avoids unnecessary _LIST_POISON. Trivial for 2.6.17. Signed-off-by: Stephen Hemminger [EMAIL

Re: [RFC/PATCH] rcuification of ipv4 established and timewait connections

2006-03-06 Thread David S. Miller
From: Benjamin LaHaise [EMAIL PROTECTED] Date: Mon, 6 Mar 2006 14:01:11 -0800 This patch introduces the use of rcu for the ipv4 established connections hashtable, as well as the timewait table since they are closely intertwined. Thanks for doing this work, I'll try study it seriously very

Re: [openib-general] Re: [PATCH 6/6] IB: userspace support for RDMA connection manager

2006-03-06 Thread David S. Miller
From: Roland Dreier [EMAIL PROTECTED] Date: Mon, 06 Mar 2006 13:58:32 -0800 Sean Unless I miss counted, they should be aligned. Sean ib_user_path_rec is defined near the end of patch 1/6. You're right. struct sockaddr_in6 is 28 bytes long (not a multiple of 8) but gcc seems to lay

Re: [openib-general] Re: [PATCH 6/6] IB: userspace support for RDMA connection manager

2006-03-06 Thread Roland Dreier
David Please make sure you check x86_64 vs. x86, and then David something like powerpc64 vs. powerpc32 or sparc64 David vs. sparc32, as those are the two different classes of ABI David layouts. Yes, I tried ppc64 vs ppc and it still comes out the same. Unfortunately I don't have

TSO and IPoIB performance degradation

2006-03-06 Thread Michael S. Tsirkin
Hello, Dave! As you might know, the TSO patches merged into mainline kernel since 2.6.11 have hurt performance for the simple (non-TSO) high-speed netdevice that is IPoIB driver. This was discussed at length here http://openib.org/pipermail/openib-general/2005-October/012271.html I'm trying to

Re: TSO and IPoIB performance degradation

2006-03-06 Thread David S. Miller
From: Michael S. Tsirkin [EMAIL PROTECTED] Date: Tue, 7 Mar 2006 00:34:38 +0200 So I'm trying to get a handle on it: could a solution be to simply look at the frame size, and call tcp_send_delayed_ack from if the frame size is no larger than 1/8? Does this make sense? The comment you

Re: [openib-general] Re: [PATCH 6/6] IB: userspace support for RDMA connection manager

2006-03-06 Thread David S. Miller
From: Roland Dreier [EMAIL PROTECTED] Date: Mon, 06 Mar 2006 14:32:28 -0800 The fundamental question seems to be whether things like struct foo { struct sockaddr_in6 src; struct sockaddr_in6 dst; }; and struct bar { struct

Re: [openib-general] Re: [PATCH 6/6] IB: userspace support for RDMA connection manager

2006-03-06 Thread Roland Dreier
David I wrote a test program and it looks ok: Cool, thanks. I should look into getting some niagara machines to test with -- with PCIe slots they should actually be good for IB testing. - R. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to

Re: [openib-general] Re: [PATCH 6/6] IB: userspace support for RDMA connection manager

2006-03-06 Thread David S. Miller
From: Roland Dreier [EMAIL PROTECTED] Date: Mon, 06 Mar 2006 14:41:21 -0800 I should look into getting some niagara machines to test with -- with PCIe slots they should actually be good for IB testing. You'll be cpu limited until we have Van Jacobson net channels. Also, since our existing

Re: [PATCH, RESEND] Add MWI workaround for Tulip DC21143

2006-03-06 Thread Martin Michlmayr
* Peter Horton [EMAIL PROTECTED] [2006-02-18 22:08]: This patch works around the MWI bug on the DC21143 rev 65 Tulip by ensuring that the receive buffers don't end on a cache line boundary (as documented in the errata). This patch is required for the MIPs based Cobalt Qube/RaQ as supporting

Re: spider_net versus sungem_phy

2006-03-06 Thread Arnd Bergmann
Am Monday 06 March 2006 23:07 schrieb Andrew Morton: Jens Osterkamp [EMAIL PROTECTED] wrote: Which kernel version was this in ? 2.6.16-rc5 builds ok for me. drivers/net/spider_net.c:421: multiple definition of `mii_phy_probe'

Re: [PATCH, RESEND] Add MWI workaround for Tulip DC21143

2006-03-06 Thread Francois Romieu
Martin Michlmayr [EMAIL PROTECTED] : [...] Does anyone have comments regarding this patch? I received confirmation from a number of Debian users that this patch significantly improves the lockup situation on Cobalt, so it would be nice if it could go in. I'll queue it with the pending

[PATCH] avoid memory barrier bitops in hot paths

2006-03-06 Thread Benjamin LaHaise
This patch removes a couple of memory barriers from atomic bitops that showed up on profiles of netperf. -ben Signed-off-by: Benjamin LaHaise [EMAIL PROTECTED] diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c index 00aa80e..dadc84c 100644 --- a/net/ipv4/tcp.c +++ b/net/ipv4/tcp.c @@

Re: [PATCH] avoid memory barrier bitops in hot paths

2006-03-06 Thread David S. Miller
From: Benjamin LaHaise [EMAIL PROTECTED] Date: Mon, 6 Mar 2006 15:06:41 -0800 This patch removes a couple of memory barriers from atomic bitops that showed up on profiles of netperf. A little ugly, we should have a nicer way to do this generically. - To unsubscribe from this list: send the

Re: [RFC/PATCH 7/13] d80211: remove adm_status

2006-03-06 Thread Jouni Malinen
On Mon, Mar 06, 2006 at 02:25:52PM -0800, Jean Tourrilhes wrote: Jouni Malinen wrote : This is used to implement radio on/off without having to change other parts of the configuration (e.g., set interfaces down). The airo driver use 'txpower' for that. txpower has a 'off' option, and

Re: [PATCH] avoid memory barrier bitops in hot paths

2006-03-06 Thread Arnaldo Carvalho de Melo
On 3/6/06, David S. Miller [EMAIL PROTECTED] wrote: From: Benjamin LaHaise [EMAIL PROTECTED] Date: Mon, 6 Mar 2006 15:06:41 -0800 This patch removes a couple of memory barriers from atomic bitops that showed up on profiles of netperf. A little ugly, we should have a nicer way to do this

[PATCH 2.6.17 1/9] tg3: Add 5787 and 5754 basic support

2006-03-06 Thread Michael Chan
Add basic support for 2 new chips 5787 and 5754. Signed-off-by: Michael Chan [EMAIL PROTECTED] diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c index 683d979..b24408a 100644 --- a/drivers/net/tg3.c +++ b/drivers/net/tg3.c @@ -221,6 +221,14 @@ static struct pci_device_id tg3_pci_tbl[

Re: IPv6: avoid dereference of null route entry in ipv6_del_addr()

2006-03-06 Thread YOSHIFUJI Hideaki / 吉藤英明
In article [EMAIL PROTECTED] (at Mon, 06 Mar 2006 21:50:33 +0100), Jean-Mickael Guerin [EMAIL PROTECTED] says: Hi, This patch fixes potential null pointer dereference (I never experiment such crash). The patch is made for net-2.6.17. I disagree. It never happen, because (void *)rt-u.dst

[PATCH 2.6.17 3/9] tg3: Add new hard_start_xmit

2006-03-06 Thread Michael Chan
Support 5787 hardware TSO using a new flag TG3_FLG2_HW_TSO_2. Since the TSO interface is slightly different and these chips have finally fixed the 4GB DMA problem and do not have the 40-bit DMA problem, a new hard_start_xmit is used for these chips. All previous chips will use the old

[PATCH 2.6.17 2/9] tg3: Add 5787 nvram support

2006-03-06 Thread Michael Chan
Support additional nvrams and new nvram format for 5787 and 5754. Signed-off-by: Michael Chan [EMAIL PROTECTED] diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c index b24408a..67de9f8 100644 --- a/drivers/net/tg3.c +++ b/drivers/net/tg3.c @@ -7816,29 +7816,53 @@ static void

[PATCH 2.6.17 8/9] tg3: Add firmware version info

2006-03-06 Thread Michael Chan
Add fw_version information to ethtool -i. Signed-off-by: Michael Chan [EMAIL PROTECTED] diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c index 1a35dbe..dd545b0 100644 --- a/drivers/net/tg3.c +++ b/drivers/net/tg3.c @@ -7666,6 +7666,7 @@ static void tg3_get_drvinfo(struct net_d

[PATCH 2.6.17 4/9] tg3: Add ipv6 checksum support

2006-03-06 Thread Michael Chan
Support ipv6 tx csum on 5787 by setting NETIF_F_HW_CSUM. Signed-off-by: Michael Chan [EMAIL PROTECTED] diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c index 3e7eb3d..8560f58 100644 --- a/drivers/net/tg3.c +++ b/drivers/net/tg3.c @@ -7871,10 +7871,10 @@ static int tg3_set_tx_csum(struct

Re: TSO and IPoIB performance degradation

2006-03-06 Thread Stephen Hemminger
On Tue, 7 Mar 2006 00:34:38 +0200 Michael S. Tsirkin [EMAIL PROTECTED] wrote: Hello, Dave! As you might know, the TSO patches merged into mainline kernel since 2.6.11 have hurt performance for the simple (non-TSO) high-speed netdevice that is IPoIB driver. This was discussed at length here

[PATCH 2/6 v2] IB: match connection requests based on private data

2006-03-06 Thread Sean Hefty
Extend matching connection requests to listens in the Infiniband CM to include private data checks. This allows applications to listen on the same service identifier, with private data directing the request to the appropriate application. Signed-off-by: Sean Hefty [EMAIL PROTECTED] --- This

Re: [RFC/PATCH] rcuification of ipv4 established and timewait connections

2006-03-06 Thread Eric Dumazet
Benjamin LaHaise a écrit : Hello again, This patch introduces the use of rcu for the ipv4 established connections hashtable, as well as the timewait table since they are closely intertwined. This removes 4 atomic operations per packet from the tcp_v4_rcv codepath, which helps quite a bit

Re: [PATCH] avoid memory barrier bitops in hot paths

2006-03-06 Thread Benjamin LaHaise
On Mon, Mar 06, 2006 at 08:29:30PM -0300, Arnaldo Carvalho de Melo wrote: - clear_bit(SOCK_ASYNC_NOSPACE, sk-sk_socket-flags); + if (test_bit(SOCK_ASYNC_NOSPACE, sk-sk_socket-flags)) + clear_bit(SOCK_ASYNC_NOSPACE, sk-sk_socket-flags); Something like

Re: [PATCH] avoid memory barrier bitops in hot paths

2006-03-06 Thread Eric Dumazet
Arnaldo Carvalho de Melo a écrit : On 3/6/06, David S. Miller [EMAIL PROTECTED] wrote: From: Benjamin LaHaise [EMAIL PROTECTED] Date: Mon, 6 Mar 2006 15:06:41 -0800 This patch removes a couple of memory barriers from atomic bitops that showed up on profiles of netperf. A little ugly, we

Re: [RFC/PATCH] rcuification of ipv4 established and timewait connections

2006-03-06 Thread Benjamin LaHaise
On Tue, Mar 07, 2006 at 12:48:23AM +0100, Eric Dumazet wrote: If I understand your patch correctly, your future plan is to change struct inet_ehash_bucket rwlock_t wlock to a pure spinlock (when ipv6 is converted to rcu lookups too), because no more read_lock() are expected ? Yes/no... The

Re: [PATCH] avoid memory barrier bitops in hot paths

2006-03-06 Thread Benjamin LaHaise
On Tue, Mar 07, 2006 at 12:59:17AM +0100, Eric Dumazet wrote: I'm not even sure this 'optimization' is valid on UP. It can be, as branch prediction makes the test essentially free. The real answer is that it depends on the CPU, how much pressure there is on the write combining buffers and

Re: [PATCH] avoid memory barrier bitops in hot paths

2006-03-06 Thread David S. Miller
From: Benjamin LaHaise [EMAIL PROTECTED] Date: Mon, 6 Mar 2006 15:40:31 -0800 On Mon, Mar 06, 2006 at 08:29:30PM -0300, Arnaldo Carvalho de Melo wrote: - clear_bit(SOCK_ASYNC_NOSPACE, sk-sk_socket-flags); + if (test_bit(SOCK_ASYNC_NOSPACE, sk-sk_socket-flags)) +

Re: [RFC/PATCH 7/13] d80211: remove adm_status

2006-03-06 Thread Jean Tourrilhes
On Mon, Mar 06, 2006 at 03:23:04PM -0800, Jouni Malinen wrote: On Mon, Mar 06, 2006 at 02:25:52PM -0800, Jean Tourrilhes wrote: Jouni Malinen wrote : This is used to implement radio on/off without having to change other parts of the configuration (e.g., set interfaces down). The

Re: [PATCH] avoid memory barrier bitops in hot paths

2006-03-06 Thread David S. Miller
From: Benjamin LaHaise [EMAIL PROTECTED] Date: Mon, 6 Mar 2006 16:09:07 -0800 I'll respin it with the fast_clear_bit() suggestion. Please see my other email first, we may be able to do something even better via test_and_*_bit(). - To unsubscribe from this list: send the line unsubscribe

Re: [PATCH 2.6.17 1/9] tg3: Add 5787 and 5754 basic support

2006-03-06 Thread David S. Miller
From: Michael Chan [EMAIL PROTECTED] Date: Mon, 06 Mar 2006 13:49:54 -0800 Add basic support for 2 new chips 5787 and 5754. Signed-off-by: Michael Chan [EMAIL PROTECTED] Applied. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED]

Re: [PATCH 2.6.17 2/9] tg3: Add 5787 nvram support

2006-03-06 Thread David S. Miller
From: Michael Chan [EMAIL PROTECTED] Date: Mon, 06 Mar 2006 13:50:22 -0800 Support additional nvrams and new nvram format for 5787 and 5754. Signed-off-by: Michael Chan [EMAIL PROTECTED] Applied, but I had to remove trailing whitespace in the patch by hand, as GIT warns about that now, it

Re: spider_net versus sungem_phy

2006-03-06 Thread Benjamin Herrenschmidt
Ok, I found what I was talking about on irc... Andy Fleming wrote a proper PHY layer, initially based on sungem_phy but then evolved into something more versatile including some of the link state machine that is currently still in the MAC driver for sungem. You should probably use that... It's

Re: [PATCH 2.6.17 3/9] tg3: Add new hard_start_xmit

2006-03-06 Thread David S. Miller
From: Michael Chan [EMAIL PROTECTED] Date: Mon, 06 Mar 2006 13:50:51 -0800 Support 5787 hardware TSO using a new flag TG3_FLG2_HW_TSO_2. Since the TSO interface is slightly different and these chips have finally fixed the 4GB DMA problem and do not have the 40-bit DMA problem, a new

Re: [PATCH 2.6.17 4/9] tg3: Add ipv6 checksum support

2006-03-06 Thread David S. Miller
From: Michael Chan [EMAIL PROTECTED] Date: Mon, 06 Mar 2006 13:51:22 -0800 Support ipv6 tx csum on 5787 by setting NETIF_F_HW_CSUM. Signed-off-by: Michael Chan [EMAIL PROTECTED] Applied, thanks. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to

Re: [PATCH 2.6.17 5/9] tg3: Add new one-shot MSI handler

2006-03-06 Thread David S. Miller
From: Michael Chan [EMAIL PROTECTED] Date: Mon, 06 Mar 2006 13:51:54 -0800 Support one-shot MSI on 5787. This one-shot MSI idea is credited to David Miller. In this mode, MSI disables itself automatically after it is generated, saving the driver a register access to disable it for NAPI.

Re: [PATCH 2.6.17 8/9] tg3: Add firmware version info

2006-03-06 Thread David S. Miller
From: Michael Chan [EMAIL PROTECTED] Date: Mon, 06 Mar 2006 13:53:18 -0800 Add fw_version information to ethtool -i. Signed-off-by: Michael Chan [EMAIL PROTECTED] Applied. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More

Re: [PATCH 2.6.17 9/9] tg3: update version and reldate

2006-03-06 Thread David S. Miller
From: Michael Chan [EMAIL PROTECTED] Date: Mon, 06 Mar 2006 13:53:51 -0800 Update version to 3.52. Signed-off-by: Michael Chan [EMAIL PROTECTED] Also applied, thanks a lot Michael. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED]

Re: [PATCH] avoid atomic op on page free

2006-03-06 Thread Andrew Morton
Benjamin LaHaise [EMAIL PROTECTED] wrote: Hello Andrew et al, The patch below adds a fast path that avoids the atomic dec and test operation and spinlock acquire/release on page free. This is especially important to the network stack which uses put_page() to free user buffers.

Re: [PATCH 2.6.17 3/9] tg3: Add new hard_start_xmit

2006-03-06 Thread Michael Chan
On Mon, 2006-03-06 at 16:39 -0800, David S. Miller wrote: Also, you should probably fixup the DMA masks we use if this chip really doesn't have the 40-bit limitation. Or did you take care of that and I missed it somehow? The 40-bit stuff is handled in another patch, probably still in your

Re: [PATCH 2.6.17 3/9] tg3: Add new hard_start_xmit

2006-03-06 Thread David S. Miller
From: Michael Chan [EMAIL PROTECTED] Date: Mon, 06 Mar 2006 15:07:50 -0800 On Mon, 2006-03-06 at 16:39 -0800, David S. Miller wrote: Also, you should probably fixup the DMA masks we use if this chip really doesn't have the 40-bit limitation. Or did you take care of that and I missed it

Re: [PATCH 2.6.17 3/9] tg3: Add new hard_start_xmit

2006-03-06 Thread David S. Miller
From: David S. Miller [EMAIL PROTECTED] Date: Mon, 06 Mar 2006 16:52:41 -0800 (PST) I did put that patch in already. Actually, no I didn't, it's still in my queue sorry. I'll try to get to it tonight, it belongs in 2.6.16 for sure. - To unsubscribe from this list: send the line unsubscribe

Re: [PATCH] avoid memory barrier bitops in hot paths

2006-03-06 Thread Benjamin LaHaise
On Mon, Mar 06, 2006 at 04:25:32PM -0800, David S. Miller wrote: Wait... what about test_and_clear_bit()? Most implementations should be doing the light-weight test _first_, and only do the update if the bit isn't in the state desired. I think in such cases we can elide the memory

Re: [PATCH 2.6.17 3/9] tg3: Add new hard_start_xmit

2006-03-06 Thread Michael Chan
On Mon, 2006-03-06 at 16:52 -0800, David S. Miller wrote: Ok, so the 40-bit capable chips won't hit the 5780 class code path? The mask will be set to 40-bit for 5780 class only. In tg3_start_xmit_dma_bug(), there is a 40-bit DMA address check for 5780 class only and will return 0 for all

[PATCH 4/6 v2] IB: address translation to map IP toIB addresses (GIDs)

2006-03-06 Thread Sean Hefty
Add an address translation service that maps IP addresses to Infiniband GID addresses using IPoIB. Signed-off-by: Sean Hefty [EMAIL PROTECTED] --- This should be the correct patch. The only difference between this and the mis-post is the use of mutex_lock/unlock in place of up/down. diff

[PATCH 5/6 v2] IB: IP address based RDMA connection manager

2006-03-06 Thread Sean Hefty
Kernel mode connection management agent over Infiniband that connects based on IP addresses. The agent defines a generic RDMA connection abstraction to support clients wanting to connect over different RDMA devices. Agent also handles RDMA device hotplug events on behalf of clients.

[PATCH 6/6 v2] IB: userspace support for RDMA connection manager

2006-03-06 Thread Sean Hefty
Kernel component necessary to support the userspace RDMA connection management library. Signed-off-by: Sean Hefty [EMAIL PROTECTED] --- Discussion on the list suggested giving the userspace interface more time to develop, which seems reasonable. diff -uprN -X

Re: [openib-general] Re: [PATCH 6/6] IB: userspace support for RDMA connection manager

2006-03-06 Thread Roland Dreier
Roland I should look into getting some niagara machines to test Roland with -- with PCIe slots they should actually be good for Roland IB testing. David You'll be cpu limited until we have Van Jacobson net David channels. For IPoIB maybe but not for native IB which offloads

Re: [openib-general] Re: [PATCH 6/6] IB: userspace support for RDMA connection manager

2006-03-06 Thread Bryan O'Sullivan
On Mon, 2006-03-06 at 15:40 -0800, Roland Dreier wrote: Anyway IB works fine with standard INTx interrupts -- MSI is just icing. Depends on the driver. Ours needs the interrupt vector rather than the number, which means we don't work without CONFIG_PCI_MSI. That is, unless there's some other

  1   2   >