Re: [Bugme-new] [Bug 6177] New: Java remote debugging is slow due to apparent networking bug

2006-03-08 Thread David S. Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Wed, 08 Mar 2006 23:24:22 -0800 > I have gotten massive strace's and the java VM is: > 1) Turning on TCP_NODELAY > 2) Sending small packets. Java is doing the wrong thing, obviously. > 4) Fix java And this is the only reasonable recourse

Re: [Bugme-new] [Bug 6177] New: Java remote debugging is slow due to apparent networking bug

2006-03-08 Thread Stephen Hemminger
I am not sure if it is the same problem, but I am now able to reproduce slowness if I use eclipse and debug something. It is annoying, but not fatal. If I turn off TCP appropriate byte count: sudo sysctl -w net.ipv4.tcp_abc=0 then the problem goes away. See RFC 3465 http://www.apps.ietf.o

Re: [PATCH 1/3] bridge-netfilter: whitespace fix

2006-03-08 Thread David S. Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Mon, 6 Feb 2006 14:39:18 -0800 > This applies after the RCU fix patches; it can be held until 2.6.17. > Run br_netfilter through Lindent to fix whitespace. > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> This patch set doesn't apply clea

Re: [GIT PATCH] TIPC updates

2006-03-08 Thread David S. Miller
From: Per Liden <[EMAIL PROTECTED]> Date: Wed, 8 Mar 2006 17:05:08 +0100 (CET) > On Wed, 8 Mar 2006, David S. Miller wrote: > > > From: Per Liden <[EMAIL PROTECTED]> > > Date: Wed, 8 Mar 2006 11:18:15 +0100 (CET) > > > > > Here is a set of patches for net-2.6.17. > > > > > > Please pull from: >

potential leak in tun_get_user

2006-03-08 Thread Dave Jones
We're leaking an skb in a failure path in this function. Coverity #632 Signed-off-by: Dave Jones <[EMAIL PROTECTED]> --- linux-2.6/drivers/net/tun.c~2006-03-08 22:43:54.0 -0500 +++ linux-2.6/drivers/net/tun.c 2006-03-08 22:46:16.0 -0500 @@ -249,8 +249,11 @@ static __inline

Re: [PATCH 14/16] ipw2200: wireless extension sensitivity threshold support

2006-03-08 Thread Zhu Yi
On Wed, 2006-03-08 at 13:23 +0100, Jiri Benc wrote: > On Wed, 8 Mar 2006 13:34:10 +0800, Zhu Yi wrote: > > +3.2 iwconfig sens > > +--- > > + > > +The 'iwconfig ethX sens XX' command will not set the signal sensitivity > > +threshold, as described in iwcon

[PATCH netdev-2.6 ] e100: Fix eeh on pseries during ethtool -t

2006-03-08 Thread Jeff Kirsher
This patch was diff'd against the latest 'upstream' branch from Garzik's tree. This patch can be pulled from the following location: git://198.78.49.142/linux-2.6.git e100-upstream Jeff - should a patch be made for 2.6.16 also? Olaf Hering reported a problem on pseries with e100 where ethtool

Re: [Patch 1/1] updated: TCP/UDP getpeersec

2006-03-08 Thread Xiaolan Zhang
Hi, James, I am working on a separate patch for Unix datagram, instead of mixing the two into one patch. thanks, Catherine James Morris <[EMAIL PROTECTED]> wrote on 03/08/2006 09:56:33 PM: > On Wed, 8 Mar 2006, David S. Miller wrote: > > > I thought James still had some objections? > > James?

Re: [Patch 1/1] updated: TCP/UDP getpeersec

2006-03-08 Thread James Morris
On Wed, 8 Mar 2006, David S. Miller wrote: > I thought James still had some objections? > James? Is this the patch from a few weeks back? If so, it needs updating to support Unix datagram. - James -- James Morris <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscri

Re: [patch 1/4] net: percpufy frequently used vars -- add percpu_counter_mod_bh

2006-03-08 Thread Andrew Morton
Andi Kleen <[EMAIL PROTECTED]> wrote: > > Andrew Morton <[EMAIL PROTECTED]> writes: > > > > x86_64 is signed 32-bit! > > I'll change it. You want signed 64bit? > Well it's all random at present. Since the API is defined as unsigned I guess it's be best to make it unsigned for now. Later, when

Re: [patch 1/4] net: percpufy frequently used vars -- add percpu_counter_mod_bh

2006-03-08 Thread Andi Kleen
Andrew Morton <[EMAIL PROTECTED]> writes: > > x86_64 is signed 32-bit! I'll change it. You want signed 64bit? -Andi - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] compat. ifconf: fix limits

2006-03-08 Thread David S. Miller
From: "Randy.Dunlap" <[EMAIL PROTECTED]> Date: Wed, 8 Mar 2006 17:41:16 -0800 > On Wed, 08 Mar 2006 16:46:27 -0800 (PST) David S. Miller wrote: > > > Is this one relevant for -stable? > > Yes, IMO. Have to wait for it to be merged upstream, right? I'll take care of everything, thanks Randy. -

Re: [PATCH] compat. ifconf: fix limits

2006-03-08 Thread Randy.Dunlap
On Wed, 08 Mar 2006 16:46:27 -0800 (PST) David S. Miller wrote: > From: "Randy.Dunlap" <[EMAIL PROTECTED]> > Date: Wed, 8 Mar 2006 09:16:08 -0800 > > > From: Randy Dunlap <[EMAIL PROTECTED]> > > > > A recent change to compat. dev_ifconf() in fs/compat_ioctl.c > > causes ifconf data to be truncat

[PATCH netdev-2.6] e1000: driver update

2006-03-08 Thread Jeff Kirsher
The series only contains one patch. Sorry for the cover email, I was trying to edit the patch email and did not intend to create cover email. The one patch in this series is a fix for mii-tool. This patch was created using Jeff Garzik's latest 'upstream' branch. Jeff, This patch is d

[PATCH netdev-2.6 ] e1000: Fix mii-tool access to setting speed and duplex

2006-03-08 Thread Jeff Kirsher
Paul Rolland reported that e1000 was having a hard time using mii-tool to set speed and duplex. This patch fixes the issue on both newer hardware as well as fixing the code issue that originally caused the problem. Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by: Jeff Kirsher

Re: [PATCH] compat. ifconf: fix limits

2006-03-08 Thread David S. Miller
From: "Randy.Dunlap" <[EMAIL PROTECTED]> Date: Wed, 8 Mar 2006 09:16:08 -0800 > From: Randy Dunlap <[EMAIL PROTECTED]> > > A recent change to compat. dev_ifconf() in fs/compat_ioctl.c > causes ifconf data to be truncated 1 entry too early when copying it > to userspace. The correct amount of dat

Re: [Patch 1/1] updated: TCP/UDP getpeersec

2006-03-08 Thread David S. Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Thu, 09 Mar 2006 11:33:19 +1100 > Catherine Zhang <[EMAIL PROTECTED]> wrote: > > > > From: [EMAIL PROTECTED] > > > > This patch implements an application of the LSM-IPSec networking > > controls whereby an application can determine the label of the > >

Re: [patch 1/4] net: percpufy frequently used vars -- add percpu_counter_mod_bh

2006-03-08 Thread Andrew Morton
Ravikiran G Thirumalai <[EMAIL PROTECTED]> wrote: > > On Wed, Mar 08, 2006 at 03:43:21PM -0800, Andrew Morton wrote: > > Benjamin LaHaise <[EMAIL PROTECTED]> wrote: > > > > > > I think it may make more sense to simply convert local_t into a long, > > > given > > > that most of the users will be t

Re: [Patch 1/1] updated: TCP/UDP getpeersec

2006-03-08 Thread Herbert Xu
Catherine Zhang <[EMAIL PROTECTED]> wrote: > > From: [EMAIL PROTECTED] > > This patch implements an application of the LSM-IPSec networking > controls whereby an application can determine the label of the > security association its TCP or UDP sockets are currently connected to > via getsockopt an

Re: [Bugme-new] [Bug 6177] New: Java remote debugging is slow due to apparent networking bug

2006-03-08 Thread Stephen Hemminger
To chase this regression down, we need: 1) a strace (system call trace) of what the JVM is doing during the transfer. Is it writing lots of little buffers? 2) How to setup the same environment (for non-java savvy people) with freely available software (Sun JDK okay). I can figure out how to get J

Re: [PATCH 1/2] pcnet32: Introduce basic AT 2700/01 FTX support

2006-03-08 Thread Don Fry
On Mon, Feb 27, 2006 at 11:45:51AM +0100, Seewer Philippe wrote: > OK, found it. > > The code in pcnet32_open assigns XCVR_INTERNAL to ecmd.port instead of > ecmd.transceiver, making mii_ethtool_sset fail and leaving all phys > configured to defaults. > > On the Allied Telesyn FTX cards this me

Re: [patch 1/4] net: percpufy frequently used vars -- add percpu_counter_mod_bh

2006-03-08 Thread Ravikiran G Thirumalai
On Wed, Mar 08, 2006 at 03:43:21PM -0800, Andrew Morton wrote: > Benjamin LaHaise <[EMAIL PROTECTED]> wrote: > > > > I think it may make more sense to simply convert local_t into a long, given > > that most of the users will be things like stats counters. > > > > Yes, I agree that making local_t

Re: [patch 1/4] net: percpufy frequently used vars -- add percpu_counter_mod_bh

2006-03-08 Thread Andrew Morton
Benjamin LaHaise <[EMAIL PROTECTED]> wrote: > > On Wed, Mar 08, 2006 at 02:25:28PM -0800, Ravikiran G Thirumalai wrote: > > Then, for the batched percpu_counters, we could gain by using local_t only > > for > > the UP case. But we will have to have a new local_long_t implementation > > for that.

Re: [PATCH 7/9] sky2: smarter irq handling

2006-03-08 Thread Stephen Hemminger
On Thu, 9 Mar 2006 00:06:33 +0100 Francois Romieu <[EMAIL PROTECTED]> wrote: > Stephen Hemminger <[EMAIL PROTECTED]> : > > Please take the three patches yesterday for 2.6.16, > > The others can wait. > > So instead of #1..#6 from 07/03/2006, #1..#3 from 08/03/2003 > which actually cover (with min

Re: [patch 1/4] net: percpufy frequently used vars -- add percpu_counter_mod_bh

2006-03-08 Thread Andrew Morton
Andrew Morton <[EMAIL PROTECTED]> wrote: > > Once decrapify-asm-generic-localh.patch is merged I think all architectures > can and should use asm-generic/local.h. err, no. Because that's just atomic_long_t, and that's a locked instruction. We need to review and fix up those architectures which

Re: [PATCH 7/9] sky2: smarter irq handling

2006-03-08 Thread Francois Romieu
Stephen Hemminger <[EMAIL PROTECTED]> : > Please take the three patches yesterday for 2.6.16, > The others can wait. So instead of #1..#6 from 07/03/2006, #1..#3 from 08/03/2003 which actually cover (with minor differences) #4..#6 from 07/03/2006 should be pushed ? -- Ueimor -- going to bed - T

Re: [patch 1/4] net: percpufy frequently used vars -- add percpu_counter_mod_bh

2006-03-08 Thread Andrew Morton
Ravikiran G Thirumalai <[EMAIL PROTECTED]> wrote: > > On Wed, Mar 08, 2006 at 04:17:33PM -0500, Benjamin LaHaise wrote: > > On Wed, Mar 08, 2006 at 01:07:26PM -0800, Ravikiran G Thirumalai wrote: > > > > Last time I checked, all the major architectures had efficient local_t > > implementations.

Re: [patch 1/4] net: percpufy frequently used vars -- add percpu_counter_mod_bh

2006-03-08 Thread Benjamin LaHaise
On Wed, Mar 08, 2006 at 02:25:28PM -0800, Ravikiran G Thirumalai wrote: > Then, for the batched percpu_counters, we could gain by using local_t only > for > the UP case. But we will have to have a new local_long_t implementation > for that. Do you think just one use case of local_long_t warrant

Re: [PATCH 7/9] sky2: smarter irq handling

2006-03-08 Thread Stephen Hemminger
Please take the three patches yesterday for 2.6.16, The others can wait. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH, RESEND] Add MWI workaround for Tulip DC21143

2006-03-08 Thread Francois Romieu
Geert Uytterhoeven <[EMAIL PROTECTED]> : > On Tue, 7 Mar 2006, Ralf Baechle wrote: [...] > > I'm just not convinced of having such a workaround as a build option. > > The average person building a a kernel will probably not know if the > > option needs to be enabled or not. > > Indeed, if it's men

Re: [PATCH 7/9] sky2: smarter irq handling

2006-03-08 Thread Francois Romieu
Stephen Hemminger <[EMAIL PROTECTED]> : [...] > Then stop at #6. #1..#6 applied to branch 'for-jeff' at git://electric-eye.fr.zoreil.com/home/romieu/linux-2.6.git Shortlog Francois Romieu: de2104x: prevent interrupt before the interrupt handler is registered de2104x: fix th

Re: [patch 1/4] net: percpufy frequently used vars -- add percpu_counter_mod_bh

2006-03-08 Thread Ravikiran G Thirumalai
On Wed, Mar 08, 2006 at 04:17:33PM -0500, Benjamin LaHaise wrote: > On Wed, Mar 08, 2006 at 01:07:26PM -0800, Ravikiran G Thirumalai wrote: > > Last time I checked, all the major architectures had efficient local_t > implementations. Most of the RISC CPUs are able to do a load / store > conditi

Re: [Lse-tech] Re: [Patch 7/7] Generic netlink interface (delay accounting)

2006-03-08 Thread Shailabh Nagar
jamal wrote: On Mon, 2006-06-03 at 12:00 -0500, Shailabh Nagar wrote: My design was to have the listener get both responses (what I call replies in the code) as well as events (data sent on exit of pid) I think i may not be doing justice explaining this, so let me be more elaborate

Re: [patch 1/4] net: percpufy frequently used vars -- add percpu_counter_mod_bh

2006-03-08 Thread Benjamin LaHaise
On Wed, Mar 08, 2006 at 01:07:26PM -0800, Ravikiran G Thirumalai wrote: > But on non x86, local_bh_disable() is gonna be cheaper than a cli/atomic op > no? > (Even if they were switched over to do local_irq_save() and > local_irq_restore() from atomic_t's that is). It's still more expensive than

Re: [patch 02/12] 8139cp: register interrupt handler when net device is registered

2006-03-08 Thread Francois Romieu
Pierre Ossman <[EMAIL PROTECTED]> : [...] > This was fixed properly by Francois Romieu, so please merge those instead: > > http://bugzilla.kernel.org/show_bug.cgi?id=5681 The patch has already been merged in mainline. -- Ueimor - To unsubscribe from this list: send the line "unsubscribe netdev"

Re: [patch 1/4] net: percpufy frequently used vars -- add percpu_counter_mod_bh

2006-03-08 Thread Ravikiran G Thirumalai
On Wed, Mar 08, 2006 at 03:36:42PM -0500, Benjamin LaHaise wrote: > On Wed, Mar 08, 2006 at 12:26:56PM -0800, Ravikiran G Thirumalai wrote: > > +static inline void percpu_counter_mod_bh(struct percpu_counter *fbc, long > > amount) > > +{ > > + local_bh_disable(); > > + fbc->count += amount; >

Re: [patch 2/4] net: percpufy frequently used vars -- struct proto.memory_allocated

2006-03-08 Thread Ravikiran G Thirumalai
On Tue, Mar 07, 2006 at 07:22:34PM -0800, Andrew Morton wrote: > Ravikiran G Thirumalai <[EMAIL PROTECTED]> wrote: > > > > The problem is percpu_counter_sum has to read all the cpus cachelines. If > > we have to use percpu_counter_sum everywhere, then might as well use plain > > per-cpu counters

Re: [patch 3/4] net: percpufy frequently used vars -- proto.sockets_allocated

2006-03-08 Thread Ravikiran G Thirumalai
On Tue, Mar 07, 2006 at 06:16:02PM -0800, Andrew Morton wrote: > Ravikiran G Thirumalai <[EMAIL PROTECTED]> wrote: > > > > +static inline int read_sockets_allocated(struct proto *prot) > > +{ > > + int total = 0; > > + int cpu; > > + for_each_cpu(cpu) > > + total += *per_cpu_pt

Re: TSO and IPoIB performance degradation

2006-03-08 Thread David S. Miller
From: "Michael S. Tsirkin" <[EMAIL PROTECTED]> Date: Wed, 8 Mar 2006 14:53:11 +0200 > What I was trying to figure out was, how can we re-enable the trick without > hurting TSO? Could a solution be to simply look at the frame size, and call > tcp_send_delayed_ack if the frame size is small? The pr

Re: [patch 1/4] net: percpufy frequently used vars -- add percpu_counter_mod_bh

2006-03-08 Thread Benjamin LaHaise
On Wed, Mar 08, 2006 at 12:26:56PM -0800, Ravikiran G Thirumalai wrote: > +static inline void percpu_counter_mod_bh(struct percpu_counter *fbc, long > amount) > +{ > + local_bh_disable(); > + fbc->count += amount; > + local_bh_enable(); > +} Please use local_t instead, then you don't

Re: [patch 1/4] net: percpufy frequently used vars -- add percpu_counter_mod_bh

2006-03-08 Thread Ravikiran G Thirumalai
On Tue, Mar 07, 2006 at 06:13:01PM -0800, Andrew Morton wrote: > Ravikiran G Thirumalai <[EMAIL PROTECTED]> wrote: > > > > +static inline void percpu_counter_mod_bh(struct percpu_counter *fbc, long > > amount) > > +{ > > + local_bh_disable(); > > + percpu_counter_mod(fbc, amount); > > + loc

Re: [RFC/PATCH 7/13] d80211: remove adm_status

2006-03-08 Thread Jean Tourrilhes
On Tue, Mar 07, 2006 at 07:11:27PM -0800, Simon Barber wrote: > Overloading configuration parameters with extra meanings like this makes > it harder to configure the system - I think it's useful to keep an > on/off function separate from the power setting. > > Simon The main issue I have

Re: [RFC/PATCH] rcuification of ipv4 established and timewait connections

2006-03-08 Thread Benjamin LaHaise
On Wed, Mar 08, 2006 at 02:01:04PM +0300, Evgeniy Polyakov wrote: > When I tested RCU for similar change for kevent, but postponed more work > to RCU callback, including socket closing and some attempts to inode > dereferencing, such change forced performance degradation for httperf > benchmark and

Re: [PATCH 2/6] ipw2100: add radiotap headers to packtes captured in monitor mode

2006-03-08 Thread James Ketrenos
Christoph Hellwig wrote: >> #include >> >>+#ifdef CONFIG_IPW2100_MONITOR >>+#include >>+#endif >> >> > >please include the header unconditionally. > > As it is only conditionally used, what is the reasoning for including what isn't needed? I'm not opposed to removing the conditional, bu

Re: [PATCH] x86-64, use page->virtual to get 64 byte struct page

2006-03-08 Thread Eric Dumazet
Benjamin LaHaise a écrit : Besides, we're reducing the cache footprint for many users by only using 1 cacheline per struct page instead of the 2 for every 7 out of 8 struct pages currently. How many places in the kernel really do a linear walk of the struct page array? Aside from early boot

Re: [PATCH 6/6] ipw2100: Update version ipw2100 stamp to 1.2.2

2006-03-08 Thread James Ketrenos
Christoph Hellwig wrote: >On Wed, Mar 08, 2006 at 10:01:01AM -0600, James Ketrenos wrote: > > >>>git-foo is a pretty stupid version number, please kill the git- prefix. >>> >>> >>Perhaps for you... >> >>For us this prefix has been very useful in isolating problems reported >>by users. >>

[PATCH][RFC] Notifier mechanism to notify RDMA devices of network events

2006-03-08 Thread Tom Tucker
This patch implements a mechanism that allows interested clients to register for notification of certain network events. The intended use is to allow RDMA(OpenIB) devices to be notified of neighbour updates, ICMP redirects, path MTU changes, and route changes. The reason these devices need upd

Re: [PATCH] x86-64, use page->virtual to get 64 byte struct page

2006-03-08 Thread Andi Kleen
On Wednesday 08 March 2006 17:07, Benjamin LaHaise wrote: > You haven't come up with any data to support your position, You're proposing to waste 0.1% of the memory of the system with a quite dubious optimization. Unless you're showing real gains on some macro benchmark I won't accept that chan

Re: [PATCH] x86-64, use page->virtual to get 64 byte struct page

2006-03-08 Thread Benjamin LaHaise
On Wed, Mar 08, 2006 at 10:40:38AM +0100, Andi Kleen wrote: > On Wednesday 08 March 2006 03:38, Benjamin LaHaise wrote: > > > It's hardly that uncommon for pages to cross cachelines or for pages to > > move around CPUs with networking. > > Data? I posted a workload that shows this. Anything t

Re: [PATCH 15/16] ipw2200: switch to the new ipw2200-fw-3.0 image format

2006-03-08 Thread James Ketrenos
Christoph Hellwig wrote: >On Wed, Mar 08, 2006 at 01:34:31PM +0800, Zhu Yi wrote: > > >>From: James Ketrenos <[EMAIL PROTECTED]> >>Date: Wed, 8 Mar 2006 03:22:28 + (+0800) >> >>[PATCH 15/16] ipw2200: switch to the new ipw2200-fw-3.0 image format >> >>This patch modifies the driver to support

Re: [GIT PATCH] TIPC updates

2006-03-08 Thread Per Liden
On Wed, 8 Mar 2006, David S. Miller wrote: > From: Per Liden <[EMAIL PROTECTED]> > Date: Wed, 8 Mar 2006 11:18:15 +0100 (CET) > > > Here is a set of patches for net-2.6.17. > > > > Please pull from: > > > > git://tipc.cslab.ericsson.net/pub/git/tipc.git > > Looks good, but I can't pull it

Re: [PATCH 6/6] ipw2100: Update version ipw2100 stamp to 1.2.2

2006-03-08 Thread Christoph Hellwig
On Wed, Mar 08, 2006 at 10:01:01AM -0600, James Ketrenos wrote: > >git-foo is a pretty stupid version number, please kill the git- prefix. > > > > > Perhaps for you... > > For us this prefix has been very useful in isolating problems reported > by users. > > The 'git' prefix means "this was ba

Re: [PATCH 6/6] ipw2100: Update version ipw2100 stamp to 1.2.2

2006-03-08 Thread James Ketrenos
Christoph Hellwig wrote: >On Wed, Mar 08, 2006 at 12:26:48PM +0800, Zhu Yi wrote: > > >>-#define IPW2100_VERSION "git-1.1.4" >>+#define IPW2100_VERSION "git-1.2.2" >> >> > >git-foo is a pretty stupid version number, please kill the git- prefix. > > Perhaps for you... For us this prefix h

Re: [PATCH 15/16] ipw2200: switch to the new ipw2200-fw-3.0 image format

2006-03-08 Thread Christoph Hellwig
On Wed, Mar 08, 2006 at 01:34:31PM +0800, Zhu Yi wrote: > > From: James Ketrenos <[EMAIL PROTECTED]> > Date: Wed, 8 Mar 2006 03:22:28 + (+0800) > > [PATCH 15/16] ipw2200: switch to the new ipw2200-fw-3.0 image format > > This patch modifies the driver to support the ipw2200-fw-3.0 image form

Re: [PATCH 6/6] ipw2100: Update version ipw2100 stamp to 1.2.2

2006-03-08 Thread Christoph Hellwig
On Wed, Mar 08, 2006 at 12:26:48PM +0800, Zhu Yi wrote: > > From: Zhu Yi <[EMAIL PROTECTED]> > Date: Tue, 21 Feb 2006 18:46:15 + (+0800) > > [PATCH 6/6] ipw2100: Update version ipw2100 stamp to 1.2.2 > --- > > --- a/drivers/net/wireless/ipw2100.c > +++ b/drivers/net/wireless/ipw2100.c > @@ -

Re: [PATCH 4/6] ipw2100: semaphore to mutexes conversion

2006-03-08 Thread Christoph Hellwig
On Wed, Mar 08, 2006 at 12:25:13PM +0800, Zhu Yi wrote: > > From: Ingo Molnar <[EMAIL PROTECTED]> > Date: Tue, 28 Feb 2006 07:20:54 + (+0800) > > [PATCH 4/6] ipw2100: semaphore to mutexes conversion > > semaphore to mutexes conversion. > > the conversion was generated via scripts, and the r

Re: [PATCH 2/6] ipw2100: add radiotap headers to packtes captured in monitor mode

2006-03-08 Thread Christoph Hellwig
> + if (unlikely(status->frame_size > skb_tailroom(packet->skb) - > sizeof(struct ipw_rt_hdr))) { please don't spill over 80 characters. > #include > > +#ifdef CONFIG_IPW2100_MONITOR > +#include > +#endif please include the header unconditionally. > + > #include and for a followon

Re: Re: TSO and IPoIB performance degradation

2006-03-08 Thread Michael S. Tsirkin
Quoting r. David S. Miller <[EMAIL PROTECTED]>: > Subject: Re: Re: TSO and IPoIB performance degradation > > From: Roland Dreier <[EMAIL PROTECTED]> > Date: Tue, 07 Mar 2006 17:17:30 -0800 > > > The reason TSO comes up is that reverting the patch described below > > helps (or helped at some point

Re: [PATCH 6/6] ipw2100: Update version ipw2100 stamp to 1.2.2

2006-03-08 Thread Jiri Benc
On Wed, 8 Mar 2006 12:26:48 +0800, Zhu Yi wrote: > --- a/drivers/net/wireless/ipw2100.c > +++ b/drivers/net/wireless/ipw2100.c > [...] > -#define IPW2100_VERSION "git-1.1.4" > +#define IPW2100_VERSION "git-1.2.2" >From [PATCH 1/6] ipw2x00: expend Copyright to 2006: > --- a/Documentation/networkin

Re: [patch 08/18] happymeal: add pci probing

2006-03-08 Thread Jiri Slaby
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 [EMAIL PROTECTED] napsal(a): > From: "Jiri Slaby" <[EMAIL PROTECTED]> > > Pci probing functions added, some functions were rewritten. Use PCI_DEVICE > macro. > > Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]> > Signed-off-by: Andrew Morton <[EMAIL PR

Re: [PATCH 14/16] ipw2200: wireless extension sensitivity threshold support

2006-03-08 Thread Jiri Benc
On Wed, 8 Mar 2006 13:34:10 +0800, Zhu Yi wrote: > +3.2 iwconfig sens > +--- > + > +The 'iwconfig ethX sens XX' command will not set the signal sensitivity > +threshold, as described in iwconfig documentation, but rather the number > +of consecutive misse

[2.6 patch] drivers/net/wireless/ipw2200.c: make ipw_qos_current_mode() static

2006-03-08 Thread Adrian Bunk
This patch makes the needlessly global function ipw_qos_current_mode() static. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- This patch was already sent on: - 4 Mar 2006 --- linux-2.6.16-rc5-mm2-full/drivers/net/wireless/ipw2200.c.old 2006-03-03 17:49:37.0 +0100 +++ linux

Re: [RFC/PATCH] rcuification of ipv4 established and timewait connections

2006-03-08 Thread Evgeniy Polyakov
On Tue, Mar 07, 2006 at 03:03:13PM -0800, David S. Miller ([EMAIL PROTECTED]) wrote: > From: Evgeniy Polyakov <[EMAIL PROTECTED]> > Date: Wed, 8 Mar 2006 00:51:33 +0300 > > > RCU introduces noticeble latencies for writing part compared to > > rwlock, so workloads when a lot of new short connectio

Re: [PATCH] x86-64, use page->virtual to get 64 byte struct page

2006-03-08 Thread Eric Dumazet
Andi Kleen a écrit : Can you send tested patches with proper descriptions and signed off lines please? -Andi You are welcome Andi :) [PATCH] x86_64 : group memnodemap and memnodeshift in a memnode structure pfn_to_page() and others need to access both memnode_shift and the very first

Re: [GIT PATCH] TIPC updates

2006-03-08 Thread David S. Miller
From: Per Liden <[EMAIL PROTECTED]> Date: Wed, 8 Mar 2006 11:18:15 +0100 (CET) > Here is a set of patches for net-2.6.17. > > Please pull from: > > git://tipc.cslab.ericsson.net/pub/git/tipc.git Looks good, but I can't pull it cleanly. Please fix this up, thanks. [EMAIL PROTECTED]:~/src

[GIT PATCH] TIPC updates

2006-03-08 Thread Per Liden
Hi Dave, Here is a set of patches for net-2.6.17. Please pull from: git://tipc.cslab.ericsson.net/pub/git/tipc.git Thanks /Per net/tipc/bcast.c | 58 +++ net/tipc/bearer.c | 20 +-- net/tipc/cluster.c | 20 +-- net/tipc/

Re: [PATCH] x86-64, use page->virtual to get 64 byte struct page

2006-03-08 Thread Andi Kleen
On Wednesday 08 March 2006 10:09, Eric Dumazet wrote: > I suggest the following change (seems better than playing vmlinux.lds > games) > > include/asm-x86_64/mmzone.h > struct memnode { > int shift; > u8 map[NODEMAPSIZE]; > } cacheline_aligned; > extern struct memnode memnode; > #def

Re: [PATCH] x86-64, use page->virtual to get 64 byte struct page

2006-03-08 Thread Andi Kleen
On Wednesday 08 March 2006 03:38, Benjamin LaHaise wrote: > It's hardly that uncommon for pages to cross cachelines or for pages to > move around CPUs with networking. Data? > Please name some sort of benchmarks that show your concerns for decreased > performance. Anything that manipulates l

Re: [patch 02/12] 8139cp: register interrupt handler when net device is registered

2006-03-08 Thread Pierre Ossman
[EMAIL PROTECTED] wrote: > From: Pierre Ossman <[EMAIL PROTECTED]> > > Avoids missing interrupts if the interrupt mask gets out of sync. > > The reason this patch is needed for me is that the resume function is > broken. It enables interrupts unconditionally, but the interrupt handler > is only

Re: [PATCH] x86-64, use page->virtual to get 64 byte struct page

2006-03-08 Thread Eric Dumazet
Eric Dumazet a écrit : 8011db70 : /* pfn_to_page total: 487244 0.8036 */ 18501 0.0305 :8011db70: mov2965994(%rip),%ecx # 83312 0.1374 :8011db76: mov%rdi,%rax 2 3.3e-06 :8011db79: push %rbp :801

[patch 11/18] dev_put/dev_hold cleanup

2006-03-08 Thread akpm
From: Stephen Hemminger <[EMAIL PROTECTED]> Get rid of the old __dev_put macro that is just a hold over from pre 2.6 kernel. And turn dev_hold into an inline instead of a macro. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/n

[patch 17/18] x25: dte facilities 32 64 ioctl conversion

2006-03-08 Thread akpm
From: Shaun Pereira <[EMAIL PROTECTED]> Allows dte facility patch to use 32 64 bit ioctl conversion mechanism Signed-off-by: Shaun Pereira <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- net/x25/af_x25.c |2 ++ 1 files changed, 2 insertions(+) diff -puN net/x25/af

[patch 07/18] sem2mutex: net/, #2

2006-03-08 Thread akpm
From: Ingo Molnar <[EMAIL PROTECTED]> Semaphore to mutex conversion. The conversion was generated via scripts, and the result was validated automatically via a script as well. (akpm: something went wrong with this patch. Might need redoing) Signed-off-by: Ingo Molnar <[EMAIL PROTECTED]> Cc: "

[patch 16/18] x25: allow ITU-T DTE facilities for x25

2006-03-08 Thread akpm
From: Shaun Pereira <[EMAIL PROTECTED]> Allows use of the optional user facility to insert ITU-T (http://www.itu.int/ITU-T/) specified DTE facilities in call set-up x25 packets. This feature is optional; no facilities will be added if the ioctl is not used, and call setup packet remains the same

[patch 14/18] x25: ioctl conversion 32 bit user to 64 bit kernel

2006-03-08 Thread akpm
From: Shaun Pereira <[EMAIL PROTECTED]> To allow 32 bit x25 module structures to be passed to a 64 bit kernel via ioctl using the new compat_sock_ioctl registration mechanism instead of the obsolete 'register_ioctl32_conversion into hash table' mechanism Signed-off-by: Shaun Pereira <[EMAIL PROT

[patch 12/18] net: allow 32 bit socket ioctl in 64 bit kernel

2006-03-08 Thread akpm
From: Shaun Pereira <[EMAIL PROTECTED]> Since the register_ioctl32_conversion() patch in the kernel is now obsolete, provide another method to allow 32 bit user space ioctls to reach the kernel. Signed-off-by: Shaun Pereira <[EMAIL PROTECTED]> Acked-by: Arnd Bergmann <[EMAIL PROTECTED]> Signed-o

[patch 09/18] suni: cast arg properly in SONET_SETFRAMING

2006-03-08 Thread akpm
From: Alexey Dobriyan <[EMAIL PROTECTED]> Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/atm/suni.c |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) diff -puN drivers/atm/suni.c~suni-cast-arg-properly-in-sonet_setframing

[patch 08/18] happymeal: add pci probing

2006-03-08 Thread akpm
From: "Jiri Slaby" <[EMAIL PROTECTED]> Pci probing functions added, some functions were rewritten. Use PCI_DEVICE macro. Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/net/sunhme.c | 79 - 1

[patch 03/18] sem2mutex: net/

2006-03-08 Thread akpm
From: Arjan van de Ven <[EMAIL PROTECTED]> Semaphore to mutex conversion. The conversion was generated via scripts, and the result was validated automatically via a script as well. Signed-off-by: Arjan van de Ven <[EMAIL PROTECTED]> Signed-off-by: Ingo Molnar <[EMAIL PROTECTED]> Cc: "David S. M

[patch 05/18] sem2mutex: zoran

2006-03-08 Thread akpm
From: Ingo Molnar <[EMAIL PROTECTED]> Semaphore to mutexes conversion. The conversion was generated via scripts, and the result was validated automatically via a script as well. Signed-off-by: Ingo Molnar <[EMAIL PROTECTED]> Cc: Ronald Bultje <[EMAIL PROTECTED]> Cc: "David S. Miller" <[EMAIL PR

[patch 13/18] net: socket timestamp 32 bit handler for 64 bit kernel

2006-03-08 Thread akpm
From: Shaun Pereira <[EMAIL PROTECTED]> Get socket timestamp handler function that does not use the ioctl32_hash_table. Signed-off-by: Shaun Pereira <[EMAIL PROTECTED]> Acked-by: Arnd Bergmann <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- include/net/compat.h |5

[patch 04/18] sem2mutex: sungem

2006-03-08 Thread akpm
From: Ingo Molnar <[EMAIL PROTECTED]> Semaphore to mutexes conversion. The conversion was generated via scripts, and the result was validated automatically via a script as well. Signed-off-by: Ingo Molnar <[EMAIL PROTECTED]> Cc: Ronald Bultje <[EMAIL PROTECTED]> Cc: "David S. Miller" <[EMAIL PR

[patch 06/18] sem2mutex: cassini

2006-03-08 Thread akpm
From: Ingo Molnar <[EMAIL PROTECTED]> Semaphore to mutexes conversion. The conversion was generated via scripts, and the result was validated automatically via a script as well. Signed-off-by: Ingo Molnar <[EMAIL PROTECTED]> Cc: Ronald Bultje <[EMAIL PROTECTED]> Cc: "David S. Miller" <[EMAIL PR

[patch 15/18] x25: fix kernel error message 64 bit kernel

2006-03-08 Thread akpm
From: Shaun Pereira <[EMAIL PROTECTED]> Fixes the following error from kernel T2 kernel: schedule_timeout: wrong timeout value from 88164796 Signed-off-by: Shaun Pereira <[EMAIL PROTECTED]> Acked-by: Arnd Bergmann <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL

[patch 02/18] sem2mutex: drivers/net/irda

2006-03-08 Thread akpm
From: Arjan van de Ven <[EMAIL PROTECTED]> Semaphore to mutex conversion. The conversion was generated via scripts, and the result was validated automatically via a script as well. Signed-off-by: Arjan van de Ven <[EMAIL PROTECTED]> Signed-off-by: Ingo Molnar <[EMAIL PROTECTED]> Cc: "David S. M

[patch 01/18] git-net: remove MODULE_PARM()

2006-03-08 Thread akpm
From: Andrew Morton <[EMAIL PROTECTED]> MODULE_PARM() is deprecated and is about to go away altogether. Cc: "David S. Miller" <[EMAIL PROTECTED]> Cc: Rusty Russell <[EMAIL PROTECTED]> Cc: David Basden <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/net/irda/toi

[patch 10/12] CONFIG_FORCEDETH updates

2006-03-08 Thread akpm
From: Adrian Bunk <[EMAIL PROTECTED]> This patch contains the following possible updates: - let FORCEDETH no longer depend on EXPERIMENTAL - remove the "Reverse Engineered" from the option text: for the user it's important which hardware the driver supports, not how it was developed Signed-o

[patch 05/12] drivers/net/e1000/: proper prototypes

2006-03-08 Thread akpm
From: Adrian Bunk <[EMAIL PROTECTED]> This patch moves prototypes of global variables and functions to a header file. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Acked-by: John Ronciak <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000.h

[patch 11/12] NE2000 Kconfig help entry improvement

2006-03-08 Thread akpm
From: Jesper Juhl <[EMAIL PROTECTED]> Improve reference to PCI NE2K support in ISA NE2K documentation. Original 2.4 patch From: Ged Haywood <[EMAIL PROTECTED]> Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/net/Kconfig |3 ++- 1

[patch 03/12] via-rhine + link loss + autoneg off == trouble

2006-03-08 Thread akpm
From: Denis Vlasenko <[EMAIL PROTECTED]> Fixes stuck "carrier off" condition when ethernet line speed/duplex autonegotiation is turned off before cable is plugged in. Signed-off-by: Denis Vlasenko <[EMAIL PROTECTED]> Cc: Jeff Garzik <[EMAIL PROTECTED]> Cc: Lee Revell <[EMAIL PROTECTED]> Cc: Roge

[patch 09/12] tg3: netif_carrier_off runs too early; could still be queued when init fails

2006-03-08 Thread akpm
From: Jeff Mahoney <[EMAIL PROTECTED]> Move the netif_carrier_off() call from tg3_init_one()-> tg3_init_link_config() to tg3_open() as is the convention for most other network drivers. I was getting a panic after a tg3 device failed to initialize due to DMA failure. The oops pointed to the link

[patch 04/12] ipw2200 warning fix

2006-03-08 Thread akpm
From: Andrew Morton <[EMAIL PROTECTED]> drivers/net/wireless/ipw2200.c: In function `ipw_load': drivers/net/wireless/ipw2200.c:3224: warning: `ucode_name' might be used uninitialized in this function drivers/net/wireless/ipw2200.c:3225: warning: `fw_name' might be used uninitialized in this fun

[patch 08/12] 3c509: use proper suspend/resume API

2006-03-08 Thread akpm
From: Pekka Enberg <[EMAIL PROTECTED]> Convert 3c509 driver to use proper suspend/resume API instead of the deprecated pm_register/pm_unregister. Signed-off-by: Pekka Enberg <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/net/3c509.c | 70 +---

[patch 01/12] tulip: NatSemi DP83840A PHY fix

2006-03-08 Thread akpm
From: Thibaut VARENE <[EMAIL PROTECTED]> Fix a problem with Tulip 21142 HP branded PCI cards (PN#: B5509-66001), which feature a NatSemi DP83840A PHY. Without that patch, it is impossible to properly initialize the card's PHY, and it's thus impossible to monitor/configure it. It's a timing/post

[patch 06/12] sky2: use mutex

2006-03-08 Thread akpm
From: Stephen Hemminger <[EMAIL PROTECTED]> Convert sky2 driver phy semaphore to a mutex. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/net/sky2.c | 31 --- drivers/net/sky2.h |2 +- 2 files c

[patch 07/12] 3c509: bus registration fix

2006-03-08 Thread akpm
From: Andrew Morton <[EMAIL PROTECTED]> - Don't call eisa_driver_unregister() if eisa_driver_register() failed. - Properly propagate error values. Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/net/3c509.c | 13 - 1 files changed, 8 insertions(+), 5 deletions(-) d

[patch 12/12] de620: fix section mismatch warning

2006-03-08 Thread akpm
From: Sam Ravnborg <[EMAIL PROTECTED]> In latest -mm de620 gave following warning: WARNING: drivers/net/de620.o - Section mismatch: reference to \ .init.text:de620_probe from .text between 'init_module' (at offset \ 0x1682) and 'cleanup_module' init_module() call de620_probe() which is decl

[patch 02/12] 8139cp: register interrupt handler when net device is registered

2006-03-08 Thread akpm
From: Pierre Ossman <[EMAIL PROTECTED]> Avoids missing interrupts if the interrupt mask gets out of sync. The reason this patch is needed for me is that the resume function is broken. It enables interrupts unconditionally, but the interrupt handler is only registered when the device is up. I d