Re: [PATCH] deinline a few large functions in vlan code v2

2006-04-13 Thread Denis Vlasenko
On Wednesday 12 April 2006 20:18, Dave Dillow wrote: or loaded. And even if it saves 200 bytes in one module, unless that module text was already less than 200 bytes into a page, you've saved no memory -- a 4300 byte module takes 2 pages on x86, as does a 4100 byte module.

Re: [RFD][PATCH] typhoon and core sample for folding away VLAN stuff

2006-04-13 Thread Denis Vlasenko
On Thursday 13 April 2006 04:24, Dave Dillow wrote: Regardless, I remain opposed to this particular instance of bloat busting. While both patches have improved in style, they remove a useful feature and make the code less clean, for no net gain. What happened to non-modular build? no net

Re: [patch 1/3] softmac: return -EAGAIN from getscan while scanning

2006-04-13 Thread Pete Zaitcev
On Tue, 11 Apr 2006 10:58:06 +0200, [EMAIL PROTECTED] wrote: Below patch was developed after discussion with Daniel Drake who mentioned to me that wireless tools expect an EAGAIN return from getscan so that they can wait for the scan to finish before printing out the results. This sounds

Re: [patch 1/3] softmac: return -EAGAIN from getscan while scanning

2006-04-13 Thread Johannes Berg
On Thu, 2006-04-13 at 02:00 -0700, Pete Zaitcev wrote: This sounds completely wrong. Do you guys remember the Subject: string of this discussion by any chance? Discussed offline at the wireless summit, sorry. It's very likely that tools do indeed loop when they see EAGAIN, but this is a

[PATCH] ipw2100: wraps the debug module param within #ifdefs

2006-04-13 Thread Zhu Yi
Signed-off-by: Henrik Brix Andersen [EMAIL PROTECTED] Signed-off-by: Zhu Yi [EMAIL PROTECTED] --- drivers/net/wireless/ipw2100.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) e78cfdab91a809722be99c06574d2e0a60467644 diff --git a/drivers/net/wireless/ipw2100.c

[PATCH 0/6] ieee80211 updates

2006-04-13 Thread Zhu Yi
Hi, Here are some patches for ieee80211, please apply. [PATCH 1/6] ieee80211: Fix TKIP MIC calculation for QoS frames [PATCH 2/6] ieee80211: Fix TX code doesn't enable QoS when using WPA + QoS [PATCH 3/6] ieee80211: export list of bit rates with standard WEXT procdures [PATCH 4/6] ieee80211:

[PATCH 1/6] ieee80211: Fix TKIP MIC calculation for QoS frames

2006-04-13 Thread Zhu Yi
Fix TKIP MIC verification failure when receiving QoS frames from AP. Signed-off-by: Hong Liu [EMAIL PROTECTED] Signed-off-by: Zhu Yi [EMAIL PROTECTED] --- include/net/ieee80211.h |3 +++ net/ieee80211/ieee80211_crypt_tkip.c | 11 ++- 2 files changed, 13

[PATCH 3/6] ieee80211: export list of bit rates with standard WEXT procddures

2006-04-13 Thread Zhu Yi
The patch replace the way to export the list of bit rates in scan results from IWEVCUSTOM to SIOCGIWRATE. It also removes the max_rate item exported with SIOCGIWRATE since this should be done by userspace. Signed-off-by: Jean Tourrilhes [EMAIL PROTECTED] Signed-off-by: Zhu Yi [EMAIL PROTECTED]

[PATCH 09/18] ipw2200: Fix endian issues with v3.0 fw image format

2006-04-13 Thread Zhu Yi
This patch corrects endian issues with the v3.0 fw image format. Signed-off-by: James Ketrenos [EMAIL PROTECTED] Signed-off-by: Zhu Yi [EMAIL PROTECTED] --- drivers/net/wireless/ipw2200.c | 23 --- 1 files changed, 12 insertions(+), 11 deletions(-)

[PATCH 4/6] ieee80211: remove unnecessary CONFIG_WIRELESS_EXT checking

2006-04-13 Thread Zhu Yi
Signed-off-by: Zhu Yi [EMAIL PROTECTED] --- net/ieee80211/ieee80211_rx.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) 06f3e8b703c93ff8dbadf005878850fcd3393e5f diff --git a/net/ieee80211/ieee80211_rx.c b/net/ieee80211/ieee80211_rx.c index 604b7b0..0d18742 100644 ---

[PATCH 05/18] ipw2200: fix compile warning when !CONFIG_IPW2200_DEBUG

2006-04-13 Thread Zhu Yi
Signed-off-by: Zhu Yi [EMAIL PROTECTED] --- drivers/net/wireless/ipw2200.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) 4c418f1f7845ec9d78fe4f3a7346416c13662ace diff --git a/drivers/net/wireless/ipw2200.c b/drivers/net/wireless/ipw2200.c index 6b8c47b..c38fb90 100644 ---

[PATCH 5/6] ieee80211: replace debug IEEE80211_WARNING with each own debug macro

2006-04-13 Thread Zhu Yi
Signed-off-by: Zhu Yi [EMAIL PROTECTED] --- net/ieee80211/ieee80211_rx.c | 16 1 files changed, 8 insertions(+), 8 deletions(-) 7a5148115c33ea94ff352a305ad2b2646a573219 diff --git a/net/ieee80211/ieee80211_rx.c b/net/ieee80211/ieee80211_rx.c index 0d18742..2bf567f 100644 ---

[PATCH 2/6] ieee80211: Fix TX code doesn't enable QoS when using WPA + QoS

2006-04-13 Thread Zhu Yi
Fix ieee80211 TX code when using WPA+QOS. TKIP/CCMP will use the TID field of qos_ctl in 802.11 frame header to do encryption. We cannot ignore this field when doing host encryption and add the qos_ctl field later. Signed-off-by: Hong Liu [EMAIL PROTECTED] Signed-off-by: Zhu Yi [EMAIL PROTECTED]

[PATCH 02/18] ipw2200: Fix TX QoS enabled frames problem

2006-04-13 Thread Zhu Yi
This patch works with the ieee80211 stack to set the correct QoS bit to the ipw2200 card. It fixed the TX failure problem for using WPA with QoS. Signed-off-by: Hong Liu [EMAIL PROTECTED] Signed-off-by: Zhu Yi [EMAIL PROTECTED] --- drivers/net/wireless/ipw2200.c | 71

[PATCH 04/18] ipw2200: add module_param support for antenna selection

2006-04-13 Thread Zhu Yi
Signed-off-by: Zhu Yi [EMAIL PROTECTED] --- drivers/net/wireless/ipw2200.c |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) cfcb7bc915320b44d0d2825a8554211249c7bbcd diff --git a/drivers/net/wireless/ipw2200.c b/drivers/net/wireless/ipw2200.c index 536af9f..6b8c47b 100644 ---

[PATCH 08/18] ipw2200: Set the 'fixed' flags in wext get_rate

2006-04-13 Thread Zhu Yi
Signed-off-by: Jean Tourrilhes [EMAIL PROTECTED] Signed-off-by: Zhu Yi [EMAIL PROTECTED] --- drivers/net/wireless/ipw2200.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) 773cfa85e3c221a9d8284da73ff9e087e98dea12 diff --git a/drivers/net/wireless/ipw2200.c

[PATCH 06/18] ipw2200: Do not continue loading the firmware if kmalloc fails

2006-04-13 Thread Zhu Yi
Signed-off-by: Ingo Molnar [EMAIL PROTECTED] Cc: Zhu, Yi [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- drivers/net/wireless/ipw2200.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) bb9de6f2888b04991bc634e9700114d3b415cdcb diff --git

[PATCH 07/18] ipw2200: turn off signal debug log

2006-04-13 Thread Zhu Yi
Signed-off-by: Zhu Yi [EMAIL PROTECTED] --- drivers/net/wireless/ipw2200.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) c4613fd635d134e567b64de4d89fe54a7b0f88b2 diff --git a/drivers/net/wireless/ipw2200.c b/drivers/net/wireless/ipw2200.c index febee43..057faa0 100644 ---

[PATCH 6/6] ieee80211: update version stamp to 1.1.13

2006-04-13 Thread Zhu Yi
Signed-off-by: Zhu Yi [EMAIL PROTECTED] --- include/net/ieee80211.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) ad81572a2505f80d22a1ceae5c055966e92df09f diff --git a/include/net/ieee80211.h b/include/net/ieee80211.h index bc6bdd6..4087dfc 100644 --- a/include/net/ieee80211.h

[PATCH 01/18] ipw2200: Exponential averaging for signal and noise Level

2006-04-13 Thread Zhu Yi
This patch replaces sliding averaging by exponential averaging for reporting the wireless statistics for signal and noise level for ipw2200. See details from: http://www.ces.clemson.edu/linux/ipw2200_averages.shtml Signed-off-by: Bill Moss [EMAIL PROTECTED] Signed-off-by: Zhu Yi [EMAIL PROTECTED]

[PATCH 00/18] ipw2200 driver updates

2006-04-13 Thread Zhu Yi
Hi, The following patches are ipw2200 driver recently update. Please apply. [PATCH 01/18] ipw2200: Exponential averaging for signal and noise Level [PATCH 02/18] ipw2200: Fix TX QoS enabled frames problem [PATCH 03/18] ipw2200: generates a scan event after a scan has completed [PATCH 04/18]

[PATCH 13/18] ipw2200: update version stamp to 1.1.2

2006-04-13 Thread Zhu Yi
Signed-off-by: Zhu Yi [EMAIL PROTECTED] --- Documentation/networking/README.ipw2200 |6 +++--- drivers/net/wireless/ipw2200.c |2 +- 2 files changed, 4 insertions(+), 4 deletions(-) dd0f5de1aff491fb0358b7eaf7d22e907fa1e5ee diff --git a/Documentation/networking/README.ipw2200

[PATCH 18/18] ipw2200: Fix wpa_supplicant association problem

2006-04-13 Thread Zhu Yi
The new ipw2200 scan completion event feature will cause a potential event race condition in wpa_supplicant. The patch fixes this problem by move the ipw_disassociate() to the IW_AUTH_WPA_ENABLED event handling code. Signed-off-by: Zhu Yi [EMAIL PROTECTED] --- drivers/net/wireless/ipw2200.c |

[PATCH 16/18] ipw2200: rename CONFIG_IEEE80211_RADIOTAP to CONFIG_IPW2200_RADIOTAP

2006-04-13 Thread Zhu Yi
Signed-off-by: Zhu Yi [EMAIL PROTECTED] --- drivers/net/wireless/ipw2200.c | 12 ++-- drivers/net/wireless/ipw2200.h |2 +- 2 files changed, 7 insertions(+), 7 deletions(-) 70646d6a1c055a3bbd5b29f471ca49d43c534267 diff --git a/drivers/net/wireless/ipw2200.c

[PATCH 14/18] ipw2200: rename CONFIG_IPW_QOS to CONFIG_IPW2200_QOS

2006-04-13 Thread Zhu Yi
Signed-off-by: Zhu Yi [EMAIL PROTECTED] --- drivers/net/wireless/Kconfig |2 +- drivers/net/wireless/ipw2200.c | 42 2 files changed, 22 insertions(+), 22 deletions(-) b483305435de6baed1194ddaff5b437e0810a4c1 diff --git

[PATCH 15/18] wireless Kconfig add IPW2200_RADIOTAP

2006-04-13 Thread Zhu Yi
Makefile both IPW2200_RADIOTAP and IPW2200_PROMISCUOUS depend on IPW2200_MONITOR. Let IPW2200_PROMISCUOUS select IPW2200_RADIOTAP. Signed-off-by: Zhu Yi [EMAIL PROTECTED] --- drivers/net/wireless/Kconfig | 52 +++--- 1 files changed, 28 insertions(+), 24

[PATCH 11/18] ipw2200: Enable rtap interface for RF promiscuous mode while associated

2006-04-13 Thread Zhu Yi
With this patch, a new promiscuous mode is enabled. If the module is loaded with the rtap_iface=1 module parameter, two interfaces will be created (instead of just one). The second interface is prefixed 'rtap' and provides received 802.11 frames on the current channel to user space in a radiotap

[PATCH 17/18] ipw2200: remove priv-last_noise reference

2006-04-13 Thread Zhu Yi
priv-last_noise is not used with the exponential averaging algorithm Signed-off-by: Zhu Yi [EMAIL PROTECTED] --- drivers/net/wireless/ipw2200.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) 56992321cbe73f5dbdf93464d6cbe75b83a1e37d diff --git a/drivers/net/wireless/ipw2200.c

[PATCH 12/18] ipw2200: version string rework

2006-04-13 Thread Zhu Yi
Added version string fields so the version string indicates what is configured (ie, you'll see 1.1.1kpmd if you are using a GIT snapshot (Kernel.. previously -git), promiscuous (p), monitor (m), debug (d) build. Signed-off-by: James Ketrenos [EMAIL PROTECTED] Signed-off-by: Zhu Yi [EMAIL

Re: [patch 1/3] softmac: return -EAGAIN from getscan while scanning

2006-04-13 Thread Johannes Berg
On Thu, 2006-04-13 at 11:06 +0200, Johannes Berg wrote: It's very likely that tools do indeed loop when they see EAGAIN, but this is a workaround, not the main mode of operation. It seems obvious to me that the get method should wait until the scan results are available. Perhaps the

[PATCH] Repost : Convert cassini to pci_iomap

2006-04-13 Thread Marc Zyngier
Folks, This patch (against 2.6.17-rc1) converts the cassini driver to the pci_iomap API that will do the right thing, so architectures like PARISC can stop screaming about illegal usage of ioremap() on non-cacheable regions. Tested on 64bit PARISC kernel. Signed-off-by: Marc Zyngier [EMAIL

[patch 5] softmac: report when scanning has finished

2006-04-13 Thread Johannes Berg
Make softmac report a scan event when scanning has finished, that way userspace can wait for the event to happen instead of polling for the results. Signed-off-by: Johannes Berg [EMAIL PROTECTED] --- This patch depends on the previous patch 4. If you want, I can resend the whole series with

Re: [PATCH] deinline a few large functions in vlan code v2

2006-04-13 Thread Ingo Oeser
Hi Dave, On Wednesday, 12. April 2006 19:18, Dave Dillow wrote: you've left the spin_locks in, and have more #ifdefs. Ok, I can refactor your driver to even remove this and reduce it to exaxtly two ifdef sections for your driver. Acceptable? Regardless, I remain opposed to this particular

[RFC: 2.6 patch] net/core/: possible cleanups

2006-04-13 Thread Adrian Bunk
This patch contains the following possible cleanups: - make the following needlessly global functions static: - skbuff.c: kfree_skbmem() - skbuff.c: skb_prepare_seq_read() - skbuff.c: skb_seq_read() - skbuff.c: skb_abort_seq_read() - #if 0 the following unused global functions: -

Re: [patch 1/3] softmac: return -EAGAIN from getscan while scanning

2006-04-13 Thread Dan Williams
On Thu, 2006-04-13 at 02:00 -0700, Pete Zaitcev wrote: On Tue, 11 Apr 2006 10:58:06 +0200, [EMAIL PROTECTED] wrote: Below patch was developed after discussion with Daniel Drake who mentioned to me that wireless tools expect an EAGAIN return from getscan so that they can wait for the scan

Re: [patch 5] softmac: report when scanning has finished

2006-04-13 Thread Dan Williams
On Thu, 2006-04-13 at 11:41 +0200, Johannes Berg wrote: Make softmac report a scan event when scanning has finished, that way userspace can wait for the event to happen instead of polling for the results. Signed-off-by: Johannes Berg [EMAIL PROTECTED] ACK, good catch. Signed-off-by: Dan

Re: [patch 1/3] softmac: return -EAGAIN from getscan while scanning

2006-04-13 Thread Dan Williams
On Thu, 2006-04-13 at 11:34 +0200, Johannes Berg wrote: On Thu, 2006-04-13 at 11:06 +0200, Johannes Berg wrote: It's very likely that tools do indeed loop when they see EAGAIN, but this is a workaround, not the main mode of operation. It seems obvious to me that the get method should

Re: [patch 1/3] softmac: return -EAGAIN from getscan while scanning

2006-04-13 Thread Johannes Berg
On Thu, 2006-04-13 at 08:12 -0400, Dan Williams wrote: Maybe it's wrong now, but it's how the CLI tools have operated for quite a while AFAIK. Yes, and they don't seem to care about the netlink messages. But the question is rather -- should we block the program inside the kernel and only

Re: [PATCH] atm: clip causes unregister hang

2006-04-13 Thread Herbert Xu
On Wed, Apr 12, 2006 at 02:52:54PM -0700, Stephen Hemminger wrote: If Classical IP over ATM module is loaded, its neighbor table gets populated when permanent neighbor entries are created; but these entries are not flushed when the device is removed. Since the entry never gets flushed the

Re: [RFC: 2.6 patch] net/core/: possible cleanups

2006-04-13 Thread Jörn Engel
On Thu, 13 April 2006 13:58:28 +0200, Adrian Bunk wrote: - make the following trivial wrapper function a static inline: - neighbour.c: neigh_parms_destroy() Am I missing something or is there just a single caller? In that case, neigh_parms_put() could call kfree() directly and

Re: [PATCH] acxsm: Reduce the number of ACX_PACKED instructions

2006-04-13 Thread Denis Vlasenko
On Wednesday 12 April 2006 23:58, John W. Linville wrote: On Sat, Mar 25, 2006 at 09:01:16PM +0100, Carlos Martin wrote: Up to now, we were using ACX_PACKED after every field. I've finally found out how to use only one at the end of each struct whilst maintaining the typedef where it is

Re: [PATCH] atm: clip timer race

2006-04-13 Thread Herbert Xu
On Wed, Apr 12, 2006 at 03:42:14PM -0700, Stephen Hemminger wrote: By inspection, the clip idle timer code is racy on SMP. Here is a safe version of timer management. Untested, I don't have ATM hardware. Good catch Stephen. - if (start_timer == 0) - del_timer(idle_timer); +

[XFRM] Fix aevent timer

2006-04-13 Thread jamal
Finally got an opportunity to test this. I have incorporated all the feedback and it passes all the scenarios i know. Dave, please apply to Linus tree since this is a bug fix. cheers, jamal Send aevent immediately if we have sent nothing since last timer and this is the first packet. Fixes a

Re: [RFC][PATCH] Avoid multi-page allocs for large mtu datagram sends

2006-04-13 Thread Herbert Xu
Hi Zach: On Wed, Apr 05, 2006 at 05:51:02PM +, Zach Brown wrote: + if ((rt-u.dst.dev-featuresNETIF_F_SG) + (SKB_DATA_KMALLOC_BYTES(alloclen + datalen) + PAGE_SIZE)) { +

[XFRM Doc]: aevent description

2006-04-13 Thread jamal
Dave, There is dependency on the previous patch i sent since the issue that patch fixes is assumed in this text description. It would be a good idea to apply at the same time as the other. cheers, jamal Documentation to describe asynchronous xfrm events to help people writting HA code in user

Re: [PATCH] acxsm: Reduce the number of ACX_PACKED instructions

2006-04-13 Thread John W. Linville
On Thu, Apr 13, 2006 at 03:33:57PM +0300, Denis Vlasenko wrote: Did you rename softmac branch again? I'm trying to reduce the branches. Some/most of what was the softmac branch has been merged upstream. The tiacx and prism54usb drivers remain in wireless-2.6 under the master branch. BTW, the

Re: tc actions like pass,drop executed at a given percentage, not every nth

2006-04-13 Thread jamal
On Tue, 2006-11-04 at 08:42 -0700, pfer wrote: Hi all! Can you give me some guideline about how and where netrand ... influences an action in the tc sources? (I've also tried LARTC mailing list, but did not get any response) Did you look at the docs included in iproute2? When I last

[PATCH] bcm43xx: iw_priv_args names should be 16 characters

2006-04-13 Thread Erik Mouw
The room for the names in bcm43xx_priv_wx_args[] are IFNAMSIZ long and IFNAMSIZ is defined as 16, so the names in bcm43xx_priv_wx_args should be 15 characters (16 including the trailing \0). This patch fixes that for the set_shortpreambl, get_shortpreambl, set_swencryption, and get_swencryption

Re: [XFRM] Fix aevent timer

2006-04-13 Thread Herbert Xu
On Thu, Apr 13, 2006 at 08:55:58AM -0400, jamal wrote: Finally got an opportunity to test this. I have incorporated all the feedback and it passes all the scenarios i know. Looks good to me. Thanks Jamal. -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL

Re: [RFD][PATCH] typhoon and core sample for folding away VLAN stuff

2006-04-13 Thread Dave Dillow
On Thu, 2006-04-13 at 11:38 +0300, Denis Vlasenko wrote: On Thursday 13 April 2006 04:24, Dave Dillow wrote: Regardless, I remain opposed to this particular instance of bloat busting. While both patches have improved in style, they remove a useful feature and make the code less clean, for

Re: [patch 1/3] softmac: return -EAGAIN from getscan while scanning

2006-04-13 Thread Jouni Malinen
On Thu, Apr 13, 2006 at 02:19:26PM +0200, Johannes Berg wrote: But the question is rather -- should we block the program inside the kernel and only return from get scan after the scan is actually done, rather than returning we can't give you anything now, try later. We could do that too, but

[RFC: 2.6 patch] net/netlink/: possible cleanups

2006-04-13 Thread Adrian Bunk
This patch contains the following possible cleanups plus changes related to them: - make the following needlessly global functions static: - attr.c: __nla_reserve() - attr.c: __nla_put() - #if 0 the following unused global functions: - attr.c: nla_validate() - attr.c: nla_find() -

Re: [PATCH] atm: clip timer race

2006-04-13 Thread Stephen Hemminger
On Thu, 13 Apr 2006 22:45:34 +1000 Herbert Xu [EMAIL PROTECTED] wrote: On Wed, Apr 12, 2006 at 03:42:14PM -0700, Stephen Hemminger wrote: By inspection, the clip idle timer code is racy on SMP. Here is a safe version of timer management. Untested, I don't have ATM hardware. Good catch

Re: [PATCH 12/18] ipw2200: version string rework

2006-04-13 Thread Stephen Hemminger
On Thu, 13 Apr 2006 17:20:34 +0800 Zhu Yi [EMAIL PROTECTED] wrote: Added version string fields so the version string indicates what is configured (ie, you'll see 1.1.1kpmd if you are using a GIT snapshot (Kernel.. previously -git), promiscuous (p), monitor (m), debug (d) build. No, this is

Re: [PATCH] ipw2100: wraps the debug module param within #ifdefs

2006-04-13 Thread Stephen Hemminger
Please get rid of the debug config option. Make the debug code, default off and be low enough impact that everyone can ship with it. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH] atm: clip timer race

2006-04-13 Thread Herbert Xu
On Thu, Apr 13, 2006 at 10:26:30AM -0700, Stephen Hemminger wrote: Arp and neighbor table have the same rescheduling bug. You're absolutely right. Maybe the easy way out for now is to make clip unremovable. -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL

Re: [PATCH] bcm43xx: iw_priv_args names should be 16 characters

2006-04-13 Thread Stephen Hemminger
On Thu, 13 Apr 2006 15:02:27 +0200 Erik Mouw [EMAIL PROTECTED] wrote: The room for the names in bcm43xx_priv_wx_args[] are IFNAMSIZ long and IFNAMSIZ is defined as 16, so the names in bcm43xx_priv_wx_args should be 15 characters (16 including the trailing \0). This patch fixes that for the

[RESEND PATCH 2/2] s390: remove tty support from ctc network device driver [2/2]

2006-04-13 Thread Frank Pavlic
Hi, here comes the second of the two patches ... Frank From: Peter Tiedemann [EMAIL PROTECTED] [2/2]: remove ctctty.c and ctctty.h files . Signed-off-by: Frank Pavlic [EMAIL PROTECTED] --- drivers/s390/net/ctctty.c | 1259 -

[PATCH RESEND 1/2] s390: remove tty support from ctc network device driver [1/2]

2006-04-13 Thread Frank Pavlic
Hi jeff, after the first shot I sent to you did not apply I resend two new patches I've made today to remove tty from ctc network driver. Please apply Thank you ... Frank From: Peter Tiedemann [EMAIL PROTECTED] [1/2]: tty support code will be removed from the ctc network

Re: via_rhine modules error on 2.6.16 with mii-tool

2006-04-13 Thread John W. Linville
On Mon, Mar 27, 2006 at 10:39:46PM +0200, Roger Luethi wrote: On Fri, 24 Mar 2006 16:49:10 +0100, Marco Berizzi wrote: Hello evebody. I get this error on linux vanilla 2.6.16 with via_rhine module loaded when I run mii-tool: That was caused by a recent change that replaced an mdelay

Re: [RFC: 2.6 patch] net/netlink/: possible cleanups

2006-04-13 Thread David S. Miller
From: Adrian Bunk [EMAIL PROTECTED] Date: Thu, 13 Apr 2006 18:27:10 +0200 This patch contains the following possible cleanups plus changes related to them: - make the following needlessly global functions static: - attr.c: __nla_reserve() - attr.c: __nla_put() - #if 0 the following

Re: via_rhine modules error on 2.6.16 with mii-tool

2006-04-13 Thread Roger Luethi
On Thu, 13 Apr 2006 14:26:43 -0400, John W. Linville wrote: I wonder if low latency for ancient Rhine-I chips is worth the trouble. IIRC, the point was that mdelay was getting called in interrupt context and causing ugly messages to show-up in dmesg. I suppose the patch back then was to

Re: via_rhine modules error on 2.6.16 with mii-tool

2006-04-13 Thread Roger Luethi
On Thu, 13 Apr 2006 11:40:18 -0700, Stephen Hemminger wrote: The right thing to do is get rid of the locking in via_rhine:netdev_ioctl and push the locking down into mdio_read, mdio_write. As I said before, a dozen other network drivers do the exact same thing -- they call generic_mii_ioctl

Re: via_rhine modules error on 2.6.16 with mii-tool

2006-04-13 Thread Stephen Hemminger
On Thu, 13 Apr 2006 22:47:31 +0200 Roger Luethi [EMAIL PROTECTED] wrote: On Thu, 13 Apr 2006 11:40:18 -0700, Stephen Hemminger wrote: The right thing to do is get rid of the locking in via_rhine:netdev_ioctl and push the locking down into mdio_read, mdio_write. As I said before, a dozen

Re: [PATCH] atm: clip timer race

2006-04-13 Thread Roland Dreier
Herbert I don't think this is enough though since this timer is Herbert one of those self-rescheduling timers. You need to Herbert provide some sort of a flag for it to stop scheduling Herbert itself and synchronise it properly. I'm probably missing an obvious race but it seems

Re: via_rhine modules error on 2.6.16 with mii-tool

2006-04-13 Thread Francois Romieu
Stephen Hemminger [EMAIL PROTECTED] : [...] The other drivers should be fixed as well. Phy access with irq's disabled is not good. The hardware I checked takes 100's of usecs to do one read transaction. Yep, 802.3 allows it. :o| It's surprizing that the low latency squadron has not

Re: via_rhine modules error on 2.6.16 with mii-tool

2006-04-13 Thread Roger Luethi
On Thu, 13 Apr 2006 14:02:52 -0700, Stephen Hemminger wrote: I am not keen on patches that make via-rhine more of a special case even if it was safe now; next thing you know generic_mii_ioctl is changed in a way that breaks the only driver that foolishly made assumptions about the

Re: [PATCH] atm: clip timer race

2006-04-13 Thread Herbert Xu
Roland Dreier [EMAIL PROTECTED] wrote: I'm probably missing an obvious race but it seems del_timer_sync() should be fine on a timer that reschedules itself. del_timer_sync() loops until try_to_del_timer_sync() succeeds, and try_to_del_timer_sync() will fail unless the timer being killed is

Re: [patch 1/3] softmac: return -EAGAIN from getscan while scanning

2006-04-13 Thread Pete Zaitcev
On Thu, 13 Apr 2006 08:12:55 -0400, Dan Williams [EMAIL PROTECTED] wrote: This sounds completely wrong. Do you guys remember the Subject: string of this discussion by any chance? There are two options for tools: (a) request scan and block on GIWSCAN until it doesn't return EAGAIN, or (b)

[PATCH 4/4] clip: add module info

2006-04-13 Thread Stephen Hemminger
Add module information Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- clip.orig/net/atm/clip.c2006-04-13 15:20:38.0 -0700 +++ clip/net/atm/clip.c 2006-04-13 15:23:41.0 -0700 @@ -1017,5 +1017,6 @@ module_init(atm_clip_init); module_exit(atm_clip_exit); -

[PATCH 2/4] clip: get rid of PROC_FS ifdef

2006-04-13 Thread Stephen Hemminger
Don't need the ifdef here since create_proc_entry() is stubbed to always return NULL. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- clip.orig/net/atm/clip.c2006-04-13 15:18:21.0 -0700 +++ clip/net/atm/clip.c 2006-04-13 15:20:26.0 -0700 @@ -976,6 +976,7 @@ static

[PATCH 1/4] clip: run through Lindent

2006-04-13 Thread Stephen Hemminger
Run CLIP driver through Lindent script to fix formatting. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- clip.orig/net/atm/clip.c2006-04-13 09:44:22.0 -0700 +++ clip/net/atm/clip.c 2006-04-13 15:18:21.0 -0700 @@ -2,7 +2,6 @@ /* Written 1995-2000 by Werner

[PATCH 3/4] clip: notifier related cleanups

2006-04-13 Thread Stephen Hemminger
Cleanup some code around notifier. Don't need (void) casts to ignore return values, and use C90 style initializer. Just ignore unused device events. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- clip.orig/net/atm/clip.c2006-04-13 15:20:26.0 -0700 +++ clip/net/atm/clip.c

Re: [patch 1/3] softmac: return -EAGAIN from getscan while scanning

2006-04-13 Thread Pete Zaitcev
On Thu, 13 Apr 2006 09:00:51 -0700, Jouni Malinen [EMAIL PROTECTED] wrote: That could be blocking an ioctl call for couple of seconds and would be quite horrible for single threaded programs. I would say that waiting for couple of seconds in the kernel would be quite wonderful for single

Re: [stable] [PATCH 1/4] clip: run through Lindent

2006-04-13 Thread Greg KH
On Thu, Apr 13, 2006 at 03:22:24PM -0700, Stephen Hemminger wrote: Run CLIP driver through Lindent script to fix formatting. That's well and good, but really not a -stable thing. In fact, I don't see any of these 4 patches being -stable material, do you? thanks, greg k-h - To unsubscribe from

Re: [patch 1/3] softmac: return -EAGAIN from getscan while scanning

2006-04-13 Thread Jouni Malinen
On Thu, Apr 13, 2006 at 03:28:53PM -0700, Pete Zaitcev wrote: On Thu, 13 Apr 2006 09:00:51 -0700, Jouni Malinen [EMAIL PROTECTED] wrote: That could be blocking an ioctl call for couple of seconds and would be quite horrible for single threaded programs. I would say that waiting for

Re: [patch 1/3] softmac: return -EAGAIN from getscan while scanning

2006-04-13 Thread Stephen Hemminger
On Thu, 13 Apr 2006 15:45:22 -0700 Jouni Malinen [EMAIL PROTECTED] wrote: On Thu, Apr 13, 2006 at 03:28:53PM -0700, Pete Zaitcev wrote: On Thu, 13 Apr 2006 09:00:51 -0700, Jouni Malinen [EMAIL PROTECTED] wrote: That could be blocking an ioctl call for couple of seconds and would be

[patch 05/22] sky2: bad memory reference on dual port cards

2006-04-13 Thread Greg KH
-stable review patch. If anyone has any objections, please let us know. -- Sky2 driver will oops referencing bad memory if used on a dual port card. The problem is accessing past end of MIB counter space. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] Signed-off-by: Greg

[patch 22/22] atm: clip causes unregister hang

2006-04-13 Thread Greg KH
-stable review patch. If anyone has any objections, please let us know. -- If Classical IP over ATM module is loaded, its neighbor table gets populated when permanent neighbor entries are created; but these entries are not flushed when the device is removed. Since the entry

[PATCH 1/3] eth: use constant size address (revised)

2006-04-13 Thread Stephen Hemminger
Change the ethernet support routines to use constant address size. This generates smaller faster code. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- sky2-2.6.17.orig/net/ethernet/eth.c 2006-03-07 13:28:54.0 -0800 +++ sky2-2.6.17/net/ethernet/eth.c 2006-04-12

Re: [patch 1/3] softmac: return -EAGAIN from getscan while scanning

2006-04-13 Thread Jean Tourrilhes
Pete Zaitcev wrote : Do you realize that block means enterering the kernel and calling schedule(), which is exactly what is NOT happening in the patch? I would not mind if the tools blocked in GIWSCAN, only until it returns success and not EGAIN. Do you realise that block means

Re: [patch 1/3] softmac: return -EAGAIN from getscan while scanning

2006-04-13 Thread Jean Tourrilhes
Stephen Hemminger wrote : Sounds like you want a message interface like netlink, not ioctl's. We have the message interface (through a Wireless Events, since WE-14). However, netlink is highly undesirable in embedded space for bloat reason. Jean - To unsubscribe from this

[RFC] Geographical/regulatory information for ieee80211

2006-04-13 Thread Larry Finger
I am planning on writing a new routine to be added to net/ieee80211/ieee80211_geo.c that will populate an ieee80211_geo object given a country code. The new routine will eliminate the need for each driver to do their own. Finding the allowable channels, etc. for various countries has not been

Re: [RFC PATCH] softmac: (v2) send WEXT assoc/disassoc events to userspace

2006-04-13 Thread Hans Fugal
With the patch, wpa_supplicant is able to work properly for WEP and plaintext as tested with my bcm4306 (iBook), and the latest git. However, and this may not be related, I still must issue an ip link set up eth1 after loading the bcm43xx module but before starting wpa_supplicant or it

Re: [PATCH] ipw2100: wraps the debug module param within #ifdefs

2006-04-13 Thread Zhu Yi
On Thu, 2006-04-13 at 10:30 -0700, Stephen Hemminger wrote: Please get rid of the debug config option. Make the debug code, default off and be low enough impact that everyone can ship with it. This patch is exactly doing so. There won't be the debug module param if CONFIG_IPW2200_DEBUG is not