Re: [NETLINK]: Restore API compatibility of address and neighbour bits

2006-12-07 Thread David Miller
From: David Woodhouse <[EMAIL PROTECTED]> Date: Thu, 07 Dec 2006 11:28:28 + > On Thu, 2006-12-07 at 11:55 +0100, Thomas Graf wrote: > > Restore API compatibility due to bits moved from rtnetlink.h to > > separate headers. > > For 2.6.19.1 too, please. I will, thanks for reminding me. - To un

Re: NAPI and shared interrupt control

2006-12-07 Thread David Miller
From: Benjamin Herrenschmidt <[EMAIL PROTECTED]> Date: Thu, 07 Dec 2006 21:56:02 +1100 > Dave, the main point of my initial email was: should we provide a > routine from the net core to initialize such dummy devices properly ? > I'm a little worried that some day, the NAPI code will change and the

Re: [NETLINK]: Restore API compatibility of address and neighbour bits

2006-12-07 Thread David Miller
From: Thomas Graf <[EMAIL PROTECTED]> Date: Thu, 7 Dec 2006 11:55:02 +0100 > Restore API compatibility due to bits moved from rtnetlink.h to > separate headers. > > Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Applied, thanks for taking care of this Thomas. - To unsubscribe from this list: sen

Re: Marvell Libertas wifi

2006-12-07 Thread Alex Deucher
On 12/7/06, Dan Williams <[EMAIL PROTECTED]> wrote: On Thu, 2006-12-07 at 12:32 -0500, Alex Deucher wrote: > I just wanted to check on the status of the libertas driver from > Marvell for the OLPC project. I haven't really been able to find out The driver needs quite a bit of love. It's only b

[PATCH 9/10] cxgb3 - register definitions

2006-12-07 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> This patch implements the registers definitions for the Chelsio network adapter's driver. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/regs.h | 2177 ++ 1 files changed, 2177 insertions(+),

[PATCH 7/10] cxgb3 - offload header files

2006-12-07 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> This patch implements the offload operations header files for the Chelsio T3 network adapter's driver. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/cxgb3_ctl_defs.h | 142 drivers/net/cxgb3/cxgb3_defs.h | 99 ++ drivers/n

[PATCH 6/10] cxgb3 - on board memory, MAC and PHY

2006-12-07 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> This patch implements on board memory, MAC and PHY management for the Chelsio T3 network adapter's driver. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/ael1002.c | 231 ++ drivers/net/cxgb3/mc5.c | 456 +

[PATCH 8/10] cxgb3 - offload capabilities

2006-12-07 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> This patch implements the offload capabilities of the Chelsio network adapter's driver. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/cxgb3_offload.c | 1221 + drivers/net/cxgb3/l2t.c | 4

[PATCH 10/10] cxgb3 - build files and versioning

2006-12-07 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> This patch implements build files and versioning for the Chelsio T3 network adapter's driver. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/Kconfig | 18 ++ drivers/net/Makefile|1 + drivers/net/cxgb3/

[PATCH 3/10] cxgb3 - HW access routines - part 1

2006-12-07 Thread divy
From: Divy Le Ray <[EMAIL PROTECTED]> This patch implements the HW access routines for the Chelsio T3 network adapter's driver. This patch is split. This is the first part. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/t3_hw.c | 3352 +++

[PATCH 4/10] cxgb3 - HW access routines - part 2

2006-12-07 Thread divy
From: Divy Le Ray <[EMAIL PROTECTED]> This patch implements the HW access routines for the Chelsio T3 network adapter's driver. This patch is split. This is the second part. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> -- +/** + * t3_sge_write_context - write an SGE context + * @adapter

[PATCH 0/10] cxgb3: Chelsio T3 1G/10G ethernet device driver

2006-12-07 Thread Divy Le Ray
Hi, I resubmit the patch supporting the latest Chelsio T3 adapter. It incorporates feedbacks from Stephen: - per port data accessed through netdev_priv() - remove locking in netpoll() method It also adapts to the new workqueue rules. This patch adds support for the latest Chelsio adapter, T3. I

[PATCH 1/10] cxgb3 - main header files

2006-12-07 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> This patch implements the main header files of the Chelsio T3 network driver. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/adapter.h | 255 drivers/net/cxgb3/common.h | 710 ++

[IPROUTE2 PATCH][utils] make muticast group to bitmask conversion generic

2006-12-07 Thread jamal
[utils] make muticast group to bitmask conversion generic Signed-off-by: J Hadi Salim <[EMAIL PROTECTED]> --- commit 1326d6a1eb107e3b9ea7a3254e621dd3f827bb4d tree 47387be512f44a27ee73678d3775801dfafaf03d parent 06f5ab6e44fd60430c1b25cd6144d93d3c598bb0 author Jamal Hadi Salim <[EMAIL PROTECTED]>

[IPROUTE2 PATCH][XFRM] update xfrm async events

2006-12-07 Thread jamal
[XFRM] update xfrm async events Report abbreviated async xfrm aevents. --- commit 06f5ab6e44fd60430c1b25cd6144d93d3c598bb0 tree a2fe589d73fe8a0e565ae4a73790b0a6b14c96d4 parent 74ca97373a2c98ac49156bd76d6df6a0d2a27ffc author Jamal Hadi Salim <[EMAIL PROTECTED]> Thu, 07 Dec 2006 20:27:06 -0500 com

[PATCH] [XFRM] Fix XFRMGRP_REPORT to use correct multicast group

2006-12-07 Thread jamal
Against net-2.6 but should probably go into anything stable that has reports already. cheers, jamal [XFRM] Fix XFRMGRP_REPORT to use correct multicast group XFRMGRP_REPORT uses 0x10 which is a group that belongs to events. The correct value is 0x20. We should really be using xfrm_nlgroups going

[AX.25] Fix default address and broadcast address initialization

2006-12-07 Thread Ralf Baechle
Only the callsign but not the SSID part of an AX.25 address is ASCII based but Linux by initializes the SSID which should be just a 4-bit number from ASCII anyway. Fix that and convert the code to use a shared constant for both default addresses. While at it, use the same style for null_ax25_addr

Re: [AX.25] Fix default address and broadcast address initialization

2006-12-07 Thread David Miller
From: Ralf Baechle <[EMAIL PROTECTED]> Date: Thu, 7 Dec 2006 23:45:59 + > Only the callsign but not the SSID part of an AX.25 address is ASCII > based but Linux by initializes the SSID which should be just a 4-bit > number from ASCII anyway. > > Fix that and convert the code to use a shared c

Re: [AX.25] Constify ax25 utility functions

2006-12-07 Thread David Miller
From: Ralf Baechle <[EMAIL PROTECTED]> Date: Thu, 7 Dec 2006 23:40:57 + > Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> Applied, thanks Ralf. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger

[AX.25] Constify ax25 utility functions

2006-12-07 Thread Ralf Baechle
Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> include/net/ax25.h | 18 ++ net/ax25/ax25_addr.c | 19 +++ 2 files changed, 21 insertions(+), 16 deletions(-) Index: linux-net/include/net/ax25.h

Re: [PATCH] convert hh_lock to seqlock

2006-12-07 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Thu, 7 Dec 2006 11:33:09 -0800 > The hard header cache is in the main output path, so using > seqlock instead of reader/writer lock should reduce overhead. > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> I've applied this, thanks Stephen

Re: [PATCH] convert hh_lock to seqlock

2006-12-07 Thread Eric Dumazet
Stephen Hemminger a écrit : On Thu, 07 Dec 2006 23:27:00 +0100 Eric Dumazet <[EMAIL PROTECTED]> wrote: Stephen Hemminger a écrit : On Thu, 07 Dec 2006 21:23:07 +0100 Eric Dumazet <[EMAIL PROTECTED]> wrote: Stephen Hemminger a écrit : The hard header cache is in the main output path, so usin

Re: [PATCH] convert hh_lock to seqlock

2006-12-07 Thread David Miller
From: Eric Dumazet <[EMAIL PROTECTED]> Date: Fri, 08 Dec 2006 00:02:44 +0100 > What's the problem with my suggestion of keeping hh_refcnt on > another cache line ? It is basically free (once your change from > rwlock to seqlock put in), and no change of algorithm. I think this change is worthwhi

Re: [PATCH] convert hh_lock to seqlock

2006-12-07 Thread Stephen Hemminger
On Thu, 07 Dec 2006 23:27:00 +0100 Eric Dumazet <[EMAIL PROTECTED]> wrote: > Stephen Hemminger a écrit : > > On Thu, 07 Dec 2006 21:23:07 +0100 > > Eric Dumazet <[EMAIL PROTECTED]> wrote: > > > >> Stephen Hemminger a écrit : > >>> The hard header cache is in the main output path, so using > >>> s

Re: [PATCH/RFC] make MII and PHYLIB independent of NET_ETHERNET

2006-12-07 Thread Randy Dunlap
> still didn't apply --- From: Randy Dunlap <[EMAIL PROTECTED]> PHYLIB can be used by non-NET_ETHERNET (10/100 ethernet) devices; e.g., GIANFAR (gigabit) uses it. We also have USB ethernet devices trying to use MII without NET_ETHERNET being enabled, so move MII outside of NET_ETHERNET, along wi

RE: [openib-general] [RFC] [PATCH V2 0/3] bonding support foroperation over IPoIB

2006-12-07 Thread Carl Yang \(caryang\)
Or, Can you please forward me (or to the email alias) "an example bonding sysfs script which can be used to set bonding to work with patches 1-3?" Thanks, Carl -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Or Gerlitz Sent: Thursday, November 30, 2006

Re: [PATCH] convert hh_lock to seqlock

2006-12-07 Thread Eric Dumazet
Stephen Hemminger a écrit : On Thu, 07 Dec 2006 21:23:07 +0100 Eric Dumazet <[EMAIL PROTECTED]> wrote: Stephen Hemminger a écrit : The hard header cache is in the main output path, so using seqlock instead of reader/writer lock should reduce overhead. Nice work Stephen, I am very interested.

Re: [PATCH][IPSEC][4/7] inter address family ipsec tunnel

2006-12-07 Thread David Miller
From: Kazunori MIYAZAWA <[EMAIL PROTECTED]> Date: Thu, 07 Dec 2006 20:23:48 +0900 > David Miller wrote: > > From: David Miller <[EMAIL PROTECTED]> > > Date: Wed, 06 Dec 2006 23:37:49 -0800 (PST) > > > >> From: Kazunori MIYAZAWA <[EMAIL PROTECTED]> > >> Date: Wed, 6 Dec 2006 20:35:37 +0900 > >> >

Re: [RFC] rfkill - Add support for input key to control wireless radio

2006-12-07 Thread Ivo van Doorn
Hi, > > > > 2 - Hardware key that does not control the hardware radio and does not > > > > report anything to userspace > > > > > > Kind of uninteresting button ;) > > > > And this is the button that rfkill was originally designed for. > > Laptops with integrated WiFi cards from Ralink have a ha

Re: [RFC] rfkill - Add support for input key to control wireless radio

2006-12-07 Thread Ivo van Doorn
Hi, > > > > 2 - Hardware key that does not control the hardware radio and does not > > > > report anything to userspace > > > > > > Kind of uninteresting button ;) > > > > And this is the button that rfkill was originally designed for. > > Laptops with integrated WiFi cards from Ralink have a

Re: [PATCH]: Fix netpoll arp_reply for multiple routers

2006-12-07 Thread Chris Lalancette
Chris Lalancette wrote: > All, > Attached is a patch to fix arp_reply when you have multiple possible > routers doing ARP requests to you. Currently arp_reply always replies to the > MAC address that it was given when it starts. However, if you have multiple > routers that can ARP request

Re: Marvell Libertas wifi

2006-12-07 Thread Dan Williams
On Thu, 2006-12-07 at 12:32 -0500, Alex Deucher wrote: > I just wanted to check on the status of the libertas driver from > Marvell for the OLPC project. I haven't really been able to find out The driver needs quite a bit of love. It's only been used for embedded devices so far and has quite a f

Re: [PATCH] convert hh_lock to seqlock

2006-12-07 Thread Stephen Hemminger
On Thu, 07 Dec 2006 21:23:07 +0100 Eric Dumazet <[EMAIL PROTECTED]> wrote: > Stephen Hemminger a écrit : > > The hard header cache is in the main output path, so using > > seqlock instead of reader/writer lock should reduce overhead. > > > > Nice work Stephen, I am very interested. > > Did you

Re: [PATCH] convert hh_lock to seqlock

2006-12-07 Thread Eric Dumazet
Stephen Hemminger a écrit : The hard header cache is in the main output path, so using seqlock instead of reader/writer lock should reduce overhead. Nice work Stephen, I am very interested. Did you benchmarked it ? I ask because I think hh_refcnt frequent changes may defeat the gain you want

Re: [PATCH] bonding: change spinlocks and remove timers in favor of workqueues

2006-12-07 Thread Jay Vosburgh
Andy Gospodarek <[EMAIL PROTECTED]> wrote: [...] >My patch actually only uses a single workqueue for each bond (almost >exactly like yours in-fact) with 4 different types of work that can be >placed on it. Well, what I was trying to say was that there are still multiple independently sched

Re: network devices don't handle pci_dma_mapping_error()'s

2006-12-07 Thread Stephen Hemminger
On Wed, 06 Dec 2006 23:24:59 -0800 (PST) David Miller <[EMAIL PROTECTED]> wrote: > From: "Amit S. Kale" <[EMAIL PROTECTED]> > Date: Thu, 7 Dec 2006 11:55:22 +0530 > > > We can let a driver handle dma mapping errors using these-> > > > > 1.Reduce the size of a receive ring. This will free some po

[PATCH 2/2] ucc_geth: Initialize mdio_lock.

2006-12-07 Thread Scott Wood
Signed-off-by: Scott Wood <[EMAIL PROTECTED]> --- drivers/net/ucc_geth.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/net/ucc_geth.c b/drivers/net/ucc_geth.c index 62d979b..8243150 100644 --- a/drivers/net/ucc_geth.c +++ b/drivers/net/ucc_geth.c @@ -1852,6 +185

[PATCH 1/2] ucc_geth: compilation error fixes

2006-12-07 Thread Scott Wood
Fix compilation failures when building the ucc_geth driver with spinlock debugging. Signed-off-by: Scott Wood <[EMAIL PROTECTED]> --- drivers/net/ucc_geth.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/ucc_geth.c b/drivers/net/ucc_geth.c index 1f05

[PATCH] convert hh_lock to seqlock

2006-12-07 Thread Stephen Hemminger
The hard header cache is in the main output path, so using seqlock instead of reader/writer lock should reduce overhead. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- include/linux/netdevice.h |2 +- include/net/neighbour.h | 18 ++ net/core/neighbour.c |

Re: [PATCH 3/16] Spidernet RX Locking

2006-12-07 Thread Linas Vepstas
On Thu, Dec 07, 2006 at 05:09:20AM -0500, Jeff Garzik wrote: > Linas Vepstas wrote: > >The RX packet handling can be called from several > >places, yet does not protect the rx ring structure. > >This patch places the ring buffer pointers under a lock. > > > >Signed-off-by: Linas Vepstas <[EMAIL PRO

Marvell Libertas wifi

2006-12-07 Thread Alex Deucher
I just wanted to check on the status of the libertas driver from Marvell for the OLPC project. I haven't really been able to find out much about this driver other than the commits to the olpc and infradead libertas git trees. The olpc laptop uses the usb interface and that seems to be what is su

Re: [PATCH 1/16] Spidernet DMA coalescing

2006-12-07 Thread Linas Vepstas
On Wed, Dec 06, 2006 at 11:08:47PM -0800, Andrew Morton wrote: > > It worries me when a patch series gets resent a few hours later. > > Did anything change? I did not resend this patch series. However, I did receive a large number of MTA errors: <[EMAIL PROTECTED]>: mail forwarding loop for

Re: [PATCH 2.6.19] AT91RM9200 Ethernet update 3

2006-12-07 Thread Stephen Hemminger
On 05 Dec 2006 09:29:52 +0200 Andrew Victor <[EMAIL PROTECTED]> wrote: > hi Stephen, > > > Use netdev_alloc_skb instead. It sets skb->dev so you don't have to. > > netdev_alloc_skb() seems to cause 2 function calls [__netdev_alloc_skb() > and __alloc_skb()], instead of just 1 for the dev_alloc_s

Re: [patch 7/7] d80211: do not pass an invalid key index to set_key()

2006-12-07 Thread David Kimdon
> Use HW_KEY_IDX_INVALID, please. oops, here you go (also fixed bad indentation): -- d80211: do not pass an invalid key index to set_key() If a hardware key has not been configured then there is no point to calling DISABLE_KEY. Signed-off-by: David Kimdon <[EMAIL PROTECTED]> Index: wirel

RE: drivers/net/chelsio/my3126.c: inconsequent NULL checking

2006-12-07 Thread Felix Marti
> Jesper Juhl <[EMAIL PROTECTED]> wrote: > On 07/12/06, Adrian Bunk <[EMAIL PROTECTED]> wrote: > > The Coverity checker spotted the following inconsequent NULL checking > > introduced by commit f1d3d38af75789f1b82969b83b69cab540609789: > > > > <-- snip --> > > > > ... > > static struct cphy *my3

[IPROUTE2 PATCH][U32] Fix missing class/flowid oddity

2006-12-07 Thread jamal
[U32] Fix missing class/flowid oddity When an action or policer is specified but not a classid/flowid, the syntax accepts it but the kernel never really hits it. This has been a long standing problem, but thanks to the persistence of Marco Berizzi <[EMAIL PROTECTED]> I broke down and fixed it. Si

[PATCH] prism54: set carrier flags correctly

2006-12-07 Thread Roy Marples
prism54 should set the carrier flags correctly when it thinks the link can be used. Signed-off-by: Roy Marples <[EMAIL PROTECTED]> --- a/drivers/net/wireless/prism54/isl_ioctl.c 2006-08-24 10:48:50.0 +0100 +++ b/drivers/net/wireless/prism54/isl_ioctl.c 2006-08-24 10:29:32.0 +

Re: drivers/net/chelsio/my3126.c: inconsequent NULL checking

2006-12-07 Thread Jesper Juhl
On 07/12/06, Adrian Bunk <[EMAIL PROTECTED]> wrote: The Coverity checker spotted the following inconsequent NULL checking introduced by commit f1d3d38af75789f1b82969b83b69cab540609789: <-- snip --> ... static struct cphy *my3126_phy_create(adapter_t *adapter, int phy_a

Re: [PATCH] bonding: change spinlocks and remove timers in favor of workqueues

2006-12-07 Thread Andy Gospodarek
On 12/7/06, Jay Vosburgh <[EMAIL PROTECTED]> wrote: I don't see a problem in starting with your patch; the end state will be sufficiently different (e.g., the four workqueues would ultimately be consolidated into one) that it's still a good testbed to start with. My patch actually only

Re: [RFC] rfkill - Add support for input key to control wireless radio

2006-12-07 Thread Dan Williams
On Wed, 2006-12-06 at 22:41 +0100, Ivo van Doorn wrote: > Hi, > > > > > That is my point. Given the fact that there are keys that are not > > > > directly connected with the radio switch userspace will have to handle > > > > them (wait for events then turn off radios somehow). You are > > > > advo

Re: network devices don't handle pci_dma_mapping_error()'s

2006-12-07 Thread Muli Ben-Yehuda
On Thu, Dec 07, 2006 at 11:48:14AM +0530, Amit S. Kale wrote: > On the x86_64 boxes that don't feature iommu functionality (because the > motherboard disables it or because Linux can't handle it) Linux bounce buffer > framework automatically comes into picture. Could we have the same framework

Re: [patch 6/7] d80211: fix invalid check for sub interface type AP

2006-12-07 Thread Jiri Benc
Patches 1 to 6 have been applied to my tree. Thanks, Jiri On Wed, 6 Dec 2006 16:45:32 -0800, David Kimdon wrote: > We should be checking the type member, not the raw pointer. > > Signed-off-by: David Kimdon <[EMAIL PROTECTED]> -- Jiri Benc SUSE Labs - To unsubscribe from this list: send the

Re: [patch 5/7] d80211: remove unused references to sub interface data

2006-12-07 Thread Johannes Berg
On Wed, 2006-12-06 at 16:45 -0800, David Kimdon wrote: > plain text document attachment (unused-sdata.patch) > In these three cases the pointer returned by IEEE80211_DEV_TO_SUB_IF() > is never used. Good catch, I must have introduced this when converting the prototypes. Thanks. johannes signatu

Re: [patch 7/7] d80211: do not pass an invalid key index to set_key()

2006-12-07 Thread Jiri Benc
On Wed, 6 Dec 2006 16:45:40 -0800, David Kimdon wrote: > Index: wireless-dev/net/d80211/ieee80211_ioctl.c > === > --- wireless-dev.orig/net/d80211/ieee80211_ioctl.c > +++ wireless-dev/net/d80211/ieee80211_ioctl.c > @@ -612,7 +612,7 @@

[git patches] net driver updates

2006-12-07 Thread Jeff Garzik
[just sent this upstream] Random schtuff. Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream-linus to receive the following updates: drivers/net/3c501.c|2 drivers/net/3c503.c

drivers/net/chelsio/my3126.c: inconsequent NULL checking

2006-12-07 Thread Adrian Bunk
The Coverity checker spotted the following inconsequent NULL checking introduced by commit f1d3d38af75789f1b82969b83b69cab540609789: <-- snip --> ... static struct cphy *my3126_phy_create(adapter_t *adapter, int phy_addr, struct mdio_ops *mdio_ops) { struct cphy

Re: Kernel header changes break glibc build

2006-12-07 Thread David Woodhouse
On Wed, 2006-12-06 at 15:23 +0100, Thomas Graf wrote: > > I'm suggesting that if you want to change things around as you did, you > > should make sure the users of those headers adapt to cope. You did fix > > the in-kernel users; you neglected to fix glibc -- and as far as I can > > tell you didn't

Re: [NETLINK]: Restore API compatibility of address and neighbour bits

2006-12-07 Thread David Woodhouse
On Thu, 2006-12-07 at 11:55 +0100, Thomas Graf wrote: > Restore API compatibility due to bits moved from rtnetlink.h to > separate headers. For 2.6.19.1 too, please. > Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> > > Index: net-2.6/include/linux/rtnetlink.h > ==

Re: [PATCH][IPSEC][4/7] inter address family ipsec tunnel

2006-12-07 Thread Kazunori MIYAZAWA
David Miller wrote: From: David Miller <[EMAIL PROTECTED]> Date: Wed, 06 Dec 2006 23:37:49 -0800 (PST) From: Kazunori MIYAZAWA <[EMAIL PROTECTED]> Date: Wed, 6 Dec 2006 20:35:37 +0900 BTW, I have a question about descrementing the reference count of rt->peer. The reference cound in normal "d

Re: NAPI and shared interrupt control

2006-12-07 Thread Benjamin Herrenschmidt
On Thu, 2006-12-07 at 02:22 -0800, Eugene Surovegin wrote: > On Thu, Dec 07, 2006 at 02:20:10AM -0800, David Miller wrote: > > It also just occured to me that even if you use the dummy device > > approach, it's the dummy device's quota that will be used by the > > generic ->poll() downcall into the

[NETLINK]: Restore API compatibility of address and neighbour bits

2006-12-07 Thread Thomas Graf
Restore API compatibility due to bits moved from rtnetlink.h to separate headers. Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Index: net-2.6/include/linux/rtnetlink.h === --- net-2.6.orig/include/linux/rtnetlink.h 2006-12-07

Re: Kernel header changes break glibc build

2006-12-07 Thread David Miller
From: Thomas Graf <[EMAIL PROTECTED]> Date: Thu, 7 Dec 2006 11:47:21 +0100 > * David Miller <[EMAIL PROTECTED]> 2006-12-06 16:56 > > That's enough for me. > > > > Thomas we need to restore things to how they were before. > > If that means including if_addr.h from rtnetlink.h so be it. > > > > We

Re: Kernel header changes break glibc build

2006-12-07 Thread Thomas Graf
* David Miller <[EMAIL PROTECTED]> 2006-12-06 16:56 > That's enough for me. > > Thomas we need to restore things to how they were before. > If that means including if_addr.h from rtnetlink.h so be it. > > We can't break shit like this, there are no excuses, especially > now that we properly frob

Re: 2.6.19: very low transmit speed after suspend/resume with Sky2

2006-12-07 Thread Tino Keitel
On Sat, Dec 02, 2006 at 13:16:28 -0800, Stephen Hemminger wrote: [...] > Most likely, the problem is similar to one I am working. The > device_resume code gets run before > BIOS. And the BIOS wakeup screws up the device. The proper fix will > happen in 2.6.20. Hum, are you talking about suspen

Re: NAPI and shared interrupt control

2006-12-07 Thread Eugene Surovegin
On Thu, Dec 07, 2006 at 02:20:10AM -0800, David Miller wrote: > It also just occured to me that even if you use the dummy device > approach, it's the dummy device's quota that will be used by the > generic ->poll() downcall into the driver. Yes, that's true. That's why I made this parameter Konfi

Re: NAPI and shared interrupt control

2006-12-07 Thread David Miller
From: Eugene Surovegin <[EMAIL PROTECTED]> Date: Thu, 7 Dec 2006 02:15:55 -0800 > On Thu, Dec 07, 2006 at 01:59:54AM -0800, David Miller wrote: > > From: Eugene Surovegin <[EMAIL PROTECTED]> > > Date: Thu, 7 Dec 2006 01:45:02 -0800 > > > > > I fail to see how this is not even more ugly and more c

Re: NAPI and shared interrupt control

2006-12-07 Thread Eugene Surovegin
On Thu, Dec 07, 2006 at 01:59:54AM -0800, David Miller wrote: > From: Eugene Surovegin <[EMAIL PROTECTED]> > Date: Thu, 7 Dec 2006 01:45:02 -0800 > > > I fail to see how this is not even more ugly and more complex than the > > solution we have right now. Instead of trivial "orthogonal" polling >

Re: [PATCH] netxen: sparse warning and ioctl bug fixes

2006-12-07 Thread Christoph Hellwig
On Tue, Dec 05, 2006 at 12:07:17PM -0800, Stephen Hemminger wrote: > Fix sparse warnings and get rid of casts that hide misuse > of __user pointers. There were two real bugs here: > * ioctl was copying uninitialized stack om NETXEN_NIC_NAME > * ioctl was dereferencing a user pointer > in n

Re: [PATCH 1/16] Spidernet DMA coalescing

2006-12-07 Thread Christoph Hellwig
On Wed, Dec 06, 2006 at 05:27:45PM -0600, Linas Vepstas wrote: > > The current driver code performs 512 DMA mappings of a bunch of > 32-byte structures. This is silly, as they are all in contiguous > memory. Ths patch changes the code to DMA map the entie area > with just one call. This is stil

Re: [PATCH 3/16] Spidernet RX Locking

2006-12-07 Thread Jeff Garzik
Linas Vepstas wrote: The RX packet handling can be called from several places, yet does not protect the rx ring structure. This patch places the ring buffer pointers under a lock. Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]> Cc: James K Lewis <[EMAIL PROTECTED]> Cc: Arnd Bergmann <[EMAIL PRO

Re: [PATCH 0/5] Pull request for 'r8169-upstream-20061204-00' tag

2006-12-07 Thread Jeff Garzik
Francois Romieu wrote: Please pull from tag 'r8169-upstream-20061204-00' in repository git://electric-eye.fr.zoreil.com/home/romieu/linux-2.6.git#r8169-upstream-20061204-00 pulled. please change your "please pull" email message to reflect something I can cut-n-paste directly to the command l

Re: Please pull 'upstream' branch of wireless-2.6

2006-12-07 Thread Jeff Garzik
John W. Linville wrote: The following changes since commit e62438630ca37539c8cc1553710bbfaa3cf960a7: Matthew Wilcox: Centralise definitions of sector_t and blkcnt_t are found in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.git upstream

Re: NAPI and shared interrupt control

2006-12-07 Thread David Miller
From: Eugene Surovegin <[EMAIL PROTECTED]> Date: Thu, 7 Dec 2006 01:45:02 -0800 > I fail to see how this is not even more ugly and more complex than the > solution we have right now. Instead of trivial "orthogonal" polling > code you are suggesting adding additional complexity - handle > dynami

Re: [PATCH] netxen: sparse warning and ioctl bug fixes

2006-12-07 Thread Jeff Garzik
Stephen Hemminger wrote: Fix sparse warnings and get rid of casts that hide misuse of __user pointers. There were two real bugs here: * ioctl was copying uninitialized stack om NETXEN_NIC_NAME * ioctl was dereferencing a user pointer in nettxen_nic_cmd_clear_stats. IMHO the ioctl usage

Re: [PATCH/RFC] make MII and PHYLIB independent of NET_ETHERNET

2006-12-07 Thread Jeff Garzik
Randy Dunlap wrote: On Thu, 30 Nov 2006 06:10:14 -0500 Jeff Garzik wrote: ACK, but patch doesn't apply to #upstream Does it work to patch -mm instead? (below) --- From: Randy Dunlap <[EMAIL PROTECTED]> PHYLIB can be used by non-NET_ETHERNET (10/100 ethernet) devices; e.g., GIANFAR (gigabit

Re: [PATCH] softmac: Fixed handling of deassociation from AP

2006-12-07 Thread Michael Buesch
On Thursday 07 December 2006 01:36, Larry Finger wrote: > it seems to > me that the mutex protects only the association data; whereas the spinlock > protects more data, but > does include the association data. Nope. The same way you could argue that the BKL should be taken here, as it's "the g

Re: NAPI and shared interrupt control

2006-12-07 Thread Eugene Surovegin
On Thu, Dec 07, 2006 at 01:16:27AM -0800, David Miller wrote: > From: Benjamin Herrenschmidt <[EMAIL PROTECTED]> > Date: Thu, 07 Dec 2006 15:24:06 +1100 > > > > > > What Eugene does currently, which seems to me like it's actually the > > > only proper solution, is to create a separate net_device

Re: [PATCH] netfilter: fix non-ANSI func. decl.

2006-12-07 Thread David Miller
From: Randy Dunlap <[EMAIL PROTECTED]> Date: Tue, 5 Dec 2006 19:37:13 -0800 > From: Randy Dunlap <[EMAIL PROTECTED]> > > Fix non-ANSI function declaration: > net/netfilter/nf_conntrack_core.c:1096:25: warning: non-ANSI function > declaration of function 'nf_conntrack_flush' > > Signed-off-by: R

Re: NAPI and shared interrupt control

2006-12-07 Thread David Miller
From: Benjamin Herrenschmidt <[EMAIL PROTECTED]> Date: Thu, 07 Dec 2006 15:24:06 +1100 > > > What Eugene does currently, which seems to me like it's actually the > > only proper solution, is to create a separate net_device structure for > > the DMA engine and thus have a single NAPI poll & weight

Re: [PATCH 7/7][TG3]: Identify Serdes devices more clearly.

2006-12-07 Thread Jeff Garzik
Michael Chan wrote: [TG3]: Identify Serdes devices more clearly. Change the message to more clearly identify Serdes devices. Update version to 3.70. ACK patches 1-7 - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordo

Re: [PATCH 4/7][TG3]: Allow partial speed advertisement.

2006-12-07 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Wed, 06 Dec 2006 23:46:47 -0800 > [TG3]: Allow partial speed advertisement. > > Honor the advertisement bitmask from ethtool. We used to always > advertise the full capability when autoneg was set to on. > > Signed-off-by: Michael Chan <[EMAIL PROT

Re: [PATCH 2/7][TG3]: Add 5787F device ID.

2006-12-07 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Wed, 06 Dec 2006 23:46:25 -0800 > [TG3]: Add 5787F device ID. > > Signed-off-by: Michael Chan <[EMAIL PROTECTED]> Applied, thanks. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More

Re: [PATCH 5/7][TG3]: Use netif_msg_*.

2006-12-07 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Wed, 06 Dec 2006 23:47:11 -0800 > [TG3]: Use netif_msg_*. > > Use netif_msg_* to turn on or off some messages. > > Based on Stephen Hemminger's initial patch. > > Signed-off-by: Michael Chan <[EMAIL PROTECTED]> Applied, thanks. - To unsubscribe fr

Re: [PATCH 1/7][TG3]: Fix Phy loopback.

2006-12-07 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Wed, 06 Dec 2006 23:46:06 -0800 > [TG3]: Fix Phy loopback. > > Phy loopback on most 10/100 devices need to be run in 1Gbps mode in > GMII mode. > > Signed-off-by: Michael Chan <[EMAIL PROTECTED]> Applied, thanks Michael. - To unsubscribe from this

Re: [PATCH 3/7][TG3]: Add TG3_FLG2_IS_NIC flag.

2006-12-07 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Wed, 06 Dec 2006 23:46:29 -0800 > [TG3]: Add TG3_FLG2_IS_NIC flag. > > Add Tg3_FLG2_IS_NIC flag to unambiguously determine whether the > device is NIC or onboard. Previously, the EEPROM_WRITE_PROT flag was > overloaded to also mean onboard. With th

Re: [PATCH 7/7][TG3]: Identify Serdes devices more clearly.

2006-12-07 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Wed, 06 Dec 2006 23:47:23 -0800 > [TG3]: Identify Serdes devices more clearly. > > Change the message to more clearly identify Serdes devices. > > Update version to 3.70. > > Signed-off-by: Michael Chan <[EMAIL PROTECTED]> Applied. Thanks Michael

Re: [PATCH 6/7][TG3]: Use msleep.

2006-12-07 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Wed, 06 Dec 2006 23:47:17 -0800 > [TG3]: Use msleep. > > Change some udelay() in some eeprom functions to msleep(). Eeprom > related functions are always called from sleepable context. > > Signed-off-by: Michael Chan <[EMAIL PROTECTED]> Applied.

Re: [RFC] memory barrier cleanups

2006-12-07 Thread David Miller
From: Ralf Baechle <[EMAIL PROTECTED]> Date: Wed, 6 Dec 2006 21:49:46 + > I believe all the below memory barriers only matter on SMP so therefore > the smp_* variant of the barrier should be used. > > I'm wondering if the barrier in net/ipv4/inet_timewait_sock.c should be > dropped entirely.