Re: [RFC] remove NLA_STRING NUL trimming

2007-03-23 Thread Thomas Graf
* Johannes Berg [EMAIL PROTECTED] 2007-03-23 00:12 Looking through the netlink/attr.c code I noticed that NLA_STRING attributes that end with a binary NUL have it removed before passing it to the consumer. It's not really removed, the trailing NUL is just ignored when checking the length of

Re: [NET_SCHED 11/11]: qdisc: avoid dequeue while throttled

2007-03-23 Thread Patrick McHardy
Patrick McHardy wrote: [NET_SCHED]: qdisc: avoid dequeue while throttled It just occured to me that this doesn't work properly with qdiscs that have multiple classes since they all don't properly maintain the TCQ_F_THROTTLED flag. They set it on dequeue when no active class is willing to give

Re: [RFC] remove NLA_STRING NUL trimming

2007-03-23 Thread Johannes Berg
On Fri, 2007-03-23 at 15:20 +0100, Thomas Graf wrote: It's not really removed, the trailing NUL is just ignored when checking the length of the attribute. Good point. This is needed for older netlink families where strings are not always NUL terminated, yet we still need to accept the

Re: [NET_SCHED 11/11]: qdisc: avoid dequeue while throttled

2007-03-23 Thread Patrick McHardy
Patrick McHardy wrote: [NET_SCHED]: qdisc: avoid dequeue while throttled It just occured to me that this doesn't work properly with qdiscs that have multiple classes since they all don't properly maintain the TCQ_F_THROTTLED flag. They set it on dequeue when no active class is willing to

[PATCH] netlink: introduce NLA_BINARY type

2007-03-23 Thread Johannes Berg
This patch introduces a new NLA_BINARY attribute policy type with the verification of simply checking the maximum length of the payload. It also fixes a small typo in the example. Signed-off-by: Johannes Berg [EMAIL PROTECTED] Cc: Thomas Graf [EMAIL PROTECTED] Cc: netdev@vger.kernel.org ---

Re: [PATCH] netlink: introduce NLA_BINARY type

2007-03-23 Thread Thomas Graf
* Johannes Berg [EMAIL PROTECTED] 2007-03-23 16:02 This patch introduces a new NLA_BINARY attribute policy type with the verification of simply checking the maximum length of the payload. It also fixes a small typo in the example. Signed-off-by: Johannes Berg [EMAIL PROTECTED] Cc: Thomas

Re: [PATCH] Fix use of uninitialized field in mv643xx_eth

2007-03-23 Thread Dale Farnsworth
On Fri, Mar 23, 2007 at 01:30:02PM +0100, Gabriel Paubert wrote: In this driver, the default ethernet address is first set by by calling eth_port_uc_addr_get() which reads the relevant registers of the corresponding port as initially set by firmware. However that function used the port_num

[PATCH][SCTP]: Update SCTP Maintainers entry

2007-03-23 Thread Sridhar Samudrala
Dave, I have asked Vlad Yasevich to take over the role of primary maintainer of SCTP and he has accepted it. He has been contributing to SCTP for more than 2 years and has become more active than me in the past year. Thanks Sridhar [SCTP]: Update SCTP Maintainers entry Add Vlad Yasevich as

Re: [NET_SCHED 01/11]: sch_netem: fix off-by-one in send time comparison

2007-03-23 Thread Stephen Hemminger
On Fri, 23 Mar 2007 14:35:40 +0100 (MET) Patrick McHardy [EMAIL PROTECTED] wrote: [NET_SCHED]: sch_netem: fix off-by-one in send time comparison netem checks PSCHED_TLESS(cb-time_to_send, now) to find out whether it is allowed to send a packet, which is equivalent to cb-time_to_send now.

Re: [PATCH]: Add security check before flushing SAD/SPD

2007-03-23 Thread Joy Latten
On Fri, 2007-03-23 at 01:39 -0400, Eric Paris wrote: In either case though proper auditing needs to be addressed. I see that the first patch from Joy wouldn't audit deletion failures. It appears to me if the check is done per policy then the security hook return code needs to be recorded

Re: [PATCH]: Add security check before flushing SAD/SPD

2007-03-23 Thread Eric Paris
On Fri, 2007-03-23 at 10:33 -0600, Joy Latten wrote: On Fri, 2007-03-23 at 01:39 -0400, Eric Paris wrote: In either case though proper auditing needs to be addressed. I see that the first patch from Joy wouldn't audit deletion failures. It appears to me if the check is done per

[PATCH] NAPI support for Sibyte MAC

2007-03-23 Thread mason
[ This is a re-post, but the patch still applies and works fine against the linux-mips.org tip. We'd really like to get this in. -Mark] This patch completes the NAPI functionality for SB1250 MAC, including making NAPI a kernel option that can be turned on or off and adds the sbmac_poll

Re: Recent net-2.6.22 patches break bootup!

2007-03-23 Thread Stephen Hemminger
On Thu, 22 Mar 2007 21:41:23 -0700 (PDT) David Miller [EMAIL PROTECTED] wrote: From: Thomas Graf [EMAIL PROTECTED] Date: Fri, 23 Mar 2007 00:47:04 +0100 * Stephen Hemminger [EMAIL PROTECTED] 2007-03-22 14:27 Something is broken now. If I boot the system (Fedora) it gets to:

Re: [NET_SCHED 11/11]: qdisc: avoid dequeue while throttled

2007-03-23 Thread David Miller
From: Patrick McHardy [EMAIL PROTECTED] Date: Fri, 23 Mar 2007 15:57:08 +0100 I found another case that doesn't work properly, so let me retract this patch until I've properly thought this through. Ok, I'll apply the rest. - To unsubscribe from this list: send the line unsubscribe netdev in

Re: [NET_SCHED 00/11]: pkt_sched.h cleanup + misc changes

2007-03-23 Thread David Miller
From: Patrick McHardy [EMAIL PROTECTED] Date: Fri, 23 Mar 2007 14:35:38 +0100 (MET) These patches fix an off-by-one in netem, clean up pkt_sched.h by removing most of the now unnecessary PSCHED time macros and turning the two remaining ones into inline functions, consolidate some common filter

Re: [PATH 0/6] New SCTP functionality for 2.6.22

2007-03-23 Thread David Miller
From: Vlad Yasevich [EMAIL PROTECTED] Date: Fri, 23 Mar 2007 09:52:46 -0400 This patch series implements additional SCTP socket options. This was originally submitted too late for 2.6.21, so I am re-submitting for 2.6.22. Please consider applying. All 6 patches applied, thanks Vlad. -

Re: [PATCH] netlink: introduce NLA_BINARY type

2007-03-23 Thread David Miller
From: Thomas Graf [EMAIL PROTECTED] Date: Fri, 23 Mar 2007 16:13:24 +0100 * Johannes Berg [EMAIL PROTECTED] 2007-03-23 16:02 This patch introduces a new NLA_BINARY attribute policy type with the verification of simply checking the maximum length of the payload. It also fixes a small

Re: [PATCH][SCTP]: Update SCTP Maintainers entry

2007-03-23 Thread David Miller
From: Sridhar Samudrala [EMAIL PROTECTED] Date: Fri, 23 Mar 2007 09:28:30 -0700 I have asked Vlad Yasevich to take over the role of primary maintainer of SCTP and he has accepted it. He has been contributing to SCTP for more than 2 years and has become more active than me in the past year.

Re: [PATCH]: Add security check before flushing SAD/SPD

2007-03-23 Thread James Morris
On Fri, 23 Mar 2007, Eric Paris wrote: Maybe I'm way out on a limb here but if I am a regular user and I say rm /tmp/* and I only have permissions to delete some of the files I expect just those couple to be delete, not the whole operation denied. I don't think this analogy holds up, as rm is

Re: RFC: Established connections hash function

2007-03-23 Thread David Miller
From: Eric Dumazet [EMAIL PROTECTED] Date: Fri, 23 Mar 2007 09:00:08 +0100 I dont consider this new hash as bug fix at all, ie your patch might enter 2.6.22 normal dev cycle. Ok, I checked the patch into net-2.6.22 - To unsubscribe from this list: send the line unsubscribe netdev in the body

Re: [PATCH]: Add security check before flushing SAD/SPD

2007-03-23 Thread David Miller
From: James Morris [EMAIL PROTECTED] Date: Fri, 23 Mar 2007 14:46:48 -0400 (EDT) A 'flush' has a semantic implication that all entries will be removed, and it should be atomic and either succeed or fail at that granularity. Correct. - To unsubscribe from this list: send the line unsubscribe

Re: VIA Velocity VLAN vexation

2007-03-23 Thread linux
Or should I just get a different gigabit card ? This one probably got answered the 2005/11/29. :o) Ah, that's where I asked before. I misplaced the e-mail. I hope you don't mind my asking every year or two. But I don't see any suggestions for an alternative gigabit card anywhere. I had

Re: [PATCH]: Add security check before flushing SAD/SPD

2007-03-23 Thread Eric Paris
On Fri, 2007-03-23 at 11:47 -0700, David Miller wrote: From: James Morris [EMAIL PROTECTED] Date: Fri, 23 Mar 2007 14:46:48 -0400 (EDT) A 'flush' has a semantic implication that all entries will be removed, and it should be atomic and either succeed or fail at that granularity.

[PATCH 1/2] mv643xx_eth: Fix use of uninitialized port_num field

2007-03-23 Thread Dale Farnsworth
From: Gabriel Paubert [EMAIL PROTECTED] In this driver, the default ethernet address is first set by by calling eth_port_uc_addr_get() which reads the relevant registers of the corresponding port as initially set by firmware. However that function used the port_num field accessed through the

Re: [PATCH]: Add security check before flushing SAD/SPD

2007-03-23 Thread Joy Latten
On Fri, 2007-03-23 at 12:59 -0400, Eric Paris wrote: On Fri, 2007-03-23 at 10:33 -0600, Joy Latten wrote: On Fri, 2007-03-23 at 01:39 -0400, Eric Paris wrote: In either case though proper auditing needs to be addressed. I see that the first patch from Joy wouldn't audit deletion

[PATCH 2/2] mv643xx_eth: make eth_port_uc_addr_{get,set}() calls symmetric

2007-03-23 Thread Dale Farnsworth
From: Gabriel Paubert [EMAIL PROTECTED] There is no good reason for the asymmetry in the parameters of eth_port_uc_addr_get() and eth_port_uc_addr_set(). Make them symmetric. Remove some gratuitous block comments while we're here. Signed-off-by: Gabriel Paubert [EMAIL PROTECTED] Signed-off-by:

[PATCH] tcp: cubic update for net-2.6.22

2007-03-23 Thread Stephen Hemminger
The following update received from Injong updates TCP cubic to the latest version. I am running more complete tests and will have results after 4/1. According to Injong: the new version improves on its scalability, fairness and stability. So in all properties, we confirmed it shows better

[PATCH] tcp_probe: improvements for net-2.6.22

2007-03-23 Thread Stephen Hemminger
Change tcp_probe to use ktime (needed to add one export). Add option to only get events when cwnd changes - from Doug Leith Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- kernel/time.c|1 + net/ipv4/tcp_probe.c | 68 - 2 files

Re: VIA Velocity VLAN vexation

2007-03-23 Thread Francois Romieu
[EMAIL PROTECTED] [EMAIL PROTECTED] : [...] But I don't see any suggestions for an alternative gigabit card anywhere. I had assumed they all mostly worked, but now it appears I need to know details. Mostly. Assuming you won't play with huge jumbo frames, I'd suggest a plain old pci 8169 (not

[PATCH 1/2] forcedeth: fix nic poll

2007-03-23 Thread Ayaz Abdulla
The nic poll routine was missing the call to the optimized irq routine. This patch adds the missing call for the optimized path. See http://bugzilla.kernel.org/show_bug.cgi?id=7950 for more information. Signed-Off-By: Ayaz Abdulla [EMAIL PROTECTED] --- orig/drivers/net/forcedeth.c

[PATCH 2/2] forcedeth: fix tx timeout

2007-03-23 Thread Ayaz Abdulla
The tx timeout routine was waking the tx queue conditionally. However, it must call it unconditionally since the dev_watchdog has halted the tx queue before calling the timeout function. Signed-Off-By: Ayaz Abdulla [EMAIL PROTECTED] --- orig/drivers/net/forcedeth.c2007-03-11

[PATCH 3/5 2.6.21-rc4] l2tp: pppox protocol module load

2007-03-23 Thread James Chapman
[PPPOL2TP]: Add the ability to autoload a pppox protocol module. This patch allows a name pppox-proto-nnn to be used in modprobe.conf to autoload a driver for PPPoX protocol nnn. Signed-off-by: James Chapman [EMAIL PROTECTED] Index: linux-2.6.21-rc4/drivers/net/pppox.c

[PATCH 4/5 2.6.21-rc4] l2tp: pppol2tp kbuild changes

2007-03-23 Thread James Chapman
[PPPOL2TP]: Modify kbuild for the new pppol2tp driver. This patch adds a new config option, CONFIG_PPPOL2TP and adds if_pppol2tp.h to the list of exported headers. Signed-off-by: James Chapman [EMAIL PROTECTED] Index: linux-2.6.21-rc4/drivers/net/Kconfig

[PATCH 5/5 2.6.21-rc4] l2tp: add pppol2tp maintainer

2007-03-23 Thread James Chapman
[PPPOL2TP]: Update maintainers file for PPP over L2TP. Signed-off-by: James Chapman [EMAIL PROTECTED] Index: linux-2.6.21-rc4/MAINTAINERS === --- linux-2.6.21-rc4.orig/MAINTAINERS +++ linux-2.6.21-rc4/MAINTAINERS @@ -2700,6 +2700,11

[PATCH]: SAD sometimes has double SAs.

2007-03-23 Thread Joy Latten
Last Friday I proposed creating larval SAs to act as placeholders to prevent a second acquire resulting in double SAs being created. I tried this and so far I have not seen any double SAs being created. I also plan to run some stress tests over the weekend. Please let me know what improvements

Re: [PATCH]: SAD sometimes has double SAs.

2007-03-23 Thread David Miller
From: Joy Latten [EMAIL PROTECTED] Date: Fri, 23 Mar 2007 16:58:20 -0600 Last Friday I proposed creating larval SAs to act as placeholders to prevent a second acquire resulting in double SAs being created. I tried this and so far I have not seen any double SAs being created. I also plan to

[TG3 1/3]: Eliminate the unused TG3_FLAG_SPLIT_MODE flag.

2007-03-23 Thread Michael Chan
[TG3]: Eliminate the unused TG3_FLAG_SPLIT_MODE flag. This flag to support multiple PCIX split completions was never used because of hardware bugs. This will make room for a new flag. Signed-off-by: Michael Chan [EMAIL PROTECTED] diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c index

[TG3 2/3]: Exit irq handler during chip reset.

2007-03-23 Thread Michael Chan
[TG3]: Exit irq handler during chip reset. On most tg3 chips, the memory enable bit in the PCI command register gets cleared during chip reset and must be restored before accessing PCI registers using memory cycles. The chip does not generate interrupt during chip reset, but the irq handler can

[TG3 3/3]: Update version and reldate.

2007-03-23 Thread Michael Chan
[TG3]: Update version and reldate. Update version to 3.75. Signed-off-by: Michael Chan [EMAIL PROTECTED] diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c index 9aca100..e682f90 100644 --- a/drivers/net/tg3.c +++ b/drivers/net/tg3.c @@ -64,8 +64,8 @@ #define DRV_MODULE_NAME

Re: [irda-users] [2.6.20-rt8] Neighbour table overflow.

2007-03-23 Thread Samuel Ortiz
On Fri, Mar 23, 2007 at 01:14:43PM +0100, Guennadi Liakhovetski wrote: On Wed, 21 Mar 2007, Guennadi Liakhovetski wrote: On Wed, 21 Mar 2007, Samuel Ortiz wrote: I'm quite sure the leak is in the IrDA code rather than in the ppp or ipv4 one, hence the need for full irda debug...

[PATCH 0/3] [NET] MTU discovery changes

2007-03-23 Thread John Heffner
These are a few changes to fix/clean up some of the MTU discovery processing with non-stream sockets, and add a probing mode. See also matching patches to tracepath to take advantage of this. -John - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to

[PATCH 1/3] [NET] Do pmtu check in transport layer

2007-03-23 Thread John Heffner
Check the pmtu check at the transport layer (for UDP, ICMP and raw), and send a local error if socket is PMTUDISC_DO and packet is too big. This is actually a pure bugfix for ipv6. For ipv4, it allows us to do pmtu checks in the same way as for ipv6. Signed-off-by: John Heffner [EMAIL

[PATCH 2/3] [NET] Move DF check to ip_forward

2007-03-23 Thread John Heffner
Do fragmentation check in ip_forward, similar to ipv6 forwarding. Also add a debug printk in the DF check in ip_fragment since we should now never reach it. Signed-off-by: John Heffner [EMAIL PROTECTED] --- net/ipv4/ip_forward.c |8 net/ipv4/ip_output.c |2 ++ 2 files changed,

[PATCH 3/3] [NET] Add IP(V6)_PMTUDISC_RPOBE

2007-03-23 Thread John Heffner
Add IP(V6)_PMTUDISC_PROBE value for IP(V6)_MTU_DISCOVER. This option forces us not to fragment, but does not make use of the kernel path MTU discovery. That is, it allows for user-mode MTU probing (or, packetization-layer path MTU discovery). This is particularly useful for diagnostic

[PATCH 0/2] [iputils] MTU discovery changes

2007-03-23 Thread John Heffner
These add some changes that make tracepath a little more useful for diagnosing MTU issues. The length flag helps distinguish between MTU black holes and other types of black holes by allowing you to vary the probe packet lengths. Using PMTUDISC_PROBE gives you the same results on each run

[PATCH 2/2] [iputils] Use PMTUDISC_PROBE mode if it exists.

2007-03-23 Thread John Heffner
Signed-off-by: John Heffner [EMAIL PROTECTED] --- tracepath.c | 10 -- tracepath6.c | 10 -- 2 files changed, 16 insertions(+), 4 deletions(-) diff --git a/tracepath.c b/tracepath.c index 1f901ba..a562d88 100644 --- a/tracepath.c +++ b/tracepath.c @@ -24,6 +24,10 @@

[PATCH] ehea: removing unused functionality

2007-03-23 Thread Jan-Bernd Themann
This patch includes: - removal of unused fields in structs - ethtool statistics cleanup - removes unsed functionality from send path Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED] --- This patch applies on top of the netdev upstream branch for 2.6.22 drivers/net/ehea/ehea.h |

Re: [git patches] net driver fixes

2007-03-23 Thread Guennadi Liakhovetski
Jeff, might be worth getting the sk_buff leak fix in ppp from http://www.spinics.net/lists/netdev/msg27706.html in 2.6.21 too? Don't know how important it is for stable. It was present in 2.6.18 too. Thanks Guennadi --- Guennadi Liakhovetski - To unsubscribe from this list: send the line

[5/5] 2.6.21-rc4: known regressions (v2)

2007-03-23 Thread Adrian Bunk
This email lists some known regressions in Linus' tree compared to 2.6.20. If you find your name in the Cc header, you are either submitter of one of the bugs, maintainer of an affectected subsystem or driver, a patch of you caused a breakage or I'm considering you in any other way possibly

Re: RFC: Established connections hash function

2007-03-23 Thread David Miller
From: Eric Dumazet [EMAIL PROTECTED] Date: Thu, 22 Mar 2007 23:03:04 +0100 David Miller a écrit : From: Nikolaos D. Bougalis [EMAIL PROTECTED] Date: Thu, 22 Mar 2007 12:44:09 -0700 People _have_ had problems. _I_ have had problems. And when someone with a few thousand drones under

Re: L2TP support?

2007-03-23 Thread Jorge Boncompte [DTI2]
- Original Message - From: James Chapman [EMAIL PROTECTED] To: Ingo Oeser [EMAIL PROTECTED] Cc: netdev@vger.kernel.org Sent: Thursday, March 22, 2007 9:13 PM Subject: Re: L2TP support? Yes there is. There's a pppd plugin which comes with the openl2tp project,

Re: RFC: Established connections hash function

2007-03-23 Thread Evgeniy Polyakov
On Thu, Mar 22, 2007 at 01:53:03PM -0700, Nikolaos D. Bougalis ([EMAIL PROTECTED]) wrote: Grrr, I think I pointed several times already, that properly distributed values do not change distribution after folding. And it can be seen in all tests (and in that you pointed too). Yes, I agree

Re: RFC: Established connections hash function

2007-03-23 Thread Eric Dumazet
David Miller a écrit : From: Eric Dumazet [EMAIL PROTECTED] Welcome to the club :) Ok, how about we put something like the following into 2.6.21? 2.6.21 really ? Just to be clear : I had an attack two years ago, I applied your patch, rebooted the machine, and since then the attackers

Re: RFC: Established connections hash function

2007-03-23 Thread Evgeniy Polyakov
On Thu, Mar 22, 2007 at 01:58:34PM -0700, David Miller ([EMAIL PROTECTED]) wrote: From: Nikolaos D. Bougalis [EMAIL PROTECTED] Date: Thu, 22 Mar 2007 12:44:09 -0700 People _have_ had problems. _I_ have had problems. And when someone with a few thousand drones under his control hoses

Re: RFC: Established connections hash function

2007-03-23 Thread Eric Dumazet
Evgeniy Polyakov a ecrit : Call me a loooser which mail will be deleted on arrival, but... jhash_2words(const, const, ((const 16) | $sport) ^ $random) where $sport is 1-65535 in a loop, and $random is pseudo-random number obtained on start. Which is exactly the case of web server and

Re: RFC: Established connections hash function

2007-03-23 Thread Evgeniy Polyakov
On Fri, Mar 23, 2007 at 09:17:19AM +0100, Eric Dumazet ([EMAIL PROTECTED]) wrote: You have a machine somewhere that allows 65536 concurrent connections coming from the same IP address ? Attached png file of botnet scenario: 1000 addresses from the same network (class B for example), each one

Re: RFC: Established connections hash function

2007-03-23 Thread Evgeniy Polyakov
On Fri, Mar 23, 2007 at 11:33:32AM +0300, Evgeniy Polyakov ([EMAIL PROTECTED]) wrote: Eric, I agree, that XOR hash is not perfect, and it should be changed, but not blindly. Attached case of how broken can be xor in botnet scenario. -- Evgeniy Polyakov jhash_good.png Description:

Re: [PATCH 4/5] netem: avoid excessive requeues

2007-03-23 Thread Patrick McHardy
David Miller wrote: From: Patrick McHardy [EMAIL PROTECTED] Date: Thu, 22 Mar 2007 21:40:43 +0100 Perhaps we should put this in qdisc_restart, other qdiscs have the same problem. Agreed, patches welcome :) I've tried this, but for some reason it makes TBF stay about 5% under the

XOR hash beauty solved [Was: RFC: Established connections hash function]

2007-03-23 Thread Evgeniy Polyakov
Please, do not apply patch as is, I will devote this day to find where jenkins has problems and try to fix distribution. If I will fail, then it is up to you to decide that above results are bad or good. I need to admit that I was partially wrong in my analysis of the Jenkins hash distribution

Re: [irda-users] [2.6.20-rt8] Neighbour table overflow.

2007-03-23 Thread Guennadi Liakhovetski
On Wed, 21 Mar 2007, Guennadi Liakhovetski wrote: On Wed, 21 Mar 2007, Samuel Ortiz wrote: I'm quite sure the leak is in the IrDA code rather than in the ppp or ipv4 one, hence the need for full irda debug... Well, looks like you were wrong, Samuel. Below is a patch that fixes ONE sk_buff

Re: RFC: Established connections hash function

2007-03-23 Thread Nikolaos D. Bougalis
Let me start off by saying that I hope I didn't come across as condenscending in my previous posts. If I did, then it wasn't intended. Now, on to more important things :) jhash_2words(const, const, ((const 16) | $sport) ^ $random) where $sport is 1-65535 in a loop, and $random is

[PATCH] Fix use of uninitialized field in mv643xx_eth

2007-03-23 Thread Gabriel Paubert
In this driver, the default ethernet address is first set by by calling eth_port_uc_addr_get() which reads the relevant registers of the corresponding port as initially set by firmware. However that function used the port_num field accessed through the private area of net_dev before it was set.

Re: XOR hash beauty solved [Was: RFC: Established connections hash function]

2007-03-23 Thread Nikolaos D. Bougalis
So, briefly saying, jhash_2/3words have safe distribution, but have higher-number of elements waves as a result of folding which is unavoidable for general-purpose hash. Thanks for the analysis. -n - To unsubscribe from this list: send the line unsubscribe netdev in the body of a

Re: [PATCH 1/1][PKT_CLS] Avoid multiple tree locks

2007-03-23 Thread jamal
On Thu, 2007-22-03 at 12:36 +0100, Patrick McHardy wrote: jamal wrote: On Wed, 2007-21-03 at 15:04 +0100, Patrick McHardy wrote: We can remove qdisc_tree_lock since with this patch all changes and all tree walking happen under the RTNL. We still need to keep dev-queue_lock for the data

[NET_SCHED 00/11]: pkt_sched.h cleanup + misc changes

2007-03-23 Thread Patrick McHardy
These patches fix an off-by-one in netem, clean up pkt_sched.h by removing most of the now unnecessary PSCHED time macros and turning the two remaining ones into inline functions, consolidate some common filter destruction code and move the TCQ_F_THROTTLED optimization from netem to qdisc_restart.

[NET_SCHED 01/11]: sch_netem: fix off-by-one in send time comparison

2007-03-23 Thread Patrick McHardy
[NET_SCHED]: sch_netem: fix off-by-one in send time comparison netem checks PSCHED_TLESS(cb-time_to_send, now) to find out whether it is allowed to send a packet, which is equivalent to cb-time_to_send now. Use !PSCHED_TLESS(now, cb-time_to_send) instead to properly handle cb-time_to_send ==

[NET_SCHED 02/11]: kill PSCHED_AUDIT_TDIFF

2007-03-23 Thread Patrick McHardy
[NET_SCHED]: kill PSCHED_AUDIT_TDIFF Signed-off-by: Patrick McHardy [EMAIL PROTECTED] --- commit 4a4a3d59dca71f202ab063b909c84c96c8ea09a7 tree 4958bfec571a3330bd023ebe50f7b071f6dc7dd7 parent 9f8c07452088f432c79ac3a8d87d6adebcce57df author Patrick McHardy [EMAIL PROTECTED] Thu, 22 Mar 2007

[NET_SCHED 05/11]: kill PSCHED_SET_PASTPERFECT/PSCHED_IS_PASTPERFECT

2007-03-23 Thread Patrick McHardy
[NET_SCHED]: kill PSCHED_SET_PASTPERFECT/PSCHED_IS_PASTPERFECT Use direct assignment and comparison instead. Signed-off-by: Patrick McHardy [EMAIL PROTECTED] --- commit ec252ac5640ea38d3630cdb97333c398a75391b9 tree bce7b2c63ffb0694942484418f1adf08ed78292d parent

[NET_SCHED 07/11]: turn PSCHED_TDIFF_SAFE into inline function

2007-03-23 Thread Patrick McHardy
[NET_SCHED]: turn PSCHED_TDIFF_SAFE into inline function Also rename to psched_tdiff_bounded. Signed-off-by: Patrick McHardy [EMAIL PROTECTED] --- commit c86b236046f7de4094ceb2b2cb069c32969ee36c tree 27c99a0d619bcabf384838adeae3c0469472b86b parent d72d57707edf96c31e62da0841faf59c011dcd92 author

[NET_SCHED 06/11]: kill PSCHED_TDIFF

2007-03-23 Thread Patrick McHardy
[NET_SCHED]: kill PSCHED_TDIFF Signed-off-by: Patrick McHardy [EMAIL PROTECTED] --- commit d72d57707edf96c31e62da0841faf59c011dcd92 tree 8b6192c94e025fb8b6e1be3b02526d4792bd4fa1 parent ec252ac5640ea38d3630cdb97333c398a75391b9 author Patrick McHardy [EMAIL PROTECTED] Fri, 23 Mar 2007 00:01:47

[NET_SCHED 09/11]: Unline tcf_destroy

2007-03-23 Thread Patrick McHardy
[NET_SCHED]: Unline tcf_destroy Uninline tcf_destroy and add a helper function to destroy an entire filter chain. Signed-off-by: Patrick McHardy [EMAIL PROTECTED] --- commit 8da4bcec7e54c8344c8fd77c72a61f24ce12cfc3 tree 7f36f4af8e9413637fb9b65501f281fd8a915da3 parent

[NET_SCHED 03/11]: kill PSCHED_TADD/PSCHED_TADD2

2007-03-23 Thread Patrick McHardy
[NET_SCHED]: kill PSCHED_TADD/PSCHED_TADD2 Signed-off-by: Patrick McHardy [EMAIL PROTECTED] --- commit 145a1a6010c6b852ffab28c110d8911a6161aa8b tree 84b7bf284ea3b870a9b5fd9dae3adaad9979dc26 parent 4a4a3d59dca71f202ab063b909c84c96c8ea09a7 author Patrick McHardy [EMAIL PROTECTED] Thu, 22 Mar 2007

[NET_SCHED 08/11]: turn PSCHED_GET_TIME into inline function

2007-03-23 Thread Patrick McHardy
[NET_SCHED]: turn PSCHED_GET_TIME into inline function Signed-off-by: Patrick McHardy [EMAIL PROTECTED] --- commit 231788aa3b9eef85b72ecac2e33441bd842ce3f4 tree f302e509ec32a86bc9a6c3712d188fc91455a213 parent c86b236046f7de4094ceb2b2cb069c32969ee36c author Patrick McHardy [EMAIL PROTECTED] Fri,

[NET_SCHED 04/11]: kill PSCHED_TLESS

2007-03-23 Thread Patrick McHardy
[NET_SCHED]: kill PSCHED_TLESS Signed-off-by: Patrick McHardy [EMAIL PROTECTED] --- commit 4f8fc418f88c0b7ee6e726b05f27c42d8e20593c tree c70508f2e0174aef42aaf99bf0cef4184d7ed07e parent 145a1a6010c6b852ffab28c110d8911a6161aa8b author Patrick McHardy [EMAIL PROTECTED] Fri, 23 Mar 2007 00:00:55

[RFC] remove NLA_STRING NUL trimming

2007-03-23 Thread Johannes Berg
Looking through the netlink/attr.c code I noticed that NLA_STRING attributes that end with a binary NUL have it removed before passing it to the consumer. For wireless, we have a few places where we need to be able to accept any (even binary) values, for example for the SSID; the SSID can validly

[PATH 0/6] New SCTP functionality for 2.6.22

2007-03-23 Thread Vlad Yasevich
This patch series implements additional SCTP socket options. This was originally submitted too late for 2.6.21, so I am re-submitting for 2.6.22. Please consider applying. Thanks -vlad - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL

[PATCH 2/6] [SCTP] Implement SCTP_PARTIAL_DELIVERY_POINT option.

2007-03-23 Thread Vlad Yasevich
This option induces partial delivery to run as soon as the specified amount of data has been accumulated on the association. However, we give preference to fully reassembled messages over PD messages. In any case, window and buffer is freed up. Signed-off-by: Vlad Yasevich [EMAIL PROTECTED] ---

[PATCH 5/6] [SCTP] Implement sac_info field in SCTP_ASSOC_CHANGE notification.

2007-03-23 Thread Vlad Yasevich
As stated in the sctp socket api draft: sac_info: variable If the sac_state is SCTP_COMM_LOST and an ABORT chunk was received for this association, sac_info[] contains the complete ABORT chunk as defined in the SCTP specification RFC2960 [RFC2960] section 3.3.7. We now save received

[PATCH 4/6] [SCTP] Honor flags when setting peer address parameters

2007-03-23 Thread Vlad Yasevich
Parameters only take effect when a corresponding flag bit is set and a value is specified. This means we need to check the flags in addition to checking for non-zero value. Signed-off-by: Vlad Yasevich [EMAIL PROTECTED] --- include/net/sctp/user.h | 15 +++-- net/sctp/socket.c |

[PATCH 3/6] [SCTP]: Implement SCTP_ADDR_CONFIRMED state for ADDR_CHNAGE event

2007-03-23 Thread Vlad Yasevich
Signed-off-by: Vlad Yasevich [EMAIL PROTECTED] --- include/net/sctp/user.h |1 + net/sctp/associola.c| 10 +- 2 files changed, 10 insertions(+), 1 deletions(-) diff --git a/include/net/sctp/user.h b/include/net/sctp/user.h index 9a83527..4ed7521 100644 ---

[PATCH 6/6] [SCTP] Implement SCTP_MAX_BURST socket option.

2007-03-23 Thread Vlad Yasevich
Signed-off-by: Vlad Yasevich [EMAIL PROTECTED] --- include/net/sctp/constants.h |2 +- include/net/sctp/structs.h |1 + include/net/sctp/user.h |2 + net/sctp/associola.c |2 +- net/sctp/protocol.c |2 +- net/sctp/socket.c| 61

[PATCH 1/6] [SCTP] Implement SCTP_FRAGMENT_INTERLEAVE socket option

2007-03-23 Thread Vlad Yasevich
This option was introduced in draft-ietf-tsvwg-sctpsocket-13. It prevents head-of-line blocking in the case of one-to-many endpoint. Applications enabling this option really must enable SCTP_SNDRCV event so that they would know where the data belongs. Based on an earlier patch by Ivan Skytte

Re: routing question under invisible bridge

2007-03-23 Thread Lennert Buytenhek
On Thu, Mar 22, 2007 at 03:52:55PM -0500, Bin He wrote: Dear sir, Hi, I found your email address from kernel bridge source codes. I would appreciate if you could look into my question a little bit. The netdev@ mailing list is a better forum to ask such questions, I've CC'ed this email