Re: [PATCH net-2.6.24] [NET] Cleanup: DIV_ROUND_UP

2007-08-25 Thread David Miller
From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Wed, 22 Aug 2007 13:48:14 +0300 (EEST) Signed-off-by: Ilpo Järvinen [EMAIL PROTECTED] Applied, thanks Ilpo. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH] IOAT: ioatdma needs to to play nice in a multi-dma-client world

2007-08-25 Thread David Miller
From: Shannon Nelson [EMAIL PROTECTED] Date: Wed, 22 Aug 2007 17:12:18 -0700 Now that the DMA engine has a multi-client interface, fix the ioatdma driver to play along. At the same time, remove a couple of unnecessary reads and writes. Signed-off-by: Shannon Nelson [EMAIL PROTECTED]

Re: [PATCH 1/2] E1000: Fix ifdown hang in git-2.6.24

2007-08-25 Thread David Miller
From: Krishna Kumar [EMAIL PROTECTED] Date: Thu, 23 Aug 2007 14:34:18 +0530 Doing napi_disable twice hangs ifdown of the device. e1000_down is the common place to call napi_disable. Signed-off-by: Krishna Kumar [EMAIL PROTECTED] Applied, thanks a lot. - To unsubscribe from this list: send

Re: [PATCH 2/2] [RFC] E1000: Fix hang in netdev_wait_allrefs()

2007-08-25 Thread David Miller
From: Krishna Kumar [EMAIL PROTECTED] Date: Thu, 23 Aug 2007 14:34:31 +0530 After applying patch1, I started getting waiting for count messages when doing ifdown. Not sure if this is the right fix since the count was already showing as -1 in that message, but this patch fixes the problem.

Re: [PATCH] udp: randomize port selection

2007-08-25 Thread David Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Thu, 23 Aug 2007 11:32:26 -0700 This patch causes UDP port allocation to be randomized like TCP. The earlier code would always choose same port (ie first empty list). Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] Applied to net-2.6.24,

Re: [PATCH 1/1] net/core: Fix crash in dev_mc_sync()/dev_mc_unsync()

2007-08-25 Thread David Miller
From: Patrick McHardy [EMAIL PROTECTED] Date: Thu, 23 Aug 2007 16:48:28 +0200 Benjamin Thery wrote: From: [EMAIL PROTECTED] Subject: net/core: Fix crash in dev_mc_sync()/dev_mc_unsync() This patch fixes a crash that may occur when the routine dev_mc_sync() deletes an address from the

Re: [PATCH net-2.6.24] introduce MAC_FMT/MAC_ARG

2007-08-25 Thread David Miller
From: John W. Linville [EMAIL PROTECTED] Date: Thu, 23 Aug 2007 13:08:30 -0400 On Thu, Aug 23, 2007 at 06:12:00PM +0200, Johannes Berg wrote: On Thu, 2007-08-23 at 09:01 -0700, Joe Perches wrote: There are also several different uses of the equivalent of printk(%02x,addr[0])

Re: [IPv6] Add v4mapped address inline

2007-08-25 Thread David Miller
From: Brian Haley [EMAIL PROTECTED] Date: Thu, 23 Aug 2007 14:14:35 -0400 YOSHIFUJI Hideaki / wrote: Please put this just after ipv6_addr_any(), not after ipv6_addr_diff(). Ok, updated patch attached. Add v4mapped address inline to avoid calls to ipv6_addr_type().

Re: [PATCH 16/30] net: Avoid pointless allocation casts in BSD compression module

2007-08-25 Thread David Miller
From: Jesper Juhl [EMAIL PROTECTED] Date: Fri, 24 Aug 2007 02:06:58 +0200 The general kernel memory allocation functions return void pointers and there is no need to cast their return values. Signed-off-by: Jesper Juhl [EMAIL PROTECTED] Applied. - To unsubscribe from this list: send the

Re: [PATCH] [XFRM] : Fix pointer copy size for encap_tmpl and coaddr.

2007-08-25 Thread David Miller
From: Masahide NAKAMURA [EMAIL PROTECTED] Date: Fri, 24 Aug 2007 19:05:20 +0900 This is minor fix about sizeof argument using with kmemdup(). Signed-off-by: Masahide NAKAMURA [EMAIL PROTECTED] Patch applied, thank you! - To unsubscribe from this list: send the line unsubscribe netdev in the

Re: [PATCH] [IPV6] XFRM: Fix connected socket to use transformation.

2007-08-25 Thread David Miller
From: Masahide NAKAMURA [EMAIL PROTECTED] Date: Fri, 24 Aug 2007 19:08:38 +0900 When XFRM policy and state are ready after TCP connection is started, the traffic should be transformed immediately, however it does not on IPv6 TCP. It depends on a dst cache replacement policy with connected

Re: [PATCH 2.6.23 RESEND] cxgb3 - Fix dev-priv usage

2007-08-25 Thread Jeff Garzik
Jeff Garzik wrote: Divy Le Ray wrote: From: Divy Le Ray [EMAIL PROTECTED] cxgb3 used netdev_priv() and dev-priv for different purposes. In 2.6.23, netdev_priv() == dev-priv, cxgb3 needs a fix. This patch is a partial backport of Dave Miller's changes in the net-2.6.24 git branch. Without

Re: [PATCH 1/2] [IPV6] IPSEC: Omit redirect for tunnelled packet.

2007-08-25 Thread David Miller
From: Masahide NAKAMURA [EMAIL PROTECTED] Date: Fri, 24 Aug 2007 19:08:55 +0900 IPv6 IPsec tunnel gateway incorrectly sends redirect to router or sender when network device the IPsec tunnelled packet is arrived is the same as the one the decapsulated packet is sent. With this patch, it

Re: [PATCH 2/2] [IPV4] IPSEC: Omit redirect for tunnelled packet.

2007-08-25 Thread David Miller
From: Masahide NAKAMURA [EMAIL PROTECTED] Date: Fri, 24 Aug 2007 19:09:01 +0900 IPv4 IPsec tunnel gateway incorrectly sends redirect to sender if it is onlink host when network device the IPsec tunnelled packet is arrived is the same as the one the decapsulated packet is sent. With this

Re: Please pull 'upstream-jgarzik' branch of wireless-2.6

2007-08-25 Thread Jeff Garzik
John W. Linville wrote: A few items intended for 2.6.24. Individual patches here: http://www.kernel.org/pub/linux/kernel/people/linville/wireless-2.6/upstream-jgarzik/ Thanks! John --- The following changes since commit 39d3520c92cf7a28c07229ca00cc35a1e8026c77: Linus Torvalds

Re: [PATCH 1/3] e1000e: retire last_tx_tso workaround

2007-08-25 Thread Jeff Garzik
Auke Kok wrote: This TSO-related workaround is no longer needed since it's only applicable for 8254x silicon. Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/e1000e/e1000.h | 15 +++ drivers/net/e1000e/netdev.c | 20 ++-- 2 files changed, 5

[git patches] net driver fixes

2007-08-25 Thread Jeff Garzik
Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream-linus to receive the following updates: drivers/net/dm9000.c| 25 --- drivers/net/ehea/ehea_main.c|8 ++-- drivers/net/ehea/ehea_qmr.c

[PATCH 3/4] Net: ath5k, use short preamble for some rates

2007-08-25 Thread Jiri Slaby
ath5k, use short preamble for some rates 2, 5.5 and 11 in b/g are now in short preamble mode Signed-off-by: Jiri Slaby [EMAIL PROTECTED] Cc: [EMAIL PROTECTED] --- commit 0a11d301ccb5caf1c9738a7307002a5295aecd58 tree f812c3fb91651437c7b434afbd4f8dc8435611f0 parent

[PATCH 4/4] Net: ath5k, remove some ieee80211 re-defines

2007-08-25 Thread Jiri Slaby
ath5k, remove some ieee80211 re-defines use mac80211 defines directly instead. this means MODULATION_* to IEEE80211_RATE_* switch. Signed-off-by: Jiri Slaby [EMAIL PROTECTED] Cc: [EMAIL PROTECTED] --- commit c858c1b27bfb4c58c9ebfa24de0d6442e364db97 tree 1add137b1e95ca1b4905441b5e30c779f8801c36

[PATCH 1/1] MAINTAINERS, order NETERION alphabetically

2007-08-25 Thread Jiri Slaby
MAINTAINERS, order NETERION alphabetically Signed-off-by: Jiri Slaby [EMAIL PROTECTED] --- commit f5f10b061961546a77300f3ebe92abd9cb5b9b48 tree 90ad6e22504aeaadb17309d01996eb6cd7eb5a93 parent c858c1b27bfb4c58c9ebfa24de0d6442e364db97 author Jiri Slaby [EMAIL PROTECTED] Sat, 25 Aug 2007 09:39:05

Re: [PATCH 4/5] [TCP]: Discard fuzzy SACK blocks

2007-08-25 Thread Ilpo Järvinen
On Fri, 24 Aug 2007, David Miller wrote: From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Mon, 20 Aug 2007 16:16:32 +0300 SACK processing code has been a sort of russian roulette as no validation of SACK blocks is previously attempted. Besides, it is not very clear what all kinds of broken

Re: [PATCH 2.6.23-rc3-mm1] request_irq fix DEBUG_SHIRQ handling Re: 2.6.23-rc2-mm1: rtl8139 inconsistent lock state

2007-08-25 Thread Mariusz Kozlowski
= [ INFO: inconsistent lock state ] 2.6.23-rc2-mm1 #7 - inconsistent {in-hardirq-W} - {hardirq-on-W} usage. ifconfig/5492 [HC0[0]:SC0[0]:HE1:SE1] takes: (tp-lock){+...}, at: [de8706e0] rtl8139_interrupt+0x27/0x46b

[XFRM] policy: Replace magic number with XFRM_POLICY_OUT

2007-08-25 Thread Thomas Graf
Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.24/net/xfrm/xfrm_policy.c === --- net-2.6.24.orig/net/xfrm/xfrm_policy.c 2007-08-24 13:11:17.0 +0200 +++ net-2.6.24/net/xfrm/xfrm_policy.c 2007-08-24

Re: [PATCH] ucc_geth: kill unused include

2007-08-25 Thread Kumar Gala
On Aug 24, 2007, at 11:37 PM, Jeff Garzik wrote: Kumar Gala wrote: The ucc_geth_mii code is based on the gianfar_mii code that use to include ocp.h. ucc never need this and it causes issues when we want to kill arch/ppc includes from arch/powerpc. Signed-off-by: Kumar Gala [EMAIL

Re: [Bug 8934] System freeze when restarting network connection with Broadcom driver

2007-08-25 Thread Andrew Morton
On Sat, 25 Aug 2007 03:26:24 -0700 (PDT) [EMAIL PROTECTED] wrote: http://bugzilla.kernel.org/show_bug.cgi?id=8934 Various nasty box-killing things happening here and http://bugzilla.kernel.org/show_bug.cgi?id=8937 might be related. Michal, 8934 (at least) is a post-2.6.22 regression - can you

iproute2: no error messages for unsupported table requests

2007-08-25 Thread Martin von Gagern
Hi! A while ago I've tried to configure multiple routing tables using iproute2-2.6.20. As my kernel at that time was configured without CONFIG_IP_MULTIPLE_TABLES this could not work. However, I got no error message from the ip command, the route was added to the main table, and it took me quite a

[PATCH] bmac: add simple ethtool support for network manager

2007-08-25 Thread Olaf Hering
NetworkManager will not start dhcpd on an interface unless it reports link-up state via ethtool. Signed-off-by: Olaf Hering [EMAIL PROTECTED] --- drivers/net/bmac.c | 13 + 1 file changed, 13 insertions(+) --- a/drivers/net/bmac.c +++ b/drivers/net/bmac.c @@ -19,6 +19,7 @@

Re: [XFRM] policy: Replace magic number with XFRM_POLICY_OUT

2007-08-25 Thread David Miller
From: Thomas Graf [EMAIL PROTECTED] Date: Sat, 25 Aug 2007 12:53:41 +0200 Signed-off-by: Thomas Graf [EMAIL PROTECTED] Applied, thanks Thomas. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

[PATCH 00/10] SFQ: backport some features from ESFQ (try 3)

2007-08-25 Thread Corey Hickey
Patchset try 2 addresses the review by Michael Buesch. Patchset try 3 addresses the review by Patrick McHardy. The first 7 patches in this series resemble the corresponding 7 patches I sent previously. There aren't any major changes--just modifications to address errors noticed in review and

[PATCH 01/10] Preparatory refactoring part 1.

2007-08-25 Thread Corey Hickey
Make a new function sfq_q_enqueue() that operates directly on the queue data. This will be useful for implementing sfq_change() in a later patch. A pleasant side-effect is reducing most of the duplicate code in sfq_enqueue() and sfq_requeue(). Similarly, make a new function sfq_q_dequeue().

[PATCH 02/10] Preparatory refactoring part 2.

2007-08-25 Thread Corey Hickey
Factor code out of sfq_init() and sfq_destroy(), again so that the new functions can be used by sfq_change() later. Actually, as the diff itself shows, most of the sfq_q_init() code comes from the original sfq_change(), but sfq_change() is only called by sfq_init() right now. Thus, it is safe to

[PATCH 03/10] Move two functions.

2007-08-25 Thread Corey Hickey
Move sfq_q_destroy() to above sfq_q_init() so that it can be used by an error case in a later patch. Move sfq_destroy() as well, for clarity. Signed-off-by: Corey Hickey [EMAIL PROTECTED] --- net/sched/sch_sfq.c | 22 +++--- 1 files changed, 11 insertions(+), 11 deletions(-)

[PATCH 04/10] Make depth (number of queues) user-configurable:

2007-08-25 Thread Corey Hickey
* replace #define with a parameter * use old hardcoded value as a default * kcalloc() arrays in sfq_q_init() * free() arrays in sfq_q_destroy() Signed-off-by: Corey Hickey [EMAIL PROTECTED] --- net/sched/sch_sfq.c | 84 +++ 1 files changed, 58

[PATCH 08/10] Multiply perturb_period by HZ when used rather than when assigned.

2007-08-25 Thread Corey Hickey
perturb_period is the only parameter that doesn't match 1:1 with the value from userspace. This change makes it easy and clean to use a small macro for setting parameters (in a subsequent patch). Signed-off-by: Corey Hickey [EMAIL PROTECTED] --- net/sched/sch_sfq.c | 10 +- 1 files

[PATCH 06/10] Make qdisc changeable.

2007-08-25 Thread Corey Hickey
Re-implement sfq_change() and enable Qdisc_opts.change so tc qdisc change will work. Signed-off-by: Corey Hickey [EMAIL PROTECTED] --- net/sched/sch_sfq.c | 64 ++- 1 files changed, 63 insertions(+), 1 deletions(-) diff --git

[PATCH 07/10] Remove comments about hardcoded values.

2007-08-25 Thread Corey Hickey
None of these are true anymore (hooray!). Signed-off-by: Corey Hickey [EMAIL PROTECTED] --- include/linux/pkt_sched.h |8 net/sched/sch_sfq.c | 17 +++-- 2 files changed, 3 insertions(+), 22 deletions(-) diff --git a/include/linux/pkt_sched.h

[PATCH 05/10] Add divisor.

2007-08-25 Thread Corey Hickey
Make hash divisor user-configurable. Signed-off-by: Corey Hickey [EMAIL PROTECTED] --- net/sched/sch_sfq.c | 18 +- 1 files changed, 13 insertions(+), 5 deletions(-) diff --git a/net/sched/sch_sfq.c b/net/sched/sch_sfq.c index 2e6d607..827b885 100644 --- a/net/sched/sch_sfq.c

[PATCH 09/10] Change perturb_period to unsigned.

2007-08-25 Thread Corey Hickey
perturb_period is currently a signed integer, but I can't see any good reason why this is so--a negative perturbation period will add a timer that expires in the past, causing constant perturbation, which makes hashing useless. if (q-perturb_period) {

[PATCH 10/10] Use nested compat attributes to pass parameters.

2007-08-25 Thread Corey Hickey
This fixes the ambiguity between, for example: tc qdisc change ... perturb 0 tc qdisc change ... Without this patch, there is no way for SFQ to differentiate between a parameter specified to be 0 and a parameter that was omitted. Signed-off-by: Corey Hickey [EMAIL PROTECTED] ---

[PATCH 0/3][iproute2] SFQ: backport some features from ESFQ

2007-08-25 Thread Corey Hickey
These patches follow the ESFQ--SFQ kernel patches. See the kernel patch summary for general information. Thanks, Corey include/linux/pkt_sched.h | 23 ++- tc/q_sfq.c| 43 ++- 2 files changed, 52 insertions(+), 14

[PATCH 1/3] SFQ: Support changing depth and divisor.

2007-08-25 Thread Corey Hickey
This can safely be applied either before or after the kernel patches because the tc_sfq_qopt struct is unchanged: - old kernels will ignore the parameters from new iproute2 - new kernels will use the same default parameters --- include/linux/pkt_sched.h |9 - tc/q_sfq.c

[PATCH 2/3] Change perturb_period to unsigned.

2007-08-25 Thread Corey Hickey
This corresponds to the kernel patch doing the same. Here, too, this will technically break binary compatibility with older kernels, but that shouldn't be a problem because negative perturb_period values aren't usable anyway. --- include/linux/pkt_sched.h |2 +- tc/q_sfq.c|

[PATCH 3/3] Use nested compat attributes for passing parameters to the kernel.

2007-08-25 Thread Corey Hickey
Note that I have left sfq_print_opt() alone. At this point, there can be no difference between the data in the nested rtattrs and the data in the compat rtattr, and I didn't want to add clutter that isn't useful. Let me know if I should do differently. Signed-off-by: Corey Hickey [EMAIL

Re: [PATCH 0/9 Rev3] Implement batching skb API and support in IPoIB

2007-08-25 Thread Bill Fink
On Sat, 25 Aug 2007, Herbert Xu wrote: On Fri, Aug 24, 2007 at 02:25:03PM -0700, David Miller wrote: My hunch is that even if in the non-TSO case the TX packets were all back to back in the cards TX ring, TSO still spits them out faster on the wire. If this is the case then we should