Re: [PATCH] [-MM, FIX V3] e1000e: incorporate napi_struct changes from net-2.6.24.git

2007-09-12 Thread David Miller
From: "Kok, Auke" <[EMAIL PROTECTED]> Date: Wed, 12 Sep 2007 09:42:29 -0700 > David Miller wrote: > > > > diff --git a/drivers/net/e1000/e1000_main.c b/drivers/net/e1000/e1000_main.c > > index 7b0bcdb..58bb758 100644 > > --- a/drivers/net/e1000/e1000_main.c > > +++ b/drivers/net/e1000/e1000_main.

Re: [net-2.6.24][XFRM][patch 0/1] fix allmodconfig

2007-09-12 Thread David Miller
From: [EMAIL PROTECTED] Date: Wed, 12 Sep 2007 17:27:15 +0200 > Fixes missing export symbols This should already be corrected in net-2.6.24 - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.

Re: [PATCH] 3c59x: sparse warning fix

2007-09-12 Thread Steffen Klassert
On Wed, Sep 05, 2007 at 03:23:59PM +0100, Stephen Hemminger wrote: > --- a/drivers/net/3c59x.c 2007-09-05 15:15:16.0 +0100 > +++ b/drivers/net/3c59x.c 2007-09-05 15:16:29.0 +0100 > @@ -1122,7 +1122,7 @@ static int __devinit vortex_probe1(struc >

[net-2.6.24][NETNS][patch 1/1] fix allnoconfig compilation error

2007-09-12 Thread dlezcano
From: Daniel Lezcano <[EMAIL PROTECTED]> When CONFIG_NET=no, init_net is unresolved because net_namespace.c is not compiled and the include pull init_net definition. This problem was very similar with the ipc namespace where the kernel can be compiled with SYSV ipc out. This patch fix that defin

Re: [PATCH] veth: Cleanly handle a missing peer_tb argument on creation.

2007-09-12 Thread Pavel Emelyanov
Eric W. Biederman wrote: > Pavel Emelyanov <[EMAIL PROTECTED]> writes: > >> Eric W. Biederman wrote: >>> Pavel Emelyanov <[EMAIL PROTECTED]> writes: >>> > + } > > - tbp = peer_tb; > - } else > - tbp = tb; The intention of this part was to get the same par

[net-2.6.24][NETNS][patch 0/1] fix allnoconfig compilation erro

2007-09-12 Thread dlezcano
fixes a compilation issue when allnoconfig is used. - init_net is unresolved. -- - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[git patches] net driver fixes

2007-09-12 Thread Jeff Garzik
Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream-linus to receive the following updates: drivers/net/atl1/atl1_main.c | 19 +++ drivers/net/ehea/ehea.h |5 - drivers/net/ehea/ehea_main.c | 1

RE: [PATCH v3] Make the pr_*() family of macros in kernel.h complete

2007-09-12 Thread Joe Perches
On Wed, 2007-09-12 at 11:44 -0700, Medve Emilian-EMMEDVE1 wrote: > First, this patch doesn't have the trailing "\n" problem that one had. I expect all the kernel logging functions to be overhauled eventually. I'd prefer a mechanism that somehow supports identifying complete messages. I think the

Re: [PATCH] spidernet: fix interrupt reason recognition

2007-09-12 Thread Jeff Garzik
Ishizaki Kou wrote: This patch solves a problem that the spidernet driver sometimes fails to handle IRQ. The problem happens because, - In Cell architecture, interrupts may arrive at an interrupt controller, even if they are masked by the setting on registers of devices. It happens when inte

Re: [PATCH 1/2] ethtool: add register dump support for intel 82575 chipsets (igb driver)

2007-09-12 Thread Jeff Garzik
Auke Kok wrote: From: Nicholas Nunley <[EMAIL PROTECTED]> Signed-off-by: Nicholas Nunley <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- Makefile.am|2 ethtool-util.h |2 ethtool.c |1 igb.c | 864 +++

Re: [PATCH 1/2][RESEND] ehea: propagate physical port state

2007-09-12 Thread Jeff Garzik
Jan-Bernd Themann wrote: Introduces a module parameter to decide whether the physical port link state is propagated to the network stack or not. It makes sense not to take the physical port state into account on machines with more logical partitions that communicate with each other. This is alway

Re: [PATCH] Fix a lock problem in generic phy code

2007-09-12 Thread Jeff Garzik
Hans-Jürgen Koch wrote: Lock debugging finds a problem in phy.c and phy_device.c, this patch fixes it. Tested on an AT91SAM9263-EK board, kernel 2.6.23-rc4. Signed-off-by: Hans J. Koch <[EMAIL PROTECTED]> applied - To unsubscribe from this list: send the line "unsubscribe netdev" in the bo

Re: [PATCH 2/2] drivers/net/: all drivers/net/ cleanup with ARRAY_SIZE

2007-09-12 Thread Jeff Garzik
Denis Cheng wrote: Signed-off-by: Denis Cheng <[EMAIL PROTECTED]> --- drivers/net/apne.c |2 +- drivers/net/arm/am79c961a.c|2 +- drivers/net/atarilance.c |2 +- drivers/net/atl1/atl1_hw.c |2 +- drivers/ne

Re: [NET] Nuke SET_MODULE_OWNER macro

2007-09-12 Thread Jeff Garzik
Ralf Baechle wrote: It's been a useless no-op for long enough in 2.6 so I figured it's time to remove it. The number of people that could object because they're maintaining unified 2.4 and 2.6 drivers is probably rather small. Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> applied - To uns

Re: ne driver crashes when unloaded in 2.6.22.6

2007-09-12 Thread Dan Williams
On Wed, 2007-09-12 at 19:23 +0100, Chris Rankin wrote: > --- Dan Williams <[EMAIL PROTECTED]> wrote: > > > > Offhand question, does your ne2000 card support carrier detection? > > > > > > Err... there is a /sys/class/net/eth0/carrier entry > > > > Does it read '0' when you unplug the cable? > >

Re: [PATCH 2.6.24 1/5]S2io: Enable all the error and alarm indications

2007-09-12 Thread Jeff Garzik
Sivakumar Subramani wrote: - Added support to unmask entire set of device errors and alarams. Alarm interrupts are generated for a myriad of purposes, ranging from illegal operations or requests to internal state machine errors and uncorrectable data corruption errors. In several case

Re: [PATCH] sky2: restore multicast list on resume and other ops

2007-09-12 Thread Jeff Garzik
Stephen Hemminger wrote: Need to restore multicast settings on resume and after 'ethtool -r'. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> applied to #upstream-fixes - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More

Re: [PATCH 2.6.18-rc6 1/2] dllink driver: porting v1.19 to linux 2.6.18-rc6

2007-09-12 Thread Jeff Garzik
Hayim Shaul wrote: Description: For DLink Fiber NIC, Linux 2.4.22 ships with driver version 1.19, whereas, Linux 2.6.x ship with driver version 1.17. The following patch upgrades the 2.6.x driver to include changes (and bug fixes done until 1.19b). These fixes are (copied from the driver):

Re: [PATCH] sb1250-mac.c: De-typedef, de-volatile, de-etc...

2007-09-12 Thread Jeff Garzik
Maciej W. Rozycki wrote: Remove typedefs, volatiles and convert kmalloc()/memset() pairs to kcalloc(). Also reformat the surrounding clutter. Signed-off-by: Maciej W. Rozycki <[EMAIL PROTECTED]> --- Per your request, Andrew, a while ago. It builds, runs, passes checkpatch.pl and sparse. No

Re: [PATCH, 2nd try] remove setup of platform device from jazzsonic.c

2007-09-12 Thread Jeff Garzik
Thomas Bogendoerfer wrote: remove setup platform device from jazzsonic, which is done in arch code now Signed-off-by: Thomas Bogendoerfer <[EMAIL PROTECTED]> applied - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordo

Re: [NET] sgiseeq: replace use of dma_cache_wback_inv

2007-09-12 Thread Jeff Garzik
Ralf Baechle wrote: The sgiseeq driver is one of the few remaining users of the ancient cache banging DMA API. Replaced with the modern days DMA API. Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> applied - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a

Re: [PATCH 1/7 RESEND] cxgb3 - Firmware update

2007-09-12 Thread Jeff Garzik
Divy Le Ray wrote: From: Divy Le Ray <[EMAIL PROTECTED]> Update firmware version. Allow the driver to be up and running with older FW image Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> applied 1-7 - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message

Re: [PATCH] e100: timer power saving

2007-09-12 Thread Jeff Garzik
Auke Kok wrote: From: Stephen Hemminger <[EMAIL PROTECTED]> Since E100 timer is 2HZ, use rounding to make timer occur on the correct boundary. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> applied - To unsubscribe from this list: send the l

Re: [PATCH][MIPS][7/7] AR7: ethernet

2007-09-12 Thread Thiemo Seufer
Ralf Baechle wrote: > On Sat, Sep 08, 2007 at 02:23:00AM +0200, Matteo Croce wrote: [snip] > > +/* Register definitions */ > > +struct cpmac_control_regs { > > + u32 revision; > > + u32 control; > > + u32 teardown; > > + u32 unused; > > +} __attribute__ ((packed)); > > + > > +struct cpmac_i

Re: [PATCH 1/4] [IPV6]: Fix unbalanced socket reference with MSG_CONFIRM.

2007-09-12 Thread YOSHIFUJI Hideaki / 吉藤英明
| [PATCH 1/4] [IPV6]: Fix unbalanced socket reference with MSG_CONFIRM. Ah, I should say, socket locking, probably... Anyway, lock_sock() and release_sock() are not paired approriately. --yoshfuji - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMA

[PATCH 4/4] [IPV4]: Just increment OutDatagrams once per a datagram.

2007-09-12 Thread YOSHIFUJI Hideaki / 吉藤英明
Signed-off-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> --- diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c index facb7e2..ccb67f3 100644 --- a/net/ipv4/udp.c +++ b/net/ipv4/udp.c @@ -504,6 +504,8 @@ send: out: up->len = 0; up->pending = 0; + if (!err) + UDP_INC_STAT

[PATCH 3/4] [IPV6]: Just increment OutDatagrams once per a datagram.

2007-09-12 Thread YOSHIFUJI Hideaki / 吉藤英明
Signed-off-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> diff --git a/net/ipv6/udp.c b/net/ipv6/udp.c index 4210951..c347f3e 100644 --- a/net/ipv6/udp.c +++ b/net/ipv6/udp.c @@ -555,6 +555,8 @@ static int udp_v6_push_pending_frames(struct sock *sk) out: up->len = 0; up->pending = 0; +

[PATCH 1/4] [IPV6]: Fix unbalanced socket reference with MSG_CONFIRM.

2007-09-12 Thread YOSHIFUJI Hideaki / 吉藤英明
Also applicable for stable releases. Signed-off-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> -- diff --git a/net/ipv6/raw.c b/net/ipv6/raw.c index a58459a..fc5cb83 100644 --- a/net/ipv6/raw.c +++ b/net/ipv6/raw.c @@ -858,11 +858,10 @@ back_from_confirm: ip6_flush_pending_fra

[PATCH 2/4] [IPV6]: Fix oops during flushing corked datagrams.

2007-09-12 Thread YOSHIFUJI Hideaki / 吉藤英明
When we corking sub-datagrams, we do not clone skb->dst for sub-datagrams other than the first one, so we get oops if we have multiple sub-datagrams here. One possible way to fix this is to clone skb->dst for all sub-datagrams, but we do not take this approach because skb->dst is not used in other

cc: Re: skb configured but can't get data allocated

2007-09-12 Thread DHAJOGLO
To All, Thanks for the help. I ended up adding my data packet after the ip headers and then updated the IP length: /* Allocate space for our exp_packet data payload and set the data */ d_out = (struct exp_packet *)skb_put(skb,sizeof(struct exp_packet)); d_out->headbits = (reply<

Re: [PATCH] [-MM, FIX] ixgbe: incorporate napi_struct changes from net-2.6.24.git

2007-09-12 Thread Kok, Auke
Andrew Morton wrote: On Wed, 12 Sep 2007 15:20:01 -0700 "Kok, Auke" <[EMAIL PROTECTED]> wrote: Andrew Morton wrote: On Wed, 12 Sep 2007 11:13:07 -0700 Auke Kok <[EMAIL PROTECTED]> wrote: This incorporates the new napi_struct changes into ixgbe. I get a reject storm. --- a/drivers/net/ixgb

Re: [PATCH] [-MM, FIX] ixgbe: incorporate napi_struct changes from net-2.6.24.git

2007-09-12 Thread Andrew Morton
On Wed, 12 Sep 2007 15:20:01 -0700 "Kok, Auke" <[EMAIL PROTECTED]> wrote: > Andrew Morton wrote: > > On Wed, 12 Sep 2007 11:13:07 -0700 > > Auke Kok <[EMAIL PROTECTED]> wrote: > > > >> This incorporates the new napi_struct changes into ixgbe. > > > > I get a reject storm. > > > >> --- a/drivers

Re: [RFC v2 PATCH 1/2] SCTP: Add RCU synchronization around sctp_localaddr_list

2007-09-12 Thread Sridhar Samudrala
Vlad, few minor comments inline. otherwise, looks good. Thanks Sridhar On Wed, 2007-09-12 at 15:46 -0400, Vlad Yasevich wrote: > sctp_localaddr_list is modified dynamically via NETDEV_UP > and NETDEV_DOWN events, but there is not synchronization > between writer (even handler) and readers. As a

[PATCH] IPV6: fix source address selection

2007-09-12 Thread Jiri Kosina
From: Jiri Kosina <[EMAIL PROTECTED]> [PATCH] IPV6: fix source address selection The commit 95c385 broke proper source address selection for cases in which there is a address which is makred 'deprecated'. The commit mistakenly changed ifa->flags to ifa_result->flags (probably copy/paste error f

Re: [PATCH] net: Fix race when opening a proc file while a network namespace is exiting.

2007-09-12 Thread Paul E. McKenney
On Wed, Sep 12, 2007 at 10:24:34AM -0600, Eric W. Biederman wrote: > > The problem: proc_net files remember which network namespace the are > against but do not remember hold a reference count (as that would pin > the network namespace). So we currently have a small window where > the reference

Re: [RFC v3 PATCH 2/21] SCTP: Convert bind_addr_list locking to RCU

2007-09-12 Thread Paul E. McKenney
On Wed, Sep 12, 2007 at 05:03:42PM -0400, Vlad Yasevich wrote: > [... and here is the updated version as promissed ...] > > Since the sctp_sockaddr_entry is now RCU enabled as part of > the patch to synchronize sctp_localaddr_list, it makes sense to > change all handling of these entries to RCU.

Re: [RFC v2 PATCH 1/2] SCTP: Add RCU synchronization around sctp_localaddr_list

2007-09-12 Thread Paul E. McKenney
On Wed, Sep 12, 2007 at 03:46:37PM -0400, Vlad Yasevich wrote: > sctp_localaddr_list is modified dynamically via NETDEV_UP > and NETDEV_DOWN events, but there is not synchronization > between writer (even handler) and readers. As a result, > the readers can access an entry that has been freed and

Re: [PATCH] [-MM, FIX] ixgbe: incorporate napi_struct changes from net-2.6.24.git

2007-09-12 Thread Kok, Auke
Andrew Morton wrote: On Wed, 12 Sep 2007 11:13:07 -0700 Auke Kok <[EMAIL PROTECTED]> wrote: This incorporates the new napi_struct changes into ixgbe. I get a reject storm. --- a/drivers/net/ixgbe/ixgbe_main.c +++ b/drivers/net/ixgbe/ixgbe_main.c @@ -557,14 +557,15 @@ static irqreturn_t ixgb

Re: [patch] sunrpc: make closing of old temporary sockets work (was: problems with lockd in 2.6.22.6)

2007-09-12 Thread Wolfgang Walter
On Wednesday 12 September 2007, J. Bruce Fields wrote: > On Wed, Sep 12, 2007 at 09:40:57PM +0200, Wolfgang Walter wrote: > > On Wednesday 12 September 2007, J. Bruce Fields wrote: > > > On Wed, Sep 12, 2007 at 04:14:06PM +0200, Neil Brown wrote: > > > > So it is in 2.6.21 and later and should prob

Re: [PATCH] [-MM, FIX] ixgbe: incorporate napi_struct changes from net-2.6.24.git

2007-09-12 Thread Andrew Morton
On Wed, 12 Sep 2007 11:13:07 -0700 Auke Kok <[EMAIL PROTECTED]> wrote: > This incorporates the new napi_struct changes into ixgbe. I get a reject storm. > --- a/drivers/net/ixgbe/ixgbe_main.c > +++ b/drivers/net/ixgbe/ixgbe_main.c > @@ -557,14 +557,15 @@ static irqreturn_t ixgbe_msix_clean_rx(in

Re: [PATCH] Add IP1000A Driver

2007-09-12 Thread Francois Romieu
-Jesse <[EMAIL PROTECTED]> : [...] > Because lot of patch was created by you, could I write your name on > MAINTAINERS file. No objection/volunteer in the room ? -- Ueimor - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majo

[RFC v3 PATCH 2/21] SCTP: Convert bind_addr_list locking to RCU

2007-09-12 Thread Vlad Yasevich
[... and here is the updated version as promissed ...] Since the sctp_sockaddr_entry is now RCU enabled as part of the patch to synchronize sctp_localaddr_list, it makes sense to change all handling of these entries to RCU. This includes the sctp_bind_addrs structure and it's list of bound addres

Re: [RFC v2 PATCH 0/2] Add RCU locking to SCTP address management

2007-09-12 Thread Vlad Yasevich
Vlad Yasevich wrote: > Ok, this is version 2 of the patch that incorporates comments from > Sridhar Samudrala and Paul McKenney. > > The changes icorporated are: > 1. Add locking around the modification of the global sctp_local_addr_list > when processing the notifiers. After looking around, i

Re: net/bluetooth/hci_sock.c:352: error: storage size of 'ctv' isn't known

2007-09-12 Thread Randy Dunlap
On Wed, 12 Sep 2007 06:15:20 -0400 (EDT) Robert P. J. Day wrote: > p.s. dumb question -- what locale should i be using to get those > quotes to not make such a mess of my screen? thanks. right or wrong, I use "LC_ALL=C" and it works for me. --- ~Randy - To unsubscribe from this list: send the l

Re: PROBLEM: 2.6.23-rc "NETDEV WATCHDOG: eth0: transmit timed out"

2007-09-12 Thread Francois Romieu
Karl Meyer <[EMAIL PROTECTED]> : [...] > am am looking for this issue for some time now, but there where no > errors in 2.6.22-r2 (gentoo speak, I guess this is 2.6.22.2 > officially), I also ran git-bisect (for more information see the older > messages in this thread). 2.6.22-r2 in gentoo is base

Re: [PATCH] [RFC] allow admin/users to specify rto_min in milliseconds rather than jiffies

2007-09-12 Thread Rick Jones
The api in netlink should be in milliseconds rather than compensating in the application (iproute2). My understanding of the in-kernel rtnetlink code is far from complete, but it doesn't seem to have much in the way of provisions for unit conversion, which would suggest no nice suffix-based u

Re: skb configured but can't get data allocated

2007-09-12 Thread Vlad Yasevich
You may want to read this page: http://vger.kernel.org/~davem/skb.html You will then see you problem. Essentially, you are writing your data into an area that is never sent. What you are end up is this: - | your data| space | ll-header | IPv4 header|

Re: [PATCH] Fix e100 on systems that have cache incoherent DMA

2007-09-12 Thread David Acker
James Chapman wrote: David Acker wrote: Jeff Garzik wrote: pktgen outputs for the various cases modified/unmodified[/others?] would be nice, if you have a spot of time. Jeff I am not familiar with pktgen but I seem to have it working for a simple test. I edited the 1-1 example from ft

Re: [patch] sunrpc: make closing of old temporary sockets work (was: problems with lockd in 2.6.22.6)

2007-09-12 Thread J. Bruce Fields
On Wed, Sep 12, 2007 at 09:40:57PM +0200, Wolfgang Walter wrote: > On Wednesday 12 September 2007, J. Bruce Fields wrote: > > On Wed, Sep 12, 2007 at 04:14:06PM +0200, Neil Brown wrote: > > > So it is in 2.6.21 and later and should probably go to .stable for .21 > > > and .22. > > > > > > Bruce:

[RFC v2 PATCH 2/2] SCTP: Convert bind_addr_list locking to RCU

2007-09-12 Thread Vlad Yasevich
Since the sctp_sockaddr_entry is now RCU enabled as part of the patch to synchronize sctp_localaddr_list, it makes sense to change all handling of these entries to RCU. This includes the sctp_bind_addrs structure and it's list of bound addresses. This list is currently protected by an external rw

[RFC v2 PATCH 1/2] SCTP: Add RCU synchronization around sctp_localaddr_list

2007-09-12 Thread Vlad Yasevich
sctp_localaddr_list is modified dynamically via NETDEV_UP and NETDEV_DOWN events, but there is not synchronization between writer (even handler) and readers. As a result, the readers can access an entry that has been freed and crash the sytem. Signed-off-by: Vlad Yasevich <[EMAIL PROTECTED]> ---

[RFC v2 PATCH 0/2] Add RCU locking to SCTP address management

2007-09-12 Thread Vlad Yasevich
Ok, this is version 2 of the patch that incorporates comments from Sridhar Samudrala and Paul McKenney. The changes icorporated are: 1. Add locking around the modification of the global sctp_local_addr_list when processing the notifiers. After looking around, it is possible for the IPv4 and I

Re: [patch] sunrpc: make closing of old temporary sockets work (was: problems with lockd in 2.6.22.6)

2007-09-12 Thread Wolfgang Walter
On Wednesday 12 September 2007, J. Bruce Fields wrote: > On Wed, Sep 12, 2007 at 04:14:06PM +0200, Neil Brown wrote: > > So it is in 2.6.21 and later and should probably go to .stable for .21 > > and .22. > > > > Bruce: for you :-) > > OK, thanks! But, (as is alas often the case) I'm still conf

Re: [PATCH] bonding: update some distro-specific documentation

2007-09-12 Thread Andy Gospodarek
On 9/12/07, Jay Vosburgh <[EMAIL PROTECTED]> wrote: > Andy Gospodarek <[EMAIL PROTECTED]> wrote: > > >I could do that, or we could just take this as-is and get initscripts > >fixed up to account for this. Does that seem reasonable? > > Changing initscripts is fine, too, but is there then g

Re: [PATCH]: xfrm audit calls

2007-09-12 Thread Joy Latten
On Wed, 2007-09-12 at 14:56 -0400, [EMAIL PROTECTED] wrote: > On Tue, 11 Sep 2007 19:03:14 CDT, Joy Latten said: > > This patch modifies the current ipsec audit layer > > by breaking it up into purpose driven audit calls. > > > > So far, the only audit calls made are when add/delete > > an SA/polic

[PATCH] CIPSO: remove duplicated code in the cipso_v4_*_getattr() functions

2007-09-12 Thread Paul Moore
The bulk of the CIPSO option parsing/processing in the cipso_v4_sock_getattr() and cipso_v4_skb_getattr() functions are identical, the only real difference being where the functions obtain the CIPSO option itself. This patch creates a new function, cipso_v4_getattr(), which contains the common CIP

[PATCH] Small cleanup for 2.6.24 and a git tree test

2007-09-12 Thread Paul Moore
The cleanup patch is pretty trivial and is explained in it's own email, but essentially it is just moving similar code into a new function and then modifying the original functions to call the newly created function. The new and exciting thing is that I actually decided I should probably know how

Re: [PATCH]: xfrm audit calls

2007-09-12 Thread Valdis . Kletnieks
On Tue, 11 Sep 2007 19:03:14 CDT, Joy Latten said: > This patch modifies the current ipsec audit layer > by breaking it up into purpose driven audit calls. > > So far, the only audit calls made are when add/delete > an SA/policy. What other audit calls do you envision adding in the future? pgpGA

Re: [PATCH] bonding: update some distro-specific documentation

2007-09-12 Thread Jay Vosburgh
Andy Gospodarek <[EMAIL PROTECTED]> wrote: >I could do that, or we could just take this as-is and get initscripts >fixed up to account for this. Does that seem reasonable? Changing initscripts is fine, too, but is there then going to be some (perhaps small) installed base for which the d

Re: [PATCH] ixgbe: driver for Intel(R) 82598 PCI-Express 10GbE adapters (v4)

2007-09-12 Thread Kok, Auke
Jeff Garzik wrote: David Miller wrote: From: "Kok, Auke" <[EMAIL PROTECTED]> Date: Thu, 06 Sep 2007 11:31:47 -0700 Also available through git:// and http:// here: http://foo-projects.org/~sofar/ixgbe-20070905-submission.patch http://foo-projects.org/~sofar/ixgbe-20070905-submission.patc

RE: [PATCH v3] Make the pr_*() family of macros in kernel.h complete

2007-09-12 Thread Medve Emilian-EMMEDVE1
> -Original Message- > From: Jan Engelhardt [mailto:[EMAIL PROTECTED] > Sent: Wednesday, September 12, 2007 1:04 PM > To: Medve Emilian-EMMEDVE1 > Cc: [EMAIL PROTECTED]; netdev@vger.kernel.org; > [EMAIL PROTECTED]; [EMAIL PROTECTED] > Subject: Re: [PATCH v3] Make the pr_*() family of macr

Re: [patch] sunrpc: make closing of old temporary sockets work (was: problems with lockd in 2.6.22.6)

2007-09-12 Thread J. Bruce Fields
On Wed, Sep 12, 2007 at 04:14:06PM +0200, Neil Brown wrote: > So it is in 2.6.21 and later and should probably go to .stable for .21 > and .22. > > Bruce: for you :-) OK, thanks! But, (as is alas often the case) I'm still confused: > if (!test_and_set_bit(SK_OLD, &svsk->sk_flags)

Re: [PATCH] bonding: update some distro-specific documentation

2007-09-12 Thread Andy Gospodarek
On Fri, Sep 07, 2007 at 11:27:49AM -0700, Jay Vosburgh wrote: > Andy Gospodarek <[EMAIL PROTECTED]> wrote: > > This all looks fine except for one nit (well, request for extra > detail, really): > > >@@ -802,15 +802,20 @@ BROADCAST=192.168.1.255 > > ONBOOT=yes > > BOOTPROTO=none > > USERCTL=

Re: ne driver crashes when unloaded in 2.6.22.6

2007-09-12 Thread Chris Rankin
--- Dan Williams <[EMAIL PROTECTED]> wrote: > > > Offhand question, does your ne2000 card support carrier detection? > > > > Err... there is a /sys/class/net/eth0/carrier entry > > Does it read '0' when you unplug the cable? Hmm, apparently not. The light on the card goes out though, so could t

Re: [PATCH] phy: implement release function

2007-09-12 Thread Andy Fleming
On Sep 12, 2007, at 06:26, Anton Vorontsov wrote: Lately I've got this nice badness on mdio bus removal: Device 'e0103120:06' does not have a release() function, it is broken and must be fixed. [ cut here ] Badness at drivers/base/core.c:107 NIP: c015c1a8 LR: c015c1a

Re: cc: skb configured but can't get data allocated

2007-09-12 Thread Macnish
DHAJOGLO escreveu: Right, I managed to figure out through looking at the code how to configure and send my skb properly. For those who say the code is well documented.. you're right.. however I fell like a blind man in an "adult book store" and just don't see what I'm missing. Below is m

[PATCH] [-MM, FIX] ixgbe: incorporate napi_struct changes from net-2.6.24.git

2007-09-12 Thread Auke Kok
This incorporates the new napi_struct changes into ixgbe. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/ixgbe/ixgbe.h |1 + drivers/net/ixgbe/ixgbe_main.c | 62 +--- 2 files changed, 27 insertions(+), 36 deletions(-) diff --git a/driv

RE: [PATCH] RDMA/CMA: Use neigh_event_send() to initiate neighbour discovery.

2007-09-12 Thread Sean Hefty
>RDMA/CMA: Use neigh_event_send() to initiate neighbour discovery. > >Calling arp_send() to initiate neighbour discovery (ND) doesn't do the >full ND protocol. Namely, it doesn't handle retransmitting the arp >request if it is dropped. The function neigh_event_send() does all this. >Without doing

Re: [PATCH v3] Make the pr_*() family of macros in kernel.h complete

2007-09-12 Thread Jan Engelhardt
On Sep 12 2007 11:39, Emil Medve wrote: > >Other/Some pr_*() macros are already defined in kernel.h, but pr_err() was >defined >multiple times in several other places Note http://lkml.org/lkml/2007/8/4/30 . - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a mess

[PATCH 3/3 v4] rfkill: Add rfkill documentation

2007-09-12 Thread Ivo van Doorn
Add a documentation file which contains a short description about rfkill with some notes about drivers and the userspace interface. Changes since v1 and v2:  - Spellchecking Signed-off-by: Ivo van Doorn <[EMAIL PROTECTED]> Acked-by: Dmitry Torokhov <[EMAIL PROTECTED]> Acked-by: Randy Dunlap <[EMA

[PATCH 1/3 v4] rfkill: Remove IRDA

2007-09-12 Thread Ivo van Doorn
As Dmitry pointed out earlier, rfkill-input.c doesn't support irda because there are no users and we shouldn't add unrequired KEY_ defines. However, RFKILL_TYPE_IRDA was defined in the rfkill.h header file and would confuse people about whether it is implemented or not. This patch removes IRDA su

[PATCH 2/3 v4] rfkill: Add support for ultrawideband

2007-09-12 Thread Ivo van Doorn
This patch will add support for UWB keys to rfkill, support for this has been requested by Inaky. Signed-off-by: Ivo van Doorn <[EMAIL PROTECTED]> CC: Dmitry Torokhov <[EMAIL PROTECTED]> CC: Inaky Perez-Gonzalez <[EMAIL PROTECTED]> --- include/linux/input.h |1 + include/linux/rfkill.h

Re: [-mm patch] make tcp_splice_data_recv() static

2007-09-12 Thread Jens Axboe
On Wed, Sep 12 2007, David Miller wrote: > From: Adrian Bunk <[EMAIL PROTECTED]> > Date: Sun, 9 Sep 2007 22:25:58 +0200 > > > On Fri, Aug 31, 2007 at 09:58:22PM -0700, Andrew Morton wrote: > > >... > > > Changes since 2.6.23-rc3-mm1: > > >... > > > git-block.patch > > >... > > > git trees > > >.

skb configured but can't get data allocated

2007-09-12 Thread DHAJOGLO
Right, I managed to figure out through looking at the code how to configure and send my skb properly. For those who say the code is well documented.. you're right.. however I fell like a blind man in an "adult book store" and just don't see what I'm missing. Below is my code. The packets a

Re: 2.6.23-rc6: known regressions with patches

2007-09-12 Thread Michal Piotrowski
On 12/09/2007, David Woodhouse <[EMAIL PROTECTED]> wrote: > On Wed, 2007-09-12 at 18:59 +0200, Michal Piotrowski wrote: > > MTD > > > > Subject : include/linux/mtd/map.h:128:2: error: #error "No bus > > width supported. What's the point?" > > References : http://lkml.org/lkml/2007/9/1

Re: 2.6.23-rc6: known regressions with patches

2007-09-12 Thread David Woodhouse
On Wed, 2007-09-12 at 18:59 +0200, Michal Piotrowski wrote: > MTD > > Subject : include/linux/mtd/map.h:128:2: error: #error "No bus width > supported. What's the point?" > References : http://lkml.org/lkml/2007/9/11/151 > Last known good : ? > Submitter : Toralf Förster <[EMAI

2.6.23-rc6: known regressions with patches

2007-09-12 Thread Michal Piotrowski
Hi all, Here is a list of some known regressions in 2.6.23-rc6 with patches available. Feel free to add new regressions/remove fixed etc. http://kernelnewbies.org/known_regressions List of Aces NameRegressions fixed since 21-Jun-2007 Adrian Bunk10

Re: [3/4] 2.6.23-rc6: known regressions

2007-09-12 Thread Michal Piotrowski
Hi all, Here is a list of some known regressions in 2.6.23-rc6. Feel free to add new regressions/remove fixed etc. http://kernelnewbies.org/known_regressions List of Aces NameRegressions fixed since 21-Jun-2007 Adrian Bunk10 Linus Torvalds

Re: [PATCH] Configurable tap interface MTU

2007-09-12 Thread Ed Swierk
On 9/11/07, Herbert Xu <[EMAIL PROTECTED]> wrote: > Please make it 65535 without an Ethernet header and 65521 > with an Ethernet header. Here is a revised patch that allows MTUs up to 65535 for tap interfaces and up to 65521 for tun interfaces. (If I set the MTU to 65521 on a tun interface, ping

[PATCH v3] Make the pr_*() family of macros in kernel.h complete

2007-09-12 Thread Emil Medve
Other/Some pr_*() macros are already defined in kernel.h, but pr_err() was defined multiple times in several other places Signed-off-by: Emil Medve <[EMAIL PROTECTED]> --- I'm writing a driver and I've been using the pr_*() macros from kernel.h and I was surprised not to find there pr_err() but

Re: [PATCH][MIPS][7/7] AR7: ethernet

2007-09-12 Thread Ralf Baechle
On Sat, Sep 08, 2007 at 02:23:00AM +0200, Matteo Croce wrote: > Driver for the cpmac 100M ethernet driver. > It works fine disabling napi support, enabling it gives a kernel panic > when the first IPv6 packet has to be forwarded. > Other than that works fine. > > Signed-off-by: Matteo Croce <[EMA

Re: [RFC PATCH 2/2] SCTP: Convert bind_addr_list locking to RCU

2007-09-12 Thread Paul E. McKenney
On Tue, Sep 11, 2007 at 10:56:09AM -0400, Vlad Yasevich wrote: > Hi Paul > > Thanks for review. I'll leave out the comments about > the ->valid usage since there are the same as the first patch > in the series. Fair enough. > Other questions/responses below... > > Paul E. McKenney wrote: > >>

Re: RFC: possible NAPI improvements to reduce interrupt rates for low traffic rates

2007-09-12 Thread Mandeep Baines
On 9/12/07, Stephen Hemminger <[EMAIL PROTECTED]> wrote: > But if you compare this to non-NAPI driver the same softirq > overhead happens. The problem is that for many older devices disabling IRQ's > require an expensive non-cached PCI access. Smarter, newer devices > all use MSI which is pure edge

Re: [PATCH] [-MM, FIX V3] e1000e: incorporate napi_struct changes from net-2.6.24.git

2007-09-12 Thread Kok, Auke
David Miller wrote: From: Robert Olsson <[EMAIL PROTECTED]> Date: Sat, 8 Sep 2007 09:53:49 +0200 Yes a correct observation. I've spotted this bug too and it caused by the policy change in the NAPI scheduling. Look at tx_cleaned. I suggest we revert this change for now. The tx_cleaned lo

Re: [NET] Nuke SET_NETDEV_DEVICE macro

2007-09-12 Thread Ralf Baechle
On Wed, Sep 12, 2007 at 05:27:13PM +0100, Ralf Baechle wrote: > It's been a useless no-op for long enough in 2.6 so I figured it's time to > remove it. The number of people that could object because they're > maintaining unified 2.4 and 2.6 drivers is probably rather small. Whops, wrong patch an

Re: RFC: possible NAPI improvements to reduce interrupt rates for low traffic rates

2007-09-12 Thread James Chapman
David Miller wrote: From: James Chapman <[EMAIL PROTECTED]> Date: Thu, 6 Sep 2007 15:16:00 +0100 First, do we need to encourage consistency in NAPI poll drivers? A survey of current NAPI drivers shows different strategies being used in their poll(). Some such as r8169 do the napi_complete() if

Re: RFC: possible NAPI improvements to reduce interrupt rates for low traffic rates

2007-09-12 Thread James Chapman
Stephen Hemminger wrote: On Wed, 12 Sep 2007 14:50:01 +0100 James Chapman <[EMAIL PROTECTED]> wrote: By low traffic, I assume you mean a rate at which the NAPI driver doesn't stay in polled mode. The problem is that that rate is getting higher all the time, as interface and CPU speeds increase.

[PATCH] net: Fix race when opening a proc file while a network namespace is exiting.

2007-09-12 Thread Eric W. Biederman
The problem: proc_net files remember which network namespace the are against but do not remember hold a reference count (as that would pin the network namespace). So we currently have a small window where the reference count on a network namespace may be incremented when opening a /proc file wh

Re: [PATCH 4/6] [IPROUTE2]: Overhead calculation is now done in the kernel

2007-09-12 Thread Andy Furniss
Jesper Dangaard Brouer wrote: commit 07a74a2613440fc1a68d0faa7235ed7027532d78 Author: Jesper Dangaard Brouer <[EMAIL PROTECTED]> Date: Tue Sep 11 16:59:58 2007 +0200 [IPROUTE2]: Overhead calculation is now done in the kernel. The only current user is HTB. HTB overhead argument is

[net-2.6.24][XFRM][patch 1/1] fix xfrm audit export symbol for allmodconfig

2007-09-12 Thread dlezcano
From: Daniel Lezcano <[EMAIL PROTECTED]> This patch fixes export symbol for: xfrm_audit_policy_add xfrm_audit_policy_delete xfrm_audit_state_add xfrm_audit_state_delete That allows xfrm_user and af_key to be compiled as module I didn't used EXPORT_SYMBOL_GPL to be

[net-2.6.24][XFRM][patch 0/1] fix allmodconfig

2007-09-12 Thread dlezcano
Fixes missing export symbols -- - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] veth: Cleanly handle a missing peer_tb argument on creation.

2007-09-12 Thread Eric W. Biederman
Pavel Emelyanov <[EMAIL PROTECTED]> writes: > Eric W. Biederman wrote: >> Pavel Emelyanov <[EMAIL PROTECTED]> writes: >> + } - tbp = peer_tb; - } else - tbp = tb; >>> The intention of this part was to get the same parameters for >>> peer as for the f

Re: new NAPI interface broken for POWER architecture?

2007-09-12 Thread Arnd Bergmann
On Wednesday 12 September 2007, Christoph Raisch wrote: > David Miller <[EMAIL PROTECTED]> wrote on 12.09.2007 14:50:04: > > > I agree that it should be fixed, but we should also fix the IRQ > > distribution scheme used on powerpc platforms which is totally > > broken in these cases. > > This is d

Re: [RFC PATCH 1/2] SCTP: Add RCU synchronization around sctp_localaddr_list

2007-09-12 Thread Paul E. McKenney
On Tue, Sep 11, 2007 at 10:05:10AM -0400, Vlad Yasevich wrote: > Sridhar, Paul > > Thanks for review. Some answers and questions below... NP! > Sridhar Samudrala wrote: > > Paul E. McKenney wrote: [ . . . ] > >>> if ((PF_INET == sk->sk_family) && > >>> (A

Re: [RFC 0/3] rfkill

2007-09-12 Thread David Miller
From: Dmitry Torokhov <[EMAIL PROTECTED]> Date: Mon, 10 Sep 2007 00:04:55 -0400 > Looks good, feel free to add > > Acked-by: Dmitry Torokhov <[EMAIL PROTECTED]> I've been loosely following these patches, they have gone through several revisions. Please resubmit all of these patches if the

Re: RFC: possible NAPI improvements to reduce interrupt rates for low traffic rates

2007-09-12 Thread David Miller
From: James Chapman <[EMAIL PROTECTED]> Date: Thu, 6 Sep 2007 15:16:00 +0100 > First, do we need to encourage consistency in NAPI poll drivers? A > survey of current NAPI drivers shows different strategies being used > in their poll(). Some such as r8169 do the napi_complete() if poll() > does les

Re: [PATCH 4/4] [IPROUTE2] iproute2: link_veth support bug fixes.

2007-09-12 Thread Eric W. Biederman
Pavel Emelyanov <[EMAIL PROTECTED]> writes: > [snip] > >> @@ -25,6 +26,3 @@ clean: >> >> LDLIBS += -ldl >> LDFLAGS += -Wl,-export-dynamic >> - >> -%.so: %.c >> -$(CC) $(CFLAGS) -shared $< -o $@ > > %) How do we get the .so file then? The code was built into iproute2, so we don't

Re: SO_BINDTODEVICE mismatch with man page & comments.

2007-09-12 Thread David Miller
From: Ben Greear <[EMAIL PROTECTED]> Date: Tue, 04 Sep 2007 15:45:14 -0700 > According to the comment in the net/core/sock.c code (in 2.6.20), I should be > able to pass a zero > optlen to the setsockopt method for SO_BINDTODEVICE: ... > > However, earlier in that method it returns -EINVAL if o

Re: net-2.6.24 build problem

2007-09-12 Thread Joy Latten
On Wed, 2007-09-12 at 07:18 -0700, David Miller wrote: > From: Stephen Hemminger <[EMAIL PROTECTED]> > Date: Wed, 12 Sep 2007 16:08:33 +0200 > > > ERROR: "xfrm_audit_state_delete" [net/key/af_key.ko] undefined! > > ERROR: "xfrm_audit_state_add" [net/key/af_key.ko] undefined! > > ERROR: "xfrm_audit

Re: [PATCH net-2.6.24] cxgb3 - napi update

2007-09-12 Thread David Miller
From: Divy Le Ray <[EMAIL PROTECTED]> Date: Sun, 09 Sep 2007 00:09:17 -0700 > From: Divy Le Ray <[EMAIL PROTECTED]> > > Embed napi_struct directly into sge_qset. > Use napi_schedule/napi_complete. > > Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> Patch applied, thanks a lot! - To unsubscribe f

  1   2   3   >