Re: Network Namespace status

2007-09-14 Thread Oliver Hartkopp
Eric W. Biederman wrote: Looking into my patch queue I have: 5 patches for cleaning up and making a per network namespace loopback device. 4 patches for making rtnetlink message processing per network namespace 1 patch for making AF_UNIX per network namespace 1 patch for making AF_PACKET per

Re: [PATCH 0/9 Rev3] Implement batching skb API and support in IPoIB

2007-09-14 Thread Bill Fink
On Mon, 27 Aug 2007, jamal wrote: On Sun, 2007-26-08 at 19:04 -0700, David Miller wrote: The transfer is much better behaved if we ACK every two full sized frames we copy into the receiver, and therefore don't stretch ACK, but at the cost of cpu utilization. The rx coalescing in

[PATCH][NETNS] Use list_for_each_entry_continue_reverse in setup_net

2007-09-14 Thread Pavel Emelyanov
I proposed introducing a list_for_each_entry_continue_reverse macro to be used in setup_net() when unrolling the failed -init callback. Here is the macro and some more cleanup in the setup_net() itself to remove one variable from the stack :) Minor, but the code looks nicer. Signed-off-by: Pavel

[PATCH][NETNS] Consolidate hashes creation in netdev_init()

2007-09-14 Thread Pavel Emelyanov
The dev_name_hash and the dev_index_hash are now booth kmalloc-ed (and each element is properly initialized as usually) so I think it's worth consolidating this code making it look nicer (and saving 28 bytes of .text section ;) ) Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED] --- diff --git

[PATCH 2/10 REV5] [core] Add skb_blist support for batching

2007-09-14 Thread Krishna Kumar
Introduce skb_blist, NETIF_F_BATCH_SKBS, use single API for batching/no-batching, etc. Signed-off-by: Krishna Kumar [EMAIL PROTECTED] --- include/linux/netdevice.h |8 ++-- net/core/dev.c| 29 ++--- 2 files changed, 32 insertions(+), 5 deletions(-)

[PATCH 0/10 REV5] Implement skb batching and support in IPoIB/E1000

2007-09-14 Thread Krishna Kumar
This set of patches implements the batching xmit capability, and adds support for batching in IPoIB and E1000 (E1000 driver changes is ported, thanks to changes taken from Jamal's code from an old kernel). List of changes from previous revision: 1. [Dave]

[RESEND] Implement batching skb API and support in IPoIB

2007-09-14 Thread Krishna Kumar2
Hi Dave, I am re-sending in case you didn't get this earlier. Also sending REV5 of the patch. I will send patch for e1000e on monday or tuesday after making the changes and testing over the weekend. thanks, - KK __ Hi Dave, David Miller [EMAIL PROTECTED] wrote on 08/29/2007

[PATCH 3/10 REV5] [sched] Modify qdisc_run to support batching

2007-09-14 Thread Krishna Kumar
Modify qdisc_run() to support batching. Modify callers of qdisc_run to use batching, modify qdisc_restart to implement batching. Signed-off-by: Krishna Kumar [EMAIL PROTECTED] --- include/linux/netdevice.h |2 include/net/pkt_sched.h | 17 +-- net/core/dev.c| 45

[PATCH 4/10 REV5] [ethtool] Add ethtool support

2007-09-14 Thread Krishna Kumar
Add ethtool support to enable/disable batching. Signed-off-by: Krishna Kumar [EMAIL PROTECTED] --- include/linux/ethtool.h |2 ++ include/linux/netdevice.h |2 ++ net/core/dev.c| 44 net/core/ethtool.c| 27

[PATCH 5/10 REV5] [IPoIB] Header file changes

2007-09-14 Thread Krishna Kumar
IPoIB header file changes to use batching. Signed-off-by: Krishna Kumar [EMAIL PROTECTED] --- ipoib.h |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff -ruNp org/drivers/infiniband/ulp/ipoib/ipoib.h new/drivers/infiniband/ulp/ipoib/ipoib.h ---

[PATCH 6/10 REV5] [IPoIB] CM Multicast changes

2007-09-14 Thread Krishna Kumar
IPoIB CM Multicast changes based on header file changes. Signed-off-by: Krishna Kumar [EMAIL PROTECTED] --- ipoib_cm.c| 13 + ipoib_multicast.c |4 ++-- 2 files changed, 11 insertions(+), 6 deletions(-) diff -ruNp org/drivers/infiniband/ulp/ipoib/ipoib_cm.c

Re: [BUG] tg3 cannot do PXE (loses MAC address) after soft reboot

2007-09-14 Thread Ingo Oeser
Michael Chan schrieb: On Thu, 2007-09-13 at 21:28 +0200, Lucas Nussbaum wrote: Erm, Wouldn't it be possible to print a warning when the driver loads, saying that the firmware is outdated ? It's possible, but would require the driver to parse the version string. The driver currently

[PATCH 1/10 REV5] [Doc] HOWTO Documentation for batching

2007-09-14 Thread Krishna Kumar
Add Documentation describing batching skb xmit capability. Signed-off-by: Krishna Kumar [EMAIL PROTECTED] --- batching_skb_xmit.txt | 107 ++ 1 files changed, 107 insertions(+) diff -ruNp org/Documentation/networking/batching_skb_xmit.txt

Re: [patch] sunrpc: make closing of old temporary sockets work (was: problems with lockd in 2.6.22.6)

2007-09-14 Thread Wolfgang Walter
Am Mittwoch, 12. September 2007 21:55 schrieb J. Bruce Fields: On Wed, Sep 12, 2007 at 09:40:57PM +0200, Wolfgang Walter wrote: On Wednesday 12 September 2007, J. Bruce Fields wrote: On Wed, Sep 12, 2007 at 04:14:06PM +0200, Neil Brown wrote: So it is in 2.6.21 and later and should

[PATCH 10/10 REV5] [E1000] Implement batching

2007-09-14 Thread Krishna Kumar
E1000: Implement batching capability (ported thanks to changes taken from Jamal). Signed-off-by: Krishna Kumar [EMAIL PROTECTED] --- e1000_main.c | 104 ++- 1 files changed, 75 insertions(+), 29 deletions(-) diff -ruNp

[PATCH 7/10 REV5] [IPoIB] Verbs changes

2007-09-14 Thread Krishna Kumar
IPoIB verb changes to use batching. Signed-off-by: Krishna Kumar [EMAIL PROTECTED] --- ipoib_verbs.c | 23 ++- 1 files changed, 14 insertions(+), 9 deletions(-) diff -ruNp org/drivers/infiniband/ulp/ipoib/ipoib_verbs.c new/drivers/infiniband/ulp/ipoib/ipoib_verbs.c ---

[PATCH 8/10 REV5] [IPoIB] Post and work completion handler changes

2007-09-14 Thread Krishna Kumar
IPoIB internal post and work completion handler changes. Signed-off-by: Krishna Kumar [EMAIL PROTECTED] --- ipoib_ib.c | 212 - 1 files changed, 168 insertions(+), 44 deletions(-) diff -ruNp org/drivers/infiniband/ulp/ipoib/ipoib_ib.c

[PATCH 9/10 REV5] [IPoIB] Implement batching

2007-09-14 Thread Krishna Kumar
IPoIB: implement the new batching API. Signed-off-by: Krishna Kumar [EMAIL PROTECTED] --- ipoib_main.c | 248 +++ 1 files changed, 168 insertions(+), 80 deletions(-) diff -ruNp org/drivers/infiniband/ulp/ipoib/ipoib_main.c

Re: Network Namespace status

2007-09-14 Thread Eric W. Biederman
Oliver Hartkopp [EMAIL PROTECTED] writes: can you send me your current AF_PACKET patch? I just want to update our recent post of the CAN (controller area network) subsystem (AF_CAN) which is (in some parts) similar to AF_PACKET. So i can take a look on it to provide the latest technique in

Re: [RFC] af_packet: allow disabling timestamps

2007-09-14 Thread Stephen Hemminger
On Thu, 13 Sep 2007 14:24:06 +0200 Eric Dumazet [EMAIL PROTECTED] wrote: On Thu, 13 Sep 2007 12:42:53 +0200 Stephen Hemminger [EMAIL PROTECTED] wrote: Currently, af_packet does not allow disabling timestamps. This patch changes that but doesn't force global timestamps on. This shows

[PATCH] Cleanup calling netdev notifiers

2007-09-14 Thread Pavel Emelyanov
The call_netdev_notifiers routine can successfully be used in the net/core_dev.c itself. This will save 6 lines of code and 62 ;) bytes of .text section. 62 is rather small, but I have one more patch saving ~30 bytes from netns code (sent to Eric), so altogether they can save some more

Re: [PATCH] sb1250-mac.c: De-typedef, de-volatile, de-etc...

2007-09-14 Thread Maciej W. Rozycki
Remove typedefs, volatiles and convert kmalloc()/memset() pairs to kcalloc(). Also reformat the surrounding clutter. Signed-off-by: Maciej W. Rozycki [EMAIL PROTECTED] --- On Thu, 13 Sep 2007, Jeff Garzik wrote: Net driver patches should apply on top of netdev-2.6.git#upstream, which is

[PATCH] NET_SB1250_MAC: Update Kconfig entry

2007-09-14 Thread Maciej W. Rozycki
The SB1250 network interfaces are Gigabit Ethernet ones. Move the Kconfig entry to the appropriate section and add some help text. Signed-off-by: Maciej W. Rozycki [EMAIL PROTECTED] --- It should be obvious; I hope the help text will be useful to somebody and will prevent from misclassifying

[PATCH] NET_SB1250_MAC: Rename to SB1250_MAC

2007-09-14 Thread Maciej W. Rozycki
Rename NET_SB1250_MAC to SB1250_MAC to follow the convention. Signed-off-by: Maciej W. Rozycki [EMAIL PROTECTED] --- The NET prefix seems to be used mainly for device groups (NET_ISA, NET_VENDOR_*, etc.) rather than single drivers and adds no information. I suggest it to be removed.

[PATCH] small cleanup for fib rules

2007-09-14 Thread Denis V. Lunev
From: Denis V. Lunev [EMAIL PROTECTED] This patch slightly cleanups FIB rules framework. rules_list as a pointer on struct fib_rules_ops is useless. It is always assigned with a static per/subsystem list in IPv4, IPv6 and DecNet. Signed-off-by: Denis V. Lunev [EMAIL PROTECTED] Acked-by: Alexey

[PATCH 2.6.24 1/2]S2io: Change kmalloc+memset to k[zc]alloc

2007-09-14 Thread Sivakumar Subramani
- Changed kmalloc+memset to k[zc]alloc as per Mariusz's patch [EMAIL PROTECTED] Signed-off-by: Sivakumar Subramani [EMAIL PROTECTED] Signed-off-by: Ramkrishna Vepa [EMAIL PROTECTED] --- diff -urpN org/drivers/net/s2io.c patch1/drivers/net/s2io.c --- org/drivers/net/s2io.c 2007-08-09

[PATCH 2.6.24 2/2]S2io: Removed unused feature - bimodal interrupts

2007-09-14 Thread Sivakumar Subramani
- Removed bimodal interrupt support - unused feature Signed-off-by: Sivakumar Subramani [EMAIL PROTECTED] Signed-off-by: Ramkrishna Vepa [EMAIL PROTECTED] --- diff -pNur prior/drivers/net/s2io.c patch_dir/drivers/net/s2io.c --- prior/drivers/net/s2io.c2007-09-06 11:31:04.0 -0700 +++

[PATCH 2.6.24 1/3]S2io: Added support set_mac_address driver entry point

2007-09-14 Thread Sivakumar Subramani
- Added set_mac_address driver entry point - Copying permanent mac address to dev-perm_addr - Incorporated following review comments from Jeff - Converted the macro to a function and removed call to memset - regarding function naming convention, for all callbacks and entry points

[PATCH 2.6.24 2/3]S2io: Support for add/delete/store/restore ethernet addresses

2007-09-14 Thread Sivakumar Subramani
- Support to add/delete/store/restore 64 and 128 Ethernet addresses for Xframe I and Xframe II respectively. Signed-off-by: Sreenivasa Honnur [EMAIL PROTECTED] --- diff -Nurp 2.0.26.5-1/drivers/net/s2io.c 2.0.26.5-2/drivers/net/s2io.c --- 2.0.26.5-1/drivers/net/s2io.c 2007-09-06

[PATCH 2.6.24 3/3]S2io: Updating transceiver information in ethtool function

2007-09-14 Thread Sivakumar Subramani
- Update transceiver information in ethtool function Signed-off-by: Sreenivasa Honnur [EMAIL PROTECTED] --- diff -urpN patch2/drivers/net/s2io.c patch3/drivers/net/s2io.c --- patch2/drivers/net/s2io.c 2007-09-06 18:31:27.0 +0530 +++ patch3/drivers/net/s2io.c 2007-09-06

wireless vs. network namespaces

2007-09-14 Thread Johannes Berg
Now that the network namespace work is in net-2.6.24, I'm wondering how wireless will be handling this. Is there any benefit at all to a wireless device supporting network namespaces? Should we, for now, set the new NETIF_F_NETNS_LOCAL flag for all mac80211 devices? If we do want to support

Re: [PATCH 3/10 REV5] [sched] Modify qdisc_run to support batching

2007-09-14 Thread Evgeniy Polyakov
Hi Krishna. On Fri, Sep 14, 2007 at 02:31:56PM +0530, Krishna Kumar ([EMAIL PROTECTED]) wrote: +int dev_add_skb_to_blist(struct sk_buff *skb, struct net_device *dev) +{ + if (!list_empty(ptype_all)) + dev_queue_xmit_nit(skb, dev); + + if (netif_needs_gso(dev, skb)) { +

[PATCH] sb1250-mac.c: Fix stats references

2007-09-14 Thread Maciej W. Rozycki
Fix build errors resulting from a recent commit that added references to stats through dev from sbdma_rx_process() and sbdma_tx_process(), but no definitions of that variable. Signed-off-by: Maciej W. Rozycki [EMAIL PROTECTED] --- This is probably the simplest fix possible, though at this

Re: [PATCH][NETNS] Use list_for_each_entry_continue_reverse in setup_net

2007-09-14 Thread Stephen Hemminger
On Fri, 14 Sep 2007 11:39:32 +0400 Pavel Emelyanov [EMAIL PROTECTED] wrote: I proposed introducing a list_for_each_entry_continue_reverse macro to be used in setup_net() when unrolling the failed -init callback. Here is the macro and some more cleanup in the setup_net() itself to remove

Re: [PATCH 10/10 REV5] [E1000] Implement batching

2007-09-14 Thread Evgeniy Polyakov
On Fri, Sep 14, 2007 at 02:34:42PM +0530, Krishna Kumar ([EMAIL PROTECTED]) wrote: @@ -3276,7 +3282,7 @@ e1000_xmit_frame(struct sk_buff *skb, st if (unlikely(skb-len = 0)) { dev_kfree_skb_any(skb); - return NETDEV_TX_OK; + return

Re: [PATCH 2/10 REV5] [core] Add skb_blist support for batching

2007-09-14 Thread Evgeniy Polyakov
On Fri, Sep 14, 2007 at 02:31:37PM +0530, Krishna Kumar ([EMAIL PROTECTED]) wrote: @@ -3566,6 +3579,13 @@ int register_netdevice(struct net_device } } + if (dev-features NETIF_F_BATCH_SKBS) { + /* Driver supports batching skb */ +

Re: [PATCH 0/10 REV5] Implement skb batching and support in IPoIB/E1000

2007-09-14 Thread Evgeniy Polyakov
Hi Krishna. On Fri, Sep 14, 2007 at 02:30:58PM +0530, Krishna Kumar ([EMAIL PROTECTED]) wrote: The retransmission problem reported earlier seems to happen when mthca is used as the underlying device, but when I tested ehca the retransmissions dropped to normal levels (around 2 times

Re: [ofa-general] InfiniBand/RDMA merge plans for 2.6.24

2007-09-14 Thread Evgeniy Polyakov
On Thu, Sep 13, 2007 at 01:59:21PM -0500, Steve Wise ([EMAIL PROTECTED]) wrote: Well, if it involves /sharing/ port space with the native stack, i.e. where port 1234 is IB but 1235 is Linux, pretty much all the networking devs have NAK'd that approach AFAICS. Jeff, I posted a fix that

Re: [PATCH v2] iw_cxgb3: Support iwarp-only interfaces to avoid 4-tuple conflicts.

2007-09-14 Thread Evgeniy Polyakov
On Thu, Sep 13, 2007 at 02:16:17PM -0500, Steve Wise ([EMAIL PROTECTED]) wrote: iw_cxgb3: Support iwarp-only interfaces to avoid 4-tuple conflicts. Version 2: - added a per-device mutex for the address and listening endpoints lists. - wait for all replies if sending multiple

Re: RFC: possible NAPI improvements to reduce interrupt rates for low traffic rates

2007-09-14 Thread jamal
On Wed, 2007-12-09 at 14:50 +0100, James Chapman wrote: By low traffic, I assume you mean a rate at which the NAPI driver doesn't stay in polled mode. i.e: one interupt per packet per napi poll which cause about 1-2 more IOs in comparison to the case where you didnt do NAPI. The problem is

RE: [PATCH v3] Make the pr_*() family of macros in kernel.h complete

2007-09-14 Thread Medve Emilian-EMMEDVE1
Hello Andrew, I realize this e-mail might be nuisance and time waster for you but I'm in need of advice. I apologize in advance for any commonsense cultural conventions I'm breaking. I sent the below patch to four e-mail lists and it lead to orthogonal conversations about how the entire kernel

[PATCH] sky2: fix PHY setup on FE-P

2007-09-14 Thread Stephen Hemminger
Marvell reported the following fix is necessary to get fe-plus chips to work. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- a/drivers/net/sky2.c2007-09-14 14:40:35.0 +0200 +++ b/drivers/net/sky2.c2007-09-14 14:41:00.0 +0200 @@ -488,11 +488,12 @@ static

TSO, TCP Cong control etc

2007-09-14 Thread jamal
Ive changed the subject to match content.. On Fri, 2007-14-09 at 03:20 -0400, Bill Fink wrote: On Mon, 27 Aug 2007, jamal wrote: Bill: who suggested (as per your email) the 75usec value and what was it based on measurement-wise? Belatedly getting back to this thread. There was a

Re: [PATCH] ucc_geth: fix compilation

2007-09-14 Thread Kumar Gala
On Sep 13, 2007, at 10:23 AM, Anton Vorontsov wrote: Currently qe_bd_t is used in the macro call -- dma_unmap_single, which is a no-op on PPC32, thus error is hidden today. Starting with 2.6.24, macro will be replaced by the empty static function, and erroneous use of qe_bd_t will trigger

Re: [patch] sunrpc: make closing of old temporary sockets work (was: problems with lockd in 2.6.22.6)

2007-09-14 Thread J. Bruce Fields
On Fri, Sep 14, 2007 at 11:12:30AM +0200, Wolfgang Walter wrote: Am Mittwoch, 12. September 2007 21:55 schrieb J. Bruce Fields: On Wed, Sep 12, 2007 at 09:40:57PM +0200, Wolfgang Walter wrote: On Wednesday 12 September 2007, J. Bruce Fields wrote: On Wed, Sep 12, 2007 at 04:14:06PM

Re: [PATCH][NETNS] Use list_for_each_entry_continue_reverse in setup_net

2007-09-14 Thread Eric W. Biederman
Stephen Hemminger [EMAIL PROTECTED] writes: On Fri, 14 Sep 2007 11:39:32 +0400 Pavel Emelyanov [EMAIL PROTECTED] wrote: I proposed introducing a list_for_each_entry_continue_reverse macro to be used in setup_net() when unrolling the failed -init callback. Here is the macro and some more

Re: wireless vs. network namespaces

2007-09-14 Thread Eric W. Biederman
Johannes Berg [EMAIL PROTECTED] writes: Now that the network namespace work is in net-2.6.24, I'm wondering how wireless will be handling this. Is there any benefit at all to a wireless device supporting network namespaces? Good question. Network namespaces are designed as a general tool so

Re: [PATCH] tehuti: driver for Tehuti 10GbE network adapters

2007-09-14 Thread Andy Gospodarek
On Tue, Sep 11, 2007 at 12:40:34PM -0400, Andy Gospodarek wrote: This introduces support for a line of 10GbE adapters made by Tehuti Networks. An attempt to get this included was made a few months ago and since the driver has been re-factored based on Jeff's suggestions. You can download

Re: [PATCH v2] iw_cxgb3: Support iwarp-only interfaces to avoid 4-tuple conflicts.

2007-09-14 Thread Roland Dreier
Maybe you should automatically create an alias each time new interface is added so that admin would not care about proper aliases? I agree that makes much more sense from a user interface point of view. Unfortunately an alias without an address doesn't make sense, so there doesn't seem to be

Re: InfiniBand/RDMA merge plans for 2.6.24

2007-09-14 Thread Roland Dreier
The patch is just needed to pick up broadcast MTU size instead of hard coding 2K right now. SKB allocation shouldn't be different with Ethernet Jambo Frame and IPoIB-CM which 64K MTU. I don't understand why it's different. Could you please explain this? It's exactly the same problem as

Re: [ofa-general] InfiniBand/RDMA merge plans for 2.6.24

2007-09-14 Thread Roland Dreier
I've been meaning to track down the bnx2 iscsi offload patch to look and see if this issue is addressed, since the same problem seems to exist: it seems an iscsi connection and a main stack tcp connection might share the same 4-tuple unless something is done to avoid that happening.

Re: [PATCH] tehuti: driver for Tehuti 10GbE network adapters

2007-09-14 Thread Jeff Garzik
Andy Gospodarek wrote: On Tue, Sep 11, 2007 at 12:40:34PM -0400, Andy Gospodarek wrote: This introduces support for a line of 10GbE adapters made by Tehuti Networks. An attempt to get this included was made a few months ago and since the driver has been re-factored based on Jeff's suggestions.

Re: [PATCH v3] Make the pr_*() family of macros in kernel.h complete

2007-09-14 Thread Satyam Sharma
-Original Message- From: Medve Emilian-EMMEDVE1 Sent: Wednesday, September 12, 2007 11:40 AM To: [EMAIL PROTECTED]; netdev@vger.kernel.org; [EMAIL PROTECTED]; [EMAIL PROTECTED] Cc: Medve Emilian-EMMEDVE1 ... no maintainer explicitly copied on the original mail who'd push this

Re: [PATCH v3] Make the pr_*() family of macros in kernel.h complete

2007-09-14 Thread Randy Dunlap
On Fri, 14 Sep 2007 22:11:59 +0530 Satyam Sharma wrote: -Original Message- From: Medve Emilian-EMMEDVE1 Sent: Wednesday, September 12, 2007 11:40 AM To: [EMAIL PROTECTED]; netdev@vger.kernel.org; [EMAIL PROTECTED]; [EMAIL PROTECTED] Cc: Medve Emilian-EMMEDVE1 ... no

Re: [PATCH 0/9 Rev3] Implement batching skb API and support in IPoIB

2007-09-14 Thread David Miller
From: Bill Fink [EMAIL PROTECTED] Date: Fri, 14 Sep 2007 03:20:55 -0400 TSO disabled performance is always better than equivalent TSO enabled performance. With TSO enabled, the optimum performance is indeed at a TX/RX interrupt coalescing value of 75 usec. With TSO disabled, performance is

Re: [PATCH][NETNS] Use list_for_each_entry_continue_reverse in setup_net

2007-09-14 Thread Eric W. Biederman
Pavel Emelyanov [EMAIL PROTECTED] writes: I proposed introducing a list_for_each_entry_continue_reverse macro to be used in setup_net() when unrolling the failed -init callback. Here is the macro and some more cleanup in the setup_net() itself to remove one variable from the stack :) Minor,

RE: [ofa-general] InfiniBand/RDMA merge plans for 2.6.24

2007-09-14 Thread Sean Hefty
OK -- just to make sure I'm understanding what you're saying: have you confirmed that your proposed patches actually fix the issue? Not directly. I cannot easily test kernel patches on our larger, production clusters. We've seen the issue with specific applications on 512 and 1024 cores, but

Re: [BUG] tg3 cannot do PXE (loses MAC address) after soft reboot

2007-09-14 Thread Michael Chan
On Fri, 2007-09-14 at 10:14 +0200, Ingo Oeser wrote: Michael Chan schrieb: On Thu, 2007-09-13 at 21:28 +0200, Lucas Nussbaum wrote: Erm, Wouldn't it be possible to print a warning when the driver loads, saying that the firmware is outdated ? It's possible, but would require the

Re: wireless vs. network namespaces

2007-09-14 Thread Johannes Berg
On Fri, 2007-09-14 at 09:31 -0600, Eric W. Biederman wrote: Now that the network namespace work is in net-2.6.24, I'm wondering how wireless will be handling this. Is there any benefit at all to a wireless device supporting network namespaces? Good question. Network namespaces are

Re: [git patches] net driver fixes

2007-09-14 Thread Dan Williams
On Thu, 2007-09-13 at 01:30 -0400, Jeff Garzik wrote: Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream-linus to receive the following updates: drivers/net/atl1/atl1_main.c | 19 +++

Re: [git patches] net driver fixes

2007-09-14 Thread Jeff Garzik
Dan Williams wrote: WTF? why would the default be to _not_ propagate carrier state? Are there some mitigating circumstances that require this driver to not notify the stack of carrier on/off? Userspace stuff really should know about the carrier state, and this disables it by default. The

[PATCH] mv643xx_eth: Fix tx_bytes stats calculation

2007-09-14 Thread Dale Farnsworth
Reported by Corey Minyard [EMAIL PROTECTED] --- drivers/net/mv643xx_eth.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mv643xx_eth.c b/drivers/net/mv643xx_eth.c index 1799eee..6a117e9 100644 --- a/drivers/net/mv643xx_eth.c +++ b/drivers/net/mv643xx_eth.c @@

Re: InfiniBand/RDMA merge plans for 2.6.24

2007-09-14 Thread Shirley Ma
IPoIB CM handles this properly by gathering together single pages in skbs' fragment lists. - R. Then can we reuse IPoIB CM code here? Thanks Shirley - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: e1000 driver and samba

2007-09-14 Thread L F
On 9/14/07, Francois Romieu [EMAIL PROTECTED] wrote: For the 8169 or the 8110, try 2.6.23-rc6 + http://www.fr.zoreil.com/people/francois/misc/20070903-2.6.23-rc5-r8169-test.patch Thank you, I will give that a whirl also, because there are some machine builds which will not have Intel boards in

[PATCH 4/8] SCTP: Implete SCTP-AUTH parameter processing

2007-09-14 Thread Vlad Yasevich
Implement processing for the CHUNKS, RANDOM, and HMAC parameters and deal with how this parameters are effected by association restarts. In particular, during unexpeted INIT processing, we need to reply with parameters from the original INIT chunk. Also, after restart, we need to update the old

[PATCH 2/8] SCTP: Implement SCTP-AUTH internals

2007-09-14 Thread Vlad Yasevich
This patch implements the internals operations of the AUTH, such as key computation and storage. It also adds necessary variables to the SCTP data structures. Signed-off-by: Vlad Yasevich [EMAIL PROTECTED] --- include/net/sctp/auth.h | 112 +++ include/net/sctp/constants.h | 49 +++-

[PATCH 5/8] SCTP: Enable the sending of the AUTH chunk.

2007-09-14 Thread Vlad Yasevich
SCTP-AUTH, Section 6.2: Endpoints MUST send all requested chunks authenticated where this has been requested by the peer. The other chunks MAY be sent authenticated or not. If endpoint pair shared keys are used, one of them MUST be selected for authentication. To send chunks in

[PATCH 7/8] SCTP: API updates to suport SCTP-AUTH extensions.

2007-09-14 Thread Vlad Yasevich
Add SCTP-AUTH API. The API implemented here was agreed to between implementors at the 9th SCTP Interop. It will be documented in the next revision of the SCTP socket API spec. Signed-off-by: Vlad Yasevich [EMAIL PROTECTED] --- include/net/sctp/auth.h | 16 +++ include/net/sctp/ulpevent.h

[RFC PATCH 0/8] Implement SCTP-AUTH specification.

2007-09-14 Thread Vlad Yasevich
Hi All The following series of 8 patches is the implementation of SCTP-AUTH spec (RFC 4895) that was tested at the 9th SCTP Interop. The code is based on the implementation of the Supported Extensions parameter that was send out separately for inclusion into 2.6.24. I'd really appreciate people

[PATCH 8/8] SCTP: Tie ADD-IP and AUTH functionality as required by spec.

2007-09-14 Thread Vlad Yasevich
ADD-IP spec requires AUTH. It is, in fact, dangerous without AUTH. So, disable ADD-IP functionality if the peer claims to support ADD-IP, but not AUTH. Signed-off-by: Vlad Yasevich [EMAIL PROTECTED] --- include/net/sctp/structs.h |1 + net/sctp/sm_make_chunk.c | 13 - 2 files

[PATCH 6/8] SCTP: Implement the receive and verification of AUTH chunk

2007-09-14 Thread Vlad Yasevich
This patch implements the receive path needed to process authenticated chunks. Add ability to process the AUTH chunk and handle edge cases for authenticated COOKIE-ECHO as well. Signed-off-by: Vlad Yasevich [EMAIL PROTECTED] --- include/net/sctp/constants.h |4 +- include/net/sctp/sm.h

[PATCH 3/8] SCTP: Implement SCTP-AUTH initializations.

2007-09-14 Thread Vlad Yasevich
The patch initializes AUTH related members of the generic SCTP structures and provides a way to enable/disable auth extension. Signed-off-by: Vlad Yasevich [EMAIL PROTECTED] --- net/sctp/associola.c | 34 +++ net/sctp/endpointola.c | 83

[PATCH 1/8] SCTP: protocol definitions for SCTP-AUTH implementation

2007-09-14 Thread Vlad Yasevich
Signed-off-by: Vlad Yasevich [EMAIL PROTECTED] --- include/linux/sctp.h | 100 +- 1 files changed, 99 insertions(+), 1 deletions(-) diff --git a/include/linux/sctp.h b/include/linux/sctp.h index f4d717b..5eb38cc 100644 --- a/include/linux/sctp.h

Re: [git patches] net driver fixes

2007-09-14 Thread Dan Williams
On Fri, 2007-09-14 at 14:17 -0400, Jeff Garzik wrote: Dan Williams wrote: WTF? why would the default be to _not_ propagate carrier state? Are there some mitigating circumstances that require this driver to not notify the stack of carrier on/off? Userspace stuff really should know about

Re: e1000 driver and samba

2007-09-14 Thread Francois Romieu
L F [EMAIL PROTECTED] : [...] Now, the machine worked when it was using an onboard Realtek 8169 chipset on a 945G board from ASUS, but it worked slowly. I upgraded to a P965 chipset, started using the realtek driver for the 8110B on that board.. and started getting consistent samba errors. I

Re: e1000 driver and samba

2007-09-14 Thread L F
On 9/14/07, Kok, Auke [EMAIL PROTECTED] wrote: this slowness might have been masking the issue That is possible. However, it worked for upwards of twelve months without an error. I have not yet seen other reports of this issue, and it would be interesting to see if the stack or driver is

Re: Distributed storage. Move away from char device ioctls.

2007-09-14 Thread Jeff Garzik
Evgeniy Polyakov wrote: Hi. I'm pleased to announce fourth release of the distributed storage subsystem, which allows to form a storage on top of remote and local nodes, which in turn can be exported to another storage as a node to form tree-like storages. This release includes new

[v2 PATCH 8/8] SCTP: Tie ADD-IP and AUTH functionality as required by spec.

2007-09-14 Thread Vlad Yasevich
[.. forgot to refresh the patch, the other version has compile problems ..] ADD-IP spec requires AUTH. It is, in fact, dangerous without AUTH. So, disable ADD-IP functionality if the peer claims to support ADD-IP, but not AUTH. Signed-off-by: Vlad Yasevich [EMAIL PROTECTED] ---

Re: [git patches] net driver fixes

2007-09-14 Thread Jay Vosburgh
Dan Williams [EMAIL PROTECTED] wrote: [...] I admit that I probably don't understand the system architecture of where ehea would be used, but would this cause /sys/class/net/ethX/carrier to be TRUE even if the device has no carrier? That seems quite wrong IMHO. When does ehea not have a carrier?

Re: 2.6.23-rc4-mm1 list_add corruption in networking code

2007-09-14 Thread Randy Dunlap
[adding netdev] On Fri, 14 Sep 2007 10:08:03 -0400 Mathieu Desnoyers wrote: Hi Andrew, My P4 is crashing about once a day, started with 2.6.23-rc4-mm1, with errors that seems related to network code. Here is the latest BUG: (sorry, my console log cuts it at 80 cols) Mathieu [

Re: [PATCH net-2.6.24] introduce MAC_FMT/MAC_ARG

2007-09-14 Thread Joe Perches
David? Did you ever get a chance to look at this? Do you want me to rebase it against your newer net-2.4.26? http://repo.or.cz/w/linux-2.6/trivial-mods.git I've inlined the include changes, but the entire patch is quite large. (300KB) MAC address format changes: UPPER-lower case changes

Re: [PATCH net-2.6.24] introduce MAC_FMT/MAC_ARG

2007-09-14 Thread David Miller
From: Joe Perches [EMAIL PROTECTED] Date: Fri, 14 Sep 2007 12:41:48 -0700 David? Did you ever get a chance to look at this? Do you want me to rebase it against your newer net-2.4.26? http://repo.or.cz/w/linux-2.6/trivial-mods.git I just got back from 2 weeks of travelling, sit tight :-) -

Re: [PATCH 1/10 REV5] [Doc] HOWTO Documentation for batching

2007-09-14 Thread Randy Dunlap
On Fri, 14 Sep 2007 14:31:18 +0530 Krishna Kumar wrote: Add Documentation describing batching skb xmit capability. Signed-off-by: Krishna Kumar [EMAIL PROTECTED] --- batching_skb_xmit.txt | 107 ++ 1 files changed, 107 insertions(+)

Re: [PATCH][NETNS] Use list_for_each_entry_continue_reverse in setup_net

2007-09-14 Thread Stephen Hemminger
On Fri, 14 Sep 2007 08:41:07 -0600 [EMAIL PROTECTED] (Eric W. Biederman) wrote: Stephen Hemminger [EMAIL PROTECTED] writes: On Fri, 14 Sep 2007 11:39:32 +0400 Pavel Emelyanov [EMAIL PROTECTED] wrote: I proposed introducing a list_for_each_entry_continue_reverse macro to be used in

Re: [ofa-general] InfiniBand/RDMA merge plans for 2.6.24

2007-09-14 Thread Michael Chan
On Fri, 2007-09-14 at 09:18 -0700, Roland Dreier wrote: However, do you have any plans to support iSCSI offload for targets? Also, looking at the first CNIC patch, I can't help but notice that you seem to have at least some support for iWARP there. How does the CNIC look? Does it share the

Re: SO_BINDTODEVICE mismatch with man page comments.

2007-09-14 Thread David Miller
From: Ben Greear [EMAIL PROTECTED] Date: Tue, 04 Sep 2007 15:45:14 -0700 According to the comment in the net/core/sock.c code (in 2.6.20), I should be able to pass a zero optlen to the setsockopt method for SO_BINDTODEVICE: ... However, earlier in that method it returns -EINVAL if optlen is

Re: [git patches] net driver fixes

2007-09-14 Thread Dan Williams
On Fri, 2007-09-14 at 12:19 -0700, Jay Vosburgh wrote: Dan Williams [EMAIL PROTECTED] wrote: [...] I admit that I probably don't understand the system architecture of where ehea would be used, but would this cause /sys/class/net/ethX/carrier to be TRUE even if the device has no carrier?

Re: [PATCH v3] Make the pr_*() family of macros in kernel.h complete

2007-09-14 Thread Andrew Morton
On Fri, 14 Sep 2007 06:27:04 -0700 Medve Emilian-EMMEDVE1 [EMAIL PROTECTED] wrote: I realize this e-mail might be nuisance and time waster for you but I'm in need of advice. I apologize in advance for any commonsense cultural conventions I'm breaking. I sent the below patch to four e-mail

Re: [PATCH net-2.6.23-rc5] ipsec interfamily route handling fix

2007-09-14 Thread David Miller
From: Joakim Koskela [EMAIL PROTECTED] Date: Thu, 6 Sep 2007 19:00:10 +0300 This patch addresses a couple of issues related to interfamily ipsec modes. The problem is that the structure of the routing info changes with the family during the __xfrmX_bundle_create, which hasn't been taken

Re: Distributed storage. Move away from char device ioctls.

2007-09-14 Thread Al Boldi
Jeff Garzik wrote: Evgeniy Polyakov wrote: Hi. I'm pleased to announce fourth release of the distributed storage subsystem, which allows to form a storage on top of remote and local nodes, which in turn can be exported to another storage as a node to form tree-like storages. This

Re: 2.6.23-rc4-mm1 list_add corruption in networking code

2007-09-14 Thread Andrew Morton
On Fri, 14 Sep 2007 09:25:52 -0700 Randy Dunlap [EMAIL PROTECTED] wrote: [adding netdev] yup. I wonder if the net developers are setting CONFIG_DEBUG_LIST On Fri, 14 Sep 2007 10:08:03 -0400 Mathieu Desnoyers wrote: Hi Andrew, My P4 is crashing about once a day, started with

Pull request for 'r8169-for-jeff-20070914' branch

2007-09-14 Thread Francois Romieu
Please pull from branch 'r8169-for-jeff-20070914' in repository git://electric-eye.fr.zoreil.com/home/romieu/linux-2.6.git r8169-for-jeff-20070914 to get the fixes below. Distance from 'netdev-2.6/upstream' (18d256761aa268fd2fb113c4fd26c400431f1dc1

Re: [git patches] net driver fixes

2007-09-14 Thread Jay Vosburgh
Dan Williams [EMAIL PROTECTED] wrote: [...] So essentially the ehea device has a 1(+) external ports that may/may not be connected, but all lpars share the physical hardware itself, which is quite happy to let all the lpars talk to each other essentially via loopback even if there is no actual

Re: e1000 driver and samba

2007-09-14 Thread Kok, Auke
L F wrote: On 9/14/07, Kok, Auke [EMAIL PROTECTED] wrote: this slowness might have been masking the issue That is possible. However, it worked for upwards of twelve months without an error. I have not yet seen other reports of this issue, and it would be interesting to see if the stack or

Re: Distributed storage. Move away from char device ioctls.

2007-09-14 Thread J. Bruce Fields
On Fri, Sep 14, 2007 at 05:14:53PM -0400, Jeff Garzik wrote: J. Bruce Fields wrote: On Fri, Sep 14, 2007 at 03:07:46PM -0400, Jeff Garzik wrote: I've been waiting for years for a smart person to come along and write a POSIX-only distributed filesystem. What exactly do you mean by

Fw: [PATCH] Add ICMPMsgStats MIB (RFC 4293) [rev 2]

2007-09-14 Thread David Stevens
Background: RFC 4293 deprecates existing individual, named ICMP type counters to be replaced with the ICMPMsgStatsTable. This table includes entries for both IPv4 and IPv6, and requires counting of all ICMP types, whether or not the machine implements the type. These patches remove (but not

Re: Distributed storage. Move away from char device ioctls.

2007-09-14 Thread J. Bruce Fields
On Fri, Sep 14, 2007 at 03:07:46PM -0400, Jeff Garzik wrote: My thoughts. But first a disclaimer: Perhaps you will recall me as one of the people who really reads all your patches, and examines your code and proposals closely. So, with that in mind... I question the value of distributed

Re: [PATCH] Add IP1000A Driver into Kernel (2007/09/12)

2007-09-14 Thread Francois Romieu
Jesse Huang [EMAIL PROTECTED] : [...] Change Logs: Add IP1000A Driver to kernel tree. It misses the needed Kconfig, Makefile and pci_ids changes from Stefan Lippers-Hollmann. -- Ueimor - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL

Re: Distributed storage. Move away from char device ioctls.

2007-09-14 Thread Jeff Garzik
J. Bruce Fields wrote: On Fri, Sep 14, 2007 at 03:07:46PM -0400, Jeff Garzik wrote: I've been waiting for years for a smart person to come along and write a POSIX-only distributed filesystem. What exactly do you mean by POSIX-only? Don't bother supporting attributes, file modes, and other

Re: [PATCH][NETNS] Use list_for_each_entry_continue_reverse in setup_net

2007-09-14 Thread Eric W. Biederman
Stephen Hemminger [EMAIL PROTECTED] writes: Could we just make it so dev-init is not allowed to fail? Then it can be a void function and the nasty unwind code can go? Unfortunately we need to allocate memory, and perform other operations that can fail. That's the nature of the problem. So I

  1   2   >