Re: [PATCH] jumbo all-NICs ethtool count cleanup

2007-09-15 Thread Sam Ravnborg
Hi Jeff. You wrote: > The hooks ->self_test_count() and ->get_stats_count() are now unused > in the main tree. So I'm suprised to see more lines added than deleted: > 35 files changed, 346 insertions(+), 246 deletions(-) Puzzled - may need a bit more coffee (morning here).. Sam - To un

[PATCH] jumbo all-NICs ethtool count cleanup

2007-09-15 Thread Jeff Garzik
Just checked this in locally... The hooks ->self_test_count() and ->get_stats_count() are now unused in the main tree. (based off of latest davem/net-2.6.24.git) drivers/net/3c59x.c | 11 +++- drivers/net/8139cp.c| 11 +++- drivers/net/8139too.c

Re: e1000 driver and samba

2007-09-15 Thread Kok, Auke
L F wrote: > tx_deferred_ok: 486 >> this one I wonder about, and might cause delays, I'll have to look >> up what it exactly could implicate though. > Please do and let me know. samba 3.0.26 helped, but the issue is > still there. ok, from the spec: tx_deferred_ok is what is in the DC stats re

Re: Please pull 'adm8211' branch of wireless-2.6

2007-09-15 Thread Michael Wu
On Sunday 16 September 2007 00:50, David Miller wrote: > From: Michael Wu <[EMAIL PROTECTED]> > Date: Sun, 16 Sep 2007 00:47:40 -0400 > > > Huh? How does a driver use NAPI if it can't pass a struct net_device? > > It is now managed by a struct napi_struct which you can embed into any > object you l

Re: Please pull 'adm8211' branch of wireless-2.6

2007-09-15 Thread David Miller
From: Michael Wu <[EMAIL PROTECTED]> Date: Sun, 16 Sep 2007 00:47:40 -0400 > Huh? How does a driver use NAPI if it can't pass a struct net_device? It is now managed by a struct napi_struct which you can embed into any object you like. NAPI is now totally disconnected from the network device stru

Re: [PATCH 1/1] ipv6: remove redundant RTM_DELLINK message

2007-09-15 Thread David Miller
From: Milan Kocian <[EMAIL PROTECTED]> Date: Thu, 13 Sep 2007 11:57:38 +0200 > remove useless message. We get right message from other subsystem. ... > Signed-off-by: Milan Kocian <[EMAIL PROTECTED]> Applied, thanks Milan. - To unsubscribe from this list: send the line "unsubscribe netdev" in th

Re: Please pull 'adm8211' branch of wireless-2.6

2007-09-15 Thread Michael Wu
On Saturday 15 September 2007 20:56, Jeff Garzik wrote: > >>> + if (flags & IFF_PROMISC) > >>> + dev->flags |= IEEE80211_HW_RX_INCLUDES_FCS; > >>> + else > >>> + dev->flags &= ~IEEE80211_HW_RX_INCLUDES_FCS; > >> > >> why does promisc dictate inclusion of FCS? > > > > Because that's

Re: [PATCH] CIPSO: remove duplicated code in the cipso_v4_*_getattr() functions

2007-09-15 Thread David Miller
From: Paul Moore <[EMAIL PROTECTED]> Date: Wed, 12 Sep 2007 15:29:38 -0400 > The bulk of the CIPSO option parsing/processing in the cipso_v4_sock_getattr() > and cipso_v4_skb_getattr() functions are identical, the only real difference > being where the functions obtain the CIPSO option itself. Th

Re: e1000 driver and samba

2007-09-15 Thread L F
On 9/15/07, James Chapman <[EMAIL PROTECTED]> wrote: > Are these long frames expected in your network? What is the MTU of the > transmitting clients? Perhaps this might explain why reads work (because > data is coming from the Linux box so the packets have smaller MTU) while > writes cause delays o

Re: e1000 driver and samba

2007-09-15 Thread L F
> >>> tx_deferred_ok: 486 > > this one I wonder about, and might cause delays, I'll have to look up what it > exactly could implicate though. Please do and let me know. samba 3.0.26 helped, but the issue is still there. > those are not "long frames" but the number of bytes the hardware counte

Re: Please pull 'adm8211' branch of wireless-2.6

2007-09-15 Thread Jeff Garzik
John W. Linville wrote: On Sat, Sep 15, 2007 at 11:25:49AM -0700, David Miller wrote: 4) Integrate linville's adm8211 driver into net-2.6.24 We'll see how well that goes. It sounds like Michael will be respinning in response to Jeff's comments...? It's already pulled, so I assume it will be

Re: Please pull 'adm8211' branch of wireless-2.6

2007-09-15 Thread John W. Linville
On Sat, Sep 15, 2007 at 11:25:49AM -0700, David Miller wrote: > From: "John W. Linville" <[EMAIL PROTECTED]> > Date: Sat, 15 Sep 2007 13:00:18 -0400 > > > Come to think of it, this driver will depend on some of the mac80211 > > patches Dave M. has queued for net-2.6.24. Perhaps it would be better

[PATCH 3/3] Blackfin EMAC driver: Add phy abstraction layer supporting in bfin_emac driver

2007-09-15 Thread Bryan Wu
- add MDIO functions and register mdio bus - add phy abstraction layer (PAL) functions and use PAL API - test on STAMP537 board Signed-off-by: Bryan Wu <[EMAIL PROTECTED]> --- drivers/net/bfin_mac.c | 311 +--- drivers/net/bfin_mac.h | 53 ++-

[PATCH 1/3] Blackfin EMAC driver: add function to change the MAC address

2007-09-15 Thread Bryan Wu
>From 157dfddae50708a716c2a42a314eccb9621d8793 Mon Sep 17 00:00:00 2001 From: Alex Landau <[EMAIL PROTECTED]> Date: Sun, 5 Aug 2007 15:58:03 +0800 Subject: [PATCH] Blackfin Ethernet MAC driver: add function to change the MAC address Alex Landau writes in the forums: Previously, changing the MAC

[PATCH 2/3] Blackfin EMAC driver: add power management interface and change the bf537mac_reset to bf537mac_disable

2007-09-15 Thread Bryan Wu
Signed-off-by: Bryan Wu <[EMAIL PROTECTED]> --- drivers/net/bfin_mac.c | 23 +++ 1 files changed, 19 insertions(+), 4 deletions(-) diff --git a/drivers/net/bfin_mac.c b/drivers/net/bfin_mac.c index 8d61ca9..3015385 100644 --- a/drivers/net/bfin_mac.c +++ b/drivers/net/bfin_

Re: r8169: slow samba performance

2007-09-15 Thread David Madsen
> Do you see a difference in the system load too, say a few lines of 'vmstat 1' > ? This is running on a dual core machine which explains the 50/50 sys/idle in vmstat. with 8168 hack (patch #0002): writes: isis tmp # dd if=/dev/zero of=test.fil bs=1M count=1000 1000+0 records in 1000+0 records

Re: Please pull 'adm8211' branch of wireless-2.6

2007-09-15 Thread Jeff Garzik
Michael Wu wrote: On Saturday 15 September 2007 17:32, Jeff Garzik wrote: Review summary: many minor issues, only one major one: irq handler loop CCing me would help. Sorry. I just hit 'reply to all'... apparently you were not CC'd on the submission. + if (flags & IFF_PROMISC)

Re: Please pull 'adm8211' branch of wireless-2.6

2007-09-15 Thread Michael Wu
On Saturday 15 September 2007 17:32, Jeff Garzik wrote: > Review summary: many minor issues, only one major one: irq handler loop > CCing me would help. > John W. Linville wrote: > > +static unsigned int tx_ring_size __read_mostly = 16; > > +static unsigned int rx_ring_size __read_mostly = 16; >

Re: Please pull 'adm8211' branch of wireless-2.6

2007-09-15 Thread Michael Wu
On Saturday 15 September 2007 09:22, John W. Linville wrote: > It is reverse-engineered and still has more magic > initialization numbers than I'd like, but overall I think it would > be better to have this upstream than not. > Not entirely accurate, as ADMtek released specs (publically downloadabl

Re: [PATCH 3/3] netxen: ethtool fixes

2007-09-15 Thread Jeff Garzik
Dhananjay Phadke wrote: Resubmitting the patch. This patch improves ethtool support for printing correct ring statistics, segmentation offload status, etc. Signed-off by: Dhananjay Phadke <[EMAIL PROTECTED]> is this for 2.6.23 or 2.6.24? - To unsubscribe from this list: send the line "uns

Re: [PATCH 3/3]: sk98lin: neuter device to only SysKonnect boards

2007-09-15 Thread Jeff Garzik
applied 1-3 as a single commit, so that git-bisect will not break Jeff - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] mv643xx_eth: Fix tx_bytes stats calculation

2007-09-15 Thread Jeff Garzik
Dale Farnsworth wrote: Reported by Corey Minyard <[EMAIL PROTECTED]> --- drivers/net/mv643xx_eth.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) applied - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordom

Re: [PATCH] ucc_geth: fix compilation

2007-09-15 Thread Jeff Garzik
Anton Vorontsov wrote: Currently qe_bd_t is used in the macro call -- dma_unmap_single, which is a no-op on PPC32, thus error is hidden today. Starting with 2.6.24, macro will be replaced by the empty static function, and erroneous use of qe_bd_t will trigger compilation error. Signed-off-by: An

Re: Please pull 'fixes-jgarzik' branch of wireless-2.6

2007-09-15 Thread Jeff Garzik
John W. Linville wrote: Jeff, Two more fixes for 2.6.23, including one for kernel.org bug 8937... Thanks, John --- The following changes since commit 0d4cbb5e7f60b2f1a4d8b7f6ea4cc264262c7a01: Linus Torvalds (1): Linux 2.6.23-rc6 are available in the git repository at: git://git

Re: READ ME Major net-2.6.24 rebase

2007-09-15 Thread Jeff Garzik
David Miller wrote: Andrew, this means you can stop pulling in Jeff's tree for the time being, everything is in my tree above. ACK - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/ma

READ ME Major net-2.6.24 rebase

2007-09-15 Thread David Miller
I've fully rebased the tree at: kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6.24.git Also, I've fully integrated both John Linville's wireless infrastructure and driver updates, as well as Jeff Garzik's upstream netdevice changes. This should resolve all of the merging conflicts th

Re: Please pull 'adm8211' branch of wireless-2.6

2007-09-15 Thread Jeff Garzik
Review summary: many minor issues, only one major one: irq handler loop John W. Linville wrote: +static unsigned int tx_ring_size __read_mostly = 16; +static unsigned int rx_ring_size __read_mostly = 16; + +module_param(tx_ring_size, uint, 0); +module_param(rx_ring_size, uint, 0); should b

Re: ne driver crashes when unloaded in 2.6.22.6

2007-09-15 Thread Chris Rankin
--- Dan Williams <[EMAIL PROTECTED]> wrote: > On Wed, 2007-09-12 at 19:23 +0100, Chris Rankin wrote: > > Hmm, apparently not. The light on the card goes out though, so could this > > just be a lack of > driver > > support? > > Likely, yes. I've been trawling the Internet for 8390 specifications

Re: e1000 driver and samba

2007-09-15 Thread Kok, Auke
James Chapman wrote: Kok, Auke wrote: L F wrote: On 9/14/07, Kok, Auke <[EMAIL PROTECTED]> wrote: this slowness might have been masking the issue That is possible. However, it worked for upwards of twelve months without an error. I have not yet seen other reports of this issue, and it would

Re: Please pull 'adm8211' branch of wireless-2.6

2007-09-15 Thread David Miller
From: "John W. Linville" <[EMAIL PROTECTED]> Date: Sat, 15 Sep 2007 13:00:18 -0400 > Come to think of it, this driver will depend on some of the mac80211 > patches Dave M. has queued for net-2.6.24. Perhaps it would be better > if Dave were to merge it with his tree? > > Jeff, if you have no obj

Re: [PATCH] IPV4 : convert rt_check_expire() from softirq processing to workqueue

2007-09-15 Thread David Miller
From: Eric Dumazet <[EMAIL PROTECTED]> Date: Wed, 12 Sep 2007 15:34:44 +0200 > On loaded/big hosts, rt_check_expire() if of litle use, because it > generally breaks out of its main loop because of a jiffies change. > > It can take a long time (read : timer invocations) to actually > scan the whol

Re: Distributed storage. Move away from char device ioctls.

2007-09-15 Thread Andreas Dilger
On Sep 15, 2007 12:20 -0400, Robin Humble wrote: > On Sat, Sep 15, 2007 at 10:35:16AM -0400, Jeff Garzik wrote: > >Lustre is tilted far too much towards high-priced storage, > > many (most?) Lustre deployments are with SATA and md raid5 and GigE - > can't get much cheaper than that. I have to ag

Re: e1000 driver and samba

2007-09-15 Thread James Chapman
Kok, Auke wrote: L F wrote: On 9/14/07, Kok, Auke <[EMAIL PROTECTED]> wrote: this slowness might have been masking the issue That is possible. However, it worked for upwards of twelve months without an error. I have not yet seen other reports of this issue, and it would be interesting to see

Re: Distributed storage. Move away from char device ioctls.

2007-09-15 Thread Andreas Dilger
On Sep 15, 2007 16:29 +0400, Evgeniy Polyakov wrote: > Yes, block device itself is not able to scale well, but it is the place > for redundancy, since filesystem will just fail if underlying device > does not work correctly and FS actually does not know about where it > should place redundancy bit

Re: Distributed storage. Move away from char device ioctls.

2007-09-15 Thread Robin Humble
On Sat, Sep 15, 2007 at 10:35:16AM -0400, Jeff Garzik wrote: >Robin Humble wrote: >>On Fri, Sep 14, 2007 at 03:07:46PM -0400, Jeff Garzik wrote: >>>I've been waiting for years for a smart person to come along and write a >>>POSIX-only distributed filesystem. >>it's called Lustre. >>works well, sca

ip monitor bug

2007-09-15 Thread Benoit PAPILLAULT
Hi there, I'd like to get feedbacks on the following scenario and whether it's a bug or not. Moreover, i'd like to know how to make a route permanent (ie never removed by the kernel). # configure eth0 with IP 1.1.1.1 ifconfig eth0 1.1.1.1 up # show routes added by the kernel (expected result

Re: [PATCH v2] iw_cxgb3: Support "iwarp-only" interfaces to avoid 4-tuple conflicts.

2007-09-15 Thread Steve Wise
Evgeniy Polyakov wrote: On Thu, Sep 13, 2007 at 02:16:17PM -0500, Steve Wise ([EMAIL PROTECTED]) wrote: iw_cxgb3: Support "iwarp-only" interfaces to avoid 4-tuple conflicts. Version 2: - added a per-device mutex for the address and listening endpoints lists. - wait for all replies if sendin

Re: Distributed storage. Move away from char device ioctls.

2007-09-15 Thread Jeff Garzik
Robin Humble wrote: On Fri, Sep 14, 2007 at 03:07:46PM -0400, Jeff Garzik wrote: It is my hope that you will put your skills towards a distributed filesystem :) Of the current solutions, GFS (currently in kernel) scales poorly, and NFS v4.1 is amazingly bloated and overly complex. I've been

Re: Distributed storage. Move away from char device ioctls.

2007-09-15 Thread Robin Humble
On Fri, Sep 14, 2007 at 03:07:46PM -0400, Jeff Garzik wrote: >It is my hope that you will put your skills towards a distributed >filesystem :) Of the current solutions, GFS (currently in kernel) >scales poorly, and NFS v4.1 is amazingly bloated and overly complex. > >I've been waiting for years

Re: [ofa-general] [PATCH v2] iw_cxgb3: Support "iwarp-only" interfaces to avoid 4-tuple conflicts.

2007-09-15 Thread Steve Wise
Sean Hefty wrote: The iWARP driver must translate all listens on address 0.0.0.0 to the set of rdma-only ip addresses for the device in question. This prevents incoming connect requests to the TCP ipaddresses from going up the rdma stack. I've only given this a high level review at this poin

Re: [ofa-general] InfiniBand/RDMA merge plans for 2.6.24

2007-09-15 Thread Steve Wise
Roland Dreier wrote: > I was about to post v2 of my patch to avoid port space collisions with > the native stack. Can we get that 2.6.24? It is high priority > IMO. I've tried to solicit review on it, but I think folks are > reluctant... ;-) I would like to get this in, but I'm still at

Please pull 'upstream-davem' branch of wireless-2.6

2007-09-15 Thread John W. Linville
Dave, Some more stuff for 2.6.24... Individual patches here: http://www.kernel.org/pub/linux/kernel/people/linville/wireless-2.6/upstream-davem/ I hope you had a nice time in .eu! :-) John P.S. Jeff, there is a one-line change to rtl8187 in there too... --- The following changes s

Please pull 'upstream-jgarzik' branch of wireless-2.6

2007-09-15 Thread John W. Linville
Jeff, A few more for 2.6.24... Thanks, John --- The following changes since commit 18d256761aa268fd2fb113c4fd26c400431f1dc1: Jeff Garzik (1): Merge branch 'stats' into upstream are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless

Please pull 'fixes-davem' branch of wireless-2.6

2007-09-15 Thread John W. Linville
Dave, A few more fixes targetted for 2.6.23, including a couple of warning fixes. As usual, the individual patches are available here: http://www.kernel.org/pub/linux/kernel/people/linville/wireless-2.6/fixes-davem/ Thanks, John --- The following changes since commit 0d4cbb5e7f60b2f

Please pull 'fixes-jgarzik' branch of wireless-2.6

2007-09-15 Thread John W. Linville
Jeff, Two more fixes for 2.6.23, including one for kernel.org bug 8937... Thanks, John --- The following changes since commit 0d4cbb5e7f60b2f1a4d8b7f6ea4cc264262c7a01: Linus Torvalds (1): Linux 2.6.23-rc6 are available in the git repository at: git://git.kernel.org/pub/scm/linux/

Re: e1000 driver and samba

2007-09-15 Thread L F
I also upgraded to samba-3.0.26-1 and so far the problem seems significantly less frequent and limited, unfortunately, to the 'silent' corruption. I am still running with HW checksumming off, with a new cable (cat6, even though it's 50cm long, so I could probably be running chicken wire), on the or

Re: Distributed storage. Move away from char device ioctls.

2007-09-15 Thread Evgeniy Polyakov
Hi Mike. On Fri, Sep 14, 2007 at 10:54:56PM -0400, Mike Snitzer ([EMAIL PROTECTED]) wrote: > This distributed storage is very much needed; even if it were to act > as a more capable/performant replacement for NBD (or MD+NBD) in the > near term. Many high availability applications don't _need_ al

Re: Distributed storage. Move away from char device ioctls.

2007-09-15 Thread Evgeniy Polyakov
Hi Jeff. On Fri, Sep 14, 2007 at 03:07:46PM -0400, Jeff Garzik ([EMAIL PROTECTED]) wrote: > >Further TODO list includes: > >* implement optional saving of mirroring/linear information on the remote > > nodes (simple) > >* new redundancy algorithm (complex) > >* some thoughts about distributed

Re: e1000 driver and samba

2007-09-15 Thread L F
On 9/15/07, Bill Fink <[EMAIL PROTECTED]> wrote: > Would it be worth a shot to try disabling the receiver hardware > checksumming (ethtool -K ethX rx off)? I just did, unfortunately it doesn't seem to change much. In the various attempts, however, I seem to have improved something, maybe. As I ment

Re: [RFC PATCH v0.2] net driver: mpc52xx fec

2007-09-15 Thread Domen Puncer
On 03/09/07 09:57 -0600, Grant Likely wrote: > On 9/2/07, Domen Puncer <[EMAIL PROTECTED]> wrote: > > Hi! > > > > new in this version: > > - fixed stuff that was commented on. > > - added 7-wire support (compile at least, if someone has the hardware, > > please test!) > > - ethtool support

Re: [PATCH] Move the definition of pr_err() into kernel.h

2007-09-15 Thread Jan Engelhardt
On Sep 12 2007 12:59, Stephen Hemminger wrote: >> Other pr_*() macros are already defined in kernel.h, but pr_err() was defined >> multiple times in several other places >> >> Signed-off-by: Emil Medve <[EMAIL PROTECTED]> > >pr_error seems better than pr_err > >Please add the full set: > pr