Re: InfiniBand/RDMA merge plans for 2.6.24

2007-09-19 Thread Michael S. Tsirkin
Missing from this list (IMPORTANT patch!): [ofa-general] [PATCH 2 of 2] IB/mlx4: Handle new FW requirement for send request prefetching, for WQE sg lists (Posted by me to list on Sept 4) {patch header: This is an addendum to Roland's commit 0e6e74162164d908edf7889ac66dca09e7505745 (June

Re: [PATCH 5/7] CAN: Add virtual CAN netdevice driver

2007-09-19 Thread Oliver Hartkopp
Urs Thuermann wrote: Now I think we should consider removing the loopback code from can_send() and demand from each CAN driver that it *has to* implement this itself. I also thought about this solution, which would remove the 'loopback' parameter in vcan.c and some loopback code in

Re: NetXen driver causing slab corruption in -RT kernels

2007-09-19 Thread Dhananjay Phadke
That 00 0e 1e ... is netxen's mac address, so sounds like the NIC is dumping a frame in the skb already freed (and poisoned) by the stack. I suppose -RT kernels preempt the softirq, giving a chance for this race. The netxen driver doesn't seem to clear the mapped address of the skb in rx

Re: Pull request for 'r8169-for-jeff-20070914' branch

2007-09-19 Thread Francois Romieu
Jeff Garzik [EMAIL PROTECTED] : [...] For fixes, please base off of linux-2.6.git. I can't push this upstream immediately, since it pulls in for-2.6.24 stuff. I will do it this evening. -- Ueimor - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to

Re: [PATCH 1/3] Blackfin EMAC driver: add function to change the MAC address

2007-09-19 Thread Bryan Wu
On Wed, 2007-09-19 at 06:07 +0800, Jeff Garzik wrote: Bryan Wu wrote: From 157dfddae50708a716c2a42a314eccb9621d8793 Mon Sep 17 00:00:00 2001 From: Alex Landau [EMAIL PROTECTED] Date: Sun, 5 Aug 2007 15:58:03 +0800 Subject: [PATCH] Blackfin Ethernet MAC driver: add function to change

Re: [FIX NETLINK] properly check arguments to netlink_bind()

2007-09-19 Thread Holger Eitzenberger
David Miller [EMAIL PROTECTED] writes: while going through going netlink code I found out that netlink_bind() does not properly check bind parameters. I checked both 2.6.23-rc1 as well as 2.6.16.53, both are affected. Firstly, you patch compares the address _pointer_ against the minimum

drop association of connection-less socket

2007-09-19 Thread Ulrich Drepper
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 The Linux man page for connect(2) currently says: Connectionless sockets may dissolve the association by connecting to an address with the sa_family member of sockaddr set to AF_UNSPEC. No such wording is in the POSIX definition which only says

Re: bnx2 dirver's firmware images

2007-09-19 Thread Denys Vlasenko
On Tuesday 18 September 2007 21:05, Michael Chan wrote: The bnx2 firmware changes quite frequently. A new driver quite often requires new firmware to work correctly. Splitting them up makes things difficult for the user. sounds reasonable. I see that bnx2 has support for unpacking gzipped

Re: [PATCH 2/7] CAN: Add PF_CAN core module

2007-09-19 Thread Patrick McHardy
Urs Thuermann wrote: Patrick McHardy [EMAIL PROTECTED] writes: +HLIST_HEAD(rx_dev_list); Same here (static). Can't be static since it's used in proc.c. But __read_mostly might make sense. What exactly is the effect of __read_mostly? Is that in a separate ELF section? Where is

Re: [PATCH 3/7] CAN: Add raw protocol

2007-09-19 Thread Patrick McHardy
Urs Thuermann wrote: Patrick McHardy [EMAIL PROTECTED] writes: +config CAN_RAW_USER +bool Allow non-root users to access Raw CAN Protocol sockets +depends on CAN_RAW Would it be much more trouble for userspace to use capabilities for this? This would allow userspace to always know

Re: [PATCH 3/3] [PPP] L2TP: Fix skb handling in pppol2tp_xmit

2007-09-19 Thread James Chapman
Herbert Xu wrote: On Tue, Sep 18, 2007 at 09:19:33PM +0100, James Chapman wrote: This one causes my test system to lock up. I'll investigate. Please don't apply this patch for now. Sorry, I added a double-free on the skb after ip_queue_xmit. Please try this one instead. - /* Free the

Re: [PATCH 5/7] CAN: Add virtual CAN netdevice driver

2007-09-19 Thread Patrick McHardy
Urs Thuermann wrote: Patrick McHardy [EMAIL PROTECTED] writes: +static int loopback; /* loopback testing. Default: 0 (Off) */ +module_param(loopback, int, S_IRUGO); +MODULE_PARM_DESC(loopback, Loop back frames (for testing). Default: 0 (Off)); I would still prefer to have this on a

Re: [PATCH 3/3] [PPP] L2TP: Fix skb handling in pppol2tp_xmit

2007-09-19 Thread Herbert Xu
On Wed, Sep 19, 2007 at 09:43:49AM +0100, James Chapman wrote: -discard: -/* Free the new skb. Caller will free original skb. */ -if (skb2 != skb) -kfree_skb(skb2); abort: -return 0; +/* Free the original skb */ +kfree_skb(skb); +return 1; }

RE: [PATCH] phy: export phy_mii_ioctl

2007-09-19 Thread Pedro Luis D. L.
Hello Jon, I´m also working with a Phytec pcm030, but I can´t get it booted... Which kernel are you using? I tried to apply the 7 bestcomm patches from Sylvain and patch over these with this new ones that Domen released. The base kernel I´m using is 2.6.22.6 from kernel.org. Although I used the

RE: [PATCH] phy: export phy_mii_ioctl

2007-09-19 Thread Pedro Luis D. L.
Hello Jon, I´m also working with a Phytec pcm030, but I can´t get it booted... Which kernel are you using? I tried to apply the 7 bestcomm patches from Sylvain and patch over these with this new ones that Domen released. The base kernel I´m using is 2.6.22.6 from kernel.org. Although I used the

Re: [RFC] af_packet: allow disabling timestamps

2007-09-19 Thread Evgeniy Polyakov
On Fri, Sep 14, 2007 at 12:26:42PM +0200, Stephen Hemminger ([EMAIL PROTECTED]) wrote: No, then we end up timestamping all the packets, even if they get dropped by packet filter. The change in 2.6.24 allows dhclient (and rstp) to only call hires clock source for packets they want, not all

Info about updates

2007-09-19 Thread Sergej Stepanov
Hello list. For our embedded platform i wrote the driver for micrel phy and integrated it into drivers/net/phy. I need general information about how do i send the patch to the netdev-list. Thanks for any advice and sorry. Best regards Sergej. -- Sergej I. Stepanov IDS GmbH Nobelstr. 18, Zim.

Re: SFQ qdisc crashes with limit of 2 packets

2007-09-19 Thread Alexey Kuznetsov
Hello! OK the off-by-one prevents an out-of-bounds array access, Yes, this is not off-by-one (off-by-two, to be more exact :-)). Maximal queue length is really limited by SFQ_DEPTH-2, because: 1. SFQ keeps list of queue lengths in array of length SFQ_DEPTH. This means length of queue must

Re: Please pull 'iwlwifi' branch of wireless-2.6

2007-09-19 Thread Christoph Hellwig
On Tue, Sep 18, 2007 at 02:50:40PM -0400, John W. Linville wrote: Jeff Dave, Here it is -- it's big, it's...well...beautiful in its own way...well, at least it seems to work... :-) There are some outstanding issues. The driver does more than it probably should under the covers instead

Re: [PATCH] phy: export phy_mii_ioctl

2007-09-19 Thread Juergen Beisert
Pedro, On Wednesday 19 September 2007 10:54, Pedro Luis D. L. wrote: I´m also working with a Phytec pcm030, but I can´t get it booted... Which kernel are you using? I tried to apply the 7 bestcomm patches from Sylvain and patch over these with this new ones that Domen released. The base

RE: [PATCH] tehuti: driver for Tehuti 10GbE network adapters

2007-09-19 Thread Alexander Indenbaum
Christoph, Thank you for reviewing the driver and giving us this feedback. Our goal is the driver which is in full accordance with all Linux kernel style guidelines. Please note the fist Tehuti driver submission to netdev was by Andy on Mars 15 and since the driver has been heavily re-factored

Re: Please pull 'b43' branch of wireless-2.6

2007-09-19 Thread Johannes Berg
On Tue, 2007-09-18 at 16:28 -0400, John W. Linville wrote: This series adds the b43 and b43legacy drivers, as well as the ssb bus infrastructure upon which they depend. Shouldn't we be getting rid of bcm43xx at the same time? johannes signature.asc Description: This is a digitally signed

Re: [PATCH v2] iw_cxgb3: Support iwarp-only interfaces to avoid 4-tuple conflicts.

2007-09-19 Thread Evgeniy Polyakov
Hi Steve. On Mon, Sep 17, 2007 at 10:25:04AM -0500, Steve Wise ([EMAIL PROTECTED]) wrote: Does creating the whole new netdevice is a too big overhead, or is it considered bad idea? I think its too big overhead, and pretty invasive on the low level cxgb3 driver. I think having a device in

[patch 0/1] s390 maintainer change

2007-09-19 Thread Ursula Braun
-- Please update MAINTAINERS file because of changes in the s390 networking team Regards, Ursula Braun - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[patch 1/1] From: Ursula Braun [EMAIL PROTECTED]

2007-09-19 Thread Ursula Braun
[PATCH] s390 MAINTAINERS maintainer change for s390 networking Signed-off-by: Ursula Braun [EMAIL PROTECTED] --- MAINTAINERS | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) === Index:

[Bug, PATCH and another Bug] Was: Fix refcounting problem with netif_rx_reschedule()

2007-09-19 Thread Krishna Kumar
Hi Dave, After applying Roland's NAPI patch, system panics when I run multiple thread iperf (no stack trace at this time, it shows that the panic is in net_tx_action). I think the problem is: In the done budget case, ipoib_poll calls netif_rx_complete() netif_rx_complete()

Re: [0/7] [PPP]: Fix shared/cloned/non-linear skb bugs (was: malformed captured packets)

2007-09-19 Thread Herbert Xu
On Tue, Sep 11, 2007 at 08:12:50PM +0200, Toralf Förster wrote: I'm wondering why some UDP packets of the MS messenger protocol (with the usual text like please click at www.we-destroy-your-computer.com) always have wrong check sums regardless whether sniffed at ppp0 or eth0 interface.

Re: [PATCH] phy: export phy_mii_ioctl

2007-09-19 Thread Domen Puncer
On 18/09/07 15:17 -0400, Jon Smirl wrote: On 9/18/07, Domen Puncer [EMAIL PROTECTED] wrote: More testing and getting it to work properly on Phytec pcm030 would be great. I compiled it as a module: CC [M] drivers/net/fec_mpc52xx/fec.o drivers/net/fec_mpc52xx/fec.c:613: warning:

[PATCH] smc91x Hitachi Solution Engine (SuperH) Support

2007-09-19 Thread Nobuhiro Iwamatsu
Hi, all. This patch supports Hitachi Solution Engine (SuperH) of smc91x. Please apply this patch . regards, Nobuhiro -- Nobuhiro Iwamatsu E-Mail : [EMAIL PROTECTED] GPG ID : 3170EBE9 Signed-off-by: Nobuhiro Iwamatsu [EMAIL PROTECTED] diff --git a/drivers/net/smc91x.h

Re: wrong arp query with policy routing

2007-09-19 Thread Marco Berizzi
Marco Berizzi wrote: HDSL.225 dev eth0 scope link ADSL.129 dev eth0 scope link src ADSL.134 ADSL.128/29 dev eth1 proto kernel scope link src ADSL.134 HDSL.224/27 dev eth1 proto kernel scope link src HDSL.254 127.0.0.0/8 dev lo scope link default via HDSL.225 dev eth0 metric 1

Re: [LARTC] ifb and ppp

2007-09-19 Thread Patrick McHardy
Frithjof Hammer wrote: My goal is to setup an ingress traffic shaping on my PPPOE DSL line with ifb. My old imq stuff used iptables marks (like 'iptables -t mangle -A PREROUTING -p tcp --sport 22 -m length --length :500 -j MARK --set-mark 31') to classify the traffic and since i am lazy,

Re: SFQ qdisc crashes with limit of 2 packets

2007-09-19 Thread Patrick McHardy
Alexey Kuznetsov wrote: Hello! CCed Alexey just to be safe, but I think the patch should be fine. Yes. But what'a about limit == 1? tc prohibits this case, but it is still not nice to have the bug in kernel. Plus, code remains creepy, the check + if (++sch-q.qlen q-limit) {

Re: [Bug, PATCH and another Bug] Was: Fix refcounting problem with netif_rx_reschedule()

2007-09-19 Thread Jan-Bernd Themann
Hi, On Wednesday 19 September 2007 13:54, Krishna Kumar wrote: CPU#1: ipoib_poll(budget=100) { A. process 100 skbs B. netif_rx_complete() Process unrelated interrupts; executes slower than steps C, D, E on CPU#2 F. ib_req_notify_cq() (no missed completions,

Re: Please pull 'iwlwifi' branch of wireless-2.6

2007-09-19 Thread Jeff Garzik
David Miller wrote: Jeff, if you have no objections I'll pull this into net-2.6.24 Given that there is now a large backlog of new drivers to review, I think the preferred course of action would be to queue them into -mm (via net-2.6.24) for wider review and testing, and then make sure they

Re: [RFC][NET_SCHED] explict hold dev tx lock

2007-09-19 Thread jamal
On Mon, 2007-17-09 at 22:48 -0400, jamal wrote: Nothing much has changed from what it was before. The only difference is we let go of the queue lock before grabbing the tx lock which never mattered for LLTX. Once we grab the tx lock it is the same logic and so far is working well on both

Re: bnx2 dirver's firmware images

2007-09-19 Thread Bill Davidsen
David Miller wrote: From: Michael Chan [EMAIL PROTECTED] Date: Tue, 18 Sep 2007 13:05:51 -0700 The bnx2 firmware changes quite frequently. A new driver quite often requires new firmware to work correctly. Splitting them up makes things difficult for the user. The firmware in tg3 is a lot

Re: [PATCH] phy: export phy_mii_ioctl

2007-09-19 Thread Jon Smirl
On 9/19/07, Pedro Luis D. L. [EMAIL PROTECTED] wrote: Hello Jon, I´m also working with a Phytec pcm030, but I can´t get it booted... Which kernel are you using? I tried to apply the 7 bestcomm patches from Sylvain and patch over these with this new ones that Domen released. The base kernel

[NET-2.6.24][VETH][patch 0/1] fix kernel Oops for veth

2007-09-19 Thread dlezcano
When I tryed the veth driver, I fall into a kernel oops. qemu login: Oops: [#1] Modules linked in: CPU:0 EIP:0060:[c0265c9e]Not tainted VLI EFLAGS: 0202 (2.6.23-rc6-g754f885d-dirty #33) EIP is at __linkwatch_run_queue+0x6a/0x175 eax: c7fc9550 ebx: 6b6b6b6b ecx: c3360c80

[PATCH] PHYLIB: IRQ event workqueue handling fixes

2007-09-19 Thread Maciej W. Rozycki
Keep track of disable_irq_nosync() invocations and call enable_irq() the right number of times if work has been cancelled that would include them. Signed-off-by: Maciej W. Rozycki [EMAIL PROTECTED] --- Now that the call to flush_work_keventd() (problematic because of rtnl_mutex being held)

Re: e1000 driver and samba

2007-09-19 Thread L F
Well, the issue seems to have gone away as of this morning, but I am somewhat unsure as to why. Placement of some things were modified so as to allow shorter cables. Now there are 3' CAT6 cables everywhere except for the 15' cable between the two switches. All the cables are new, high quality

Re: drop association of connection-less socket

2007-09-19 Thread Ulrich Drepper
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I guess the request is not that useful. The family of the socket is determined earlier so to undo this it takes more of an effort. I managed to get by for most cases without this change so no action needed. - -- ➧ Ulrich Drepper ➧ Red Hat, Inc. ➧

Re: [RFC PATCH] 2.6.22.6 netfilter: sk_setup_caps in ip_make_route_harder

2007-09-19 Thread Patrick McHardy
lepton wrote: Hi, For local src packets, it is better to update sk_route_caps in ip_route_me_harder. This seems like a good idea to me. But why only for local src (address) packets? This function can also be used for locally generated packet that have been (f.i.) NATed to a foreign

Re: Please pull 'iwlwifi' branch of wireless-2.6

2007-09-19 Thread John W. Linville
On Wed, Sep 19, 2007 at 09:28:52AM -0400, Jeff Garzik wrote: David Miller wrote: Jeff, if you have no objections I'll pull this into net-2.6.24 Given that there is now a large backlog of new drivers to review, I think the preferred course of action would be to queue them into -mm (via

[PATCH] PHYLIB: Fix an interrupt loop potential when halting

2007-09-19 Thread Maciej W. Rozycki
Ensure the PHY_HALTED state is not entered with the IRQ asserted as it could lead to an interrupt loop. Signed-off-by: Maciej W. Rozycki [EMAIL PROTECTED] --- There is a small window in phy_stop(), where the state of the PHY machine indicates it has been halted, but its interrupt output might

Re: [PATCH 2.6.23-rc6] NETWORKING : Edge Triggered EPOLLOUT events get missed for TCP sockets

2007-09-19 Thread Davide Libenzi
On Wed, 19 Sep 2007, Nagendra Tomar wrote: [ ... ] Seems like epoll ate your message too :) Can you repost your bug report and the patch? - Davide - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

follow-up: discrepancy with POSIX

2007-09-19 Thread Ulrich Drepper
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 As a follow up to my question from yesterday on the netdev list what I think is a real problem. Either in the kernel or in the POSIX spec. The POSIX spec currently says this about SOCK_DGRAM sockets: If address is a null address for the

Re: S2io: Support for add/delete/store/restore ethernet addresses

2007-09-19 Thread Jeff Garzik
S2io: Support for add/delete/store/restore ethernet addresses - Support to add/delete/store/restore 64 and 128 Ethernet addresses for Xframe I and Xframe II respectively. Signed-off-by: Sreenivasa Honnur [EMAIL PROTECTED] Please resend this against the latest

Re: [RFC PATCH] 2.6.22.6 netfilter: sk_setup_caps in ip_make_route_harder

2007-09-19 Thread Patrick McHardy
Patrick McHardy wrote: lepton wrote: Hi, For local src packets, it is better to update sk_route_caps in ip_route_me_harder. This seems like a good idea to me. But why only for local src (address) packets? This function can also be used for locally generated packet that have been

Re: [RESEND][PATCH 2/4 Rev-3] Add new timeval_to_sec function

2007-09-19 Thread Stephen Hemminger
On Wed, 19 Sep 2007 09:24:07 +0530 Varun Chandramohan [EMAIL PROTECTED] wrote: A new function for converting timeval to time_t is added in netlink.h. Its a common function used in differentplaces. The reason for adding this function in netlink.h is that its used by netlink for stats purpose.

[PATCH] ucc_geth: remove unnecessary asm/ocp.h include from ucc_geth_mii.c

2007-09-19 Thread Timur Tabi
ucc_geth_mii.c includes asm/ocp.h, but it never needed it. With commit 2f6c9d961081dc7b109eb19166244bcb2a5dfc28, the asm-powerpc = asm-ppc link is removed, and so ucc_geth_mii.c can no longer include include/asm-ppc/ocp.h, so the compile fails. This patch removes the #include line.

Re: new NAPI interface broken

2007-09-19 Thread Roland Dreier
One other thing I observed is that I can not unload the module as the ref counter of the eth device is too low. I haven't tracked down the source of this problem yet. I suspect that this is because netif_rx_reschedule() was missing a dev_hold() to match the dev_put() in

[PATCH 1/4] Blackfin EMAC driver: add function to change the MAC address

2007-09-19 Thread Bryan Wu
From: Alex Landau [EMAIL PROTECTED] Date: Wed, 19 Sep 2007 23:14:18 +0800 Subject: [PATCH] Blackfin EMAC driver: add function to change the MAC address Alex Landau writes in the forums: Previously, changing the MAC address (e.g. via ifconfig) resulted in a generic function to be called that

[PATCH net-2.6.24] eHEA: poll function update for new NAPI scheme

2007-09-19 Thread Jan-Bernd Themann
Update of ehea_poll function to work with new NAPI scheme. Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED] --- Hi David, this patch is built upon the patches provided by Mel Gorman (2.6.23-rc6-mm1: Build failure on ppc64 drivers/net/ehea/ehea_main.c) and Roland Dreier ([PATCH net-2.6.24]

[PATCH 2/4] Blackfin EMAC driver: add power management interface and change the bf537mac_reset to bf537mac_disable

2007-09-19 Thread Bryan Wu
Signed-off-by: Bryan Wu [EMAIL PROTECTED] Acked-by: Jeff Garzik [EMAIL PROTECTED] --- drivers/net/bfin_mac.c | 23 +++ 1 files changed, 19 insertions(+), 4 deletions(-) diff --git a/drivers/net/bfin_mac.c b/drivers/net/bfin_mac.c index ead7be9..5cb4433 100644 ---

[PATCH 3/4] Blackfin EMAC driver: Add phy abstraction layer supporting in bfin_emac driver

2007-09-19 Thread Bryan Wu
- add MDIO functions and register mdio bus - add phy abstraction layer (PAL) functions and use PAL API - test on STAMP537 board Signed-off-by: Bryan Wu [EMAIL PROTECTED] Acked-by: Jeff Garzik [EMAIL PROTECTED] --- drivers/net/bfin_mac.c | 311 +---

[PATCH 4/4] Blackfin EMAC driver: add a select for the PHYLIB of this driver

2007-09-19 Thread Bryan Wu
Since we are adding requirement for the PHYLIB for this driver, there should be a select for that Cc: Robin Getz [EMAIL PROTECTED] Signed-off-by: Bryan Wu [EMAIL PROTECTED] --- drivers/net/Kconfig |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/net/Kconfig

Re: [ofa-general] [PATCH] RDMA/CMA: Implement rdma_resolve_ip retry enhancement.

2007-09-19 Thread Roland Dreier
Thanks for the patch... If an application is calling rdma_resolve_ip() and a status of -ENODATA is returned from addr_resolve_local/remote(), the timeout mechanism waits until the application's timeout occurs before rechecking the address resolution status; the application will wait

Re: new NAPI interface broken

2007-09-19 Thread Jan-Bernd Themann
On Wednesday 19 September 2007 17:33, Roland Dreier wrote: One other thing I observed is that I can not unload the module as the ref counter of the eth device is too low. I haven't tracked down the source of this problem yet. I suspect that this is because netif_rx_reschedule() was

Re: follow-up: discrepancy with POSIX

2007-09-19 Thread Andi Kleen
Ulrich Drepper [EMAIL PROTECTED] writes: fd = socket(AT_INET6, ...) connect(fd, ...some IPv6 address...) struct sockaddr_in6 sin6 = { .sin6_family = AF_INET6 }; connect(fd, sin6, sizeof (sin6)); The standard way to undo connect is to use AF_UNSPEC. Code to handle that for

Re: [PATCH] tehuti: driver for Tehuti 10GbE network adapters

2007-09-19 Thread 'Christoph Hellwig'
On Wed, Sep 19, 2007 at 12:44:33PM +0200, Alexander Indenbaum wrote: - please don't redefine the dma mask constants - please use the firmware loader instead of mebedding a firmware image Could you give us some pointers to docs and examples of firmware loader? I'm not sure I'm

Re: [RFC PATCH] 2.6.22.6 netfilter: sk_setup_caps in ip_make_route_harder

2007-09-19 Thread lepton
Yes, you are right. What do you think about this: For all packets can be sent out, we just disable all things in sk_route_caps in ip_route_me_harder diff -X linux-2.6.22.6/Documentation/dontdiff -pru linux-2.6.22.6/net/ipv4/netfilter.c linux-2.6.22.6-lepton/net/ipv4/netfilter.c ---

Re: [PATCH 2.6.23-rc6] NETWORKING : Edge Triggered EPOLLOUT events get missed for TCP sockets

2007-09-19 Thread David Miller
From: Nagendra Tomar [EMAIL PROTECTED] Date: Wed, 19 Sep 2007 04:13:24 -0700 (PDT) With the SOCK_NOSPACE check in tcp_check_space(), this epoll_wait call will not return, even when the incoming acks free the buffers. Note that this patch assumes that the SOCK_NOSPACE check in

Re: [Bug, PATCH and another Bug] Was: Fix refcounting problem with netif_rx_reschedule()

2007-09-19 Thread David Miller
From: Krishna Kumar [EMAIL PROTECTED] Date: Wed, 19 Sep 2007 17:24:03 +0530 Note: during steps F-H and C-E, priv/napi is read/modified by both cpu's which is another bug relating to the same race. I guess the above patch is not required if this bug (in IPoIB) is fixed? The

Re: [RFC][NET_SCHED] explict hold dev tx lock

2007-09-19 Thread David Miller
From: jamal [EMAIL PROTECTED] Date: Wed, 19 Sep 2007 09:33:52 -0400 On Mon, 2007-17-09 at 22:48 -0400, jamal wrote: Nothing much has changed from what it was before. The only difference is we let go of the queue lock before grabbing the tx lock which never mattered for LLTX. Once we

Re: bnx2 dirver's firmware images

2007-09-19 Thread David Miller
From: Bill Davidsen [EMAIL PROTECTED] Date: Wed, 19 Sep 2007 09:40:14 -0400 Is that a suggestion that the driver work differently when built as a module or built in? Absolutely. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED]

Re: follow-up: discrepancy with POSIX

2007-09-19 Thread David Miller
From: Ulrich Drepper [EMAIL PROTECTED] Date: Wed, 19 Sep 2007 08:21:47 -0700 If you think the POSIX spec is wrong (and can point to other implementations doing the same as Linux) let me know and I'll work on getting the spec changed. The whole AF_UNSPEC thing I'm almost certain comes from

Re: follow-up: discrepancy with POSIX

2007-09-19 Thread Alan Cox
On Wed, 19 Sep 2007 09:15:10 -0700 (PDT) David Miller [EMAIL PROTECTED] wrote: From: Ulrich Drepper [EMAIL PROTECTED] Date: Wed, 19 Sep 2007 08:21:47 -0700 If you think the POSIX spec is wrong (and can point to other implementations doing the same as Linux) let me know and I'll work on

Re: bnx2 dirver's firmware images

2007-09-19 Thread maximilian attems
On Tue, 18 Sep 2007, Michael Chan wrote: The bnx2 firmware changes quite frequently. A new driver quite often requires new firmware to work correctly. Splitting them up makes things difficult for the user. sorry didn't check, what's the license of the firmware? The firmware in tg3 is a

Re: bnx2 dirver's firmware images

2007-09-19 Thread David Miller
From: maximilian attems [EMAIL PROTECTED] Date: Wed, 19 Sep 2007 18:33:18 +0200 we have to strip the firmware for Debian for the upcoming Lenny release. Why do you have to? The vendor has given you explicit rights to distribute it: * Firmware is: * Derived from proprietary unpublished

Re: [ofa-general] Re: [PATCH 02/11] IB/ipoib: Notify the world before doing unregister

2007-09-19 Thread Moni Shoua
Roland, Jay, Thanks a lot for the comments. I'd like to summarize the points raised so far 1. Reduce the indentation in patch #4 (Roland) I will resend 2. Remove the if (n-dev-flags IFF_MASTER) from patch #3 (Roland) I will resend 3. Consider making ipoib_slave_detach()

Re: [ofa-general] Re: [PATCH 02/11] IB/ipoib: Notify the world before doing unregister

2007-09-19 Thread Roland Dreier
I think that if there are no other comments, I will submit the entire 11 patches again (with changes) to make it easier to merge into the kernel. Since the most of the content in the patch series is in bonding I thought it would be right that Jay will push all the patches to

Re: [PATCH net-2.6.24] eHEA: poll function update for new NAPI scheme

2007-09-19 Thread David Miller
From: Jan-Bernd Themann [EMAIL PROTECTED] Date: Wed, 19 Sep 2007 17:40:30 +0200 Update of ehea_poll function to work with new NAPI scheme. Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED] Applied, thanks. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a

Re: [NET-2.6.24][VETH][patch 1/1] fix bad netif_carrier_off place

2007-09-19 Thread David Miller
From: [EMAIL PROTECTED] Date: Wed, 19 Sep 2007 15:38:22 +0200 From: Daniel Lezcano [EMAIL PROTECTED] If the netif_carrier_off is called before register_netdev that will use and generate an event for a non initialized network device and that leads to a Oops. I moved the netif_carrier_off

Re: follow-up: discrepancy with POSIX

2007-09-19 Thread Ulrich Drepper
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Andi Kleen wrote: The standard way to undo connect is to use AF_UNSPEC. Code to handle that for dgram sockets is there. It's the same code for v4 and v6. I quoted the standard and it does not say anything about AF_UNSPEC. So you cannot simply make

Re: bnx2 dirver's firmware images

2007-09-19 Thread maximilian attems
hello dave, i appreciate a lot your opinon, but please cool down. this is not a four spin on your beloved pipe. :) On Wed, Sep 19, 2007 at 09:38:32AM -0700, David Miller wrote: From: maximilian attems [EMAIL PROTECTED] Date: Wed, 19 Sep 2007 18:33:18 +0200 we have to strip the firmware for

Re: [ofa-general] [PATCH] RDMA/CMA: Implement rdma_resolve_ip retry enhancement.

2007-09-19 Thread Sean Hefty
If an application is calling rdma_resolve_ip() and a status of -ENODATA is returned from addr_resolve_local/remote(), the timeout mechanism waits until the application's timeout occurs before rechecking the address resolution status; the application will wait until it's full timeout occurs.

Re: follow-up: discrepancy with POSIX

2007-09-19 Thread David Miller
From: Ulrich Drepper [EMAIL PROTECTED] Date: Wed, 19 Sep 2007 09:49:09 -0700 But the spec calls for a null address to be used and that's in my understanding something different from using AF_UNSPEC. It just occured to me that AF_UNSPEC might be used simply because all zeros might be a valid

new NAPI quota synchronization issue

2007-09-19 Thread David Miller
Ok, as has been hinted at with some postings from Krishna and others, we still have some mutual exclusion issues in the new NAPI code. In short, the napi-quota updates happen outside of the sections where the code stream owns the napi_struct instance, so it can be modified in parallel on

Re: bnx2 dirver's firmware images

2007-09-19 Thread maximilian attems
On Tue, 18 Sep 2007, Sam Ravnborg wrote: Anyway - if we again consider klibc I will do my best to make the build stuff as smooth as possible. Sam nitpicking mode on currently klibc has tendency to rebuild a bit too much if you touch some part of it, seen in usr/utils for the main

Re: bnx2 dirver's firmware images

2007-09-19 Thread H. Peter Anvin
maximilian attems wrote: On Tue, 18 Sep 2007, Sam Ravnborg wrote: Anyway - if we again consider klibc I will do my best to make the build stuff as smooth as possible. Sam nitpicking mode on currently klibc has tendency to rebuild a bit too much if you touch some part of it, seen

Re: bnx2 dirver's firmware images

2007-09-19 Thread maximilian attems
On Wed, Sep 19, 2007 at 10:12:38AM -0700, H. Peter Anvin wrote: Could you give a concrete example? -hpa [EMAIL PROTECTED]:~/src/klibc$ touch usr/utils/mount_main.c [EMAIL PROTECTED]:~/src/klibc$ make KLIBCCC usr/utils/mount_main.o KLIBCLD usr/utils/static/halt LN

Re: follow-up: discrepancy with POSIX

2007-09-19 Thread Andi Kleen
On Wed, Sep 19, 2007 at 09:49:09AM -0700, Ulrich Drepper wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Andi Kleen wrote: The standard way to undo connect is to use AF_UNSPEC. Code to handle that for dgram sockets is there. It's the same code for v4 and v6. I quoted the standard

Re: follow-up: discrepancy with POSIX

2007-09-19 Thread Ulrich Drepper
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Ulrich Drepper wrote: Yes, but for IPv4/6 it's not an issue. Some implementations might handle all-zeros and the spec _currently_ calls for it. In this case an alignment would be good. Searching the web shows up this:

Re: new NAPI quota synchronization issue

2007-09-19 Thread David Miller
From: David Miller [EMAIL PROTECTED] Date: Wed, 19 Sep 2007 09:58:25 -0700 (PDT) Probably a good way to deal with this is to simply make the quota handling stateless. The only reason we handle partial quota usage is to handle the global netdev_budget. But we can simply round up and let

Re: bnx2 dirver's firmware images

2007-09-19 Thread Sam Ravnborg
Hi Maks. On Wed, Sep 19, 2007 at 07:18:41PM +0200, maximilian attems wrote: On Wed, Sep 19, 2007 at 10:12:38AM -0700, H. Peter Anvin wrote: Could you give a concrete example? -hpa [EMAIL PROTECTED]:~/src/klibc$ touch usr/utils/mount_main.c [EMAIL PROTECTED]:~/src/klibc$ make

Re: follow-up: discrepancy with POSIX

2007-09-19 Thread Andi Kleen
On Wed, Sep 19, 2007 at 10:46:54AM -0700, Ulrich Drepper wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Andi Kleen wrote: But the spec calls for a null address to be used and that's in my understanding something different from using AF_UNSPEC. memset(sockaddr, 0,

Re: [PATCH 3/3] [PPP] L2TP: Fix skb handling in pppol2tp_xmit

2007-09-19 Thread David Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Wed, 19 Sep 2007 09:25:29 +0800 [PPP] L2TP: Fix skb handling in pppol2tp_xmit This patch makes pppol2tp_xmit call skb_cow_head so that we don't modify cloned skb data. It also gets rid of skb2 we only need to preserve the original skb for congestion

Re: [PATCH] tehuti: driver for Tehuti 10GbE network adapters

2007-09-19 Thread 'Christoph Hellwig'
On Wed, Sep 19, 2007 at 07:37:18PM +0200, Alexander Indenbaum wrote: In my understanding unregister_netdev(), in case netdev is still IFF_UP and holds irq, will call dev_close() which will call netdev-stop(), bdx_close() in our case. bdx_close() releases all netdev resources among others calls

Re: SFQ qdisc crashes with limit of 2 packets

2007-09-19 Thread David Miller
From: Patrick McHardy [EMAIL PROTECTED] Date: Wed, 19 Sep 2007 15:08:22 +0200 Alexey Kuznetsov wrote: Hello! CCed Alexey just to be safe, but I think the patch should be fine. Yes. But what'a about limit == 1? tc prohibits this case, but it is still not nice to have the bug in

Re: [PATCH 3/3] [PPP] L2TP: Fix skb handling in pppol2tp_xmit

2007-09-19 Thread David Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Wed, 19 Sep 2007 09:30:18 +0800 [PPP] pppoe: Fix double-free on skb after transmit failure When I got rid of the second packet in __pppoe_xmit I created a double-free on the skb because of the goto abort on failure. This patch removes that.

Re: follow-up: discrepancy with POSIX

2007-09-19 Thread Ulrich Drepper
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Andi Kleen wrote: But the spec calls for a null address to be used and that's in my understanding something different from using AF_UNSPEC. memset(sockaddr, 0, sizeof(sockaddr)) should give you AF_UNSPEC But the spec calls for quotenull address

Re: follow-up: discrepancy with POSIX

2007-09-19 Thread Ulrich Drepper
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Andi Kleen wrote: Spec doesn't match traditional behaviour then. Well, determining whether that's the case is part of this exercise. IPv4 0.0.0.0 is traditionally an synonym for old style all broadcast (255.255.255.255) on UDP/RAW and it's

RE: [PATCH] tehuti: driver for Tehuti 10GbE network adapters

2007-09-19 Thread Alexander Indenbaum
-Original Message- From: 'Christoph Hellwig' [mailto:[EMAIL PROTECTED] Sent: Wednesday, September 19, 2007 5:53 PM Putting dual-port issue aside, could you elaborate what is the problem in your opinion in bdx_remove() implementation? What is wrong with calling free_netdev()

Re: [PATCH net-2.6.24] introduce MAC_FMT/MAC_ARG

2007-09-19 Thread David Miller
From: Joe Perches [EMAIL PROTECTED] Date: Tue, 18 Sep 2007 21:50:01 -0700 I rebased against yesterday's net-2.6.24 Please pull from: git://repo.or.cz/linux-2.6/trivial-mods.git net-2.6.24-fordave You didn't rebase you merged and this makes your tree a complete mess. When you do a real

Re: [RESEND][PATCH 3/4 Rev-3] Initilize and populate age field

2007-09-19 Thread David Miller
From: Varun Chandramohan [EMAIL PROTECTED] Date: Wed, 19 Sep 2007 09:24:34 +0530 The age field is filled with the current time at the time of creation of the route. When the routes are dumped then the age value stored in the route structure is subtracted from the current time value and the

Re: Please pull 'rt2x00' branch of wireless-2.6

2007-09-19 Thread David Miller
From: Ivo van Doorn [EMAIL PROTECTED] Date: Wed, 19 Sep 2007 20:31:19 +0200 Because I am indeed not really happy with this early merge, but I'll do my best to resolve the last outstanding bugs as soon as possible. Relax :-) A merge upstream doesn't mean bug free, it means significantly better

Re: Please pull 'rt2x00' branch of wireless-2.6

2007-09-19 Thread Ivo van Doorn
Hi, This patch adds the rt2x00 drivers for Ralink wireless hardware. This collection of drivers has seen lots of action in Fedora (both F7 and rawhide) and many people are using them with good results (although some problems do remain). Ivo in particular has been very helpful in responding

Re: follow-up: discrepancy with POSIX

2007-09-19 Thread Alan Cox
On Wed, 19 Sep 2007 10:46:54 -0700 Ulrich Drepper [EMAIL PROTECTED] wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Andi Kleen wrote: But the spec calls for a null address to be used and that's in my understanding something different from using AF_UNSPEC. memset(sockaddr, 0,

Re: follow-up: discrepancy with POSIX

2007-09-19 Thread Andi Kleen
On Wed, Sep 19, 2007 at 11:02:00AM -0700, Ulrich Drepper wrote: on UDP/RAW and it's certainly possible to connect() to that. Where do you get this from? And where is this implemented? I don't Sorry it's actually loopback, not broadcast as implemented in Linux. In Linux it's implemented in

Re: Please pull 'rt2x00' branch of wireless-2.6

2007-09-19 Thread Ivo van Doorn
On Wednesday 19 September 2007, David Miller wrote: From: Ivo van Doorn [EMAIL PROTECTED] Date: Wed, 19 Sep 2007 20:31:19 +0200 Because I am indeed not really happy with this early merge, but I'll do my best to resolve the last outstanding bugs as soon as possible. Relax :-) :) A

  1   2   3   >