net-2.6.24 rebased...

2007-09-26 Thread David Miller
Ok the rebase is complete and I integrated all of the easy stuff in my backlog. In the usual spot: kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6.git John, one patch didn't go in cleanly after I removed the Z1211 driver. I put it here for your consideration so it doesn't get lost:

[patch 33/43] lguest: Net driver using virtio

2007-09-26 Thread rusty
The network driver uses two virtqueues: one for input packets and one for output packets. This has nice locking properties (ie. we don't do any for recv vs send). TODO: 1) Big packets. 2) Multi-client devices (maybe separate driver?). 3) Resolve freeing of old xmit skbs

Re: net-2.6.24 rebased...

2007-09-26 Thread Johannes Berg
On Tue, 2007-09-25 at 23:33 -0700, David Miller wrote: http://vger.kernel.org/~davem/0433-Z1211-Fix-TX-status-reports.patch What probably needs to happen is some other changes that were in z1211 need to go into the non-mac80211 driver and then this patch applies correctly. I tried

Re: Userspace network stack and netchannels.

2007-09-26 Thread Evgeniy Polyakov
On Tue, Sep 25, 2007 at 12:34:44PM -0700, Stephen Hemminger ([EMAIL PROTECTED]) wrote: It was proven [3] that unetstack can be *much* faster than vanilla TCP stack (mainly because of heavily reduced number of syscalls, different congestion control algorithm and other features). I am glad

Re: Userspace network stack and netchannels.

2007-09-26 Thread Evgeniy Polyakov
Hi Robert. On Tue, Sep 25, 2007 at 09:20:44PM +0200, Robert Iakobashvili ([EMAIL PROTECTED]) wrote: 3. Gigabit send/recv benchmark for netchannels and sockets using small packets. http://tservice.net.ru/~s0mbre/blog/devel/networking/2006_10_26.html

Re: [PATCH v3 2/2][BNX2]: Add iSCSI support to BNX2 devices.

2007-09-26 Thread FUJITA Tomonori
On Tue, 25 Sep 2007 10:39:17 +0200 Hannes Reinecke [EMAIL PROTECTED] wrote: Hi Tomo, FUJITA Tomonori wrote: On Sat, 8 Sep 2007 13:00:36 +0100 Christoph Hellwig [EMAIL PROTECTED] wrote: On Sat, Sep 08, 2007 at 07:32:27AM -0400, Jeff Garzik wrote: FUJITA Tomonori wrote: Yeah, iommu

Re: PROBLEM: 2.6.23-rc NETDEV WATCHDOG: eth0: transmit timed out

2007-09-26 Thread Karl Meyer
Hi Francois, this is what I found and sent: The error exists from patch 2 on. I did some network testing with patch 1 and currently use it and have no errors so far. From my experiences up to now patch 1 should be error free. Do you need additional info? 2007/9/12, Francois Romieu [EMAIL

Re: [PATCH] ipg: add IP1000A driver to kernel tree

2007-09-26 Thread linux
(Resend to netdev; already sent to relevant individuals.) Here's a possible fix for the p[] array issues akpm noticed. This replaces them with calls to a new mdio_write_bits function. Boot-tested, passes net traffic, and mii-tool and mii-diag produce sensible output (including noticing link

Re: Userspace network stack and netchannels.

2007-09-26 Thread Robert Iakobashvili
On 9/26/07, Evgeniy Polyakov [EMAIL PROTECTED] wrote: http://tservice.net.ru/~s0mbre/blog/devel/networking/2006_10_26.html http://tservice.net.ru/~s0mbre/blog/devel/networking/2006_12_21.html Very interesting. Are there any details of your benchmarking available, namely, how it was

Re: [SCTP PULL Request]: Bug fixes for 2.6.23

2007-09-26 Thread Vlad Yasevich
David Miller wrote: From: Vlad Yasevich [EMAIL PROTECTED] Date: Mon, 24 Sep 2007 16:59:25 -0400 Can you please pull the following changes since commit a41d3015c11a4e864b95cb57f579f2d8f40cd41b: I had to apply this by hand because: David S. Miller (1): Revert PCI: disable MSI

Re: net-2.6.24 rebased...

2007-09-26 Thread John W. Linville
On Tue, Sep 25, 2007 at 11:33:44PM -0700, David Miller wrote: John, one patch didn't go in cleanly after I removed the Z1211 driver. I put it here for your consideration so it doesn't get lost: http://vger.kernel.org/~davem/0433-Z1211-Fix-TX-status-reports.patch What probably

Re: Userspace network stack and netchannels.

2007-09-26 Thread jamal
Evgeniy, Those numbers look impressive. How mysterious do things get in SMP? Sorry havent had time to stare at the code. How do you measure cpu you quoted? cheers, jamal - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More

Re: [RFC][NET_SCHED] explict hold dev tx lock

2007-09-26 Thread jamal
On Tue, 2007-25-09 at 19:28 -0700, David Miller wrote: I've applied this to net-2.6.24, although I want to study more deeply the implications of this change myself at some point :) sounds reasonable. Ive done a lot of testing with my 2-3 NIC variants; ive cced whoever i thought was a

Re: [PATCH: 2.6.13-15-SMP 3/3] network: concurrentlyrunsoftirqnetwork code on SMP

2007-09-26 Thread jamal
On Wed, 2007-26-09 at 10:12 +0800, John Ye wrote: cpu hash (srcip + dstip) % nr_cpus, plus checking cpu balance periodically, shift cpu by an extra seed value? That may work maybe even add ipproto as a 3rd tuple; experiments will tell - you need to be able to generate a random enough traffic

Re: Userspace network stack and netchannels.

2007-09-26 Thread Evgeniy Polyakov
Hi Jamal. On Wed, Sep 26, 2007 at 09:08:45AM -0400, jamal ([EMAIL PROTECTED]) wrote: Those numbers look impressive. How mysterious do things get in SMP? Sorry havent had time to stare at the code. How do you measure cpu you quoted? I did not checked how netchannels and userspace stack behaves

[PATCH] [TCP] MIB: Fine-tune reordered ACK's SACK block counting more

2007-09-26 Thread Ilpo Järvinen
On Tue, 25 Sep 2007, David Miller wrote: From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Mon, 24 Sep 2007 12:04:07 +0300 In case of ACK reordering, the SACK block might be valid in it's time but is already obsoleted since we've received another kind of confirmation about arrival of the

e100 problems in .23rc8 ?

2007-09-26 Thread Dave Jones
Last night, I hit this bug during boot up.. http://www.codemonkey.org.uk/junk/e100-2.jpg This morning, I got a mail from a Fedora user of the same .23-rc8 based kernel that has seen a different trace also implicating e100.. http://www.codemonkey.org.uk/junk/e100.jpg It may be that the two

Re: [RFC] Zero-length write() does not generate a datagram on connected socket

2007-09-26 Thread Rick Jones
Herbert Xu wrote: Stephen Hemminger [EMAIL PROTECTED] wrote: The bug http://bugzilla.kernel.org/show_bug.cgi?id=5731 describes an issue where write() can't be used to generate a zero-length datagram (but send, and sendto do work). I think the following is needed: --- a/net/socket.c

Re: e100 problems in .23rc8 ?

2007-09-26 Thread Kok, Auke
Dave Jones wrote: Last night, I hit this bug during boot up.. http://www.codemonkey.org.uk/junk/e100-2.jpg This morning, I got a mail from a Fedora user of the same .23-rc8 based kernel that has seen a different trace also implicating e100.. http://www.codemonkey.org.uk/junk/e100.jpg

Re: e100 problems in .23rc8 ?

2007-09-26 Thread Dave Jones
On Wed, Sep 26, 2007 at 11:10:11AM -0700, Kok, Auke wrote: Dave Jones wrote: Last night, I hit this bug during boot up.. http://www.codemonkey.org.uk/junk/e100-2.jpg This morning, I got a mail from a Fedora user of the same .23-rc8 based kernel that has seen a different trace

Re: [RFC] Zero-length write() does not generate a datagram on connected socket

2007-09-26 Thread Vlad Yasevich
Herbert Xu wrote: Stephen Hemminger [EMAIL PROTECTED] wrote: The bug http://bugzilla.kernel.org/show_bug.cgi?id=5731 describes an issue where write() can't be used to generate a zero-length datagram (but send, and sendto do work). I think the following is needed: --- a/net/socket.c

Re: [ofa-general] [PATCH v3] iw_cxgb3: Support iwarp-only interfaces to avoid 4-tuple conflicts.

2007-09-26 Thread Steve Wise
Rolan/Sean, What do you all think? Steve. Steve Wise wrote: iw_cxgb3: Support iwarp-only interfaces to avoid 4-tuple conflicts. Version 3: - don't use list_del_init() where list_del() is sufficient. Version 2: - added a per-device mutex for the address and listening endpoints lists. -

Re: net-2.6.24 rebased...

2007-09-26 Thread David Miller
From: John W. Linville [EMAIL PROTECTED] Date: Wed, 26 Sep 2007 08:46:49 -0400 On Tue, Sep 25, 2007 at 11:33:44PM -0700, David Miller wrote: John, one patch didn't go in cleanly after I removed the Z1211 driver. I put it here for your consideration so it doesn't get lost:

[PATCH] [0/6] Bugfixes for pasemi_mac

2007-09-26 Thread Olof Johansson
Hi, Following patches are for various bug fixes against current netdev-2.6.24 upstream branch. Please apply. [PATCH] [1/6] pasemi_mac: fix build break in pasemi_mac_probe() [PATCH] [2/6] pasemi_mac: fix build break in pasemi_mac_clean_rx() [PATCH] [3/6] pasemi_mac: set interface speed correctly

[PATCH] [1/6] pasemi_mac: fix build break in pasemi_mac_probe()

2007-09-26 Thread Olof Johansson
pasemi_mac: fix build break in pasemi_mac_probe() Fix breakage caused by recent unification of print_mac() stuff. Signed-off-by: Olof Johansson [EMAIL PROTECTED] Index: k.org/drivers/net/pasemi_mac.c === ---

[PATCH] [2/6] pasemi_mac: fix build break in pasemi_mac_clean_rx()

2007-09-26 Thread Olof Johansson
pasemi_mac: fix build break in pasemi_mac_clean_rx() Fix breakage caused by the unification of stats structs. Signed-off-by: Olof Johansson [EMAIL PROTECTED] Index: k.org/drivers/net/pasemi_mac.c === ---

[PATCH] [3/6] pasemi_mac: set interface speed correctly on XAUI ports

2007-09-26 Thread Olof Johansson
pasemi_mac: set interface speed correctly on XAUI ports Set interface speed for XAUI to 10G per default, not 1G. Signed-off-by: Olof Johansson [EMAIL PROTECTED] Index: 2.6.23/drivers/net/pasemi_mac.c === ---

[PATCH] [5/6] pasemi_mac: flags as passed to spin_*_irqsave() should be unsigned long

2007-09-26 Thread Olof Johansson
pasemi_mac: flags as passed to spin_*_irqsave() should be unsigned long. Signed-off-by: Tony Breeds [EMAIL PROTECTED] Signed-off-by: Olof Johansson [EMAIL PROTECTED] --- Found trying to build a -rt kernel, which has a BUILD_BUG_ON(), in this caswe. drivers/net/pasemi_mac.c |4 ++-- 1 file

[PATCH] [5/6] pasemi_mac: don't enable rx before there are buffers on the ring

2007-09-26 Thread Olof Johansson
pasemi_mac: don't enable rx before there are buffers on the ring Reorder initialization of the DMA channels and the interface. Before there was a time window when the interface was enabled before DMA was enabled. Also, now there will always be RX buffers available at the time the MAC interface is

Re: [PATCH] [1/6] pasemi_mac: fix build break in pasemi_mac_probe()

2007-09-26 Thread David Miller
From: Olof Johansson [EMAIL PROTECTED] Date: Wed, 26 Sep 2007 16:22:43 -0500 pasemi_mac: fix build break in pasemi_mac_probe() Fix breakage caused by recent unification of print_mac() stuff. Signed-off-by: Olof Johansson [EMAIL PROTECTED] This one is in net-2.6.24 already, thanks! - To

[PATCH] [6/6] pasemi_mac: pass in count of buffers to replenish rx ring with

2007-09-26 Thread Olof Johansson
pasemi_mac: pass in count of buffers to replenish rx ring with Refactor replenish_rx_ring to take an argument for how many entries to fill. Since it's normally available from where it's called anyway, this is just simpler. It also removes the awkward logic to try to figure out if we're filling

Re: [PATCH] [2/6] pasemi_mac: fix build break in pasemi_mac_clean_rx()

2007-09-26 Thread David Miller
From: Olof Johansson [EMAIL PROTECTED] Date: Wed, 26 Sep 2007 16:23:06 -0500 pasemi_mac: fix build break in pasemi_mac_clean_rx() Fix breakage caused by the unification of stats structs. Signed-off-by: Olof Johansson [EMAIL PROTECTED] Jeff, I added this to my net-2.6.24 tree because it

Re: [PATCH] [0/6] Bugfixes for pasemi_mac

2007-09-26 Thread David Miller
From: Olof Johansson [EMAIL PROTECTED] Date: Wed, 26 Sep 2007 16:22:00 -0500 [PATCH] [1/6] pasemi_mac: fix build break in pasemi_mac_probe() [PATCH] [2/6] pasemi_mac: fix build break in pasemi_mac_clean_rx() [PATCH] [3/6] pasemi_mac: set interface speed correctly on XAUI ports [PATCH] [4/6]

Re: [net-2.6.24][patch 2/2] Dynamically allocate the loopback device

2007-09-26 Thread Eric W. Biederman
David Miller [EMAIL PROTECTED] writes: I've put these patches into the just-rebased net-2.6.24 tree. I made a minor modification to the second patch, the out_free_netdev: code in loopback_init() ended like this: out_free_netdev: free_netdev(dev); goto out; return err;

[PATCH] net: Fix running without sysfs

2007-09-26 Thread Eric W. Biederman
When sysfs support is compiled out the kernel still keeps and maintains the kobject tree. So it is not safe to skip our kobject reference counting or to avoid becoming members of the kobject tree. It is safe to not add the networking specific sysfs attributes. This patch removes the sysfs

[PATCH] net: Add network namespace clone unshare support.

2007-09-26 Thread Eric W. Biederman
This patch allows you to create a new network namespace using sys_clone, or sys_unshare. As the network namespace is still experimental and under development clone and unshare support is only made available when CONFIG_NET_NS is selected at compile time. As this patch introduces network

[PATCH 1/4] net: Dynamically allocate the per cpu counters for the loopback device.

2007-09-26 Thread Eric W. Biederman
This patch add support for dynamically allocating the statistics counters for the loopback device and adds appropriate device methods for allocating and freeing the loopback device. This completes support for creating multiple instances of the loopback device, in preparation for creating per

[PATCH 2/4] net ipv4: Remove unnecessary test for the loopback device from inetdev_destroy

2007-09-26 Thread Eric W. Biederman
Currently we never call unregister_netdev for the loopback device so it is impossible for us to reach inetdev_destroy with the loopback device. So the test in inetdev_destroy is unnecessary. Further when testing with my network namespace patches removing unregistering the loopback device and

[PATCH 3/4] net ipv4: When possible test for IFF_LOOPBACK and not dev == loopback_dev

2007-09-26 Thread Eric W. Biederman
Now that multiple loopback devices are becoming possible it makes the code a little cleaner and more maintainable to test if a deivice is th a loopback device by testing dev-flags IFF_LOOPBACK instead of dev == loopback_dev. Signed-off-by: Eric W. Biederman [EMAIL PROTECTED] ---

[PATCH 4/4] net: Make the loopback device per network namespace

2007-09-26 Thread Eric W. Biederman
This patch makes loopback_dev per network namespace. Adding code to create a different loopback device for each network namespace and adding the code to free a loopback device when a network namespace exits. This patch modifies all users the loopback_dev so they access it as

Re: [PATCH] net: Fix running without sysfs

2007-09-26 Thread Stephen Hemminger
On Wed, 26 Sep 2007 17:48:10 -0600 [EMAIL PROTECTED] (Eric W. Biederman) wrote: When sysfs support is compiled out the kernel still keeps and maintains the kobject tree. So it is not safe to skip our kobject reference counting or to avoid becoming members of the kobject tree. It is safe

[PATCH 1/3] net-2.6.24: wrap netdevice hardware header creation

2007-09-26 Thread Stephen Hemminger
Add inline for common usage of hardware header creation, and fix bug in IPV6 mcast where the assumption about negative return is an errno. Negative return from hard_header means not enough space was available,(ie -N bytes). Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] ---

[PATCH 2/3] net-2.6.24: wrap hard_header_parse

2007-09-26 Thread Stephen Hemminger
Wrap the hard_header_parse function to simplify next step of header_ops conversion. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- a/include/linux/netdevice.h 2007-09-26 16:26:03.0 -0700 +++ b/include/linux/netdevice.h 2007-09-26 16:26:04.0 -0700 @@ -657,7 +657,7 @@

net-2.6.24 won't power off

2007-09-26 Thread Stephen Hemminger
Shutdown no longer powers off, something changed. 2.6.23-rc8 works fine, but net-2.6.24 gets to shutting off the disks and never finishes. Any ideas before I go on a bisect hunt? -- Stephen Hemminger [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe netdev in the

[PATCH] netns: Simplify the network namespace list locking rules.

2007-09-26 Thread Eric W. Biederman
Denis V. Lunev [EMAIL PROTECTED] noticed that the locking rules for the network namespace list are over complicated and broken. In particular the current register_netdev_notifier currently does not take any lock making the for_each_net iteration racy with network namespace creation and

TCP Spike

2007-09-26 Thread Majumder, Rajib
Hi, We have observed 40ms latency spikes in TCP connections in burst type of traffic. This affects regular TCP sockets. We observed this issue in kernels of 2.4.21 and kernel 2.6.5. Aparently, this seems to be fixed in 2.6.19. Can someone throw some light on this? Is this a congestion

Re: [PATCH] [TCP] MIB: Fine-tune reordered ACK's SACK block counting more

2007-09-26 Thread David Miller
From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Wed, 26 Sep 2007 17:07:04 +0300 (EEST) Hmm, thought a bit more about it... How about this then? No additional counter. Compile tested. Not that I see a large benefit from it, in theory could help logging in some malicious attempt cases; we safely

Re: [PATCH] net: Fix running without sysfs

2007-09-26 Thread David Miller
From: [EMAIL PROTECTED] (Eric W. Biederman) Date: Wed, 26 Sep 2007 17:48:10 -0600 When sysfs support is compiled out the kernel still keeps and maintains the kobject tree. So it is not safe to skip our kobject reference counting or to avoid becoming members of the kobject tree. It is

Re: [PATCH] net: Add network namespace clone unshare support.

2007-09-26 Thread David Miller
From: [EMAIL PROTECTED] (Eric W. Biederman) Date: Wed, 26 Sep 2007 17:49:54 -0600 This patch allows you to create a new network namespace using sys_clone, or sys_unshare. As the network namespace is still experimental and under development clone and unshare support is only made available

Re: [PATCH 1/4] net: Dynamically allocate the per cpu counters for the loopback device.

2007-09-26 Thread David Miller
From: [EMAIL PROTECTED] (Eric W. Biederman) Date: Wed, 26 Sep 2007 17:53:40 -0600 This patch add support for dynamically allocating the statistics counters for the loopback device and adds appropriate device methods for allocating and freeing the loopback device. This completes support

Re: [PATCH 2/4] net ipv4: Remove unnecessary test for the loopback device from inetdev_destroy

2007-09-26 Thread David Miller
From: [EMAIL PROTECTED] (Eric W. Biederman) Date: Wed, 26 Sep 2007 17:55:29 -0600 Currently we never call unregister_netdev for the loopback device so it is impossible for us to reach inetdev_destroy with the loopback device. So the test in inetdev_destroy is unnecessary. Further when

Re: [PATCH 3/4] net ipv4: When possible test for IFF_LOOPBACK and not dev == loopback_dev

2007-09-26 Thread David Miller
From: [EMAIL PROTECTED] (Eric W. Biederman) Date: Wed, 26 Sep 2007 17:58:21 -0600 Now that multiple loopback devices are becoming possible it makes the code a little cleaner and more maintainable to test if a deivice is th a loopback device by testing dev-flags IFF_LOOPBACK instead of dev

Re: [PATCH 4/4] net: Make the loopback device per network namespace

2007-09-26 Thread David Miller
From: [EMAIL PROTECTED] (Eric W. Biederman) Date: Wed, 26 Sep 2007 18:00:20 -0600 This patch makes loopback_dev per network namespace. Adding code to create a different loopback device for each network namespace and adding the code to free a loopback device when a network namespace exits.

Re: [PATCH 1/3] net-2.6.24: wrap netdevice hardware header creation

2007-09-26 Thread David Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Wed, 26 Sep 2007 17:21:29 -0700 Add inline for common usage of hardware header creation, and fix bug in IPV6 mcast where the assumption about negative return is an errno. Negative return from hard_header means not enough space was

Re: [PATCH 2/3] net-2.6.24: wrap hard_header_parse

2007-09-26 Thread David Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Wed, 26 Sep 2007 17:21:37 -0700 Wrap the hard_header_parse function to simplify next step of header_ops conversion. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] Applied. - To unsubscribe from this list: send the line unsubscribe netdev

Re: [PATCH 3/3] net-2.6.24: move hardware header operations out of netdevice

2007-09-26 Thread David Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Wed, 26 Sep 2007 17:22:46 -0700 Since hardware header operations are part of the protocol class not the device instance, make them into a separate object and save memory. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] I applied this by

Re: [PATCH] netns: Simplify the network namespace list locking rules.

2007-09-26 Thread Denis V. Lunev
Eric W. Biederman wrote: Denis V. Lunev [EMAIL PROTECTED] noticed that the locking rules for the network namespace list are over complicated and broken. In particular the current register_netdev_notifier currently does not take any lock making the for_each_net iteration racy with network

Re: [PATCH] netns: Simplify the network namespace list locking rules.

2007-09-26 Thread David Miller
From: [EMAIL PROTECTED] (Eric W. Biederman) Date: Wed, 26 Sep 2007 21:54:47 -0600 Denis V. Lunev [EMAIL PROTECTED] noticed that the locking rules for the network namespace list are over complicated and broken. In particular the current register_netdev_notifier currently does not take any

Re: [patch 10/11] net: use numa_node in net_device-dev instead of parent

2007-09-26 Thread Jeff Garzik
(warning, adjusted CC's and added netdev mailing list) David Miller wrote: From: [EMAIL PROTECTED] Date: Wed, 26 Sep 2007 18:14:42 -0700 From: Yinghai Lu [EMAIL PROTECTED] Signed-off-by: Yinghai Lu [EMAIL PROTECTED] Cc: Christoph Lameter [EMAIL PROTECTED] Cc: Andy Whitcroft [EMAIL